[00:05:09] d3r1ck it's harder than you might think xD [00:05:22] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860127 (10D3r1ck01) [00:05:34] (03CR) 10jenkins-bot: [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [00:05:45] Albert221: Ohhh really? So you can just fix the trailings for now and submit the patch [00:06:02] Then we'll file a different ticket related to that extension not following Wikimedia CS [00:07:06] I'll try to finnish that [00:07:28] Okay! Let me know when done :) [00:07:31] my problem is with git though, I've done some bad and now I have 'funny' situation to get out from [00:07:44] Albert221: conflicts? [00:07:44] oh you know what [00:07:50] Albert221: What? [00:08:03] nonono, some rebase-git-apply-dev-null stuff [00:08:11] I don't know how to describe it tho xD [00:08:19] but I know the solution, gimme sec [00:09:00] Okay :) [00:12:56] (03PS1) 10Albert221: Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) [00:12:59] okay, finally cleaned up things [00:13:13] (03Abandoned) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400122 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [00:13:33] (03CR) 10jenkins-bot: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [00:13:56] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [00:14:23] Albert221: I have some notes for rebasing to solve merge conflicts, if you'd like. https://www.mediawiki.org/wiki/User:SamanthaNguyen/git#How_to_rebase [00:14:24] oh one sec [00:14:56] SamanthaNguyen thanks! my problem was a little bit more complicated than simple conflict thought :) [00:15:12] no worries :) [00:15:56] (03PS2) 10Albert221: Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) [00:16:03] I want to say that Jenkins is working on my patches Albert221 [00:16:22] divadsn, that's good, but why do you tell me that? :D [00:16:25] divadsn: It is not enabled for some extensions though [00:16:30] Zppix, could you help d3r1ck with code review at https://gerrit.wikimedia.org/r/#/c/400128/? :) [00:16:59] Phantom42, on which? [00:17:26] divadsn: Well, we are currently creating a list of those :) [00:18:41] legoktm, you there? there is some code review needed: https://gerrit.wikimedia.org/r/#/c/400128/2 [00:18:59] I've added Code Sniffer in this patch and run phpcbf that's why that big diff [00:19:10] Phantom42: Good, I am too tired from everything now, I have no meds taken [00:19:36] So I will only do some 2 patches and go sleep, tomorrow I will finally finish my post [00:20:13] (03CR) 10Divadsn: "Oh alright, no problem" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [00:21:33] d3r1ck: I wrote a simple script to make a list of extensions without CI. May I update your task description? [00:21:53] Phantom42: Wondeful :) [00:21:58] Thanks ;) [00:22:10] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860131 (10Phantom42) [00:22:45] d3r1ck: Done! Not sure if that list is complete, but hope that helps anyway :) [00:24:09] Phantom42: That helps a lot, I'll continue tomorrow on it to fill the ticket in case some are left [00:24:13] Thank you very much : [00:24:15] :) [00:24:34] d3r1ck: Great! :) [00:25:20] d3r1ck, have you seen https://gerrit.wikimedia.org/r/#/c/400128/? [00:25:28] Phantom42: BlueSpice* alone is giving Jenkins hard times :) [00:25:38] Albert221: Yes! [00:25:41] I'm on it now :) [00:28:40] (03CR) 10Phantom42: [C: 031] Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [00:29:13] (03PS2) 10Divadsn: Replace deprecated tag with custom styled
tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) [00:29:21] Albert221: Looks okay from a quick first glance :) [00:29:35] I'll have a close look at it tomorrow, need to sleep now :) [00:29:40] hm, okay! [00:29:47] should I mark it as submitted for a review? [00:29:51] d3r1ck: Good night and happy holidays! [00:29:57] Albert221: Yes [00:30:02] and should I write this phpcs s task now or when you'll merge eventually? [00:30:05] Phantom42: :D, I here all day lone [00:30:34] I think you can file a ticket for the CS issue [00:30:41] Phantom42: *long [00:31:06] Albert221: I think someone will review your patch and hopefully merge before I even get up tomorrow [00:31:40] that'd be nice [00:32:08] Albert221: Tomorrow is Christmas say :D [00:32:23] So let's just hope! [00:33:01] heh :D [00:33:14] *day [00:33:33] My eyes are already getting dark, that's why I'm having a lot of typos :( [00:33:48] Let me sleep before I have a brain freeze [00:33:50] hehe :D have a good night [00:33:58] Merry christmas from UTC+7 ! :D [00:34:16] * d3r1ck checks, good night everyone! Merry Merry refeed[m] :) [00:34:33] * d3r1ck checks out [00:34:40] good night! [01:09:21] (03PS1) 10Legoktm: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 [01:12:17] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3860158 (10Albert221) [01:12:30] can anyone look if this Phab task is good enough? [01:12:35] https://phabricator.wikimedia.org/T183676 [01:12:50] 10MediaWiki-General-or-Unknown, 10CSS: Replace layout-only span.mw-editButtons-pipe-separator in favor of CSS - https://phabricator.wikimedia.org/T183672#3859983 (10Nirmos) I suppose the same could be said for the pipes in `#contentSub` on Special:Contributions and Special:DeletedContributions. On the other h... [01:14:12] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3860158 (10Albert221) [01:16:50] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks: CLL shows wrong number for "X more languages" label - https://phabricator.wikimedia.org/T183649#3860172 (10Petar.petkovic) [01:20:51] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 10Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#3860175 (10Graham87) Also, for example, this link should show far more than 19... [01:22:52] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks: CLL shows wrong number for "X more languages" label - https://phabricator.wikimedia.org/T183649#3860183 (10Petar.petkovic) 05Open>03Invalid Since I have discovered this to be the problem with plural rules with message translations, I'm c... [01:31:53] 10MediaWiki-extensions-EducationProgram, 10Ladies-That-FOSS-MediaWiki, 10Easy, 10Google-Code-in-2017, 10JavaScript: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#3860189 (10divadsn) So after looking up the code I noticed tha... [01:35:07] (03PS1) 10Legoktm: Add tests for TextboxBuilder [core] - 10https://gerrit.wikimedia.org/r/400130 [01:37:44] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [01:38:23] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/400114 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [01:42:22] 04(no projects): Quantcast: switch to HTTPS - https://phabricator.wikimedia.org/T183677#3860195 (10MtMNC) [01:43:45] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10eflyjason) Is there any way we could use `phan` in MediaWiki-Vagrant... [01:45:03] (03CR) 10Rafidaslam: [C: 031] Add minus-x and phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [01:45:17] (03CR) 10Legoktm: [C: 04-1] "Please submit the MinusX change as a separate commit like you had previously, as that should be easy to merge without a more involved revi" (035 comments) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [01:47:05] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10Bawolff) >>! In T179554#3860205, @eflyjason wrote: > Is there any way... [01:48:53] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3860209 (10Legoktm) See https://lists.wikimedia.org/pipermail/wikitech-l/2017-De... [01:55:49] (03PS1) 10Ladsgroup: Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 [01:57:27] (03PS3) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (https://phabricator.wikimedia.org/T175794) [01:58:02] (03PS4) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:07:15] (03PS5) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:08:13] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [02:08:30] (03PS6) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:09:26] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [02:09:53] (03PS7) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:10:56] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [02:11:02] legoktm: is this change independent enough? https://gerrit.wikimedia.org/r/#/c/400128/ [02:14:04] (03PS8) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:15:02] (03CR) 10Legoktm: [C: 04-1] Add tests for several methods of Xml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [02:17:26] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860227 (10bd808) p:05Triage>03Normal [02:19:59] (03CR) 10Legoktm: "Shouldn't this have some kind of skip if firejail is not installed?" [core] - 10https://gerrit.wikimedia.org/r/399767 (owner: 10Gergő Tisza) [02:20:25] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add shell restriction to deny access to LocalSettings.php - https://phabricator.wikimedia.org/T182484#3860244 (10Legoktm) 05Open>03Resolved [02:20:30] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860245 (10bd808) ``` $ sudo /usr/bin/mysql -qfsAe "USE centralauth; SOURCE /vagrant/mediawiki/extensions/CentralAuth/central-auth.sql;" ERROR 1709 (HY000) a... [02:20:46] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:21:40] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:23:24] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:24:22] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:26:33] (03CR) 10Legoktm: [C: 04-1] Add minus-x to composer test and fix (031 comment) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:27:05] (03PS3) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:27:53] (03PS4) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) [02:28:11] 10MediaWiki-Shell: firejail < 0.9.50 doesn't support --seccomp=@default - https://phabricator.wikimedia.org/T183680#3860250 (10Legoktm) [02:29:59] legoktm, everything is fine now I think :) [02:33:35] (03PS1) 10Divadsn: Always define wgRestrictionEdit as an empty array for pages [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) [02:36:16] (03CR) 10Legoktm: [C: 032] Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:36:51] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860263 (10bd808) This cause of this seems to be that the default CHARSET is now utf8mb4: ``` (02:31) vagrant@localhost:[centralauth]> show create table glob... [02:37:43] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400133 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:37:54] thanks legoktm! [02:38:01] np [02:40:47] (03Abandoned) 10Divadsn: Always define wgRestrictionEdit as an empty array for pages [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [02:42:50] (03PS1) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [02:45:40] (03PS2) 10Ladsgroup: Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 [02:45:44] (03CR) 10Ladsgroup: Add tests for several methods of Xml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [02:46:40] (03CR) 10Legoktm: [C: 032] Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [02:48:15] (03PS9) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [02:48:24] (03PS2) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [02:50:19] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3860266 (10Albert221) [02:50:43] 10OCG-General: PDF export extension problem with
(03CR) 10jerkins-bot: [V: 04-1] Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [02:56:07] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/400136 (https://phabricator.wikimedia.org/T175749) [02:56:16] (03PS3) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [02:57:23] (03PS1) 10Ryan10145: Added a unit test to check that the main page exists [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400137 (https://phabricator.wikimedia.org/T183632) [02:57:55] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/400138 (https://phabricator.wikimedia.org/T175749) [02:58:37] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/400138 (https://phabricator.wikimedia.org/T175794) [02:59:10] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/400136 (https://phabricator.wikimedia.org/T175794) [03:00:29] good night everyone! [03:01:07] Albert221: Good night! [03:01:21] (03PS4) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [03:01:28] legoktm: For the phan task, should we solve the deprecation warnings as well ? [03:01:31] (03CR) 10Gergő Tisza: "I'll add one, although right now this test has to be executed manually so it doesn't make much difference." [core] - 10https://gerrit.wikimedia.org/r/399767 (owner: 10Gergő Tisza) [03:03:40] (03CR) 10jenkins-bot: Add tests for several methods of Xml [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [03:07:03] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [03:07:38] (03PS3) 10Gergő Tisza: Integration tests for FirejailCommand [core] - 10https://gerrit.wikimedia.org/r/399767 [03:10:28] (03PS1) 10Legoktm: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 [03:14:05] (03PS1) 10Legoktm: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 [03:14:50] refeed[m]: no, you can add them as a suppressed warning for now [03:15:21] Amir1: oops, Trying to @cover or @use not existing method "Xml::testBuildTable". [03:16:00] (03CR) 10Legoktm: Add tests for several methods of Xml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [03:16:47] (03PS1) 10Legoktm: Fix @covers in XmlTest [core] - 10https://gerrit.wikimedia.org/r/400141 [03:17:01] (03CR) 10Legoktm: [C: 032] "self-merge to unbreak coverage..." [core] - 10https://gerrit.wikimedia.org/r/400141 (owner: 10Legoktm) [03:19:31] (03CR) 10Gergő Tisza: Add formatversion=2 to all API examples (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [03:20:13] (03CR) 10Gergő Tisza: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [03:23:51] (03Merged) 10jenkins-bot: Fix @covers in XmlTest [core] - 10https://gerrit.wikimedia.org/r/400141 (owner: 10Legoktm) [03:24:23] (03CR) 10Legoktm: Add formatversion=2 to all API examples (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [03:26:17] 10MediaWiki-extensions-Other: Quantcast: switch to HTTPS - https://phabricator.wikimedia.org/T183677#3860289 (10Peachey88) [03:26:45] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-General: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860290 (10Legoktm) [03:27:04] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3860292 (10Legoktm) [03:27:06] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-General: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3858410 (10Legoktm) [03:27:44] (03Merged) 10jenkins-bot: Allow fallbacks for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [03:30:16] (03PS1) 10Legoktm: Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) [03:32:07] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, 10Cognate, and 2 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860299 (10Legoktm) a:03Legoktm [03:33:13] (03CR) 10jenkins-bot: Fix @covers in XmlTest [core] - 10https://gerrit.wikimedia.org/r/400141 (owner: 10Legoktm) [03:38:24] legoktm: Okay!, thanks [03:41:41] (03CR) 10jenkins-bot: Allow fallbacks for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [03:43:58] (03PS2) 10BryanDavis: mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) [03:44:00] (03PS1) 10BryanDavis: mysql: Provide default charset for MediaWiki tables [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400145 (https://phabricator.wikimedia.org/T183679) [03:44:02] (03PS1) 10BryanDavis: mysql: Fix service notification in mysql::large_prefix [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400146 [03:44:41] (03CR) 10BryanDavis: [C: 032] mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [03:44:52] (03CR) 10BryanDavis: [C: 032] mysql: Provide default charset for MediaWiki tables [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400145 (https://phabricator.wikimedia.org/T183679) (owner: 10BryanDavis) [03:45:04] (03CR) 10BryanDavis: [C: 032] mysql: Fix service notification in mysql::large_prefix [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400146 (owner: 10BryanDavis) [03:45:13] (03Merged) 10jenkins-bot: mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [03:45:48] (03Merged) 10jenkins-bot: mysql: Provide default charset for MediaWiki tables [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400145 (https://phabricator.wikimedia.org/T183679) (owner: 10BryanDavis) [03:45:50] (03Merged) 10jenkins-bot: mysql: Fix service notification in mysql::large_prefix [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400146 (owner: 10BryanDavis) [03:47:25] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860308 (10bd808) [03:47:27] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review: Creating centralauth tables in Stretch MariaDB fails - https://phabricator.wikimedia.org/T183679#3860307 (10bd808) 05Open>03Resolved [03:47:46] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847555 (10bd808) [03:47:48] 10MediaWiki-Vagrant, 10Patch-For-Review: Fix default .my.cnf/grants for vagrant user on Stretch - https://phabricator.wikimedia.org/T181918#3860310 (10bd808) 05Open>03Resolved [03:50:30] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860312 (10bd808) [03:53:02] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860313 (10bd808) [03:53:28] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847763 (10bd808) [04:09:54] (03PS2) 10Legoktm: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 [04:09:56] (03PS2) 10Legoktm: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 [04:09:58] (03PS2) 10Legoktm: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 [04:10:00] (03PS1) 10Legoktm: Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 [04:10:02] (03PS1) 10Legoktm: Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 [04:10:04] (03PS1) 10Legoktm: Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 [04:10:06] (03PS1) 10Legoktm: Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 [04:10:08] (03PS1) 10Legoktm: Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 [04:10:10] (03PS1) 10Legoktm: Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 [04:18:48] (03PS3) 10Rafidaslam: Add phan configuration for static analysis and fix phan warnings [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) [04:20:54] legoktm: do you have a free time, if yes could you take a look to my patch https://gerrit.wikimedia.org/r/400079 before I continue ? [04:21:21] (03CR) 10Rafidaslam: "check experimental" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [04:42:02] (03CR) 10Gergő Tisza: "Oh right, the array is the initial value of a static variable. Static/constant expressions are introduced in PHP 5.6." [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [04:45:39] (03PS3) 10Gergő Tisza: Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) [04:48:50] refeed[m]: looking [04:49:16] legoktm: thanks :D [04:49:52] refeed[m]: yep, looks correct to me [04:50:04] also let me whitelist you so you can actually do "check experimental" [04:51:40] legoktm: thanks :D [04:54:42] refeed[m]: try commenting it again? [04:56:12] legoktm: ok [04:56:34] (03CR) 10Rafidaslam: "check experimental" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [04:57:06] now we wait 5 mintues :p [04:57:41] okay :P [05:00:19] legoktm: btw before the patch, there are some codes that call to `SyntaxHighlight_GeSHi`, I changed it to `SyntaxHighlight` since I think `SyntaxHighlight_GeSHi` isn't declared anywhere. is that OK ? I meant I doubt about 'was the code working previously when using `SyntaxHighlight_GeSHi` [05:00:33] 10Internet-Archive, 10InternetArchiveBot: IABot misreporting added archive - https://phabricator.wikimedia.org/T183681#3860317 (10Black_Falcon) [05:00:48] at the very bottom of the file there's [05:00:49] class_alias( SyntaxHighlight::class, 'SyntaxHighlight_GeSHi' ); [05:01:00] however, the _GeSHi version is deprecated [05:01:02] so replacing it is good [05:01:24] all of this code better be working since it's deployed on Wikimedia sites :) [05:02:35] refeed[m]: I peeked, jenkins will tell you it passed :) https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/1926/console [05:02:45] legoktm: ou okay, I didn't know about that magic function exist [05:02:51] legoktm: okay [05:02:57] refeed[m]: if you want to update your other two changes as well, I'd like to merge all three at the same time [05:04:10] legoktm: great, btw I still working on it atm, will ping you when I done :) [05:09:12] legoktm: btw is there any documentation to run the mediawiki extension's phpunit unittests ? [05:09:43] php core/tests/phpunit/phpunit.php extensions/ExtensionName/tests/phpunit/ [05:09:58] https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Run_your_tests [05:10:37] thanks! let me try it first [05:10:58] but you know those are entirely unrelated to phan right? [05:11:31] legoktm: yup, just to make sure everything is alright [05:11:50] good idea :) [05:12:28] but sadly some extensions don't have testcases :/ [05:12:45] yeah [05:12:47] which one? [05:13:31] SyntaxHighlight_GeSHi is one of them [05:13:37] usually there's some sort of manual verification we can do [05:13:48] oh [05:13:50] that one has parser tests [05:14:03] try [05:14:38] php core/tests/parser/parserTests.php --file=extensions/SyntaxHighlight_GeSHi/tests/parserTests.txt [05:15:27] ou, just know about that [05:15:53] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860331 (10bd808) [05:15:56] 10MediaWiki-Vagrant, 10Operations, 10Patch-For-Review: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3860329 (10bd808) 05Open>03Resolved a:03bd808 [05:18:54] (03PS1) 10Legoktm: Fix typo in elasticsearch::repository [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400154 [05:19:37] (03CR) 10BryanDavis: [C: 032] Fix typo in elasticsearch::repository [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400154 (owner: 10Legoktm) [05:20:20] (03Merged) 10jenkins-bot: Fix typo in elasticsearch::repository [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400154 (owner: 10Legoktm) [05:26:51] legoktm: https://dpaste.de/uR29 any idea? I haven't changed anything yet [05:27:29] did you add wfLoadExtension('TitleBlacklist') to your LocalSettings.php ? [05:28:00] legoktm: no I didn't, should I ? [05:28:30] yeah, tests won't work unless the extension is loaded [05:32:45] legoktm: thanks, now it works :D [05:36:35] :D [05:39:04] legoktm: should I include phpunit unittests to phan analysis as well ? [05:39:21] no, those should be excluded for now [05:39:57] legoktm: okay! [05:48:09] I wonder what do `wf` `wg` etc prefixes mean in mediawiki variables, does anyone know about that? [05:49:53] yes :D [05:50:07] https://www.mediawiki.org/wiki/Manual:Wg_variable [05:50:25] wg = "Wikipedia global" [05:50:30] wf = ... function [05:51:47] legoktm: oh thanks, finally the mystery revealed :D [05:54:25] (03PS1) 10BryanDavis: elk: Fix kibana reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400155 [05:57:41] 10MediaWiki-Vagrant: Puppet failing when using stretch-migration branch - https://phabricator.wikimedia.org/T183067#3860336 (10bd808) @Paladox, now that {T181918} is fixed can you recheck this problem? To have a fair comparison with your past tests you will need to enable the hhvm role as php7 is the default run... [05:57:58] (03CR) 10BryanDavis: [C: 032] elk: Fix kibana reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400155 (owner: 10BryanDavis) [05:58:31] (03Merged) 10jenkins-bot: elk: Fix kibana reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400155 (owner: 10BryanDavis) [05:58:42] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860337 (10bd808) [06:02:31] 10MediaWiki-Vagrant: /vagrant/cache/apt permissions issues with Stretch - https://phabricator.wikimedia.org/T183150#3860338 (10bd808) I do not see this error when using VirtualBox file shares (`vagrant config nfs_shares off`), but I'll check with NFS to see if I can recreate it. [06:16:05] legoktm: Does jenkins test for a mediawiki extension just install one extension (the extension that will be tested) in the jenkins mediawiki environment? [06:16:20] it also installs any dependencies [06:17:20] okay [06:19:27] legoktm: where the dependencies specified btw ? [06:20:07] refeed[m]: https://phabricator.wikimedia.org/source/integration-config/browse/master/zuul/parameter_functions.py;5f9f4c41a715c0c35a20dd6b78b6ac2a486966de$138 [06:20:33] (03PS1) 10Phantom42: Add phan configuration for static analysis [skins/Vector] - 10https://gerrit.wikimedia.org/r/400156 (https://phabricator.wikimedia.org/T179554) [06:22:40] legoktm: Ok [06:31:19] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/400136 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [06:31:47] (03CR) 10Legoktm: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/400138 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [06:36:31] hi, legoktm, are you around? [06:36:38] hi cf_fairfeld_ [06:36:57] hey, Merry Christmas :) [06:37:35] just wanted to ask, my task to add minusx to two extensions was approved by Florian [06:37:44] but jenkins shows a build error [06:37:49] link? [06:38:19] https://gerrit.wikimedia.org/r/#/c/400101/ and https://gerrit.wikimedia.org/r/#/c/400102/ [06:38:56] 10MediaWiki-Vagrant: /vagrant/cache/apt permissions issues with Stretch - https://phabricator.wikimedia.org/T183150#3860344 (10bd808) Confirmed that this warning occurs with NFS shares and not with VirtualBox shares. It does not seem to effect actual usage or Puppet's processing of package resources. ``` $ vagr... [06:39:43] 10MediaWiki-Vagrant: /vagrant/cache/apt permissions warnings with Stretch sandboxed apt settings - https://phabricator.wikimedia.org/T183150#3860345 (10bd808) [06:40:26] (03CR) 10Legoktm: [C: 04-1] Add minus-x to extension PagesList (032 comments) [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:40:47] cf_fairfeld_: he approved it too early :p, see the inline comments I just left, which apply to both changes [06:41:14] haha xD I figured [06:41:23] thanks :) I'll check [06:42:47] (03PS2) 10Clockery: Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) [06:43:34] (03PS2) 10Clockery: Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) [06:44:44] (03CR) 10Legoktm: [C: 032] Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:44:52] (03CR) 10Legoktm: [C: 032] Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:46:13] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:46:51] cf_fairfeld_: did you try running minus-x locally? [06:46:53] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [06:48:54] legoktm: do you know what's annotation for associative array in php ? [06:49:06] annotation? what do you mean? [06:49:33] like string, array(), int, etc [06:49:45] legoktm: no, I didn't have php installed, my net is kinda slow [06:50:02] uh just array ? [06:50:06] (03PS1) 10Phantom42: Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) [06:50:33] cf_fairfeld_: ok, I think you should take some time to set up PHP and composer, it'll make doing other tasks much easier. [06:51:13] (03CR) 10jerkins-bot: [V: 04-1] Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [06:51:22] hmm, sure :) [06:52:53] legoktm: hmmm, ok, that's the easy way I think, but it's fine for now [06:53:32] refeed[m]: what are you trying to do? [06:54:41] (03PS2) 10Phantom42: Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) [06:55:51] (03CR) 10jerkins-bot: [V: 04-1] Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [06:55:53] legoktm: Phan detected some wrong type annotations in TitleBlacklist, I wanted to correct it by changing the annotation, f.ex @param string, into @param array, etc [06:56:02] ah [06:56:22] so you can also do [] e.g. Title[] [06:57:07] legoktm: yup! [06:57:17] (03PS3) 10Phantom42: Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) [06:59:34] I just confused about how to annotate associative array in php, since it has no difference with usual array, in Python there is `dict` type, in other languages it's called `map` [07:00:02] yes, PHP's array being both value lists and associative maps is extremely confusing [07:00:24] legoktm: Hi! If you have some free time now, it would be great if you could review my patches: https://gerrit.wikimedia.org/r/400156 https://gerrit.wikimedia.org/r/400157 https://gerrit.wikimedia.org/r/400158 https://gerrit.wikimedia.org/r/400159 Thank you! [07:00:34] will do in a bit [07:00:48] Okay :) [07:02:56] even a php developer said it's extremely confusing, and I still trying to get used to php xD [07:13:17] (03CR) 10Legoktm: "check experimental" [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [07:13:28] (03CR) 10Legoktm: "check experimental" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400156 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [07:13:29] legoktm, um, not sure about this, but jenkins shows errors again for both patches [07:14:05] cf_fairfeld_: yeah, you'll need to run "composer fix" to address the issues, and then recommit it [07:14:46] okay... I'll do that then, after installing php [07:25:14] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3860350 (10Jayprakash12345) @Dereckson Sir, ok Can someone help me to make RfC? [07:29:15] (03PS1) 10Legoktm: Add @covers tags to logging tests [core] - 10https://gerrit.wikimedia.org/r/400160 [07:29:18] (03PS1) 10Legoktm: Add @covers tags to media tests [core] - 10https://gerrit.wikimedia.org/r/400161 [07:29:19] (03PS1) 10Legoktm: Add @covers tags to objectcache tests [core] - 10https://gerrit.wikimedia.org/r/400162 [07:29:21] (03PS1) 10Legoktm: Add @covers tags to page tests [core] - 10https://gerrit.wikimedia.org/r/400163 [07:29:23] (03PS1) 10Legoktm: Add @covers tags to parser tests [core] - 10https://gerrit.wikimedia.org/r/400164 [07:29:25] (03PS1) 10Legoktm: Add @covers tags to specials tests [core] - 10https://gerrit.wikimedia.org/r/400165 [07:29:27] (03PS1) 10Legoktm: Add @covers tags to user tests [core] - 10https://gerrit.wikimedia.org/r/400166 [07:29:29] (03PS1) 10Legoktm: Add @covers tags to utils tests [core] - 10https://gerrit.wikimedia.org/r/400167 [07:29:31] (03PS1) 10Legoktm: Add @covers tags to miscellaneous tests [core] - 10https://gerrit.wikimedia.org/r/400168 [07:34:43] Btw, what is commit message statement that used to state that this commit is related to that commit ? is it Related-to: ? [07:35:11] just say it in English, "This commit is related to " [07:44:31] legoktm: Okay, I thought there was one [07:45:32] legoktm: btw, how about if the case is the related commit is in the different project ? [07:56:29] s/the different project/a different project [08:08:24] (03PS1) 10Rafidaslam: Fix the return type of Scribunto_LuaLibraryBase::register() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/400169 [08:12:40] (03PS2) 10Rafidaslam: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) [08:12:46] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3860352 (10Fullmeteor172) >>! In T179677#3824780, @Gabe_Mitnick wrote: > GCI Submission: > I went full out with the "PAWS" name. My favorite is paws-01, but I created paws-02 in case 01 ha... [08:16:42] (03CR) 10Rafidaslam: "check experimental" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [08:28:11] (03CR) 10Rafidaslam: "I think we need to add Scribunto to the dependency list in integration-config repo" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [08:30:20] (03CR) 10Rafidaslam: "or ignore it? I don't see Scribunto_LuaTitleBlacklistLibrary is used anywhere" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [08:32:15] legoktm: If you have time, could you take a look to https://gerrit.wikimedia.org/r/400081 ? :) [08:40:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400170 (owner: 10L10n-bot) [08:43:19] (03PS19) 10Iniquity: Adaptive design for babel-box and turning on CSS for mobile version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/385852 (https://phabricator.wikimedia.org/T178782) [09:24:03] (03PS1) 10PortalsBuilder: Assets build - 2017-12-25 09:24:01+00:00 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/400172 [10:04:13] (03PS2) 10Rafidaslam: Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) [10:04:20] (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400137 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [10:05:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3860358 (1001tonythomas) [10:05:54] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The main page should exist" in NewsletterCreate - https://phabricator.wikimedia.org/T183635#3860356 (1001tonythomas) 05Open>03Resolved a:03Ryan10145 [10:06:00] (03CR) 10Rafidaslam: "check experimental" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [10:06:18] (03Merged) 10jenkins-bot: Added a unit test to check that the main page exists [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400137 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [10:11:36] (03CR) 10Umherirrender: [C: 04-1] "Error: /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/MsWikiEditor/README.md should not be executable" [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [10:13:45] (03CR) 10Umherirrender: "The failures coming from an external lib in modules/DataTables" [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [10:14:26] (03CR) 10Umherirrender: [C: 032] Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:14:58] 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [BUG] Incorrect language counts in "About this page" section - https://phabricator.wikimedia.org/T180182#3860360 (10Kaartic) 05Resolved>03Open [10:15:10] (03CR) 10Umherirrender: [C: 032] Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:16:13] (03Merged) 10jenkins-bot: Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:16:25] 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [BUG] Incorrect language counts in "About this page" section - https://phabricator.wikimedia.org/T180182#3749643 (10Kaartic) Re-opening just in case the comment wasn't noticed. [10:16:36] (03Merged) 10jenkins-bot: Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [10:19:57] (03CR) 10Hashar: "That magically fixed it :-}" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [10:21:30] 10MediaWiki-General-or-Unknown: srcset uses incorrect radix character - https://phabricator.wikimedia.org/T183660#3860365 (10Ciencia_Al_Poder) [10:21:30] Hi guys! [10:21:32] 10MediaWiki-General-or-Unknown: locale-aware float to string conversion in Html::srcSet - https://phabricator.wikimedia.org/T183659#3860368 (10Ciencia_Al_Poder) [10:21:53] I am creating a new skin based on Vector and as part of that, I would like to set my own colors for @colorProgressive, @colorProgressiveHighlight and @colorProgressiveActive [10:22:01] so that these colors are then used at different places automatically. [10:22:05] (03CR) 10Umherirrender: "Looks good otherwise" (031 comment) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [10:22:07] However, when I add these variables to the central variables.less file of my skin, they are not taken into account. They are just not used. [10:22:15] What do I have to do differently in order for MediaWiki to use my definitions? [10:22:23] 10MediaWiki-General-or-Unknown: locale-aware float to string conversion in Html::srcSet - https://phabricator.wikimedia.org/T183659#3859667 (10Ciencia_Al_Poder) >>! In T183660#3859726, @TheDJ wrote: > We could either use number_format, but then we end up with 1.0x instead of 1x, or I guess we can do character re... [10:25:34] Hello everyone :) [10:25:46] d3r1ck you there? I have something to discuss with you [10:26:12] 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Page status indicator should not be automatically sorted outside main namespace - https://phabricator.wikimedia.org/T94307#1159433 (10TheDragonFire) @Edokter Hey! Over two years on from the opening of this ticket, {{[top icon](https://en.wikipedia.org/wiki/Te... [10:27:36] MyName_: maybe #wikimedia-design ? [10:27:50] or wait, there might be a skins only channel [10:28:34] I see it is defined in resources/src/mediawiki.less/mediawiki.ui/variables.less [10:28:40] but how can I overwrite that? [10:29:46] 10Wikipedia-Android-App-Backlog: Suggestions to improve (?) "On the Day" screen of the app - https://phabricator.wikimedia.org/T179278#3860374 (10Kaartic) It seems the ones in the task description have already been completed. I've added one other minor thing I noticed, now. [10:29:55] Sorry, I dont have enough idea on this - but if I was you - I would look at the place where this file is getting included [10:30:13] (and I expect it to be the skins, if not - I am not sure). [10:32:05] Hmm, I don't find where it is included. That's the problem... [10:33:47] (03CR) 10Rafidaslam: "10:06:33 RecursiveDirectoryIterator::__construct(./../EventLogging): failed to open dir: No such file or directory" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [10:34:12] MyName_ I think it's because if the MediaWiki cache. Read how to force clearing that [10:35:56] Alber221 afaik there is no cache, as I was doing some less changes for MinervaNeue [10:37:13] Isn't there this DB table with resourceloader information, where style paths and so are saved in? I am using debug=true in the URLs... [10:40:07] MyName_: like - Vector seems to import this though - https://github.com/wikimedia/mediawiki-skins-Vector/search?utf8=%E2%9C%93&q=variables&type= [10:40:28] and it overrides in https://github.com/wikimedia/mediawiki-skins-Vector/blob/b7426c30cdd62f9375f494f2ed681522e5a8f8f4/variables.less [10:43:06] addshore FlorianSW_ : Hello, are you guys around? wanna discuss something with one of you [10:45:25] refeed[m]: It's Christmas morning I guess now [10:45:34] 1st day of Christmas [10:47:07] divadsn: oh, just remembered xD [10:47:56] Oh, a wild andre__ appeared :D [10:48:12] Hello :D [10:51:39] hehe [10:51:42] hej hej [10:54:44] * refeed[m] waves ヾ(°∇°*) [10:58:29] (03PS2) 10Nehajha: Added Mediawiki OAuth for applicants [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/398063 (https://phabricator.wikimedia.org/T119534) [11:11:58] 10MediaWiki-Patrolling: New pages if moved or deleted cannot be marked as verified - https://phabricator.wikimedia.org/T177703#3860387 (10Andyrom75) Same thing happens to this redirect: https://it.wikivoyage.org/w/index.php?title=Utente:Yiyi/Il_Liberty_a_Cernobbio,_Como_e_Brunate&redirect=no It's the original p... [11:45:15] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [skins/Vector] - 10https://gerrit.wikimedia.org/r/400156 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [11:46:13] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [skins/Modern] - 10https://gerrit.wikimedia.org/r/400158 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [11:46:54] FlorianSW: Thank you for +1 on my patches! Hopefully they will get merged by somebody soon :) [11:47:44] Phantom42: I think so :) I just haven't +2ed them to make sure I haven't missed something in my review (was my first "introduce phan" change I reviewed). So, I'll learn here, too :P [11:48:40] FlorianSW: Oh, okay :) Thank you and Happy Christmas! [11:48:55] for you and your family, too :) [11:55:43] good morning! [11:56:16] FlorianSW: maybe we can fix this issue that we broke the rules by changing the second extension to have MinusX set up? :) [11:57:10] (03PS10) 10Albert221: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 [11:58:33] Albert221: good morning :) I always appreciate additional work, however, it's not required to get over the broken rule. That happens from time to time, and even if it is not ok, I think that mentioning it and making sure, that this does not happen again, is action enough in this case :) [11:59:40] I understand :) sorry for the problem tho! [11:59:52] and happy 1st Christmas Day! [12:01:39] FlorianSW: Hi (sorry if I'm interrupting), I wanna discuss about https://gerrit.wikimedia.org/r/#/c/400083/ , may I open a CR in `integration-config` regarding to my comment (the last comment) in the gerrit? [12:02:13] Albert221: last christmas day? We've our first christmas holiday today :P [12:02:35] first! :D [12:02:46] I think you misread what I wrote [12:04:07] Albert221: that's when the l and the 1 looks identical (nearly) :P Sorry, yeah, you're right, happy first christmas day, too :D [12:04:40] refeed[m]: Yes, I think changing the integration-config repo to require EventLogging when checking WikiEditor is correct here :) [12:06:08] FlorianSW: Okay :) [12:07:06] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thanks for the great work @Albert221." [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [12:07:13] (03CR) 10Ladsgroup: [C: 032] Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:08:27] FlorianSW: Hey! [12:08:38] Hi everyone! It's Christmas day :D [12:08:46] d3r1ck: hey :) [12:08:49] you too! [12:09:24] (03CR) 10Ladsgroup: Add tests for several methods of Xml (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400131 (owner: 10Ladsgroup) [12:09:41] you too :D [12:10:04] d3r1ck: Hi! Happy Holidays! [12:10:16] refeed[m], Phantom42, hey hey! [12:11:11] Who is working on this? https://gerrit.wikimedia.org/r/#/c/399480/ [12:11:21] That patch is a pain in the ass :( [12:11:48] If it disturbs, the person can abandon and instead work another patch very quickly? [12:12:09] I see it's [12:12:10] Rafid Aslam [12:12:14] refeed[m]: Is that you? [12:12:30] d3r1ck: oh yup, sorry about that ww [12:12:46] No problem [12:13:11] (03CR) 10Rafidaslam: "Opened a CR for adding EventLogging to WikiEditor test dependency (https://gerrit.wikimedia.org/r/400173) the CR dependency need to be mer" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [12:15:00] I'll try to fix it ASAP [12:15:46] (03Merged) 10jenkins-bot: Remove invalid @covers tag [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400143 (https://phabricator.wikimedia.org/T183604) (owner: 10Legoktm) [12:18:02] refeed[m]: Okay [12:21:15] (03PS5) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [12:21:24] hey, I encountered an error when on Special:ContentTranslation on my local setup: https://pastebin.com/uUyJJhC5, I've installed VisualEditor and ContentTranslation and run `composer install`, I don't know why's that happening [12:24:10] Albert221: Looks like a namespace issue to me from first look [12:24:27] the thing is I didn't edit any PHP file [12:24:32] nor composer stuff [12:25:18] Yeah, let me see something, hold on [12:25:54] `composer dump` doesn't help both in mediawiki root and extension root [12:28:14] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [12:31:43] Albert221: You've configured both extensions in LocalSettings.php? [12:31:59] https://www.mediawiki.org/wiki/Extension:ContentTranslation [12:32:23] if you're talking about wfLoadExtension, then yes [12:32:57] ContentTranslation depends on VE [12:33:37] Albert221: No just that, check the docs here: https://www.mediawiki.org/wiki/Extension:ContentTranslation [12:34:55] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3860397 (10Aklapper) p:05Triage>03Lowest [12:35:17] (03CR) 10Umherirrender: [C: 032] Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [12:36:50] (03Merged) 10jenkins-bot: Add phpcs&phpcbf to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400128 (owner: 10Albert221) [12:38:31] Albert221: See this, the namespaces has been autoloaded: https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/master/extension.json#L89 [12:39:09] And the "Translation" is there, https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/master/includes/Translation.php [12:39:19] This seems wierd, check your extension configs again [12:39:36] both VE and CT [12:41:41] Albert221: ^ [12:50:52] Maybe you've something missing at the level of the config and always remember of "composer install/update" and run the "php maintenance/update.php" script [12:56:16] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860399 (10D3r1ck01) [12:58:58] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, 10Cognate, and 2 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860410 (10thiemowmde) >>! In T183604#3859996, @Legoktm wrote: > PHPUnit. Did you read https://phpu... [12:59:21] 10Hindi-Sites: Hindi Wikiversity is not showing in Wikimedia Stats - https://phabricator.wikimedia.org/T183682#3860411 (10Jayprakash12345) [13:07:01] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860415 (10D3r1ck01) [13:11:23] d3r1ck, unfortunately I can't get this to work [13:11:34] Hmmm.. :( [13:11:52] from the docs of Extension on MediaWiki this wfLoadExtension should be enough, I've run update.php, all composer installs and stuff and still [13:11:59] it throws that error [13:13:40] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3860416 (10thiemowmde) > […] if we weren't commenting it […]... [13:13:55] (03PS6) 10Ladsgroup: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 [13:14:02] Can you do a require on the includes/Translation.php file in the special page and try to change ContentTranslation\Translation to Translation and let's see? [13:14:12] That could be a namespace issue IMHO [13:14:26] So let's disregard the namespace ATM and try the manual require [13:14:34] Albert221: ^ [13:16:08] yes, no error now [13:17:48] Damn, so it's a namespace issue [13:17:48] :( [13:18:11] I think you should file a ticket for that right? [13:21:36] Albert221: ^ [13:21:50] sure! [13:23:25] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860418 (10D3r1ck01) [13:24:39] (03PS1) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [13:24:58] 10ContentTranslation: Issue with autoloading of ContentTranslation\Translation from SpecialContentTranslation.php - https://phabricator.wikimedia.org/T183683#3860420 (10Albert221) [13:34:59] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860430 (10D3r1ck01) [13:35:47] 10Discovery: Project Progress (internal) - https://phabricator.wikimedia.org/T154592#3860431 (10Aklapper) One year later: Any updates? Is this task still "used"? What is "CW"? [13:47:48] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860435 (10D3r1ck01) [13:55:11] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860438 (10D3r1ck01) [13:57:32] d3r1ck: I think something is wrong with task description: extensions/Collection/OfflineContentGenerator/node_modules and extensions/DonationInterface/vendor should not be in zuul. I think you need to change that to extensions/Collection/OfflineContentGenerator and extensions/DonationInterface [13:58:17] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860439 (10D3r1ck01) [13:59:02] Phantom42: I think they should be :) [13:59:07] Let me point you to something [14:00:33] Phantom42: Check from here below: https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L3105 [14:00:42] Tell me what you think :) [14:02:29] d3r1ck: Well, I checked. I think `bundler` is okay because it is just one of directories with source code. However `node_modules` and `vendor` contain third-party libraries. I think there is no need to test it separately [14:03:09] d3r1ck: Oh, wait. It is not clear about `vendor`... https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L2749 [14:06:46] Phantom42: Did you see my messages? [14:07:09] d3r1ck: Look at this: `https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Collection/OfflineContentGenerator/bundler` it is a separate repo [14:07:30] Phantom42: Yes it is :) [14:08:05] Hmm. This one is too: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Collection/OfflineContentGenerator/node_modules [14:08:11] That's strange. Maybe I am not right... [14:08:35] :) [14:08:39] They are separate repos [14:12:51] d3r1ck: I checked it. Yes, you are right. Looks like those should be added to zuul too. I was a bit confused by repo names. Sorry :) [14:13:22] It's totally fine, you are always free to ask questions :) [14:13:27] Phantom42: hey hey! :) [14:27:20] 10MediaWiki-General-or-Unknown, 10CSS: Replace layout-only span.mw-editButtons-pipe-separator in favor of CSS - https://phabricator.wikimedia.org/T183672#3860440 (10matmarex) Pipes like on Special:Contributions and Special:DeletedContributions are used in a large number of places (see usages of the 'Language::... [14:28:24] 10Design, 10OOjs-UI, 10UI-Standardization, 10CSS, and 3 others: Adding 'margin-bottom' for widgets which are part of OOUI HorizontalLayout - https://phabricator.wikimedia.org/T179040#3860441 (10matmarex) 05Open>03Resolved [14:31:46] (03CR) 10Bartosz Dziewoński: [C: 032] Remove font-size now it is set by editfont [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399616 (https://phabricator.wikimedia.org/T180678) (owner: 10Esanders) [14:33:36] (03Merged) 10jenkins-bot: Remove font-size now it is set by editfont [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399616 (https://phabricator.wikimedia.org/T180678) (owner: 10Esanders) [14:37:20] (03PS2) 10Bartosz Dziewoński: Add collation for Abkhaz (ab) [core] - 10https://gerrit.wikimedia.org/r/399537 (https://phabricator.wikimedia.org/T183430) [14:37:48] (03CR) 10Bartosz Dziewoński: [C: 032] Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [15:08:26] d3r1ck, are you there? [15:08:43] (03PS1) 10Ladsgroup: Update model version when it's different in ScoreParser [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) [15:08:45] divadsn: Always :) [15:09:05] Alright, I have this task with you d3r1ck, but look this: https://phabricator.wikimedia.org/T133289#3860189 [15:09:29] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860473 (10D3r1ck01) [15:10:25] divadsn: Are my mentoring it? [15:10:27] :D [15:10:47] In my opinion it's not really a issue with Education Program pages, but with the Gadget authors not using mw.config.get properly [15:10:55] Yes d3r1ck, https://codein.withgoogle.com/dashboard/task-instances/4551263544934400/ :P [15:11:11] Ohhh, sounded familiar :) [15:11:29] Any specific question? I'm currently working on curating a list of extensions that are not in zuul [15:11:43] So kinda busy now but let me look at your comment in a bit okay? [15:12:18] Well, I think I solved that issue, but now I just wanted to have your final word as I submitted it for review ^^ [15:12:52] Let me look at the patch [15:13:03] You abandoned the patch divadsn? [15:13:09] Can you link me to the patch you submitted? [15:13:19] Yes, as the patch isn't a solution for the problem [15:13:33] There is no patch required in my opinion [15:13:49] But anyways, here it is: https://gerrit.wikimedia.org/r/400134 [15:14:25] divadsn: let me transfer you to Zppix ATM before I get back to your patch [15:14:41] Zppix: Welcome and please handle divadsn's issue for me :D [15:14:42] Alright, np d3r1ck :) [15:14:52] divadsn: Sure, I'll get back to you. I'm almost done ;) [15:14:55] Hello this is Zppix how may i take your call? [15:15:26] What issue? [15:17:58] Hello Zppix, thanks, this is my issue: https://codein.withgoogle.com/dashboard/task-instances/4551263544934400 [15:18:32] In my opinion it's not a Education Program related problem, it's a wrong use of mw.config.get without a default return parameter [15:18:52] I explained how the usage should be here: https://phabricator.wikimedia.org/T133289#3860189 [15:22:14] Hmm [15:23:16] I have no clue [15:23:18] Hm. I have an interesting issue here. StringPrefixSearch documentation page (https://doc.wikimedia.org/mediawiki-core/master/php/classStringPrefixSearch.html) says that StringPrefixSearch class is deprecated and we need to "use SearchEngine::prefixSearchSubpages or SearchEngine::completionSearch" instead. However `SearchEngine::prefixSearchSubpages` does not actually exist. Am I missing something? [15:23:56] Zppix but you should have a clue if it's possible to define JS vars within a Page interface? [15:24:11] I mean the EducationPage class does only implement the Page interface [15:24:24] And afaik addtional JS vars can be only set in OutputPage [15:24:53] divadsn: i personally would think no, but it may be possible, but perhaps messy as hell [15:25:19] so we should rather nag those Gadget authors about using mw.config.get properly? Zppix [15:25:32] Or create a task where students could fix that maybe? :D [15:26:28] "Add empty array as default when getting wgRestrictionEdit in Gadget"? [15:26:55] (03PS1) 10Hashar: swift: remove unused list of packages [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400184 [15:27:53] (03CR) 10Hashar: Fix dupe python-setuptools (033 comments) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [15:28:58] divadsn: either or [15:29:16] divadsn: but d3r1ck may have a different ideah [15:29:39] Let's wait then ^^ [15:31:01] (03PS3) 10Hashar: keystone: remove python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) [15:39:34] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860475 (10D3r1ck01) [15:40:39] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10D3r1ck01) I've iterated over `mediawiki/extensions/*` for all extensions not found in `zuul/layout.yaml`... [15:40:59] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860477 (10D3r1ck01) [15:42:38] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10D3r1ck01) [15:42:47] Zppix: I'm done :) [15:42:53] Kindly have a look: https://phabricator.wikimedia.org/T183674 [15:42:59] hello Zppix! [15:43:02] 47 more tickets to go into GCI soon :) [15:43:12] divadsn: Let me look at your issue now [15:43:20] andre__: You are up, https://phabricator.wikimedia.org/T183674. [15:46:28] Hi Albert221 [15:51:31] divadsn: After looking at the issue closely, you have a point [15:51:42] I think that check should be done at the level of the Gadget [15:52:18] So should I open a new task which could then be imported to GCI for other students? [15:52:55] I mean, this is really easy to do and if anyone does one Gadget on the list, then it should be fixed :D [15:53:21] Or are these Gadgets non-editable? [15:57:41] divadsn: That I'm not really sure! [15:58:09] I'm not good at Gadgets, I only use them :) [16:04:35] (03PS1) 10Phantom42: Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) [16:04:41] (03PS13) 10Fomafix: Strip soft hyphens (U+00AD) from title [core] - 10https://gerrit.wikimedia.org/r/393381 (https://phabricator.wikimedia.org/T121979) [16:05:33] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/393381 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [16:06:35] (03PS2) 10Phantom42: Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) [16:11:59] (03CR) 10Phantom42: "check experimental" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:12:11] (03CR) 10Phantom42: "check experimental" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:12:52] hello my name is flash and i am on IRC for a Google Code-in task. [16:15:33] So, have I done my task? :D d3r1ck [16:15:55] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3860482 (10matmarex) The patches here got merged, but we still do not have a help page and we do not have an announcement... [16:17:26] I think I would disagree, d3r1ck [16:18:33] Unless there is some good reason for a function to return nil, then its default ought to be of the same type as the outputs it normally returns [16:19:43] It's cleaner to return a consistent type, because it simplifies use - otherwise every use has to test for nil [16:21:40] d3r1ck: If you have some free time, it would be great if you take a look at my patches and say if something is wrong: https://gerrit.wikimedia.org/r/#/c/400174/ https://gerrit.wikimedia.org/r/#/c/400185/ [16:21:41] https://gerrit.wikimedia.org/r/#/c/400186/ https://gerrit.wikimedia.org/r/#/c/400187/ [16:22:06] yeah i agree with you [16:24:06] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: "Login to Wikidata as QuickStatementsBot from a computer you have not recently used" - https://phabricator.wikimedia.org/T182867#3837192 (10Vituzzu) Same happens with my Irclogbot, only... [16:34:11] RexxS but not when it's not supposed to be, because an empty array for wgRestrictionEdit means that there are no restrictions and the page is editable, so it's a logical problem [16:37:02] * d3r1ck checks in and reads logs [16:37:32] Hello everyone.... I'm Akhilesh Adithya ... and I'm participating in the GCI(Google code in ) thingy.... Wanted to pop in and say hi [16:37:53] marcusfromwd2: Welcome! Good luck with your GCI tasks! [16:38:08] marcusfromwd2: Which country are you from? :) [16:38:34] I'm from India... [16:38:42] i am also for that task [16:38:44] Thank you [16:39:04] marcusfromwd2: Nice! We have some other GCI students from India here. Hope you meet them soon! [16:39:14] flash1: Welcome! [16:39:24] Sure.... Would be a pleasure [16:39:25] welcome marcusfromwd2 ! [16:39:38] i am from india too [16:40:17] RexxS: yes, I agree with you on that generally! [16:40:28] flash1: Great! [16:41:15] RexxS: We are talking about this: https://phabricator.wikimedia.org/T133289 [16:41:39] The first issue is, would it be good to tackle this at the level of the gadgets or at the level of MediaWiki? [16:42:10] Based on the problem, I think tackling it at the level of the gadget is better before now we can look at the solution to the problem? [16:42:25] marcusfromwd2: Welcome and feel at home :) [16:42:37] Phantom42: Let me look at your patches [16:43:04] d3r1ck: Oh, good! Thank you! [16:44:31] Phantom42: Which tasks does your patches solve? 4 patch? Hmm... [16:45:13] d3r1ck: That's for phan task. Give me a second, I will send you a link... [16:46:00] Okay! [16:46:31] d3r1ck: https://phabricator.wikimedia.org/T179554 [16:46:56] Phantom42: On GCI, can you link me? [16:47:16] * d3r1ck is lazy :D [16:47:46] d3r1ck: https://codein.withgoogle.com/dashboard/task-instances/5312452545740800/ [16:49:11] Thank you [16:54:13] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:56:34] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [16:58:46] Phantom42: Done! I've added more people to you patch in case I miss something. If all goes well, then the patches will be merged :) [16:59:04] d3r1ck: Thank you so much! :) [16:59:09] Welcome sir! [17:06:31] (03PS1) 10Ladsgroup: [WIP] Split ThresholdLookup into two class [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400188 (https://phabricator.wikimedia.org/T181892) [17:22:09] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3854002 (10Anamdas) >>! In T183465#3859807, @Dereckson wrote: > So, for the on-wiki consensus part, you could start by Hi... [17:35:41] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:35:55] (03CR) 10Florianschmidtwelzow: [C: 031] Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:38:45] So d3r1ck, what do we do with my task? :/ [17:41:20] divadsn: TBH, we are still delibrating :) [17:42:22] d3r1ck, oh ok :D [17:42:42] divadsn: don't know if you will get a reply for the comment you left on the ticket :) [17:43:23] d3r1ck: But I hope I will get on GCI? :D [17:43:32] Maybe :) [17:43:46] You've left a comment there right? [17:44:36] Yes ^^ [17:44:48] I also submitted my task, d3r1ck [17:51:06] Okay! [18:26:31] d3r1ck: Could you check please if this task is already completed: https://codein.withgoogle.com/tasks/6587968972128256/ ? I was about to claim it, but then I noticed that there is already a patch uploaded by other GCI student: https://gerrit.wikimedia.org/r/#/c/398174/ [18:29:36] The task on Phabricator (https://phabricator.wikimedia.org/T94020) mentions 4 things which need to be localized. I checked that patch and looks like it introduced all needed localization features. Is there any additional work needed? [18:45:16] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, 10Cognate, and 3 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860495 (10Legoktm) >>! In T183604#3860410, @thiemowmde wrote: >>>! In T183604#3859996, @Legoktm wr... [18:46:32] 10Discovery, 10Wikimedia-Portals: Change "liguru" in "lìgure" in the Wikipedia portal - https://phabricator.wikimedia.org/T180772#3860496 (10Samuele2002) You have to replace Liguru with Lìgure. [18:50:02] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3860498 (10Legoktm) [18:50:07] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-WikibaseMediaInfo, 10Cognate, and 3 others: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3860497 (10Legoktm) 05Open>03Resolved [19:11:44] legoktm: the list is up, https://phabricator.wikimedia.org/T183674. [19:13:56] (03CR) 10Legoktm: "check experimental" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:14:49] d3r1ck: thanks, I'm mostly offline today, I'll look at it tomorrow [19:15:48] legoktm: Sure! :) [19:30:51] (03CR) 10Legoktm: [C: 032] "Nice find :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/400169 (owner: 10Rafidaslam) [19:31:11] (03Restored) 10Divadsn: Always define wgRestrictionEdit as an empty array for pages [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [19:31:26] (03PS3) 10Legoktm: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:34:12] (03Merged) 10jenkins-bot: Fix the return type of Scribunto_LuaLibraryBase::register() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/400169 (owner: 10Rafidaslam) [19:36:47] (03CR) 10Legoktm: "check experimental" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:37:12] (03CR) 10Legoktm: "check experimental" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:44:14] d3r1ck: So can I claim that task or I better choose other one? [19:44:44] I'll be better you choose a different one :) [19:45:52] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:46:06] d3r1ck: Okay. Thanks. Maybe we need to ask Andre to remove that task, if it is already completed, to avoid confusing other gci students. [19:46:12] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:46:19] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis and fix phan warnings [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:46:20] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:46:23] (03CR) 10Legoktm: [C: 032] Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:46:29] Phantom42: It's already marked as completed but the patch is still yet to be merged. [19:47:46] d3r1ck: It is not marked as completed. It is disabled on GCI task search page and is available to be claimed. [19:48:03] (03Merged) 10jenkins-bot: Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:48:18] Nikerabbit: if you are around, you can have a final round look? https://gerrit.wikimedia.org/r/#/c/398174/ [19:48:29] Phantom42: Hmm... Let me look again [19:49:30] mistake in my previous message: it is displayed* [19:49:57] Phantom42: Ohh I see it had 3 instances. [19:50:07] This ticket should really have just 1 instance [19:50:26] And in the case of 1 instance, it has been done already [19:50:34] (03Merged) 10jenkins-bot: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:50:36] (03Merged) 10jenkins-bot: Add phan configuration for static analysis and fix phan warnings [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [19:50:38] (03Merged) 10jenkins-bot: Add phan configuration for static analysis [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/400185 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:50:44] d3r1ck: Okay. Thanks :) Hope it will get removed from task search soon [19:50:57] Phantom42: Can you search again? [19:51:01] And give me feedback? [19:51:26] d3r1ck: Will try now... [19:51:37] Okay! [19:52:29] d3r1ck: Now it is hidden. Thank you! [19:53:07] (03CR) 10jerkins-bot: [V: 04-1] Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:53:16] Phantom42: Welcome :) [19:55:37] 10Security-Team, 10phan-taint-check-plugin, 10Google-Code-in-2017: Make phan-taint-check-plugin support Hooks::runWithoutAbort - https://phabricator.wikimedia.org/T183194#3860515 (10Phantom42) a:03Phantom42 I will work on fixing this! [20:00:30] (03CR) 10Legoktm: [C: 04-1] "Looks like there are 2 phan errors that need to be fixed :/" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:01:04] legoktm: wow. by any chance are you up for a minute ? [20:01:10] had a query on unit tests! [20:01:22] (just wrote an email to wikitech-l, so if you are free - a reply there would also help) [20:07:04] (03CR) 10Phantom42: "Hm. Strange. It doesn't fail on my machine. Anyway, I will try to fix it now" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:07:21] Good evening [20:07:37] refeed[m]: Good evening! [20:07:57] Phantom42: o/ [20:09:03] refeed[m]: Good evening :) [20:09:22] Btw, could any mentor approve my task (https://codein.withgoogle.com/dashboard/task-instances/6227327019122688/ )? all patches for this task have been merged by legoktm.. [20:15:31] refeed[m]: Done! [20:15:46] (03CR) 10Hashar: thumbor: `nproc` => $::processorcount (032 comments) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400098 (https://phabricator.wikimedia.org/T183462) (owner: 10Hashar) [20:15:51] d3r1ck: Thanks :D [20:17:26] refeed[m]: Good Evening! :D [20:17:39] Someone want to proofread here my post? :) [20:17:44] https://www.codebucket.de/blog/contest/2017/12/24/google-code-in-beginners-guide.html [20:18:35] I'll check it over cursorily [20:23:17] (03PS2) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [20:23:54] divadsn: o/ , just read it, nice article, I like how did you make tl;drs for most of the points [20:25:01] d3r1ck: the task "The labels and numbers in CX translation trend graph should be localized" says "0 students are working on this task and 1 student has finished. 0 claims remaining." So I don't see what to remove? [20:25:14] there should not be further task instances to claim, I think? [20:25:16] (03PS3) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [20:25:23] andre__: Yes! [20:26:28] divadsn: Good article. Stylistically, sentences shouldn't start with a co-ordinating conjunction (such as "and" or "or") [20:28:27] (03CR) 10Phantom42: "I am done! Let's try once more and see if it fails this time!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:28:38] 10ContentTranslation: Issue with autoloading of ContentTranslation\Translation from SpecialContentTranslation.php - https://phabricator.wikimedia.org/T183683#3860420 (10Nikerabbit) Your mediawiki core might be too old. The namespace based autoloading is a very recent feature. [20:31:43] Ebe123, ah, never have heard that, thanks, will correct later! :) [20:32:41] (03PS1) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [20:32:56] Nah, the language is changing, and is becoming more acceptable, but I don't like it! :) [20:35:24] (03PS2) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [20:36:56] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3860544 (10Pppery) a:03Pppery [20:39:58] (03CR) 10Phantom42: [C: 031] Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [20:42:04] (03CR) 1001tonythomas: "Looking good, minor improvements." (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [20:44:35] Ebe123, you got it :) [20:46:03] Or just more variety, "but" is used 18 times. However, "however" not once [20:46:22] (03CR) 10Anomie: "It's probably not a matter for this task, but do you have any idea if we can get ApiStructureTest to cover the stuff it covers? It seems t" [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [20:47:32] (03CR) 10Anomie: Add @covers tags API tests without them (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [20:52:25] (03PS3) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [20:52:46] (03CR) 10Pppery: "Wow, remarkably fast review" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [20:58:31] (03CR) 1001tonythomas: "Almost there. :)" (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [21:16:11] 10MediaWiki-Maintenance-scripts: fix needed for cases where users have multiple userids, such as user:0 on enwiki - https://phabricator.wikimedia.org/T182374#3821874 (10Anomie) If you're pointing out how enwiki has 1356 edits where the revision table has `rev_user_text` as '0' (meaning https://en.wikipedia.org/w... [21:16:38] I go to sleep early today, good night :) [21:17:47] Albert221: Good night! [21:18:14] Hello, I'm in here for a Google Code-in task (codein.withgoogle.com) [21:18:35] mundus: Welcome! [21:18:47] mundus: Which country are you from? :) [21:18:53] I'm from the US [21:19:12] Just found out about this thing today from the Ubuntu MOTD haha [21:19:23] Great! Just of curiosity, which state? [21:19:23] Figured I'd do some tasks [21:19:27] Iowa [21:20:54] Okay :) [21:21:10] And which IRC client are you using? [21:21:34] HexChat [21:21:45] And running through ZNC [21:22:26] mundus: Great! Good luck with your GCI tasks! [21:22:31] Thanks! [21:22:58] (03CR) 10Legoktm: "I'll look into ApiStructureTest separately, I think we can come up with something..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [21:23:30] If you have any questions - feel free to ask any time - we are always happy to help :) [21:23:37] Will do :) [21:24:11] Is wikimedia liek the pare nt company for Wikipedia? [21:24:17] *like the parent [21:24:40] yes [21:24:48] yes, we maintain the infrastructure and the code for Wikipedia and all related projects [21:24:54] (03PS4) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [21:24:54] Ah, cool [21:26:21] Phantom42: o/ [21:26:32] (03PS5) 10Pppery: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) [21:27:24] Zppix: Hey! :) [21:29:09] Phantom42: how are you [21:31:42] mundus: Welcome :) [21:32:03] guess whose back guyz [21:32:17] hello everyone! ;] [21:32:32] RootKlawiter: Hi, welcome :) [21:32:33] Zppix: Nice. A bit busy though (gci tasks, homework). Hopefully I will finish soon and get back to ZppixBot and miraheze related things I promised to do :) [21:32:39] RootKlawiter: Welcome back! [21:32:45] yaaay [21:32:52] nice to see you guys! [21:33:41] Phantom42: hey, take a break from our stuff and focus on GCI, You deserve to get tasks done [21:34:11] * d3r1ck needs to get some sleep :) [21:35:00] * d3r1ck sends good night wishes to everyone especially GCI participants (students) :D [21:35:05] I need to focus on GCI also ;-; [21:35:21] Zppix: Don't worry about that. Your stuff is interesting to me and I do it while waiting for my gci tasks to be reviewed :) [21:35:32] I need to do at least 3 more tasks [21:35:35] * Phantom42 wishes good night to d3r1ck [21:36:04] d3r1ck: night [21:36:23] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 10Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#3860553 (10Anomie) >>! In T36873#3860045, @Ebe123 wrote: > Hein? T179831 hasn'... [21:36:52] good night d3r1ck [21:44:59] (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [21:46:31] (03Merged) 10jenkins-bot: Add a unit test to check that the main page must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400192 (https://phabricator.wikimedia.org/T183632) (owner: 10Pppery) [21:48:30] (03CR) 10Anomie: Add @covers tags API tests without them (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [21:58:40] (03PS3) 10Legoktm: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 [21:59:02] (03PS3) 10Legoktm: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 [21:59:06] (03CR) 10Legoktm: [C: 032] Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [22:01:39] (03CR) 10Legoktm: [C: 04-1] Add phan configuration for static analysis (033 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [22:06:14] (03Merged) 10jenkins-bot: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [22:06:38] (03PS2) 10BryanDavis: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:06:45] (03CR) 10BryanDavis: [C: 032] tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:06:51] (03PS4) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [22:08:42] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3860561 (10Leg... [22:09:58] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10Leg... [22:10:23] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554#3728463 (10Leg... [22:13:26] (03Merged) 10jenkins-bot: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:13:56] (03PS5) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [22:17:25] (03CR) 10jenkins-bot: Add @covers tags for Collation tests [core] - 10https://gerrit.wikimedia.org/r/400139 (owner: 10Legoktm) [22:22:57] (03PS6) 10Phantom42: Add phan configuration for static analysis [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) [22:24:00] (03CR) 10Phantom42: "Thank you for reviewing! Hopefully we will get all issues fixed soon with this :)" (033 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [22:24:04] (03PS3) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [22:24:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [22:26:53] (03CR) 10jenkins-bot: tests: Use checkPHPExtension() instead of re-implementing it [core] - 10https://gerrit.wikimedia.org/r/400140 (owner: 10Legoktm) [22:29:10] (03PS4) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [22:32:03] Anyone know what parser comes bundled with mw 1.30? [22:37:34] (03CR) 10BryanDavis: [C: 032] swift: remove unused list of packages [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400184 (owner: 10Hashar) [22:37:53] (03CR) 10BryanDavis: [C: 032] keystone: remove python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [22:38:06] (03Merged) 10jenkins-bot: swift: remove unused list of packages [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400184 (owner: 10Hashar) [22:38:24] (03Merged) 10jenkins-bot: keystone: remove python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [22:51:34] (03PS1) 10SamanthaNguyen: Use newer DBUpdater function for LoadExtensionSchemaUpdates hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400193 [22:59:52] (03PS1) 10Phantom42: Add Hooks::runWithoutAbort support [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/400194 (https://phabricator.wikimedia.org/T183194) [23:13:06] Zppix, for what? [23:15:01] divadsn: nevermimd [23:15:27] Ugh, seems like Jenkins is having it's days on pywikibot xD https://gerrit.wikimedia.org/r/#/c/400195/1 [23:28:35] divadsn: lookin [23:28:51] Zppix, has been solved, not sorted imports xD [23:29:06] Jenkins can be somtimes annoying tho :P [23:33:08] divadsn: fixedd [23:36:52] Zppix, yeah :D [23:36:56] Thanksss [23:44:04] Np [23:48:43] 10Accessibility, 10MediaWiki-Parser, 10Parsoid: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#3860572 (10SMcCandlish) Agreed with TheDJ on all counts, except that it's actually worse. What's happening is that...