[00:03:14] 10Support-and-Safety, 10Wikimedia-Site-requests: Enable create a Secure poll in Arwiki - https://phabricator.wikimedia.org/T183358#3859358 (10Huji) @Ibrahim.ID we have been using SecurePoll (via vote.wikimedia.org) for the Persian Wikipedia (fawiki) major elections for the last two years in the row as well. I... [00:06:41] (03PS1) 10Phantom42: Add minus-x to composer test and fix [extensions/Athena] - 10https://gerrit.wikimedia.org/r/400076 (https://phabricator.wikimedia.org/T175794) [00:13:08] (03PS1) 10Phantom42: Add minus-x to composer test and fix [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/400077 [00:13:47] 10Support-and-Safety, 10Wikimedia-Site-requests: Enable SecurePoll on Arabic Wikipedia - https://phabricator.wikimedia.org/T183358#3859362 (10Huji) [00:14:29] (03PS2) 10Phantom42: Add minus-x to composer test and fix [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/400077 (https://phabricator.wikimedia.org/T175794) [00:22:38] can someone please check my task [00:22:51] ive submitted it for review [00:22:56] thanks [00:23:00] Which task is it? [00:23:41] link? [00:24:19] (03CR) 10Gergő Tisza: Add formatversion=2 to all API examples (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [00:24:30] bawolff: I think it IRC task [00:24:35] Oh [00:24:38] it is* [00:25:11] yep it is [00:25:18] GCI [00:25:33] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859366 (10Doc_James) [00:26:27] Albert221: You too Merry christmas! :D and others as well [00:27:01] #offtop is there anyone who uses PHP on daily basis? I'd like to get some feedback about my lib :) [00:27:19] PM me if you want to give me some feedback, I'll write you details [00:27:44] Hmm. Logs dont show joins/quits [00:27:45] it's a validation library [00:27:52] bawolff, which logs? [00:28:02] shubby: you promise youve been here an hour? [00:28:06] oh [00:28:09] I can tell you [00:28:16] I have been here an hour [00:28:25] 00:18 Hiya I'm part of the Google Code In Task [00:28:43] Thanks Albert :) [00:28:58] no problem fellow :) [00:29:47] wait thats wrong time [00:29:47] Oh. I mispelled your name when i looked for you [00:30:03] or it might be time zones [00:30:15] I'm UTC+1, it's 01:30 in my location now [00:30:16] sorry, i should have been able to find you [00:30:36] oh yes makes sense, its GMT here [00:30:51] In http://wm-bot.wmflabs.org/logs/%23wikimedia-dev/20171223.txt [00:31:52] shubby: do you have a link to the task instance? I hate navigating the google code in site [00:32:12] https://codein.withgoogle.com/dashboard/task-instances/5452021266120704/ Here you go [00:33:35] Thanks, approved [00:33:41] welcome to gci! [00:33:54] Thanks a lot:) [00:34:12] wait Ive won a T-shirt [00:34:34] legoktm: Hi! Around? [00:36:43] anyways its 12am here, I'll try and do some more tasks tomorrow [00:36:47] jdlrobson you're up? :) [00:36:49] bye [00:37:35] "~lubuntu@" great :D [00:38:05] divadsn: Installed lubuntu? :D [00:38:22] Phantom42, no but shubyy :P [00:38:41] I saw his IRC username ^^ [00:38:46] divadsn: Oh, sorry. I see :)) [00:39:00] Anyways, I'm too tired to finish this https://imgur.com/a/NtBBt [00:39:19] I'm going to sleep, tomorrow another batch of xmas preparations [00:40:24] divadsn: Noice! [00:40:25] Good night everyone! [00:40:29] divadsn: Good night! And Happy Holidays! [00:40:47] divadsn: Good night! [00:40:52] Phantom42, thanks, you too 🎄 [00:45:32] good night divadsn! [00:46:00] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.) - https://phabricator.wikimedia.org/T171563#3859381 (10MGChecker) I don't think there's need to treat css pages the... [00:49:58] 10MediaWiki-Special-pages, 10Collaboration-Team-Triage, 10TechCom-RfC, 10Patch-For-Review: Introduce article creation log - https://phabricator.wikimedia.org/T12331#3859382 (10MGChecker) >>! In T12331#3858604, @MZMcBride wrote: > Even though the log won't be complete and won't solve the "show all pages cre... [00:50:53] About Google Code-in task, before submitting, what do I need to comment below? [00:53:04] ycwei982: Welcome! If it is an IRC task, you will need to write your name in comments. However, according to task description, you need to stay here for 1 hour before submitting. [00:54:32] 10MediaWiki-extensions-OnlineStatus: OnlineStatus extension shows warning on deprecated hookEvent - https://phabricator.wikimedia.org/T165552#3859383 (10SpookyGhost8) Now under MediaWiki 1.29.2, FireFox console tells me ``` Exception in module-execute in module ext.onlineStatus: ReferenceError: hookEvent is not... [00:56:34] 10MediaWiki-extensions-OnlineStatus: Extension:OnlineStatus reference error - undefined hookevent - https://phabricator.wikimedia.org/T165552#3859385 (10SpookyGhost8) [00:58:04] So actually I stayed here for 1 hour (12 hours ago), then submitted for review [00:58:51] 10MediaWiki-extensions-OnlineStatus: Extension:OnlineStatus reference error - undefined hookevent - https://phabricator.wikimedia.org/T165552#3859387 (10SpookyGhost8) [01:09:13] ycwei982: ill look in the logs [01:11:01] 12:55:27] Hello and I am from Google Code-in task [01:11:42] Yeah you are good [01:12:09] Welcome! [01:12:29] and it is still, not accecped [01:12:50] the only message i got is Welcome to Wikimedia. Keep up the great work and ask questions on #wikimedia-dev while working on your tasks. Good luck :) remove_circle [01:13:19] ycwei982: i meant im going to approve the task now [01:13:28] ok thanks a lot :) [01:13:49] as soon as i find it on the gci site. Do you happen to have a link? [01:14:27] https://codein.withgoogle.com/dashboard/task-instances/4520377092931584/ [01:14:46] you mean this link? [01:15:27] Yep [01:20:06] 10MediaWiki-Export-or-Import, 10Patch-For-Review: Usernames in history of imported pages should refer to original wiki - https://phabricator.wikimedia.org/T9240#117740 (10Metronomo) I think it may be related to T36873 [01:31:44] (03CR) 10Kaldari: "recheck" [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [01:35:34] 10MediaWiki-extensions-UniversalLanguageSelector, 10ContentTranslation, 10ULS-CompactLinks: CLL has the problem when displaying gray links for languages with variants - https://phabricator.wikimedia.org/T183648#3859395 (10Petar.petkovic) [01:37:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [01:42:06] Btw, which php version is used by mediawiki core ? [01:42:51] 1.30 is 5.0+ [01:43:03] 5.4* [01:43:13] 5.5* even jeeez [01:45:29] Zppix: thanks [01:45:48] refeed[m]: we increase the version requirements every now and then [01:47:05] Hence me having to correct myself 3 times [01:47:35] Well 5.0+ hasnt been the case for quite a long time [01:47:53] haha makes sense [01:48:28] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10Patch-For-Review: Add an AbuseFilter variable for global edit count of the user - https://phabricator.wikimedia.org/T130439#3859408 (10Dispenser) [01:48:30] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10Commons: Add SUL/CentralAuth variables to AbuseFilter - https://phabricator.wikimedia.org/T181932#3859407 (10Dispenser) [01:49:38] eh wanna ask again, do you know where do I can find the CI scripts ran by jenkins? [01:50:23] refeed[m]: on the subject of version, you might find https://phabricator.wikimedia.org/T172165 interesting [01:50:38] depends which script you mean [01:51:25] The actual tests are in mediawiki core [01:51:53] There are some scripts to run the other scripts that are elsewhere though [01:52:23] bawolff: idk what is it, but it's named `extension-phan-generic`, I found it in the `template` section of layout.yml https://gerrit.wikimedia.org/r/#/c/387960/2/zuul/layout.yaml [01:52:52] *in one of item's template section [01:53:34] https://www.mediawiki.org/wiki/Phan has instructions on how to run it locally [01:55:32] oh okay, I actually just wanna make sure that the CI scripts sync with my local environment, since `phan` now is in `0.11` and it just supports PHP 7.2 syntax [01:56:04] *CI script=`extension-phan-generic` [02:05:11] Oh found it, apparently the phan runs in docker, and it still uses phan 0.8, btw thanks bawolff ! [02:06:10] Not even that, we are at like 0.8.0 instead of 0.8.9 [02:06:49] bawolff: oh yup, missed the zero xD [02:07:22] * bawolff learned that the hard way [02:08:37] kek [02:10:46] 10MediaWiki-extensions-UniversalLanguageSelector, 10ContentTranslation, 10ULS-CompactLinks: CLL has the problem when displaying gray links for languages with variants - https://phabricator.wikimedia.org/T183648#3859410 (10Petar.petkovic) [02:16:36] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks: CLL shows wrong number for "X more languages" label - https://phabricator.wikimedia.org/T183649#3859412 (10Petar.petkovic) [02:17:10] 10MediaWiki-Core-Tests, 10MediaWiki-General-or-Unknown, 10NewPHP, 10Patch-For-Review: MediaWiki PHPUnit fails with PHP 7.2 - https://phabricator.wikimedia.org/T181931#3859423 (10Reedy) No it wouldn't/isn't. It'll use the "newest" version of phpunit available for that version of PHP that it's running under.... [02:55:16] good night everyone! :) [03:01:03] Albert221: Good night! [03:01:24] (03PS1) 10Rafidaslam: Add phan configuration for static analysis [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) [03:05:59] (03PS2) 10Rafidaslam: Add phan configuration for static analysis [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) [03:18:08] (03PS1) 10Rafidaslam: Add phan configuration for static analysis [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) [03:36:57] (03PS1) 10Rafidaslam: Add phan configuration for static analysis [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) [03:42:50] (03CR) 10BryanDavis: "d3r1ck: did you need to make a follow up to this for the Composer dependency?" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399773 (https://phabricator.wikimedia.org/T183305) (owner: 10BryanDavis) [03:45:25] 10MediaWiki-Vagrant, 10Operations, 10Patch-For-Review: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3859447 (10bd808) The ELK packages are fix now. The cirrussearch role is still failing (T183306) in part due to: ``` ==> default: Error: Could not update: Executio... [03:45:51] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3859451 (10bd808) [03:45:53] 10MediaWiki-Vagrant, 10Patch-For-Review: elasticsearch package missing for geodata_elastic role - https://phabricator.wikimedia.org/T183305#3859449 (10bd808) 05Open>03Resolved a:03bd808 [04:18:18] (03PS1) 10BryanDavis: kafka: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400085 (https://phabricator.wikimedia.org/T183306) [04:19:45] (03CR) 10BryanDavis: [C: 032] kafka: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400085 (https://phabricator.wikimedia.org/T183306) (owner: 10BryanDavis) [04:20:15] (03Merged) 10jenkins-bot: kafka: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400085 (https://phabricator.wikimedia.org/T183306) (owner: 10BryanDavis) [04:21:17] 10MediaWiki-Vagrant, 10Patch-For-Review: packages are missing for cirrussearch role - https://phabricator.wikimedia.org/T183306#3859457 (10bd808) [04:25:45] (03PS1) 10Sharvaniharan: Update empty state of reading lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/400086 (https://phabricator.wikimedia.org/T183434) [04:26:25] (03CR) 10jerkins-bot: [V: 04-1] Update empty state of reading lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/400086 (https://phabricator.wikimedia.org/T183434) (owner: 10Sharvaniharan) [04:26:55] 10MediaWiki-Vagrant: wmf-elasticsearch-search-plugin not available for Stretch - https://phabricator.wikimedia.org/T183306#3859462 (10bd808) [04:32:06] (03PS3) 10Sharvaniharan: Expose default list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) [04:50:20] (03Abandoned) 10Sharvaniharan: Update empty state of reading lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/400086 (https://phabricator.wikimedia.org/T183434) (owner: 10Sharvaniharan) [04:52:11] (03PS1) 10Sharvaniharan: Update empty state of reading lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/400087 (https://phabricator.wikimedia.org/T183434) [05:13:57] 10Social-Tools, 10SocialProfile: SocialProfile: UserProfile conditionally runs deprecated ParserLimitReport hook within a ArticleFromTitle hook - https://phabricator.wikimedia.org/T183652#3859486 (10SamanthaNguyen) [05:33:30] (03PS1) 10SamanthaNguyen: Improve user profile page design styles [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400089 [05:42:08] 10MediaWiki-File-management, 10Commons, 10Multimedia: $wgForeignFileRepos class ForeignDBViaLBRepo, result in "Empty server array given to LoadBalancer" - https://phabricator.wikimedia.org/T183653#3859501 (10Zoglun) [05:59:57] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3854002 (10YmKavishwar) Thanks for creating this task and working to solv this problem. wikimedia foundation respect all... [06:07:41] 10MediaWiki-Database, 10MediaWiki-File-management, 10Commons, 10Multimedia: $wgForeignFileRepos class ForeignDBViaLBRepo, result in "Empty server array given to LoadBalancer" - https://phabricator.wikimedia.org/T183653#3859514 (10Zoglun) [06:22:13] 10MediaWiki-Database, 10MediaWiki-File-management, 10Commons, 10Multimedia: $wgForeignFileRepos class ForeignDBViaLBRepo, result in "Empty server array given to LoadBalancer" - https://phabricator.wikimedia.org/T183653#3859515 (10Zoglun) 05Open>03Invalid Solved by add 'wiki' => 'wiki-db-name-used-with-... [06:23:33] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Unify and refine WikimediaUI icon set - https://phabricator.wikimedia.org/T177432#3859518 (10Volker_E) [06:23:36] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Deprecate and remove 'find' - https://phabricator.wikimedia.org/T183645#3859517 (10Volker_E) [06:37:23] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859520 (10Tgr) [06:37:40] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859366 (10Tgr) [06:38:20] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859366 (10Tgr) [06:41:05] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859523 (10Tgr) [06:41:40] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859524 (10Jayprakash12345) >>! In T183465#3859304, @MarkAHershberger wrote: > We will also need on-wiki consensus from t... [06:43:28] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859366 (10Tgr) Just to confirm what's already stated in the linked discussions, the characters being converted are non-breaking spaces (so the content of the article is not changed, the nbsp's are just made more e... [06:47:06] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859527 (10Jayprakash12345) >>! In T183465#3859355, @MarkAHershberger wrote: > Thanks, @bawolff. Good point. > > I'll h... [07:03:33] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859528 (10Tgr) The first edit adding a non-breaking space to that article seems to be [https://en.wikipedia.org/w/index.php?title=Parkinson%27s_disease&diff=prev&oldid=788406064 this one]. [07:06:03] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859529 (10Tgr) 05Open>03Invalid WikEd issues are not tracked in Phabricator (cf. T85433#3297818) so there is not much to do here. If enwiki does not have one yet, I'd suggest setting up an edit filter that war... [07:07:07] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859533 (10Tgr) [07:10:00] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859535 (10Doc_James) Okay so an edit filter to block hidden no-breaking spaces? It could also come from a copy and paste issue involving visual editor. I am not really sure of the cause. Students often use VE work... [07:12:00] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859536 (10Doc_James) Why can we not simple replace hidden no-breaking spaces with normal space with WikEd? [07:27:29] 10Architecture, 10Developer-Relations, 10JavaScript: Develop a long term vision for community managed scripts and gadgets - https://phabricator.wikimedia.org/T171577#3859538 (10Tgr) The main vision-level question IMO is whether we want gadgets which are "familiar" for wiki editors (can be updated by editing... [07:42:57] 04(no projects): Hard Spaces Being Added to Wikipedia - https://phabricator.wikimedia.org/T183647#3859543 (10Tgr) I believe you can; it's a content decision (A. in the cases where non-breaking spaces are used intentionally, do you prefer raw ones over ` `? cf. T96701; B. how would you deal with the diffs b... [07:50:38] 10MediaWiki-Authentication-and-authorization, 10Security-Core: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420#3859546 (10Tgr) >>! In T183420#3852730, @Anomie wrote: > If you want to generically store "authentication data", then do... [07:54:17] 10MediaWiki-Authentication-and-authorization, 10Security-Core: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420#3859547 (10Tgr) MariaDB supports [[https://mariadb.com/kb/en/library/grant/#column-privileges|per-column privileges]] so... [08:12:51] 10MediaWiki-Special-pages, 10Collaboration-Team-Triage, 10TechCom-RfC, 10Patch-For-Review: Introduce article creation log - https://phabricator.wikimedia.org/T12331#3859548 (10kaldari) Anyone have any idea why my patch causes all the tests in ApiQueryWatchlistIntegrationTest to fail?? [08:35:13] ei... i am coming back. i was though i was really banned. its just like the notification said [08:35:41] Welcome back! [08:37:22] hey, eisenhaus335 :) [08:38:12] i was panicked before what did i am just do before xD [08:38:17] it's funny, when I tried to join the channel it said I was banned too... [08:38:54] haha xD same [09:09:58] anyone know what's the difference between libvirt and virtualbox provider in vagrant? [09:12:38] (03CR) 10Fomafix: Add formatversion=2 to all API examples (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [09:27:43] refeed[m]: Virtualbox is one way. libvirt as the base for KVM or for qemu is another way. I think. [09:29:09] Fork a child process. Return 0 in the child and the child’s process id in the parent. [09:29:15] https://docs.python.org/2/library/os.html [09:29:34] os.fork() [09:30:07] andre__: okay, thanks [09:30:08] i am cannot understand what is this child. any tips? [09:30:26] 04(no projects): Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3859554 (10Aklapper) [09:31:12] eisenhaus335: https://en.m.wikipedia.org/wiki/Child_process [09:31:32] thanks :) [09:32:15] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859555 (10Aklapper) Please see https://www.mediawiki.org/wiki/Requests_for_comment for general info on RfCs. Thanks. [09:32:20] how many times you enter GCI Phantom42 you seem know much [09:32:35] This is my second time [09:34:52] eisenhaus335: the child is the process that is "forked" from the (now "parent") process, basically [09:36:56] By the way, does anybody know how Phabricator shows commits in feed? For me, sometimes it shows my commits, sometimes it doesn't. It would be great if someone could explain me which commits are shown in feed and which aren't. Are there any settings for this? [09:39:36] Hey [09:39:41] I'm on IRC for a Google Code-in task [09:39:59] Leorjj: Welcome! Good luck with your GCI tasks! [09:40:14] Thanks :D [09:40:19] Which country are you from? :) [09:40:53] From India [09:41:21] Trying to figure out how I submit this task xD [09:41:33] Nice! We have a lot of other GCI students from India. Hope you meet them soon :) [09:42:09] And just note that according to task description you have to wait 1 hour before submitting this task. [09:42:18] Oh [09:42:27] Didn't know that [09:42:28] Thanks [09:51:42] hey, Leorjj! :) [09:51:47] welcome :) [09:51:54] Hey [09:52:10] (03CR) 10Addshore: "Woo, gerrit change #400000" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [09:54:28] (03CR) 10Addshore: "check experimental" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [09:54:35] (03CR) 10Addshore: "check experimental" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [09:54:40] (03CR) 10Addshore: "check experimental" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [09:55:27] Leorjj: welcome! [09:58:23] (03CR) 10Addshore: [C: 04-1] Add phan configuration for static analysis (031 comment) [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400079 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [09:58:47] (03CR) 10Addshore: [C: 04-1] Add phan configuration for static analysis (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/400081 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [09:59:15] (03CR) 10Addshore: [C: 04-1] Add phan configuration for static analysis (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/400083 (https://phabricator.wikimedia.org/T179554) (owner: 10Rafidaslam) [10:02:26] is RexxS around, by any chance? [10:03:40] in the Module namespace, how do you call a function (with named parameters) defined in one module from another? [10:20:18] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3859558 (10D3r1ck01) 05Resolved>03Open Follow up patch needed, will close this once it's done. [10:24:28] (03CR) 1001tonythomas: [C: 04-1] "Amazing. Few nitpicks and we are ready to go." (034 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) (owner: 10Albert221) [10:24:59] Hello Tony Thomas! [10:25:06] tonythomas* [10:25:59] d3r1ck: Good morning! Around? [10:30:08] (03PS1) 10D3r1ck01: Add composer feature to SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) [10:30:54] (03CR) 10jerkins-bot: [V: 04-1] Add composer feature to SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [10:31:12] (03PS2) 10D3r1ck01: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) [10:31:57] (03CR) 10jerkins-bot: [V: 04-1] Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [10:32:52] (03PS3) 10D3r1ck01: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) [10:33:09] (03CR) 10D3r1ck01: "@BryanDavis, yes! I sent a follow up patch, https://gerrit.wikimedia.org/r/#/c/400092/. Thanks" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399773 (https://phabricator.wikimedia.org/T183305) (owner: 10BryanDavis) [10:33:37] (03CR) 10jerkins-bot: [V: 04-1] Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [10:33:52] Albert221: ssup! [10:34:51] tonythomas: I'll get to fix this asaic :) [10:35:22] nice [10:37:16] (03PS4) 10D3r1ck01: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) [10:38:03] Phantom42: Hello, I'm around :) [10:38:04] (03CR) 10jerkins-bot: [V: 04-1] Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [10:39:14] d3r1ck: Awesome! Do you have some free time? It would be great if you could review my patches: https://gerrit.wikimedia.org/r/#/c/400076/ and https://gerrit.wikimedia.org/r/#/c/400077/ [10:40:20] Phantom42: Okay! :) [10:40:59] (03PS5) 10D3r1ck01: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) [10:41:45] (03CR) 10jerkins-bot: [V: 04-1] Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [10:42:59] (03CR) 10D3r1ck01: [C: 031] "LGTM! Great work @Phantom42 :)" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/400077 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [10:43:05] 10MediaWiki-extensions-InputBox: default parameter doesn't work on search2 - https://phabricator.wikimedia.org/T183654#3859564 (10Gustmd7410) [10:45:09] 10Accessibility, 10MediaWiki-Parser, 10Parsoid: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#3859574 (10Jc86035) @SMcCandlish MediaWiki is written in PHP. [10:46:27] (03CR) 10D3r1ck01: "Some trailings that should be removed. Trivial :)" (032 comments) [extensions/Athena] - 10https://gerrit.wikimedia.org/r/400076 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [10:46:33] 10MediaWiki-Internationalization, 10Patch-For-Review: Removal of mo language codes - https://phabricator.wikimedia.org/T18889#3859575 (10Liuxinyu970226) Should we wait for some days? It seems @Cybernenea11 does [[https://translatewiki.net/wiki/Special:Contributions/Cybernenea11|contributed in this month]]. [10:46:44] Phantom42: I spotted some issues here: https://gerrit.wikimedia.org/r/#/c/400076/1 [10:46:54] But it's trivial, you can quickly fix it :) [10:49:31] d3r1ck: Thank you for reviewing! Yes, that spacing issue needs to be fixed. However, it is a bit unrelated to that change. Should I change that there anyway, or it is better to upload another patch to keep things separate? [10:52:36] Phantom42: Anything you decide is totally fine! But If it's me, I'll just make everything in 1 patch :) [10:55:05] (03PS6) 10D3r1ck01: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) [10:58:09] (03CR) 10D3r1ck01: "@BryanDavis, I didn't know that the indentation here is spaces and not tabs (4 spaces rather than 1 tag). I got keep getting a failing bui" [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [10:59:45] 10Wikimedia-Site-requests: The flag of the rewind - https://phabricator.wikimedia.org/T183655#3859586 (10Pavliukdanila) [11:01:02] 04(no projects): Strange expiration time summary in special:log - https://phabricator.wikimedia.org/T183656#3859598 (10Xqt) [11:04:23] 04(no projects): Strange expiration time summary in special:log - https://phabricator.wikimedia.org/T183656#3859607 (10Aklapper) [11:04:31] (03PS2) 10Phantom42: Add minus-x to composer test and fix [extensions/Athena] - 10https://gerrit.wikimedia.org/r/400076 (https://phabricator.wikimedia.org/T175794) [11:04:37] 10MediaWiki-Interface: Strange expiration time summary in special:log - https://phabricator.wikimedia.org/T183656#3859608 (10Xqt) [11:05:28] (03PS4) 1001tonythomas: Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) [11:06:07] 10MediaWiki-Special-pages, 10MediaWiki-User-management: Strange expiration time summary displayed on Special:Log (blocked for 18 months but shows slightly different value) - https://phabricator.wikimedia.org/T183656#3859610 (10Aklapper) [11:06:33] (03CR) 1001tonythomas: "should be ready to go at this point." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) (owner: 1001tonythomas) [11:06:42] d3r1ck: Done! Thank you again! Hopefully someone will merge those patches soon :) [11:07:02] Phantom42: Sure! It'll be merged :) [11:07:57] (03CR) 10D3r1ck01: [C: 031] "LGTM! Great work @Phantom42 :)" [extensions/Athena] - 10https://gerrit.wikimedia.org/r/400076 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [11:08:08] Phantom42: Great work! Thank you very much :) Keep up! [11:08:24] d3r1ck: Thank you! [11:09:03] Phantom42: I added people with +2 rights to the patch. [11:09:12] So It'll be merged ASAP [11:09:23] *hopefully. [11:09:32] d3r1ck: Great! [11:09:38] 10MediaWiki-extensions-CookieWarning: The cookiewarning_dismissed cookie should be evaluated at client side, not server side - https://phabricator.wikimedia.org/T183657#3859612 (10Ciencia_Al_Poder) [11:10:00] tonythomas: Hey! :) [11:10:02] (thing is its vacation, and people would be slow to do this ASAP) [11:10:15] d3r1ck: hey! ssup [11:10:29] tonythomas: Sure! But Reedy is always around :) [11:10:52] tonythomas: Saw the Newsletter tasks, great one :) [11:10:59] more incoming [11:11:03] Have they been published already? [11:11:05] Ohh wow [11:12:31] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3859627 (10thiemowmde) I started coding in PHP 3 and are awar... [11:17:57] Hello addshore are you around ? [11:20:55] 10MediaWiki-Internationalization, 10Patch-For-Review: Removal of mo language codes - https://phabricator.wikimedia.org/T18889#3859637 (10Cybernenea11) Yes, I was contributing and will continue to contribute to the Moldavian language till the very end despite having very little free time. Because my language is... [11:24:06] 10Accessibility, 10MediaWiki-Parser, 10Parsoid: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#3859641 (10TheDJ) I also actually think that this is up to developers honestly. Especially for discussion pages, m... [11:32:15] 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: Colour not appearing in print - https://phabricator.wikimedia.org/T183625#3859644 (10TheDJ) backgrounds are usually never printed by a browsers to begin with and similarly for PDF, we want to create a 'quiet' and more 'rustic' re... [11:33:00] 10MediaWiki-General-or-Unknown, 10CSS: Colour not appearing in print - https://phabricator.wikimedia.org/T183625#3859645 (10TheDJ) [11:37:53] tonythomas, okay, I'm on PC now! [11:37:57] can someone tell me if https://dpaste.de/sdfS/raw is the right way to create a wikipage (to be used in a test) [11:38:15] 4 lines to create a page, or am I missing something ? [11:38:39] (it works, but i am sure there should be a simpler way) ? [11:39:02] 10Documentation, 10Google-Code-in-2017: [beginner] [recurring] Set up your MediaWiki development environment and upload a screenshot of a MediaWiki extension - https://phabricator.wikimedia.org/T178987#3859646 (10Framawiki) [11:41:46] (03PS2) 10Albert221: Unit test NewsletterDb::addPublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) [11:42:51] (03CR) 10Albert221: Unit test NewsletterDb::addPublisher (034 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) (owner: 10Albert221) [11:43:03] tonythomas, fixed these issues! [11:45:07] (03CR) 1001tonythomas: [C: 04-1] "Getting better :)" (034 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) (owner: 10Albert221) [11:46:01] hmm, why $this->returnValue instead of ->willReturn? [11:48:09] tonythomas^ [11:48:47] check `getMockLoadBalancer()` above [11:49:20] oh, so I suppose it's only for consistency, right? [11:49:35] I didn't see that in getMockLoadBalancer() though, so sorry! [11:49:37] yes. it works either way - but probably its some standard (I dont know about) [11:52:50] and this second thing where you said I need [[ ]], are you 100% sure? `addSubscription()` gets array of associative arrays as a second parameter (here: https://phabricator.wikimedia.org/diffusion/ENLT/browse/master/includes/NewsletterDb.php;f8105bd7bf4240b5cd3df4693233c2e4a2389129$38), but `addPublisher()` gets associative array, not array of assoc [11:52:51] arrays (here: https://phabricator.wikimedia.org/diffusion/ENLT/browse/master/includes/NewsletterDb.php;f8105bd7bf4240b5cd3df4693233c2e4a2389129$102). So I don't understand [11:54:41] I am not sure if its related to our (Newsletter) functions though. [11:54:55] Albert221: did you try it with `[[]]` -- was it still working ? [12:00:57] Albert221: found it. my mistake, `[]` is enough there [12:01:47] I wonder why we are doing it per user in `addPublisher` though. I will create another ticket for it to receive things in bulk. [12:02:47] because second parameter of `addSubscription()` is an array of user ids, that's why I think [12:03:31] there's everything okay with this code IMHO tonythomas, no need to create a ticket [12:04:45] Albert221: for this PS, not a problem - but look at https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/includes/NewsletterEditPage.php#L415 [12:05:12] we really want that function to receive a list of users so that we can add 'n' publishers in one go [12:05:21] rather than looping through individual users. [12:05:26] anyway, an improvement for later [12:05:30] (03PS3) 10Albert221: Unit test NewsletterDb::addPublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) [12:06:38] no problem, create a ticket and I'll fix that! [12:06:42] I mean improve not fx [12:07:07] that really makes sense, I was thinking you've an issue to addPublisher itself [12:08:33] yeah. there are bunch of bad code here and there which needs cleansing [12:09:40] tonythomas, when you'll be creating that ticket, add me as a subscriber on Phab, please! [12:09:49] same nick as on IRC [12:10:10] BTW, current patch is okay? [12:11:52] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Add/Remove/Notify of Publishers should happen in bulk - https://phabricator.wikimedia.org/T183658#3859652 (1001tonythomas) [12:11:55] sure. [12:12:13] I would make one 'medium-high' GCI task out of it [12:13:40] (03CR) 1001tonythomas: [C: 032] Unit test NewsletterDb::addPublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) (owner: 10Albert221) [12:13:47] (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) (owner: 10Albert221) [12:15:17] (03Merged) 10jenkins-bot: Unit test NewsletterDb::addPublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) (owner: 10Albert221) [12:15:38] tonythomas thanks! Merry Christmas! :) [12:15:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3859665 (1001tonythomas) [12:15:59] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test addPublisher in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183615#3859663 (1001tonythomas) 05Open>03Resolved Nice work! Thanks. [12:16:01] Albert221: same to you! [12:25:54] 10MediaWiki-General-or-Unknown: locale-aware float to string conversion in Html::srcSet - https://phabricator.wikimedia.org/T183659#3859667 (10Ciencia_Al_Poder) [12:27:20] 10MediaWiki-General-or-Unknown: srcset uses incorrect radix character - https://phabricator.wikimedia.org/T183660#3859677 (10TheDJ) [12:29:40] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) [12:31:38] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/400095 (https://phabricator.wikimedia.org/T175794) [12:32:35] (03CR) 10D3r1ck01: "recheck" [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [12:34:37] (03CR) 10D3r1ck01: "recheck" [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/400095 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [12:55:58] d3r1ck, do you know why Jenkins isn't working? [12:56:51] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/400095 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [12:56:57] (03CR) 10D3r1ck01: [C: 031] "recheck" [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/400095 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [12:57:06] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [12:57:11] (03CR) 10D3r1ck01: [C: 031] "recheck" [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [12:57:37] Albert221: No idea, lets see if it would work now :) [12:58:16] d3r1ck: why do you want to manually do this `recheck` ? [13:02:39] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3732727 (10Fullmeteor172) {F12028165} Hey There! This is my entry for the Google Code in Contest 2017, I had a ton of fun designing it ^^ I hope you guys like it too :) @Framawiki @yuvipa... [13:06:46] Merry christmas [13:06:55] Thanks! You too! [13:09:12] :) [13:14:10] Zppix: Merry Christmas! [13:14:19] and Merry Christmas, everyone! :D [13:18:38] Zppix: you too! :D [13:22:04] cf_fairfeld: you too :D [13:22:55] (03CR) 10Divadsn: "@Daimona, alright I see the point, also if the class is everywhere too then it would be better to use it to keep it consistent :)" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [13:23:18] (03Abandoned) 10Divadsn: Replace deprecated tag with tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [13:23:49] 04(no projects): Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3859711 (10Betacommand) In most wikis the use of non-visible non-breaking spaces is discouraged. What I think the real issue here is the spike in non-breaking spaces being added in the... [13:24:15] Good afternoon and merry christmas :D [13:24:23] cf_fairfeld you too ;) [13:24:35] divadsn: Merry Christmas! [13:24:47] Oh and I saw tonythomas you joined our smalltalk group on Telegram ^^ [13:24:57] :-D [13:25:00] Phantom42: you too! :D [13:25:09] divadsn: Merry christmas! [13:25:18] Yeah but there is not so much going on in our channel mostly :/ [13:25:43] well, I dont know - too many channels to interact to - probably :P [13:25:45] noice, I haven't opened telegram for a while [13:26:22] refeed[m] since the schooltrip? :D [13:27:48] divadsn: yeah, my phone battery always dying in the schooltrip yesterday, so I can't open it xD [13:28:33] refeed[m]: uh, my phone's battery is also weak after a year, but I'm also lazy to get a powerbank charged xD [13:31:37] divadsn: same case with me, what a coincident xD [13:32:13] 10MediaWiki-extensions-EducationProgram, 10Ladies-That-FOSS-MediaWiki, 10Easy, 10Google-Code-in-2017, 10JavaScript: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#3859720 (10divadsn) a:03divadsn I will fix that issue :) [13:34:05] 04(no projects): Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3859724 (10Doc_James) Yup agree with Betacommand. The big question is why did 450 non-visible no-breaking spaces get added in this edit? https://en.wikipedia.org/w/index.php?title=Sept... [13:35:37] 10MediaWiki-General-or-Unknown: srcset uses incorrect radix character - https://phabricator.wikimedia.org/T183660#3859726 (10TheDJ) I guess this is due to LC_NUMERIC being set to his french number format. There is a foreach loop in Html::srcSet that does ``` // Cast density to float to strip 'x', then back to s... [13:38:34] 10MediaWiki-Templates, 10I18n: Template subpage name "doc" is not localized - change to Pashto لاسوند. - https://phabricator.wikimedia.org/T182309#3859727 (10Baloch007) Hei it's finished, please close this task [13:39:36] Albert221 sometimes it takes hours to get your queue [13:51:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: [Bug] Editing a qualifier in a group of qualifiers shows the other ones as recreated in diff - https://phabricator.wikimedia.org/T118232#3859733 (10matej_suchanek) p:05High>03Low Hm, now when I take a look at the diff, it looks perfect. Unl... [13:57:13] 10MediaWiki-Templates, 10I18n: Template subpage name "doc" is not localized - change to Pashto لاسوند. - https://phabricator.wikimedia.org/T182309#3859737 (10Dinoguy1000) 05Open>03Resolved a:03Dinoguy1000 [13:59:18] (03PS3) 10Hashar: rspec-puppet for all the roles [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) [14:00:30] d3r1ck, do you think that Jenkins is having Christmas Eve too? [14:01:05] Albert221: i hope not [14:01:05] tonythomas: Maybe you can help me out? :D [14:01:19] Albert221: ill look to see what the job queue is like [14:01:21] Albert221: maybe but praying God that doesn't happen [14:01:50] Albert221: theres nothing in job queue [14:02:15] (03CR) 10Hashar: "I have hit a bug with puppet 4.8.x which caused a syntax error whenever app_management is enabled. Worked around by using a mock." [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [14:05:09] Maybe that's because change topic is empty? [14:06:10] Try setting it and see if Jenkins will notice that change [14:07:16] it would be strange because it's not my first patch without topic [14:07:34] but I did this, Zppix, could you check queue? [14:07:49] No topic doesnt mean anything to ci [14:07:54] Hashar is not around, he's the CI guy talking with Jenkins always [14:08:10] d3r1ck: i have my ways [14:08:20] Zppix: Okay :) [14:08:30] Albert221: gerrit links? [14:09:14] https://gerrit.wikimedia.org/r/#/c/400094/ + https://gerrit.wikimedia.org/r/#/c/400095/ [14:09:39] (03CR) 10Zppix: "Recheck" [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [14:09:52] Hmm [14:11:27] I yelled at releng [14:11:32] So well see what happens [14:12:05] Zppix: Maybe this could be the problem? [14:12:07] https://www.mediawiki.org/wiki/Continuous_integration/Jenkins#OOM_Issues [14:12:12] I dont know [14:12:29] I am not a jenkins expert i just know if its broken or not [14:14:54] Okay! [14:15:10] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [14:17:29] (03CR) 10Paladox: "recheck" [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [14:17:31] So now i feel like an idiot [14:17:42] The repos dont have ci [14:18:20] Albert221: [14:18:21] oh! [14:18:42] I think jenkins should yell if he's marked as a reviewer but can't do anything [14:18:45] wat did i am just missing on chat? i want to know [14:19:09] eisenhaus335: nothing [14:20:43] i am just dont want to missing an discussion. i want to learn afterall to join this [14:22:05] Zppix: Can a ticket be filled for that? [14:22:19] eisenhaus335: You'll learn :), just stick around :) [14:22:32] Welcome to the Wikimedia Dev channel eisenhaus335 [14:22:46] eisenhaus335: public logs are available. [14:22:54] eisenhaus335: http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/ [14:25:28] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3859747 (10hashar) [14:25:30] 10MediaWiki-Vagrant, 10Patch-For-Review: Make php7 the default PHP on stretch - https://phabricator.wikimedia.org/T181915#3859745 (10hashar) 05Resolved>03Open https://gerrit.wikimedia.org/r/398707 removed the `role::zend` class though it is still used by `role::zero` and referenced in a comment: ``` module... [14:29:05] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3859748 (10hashar) [14:29:10] 10MediaWiki-Page-deletion, 10MediaWiki-extensions-Nuke, 10Wikidata: Pages, deleted with Special:Nuke, wasn't deleted from its Wikidata items - https://phabricator.wikimedia.org/T183662#3859751 (10MaxBioHazard) [14:34:08] (03Abandoned) 10Esanders: Avoid loading the old editor system if we can. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247028 (owner: 10Catrope) [14:36:06] (03CR) 10Esanders: Remove the old editor system (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 (owner: 10Catrope) [14:40:02] 10MediaWiki-extensions-Translate: Protection "Translations talk" namespace (#1199) from editing - https://phabricator.wikimedia.org/T182530#3859764 (10Liuxinyu970226) @Base: //(Wish you to answer those questions when your wikibreak of Phabricator is done.)// # `For what it is worth, Translations namespace itself... [14:40:24] 10MediaWiki-extensions-InputBox: default parameter doesn't work on search2 - https://phabricator.wikimedia.org/T183654#3859766 (10Aklapper) Hi Gustmd7410, thanks for reporting this! Please see https://mediawiki.org/wiki/How_to_report_a_bug and describe what "does not work" means exactly, and provide basic inform... [14:55:21] (03CR) 10Ladsgroup: [C: 032] Remove duplicate ServiceWiring definitions [core] - 10https://gerrit.wikimedia.org/r/399997 (owner: 10Addshore) [15:01:00] (03CR) 10Ladsgroup: Introduce DB schema overrides for unit tests. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/391866 (https://phabricator.wikimedia.org/T180705) (owner: 10Daniel Kinzler) [15:01:21] (03Merged) 10jenkins-bot: Remove duplicate ServiceWiring definitions [core] - 10https://gerrit.wikimedia.org/r/399997 (owner: 10Addshore) [15:09:25] (03PS4) 10Hashar: rspec-puppet for all the roles [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) [15:09:42] (03CR) 10jenkins-bot: Remove duplicate ServiceWiring definitions [core] - 10https://gerrit.wikimedia.org/r/399997 (owner: 10Addshore) [15:09:59] (03PS1) 10Hashar: hadoop: fix Resource type not found: BLOCK [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400097 [15:10:14] (03PS1) 10Hashar: thumbor: `nproc` => $::processorcount [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400098 (https://phabricator.wikimedia.org/T183462) [15:11:14] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3859783 (10Scott) [15:11:16] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Customizable summary of page editors/authors - https://phabricator.wikimedia.org/T29629#3859785 (10Scott) [15:11:55] (03CR) 10Hashar: "I have added lsbdist: Debian" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [15:14:07] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3859787 (10Scott) At T29629#323647 @demon wrote: > agree that it's probably a good idea to strike vandal accounts (does action=credits even respect Re... [15:18:19] 10Collection: Collection extension needs some way to credit original authors of a work - https://phabricator.wikimedia.org/T30064#3859789 (10Scott) [15:19:11] 10Collection: Collection extension needs some way to credit original authors of a work - https://phabricator.wikimedia.org/T30064#335012 (10Scott) [15:20:08] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#72802 (10Scott) [15:20:37] Bye! [15:22:46] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3859797 (10Scott) [15:25:55] hey! [15:27:39] Albert221: Hi! [15:27:54] sorry I was having issues with irc [15:30:49] 10MediaWiki-General-or-Unknown: Deleted pages should be served as HTTP 404 instead of HTTP 200 - https://phabricator.wikimedia.org/T61733#3859799 (10Scott) [15:33:20] 10MediaWiki-extensions-CookieWarning: The cookiewarning_dismissed cookie should be evaluated at client side, not server side - https://phabricator.wikimedia.org/T183657#3859800 (10Ciencia_Al_Poder) a:03Ciencia_Al_Poder [15:35:33] 10MediaWiki-General-or-Unknown: Deleted pages should be served as HTTP 404 instead of HTTP 200 - https://phabricator.wikimedia.org/T61733#3859801 (10Scott) [15:36:43] 10MediaWiki-General-or-Unknown: Deleted pages should be served as HTTP 404 instead of HTTP 200 - https://phabricator.wikimedia.org/T61733#612171 (10Scott) [15:43:29] "Cannot join channel (+b) - you are banned (banned_from_channel)" what's happening? [15:43:42] d3r1ck, can you see my messages? [15:43:46] Albert221, happened to me too [15:44:05] your messages are appearing on the channel though [15:44:23] yup I can see you guys messages [15:45:03] I was able to join when I registered my nick, for some reason it was showing up as unregistered [15:45:39] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859807 (10Dereckson) So, for the on-wiki consensus part, you could start by Hindi wikis, as you discussed with Hindi wik... [15:54:37] (03PS1) 10Martineznovo: Check the dismissed cookie on client-side before calling geolocation [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/400099 (https://phabricator.wikimedia.org/T183657) [16:09:48] 10MediaWiki-General-or-Unknown: nuke.php and nukeNS.php delete content without extension being notified - https://phabricator.wikimedia.org/T152261#3859819 (10mwjames) @cicalese @MarkAHershberger FYI [16:11:27] d3r1ck: well, I thought your issue was jenkins not automatically getting added to the PS ? [16:12:09] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859821 (10Bawolff) I dont really think on wiki consensus is needed at this time - this sort of thing has been on and off... [16:18:00] jenkins only gets added when the user adds a comment. [16:19:12] well, he can just add jenkins manually as a reviewer though. [16:20:15] Yep. [16:32:14] 10Google-Code-in-2017: Improve the maintenance script that download Wikimedia database dump - https://phabricator.wikimedia.org/T183663#3859825 (10Framawiki) [16:44:15] 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3859839 (10Framawiki) p:05Triage>03Normal [16:44:28] 10Google-Code-in-2017: download_dump.py: Add a progress bar - https://phabricator.wikimedia.org/T183664#3859839 (10Framawiki) [16:48:04] 10Google-Code-in-2017: download_dump.py: Use response.iter_content - https://phabricator.wikimedia.org/T183666#3859862 (10Framawiki) p:05Triage>03Normal [16:55:56] 10Google-Code-in-2017: download_dump.py: If the file already exists - https://phabricator.wikimedia.org/T183667#3859873 (10Framawiki) p:05Triage>03Normal [16:56:08] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.) - https://phabricator.wikimedia.org/T171563#3859884 (10Bawolff) On old browsers it is possible to inject scripts int... [17:12:54] (03PS1) 10Clockery: Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) [17:16:42] 10Timeless: References bug - https://phabricator.wikimedia.org/T183669#3859912 (10Roumpf) [17:17:05] can someone tell me how to do a request as a logged in user in Mediawiki Unit tests ? [17:17:25] (03PS1) 10Clockery: Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) [17:17:56] like, I want something like an `AuthenticatedTestCase` so that the tests execute as though $this->getUser() gives the right reply [17:29:06] 10Social-Tools, 10SocialProfile: SocialProfile: UserProfile conditionally runs deprecated ParserLimitReport hook within a ArticleFromTitle hook - https://phabricator.wikimedia.org/T183652#3859935 (10SamanthaNguyen) [18:07:46] (03PS1) 10Ryan10145: Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) [18:09:07] (03PS1) 10Ryan10145: Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) [18:16:47] Albert221 same to me with #mediawiki, there are bad things going on right now on freenode, but I am currently at the dining table :P [18:17:45] But I will definitely move the IRC bouncer and The Lounge in the next 2 days so you won't have any problems when my hoster have problems with OpenVZ ^^ [18:36:12] (03PS1) 10Divadsn: Replace deprecated tag with custom styled
tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) [18:37:31] 10EasyTimeline, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3859959 (10divadsn) Thanks @Daimona, I took your suggestion and adjusted the font-size to match the one from `tt`, also behaves... [18:45:54] 10MediaWiki-General-or-Unknown, 10I18n: Some wikidata labels in Urdu have incorrectly rendered Urdu characters on the mobile site - https://phabricator.wikimedia.org/T183388#3859971 (10BukhariSaeed) I am using chrome, and all mobile users are facing same problem [18:51:16] 10GraphViz: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats - https://phabricator.wikimedia.org/T181926#3806791 (10mwjames) > The SRF devs seem dead against supporting extension registration The extension registration has nothing do with whether you use Composer or not.... [18:52:50] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3859975 (10StevenJ81) Is the SVG logo what is stalling this? [18:55:44] 10GraphViz: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats - https://phabricator.wikimedia.org/T181926#3859976 (10mwjames) > GraphViz no longer working ... In regards to "GraphViz no longer working ...", GraphViz was working relatively fine with version 2.x, now with 3... [18:57:46] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857043 (10Urbanecm) No. In Wiki creations there are too many people involved and it takes some time. Additionaly, a code freeze is right now in effect and it will be released on January... [19:15:12] 10MediaWiki-General-or-Unknown, 10CSS: Replace layout-only span.mw-editButtons-pipe-separator in favor of CSS - https://phabricator.wikimedia.org/T183672#3859983 (10Volker_E) [19:16:56] (03CR) 10VolkerE: [C: 04-1] Add `margin-bottom` for editButtons (EditPage) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) (owner: 10Phantom42) [19:18:37] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3859995 (10Legoktm) >>! In T153505#3859627, @thiemowmde wrote... [19:21:32] (03CR) 10Legoktm: "My plan was that once this was merged, I would use libraryupgrader for the new MediaWiki-CodeSniffer release, triggering most extension te" [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [19:25:27] 10MediaWiki-Core-Tests: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3859996 (10Legoktm) >>! In T183604#3858672, @thiemowmde wrote: > My answer to the question asked is: yes. Why not? > > The more relevant question is: Which tools complain about `@covers` tags that poi... [19:30:32] (03CR) 10Legoktm: [C: 032] "Thanks :(" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [19:32:03] (03CR) 10Legoktm: "There's even a note that says to test the Installer when modifying that module :(" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/388133 (https://phabricator.wikimedia.org/T178028) (owner: 10Jdlrobson) [19:32:23] (03Merged) 10jenkins-bot: Revert "Print styles in Vector are no longer feature flagged" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [19:34:57] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia: Is it possible to exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage? - https://phabricator.wikimedia.org/T183673#3859998 (10Zoglun) [19:36:27] 10MediaWiki-Configuration, 10MediaWiki-Installer, 10Vector, 10Patch-For-Review: No registered builder available for vector. - https://phabricator.wikimedia.org/T183640#3860009 (10Legoktm) 05Open>03Resolved a:03Paladox [19:38:32] 10Readers-Web-Backlog, 10Epic: [EPIC] Print styles - desktop - https://phabricator.wikimedia.org/T154965#3860014 (10Legoktm) [19:40:40] 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3860015 (10Legoktm) [19:42:23] 10MediaWiki-Authentication-and-authorization, 10Security-Core: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420#3860016 (10Anomie) >>! In T183420#3859546, @Tgr wrote: > It is a generic need in the sense that there are many places wh... [19:46:48] 10Design, 10OOjs-UI (OOjs-UI-0.24.1): MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos - https://phabricator.wikimedia.org/T92452#3860017 (10Volker_E) [19:50:36] 10Design, 10OOjs-UI, 10UI-Standardization, 10CSS, and 3 others: Adding 'margin-bottom' for widgets which are part of OOUI HorizontalLayout - https://phabricator.wikimedia.org/T179040#3860018 (10Volker_E) [19:53:02] (03CR) 10Paladox: "Thanks." [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [19:56:53] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3860019 (10Anomie) >>! In T153505#3859627, @thiemowmde wrote:... [20:00:05] 10WMF-Legal, 10Tracking: Copyright license and attribution issues (tracking) - https://phabricator.wikimedia.org/T87268#3860026 (10Anomie) [20:00:07] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 10Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#3860021 (10Anomie) 05Open>03Resolved a:03Anomie This should be resolved... [20:06:20] (03CR) 10Florianschmidtwelzow: [C: 032] Add minus-x to composer test and fix [extensions/Athena] - 10https://gerrit.wikimedia.org/r/400076 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:06:31] (03CR) 10Florianschmidtwelzow: [C: 032] Add minus-x to composer test and fix [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/400077 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:08:08] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/Athena] - 10https://gerrit.wikimedia.org/r/400076 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:08:17] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/400077 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:12:41] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia: Is it possible to exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage? - https://phabricator.wikimedia.org/T183673#3859998 (10Bawolff) [Without committing to doing it] yes, it should be possible to make a special:globall... [20:16:59] Zppix, is there maybe any progress on this Jenkins issue? [20:17:27] (03CR) 10Legoktm: [C: 04-1] [MCR] Introduce BlobStoreFactory (034 comments) [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [20:20:14] legoktm, maybe you are able to do something with the issue with my patches? the repo doesn't have Jenkins set up and because of that patches don't get V+2 [20:20:25] https://gerrit.wikimedia.org/r/#/c/400094/ + https://gerrit.wikimedia.org/r/#/c/400095/ [20:20:57] (03CR) 10Florianschmidtwelzow: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/400094 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [20:21:19] (03CR) 10Florianschmidtwelzow: [V: 032 C: 032] Add minus-x to composer test and fix [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/400095 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [20:21:28] oh! thank you FlorianSW! [20:21:46] Albert221: I would have done what Florian did he [20:21:48] heh* [20:22:00] Albert221: yay, sorry, haven't seen your conversation here :) [20:23:56] 10Phabricator, 10VPS-project-codesearch: Consider adding a way to query https://codesearch.wmflabs.org/search/ from phabricator. - https://phabricator.wikimedia.org/T183608#3860034 (10Legoktm) codesearch does provide an API, but I'm not sure how this would work in practice, since production machines are unabl... [20:24:31] (03CR) 10Florianschmidtwelzow: [C: 032] Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [20:24:49] (03CR) 10Florianschmidtwelzow: [C: 032] Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [20:25:16] 10Phabricator, 10VPS-project-codesearch: Consider adding a way to query https://codesearch.wmflabs.org/search/ from phabricator. - https://phabricator.wikimedia.org/T183608#3860035 (10mmodell) @legoktm: Ah good point. Maybe (some day in a future fantasy world) we could bring codesearch into production? [20:25:44] (03CR) 10Florianschmidtwelzow: [C: 032] Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [20:25:47] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to extension PagesList [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/400101 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [20:25:54] (03CR) 10Florianschmidtwelzow: [C: 032] Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [20:26:26] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to extension MsWikiEditor [extensions/MsWikiEditor] - 10https://gerrit.wikimedia.org/r/400102 (https://phabricator.wikimedia.org/T175794) (owner: 10Clockery) [20:27:40] (03CR) 10jerkins-bot: [V: 04-1] Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [20:28:15] (03CR) 10jerkins-bot: [V: 04-1] Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [20:34:45] (03PS1) 10Phantom42: Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) [20:41:01] (03PS2) 10Phantom42: Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) [20:41:59] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:42:28] (03PS3) 10Phantom42: Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) [20:50:18] (03PS4) 10Phantom42: Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) [20:51:23] (03PS5) 10Phantom42: Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) [20:53:37] 10Phabricator, 10VPS-project-codesearch: Consider adding a way to query https://codesearch.wmflabs.org/search/ from phabricator. - https://phabricator.wikimedia.org/T183608#3860041 (10Legoktm) I'm open to that, but I think it would require re-evaluating the implementation strategy, since the current one is re... [20:53:39] (03PS1) 10Phantom42: Add minus-x to composer test and fix [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/400111 (https://phabricator.wikimedia.org/T175794) [20:56:08] (03PS1) 10SamanthaNguyen: Avoid use of $wgUser global in UserProfilePage [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400112 [20:56:32] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages, 10Regression: Special:Contributions no longer shows contributions by name - problems listing contributions stored with user ID = 0 - https://phabricator.wikimedia.org/T36873#3860045 (10Ebe123) Hein? T179831 hasn't been resolved yet either, without a pa... [20:57:34] (03CR) 10Legoktm: [C: 032] Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:57:44] (03CR) 10Legoktm: [C: 032] Add minus-x to composer test and fix [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/400111 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:59:11] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/400110 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [20:59:28] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/400111 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [21:04:19] (03PS1) 10Phantom42: Add minus-x to composer test and fix [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) [21:08:39] (03PS1) 10Phantom42: Add minus-x to composer test and fix [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/400114 (https://phabricator.wikimedia.org/T175794) [21:27:19] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801#3860055 (10Volker_E) [21:28:16] (03PS8) 10Phantom42: Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) [21:34:45] (03CR) 10Phantom42: Add `margin-bottom` for editButtons (EditPage) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) (owner: 10Phantom42) [21:48:08] (03CR) 10Legoktm: [C: 032] JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [21:48:36] (03PS2) 10Legoktm: JavaScriptMinifier: Improve docs around parsing of regexp literals [core] - 10https://gerrit.wikimedia.org/r/399861 (https://phabricator.wikimedia.org/T75556) (owner: 10Krinkle) [21:49:15] (03CR) 10Legoktm: [C: 032] JavaScriptMinifier: Improve docs around parsing of regexp literals [core] - 10https://gerrit.wikimedia.org/r/399861 (https://phabricator.wikimedia.org/T75556) (owner: 10Krinkle) [21:54:47] (03Merged) 10jenkins-bot: JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [21:57:02] (03Merged) 10jenkins-bot: JavaScriptMinifier: Improve docs around parsing of regexp literals [core] - 10https://gerrit.wikimedia.org/r/399861 (https://phabricator.wikimedia.org/T75556) (owner: 10Krinkle) [22:00:18] (03CR) 10Legoktm: [C: 032] "Unfortunately this doesn't make much of a difference since setContext() is only called after the constructor, so calling getContext() in t" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400112 (owner: 10SamanthaNguyen) [22:02:03] (03Merged) 10jenkins-bot: Avoid use of $wgUser global in UserProfilePage [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400112 (owner: 10SamanthaNguyen) [22:03:07] Hello! Just letting you know that I basically have the same issue as Albert on my patches too: https://gerrit.wikimedia.org/r/#/c/400113/ and https://gerrit.wikimedia.org/r/#/c/400114/ Anyway, it is quite strange that those extensions don't have CI set up even though there were some lint tests declared in `composer.json` [22:05:16] (03CR) 10jenkins-bot: JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [22:14:00] (03PS7) 10BryanDavis: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [22:14:11] (03CR) 10BryanDavis: [C: 032] Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [22:14:18] (03CR) 10jenkins-bot: JavaScriptMinifier: Improve docs around parsing of regexp literals [core] - 10https://gerrit.wikimedia.org/r/399861 (https://phabricator.wikimedia.org/T75556) (owner: 10Krinkle) [22:15:14] (03Merged) 10jenkins-bot: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [22:15:52] (03CR) 10jenkins-bot: Enable Composer for SendGrid role [vagrant] - 10https://gerrit.wikimedia.org/r/400092 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [22:26:04] (03PS1) 10Hashar: Fix dupe python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 [22:26:50] (03PS2) 10Hashar: Fix dupe python-setuptools [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) [22:27:48] (03CR) 10Hashar: "Cause a duplicate definition error on python-setuptools. Fixed by https://gerrit.wikimedia.org/r/400115" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/398705 (https://phabricator.wikimedia.org/T183095) (owner: 10Paladox) [22:36:55] (03CR) 10Legoktm: "We generally try and avoid using inline styles - can we use a class like "mw-timeline-error" and add some CSS for the monospace styling?" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [22:44:59] (03PS2) 10Ryan10145: Added Minus-X Support [extensions/MsLinks] - 10https://gerrit.wikimedia.org/r/400107 (https://phabricator.wikimedia.org/T175794) [22:46:25] 10MediaWiki-Internationalization, 10Patch-For-Review: Removal of mo language codes - https://phabricator.wikimedia.org/T18889#3860066 (10Fomafix) https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry defines ``` %% Type: language Subtag: mo Description: Moldavian Description: Moldo... [22:46:47] (03PS2) 10Ryan10145: Added Minus-X Support [extensions/MsInsert] - 10https://gerrit.wikimedia.org/r/400106 (https://phabricator.wikimedia.org/T175794) [22:47:37] (03CR) 10BryanDavis: "check" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [22:48:44] how is you Eve dinner going? :) [22:48:48] your* [22:49:49] (03CR) 10Hashar: "That one causes a dependency cycle when compiling the catalog with rspec-puppet and enabling the role:centralauth (in addition to the clas" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399565 (https://phabricator.wikimedia.org/T181918) (owner: 10BryanDavis) [22:49:54] Pretty nice. And yours? :) [22:50:24] (03CR) 10Legoktm: [C: 032] "Both https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy and https://developer.mozilla.org/en-US/docs/Web/HTML/Eleme" [core] - 10https://gerrit.wikimedia.org/r/392360 (owner: 10Gergő Tisza) [22:51:51] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860070 (10hashar) [22:51:53] 10MediaWiki-Vagrant, 10Patch-For-Review: Fix default .my.cnf/grants for vagrant user on Stretch - https://phabricator.wikimedia.org/T181918#3860068 (10hashar) 05Resolved>03Open https://gerrit.wikimedia.org/r/399565 causes a dependency cycle when compiling the catalog with rspec-puppet and enabling the role... [22:54:49] (03PS1) 10BryanDavis: apt: better support for `apt-get update` refresh [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400116 [22:54:51] (03PS1) 10BryanDavis: npm: Add guard for Exec['downgrade_npm'] [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400117 [22:54:53] (03PS1) 10BryanDavis: mysql: Use mariadb-server package [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400118 (https://phabricator.wikimedia.org/T51652) [22:54:55] (03PS1) 10BryanDavis: mysql: remove unnecessary -p${mysql::root_password} usage [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400119 (https://phabricator.wikimedia.org/T51652) [22:54:57] (03PS1) 10BryanDavis: php7: remove remaining role::zend references [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400120 (https://phabricator.wikimedia.org/T181915) [22:54:59] (03PS1) 10BryanDavis: composer: fix oscillating file group [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400121 [22:56:02] (03Merged) 10jenkins-bot: Improve documentation of $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/392360 (owner: 10Gergő Tisza) [22:56:45] 10PollNY, 10Social-Tools, 10SocialProfile: SocialProfile: UserProfile conditionally runs deprecated ParserLimitReport hook within a ArticleFromTitle hook - https://phabricator.wikimedia.org/T183652#3860073 (10SamanthaNguyen) [22:56:56] 10PollNY, 10Social-Tools, 10SocialProfile: SocialProfile: UserProfile conditionally runs deprecated ParserLimitReport hook within a ArticleFromTitle hook - https://phabricator.wikimedia.org/T183652#3859486 (10SamanthaNguyen) a:05ashley>03SamanthaNguyen [22:58:03] (03CR) 10BryanDavis: Fix dupe python-setuptools (032 comments) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [22:59:33] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3860076 (10D3r1ck01) Well tested on Cloud VPS and composer enabled for the role. Thanks @bd808 for merging :) [22:59:38] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400122 (https://phabricator.wikimedia.org/T175794) [23:00:12] (03CR) 10BryanDavis: [C: 032] apt: better support for `apt-get update` refresh [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400116 (owner: 10BryanDavis) [23:00:42] (03Merged) 10jenkins-bot: apt: better support for `apt-get update` refresh [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400116 (owner: 10BryanDavis) [23:00:44] (03CR) 10BryanDavis: [C: 032] npm: Add guard for Exec['downgrade_npm'] [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400117 (owner: 10BryanDavis) [23:00:47] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [23:01:11] (03CR) 10BryanDavis: [C: 032] mysql: Use mariadb-server package [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400118 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [23:01:19] (03Merged) 10jenkins-bot: npm: Add guard for Exec['downgrade_npm'] [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400117 (owner: 10BryanDavis) [23:01:40] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers, 10Wikibugs, 10Patch-For-Review: Push Gerrit changes (notifications) to #wiki-dev-africa for some extension - https://phabricator.wikimedia.org/T183573#3860079 (10D3r1ck01) This is working and wikibugs pushes notifications to #wiki-dev-africa.... [23:01:43] (03Merged) 10jenkins-bot: mysql: Use mariadb-server package [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400118 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [23:01:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [23:02:26] (03PS2) 10BryanDavis: php7: remove remaining role::zend references [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400120 (https://phabricator.wikimedia.org/T181915) [23:02:28] (03PS2) 10BryanDavis: composer: fix oscillating file group [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400121 [23:02:30] (03PS2) 10BryanDavis: mysql: remove unnecessary -p${mysql::root_password} usage [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400119 (https://phabricator.wikimedia.org/T51652) [23:02:35] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers, 10Wikibugs, 10Patch-For-Review: Push Gerrit changes (notifications) to #wiki-dev-africa for some extension - https://phabricator.wikimedia.org/T183573#3860081 (10D3r1ck01) 05Open>03Resolved [23:03:20] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3860083 (10D3r1ck01) 05Open>03Resolved [23:03:24] (03CR) 10BryanDavis: [C: 032] php7: remove remaining role::zend references [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400120 (https://phabricator.wikimedia.org/T181915) (owner: 10BryanDavis) [23:03:45] (03CR) 10BryanDavis: [C: 032] composer: fix oscillating file group [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400121 (owner: 10BryanDavis) [23:03:58] (03Merged) 10jenkins-bot: php7: remove remaining role::zend references [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400120 (https://phabricator.wikimedia.org/T181915) (owner: 10BryanDavis) [23:04:16] (03Merged) 10jenkins-bot: composer: fix oscillating file group [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400121 (owner: 10BryanDavis) [23:04:38] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860090 (10bd808) [23:04:40] 10MediaWiki-Vagrant, 10Patch-For-Review: Make php7 the default PHP on stretch - https://phabricator.wikimedia.org/T181915#3860089 (10bd808) 05Open>03Resolved [23:04:56] (03CR) 10jenkins-bot: Improve documentation of $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/392360 (owner: 10Gergő Tisza) [23:06:30] oh no :((( [23:06:34] GCI website sucks [23:06:41] it doesn't support emojis in comments :( [23:08:38] (03CR) 10BryanDavis: thumbor: `nproc` => $::processorcount (031 comment) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400098 (https://phabricator.wikimedia.org/T183462) (owner: 10Hashar) [23:09:10] (03PS2) 10BryanDavis: hadoop: fix Resource type not found: BLOCK [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400097 (owner: 10Hashar) [23:09:17] (03CR) 10BryanDavis: [C: 032] hadoop: fix Resource type not found: BLOCK [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400097 (owner: 10Hashar) [23:09:38] d3r1ck, isn't that strange that I've received 4 times same email? https://i.imgur.com/gkTldFa.png it's all the same [23:09:52] (03Merged) 10jenkins-bot: hadoop: fix Resource type not found: BLOCK [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400097 (owner: 10Hashar) [23:10:57] (03CR) 10D3r1ck01: "Some trailing spaces/tab issues, please remove." (035 comments) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400122 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [23:11:30] Strange indeed :( [23:11:37] Albert221: I've reviewed your patch [23:11:43] Some house cleaning to do :D [23:12:38] (03PS4) 10Legoktm: Allow fallbacks for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [23:14:15] (03PS5) 10Legoktm: Allow fallbacks for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [23:14:46] (03CR) 10Legoktm: [C: 031] "PS4-5: Improved commit message and added release notes. LGTM, +2 if those changes are OK with you." [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [23:15:02] (03CR) 10BryanDavis: [C: 04-1] Fix dupe python-setuptools (031 comment) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400115 (https://phabricator.wikimedia.org/T183095) (owner: 10Hashar) [23:15:21] thanks for the review legoktm [23:15:26] np [23:15:45] going to fix it now [23:16:03] (03CR) 10D3r1ck01: "recheck" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [23:16:23] d3r1ck this one file really lacks ton of CS fixes [23:16:24] let me fix it [23:16:46] (03CR) 10D3r1ck01: "recheck" [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/400114 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [23:18:38] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thanks Phantom42" [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/400114 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [23:19:01] d3r1ck, this doesn't follow Wikimedia CS guidelines? [23:21:28] Albert221: I think it does [23:21:34] Just the trailings :) [23:22:22] no, look, no spaces surrounding parameters, no spaces around keywords like "if", too many empty phpDoc lines etc [23:22:35] (03PS5) 10Addshore: [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) [23:22:41] legoktm: ^^ [23:23:24] It would be great to get that and possibly https://gerrit.wikimedia.org/r/#/c/399856/ merged asap so that I can keep testing on beta without hiting those exceptions :) [23:23:28] Albert221: Hmmm... Looking again! [23:23:51] you know what, I'll just throw phpcs here [23:23:53] what do you think? [23:23:55] Albert221: You are correct [23:23:59] (03PS1) 10Legoktm: Add @covers tags to CategoriesRdfTest [core] - 10https://gerrit.wikimedia.org/r/400123 [23:24:01] Albert221: Do that :) [23:24:06] Let me check the other files [23:24:13] Maybe the whole extension can be affect? [23:24:23] Which extension is that by the way? [23:24:28] addshore: sure, wanna look at https://gerrit.wikimedia.org/r/400123 ? [23:24:47] *looks* [23:24:50] TweetANew extension? Hmmm... Pulling up MW docs now [23:24:54] yes, whole ext lacks of CS [23:25:57] Albert221: Okay! You are up, fire up phpcs :D [23:26:13] (03PS1) 10SamanthaNguyen: Replace deprecated ParserLimitReport hook with ParserLimitReportPrepare [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400124 (https://phabricator.wikimedia.org/T183652) [23:26:33] It's quiet a huge extension with lots of docs: https://www.mediawiki.org/wiki/Extension:TweetANew [23:27:49] (03CR) 10Addshore: [C: 032] Add @covers tags to CategoriesRdfTest [core] - 10https://gerrit.wikimedia.org/r/400123 (owner: 10Legoktm) [23:28:18] addshore: do we still need a MediaWikiServices::getBlobStore() / _SqlBlobStore now? [23:28:56] (03PS1) 10BryanDavis: mysql: break Mysql::User['vagrant'] dependency cycle [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400125 (https://phabricator.wikimedia.org/T181918) [23:30:10] So, we can probably kill them, but again I'd probably rather do that in Jan / after the next deploy [23:30:20] ok [23:30:45] d3r1ck: thank you for reviewing my patch! [23:31:01] Right now the less I do the easier https://wikitech.wikimedia.org/wiki/User:Addshore/MCR_Revert will be :P [23:31:06] (03CR) 10VolkerE: [C: 032] Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) (owner: 10Phantom42) [23:31:23] (03CR) 10Legoktm: [C: 032] [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [23:31:34] (03CR) 10D3r1ck01: "@Bryan, seems this extension is not in layout.yaml, so Jenkins can run here: https://github.com/wikimedia/integration-config/blob/master/z" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [23:31:52] legoktm: If you have some free time, it would be great if you take a look too and possibly merge if everything is okay: https://gerrit.wikimedia.org/r/#/c/400113/ and https://gerrit.wikimedia.org/r/#/c/400114/ :) [23:31:54] (03CR) 10D3r1ck01: "*can't" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [23:32:11] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thanks for the work Phantom42." [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/400113 (https://phabricator.wikimedia.org/T175794) (owner: 10Phantom42) [23:32:25] also, merry christmas (nearly) legoktm :D [23:32:31] Phantom42: You are welcome :) [23:32:45] legoktm: Maybe a quick review and merge could come in handy? [23:33:08] legoktm: https://gerrit.wikimedia.org/r/#/c/400113/, https://gerrit.wikimedia.org/r/#/c/400114/ [23:33:16] it's on my list :) [23:33:24] addshore: :D you too [23:33:25] Perfect! thanks :) [23:33:33] (03Merged) 10jenkins-bot: Add @covers tags to CategoriesRdfTest [core] - 10https://gerrit.wikimedia.org/r/400123 (owner: 10Legoktm) [23:33:37] I'm going to go and wrap some stuf and head to bed :0 [23:34:10] addshore, legoktm, don't you think a sprint should be done on adding extensions that are not in zuul? [23:34:30] I mean Jenkins not running on some extensions is not cool, maybe we can bring in this as a GCI task? [23:34:41] With multiple instances so students can work on? [23:34:45] andre__: What do you think? [23:34:56] (03CR) 10Legoktm: [C: 032] [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [23:34:58] (03PS1) 10SamanthaNguyen: Replace deprecated ParserLimitReport hook with ParserLimitReportPrepare [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/400126 (https://phabricator.wikimedia.org/T183652) [23:35:14] addshore: anything else? [23:35:39] d3r1ck: yes, all extensions should be in zuul, should be fine as a GCI task. [23:35:50] d3r1ck there's a ton of work with this... [23:35:51] actually it would be nice if we had a regular report for this [23:35:59] maybe a toolforge tool [23:36:04] Albert221: With what? [23:36:09] I think I'll create s and make a Phab task to get rid of them [23:36:32] Albert221: Okay! [23:36:54] legoktm: yeah! Manually finding them is hell lot of work :( [23:37:06] d3r1ck: [23:37:06] $ phpcs | wc -l [23:37:06] 484 [23:37:07] :| [23:37:21] Wooooaaaahhhh! [23:37:52] legoktm: Does any tool exist? Or maybe we could find a work around? [23:38:11] not that I'm aware of [23:38:38] Phantom42: legoktm will merge your patches in a bit :) [23:38:52] d3r1ck: Okay. No rush here :) [23:38:57] Phantom42: Sure :) [23:38:58] (03Merged) 10jenkins-bot: Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) (owner: 10Phantom42) [23:39:16] legoktm: Hmmm... Okay! Should we go the manual way? Maybe you can help me on this? [23:40:00] (03Merged) 10jenkins-bot: [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [23:41:22] We can mimic what you did for minus-x ticket [23:41:58] legoktm: In fact, let me go ahead and create a ticket for this at once. [23:42:57] (03Merged) 10jenkins-bot: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [23:44:53] (03PS1) 10Legoktm: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 [23:48:24] (03CR) 10jenkins-bot: Add @covers tags to CategoriesRdfTest [core] - 10https://gerrit.wikimedia.org/r/400123 (owner: 10Legoktm) [23:53:03] legoktm: Started this: https://phabricator.wikimedia.org/T183674 [23:53:32] I'll work on this tomorrow and fill it up. Also, will ping andre__ on if it can be imported to GCI anytime soon :) [23:57:05] (03CR) 10jenkins-bot: Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) (owner: 10Phantom42)