[00:01:05] tbh I tried fixing it locally for several hours, heck it, Jenkins and I make good friends [00:01:52] in vendor/etsy/phan/src/Phan/Bootstrap.php line 56, if you comment out set_error_handler i think it would make it forwards compatible [00:02:47] sorry, you spent so much time on that. Its my fault for using outdated dependencies. Its next on my list of things to fix with the plugin [00:04:59] (03PS4) 10Albert221: Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (https://phabricator.wikimedia.org/T182448) [00:05:40] no problem bawolff, ^that patch looks like is final [00:05:44] it is not WIP [00:06:00] 10TemplateStyles: Clarify how content-like messages should be handled - https://phabricator.wikimedia.org/T183603#3858398 (10Tgr) [00:06:18] Woo [00:06:39] woah, it is Jerkins not Jenkins :O [00:06:50] whole life in untruth :O [00:08:22] fingers crossed bawolff [00:09:00] Its only jerkins when its being a jerk [00:09:17] XD [00:09:26] is it true genesis or just a joke? [00:09:49] jenkins-bot [00:09:49] 1:06 AM [00:09:49] ↩ [00:09:49] Patch Set 4: Verified+2 [00:09:50] Main test build succeeded. [00:09:50] 10Wikipedia-Android-App-Backlog, 10Reading Epics (Synchronized Reading Lists): Show messages when limits to articles in a reading list or number of lists is reached - https://phabricator.wikimedia.org/T180230#3858409 (10RHo) [00:09:57] do you see that bawolff? it passed [00:10:02] take a look please [00:10:05] whee [00:10:23] looking [00:10:35] but why wikibugs hasn't posted about Jenkins here? o_O [00:11:08] Wikibugs only posts for failed tests [00:11:18] didn't know that! [00:11:33] on the idea if it fails you have to do something, if it passes its just spam [00:11:47] it's spam anyway xD [00:13:06] There seems to be quite a lot of style changes related to commas? [00:13:08] 10MediaWiki-Core-Tests: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3858410 (10Legoktm) [00:13:30] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3858427 (10Legoktm) [00:13:32] (03CR) 10Gergő Tisza: [C: 032] Make it possible to install existing python modules "editably" [vagrant] - 10https://gerrit.wikimedia.org/r/397617 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:14:20] Generally its better to avoid style changes in the same patch as functional changes, as it makes it more difficult to see what had actually changed [00:14:35] (03CR) 10Gergő Tisza: [C: 032] Check out both ores and revscoring as editable modules [vagrant] - 10https://gerrit.wikimedia.org/r/397618 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:14:42] Just for future reference :) [00:14:48] (03Merged) 10jenkins-bot: Make it possible to install existing python modules "editably" [vagrant] - 10https://gerrit.wikimedia.org/r/397617 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:15:35] (03CR) 10jenkins-bot: Make it possible to install existing python modules "editably" [vagrant] - 10https://gerrit.wikimedia.org/r/397617 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:15:40] (03Merged) 10jenkins-bot: Check out both ores and revscoring as editable modules [vagrant] - 10https://gerrit.wikimedia.org/r/397618 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:16:19] (03CR) 10jenkins-bot: Check out both ores and revscoring as editable modules [vagrant] - 10https://gerrit.wikimedia.org/r/397618 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:17:58] bawolff, I thought of that, but in my previous tasks I was told to fix CS on the occassion so I'm confused :| [00:18:05] I mean I understand and second your opinion [00:18:57] 10MediaWiki-Vagrant, 10Scoring-platform-team, 10Wikilabels: wikilabels vagrant role errors out on DB permissions - https://phabricator.wikimedia.org/T183605#3858433 (10Tgr) [00:19:14] Also another sign of being a true mw developer: reviewers give you conflicting and annoying advice ;) [00:22:49] lol [00:23:28] :D [00:25:32] (03CR) 10Gergő Tisza: "> This doesn't work beyond the 64k buffer size. Try using a couple" [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) (owner: 10Gergő Tisza) [00:25:47] * bawolff is going to run this against mediawiki core to check to see if ot causes any large amounts of false positives [00:26:31] * Albert221 is crossing his fingers. [00:26:52] (03PS3) 10Divadsn: Fix infobox styles to work well with multiple column infobox rows [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399866 (https://phabricator.wikimedia.org/T168716) [00:27:47] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Split reading lists with more articles than the limit per list into multiple lists - https://phabricator.wikimedia.org/T180229#3858444 (10RHo) [00:28:12] This usually takes about three minutes [00:28:26] Albert221 for god sake, you aren't tired from that concert? :D [00:28:49] divadsn: me? no. my legs and back and THROAT? yes [00:29:03] I laughed when I said something aloud xD my voice is funny now [00:29:23] * divadsn asks himself about the point of his life XD [00:29:33] divadsn remember my friend. open source doesn't sleep [00:29:36] read it with Pasha's voice [00:29:44] I hope you know Pasha? [00:29:44] Pasha xD [00:30:06] Yes of course, I just went for him to Tauron Arena last summer when Cracow had the first CS:GO major in the city [00:30:19] nice [00:30:27] I just spend the last 4 hours making open-source t-shirt designs, ended up ordering one for myself :D [00:31:01] my school has poligraphical lab, we can print tshirt on it too, not commercially of course [00:31:26] And you're saying it to me after I've done the payment? Sssssh xD [00:31:48] You could make me one and I would pay you for the parcel and T-Shirt 😆 [00:32:30] (03CR) 10MaxSem: [C: 04-1] "Your example doesn't block because stdout doesn't exceed buffer size. Try" [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) (owner: 10Gergő Tisza) [00:32:58] (03CR) 10jerkins-bot: [V: 04-1] Fix infobox styles to work well with multiple column infobox rows [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399866 (https://phabricator.wikimedia.org/T168716) (owner: 10Divadsn) [00:33:08] 10Epic, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3751114 (10Sharvaniharan) Screenshots :{F12000525} {F12000524} {F12000523} [00:33:12] Poligraphic? [00:33:15] Still failing, dumb less... [00:33:22] don'tknow if it was a valid word [00:33:36] polygraphic [00:33:48] Google Translate says: printing lab D: [00:33:49] (03PS1) 10Sharvaniharan: Expose default list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) [00:33:57] "Warning: Task "stylelint:all" failed. Use --force to continue." oh wew, jenkins-bot is too sensitive :P [00:34:09] 44:10 ✖ Unexpected whitespace at end of line no-eol-whitespace [00:34:25] (03CR) 10jerkins-bot: [V: 04-1] Expose default list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) (owner: 10Sharvaniharan) [00:34:31] Albert221 and you trust GTranslate? ;P [00:34:40] no, that's why I put "D:" [00:35:11] (03PS4) 10Divadsn: Fix infobox styles to work well with multiple column infobox rows [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399866 (https://phabricator.wikimedia.org/T168716) [00:35:12] 10Epic, 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3858451 (10Sharvaniharan) @Rho @Dbrant I feel Part B should be a separate tic... [00:35:24] When i looked it up it meant done with a polygraph [00:35:29] Tip: We are in 2017 😱 [00:35:38] Which confused me [00:35:57] Now I am wondering if anyone see my emojis :D [00:36:02] once when I was on Amazon's conference they showed us how they taught convolutional neural network how to translate from english to deutsch and it was *very* accurate given the fact that it was learning 500 A4 pages of some book and using 16xGPU it took like 2 minutes [00:36:08] it will be 2018 soon :) [00:36:28] but i think you mean the old definition of polygraph (ie a machine to copy stuff. Not a lie detector) [00:36:29] ^^I think that sentence is so bad in English :( [00:36:57] Albert221 english to german and vice versa translations aren't really hard tho :P [00:37:17] but it was done by AI in two minutes [00:37:17] i was trying to figurd out how to make tshirts out of a lie detector ;) [00:37:18] I cheat in English class by translating words from Polish to German and then to English :D [00:37:44] * divadsn wuts bawolff [00:37:48] bawolff, how are the things going? [00:37:48] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Plan and organize a workshop around Google Code-in for ChickTech b/w December 9th-10th, 2017 - https://phabricator.wikimedia.org/T179889#3858453 (10srishakatux) [00:38:19] isn't it 6:38AM in your location? [00:38:47] So it found 11 instances of double escaping in core, im looking to see how accurate that is [00:38:56] no, its 7:38 pm [00:39:26] aren't you UTC+5? [00:39:35] Albert221: https://imgur.com/a/MxGtF [00:39:48] it's MINUS five, okay! [00:39:59] ^^ [00:40:01] (03CR) 10Sharvaniharan: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) (owner: 10Sharvaniharan) [00:40:05] that's a HUUUGE difference [00:40:13] 10 hours exactly :P [00:40:14] Timezones are confusing [00:40:25] + means subtraction [00:40:35] divadsn I've just thought from the Mentors wikipage that bawolff was UTC+5 [00:40:47] my timezone is not confusing, i am right in the center :) [00:40:50] (03CR) 10jerkins-bot: [V: 04-1] Expose default list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) (owner: 10Sharvaniharan) [00:40:58] bawolff ^^ [00:40:59] and it's true! bawolff, you have UTC+5 in here: https://www.mediawiki.org/wiki/Google_Code-in/2017 [00:41:08] I may have wrote +5 instead of -5. I can never keep it straight [00:41:50] I corrected that ^^ [00:41:55] what's the point of halftimezones like UTC+5:30? [00:42:08] About half of the double escaping is from the total messed upness of FormatMetada. So looks like thats working :) [00:42:23] to make newfoundland feel better [00:42:24] bawolff yaaaay! [00:42:29] about itself [00:42:33] Albert221: there are locations that have picked the :30 offset for "reasons" [00:42:47] what exactly are those *reasons*? [00:42:57] Albert221 India has a weird timezone too [00:43:01] +5:30 is all of India [00:43:04] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Document steps to organizing a workshop around Google Code-in - https://phabricator.wikimedia.org/T179890#3858454 (10srishakatux) **Pros:** 10 participants including students and volunteers had a good time, they seemed engaged. 5 of them were student... [00:43:04] Ask Google I guess ^^ [00:43:17] divadsn let my uncle sleep [00:43:21] Venezula did it to give the finger to america and britian i think [00:43:29] Albert221: https://www.mnn.com/lifestyle/arts-culture/questions/why-are-some-countries-30-minutes-off-the-global-time-zone-grid [00:43:49] * paladox wonders what britian is? :) [00:44:08] "All of China, which spans an impressive five time zones, has the same time, which is UTC +8 hours." I respect that [00:44:18] in canada, it was like the catch phrase of cbc to say "and half an hour later in Newfoundland" [00:44:18] Albert221 lmao [00:44:38] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Plan and organize a workshop around Google Code-in for ChickTech b/w December 9th-10th, 2017 - https://phabricator.wikimedia.org/T179889#3858455 (10srishakatux) **Pros:** 10 participants including students and volunteers had a good time, they seemed... [00:45:01] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Plan and organize a workshop around Google Code-in for ChickTech b/w December 9th-10th, 2017 - https://phabricator.wikimedia.org/T179889#3858456 (10srishakatux) [00:45:01] https://en.wikipedia.org/wiki/Indian_Standard_Time [00:45:06] 10Epic, 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3858457 (10RHo) >>! In T180239#3858451, @Sharvaniharan wrote: > @Rho @Dbrant... [00:45:32] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Plan and organize a workshop around Google Code-in for ChickTech b/w December 9th-10th, 2017 - https://phabricator.wikimedia.org/T179889#3739432 (10srishakatux) 05Open>03Resolved [00:45:33] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Growing the MediaWiki Technical Community - https://phabricator.wikimedia.org/T183318#3858459 (10Quiddity) [00:46:10] Looks like the British Raj picked +5:30 for them and its never been changed [00:46:21] bd808 :joy: [00:46:36] Oh lmao, The Lounge failed formatting my message 😂 [00:47:00] (03CR) 10Gergő Tisza: [C: 031] ApiMobileView: Disable 'deduplicateStyles' ParserOutput::getText() transformation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/393283 (https://phabricator.wikimedia.org/T160563) (owner: 10Anomie) [00:47:02] :joy: [00:47:08] 😂 [00:47:25] 10Epic, 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3858460 (10Sharvaniharan) Thanks @RHo . also just now noticed the image missin... [00:48:08] bawolff, keep me up to date :) [00:48:19] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Plan and organize a workshop around Google Code-in for ChickTech b/w December 9th-10th, 2017 - https://phabricator.wikimedia.org/T179889#3858463 (10srishakatux) [00:48:22] (03CR) 10Brian Wolff: [C: 032] Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (https://phabricator.wikimedia.org/T182448) (owner: 10Albert221) [00:48:26] Just some off-topic question here, on Wikipedia when I would write an article about something I'm affiliated with, the article would be removed probably right? Just asking for a friend :D [00:48:50] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Document steps to organizing a workshop around Google Code-in - https://phabricator.wikimedia.org/T179890#3858462 (10srishakatux) 05Open>03Resolved [00:48:52] 10Phabricator: Redesign Phabricator login page: LDAP login too prominent; position of MediaWiki SUL login not prominent enough - https://phabricator.wikimedia.org/T862#3858466 (10mmodell) [00:48:53] WP:COI has info on that [00:48:55] 10Phabricator, 10Patch-For-Review: Make the phabricator OAuth login UI more prominent - https://phabricator.wikimedia.org/T963#3858464 (10mmodell) 05Open>03Resolved a:03mmodell [00:49:15] bawolff, oh, sweet! [00:49:55] (03Merged) 10jenkins-bot: Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (https://phabricator.wikimedia.org/T182448) (owner: 10Albert221) [00:50:18] ❤️ [00:50:26] Albert221: so, how would you rate the difficulty of that task? It was my attempt to find slightly harder tasks for gci [00:50:44] Do you think that was too hard? Too easy? Other opinions? [00:50:49] for me or objectively? [00:50:50] bawolff, hmm right, so basically you shouldn't do that, even when you try to write it objectively without any comparison? [00:50:53] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Embracing Open Source Software - https://phabricator.wikimedia.org/T183319#3858468 (10Quiddity) [00:51:53] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Embracing Open Source Software - https://phabricator.wikimedia.org/T183319#3850032 (10Quiddity) [00:52:12] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3858470 (10Quiddity) [00:52:13] divadsn: probably not. But you can do something like write a draft and ask an experianced contributor to turn it into a real article if they think its appropriate [00:52:27] 10Wikipedia-Android-App-Backlog, 10Reading Epics (Synchronized Reading Lists): Provide an option to cancel merging locally saved reading list articles when logging in - https://phabricator.wikimedia.org/T180236#3858471 (10RHo) [00:52:43] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183315#3858472 (10Quiddity) [00:52:58] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Supporting Third-Party Use of MediaWiki - https://phabricator.wikimedia.org/T183312#3858473 (10Quiddity) [00:53:01] in particular, be very careful if you are being paid by the other org, as that is a hot button issue [00:53:39] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture - https://phabricator.wikimedia.org/T183313#3858475 (10Quiddity) [00:53:41] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Next Steps for Languages and Cross Project Collaboration - https://phabricator.wikimedia.org/T183314#3858476 (10Quiddity) [00:53:43] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Advancing the Contributor Experience - https://phabricator.wikimedia.org/T183317#3858477 (10Quiddity) [00:54:01] its usually ok to correct blatent errors as long as you disclose your conflict of interest (in edit summary and user page) [00:54:12] * bawolff not actually a wikipedian [00:54:31] Nah, my friend would rather write an article about our open-source project, which has gained a lot of attention and he would like to write there some facts and the history on how the project was born, as he and me created blog posts where we have written about our journey ^^ [00:54:46] bawolff, you want my subjective opinion or objective? [00:55:07] Albert221: either is fine [00:55:22] But I can tell him to leave it as a draft, I mean some Wikipedian should probably know our project, especially when it's someone which is using Android and is into Launchers :D [00:55:59] subjectively that task involved just more effort than the other ones I did and wasn't hell'a'repetitive like some of my previous were, nice experience; objectively, it was I think ideally between the border of too hard [00:56:12] divadsn: that would probably be discouraged, although the people at #wikipedia might be able to provide better advice [00:57:02] * divadsn goes straight into the DM, ehh, channel :D [00:57:24] divadsn: whatever your friend does, just make sure not to hide the affiliation, as if people think your hiding a coi things tend to go bad [00:58:01] also, unless your open source project is fairly famous, it may fail wikipedia notability guidelines [00:58:43] I think the project is quite notable, my edit on the list hasn't failed yet, and the project is receiving huge press coverage too [00:59:03] divadsn: read also [[WP:NSOFT]] [00:59:08] We even got featured a whole month on the GitHub trending page :D [00:59:16] #offtop: fun fact: today after concert when I was ordering a kebab, some random guy confused break with accellerate pedals and instead of stopping to park the car he destroyed part of the wall of kebab shop [00:59:29] wow [00:59:31] and front of his Audi too [01:00:27] Albert221: glad you enjoyed it [01:00:31] Albert221 typical in Poland I guess :DD [01:00:59] (03CR) 10Gergő Tisza: [C: 031] Deduplicate embedded style rules [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/393285 (https://phabricator.wikimedia.org/T168333) (owner: 10Anomie) [01:01:15] (03CR) 10Kaldari: [C: 04-1] "A few suggestions. No idea why the QUnit test is failing. Would be good to look at the screenshot it creates if you can find it." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [01:01:17] bawolff not that I laugh of it, I just used "fun fact" out of a habit [01:01:53] I meant im glad you enjoyed the task. Not the car crash :p [01:02:23] 10Wikimedia-Hackathon-2017-Organization, 10Developer-Relations (Oct-Dec 2017), 10Goal: Retain at least 10% of newcomers at the Wikimedia Hackathon 2017 - https://phabricator.wikimedia.org/T163440#3858478 (10srishakatux) [01:02:39] ohhhh, nevermind xD [01:02:43] https://photos.app.goo.gl/fT97AF75Eo5DNjGc2 [01:03:00] unfortunately quality of the video is.... really low [01:03:49] It can be difficult to find larger tasks that arent repetitive but at the same time predictable how difficult it is without actually doing it [01:04:00] Atleast it's not so bad tho, could be much more worse Albert221 ;) [01:04:23] divadsn he could drive onto kebab and it wouldn't be fun for us :| [01:04:52] bawolff, yesterday I was searching long for a task and I picked up that CSS task which is kinda hard to replicate, but easier to fix [01:04:58] (03CR) 10Kaldari: [C: 04-1] Convert Preferences class into PreferencesFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [01:05:27] Albert221 remember that attack at a kebab last year or so? [01:05:37] yes [01:05:50] Guess i need to come up with more tasks, all mine are basically completed [01:05:54] don't remember details tho [01:06:19] bawolff, that's good! it means that you did great job finding perfect tasks for us, students :) [01:06:57] bawolff if I can propose something, tasks related to making some parts of UI into OOUI are fine for me, could be same for other students [01:07:28] btw correct my english if you can, I really think that I'm making hell of mistakes now :/ [01:07:36] I think i have one task open + the multiple instance one that will never end [01:07:55] And some PHP tasks which aren't only replacing some deprecated stuff :^) [01:08:12] 10Security-Team, 10phan-taint-check-plugin: Experiment using phan for static analysis - https://phabricator.wikimedia.org/T181660#3858491 (10Albert221) [01:08:15] i dont really know which parts of the interface need ooui-ifying [01:08:16] 10Security-Team, 10phan-taint-check-plugin, 10Google-Code-in-2017, 10Patch-For-Review: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3858490 (10Albert221) 05Open>03Resolved [01:08:37] bawolff there was a "family" of tasks related to OOUI afair [01:08:39] on phab [01:09:26] let me find it [01:09:32] 10Wikipedia-Android-App-Backlog, 10Reading Epics (Synchronized Reading Lists): Provide an option to cancel keep or clear reading list articles on device when logging out - https://phabricator.wikimedia.org/T183607#3858492 (10RHo) [01:09:47] Anyway guys, I need to go to bed, I think my parents are awake again ^^" [01:09:50] 10Wikipedia-Android-App-Backlog, 10Reading Epics (Synchronized Reading Lists): Provide an option to cancel merging locally saved reading list articles when logging in - https://phabricator.wikimedia.org/T180236#3751035 (10RHo) [01:09:58] Good night or afternoon or whatever :) [01:10:07] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Provide an option to cancel merging locally saved reading list articles when logging in - https://phabricator.wikimedia.org/T180236#3751035 (10RHo) [01:10:26] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Provide an option to cancel keep or clear reading list articles on device when logging out - https://phabricator.wikimedia.org/T183607#3858492 (10RHo) [01:10:51] bawolff: https://phabricator.wikimedia.org/T107037 [01:10:58] divadsn good night! [01:11:02] Some of the ooui tasks have hidden gotchas that im not really aware of [01:11:45] :/ [01:11:48] brb [01:12:48] Special:edittags and special:import seem like the likeliest candidates for ooui [01:12:59] out of that list [01:19:38] 10Google-Code-in-2017, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), 10WorkType-NewFunctionality: Long press on find in page up / down arrows should advance to first / last match - https://phabricator.wikimedia.org/T103952#3858509 (10Albert221) 05Open>03Resolved [01:22:27] 10Phabricator, 10VPS-project-codesearch: Consider adding a way to query https://codesearch.wmflabs.org/search/ from phabricator. - https://phabricator.wikimedia.org/T183608#3858510 (10mmodell) [01:24:11] 10Wikimedia-Hackathon-2017-Organization, 10Developer-Relations (Oct-Dec 2017), 10Goal: Retain at least 10% of newcomers at the Wikimedia Hackathon 2017 - https://phabricator.wikimedia.org/T163440#3858521 (10srishakatux) Out of 84 participants to whom emails were sent, 11 responded. Out of the 11, two never m... [01:26:30] (03PS1) 10Albert221: Replace MediaWiki links with parameters [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/399974 (https://phabricator.wikimedia.org/T59181) [01:27:47] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [QA only] Article saved to a reading list whilst offline should be synced when online - https://phabricator.wikimedia.org/T183609#3858523 (10RHo) [01:28:20] 10Developer-Relations (Oct-Dec 2017), 10Goal: Creation of a short term plan to improve outreach and increase retention - https://phabricator.wikimedia.org/T176488#3858536 (10srishakatux) Doc that only DevRel's have access to right now > https://docs.google.com/document/d/1PLcwags540H--0K147LWT4kRDbwHk748dP51C0... [01:37:18] tgr, you there? [01:37:30] (03PS2) 10Albert221: Replace MediaWiki links with parameters [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/399974 (https://phabricator.wikimedia.org/T59181) [01:37:36] Albert221: o/ [01:38:03] tgr, I've fixed what you mentioned :) https://phabricator.wikimedia.org/T59181 that unresolved tasks was driving me crazy [01:38:20] task* [01:40:19] cool [01:40:35] (03CR) 10Gergő Tisza: [C: 032] Replace MediaWiki links with parameters [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/399974 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [01:41:26] 10Wikimedia-Hackathon-2017-Organization, 10Developer-Relations (Oct-Dec 2017), 10Goal: Retain at least 10% of newcomers at the Wikimedia Hackathon 2017 - https://phabricator.wikimedia.org/T163440#3858539 (10srishakatux) p:05High>03Normal [01:41:55] tgr thanks [01:42:10] (03Merged) 10jenkins-bot: Replace MediaWiki links with parameters [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/399974 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [01:42:13] thanks for writing the patch! [01:42:37] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, and 2 others: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3858541 (10Albert221) 05Open>03Resolved [01:43:37] bawolff, would you mind taking a look here? https://gerrit.wikimedia.org/r/#/c/395148/ [01:44:18] Reedy ping [01:45:32] d3r1ck ping? :D [01:46:40] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow manual refreshing of synced reading lists - https://phabricator.wikimedia.org/T183610#3858542 (10RHo) [01:50:43] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) [01:51:13] Zppix ping? [01:54:33] (03PS1) 10Albert221: Add minus-x to composer test and fix [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) [01:54:56] Im sorry, but i probably cant look at it tonight [01:55:35] okay okay [01:56:02] Albert221: pomg [01:56:06] Albert221: pong even [01:56:41] Zppix I've added you to two Gerrit patches :) [01:56:42] easy ones [01:57:07] Ok [01:57:47] (03CR) 10Zppix: [C: 031] "LGTM" [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [01:58:15] (03CR) 10Zppix: [C: 031] "LGTM" [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [02:06:34] isn't tomorrow exactly half of the GCI passing? [02:07:44] okay, I go to sleep, good night :) [02:11:52] (03PS6) 10Gergő Tisza: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) [02:12:26] (03CR) 10Gergő Tisza: "OK. I still don't have much idea what I am doing but this seems to work :)" [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) (owner: 10Gergő Tisza) [02:20:12] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3858564 (10BukhariSaeed) {F12001776} The first syllable is broken/unable to connect to next properly. Like if you look at example in this screenshot, you can see that first character is not connected while re... [02:34:19] 10MediaWiki-Page-protection, 10JavaScript, 10Security-General: Implement better default protection model for JS files that are not in MediaWiki namespace - https://phabricator.wikimedia.org/T171563#3858565 (10Mattflaschen-WMF) [02:37:19] 10MediaWiki-Page-protection, 10JavaScript, 10Security-General: Implement better default protection model for JS files that are not in MediaWiki namespace - https://phabricator.wikimedia.org/T171563#3858566 (10Mattflaschen-WMF) [02:37:36] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review, 10Wikimedia-log-errors: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - https://phabricator.wikimedia.org/T75556#3858567 (10Od1n) Indeed, the error happens only on invalid input. Still, there is... [02:41:48] 10MediaWiki-Page-protection, 10JavaScript, 10Security-General: Implement better default protection model for JS files that are not in MediaWiki namespace - https://phabricator.wikimedia.org/T171563#3858568 (10Mattflaschen-WMF) >>! In T171563#3469057, @Schnark wrote: > Instead, I'd like to propose that JS/CSS... [02:43:12] 10MediaWiki-Page-protection, 10JavaScript, 10Security-General: Implement better default protection model for JS files that are not in MediaWiki namespace - https://phabricator.wikimedia.org/T171563#3468878 (10Bawolff) >>! In T171563#3469057, @Schnark wrote: > Whether a shared JS is "critical" or not does not... [02:43:51] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Implement better default protection model for JS files that are not in MediaWiki namespace - https://phabricator.wikimedia.org/T171563#3858571 (10Bawolff) [02:44:41] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Implement better default protection model for JS files that are not in MediaWiki namespace - https://phabricator.wikimedia.org/T171563#3858572 (10Mattflaschen-WMF) [02:45:11] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS (no project namespace, etc.) - https://phabricator.wikimedia.org/T171563#3468878 (10Mattflaschen-WMF) [02:46:39] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS (no project namespace, etc.) - https://phabricator.wikimedia.org/T171563#3468878 (10Mattflaschen-WMF) I've edited the description to use @Schnark's prop... [02:46:45] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security-General: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.) - https://phabricator.wikimedia.org/T171563#3858575 (10Mattflaschen-WMF) [02:54:29] (03PS2) 10Evad37: Change `pagemisc` portlet to `cactions` [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399783 (https://phabricator.wikimedia.org/T181362) [03:00:00] 10Security-Team, 10Gadgets-2.0: Make javascript editing permissions more fine grained and separate from normal edit-interface - https://phabricator.wikimedia.org/T120886#3858579 (10Mattflaschen-WMF) [03:00:02] 10MediaWiki-User-management: Separate the user rights to edit MediaWiki: namespace scripts and viewable texts - https://phabricator.wikimedia.org/T174307#3858581 (10Mattflaschen-WMF) [03:00:30] 10Security-Team, 10Gadgets-2.0: Make javascript editing permissions more fine grained and separate from normal editinterface right - https://phabricator.wikimedia.org/T120886#1864154 (10Mattflaschen-WMF) [03:26:29] (03CR) 10Isarra: "Actually, given the use case (adding tabs and often dropdowns), maybe it would be better to change pagetools instead of pagemisc? They are" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399783 (https://phabricator.wikimedia.org/T181362) (owner: 10Evad37) [03:31:39] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857635 (10Tiven2240) >>! In T183581#3857860, @abhaynatu wrote: > Moved discussion to [[https://meta.wikimedia.org/wiki/User_talk:Martin_Urbanec]| Martin's talk page]] Link correction https://meta.wikimedia.org/wi... [03:34:55] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3858591 (10BukhariSaeed) [03:41:51] 10MediaWiki-History-or-Diffs, 10MediaWiki-extensions-Diff, 10Page-Previews, 10Wikidata, 10JavaScript: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes - https://phabricator.wikimedia.org/T183611#3858592 (10Od1n) [03:50:22] 10MediaWiki-Special-pages, 10Collaboration-Team-Triage, 10TechCom-RfC, 10Patch-For-Review: Introduce article creation log - https://phabricator.wikimedia.org/T12331#3858604 (10MZMcBride) Even though the log won't be complete and won't solve the "show all pages created by this user ever" issue, I think addi... [03:51:14] (03PS8) 10SamanthaNguyen: [DNM] 4.4.0 - Comments form converted to OOUI [extensions/Comments] - 10https://gerrit.wikimedia.org/r/380322 (https://phabricator.wikimedia.org/T156055) [04:47:49] (03PS7) 10Gergő Tisza: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) [05:10:16] Hey there ! [05:11:08] Heh mudit_015 , welcome [05:11:25] I am Mudit Khandewal, I am from India and would love working here :) [05:12:09] Great, glad to meet you here. [05:17:12] (03CR) 10Isarra: [V: 032 C: 032] "Fugg it, let's just see what happens." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399783 (https://phabricator.wikimedia.org/T181362) (owner: 10Evad37) [05:18:22] (03Merged) 10jenkins-bot: Change `pagemisc` portlet to `cactions` [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399783 (https://phabricator.wikimedia.org/T181362) (owner: 10Evad37) [05:27:26] (03CR) 10Legoktm: [C: 04-1] Add minus-x to composer test and fix (031 comment) [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [05:27:29] (03CR) 10Legoktm: [C: 04-1] Add minus-x to composer test and fix (031 comment) [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [06:12:06] 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Web-Local-Wiki-Issues: File Upload Wizard not working on iOS and MobileFrontend - https://phabricator.wikimedia.org/T183511#3858628 (10matmarex) Note that English Wikipedia's "File Upload Wizard" has nothing to do with the Commons' "UploadWizard". It's a scr... [06:16:11] 10Timeless, 10CSS, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add-portlet-link gadgets and scripts in "more" menu are missing in Timeless - https://phabricator.wikimedia.org/T181362#3858631 (10Evad37) //In [[https://gerrit.wikimedia.org/r/#/c/399783/]], @Isarra wr... [06:47:54] (03PS2) 10Sharvaniharan: Expose default list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) [06:48:29] (03CR) 10jerkins-bot: [V: 04-1] Expose default list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399973 (https://phabricator.wikimedia.org/T180239) (owner: 10Sharvaniharan) [06:55:32] 10Timeless, 10CSS, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add-portlet-link gadgets and scripts in "more" menu are missing in Timeless - https://phabricator.wikimedia.org/T181362#3858632 (10Evad37) Looking at the source code for mw.util.addPortletLinks ([[https:... [07:42:14] 10Dumps-Generation: Dumps not available for download for 20171220 - https://phabricator.wikimedia.org/T183535#3858636 (10ArielGlenn) 05Open>03Resolved Rsync completed for web server, html files and dump content files are back in sync, [07:47:49] (03PS2) 10ArielGlenn: make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 [07:52:27] 10Dumps-Generation, 10Patch-For-Review: Investigate use of 7z page content files for prefetch - https://phabricator.wikimedia.org/T179267#3858639 (10ArielGlenn) This is waiting on https://gerrit.wikimedia.org/r/#/c/399947/ or https://phabricator.wikimedia.org/T182814 so that the 7zip wrapper is actually availa... [07:58:27] 10Dumps-Generation, 10Patch-For-Review: Investigate use of 7z page content files for prefetch - https://phabricator.wikimedia.org/T179267#3858640 (10ArielGlenn) Here's some data for the record. Note that each decompression ran while nothing else was happening on the box, from local disks. Commands run, one at... [08:25:28] (03PS1) 10Evad37: Changes to portlets for greater compatibility with other skins [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399977 (https://phabricator.wikimedia.org/T181362) [08:55:43] 10MediaWiki-History-or-Diffs, 10Wikidata, 10JavaScript: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes - https://phabricator.wikimedia.org/T183611#3858651 (10Aklapper) Unrelated to #Page-Previews (see its description) or the Diff extension which is not in... [08:57:32] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3858653 (10Aklapper) @BukhariSaeed: Please see my previous comment: Please post what you expected //as text//, and please post what actually happens //as text//. Please provide full //links//, so someone else... [09:11:06] (03CR) 10Thiemo Kreuz (WMDE): "How should I know what the intention of such a change is? If I see a change that makes code worse (and this is the case here, as this chan" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [09:11:16] 10Developer-Relations (Oct-Dec 2017), 10Google-Code-in-2017: Document steps to organizing a workshop around Google Code-in - https://phabricator.wikimedia.org/T179890#3858656 (10Aklapper) (Moving to December on the workboard) [09:12:51] 10Design, 10Discovery, 10WMDE-Design, 10Wikidata, and 5 others: Imagegrid should lazy load - https://phabricator.wikimedia.org/T166216#3858658 (10StudentSydney) I'm new at this so forgive me if I say anything dumb. @Lucas_Werkmeister_WMDE made some good points. Are rows of uniform height acceptable, or is... [09:19:05] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3291788 (10thiemowmde) I'm very much disappointed by the chan... [09:26:05] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3858668 (10MarcoAurelio) [09:34:57] 10MediaWiki-extensions-Translate, 10Wikimedia-Site-requests, 10Patch-For-Review, 10RfC, 10User-MarcoAurelio: Bureaucrats on WMF wikis to add and remove 'translationadmin' by default - https://phabricator.wikimedia.org/T178793#3858669 (10MarcoAurelio) p:05Lowest>03Low [09:37:01] 10MediaWiki-extensions-Translate, 10Wikimedia-Site-requests, 10Patch-For-Review, 10RfC, 10User-MarcoAurelio: Bureaucrats on WMF wikis to add and remove 'translationadmin' by default - https://phabricator.wikimedia.org/T178793#3858671 (10MarcoAurelio) https://gerrit.wikimedia.org/r/#/c/385953/ seems now r... [09:43:51] (03CR) 10Umherirrender: "recheck" [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [09:51:05] HI [09:52:24] Agam: Hello! [09:52:47] 10MediaWiki-Core-Tests: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3858672 (10thiemowmde) My answer to the question asked is: yes. Why not? The more relevant question is: Which tools complain about `@covers` tags that point to `….php` file names instead of (full qual... [09:55:11] Anyone here for gci [09:56:02] Well, in this channel you can meet mentors and participants of GCI [09:59:38] (03CR) 10Umherirrender: [C: 031] "This is like a new structure test and will running on all test runs. I have no idea how to find other breakage than from the gated-extensi" [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [10:00:15] 10MediaWiki-Database, 10AbuseFilter, 10Schema-change: Schema change for AbuseFilter logging - https://phabricator.wikimedia.org/T182762#3858674 (10MarcoAurelio) 05Open>03declined per @matej_suchanek I'm declining this; in favor of using log_action instead, which seems more doable. [10:02:17] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3858679 (10Umherirrender) [10:02:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Wikibase has invalid @covers tags - https://phabricator.wikimedia.org/T183531#3858677 (10Umherirrender) 05Open>03Resolved a:03Legoktm [10:03:56] 10MediaWiki-Core-Tests: Can PHPUnit @covers tags cover entire files - https://phabricator.wikimedia.org/T183604#3858681 (10Umherirrender) There is work to fix T171899 For EventLogging the @covers contains a whole file, which was detected as error (but that was without .php). [10:21:35] (03PS2) 10Umherirrender: Start showing warnings for deprecated PHP entry point [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/399238 (owner: 10Fomafix) [10:21:39] (03CR) 10Umherirrender: [C: 032] Start showing warnings for deprecated PHP entry point [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/399238 (owner: 10Fomafix) [10:26:13] 10Research, 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3858683 (10leila) [10:26:22] (03CR) 10Umherirrender: [C: 031] Add composer for CI, and fix CS errors [extensions/Description2] - 10https://gerrit.wikimedia.org/r/388003 (https://phabricator.wikimedia.org/T183532) (owner: 10Samwilson) [10:31:11] (03PS2) 10Umherirrender: Add license-name to extension.json [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/394844 (https://phabricator.wikimedia.org/T123943) (owner: 10Samwilson) [10:31:15] (03CR) 10Umherirrender: [C: 032] Add license-name to extension.json [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/394844 (https://phabricator.wikimedia.org/T123943) (owner: 10Samwilson) [10:32:15] (03Merged) 10jenkins-bot: Start showing warnings for deprecated PHP entry point [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/399238 (owner: 10Fomafix) [10:34:22] (03Merged) 10jenkins-bot: Add license-name to extension.json [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/394844 (https://phabricator.wikimedia.org/T123943) (owner: 10Samwilson) [10:38:30] (03CR) 10Umherirrender: [C: 032] Access ParserCache through MediaWikiServices instead [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/398769 (owner: 10SamanthaNguyen) [10:39:58] (03Merged) 10jenkins-bot: Access ParserCache through MediaWikiServices instead [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/398769 (owner: 10SamanthaNguyen) [10:45:18] (03PS1) 10Umherirrender: Access ParserCache through MediaWikiServices instead [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/399978 [10:47:09] (03CR) 10Multichill: [C: 031] Add more data to categories dump [core] - 10https://gerrit.wikimedia.org/r/392173 (https://phabricator.wikimedia.org/T173980) (owner: 10Smalyshev) [10:54:22] (03PS4) 10Addshore: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) [10:55:21] (03PS24) 10Samwilson: Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) [10:57:20] 10MediaWiki-History-or-Diffs, 10JavaScript: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes - https://phabricator.wikimedia.org/T183611#3858687 (10Od1n) [11:00:51] (03CR) 10Addshore: Switch Revision MCR overhaul based on $wgUseMCRRevision (033 comments) [core] - 10https://gerrit.wikimedia.org/r/399881 (https://phabricator.wikimedia.org/T183592) (owner: 10Addshore) [11:00:52] (03PS9) 10Addshore: Switch Revision MCR overhaul based on $wgUseMCRRevision [core] - 10https://gerrit.wikimedia.org/r/399881 (https://phabricator.wikimedia.org/T183592) [11:01:15] (03CR) 10Samwilson: [C: 031] "The screenshot was https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/12019/artifact/log/should-be-able-to-chan" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [11:03:00] (03CR) 10Samwilson: Convert Preferences class into PreferencesFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [11:07:51] 10MediaWiki-extensions-Other, 10Patch-For-Review: Add phpcs to Description2 - https://phabricator.wikimedia.org/T183532#3858694 (10Samwilson) @DanielFriesen are you still the maintainer of Description2? I was thinking of adding a couple of features (see the talk page). [11:25:22] is there some good examples of extension special page unit testing available somewhere in our repos ? [11:33:16] hey, everyone! :) [11:33:39] cf_fairfeld: Hey! [11:35:26] Phantom42: heylo :D [11:36:05] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/399880 (owner: 10Umherirrender) [11:36:27] (03CR) 10Addshore: [C: 032] Access ParserCache through MediaWikiServices instead [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/399978 (owner: 10Umherirrender) [11:36:46] (03CR) 10Addshore: [C: 032] Update reference to DatabaseBase in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/399964 (owner: 10Umherirrender) [11:37:03] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/399962 (owner: 10Umherirrender) [11:37:25] cf_fairfeld: Hey! [11:37:48] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/399957 (owner: 10Umherirrender) [11:39:57] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/Memento] - 10https://gerrit.wikimedia.org/r/399960 (owner: 10Umherirrender) [11:40:26] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/399880 (owner: 10Umherirrender) [11:40:44] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/399961 (owner: 10Umherirrender) [11:40:57] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/399955 (owner: 10Umherirrender) [11:41:16] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/399958 (owner: 10Umherirrender) [11:41:22] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/399953 (owner: 10Umherirrender) [11:41:55] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/399886 (owner: 10Umherirrender) [11:42:02] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399883 (owner: 10Umherirrender) [11:42:11] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/Cite] - 10https://gerrit.wikimedia.org/r/399890 (owner: 10Umherirrender) [11:42:25] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/399896 (owner: 10Umherirrender) [11:42:33] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/399898 (owner: 10Umherirrender) [11:42:40] (03Merged) 10jenkins-bot: Access ParserCache through MediaWikiServices instead [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/399978 (owner: 10Umherirrender) [11:42:47] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/399900 (owner: 10Umherirrender) [11:43:23] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/399944 (owner: 10Umherirrender) [11:43:34] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/399948 (owner: 10Umherirrender) [11:44:42] (03CR) 10Addshore: [C: 032] Rename class MostGloballyLinkedFilesPage to match file [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/396640 (owner: 10Umherirrender) [11:45:36] (03CR) 10Addshore: [C: 032] Improve types in documentation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 (owner: 10Umherirrender) [11:46:01] (03CR) 10Addshore: [C: 032] Set wgCommentTableSchemaMigrationStage in RevisionStoreTest [core] - 10https://gerrit.wikimedia.org/r/398543 (owner: 10Umherirrender) [11:46:10] d3r1ck: hey! :) [11:47:18] (03Merged) 10jenkins-bot: Update reference to DatabaseBase in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/399964 (owner: 10Umherirrender) [11:47:22] (03CR) 10Addshore: [C: 032] Move GlobalBlockListPager to own file [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/398641 (owner: 10Umherirrender) [11:48:32] (03CR) 10Addshore: [C: 04-1] Improve some parameter docs (031 comment) [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 (owner: 10Umherirrender) [11:48:49] (03CR) 10Addshore: [C: 032] Move InterwikiLogFormatter to own file [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/398643 (owner: 10Umherirrender) [11:49:07] (03CR) 10Addshore: [C: 032] Move ConfirmAccountsPager to own file [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/398636 (owner: 10Umherirrender) [11:49:46] (03CR) 10Addshore: [C: 032] Move TitleBlacklistEntry to own file [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/399705 (owner: 10Umherirrender) [11:51:56] (03CR) 10Addshore: "Hmmm, I was going to say an autoload entry is missing, but i actually can't see anything that uses these classes...." [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 (owner: 10Umherirrender) [11:52:19] (03CR) 10Addshore: "recheck" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/399915 (owner: 10Umherirrender) [11:52:22] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/399962 (owner: 10Umherirrender) [11:52:24] (03CR) 10Addshore: "recheck" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 (owner: 10Umherirrender) [11:52:26] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/399957 (owner: 10Umherirrender) [11:52:28] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/Memento] - 10https://gerrit.wikimedia.org/r/399960 (owner: 10Umherirrender) [11:52:30] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/399961 (owner: 10Umherirrender) [11:52:32] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/399955 (owner: 10Umherirrender) [11:52:34] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/399958 (owner: 10Umherirrender) [11:52:36] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/399953 (owner: 10Umherirrender) [11:52:38] (03CR) 10Addshore: "recheck" [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/399946 (owner: 10Umherirrender) [11:52:40] (03CR) 10Addshore: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/399949 (owner: 10Umherirrender) [11:52:43] (03CR) 10Addshore: "recheck" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/399952 (owner: 10Umherirrender) [11:52:46] (03CR) 10Addshore: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399963 (owner: 10Umherirrender) [11:53:32] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/399886 (owner: 10Umherirrender) [11:53:43] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399883 (owner: 10Umherirrender) [11:56:14] 10Beta-Cluster-reproducible: Special:MovePage is broken on beta with JS enabled - https://phabricator.wikimedia.org/T183494#3858725 (10Addshore) [11:58:38] Hi cf_fairfeld, hi Phantom42, hi d3r1ck and hi everyone else :D [11:58:51] divadsn: Hi :) [11:58:52] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/Cite] - 10https://gerrit.wikimedia.org/r/399890 (owner: 10Umherirrender) [11:58:56] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/399896 (owner: 10Umherirrender) [11:58:58] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/399898 (owner: 10Umherirrender) [11:59:00] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/399900 (owner: 10Umherirrender) [12:01:14] hey there divadsn! :D [12:03:14] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/399944 (owner: 10Umherirrender) [12:03:16] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/399948 (owner: 10Umherirrender) [12:03:18] (03Merged) 10jenkins-bot: Rename class MostGloballyLinkedFilesPage to match file [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/396640 (owner: 10Umherirrender) [12:03:20] (03Merged) 10jenkins-bot: Improve types in documentation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 (owner: 10Umherirrender) [12:03:39] Gonna write my blog post today as my task is still on review :) [12:04:14] divadsn: but...but...there will be a GCI task for that too, next year! :P [12:04:49] andre__, I'm not writing the summary blog post :D [12:05:07] I am writing the beginners guide post, as it would fit perfectly for holidays [12:05:21] Idk, but I think during holidays some students might wanna try GCI :) [12:05:31] ah. good :D [12:05:35] 10MediaWiki-extensions-Newsletter: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3858732 (1001tonythomas) [12:05:36] thank you! [12:08:45] (03Merged) 10jenkins-bot: Set wgCommentTableSchemaMigrationStage in RevisionStoreTest [core] - 10https://gerrit.wikimedia.org/r/398543 (owner: 10Umherirrender) [12:08:46] (03Merged) 10jenkins-bot: Move GlobalBlockListPager to own file [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/398641 (owner: 10Umherirrender) [12:08:48] (03Merged) 10jenkins-bot: Move InterwikiLogFormatter to own file [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/398643 (owner: 10Umherirrender) [12:08:50] (03Merged) 10jenkins-bot: Move ConfirmAccountsPager to own file [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/398636 (owner: 10Umherirrender) [12:08:52] (03Merged) 10jenkins-bot: Move TitleBlacklistEntry to own file [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/399705 (owner: 10Umherirrender) [12:11:49] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test removeSubscription in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183614#3858747 (1001tonythomas) [12:12:44] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test addPublisher in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183615#3858757 (1001tonythomas) [12:13:50] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183616#3858767 (1001tonythomas) [12:14:58] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `addNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183617#3858777 (1001tonythomas) [12:15:56] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183618#3858787 (1001tonythomas) [12:16:47] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183619#3858797 (1001tonythomas) [12:17:01] (03CR) 10jerkins-bot: [V: 04-1] Change doc type from DatabaseBase to IDatabase [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 (owner: 10Umherirrender) [12:17:36] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183620#3858807 (1001tonythomas) [12:17:52] Good evening ! :D [12:18:43] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `deleteNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183621#3858817 (1001tonythomas) [12:19:53] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `restoreNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183622#3858827 (1001tonythomas) [12:20:10] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3858837 (1001tonythomas) [12:20:49] 10Beta-Cluster-reproducible: Special:MovePage is broken on beta with JS enabled - https://phabricator.wikimedia.org/T183494#3858843 (10Addshore) [12:21:53] Evening :V [12:22:32] eisenhaus335: o/ [12:22:53] refeed[m], \o [12:23:26] (03CR) 10jenkins-bot: Update reference to DatabaseBase in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/399964 (owner: 10Umherirrender) [12:26:02] i am dont know Visual Studio can be installed on ubuntu. its like traitorous act :V *laugh in heart [12:27:18] eisenhaus335: do you mean Visual Studio Code ? [12:31:38] (03CR) 10jenkins-bot: Set wgCommentTableSchemaMigrationStage in RevisionStoreTest [core] - 10https://gerrit.wikimedia.org/r/398543 (owner: 10Umherirrender) [12:34:27] 10MediaWiki-extensions-UniversalLanguageSelector: You can't click the "input tools" button in user contributions page's date picker on Edge browser - https://phabricator.wikimedia.org/T183623#3858862 (10Stryn) [12:34:32] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/Math] - 10https://gerrit.wikimedia.org/r/399949 (owner: 10Umherirrender) [12:35:02] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399963 (owner: 10Umherirrender) [12:35:10] (03CR) 10Addshore: [C: 032] Change typehint from DatabaseBase to IDatabase [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/399946 (owner: 10Umherirrender) [12:35:15] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/399952 (owner: 10Umherirrender) [12:35:27] (03CR) 10Addshore: [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/399915 (owner: 10Umherirrender) [12:36:22] (03CR) 10Addshore: "Test failure is not relevant, I'll leave this patch here for a while and if the test doesn't get fixed I'll push it through" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 (owner: 10Umherirrender) [12:36:26] (03CR) 10Addshore: [C: 031] Change doc type from DatabaseBase to IDatabase [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 (owner: 10Umherirrender) [12:36:55] (03CR) 10Addshore: [C: 032] Move RSSUtils to own file [extensions/RSS] - 10https://gerrit.wikimedia.org/r/399701 (owner: 10Umherirrender) [12:40:38] eisenhaus335: use snap? [12:40:52] https://insights.ubuntu.com/2017/05/19/visual-studio-code-is-now-available-as-a-snap-on-ubuntu/ [12:42:30] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/Math] - 10https://gerrit.wikimedia.org/r/399949 (owner: 10Umherirrender) [12:42:34] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399963 (owner: 10Umherirrender) [12:42:36] (03Merged) 10jenkins-bot: Change typehint from DatabaseBase to IDatabase [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/399946 (owner: 10Umherirrender) [12:42:38] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/399952 (owner: 10Umherirrender) [12:42:40] (03Merged) 10jenkins-bot: Change doc type from DatabaseBase to IDatabase [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/399915 (owner: 10Umherirrender) [12:42:42] (03Merged) 10jenkins-bot: Move RSSUtils to own file [extensions/RSS] - 10https://gerrit.wikimedia.org/r/399701 (owner: 10Umherirrender) [12:43:36] wikimedia/stylelint-config-wikimedia#25 (master - 2d9aa55 ricordisamoa): The build passed. - https://travis-ci.org/wikimedia/stylelint-config-wikimedia/builds/320635687 [12:49:01] 10MediaWiki-General-or-Unknown: Two calendars gets opened in user contributions page if you click the form before the page is fully loaded - https://phabricator.wikimedia.org/T183624#3858874 (10Stryn) [12:55:27] Hello and I am from Google Code-in task [12:55:53] ycwei982: Welcome! [12:58:09] ycwei982: hi [13:12:50] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) [13:13:06] (03PS2) 10Albert221: Add minus-x to composer test and fix [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) [13:13:15] 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: Colour not appearing in print - https://phabricator.wikimedia.org/T183625#3858888 (10Neve-selbert) [13:13:25] hello! :) [13:20:32] ycwei982 hello ^^ [13:21:10] Hi [13:22:09] FlorianSW: Are you around ? [13:22:10] Hello. My name is Adam Husain. I am on IRC for a Google Code-In (GCI) task [13:23:22] refeed[m] I guess no, holiday preparations :/ [13:23:34] I'm also busy today doing those [13:23:35] GCI task too here lol [13:23:54] U too? lol [13:23:58] divadsn: hmm, ok then [13:25:17] refeed[m] I'm just saying, in Europe it's common that people aren't available between 23 and 27 December mostly, but there are exceptions like Reedy or andre__ (but I think he will be away on 24th at least) [13:25:18] (03PS1) 10Addshore: README note about how to run sculpin in docker [wikibase/wikiba.se] - 10https://gerrit.wikimedia.org/r/399984 [13:25:45] Zppix: https://gerrit.wikimedia.org/r/#/c/399975/ + https://gerrit.wikimedia.org/r/#/c/399976/ would you take a look? :) [13:25:53] again [13:26:03] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3858900 (10BamLifa) @D3r1ck01 I am ready to improve the README. Assign it to me [13:26:41] Albert221: give me a second and sure [13:27:07] (03CR) 10Ladsgroup: [C: 032] README note about how to run sculpin in docker [wikibase/wikiba.se] - 10https://gerrit.wikimedia.org/r/399984 (owner: 10Addshore) [13:27:57] (03Merged) 10jenkins-bot: README note about how to run sculpin in docker [wikibase/wikiba.se] - 10https://gerrit.wikimedia.org/r/399984 (owner: 10Addshore) [13:28:24] (03PS1) 10Ladsgroup: Remove trailing whitespace [wikibase/wikiba.se] - 10https://gerrit.wikimedia.org/r/399985 [13:31:08] divadsn: okay [13:32:03] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3858901 (10Zppix) a:03BamLifa [13:33:56] (03CR) 10Zppix: [C: 031] Add minus-x to composer test and fix [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [13:34:10] (03CR) 10Zppix: [C: 031] Add minus-x to composer test and fix [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [13:37:58] i am just joking before. i am not really want install VS Code. its from microsoft thats the fun part [13:38:16] (03CR) 10Umherirrender: [V: 032 C: 032] "It is T179777" [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 (owner: 10Umherirrender) [13:38:37] (03PS4) 10Umherirrender: Improve some parameter docs [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 [13:38:45] (03CR) 10Umherirrender: Improve some parameter docs (031 comment) [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 (owner: 10Umherirrender) [13:39:43] eisenhaus335 lol what? :D [13:41:10] divadsn: GCI and work can be good excuses to sneak out of family meetings :P [13:41:44] andre__: nah not so much for me, my dog doesn't understand that ;P [13:42:26] (03PS4) 10Umherirrender: Move classes to own files [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/398644 [13:42:57] I am just deciding which task shud I choose next [13:43:38] (03PS3) 10Umherirrender: Move classes to own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/398609 [13:44:23] (03CR) 10Umherirrender: [C: 032] Add minus-x to composer test and fix [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [13:44:46] (03CR) 10Umherirrender: [C: 032] Add minus-x to composer test and fix [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [13:45:52] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/399975 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [13:46:14] (03Merged) 10jenkins-bot: Add minus-x to composer test and fix [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/399976 (https://phabricator.wikimedia.org/T175794) (owner: 10Albert221) [13:49:57] (03PS5) 10Jcasariego: Add actions on articles shown within "On this day" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399662 [13:50:39] (03CR) 10Umherirrender: "Autoloader was not there on old php entry - https://gerrit.wikimedia.org/r/#/c/213314/18/TorBlock.php" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 (owner: 10Umherirrender) [13:53:07] snyper choose one where you have some basic language knowledge and want to learn more ;) [13:53:56] Oh thanx... [13:54:26] I just need to know English ryt? [13:55:26] Altho I do know a few more languages... but not fluent [13:56:37] (03PS2) 10Umherirrender: Remove unused ASN1Parser.php [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 [13:57:56] 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review, 10Reading Epics (Feed 2.0): Enable secondary actions on articles shown within On this day - https://phabricator.wikimedia.org/T180391#3858917 (10Jcasariego) @RHo this is how it looks with the new component: {F12011324} [14:02:03] snyper: I think divadsn means 'language' as programming language [14:02:07] (03PS2) 10Ladsgroup: Introduce ScoreStorage and its Sql implementetion [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398651 (https://phabricator.wikimedia.org/T181334) [14:02:11] (03CR) 10Ladsgroup: Introduce ScoreStorage and its Sql implementetion (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398651 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [14:02:20] refeed[m] exactly, thanks! [14:02:53] refeed[m]: lol [14:02:56] got it [14:03:12] (03CR) 10jerkins-bot: [V: 04-1] Introduce ScoreStorage and its Sql implementetion [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398651 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [14:07:01] 10MediaWiki-extensions-Wikilog, 10Easy, 10Google-Code-in-2017, 10Technical-Debt: Call to undefined method WikiPage::getText() - https://phabricator.wikimedia.org/T179532#3858923 (10rafidaslam) a:03rafidaslam I'll work on this (claimed on Google Code-in) [14:07:26] divadsn: So how do u bcome a mentor... Did Google choose u or Wikimedia? [14:07:47] snyper I'm not a mentor :D [14:08:09] divadsn: Oh sorry! :P [14:08:22] (03PS3) 10Umherirrender: Remove unused ASN1Parser.php [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 [14:08:25] divadsn: Mistook u 4 some1 else [14:08:28] snyper: you have to be a established member in a community [14:08:55] Zppix: Ryt I wanted to ask u [14:09:59] exit [14:10:10] i did forgot to add a slash lol [14:19:05] 10MediaWiki-ResourceLoader, 10MediaWiki-Special-pages, 10Performance-Team: Two calendars gets opened in user contributions page if you click the form before the page is fully loaded - https://phabricator.wikimedia.org/T183624#3858930 (10Aklapper) Yes, I can reproduce this. Also, the placeholder initially sho... [14:22:31] Zppix: I need a little help [14:22:47] Zppix: Do u know how to publish a website? [14:27:14] (03PS3) 10Ladsgroup: Introduce ScoreStorage and its Sql implementetion [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398651 (https://phabricator.wikimedia.org/T181334) [14:30:16] snyper: yes [14:30:33] Zppix: The thing is... suppose I create a website in Dreamweaver(say). How do I get it on the internet? [14:30:57] snyper: can i pm you? [14:31:07] Zppix: Ya sure [14:40:01] 10Mediawiki-extensions-PropertySuggester, 10Phabricator, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3858937 (10Addshore) [14:42:08] 10Mediawiki-extensions-PropertySuggester, 10Phabricator, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3858937 (10Paladox) It needs to have a callsign in the repo for our gerrit to phabricator converter to work. [14:45:50] 10MediaWiki-extensions-Wikilog, 10Easy, 10Google-Code-in-2017, 10Technical-Debt: Call to undefined method WikiPage::getText() - https://phabricator.wikimedia.org/T179532#3858949 (10rafidaslam) Created a PR for this in the github repo at https://github.com/mediawiki4intranet/Wikilog/pull/21 [14:50:43] 10MediaWiki-extensions-UniversalLanguageSelector: Can't click "input tools" button for date field on Special:Contributions; collides with date picker widget on Edge browser - https://phabricator.wikimedia.org/T183623#3858950 (10Aklapper) [14:52:50] 10MediaWiki-extensions-FlaggedRevs: Add a new legend to the legend box on wikis with flagged revisions enabled - https://phabricator.wikimedia.org/T172787#3858963 (10Stryn) [14:52:52] 10MediaWiki-extensions-FlaggedRevs: Add "flagged revisions" label to the legend table - https://phabricator.wikimedia.org/T63381#3858966 (10Stryn) [14:55:24] \exit [14:55:48] 10MediaWiki-extensions-FlaggedRevs: Add "flagged revisions" label to the legend table - https://phabricator.wikimedia.org/T63381#3858971 (10Stryn) [14:58:23] 10MediaWiki-Maintenance-scripts: purgeList.php doesn't purge all URL variants provided in the TitleSquidURLs hook - https://phabricator.wikimedia.org/T183628#3858974 (10Ciencia_Al_Poder) [14:59:37] 10MediaWiki-Maintenance-scripts, 10Easy: purgeList.php doesn't purge all URL variants provided in the TitleSquidURLs hook - https://phabricator.wikimedia.org/T183628#3858984 (10Ciencia_Al_Poder) Tagging as #easy, looks it should take only a few lines of code on the maintenance script itself to fix this. [14:59:39] 10Developer-Relations (Oct-Dec 2017): Make my project a Featured Project : LinguaLibre - https://phabricator.wikimedia.org/T173037#3858987 (10Aklapper) @Yug: Hmm. Thing is, going to https://lists.wikimedia.fr/info/lingualibre you'd need to find `Abonnement > Votre adresse de messagerie` to subscribe. In its cur... [15:06:55] 10Google-Code-in-2017: [Lua task #11] Create a general date-handling function - https://phabricator.wikimedia.org/T183560#3858988 (10Aklapper) Thanks! Published as https://codein.withgoogle.com/tasks/6223144526282752/ [15:10:31] (03CR) 10Addshore: [C: 032] Improve some parameter docs [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 (owner: 10Umherirrender) [15:11:00] (03CR) 10Addshore: [C: 031] Remove unused ASN1Parser.php [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 (owner: 10Umherirrender) [15:12:00] (03Merged) 10jenkins-bot: Improve some parameter docs [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 (owner: 10Umherirrender) [15:14:04] 10MediaWiki-extensions-Wikilog, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review, 10Technical-Debt: Call to undefined method WikiPage::getText() - https://phabricator.wikimedia.org/T179532#3858993 (10Aklapper) [15:15:29] 10Mediawiki-extensions-PropertySuggester, 10Diffusion, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3858994 (10Aklapper) There seems to be no such repo containing the words PropertySuggester in the name in Phab [15:17:06] 10Mediawiki-extensions-PropertySuggester, 10Diffusion, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3858998 (10Paladox) I guess the repo dosen't exist in diffusion. It's on GitHub https://github.com/wikimedia/mediawiki-... [15:18:38] 10Mediawiki-extensions-PropertySuggester, 10Diffusion, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3858999 (10Addshore) I have a feeling this could be the case for quite a few extensions. Is this not all done automatic... [15:20:55] 10Mediawiki-extensions-PropertySuggester, 10Diffusion, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3859000 (10Paladox) It's done for all new repo's created (only if the repo is created through gerrit). It's all done ma... [15:24:49] 10Community-Liaisons (Jan-Mar-2018), 10Documentation, 10Google-Code-in-2017: Monitor some Google Code-in 2017 tasks about documentation - https://phabricator.wikimedia.org/T181970#3859001 (10Trizek-WMF) [15:27:51] 10MediaWiki-extensions-ORES, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Scoring-platform-team (Current), 10User-Ladsgroup: Tests should have covered regression in T182936 - https://phabricator.wikimedia.org/T182942#3859005 (10Ladsgroup) Yeah, I've been thinking about how we can write proper... [15:36:42] (03PS5) 10MarcoAurelio: Convert AdManager to use extension registration [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/392021 (https://phabricator.wikimedia.org/T180679) [15:44:21] hey tonythomas! [15:44:46] I just wanted to let you know that I've claimed a task you are mentoring :) [15:47:10] 10Mediawiki-extensions-PropertySuggester, 10Diffusion, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627#3859009 (10Addshore) Maybe we need to have someone write up a script and just create them all for existing repos rather... [15:52:25] Albert221: hej! [15:52:35] I got the notifications - yes! [15:54:50] (03PS1) 10Ladsgroup: Move methods of Cache to PurgeScoreCache [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399994 (https://phabricator.wikimedia.org/T181334) [15:55:23] 10MediaWiki-extensions-ORES, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10Scoring-platform-team (Current), 10User-Ladsgroup: Split Cache.php to different services - https://phabricator.wikimedia.org/T181334#3859037 (10Ladsgroup) Two patches are waiting for review... [16:02:33] (03PS34) 10Aude: MCR database schema [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [16:04:02] (03CR) 10Aude: MCR database schema (038 comments) [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [16:09:33] legoktm: You around? :) [16:10:02] It's possibly a bit early still for him [16:10:07] Like 8am ish [16:11:28] Reedy: Okay! [16:13:55] Reedy, check https://gerrit.wikimedia.org/r/#/c/399893/ please? [16:14:03] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3859067 (1001tonythomas) [16:14:19] Ebe123: heh, 0 based indexing? :P [16:14:28] Yep [16:14:28] (not that it matters whatsoever) [16:14:52] (03PS1) 1001tonythomas: Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) [16:15:15] Reedy got a minute ? [16:15:39] I wanted to just know if https://gerrit.wikimedia.org/r/#/c/399995/1/tests/specials/SpecialNewsletterCreateTest.php would be the right way to unit test a validation on form submission (in a special page actually). [16:15:55] (03CR) 10jerkins-bot: [V: 04-1] Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) (owner: 1001tonythomas) [16:15:56] if yes, we can have more GCI tasks which can follow this to do other validations sa well [16:16:56] (03CR) 10Reedy: [C: 032] Add variables to score hash [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [16:17:04] (03PS2) 1001tonythomas: Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) [16:18:10] Thank you! [16:18:54] (03Merged) 10jenkins-bot: Add variables to score hash [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [16:23:25] tonythomas: Dunno.. It doesn't look bad, but I don't really do much testing stuff... I'd say ask addshore [16:23:39] nice. [16:27:44] ohia [16:28:32] tonythomas: looks good [16:28:41] nice then [16:28:41] Yes, SpecialPageTestBase is the thing to use (i put it on core) ;) [16:28:48] Does that count as a CR+1 and a CR+2? :P [16:28:57] oh, does it want actual review? :D [16:29:10] I think the TODO says it's not ready [16:29:16] Just tonythomas checking he's on the right track [16:29:26] yep, looks like the right track [16:29:34] * addshore still has his head deep in MCR [16:30:05] * addshore thinks he might enable ALL wmf extensions before touching core again... [16:30:34] caboom [16:31:07] Reedy: my idea was to have an example on which other GCI students can build upon [16:31:08] https://phabricator.wikimedia.org/T183634 is funny, as daniel and I wrote and review this stuff, and know about wikibase, yet, it broke wikibase... [16:31:20] like we have multiple validations which we can make as one GCI task or evne multiple [16:35:47] Time for a BlobStore factory :D [16:38:56] so, I think someone should +2 this then ? Then I can show this as an example for others to hack upon ? Or extend ? [16:39:51] oops - btw - I see I have bad author email address there in the commit message :/ let me fix that [16:41:05] (03PS3) 1001tonythomas: Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) [16:41:30] yes. should be good to go then. I will create the GCI issues as well [16:41:44] we can even make separate GCI issues, I guess ? [16:59:30] 10MediaWiki-extensions-Newsletter, 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3859111 (1001tonythomas) [16:59:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3859067 (1001tonythomas) [17:02:06] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The main page should exist" in NewsletterCreate - https://phabricator.wikimedia.org/T183635#3859115 (1001tonythomas) [17:04:05] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3859134 (1001tonythomas) [17:05:37] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate - https://phabricator.wikimedia.org/T183638#3859144 (1001tonythomas) [17:06:13] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3859154 (1001tonythomas) [17:16:35] (03PS1) 10Addshore: Remove duplicate ServiceWiring definitions [core] - 10https://gerrit.wikimedia.org/r/399997 [17:28:15] Hi I'm sam I'm here for the Google Code-In [17:28:48] sam___: Welcome :) [17:29:04] 10WikiCV: Design Mockup - https://phabricator.wikimedia.org/T183639#3859164 (10Meghasharma213) [17:29:06] sam___: Hi! Glad to see you! Good luck with GCI tasks! [17:29:25] So can u tell me what to do next [17:29:37] 10WikiCV: Design Mockup - https://phabricator.wikimedia.org/T183639#3859176 (10Meghasharma213) [17:29:39] I need some guidance [17:29:48] Okay, first of all, you need to wait 1 hour so this task could be marked as complete [17:29:58] Like how to submit this work [17:30:01] hi sam___! [17:30:03] After that you would be able to claim your next task [17:30:27] Meanwhile we may help you to set up development environment [17:31:17] sam___: Out of curiosity, which IRC client did you choose? [17:31:18] Ok now I [17:31:23] guys [17:31:27] what is IRC? [17:31:34] (03PS3) 10Addshore: [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) [17:31:40] mauli_: Internet Relay Chat [17:31:41] Internet relay chat [17:31:50] ok.... [17:31:52] but [17:31:54] mauli_: https://en.wikipedia.org/wiki/Internet_Relay_Chat [17:32:05] I came here through a URL [17:32:15] mauli_: Which URL? [17:32:16] I didn't use any IRC [17:32:23] Ohhhh I see :) [17:32:25] https://webchat.freenode.net/ [17:32:57] mauli_: Yes, you use that to access IRC via the web :) [17:32:57] Andre I just typed web chat.freenode.net [17:33:02] Reedy: https://gerrit.wikimedia.org/r/#/c/399997/ is an easy one [17:33:15] sam___, so you're using a web client? See the GCI task description. [17:33:27] It asked me to fill in details so I filled them n here I am [17:33:54] Yep Andre web client [17:35:02] sam___, if you are here for GCI then please do read the GCI task description again. If you are interested to get credits for the task. :) [17:35:18] err "in getting" instead of "to get", sorry [17:35:57] Andre the task description said wait one hour before leavin [17:36:00] So [17:36:29] sam___, have you read the complete task description? it says more :) [17:36:33] Andre u there [17:36:37] sam___: Let me quote: install an IRC client you like, but not IRC clients listed as "web" [17:36:38] Yep [17:36:40] Hello guys [17:36:45] hello mauli_ [17:36:50] I read it n claimed the task [17:36:50] sam___, so you use a web client. Just saying :) [17:36:56] oh [17:36:57] are you here for the google code-in? [17:37:01] hey sam_ [17:37:10] I'm here with the CGI too [17:37:12] ...and for that GCI task you should not use a web client. But up to you. :) [17:37:16] Yep bcuz I'm usin a Samsung pda [17:37:32] andre__, why? [17:37:39] do you have access to a laptop or desktop at some point, mauli_? [17:37:39] mauli_: it says not too [17:37:40] mauli_, because the task description says so. [17:37:52] apergos_, yes I do [17:38:05] we're happy to have you here now, but you'll want to come back on from there with an irc client app [17:38:07] Andre so I should not use a web client [17:38:09] Oh god [17:38:11] Right [17:38:12] I just read it [17:38:25] thanks andre and sam [17:38:35] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), and 2 others: InvalidArgumentException from line 101 RevisionStoreRecord.php: The given Title does not belong... - https://phabricator.wikimedia.org/T183564#3859179 [17:38:41] sam___, that is what it says, yes. [17:39:07] sam___: Even if you are using mobile phone or tablet now, you may download IRC client for Android to avoid using Web client [17:39:32] Ok Andre can u give me a list of clients(apps for a Samsung bus my computer has no net [17:39:36] (...a free one though, and "free" does not mean "freeware". Again, see the task description) [17:39:46] sam___, no, because there is a link to IRC software in the task descrption. [17:39:52] You need to read the task description, sorry :) [17:40:03] Ok hold on [17:40:21] I don't have a Samsung phone and I don't use Android or whatever is on there, and I have not tried all the IRC clients out there in the world. [17:40:51] sam___: So I can just ask you to throughly read the GCI task description. Because every sentence has a meaning there. :) [17:41:42] * andre__ cannot read for others - that's one thing he cannot help with :P [17:41:48] Wait Andre it's not there the link [17:42:15] sam___, oh yes, it is. [17:42:15] So should I search on Google play for an orc client [17:42:20] sam___: I am afraid that link is in "please do not use" context [17:42:37] sam___, in the sentence "install an IRC client you like", "IRC client" is a link. [17:43:02] it even explicitly says "webchat.freenode.net are not ok" :) [17:44:14] Ok I have have downloaded a client [17:44:57] If I close tis page after connecting to freenode n the Wikimedia tag [17:45:11] I can chat with u n others right [17:45:39] Andre pls. Help me [17:46:03] Yes. Just close this page and connect using your client to this channel again [17:46:59] Is that you, Sam? [17:47:32] Hi it's me sam on the client named androIRC [17:47:52] AndroUser: AndroIRC is proprietary. Again, see the task description. [17:48:23] (03PS4) 10Addshore: [MCR] Introduce BlobStoreFactory [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) [17:49:36] * andre__ is off to grab some food [17:49:49] Ok give me some names of other IR C clients [17:50:00] (03PS2) 10Gergő Tisza: Improve documentation of $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/392360 [17:50:02] (03PS1) 10Gergő Tisza: Allow multiple values for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) [17:50:30] AndroUser: HexChat, IRSSI, WeeChat, LimeChat, XChat, etc... [17:50:54] Which can be used on android [17:51:03] Are they [17:51:08] Hmm.... [17:51:15] Those I listed are *nix based [17:51:31] Man pls. Help me [17:51:37] Maybe HoloIRC? [17:51:40] I've only used JuiceSSH to connect to IRC on Andriod [17:51:49] Is it [17:52:02] AndroUser: You can use HoloIRC, maybe [17:52:05] Yes. Try HoloIRC. I just checked - it is opensource [17:52:11] It's andriod based I think [17:52:23] Hallujah [17:52:58] Downloading [17:53:13] Meet u on that [17:54:52] Welcome back [17:55:19] Hi it's me sam [17:55:35] HoloIRCUser7: Okay, welcome back Sam :) [17:56:10] Ok now what should I do to submit the work [17:56:30] According to task description, you should wait 1 hour first :) [17:56:32] Andre [17:56:49] Ok I will wait after that [17:58:32] (03PS2) 10Gergő Tisza: Allow multiple values for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) [17:58:45] andre__: where are u [17:59:13] sanjaysam: You have some questions? You may ask them. Maybe someone else will be able to help you [17:59:19] Phantom42: man where r u [17:59:28] Ok [17:59:34] i am here >> x [17:59:51] Now so u are in the US right [18:00:02] Hmm [18:00:09] No. We all are from different countries :) [18:01:45] Ok [18:02:35] So do u work [18:02:53] Phantom42: [18:02:54] Me? I am GCI participant, just like you :) [18:03:15] K peace [18:03:16] But I contribute apart GCI too, by the way. Because it is interesting and fun! [18:03:25] Hope you join us too! [18:03:32] I what [18:03:40] *in what [18:04:17] sanjaysam: in contributing to wikimedia by completing gci tasks for example. [18:04:47] Ok i have already regestered [18:04:49] And don't worry - we will help you to get started and will answer all your questions :) [18:05:13] K thanks man now it's 11:30 in the night [18:05:17] Here [18:05:59] Phantom42: out of curiosity what class r u in [18:06:07] I guess your task requires to stay online 20 more minutes or something like that :) [18:06:17] Yep [18:06:41] sanjaysam: I am not sure how to convert my class number to US system, but I am 11th (my last year) in school now. [18:07:01] I'm not in the US I'm in india [18:07:20] Oh, sorry [18:07:27] Which country r u in [18:07:34] hey, everyone :) [18:07:40] By the way, there are a lot of other GCI participants from India! Hope you meet them soon [18:07:42] Then I can get to know [18:07:47] Yep [18:07:48] I am from Ukraine [18:07:54] sanjaysam: welcome ;) [18:07:56] O k [18:08:17] andre__, The Lounge is open source too :D [18:08:25] Hi c.f._ fairfield [18:08:49] divadsn: Yes, but we were looking for open source android client [18:08:55] divadsn, Phantom42, d3r1ck, Albert221, hey! :) [18:08:55] Phantom42: what's the time I ukraine [18:09:02] *in [18:09:02] cf_fairfeld: Hello! [18:09:04] ukraine++ i've known some smart programmers [18:09:09] cf_fairfeld: Hi :) [18:09:11] Phantom42, but The Lounge runs also well on Android as a webapp :P [18:09:15] sanjaysam: 20:09 [18:09:19] cf_fairfeld hi! [18:09:22] what is the lounge? [18:09:38] Phantom42: am or pm sorry [18:09:40] tca: thelounge.github.io [18:10:02] sanjaysam: It is evening here, so pm :) [18:10:10] A self-hosted web IRC client, works with any browser and OS, with more or less deep integrations :) [18:10:26] divadsn if it runs as a web app then it's proprietory [18:10:39] sanjaysam: No, the lounge is open source [18:10:39] Read the descriptions pls. [18:10:48] K [18:10:58] sanjaysam lol what? :D [18:11:15] nice, is that in node js? [18:11:15] I'm much of a ethical hacker [18:11:28] So [18:12:03] lol? [18:12:48] tca: Yes. The Lounge is written in node js [18:13:43] Hi guys I'm back [18:13:59] Hi! [18:14:10] It's me man the sam [18:14:13] Ugh, why disconnecting whole the time XD [18:14:15] can write some impressive webapps these days with javascript..I never paid respected js much in the past since I am more of a backend dev, but its come into its own in recent years. [18:14:36] hi sanjaysam :) [18:14:43] Guys have u done c++ [18:14:45] s/paid// [18:14:54] yes, c++ here [18:14:54] divadsn: Because all android irc clients have issues with disconnecting. Hopefully Sam will switch to desktop irc later [18:15:13] Phantom42 that's why ZNC is for ;) [18:15:23] Nope my comp does not have internet [18:15:31] divadsn: However it requires some time to setup :( [18:15:37] Hmm [18:15:44] (03CR) 10Mainframe98: Allow multiple values for $wgReferrerPolicy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) (owner: 10Gergő Tisza) [18:15:50] Phantom42 not really, my runs just out-of-the box :D [18:16:02] And the web UI is easy to use, clean and simple [18:16:08] Ok guys do not be angry at me what's freenode [18:16:21] rfc2549 ftw [18:16:28] divadsn: Really? `apt install znc` and nothing else? [18:16:35] Hmm [18:16:50] sanjaysam: It is network of IRC servers we use for communication [18:16:52] Phantom42, yes, only setup NGINX proxy to access 9000 in your browser [18:17:04] Ok thanks [18:17:30] sanjaysam, feel free to ask questions about stuff you're unsure about :) [18:18:23] divadsn: Hm. Okay. I will take into account that ZNC is fast to install. I just didn't use it. Thank you for clarification :) [18:18:23] All day I tried to do Dean Ambrose's dirty deeds attack n my head is in pain [18:18:31] https://imgur.com/a/UBlEM runs stable with 3 users Phantom42 [18:18:56] Guys [18:19:54] Phantom42: do u know how much time is left for me [18:20:04] To stay on [18:20:11] sanjaysam: I guess around 10 minutes [18:20:12] Here [18:20:18] Ok thanks [18:20:22] Phantom42: last year I know it was complicated to get it running on Debian 7, as it wasn't available I guess, but Ubuntu 16.04 LTS have the latest stable in their repos [18:20:31] Hmm [18:20:38] sanjaysam you can stay more :P [18:20:46] sanjaysam: You joined the chat at :28, and now it is :20 [18:20:58] Phantom42: k [18:22:46] Phantom42: so in ukraine in 11 what's the syllabus bcuz I'm in 8th [18:23:33] sanjaysam: Is 8th the last year in India too? [18:23:51] 04(no projects): No registered builder available for vector. - https://phabricator.wikimedia.org/T183640#3859189 (10Paladox) [18:24:27] 10MediaWiki-Configuration, 10MediaWiki-Installer, 10Vector: No registered builder available for vector. - https://phabricator.wikimedia.org/T183640#3859199 (10Paladox) [18:25:00] sanjaysam: oh, so you're 13 :) [18:25:33] divadsn: Okay. Thank you. I may try running ZNC later on my server [18:26:23] No it's like In my school we have till 12th [18:26:52] Then our degree [18:27:05] 10MediaWiki-extensions-Score, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add version to Score hashes - https://phabricator.wikimedia.org/T49448#3859201 (10Ebe123) 05Open>03Resolved [18:27:13] sanjaysam: Okay. Thank you. As for syllabus, I think it would be difficult to compare :) [18:27:23] I know [18:27:51] Man now how do I submit my work [18:28:08] There is a button for that on GCI dashboard task page [18:28:13] Ok [18:28:17] Then [18:28:40] Then you will need to get it approved and after that you can move to your next task! [18:29:05] No about uploading the file part how to do that [18:29:26] Oh, for this IRC task you have to upload nothing [18:29:33] Just submit [18:29:55] Ok [18:30:07] and maybe leave a comment with your username and other relevant details [18:30:16] How will the see where my work is [18:30:28] (03PS3) 10Gergő Tisza: Allow multiple values for $wgReferrerPolicy [core] - 10https://gerrit.wikimedia.org/r/399998 (https://phabricator.wikimedia.org/T180921) [18:30:34] sanjaysam: Could you clarify please what you mean? [18:30:47] All your work information is available on GCI dashboard [18:30:49] username, and from when to when you joined the channel [18:31:05] Where should I put my nick n client info [18:31:15] In comments under the task description [18:31:21] K [18:31:29] the mentors are also on this channel [18:31:41] they'll be able to verify that you were here :) [18:31:53] 10MediaWiki-extensions-Score: Support MusicXML notation - https://phabricator.wikimedia.org/T183641#3859202 (10Ebe123) [18:32:20] 10MediaWiki-extensions-Score: Support MusicXML notation - https://phabricator.wikimedia.org/T183641#3859202 (10Ebe123) 05Open>03stalled p:05Triage>03Lowest [18:33:26] I sent it as my time is overPhantom42: I sent it as my tim.e is over [18:33:52] sanjaysam: Great! Now need to wait for mentors to approve and you may move to your next task! [18:34:00] Ok is my work done [18:34:09] For now, I think yes [18:35:05] sanjaysam: You've made 1 hour already? [18:35:13] Hmm [18:35:56] sanjaysam: ? [18:36:05] d3r1ck: Yes. He had. He joined at :28, now it is :36 [18:37:30] Thanks to all the guys for helping me out [18:37:46] sanjaysam: Let me approve :) [18:38:03] sanjaysam: You are welcome! If you have any other questions, feel free to ask - we are always happy to help :) [18:38:08] Phantom42: r u on instagram [18:38:20] sanjaysam: No, I don't use it [18:38:31] d3r1ck: drum roll [18:38:47] But you may always find me and other gci paricipants and mentors here, on IRC [18:38:57] sanjaysam: Done! Good luck and move on to your next task :) [18:39:02] Phantom42: y r u on any other social media [18:39:28] d3r1ck: thanks u on Instagram [18:39:48] um not to be rude, but sanjaysam I don't really think it's best practice to ask personal info on a public channel :) [18:39:51] sanjaysam: Yeah but I rarely use it. I'm always here, so you can get in touch with me here :) [18:40:29] Ok ok thanks guys need to get some sleep as it's MIDNIGHT IN INDIA [18:40:33] sanjaysam: I don't activelly use social media. I mostly use Telegram for communication, but again - it is better to ask questions here as you will get replies faster :) [18:40:56] sanjaysam: Good night! [18:41:03] Ok I will surely chat on orc thanks to u guys [18:41:07] sanjaysam: good night :) [18:41:10] Over n out [18:41:57] 10MediaWiki-extensions-Score, 10RfC: Support MusicXML to Lilypond Conversion - https://phabricator.wikimedia.org/T183642#3859213 (10Ebe123) p:05Triage>03Low [18:43:12] 10MediaWiki-extensions-Score: Render musical notation as MusicXML - https://phabricator.wikimedia.org/T183641#3859225 (10Ebe123) [18:43:50] telegram? what about signal 🙃 [18:44:50] OH-: Unluckily, it is not used by people I communicate with a lot :( [18:45:23] And I am not sure about signal. Something like tox is more attractive to me [18:45:56] yep :( that's why i am glued to facebook messenger [18:46:03] 10MediaWiki-extensions-Score, 10Upstream: Support custom tablatures (supported in Lilypond 2.20) - https://phabricator.wikimedia.org/T181370#3859227 (10Ebe123) [18:46:06] I did convert one friend to signal though [18:48:18] (03PS2) 10BryanDavis: Add role sendgrid.pp to MW-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/399844 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [18:48:23] (03CR) 10BryanDavis: [C: 032] Add role sendgrid.pp to MW-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/399844 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [18:48:48] (03PS1) 10Sophivorus: Respond to second code review by Reedy [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/399999 (https://phabricator.wikimedia.org/T149766) [18:49:34] (03Merged) 10jenkins-bot: Add role sendgrid.pp to MW-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/399844 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [18:50:15] (03CR) 10jenkins-bot: Add role sendgrid.pp to MW-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/399844 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [18:53:13] OH-, no one uses in Android development Signal afaik, Telegram is being used a lot [18:53:29] 10MediaWiki-extensions-WikipediaExtracts, 10Patch-For-Review: WikipediaExtracts code review - https://phabricator.wikimedia.org/T149766#3859233 (10Sophivorus) @Reedy Hi, I like your code reviews, thanks! Some of your comments seemed to be based on a previous version of the extension. The getCredits() method ha... [18:53:58] The most attractive feature for me in Telegram is powerful bot system :) [18:56:31] (03CR) 10Florianschmidtwelzow: "@Thiemo: That's why we've link tasks in the commit message to explain the broader rationale there, without always copying information in d" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [18:58:52] hey [18:59:03] I'm here for the google code in challenge [18:59:14] idiotguy123: Welcome! [18:59:37] idiotguy123, hi and welcome here! [19:00:27] Phantom42, and how easy the APIs are :D [19:00:38] idiotguy123 hi, although your nick is somehow strange :D [19:00:40] idiotguy123: Welcome :) [19:00:58] I thought it would stand out [19:01:05] gotta make an impression [19:01:12] divadsn: Yes, that's something I was talking about. APIs for bots are awesome. And for clients too [19:01:26] idiotguy123: 😂 [19:02:08] hey, idiotguy123! :) [19:02:24] (03CR) 10Florianschmidtwelzow: [C: 032] "*yay* Thanks Phantom42 again for making this change, too :)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399339 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:02:32] calling you that is awkward xD [19:03:00] heh [19:03:16] quite an accurate description of me [19:03:19] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 4 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3859236 (10Florian) 05Open>03Resolved [19:06:25] idiotguy123: It is smart and creative! You took the username which has a low probability of being taken when you register somewhere :) Anyway, usernames don't matter really :))) [19:07:16] idiotguy123: your name when rearranged spells you dig it 123 [19:07:19] that's not too bad [19:07:41] anyways, welcome :-) [19:07:53] haha thanks [19:08:11] apergos: Wow! Awesome job of moving letter around :D [19:08:33] thank the internets [19:09:07] (03Merged) 10jenkins-bot: Add cURL PHP extension to the list of composer requirements [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399339 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:09:10] https://xkcd.com/903/ something like this... [19:10:50] apergos: Haha :) So true [19:12:41] (03CR) 10Phantom42: "Thank you too for merging and reviewing this!" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399339 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:14:38] 10MediaWiki-Configuration, 10MediaWiki-Installer, 10Vector: No registered builder available for vector. - https://phabricator.wikimedia.org/T183640#3859253 (10Paladox) Caused by https://github.com/wikimedia/mediawiki-skins-Vector/commit/c863b94302a135dadeb9a0895548ed46391bbc0e#diff-d0d8757209d9c0a810a54d0862... [19:15:19] (03PS1) 10Paladox: Revert "Print styles in Vector are no longer feature flagged" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) [19:15:25] (03CR) 10jerkins-bot: [V: 04-1] Revert "Print styles in Vector are no longer feature flagged" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [19:18:35] (03PS2) 10Paladox: Revert "Print styles in Vector are no longer feature flagged" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) [19:25:57] (03PS2) 10Sophivorus: Respond to second code review by Reedy [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/399999 (https://phabricator.wikimedia.org/T149766) [19:33:18] p [19:35:17] 10HHVM, 10Patch-For-Review, 10Upstream: HHVM and PHP handle non-static input to call_user_func_array() different - https://phabricator.wikimedia.org/T157213#3859263 (10Florian) > So I guess we will want to revisit the php.ini confguration file being shipped and most probably make sure strict errors are repor... [19:36:38] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Patch-For-Review, 10Technical-Debt: Remove HitCounters from AbuseFilter and use hooks instead - https://phabricator.wikimedia.org/T159069#3055879 (10Tgr) I wonder if this is something that would be useful on Wikimedia sites? [[https://www.mediawiki.org/w... [19:50:30] 10MediaWiki-Core-Tests, 10MediaWiki-General-or-Unknown, 10NewPHP, 10Patch-For-Review: MediaWiki PHPUnit fails with PHP 7.2 - https://phabricator.wikimedia.org/T181931#3806953 (10Florian) > Then for anyone running composer themselves (not using wikimedia's mediawiki-vendor), composer will select an appropri... [19:52:46] (03CR) 10Florianschmidtwelzow: Allow PHPUnit 5 and 6 versions optionally in require-dev (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394851 (https://phabricator.wikimedia.org/T181931) (owner: 10Reedy) [20:03:10] Reedy, addshore: Do you have time (and do you want to) to take a look at https://gerrit.wikimedia.org/r/#/c/399219/1 ? :) [20:03:50] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/398638 (owner: 10Umherirrender) [20:05:00] (03CR) 10Florianschmidtwelzow: [C: 032] "I like codesearch, found no usages:" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 (owner: 10Umherirrender) [20:06:24] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3859271 (10D3r1ck01) Tested on an instance running MW-Vagrant on Cloud VPS. Everything is working. Updated documentation to include... [20:06:26] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/398609 (owner: 10Umherirrender) [20:07:23] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/398644 (owner: 10Umherirrender) [20:08:07] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399690 (owner: 10Umherirrender) [20:08:36] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/398639 (owner: 10Umherirrender) [20:09:16] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/Collection] - 10https://gerrit.wikimedia.org/r/398635 (owner: 10Umherirrender) [20:09:47] (03CR) 10Florianschmidtwelzow: [C: 032] Move classes to own files [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/398629 (owner: 10Umherirrender) [20:10:48] (03Merged) 10jenkins-bot: Move classes to own files [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/398638 (owner: 10Umherirrender) [20:10:50] (03Merged) 10jenkins-bot: Remove unused ASN1Parser.php [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/399707 (owner: 10Umherirrender) [20:11:52] (03CR) 10Brian Wolff: "> It's indeed 3 table merge, but with primary keys, so it should be OK (I checked it manually on the db and it worked ok for me)" [core] - 10https://gerrit.wikimedia.org/r/392173 (https://phabricator.wikimedia.org/T173980) (owner: 10Smalyshev) [20:13:15] (03Merged) 10jenkins-bot: Move classes to own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/398609 (owner: 10Umherirrender) [20:13:17] (03Merged) 10jenkins-bot: Move classes to own files [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/398644 (owner: 10Umherirrender) [20:13:19] (03Merged) 10jenkins-bot: Move classes to own files [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399690 (owner: 10Umherirrender) [20:13:21] (03Merged) 10jenkins-bot: Move classes to own files [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/398639 (owner: 10Umherirrender) [20:13:45] (03Merged) 10jenkins-bot: Move classes to own files [extensions/Collection] - 10https://gerrit.wikimedia.org/r/398635 (owner: 10Umherirrender) [20:13:47] (03Merged) 10jenkins-bot: Move classes to own files [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/398629 (owner: 10Umherirrender) [20:23:51] FlorianSW: not me ;) [20:24:07] addshore: ok, thanks anyway :) [20:27:45] (03CR) 10Brian Wolff: Port categories dump header fix (031 comment) [core] - 10https://gerrit.wikimedia.org/r/392175 (owner: 10Smalyshev) [20:31:00] (03CR) 10Smalyshev: "> If we want to always keep the title constant regardless of changes in localization files between versions of MediaWiki, then we should d" [core] - 10https://gerrit.wikimedia.org/r/392175 (owner: 10Smalyshev) [20:31:18] Hi I'm here for the Google Code-in challenge [20:31:49] RedAlan1: Welcome! Good luck with your GCI tasks! [20:31:53] Welcome RedAlan1 [20:32:08] thank you [20:33:02] Thank you [20:33:08] Hello [20:34:34] RedAlan1: Welcome :) [20:34:51] Good luck :) [20:34:58] d3r1ck This is a fine program [20:35:10] RedAlan1: Yeah it is :) [20:40:05] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3859275 (10D3r1ck01) 05Open>03Resolved [20:42:03] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3859277 (10D3r1ck01) @BamLifa, you can self assign a task if you want to work on it. @Zppix helped you but next time, you can always do it on your own :) [20:48:34] (03CR) 10Brian Wolff: "I'd prefer directly using $wgArticlePath. I don't think there's any gurantee that Title::makeTitle( NS_MAIN, "Special:CategoryDump" ) will" [core] - 10https://gerrit.wikimedia.org/r/392175 (owner: 10Smalyshev) [20:52:09] This is fun [20:52:24] (03CR) 10Smalyshev: "but wgArticlePath only has the local part? Could you provide the full code that produces the string you thing should be there? I am feelin" [core] - 10https://gerrit.wikimedia.org/r/392175 (owner: 10Smalyshev) [20:52:54] Contributing to open source is always fun! :) [20:53:31] I feel this a very calming and chill platform [20:53:35] to converse of course [20:53:48] it sure is ;) [20:59:30] (03CR) 10Brian Wolff: "Oh. You're right. Sorry, I didn't think of that" [core] - 10https://gerrit.wikimedia.org/r/392175 (owner: 10Smalyshev) [21:01:03] going now :) night, everyone [21:01:27] Good night! [21:04:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400003 (owner: 10L10n-bot) [21:04:45] k [21:05:16] cf_fairfeld: Good night :) [21:07:01] This is fun [21:07:15] It's so late here [21:07:17] but [21:07:25] 10Support-and-Safety, 10Wikimedia-Site-requests: Enable create a Secure poll in Arwiki - https://phabricator.wikimedia.org/T183358#3859283 (10Ibrahim.ID) we will use it in our ArbCom election 2018, Maybe in (Check User - Oversight) candidates if it acceptable in secure poll. Generally, we want to use it in b... [21:08:35] This is an official and formal ? [21:08:57] Yes it is [21:09:11] Oh wow [21:09:36] Trust me my english isn't as informal and low levelled as how i was speaking before [21:09:55] (03CR) 10Florianschmidtwelzow: "BlogPage also has a config variable with the name UserProfileDisplay. That means, if one loads the BlogPage extension after the SocialProf" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [21:11:39] Well, it isn't really formal in here. We just discuss development questions here, but sometimes go offtopic too :) [21:11:46] oh nice [21:12:15] Google Code-in makes me realise that stuff like this exists too [21:12:20] it's fascinating [21:13:25] (03CR) 10Florianschmidtwelzow: [C: 031] "I'm not sure, if you want this patch to be merged before you've fixed the error I explained in my comment, before, that's why I just leave" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [21:13:31] The world of open source is quite big. Google Code In helps you to start the great trip in this world :) [21:16:29] (03CR) 10SamanthaNguyen: "Thank you Florian for the comments, I'll work on fixing that! It'll be a separate patch, and would like to have that merged before this on" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [21:19:18] 10MediaWiki-Configuration, 10WorkType-NewFunctionality: Allow definition of Extension Dependencies - https://phabricator.wikimedia.org/T32234#353496 (10Florian) Where should the "suggests"/"recommend" message be printed to? If we would have something like "php maintenance/mwscript installExtension FooBar" whic... [21:20:19] I find this chat interesting [21:20:46] (03CR) 10Florianschmidtwelzow: "So, if the extension consists of multiple extensions:" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396591 (owner: 10SamanthaNguyen) [21:24:00] interestiing [21:26:55] (03CR) 10SamanthaNguyen: "Thanks again :) Me and Jack Phoenix then decided that we'll just leave this patch open for now (but the UserProfile thing will at least be" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396591 (owner: 10SamanthaNguyen) [21:27:07] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions Compatible with UTF-8 Digit - https://phabricator.wikimedia.org/T183465#3859302 (10Jayprakash12345) Adding You All. Because you were involved in T36193. [21:27:25] (03CR) 10Florianschmidtwelzow: [C: 031] "> It'll be a separate patch, and would like to have that merged before this one goes through." [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [21:28:15] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I put my -1 here, then, so I do not accidently merge this one :P If you think this is fine, feel free to remove my vote :)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396591 (owner: 10SamanthaNguyen) [21:28:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400030 (owner: 10L10n-bot) [21:28:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/400033 (owner: 10L10n-bot) [21:29:58] (03CR) 10SamanthaNguyen: "Sorry, stupid me. :P Thanks for explaining!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [21:30:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400045 (owner: 10L10n-bot) [21:34:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/400047 (owner: 10L10n-bot) [21:35:10] Username- RedAlan1 [21:35:17] Nickname- RedAlan1 [21:52:41] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions Compatible with UTF-8 Digit - https://phabricator.wikimedia.org/T183465#3859304 (10MarkAHershberger) I am not the target audience for this fix but I'm willing to help shepherd a fix. I need, though, someone who: # is affected b... [21:53:38] hello! [21:58:17] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: Deprecate and remove 'find' - https://phabricator.wikimedia.org/T183645#3859305 (10Volker_E) p:05Triage>03High [21:58:27] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: Deprecate and remove 'find' - https://phabricator.wikimedia.org/T183645#3859305 (10Volker_E) [21:58:41] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Deprecate and remove 'find' - https://phabricator.wikimedia.org/T183645#3859305 (10Volker_E) [22:02:51] (03CR) 10MarkAHershberger: "Thanks for your review!" (031 comment) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [22:03:36] (03PS11) 10MarkAHershberger: Update to extension.json [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 [22:08:25] (03CR) 10MarkAHershberger: "Everything leading up to this has been merged. Could someone +2 this, as well?" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 (owner: 10MarkAHershberger) [22:20:07] (03CR) 10Daniel Kinzler: [C: 031] "Approach and intent look good. Didn't check this line-by-line" [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [22:21:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Update to extension.json [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 (owner: 10MarkAHershberger) [22:21:50] tonythomas, are you here? :) I'm starting to work on my task! [22:22:45] (03Merged) 10jenkins-bot: Update to extension.json [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 (owner: 10MarkAHershberger) [22:31:42] Phantom42, Zppix, andre__, bawolff, divadsn, refeed[m], d3r1ck, FlorianSW, Reedy, TheresNoTime, Merry Christmas to you and all others! 🎄 [22:32:03] You too Albert221 [22:32:06] Albert221: you too! [22:32:07] Albert221: You too! :) [22:33:27] Albert221: Thank you! Merry Christmas! [22:35:02] Albert221: Merry Christmas ;) [22:38:04] (03PS1) 10Gergő Tisza: Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) [22:43:16] (03PS35) 10Aude: MCR database schema [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [22:43:25] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3859327 (10Aklapper) So if I interpret this correctly: The problem can be seen on https://ur.m.wikipedia.org/wiki/یسوع_مسیح The description text we are talking about is `مسیحیت کی مرکزی شخصیت` The text is co... [22:43:37] (03CR) 10jerkins-bot: [V: 04-1] Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [22:45:32] 10MediaWiki-API: Make formatversion=2 more discoverable for new users - https://phabricator.wikimedia.org/T122871#1915693 (10Tgr) People getting confused by query.pages not being an array is one of the more frequent problems on Stackoverflow. It would certainly be nice to improve this. [22:48:52] 10MediaWiki-General-or-Unknown, 10I18n: Some wikidata labels in Urdu have incorrectly rendered Urdu characters on the mobile site - https://phabricator.wikimedia.org/T183388#3859330 (10Aklapper) [22:49:24] 10MediaWiki-General-or-Unknown, 10I18n: Some wikidata labels in Urdu have incorrectly rendered Urdu characters on the mobile site - https://phabricator.wikimedia.org/T183388#3851752 (10Aklapper) 05stalled>03Open [22:52:16] Albert221, Merry Christmas! :) [23:03:54] (03PS2) 10Gergő Tisza: Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) [23:09:42] (03CR) 10jerkins-bot: [V: 04-1] Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [23:12:06] 10MediaWiki-extensions-CleanChanges: Dates on last modifications are doubled - https://phabricator.wikimedia.org/T183646#3859334 (10S.piccardi) [23:14:10] (03CR) 10Gergő Tisza: "recheck" [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [23:16:36] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3859345 (10Anomie) >>! In T153505#3858659, @thiemowmde wrote:... [23:18:11] Hiya I'm part of the Google Code In Task [23:18:29] shubyy: Welcome! [23:19:27] hello shubyy! [23:19:34] (03PS1) 10Albert221: Unit test NewsletterDb::addPublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400075 (https://phabricator.wikimedia.org/T183615) [23:19:38] where are you from? how did you got to know about the GCI? :) [23:19:51] (03CR) 10jerkins-bot: [V: 04-1] Add formatversion=2 to all API examples [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [23:19:51] So do we do anything here [23:20:08] welcome shubyy! Yeah, sometimes we chat about development related things here. [23:20:08] shubyy: Here we discuss questions related to development and contributing to wikimedia [23:20:11] we just discuss development stuff or offtop sometimes :) [23:20:24] anything development rated [23:20:28] ? [23:20:40] anything MediaWiki development related. [23:20:41] mainly WikiMedia stuff, but sometimes not [23:20:50] oh okay [23:20:51] but yes, let's say only MediaWiki [23:21:18] i dont really understand what wikimedia is for [23:21:40] https://www.wikimedia.org/ [23:21:48] yes ik [23:21:52] oh [23:21:55] nvm [23:22:27] i went on the commons page and i didnt really get much info there [23:22:39] Albert221: thanks you too :) [23:25:47] (03CR) 10Fomafix: Add formatversion=2 to all API examples (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400074 (https://phabricator.wikimedia.org/T103015) (owner: 10Gergő Tisza) [23:26:36] andre__: Thank you a lot for approving my task! [23:28:21] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test addPublisher in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183615#3859349 (10Albert221) a:03Albert221 [23:29:01] Phantom42, yw [23:29:10] andre__, what is a ChickTech Workshop stuff? [23:30:53] anyways how come you guys don't use discord or some other service [23:31:05] IRC is like really old [23:31:13] shubyy: Because irc is free, independent and open source [23:31:27] discord is free and open source too [23:31:43] Oh, can I setup my own discord server? [23:31:49] yes u can for free [23:32:57] So there is a way I can setup discord server on my own computer / server? [23:33:15] you dont need to have a server [23:33:26] its done in 3 or 4 steps [23:33:42] And their backend is not open source :( [23:33:52] true [23:34:06] So what if they shutdown their servers tomorrow? [23:34:13] but that makes it open to people to see it and check for vulnerabilities [23:34:24] they wont lol [23:35:21] Who knows. In a "what if" world anything can happen. That's why we use IRC [23:36:18] what if the internet shuts down [23:37:39] I feel we are about to go offtopic :) [23:40:13] shubyy: Anyway, good luck with your GCI tasks! Feel free to ask if you have any questions - we are always happy to help! [23:41:54] alright thanks :) [23:47:35] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions Compatible with UTF-8 Digit - https://phabricator.wikimedia.org/T183465#3854002 (10Bawolff) #time and #(if)expr are different enough i think thet should be discussed separately. I am undecided if this is a good idea or not. Pros... [23:49:23] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to "english" digits in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859353 (10Bawolff) [23:50:01] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to "english" digits in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859355 (10MarkAHershberger) Thanks, @bawolff. Good point. I'll help write an RFC if anyone is interested in getting t... [23:55:01] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to "english" digits in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859356 (10Bawolff) There is also the matter of if localized digit grouping would also be converted. When we localize nu... [23:55:09] 10MediaWiki-extensions-ParserFunctions, 10I18n: Make Extension:ParserFunctions convert localized digits to arabic numerals in #(if)expr and #time - https://phabricator.wikimedia.org/T183465#3859357 (10MarkAHershberger)