[00:04:32] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Show a reading list sync opt-in prompt to users upon log in - https://phabricator.wikimedia.org/T180220#3855828 (10RHo) [00:07:55] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 2 others: MediaWiki\Storage\RevisionAccessException from line 217 of /srv/mediawiki/php-master/includes/Storage/RevisionStore.php Could not determine title for page ID 7... - https://phabricator.wikimedia.org/T183505#3855830 [00:14:18] (03PS1) 10Ryan10145: Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) [00:20:16] (03PS1) 10Ryan10145: Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) [00:25:20] (03CR) 10Mooeypoo: "Discovered a bug, putting back in WIP while I fix it." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) (owner: 10Mooeypoo) [00:26:01] (03PS1) 10Addshore: Use Revision::newFromId with READ_LATEST for onRevisionInsertComplete [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) [00:26:32] (03PS8) 10Mooeypoo: [wip] RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) [00:26:48] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 3 others: MediaWiki\Storage\RevisionAccessException from line 217 of /srv/mediawiki/php-master/includes/Storage/RevisionStore.php Could not determine title for page ID 7... - https://phabricator.wikimedia.org/T183505#3855842 [00:27:20] legoktm: there is also a patch up for https://phabricator.wikimedia.org/T183505 now [00:27:23] now for bed [00:27:26] more testing tommorrow [00:28:32] :D [00:28:35] Krinkle: my dev setup has mysql replication now ;) [00:29:08] I might start looking at porting it to work on kubernetes over the coming month [00:41:33] (03PS22) 10MaxSem: Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [00:46:40] 10Developer-Relations, 10TechCom, 10TechCom-RfC: Launch the Wikimedia "Code Review Special Interest Group" - https://phabricator.wikimedia.org/T129842#2117691 (10Krinkle) [00:46:49] 10MediaWiki-User-login-and-signup, 10TechCom-RfC, 10I18n: RFC: Allow user login with email address in addition to username - https://phabricator.wikimedia.org/T30085#3855855 (10Krinkle) [00:46:55] 10MediaWiki-Watchlist, 10Collaboration-Team-Triage, 10Notifications, 10TechCom-RfC: RfC: Need to merge Notifications and Watchlist or lack thereof - https://phabricator.wikimedia.org/T128352#3855857 (10Krinkle) [00:47:08] (03CR) 10jerkins-bot: [V: 04-1] Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [00:52:02] (03CR) 10Krinkle: [C: 04-1] Use Revision::newFromId with READ_LATEST for onRevisionInsertComplete (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [00:53:49] (03CR) 10Krinkle: [C: 04-1] Use Revision::newFromId with READ_LATEST for onRevisionInsertComplete (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [00:54:44] (03PS4) 10Smalyshev: Move Lucene explain to outside library [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398608 [00:55:30] (03CR) 10SamanthaNguyen: [C: 032] 2008 called, it wants its IDs back [extensions/Theme] - 10https://gerrit.wikimedia.org/r/399563 (owner: 10Jack Phoenix) [00:57:10] (03Merged) 10jenkins-bot: 2008 called, it wants its IDs back [extensions/Theme] - 10https://gerrit.wikimedia.org/r/399563 (owner: 10Jack Phoenix) [01:09:40] 10MediaWiki-Vendor, 10Security: Security review for lucene-explain-parser library - https://phabricator.wikimedia.org/T183518#3855873 (10Smalyshev) [01:13:05] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398608 (owner: 10Smalyshev) [01:18:09] 10MediaWiki-Vendor, 10Security-Reviews: Security review for lucene-explain-parser library - https://phabricator.wikimedia.org/T183518#3855884 (10Legoktm) https://www.mediawiki.org/wiki/Manual:External_libraries isn't very clear about this, but security reviews are generally needed only for externally written c... [01:21:30] (03PS1) 10Gergő Tisza: Integration tests for FirejailCommand [core] - 10https://gerrit.wikimedia.org/r/399767 [01:23:46] (03CR) 10Gergő Tisza: [C: 032] shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [01:23:58] 10MediaWiki-Vendor, 10Security-Reviews: Security review for lucene-explain-parser library - https://phabricator.wikimedia.org/T183518#3855889 (10Smalyshev) 05Open>03Resolved a:03Smalyshev Ah, ok, it wasn't clear from that page, indeed. If so, resolving it (unless anybody thinks it's still needed, and the... [01:24:12] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Update app-wide onboarding to promote reading list sync feature - https://phabricator.wikimedia.org/T183519#3855892 (10RHo) [01:27:12] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for FirejailCommand [core] - 10https://gerrit.wikimedia.org/r/399767 (owner: 10Gergő Tisza) [01:28:12] (03PS9) 10Mooeypoo: RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) [01:29:17] (03CR) 10Mooeypoo: RCFilters: Create one single source of truth for item display (031 comment) [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) (owner: 10Mooeypoo) [01:30:56] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): User-education and promotion of the reading list sync feature - https://phabricator.wikimedia.org/T183520#3855904 (10RHo) [01:32:10] 10MediaWiki-Platform-Team, 10Security, 10Services (watching), 10TechCom-RfC (TechCom-Approved): RFC: Deprecate using php serialization inside MediaWiki - https://phabricator.wikimedia.org/T161647#3855920 (10CCicalese_WMF) [01:33:00] 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Security, 10Services (watching), 10TechCom-RfC (TechCom-Approved): RFC: Deprecate using php serialization inside MediaWiki - https://phabricator.wikimedia.org/T161647#3138377 (10CCicalese_WMF) [01:33:25] (03Merged) 10jenkins-bot: shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [01:33:30] (03Merged) 10jenkins-bot: shell: Add debug logging to find binaries that aren't being restricted [core] - 10https://gerrit.wikimedia.org/r/397606 (owner: 10Legoktm) [01:34:53] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): User-education and promotion of the reading list sync feature - https://phabricator.wikimedia.org/T183520#3855925 (10RHo) [01:35:16] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Show a reading list sync opt-in prompt to users upon log in - https://phabricator.wikimedia.org/T180220#3855928 (10RHo) [01:35:28] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Show a reading list sync opt-in prompt to users upon log in - https://phabricator.wikimedia.org/T180220#3750701 (10RHo) [01:35:30] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): User-education and promotion of the reading list sync feature - https://phabricator.wikimedia.org/T183520#3855904 (10RHo) [01:38:44] (03CR) 10Gergő Tisza: [C: 032] shell: Add NO_LOCALSETTINGS restriction [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [01:39:07] (03PS2) 10Gergő Tisza: Integration tests for FirejailCommand [core] - 10https://gerrit.wikimedia.org/r/399767 [01:39:43] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): User-education and promotion of the reading list sync feature - https://phabricator.wikimedia.org/T183520#3855931 (10RHo) [01:44:24] (03Merged) 10jenkins-bot: shell: Add NO_LOCALSETTINGS restriction [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [01:46:29] (03CR) 10jenkins-bot: shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [01:52:28] 10Security-Team, 10phan-taint-check-plugin, 10Google-Code-in-2017: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3855950 (10Albert221) a:03Albert221 [01:53:48] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): User-education and promotion of the reading list sync feature - https://phabricator.wikimedia.org/T183520#3855951 (10RHo) [01:54:36] (03CR) 10jenkins-bot: shell: Add debug logging to find binaries that aren't being restricted [core] - 10https://gerrit.wikimedia.org/r/397606 (owner: 10Legoktm) [01:54:51] (03PS5) 10SamanthaNguyen: Abstract profile header out of UserProfilePage into its own class [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398710 [01:55:58] (03CR) 10jerkins-bot: [V: 04-1] Abstract profile header out of UserProfilePage into its own class [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398710 (owner: 10SamanthaNguyen) [01:58:01] (03PS6) 10SamanthaNguyen: Abstract profile header out of UserProfilePage into its own class [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398710 [01:59:19] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Split reading lists with more articles than the limit per list into multiple lists - https://phabricator.wikimedia.org/T180229#3855955 (10RHo) [02:00:02] 10TechCom, 10TechCom-RfC, 10RfC: Transition WikiDev '16 working areas into working groups - https://phabricator.wikimedia.org/T124504#3855960 (10Krinkle) [02:00:08] (03CR) 10SamanthaNguyen: "PS5: Manually rebased on top of I688e9537a9aac0e473ff56bd8593141e04f6d07f" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398710 (owner: 10SamanthaNguyen) [02:00:09] 10Developer-Relations, 10TechCom: RFC: Implement ArchCom-affiliated working groups (process inspired by Rust's "subteams") - https://phabricator.wikimedia.org/T123606#3855958 (10Krinkle) 05Open>03declined [02:00:53] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#3855964 (10eflyjason) [02:01:29] (03CR) 10SamanthaNguyen: "PS6: Remove accidentally added unfinished UserProfileModule concept (was supposed to be in a future, separate patch)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398710 (owner: 10SamanthaNguyen) [02:03:22] (03CR) 10jenkins-bot: shell: Add NO_LOCALSETTINGS restriction [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [02:03:23] 10Developer-Relations, 10TechCom: RFC: Implement ArchCom-affiliated working groups (process inspired by Rust's "subteams") - https://phabricator.wikimedia.org/T123606#3855966 (10Krinkle) Obsoleted by the TechCom Charter, adopted in July 2017. [02:08:46] (03PS1) 10Gergő Tisza: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 [02:10:28] (03CR) 10Gergő Tisza: "I haven't really taken the time to understand how proc_open works but this seems to work. Hopefully someone with a deeper understanding ca" [core] - 10https://gerrit.wikimedia.org/r/399768 (owner: 10Gergő Tisza) [02:13:08] 10MediaWiki-Vendor, 10Security-Reviews: Security review for lucene-explain-parser library - https://phabricator.wikimedia.org/T183518#3855967 (10Legoktm) I tried to clarify the documentation https://www.mediawiki.org/w/index.php?title=Manual%3AExternal_libraries&type=revision&diff=2653108&oldid=2609551 [02:15:55] (03PS2) 10Gergő Tisza: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 [02:16:41] (03CR) 10Eflyjason: Component: Add some CSS spacing before table collapsing button (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [02:17:18] (03CR) 10Gergő Tisza: [C: 031] "See https://gerrit.wikimedia.org/r/#/c/399768 for stdin." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) (owner: 10Legoktm) [02:17:53] (03CR) 10Gergő Tisza: [C: 031] Use shell restrictions to contain pygments [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396477 (https://phabricator.wikimedia.org/T182468) (owner: 10Legoktm) [02:19:40] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#1039350 (10Krinkle) @Fomafix If I understand correctly, our current approach in stylesheets is to write both the LTR and RTL versions of... [02:19:58] (03PS3) 10Legoktm: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) (owner: 10Gergő Tisza) [02:20:53] (03PS1) 10Cicalese: Handle status array when passed as list [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/399769 [02:25:24] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#3855985 (10eflyjason) I guess we might have to wait till `margin-start` got supported by major browsers to solve it? [02:29:54] (03PS4) 10Gergő Tisza: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) [02:30:46] (03CR) 10MarkAHershberger: [C: 032] Handle status array when passed as list [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/399769 (owner: 10Cicalese) [02:32:13] (03Merged) 10jenkins-bot: Handle status array when passed as list [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/399769 (owner: 10Cicalese) [02:40:31] 10MediaWiki-Cache, 10MediaWiki-File-management, 10Commons: Deleting a file from a wiki AFTER moving to commons: pages on the original wiki linking to the file may have broken links until the page is purged - https://phabricator.wikimedia.org/T183478#3855986 (10Ramsey-WMF) [03:01:38] (03CR) 10Krinkle: [C: 032] objectcache: fix getMultiWithUnionSetCallback() doc [core] - 10https://gerrit.wikimedia.org/r/399531 (owner: 10Aaron Schulz) [03:05:22] (03CR) 10Krinkle: [C: 031] "Will do one review pass while verifying manually, but LGTM now." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/394298 (https://phabricator.wikimedia.org/T181413) (owner: 10Imarlier) [03:07:07] (03CR) 10Krinkle: Allow programmatic input in Command (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) (owner: 10Gergő Tisza) [03:07:39] (03Merged) 10jenkins-bot: objectcache: fix getMultiWithUnionSetCallback() doc [core] - 10https://gerrit.wikimedia.org/r/399531 (owner: 10Aaron Schulz) [03:11:48] (03CR) 10Krinkle: [C: 031] "(Untested, code LGTM)" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) (owner: 10Legoktm) [03:12:42] (03PS6) 10Mooeypoo: RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 [03:14:51] (03PS5) 10Gergő Tisza: Allow programmatic input in Command [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) [03:16:09] (03CR) 10jenkins-bot: objectcache: fix getMultiWithUnionSetCallback() doc [core] - 10https://gerrit.wikimedia.org/r/399531 (owner: 10Aaron Schulz) [03:17:14] (03PS1) 10Eflyjason: [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) [03:27:53] (03CR) 10Brian Wolff: [C: 04-1] "You should change the command line importer (maintenance/importDump.php) in the same commit as you change the default implementation." [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:29:55] (03PS8) 10MarkAHershberger: Update to extension.json [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 [03:35:59] (03CR) 10Brian Wolff: [C: 04-1] "[If you need any advice on how to do that part, please don't hesitate to ask]" [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:36:22] (03PS9) 10MarkAHershberger: Update to extension.json [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 [03:36:42] (03PS10) 10MarkAHershberger: Update to extension.json [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 [03:40:43] 10MediaWiki-Recent-changes, 10MonoBook: first time intro to new rc filters guided tour thing looks weird on monobook - https://phabricator.wikimedia.org/T183523#3856004 (10Bawolff) [03:41:57] (03CR) 10Gergő Tisza: [C: 04-1] Switch ServiceWiring to the new execution framework (031 comment) [core] - 10https://gerrit.wikimedia.org/r/386329 (owner: 10MaxSem) [03:44:09] (03CR) 10Eflyjason: "> [If you need any advice on how to do that part, please don't" [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:44:20] 10Genealogy, 10GraphViz, 10Patch-For-Review: Permit tree regeneration by users without upload permission - https://phabricator.wikimedia.org/T176594#3856014 (10Samwilson) Okay, if anyone feels like reviewing https://gerrit.wikimedia.org/r/#/c/398784 it's ready. Any suggestions for other tests would be good too. [03:48:20] (03CR) 10Gergő Tisza: Convert RandomImageGenerator to use the new execution framework (032 comments) [core] - 10https://gerrit.wikimedia.org/r/391156 (owner: 10MaxSem) [03:49:30] (03CR) 10TTO: "You answered your own question in the comment: "the command line importers should call setNoticeCallback() for their own custom callback t" [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:51:06] 10Support-and-Safety, 10Wikimedia-Site-requests: Enable create a Secure poll in Arwiki - https://phabricator.wikimedia.org/T183358#3856015 (10Huji) Setting up polls does not require sysadmin right anymore (all the associated bugs were fixed, and if I recall correctly, for the last fawiki elections @Jalexander... [03:52:12] (03CR) 10Eflyjason: "> You answered your own question in the comment: "the command line" [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:55:09] (03CR) 10Brian Wolff: [C: 04-1] "So basically you have to set it where the WikiImporter object is created. That would be the importFromHandle method in importDump.php." [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:58:16] (03CR) 10Samwilson: [C: 032] Move graph-creating and checking to the Tree class [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/398622 (owner: 10Samwilson) [03:59:45] (03CR) 10Brian Wolff: [C: 04-1] "Yes, you can test by using importDump.php to import a dump file. You can generate one by running dumpBackup.php, or download a dump file f" [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [03:59:48] (03Merged) 10jenkins-bot: Move graph-creating and checking to the Tree class [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/398622 (owner: 10Samwilson) [04:10:21] 10MediaWiki-extensions-Score, 10VisualEditor, 10Upstream: Provide better error message when a Score is empty - https://phabricator.wikimedia.org/T116392#3856024 (10Ebe123) How about just a rendering error that says that it's an empty score. That is what my patch #upstream does: http://codereview.appspot.com/... [04:12:41] (03PS2) 10Eflyjason: [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) [04:15:39] (03CR) 10Brian Wolff: [C: 031] "[I can't really review this now, but at first glance it looks correct]" [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [04:21:28] (03CR) 10jerkins-bot: [V: 04-1] [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [04:24:59] (03PS3) 10Eflyjason: [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) [04:40:56] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CentralNotice, 10Regression: Central Notice does not work for logged in users - https://phabricator.wikimedia.org/T181953#3856029 (10Liuxinyu970226) @IKhitron: > Ping @Liuxinyu970226, @Jay8g, @TerraCodes. Is this really UBN for us? If not I think you s... [04:44:07] (03PS1) 10Legoktm: RevisionTest: Make @covers tags absolute (re-apply) [core] - 10https://gerrit.wikimedia.org/r/399771 [04:44:50] (03CR) 10Legoktm: [C: 032] "self-merge to unbreak coverage" [core] - 10https://gerrit.wikimedia.org/r/399771 (owner: 10Legoktm) [04:46:59] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CentralNotice, 10Regression: Central Notice does not work for logged in users - https://phabricator.wikimedia.org/T181953#3807617 (10Jseddon) Hey all, I am a little confused as to the precise nature of the issue with this ticket. [04:50:41] (03Merged) 10jenkins-bot: RevisionTest: Make @covers tags absolute (re-apply) [core] - 10https://gerrit.wikimedia.org/r/399771 (owner: 10Legoktm) [04:53:03] 10Timeless, 10CSS, 10Mobile: Picture render with points - https://phabricator.wikimedia.org/T180299#3856033 (10Isarra) Typically for images on the page, we don't want the text to wrap around them on mobile. This specifically applies to thumbs, which are floated left or right, usually, in the content. Where... [04:59:10] (03CR) 10jenkins-bot: RevisionTest: Make @covers tags absolute (re-apply) [core] - 10https://gerrit.wikimedia.org/r/399771 (owner: 10Legoktm) [05:02:15] (03CR) 10Gergő Tisza: Cache processed stylesheets during the parse (031 comment) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/394369 (owner: 10Anomie) [05:10:45] 10MediaWiki-Cache, 10MediaWiki-File-management, 10Commons: Deleting a file from a wiki AFTER moving to commons: pages on the original wiki linking to the file may have broken links until the page is purged - https://phabricator.wikimedia.org/T183478#3854503 (10Tgr) > The obvious solution would be to clear th... [05:14:59] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CentralNotice, 10Regression: Central Notice does not work for logged in users - https://phabricator.wikimedia.org/T181953#3856061 (10Isarra) >>! In T181953#3856031, @Jseddon wrote: > I am a little confused as to the precise nature of the issue with this... [05:32:16] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, and 2 others: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3856065 (10Bawolff) [05:33:11] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, and 2 others: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3856069 (10Bawolff) [Rv make bug security because bug does not appear sensitive] [05:33:28] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3856070 (10Bawolff) [05:42:39] (03PS1) 10tosfos: Initial commit [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/399772 [06:02:07] 10MediaWiki-API, 10MediaWiki-User-management, 10Security: API action=block allows blocking non-existent accounts - https://phabricator.wikimedia.org/T183211#3856072 (10Legoktm) [06:02:20] 10MediaWiki-API, 10MediaWiki-User-management, 10Security: API action=block allows blocking non-existent accounts - https://phabricator.wikimedia.org/T183211#3856075 (10Legoktm) [06:08:08] (03PS2) 10tosfos: Initial commit [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/399772 [06:09:11] bawolff, hey! [06:14:26] 10ContentTranslation, 10Language-2018-Jan-Mar: Please consider purging the cx_corpora table - https://phabricator.wikimedia.org/T183485#3856076 (10santhosh) I have 2 suggestions for candiates to delete from the table: # Translations that are 6 months old AND in Draft state - Remove the entry from cx_transla... [06:28:28] divadsn: happy holidays too. I'll back online this night :D, 8 hours to home :/ [06:38:16] (03PS1) 10BryanDavis: elasticsearch: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399773 (https://phabricator.wikimedia.org/T183305) [06:41:26] (03PS102) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [06:47:33] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: The NO_EXECVE shell restriction doesn't work with firejail because of limit.sh - https://phabricator.wikimedia.org/T182489#3856112 (10Legoktm) 05Open>... [06:54:16] (03PS1) 10Samwilson: Ensure project name is set on 2nd loop when saving [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/399774 [06:54:46] (03PS2) 10Samwilson: Ensure project name is set on 2nd loop when saving [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/399774 (https://phabricator.wikimedia.org/T182937) [06:55:33] (03CR) 10jerkins-bot: [V: 04-1] Ensure project name is set on 2nd loop when saving [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/399774 (https://phabricator.wikimedia.org/T182937) (owner: 10Samwilson) [06:56:52] 10MediaWiki-extensions-PageAssessments, 10Community-Tech, 10Patch-For-Review, 10Wikimedia-log-errors: Undefined index in PageAssessmentsBody.php on line 85 - https://phabricator.wikimedia.org/T182937#3856118 (10Samwilson) a:03Samwilson I couldn't find what was causing this, but have added a fix for it —... [06:58:28] (03PS3) 10Samwilson: Ensure project name is set on 2nd loop when saving [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/399774 (https://phabricator.wikimedia.org/T182937) [06:59:28] (03CR) 10jerkins-bot: [V: 04-1] Ensure project name is set on 2nd loop when saving [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/399774 (https://phabricator.wikimedia.org/T182937) (owner: 10Samwilson) [07:02:51] (03PS4) 10Samwilson: Ensure project name is set on 2nd loop when saving [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/399774 (https://phabricator.wikimedia.org/T182937) [07:04:50] 10MediaWiki-extensions-PageAssessments, 10Community-Tech-Sprint, 10Patch-For-Review, 10Wikimedia-log-errors: Undefined index in PageAssessmentsBody.php on line 85 - https://phabricator.wikimedia.org/T182937#3856120 (10Samwilson) [07:06:26] (03PS2) 10Smalyshev: Add lucene-explain-parser [vendor] - 10https://gerrit.wikimedia.org/r/399765 [07:12:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), 10Patch-For-Review, 10User-Daniel: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index - https://phabricator.wikimedia.org/T172914#3856122 (10eranroz)... [07:24:14] (03PS1) 10Legoktm: Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 [07:24:40] (03PS1) 10Albert221: [WIP] Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 [07:25:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (owner: 10Albert221) [07:29:57] (03CR) 10jerkins-bot: [V: 04-1] Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 (owner: 10Legoktm) [07:30:36] (03CR) 10Phuedx: [C: 032] Replace `width` by flexible solution for other pages dialog [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/399757 (https://phabricator.wikimedia.org/T183517) (owner: 10VolkerE) [07:32:02] (03PS2) 10Legoktm: Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 [07:32:04] (03PS1) 10Legoktm: RevisionTest: Fix @covers tags [core] - 10https://gerrit.wikimedia.org/r/399777 [07:32:28] (03CR) 10Legoktm: [C: 032] "self-merge to unbreak coverage" [core] - 10https://gerrit.wikimedia.org/r/399777 (owner: 10Legoktm) [07:32:30] (03Merged) 10jenkins-bot: Replace `width` by flexible solution for other pages dialog [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/399757 (https://phabricator.wikimedia.org/T183517) (owner: 10VolkerE) [07:34:30] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018): Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3856132 (10Legoktm) a:03Legoktm [07:35:33] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018): Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3479635 (10Legoktm) Re-triaging under #mediawiki-core-tests since this is a PHPUnit issue, and not something easily doable in MW-CS. [07:35:52] (03PS3) 10Legoktm: Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) [07:39:47] (03Merged) 10jenkins-bot: RevisionTest: Fix @covers tags [core] - 10https://gerrit.wikimedia.org/r/399777 (owner: 10Legoktm) [07:43:36] (03CR) 10jerkins-bot: [V: 04-1] Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [07:44:30] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10I18n, and 2 others: Wikidata textarea are LTR for RTL labels - https://phabricator.wikimedia.org/T181340#3856140 (10eranroz) Seems like the issue is solved(?) and I can't reproduce the issue. @IKhitron can you please t... [07:46:32] 10MobileFrontend: MobileContextTest has invalid @covers tag - https://phabricator.wikimedia.org/T183529#3856155 (10Legoktm) p:05Triage>03Lowest [07:47:12] (03PS1) 10Legoktm: MobileContextTest: Fix invalid @covers tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399778 (https://phabricator.wikimedia.org/T183529) [07:48:01] 10CirrusSearch, 10Discovery, 10Discovery-Search: CirrusSearch\UtilTest has invalid @covers tag - https://phabricator.wikimedia.org/T183530#3856170 (10Legoktm) p:05Triage>03Lowest [07:48:31] (03PS3) 10Samwilson: Add composer for CI, and fix CS errors [extensions/Description2] - 10https://gerrit.wikimedia.org/r/388003 [07:49:28] (03PS1) 10Legoktm: UtilTest: Fix invalid @covers tags [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399779 (https://phabricator.wikimedia.org/T183530) [07:50:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase has invalid @covers tags - https://phabricator.wikimedia.org/T183531#3856186 (10Legoktm) p:05Triage>03Lowest [07:54:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikimedia-Israel-Hackers, 10I18n, 10RTL: [Bug] Input boxes for time datatype statements always use ltr - https://phabricator.wikimedia.org/T101954#3856199 (10eranroz) [07:55:24] (03CR) 10jenkins-bot: RevisionTest: Fix @covers tags [core] - 10https://gerrit.wikimedia.org/r/399777 (owner: 10Legoktm) [07:57:03] (03PS4) 10Legoktm: Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) [08:01:15] 10MediaWiki-extensions-General: Add phpcs to Description2 - https://phabricator.wikimedia.org/T183532#3856201 (10Samwilson) [08:01:40] (03PS4) 10Samwilson: Add composer for CI, and fix CS errors [extensions/Description2] - 10https://gerrit.wikimedia.org/r/388003 (https://phabricator.wikimedia.org/T183532) [08:03:00] (03CR) 10jerkins-bot: [V: 04-1] Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [08:04:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase has invalid @covers tags - https://phabricator.wikimedia.org/T183531#3856215 (10Legoktm) [08:05:40] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399779 (https://phabricator.wikimedia.org/T183530) (owner: 10Legoktm) [08:09:36] 10ContentTranslation, 10Language-2018-Jan-Mar: Please consider purging the cx_corpora table - https://phabricator.wikimedia.org/T183485#3854755 (10Nikerabbit) We don't want to deleted published articles as we require those for the corpora dumps. [08:12:01] (03PS1) 10Smalyshev: Update system files to cookicutter standard [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399780 [08:12:09] (03CR) 10jerkins-bot: [V: 04-1] Update system files to cookicutter standard [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399780 (owner: 10Smalyshev) [08:13:53] (03PS2) 10Smalyshev: Update system files to cookicutter standard [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399780 [08:16:02] (03CR) 10Legoktm: [C: 032] "Thanks!" [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399780 (owner: 10Smalyshev) [08:16:31] (03Merged) 10jenkins-bot: Update system files to cookicutter standard [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399780 (owner: 10Smalyshev) [08:18:28] (03CR) 10Legoktm: "I filed blocking bugs against failing extensions, but I think this is ready for review otherwise." [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [08:20:45] (03PS1) 10Smalyshev: Update readme & build atatus [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399781 [08:21:18] (03CR) 10Legoktm: [C: 04-1] "Could you tag a new release that has the .gitattributes changes so we don't include all of the test files here?" [vendor] - 10https://gerrit.wikimedia.org/r/399765 (owner: 10Smalyshev) [08:24:02] 04(no projects): Enable Travis CI builds for - https://phabricator.wikimedia.org/T183533#3856225 (10Smalyshev) [08:24:19] 04(no projects): Enable Travis CI builds for wikimedia-lucene-explain-parser - https://phabricator.wikimedia.org/T183533#3856234 (10Smalyshev) [08:24:32] 04(no projects): Enable Travis CI builds for wikimedia-lucene-explain-parser - https://phabricator.wikimedia.org/T183533#3856225 (10Smalyshev) Also would be nice to do the same for https://travis-ci.org/wikimedia/wikimedia-textcat [08:28:22] (03CR) 10Smalyshev: [C: 032] Update readme & build atatus [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399781 (owner: 10Smalyshev) [08:28:54] (03Merged) 10jenkins-bot: Update readme & build atatus [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/399781 (owner: 10Smalyshev) [08:34:55] 10HHVM, 10Patch-For-Review, 10Upstream: HHVM and PHP handle non-static input to call_user_func_array() different - https://phabricator.wikimedia.org/T157213#3856245 (10hashar) We have HHVM 3.18 which should include the upstream fix for [[ https://github.com/facebook/hhvm/issues/7647 | issue #7647 ]]. The h... [08:35:04] (03PS1) 10Evad37: Change `pagemisc` portlet to `cactions` [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399783 (https://phabricator.wikimedia.org/T181362) [08:36:35] (03PS3) 10Smalyshev: Add lucene-explain-parser [vendor] - 10https://gerrit.wikimedia.org/r/399765 [08:39:53] (03PS1) 10Smalyshev: Add .idea to ignore file [tools/cookiecutter-library] - 10https://gerrit.wikimedia.org/r/399784 [08:40:50] (03CR) 10Smalyshev: [C: 032] UtilTest: Fix invalid @covers tags [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399779 (https://phabricator.wikimedia.org/T183530) (owner: 10Legoktm) [08:41:39] 10Timeless, 10CSS, 10Patch-For-Review: Add-portlet-link gadgets and scripts in "more" menu are missing in Timeless - https://phabricator.wikimedia.org/T181362#3856250 (10Evad37) a:03Evad37 @Isarra: here's a patch [08:47:36] 04(no projects): AdvancedSearch placeholder text in IE slightly cut at the bottom - https://phabricator.wikimedia.org/T183534#3856256 (10WMDE-Fisch) [08:49:19] (03Merged) 10jenkins-bot: UtilTest: Fix invalid @covers tags [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399779 (https://phabricator.wikimedia.org/T183530) (owner: 10Legoktm) [09:08:26] 04(no projects): dumps not found (404 Not Found) nginx/1.11.13 - https://phabricator.wikimedia.org/T183535#3856280 (10Formatierer) [09:20:22] 10MediaWiki-Vagrant, 10Operations, 10Patch-For-Review: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3856290 (10Volans) p:05Triage>03Normal [09:22:37] (03CR) 10Daimona Eaytoy: "Sorry, I forgot to also reply here :-) Maybe it's true that tt is styled differently depending on the browser, but IMVHO that's a minor is" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [09:45:55] (03CR) 10Daniel Kinzler: Prevent writes on connections obtained with DB_REPLICA. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [09:46:40] 10Discovery, 10Wikimedia-Portals, 10Discovery-Portal-Sprint, 10Epic: [epic] Wikipedia.org Portal: automating updates for the portal - https://phabricator.wikimedia.org/T140159#3856311 (10hashar) [09:49:00] (03CR) 10Daniel Kinzler: Prevent writes on connections obtained with DB_REPLICA. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [09:51:56] 10Research: Work on Recommending Images to Wikidata Items - https://phabricator.wikimedia.org/T180013#3856321 (10Miriam) [09:55:23] (03CR) 10DCausse: [C: 031] Remove ESLint inline comments in WebdriverIO configuration files [core] - 10https://gerrit.wikimedia.org/r/399656 (https://phabricator.wikimedia.org/T175179) (owner: 10Zfilipin) [09:57:31] 10Research-Programs, 10Epic: [Objective 9.1.1] Article expansion recommendations - https://phabricator.wikimedia.org/T171224#3856325 (10Miriam) [09:57:33] 10Research: Work on Recommending Images to Wikidata Items - https://phabricator.wikimedia.org/T180013#3856324 (10Miriam) [09:58:31] 10MediaWiki-Vagrant, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3856327 (10zeljkofilipin) Results for the above script: P6499 (mwv-stretch). [10:00:14] (03CR) 10DCausse: [C: 031] Prepare replacement of selenium-CirrusSearch job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [10:06:50] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CentralNotice, 10Regression: Central Notice does not work for logged in users - https://phabricator.wikimedia.org/T181953#3856329 (10IKhitron) I'm sorry. My English is not good, so I did not understand the three last posts. Not about the United Blood Nat... [10:08:52] (03PS2) 10星耀晨曦: Compatible with php7.2, avoid passing null to count() [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/398225 (https://phabricator.wikimedia.org/T182847) [10:10:58] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10I18n, and 2 others: Wikidata textarea are LTR for RTL labels - https://phabricator.wikimedia.org/T181340#3856331 (10IKhitron) I can't eaither. Even on a tablet, that regularly works badly with such things. [10:14:45] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10I18n, and 3 others: Wikidata textarea are LTR for RTL labels - https://phabricator.wikimedia.org/T181340#3856343 (10Ladsgroup) 05Open>03Resolved a:03Ladsgroup Bugs that get magically resolved, It's definitely Chr... [10:16:23] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#3856347 (10Fomafix) The main intent is to reduce redundancy on the definition to avoid inconsistencies and mistakes. This can solved on d... [10:26:55] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856367 (10zeljkofilipin) [10:29:04] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3856373 (10kai.nissen) [10:29:10] (03Abandoned) 10Pwirth: Removed entry point due to end of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/394300 (owner: 10Robert Vogel) [10:35:17] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856374 (10zeljkofilipin) [10:36:22] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3826900 (10zeljkofilipin) [10:39:20] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856377 (10zeljkofilipin) [10:41:29] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856378 (10zeljkofilipin) [10:44:42] (03CR) 10Robert Vogel: [C: 032] Fixed possible object when expected array in client config var for mlmLanguages [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/395984 (owner: 10Pwirth) [10:44:51] (03CR) 10Robert Vogel: [C: 032] Added switch language support [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/399362 (owner: 10Pwirth) [10:45:16] (03Merged) 10jenkins-bot: Fixed possible object when expected array in client config var for mlmLanguages [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/395984 (owner: 10Pwirth) [10:45:23] (03Merged) 10jenkins-bot: Added switch language support [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/399362 (owner: 10Pwirth) [10:46:14] refeed[m] oh, well, good morning here in Europe :P [10:46:27] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 4 others: MediaWiki\Storage\RevisionAccessException from line 217 of /srv/mediawiki/php-master/includes/Storage/RevisionStore.php Could not determine title for page ID 7... - https://phabricator.wikimedia.org/T183505#3856382 [10:46:47] still kinda sick, but I need to finish some shopping today, but I don't like going outside :( [10:47:54] (03CR) 10Hashar: "It would have been nice to at least fill a task about the build failure!" [cergen] - 10https://gerrit.wikimedia.org/r/394105 (owner: 10Ottomata) [10:49:55] And I am still in school :( Can't wait to get home and write some code :) [10:51:30] at home now, but tons of work to do... :/ [10:52:07] Phantom42: you guys don't have holidays now? [10:53:21] (03CR) 10DCausse: [C: 032] Move Lucene explain to outside library [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398608 (owner: 10Smalyshev) [10:54:16] and more to the point, you can use phones and stuff in school? o_O [10:54:27] cf_fairfeld: For me it is last day at school today. And what about you? [10:54:28] cf_fairfeld: For me it is last day at school today. And what about you? [10:54:44] Phantom42: ooh I see :) [10:54:55] Sorry if sent multiple times, Internet connection is bad here :( [10:55:23] our last day was today, celebration in school and all [10:55:32] skipped it though xD no one from our class was going [10:55:51] Haha :) [10:56:01] 10MediaWiki-Cache, 10MediaWiki-File-management, 10Commons: Deleting a file from a wiki AFTER moving to commons: pages on the original wiki linking to the file may have broken links until the page is purged - https://phabricator.wikimedia.org/T183478#3856384 (10Cparle) Thanks @Tgr ... I think I can see how to... [10:57:02] Phantom42: wait a sec, phones are allowed in your school? [10:59:38] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3856385 (10Pablo-WMDE) a:03Pablo-WMDE [10:59:48] cf_fairfeld: Formally no. But actually yes :D [11:00:22] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856399 (10zeljkofilipin) [11:00:38] (03PS1) 10Ladsgroup: Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 [11:00:53] Phantom42: woah, that's really cool :D [11:01:10] cf_fairfeld: Formally no. But actually yes :D [11:01:10] Was it sent twice again? 0_o [11:01:10] (03Merged) 10jenkins-bot: Move Lucene explain to outside library [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398608 (owner: 10Smalyshev) [11:01:27] Phantom42: haha yeah xD [11:02:53] if you bring phones to our school they threaten to drop them in water [11:03:00] never actually happened tho xD [11:04:58] 10Wikimedia-User-Group-Basque: FOPU baten prestaketa - https://phabricator.wikimedia.org/T178678#3856400 (10Theklan) Hementxe prestatutako dokumentua. Bidali dugu jada. Ideia da irakasleek 25 orduko ikastaroa egitea, aurrerantzean ere eurek proiektuak diseinatu ahal izateko. Bertaratzen diren irakasleek wikilari... [11:06:09] (03PS1) 10Addshore: [MCR] Add optional $title param to Revision byId methods [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) [11:06:21] (03CR) 10jerkins-bot: [V: 04-1] Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 (owner: 10Ladsgroup) [11:07:15] (03PS2) 10Addshore: Pass a Title to Revision::newFromId in onRevisionInsertComplete [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) [11:08:00] On the other hand phone is needed as a learning tool. I have all my books here in digital form, I use Wikipedia on some subjects (some teachers even encourage to do that), I draw graphs and charts etc. We are allowed to bring tablets too. On some subjects teachers even allow me to take notes in digital form! [11:08:36] However playing games and social networks are not allowed. That may end sadly :D [11:10:14] (03PS2) 10Ladsgroup: Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 [11:10:16] (03CR) 10Nikerabbit: [C: 04-1] Refactor and bump version to 1.3 (0320 comments) [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/398618 (owner: 10MarkAHershberger) [11:10:48] yeah... it's true [11:11:30] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856407 (10zeljkofilipin) [11:11:36] but technology isn't trusted that much in schools here xD we still have a long way to go [11:12:19] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3843317 (10zeljkofilipin) >>! In T181353#3854210, @Gilles wrote: > Out of curiosity, do all roles provision correctly on master? (Jessie) Done. Take a look at task description. [11:13:22] you'd never find a teacher here who'd encourage you to use phones in school [11:13:57] granted, it's true most students don't use them responsibly xD but they be really useful [11:14:06] they'd* [11:14:19] (03PS1) 10Fomafix: jquery.tablesorter.less: Simplify by using less syntax [core] - 10https://gerrit.wikimedia.org/r/399796 [11:14:26] most students in our school, anyway :P [11:15:55] (03Abandoned) 10Nikerabbit: Use MovePage if available [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/338325 (owner: 10Nikerabbit) [11:17:04] (03CR) 10Nikerabbit: [C: 032] jquery.tablesorter.less: Simplify by using less syntax [core] - 10https://gerrit.wikimedia.org/r/399796 (owner: 10Fomafix) [11:19:43] (03PS1) 10Hashar: Test run [cergen] - 10https://gerrit.wikimedia.org/r/399797 [11:20:16] (03CR) 10Sbisson: [C: 04-1] RCFilters: Only normalize title with 'target' when it is needed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399310 (owner: 10Mooeypoo) [11:20:27] (03CR) 10jerkins-bot: [V: 04-1] Test run [cergen] - 10https://gerrit.wikimedia.org/r/399797 (owner: 10Hashar) [11:22:32] (03Merged) 10jenkins-bot: jquery.tablesorter.less: Simplify by using less syntax [core] - 10https://gerrit.wikimedia.org/r/399796 (owner: 10Fomafix) [11:23:17] (03PS1) 10Hashar: Pin pyOpenSSL<17.5.0 [cergen] - 10https://gerrit.wikimedia.org/r/399798 [11:26:17] (03Abandoned) 10Hashar: Test run [cergen] - 10https://gerrit.wikimedia.org/r/399797 (owner: 10Hashar) [11:27:28] (03CR) 10Cparle: [V: 032 C: 032] Look at 3D objects from another angle [3d2png] - 10https://gerrit.wikimedia.org/r/398460 (https://phabricator.wikimedia.org/T179887) (owner: 10Matthias Mullie) [11:27:35] (03CR) 10Florianschmidtwelzow: [C: 032] [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [11:28:03] 10Wikimedia-Site-requests: Cherokee Wikipedias uses an outdated logo - https://phabricator.wikimedia.org/T180553#3761503 (10Fito) Looking forward to see this fixed; I’ve just uploaded new versions of the Cherokee Wikipedia v2 logos to Commons. [11:28:15] 10MediaWiki-Export-or-Import, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review, and 2 others: WikiImporter::notice echoing of unescaped values is a dangerous api - https://phabricator.wikimedia.org/T177997#3856457 (10Florian) 05Open>03Resolved a:03eflyjason [11:32:26] (03CR) 10Santhosh: [C: 04-1] Add UniversalLanguageSelector support (032 comments) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) (owner: 10MaxSem) [11:32:32] (03CR) 10jenkins-bot: jquery.tablesorter.less: Simplify by using less syntax [core] - 10https://gerrit.wikimedia.org/r/399796 (owner: 10Fomafix) [11:33:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Regression, 10User-thiemowmde, 10Wikidata-Sprint-2017-12-20: Can't see references on historic revisions of items on Wikidata - https://phabricator.wikimedia.org/T182767#3856465 (10thiemowmde) Thanks! This CSS workaround gives us time to figure out... [11:33:29] (03Merged) 10jenkins-bot: [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [11:36:23] (03CR) 10Ladsgroup: [MCR] Add optional $title param to Revision byId methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [11:44:27] (03CR) 10Sbisson: [C: 032] RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) (owner: 10Mooeypoo) [11:44:29] (03CR) 10jenkins-bot: [WikiImporter::notice] use wfDebug instead of echo in notice() [core] - 10https://gerrit.wikimedia.org/r/399770 (https://phabricator.wikimedia.org/T177997) (owner: 10Eflyjason) [11:47:55] (03CR) 10Zfilipin: [C: 032] Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [11:48:28] (03CR) 10Sbisson: Use new editor instead of old editor for undoing topic summary edits (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [11:50:19] (03Merged) 10jenkins-bot: RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) (owner: 10Mooeypoo) [11:54:47] (03Merged) 10jenkins-bot: Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [11:57:48] (03CR) 10Ladsgroup: Pass a Title to Revision::newFromId in onRevisionInsertComplete (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [11:59:55] (03CR) 10jenkins-bot: RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) (owner: 10Mooeypoo) [12:00:55] hello there! [12:02:38] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-06-02, and 4 others: [Task] Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration - https://phabricator.wikimedia.org/T88258#3856499 (10WMDE-leszek) [12:05:23] Albert221: hey! :) [12:05:50] Albert221: Hello :) [12:05:58] cf_fairfeld: :) [12:06:00] finally school break! [12:06:09] Albert221: Yeehaa! [12:06:19] d3r1ck: heey :D [12:06:30] cf_fairfeld: Hey hey! [12:08:21] Albert221: haha, happy holidays :) [12:20:16] (03PS1) 10Catrope: Follow-up fecdfacabd: unbreak creation of new summaries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 [12:20:18] (03PS3) 10Addshore: Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 (owner: 10Ladsgroup) [12:20:23] (03CR) 10Addshore: "PS3 just changes the assertEquals to assertSame" [core] - 10https://gerrit.wikimedia.org/r/399794 (owner: 10Ladsgroup) [12:20:48] (03CR) 10Addshore: [C: 032] Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 (owner: 10Ladsgroup) [12:21:15] (03CR) 10Addshore: Pass a Title to Revision::newFromId in onRevisionInsertComplete (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:21:53] (03PS3) 10Addshore: Pass a Title to Revision::newFromId in onRevisionInsertComplete [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) [12:22:38] (03PS2) 10Addshore: [MCR] Add optional $title param to Revision byId methods [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) [12:22:40] (03CR) 10jerkins-bot: [V: 04-1] Pass a Title to Revision::newFromId in onRevisionInsertComplete [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:23:27] (03CR) 10Catrope: Use new editor instead of old editor for undoing topic summary edits (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [12:23:34] (03PS5) 10Catrope: Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 [12:24:49] cf_fairfeld: Same case when I was still in JHS. In my school currently, I even bring my router to school xD [12:25:47] refeed[m]: woaaah XDD [12:28:27] (03Merged) 10jenkins-bot: Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 (owner: 10Ladsgroup) [12:31:30] refeed[m]: I need to move xD [12:31:43] (03CR) 10Catrope: "Some inline comments on the comments that I wrote yesterday. Didn't realize the patch was merged after I wrote these but before I submitte" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) (owner: 10Daniel Kinzler) [12:33:24] (03PS3) 10Addshore: [MCR] Add optional $title param to Revision byId methods [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) [12:33:32] (03CR) 10Addshore: "recheck" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:36:23] 10docker-pkg: Separate http and apt proxy - https://phabricator.wikimedia.org/T183545#3856519 (10hashar) [12:37:15] 10docker-pkg: Separate http and apt proxy - https://phabricator.wikimedia.org/T183545#3856529 (10hashar) p:05Triage>03Low My lame hack to skip http_proxy: ``` --- a/docker_pkg/builder.py +++ b/docker_pkg/builder.py @@ -34,7 +34,7 @@ class ImageFSM(object): def _is_published(self): """Check the... [12:37:44] (03CR) 10Catrope: [C: 032] [MCR] Add optional $title param to Revision byId methods [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:37:48] (03CR) 10Catrope: [C: 032] Pass a Title to Revision::newFromId in onRevisionInsertComplete [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:41:20] (03CR) 10jenkins-bot: Improve coverage of PageArchive [core] - 10https://gerrit.wikimedia.org/r/399794 (owner: 10Ladsgroup) [12:42:42] 10docker-pkg: .dockerignore is not used to filter the build context - https://phabricator.wikimedia.org/T183546#3856533 (10hashar) [12:43:00] (03Restored) 10Zfilipin: Selenium test: alerts and notices are visible after logging in [extensions/Echo] - 10https://gerrit.wikimedia.org/r/368409 (https://phabricator.wikimedia.org/T171848) (owner: 10Zfilipin) [12:43:34] (03Merged) 10jenkins-bot: [MCR] Add optional $title param to Revision byId methods [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:43:36] (03Merged) 10jenkins-bot: Pass a Title to Revision::newFromId in onRevisionInsertComplete [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/399764 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:52:15] (03CR) 10Catrope: "In addition to your instructions, I had to run sudo ldconfig /opt/lib/v8 before ./configure would work" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398523 (owner: 10Sbisson) [12:53:05] (03CR) 10jenkins-bot: [MCR] Add optional $title param to Revision byId methods [core] - 10https://gerrit.wikimedia.org/r/399795 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [12:53:31] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - Ikasleen praktikak - https://phabricator.wikimedia.org/T183547#3856562 (10Theklan) p:05Triage>03High [12:55:17] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 4 others: MediaWiki\Storage\RevisionAccessException from line 217 of /srv/mediawiki/php-master/includes/Storage/RevisionStore.php Could not determine title for page ID 7... - https://phabricator.wikimedia.org/T183505#3856574 [12:57:25] cf_fairfeld: Haha :D [12:57:56] 10MediaWiki-extensions-Other, 10Patch-For-Review: Add phpcs to Description2 - https://phabricator.wikimedia.org/T183532#3856582 (10Aklapper) [12:59:08] 10MediaWiki-API, 10MediaWiki-User-management: API action=block allows blocking non-existent accounts - https://phabricator.wikimedia.org/T183211#3856583 (10Aklapper) [13:00:04] (03CR) 10Catrope: Add change_tag_statistics table to speed up tag hitcount retrieval (031 comment) [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [13:00:52] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - Ikasleen praktikak - https://phabricator.wikimedia.org/T183547#3856585 (10Theklan) p:05High>03Low Praktika proposamena bidalita! [13:04:13] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionStore.php: Could not determine title for page ID and revision ID - https://phabricator.wikimedia.org/T183548#3856591 (10Addshore) [13:04:24] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionStore.php: Could not determine title for page ID and revision ID - https://phabricator.wikimedia.org/T183548#3856604 (10Addshore) p:05Triage>03Unbreak! [13:07:18] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionStore.php: Could not determine title for page ID and revision ID - https://phabricator.wikimedia.org/T183548#3856607 (10Addshore) I just managed to create a tlak page with 2 revisions, delete and und... [13:07:39] (03PS1) 10Petar.petkovic: Fix detached RCFilters menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/399802 (https://phabricator.wikimedia.org/T183442) [13:08:28] (03PS1) 10Zfilipin: Update YARD Ruby gem [vagrant] - 10https://gerrit.wikimedia.org/r/399803 (https://phabricator.wikimedia.org/T183440) [13:11:53] (03CR) 10Nikerabbit: "recheck" [extensions/Babel] - 10https://gerrit.wikimedia.org/r/385852 (https://phabricator.wikimedia.org/T178782) (owner: 10Iniquity) [13:12:24] (03PS4) 10Robert Vogel: Use of DFD module and some new features [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/398663 [13:13:31] (03PS4) 10Robert Vogel: Refactor UserMiniProfile and UserProfileImage DFD-Module [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/398659 [13:15:10] (03PS4) 10Robert Vogel: [WIP] New task interfaces [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/378863 [13:17:49] (03CR) 10jerkins-bot: [V: 04-1] Adaptive design for babel-box and turning on CSS for mobile version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/385852 (https://phabricator.wikimedia.org/T178782) (owner: 10Iniquity) [13:27:59] 10Dumps-Generation: Dumps for dewiktionary not created on 20171220 - https://phabricator.wikimedia.org/T183535#3856651 (10Aklapper) [13:28:01] (03CR) 10Catrope: "BTW you should probably not link to the php7 instructions when telling people how to build against php5.6. The php5 instructions are here:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398523 (owner: 10Sbisson) [13:29:36] (03CR) 10Sbisson: "> BTW you should probably not link to the php7 instructions when" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398523 (owner: 10Sbisson) [13:30:48] 10MediaWiki-Export-or-Import, 10Multi-Content-Revisions, 10User-Addshore: Import failed: Could not determine title for page ID X and revision ID Y - https://phabricator.wikimedia.org/T183550#3856656 (10Addshore) [13:32:59] (03CR) 10Sbisson: "> > BTW you should probably not link to the php7 instructions when" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398523 (owner: 10Sbisson) [13:33:59] 10MediaWiki-Export-or-Import, 10Multi-Content-Revisions, 10User-Addshore: Import failed: Could not determine title for page ID X and revision ID Y - https://phabricator.wikimedia.org/T183550#3856681 (10Addshore) [13:35:40] (03CR) 10Thiemo Kreuz (WMDE): Follow-up fecdfacabd: unbreak creation of new summaries (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 (owner: 10Catrope) [13:35:59] 10Wikimedia-User-Group-Basque: Itzulpenen kudeaketa - https://phabricator.wikimedia.org/T176658#3856682 (10Xabier.Armendaritz) [13:36:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Compatible with php7.2, avoid passing null to count() [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/398225 (https://phabricator.wikimedia.org/T182847) (owner: 10星耀晨曦) [13:37:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Remove ESLint inline comments in WebdriverIO configuration files [core] - 10https://gerrit.wikimedia.org/r/399656 (https://phabricator.wikimedia.org/T175179) (owner: 10Zfilipin) [13:37:13] (03Merged) 10jenkins-bot: Compatible with php7.2, avoid passing null to count() [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/398225 (https://phabricator.wikimedia.org/T182847) (owner: 10星耀晨曦) [13:38:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add .idea to ignore file [tools/cookiecutter-library] - 10https://gerrit.wikimedia.org/r/399784 (owner: 10Smalyshev) [13:38:53] (03Merged) 10jenkins-bot: Add .idea to ignore file [tools/cookiecutter-library] - 10https://gerrit.wikimedia.org/r/399784 (owner: 10Smalyshev) [13:41:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] MobileContextTest: Fix invalid @covers tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399778 (https://phabricator.wikimedia.org/T183529) (owner: 10Legoktm) [13:41:37] Hey, everyone. I'm here on the IRC for the Google Code-in. [13:42:09] lostinenigma: Welcome! Good luck with GCI tasks! [13:42:44] Thanks. I hope I learn something new here! [13:42:57] (03CR) 10Pmiazga: When showing history include the namespace text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) (owner: 10Pmiazga) [13:43:31] lostinenigma: You definitely will! There is always something new and interesting here :) [13:44:25] (03Merged) 10jenkins-bot: Remove ESLint inline comments in WebdriverIO configuration files [core] - 10https://gerrit.wikimedia.org/r/399656 (https://phabricator.wikimedia.org/T175179) (owner: 10Zfilipin) [13:44:27] (03CR) 10Thiemo Kreuz (WMDE): Changed &$this in hooks (032 comments) [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [13:44:35] hi lostinenigma! [13:44:57] Hi! [13:46:17] (03CR) 10Thiemo Kreuz (WMDE): Changed &$this in hooks (032 comments) [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [13:47:15] (03PS5) 10Pmiazga: When showing history include the namespace text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) [13:47:28] lostinenigma: Welcome! [13:48:39] Hi. I was just reading up about what exactly an IRC is. [13:48:54] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionStore.php: Could not determine title for page ID and revision ID in User::updateNewtalk - https://phabricator.wikimedia.org/T183548#3856701 (10Addshore) [13:49:17] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3856703 (10zeljkofilipin) [13:49:19] (03PS6) 10Pmiazga: When showing history include the namespace text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) [13:49:21] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 5 others: RevisionStore.php Could not determine title for page ID X and revision ID Y in EventBus::createRevisionAttrs - https://phabricator.wikimedia.org/T183505#3856704 (10Addshore) [13:49:25] (03Merged) 10jenkins-bot: MobileContextTest: Fix invalid @covers tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399778 (https://phabricator.wikimedia.org/T183529) (owner: 10Legoktm) [13:49:55] 10MediaWiki-Page-deletion: Nuke suggests to delete already deleted pages - https://phabricator.wikimedia.org/T183552#3856705 (10IKhitron) [13:51:11] So? What exactly do people here talk about? [13:51:44] lostinenigma: Here we discuss questions related to development [13:51:46] Development [13:52:05] And sometimes we talk about code that works [13:52:08] xD [13:52:15] Nice.:D [13:52:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I can't support this change. The suggested label is way to long and wraps over five lines. What is wrong with the explanatory text below?" [core] - 10https://gerrit.wikimedia.org/r/399673 (https://phabricator.wikimedia.org/T183030) (owner: 10Petar.petkovic) [13:53:24] I'm new to IRCs. Can someone explain what's going on with the "wikibugs"? [13:53:58] It is a bot which posts updates from Wikimedia bug tracker [13:54:06] phabricator.wikimedia.org [13:54:24] (03CR) 10jenkins-bot: MobileContextTest: Fix invalid @covers tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399778 (https://phabricator.wikimedia.org/T183529) (owner: 10Legoktm) [13:54:57] 10MediaWiki-extensions-Nuke, 10MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), 10User-Ladsgroup: Add confirmation feature to Nuke extension - https://phabricator.wikimedia.org/T131975#3856730 (10IKhitron) Hi, @Ladsgroup, @Jdforrester-WMF. I just used Nuke first time from this task was closed, a... [13:55:25] (03CR) 10jenkins-bot: Remove ESLint inline comments in WebdriverIO configuration files [core] - 10https://gerrit.wikimedia.org/r/399656 (https://phabricator.wikimedia.org/T175179) (owner: 10Zfilipin) [13:57:04] Oh. So, now we can actually use the link and go find out about the bugs this bot updates? [13:57:36] (03CR) 10Catrope: [EXPERIMENTAL] Isomorphic react app (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398523 (owner: 10Sbisson) [13:57:45] Yes. All information is on Phabricator. Bot just posts updates here [13:58:13] (03PS1) 10Sharvaniharan: On-this-day minor ui fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399810 (https://phabricator.wikimedia.org/T180372) [13:59:58] Hi - I am newbie. [14:00:06] Welcome! [14:00:17] I am on IRC for Google Code-In task [14:00:23] newbie|2: Welcome :) [14:01:37] (03CR) 10Sbisson: [C: 032] Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [14:01:50] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Clear reading lists from the server if an existing reading list user opts out of reading list sync - https://phabricator.wikimedia.org/T167311#3856742 (10RHo) [14:03:08] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Clear reading lists from the server if an existing reading list user opts out of reading list sync - https://phabricator.wikimedia.org/T167311#3324331 (10RHo) [14:06:44] (03CR) 10Petar.petkovic: "> I can't support this change. The suggested label is way to long and" [core] - 10https://gerrit.wikimedia.org/r/399673 (https://phabricator.wikimedia.org/T183030) (owner: 10Petar.petkovic) [14:07:56] (03CR) 10Petar.petkovic: "> > I can't support this change. The suggested label is way to long" [core] - 10https://gerrit.wikimedia.org/r/399673 (https://phabricator.wikimedia.org/T183030) (owner: 10Petar.petkovic) [14:09:25] (03CR) 10Catrope: Follow-up fecdfacabd: unbreak creation of new summaries (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 (owner: 10Catrope) [14:11:05] (03Merged) 10jenkins-bot: Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [14:11:25] (03CR) 10jenkins-bot: Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [14:13:01] 10BlueSky, 10NewPHP: Warning: count(): Parameter must be an array or an object that implements Countable in BlueSky/BlueSkyTemplate.php on line 29 - https://phabricator.wikimedia.org/T182847#3856757 (10RazeSoldier) 05Open>03Resolved [14:14:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-Wishlist-Survey-2016, 10Goal: [Goal] Sitelinks to Incubator, OldWikisource and BetaWikiversity - https://phabricator.wikimedia.org/T54971#3856761 (10StevenJ81) That was well-said, @Billinghurst . Thank you. [14:14:51] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): MobileContextTest has invalid @covers tag - https://phabricator.wikimedia.org/T183529#3856762 (10bmansurov) 05Open>03Resolved [14:14:54] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3856764 (10bmansurov) [14:19:03] (03PS2) 10Sharvaniharan: On-this-day minor ui fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399810 (https://phabricator.wikimedia.org/T180372) [14:19:38] 10Mobile-Web-Settings, 10Readers-Web-Backlog: 'Expand all section' toggle should work on tablets and desktops - https://phabricator.wikimedia.org/T183493#3856772 (10bmansurov) How about we hide the "Expand all sections" on tablets? As far as I know tablets never had the section toggling feature. [14:22:28] 10MediaWiki-extensions-Nuke: Nuke suggests to delete already deleted pages - https://phabricator.wikimedia.org/T183552#3856778 (10Aklapper) [14:25:19] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3856783 (10Sharvaniharan) @RHo I have fixed this. Please take a look at this and let me know... [14:27:01] 10Dumps-Generation: Dumps for dewiktionary not created on 20171220 - https://phabricator.wikimedia.org/T183535#3856789 (10Formatierer) This seems to be a general problem for all wikis. None of the links on the pages dumps.wikimedia.org/*/20171220/ can be found. [14:27:11] (03PS1) 10Addshore: [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) [14:28:23] (03PS2) 10Addshore: [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) [14:29:24] (03PS2) 10Catrope: Follow-up fecdfacabd: unbreak creation of new summaries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 [14:29:39] 10MediaWiki-Export-or-Import, 10Multi-Content-Revisions, 10User-Addshore: Import failed: Could not determine title for page ID X and revision ID Y - https://phabricator.wikimedia.org/T183550#3856794 (10Addshore) p:05Triage>03Unbreak! a:03Addshore [14:29:59] lostinenigma we also talk here offtopic sometimes, feel free to talk about everything here and don't fear to ask ;) [14:30:28] (03CR) 10Catrope: [C: 032] [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) (owner: 10Addshore) [14:30:31] * divadsn finally arrived back home after being stuck for 2 hours in christmas shopping jam [14:31:27] Yeah. Definitely. [14:32:36] 10MediaWiki-Vagrant, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3856800 (10zeljkofilipin) @bd808 @dduvall I would like to set up CI for #mediawiki-vagrant. The g... [14:32:58] (03CR) 10Petar.petkovic: "This caused menu to be detached, as it turns out we don't want `position` property override that this patch introduces. T183442." [skins/Vector] - 10https://gerrit.wikimedia.org/r/397978 (https://phabricator.wikimedia.org/T182711) (owner: 10Bartosz Dziewoński) [14:33:01] (03PS5) 10Sbisson: Remove the old editor system [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 (owner: 10Catrope) [14:34:13] 10Design, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Update fontstack on mobile web to use system typefaces - https://phabricator.wikimedia.org/T175877#3856815 (10Jdrewniak) I've taken many screenshots http://public.j4n.co/fontstack/ios_9.2_Safari.html (and I'll take even more when I get a foundation... [14:35:23] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-06-02, and 4 others: [Task] Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration - https://phabricator.wikimedia.org/T88258#1007381 (10WMDE-leszek) a:03W... [14:35:38] 10LDAP: Drop 'svn' and 'svnadm' groups from LDAP - https://phabricator.wikimedia.org/T183508#3856818 (10demon) Hmm, my ldap search said 0 results. I thought that meant zero members but I think you're right it means zero groups :p [14:37:01] (03CR) 10Ladsgroup: Add change_tag_statistics table to speed up tag hitcount retrieval (031 comment) [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [14:37:32] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) (owner: 10Addshore) [14:38:24] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) (owner: 10Addshore) [14:38:44] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3856820 (10hashar) [14:40:47] (03PS3) 10Addshore: [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) [14:41:07] silly phpcs [14:41:58] RoanKattouw: ^^ could do with another +2 after a phpcs fix (one day I'll get into the habit of running that locally....) [14:42:24] (03CR) 10Zfilipin: "I'm working on running CirrusSearch tests from mediawiki/core." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [14:42:58] (03CR) 10Catrope: [C: 032] [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) (owner: 10Addshore) [14:43:15] 10Wikimedia-IEG-grant-review: Integrate with OAuth - https://phabricator.wikimedia.org/T74292#3856832 (10Nehajha) [14:44:32] (03CR) 10Sbisson: [C: 032] Follow-up fecdfacabd: unbreak creation of new summaries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 (owner: 10Catrope) [14:48:27] (03CR) 10Sbisson: "It seems to still work with all of this removed but here's two more cleanup opportunities:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 (owner: 10Catrope) [14:49:35] back in a bit [14:50:05] (03Merged) 10jenkins-bot: [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) (owner: 10Addshore) [14:50:51] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Fix layout alignment for WikiErrorView - https://phabricator.wikimedia.org/T183555#3856834 (10Sharvaniharan) [14:52:29] 10MinervaNeue, 10Readers-Web-Backlog: Browser test "Wikidata descriptions.Description appears on main namespace" is failing - https://phabricator.wikimedia.org/T183556#3856845 (10bmansurov) [14:53:23] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline - https://phabricator.wikimedia.org/T182803#3856856 (10Sharvaniharan) @Rho The Error view is an independent view that is... [14:53:45] (03Merged) 10jenkins-bot: Follow-up fecdfacabd: unbreak creation of new summaries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 (owner: 10Catrope) [14:54:15] (03CR) 10jenkins-bot: Follow-up fecdfacabd: unbreak creation of new summaries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399800 (owner: 10Catrope) [14:54:25] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Update messaging to clarify sync behavior is per account level - https://phabricator.wikimedia.org/T177516#3856857 (10RHo) [14:57:20] 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review, 10Reading Epics (Feed 2.0): Enable secondary actions on articles shown within On this day - https://phabricator.wikimedia.org/T180391#3856859 (10Jcasariego) This is how it looks using a long-press re-using the same component built when tapping on... [14:58:46] (03CR) 10Bmansurov: [C: 031] When showing history include the namespace text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) (owner: 10Pmiazga) [15:00:45] (03PS1) 10Lucas Werkmeister (WMDE): Add semantic tags to license info text [core] - 10https://gerrit.wikimedia.org/r/399818 [15:01:31] (03PS4) 10Jcasariego: Add actions on articles shown within "On this day" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399662 [15:01:58] (03CR) 10jenkins-bot: [MCR] Add and use $title param to RevisionStore getPrevious/Next [core] - 10https://gerrit.wikimedia.org/r/399812 (https://phabricator.wikimedia.org/T183548) (owner: 10Addshore) [15:03:18] (03CR) 10Lucas Werkmeister (WMDE): "Just a small idea I had :) WDYT?" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [15:04:10] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3856863 (10RHo) @Sharvaniharan - LGTM for QA. | {F11993308} | {F11993362} [15:05:29] (03CR) 10Esanders: "This needs to be merged before the next cut to unbreak from the change made in master." [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399616 (https://phabricator.wikimedia.org/T180678) (owner: 10Esanders) [15:07:01] (03CR) 10jerkins-bot: [V: 04-1] Add semantic tags to license info text [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [15:08:31] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint RadioActivewear, 10Fundraising Sprint Synchronized Screaming, and 5 others: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3856864 (10Pcoombe) Even after updating all the banners, we continued to... [15:09:59] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline - https://phabricator.wikimedia.org/T182803#3856871 (10RHo) hi @Sharvaniharan - i just took a look at the ticket T183555... [15:12:25] (03PS2) 10Lucas Werkmeister (WMDE): Add semantic tags to license info text [core] - 10https://gerrit.wikimedia.org/r/399818 [15:12:52] (03CR) 10Pmiazga: When showing history include the namespace text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) (owner: 10Pmiazga) [15:13:16] 10Operations-Software-Development, 10Patch-For-Review: Cumin: PuppetDB backend, add support for API v4 - https://phabricator.wikimedia.org/T182575#3856880 (10Volans) p:05Triage>03Normal [15:13:18] (03PS1) 10Zfilipin: Clean up ESLint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399822 (https://phabricator.wikimedia.org/T177262) [15:14:10] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Fix layout alignment for WikiErrorView - https://phabricator.wikimedia.org/T183555#3856834 (10RHo) Per my comment on T182803#3856871, error views appear to be aligned correctly at least in the Other languages and Search views when offline. C... [15:16:03] (03PS1) 10Zfilipin: Clean up ESLint configuration [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399823 (https://phabricator.wikimedia.org/T164024) [15:20:20] 10MediaWiki-Database, 10MediaWiki-Platform-Team, 10Multi-Content-Revisions, 10Epic, and 2 others: Compacting the revision table - https://phabricator.wikimedia.org/T161671#3856929 (10Anomie) [15:20:29] 10MediaWiki-Database, 10Community-Tech, 10Hindi-Sites, 10Malayalam-Sites, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#3856930 (10Anomie) [15:20:32] (03CR) 10Bmansurov: [C: 032] "Sorry, missed that part." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) (owner: 10Pmiazga) [15:20:34] (03CR) 10jerkins-bot: [V: 04-1] Add semantic tags to license info text [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [15:24:01] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Status classes (e.g. error) for field validity - https://phabricator.wikimedia.org/T182850#3856947 (10Pablo-WMDE) https://spenden.wikimedia.de/ [15:25:07] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Donate with foreign IBAN w/o adding BIC - https://phabricator.wikimedia.org/T181151#3856952 (10Pablo-WMDE) Deployed to https://spenden.wikimedia.de/ [15:27:52] (03Merged) 10jenkins-bot: When showing history include the namespace text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) (owner: 10Pmiazga) [15:30:09] (03CR) 10Phuedx: [C: 032] Clean up ESLint configuration [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399823 (https://phabricator.wikimedia.org/T164024) (owner: 10Zfilipin) [15:30:40] (03CR) 10jenkins-bot: When showing history include the namespace text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399660 (https://phabricator.wikimedia.org/T147722) (owner: 10Pmiazga) [15:34:09] (03Merged) 10jenkins-bot: Clean up ESLint configuration [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399823 (https://phabricator.wikimedia.org/T164024) (owner: 10Zfilipin) [15:36:06] 10Google-Code-in-2017: [Lua task #11] Create a general date-handling function - https://phabricator.wikimedia.org/T183560#3856977 (10RexxS) [15:36:14] 10Google-Code-in-2017: [Lua task #11] Create a general date-handling function - https://phabricator.wikimedia.org/T183560#3856987 (10RexxS) I will mentor this in Google-Code-in 2017. [15:37:02] 10Community-Liaisons (Oct-Dec 2017), 10Developer-Relations (Jan-Mar-2018): Documentation of Technical Collaboration's annual plan programs - https://phabricator.wikimedia.org/T170525#3856994 (10Qgil) [15:37:11] 10Community-Engagement-Insights, 10Community-Liaisons (Oct-Dec 2017), 10Developer-Relations (Jan-Mar-2018), 10Goal: Review CE Insights results and future questions for Technical Collaboration - https://phabricator.wikimedia.org/T170516#3856996 (10Qgil) [15:38:12] (03CR) 10Mobrovac: [C: 031] [Config] Rerender mobile-sectionss and summary on MW purge and null edit. [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/399692 (https://phabricator.wikimedia.org/T182953) (owner: 10Ppchelko) [15:38:48] 10Phabricator, 10Community-Liaisons, 10Developer-Relations (Jan-Mar-2018), 10Developer-Wishlist (2017), 10Goal: Consolidate the many tech events calendars in Phabricator's calendar - https://phabricator.wikimedia.org/T1035#3857005 (10Qgil) [15:38:50] 10Community-Liaisons (Oct-Dec 2017), 10Developer-Relations (Jan-Mar-2018): A CRM for Technical Collaboration - https://phabricator.wikimedia.org/T177583#3857008 (10Qgil) [15:39:33] 10Community-Liaisons (Oct-Dec 2017), 10Developer-Relations (Jan-Mar-2018): Technical Collaboration quarterly check in for October - December 2017 - https://phabricator.wikimedia.org/T175000#3857010 (10Qgil) [15:39:37] 10Developer-Relations (Jan-Mar-2018): Improve #wikimedia-devrel Freenode IRC channel topic: Link to how to contribute - https://phabricator.wikimedia.org/T179538#3857014 (10Qgil) [15:40:37] 10Community-Liaisons (Jan-Mar-2018), 10Developer-Relations (Jan-Mar-2018): Documentation of Technical Collaboration's annual plan programs - https://phabricator.wikimedia.org/T170525#3857024 (10Qgil) [15:40:48] 10Community-Engagement-Insights, 10Community-Liaisons (Jan-Mar-2018), 10Developer-Relations (Jan-Mar-2018), 10Goal: Review CE Insights results and future questions for Technical Collaboration - https://phabricator.wikimedia.org/T170516#3857027 (10Qgil) [15:41:12] 10Community-Liaisons (Jan-Mar-2018), 10Developer-Relations (Jan-Mar-2018): A CRM for Technical Collaboration - https://phabricator.wikimedia.org/T177583#3857034 (10Qgil) [15:41:40] 10Community-Liaisons (Jan-Mar-2018), 10Developer-Relations (Jan-Mar-2018): Technical Collaboration quarterly check in for October - December 2017 - https://phabricator.wikimedia.org/T175000#3857038 (10Qgil) [15:44:55] 10Wikimedia-Language-setup, 10Wikimedia-Site-requests: Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857043 (10MF-Warburg) [15:45:43] 10Wikimedia-Language-setup, 10Wikimedia-Site-requests: Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857053 (10MF-Warburg) This should be in #Wiki-Setup (Create), however that works. [15:47:40] 10Wikimedia-Language-setup, 10Wikimedia-Site-requests: Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857043 (10Jayprakash12345) Will Make Initial Config [15:49:39] (03PS6) 10Catrope: Remove the old editor system [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 [15:50:33] 10MediaWiki-Export-or-Import, 10Multi-Content-Revisions, 10User-Addshore: Import failed: Could not determine title for page ID X and revision ID Y - https://phabricator.wikimedia.org/T183550#3857058 (10Addshore) [15:50:35] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), and 2 others: RevisionStore.php: Could not determine title for page ID and revision ID in User::updateNewtalk - https://phabricator.wikimedia.org/T183548#3857061... [15:50:45] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), and 2 others: RevisionStore.php: Could not determine title for page ID and revision ID in User::updateNewtalk - https://phabricator.wikimedia.org/T183548#3856591... [15:57:49] (03CR) 10jerkins-bot: [V: 04-1] Remove the old editor system [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 (owner: 10Catrope) [15:59:05] 10Phabricator, 10LDAP: Having difficulty logging into Phabricator via LDAP when multiple accounts returned for username - https://phabricator.wikimedia.org/T138672#3857082 (10Andrew) @SMcCandlish sorry for the delay in responding, I'm trying to catch up here. Is the 'mech' account also you, or is that some ot... [15:59:27] (03PS6) 10Petar.petkovic: Cleanup live update feature flag and FilterWrapperWidget [core] - 10https://gerrit.wikimedia.org/r/395530 [15:59:57] (03PS1) 10Zfilipin: WIP Run selenium-EXTENSION-jessie Jenkins job for CirrusSearch [core] - 10https://gerrit.wikimedia.org/r/399833 (https://phabricator.wikimedia.org/T175179) [16:01:27] (03PS14) 10Zfilipin: Prepare replacement of selenium-CirrusSearch job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [16:02:32] (03CR) 10Zfilipin: "I'm doing something wrong:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [16:03:02] 10Design, 10MinervaNeue, 10Mobile-Web-Settings, 10MobileFrontend, and 4 others: Display namespace in mobile view of the page history - https://phabricator.wikimedia.org/T147722#2701617 (10pmiazga) [16:04:50] 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review, 10Reading Epics (Feed 2.0): Enable secondary actions on articles shown within On this day - https://phabricator.wikimedia.org/T180391#3857107 (10Jcasariego) Update: Sorry @RHo, I didn't see the comment about re-using the same component built when... [16:05:58] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: InvalidArgumentException from line 101 RevisionStoreRecord.php: The given Title does not belong to page ID 1187 - https://phabricator.wikimedia.org/T183564#3857108 (10Addshore) [16:06:11] 10MediaWiki-Page-deletion, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: InvalidArgumentException from line 101 RevisionStoreRecord.php: The given Title does not belong to page ID 1187 - https://phabricator.wikimedia.org/T183564#3857119 (10Addshore) p:05Triage>03Unbreak! [16:06:17] bah RoanKattouw, another one.... [16:06:47] From the surface it looks like this one is a new check failing, that we didn't have before RevisionStore [16:07:56] lostinenigma: Approved! :) [16:09:34] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [16:11:30] (03PS1) 10Hashar: rspec-puppet for all the roles [vagrant] - 10https://gerrit.wikimedia.org/r/399834 [16:12:29] (03CR) 10jerkins-bot: [V: 04-1] rspec-puppet for all the roles [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (owner: 10Hashar) [16:14:32] (03CR) 10BryanDavis: "I fear that if this lands we will have a very difficult time merging in the stretch-migration branch later. That branch already has a lot " [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (owner: 10Hashar) [16:17:04] * Albert221 goes to a concert so he'll be afk for several hours [16:17:20] (03CR) 10Petar.petkovic: "> This change keeps the ability to disable Live Update (see" [core] - 10https://gerrit.wikimedia.org/r/395530 (owner: 10Petar.petkovic) [16:23:20] (03PS26) 10Anomie: Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) [16:23:51] 10Wiki-Setup, 10Patch-For-Review: Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857148 (10Urbanecm) [16:24:00] 10Wiki-Setup, 10Patch-For-Review: Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857043 (10Urbanecm) p:05Triage>03Low [16:24:10] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857043 (10Urbanecm) [16:24:14] (03PS2) 10Hashar: rspec-puppet for all the roles [vagrant] - 10https://gerrit.wikimedia.org/r/399834 [16:24:16] (03CR) 10Hashar: "Set processorcount fact to fix a few roles." [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (owner: 10Hashar) [16:25:52] 10Dumps-Generation: Dumps for dewiktionary not created on 20171220 - https://phabricator.wikimedia.org/T183535#3857166 (10Aklapper) Feel free to adjust the task summary accordingly :) [16:26:01] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857167 (10Jayprakash12345) [16:26:06] 10Dumps-Generation: No dumps created / available for 20171220 - https://phabricator.wikimedia.org/T183535#3857168 (10Aklapper) [16:27:27] 10Dumps-Generation: No dumps created / available for 20171220 - https://phabricator.wikimedia.org/T183535#3856280 (10ArielGlenn) Welp, didn't see this until after fixing it. The rsync was broken. Well, to be exact, I broke it during recent puppet manifest cleanups, getting the source path wrong. https://gerri... [16:27:31] (03CR) 10jerkins-bot: [V: 04-1] rspec-puppet for all the roles [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (owner: 10Hashar) [16:27:52] 10Dumps-Generation: Dumps not available for download for 20171220 - https://phabricator.wikimedia.org/T183535#3857173 (10ArielGlenn) [16:28:44] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Validate @covers tags during normal test runs - https://phabricator.wikimedia.org/T171899#3857176 (10Legoktm) [16:28:47] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: CirrusSearch\UtilTest has invalid @covers tag - https://phabricator.wikimedia.org/T183530#3857174 (10Legoktm) 05Open>03Resolved a:03Legoktm [16:29:14] 10Dumps-Generation: Dumps not available for download for 20171220 - https://phabricator.wikimedia.org/T183535#3856280 (10ArielGlenn) a:03ArielGlenn [16:29:57] 10MediaWiki-Vagrant, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3857197 (10bd808) @zeljkofilipin I have added you as a project admin so that you can create new V... [16:30:11] * divadsn winks to Albert221 "have fun" [16:34:18] (03CR) 10Umherirrender: [C: 032] Do not assume composer installation [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/397609 (owner: 10Notartom) [16:35:30] (03Merged) 10jenkins-bot: Do not assume composer installation [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/397609 (owner: 10Notartom) [16:39:42] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Easy: Make CentralNotice banner completely believe it to be in a certain country - https://phabricator.wikimedia.org/T111071#3857212 (10Pcoombe) 05Open>03Resolved a:03Pcoombe You can now use `mw.centralNotice.data.country` in the banner cod... [16:41:02] (03PS2) 10DCausse: [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) [16:42:30] (03PS1) 10Addshore: [MCR] Revision::newFromArchiveRow convert overrides for rows [core] - 10https://gerrit.wikimedia.org/r/399838 (https://phabricator.wikimedia.org/T183564) [16:43:57] 10Accessibility, 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), and 3 others: Align GettingStarted colors to WikimediaUI palette ones - https://phabricator.wikimedia.org/T177712#3857237 (10Etonkovidova) @Volker_E I got the same p... [16:46:55] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline - https://phabricator.wikimedia.org/T182803#3857243 (10Sharvaniharan) @RHo we can take the same image that you have pos... [16:47:16] (03CR) 10Anomie: "I used to have a fake replica in my local configuration. Then it got broke, and I removed it. Aaron's suggested configuration looks even m" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [16:47:30] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [16:47:47] (03CR) 10Catrope: [C: 032] [MCR] Revision::newFromArchiveRow convert overrides for rows [core] - 10https://gerrit.wikimedia.org/r/399838 (https://phabricator.wikimedia.org/T183564) (owner: 10Addshore) [16:47:59] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 5 others: RevisionStore.php Could not determine title for page ID X and revision ID Y in EventBus::createRevisionAttrs - https://phabricator.wikimedia.org/T183505#3855484 (10mwjames) > [mediawiki/core@master] [MCR] Add... [16:48:10] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Fix layout alignment for WikiErrorView - https://phabricator.wikimedia.org/T183555#3857248 (10Sharvaniharan) @RHo we can take the same image that you have posted as an example... it actually is not vertically centered, it is off by around 32... [16:48:39] 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10UI-Standardization-Kanban: GettingStarted on other pages: Use flexible width for dialog if possible - https://phabricator.wikimedia.org/T183517#3857249 (10Eto... [16:49:32] 10MediaWiki-Vagrant, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857273 (10hashar) p:05Triage>03Normal [16:53:27] (03Merged) 10jenkins-bot: [MCR] Revision::newFromArchiveRow convert overrides for rows [core] - 10https://gerrit.wikimedia.org/r/399838 (https://phabricator.wikimedia.org/T183564) (owner: 10Addshore) [16:55:45] (03CR) 10Mwjames: "Would this prevent TEMP table writes on a replica given that "... TEMPORARY table is visible only within the current session, and is drop" [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [16:56:38] (03CR) 10Anomie: Cache processed stylesheets during the parse (031 comment) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/394369 (owner: 10Anomie) [16:56:49] 10MediaWiki-General-or-Unknown, 10Analytics, 10EventBus, 10Multi-Content-Revisions, and 5 others: RevisionStore.php Could not determine title for page ID X and revision ID Y in EventBus::createRevisionAttrs - https://phabricator.wikimedia.org/T183505#3857378 (10Addshore) @mwjames Yup, you are absolutely ri... [16:57:14] (03PS3) 10DCausse: [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) [16:57:41] 10MediaWiki-History-or-Diffs, 10MediaWiki-Special-pages: MergeHistory: timestamp-based midpoints are not sufficient - https://phabricator.wikimedia.org/T183501#3855404 (10Umherirrender) revision IDs are not linear. Imports from other wikis with older timestamps or restore from old revisions without a revision... [16:58:28] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3857388 (10D3r1ck01) [16:58:58] 10MediaWiki-extensions-SendGrid: Delay sending email for 1 min and try again if first attempt fails for some reason in SendGrid extension - https://phabricator.wikimedia.org/T174500#3857401 (10D3r1ck01) [16:59:27] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [16:59:58] 10MediaWiki-extensions-SendGrid: Delay sending email for 1 min and try again if first attempt fails for some reason in SendGrid extension - https://phabricator.wikimedia.org/T174500#3563996 (10D3r1ck01) 05Open>03declined Will need more investigation before adding such a feature if at all it's needed. [17:01:53] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers, 10Patch-For-Review: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3857405 (10D3r1ck01) a:05D3r1ck01>03None Leaving this up for someone else with better Mark-Down skills to improve on the READM... [17:02:15] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3857407 (10D3r1ck01) p:05Low>03Normal [17:03:13] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline - https://phabricator.wikimedia.org/T182803#3857411 (10RHo) Ah fair enough @Sharvaniharan - in that case can this be pla... [17:03:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [17:04:05] (03CR) 10jenkins-bot: [MCR] Revision::newFromArchiveRow convert overrides for rows [core] - 10https://gerrit.wikimedia.org/r/399838 (https://phabricator.wikimedia.org/T183564) (owner: 10Addshore) [17:04:34] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline - https://phabricator.wikimedia.org/T182803#3857412 (10Sharvaniharan) Yes... i feel so too... [17:07:01] 10MediaWiki-extensions-SendGrid: PHPUnit tests for the SendGrid extension - https://phabricator.wikimedia.org/T183572#3857416 (10D3r1ck01) [17:07:26] (03CR) 10DCausse: "I need to check how wikibase registers its rescore components" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [17:08:07] (03PS4) 10DCausse: [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) [17:11:43] (03PS1) 10D3r1ck01: Add role sendgrid.pp to MW-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/399844 (https://phabricator.wikimedia.org/T183571) [17:12:10] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3857439 (10Tgr) >>! In T181353#3854274, @zeljkofilipin wrote: > > I had the same thought. I can not run two mediawiki-vagrant machines at the same time (because of conflicting ports) You need... [17:14:26] (03PS1) 10Sbisson: RCLFilters: support longuer page names [core] - 10https://gerrit.wikimedia.org/r/399847 (https://phabricator.wikimedia.org/T183484) [17:14:56] (03PS2) 10BryanDavis: Update YARD Ruby gem [vagrant] - 10https://gerrit.wikimedia.org/r/399803 (https://phabricator.wikimedia.org/T183440) (owner: 10Zfilipin) [17:15:13] (03CR) 10BryanDavis: [C: 032] Update YARD Ruby gem [vagrant] - 10https://gerrit.wikimedia.org/r/399803 (https://phabricator.wikimedia.org/T183440) (owner: 10Zfilipin) [17:15:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [17:16:17] (03Merged) 10jenkins-bot: Update YARD Ruby gem [vagrant] - 10https://gerrit.wikimedia.org/r/399803 (https://phabricator.wikimedia.org/T183440) (owner: 10Zfilipin) [17:17:18] (03CR) 10jenkins-bot: Update YARD Ruby gem [vagrant] - 10https://gerrit.wikimedia.org/r/399803 (https://phabricator.wikimedia.org/T183440) (owner: 10Zfilipin) [17:17:56] (03CR) 10Anomie: [C: 04-1] "Found a bug when testing PG." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T183486) (owner: 10Daniel Kinzler) [17:19:40] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [17:22:41] (03CR) 10Anomie: [C: 04-1] Push pagination decision for prefix search into SearchEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399312 (owner: 10EBernhardson) [17:25:33] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Ekonomia eta Enpresa eskola - https://phabricator.wikimedia.org/T180594#3857452 (10Theklan) Korreoa bidalita. Irakasle gutxi etorri ziren, eta aukerak ere ez zituzten handiak ikusi. [17:26:19] (03PS3) 10Hashar: rspec-puppet for all the roles [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (https://phabricator.wikimedia.org/T183570) [17:26:26] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Ingeniaritza fakultatea - https://phabricator.wikimedia.org/T176659#3857456 (10Theklan) Bilera egin zen, nahiko harrera onarekin. Ikusiko dugu zer ematen duen hemendik aurrera. [17:26:32] 10MediaWiki-extensions-DonationInterface, 10FR-Amazon, 10Fundraising-Backlog, 10Fundraising Sprint Winter Wanderland, 10Patch-For-Review: Amazon errors showing up as [Object object] - https://phabricator.wikimedia.org/T183477#3857457 (10Ejegg) p:05Triage>03High a:03Ejegg [17:26:56] (03CR) 10jerkins-bot: [V: 04-1] rspec-puppet for all the roles [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [17:27:07] 10MediaWiki-Releasing, 10MediaWiki-Vendor: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857465 (10demon) So I think what we should do is drop vendor from the REL1_xx branches. Then only extensions and skins will be submodules. Vendor will continue to be a "build... [17:29:51] (03PS1) 10Chad: Drop vendor from MW release branch [core] (REL1_29) - 10https://gerrit.wikimedia.org/r/399849 [17:29:59] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: Push Gerrit changes (notifications) to #wiki-dev-africa for some extension - https://phabricator.wikimedia.org/T183573#3857472 (10D3r1ck01) [17:30:03] 10MediaWiki-Vagrant, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857484 (10hashar) [17:33:07] (03CR) 10Mooeypoo: [C: 032] "Good catch, thanks Petar!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399802 (https://phabricator.wikimedia.org/T183442) (owner: 10Petar.petkovic) [17:33:09] (03PS3) 10Chad: Add REL1_27 submodules for bundled extensions/skins/vendor [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/399102 (https://phabricator.wikimedia.org/T172927) [17:33:48] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Test adding WMF logo to donation form on mobile - https://phabricator.wikimedia.org/T183574#3857487 (10Pcoombe) [17:35:06] (03Merged) 10jenkins-bot: Fix detached RCFilters menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/399802 (https://phabricator.wikimedia.org/T183442) (owner: 10Petar.petkovic) [17:35:09] (03PS1) 10Chad: Drop vendor from MW release branch [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/399852 [17:35:18] d3r1ck you're up? :) [17:35:41] (03CR) 10Hashar: "manifests/roles/ has some defines, skip them when we find /^define xxxx/" [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [17:36:38] (03PS1) 10Krinkle: resourceloader: Improve JavaScriptMinifier code coverage [core] - 10https://gerrit.wikimedia.org/r/399853 [17:36:46] I'm having trouble replicating the infobox from the task in order to test out some CSS hacks locally [17:36:50] https://phabricator.wikimedia.org/T168716 [17:36:54] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Test adding WMF logo to donation form on mobile - https://phabricator.wikimedia.org/T183574#3857512 (10Pcoombe) [17:38:03] 10Design, 10Marvin, 10Epic, 10Patch-For-Review: Implement grid & responsive system - https://phabricator.wikimedia.org/T175806#3857515 (10Niedzielski) a:03Niedzielski [17:38:19] (03CR) 10Petar.petkovic: "> Good catch, thanks Petar!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399802 (https://phabricator.wikimedia.org/T183442) (owner: 10Petar.petkovic) [17:41:07] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3857520 (10hashar) I have created a test suite that attempts to compile the puppet catalog for each of the roles ( T183570 and https://gerrit.wikimedia.org/r/#/c/399834/ ). It has a few failure... [17:41:28] divadsn: Always :D [17:41:40] Let me have a look [17:42:15] (03CR) 10MarkAHershberger: Refactor and bump version to 1.3 (0317 comments) [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/398618 (owner: 10MarkAHershberger) [17:42:33] divadsn: So now I got an issue, can't view images at the moment on phab so mostly I mentor only text based tickets [17:42:47] From what I see, seems the ticket has a lot of pictures so won't understand the ticket fully [17:43:06] Maybe Reedy or jdlrobson can help you out divadsn? [17:43:32] (03PS10) 10MarkAHershberger: Refactor and bump version to 1.3 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/398618 [17:43:56] Reedy, I know you're always here ;) [17:44:36] (03CR) 10jerkins-bot: [V: 04-1] Refactor and bump version to 1.3 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/398618 (owner: 10MarkAHershberger) [17:45:16] d3r1ck well the point is, I would just like to replicate a infobox to test it out, but when I copied that infobox all I see is just dead links pointing to non-existing template pages [17:45:39] I only found this on Google: https://www.mediawiki.org/wiki/Manual:Importing_Wikipedia_infoboxes_tutorial [17:46:01] Hmmm... Which info box? Can you link me to what you have done so far? [17:47:24] (03Draft2) 10Umherirrender: Use tabs in .phpcs.xml [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399854 [17:47:26] (03CR) 10Umherirrender: [C: 032] Use tabs in .phpcs.xml [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399854 (owner: 10Umherirrender) [17:47:28] (03PS1) 10Krinkle: JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag [core] - 10https://gerrit.wikimedia.org/r/399855 [17:47:29] https://cs.m.wikipedia.org/wiki/Jarmila_Kratochv%C3%ADlov%C3%A1 there is the infobox which is having some styling issues in mobile view, so I wanted to recreate it on my vagrant environment [17:47:30] (03PS1) 10Addshore: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) [17:48:05] (03CR) 10Krinkle: "Together with the parent commit, this achieves 100% coverage of JavaScriptMinifier." [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [17:48:24] 10MediaWiki-Vagrant, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857529 (10hashar) a:05zeljkofilipin>03hashar [17:49:11] (03Merged) 10jenkins-bot: Use tabs in .phpcs.xml [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399854 (owner: 10Umherirrender) [17:49:21] (03PS1) 10BryanDavis: motd: Remove double motd display [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399857 [17:49:36] 10MediaWiki-User-login-and-signup: allow lower-case user names - https://phabricator.wikimedia.org/T138147#3857530 (10Krinkle) [17:50:23] (03CR) 10MarkAHershberger: "Thanks for the review, Nikerabbit!" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/398618 (owner: 10MarkAHershberger) [17:51:56] (03CR) 10Umherirrender: BlueSpiceNamespaceManager: Change config (031 comment) [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/394030 (owner: 10Pmiguelpirzer) [17:52:29] (03PS3) 10MaxSem: Add UniversalLanguageSelector support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) [17:52:50] 10MediaWiki-Vagrant, 10Release-Engineering-Team (Kanban): Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3857537 (10hashar) p:05Triage>03Normal [17:52:58] bawolff: Welcome :) [17:53:02] bawolff: https://gerrit.wikimedia.org/r/#/c/399858 [17:54:39] Hi [17:54:51] Hey [17:55:03] that should probably be reviewed by whoever runs that bot [17:55:48] bawolff: Okay! [17:56:14] I guess legoktm has access and hashar too I think [17:56:53] (03CR) 10Paladox: [C: 031] Add role sendgrid.pp to MW-Vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/399844 (https://phabricator.wikimedia.org/T183571) (owner: 10D3r1ck01) [17:56:58] 10MediaWiki-Vagrant, 10Release-Engineering-Team (Kanban): Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3857550 (10bd808) On my stretch-migration testing VM: ``` $ vagrant ssh -- puppet --version 4.8.2 ``` ``` $ apt-cache show puppet Package: puppet Version: 4.8.2-... [17:59:46] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Medikuntza fakultatea - https://phabricator.wikimedia.org/T178680#3857552 (10Theklan) Oso bilera arrakastatsua izan zen, 18 irakasle etorri ziren. Informazioa bidali diet jada. [18:00:22] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - https://phabricator.wikimedia.org/T181659#3857553 (10Theklan) Biologiako irakasleak baino ez ziren etorri. Beste egun batean beste aurkezpen bat egin beharko dugu aurrerantzean. Informazioa bidali diet. [18:01:14] (03PS1) 10Krinkle: JavaScriptMinifier: Improve docs around parsing of regexp literals [core] - 10https://gerrit.wikimedia.org/r/399861 (https://phabricator.wikimedia.org/T75556) [18:03:43] hey, everyone! :) [18:04:32] (03PS1) 10Mooeypoo: Move the 'rcfilters overlay' rule to the RCFilters stylesheet [skins/Vector] - 10https://gerrit.wikimedia.org/r/399862 [18:04:41] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review, 10Wikimedia-log-errors: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - https://phabricator.wikimedia.org/T75556#3857578 (10Krinkle) a:03Krinkle @Od1n Thank you for your patch. To our knowledge... [18:04:58] cf_fairfeld: Hey! [18:05:15] (03PS1) 10Mooeypoo: RCFilters: Move product-specific rules into RCFilters styles [core] - 10https://gerrit.wikimedia.org/r/399863 [18:05:21] (03CR) 10jerkins-bot: [V: 04-1] Move the 'rcfilters overlay' rule to the RCFilters stylesheet [skins/Vector] - 10https://gerrit.wikimedia.org/r/399862 (owner: 10Mooeypoo) [18:06:13] (03CR) 10Catrope: [C: 032] RCFilters: Move product-specific rules into RCFilters styles [core] - 10https://gerrit.wikimedia.org/r/399863 (owner: 10Mooeypoo) [18:06:43] (03CR) 10Catrope: [C: 032] Move the 'rcfilters overlay' rule to the RCFilters stylesheet [skins/Vector] - 10https://gerrit.wikimedia.org/r/399862 (owner: 10Mooeypoo) [18:07:30] d3r1ck: hey! :D [18:07:39] hey cf_fairfeld [18:07:44] 10Wikimedia-User-Group-Basque: EHU - Gipuzkoako Campusa - Kimika Fakultatea - https://phabricator.wikimedia.org/T182787#3857585 (10Theklan) Bilera egin genuen eta dagoeneko martxan diren irakasle batzuk etorri ziren. Aberasgarria izan zen euren ikuspuntua entzuteko eta aurrera begira egon daitezkeen zailtasun ba... [18:08:06] divadsn: hey there! :) [18:08:31] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers, 10Patch-For-Review: Push Gerrit changes (notifications) to #wiki-dev-africa for some extension - https://phabricator.wikimedia.org/T183573#3857586 (10D3r1ck01) p:05Triage>03High [18:08:35] just got back from christmas shopping and stuff [18:08:38] am about done xD [18:08:57] 10MediaWiki-Vagrant, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review, 10Puppet: Create a MW-Vagrant role for SendGrid extension - https://phabricator.wikimedia.org/T183571#3857597 (10D3r1ck01) p:05Triage>03Normal [18:11:50] (03CR) 10Brian Wolff: [WIP] Add double escaping detection (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (owner: 10Albert221) [18:12:36] And I am giving up, I can't get it working xD [18:12:55] I am doing most stupid CSS edits to see if it works, but somehow I don't see the effect [18:14:15] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers, 10Wikibugs, 10Patch-For-Review: Push Gerrit changes (notifications) to #wiki-dev-africa for some extension - https://phabricator.wikimedia.org/T183573#3857603 (10D3r1ck01) [18:14:17] 10MediaWiki-extensions-LinkedWiki: handle https - https://phabricator.wikimedia.org/T183579#3857604 (10Jppialasse) [18:14:45] (03Merged) 10jenkins-bot: RCFilters: Move product-specific rules into RCFilters styles [core] - 10https://gerrit.wikimedia.org/r/399863 (owner: 10Mooeypoo) [18:14:47] (03Merged) 10jenkins-bot: Move the 'rcfilters overlay' rule to the RCFilters stylesheet [skins/Vector] - 10https://gerrit.wikimedia.org/r/399862 (owner: 10Mooeypoo) [18:15:17] (03CR) 10Anomie: [C: 04-1] [MCR] Don't require $title to be passed to Revision::newFromId (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [18:19:48] (03CR) 10Brian Wolff: [C: 04-1] [WIP] Add double escaping detection (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (owner: 10Albert221) [18:23:15] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857635 (10abhaynatu) [18:23:56] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3857647 (10D3r1ck01) [18:25:31] (03CR) 10jenkins-bot: RCFilters: Move product-specific rules into RCFilters styles [core] - 10https://gerrit.wikimedia.org/r/399863 (owner: 10Mooeypoo) [18:28:40] (03CR) 10Umherirrender: [C: 031] Fix all kinds of type safety warnings accross the code base [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399169 (owner: 10Thiemo Kreuz (WMDE)) [18:28:42] (03PS2) 10Sbisson: RCLFilters: support longer page names [core] - 10https://gerrit.wikimedia.org/r/399847 (https://phabricator.wikimedia.org/T183484) [18:31:27] (03CR) 10Imarlier: [C: 032] JavaScriptMinifier: Improve docs around parsing of regexp literals [core] - 10https://gerrit.wikimedia.org/r/399861 (https://phabricator.wikimedia.org/T75556) (owner: 10Krinkle) [18:32:49] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857635 (10Urbanecm) Hello, all projects run by the Wikimedia Foundation uses logo from server configuration. Wiki.png is no longer used as the source of logo. Wikis can still ask for anniversary logos by a) aski... [18:32:58] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857671 (10Urbanecm) 05Open>03Invalid [18:33:43] (03PS2) 10Ryan10145: Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) [18:34:17] (03CR) 10Imarlier: [C: 031] JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [18:35:23] (03PS2) 10Ryan10145: Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) [18:35:28] (03PS1) 10Divadsn: Fix infobox styles to work well with multiple column infobox rows [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399866 (https://phabricator.wikimedia.org/T168716) [18:35:30] (03CR) 10Krinkle: JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [18:35:32] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857679 (10abhaynatu) Thank you for your prompt reply. Do I need to create another request after January 2nd? Seems a bit inconvenient that we can't change logos at appropriate time on account of a code freeze but... [18:36:18] 10Phabricator: Change Kevin Smith to Deb T in Form 41 - https://phabricator.wikimedia.org/T183582#3857680 (10JAufrecht) [18:37:56] 10Design, 10MinervaNeue, 10Readers-Web-Backlog, 10Google-Code-in-2017, and 3 others: Mobile infobox styles do not work well with multiple column infobox rows - https://phabricator.wikimedia.org/T168716#3857691 (10divadsn) @Jdlrobson as you are my second mentor of the task on GCI and @D3r1ck01 isn't able to... [18:38:27] (03PS2) 10Krinkle: JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag [core] - 10https://gerrit.wikimedia.org/r/399855 [18:39:23] (03CR) 10Krinkle: "Checked usage across all Wikimedia Git repos, 0 usage of any of this methods parameters aside from $code, so good to go :) Thanks!" [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [18:39:25] (03PS2) 10Divadsn: Fix infobox styles to work well with multiple column infobox rows [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399866 (https://phabricator.wikimedia.org/T168716) [18:39:36] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857695 (10Urbanecm) You're welcome. The code freeze do not prevent you from using anniversary logos. Just get your local wiki sysop and edit MediaWiki:Common.css (example of edit is at https://en.wikipedia.org/w/i... [18:39:57] (03CR) 10Imarlier: [C: 032] resourceloader: Improve JavaScriptMinifier code coverage [core] - 10https://gerrit.wikimedia.org/r/399853 (owner: 10Krinkle) [18:40:48] 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10UI-Standardization-Kanban: GettingStarted on other pages: Use flexible width for dialog if possible - https://phabricator.wikimedia.org/T183517#3857701 (10Vol... [18:41:07] (03CR) 10Imarlier: [C: 031] JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag [core] - 10https://gerrit.wikimedia.org/r/399855 (owner: 10Krinkle) [18:42:08] 10Wikimedia-Site-requests, 10Chinese-Sites: Request to change namespaces of zh wikiquote - https://phabricator.wikimedia.org/T181374#3857704 (10Urbanecm) a:05Urbanecm>03None I have no clue what I should do next. [18:43:14] calling it a day [18:43:18] night, everyone :) [18:43:22] cf_fairfeld: Okay! [18:43:27] Good night! [18:43:35] See you around tomorrow cf_fairfeld [18:45:47] (03CR) 10jerkins-bot: [V: 04-1] Fix infobox styles to work well with multiple column infobox rows [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399866 (https://phabricator.wikimedia.org/T168716) (owner: 10Divadsn) [18:46:28] (03Merged) 10jenkins-bot: resourceloader: Improve JavaScriptMinifier code coverage [core] - 10https://gerrit.wikimedia.org/r/399853 (owner: 10Krinkle) [18:46:35] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3857715 (10Jayprakash12345) @MF-Warburg If Posible, Please give me svg logo file link. So that I can upload HD logo as well. Thank You [18:46:48] (03PS2) 10Addshore: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) [18:47:15] (03PS6) 10SamanthaNguyen: [DNM] v4.4.0 - New form in OOUI with previewing + byte limit features [extensions/Comments] - 10https://gerrit.wikimedia.org/r/380322 (https://phabricator.wikimedia.org/T156055) [18:47:46] (03CR) 10Krinkle: "Does this also check @covers in the docblock for the test class itself?" [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [18:47:50] are we merging mediawiki patches or are those on the deployment freeze as well? [18:48:41] (03PS1) 10Ebe123: Make image check precede MIDI check [extensions/Score] - 10https://gerrit.wikimedia.org/r/399868 (https://phabricator.wikimedia.org/T116392) [18:48:53] (03PS1) 10Umherirrender: Improve types in documentation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 [18:49:59] 10MediaWiki-extensions-Score, 10VisualEditor, 10Patch-For-Review, 10Upstream: Provide better error message when a Score is empty - https://phabricator.wikimedia.org/T116392#3857742 (10Ebe123) a:03Ebe123 Will do here. [18:50:03] (03CR) 10MarcoAurelio: "+2 anyone then :) ?" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/392081 (https://phabricator.wikimedia.org/T180818) (owner: 10MarcoAurelio) [18:51:21] 10MediaWiki-extensions-Score, 10VisualEditor, 10Patch-For-Review, 10Upstream: Provide better error message when a Score is empty - https://phabricator.wikimedia.org/T116392#3857744 (10Ebe123) [18:51:43] Hauskatze: There is not a freeze on master development. [18:51:46] Merging is fine :) [18:51:52] (03CR) 10Paladox: [C: 031] elasticsearch: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399773 (https://phabricator.wikimedia.org/T183305) (owner: 10BryanDavis) [18:52:13] However, there will not be new /wmf/ branches created next week, so in 2018 the first branch will contain more changes. [18:52:14] Krinkle: thanks :) [18:52:33] (03CR) 10Anomie: "Seems sane. Haven't tested." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [18:52:51] (03CR) 10Krinkle: [C: 032] Don't use non-namespaced HtmlFormatter [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/395143 (owner: 10Legoktm) [18:53:11] (03PS7) 10SamanthaNguyen: [DNM] v4.4.0 - New form in OOUI with previewing + byte limit features [extensions/Comments] - 10https://gerrit.wikimedia.org/r/380322 (https://phabricator.wikimedia.org/T156055) [18:53:55] (03PS3) 10Addshore: [MCR] Don't require $title to be passed to Revision::newFromId [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) [18:54:24] (03Merged) 10jenkins-bot: Don't use non-namespaced HtmlFormatter [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/395143 (owner: 10Legoktm) [18:55:15] (03CR) 10jenkins-bot: resourceloader: Improve JavaScriptMinifier code coverage [core] - 10https://gerrit.wikimedia.org/r/399853 (owner: 10Krinkle) [18:55:42] (03CR) 10Addshore: [V: 031] "Can be tested by having EventBus and core enabled and event bus on commit 40aaaba69330c6a0a537a833a2b998d092cc3199 (before it starts passi" [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [18:58:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I would like to give others a chance to have a look. Please poke me if this is not merged in a few days." [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [18:59:43] (03CR) 10Thiemo Kreuz (WMDE): "It looks like some whitespace has been changed by mistake (a newline added, and a space removed). Can you revert this, or was there a spec" [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [19:00:57] (03CR) 10EBernhardson: [C: 032] elasticsearch: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399773 (https://phabricator.wikimedia.org/T183305) (owner: 10BryanDavis) [19:00:59] (03PS1) 10Brian Wolff: Appearently this doesn't work with php-ast 0.1.5 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399873 [19:02:12] (03PS2) 10BryanDavis: motd: Remove double motd display [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399857 [19:02:45] (03Merged) 10jenkins-bot: elasticsearch: Use custom apt repo [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399773 (https://phabricator.wikimedia.org/T183305) (owner: 10BryanDavis) [19:02:47] (03CR) 10Brian Wolff: [C: 032] Appearently this doesn't work with php-ast 0.1.5 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399873 (owner: 10Brian Wolff) [19:03:10] (03PS1) 10Sharvaniharan: Update the user education message when user first saves an article to a reading list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399875 (https://phabricator.wikimedia.org/T183441) [19:03:47] (03CR) 10Krinkle: [MCR] Don't require $title to be passed to Revision::newFromId (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399856 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [19:04:33] (03CR) 10Legoktm: "Krinkle: Yep! If you look at the EventLogging failures, those are class-level @covers tags." [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [19:05:30] (03Merged) 10jenkins-bot: Appearently this doesn't work with php-ast 0.1.5 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399873 (owner: 10Brian Wolff) [19:06:29] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Update the user education message when user first saves an article to a reading list - https://phabricator.wikimedia.org/T183441#3857770 (10Sharvaniharan) a:03Sharvaniharan [19:07:23] 10MediaWiki-JobQueue, 10Performance-Team, 10Wikidata, 10Discovery-Search (Current work), 10Wikimedia-log-errors: Items missing from Wikidata index due to LinksUpdate lock failures - https://phabricator.wikimedia.org/T183101#3857771 (10Imarlier) Just throwing a couple of notes in here: Q45825741 and Q458... [19:07:27] (03PS6) 10Krinkle: Collect RUMSpeedIndex with NavigationTiming [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/392381 (https://phabricator.wikimedia.org/T180667) (owner: 10Gilles) [19:07:32] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Separate ChangeProp and JobQueue Redis - https://phabricator.wikimedia.org/T183586#3857772 (10Pchelolo) p:05Triage>03Normal [19:08:07] (03CR) 10BryanDavis: [C: 032] motd: Remove double motd display [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399857 (owner: 10BryanDavis) [19:09:09] (03Merged) 10jenkins-bot: motd: Remove double motd display [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399857 (owner: 10BryanDavis) [19:09:22] (03PS1) 10Niedzielski: Update: add grid [marvin] - 10https://gerrit.wikimedia.org/r/399877 (https://phabricator.wikimedia.org/T175806) [19:09:38] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857790 (10Legoktm) >>! In T172927#3857465, @demon wrote: > So I think what we should do is drop vendor from the REL1_xx branches. Then only extensions a... [19:09:52] 10Design, 10Marvin, 10Epic, 10Patch-For-Review: Implement grid & responsive system - https://phabricator.wikimedia.org/T175806#3857791 (10Niedzielski) [19:10:11] 10MediaWiki-Vagrant: "No wiki found" After setting up new wiki or reloading - https://phabricator.wikimedia.org/T183587#3857794 (10Paladox) [19:11:13] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3857804 (10RHo) [19:11:21] (03PS1) 10Umherirrender: Improve some parameter docs [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 [19:12:37] 10Wikipedia-Android-App-Backlog, 10Epic, 10Reading Epics (Synchronized Reading Lists): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3751114 (10RHo) [19:13:19] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 3 others: Separate ChangeProp and JobQueue Redis - https://phabricator.wikimedia.org/T183586#3857823 (10mobrovac) +1. Given the way Redis is used in CP and CP4JQ, we might want to set these separate instances up in Kubernetes as early as Q4! [19:14:07] (03PS3) 10Ryan10145: Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) [19:15:12] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3513508 (10Bawolff) > So I think what we should do is drop vendor from the REL1_xx branches. Then only extensions and skins will be submodules. Vendor wi... [19:17:18] (03CR) 10MaxSem: Add UniversalLanguageSelector support (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) (owner: 10MaxSem) [19:18:38] 10Epic, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3857829 (10RHo) [19:19:09] (03CR) 10Isarra: Change `pagemisc` portlet to `cactions` (031 comment) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399783 (https://phabricator.wikimedia.org/T181362) (owner: 10Evad37) [19:19:35] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/399880 [19:21:05] 10Wiki-Loves-Monuments (2017): Review WLM FAQ for being up to date and complete - https://phabricator.wikimedia.org/T183589#3857833 (10Effeietsanders) [19:27:31] (03PS2) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/399880 [19:28:25] (03CR) 10Umherirrender: "Patch Set 2: Sorted use statements" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/399880 (owner: 10Umherirrender) [19:30:57] 10Wikimedia-Site-requests: Need to switch logo on w:mr - https://phabricator.wikimedia.org/T183581#3857860 (10abhaynatu) Moved discussion to [[https://meta.wikimedia.org/wiki/User_talk:Martin_Urbanec]| Martin's talk page]] [19:32:43] (03PS2) 10Umherirrender: Improve some parameter docs [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 [19:33:24] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review, 10Regression: [BUG][REGRESSION] When offline in the feed, a message and call to action should be shown to attempt reload - https://phabricator.wikimedia.org/T183308#3857862 (10RHo) just reviewed this @cooltey and whilst the message is... [19:38:03] (03CR) 10Legoktm: "Errr, Thiemo, your comment isn't correct. We can't just remove the &, it'll break any existing hooks. Please see the linked bug, which exp" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [19:38:06] (03CR) 10Legoktm: [C: 04-1] Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [19:44:04] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CentralNotice, 10Regression: Central Notice does not work for logged in users - https://phabricator.wikimedia.org/T181953#3857863 (10TerraCodes) UBN means "unbreak now!", not "United Blood Nation" [19:44:09] 10OOjs-UI: MenuTagMultiselectWidget menu doesn't close properly when used with an overlay - https://phabricator.wikimedia.org/T183377#3857864 (10Mooeypoo) OK, as I suspected, this was $autoCloseIgnore. The widget adds the $overlay to the autoCloseIgnore, which is wrong -- it means that the menu won't close when... [19:45:39] hmm legoktm looks like I can just have 2 versions of the Revision class and swap them out in the autoloader based on a global :( [19:45:46] blerrggh [19:45:56] Unless I do something sneaky with class aliases..... [19:46:05] addshore: ehhh, autoloader.php runs before LocalSettings.php [19:46:11] 10MediaWiki-Database, 10Wikidata, 10User-Daniel: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3850657 (10ChristianKl) Could there be an option that a limit only kicks in when there's no free server capacity? It seems to me like we need a limit at times where no free serve... [19:46:28] class aliases might work? [19:46:37] yup, but I guess I can load both classes and RevisionMCR and RevisionNoMCR and then define an alias just after localsettings is loaded? [19:46:43] ewww that's brilliant [19:46:53] hah, eww [19:47:00] I'll give it a go [19:48:18] (03PS2) 10Umherirrender: Improve types in documentation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 [19:48:43] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857873 (10demon) >>! In T172927#3857790, @Legoktm wrote: >>>! In T172927#3857465, @demon wrote: >> So I think what we should do is drop vendor from the... [19:50:27] (03CR) 10Umherirrender: "Patch Set 2: Added use statement and changed @type to @var" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 (owner: 10Umherirrender) [19:51:33] (03CR) 10Krinkle: "Schema revision and ext code change looks fine. One minor point though, and a question." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/392381 (https://phabricator.wikimedia.org/T180667) (owner: 10Gilles) [19:52:54] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CentralNotice, 10Regression: Central Notice does not work for logged in users - https://phabricator.wikimedia.org/T181953#3857876 (10IKhitron) I see. So, it's not to me. [19:53:18] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857877 (10demon) This also raises an interesting question: should the bundled extensions be added as submodules on master as well? I think you could mak... [20:00:08] hmm, legoktm got to figure out how to make phan pass :P as I have no real class called Revision, i would have thought there is a way to force an alias down its throat [20:00:31] (03PS8) 10Ebe123: Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) [20:00:56] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399883 [20:01:51] oooh, pretend stub [20:01:57] (03CR) 10Ebe123: "OutputPage shouldn't be escaped, but parser yes. Right Nikerabbit?" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [20:06:53] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#3857903 (10Ebe123) 05Open>03stalled The new `-dcrop` option will be in the next stable release (2.20), which may be in the next few months. [20:07:42] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857905 (10Legoktm) >>! In T172927#3857873, @demon wrote: >>>! In T172927#3857790, @Legoktm wrote: >>>>! In T172927#3857465, @demon wrote: >>> So I think... [20:08:33] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#516065 (10Legoktm) YAY [20:09:07] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Fundraising Sprint Winter Wanderland, 10Patch-For-Review: Fatal error in Amount formatting - https://phabricator.wikimedia.org/T182737#3857913 (10Ejegg) p:05Triage>03Normal a:03Ejegg [20:09:44] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857919 (10demon) That's also a valid option [20:11:22] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/399886 [20:14:03] (03PS3) 10Ryan10145: Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) [20:15:13] 10MediaWiki-Special-pages, 10Collaboration-Team-Triage, 10TechCom-RfC: Introduce article creation log - https://phabricator.wikimedia.org/T12331#147694 (10kaldari) >A log seems overkill to me, do we really want log entries remaining after pages are deleted? A revision tag seems better to be IMO. @Legoktm: Th... [20:16:27] (03PS2) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399883 [20:21:09] (03PS3) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399883 [20:22:51] (03CR) 10Legoktm: "Looks good. Can you add a comment like" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [20:28:28] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/Cite] - 10https://gerrit.wikimedia.org/r/399890 [20:32:27] (03CR) 10Catrope: [C: 032] RCLFilters: support longer page names [core] - 10https://gerrit.wikimedia.org/r/399847 (https://phabricator.wikimedia.org/T183484) (owner: 10Sbisson) [20:34:40] (03PS7) 10Catrope: Remove the old editor system [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 [20:35:26] (03PS1) 10Ebe123: Add variables to score hash [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) [20:37:31] 10MediaWiki-extensions-Score, 10Patch-For-Review: Add version to Score hashes - https://phabricator.wikimedia.org/T49448#3857937 (10Ebe123) [20:37:54] 10MediaWiki-extensions-Score, 10Patch-For-Review: Add version to Score hashes - https://phabricator.wikimedia.org/T49448#497480 (10Ebe123) a:03Ebe123 [20:39:22] (03Merged) 10jenkins-bot: RCLFilters: support longer page names [core] - 10https://gerrit.wikimedia.org/r/399847 (https://phabricator.wikimedia.org/T183484) (owner: 10Sbisson) [20:40:20] (03CR) 10Reedy: [C: 04-1] Add variables to score hash (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [20:40:23] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/399896 [20:41:11] (03PS7) 10Addshore: Switch Revision MCR overhaul based on $wgUseMCRRevision [core] - 10https://gerrit.wikimedia.org/r/399881 [20:41:13] legoktm: ^^ well, PS7 but that should pass jenkins [20:42:36] (03PS1) 10Kaldari: Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) [20:42:38] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/399898 [20:42:59] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10Patch-For-Review: Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#3857947 (10Ebe123) [20:43:10] I guess i should probably switch some beta sites to not use mcr also... [20:43:38] (03CR) 10Kaldari: [C: 04-1] "Not ready yet :) Needs more discussion." [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [20:43:40] (03CR) 10Kaldari: [C: 04-2] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [20:44:43] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/399900 [20:47:52] (03PS2) 10Kaldari: [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) [20:48:29] (03CR) 10Legoktm: [C: 04-1] "I don't think we should use the extension version as the cache invalidator, there are probably times we should increment the version witho" [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [20:50:20] 10Design-Research, 10New-Editor-Experiences, 10Epic: Hold workshops to apply new editor experiences research - https://phabricator.wikimedia.org/T170715#3857950 (10Neil_P._Quinn_WMF) [20:50:22] 10Design-Research, 10New-Editor-Experiences: Plan concept evaluation workshop - https://phabricator.wikimedia.org/T179049#3857949 (10Neil_P._Quinn_WMF) 05Open>03Resolved [20:50:30] (03CR) 10jenkins-bot: RCLFilters: support longer page names [core] - 10https://gerrit.wikimedia.org/r/399847 (https://phabricator.wikimedia.org/T183484) (owner: 10Sbisson) [20:52:05] (03PS3) 10Umherirrender: Improve some parameter docs [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 [20:52:50] Wheee, it passed :) [20:52:54] right, I'm having a break [20:54:26] (03PS8) 10Addshore: Switch Revision MCR overhaul based on $wgUseMCRRevision [core] - 10https://gerrit.wikimedia.org/r/399881 (https://phabricator.wikimedia.org/T183592) [20:55:00] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [20:55:16] 10Release, 10Train Deployments: 1.31.0-wmf.15 deployment blockers - https://phabricator.wikimedia.org/T180748#3857979 (10Addshore) [20:55:33] (03PS2) 10Ebe123: Add variables to score hash [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) [20:57:41] (03CR) 10Ebe123: "Used your suggestion @Legoktm. I was thinking about the proper version for when SVG will be supported here. Having a proper constant for i" (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/399893 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [20:59:07] 10MediaWiki-extensions-Score, 10Patch-For-Review: Add version to Score hashes - https://phabricator.wikimedia.org/T49448#3857985 (10Ebe123) [20:59:59] (03PS3) 10Umherirrender: Improve types in documentation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 [21:01:47] (03CR) 10Umherirrender: "Patch Set 3: Use qualified class name in @param" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/399869 (owner: 10Umherirrender) [21:03:02] (03CR) 10Umherirrender: "Patch Set 3: Use qualified class name in @param" [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/399878 (owner: 10Umherirrender) [21:05:51] 10New-Editor-Experiences: Revisit steering meeting membership and frequency - https://phabricator.wikimedia.org/T183594#3857989 (10Neil_P._Quinn_WMF) [21:06:40] 10New-Editor-Experiences: Prioritize concept clusters - https://phabricator.wikimedia.org/T183595#3857998 (10Neil_P._Quinn_WMF) [21:07:02] 10Design-Research, 10New-Editor-Experiences, 10Epic: Hold workshops to apply new editor experiences research - https://phabricator.wikimedia.org/T170715#3858007 (10Neil_P._Quinn_WMF) 05Open>03Resolved We've held all the workshops—the final one was on December 14. [21:09:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399904 (owner: 10L10n-bot) [21:09:22] 10Contributors-Analysis, 10New-Editor-Experiences: Measure key aspects for New Editor Experiences initiatives - https://phabricator.wikimedia.org/T181249#3858011 (10Neil_P._Quinn_WMF) [21:10:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/399903 (owner: 10L10n-bot) [21:11:16] (03CR) 10Daniel Kinzler: "Oooohhh... conditional class alias! I didn't even think of that! Intriguing. And scary. I have no idea what the implications are :)" [core] - 10https://gerrit.wikimedia.org/r/399881 (https://phabricator.wikimedia.org/T183592) (owner: 10Addshore) [21:11:35] 10Design-Research, 10New-Editor-Experiences, 10Epic: Hold workshops to apply new editor experiences research - https://phabricator.wikimedia.org/T170715#3858019 (10Neil_P._Quinn_WMF) [21:12:30] haha, implications [21:13:07] (03CR) 10MaxSem: [C: 04-1] "This doesn't work beyond the 64k buffer size. Try using a couple megabytes string in the test." [core] - 10https://gerrit.wikimedia.org/r/399768 (https://phabricator.wikimedia.org/T182463) (owner: 10Gergő Tisza) [21:16:07] 10New-Editor-Experiences: Work with teams to define their participation in New Editor Experiences development - https://phabricator.wikimedia.org/T183596#3858023 (10Neil_P._Quinn_WMF) [21:16:18] addshore: implications include: working on a repo within wikimedia, broken code, explosions, etc :P [21:16:31] 10New-Editor-Experiences: Work with teams to define their participation in development work - https://phabricator.wikimedia.org/T183596#3858032 (10Neil_P._Quinn_WMF) [21:16:33] (03PS3) 10Kaldari: Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) [21:16:37] (03CR) 10Daniel Kinzler: "@Mwjames no, TEMP tables will work fine, since this still uses the same underlying DB connection. It just wraps the another PHP object aro" [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [21:18:01] (03PS4) 10Kaldari: [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) [21:18:29] (03CR) 10Kaldari: [C: 04-1] "Don't merge yet." [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [21:18:38] Zppix: lame :/ [21:18:57] addshore: but explosions [21:20:48] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, 10UI-Standardization-Kanban: Deprecate and remove 'citeArticle' icon - https://phabricator.wikimedia.org/T183597#3858034 (10Volker_E) p:05Triage>03Normal [21:21:34] (03CR) 10Mwjames: "> If this was not the case, *many* unit tests would fail :)" [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [21:22:04] (03PS1) 10Anomie: Add 'unwrap' ParserOutput post-cache transform [core] - 10https://gerrit.wikimedia.org/r/399907 (https://phabricator.wikimedia.org/T181846) [21:22:06] (03PS1) 10Anomie: Remove wrapclass from parser cache key [core] - 10https://gerrit.wikimedia.org/r/399908 (https://phabricator.wikimedia.org/T181846) [21:22:08] (03PS1) 10Anomie: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/399909 [21:22:11] (03PS1) 10Anomie: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399910 [21:22:29] (03PS1) 10Anomie: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/399912 [21:22:31] (03PS1) 10Anomie: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/399913 [21:22:35] (03CR) 10jerkins-bot: [V: 04-1] Remove wrapclass from parser cache key [core] - 10https://gerrit.wikimedia.org/r/399908 (https://phabricator.wikimedia.org/T181846) (owner: 10Anomie) [21:22:37] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/399915 [21:23:39] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [21:24:51] (03PS4) 10Ryan10145: Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) [21:24:56] (03CR) 10jerkins-bot: [V: 04-1] Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [21:25:19] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 [21:26:11] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801#3858061 (10Volker_E) [21:26:41] 10OOjs-UI, 10Collaboration-Team-Triage, 10Notifications, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#3858067 (10Volker_E) [21:26:44] 10OOjs-UI, 10Patch-For-Review, 10Technical-Debt: Slim down the "alerts" icon pack to the bare essentials - https://phabricator.wikimedia.org/T145163#3858066 (10Volker_E) [21:27:27] (03CR) 10jerkins-bot: [V: 04-1] Change doc type from DatabaseBase to IDatabase [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/399915 (owner: 10Umherirrender) [21:27:39] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801#2852379 (10Volker_E) [21:27:43] 10OOjs-UI, 10Patch-For-Review, 10Technical-Debt: Slim down the "alerts" icon pack to the bare essentials - https://phabricator.wikimedia.org/T145163#2621780 (10Volker_E) [21:28:12] 10OOjs-UI, 10Collaboration-Team-Triage, 10Notifications, 10Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#2442418 (10Volker_E) [21:28:16] 10OOjs-UI, 10Patch-For-Review, 10Technical-Debt: Slim down the "alerts" icon pack to the bare essentials - https://phabricator.wikimedia.org/T145163#2621780 (10Volker_E) [21:28:21] (03CR) 10jerkins-bot: [V: 04-1] Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399910 (owner: 10Anomie) [21:28:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399923 (owner: 10L10n-bot) [21:28:26] 10iOS-app-v5.8.0-Manatee-On-A-Skateboard: User education for Reading lists and account creation - https://phabricator.wikimedia.org/T177559#3858078 (10cmadeo) [21:28:28] 10MediaWiki-Vagrant, 10Patch-For-Review: Support using libvirt (KVM/QEMU) VM provider - https://phabricator.wikimedia.org/T71223#3858073 (10hashar) 05Open>03Resolved a:03scfc That was working at some point for sure thanks to https://gerrit.wikimedia.org/r/#/c/280785/ As part of bumping it to Jessie (T15... [21:28:46] (03PS5) 10Kaldari: [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) [21:29:00] 10OOjs-UI, 10Patch-For-Review, 10Technical-Debt: Slim down the "alerts" icon pack to the bare essentials - https://phabricator.wikimedia.org/T145163#3858079 (10Volker_E) [21:29:12] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/399944 [21:30:31] (03PS1) 10Hashar: Restore libvirt support [vagrant] - 10https://gerrit.wikimedia.org/r/399945 (https://phabricator.wikimedia.org/T71223) [21:30:47] 10MediaWiki-Vagrant, 10Patch-For-Review: Make libvirt provider work with a Jessie base image - https://phabricator.wikimedia.org/T154296#2906632 (10hashar) Eventually I was too lazy / not willing to install VirtualBox so I have followed @scfc step by step tutorial. Since base box and instructions were still re... [21:31:32] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.25.0): Create an icon for suggestions: 'lightbulb' - https://phabricator.wikimedia.org/T175006#3858087 (10Volker_E) [21:31:56] (03PS4) 10Ryan10145: Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) [21:32:02] (03CR) 10jerkins-bot: [V: 04-1] Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [21:32:18] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/399946 [21:33:02] (03CR) 10jerkins-bot: [V: 04-1] Change doc type from DatabaseBase to IDatabase [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/399943 (owner: 10Umherirrender) [21:33:05] (03PS13) 10Legoktm: Suppression: Don't tell non-suppressor users to view a log if they can't [core] - 10https://gerrit.wikimedia.org/r/40283 (https://phabricator.wikimedia.org/T39120) (owner: 10Alex Monk) [21:33:57] 10MediaWiki-Vagrant: install python-setuptools and python-wheel - https://phabricator.wikimedia.org/T183599#3858089 (10Paladox) [21:34:23] 10MediaWiki-Vagrant: Installing kibana indices on elasticsearch 5.5+ fail - https://phabricator.wikimedia.org/T183599#3858099 (10Paladox) [21:35:39] (03CR) 10jerkins-bot: [V: 04-1] Change typehint from DatabaseBase to IDatabase [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/399946 (owner: 10Umherirrender) [21:36:05] (03PS1) 10ArielGlenn: make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 [21:37:40] (03PS2) 10Anomie: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399910 [21:37:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [21:38:14] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/399948 [21:38:16] (03CR) 10ArielGlenn: "If I don't have this line, then a run of dumpTextPass.php with an option like --prefetch=7zip:/mnt/dumpsdata/xmldatadumps/public/svwiki/20" [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [21:38:42] 10MediaWiki-Maintenance-scripts, 10Dumps-Generation, 10Technical-Debt: Move non executable php code out of maintenance folder - https://phabricator.wikimedia.org/T182814#3858100 (10ArielGlenn) See also https://gerrit.wikimedia.org/r/#/c/399947/1 [21:39:41] 10Phabricator: Change Kevin Smith to Deb T in Form 41 - https://phabricator.wikimedia.org/T183582#3858101 (10Aklapper) @JAufrecht: In general, please always provide links for any requests, to make sure that we talk about the same things. //If// this is about https://phabricator.wikimedia.org/L41 then I cannot a... [21:40:22] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/Math] - 10https://gerrit.wikimedia.org/r/399949 [21:41:09] (03PS1) 10MaxSem: Remove bogus @covers annotation [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T171899) [21:41:34] (03CR) 10jerkins-bot: [V: 04-1] Suppression: Don't tell non-suppressor users to view a log if they can't [core] - 10https://gerrit.wikimedia.org/r/40283 (https://phabricator.wikimedia.org/T39120) (owner: 10Alex Monk) [21:42:20] (03PS2) 10MaxSem: Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T171899) [21:42:51] (03Draft1) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [21:43:08] (03CR) 10jerkins-bot: [V: 04-1] make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [21:43:10] (03PS2) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [21:43:36] 10Phabricator: Change Kevin Smith to Deb T in Form 41 - https://phabricator.wikimedia.org/T183582#3858107 (10Aklapper) 05Open>03Resolved Ah! Just when I clicked "Submit" I realized: //Task creation form// is probably meant here! Alright, so in https://phabricator.wikimedia.org/transactions/editengine/maniphe... [21:44:17] (03PS3) 10Umherirrender: Move classes to own files [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/398644 [21:44:19] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/399952 [21:44:21] (03PS3) 10MaxSem: Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T171899) [21:44:42] 10MediaWiki-Vagrant: Opening a page is really slow - https://phabricator.wikimedia.org/T107111#3858109 (10bmansurov) 05Open>03declined Not using vagrant anymore. Feel free to reopen. [21:44:48] 10MediaWiki-Vagrant, 10Release-Engineering-Team (Kanban): Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3858112 (10hashar) On a Jessie one, the **initial provisioning** is done with: 3.7.2 ``` $ apt-cache policy puppet puppet: Installed: 3.7.2-4+deb8u1 Candidate... [21:44:52] (03PS2) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/399952 [21:45:07] 10Phabricator: Change Kevin Smith to Deb T in Form 41 - https://phabricator.wikimedia.org/T183582#3858113 (10Aklapper) Side note: I do not understand why this is set. Why don't these two users [[ https://www.mediawiki.org/wiki/Phabricator/Help#Receiving_updates_and_notifications | watch ]] the project #WMF-CTO-T... [21:45:12] (03CR) 10jerkins-bot: [V: 04-1] Change doc type from DatabaseBase to IDatabase [extensions/Math] - 10https://gerrit.wikimedia.org/r/399949 (owner: 10Umherirrender) [21:46:19] (03PS3) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [21:46:32] 10MediaWiki-Vagrant, 10Release-Engineering-Team (Kanban): Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3858125 (10bd808) Stretch will be the master branch in ~2 weeks (T181353). I wouldn't waste much energy on things like this in master right now. [21:46:39] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/399953 [21:47:15] paladox: please mark your patches as [WIP] so I know I can ignore the dozens of emails that I get from them. [21:48:27] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/399955 [21:48:46] (03PS1) 10MaxSem: Fix @covers annotations [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399956 (https://phabricator.wikimedia.org/T171899) [21:49:01] bd808 it's not a WIP :) [21:49:22] 10MediaWiki-Vagrant, 10Release-Engineering-Team (Kanban): Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3858182 (10hashar) Definitely :] I guess we can keep this around as a reminder to bump the Puppet version in the Gemfile to match the one installed in Stretch. [21:49:59] (03CR) 10jerkins-bot: [V: 04-1] Change doc type from DatabaseBase to IDatabase [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/399952 (owner: 10Umherirrender) [21:50:02] paladox: 3 patches posted in <10 minutes is a work in progress. You can't be testing a full VM provision that fast [21:50:53] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/399957 [21:51:08] (03CR) 10Thiemo Kreuz (WMDE): "Depends on how you define "incorrect". The &$this is pretty much the only thing that was always wrong here. The & should be removed from t" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [21:52:39] (03PS4) 10Paladox: [WIP] Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [21:52:48] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/399958 [21:52:58] bd808 do you know how prod generates kibana index please? [21:53:25] (03CR) 10BryanDavis: [C: 032] Restore libvirt support [vagrant] - 10https://gerrit.wikimedia.org/r/399945 (https://phabricator.wikimedia.org/T71223) (owner: 10Hashar) [21:54:37] 10MediaWiki-Vagrant, 10Patch-For-Review: Make libvirt provider work with a Jessie base image - https://phabricator.wikimedia.org/T154296#3858235 (10hashar) 05Open>03Resolved [21:54:39] 10MediaWiki-Vagrant, 10Operations, 10Release-Engineering-Team, 10Epic, and 2 others: [EPIC] Migrate base image to Debian Jessie - https://phabricator.wikimedia.org/T136429#3858236 (10hashar) [21:55:24] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, 10UI-Standardization-Kanban: Deprecate and remove 'comment' icon from 'alerts' pack - https://phabricator.wikimedia.org/T183600#3858251 (10Volker_E) p:05Triage>03High [21:55:36] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, 10UI-Standardization-Kanban: Deprecate and remove 'comment' icon from 'alerts' pack - https://phabricator.wikimedia.org/T183600#3858251 (10Volker_E) p:05High>03Low [21:56:16] (03Merged) 10jenkins-bot: Restore libvirt support [vagrant] - 10https://gerrit.wikimedia.org/r/399945 (https://phabricator.wikimedia.org/T71223) (owner: 10Hashar) [21:56:21] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/399959 [21:56:59] (03CR) 10jenkins-bot: Restore libvirt support [vagrant] - 10https://gerrit.wikimedia.org/r/399945 (https://phabricator.wikimedia.org/T71223) (owner: 10Hashar) [21:57:20] (03CR) 10Anomie: "recheck" [core] - 10https://gerrit.wikimedia.org/r/399908 (https://phabricator.wikimedia.org/T181846) (owner: 10Anomie) [21:57:55] 10Support-and-Safety, 10Wikimedia-Site-requests: Enable create a Secure poll in Arwiki - https://phabricator.wikimedia.org/T183358#3851118 (10Dereckson) Thanks @Huji for your input. @Ibrahim.ID For what kind of elections do you want to use it? [21:58:45] (03CR) 10MaxSem: "https://gerrit.wikimedia.org/r/#/c/399950/" [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [22:00:14] (03PS1) 10Umherirrender: Change typehint from DatabaseBase to IDatabase [extensions/Memento] - 10https://gerrit.wikimedia.org/r/399960 [22:02:05] 10MediaWiki-Vagrant, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3858284 (10hashar) MediaWiki-Vagrant has libvirt support made by @scfc (and update to jessie with... [22:02:10] (03CR) 10Daniel Kinzler: Switch Revision MCR overhaul based on $wgUseMCRRevision (033 comments) [core] - 10https://gerrit.wikimedia.org/r/399881 (https://phabricator.wikimedia.org/T183592) (owner: 10Addshore) [22:03:33] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399956 (https://phabricator.wikimedia.org/T171899) (owner: 10MaxSem) [22:04:35] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/399961 [22:04:46] (03CR) 10Hashar: [C: 04-2] "@Bryan yup that would be nicer on the stretch branch. I have did this patch as a quick proof of concept and I eventually got surprised it " [vagrant] - 10https://gerrit.wikimedia.org/r/399834 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [22:05:33] (03CR) 10Legoktm: [C: 032] Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T171899) (owner: 10MaxSem) [22:05:50] (03CR) 10Legoktm: [C: 032] "Oops, thanks." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399956 (https://phabricator.wikimedia.org/T171899) (owner: 10MaxSem) [22:06:23] 10MediaWiki-extensions-Score, 10Electron-PDFs, 10Multimedia, 10OCG-PDFRenderer, 10Wikisource: PDF export should render music scores natively, i.e. not as images - https://phabricator.wikimedia.org/T181322#3858293 (10Ebe123) PDFs actually do support audio files, like what we do with HTML. However, it is n... [22:06:54] (03PS4) 10Legoktm: Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T183528) (owner: 10MaxSem) [22:07:10] (03CR) 10Legoktm: [C: 032] Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T183528) (owner: 10MaxSem) [22:08:02] (03PS4) 10MaxSem: Hard deprecate UtfNormalUtil [core] - 10https://gerrit.wikimedia.org/r/371984 [22:09:46] (03PS2) 10Umherirrender: Move classes to own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/398609 [22:09:48] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/399962 [22:09:52] (03PS2) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/399962 [22:11:43] 10MediaWiki-JobQueue, 10Performance-Team, 10Wikidata, 10Discovery-Search (Current work), 10Wikimedia-log-errors: Items missing from Wikidata index due to LinksUpdate lock failures - https://phabricator.wikimedia.org/T183101#3858294 (10Imarlier) First appearance of a timeout on db1100: ``` 2017-12-16T14:... [22:14:39] (03CR) 10Gergő Tisza: [C: 031] Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/399909 (owner: 10Anomie) [22:15:52] (03Merged) 10jenkins-bot: Fix @covers annotations [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399956 (https://phabricator.wikimedia.org/T171899) (owner: 10MaxSem) [22:16:19] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T183528) (owner: 10MaxSem) [22:17:05] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T183528) (owner: 10MaxSem) [22:17:28] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate UtfNormalUtil [core] - 10https://gerrit.wikimedia.org/r/371984 (owner: 10MaxSem) [22:18:11] (03CR) 10jerkins-bot: [V: 04-1] Move classes to own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/398609 (owner: 10Umherirrender) [22:19:29] (03PS4) 10Petar.petkovic: Truncate tag filter descriptions [core] - 10https://gerrit.wikimedia.org/r/395768 (https://phabricator.wikimedia.org/T179626) [22:20:27] (03PS1) 10Umherirrender: Change doc type from DatabaseBase to IDatabase [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399963 [22:20:32] 10MediaWiki-JobQueue, 10Performance-Team, 10Wikidata, 10Discovery-Search (Current work), 10Wikimedia-log-errors: Items missing from Wikidata index due to LinksUpdate lock failures - https://phabricator.wikimedia.org/T183101#3858299 (10Imarlier) Alternate theory that I think is wrong: there's a chance tha... [22:23:46] 10Phabricator: Change Kevin Smith to Deb T in Form 41 - https://phabricator.wikimedia.org/T183582#3858301 (10JAufrecht) Thanks. I'll try watching and see how it works. I think 1) I didn't understand about watching, and 2), I'm concerned about spam from watching the whole project as opposed to having some defau... [22:23:49] (03PS5) 10Paladox: [WIP] Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [22:24:22] 10WMF-CTO-Team-Backlog: Update all followup Qs and references in Tech presentation blog post 1 - https://phabricator.wikimedia.org/T180744#3858302 (10JAufrecht) [22:24:32] 10WMF-CTO-Team-Backlog, 10Epic: Publish the 2017 Tech presentation as a blog post - https://phabricator.wikimedia.org/T177794#3858304 (10JAufrecht) [22:24:34] 10WMF-CTO-Team-Backlog: Update all followup Qs and references in Tech presentation blog post 1 - https://phabricator.wikimedia.org/T180744#3768207 (10JAufrecht) 05Open>03Resolved [22:25:45] 10OOjs-UI, 10Cite: Merge Cite icons into OOUI - https://phabricator.wikimedia.org/T177847#3858305 (10Volker_E) p:05Triage>03Low [22:25:58] (03CR) 10Gergő Tisza: [C: 031] Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399910 (owner: 10Anomie) [22:25:59] (03Merged) 10jenkins-bot: Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T183528) (owner: 10MaxSem) [22:26:42] 10WMF-CTO-Team-Backlog, 10WMF-CTO-Team-InProgress (waiting): Determine administrative needs for tech-mgt - https://phabricator.wikimedia.org/T177536#3858310 (10JAufrecht) 05Open>03Resolved [22:27:46] (03CR) 10jenkins-bot: Remove/fix bogus @covers annotations [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/399950 (https://phabricator.wikimedia.org/T183528) (owner: 10MaxSem) [22:28:39] (03CR) 10jerkins-bot: [V: 04-1] Change doc type from DatabaseBase to IDatabase [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399963 (owner: 10Umherirrender) [22:31:30] 10Dumps-Generation: Dumps not available for download for 20171220 - https://phabricator.wikimedia.org/T183535#3858318 (10ArielGlenn) The rsync completed for the nfs fallback host and is now in process for the web server. [22:33:14] (03CR) 10Umherirrender: "recheck" [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [22:33:20] (03CR) 10Gergő Tisza: [C: 031] Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/399912 (owner: 10Anomie) [22:34:29] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Rename 'clip' and 'unClip' icons into 'bookmarkOutline' and 'bookmark' - https://phabricator.wikimedia.org/T183601#3858319 (10Volker_E) p:05Triage>03Lowest [22:34:40] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Rename 'clip' and 'unClip' icons into 'bookmarkOutline' and 'bookmark' - https://phabricator.wikimedia.org/T183601#3858319 (10Volker_E) a:05Volker_E>03None [22:36:15] (03CR) 10Gergő Tisza: [C: 031] Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/399913 (owner: 10Anomie) [22:38:13] (03PS6) 10Paladox: [WIP] Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [22:38:42] (03CR) 10jerkins-bot: [V: 04-1] Verify that all @covers tags are sane when running tests [core] - 10https://gerrit.wikimedia.org/r/399775 (https://phabricator.wikimedia.org/T171899) (owner: 10Legoktm) [22:41:03] (03PS1) 10Umherirrender: Update reference to DatabaseBase in hooks.txt [core] - 10https://gerrit.wikimedia.org/r/399964 [22:46:10] (03CR) 10Gergő Tisza: [C: 031] Remove wrapclass from parser cache key (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399908 (https://phabricator.wikimedia.org/T181846) (owner: 10Anomie) [22:47:07] (03CR) 10Legoktm: "recheck" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [22:47:20] (03CR) 10Gergő Tisza: [C: 031] Add 'unwrap' ParserOutput post-cache transform [core] - 10https://gerrit.wikimedia.org/r/399907 (https://phabricator.wikimedia.org/T181846) (owner: 10Anomie) [22:48:18] (03CR) 10Legoktm: [C: 032] "Thiemo: If you think this is wrong, please bring it up on the task. Telling a GCI student to do it differently is not fair to them. The wh" [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [22:49:26] (03CR) 10Legoktm: [C: 032] Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [22:49:28] (03CR) 10Gergő Tisza: [C: 031] Cache processed stylesheets during the parse [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/394369 (owner: 10Anomie) [22:50:03] (03Merged) 10jenkins-bot: Changed &$this in hooks [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/399763 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [22:50:38] (03Merged) 10jenkins-bot: Changed &$this in hooks [skins/webplatform] - 10https://gerrit.wikimedia.org/r/399762 (https://phabricator.wikimedia.org/T153505) (owner: 10Ryan10145) [22:58:07] (03CR) 10Kaldari: "recheck" [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [23:00:39] (03PS1) 10Hashar: rspec-puppet for all the roles [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) [23:01:14] (03CR) 10jerkins-bot: [V: 04-1] rspec-puppet for all the roles [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [23:03:41] (03PS7) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) [23:04:02] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [23:04:18] (03Abandoned) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] - 10https://gerrit.wikimedia.org/r/399951 (https://phabricator.wikimedia.org/T183599) (owner: 10Paladox) [23:04:23] (03Draft1) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399967 (https://phabricator.wikimedia.org/T183599) [23:04:57] (03PS2) 10Paladox: Fix kibana index on elasticsearch 5.5+ [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399967 (https://phabricator.wikimedia.org/T183599) [23:05:17] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Growing the MediaWiki Technical Community - https://phabricator.wikimedia.org/T183318#3858362 (10Quiddity) [23:06:32] (03CR) 10EBernhardson: [C: 032] Fix kibana index on elasticsearch 5.5+ [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399967 (https://phabricator.wikimedia.org/T183599) (owner: 10Paladox) [23:07:05] (03Merged) 10jenkins-bot: Fix kibana index on elasticsearch 5.5+ [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399967 (https://phabricator.wikimedia.org/T183599) (owner: 10Paladox) [23:09:23] 10MediaWiki-Vagrant, 10Patch-For-Review: Installing kibana indices on elasticsearch 5.5+ fail - https://phabricator.wikimedia.org/T183599#3858365 (10Paladox) [23:09:29] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3858364 (10Paladox) [23:09:35] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3844297 (10Paladox) [23:09:37] 10MediaWiki-Vagrant, 10Patch-For-Review: Installing kibana indices on elasticsearch 5.5+ fail - https://phabricator.wikimedia.org/T183599#3858089 (10Paladox) 05Open>03Resolved a:03Paladox [23:10:02] (03CR) 10Hashar: "Fail with:" [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [23:19:16] (03PS2) 10Hashar: rspec-puppet for all the roles [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) [23:19:43] (03CR) 10jerkins-bot: [V: 04-1] rspec-puppet for all the roles [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399965 (https://phabricator.wikimedia.org/T183570) (owner: 10Hashar) [23:24:47] Hello! [23:26:16] Albert221: Hello! [23:26:54] 10Phabricator: Phab is having issues - https://phabricator.wikimedia.org/T182832#3835986 (10mmodell) Root cause unknown but what we did discover is that apache had hundreds of stalled child processes and eventually it reached the limit set by `MaxClients` which is set to 450. It is unknown what caused the stalle... [23:29:03] (03PS1) 10MarkAHershberger: Add dependency and loader for BSFoundation [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/399970 [23:32:17] hi Albert [23:40:20] (03PS23) 10Kaldari: Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [23:45:58] (03CR) 10jerkins-bot: [V: 04-1] Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [23:47:53] Hi my name is Harshit Karwal. I am on IRC for a Google Code-In task. [23:49:03] hi HarKar [23:49:05] HarKar: Welcome! Good luck with GCI tasks! [23:49:42] Actually I am a newbie to all this and know very little about it. [23:50:09] hello HarKar! [23:50:12] (03PS2) 10Albert221: [WIP] Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 [23:50:28] ^waiting for Jenkins now heh [23:51:15] well, Wikipedia has an article on IRC [23:51:21] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add double escaping detection [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/399776 (owner: 10Albert221) [23:51:29] it might be worth looking at some time [23:51:49] Thanks. [23:53:02] 10Phabricator, 10LDAP: Having difficulty logging into Phabricator via LDAP when multiple accounts returned for username - https://phabricator.wikimedia.org/T138672#3858391 (10SMcCandlish) Yes, mech is me as well. I don't use that ID on any WMF sites any longer. [23:53:11] okay, that's better now, Jenkins good [23:53:20] (03CR) 10Gergő Tisza: " is not allowed in the document body (granted, technically