[00:02:06] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183311#3849937 (10Rfarrand) p:05Triage>03Normal [00:03:16] (03PS2) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [00:03:20] (03PS1) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [00:03:27] 04(no projects): Wikimedia Developer Summit 218 Topic: Supporting Third-Party Use of MediaWiki - https://phabricator.wikimedia.org/T183312#3849948 (10Rfarrand) p:05Triage>03Normal [00:04:12] 04(no projects): Wikimedia Developer Summit 218 Topic: Evolving the MediaWiki Architecture - https://phabricator.wikimedia.org/T183313#3849958 (10Rfarrand) p:05Triage>03Normal [00:04:30] (03PS3) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [00:04:48] (03CR) 10jerkins-bot: [V: 04-1] Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [00:04:56] 04(no projects): Wikimedia Developer Summit 218 Topic: Next Steps for Languages and Cross Project Collaboration - https://phabricator.wikimedia.org/T183314#3849969 (10Rfarrand) p:05Triage>03Normal [00:04:58] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture - https://phabricator.wikimedia.org/T183313#3849979 (10Reedy) [00:05:02] (03CR) 10Florianschmidtwelzow: [C: 032] "Works like expected, any comments are implemented. Good job! Thanks for your submission and (of course) have a lot of fun with us during G" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [00:05:27] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Supporting Third-Party Use of MediaWiki - https://phabricator.wikimedia.org/T183312#3849981 (10Reedy) [00:05:34] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183315#3849983 (10Rfarrand) p:05Triage>03Normal [00:05:40] (03CR) 10jerkins-bot: [V: 04-1] Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [00:05:54] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Next Steps for Languages and Cross Project Collaboration - https://phabricator.wikimedia.org/T183314#3849994 (10Rfarrand) [00:07:04] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Advancing the Contributor Experience - https://phabricator.wikimedia.org/T183317#3850007 (10Rfarrand) p:05Triage>03Normal [00:07:21] (03CR) 10MarkAHershberger: "This should get a +2 despite failing checks. I'm working on those in later patch sets." [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [00:07:25] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Advancing the Contributor Experience - https://phabricator.wikimedia.org/T183317#3850019 (10Reedy) [00:08:04] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Growing the MediaWiki Technical Community - https://phabricator.wikimedia.org/T183318#3850021 (10Rfarrand) p:05Triage>03Normal [00:08:55] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Embracing Open Source Software - https://phabricator.wikimedia.org/T183319#3850032 (10Rfarrand) p:05Triage>03Normal [00:09:37] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 218 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3850043 (10Rfarrand) p:05Triage>03Normal [00:10:47] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Next Steps for Languages and Cross Project Collaboration - https://phabricator.wikimedia.org/T183314#3850054 (10Aklapper) [00:10:57] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Growing the MediaWiki Technical Community - https://phabricator.wikimedia.org/T183318#3850055 (10Rfarrand) [00:11:20] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183311#3850056 (10Aklapper) [00:11:22] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183315#3850057 (10Aklapper) [00:11:24] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Embracing Open Source Software - https://phabricator.wikimedia.org/T183319#3850058 (10Aklapper) [00:11:26] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3850059 (10Aklapper) [00:11:55] (03Merged) 10jenkins-bot: Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [00:13:06] thanks andre__ and Reedy ! [00:13:26] Phantom42: around? [00:13:28] braindead copy / pasting [00:14:54] rfarrand: I love braindead work. :D [00:17:31] 10Wikimedia-Interwiki-links: be-tarask interlanguage link goes to be-x-old wiki rather than be-tarask wiki - https://phabricator.wikimedia.org/T183301#3850063 (10Aklapper) unrelated to #mediawiki-parser [00:18:20] 10MediaWiki-extensions-WikimediaMaintenance, 10Wikimedia-Interwiki-links, 10Wikimedia-Site-requests, 10Patch-For-Review, and 3 others: The href of be-tarask: interlanguage link points to the be-x-old domain - https://phabricator.wikimedia.org/T111853#3850065 (10Aklapper) unrelated to #mediawiki-parser [00:19:35] (03PS1) 10Cooltey: Add Notification Channel ID to Notification builder [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399316 [00:20:05] (03CR) 10Florianschmidtwelzow: "The getIssueCount() method is probably ok, too and can be kept, however, intorucing unused code sounds "useless" :P" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [00:21:39] (03CR) 10Cooltey: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) (owner: 10Serraboof) [00:23:06] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183315#3850070 (10Rfarrand) [00:23:08] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183311#3850072 (10Rfarrand) [00:30:33] (03CR) 10Pppery: "@Florian where is the unused code that you are talking about?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [00:42:13] oh! an update landed on GitHub's feed! [00:42:43] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Make Kafka JobQueue use Special:RunSingleJob - https://phabricator.wikimedia.org/T182372#3850105 (10Tgr) [00:42:45] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog: Batch reading list operations - https://phabricator.wikimedia.org/T182052#3850106 (10Tgr) [00:42:49] 10MediaWiki-API, 10MediaWiki-JobQueue, 10Analytics, 10EventBus, and 3 others: Handling of structured data input in MediaWiki APIs - https://phabricator.wikimedia.org/T182475#3850102 (10Tgr) 05Open>03Resolved a:03Tgr >>! In T182475#3828649, @Anomie wrote: > Probably go with your second bullet: Define... [00:42:52] (03PS7) 10Esanders: Respect "Always use VE" and "Always use source editor" preferences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394405 (https://phabricator.wikimedia.org/T178719) (owner: 10Catrope) [00:42:55] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog: Batch reading list operations - https://phabricator.wikimedia.org/T182052#3811312 (10Tgr) Per T182475, using an API parameter that contains all real parameters JSON-encoded into a string seems like the best approach, so probably add a `batch` param... [00:54:51] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 3 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3293696 (10Legoktm) I'm a bit confused, the exception message points to the Elastica extension needing curl...shouldn't the ex... [01:00:13] (03PS1) 10Cooltey: Fix: Update automatically generated article titles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399317 [01:00:34] (03PS4) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [01:00:46] (03PS2) 10Cooltey: Fix: automatically generated article titles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399317 [01:02:04] (03CR) 10jerkins-bot: [V: 04-1] Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [01:02:40] 10MediaWiki-extensions-DynamicPageList: Error with Dynamic Page List and rendering content after upgrading to 1.30.0 - https://phabricator.wikimedia.org/T183323#3850128 (10charitwo) [01:03:12] 10MediaWiki-extensions-DynamicPageList: Error with Dynamic Page List and rendering content after upgrading to 1.30.0 - https://phabricator.wikimedia.org/T183323#3850138 (10charitwo) p:05Triage>03Unbreak! [01:12:41] (03PS2) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [01:13:54] (03CR) 10jerkins-bot: [V: 04-1] Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [01:13:56] (03CR) 10Reedy: "caused T183323" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/311963 (owner: 10Thiemo Kreuz (WMDE)) [01:16:09] 10MediaWiki-extensions-DynamicPageList: Error with Dynamic Page List and rendering content after upgrading to 1.30.0 - https://phabricator.wikimedia.org/T183323#3850128 (10Reedy) Caused by https://gerrit.wikimedia.org/r/#/c/311963/3 which is in REL1_29 of Cite... [01:16:54] (03PS5) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [01:18:07] (03CR) 10jerkins-bot: [V: 04-1] Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [01:18:54] (03CR) 10VolkerE: [C: 032] Standardize editfont size across browsers/OSes [core] - 10https://gerrit.wikimedia.org/r/396005 (https://phabricator.wikimedia.org/T176636) (owner: 10Esanders) [01:22:07] 10MediaWiki-extensions-DynamicPageList, 10Cite: Error with Dynamic Page List and rendering content after upgrading to 1.30.0 - https://phabricator.wikimedia.org/T183323#3850143 (10charitwo) [01:25:15] (03Merged) 10jenkins-bot: Standardize editfont size across browsers/OSes [core] - 10https://gerrit.wikimedia.org/r/396005 (https://phabricator.wikimedia.org/T176636) (owner: 10Esanders) [01:25:17] (03CR) 10jerkins-bot: [V: 04-1] Remove duplicate editfont size definition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/397570 (owner: 10Esanders) [01:26:26] 10UI-Standardization, 10MinervaNeue, 10Vector, 10CSS, and 2 others: Unify CSS font stack of monospace-styled elements across products - https://phabricator.wikimedia.org/T176636#3850150 (10Volker_E) 05Open>03Resolved a:03Volker_E [01:28:03] 10MediaWiki-Page-editing, 10MediaWiki-User-preferences, 10VisualEditor, 10User-Ryasmeen: Edit font preview in preferences uses a small font size for monospace - https://phabricator.wikimedia.org/T181324#3850156 (10Volker_E) 05Open>03Resolved [01:28:08] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 4 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3850160 (10Florian) Now that I think about that: You're right. Even if Elastica is currently only required by the CirrusSearch... [01:28:34] (03PS1) 10Florianschmidtwelzow: Fail gracefully if curl is not installed [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399319 (https://phabricator.wikimedia.org/T166355) [01:28:54] (03PS1) 10Florianschmidtwelzow: Revert "Fail gracefully if curl is not installed" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399320 [01:29:50] (03CR) 10Florianschmidtwelzow: [C: 04-2] "Can you please propose a new change for the Elastica extension, which is the extension, which needs the curl extension. CirrusSearch just " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399241 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [01:32:02] (03CR) 10jerkins-bot: [V: 04-1] Fail gracefully if curl is not installed [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399319 (https://phabricator.wikimedia.org/T166355) (owner: 10Florianschmidtwelzow) [01:35:31] (03CR) 10jenkins-bot: Standardize editfont size across browsers/OSes [core] - 10https://gerrit.wikimedia.org/r/396005 (https://phabricator.wikimedia.org/T176636) (owner: 10Esanders) [01:38:07] 10UI-Standardization, 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3850162 (10Volker_E) [01:40:51] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: OOUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801#3850166 (10Volker_E) [01:42:12] 10Accessibility, 10Design, 10UI-Standardization, 10ContentTranslation, and 3 others: CX source selector has no focus state - https://phabricator.wikimedia.org/T177402#3850167 (10Volker_E) @Etonkovidova One more time, please :) [01:43:05] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: OOUI: Support Responsive Toolbars - https://phabricator.wikimedia.org/T175953#3850169 (10Volker_E) [01:45:39] (03CR) 10Smalyshev: [C: 032] Revert "Fail gracefully if curl is not installed" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399320 (owner: 10Florianschmidtwelzow) [01:47:03] 10Timeless, 10CSS: Add-portlet-link gadgets and scripts in "more" menu are missing in Timeless - https://phabricator.wikimedia.org/T181362#3787343 (10Evad37) A work-around I've used in one of my scripts is checking the skin type and adjusting the portlet location accordingly, i.e. changing ``` mw.util.addPortl... [01:47:29] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_prefix_redirect_accent_squashing_accented_namespace_suggest_search_prefer" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399320 (owner: 10Florianschmidtwelzow) [01:54:30] (03Merged) 10jenkins-bot: Revert "Fail gracefully if curl is not installed" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399320 (owner: 10Florianschmidtwelzow) [02:03:35] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3850173 (10Volker_E) [02:06:23] 10Timeless: Gadgets don't add links to the "Tool" sidebar section - https://phabricator.wikimedia.org/T183172#3845875 (10Evad37) This is a duplicate of {T181362}. [02:07:04] 10MediaWiki-General-or-Unknown, 10OOjs-UI: Replace and deprecate CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T183299#3850179 (10Volker_E) [02:07:27] 10MediaWiki-General-or-Unknown, 10OOjs-UI: Replace and deprecate CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T183299#3849583 (10Volker_E) [02:14:49] (03CR) 10Smalyshev: Push pagination decision for prefix search into SearchEngine (032 comments) [core] - 10https://gerrit.wikimedia.org/r/399312 (owner: 10EBernhardson) [02:23:36] (03CR) 10MarkAHershberger: "@legoktm tells me that a new release of codesniffer is coming soon that will actually use the phpcs:disable directives. See comments on h" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [02:25:34] (03CR) 10Legoktm: "If you just want to exclude some sniffs, you can use the method in https://phabricator.wikimedia.org/diffusion/EMAM/browse/master/.phpcs.x" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [02:27:36] (03CR) 10Legoktm: "This patch is fine - CI is broken." [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:27:54] (03CR) 10Legoktm: "This patch is fine - CI is broken" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:28:33] 10MobileFrontend, 10Mobile: Reference anchor and target IDs use inconsistent percent encoding - https://phabricator.wikimedia.org/T183049#3850185 (10Jdlrobson) [02:29:47] 10MinervaNeue, 10Readers-Web-Backlog, 10Design (RW-Design-Debt): Contents icon should feature an icon color aligned with text - https://phabricator.wikimedia.org/T183269#3850186 (10Jdlrobson) [02:30:06] (03CR) 10Smalyshev: [C: 031] Silently drop unknown titles in completion search [core] - 10https://gerrit.wikimedia.org/r/398192 (https://phabricator.wikimedia.org/T115756) (owner: 10EBernhardson) [02:30:35] 10MobileFrontend, 10Readers-Web-Backlog: {{Orphan}} template is quasi-visible on mobile web even when it's not visible on desktop - https://phabricator.wikimedia.org/T183246#3850187 (10Jdlrobson) [02:31:10] 10MobileFrontend, 10Readers-Web-Backlog: {{Orphan}} template is quasi-visible on mobile web even when it's not visible on desktop - https://phabricator.wikimedia.org/T183246#3847978 (10Jdlrobson) [02:31:12] 10Design, 10Epic, 10Readers-Web-Backlog (Design): [EPIC] Improve page issues - https://phabricator.wikimedia.org/T159262#3850188 (10Jdlrobson) [02:31:37] 10MobileFrontend, 10Readers-Web-Backlog: {{Orphan}} template is quasi-visible on mobile web even when it's not visible on desktop - https://phabricator.wikimedia.org/T183246#3847978 (10Jdlrobson) [02:31:40] 10Design, 10Epic, 10Readers-Web-Backlog (Design): [EPIC] Improve article notes - https://phabricator.wikimedia.org/T143535#3850190 (10Jdlrobson) [02:32:15] 10MobileFrontend, 10Readers-Web-Backlog: {{Orphan}} template is quasi-visible on mobile web even when it's not visible on desktop - https://phabricator.wikimedia.org/T183246#3847978 (10Jdlrobson) [02:32:24] 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile: Reference anchor and target IDs use inconsistent percent encoding - https://phabricator.wikimedia.org/T183049#3850193 (10Jdlrobson) [02:36:20] (03CR) 10Legoktm: "recheck" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:37:40] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:39:02] (03CR) 10Jdlrobson: Disable RCFilters in mobile view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398202 (https://phabricator.wikimedia.org/T181545) (owner: 10Catrope) [02:39:45] (03CR) 10Legoktm: [C: 032] "Filed T183324 for the CI failure. Once that is fixed, this patch will get merged." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:39:47] (03CR) 10Legoktm: "recheck" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:40:24] (03CR) 10Legoktm: [C: 032] "This patch is fine, and will be merged once the CI failure is resolved (T183324)." [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:40:55] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:40:57] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:41:51] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [02:43:19] (03PS2) 10Jdlrobson: Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [02:43:23] (03CR) 10Jdlrobson: [C: 032] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [02:45:39] (03CR) 10jerkins-bot: [V: 04-1] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [02:45:56] (03CR) 10jerkins-bot: [V: 04-1] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [02:46:38] (03CR) 10Legoktm: "The CI failure is T183324 :(" [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [02:48:54] 10Timeless: Update colours to follow Wikimedia style guide - https://phabricator.wikimedia.org/T131992#3850213 (10Isarra) [02:50:03] 10Timeless: Update colours to follow Wikimedia style guide - https://phabricator.wikimedia.org/T131992#2185356 (10Isarra) [02:50:18] 10Timeless: Update colours to follow Wikimedia style guide - https://phabricator.wikimedia.org/T131992#2185356 (10Isarra) Since we actually have a more thorough style guide now. [02:54:29] 10Timeless: Update colours to follow Wikimedia style guide - https://phabricator.wikimedia.org/T131992#3850218 (10Isarra) >>! In T131992#3543676, @Quiddity wrote: > Content text color: Timeless is currently using `#001133`, a shade of very dark blue ([[ http://www.color-hex.com/color/001133 | 1 ]]). I'd recomme... [02:54:45] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Size and placement of tags and widget's input to add them - https://phabricator.wikimedia.org/T183325#3850219 (10Volker_E) p:05Triage>03Normal [02:55:22] 10Timeless: Update colours to follow Wikimedia style guide - https://phabricator.wikimedia.org/T131992#3850232 (10Isarra) [02:55:40] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Size and placement of tags and widget's input to add them - https://phabricator.wikimedia.org/T183325#3850219 (10Volker_E) [02:59:04] (03CR) 10Jdlrobson: [C: 032] Don't make small slider icons on MMV overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398185 (https://phabricator.wikimedia.org/T108657) (owner: 10VolkerE) [03:02:00] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3850236 (10Volker_E) [03:04:28] 10Timeless: Apply Wikimedia typography style guide? - https://phabricator.wikimedia.org/T183326#3850237 (10Isarra) [03:05:15] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Size and placement of tags and widget's input to add them - https://phabricator.wikimedia.org/T183325#3850247 (10Volker_E) @Pginer-WMF The size and placement part has been successfully implemented in TagMultiselectWidget with all it's varieties... [03:05:42] (03Merged) 10jenkins-bot: Don't make small slider icons on MMV overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398185 (https://phabricator.wikimedia.org/T108657) (owner: 10VolkerE) [03:05:58] (03CR) 10Jdlrobson: [C: 032] Fix location of LocalSettings.php [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399170 (https://phabricator.wikimedia.org/T164024) (owner: 10Zfilipin) [03:07:40] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3850250 (10Volker_E) [03:08:10] (03CR) 10jenkins-bot: Don't make small slider icons on MMV overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398185 (https://phabricator.wikimedia.org/T108657) (owner: 10VolkerE) [03:08:36] (03CR) 10Jdlrobson: [C: 04-1] "pending discussion on ticket" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398202 (https://phabricator.wikimedia.org/T181545) (owner: 10Catrope) [03:09:08] (03CR) 10Jdlrobson: [C: 032] "thanks :)" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [03:09:27] (03PS2) 10Jdlrobson: Replace instances of constructive and remove option entirely [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398213 (https://phabricator.wikimedia.org/T182730) (owner: 10VolkerE) [03:10:34] (03CR) 10Jdlrobson: [C: 032] Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [03:10:39] (03Merged) 10jenkins-bot: Fix location of LocalSettings.php [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399170 (https://phabricator.wikimedia.org/T164024) (owner: 10Zfilipin) [03:11:25] (03Merged) 10jenkins-bot: Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [03:11:42] (03PS3) 10Jdlrobson: Promote expand all sections and fontchanger to stable [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396284 (https://phabricator.wikimedia.org/T169257) [03:12:06] (03CR) 10Jdlrobson: [C: 032] "ps2 is a rebase" [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396284 (https://phabricator.wikimedia.org/T169257) (owner: 10Jdlrobson) [03:12:40] (03CR) 10Jdlrobson: [C: 032] Update MobileContext#logMobileMode documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398116 (owner: 10Phuedx) [03:17:55] (03Merged) 10jenkins-bot: Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [03:20:03] (03Merged) 10jenkins-bot: Promote expand all sections and fontchanger to stable [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396284 (https://phabricator.wikimedia.org/T169257) (owner: 10Jdlrobson) [03:20:22] 10Design, 10Page-Previews, 10Readers-Web-Backlog (Design): Hovercard could show an extract from the id downward when #IDname links are used - https://phabricator.wikimedia.org/T102280#3850266 (10Jdlrobson) Okay, @SMcCandlish point taken. Edge case was probably not the right phrase. I have definitely seen th... [03:20:55] (03Merged) 10jenkins-bot: Update MobileContext#logMobileMode documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398116 (owner: 10Phuedx) [03:21:00] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Tag possibly hard to differentiate from button? - https://phabricator.wikimedia.org/T183328#3850270 (10Volker_E) p:05Triage>03Normal [03:22:05] (03CR) 10jenkins-bot: Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [03:23:22] 10UI-Standardization, 10MobileFrontend, 10Patch-For-Review, 10UI-Standardization-Kanban: Arrows for close icon and arrow icons are the wrong size MobileFrontend MMV overlay - https://phabricator.wikimedia.org/T108657#3850283 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson [03:23:59] (03CR) 10jenkins-bot: Promote expand all sections and fontchanger to stable [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396284 (https://phabricator.wikimedia.org/T169257) (owner: 10Jdlrobson) [03:25:21] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Tag possibly hard to differentiate from button? - https://phabricator.wikimedia.org/T183328#3850286 (10Volker_E) [03:26:42] (03CR) 10jenkins-bot: Update MobileContext#logMobileMode documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398116 (owner: 10Phuedx) [03:27:46] (03PS1) 10Jdlrobson: Replace instances of constructive and remove option entirely [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399324 (https://phabricator.wikimedia.org/T182730) [03:27:53] (03CR) 10Jdlrobson: [C: 032] Replace instances of constructive and remove option entirely [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399324 (https://phabricator.wikimedia.org/T182730) (owner: 10Jdlrobson) [03:27:55] (03CR) 10jerkins-bot: [V: 04-1] Replace instances of constructive and remove option entirely [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399324 (https://phabricator.wikimedia.org/T182730) (owner: 10Jdlrobson) [03:28:01] (03CR) 10jerkins-bot: [V: 04-1] Replace instances of constructive and remove option entirely [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399324 (https://phabricator.wikimedia.org/T182730) (owner: 10Jdlrobson) [03:28:20] (03PS3) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [03:28:55] (03CR) 10MarkAHershberger: "Thanks! I'm trying that now." [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [03:29:08] (03Abandoned) 10Jdlrobson: Replace instances of constructive and remove option entirely [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399324 (https://phabricator.wikimedia.org/T182730) (owner: 10Jdlrobson) [03:29:23] (03PS3) 10Jdlrobson: Replace instances of constructive and remove option entirely [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398213 (https://phabricator.wikimedia.org/T182730) (owner: 10VolkerE) [03:29:31] (03CR) 10Jdlrobson: [C: 032] Replace instances of constructive and remove option entirely [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398213 (https://phabricator.wikimedia.org/T182730) (owner: 10VolkerE) [03:33:19] (03PS6) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [03:33:24] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3850298 (10Volker_E) [03:36:20] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Clarify & streamline user experience of TagMultiselectWidget variants - https://phabricator.wikimedia.org/T162965#3850299 (10Volker_E) Merging this with parent task and file sub-tasks on specific issues. [03:37:36] (03Merged) 10jenkins-bot: Replace instances of constructive and remove option entirely [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398213 (https://phabricator.wikimedia.org/T182730) (owner: 10VolkerE) [03:38:03] (03CR) 10EBernhardson: Push pagination decision for prefix search into SearchEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399312 (owner: 10EBernhardson) [03:38:40] 10UI-Standardization, 10MobileFrontend: Remove constructive flag leftovers - https://phabricator.wikimedia.org/T182730#3850301 (10Volker_E) 05Open>03Resolved p:05Triage>03High a:03Volker_E [03:39:58] (03PS1) 10Jdlrobson: Merge remote-tracking branch 'origin/master' into HEAD [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399325 [03:40:02] (03CR) 10jenkins-bot: Replace instances of constructive and remove option entirely [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/398213 (https://phabricator.wikimedia.org/T182730) (owner: 10VolkerE) [03:40:48] (03CR) 10Jdlrobson: [C: 032] Merge remote-tracking branch 'origin/master' into HEAD [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399325 (owner: 10Jdlrobson) [03:46:52] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399325 (owner: 10Jdlrobson) [03:48:56] (03PS1) 10Jdlrobson: Drop use of MobileOptionsTracking schema [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399327 (https://phabricator.wikimedia.org/T182235) [03:49:18] (03CR) 10jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399325 (owner: 10Jdlrobson) [03:49:41] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Promote fontchanger to stable (in feature branch) - https://phabricator.wikimedia.org/T109364#3850310 (10Jdlrobson) Code is deployed on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions [03:49:55] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Promote expand all sections feature from beta (in feature branch) - https://phabricator.wikimedia.org/T169257#3850311 (10Jdlrobson) Code is deployed on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOpt... [03:49:59] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Replace settings checkboxes to ToggleSwitches - https://phabricator.wikimedia.org/T169807#3850312 (10Jdlrobson) Code is deployed on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOpt... [03:50:01] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Change font size controls to use small, regular, large and extra large buckets - https://phabricator.wikimedia.org/T169369#3850313 (10Jdlrobson) Code is deployed on http://reading-web-staging.wmflabs.org/wiki/Specia... [03:52:42] (03CR) 10jerkins-bot: [V: 04-1] Drop use of MobileOptionsTracking schema [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399327 (https://phabricator.wikimedia.org/T182235) (owner: 10Jdlrobson) [04:00:32] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3850318 (10Jdlrobson) > We should check for existence of "Android" and "Chrome" in user agent... [04:02:45] (03PS1) 10Boboivancich: Replace search_type scan, deprecated in ElasticSearch 2.1 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399328 [04:04:27] (03PS1) 10Jdlrobson: Move js-only css off critical path [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399329 [04:04:29] (03PS1) 10Jdlrobson: Remove unused css rules [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399330 [04:04:31] (03PS1) 10Jdlrobson: Only load notification icon for logged in users [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399331 [04:04:33] (03PS1) 10Jdlrobson: Change way we lod mediawiki.ui.button [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399332 [04:04:35] (03PS1) 10Jdlrobson: mw-ui-button-group only loaded where needed [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399333 [04:04:37] (03PS1) 10Jdlrobson: Do not load overlay styles on page load [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399334 [04:04:39] (03PS1) 10Jdlrobson: Logged in only styles [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399335 [04:04:41] (03PS1) 10Jdlrobson: Generalise page actions rule [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399336 [04:04:43] (03PS1) 10Jdlrobson: Restrict gallery styles to only pages which need it [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399337 [04:12:26] (03CR) 10jerkins-bot: [V: 04-1] Remove unused css rules [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399330 (owner: 10Jdlrobson) [04:12:53] (03CR) 10jerkins-bot: [V: 04-1] Only load notification icon for logged in users [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399331 (owner: 10Jdlrobson) [04:13:32] (03CR) 10jerkins-bot: [V: 04-1] mw-ui-button-group only loaded where needed [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399333 (owner: 10Jdlrobson) [04:14:05] (03CR) 10jerkins-bot: [V: 04-1] Move js-only css off critical path [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399329 (owner: 10Jdlrobson) [04:14:52] (03CR) 10jerkins-bot: [V: 04-1] Change way we lod mediawiki.ui.button [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399332 (owner: 10Jdlrobson) [04:19:57] (03CR) 10jerkins-bot: [V: 04-1] Logged in only styles [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399335 (owner: 10Jdlrobson) [04:20:06] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399328 (owner: 10Boboivancich) [04:20:15] (03CR) 10jerkins-bot: [V: 04-1] Do not load overlay styles on page load [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399334 (owner: 10Jdlrobson) [04:20:39] (03CR) 10jerkins-bot: [V: 04-1] Generalise page actions rule [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399336 (owner: 10Jdlrobson) [04:21:04] 10Timeless, 10CSS: Add-portlet-link gadgets and scripts in "more" menu are missing in Timeless - https://phabricator.wikimedia.org/T181362#3850329 (10Izno) [04:21:07] 10Timeless: Gadgets don't add links to the "Tool" sidebar section - https://phabricator.wikimedia.org/T183172#3850331 (10Izno) [04:21:08] (03CR) 10jerkins-bot: [V: 04-1] Restrict gallery styles to only pages which need it [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399337 (owner: 10Jdlrobson) [04:26:03] 10Timeless, 10CSS: Add-portlet-link gadgets and scripts in "more" menu are missing in Timeless - https://phabricator.wikimedia.org/T181362#3850334 (10Izno) I wonder if it makes sense/is possible to add a JavaScript method which allows a skin agnostic location for portlet manipulation and then let the JavaScrip... [04:28:33] (03PS2) 10Jdlrobson: Move js-only css off critical path [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399329 [04:28:35] (03PS2) 10Jdlrobson: Remove unused css rules [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399330 [04:28:37] (03PS2) 10Jdlrobson: Only load notification icon for logged in users [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399331 [04:28:39] (03PS2) 10Jdlrobson: Change way we lod mediawiki.ui.button [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399332 [04:28:41] (03PS2) 10Jdlrobson: mw-ui-button-group only loaded where needed [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399333 [04:28:43] (03PS2) 10Jdlrobson: Do not load overlay styles on page load [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399334 [04:28:45] (03PS2) 10Jdlrobson: Logged in only styles [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399335 [04:28:47] (03PS2) 10Jdlrobson: Generalise page actions rule [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399336 [04:28:49] (03PS2) 10Jdlrobson: Restrict gallery styles to only pages which need it [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399337 [04:36:28] (03CR) 10jerkins-bot: [V: 04-1] Move js-only css off critical path [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399329 (owner: 10Jdlrobson) [04:36:40] (03CR) 10jerkins-bot: [V: 04-1] Change way we lod mediawiki.ui.button [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399332 (owner: 10Jdlrobson) [04:37:18] (03CR) 10jerkins-bot: [V: 04-1] Only load notification icon for logged in users [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399331 (owner: 10Jdlrobson) [04:37:56] (03CR) 10jerkins-bot: [V: 04-1] Remove unused css rules [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399330 (owner: 10Jdlrobson) [04:43:07] (03CR) 10jerkins-bot: [V: 04-1] Logged in only styles [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399335 (owner: 10Jdlrobson) [04:43:28] (03CR) 10jerkins-bot: [V: 04-1] mw-ui-button-group only loaded where needed [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399333 (owner: 10Jdlrobson) [04:44:14] (03CR) 10jerkins-bot: [V: 04-1] Generalise page actions rule [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399336 (owner: 10Jdlrobson) [04:44:19] (03CR) 10jerkins-bot: [V: 04-1] Do not load overlay styles on page load [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399334 (owner: 10Jdlrobson) [04:45:09] (03CR) 10jerkins-bot: [V: 04-1] Restrict gallery styles to only pages which need it [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399337 (owner: 10Jdlrobson) [05:19:28] (03CR) 10Phantom42: "Okay. I will do that" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399241 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [05:19:37] (03Abandoned) 10Phantom42: Add cURL PHP extension to the list of composer requirements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399241 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [05:24:39] 10Wikimedia-IEG-grant-review: Integrate with OAuth - https://phabricator.wikimedia.org/T74292#3850339 (10bd808) Notes from an email conversation: > @bd808 wrote: >> @Nehajha wrote: >>> @bd808 wrote: >>> Grants is a little different. The current user account system handles both authentication (who are you) and au... [05:26:43] 10Wikimedia-IEG-grant-review: "Add Proposal" does not report form errors back to view - https://phabricator.wikimedia.org/T86509#3850341 (10bd808) a:05Dharavihol>03None [05:27:34] (03PS1) 10Phantom42: Add cURL PHP extension to the list of composer requirements [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399339 (https://phabricator.wikimedia.org/T166355) [05:46:43] 10MediaWiki-Vagrant, 10User-zeljkofilipin: wikidata role produces error when trying to create item - https://phabricator.wikimedia.org/T183307#3850346 (10bd808) Possibly related to {T181769}. [05:47:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-Wishlist-Survey-2016, 10Goal: [Goal] Sitelinks to Incubator, OldWikisource and BetaWikiversity - https://phabricator.wikimedia.org/T54971#3850348 (10Billinghurst) Ouch everyone. Merry Christmas to you all. The issue we have is a clash of t... [05:47:48] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3850349 (10bd808) [05:54:31] 10MediaWiki-extensions-UniversalLanguageSelector, 10I18n: The language code 'de-DE' is ignored in Accept-Language HTTP header - https://phabricator.wikimedia.org/T183295#3850356 (10Fomafix) [06:00:46] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3850369 (10bd808) [06:10:49] 10Wikipedia-Android-App-Backlog: When a user subscribes for monthly donation, stop showing the donation announcement - https://phabricator.wikimedia.org/T183330#3850374 (10Sharvaniharan) [06:12:03] 10Wikipedia-Android-App-Backlog: Create an option to donate through Google Pay - https://phabricator.wikimedia.org/T183331#3850386 (10Sharvaniharan) [06:12:13] (03PS1) 10Fomafix: Introduce language codes 'de-de' and 'en-us' [core] - 10https://gerrit.wikimedia.org/r/399341 (https://phabricator.wikimedia.org/T183295) [06:13:14] 10Wikipedia-Android-App-Backlog: Investigate crash - https://phabricator.wikimedia.org/T183332#3850399 (10Sharvaniharan) [06:16:08] 10Wikipedia-Android-App-Backlog: Black theme doesn't render few articles properly - https://phabricator.wikimedia.org/T183333#3850410 (10Sharvaniharan) [06:18:09] 10Wikipedia-Android-App-Backlog: Make it easier to find feedback screen - https://phabricator.wikimedia.org/T183334#3850422 (10Sharvaniharan) [06:32:55] 10Developer-Relations (Jul-Sep 2017), 10Google-Summer-of-Code (2017), 10Outreachy (Round-14): Engage student developers in projects and movement activities post-GSoC/ Outreachy completion - https://phabricator.wikimedia.org/T183335#3850438 (10srishakatux) p:05Triage>03Normal [07:03:07] 10Chinese-Sites, 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3850477 (10Shizhao) [07:52:02] Hello Everyone, I am Dia. I joined this channel for a Google Code-in task https://codein.withgoogle.com/dashboard/task-instances/5869807364734976/ [07:59:22] (03PS4) 10Robert Vogel: Initial commit [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/398477 (owner: 10Dvogel hallowelt) [08:15:04] 10MediaWiki-extensions-UniversalLanguageSelector, 10I18n, 10Patch-For-Review: The language code 'de-DE' is ignored in Accept-Language HTTP header - https://phabricator.wikimedia.org/T183295#3849475 (10Nikerabbit) I disagree with the expected result to some extend. You should send `de-DE, de;q=0.9` to get you... [08:17:14] (03CR) 10Nikerabbit: [C: 04-2] "I think this is slippery slope that will lead to addition a lot of pointless locale fallbacks that can mislead and confuse users. Either t" [core] - 10https://gerrit.wikimedia.org/r/399341 (https://phabricator.wikimedia.org/T183295) (owner: 10Fomafix) [08:20:48] (03CR) 10WMDE-leszek: [C: 032] "I guess moving the hooks file/class was not necessarily needed. I see it contains some "maintenance" related stuff too. But whatever, coul" [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) (owner: 10Ladsgroup) [08:23:11] (03CR) 10Nikerabbit: "It strikes to me as odd to have such a specific and rarely used functionality in core." [core] - 10https://gerrit.wikimedia.org/r/398845 (https://phabricator.wikimedia.org/T182683) (owner: 10Matthias Mullie) [08:28:21] FlorianSW: Hi! Sorry, I was sleeping when you pinged me. Looks like the issues with the task are solved now. Is there anything else I need to do / improve? [08:29:18] (03Merged) 10jenkins-bot: Make the extension fully comply with PSR-4, use proper autoloader [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) (owner: 10Ladsgroup) [08:31:35] 04(no projects): text of revisions in the archive table that were deleted before Wikipedia started using MediaWiki 1.5 is corrupt, part 2 - https://phabricator.wikimedia.org/T183337#3850542 (10Graham87) [08:31:58] 10OOjs-UI: Implement ToggleSwitchInputWidget - https://phabricator.wikimedia.org/T182466#3850553 (10Jdlrobson) No, to be clearer what we are doing is creating a form with a Checkbox widget. When client-js class is added we make it visibility: hidden. With JavaScript we then replace the checkbox widget with a Tog... [08:33:58] 10MediaWiki-History-or-Diffs: text of revisions in the archive table that were deleted before Wikipedia started using MediaWiki 1.5 is corrupt, part 2 - https://phabricator.wikimedia.org/T183337#3850555 (10Graham87) [08:38:01] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3850569 (10Tbayer) >>! In T182235#3848975, @phuedx wrote: >>>! In T182235#3848974, @Tbayer wrot... [08:46:30] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3850583 (10Tbayer) Note that data source #3 from the task description, on user preferences, is... [08:56:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3850603 (10Lea_Lacroix_WMDE) FYI @Lydia_Pintscher : ready to go [09:06:13] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3850610 (10Ainali) p:05Triage>03Normal [09:08:56] 10MediaWiki-Special-pages, 10VisualEditor: Special:RelatedChanges is shown as a template on the visual editor - https://phabricator.wikimedia.org/T183340#3850616 (10Trizek-WMF) [09:10:31] 10MediaWiki-Special-pages, 10VisualEditor: Special:RelatedChanges is shown as a template on the visual editor - https://phabricator.wikimedia.org/T183340#3850627 (10Trizek-WMF) [09:18:29] (03PS1) 10Mobrovac: Use the new versions of mocha and eslint and their configs [services/chromium-render] - 10https://gerrit.wikimedia.org/r/399361 [09:19:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3850638 (10Lydia_Pintscher) Cool. Anyone up for making a patch again? [09:19:09] (03CR) 10Mobrovac: "check experimental" [services/chromium-render] - 10https://gerrit.wikimedia.org/r/399361 (owner: 10Mobrovac) [09:19:57] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Donate with foreign IBAN w/o adding BIC - https://phabricator.wikimedia.org/T181151#3781276 (10gabriel-wmde) a:03gabriel-wmde [09:25:27] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not properly update subscriber count - https://phabricator.wikimedia.org/T183189#3846233 (10QuimGil) One question, does the number of subscribers get out of sync after adding/removing someone manually only temporar... [09:32:07] (03Draft2) 10Pwirth: Added switch language support [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/399362 [09:33:39] (03CR) 10Mobrovac: "Ifa503f878f04c2f1868c3b44c4dcab3c5ed7bf9d fixes the linting issues, but there is still a problem with getting the PDF." [services/chromium-render] - 10https://gerrit.wikimedia.org/r/394623 (owner: 10Bmansurov) [09:33:43] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10DBA, 10Data-Services, 10Dumps-Generation, and 2 others: Schema change for refactored comment storage - https://phabricator.wikimedia.org/T174569#3850655 (10Marostegui) s1 is all done but the master. I will alter the master after Christmas. [09:34:07] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10DBA, 10Data-Services, 10Dumps-Generation, and 2 others: Schema change for refactored comment storage - https://phabricator.wikimedia.org/T174569#3850656 (10Marostegui) [09:34:38] (03CR) 10Mobrovac: "Linting issues fixed, but it still unable to get the PDF. Might be related to the fact that the service shells out to chromium but the CI " [services/chromium-render] - 10https://gerrit.wikimedia.org/r/399361 (owner: 10Mobrovac) [10:21:08] 10MediaWiki-extensions-WikimediaMaintenance, 10Wikimedia-Interwiki-links, 10Wikimedia-Site-requests, 10Patch-For-Review, and 3 others: The href of be-tarask: interlanguage link points to the be-x-old domain - https://phabricator.wikimedia.org/T111853#3850767 (10Dvorapa) [10:22:44] 10MediaWiki-Core-Tests, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10User-Addshore: RevisionRecordTest is empty - https://phabricator.wikimedia.org/T183219#3850769 (10Addshore) 05Open>03Resolved [10:25:12] 10Android-app-Bugs, 10Mobile-Content-Service, 10MobileApp, 10Reading-Infrastructure-Team-Backlog, 10Wikipedia-Android-App-Backlog: mobile view rest api showing old content for current revision - https://phabricator.wikimedia.org/T183347#3850775 (10TheDJ) [10:25:16] (03CR) 10DCausse: [C: 032] "thanks!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399328 (owner: 10Boboivancich) [10:26:50] (03CR) 10Zfilipin: [C: 031] "Anything left to do here, or can this be merged?" [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/394539 (https://phabricator.wikimedia.org/T180777) (owner: 10Jdrewniak) [10:31:39] 10MediaWiki-extensions-UniversalLanguageSelector, 10I18n, 10Patch-For-Review: The language code 'de-DE' is ignored in Accept-Language HTTP header - https://phabricator.wikimedia.org/T183295#3850796 (10Fomafix) Of course when you set ``` Accept-Language: de-DE, de;q=0.9 ``` then you get `de`. But the ``` Acc... [10:31:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "This is all fine, But can we remove this "bootstrap" line please? (Or explain why it's necessary?)" (032 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [10:32:02] (03Merged) 10jenkins-bot: Replace search_type scan, deprecated in ElasticSearch 2.1 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399328 (owner: 10Boboivancich) [10:32:36] (03CR) 10Hashar: "recheck" [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399337 (owner: 10Jdlrobson) [10:33:50] (03CR) 10Hashar: "recheck" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [10:33:54] (03CR) 10Hashar: "recheck" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [10:34:12] (03CR) 10Hashar: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [10:34:22] 10MediaWiki-Vagrant: https does not seem to be working on vagrant - bad gateway - https://phabricator.wikimedia.org/T183304#3850800 (10zeljkofilipin) [10:35:12] (03CR) 10Hashar: "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/394132 (https://phabricator.wikimedia.org/T173186) (owner: 10Framawiki) [10:36:14] 10MediaWiki-Vagrant: packages are missing for cirrussearch role - https://phabricator.wikimedia.org/T183306#3850804 (10zeljkofilipin) [10:36:32] 10MediaWiki-Vagrant: Secure login notice on new vagrant install - https://phabricator.wikimedia.org/T183302#3850811 (10zeljkofilipin) [10:36:56] 10MediaWiki-Vagrant: wikidata role produces error when trying to create item - https://phabricator.wikimedia.org/T183307#3850814 (10zeljkofilipin) [10:37:24] 10MediaWiki-Vagrant: elasticsearch package missing for geodata_elastic role - https://phabricator.wikimedia.org/T183305#3850816 (10zeljkofilipin) [10:38:47] (03CR) 10Thiemo Kreuz (WMDE): "Looks fine, except for some details I want to point out. See my inline comments." (033 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 (owner: 10MarkAHershberger) [10:40:38] (03CR) 10jerkins-bot: [V: 04-1] Restrict gallery styles to only pages which need it [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399337 (owner: 10Jdlrobson) [10:42:40] I'm back guyz [10:42:44] what's up? [10:42:53] RootKlawiter: Welcome back! [10:42:53] (03PS1) 10DCausse: Fix metastore dump [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399374 [10:44:12] (03PS3) 10Jdlrobson: Move js-only css off critical path [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399329 [10:44:20] (03PS3) 10Jdlrobson: Remove unused css rules [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399330 [10:44:29] (03PS3) 10Jdlrobson: Only load notification icon for logged in users [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399331 [10:46:03] (03PS1) 10DCausse: Remove iterateOverScroll [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399376 [10:46:06] (03CR) 10jerkins-bot: [V: 04-1] Fix metastore dump [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399374 (owner: 10DCausse) [10:47:37] (03PS2) 10DCausse: Fix metastore dump [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399374 [10:47:43] (03CR) 10jerkins-bot: [V: 04-1] Remove iterateOverScroll [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399376 (owner: 10DCausse) [10:50:04] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Status classes (e.g. error) for field validity - https://phabricator.wikimedia.org/T182850#3850837 (10Pablo-WMDE) [10:51:40] (03PS1) 10Thiemo Kreuz (WMDE): Remove repetitions of the extensions name from directories & classes [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399379 (https://phabricator.wikimedia.org/T183260) [10:51:57] (03CR) 10jerkins-bot: [V: 04-1] Move js-only css off critical path [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399329 (owner: 10Jdlrobson) [10:52:31] (03CR) 10jerkins-bot: [V: 04-1] Only load notification icon for logged in users [skins/MinervaNeue] (firsterpaint) - 10https://gerrit.wikimedia.org/r/399331 (owner: 10Jdlrobson) [10:53:40] (03CR) 10jerkins-bot: [V: 04-1] Remove repetitions of the extensions name from directories & classes [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399379 (https://phabricator.wikimedia.org/T183260) (owner: 10Thiemo Kreuz (WMDE)) [10:58:12] 10Design, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Update fontstack on mobile web to use system typefaces - https://phabricator.wikimedia.org/T175877#3850860 (10phuedx) a:03Jdrewniak I'm being **bold** and moving this onto the board for visibility for the rest of Readers Web (with the hope that t... [10:58:42] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Size and placement of tags and widget's input to add them - https://phabricator.wikimedia.org/T183325#3850864 (10Pginer-WMF) >>! In T183325#3850247, @Volker_E wrote: > @Pginer-WMF The size and placement part has been successfully implemented in... [11:02:15] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399374 (owner: 10DCausse) [11:03:53] (03CR) 10DCausse: "recheck" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399376 (owner: 10DCausse) [11:14:14] (03CR) 10Legoktm: [C: 032] Add minus-x to "composer test" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [11:14:21] (03CR) 10Legoktm: [C: 032] Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [11:15:41] (03Merged) 10jenkins-bot: Add minus-x to "composer test" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [11:15:48] (03Merged) 10jenkins-bot: Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [11:17:05] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3850880 (10tmletzko) @Hanna_Petruschat_WMDE the copy will be a lot shorter. see the shorter version in the google doc [11:29:09] (03PS4) 10Zfilipin: Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [11:37:00] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3850919 (10zeljkofilipin) [11:40:19] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3850923 (10zeljkofilipin) [11:40:38] 10Dumps-Generation, 10Patch-For-Review: check rsync of dumps to labs, there seems to be a delay - https://phabricator.wikimedia.org/T154798#3850924 (10ArielGlenn) 05Open>03Resolved I checked the files copied, and they are up to date as of the cron job run, for any completed files. We now copy any complete... [11:44:26] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3850927 (10zeljkofilipin) [11:44:34] yee [11:44:45] I were on my lessons, sorry [11:45:14] 10Design, 10WMDE-Analytics-Engineering, 10User-GoranSMilovanovic, 10WMDE-Design (WMDE-Design-Workboard Doing): WDCM: User feedback - https://phabricator.wikimedia.org/T179545#3850928 (10GoranSMilovanovic) 05Resolved>03Open @Lea_Lacroix_WMDE and @GoranSMilovanovic will take over from here. Thank you @J... [11:50:25] (03CR) 10Zfilipin: [C: 031] "Looks good to me. As soon as @Mattflaschen removes -2 this can be merged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [11:55:36] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Allow rendering PDFs for mobile - https://phabricator.wikimedia.org/T181680#3850935 (10phuedx) >>! In T181680#3849295, @bmansurov wrote: > In my opinion, technically the first option is easier and gives us the maximum bang for our buck. I agree th... [12:09:52] 10MediaWiki-extensions-UniversalLanguageSelector, 10I18n, 10Patch-For-Review: The language code 'de-DE' is ignored in Accept-Language HTTP header - https://phabricator.wikimedia.org/T183295#3850957 (10Fomafix) Here another example for the inconsistency: ``` Accept-Language: en-GB, en-US;q=0.9, en;q=0.8 ```... [12:11:15] Phantom42: to your question: No, there's nothing you need to do, thanks for asking :) [12:13:05] FlorianSW: Okay. Thank you! [12:14:02] 10Community-Liaisons (Oct-Dec 2017): Evaluations of CLs tasks by PMs, Q2 - https://phabricator.wikimedia.org/T182662#3850960 (10Elitre) I'm only missing @Abit's answer, then we'd be done here. [12:14:12] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not properly update subscriber count - https://phabricator.wikimedia.org/T183189#3850962 (10Pppery) As far as I can tell, nothing resyncs the subscriber count, so it will be out of sync until someone runs the updat... [12:25:01] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Donate with foreign IBAN w/o adding BIC - https://phabricator.wikimedia.org/T181151#3850992 (10kai.nissen) [12:27:01] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3850994 (10Gilles) [12:28:19] Zppix: Hi! [12:29:30] 10UI-Standardization, 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Adjust the personal header to align with the design styleguide - https://phabricator.wikimedia.org/T160918#3850997 (10Petar.petkovic) Did the design take into account the fact that user can be anonymous on __Special:Co... [12:30:29] 10MediaWiki-Vagrant, 10User-zeljkofilipin: Swift Vagrant role errors on stretch branch - https://phabricator.wikimedia.org/T183354#3850998 (10Gilles) p:05Triage>03Normal [12:30:33] 10MediaWiki-Vagrant, 10User-zeljkofilipin: Swift Vagrant role errors on Stretch branch - https://phabricator.wikimedia.org/T183354#3850998 (10Gilles) [12:31:06] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851011 (10Gilles) [12:34:09] (03PS2) 10Florianschmidtwelzow: Fail gracefully if curl is not installed [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399319 (https://phabricator.wikimedia.org/T166355) [12:34:43] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Animation of the random die in the FAB - https://phabricator.wikimedia.org/T180806#3851016 (10RHo) [12:34:59] (03CR) 10Zfilipin: [C: 04-1] "T182692 will explain why we did not implement something like this" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/396441 (owner: 10Jdlrobson) [12:35:12] (03CR) 10Zfilipin: [C: 04-1] "T182692 will explain why we did not implement something like this" [core] - 10https://gerrit.wikimedia.org/r/396440 (owner: 10Jdlrobson) [12:35:34] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851018 (10Kaartic) > Display the download button if Android version is 5.0 or above and Chro... [12:36:31] (03PS1) 10Aaron Schulz: Unbreak read-only transactions (used for consistent reads) [core] - 10https://gerrit.wikimedia.org/r/399391 [12:37:14] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not properly update subscriber count - https://phabricator.wikimedia.org/T183189#3851019 (1001tonythomas) Wow. then its a bug then. Let me deploy the latest to our http://newsletter-test.wmflabs.org/ [12:37:21] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Animation of the random die in the FAB - https://phabricator.wikimedia.org/T180806#3851020 (10RHo) QA test: Die animation occurs on tapping floating action button i... [12:37:30] Phantom42: hi [12:38:25] 10MediaWiki-extensions-DynamicPageList, 10Cite, 10Regression: Error with Dynamic Page List and rendering content after upgrading to 1.30.0 - https://phabricator.wikimedia.org/T183323#3851028 (10Aklapper) [12:39:02] Zppix: Glad to see you! I am working right now on GCI task mentored by you (welcome function to ZppixBot) [12:39:17] Sweet! [12:39:59] (03PS2) 10Fomafix: Introduce language codes 'de-de', 'en-us' and 'pt-pt' [core] - 10https://gerrit.wikimedia.org/r/399341 (https://phabricator.wikimedia.org/T183295) [12:40:32] I have submitted a pull request but got a comment saying that we need to ensure that each user is welcomed only once. There was nothing about this in task description. So I want to hear your opinion. Should we welcome each user only once (not after each rejoin)? If yes, I will update my pull request [12:42:29] Phantom42: honestly if you could do that would be awesome, and I would give extra brownie points [12:43:02] Zppix: Okay. Then I will do it. I will notify you once I am done. Thank you! [12:44:30] Phantom42: no problem! [12:47:46] (03PS10) 10Aaron Schulz: Replace cpPosTime cookie/parameter with cpPosIndex [core] - 10https://gerrit.wikimedia.org/r/396546 (https://phabricator.wikimedia.org/T182322) [12:54:07] 10MediaWiki-API, 10Parsoid, 10VisualEditor: VisualEditor corrupts data and repeats the first ~10kB - https://phabricator.wikimedia.org/T183356#3851051 (10Czech.Fox) [12:55:10] 10MediaWiki-API, 10Parsoid, 10VisualEditor: VisualEditor corrupts data and repeats the first ~10kB - https://phabricator.wikimedia.org/T183356#3851062 (10Czech.Fox) [12:55:57] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline - https://phabricator.wikimedia.org/T182803#3851066 (10RHo) hi @Sharvaniharan - please just center the message in the ca... [13:01:30] 10Community-Liaisons (Jan-Mar-2018): Set up a Phabricator workboard/project for #techambassadors and experiment with it - https://phabricator.wikimedia.org/T183278#3851081 (10Elitre) >>! In T183278#3849160, @Aklapper wrote: > See https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects if you wa... [13:02:36] 10MediaWiki-Vagrant: Swift Vagrant role errors on Stretch branch - https://phabricator.wikimedia.org/T183354#3851090 (10zeljkofilipin) [13:02:57] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851092 (10zeljkofilipin) [13:04:50] (03CR) 10Esanders: Remove editor switching infrastructure in favor of VE's source mode (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [13:07:53] (03CR) 10Zfilipin: "CirrusSearch has three things different than other repositories with Selenium tests." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [13:08:22] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, 10German-Community-Wishlist, and 3 others: Investigate what the ideal change detection threshold would be - https://phabricator.wikimedia.org/T181494#3851100 (10Lea_WMDE) [13:08:59] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, 10German-Community-Wishlist, and 3 others: Investigate what the ideal change detection threshold would be - https://phabricator.wikimedia.org/T181494#3792048 (10Lea_WMDE) [13:13:38] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3851117 (10Ainali) [13:15:15] 10Wikimedia-Site-requests: Enable create a Secure poll in Arwiki - https://phabricator.wikimedia.org/T183358#3851118 (10Ibrahim.ID) [13:16:41] Zppix: I am done with that. If you want live demo, join #phantom42BotTest [13:17:02] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-XMAS-Sprint-2017-12-20: Add a version selection page to prototype - https://phabricator.wikimedia.org/T183359#3851131 (10Lea_WMDE) [13:17:40] (03PS1) 10Esanders: Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 [13:19:32] (03CR) 10Esanders: "This only worked before because VE incorrectly gave us the ArticleTarget module via the mwwikitext module. Fixed upstream in Iaf1aefcbf94e" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (owner: 10Esanders) [13:20:48] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3851147 (10RHo) Hi @Sharvaniharan - there's just one visual regression and one new item: * *... [13:20:59] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851159 (10jcrespo) @Billinghurst In non-technical terms, it seems to be an overload of some kind- something that normally doesn't happen, but that the code should avoid from happening in any cas... [13:21:14] 10MobileFrontend, 10Readers-Web-Backlog: Reference anchor and target IDs use inconsistent percent encoding - https://phabricator.wikimedia.org/T183049#3851161 (10Niedzielski) [13:21:17] (03PS2) 10Esanders: Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) [13:21:24] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3851165 (10RHo) can move to QA once resolved [13:21:50] 10Repository-Admins: Access request: Phabricator Repository-Admins - https://phabricator.wikimedia.org/T183361#3851168 (10Paladox) [13:21:59] 10Chinese-Sites, 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3851181 (10Mvolz) [13:23:41] 10Design, 10WMDE-QWERTY-XMAS-Sprint-2017-12-20: Change prototype's resolution page for MVP testing - https://phabricator.wikimedia.org/T183362#3851183 (10Lea_WMDE) [13:25:45] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-XMAS-Sprint-2017-12-20: Show error message in prototype if not all versions have been selected - https://phabricator.wikimedia.org/T183363#3851195 (10Lea_WMDE) [13:26:08] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851209 (10jcrespo) @Ladsgroup After looking at database logs, I can confirm there is something really bad with the wikidata new item logic- each request has to lock the table, which esentially s... [13:26:13] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851210 (10bmansurov) > Why do we need to check the user agent for Chrome? Can we not rely on... [13:26:15] 10Design, 10WMDE-Design, 10WMDE-QWERTY-XMAS-Sprint-2017-12-20: Change prototype's resolution page for MVP testing - https://phabricator.wikimedia.org/T183362#3851211 (10Lea_WMDE) [13:26:54] 10Design, 10WMDE-Design, 10WMDE-QWERTY-XMAS-Sprint-2017-12-20: Change prototype's resolution page for MVP testing - https://phabricator.wikimedia.org/T183362#3851183 (10Lea_WMDE) [13:27:12] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-XMAS-Sprint-2017-12-20: Add a version selection page to prototype - https://phabricator.wikimedia.org/T183359#3851214 (10Lea_WMDE) [13:27:15] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Design (RW-Design-Debt), 10Epic: [Epic] Improve special page template - https://phabricator.wikimedia.org/T169162#3389128 (10Niedzielski) > NOTE: This doesn't account for the two "views" of the Watchlist. Please update screenshot/provide a mock. @Nirzar ^^^ [13:27:28] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3851218 (10Ainali) [13:27:59] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851220 (10Billinghurst) fwiw the phabricator ticket came on the seventh fail in however many minutes. 3 using tool, then 2 using create item; ask in IRC, get response try again through special... [13:28:19] (03CR) 10jerkins-bot: [V: 04-1] Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [13:29:57] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851222 (10jcrespo) @Billinghurst I was actually praising you for the report, for taking the time, and saying sorry it happened :-) [13:31:43] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851228 (10jcrespo) @Ladsgroup Without looking, I imagine a bot overloaded the creation, something that should be easy to check on recentchanges. Of course, that doesn't take away from avoiding o... [13:31:57] (03CR) 10DCausse: [C: 031] Fail gracefully if curl is not installed [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/399319 (https://phabricator.wikimedia.org/T166355) (owner: 10Florianschmidtwelzow) [13:33:44] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851229 (10Billinghurst) >>! In T183341#3851222, @jcrespo wrote: > @Billinghurst I was actually praising you for the report, for taking the time, and saying sorry it happened :-) Yep, also thoug... [13:34:21] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851230 (10bmansurov) a:05bmansurov>03None [13:35:16] Hi Everyone, I am Guneet. I have claimed a task so that is why I am here. [13:35:20] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851233 (10mark) p:05Triage>03High [13:35:27] Guneet: welcome [13:35:41] Thanks [13:35:42] Guneet: Welcome! Good luck with your tasks! [13:35:57] Hope So :) [13:38:40] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851234 (10phuedx) There's a lot to read through here. Is there a tl;dr version where one can... [13:41:44] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851235 (10bmansurov) @Jdlrobson summarized the outcome at T182059#3850317. [13:42:12] 10Chinese-Sites, 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3851236 (10Mvolz) Thanks for spear-heading this, @jayvdb Finding the templates to work on is alway... [13:42:23] 10Design, 10OOjs-UI, 10UI-Standardization, 10CSS, and 3 others: Adding 'margin-bottom' for widgets which are part of OOUI HorizontalLayout - https://phabricator.wikimedia.org/T179040#3851239 (10Phantom42) a:03Phantom42 I will work on fixing this :) [13:42:53] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3851243 (10Volker_E) [13:42:57] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Size and placement of tags and widget's input to add them - https://phabricator.wikimedia.org/T183325#3851241 (10Volker_E) 05Open>03Resolved a:03Mooeypoo [13:44:50] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851245 (10Ladsgroup) Yeah, it seems a bot is making 70 items per minute: https://www.wikidata.org/w/index.php?title=Special:NewPages&dir=prev&offset=20171220133138&limit=500 70 edits per minute... [13:46:22] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3851246 (10zeljkofilipin) [13:46:25] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851247 (10Lydia_Pintscher) @Daniel_Mietchen ^ [13:46:45] 10MediaWiki-Database, 10Wikidata: New item fails (Special and WEF tool) - https://phabricator.wikimedia.org/T183341#3851249 (10jcrespo) Yes, the slowdown should avoid issues until a fix is conceived. [13:50:42] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3851250 (10Ainali) [13:55:32] 10MediaWiki-Vagrant: Swift Vagrant role errors on Stretch branch - https://phabricator.wikimedia.org/T183354#3851269 (10Paladox) Is it because we do Ring[''] instead of Swift::Ring['']? [13:56:07] 10GoogleLogin: Unable to Integrate Google Login Extension - https://phabricator.wikimedia.org/T183365#3851270 (10Vishalkshinde) [13:56:51] 10MediaWiki-Vagrant: packages are missing for cirrussearch role - https://phabricator.wikimedia.org/T183306#3851283 (10Paladox) wmf-elasticsearch-search-plugins needs to be imported into wikimedia-stretch i think. [13:57:38] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851284 (10zeljkofilipin) [13:57:55] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851295 (10zeljkofilipin) p:05Triage>03High [13:58:04] 10GoogleLogin: Unable to Integrate Google Login Extension - https://phabricator.wikimedia.org/T183365#3851296 (10Vishalkshinde) [13:59:25] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851284 (10zeljkofilipin) [14:00:16] (03CR) 10Catrope: [EXPERIMENTAL] Isomorphic react app (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398523 (owner: 10Sbisson) [14:00:54] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851301 (10zeljkofilipin) [14:02:34] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10User-zeljkofilipin: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851284 (10zeljkofilipin) [14:04:39] (03PS4) 10Matthias Mullie: Add patent selection to Special:Upload [core] - 10https://gerrit.wikimedia.org/r/398845 (https://phabricator.wikimedia.org/T182683) [14:04:50] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Define clear (visual) indication of draggable tags - https://phabricator.wikimedia.org/T183368#3851320 (10Volker_E) p:05Triage>03Normal [14:06:03] 10MediaWiki-extensions-Contributors: Contributors extension can't find articles - https://phabricator.wikimedia.org/T183369#3851331 (10Rudloff) [14:07:12] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget: Clarify appearance of invalid tags - https://phabricator.wikimedia.org/T183371#3851355 (10Volker_E) p:05Triage>03Lowest [14:12:38] 10MediaWiki-Vagrant: Swift Vagrant role errors on Stretch branch - https://phabricator.wikimedia.org/T183354#3851370 (10Gilles) Yes, but that's not the only problem, once that part's fixed. [14:16:31] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10User-zeljkofilipin: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851372 (10zeljkofilipin) ``` $ vagrant git-update (all ok) $ vagrant provision ... ==> default: Notice: /Stage[ma... [14:17:31] (03PS1) 10Gilles: Fix Swift role for Stretch [vagrant] - 10https://gerrit.wikimedia.org/r/399398 (https://phabricator.wikimedia.org/T183354) [14:17:38] (03CR) 10jerkins-bot: [V: 04-1] Fix Swift role for Stretch [vagrant] - 10https://gerrit.wikimedia.org/r/399398 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:20:19] (03CR) 10Paladox: "Needs to be on stretch-migration?" [vagrant] - 10https://gerrit.wikimedia.org/r/399398 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:20:48] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10User-zeljkofilipin: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851384 (10zeljkofilipin) ``` $ vagrant reload (all ok) $ vagrant provision ... ==> default: Notice: /Stage[main]/... [14:21:29] (03CR) 10Thiemo Kreuz (WMDE): "Thanks a lot for continuing to work on this. This looks much better now. I'm fine with most changes I see in here now, except for a few de" (035 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [14:21:55] (03CR) 10Gilles: "Yeah, I know, it's on that branch locally but git review/gerrit decided to be quite unhelpful." [vagrant] - 10https://gerrit.wikimedia.org/r/399398 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:22:09] 10Design, 10OOjs-UI, 10UI-Standardization: TagMultiselectWidget (inline input): Ensure discoverability of inline editing - https://phabricator.wikimedia.org/T183372#3851385 (10Volker_E) p:05Triage>03Normal [14:22:21] (03CR) 10Catrope: [C: 031] Fix editor switcher inheritance (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [14:22:43] (03PS3) 10Catrope: Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [14:22:55] (03CR) 10Catrope: "PS3: Remove cross-repo @inheritDoc directives, they don't work" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [14:23:18] (03CR) 10Gilles: "The parent commit id is correct, it's one from that branch..." [vagrant] - 10https://gerrit.wikimedia.org/r/399398 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:23:51] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3851400 (10Ainali) [14:23:58] (03CR) 10Thiemo Kreuz (WMDE): Do some maintenance (031 comment) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/366201 (owner: 10Kghbln) [14:25:28] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Clarify & streamline user experience of TagMultiselectWidget variants - https://phabricator.wikimedia.org/T162965#3851402 (10Volker_E) [14:25:47] (03PS1) 10Gilles: Fix Swift role for Stretch [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399403 (https://phabricator.wikimedia.org/T183354) [14:26:13] (03Abandoned) 10Gilles: Fix Swift role for Stretch [vagrant] - 10https://gerrit.wikimedia.org/r/399398 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:26:58] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Clarify & streamline user experience of TagMultiselectWidget variants - https://phabricator.wikimedia.org/T162965#3181613 (10Volker_E) [14:27:10] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10User-zeljkofilipin: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851410 (10zeljkofilipin) ``` $ cd mediawiki/extensions/GlobalUsage $ git log commit d7a27b9364fc3a8dca21982e67e... [14:27:13] (03CR) 10Jdrewniak: "> Anything left to do here, or can this be merged?" [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/394539 (https://phabricator.wikimedia.org/T180777) (owner: 10Jdrewniak) [14:27:26] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: Clarify & streamline user experience of TagMultiselectWidget variants - https://phabricator.wikimedia.org/T162965#3181613 (10Volker_E) [14:27:30] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3851415 (10Volker_E) [14:28:36] (03PS1) 10Catrope: Follow-up 36f4daf32c: allow no-write database connections to use transactions [core] - 10https://gerrit.wikimedia.org/r/399404 (https://phabricator.wikimedia.org/T183265) [14:28:58] (03CR) 10Catrope: Prevent write operations to database replicas. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [14:29:39] 10Design, 10OOjs-UI, 10UI-Standardization: Streamline & improve tag component TagMultiselectWidget (former CapsuleMultiselectWidget) - https://phabricator.wikimedia.org/T158400#3851419 (10Volker_E) [14:30:22] (03CR) 10Catrope: [C: 032] Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [14:31:32] 10Discovery, 10Discovery-Analysis (Current work): Search Relevance Survey test #3: analysis of test - https://phabricator.wikimedia.org/T175048#3851422 (10TJones) >>! In T175048#3849795, @mpopov wrote: > Alrighty, here ya go! It's not as pretty as you were probably expecting! Thanks! I'm not sure what I was e... [14:31:50] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851424 (10Kaartic) @phuedx I guess I could help you a little. > What is the list of browser... [14:35:27] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851427 (10Kaartic) >>! In T182197#3851210, @bmansurov wrote: >> @bmansurov I thought you mea... [14:37:42] (03Merged) 10jenkins-bot: Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [14:37:57] (03CR) 10jenkins-bot: Fix editor switcher inheritance [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399394 (https://phabricator.wikimedia.org/T183360) (owner: 10Esanders) [14:38:40] (03CR) 10Gilles: [C: 032] Fix Swift role for Stretch [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399403 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:39:00] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851430 (10Gilles) [14:39:05] 10MediaWiki-Vagrant, 10Patch-For-Review: Swift Vagrant role errors on Stretch branch - https://phabricator.wikimedia.org/T183354#3851429 (10Gilles) 05Open>03Resolved [14:39:20] (03Merged) 10jenkins-bot: Fix Swift role for Stretch [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399403 (https://phabricator.wikimedia.org/T183354) (owner: 10Gilles) [14:39:23] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3787138 (10Gilles) [14:40:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Full review done. See inline comments." (033 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398519 (owner: 10MarkAHershberger) [14:41:31] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10User-zeljkofilipin: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851443 (10zeljkofilipin) p:05High>03Low [14:46:24] (03PS1) 10Rafidaslam: Add minus-x to "composer test" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399407 (https://phabricator.wikimedia.org/T175794) [14:47:45] (03PS1) 10Rafidaslam: Add minus-x to "composer test" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399408 (https://phabricator.wikimedia.org/T175794) [14:47:52] 10MediaWiki-extensions-Contributors: Contributors extension can't find articles - https://phabricator.wikimedia.org/T183369#3851447 (10Rudloff) Turns out I had to run `maintenance/PopulateContributorsTable.php` and now Special:Contributors works correctly. (This should probably be added to [the wiki page](https:... [14:48:34] (03PS7) 10ItSpiderman: [WIP] Role permission system [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/393206 [14:48:39] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3851448 (10Ainali) [14:48:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Role permission system [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/393206 (owner: 10ItSpiderman) [14:48:59] 10MediaWiki-Vagrant: Fix Statsd role for Stretch - https://phabricator.wikimedia.org/T183374#3851449 (10Gilles) p:05Triage>03Normal [14:49:23] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851459 (10Gilles) [14:50:46] (03PS3) 10ItSpiderman: [WIP] Switch to Role model [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/398043 [14:54:59] 10MediaWiki-API: Use list=blocks to return all single IP blocks in a CIDR - https://phabricator.wikimedia.org/T183300#3849598 (10Anomie) > Extending on the functionality of `blocks&bkip=` (which returns a result only if the queried CIDR falls within an existing blocked range), we should also return all single IP... [14:57:44] 10MediaWiki-Page-deletion: Use ar_parent_id on undeletion - https://phabricator.wikimedia.org/T183375#3851477 (10Lahwaacz) [14:58:44] 10MediaWiki-Page-deletion: Use ar_parent_id on undeletion - https://phabricator.wikimedia.org/T183375#3851489 (10Lahwaacz) [14:59:54] 10MediaWiki-Vagrant, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10User-zeljkofilipin: Can not provision cirrussearch mediawiki-vagrant role - https://phabricator.wikimedia.org/T183366#3851491 (10zeljkofilipin) [15:02:39] Phantom42 : I hope you have completed most of the lua task as i saw you in leaderboard of wikimedia tasks. Just have on question, are we allowed to hadle lua code too rather than just invoking it in the sandbox? [15:04:32] heisenberg: which Lua task are you on currently? [15:04:58] heisenberg: Unluckily I didn't do any Lua tasks. You may ask your mentor for help. Anyway, please provide more information about your task [15:06:06] heisenberg: What do you mean by "hadle"? [15:06:46] You get to write some of your own code [15:07:04] but I need to take you through the basics first [15:07:23] If you know another language, you'll fly through the first 9 tasks [15:08:41] (03PS1) 10Thiemo Kreuz (WMDE): Disable hooks instead of accessing private Cite properties [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/399412 (https://phabricator.wikimedia.org/T183323) [15:12:32] Phantom42 : oh, its ok no problem [15:13:00] (03CR) 10Zfilipin: [C: 031] "@Jdrewniak Do you want to move wikimedia-portals-deploy-npm-browser-node-6-docker job from experimental pipeline to test and gate-and-subm" [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/394539 (https://phabricator.wikimedia.org/T180777) (owner: 10Jdrewniak) [15:13:38] cf fairfield : just on 2nd :p [15:14:00] bawolf: handle* [15:15:09] RexxS : ok mentor, BTW i have submitted task 2 for review. [15:16:02] and I've just replied and approved it :P [15:17:06] 10MediaWiki-API: Make ar_parent_id visible through the API - https://phabricator.wikimedia.org/T183376#3851507 (10Lahwaacz) [15:18:22] 10Design, 10OOjs-UI, 10UI-Standardization, 10CSS, and 3 others: Adding 'margin-bottom' for widgets which are part of OOUI HorizontalLayout - https://phabricator.wikimedia.org/T179040#3851517 (10Phantom42) Well, I checked source code for `EditPage` and I noticed that those buttons are not part of `Horizonta... [15:19:44] (03PS1) 10Gilles: Add ability to pass variables to systemd service template [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399414 (https://phabricator.wikimedia.org/T183374) [15:19:46] (03PS1) 10Gilles: Fix Statsd role for Stretch [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399415 (https://phabricator.wikimedia.org/T183374) [15:20:35] (03PS1) 10Phantom42: Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) [15:22:52] (03CR) 10Krinkle: [C: 031] "Thanks Volker. I appreciate it. Let me know if you need any input on the other commit, too." [core] - 10https://gerrit.wikimedia.org/r/372551 (https://phabricator.wikimedia.org/T171365) (owner: 10Jdlrobson) [15:23:04] (03PS1) 10Thiemo Kreuz (WMDE): Remove some non-helpful comments [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/399417 [15:23:43] 10Design, 10OOjs-UI, 10UI-Standardization, 10CSS, and 4 others: Adding 'margin-bottom' for widgets which are part of OOUI HorizontalLayout - https://phabricator.wikimedia.org/T179040#3851526 (10Phantom42) Anyway, I will submit a patch for OOUI too, so it fixes issue on second screenshot [15:24:38] (03PS1) 10Sebastian Berlin (WMSE): Break out lexicon tool while under development [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/399418 (https://phabricator.wikimedia.org/T182861) [15:24:58] (03PS1) 10Sebastian Berlin (WMSE): Reintroduce lexicon tool special page, commits e559d75 and 01f254d [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/399419 (https://phabricator.wikimedia.org/T182861) [15:26:10] (03CR) 10Sebastian Berlin (WMSE): "This should be kept in a separate branch until the lexicon tool is done." [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/399419 (https://phabricator.wikimedia.org/T182861) (owner: 10Sebastian Berlin (WMSE)) [15:26:24] (03CR) 10jerkins-bot: [V: 04-1] Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) (owner: 10Phantom42) [15:30:06] 10UI-Standardization, 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Adjust the personal header to align with the design styleguide - https://phabricator.wikimedia.org/T160918#3851535 (10Pginer-WMF) >>! In T160918#3850997, @Petar.petkovic wrote: > Did the design take into account the fa... [15:30:33] (03PS2) 10Phantom42: Add `margin-bottom` for editButtons (EditPage) [core] - 10https://gerrit.wikimedia.org/r/399416 (https://phabricator.wikimedia.org/T179040) [15:30:35] (03CR) 10D3r1ck01: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399407 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:30:37] (03CR) 10D3r1ck01: "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399408 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:33:29] (03CR) 10D3r1ck01: "LGTM! Great work @Rafid." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399408 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:34:10] (03CR) 10D3r1ck01: [C: 031] "LGTM! Great work @Rafid :)" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399407 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:34:18] (03CR) 10D3r1ck01: [C: 031] Add minus-x to "composer test" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399408 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:35:13] (03CR) 10Nikerabbit: [V: 031 C: 032] Add tags for undo edits [core] - 10https://gerrit.wikimedia.org/r/395744 (https://phabricator.wikimedia.org/T167656) (owner: 10Petar.petkovic) [15:37:57] (03CR) 10Daniel Kinzler: "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/399188 (https://phabricator.wikimedia.org/T183242) (owner: 10Addshore) [15:41:45] (03PS1) 10Thiemo Kreuz (WMDE): Add type hints to all class properties of DPLArticle [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/399424 [15:43:17] (03CR) 10jerkins-bot: [V: 04-1] Add tags for undo edits [core] - 10https://gerrit.wikimedia.org/r/395744 (https://phabricator.wikimedia.org/T167656) (owner: 10Petar.petkovic) [15:43:20] Hii [15:43:39] I'm Siddarth form Chennai and I love racing [15:43:40] Sid46: Hi, Welcome :) [15:43:57] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851545 (10Gilles) [15:44:05] I'm undergoing a task given by google. [15:44:16] Sid46: Welcome! Good luck with your tasks! [15:44:43] Any1 in GCI? [15:44:53] several [15:44:58] Thanks Phantom42 [15:45:02] Oh [15:45:57] Who else is in Chennai? [15:47:18] <-- West Midlands, UK [15:47:21] not sure anyone else in here. it's a global channel. :) [15:47:32] Sid46: I don't know about Chennai, but I am pretty sure there were some gci students from India :) [15:48:04] 10OOjs-UI: MenuTagMultiselectWidget menu doesn't close properly when used with an overlay - https://phabricator.wikimedia.org/T183377#3851548 (10Anomie) [15:48:22] 10OOjs-UI: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu - https://phabricator.wikimedia.org/T183378#3851558 (10Anomie) [15:48:40] R U just a user of this Phantom42? [15:49:36] * andre__ kindly asks for proper spelling - Makes things a lot easier to read for everybody else. Thanks :) [15:49:37] (03CR) 10Daniel Kinzler: Update to extension.json (032 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 (owner: 10MarkAHershberger) [15:49:46] Sid46, what is "this" in your question? :) [15:50:05] Sid46: I am another gci participant :) If you have any questions, I will be always happy to help. [15:50:57] Andre "this" refers to the server [15:51:17] 10RemexHtml: RemexHTML crasher - https://phabricator.wikimedia.org/T183379#3851568 (10ssastry) [15:51:19] Wow Phantom,,,,thanks a lot [15:51:28] 10RemexHtml: RemexHTML crasher - https://phabricator.wikimedia.org/T183379#3851578 (10ssastry) p:05Triage>03High [15:51:30] Sid46: which server? You mean IRC? Or MediaWiki? [15:51:36] (03PS1) 10Anomie: Use new TagMultiselectWidget in ApiSandbox [core] - 10https://gerrit.wikimedia.org/r/399427 (https://phabricator.wikimedia.org/T183299) [15:51:49] I meant Wikimedia [15:52:21] Well, Wikimedia *runs* many servers... to host Wikipedia and stuff. [15:52:52] and if people were not interested in Wikimedia, they would not be in this IRC channel called #wikimedia-dev which is about Wikimedia development. [15:52:53] (03CR) 10Daniel Kinzler: [C: 032] Follow-up 36f4daf32c: allow no-write database connections to use transactions [core] - 10https://gerrit.wikimedia.org/r/399404 (https://phabricator.wikimedia.org/T183265) (owner: 10Catrope) [15:53:06] (03CR) 10Anomie: "Regressions from CapsuleMultiselectWidget's behavior have been filed as T183377 and T183378. It may be worth waiting on this until those a" [core] - 10https://gerrit.wikimedia.org/r/399427 (https://phabricator.wikimedia.org/T183299) (owner: 10Anomie) [15:54:02] (03PS1) 10Thiemo Kreuz (WMDE): Remove dead, unused debug code, forgotten variables and such [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/399428 [15:55:23] Hey dude, Andre ur the best 1 I have seen in questioning...admiring u [15:55:47] 10RemexHtml: RemexHTML crasher - https://phabricator.wikimedia.org/T183379#3851587 (10ssastry) [15:56:27] 10MediaWiki-Vagrant: Fix Eventlogging role for Stretch - https://phabricator.wikimedia.org/T183380#3851588 (10Gilles) p:05Triage>03Normal [15:56:49] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851600 (10Gilles) [15:58:13] Yes, Sid46, Andre is a good guy, one of our organisers and very helpful. You can learn a lot from him [15:58:26] Phantom42: BTW which task r u in? [15:59:27] (03CR) 10Thiemo Kreuz (WMDE): "With the responses the only issue that remains is the class name "Hook", which should be "Hooks"." (032 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398525 (owner: 10MarkAHershberger) [15:59:28] 10OOjs-UI: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu - https://phabricator.wikimedia.org/T183378#3851616 (10Anomie) These can be observed using ApiSandbox with https://gerrit.wikimedia.org/r/399427 **Clicking within the overlay does not make it disappear** * Ope... [15:59:54] Sid46: heh, thanks. :) Maybe I ask you for proper spelling of words, please? Makes things easier to read. Thanks! :P [16:00:18] Sid46: Well, right now I am fixing some issues with MediaWiki user interface. That's quite an interesting task like all other tasks here :) [16:00:27] 10GoogleLogin: Unable to Integrate Google Login Extension - https://phabricator.wikimedia.org/T183365#3851617 (10Florian) 05Open>03Invalid a:05Florian>03None Hi! Thanks for reporting this. However, this is not a bug, as it works like expected. As you haven't connected your Google-account with any local w... [16:00:29] 10Design, 10JADE, 10Scoring-platform-team: Design curation/suppression integration with MediaWiki (for JADE) - https://phabricator.wikimedia.org/T183276#3851622 (10awight) [16:00:36] 10Design, 10JADE, 10Scoring-platform-team: Design conceptual prototype of JADE integration with MediaWiki - https://phabricator.wikimedia.org/T182829#3851624 (10awight) [16:01:26] (03CR) 10Mooeypoo: "> Moriel suggested that this could/should be done by setting" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398891 (https://phabricator.wikimedia.org/T177455) (owner: 10Catrope) [16:01:53] 10MediaWiki-General-or-Unknown, 10OOjs-UI, 10Patch-For-Review: Replace and deprecate CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T183299#3851636 (10Anomie) In the course of updating ApiSandbox, I found two regressions. * {T183377} * {T183378} [16:02:16] (03Merged) 10jenkins-bot: Follow-up 36f4daf32c: allow no-write database connections to use transactions [core] - 10https://gerrit.wikimedia.org/r/399404 (https://phabricator.wikimedia.org/T183265) (owner: 10Catrope) [16:02:33] Intelligent guy ah Phantom42...😃 [16:03:13] It's my pleasure talking to u Andre [16:03:40] Sid46: Everybody does this sort of things here. Hope you join us too! It is interesting and fun! [16:04:01] andre__: But but, third parties! ;) [16:04:31] andre__: ok, will not use short form. [16:04:43] (03PS2) 10Thiemo Kreuz (WMDE): Remove repetitions of the extensions name from directories & classes [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399379 (https://phabricator.wikimedia.org/T183260) [16:05:17] How will I join? [16:05:23] bawolff: they really exist? :P [16:05:57] Sid46: working on development related tasks, for example. or anything that interests you. See https://www.mediawiki.org/wiki/How_to_contribute [16:06:58] (03CR) 10Thiemo Kreuz (WMDE): "I would appreciate a response." [core] - 10https://gerrit.wikimedia.org/r/395721 (owner: 10Thiemo Kreuz (WMDE)) [16:07:06] (03CR) 10jerkins-bot: [V: 04-1] Remove repetitions of the extensions name from directories & classes [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399379 (https://phabricator.wikimedia.org/T183260) (owner: 10Thiemo Kreuz (WMDE)) [16:08:07] Oh, any special software required? [16:08:19] Phantom42? [16:08:25] Sid46: software for what? [16:08:41] Developing [16:09:01] depends on what you want to do [16:09:07] Oh [16:09:08] Sid46: not really. Again, depends which project you want to develop on. See https://www.mediawiki.org/wiki/New_Developers [16:09:10] but generally speaking, git, mediawiki, a web server [16:09:12] php [16:09:40] Thanks for this informationgu [16:09:48] *sorry [16:09:56] Thanks for this information guys [16:10:39] Sorry, I have another doubt. Can I proceed?1 [16:11:38] (03CR) 10Krinkle: "@Nike I'm removing them because the use of short headers is inconsistent with the majority of other test files. Whether it matches the SPD" [core] - 10https://gerrit.wikimedia.org/r/395074 (owner: 10Krinkle) [16:11:42] Sid46: Right now you need to wait a bit less than 1 hour so your IRC task could be marked as complete. After that you could claim your next task [16:11:46] (03CR) 10jenkins-bot: Follow-up 36f4daf32c: allow no-write database connections to use transactions [core] - 10https://gerrit.wikimedia.org/r/399404 (https://phabricator.wikimedia.org/T183265) (owner: 10Catrope) [16:12:02] Yes , I'm waiting for that [16:12:13] BTW how do u know that [16:12:16] ? [16:12:30] GCI taska are public. [16:12:32] What exactly? [16:12:33] err *tasks [16:12:37] Oh [16:13:09] The server will be online even if I go out right? [16:13:53] In IRC you stop getting messages when you go offline. [16:14:52] I'm asking will the time count when I lock the screen? [16:15:04] Without coming back [16:15:44] Sid46: You are connected using your phone? I think you will possibly get disconnected, depending on your client [16:16:02] (03PS1) 10Gilles: Fix Eventlogging role for Stretch [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/399432 (https://phabricator.wikimedia.org/T183380) [16:16:03] I think the idea is that spend about an hour looking at what happens on IRC [16:16:31] it's long enough to give you a chance to meet people nad see the conversations [16:16:55] Can you reply fast phantom42 ples [16:17:00] *please [16:17:04] but if your phone disconnects while you eat, etc. I'm sure you can just re-join [16:17:31] (03CR) 10Krinkle: [C: 032] objectcache: add another example case to WANObjectCache::getWithSetCallback() [core] - 10https://gerrit.wikimedia.org/r/395690 (owner: 10Aaron Schulz) [16:18:09] Rejoining is not a problem [16:18:18] RexxS is right. The point of this task is to meet mediawiki community :) [16:18:27] The time is 9:48pm [16:18:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Split RatingDataClass.php into two files [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/398632 (owner: 10Umherirrender) [16:18:48] My task gets over at 10:42pm [16:19:07] Have to wait till 10:16pm [16:19:17] That's the problem [16:19:31] I'm assuming you're Siddarth .S [16:19:41] https://codein.withgoogle.com/dashboard/task-instances/5920122839498752/ [16:20:01] Andre has asked to stay on for an hour [16:20:33] but if he knew you were connected by phone, I'm sure he wouldn't worry if you disconnect and re-connect [16:20:45] just spend a total time of an hour [16:22:14] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851664 (10Gilles) [16:22:46] d3rick: you're a mentor for "Get onto Internet Relay Chat (IRC)" [16:22:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Provide an appropriate comment [core] - 10https://gerrit.wikimedia.org/r/399232 (owner: 10VolkerE) [16:23:29] can you re-assure Sid46 that he won't be penalised if his phone disconnects and he has to re-connect? [16:23:54] RexxS: :D, Okay! [16:24:01] thank you [16:24:14] better than having him get anxious about it [16:24:18] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851670 (10Gilles) [16:24:37] Sid46: If your phone disconnects, and you rejoin, it's totally okay! [16:24:42] Sid46 - is that any better now? [16:24:54] 10MediaWiki-extensions-GoogleNewsSitemap, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Empty Special:Newsfeed on many wikinews - https://phabricator.wikimedia.org/T172875#3851672 (10Bawolff) >>! In T172875#3851665, @gerritbot wrote: > Change 399433 had a related patch set uploaded (by Brian Wolff; own... [16:25:05] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix tests [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/398799 (owner: 10Fomafix) [16:25:22] Sid46: When you get to 1 hour, just submit the task and it will be kindly reviewed by the mentors :) [16:25:54] RexxS: And he quits :D [16:26:01] Well, hoping he rejoins ASAP [16:26:15] I think his phone disconnects after a certain time [16:26:43] we can't assume everybody has the same 24/7 access that we do, I guess :( [16:26:44] RexxS: Hmmm... not a problem! I'll be waiting him/her (not sure about gender) [16:26:55] RexxS: We can't assume that! [16:27:08] Sometimes, Freenode can also mess us up! [16:27:32] indeed - thanks for your help d3r1ck [16:27:51] RexxS: You're very much welcome! Anytime Sir! [16:28:10] (03CR) 10Krinkle: [C: 04-1] "Per previous CR. The naming convention ".init" is indicative of the light bootstrap module, not the other way around. If the old name is p" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/384600 (https://phabricator.wikimedia.org/T176211) (owner: 10Jdlrobson) [16:28:48] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851677 (10Gilles) [16:29:33] RexxS: When did Sid46 join #wikimedia-dev? Can you fetch me the time please? [16:29:42] (03Merged) 10jenkins-bot: objectcache: add another example case to WANObjectCache::getWithSetCallback() [core] - 10https://gerrit.wikimedia.org/r/395690 (owner: 10Aaron Schulz) [16:30:17] 10MediaWiki-extensions-GoogleNewsSitemap, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Empty Special:Newsfeed on many wikinews - https://phabricator.wikimedia.org/T172875#3851678 (10Bawolff) If anyone wants to test, is what this change does is change the default for the categories parameter. So after... [16:30:43] 15:35 on my time [16:31:04] he left at 16:25 my time [16:31:29] Just 10mins left for him to get to 1 hour [16:31:39] Volker_E: Hi! Are you here and have some free time to discuss something? [16:31:43] (03CR) 10Krinkle: Introduce MultiGadgetRepo to help with migration (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/389793 (owner: 10Legoktm) [16:31:47] Are we really going to be that picky about the time on irc? [16:31:58] bawolff: Nope! [16:32:11] 10MediaWiki-Vagrant: Fix Poolcounter role for Stretch - https://phabricator.wikimedia.org/T183384#3851680 (10Gilles) p:05Triage>03Normal [16:32:22] (03CR) 10Krinkle: "@Legoktm Yeah, I think that would help. I'm not seeing exactly how we'd use the two repos mentioned in the commit-msg at the same time, fo" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/389793 (owner: 10Legoktm) [16:32:40] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3851692 (10Gilles) [16:32:43] bawolff: If he submits, we'll approve. Cc andre__ :) [16:32:52] d3r1ck, depends on the IRC client used. [16:33:00] andre__: True! :) [16:33:03] a /CTCP did not give me any info, though. [16:33:37] andre__: He's no longer here. He left! [16:33:38] You can usually tell by the ident if ctcp doesnt work [16:33:41] are there any non-proprietary clients for Android? [16:33:51] RexxS: irccloud [16:33:56] RexxS: I know of JuiceSSH [16:34:04] He's using AndroIRC [16:34:08] RexxS: AndroIRC, which Sid46 used [16:34:14] lol [16:34:15] even this time? [16:34:23] Sid46 ~holoirc 2405:204:714d:5715:b4:2318:e2f:63a1 * HoloIRCUser [16:34:23] ah - good point [16:34:56] nice. [16:35:06] https://github.com/tilal6991/HoloIRC [16:35:14] well done Sid [16:35:55] :) [16:36:12] 10MediaWiki-extensions-WikipediaExtracts: WikipediaExtracts code review - https://phabricator.wikimedia.org/T149766#3851709 (10Reedy) ```lang=php /** * Get a span with a link to Wikipedia */ private static function getCredits() { $title = Title::newFromText( self::$wikipediaTitle ); $url = 'https://' .... [16:38:06] He claimed the task on 17 December - did anybody give him a time extension? [16:38:07] (03Merged) 10jenkins-bot: Provide an appropriate comment [core] - 10https://gerrit.wikimedia.org/r/399232 (owner: 10VolkerE) [16:38:09] (03Merged) 10jenkins-bot: Fix tests [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/398799 (owner: 10Fomafix) [16:38:11] (03Merged) 10jenkins-bot: Use jQuery for restoring the shuffled question numbers [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/371979 (owner: 10Tacsipacsi) [16:39:29] RexxS: Nope from my end! [16:39:40] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3851727 (10Halfak) [16:40:01] hmmz [16:40:44] it would be a pity if after all that effort, he ran out of time just before completing his first trask [16:41:47] I've extended his deadline by a day - I hope nobody objects [16:43:52] sure, thanks! [16:43:53] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3851730 (10Halfak) [16:45:55] 10RemexHtml: RemexHTML crasher - https://phabricator.wikimedia.org/T183379#3851731 (10ssastry) https://logstash.wikimedia.org/goto/d34dc5529f03feea26b0d80d8e68e2d0 is the logstash dashboard snapshot for last 30 days .. it looks like all the crasher instances are from last 24 hours and primarily from sandbox test... [16:47:41] RexxS: Ohh, thank :) [16:48:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3851734 (10Mbch331) a:03Mbch331 I'll make one [16:52:53] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Design (RW-Design-Debt), 10Epic: [Epic] Improve special page template - https://phabricator.wikimedia.org/T169162#3851736 (10Nirzar) >NOTE: This doesn't account for the two "views" of the Watchlist. Please update screenshot/provide a mock. the two views are... [16:53:55] (03CR) 10jenkins-bot: objectcache: add another example case to WANObjectCache::getWithSetCallback() [core] - 10https://gerrit.wikimedia.org/r/395690 (owner: 10Aaron Schulz) [16:54:03] (03CR) 10Florianschmidtwelzow: [C: 032] Add minus-x to "composer test" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399408 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [16:54:12] (03CR) 10Florianschmidtwelzow: [C: 032] Add minus-x to "composer test" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399407 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [16:55:08] 04(no projects): Cite tags should not appear in the article contents - https://phabricator.wikimedia.org/T183387#3851738 (10Daylen) [16:55:39] (03Merged) 10jenkins-bot: Add minus-x to "composer test" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/399408 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [16:56:50] (03Merged) 10jenkins-bot: Add minus-x to "composer test" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399407 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [16:58:30] (03CR) 10Florianschmidtwelzow: "@Pppery: Sorry for the confusion :) I mean, if tony comes to the conclusion, too, that a separate query to get the issue count for each ro" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [17:04:20] (03CR) 10jenkins-bot: Provide an appropriate comment [core] - 10https://gerrit.wikimedia.org/r/399232 (owner: 10VolkerE) [17:04:27] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3851752 (10BukhariSaeed) [17:12:21] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3851800 (10Hanna_Petruschat_WMDE) @tmletzko Could you give me some feedback on this? If you do it until tomorrow I could prepare the specs (colors,... [17:14:59] (03CR) 10Chad: [C: 032] Move maintenance script to own folder [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/398617 (owner: 10Umherirrender) [17:15:33] (03CR) 10Brian Wolff: "So doing a count(*) query on each row of the newsletter table is definitely unideal. The number of rows looked at would be the number of i" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [17:15:45] (03CR) 10Chad: [C: 032] Use dedicated functions for i18n [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/394032 (owner: 10Seb35) [17:16:12] (03CR) 10Reedy: "It is" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/398617 (owner: 10Umherirrender) [17:16:47] (03Merged) 10jenkins-bot: Move maintenance script to own folder [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/398617 (owner: 10Umherirrender) [17:16:52] (03CR) 10Brian Wolff: "Addendum: Probably the proper way of doing this is storing a pre-computed count in the newsletter table so we don't have to count everythi" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [17:17:28] (03Merged) 10jenkins-bot: Use dedicated functions for i18n [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/394032 (owner: 10Seb35) [17:18:17] (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/399434 for WMF prod to be merged at a later date so we can remove the old file too..." [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/398617 (owner: 10Umherirrender) [17:22:10] 04(no projects): Inappropriate ordering of list=alldeletedrevisions results - https://phabricator.wikimedia.org/T183391#3851809 (10Lahwaacz) [17:22:25] 10MediaWiki-API: Inappropriate ordering of list=alldeletedrevisions results - https://phabricator.wikimedia.org/T183391#3851818 (10Lahwaacz) [17:25:48] 10Marvin: Add postcss with autoprefixer for CSS styles - https://phabricator.wikimedia.org/T177012#3851822 (10Niedzielski) a:03Niedzielski [17:25:57] (03PS1) 10Niedzielski: Chore: add postcss with autoprefixer [marvin] - 10https://gerrit.wikimedia.org/r/399436 (https://phabricator.wikimedia.org/T177012) [17:30:10] 10Marvin: Add support for page transitions - https://phabricator.wikimedia.org/T179489#3851844 (10Niedzielski) [17:32:14] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3851846 (10BukhariSaeed) {F11955401} One more example see "بھارتی" is not correct [17:35:56] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3851852 (10tmletzko) I like it. if @kai.nissen does not find any concerning issues you can provide the specs. But I doubt that we will change colour... [17:36:32] 10Marvin, 10Epic, 10Patch-For-Review: Initial version of article rendering - https://phabricator.wikimedia.org/T173317#3851854 (10Niedzielski) @Jhernandez, let's close this epic once all the open patches are merged. T177681 is important but stalled on PCS changes. This epic isn't adding a lot of value in its... [17:38:10] 10Community-Liaisons (Oct-Dec 2017): Evaluations of CLs tasks by PMs, Q2 - https://phabricator.wikimedia.org/T182662#3851860 (10Abit) {{done}}! [17:38:33] 04(no projects): Correct the wikidata label for mobile site - https://phabricator.wikimedia.org/T183388#3851862 (10Aklapper) 05Open>03stalled Please always provide 1) clear steps to reproduce, 2) what you expected as text, 3) what actually happens as text. See and follow https://mediawiki.org/wiki/How_to_re... [17:42:07] 10Community-Liaisons (Oct-Dec 2017): Evaluations of CLs tasks by PMs, Q2 - https://phabricator.wikimedia.org/T182662#3851872 (10Elitre) Confetti time! [17:42:28] 10Community-Liaisons (Oct-Dec 2017): Evaluations of CLs tasks by PMs, Q2 - https://phabricator.wikimedia.org/T182662#3851873 (10Elitre) 05Open>03Resolved [17:43:22] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪): Add new Settings option to allow reading list sync - https://phabricator.wikimedia.org/T167182#3851878 (10RHo) [17:43:24] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Clear reading lists from the server if an existing reading list user opts out of reading list sync - https://phabricator.wikimedia.org/T167311#3851875 (10RHo) 05Resolved>03Op... [17:45:49] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Add new Settings option to allow reading list sync - https://phabricator.wikimedia.org/T167182#3851884 (10RHo) [17:46:16] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Add new Settings option to allow reading list sync - https://phabricator.wikimedia.org/T167182#3320013 (10RHo) Re-opened for QA testing on new service [17:47:29] (03CR) 10Chad: [C: 032] Help icon is a bit weirdly aligned [skins/Timeless] - 10https://gerrit.wikimedia.org/r/394132 (https://phabricator.wikimedia.org/T173186) (owner: 10Framawiki) [17:49:00] (03Merged) 10jenkins-bot: Help icon is a bit weirdly aligned [skins/Timeless] - 10https://gerrit.wikimedia.org/r/394132 (https://phabricator.wikimedia.org/T173186) (owner: 10Framawiki) [17:49:16] (03CR) 10Krinkle: [C: 04-1] "From first glance, I would expect this to significantly regress user experience in the following ways:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/381409 (https://phabricator.wikimedia.org/T24986) (owner: 10Rammanojpotla) [17:49:56] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Add new Settings option to allow reading list sync - https://phabricator.wikimedia.org/T167182#3851894 (10RHo) Derp, sorry this task is superseded by T167182. [17:53:42] (03CR) 10Florianschmidtwelzow: "> Addendum: Probably the proper way of doing this is storing a pre-computed count in the newsletter table so we don't have to count everyt" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [17:53:44] (03CR) 10Aklapper: [C: 031] ""as the styling of tt is different depending on Browser and OS afaik":" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:57:08] bawolff: regarding https://gerrit.wikimedia.org/r/#/c/399096/4: Do you know of any other way of doing it? Having a pre-computed value might be the solution with the best performance, but feels a bit weird. Are there any other parts of MediaWiki which do the same logic (counting values in another table to output it combined with other data), which you know? [17:57:11] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Show a reading list sync opt-in prompt to users upon log in - https://phabricator.wikimedia.org/T180220#3851925 (10RHo) [17:57:34] The category table would be the closest analog [17:57:37] (03CR) 10Mooeypoo: [C: 032] "This solves the issue, but we should submit a task to clean this up a bit, and to not forget to implement a {{bidi:}} support in JS." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398891 (https://phabricator.wikimedia.org/T177455) (owner: 10Catrope) [17:57:49] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3851929 (10kai.nissen) Looks pretty straight forward to me. No concerns from my side. [17:57:52] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Special:Newsletters should have a help link to Help:Extension:Newsletter - https://phabricator.wikimedia.org/T180980#3851930 (10Florian) 05Open>03Resolved [17:59:19] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Opening - https://phabricator.wikimedia.org/T183393#3851935 (10debt) p:05Triage>03Normal [17:59:31] (03CR) 10Chad: [C: 032] "Tbh my comment inline was just nitpicking, this is fine." [core] - 10https://gerrit.wikimedia.org/r/397606 (owner: 10Legoktm) [18:00:06] (03CR) 10Chad: [C: 032] Add REL1_27 submodules for bundled extensions/skins/vendor [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/399102 (owner: 10Chad) [18:00:15] 10MediaWiki-extensions-GoogleNewsSitemap, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Empty Special:Newsfeed on many wikinews - https://phabricator.wikimedia.org/T172875#3851947 (10Bawolff) 05Open>03Resolved a:03Bawolff > Note, that we are currently in a deployment freeze, so this cannot be dep... [18:00:42] hmm, difficult :/ [18:00:50] yeah [18:00:51] 10Epic, 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T183394#3851951 (10debt) p:05Triage>03Normal [18:01:09] And you also have to be careful to make sure everything stays consistent [18:01:26] yes, that's my concern with a separate column, too. [18:01:31] Doing all the count(*)'s for each newsletter seems like something dba's won't like [18:01:51] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Update FAQs with new reading list sync capability - https://phabricator.wikimedia.org/T165049#3851966 (10RHo) [18:01:54] I agree [18:02:00] I guess that would be up to jynus [18:02:01] 10Epic, 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 - https://phabricator.wikimedia.org/T183394#3851967 (10debt) [18:03:23] I probably add him to the task explaining what we want to achieve, what the current two solution ideas are and if he has ideas how we can improve that :) [18:03:28] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Opening - https://phabricator.wikimedia.org/T183393#3851969 (10debt) [18:03:30] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Research, Analytics, and Machine Learning - https://phabricator.wikimedia.org/T183320#3851970 (10debt) [18:03:30] thanks for your input bawolff!!! [18:03:32] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Embracing Open Source Software - https://phabricator.wikimedia.org/T183319#3851971 (10debt) [18:03:34] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Growing the MediaWiki Technical Community - https://phabricator.wikimedia.org/T183318#3851972 (10debt) [18:03:39] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Advancing the Contributor Experience - https://phabricator.wikimedia.org/T183317#3851973 (10debt) [18:03:39] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Next Steps for Languages and Cross Project Collaboration - https://phabricator.wikimedia.org/T183314#3851975 (10debt) [18:03:40] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Evolving the MediaWiki Architecture - https://phabricator.wikimedia.org/T183313#3851976 (10debt) [18:03:42] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Knowledge as a Service - https://phabricator.wikimedia.org/T183315#3851974 (10debt) [18:03:44] 10Epic, 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 - https://phabricator.wikimedia.org/T183394#3851951 (10debt) [18:03:46] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Topic: Supporting Third-Party Use of MediaWiki - https://phabricator.wikimedia.org/T183312#3851977 (10debt) [18:03:48] 10Wikimedia-Developer-Summit, 10Developer-Relations (Oct-Dec 2017): Wikimedia Developer Summit 2018 Strawman - https://phabricator.wikimedia.org/T173550#3851978 (10debt) [18:03:50] 10Wikimedia-Developer-Summit, 10Developer-Relations (Oct-Dec 2017), 10Goal: Logistics plan for the Wikimedia Developer Summit 2018 - https://phabricator.wikimedia.org/T170227#3851979 (10debt) [18:04:02] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Replace settings checkboxes to ToggleSwitches - https://phabricator.wikimedia.org/T169807#3851980 (10pmiazga) a:05pmiazga>03Nirzar [18:05:50] 10Wikimedia-Developer-Summit (2018): Wikimedia Developer Summit 2018 Closing - https://phabricator.wikimedia.org/T183395#3851983 (10debt) p:05Triage>03Normal [18:05:59] (03CR) 10Fomafix: "Another solution is to rename 'en' to 'en-us' and make 'en' to a fallback to 'en-us'. Other languages especially languages with different " [core] - 10https://gerrit.wikimedia.org/r/399341 (https://phabricator.wikimedia.org/T183295) (owner: 10Fomafix) [18:06:08] (03Merged) 10jenkins-bot: Fix various bugs with timestamps in mixed directionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398891 (https://phabricator.wikimedia.org/T177455) (owner: 10Catrope) [18:06:17] 10Wikimedia-Developer-Summit, 10Developer-Relations (Oct-Dec 2017): Wikimedia Developer Summit 2018 Strawman - https://phabricator.wikimedia.org/T173550#3851996 (10debt) [18:06:20] 10Wikimania-Hackathon-2017, 10Developer-Relations (Jul-Sep 2017): Creation of a Program Committee for Wikimedia developer events (a Wikimania Hackathon session) - https://phabricator.wikimedia.org/T160996#3851995 (10debt) [18:06:22] 10Wikimedia-Site-requests: Enable create a Secure poll in Arwiki - https://phabricator.wikimedia.org/T183358#3851997 (10alanajjar) [18:08:21] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3851998 (10phuedx) a:03phuedx [18:08:30] (03CR) 10jenkins-bot: Fix various bugs with timestamps in mixed directionality [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398891 (https://phabricator.wikimedia.org/T177455) (owner: 10Catrope) [18:09:21] (03CR) 10jerkins-bot: [V: 04-1] Add REL1_27 submodules for bundled extensions/skins/vendor [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/399102 (owner: 10Chad) [18:09:22] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Promote expand all sections feature from beta (in feature branch) - https://phabricator.wikimedia.org/T169257#3851999 (10pmiazga) a:03Nirzar [18:09:30] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Promote fontchanger to stable (in feature branch) - https://phabricator.wikimedia.org/T109364#3852000 (10pmiazga) a:03Nirzar [18:09:56] 10Wikimedia-Developer-Summit (2018): WikiDev'17 Keynote by Adam Cheyer - https://phabricator.wikimedia.org/T183396#3852001 (10debt) p:05Triage>03Normal [18:10:23] 10Wikimedia-Developer-Summit (2018): WikiDev'17 Keynote by Londa Schiebinger - https://phabricator.wikimedia.org/T183397#3852011 (10debt) p:05Triage>03Normal [18:10:35] 10Wikimedia-Developer-Summit (2018): WikiDev'18 Keynote by Londa Schiebinger - https://phabricator.wikimedia.org/T183397#3852011 (10debt) [18:10:37] 10MediaWiki-API: list=alldeletedrevisions returns pageid=0 instead of ar_page_id - https://phabricator.wikimedia.org/T183398#3852022 (10Lahwaacz) [18:10:49] 10Wikimedia-Developer-Summit (2018): WikiDev'18 Keynote by Adam Cheyer - https://phabricator.wikimedia.org/T183396#3852001 (10debt) [18:11:19] 10Wikimedia-Developer-Summit (2018): WikiDev'18 Keynote by Dan McKinley - https://phabricator.wikimedia.org/T183399#3852033 (10debt) p:05Triage>03Normal [18:11:53] 10Wikimedia-Developer-Summit (2018): WikiDev'18 Keynote by Melanie Goetz - https://phabricator.wikimedia.org/T183400#3852043 (10debt) p:05Triage>03Normal [18:12:24] (03PS1) 10Petar.petkovic: Fix old style filters disappearing regression [core] - 10https://gerrit.wikimedia.org/r/399440 [18:13:49] (03CR) 10Reedy: "So @MaxSem what do you think we need to do here?" [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/381911 (owner: 10Reedy) [18:15:56] 10MediaWiki-Internationalization, 10I18n: Implement mw.language.embedBidi() in JS - https://phabricator.wikimedia.org/T183402#3852069 (10Catrope) [18:16:03] (03CR) 10Catrope: "https://phabricator.wikimedia.org/T183402" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398891 (https://phabricator.wikimedia.org/T177455) (owner: 10Catrope) [18:19:01] 10MediaWiki-extensions-Newsletter, 10DBA, 10Google-Code-in-2017, 10Patch-For-Review, 10Performance: List of Newsletters should have a column showing the number of issues - https://phabricator.wikimedia.org/T180979#3852097 (10Florian) Ok, during implementation and after chatting to @Bawolff about that, we... [18:27:13] 10OOjs-UI, 10Patch-For-Review: Release OOUI v0.24.4 with some backported patches - https://phabricator.wikimedia.org/T183195#3852116 (10matmarex) [18:30:03] 10Epic, 10iOS-app-v5.8.0-Manatee-On-A-Skateboard: [Epic] As a user of 'Save for later' I would like a way to create multiple reading lists and sync them across my devices - https://phabricator.wikimedia.org/T176357#3852120 (10RHo) @JMinor @cmadeo - should the following comment in the task description be update... [18:31:23] 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Infrastructure-Team-Backlog: Reference anchor and target IDs use inconsistent percent encoding - https://phabricator.wikimedia.org/T183049#3852125 (10Fjalapeno) [18:33:30] (03PS1) 10Daniel Kinzler: [WIP] Prevent writes on connections obtained with DB_REPLICA. [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) [18:35:43] 10MediaWiki-API: Will adrcontentformat be deprecated? - https://phabricator.wikimedia.org/T183405#3852131 (10Lahwaacz) [18:38:21] (03PS1) 10Daniel Kinzler: Set CONN_NO_WRITE on all relevant code pathes in LoadBalancer. [core] - 10https://gerrit.wikimedia.org/r/399447 (https://phabricator.wikimedia.org/T183265) [18:39:50] 10Wikipedia-Android-App-Backlog, 10Epic, 10Reading Epics (Synchronized Reading Lists): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3852143 (10RHo) [18:41:19] (03PS2) 10Daniel Kinzler: [WIP] Prevent writes on connections obtained with DB_REPLICA. [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) [18:41:24] well, Krinkle, I just got minikube working locally :) [18:41:39] (03PS2) 10Chad: Add REL1_27 submodules for bundled extensions/skins/vendor [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/399102 [18:48:37] 10MediaWiki-extensions-LoginNotify, 10Community-Tech-Sprint: Investigation: LoginNotify false positives on dewiki - https://phabricator.wikimedia.org/T178619#3852168 (10kaldari) @Niharika: You say that the attempt is considered to be from a known device if "There is CheckUser data". I'm assuming you mean there... [18:48:41] Hello everyone :) [18:48:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Prevent writes on connections obtained with DB_REPLICA. [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [18:49:17] divadsn: Hello! [18:50:07] Hi [18:50:50] (03CR) 10Divadsn: "> If we used the usual error class, I wonder how to add line breaks to that output." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [18:51:14] Phantom42, Zppix hi :D [18:51:29] everything fine? :) [18:52:28] Yep [18:57:22] (03CR) 10Nikerabbit: [C: 04-2] "That's just slightly modified initial solution. What I was thinking of conditional (I don't know exactly what it would be) stripping of co" [core] - 10https://gerrit.wikimedia.org/r/399341 (https://phabricator.wikimedia.org/T183295) (owner: 10Fomafix) [19:01:59] (03CR) 10Sbisson: [C: 032] RCFilters: Don't load JS or redirect when transcluding [core] - 10https://gerrit.wikimedia.org/r/398206 (https://phabricator.wikimedia.org/T181032) (owner: 10Catrope) [19:04:57] (03PS1) 10DCausse: [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) [19:08:04] (03Merged) 10jenkins-bot: RCFilters: Don't load JS or redirect when transcluding [core] - 10https://gerrit.wikimedia.org/r/398206 (https://phabricator.wikimedia.org/T181032) (owner: 10Catrope) [19:08:52] 10Wiki-Loves-Monuments (2017): notify winners of Wiki Loves Monuments 2017 - https://phabricator.wikimedia.org/T182919#3838744 (10LilyOfTheWest) @Nevborg I think this task is about the official confirmation of the winners rank and prize. Can you get started on this? We need to send out the confirmation notificat... [19:09:17] Hello! [19:09:39] 10Wiki-Loves-Monuments (2017): Prepare the jury report - https://phabricator.wikimedia.org/T182281#3852224 (10LilyOfTheWest) [19:10:11] Albert221: Hello! [19:10:17] 10MediaWiki-extensions-OATHAuth: Special:OATH should go to 2FA setup, not just disable - https://phabricator.wikimedia.org/T172079#3852226 (10Reedy) >>! In T172079#3779576, @Tgr wrote: > The point is, how the secret is stored and whether you display it to the user are two entirely unrelated things. We do seem to... [19:11:26] Hello, my name is Sree, I have joined as part of the Google Code In program and this was one of the tasks. [19:11:54] GCISREE: Welcome! Good luck with GCI tasks! [19:12:00] welcome, Sree! [19:12:08] Albert221, you ready for The Lounge? :D [19:12:30] GCISREE haaai, have fun :) [19:12:36] Thank you! :) [19:12:36] 10Wiki-Loves-Monuments (2017): Prepare the jury report - https://phabricator.wikimedia.org/T182281#3852228 (10LilyOfTheWest) @Nevborg @Effeietsanders Let's aim to have this report out in the first two weeks of January. For this, we need to have the text ready. We've got a recommendation for a designer who will h... [19:12:39] hi GCISREE! [19:12:47] 10Wiki-Loves-Monuments (2017): Prepare the jury report - https://phabricator.wikimedia.org/T182281#3852229 (10LilyOfTheWest) [19:12:50] Hi Albert221 :D [19:14:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Profile management [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [19:15:59] This is actually fascinating, I've never seen this before. [19:16:52] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399451 (https://phabricator.wikimedia.org/T183279) (owner: 10DCausse) [19:20:06] (03CR) 10jenkins-bot: RCFilters: Don't load JS or redirect when transcluding [core] - 10https://gerrit.wikimedia.org/r/398206 (https://phabricator.wikimedia.org/T181032) (owner: 10Catrope) [19:20:09] 10OOjs-UI, 10Patch-For-Review: Release OOUI v0.24.4 with some backported patches - https://phabricator.wikimedia.org/T183195#3852235 (10matmarex) [19:23:52] 10Timeless, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Help icon is a bit weirdly aligned in Timeless - https://phabricator.wikimedia.org/T173186#3852238 (10Framawiki) 05Open>03Resolved [19:23:54] (03PS3) 10Sbisson: Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [19:25:32] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3852240 (10pmiazga) ###TL;DR; Service is performant and stable enough to be put on production. The most performant settings are to set up... [19:25:46] 10Discovery, 10Discovery-Analysis (Current work): Search Relevance Survey test #3: analysis of test - https://phabricator.wikimedia.org/T175048#3852241 (10mpopov) >>! In T175048#3851422, @TJones wrote: > Thanks! I'm not sure what I was expecting, but it is interesting to see. It seems to like giving scores of... [19:28:20] 10Epic, 10iOS-app-v5.8.0-Manatee-On-A-Skateboard: [Epic] As a user of 'Save for later' I would like a way to create multiple reading lists and sync them across my devices - https://phabricator.wikimedia.org/T176357#3852243 (10cmadeo) @Rho, not sure about the higher value, but I believe we'll be supporting spit... [19:30:45] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3852245 (10pmiazga) a:05pmiazga>03None [19:32:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10Patch-For-Review: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3852247 (10Lydia_Pintscher) Thank you! [19:33:00] (03CR) 10MaxSem: "Dunno, for a first version it's probably OK." [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/381911 (owner: 10Reedy) [19:33:14] 10Discovery, 10Discovery-Analysis (Current work): Search Relevance Survey test #3: analysis of test - https://phabricator.wikimedia.org/T175048#3852259 (10TJones) Nice! That is not a perfectly straight line, but it is remarkably good considering the mess that was the original input. [19:33:17] Reedy: want me to merge ^ ? [19:34:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10Patch-For-Review: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3852271 (10VIGNERON) Yes, thank you a lot! [19:37:54] 10MediaWiki-API: Use list=blocks to return all single IP blocks in a CIDR - https://phabricator.wikimedia.org/T183300#3852281 (10Samtar) @Anomie agreed :-) [19:38:31] (03PS1) 10Cicalese: Adds "json xssi prefix length" parameter [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/399456 [19:39:50] 10Gadgets: Provide server-side registration for Gadgets to add tabs to skin output without flash of content - https://phabricator.wikimedia.org/T158597#3041484 (10TheDJ) Note that we now have [[ https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#Gadget_peers | gadget peers ]], that commons mai... [19:39:58] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Update messaging to clarify sync behavior is per account level - https://phabricator.wikimedia.org/T177516#3852285 (10cooltey) a:03cooltey [19:42:22] 10UI-Standardization, 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Adjust the personal header to align with the design styleguide - https://phabricator.wikimedia.org/T160918#3852287 (10Petar.petkovic) >>! In T160918#3851535, @Pginer-WMF wrote: > For anonymous users we want to communic... [19:47:58] 10UI-Standardization, 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Adjust the personal header to align with the design styleguide - https://phabricator.wikimedia.org/T160918#3852314 (10Petar.petkovic) >>! In T160918#3851535, @Pginer-WMF wrote: > Use a distinctive icon for anonymous us... [19:50:12] (03CR) 10SamanthaNguyen: [C: 032] Split RatingDataClass.php into two files [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/398632 (owner: 10Umherirrender) [19:50:17] (03PS1) 10Rudloff: Get getContributorsData() instead of getContributorsNames() in getSimpleList [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/399457 [19:50:27] 10MediaWiki-extensions-TranslationNotifications, 10Collaboration-Team-Triage, 10Notifications: Deliver notification using Echo where available - https://phabricator.wikimedia.org/T48310#3852317 (10matej_suchanek) [19:50:30] 10MediaWiki-extensions-TranslationNotifications, 10Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects: Investigate if it is possible to send translation notifications via Echo - https://phabricator.wikimedia.org/T181139#3852316 (10matej_suchanek) [19:51:56] (03Merged) 10jenkins-bot: Split RatingDataClass.php into two files [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/398632 (owner: 10Umherirrender) [19:53:37] (03PS2) 10Rudloff: Get getContributorsData() instead of getContributorsNames() in getSimpleList [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/399457 (https://phabricator.wikimedia.org/T183369) [19:55:39] 10MediaWiki-extensions-Contributors: Contributors extension can't find articles - https://phabricator.wikimedia.org/T183369#3852331 (10Rudloff) I published a patch here: https://gerrit.wikimedia.org/r/#/c/399457/ [19:58:55] (03CR) 10MarkAHershberger: "I just copied the bootstrap line from mw-cs's README. The commit that introduced it to the README seems to explain why: I2f492f889594135e" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [20:02:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "From what I understand this line is not meant to be repeated in every single .phpcs.xml file, in every extension." [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [20:02:50] (03PS4) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [20:03:31] (03CR) 10MarkAHershberger: "sorted the exclude lines for you :)" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [20:04:41] (03CR) 10Fomafix: "An only ULS oriented solution is a local mapping in ULS or in /language/" [core] - 10https://gerrit.wikimedia.org/r/399341 (https://phabricator.wikimedia.org/T183295) (owner: 10Fomafix) [20:06:57] (03CR) 10Charitwo: [C: 031] "Verified works and fixes the error mentioned in T183323" [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/399412 (https://phabricator.wikimedia.org/T183323) (owner: 10Thiemo Kreuz (WMDE)) [20:09:50] (03Abandoned) 10Framawiki: Don't create a new paragraph for each new lines of $reason in GlobalRename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/359006 (owner: 10Framawiki) [20:13:42] (03CR) 10Chad: [C: 032] Add REL1_27 submodules for bundled extensions/skins/vendor [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/399102 (owner: 10Chad) [20:16:27] (03PS1) 10MaxSem: Add UniversalLanguageSelector support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) [20:16:39] (03CR) 10jerkins-bot: [V: 04-1] Add UniversalLanguageSelector support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) (owner: 10MaxSem) [20:17:02] 04(no projects): 천호동출장안마【콜걸vip】 { 010n5906v1745 } 천호동출장맛사지 천호동출장좋은곳 천호동콜걸출장마사지 천호동안마 천호동출장문의 천호동최저가출장 천호동출장전문 - https://phabricator.wikimedia.org/T183416#3852385 (10Jyk1122) [20:20:17] 04(no projects): 방이동출장안마【콜걸vip】 { 010n5906v1745 } 방이동출장맛사지 방이동출장좋은곳 방이동콜걸출장마사지 방이동안마 방이동출장문의 방이동최저가출장 방이동출장전문 - https://phabricator.wikimedia.org/T183417#3852402 (10Jyk1122) [20:20:32] 10MediaWiki-General-or-Unknown, 10RfC, 10TechCom-RfC (ArchCom-Approved): Require either PHP 7.0+ or HHVM in MW 1.31 - https://phabricator.wikimedia.org/T172165#3852411 (10daniel) This has been approved after last call as per the TechCom meeting of December 13. [20:25:55] (03CR) 10MaxSem: "recheck" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) (owner: 10MaxSem) [20:26:40] 10ContentTranslation, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Dashboard: box-shadow visible between "New translation" dialog and suggestion/translation lists - https://phabricator.wikimedia.org/T182193#3816005 (10Etonkovidova) Checked the fix in cx-testing:... [20:26:47] 10ContentTranslation, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Dashboard: box-shadow visible between "New translation" dialog and suggestion/translation lists - https://phabricator.wikimedia.org/T182193#3852425 (10Etonkovidova) 05Open>03Resolved [20:28:20] (03CR) 10jerkins-bot: [V: 04-1] Add UniversalLanguageSelector support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) (owner: 10MaxSem) [20:31:01] 10MediaWiki-extension-requests, 10Parsoid, 10Wikisource, 10Community-Wishlist-Survey-2015: Request for feature: automatic figure and equation (formula) numbering - https://phabricator.wikimedia.org/T7600#100400 (10TheDJ) This came up during the 2017 wishlist again: https://meta.wikimedia.org/wiki/2017_Comm... [20:31:34] (03PS2) 10MaxSem: Add UniversalLanguageSelector support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/399460 (https://phabricator.wikimedia.org/T171374) [20:33:41] (03PS1) 10Pmiazga: Delay form submit by 0.25s [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399463 (https://phabricator.wikimedia.org/T169807) [20:34:21] (03PS2) 10MarkAHershberger: Fix two bugs with lockdownNamespace() [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398519 [20:35:46] (03CR) 10MarkAHershberger: "thanks for checking this out! I don't have time to create tests at the moment, but since I do make use of this extension, I'll probably a" (032 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398519 (owner: 10MarkAHershberger) [20:36:14] (03PS5) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [20:37:10] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Replace settings checkboxes to ToggleSwitches - https://phabricator.wikimedia.org/T169807#3852456 (10pmiazga) I decided to quickly patch > Beta settings toggle should not get stuck on refresh... [20:40:40] (03CR) 10Nikerabbit: [V: 031 C: 032] Fix old style filters disappearing regression [core] - 10https://gerrit.wikimedia.org/r/399440 (owner: 10Petar.petkovic) [20:41:14] (03CR) 10jerkins-bot: [V: 04-1] Delay form submit by 0.25s [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399463 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [20:42:49] (03CR) 10MarkAHershberger: "I'm fine with removing it, but WMF devs seem to be in the habit of copying CI "cruft" to every repository. See, for example Gruntfile.js " [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [20:43:57] (03PS4) 10Anomie: Migrate HistoryBlob to alternatives without PHP serialization [core] - 10https://gerrit.wikimedia.org/r/397632 (https://phabricator.wikimedia.org/T181555) [20:44:34] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10DBA: Determine how to update old compressed ExternalStore entries for T181555 - https://phabricator.wikimedia.org/T183419#3852480 (10Anomie) p:05Triage>03Normal [20:45:33] 10Phabricator, 10Wikibugs, 10Security: wikibugs IRC bot publishes task titles of tasks in the non-public Space S4 - https://phabricator.wikimedia.org/T183415#3852495 (10Legoktm) [20:47:09] (03Merged) 10jenkins-bot: Fix old style filters disappearing regression [core] - 10https://gerrit.wikimedia.org/r/399440 (owner: 10Petar.petkovic) [20:47:31] (03PS1) 10Awight: Don't double-quote model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399464 (https://phabricator.wikimedia.org/T183266) [20:50:15] (03PS25) 10Anomie: Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) [20:51:13] (03CR) 10jerkins-bot: [V: 04-1] Migrate HistoryBlob to alternatives without PHP serialization [core] - 10https://gerrit.wikimedia.org/r/397632 (https://phabricator.wikimedia.org/T181555) (owner: 10Anomie) [20:51:57] 10ContentTranslation, 10Easy, 10Google-Code-in-2017, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Translation editor shows a gap between header and content - https://phabricator.wikimedia.org/T174139#3552033 (10Etonkovidova) I will need to check it in producti... [20:53:31] Hi Albert221 back, is it still working? :D [20:53:46] yes it is :) [20:56:30] (03PS5) 10Anomie: Migrate HistoryBlob to alternatives without PHP serialization [core] - 10https://gerrit.wikimedia.org/r/397632 (https://phabricator.wikimedia.org/T181555) [20:57:56] (03CR) 10jenkins-bot: Fix old style filters disappearing regression [core] - 10https://gerrit.wikimedia.org/r/399440 (owner: 10Petar.petkovic) [20:59:16] 10Phabricator, 10Wikibugs, 10Security: wikibugs IRC bot publishes task titles of tasks in the non-public Space S4 - https://phabricator.wikimedia.org/T183415#3852512 (10RobH) Yep, thanks for checking though! [21:00:16] (03PS1) 10Awight: Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 [21:00:40] (03PS7) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [21:02:05] (03CR) 10jerkins-bot: [V: 04-1] Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 (owner: 10Awight) [21:02:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272#3852521 (10thiemowmde) [21:02:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10Wikidata-Sprint-2017-12-20: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3852519 (10thiemowmde) 05Open>03Resolved [21:04:41] (03PS2) 10Awight: Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 [21:06:55] (03CR) 10Thiemo Kreuz (WMDE): "I don't know much about Grunt, but I will happily review patches that remove unused cruft. In the case we are talking about here my reason" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [21:08:26] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Tamil-Sites: Enabling options to import from commons to Tamil wikisource - https://phabricator.wikimedia.org/T181774#3852525 (10Balajijagadesh) Hi, I have made the request in the community page https://ta.wikisource.org/wiki/%E0%AE%B5%E0%AE%BF%E0%AE... [21:09:44] (03CR) 10Awight: [C: 032] Use ScoreParser instead of Cache::processRevision in ApiHooksHandler (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/397597 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [21:09:48] (03CR) 10jerkins-bot: [V: 04-1] Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 (owner: 10Awight) [21:09:54] (03PS1) 10Cooltey: [WIP] Update messaging to clarify sync behavior is per account level [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399468 (https://phabricator.wikimedia.org/T177516) [21:10:38] (03PS6) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [21:12:32] (03CR) 10MarkAHershberger: "Removed. I disagree that it isn't intended to be copied, but that's just my understanding of the README when it was added. That can be d" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [21:12:37] (03Merged) 10jenkins-bot: Use ScoreParser instead of Cache::processRevision in ApiHooksHandler [extensions/ORES] - 10https://gerrit.wikimedia.org/r/397597 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [21:13:21] (03PS8) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [21:13:36] 10Accessibility, 10Design, 10UI-Standardization, 10ContentTranslation, and 3 others: CX source selector has no focus state - https://phabricator.wikimedia.org/T177402#3852533 (10Etonkovidova) Re-checked (cx-testing and betalabs) - the fix works fine. {F11958702} In monobook: {F11958706} [21:13:51] 10Accessibility, 10Design, 10UI-Standardization, 10ContentTranslation, and 3 others: CX source selector has no focus state - https://phabricator.wikimedia.org/T177402#3852534 (10Etonkovidova) 05Open>03Resolved [21:14:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Fix two bugs with lockdownNamespace() (032 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398519 (owner: 10MarkAHershberger) [21:15:29] 10MediaWiki-Configuration, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Operations, 10Availability (Multiple-active-datacenters), and 4 others: Allow integration of data from etcd into the MediaWiki configuration - https://phabricator.wikimedia.org/T156924#3852549 (10Krinkle) [21:15:46] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Instrument print to PDF button - https://phabricator.wikimedia.org/T181297#3852551 (10Tbayer) [21:15:51] 10OOjs-UI, 10Patch-For-Review: Release OOUI v0.24.4 with some backported patches - https://phabricator.wikimedia.org/T183195#3852552 (10matmarex) [21:16:36] (03PS1) 10MaxSem: Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 [21:17:29] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Regression testing of 5.7.3 (1287) - https://phabricator.wikimedia.org/T182710#3832085 (10Nicholas.tsg) @JMinor @ABorbaWMF TSG did a Regression of 5.7.3 (1286) while I'm still doing a smoke test of 5.7.3 (1287) that covers some of the same ground. If you have access to the "iOS... [21:18:05] (03CR) 10jerkins-bot: [V: 04-1] Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 (owner: 10MaxSem) [21:19:17] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Security, 10Services (watching), 10TechCom-RfC (ArchCom-Approved): RFC: Deprecate using php serialization inside MediaWiki - https://phabricator.wikimedia.org/T161647#3138377 (10Tgr) PHP 7 introduces a class whitelist to `unserialize`. That protects again... [21:20:55] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "What I know is that this line is not widely added to other .phpcs.xml files in extensions:" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 (owner: 10MarkAHershberger) [21:21:47] (03PS9) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [21:22:07] (03PS2) 10MaxSem: Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 [21:22:26] (03CR) 10MarkAHershberger: Fix up formatting and add code docs (034 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [21:23:25] (03CR) 10Thiemo Kreuz (WMDE): "Awesome! Who might be willing to merge this? Can you add an other reviewer with +2 rights in this code base, if you know one?" [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/399412 (https://phabricator.wikimedia.org/T183323) (owner: 10Thiemo Kreuz (WMDE)) [21:23:45] 10MediaWiki-Authentication-and-authorization, 10Security-Core: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420#3852569 (10Tgr) [21:24:06] (03CR) 10jerkins-bot: [V: 04-1] Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 (owner: 10MaxSem) [21:27:42] 10New-Readers, 10Wikipedia-Android-App-Backlog, 10Reading Epics (Offline): Create product requirements for android offline collection support - https://phabricator.wikimedia.org/T158667#3043368 (10TheDJ) BTW. did this stall ? I remember it being pretty high one the 'we are doing this' list earlier in the yea... [21:28:23] (03PS2) 10EBernhardson: Push pagination decision for prefix search into SearchEngine [core] - 10https://gerrit.wikimedia.org/r/399312 [21:28:25] (03PS5) 10EBernhardson: Silently drop unknown titles in completion search [core] - 10https://gerrit.wikimedia.org/r/398192 (https://phabricator.wikimedia.org/T115756) [21:28:28] (03CR) 10EBernhardson: Push pagination decision for prefix search into SearchEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399312 (owner: 10EBernhardson) [21:29:13] (03PS3) 10Awight: Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 [21:30:48] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Update messaging to clarify sync behavior is per account level - https://phabricator.wikimedia.org/T177516#3852596 (10cooltey) @RHo For the proposed message from **Part (ii)**,... [21:38:20] 10WMF-CTO-Team-Backlog: Plan facilitator training for 2018 Dev Summit - https://phabricator.wikimedia.org/T183423#3852636 (10JAufrecht) [21:41:09] (03CR) 10Aaron Schulz: [C: 04-1] "Can we just go with https://gerrit.wikimedia.org/r/#/projects/performance,dashboards/custom:custom instead? That seems a lot simpler." [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [21:42:13] (03CR) 10Aaron Schulz: [C: 04-1] "Err, I meant https://gerrit.wikimedia.org/r/399391" [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [21:43:01] (03PS2) 10Aaron Schulz: Unbreak read-only transactions (used for consistent reads) [core] - 10https://gerrit.wikimedia.org/r/399391 [21:43:37] (03CR) 10Bmansurov: Delay form submit by 0.25s (031 comment) [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399463 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [21:44:27] (03CR) 10Aaron Schulz: "See https://gerrit.wikimedia.org/r/#/c/399391/" [core] - 10https://gerrit.wikimedia.org/r/399404 (https://phabricator.wikimedia.org/T183265) (owner: 10Catrope) [21:45:25] (03PS3) 10Aaron Schulz: Simplify logic to prevent writes on replica DB connections [core] - 10https://gerrit.wikimedia.org/r/399391 [21:46:36] 10TechCom-RfC: RFC: Add a revision source identifier - https://phabricator.wikimedia.org/T183061#3852672 (10Krinkle) [21:48:44] 10MediaWiki-Database, 10MediaWiki-General-or-Unknown, 10TechCom-RfC: RFC: Add a revision source identifier - https://phabricator.wikimedia.org/T183061#3852679 (10Krinkle) [21:48:51] 10MediaWiki-Database, 10TechCom-RfC: RFC: Add a revision source identifier - https://phabricator.wikimedia.org/T183061#3842437 (10Krinkle) [21:49:06] 10Discovery, 10Discovery-Analysis (Current work): Search Relevance Survey test #3: analysis of test - https://phabricator.wikimedia.org/T175048#3852696 (10mpopov) Added Python version into the production instructions for @EBernhardson's convenience :) https://github.com/wikimedia-research/Discovery-Search-Adho... [21:50:41] (03PS2) 10Cicalese: Adds "json xssi prefix length" and other parameters [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/399456 [21:57:58] (03PS3) 10Cicalese: Adds "json xssi prefix length" and other parameters [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/399456 [21:59:41] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Regression testing of 5.7.3 (1287) - https://phabricator.wikimedia.org/T182710#3852726 (10ABorbaWMF) @Nicholas.tsg, yes can you concentrate testing on 5.7.3 (1296). A smoke test there would be great. Thanks [22:00:25] 10MediaWiki-Authentication-and-authorization, 10Security-Core: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420#3852569 (10Anomie) If you want to generically store "authentication data", then don't try to make a "separate auth-table... [22:00:51] (03PS1) 10Rafidaslam: Add minus-x to "composer test" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/399479 (https://phabricator.wikimedia.org/T175794) [22:03:56] (03PS3) 10MaxSem: Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 [22:04:16] 10New-Readers, 10Wikipedia-Android-App-Backlog, 10Reading Epics (Offline): Create product requirements for android offline collection support - https://phabricator.wikimedia.org/T158667#3852759 (10RHo) hi @TheDJ - we created a prototype on Android (to show ZIM files in Android) and tested a proposed 'V1' wit... [22:05:39] (03CR) 10jerkins-bot: [V: 04-1] Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 (owner: 10MaxSem) [22:05:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/399475 (owner: 10L10n-bot) [22:06:03] (03PS2) 10Pmiazga: Delay form submit by 0.25s [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399463 (https://phabricator.wikimedia.org/T169807) [22:09:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/399478 (owner: 10L10n-bot) [22:11:30] (03CR) 10Ladsgroup: [C: 032] Don't double-quote model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399464 (https://phabricator.wikimedia.org/T183266) (owner: 10Awight) [22:13:11] (03CR) 10Ladsgroup: [C: 032] Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 (owner: 10Awight) [22:13:22] (03Merged) 10jenkins-bot: Don't double-quote model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399464 (https://phabricator.wikimedia.org/T183266) (owner: 10Awight) [22:15:00] (03Merged) 10jenkins-bot: Catch another double-quote, this may change the behavior of the three changes feeds. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399465 (owner: 10Awight) [22:21:12] RoanKattouw: https://gerrit.wikimedia.org/r/399391 [22:22:12] 10Design, 10MinervaNeue, 10Mobile-Web-Settings, 10MobileFrontend, and 3 others: Display namespace in mobile view of the page history - https://phabricator.wikimedia.org/T147722#2701617 (10pmiazga) a:03pmiazga [22:24:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399509 (owner: 10L10n-bot) [22:24:53] (03PS1) 10Aaron Schulz: objectcache: fix getMultiWithUnionSetCallback() doc [core] - 10https://gerrit.wikimedia.org/r/399531 [22:26:04] (03CR) 10Catrope: [C: 032] Simplify logic to prevent writes on replica DB connections [core] - 10https://gerrit.wikimedia.org/r/399391 (owner: 10Aaron Schulz) [22:26:30] AaronSchulz: Merged, but I am a little concerned that making unwriteable master connections might be harder that way [22:26:57] If there is only one DB server, wfGetDB( DB_REPLICA ) returns a master connection, and you won't be prevented from writing ot it [22:27:26] (03PS3) 10MarkAHershberger: Fix two bugs with lockdownNamespace() [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398519 [22:27:30] Which is sort of OK, but it means that unit tests and dev environments won't be able to catch code that tries to write to replica connections. Only running it in prod or beta environments with 2+ DB servers would [22:27:40] (03CR) 10Bmansurov: [C: 032] "Merging in order to get the linting fix in master. Let's tackle the other issue separately." [services/chromium-render] - 10https://gerrit.wikimedia.org/r/399361 (owner: 10Mobrovac) [22:27:43] (03CR) 10Bmansurov: [V: 032 C: 032] Use the new versions of mocha and eslint and their configs [services/chromium-render] - 10https://gerrit.wikimedia.org/r/399361 (owner: 10Mobrovac) [22:28:17] (03CR) 10MarkAHershberger: Fix two bugs with lockdownNamespace() (032 comments) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398519 (owner: 10MarkAHershberger) [22:28:56] (03PS7) 10MarkAHershberger: Use phpcs from composer [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/399315 [22:32:26] (03Merged) 10jenkins-bot: Simplify logic to prevent writes on replica DB connections [core] - 10https://gerrit.wikimedia.org/r/399391 (owner: 10Aaron Schulz) [22:34:16] 10MediaWiki-Page-editing: Easily add templates - https://phabricator.wikimedia.org/T18951#213418 (10kaldari) This task is probably the closest existing task to [[https://meta.wikimedia.org/wiki/2017_Community_Wishlist_Survey/Editing/Infobox_wizard|the infobox wizard proposal]] on the 2017 Community Wishlist Surv... [22:36:31] RoanKattouw: this mistake is rare, and would be caught in beta likey, also local config tricks like https://pastebin.com/78L15LSy can be used and probably should be (vagrant master/replica roles should also be created if not done so) [22:36:35] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Update App Store screenshots - https://phabricator.wikimedia.org/T180991#3852804 (10JMinor) When I download these they are quite small/low res? [22:37:19] Ha nice hack [22:37:31] Yes vagrant should have a replica role [22:37:52] AaronSchulz: Did you take that code from somewhere that already executes for the unit tests? [22:37:54] our own replicas always have read-only on which query() uses [22:37:59] Cause if not, we need to add that or something like it [22:38:21] and if it didn't check there it would be rejected by the server anyway [22:38:27] Sure but the whole point is to *not* rely on the DB server's read-only flag. Defense in dpeth [22:39:27] query() also checks whether the DB is a replica, so that's fine [22:39:38] I was mostly referring to single-master setups, esp for unit tests [22:41:58] 10MediaWiki-extensions-DonationInterface, 10FR-Amazon, 10FR-Smashpig: Deal better with Amazon auth/capture timing out - https://phabricator.wikimedia.org/T183429#3852806 (10Ejegg) [22:42:34] 10MediaWiki-Internationalization: Changing the alphabetical sorting (collation) @ ab.wikipedia.org (Abkhaz Wikipedia) - https://phabricator.wikimedia.org/T183430#3852817 (10matmarex) [22:42:50] 10MediaWiki-Internationalization: Changing the alphabetical sorting (collation) @ ab.wikipedia.org (Abkhaz Wikipedia) - https://phabricator.wikimedia.org/T183430#3852830 (10matmarex) [22:43:07] (03CR) 10jenkins-bot: Simplify logic to prevent writes on replica DB connections [core] - 10https://gerrit.wikimedia.org/r/399391 (owner: 10Aaron Schulz) [22:43:45] in cases of circular replication, it might be useful to write to different masters, using RBR to reduce scanning load, which would be useful as a replica and master write use case (since they are all masters in reality). Right now that would require setLBInfo( 'slave', false ) on connections, but it can be done. The NO_WRITE it would require an extra similar step, though it seems kind of YAGNI. [22:43:52] 10MediaWiki-extensions-DonationInterface, 10FR-Amazon, 10FR-Smashpig, 10Fundraising-Backlog: Deal better with Amazon auth/capture timing out - https://phabricator.wikimedia.org/T183429#3852834 (10Ejegg) [22:43:57] (03PS8) 10Bmansurov: Close page before closing the browser [services/chromium-render] - 10https://gerrit.wikimedia.org/r/394623 [22:44:37] (03CR) 10Bmansurov: "I see the failing test in docker passes if I run it outside docker like so `mocha ./test/features/v1/html2pdf.js`." [services/chromium-render] - 10https://gerrit.wikimedia.org/r/394623 (owner: 10Bmansurov) [22:45:24] 10Developer-Relations (Jul-Sep 2017), 10Google-Summer-of-Code (2017), 10Outreachy (Round-14): Engage student developers in projects and movement activities post-GSoC/ Outreachy completion - https://phabricator.wikimedia.org/T183335#3852836 (10srishakatux) [22:45:33] (03CR) 10Daniel Kinzler: "@aaron Oh, I like that as an alternative to the allowWrite flag. It is simpler than what we have on master now." [core] - 10https://gerrit.wikimedia.org/r/399445 (https://phabricator.wikimedia.org/T183242) (owner: 10Daniel Kinzler) [22:45:39] 10Developer-Relations (Jul-Sep 2017), 10Google-Summer-of-Code (2017), 10Outreachy (Round-14): Engage student developers in projects and movement activities post-GSoC/ Outreachy completion - https://phabricator.wikimedia.org/T183335#3850438 (10srishakatux) [22:46:12] 10MediaWiki-extensions-DonationInterface, 10FR-Amazon, 10FR-Smashpig, 10Fundraising-Backlog: Deal better with Amazon auth/capture timing out - https://phabricator.wikimedia.org/T183429#3852848 (10Ejegg) [22:48:28] also it would be weird to treat a DB as a master and a replica at the same time (either override in the ring-replication case I mentioned by example) or leave it. Local testing would not work well in that case since the master/replica connection would be shared (unless using the fake replica config I had). I guess you could keep flipping flags around automatically using reference wrappers (at a glace the patch seemed to do [22:48:28] that), but it seems non-KISS and seems to overly discourage certain use cases (e.g. ring replication). In fact, it would be nice to have a convenience flag for the ring case. [22:48:50] anyway, this is probably getting to far down the use case rabbit holes ;) [22:49:54] seems every thing LGTM now [22:51:29] (03PS4) 10Esanders: Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [22:51:32] (03PS4) 10Esanders: Remove the old editor system [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 (owner: 10Catrope) [22:51:35] (03PS5) 10Esanders: Remove unused cancel buttons and some other things [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398683 (owner: 10Catrope) [22:51:38] (03PS4) 10Esanders: Don't ship unused templates to the client [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398684 (owner: 10Catrope) [22:52:04] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Update App Store screenshots - https://phabricator.wikimedia.org/T180991#3852860 (10cmadeo) [22:53:21] heh, galera would also be a use case for grouping queries by type to initiate on certain masters (since it uses wsrep replication that is PK based like RBR). Would be interesting if $group actually did something for DB_MASTER. [22:53:35] AaronSchulz: it seems i missed half of what you just said here, and I'm about to leave the office. can you copy the relevant bits to gerrit? thanks! [22:54:08] (03PS4) 10Esanders: Initializer: Simplify and deduplicate setupUndoPage() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398681 (owner: 10Catrope) [22:54:29] and grouping for galera would also reduce deadlocks [22:55:04] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Update App Store screenshots - https://phabricator.wikimedia.org/T180991#3852862 (10cmadeo) [22:55:18] AaronSchulz: I'm also interested in your oppinion of the expected behavior i coded into LoadBalancerTest [22:55:19] anyway, all theoretical, the TLDR is that I think with the begin/commit stuff having been removed and https://gerrit.wikimedia.org/r/#/c/399391/ now merged, I don't see any issues left. [22:56:00] (03PS3) 10Esanders: Drop the never-finished "Labs" publish and preview features [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392899 (owner: 10Jforrester) [22:56:03] (03PS3) 10Esanders: Follow-up 7815040: Remove the 'dialogs' config object, no longer read [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392900 (owner: 10Jforrester) [22:56:06] (03PS3) 10Esanders: Radically simplify this extension now there's only one config option [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 (owner: 10Jforrester) [22:56:09] (03PS4) 10Esanders: Merge all the non-styles-only ResourceLoader modules into one [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) (owner: 10Jforrester) [22:56:11] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Update App Store screenshots - https://phabricator.wikimedia.org/T180991#3775632 (10cmadeo) @jminor I updated with higher res images, sorry I forgot to export at 3x! [22:56:36] (03CR) 10Esanders: [C: 031] Drop the never-finished "Labs" publish and preview features [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392899 (owner: 10Jforrester) [22:56:59] (03CR) 10Esanders: [C: 031] Radically simplify this extension now there's only one config option [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 (owner: 10Jforrester) [22:57:13] (03CR) 10Esanders: [C: 032] Merge all the non-styles-only ResourceLoader modules into one [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) (owner: 10Jforrester) [22:57:37] AaronSchulz: bad code still doesn't fail in unit tests, afaik. that was the point of my patch [23:00:27] (03PS4) 10MaxSem: Namespace and PSR-4 this extension [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/399470 [23:03:38] (03CR) 10Esanders: [C: 04-1] Radically simplify this extension now there's only one config option (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 (owner: 10Jforrester) [23:14:07] (03PS1) 10Ryan10145: Added MinusX Support [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) [23:14:30] 10OOjs-UI: grunt-image 4 doesn't work on local machine - https://phabricator.wikimedia.org/T179992#3852886 (10Volker_E) …aaaand `grunt image` doesn't work again. :( > spawn /Users/.../htdocs/Wikimedia/oojs-ui/node_modules/pngquant-bin/vendor/pngquant EAGAIN [23:15:13] 10OOjs-UI: grunt-image 4 doesn't work on local machine - https://phabricator.wikimedia.org/T179992#3852887 (10Volker_E) 05Invalid>03Open [23:15:42] (03PS1) 10Ryan10145: Added MinusX Support [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) [23:16:22] (03CR) 10Esanders: [C: 04-1] "I'm getting exceptions in debug mode, so probably a subtle load order issue." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) (owner: 10Jforrester) [23:16:41] (03CR) 10Hashar: [C: 032] Added MinusX Support [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:17:27] (03CR) 10Nirzar: "toggle switch gets stuck on iOS 11, mobile chrome 63.0 on iPhone X" [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/399463 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [23:17:55] (03CR) 10jerkins-bot: [V: 04-1] Added MinusX Support [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:19:14] 10Phabricator, 10User-Matthewrbowker: Advanced bug entry form is no longer available - https://phabricator.wikimedia.org/T183432#3852893 (10Matthewrbowker) [23:20:44] 10Design, 10OOjs-UI, 10UI-Standardization, 10WMF-Design, and 2 others: OOUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801#3852907 (10Volker_E) [23:21:00] (03CR) 10Hashar: [C: 04-1] Added MinusX Support (031 comment) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:22:00] (03PS4) 10Esanders: Radically simplify this extension now there's only one config option [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 (owner: 10Jforrester) [23:22:03] (03PS5) 10Esanders: Merge all the non-styles-only ResourceLoader modules into one [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) (owner: 10Jforrester) [23:22:24] (03CR) 10Esanders: [C: 04-1] "PS5 ensures ext.* modules load after jquery.* modules (their former dependencies)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) (owner: 10Jforrester) [23:22:34] (03CR) 10Esanders: [C: 031] Merge all the non-styles-only ResourceLoader modules into one [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392902 (https://phabricator.wikimedia.org/T165112) (owner: 10Jforrester) [23:23:09] (03PS10) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [23:24:06] (03CR) 10Esanders: [C: 04-1] Radically simplify this extension now there's only one config option (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 (owner: 10Jforrester) [23:24:14] (03CR) 10Esanders: [C: 031] Radically simplify this extension now there's only one config option [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/392901 (owner: 10Jforrester) [23:24:19] (03CR) 10jerkins-bot: [V: 04-1] Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [23:25:39] 10Wikipedia-Android-App-Backlog, 10Reading Epics (Synchronized Reading Lists): Empty state of reading lists should be updated the fact that all will see the default list - https://phabricator.wikimedia.org/T183434#3852918 (10RHo) [23:26:22] (03PS11) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [23:35:54] (03CR) 10Umherirrender: Do some maintenance (031 comment) [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/366201 (owner: 10Kghbln) [23:39:02] (03PS2) 10Ryan10145: Added MinusX Support [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) [23:39:41] (03PS2) 10Ryan10145: Added MinusX Support [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) [23:43:19] (03PS12) 10MarkAHershberger: Fix up formatting and add code docs [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 [23:43:52] (03CR) 10Umherirrender: [C: 031] Added MinusX Support [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:44:29] (03CR) 10Umherirrender: [C: 031] Added MinusX Support [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:44:38] 10ContentTranslation, 10Easy, 10Google-Code-in-2017, 10I18n, and 2 others: The labels and numbers in CX translation trend graph is not localized - https://phabricator.wikimedia.org/T94020#3852935 (10Ryan10145) Is there any way for me to get any more information about which dates in particular are causing a... [23:45:00] (03CR) 10jerkins-bot: [V: 04-1] Added MinusX Support [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:45:25] (03PS1) 10Mooeypoo: Move the popups to the overlay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399536 (https://phabricator.wikimedia.org/T156080) [23:45:28] (03CR) 10jerkins-bot: [V: 04-1] Added MinusX Support [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:48:46] 10OOjs-UI, 10Apex, 10Collaboration-Team-Triage, 10Notifications: Secondary links broken in Echo (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3852947 (10Mooeypoo) [23:49:46] (03CR) 10Umherirrender: [C: 04-1] "Needs fixing of executable flag:" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:50:36] 10OOjs-UI, 10Apex, 10Collaboration-Team-Triage, 10Notifications: Secondary links broken in Echo (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3852959 (10Mooeypoo) @Volker_E I played around with trying to fix it, but all the adjustments don't make much sense (... [23:50:41] (03CR) 10Umherirrender: [C: 031] "Unrelated test failure:" [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/399535 (https://phabricator.wikimedia.org/T175794) (owner: 10Ryan10145) [23:51:06] 10OOjs-UI, 10Apex, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Secondary links broken in Echo (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3852961 (10Mooeypoo) [23:52:29] 10OOjs-UI, 10Apex, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3852947 (10Mooeypoo) [23:52:44] (03CR) 10Umherirrender: [C: 031] Add minus-x to "composer test" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/399479 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [23:54:02] 10OOjs-UI, 10Apex, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3852964 (10Volker_E) @Mooeypoo I will look into this in the next couple of days… [23:54:15] Albert221: hey i missed you coming in today how are you [23:54:38] (03PS1) 10Bartosz Dziewoński: Add collation for Abkhaz (ab) [core] - 10https://gerrit.wikimedia.org/r/399537 (https://phabricator.wikimedia.org/T183430) [23:55:48] 10Developer-Relations (Oct-Dec 2017), 10Goal, 10Outreachy (Round-15): Coordinate Wikimedia's participation in Outreachy Round 15 - https://phabricator.wikimedia.org/T173780#3852970 (10srishakatux) [23:58:23] (03CR) 10Umherirrender: [C: 032] Add minus-x to "composer test" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/399479 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [23:58:38] (03PS3) 10Ryan10145: Added MinusX Support [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/399534 (https://phabricator.wikimedia.org/T175794) [23:58:41] Zppix: hey! Fortunately I'm now using a bouncer so I didn't miss that message from you :) I was a little busy today and I'm waiting for my task to get reviewed, I also got some private problems which really dont help me in interacting with people, so sorry. I'm also going to bed right now [23:59:01] But it's nice of you that you asked :) [23:59:24] Ah well have a good night, hope those issues get sorted [23:59:36] Thank you, good night [23:59:39] Np