[00:01:49] (03PS4) 10MaxSem: Fix target detection for jquery.textSelection overrides [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/397631 (https://phabricator.wikimedia.org/T177175) [00:18:54] 10ContentTranslation: [cx-testing] 500 Internal Server Error ContentTranslation page - https://phabricator.wikimedia.org/T183206#3846833 (10Etonkovidova) [00:21:31] 10MediaWiki-extensions-CodeMirror, 10CharInsert, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: CharInsert+CodeMirror doesn't work under WebKit browsers - https://phabricator.wikimedia.org/T179287#3846843 (10MaxSem) [00:23:05] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 4 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3846847 (10jmatazzoni) [00:30:00] 10phan-taint-check-plugin: UserGroupMembership::getLink() causes a significant portion of false positives for phan-taint-check-plugin - https://phabricator.wikimedia.org/T183174#3846848 (10TTO) If only PHP supported proper enums... The function was previously split when it belonged to the User class (`User::mak... [00:31:15] 10MediaWiki-User-management, 10phan-taint-check-plugin: UserGroupMembership::getLink() causes a significant portion of false positives for phan-taint-check-plugin - https://phabricator.wikimedia.org/T183174#3846850 (10Legoktm) [00:32:27] 10MediaWiki-User-management, 10phan-taint-check-plugin: UserGroupMembership::getLink() causes a significant portion of false positives for phan-taint-check-plugin - https://phabricator.wikimedia.org/T183174#3845910 (10Legoktm) +1 to splitting the methods again. We can use a private helper function to avoid dup... [00:53:51] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, and 4 others: Selecting syntax-highlighted text in the 2017 source editor covers it completely when using Firefox on OSX - https://phabricator.wikimedia.org/T175223#3846877 (10DannyH) [00:53:54] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ProofreadPage, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), 10Patch-For-Review: ProofreadPage conflict in text box size - https://phabricator.wikimedia.org/T176449#3846878 (10DannyH) [00:57:50] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), 10Patch-For-Review: Investigation: CodeMirror and WikEd gadget (and maybe other syntax highlighting gadgets) don't get along well - https://phabricator.wikimedia.org/T178348#3846884 (10Danny... [00:59:01] 10MediaWiki-Installer, 10MediaWiki-Maintenance-scripts, 10Community-Tech, 10MW-1.30-release-notes, and 3 others: Update.php fails with postgres due to ip_changes population - https://phabricator.wikimedia.org/T177258#3846886 (10DannyH) [00:59:04] (03PS1) 10Petar.petkovic: Fix Contributions ORES preference and form override [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399122 (https://phabricator.wikimedia.org/T182911) [01:01:27] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Deep-linking should work on article subsection links (App should open articles to the appropriate section) - https://phabricator.wikimedia.org/T171521#3846890 (10cooltey) Have been trying to investigate this issue, and it looks like the https://en.wikipedia.... [01:02:20] 10MediaWiki-Parser, 10Community-Tech, 10Parsoid, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Some characters in HTML5 fragments mess with wikitext - https://phabricator.wikimedia.org/T179544#3846892 (10DannyH) [01:03:42] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10Patch-For-Review: CodeMirror textarea is non-expandable - https://phabricator.wikimedia.org/T170906#3846894 (10DannyH) [01:03:54] 10Phabricator, 10Developer-Relations: Find best way to allow CoC committee to temporarily disable Phab user accounts - https://phabricator.wikimedia.org/T183116#3846896 (10mmodell) it's fairly trivial to add a separate permission check for something like "members of acl*account admins" and then we can add indi... [01:09:13] Hello [01:10:59] 10MediaWiki-Parser, 10Community-Tech, 10Parsoid, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), 10Patch-For-Review: Non-breaking space in header ID breaks anchor - https://phabricator.wikimedia.org/T90902#3846897 (10DannyH) [01:16:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-Wishlist-Survey-2016, 10Goal: [Goal] Sitelinks to Incubator, OldWikisource and BetaWikiversity - https://phabricator.wikimedia.org/T54971#3846938 (10Samwilson) >>! In T54971#3844679, @MF-Warburg wrote: > What an outrageously nonsensical com... [01:18:58] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Epic, 10Google-Code-in-2017: Fix up PHPCS violations that are excluded in phpcs.xml - https://phabricator.wikimedia.org/T177810#3846945 (10Pppery) [01:19:00] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Google-Code-in-2017: Fix multiple PHP class declarations in one file - https://phabricator.wikimedia.org/T177809#3846944 (10Pppery) [01:19:56] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Google-Code-in-2017: Fix multiple PHP class declarations in one file - https://phabricator.wikimedia.org/T177809#3670934 (10Pppery) [01:21:34] (03CR) 10Kaldari: "For me this fixes T177175, but not T179287. Testing in Chrome with latest master repos. Maybe someone else could test." [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/397631 (https://phabricator.wikimedia.org/T177175) (owner: 10MaxSem) [01:22:47] 10Wikimedia-Wikimania-Scholarships: text content of scholarships.wikimedia.org is stale by 1 year in british english - https://phabricator.wikimedia.org/T157980#3846963 (10Niharika) >>! In T157980#3845773, @KTC wrote: > And again for 2018. https://translatewiki.net/w/i.php?title=Special:Translate&group=out-wiki... [01:53:40] (03PS1) 10Jonathanischoice: Use the INDEX_NAME constant in all the places. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 [01:56:57] 10MediaWiki-extensions-Page_Forms: Page Forms review checklist - https://phabricator.wikimedia.org/T183213#3847020 (10Yaron_Koren) [01:58:42] bawolff: im a little confused about your security tool [01:59:20] Do i run it like i would composer or do i do something special because i tried both [02:03:12] You can install it with composer [02:03:21] Ok [02:03:53] and if you put stuff in the scripts directive of composer.json, it provides a shortcut way of running it [02:04:33] Oh [02:04:38] if you dont do that step, you can run it by doing ./vendor/bin/seccheck-fast-mwext [02:04:44] Thats what i wasnt doing right [02:04:49] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [02:17:26] 10Front-end-Standards-Group, 10Epic: Tooling: Should not be possible to ship un-optimised SVGs - https://phabricator.wikimedia.org/T162319#3847047 (10Volker_E) On further tests, above recommendations for SVGO have been proven mostly fail-safe so far, with one addition, disabling 'cleanupIDs' is necessary on mo... [02:24:49] 10MediaWiki-extensions-GettingStarted, 10Collaboration-Team-Triage: Port GettingStarted Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180224#3847050 (10Mattflaschen-WMF) @Etonkovidova @SBisson @mooeypoo @Catrope I would like to make an exception and migrate this one, since it is acti... [02:26:25] 10MediaWiki-extensions-GettingStarted, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Port GettingStarted Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180224#3847052 (10Mattflaschen-WMF) It has gotten flakier lately, but I think that is due to Beta instability, not any issu... [02:29:29] (03PS6) 10Mooeypoo: [wip] RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) [02:35:38] (03CR) 10jerkins-bot: [V: 04-1] [wip] RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) (owner: 10Mooeypoo) [02:36:59] (03PS1) 10Mattflaschen: Remove Ruby browser tests [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399130 (https://phabricator.wikimedia.org/T174589) [02:38:44] (03CR) 10jerkins-bot: [V: 04-1] Remove Ruby browser tests [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399130 (https://phabricator.wikimedia.org/T174589) (owner: 10Mattflaschen) [02:40:10] (03PS1) 10Mattflaschen: Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) [02:42:18] 10UI-Standardization, 10Front-end-Standards-Group, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867#3847061 (10Volker_E) [02:45:17] 10MediaWiki-extensions-PageCuration, 10Browser-Tests, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review: PageTriage: Remove Ruby browser tests - https://phabricator.wikimedia.org/T174589#3847064 (10Mattflaschen-WMF) [02:47:30] (03CR) 10Mattflaschen: [C: 04-2] "See task" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [02:47:32] (03CR) 10jerkins-bot: [V: 04-1] Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [03:18:54] 10Front-end-Standards-Group, 10Epic: Tooling: Should not be possible to ship un-optimised SVGs - https://phabricator.wikimedia.org/T162319#3847068 (10Volker_E) [03:18:58] 10UI-Standardization, 10Front-end-Standards-Group, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867#3847067 (10Volker_E) [03:19:00] (03CR) 10Legoktm: [MCR] Turn Revision into a proxy to new code. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/375050 (owner: 10Daniel Kinzler) [03:21:28] (03CR) 10Legoktm: "I'm sorry, but this commit message is...terrible. This is a giant patch (+752, -1414), and it exactly one line in the commit message. The " [core] - 10https://gerrit.wikimedia.org/r/375050 (owner: 10Daniel Kinzler) [03:25:42] (03PS1) 10Legoktm: RevisionTest: Revision::constructFromRowArray is not a function [core] - 10https://gerrit.wikimedia.org/r/399132 [03:26:08] (03CR) 10Legoktm: [C: 032] "To unbreak the coverage" [core] - 10https://gerrit.wikimedia.org/r/399132 (owner: 10Legoktm) [03:26:46] (03CR) 10Legoktm: "This also broke the coverage job, I guessed in submitting Change-Id: Ia6c2e7eb667aa746a12ce74aad62e58d2468defd - please take a look at tha" [core] - 10https://gerrit.wikimedia.org/r/375050 (owner: 10Daniel Kinzler) [03:28:28] 10MediaWiki-User-management, 10phan-taint-check-plugin: UserGroupMembership::getLink() causes a significant portion of false positives for phan-taint-check-plugin - https://phabricator.wikimedia.org/T183174#3847069 (10Bawolff) I definitely agree that we should use private methods to avoid code duplication as m... [03:33:10] (03Merged) 10jenkins-bot: RevisionTest: Revision::constructFromRowArray is not a function [core] - 10https://gerrit.wikimedia.org/r/399132 (owner: 10Legoktm) [03:42:17] (03CR) 10jenkins-bot: RevisionTest: Revision::constructFromRowArray is not a function [core] - 10https://gerrit.wikimedia.org/r/399132 (owner: 10Legoktm) [03:44:36] (03PS1) 10VolkerE: Unify SVG markup [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399133 (https://phabricator.wikimedia.org/T178867) [03:48:22] 10UI-Standardization, 10Front-end-Standards-Group, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867#3847073 (10Volker_E) [03:50:45] 10MobileFrontend, 10Mobile: Reference anchor and target IDs use inconsistent percent encoding - https://phabricator.wikimedia.org/T183049#3847075 (10Tgr) You are right, the mobile version does have percent-encoded anchors (although in general the DOM viewer in the browser is not a reliable way of making sure -... [04:23:41] 10Phabricator, 10Developer-Relations: Find best way to allow CoC committee to temporarily disable Phab user accounts - https://phabricator.wikimedia.org/T183116#3843877 (10demon) Cf: T102577, probably others. [04:23:55] 10Phabricator, 10Repository-Admins, 10Scoring-platform-team: Access request: Phabricator Repository-Admins - https://phabricator.wikimedia.org/T182864#3847085 (10demon) 05Open>03Resolved a:03demon Done! Lemme know if you have any questions. [04:35:59] 10Timeless: Cannot correctly select text in chromium - https://phabricator.wikimedia.org/T183215#3847088 (10Isarra) [05:09:03] 10MediaWiki-Vagrant, 10Epic, 10Patch-For-Review: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847099 (10bd808) Announced for testing on wikitech-l: https://lists.wikimedia.org/pipermail/wikitech-l/2017-December/089294.html [05:16:47] (03CR) 10John Vandenberg: [C: 031] UserProfilePage: Avoid &$this in hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398673 (https://phabricator.wikimedia.org/T153505) (owner: 10Rafidaslam) [05:16:50] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3217641 (10jayvdb) @Reedy , the task description say " `The s... [05:16:55] (03CR) 10John Vandenberg: [C: 031] SpecialGlobalContributions: Avoid &$this in hooks [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/398672 (https://phabricator.wikimedia.org/T153505) (owner: 10Rafidaslam) [05:17:47] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Could not load image - https://phabricator.wikimedia.org/T183217#3847116 (10Rantemario) [05:41:43] 10MediaWiki-Categories, 10Wikimedia-Israel-Hackers: Category text "Pages in category "foo"" does not use DISPLAYTITLE - https://phabricator.wikimedia.org/T46197#3847132 (10eranroz) [05:50:17] 10MediaWiki-Categories, 10Wikimedia-Israel-Hackers: Category text "Pages in category "foo"" does not use DISPLAYTITLE - https://phabricator.wikimedia.org/T46197#512337 (10eranroz) 5 years later - issue still relvant. I may rebase https://gerrit.wikimedia.org/r/#/c/44766/ to handle other issues with categories... [06:01:39] (03CR) 10Eranroz: [C: 04-1] "1. see some minor issues" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/305991 (https://phabricator.wikimedia.org/T43720) (owner: 10Nikerabbit) [06:02:51] 10MediaWiki-Codesniffer: PHPCS should make sure @covers tags are absolute - https://phabricator.wikimedia.org/T183218#3847140 (10Legoktm) [06:03:08] (03PS1) 10Legoktm: RevisionTest: Make @covers tags absolute [core] - 10https://gerrit.wikimedia.org/r/399137 [06:03:27] (03CR) 10Legoktm: [C: 032] "Hopefully last patch to unbreak coverage..." [core] - 10https://gerrit.wikimedia.org/r/399137 (owner: 10Legoktm) [06:03:40] 10MediaWiki-Codesniffer: PHPCS should make sure @covers tags are absolute - https://phabricator.wikimedia.org/T183218#3847151 (10Legoktm) Example: https://gerrit.wikimedia.org/r/#/c/399137/ [06:04:19] (03CR) 10Legoktm: [C: 032] SpecialGlobalContributions: Avoid &$this in hooks [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/398672 (https://phabricator.wikimedia.org/T153505) (owner: 10Rafidaslam) [06:04:38] (03CR) 10Legoktm: [C: 032] UserProfilePage: Avoid &$this in hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398673 (https://phabricator.wikimedia.org/T153505) (owner: 10Rafidaslam) [06:06:17] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3847152 (10Legoktm) [06:06:35] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3217670 (10Legoktm) The task description was wrong, I've upda... [06:09:40] (03Merged) 10jenkins-bot: RevisionTest: Make @covers tags absolute [core] - 10https://gerrit.wikimedia.org/r/399137 (owner: 10Legoktm) [06:09:42] (03Merged) 10jenkins-bot: SpecialGlobalContributions: Avoid &$this in hooks [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/398672 (https://phabricator.wikimedia.org/T153505) (owner: 10Rafidaslam) [06:09:44] (03Merged) 10jenkins-bot: UserProfilePage: Avoid &$this in hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/398673 (https://phabricator.wikimedia.org/T153505) (owner: 10Rafidaslam) [06:15:24] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847160 (10bd808) [06:16:47] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3787138 (10bd808) [06:16:49] 10MediaWiki-Vagrant: Migrate from hhvm to php7 in vagrant - https://phabricator.wikimedia.org/T176387#3847163 (10bd808) [06:16:57] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3787138 (10bd808) [06:16:59] 10MediaWiki-Vagrant: Migrate from hhvm to php7 in vagrant - https://phabricator.wikimedia.org/T176387#3623615 (10bd808) [06:17:52] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847173 (10bd808) [06:17:54] 10MediaWiki-Vagrant: Migrate from hhvm to php7 in vagrant - https://phabricator.wikimedia.org/T176387#3623615 (10bd808) 05Open>03Resolved a:03bd808 {T181915} [06:19:18] (03CR) 10jenkins-bot: RevisionTest: Make @covers tags absolute [core] - 10https://gerrit.wikimedia.org/r/399137 (owner: 10Legoktm) [06:29:04] (03PS18) 10Samwilson: Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) [06:32:05] 10MediaWiki-Core-Tests: RevisionRecordTest is empty - https://phabricator.wikimedia.org/T183219#3847183 (10Legoktm) [06:34:04] 10MediaWiki-Debian, 10Patch-For-Review: Provide systemd unit for runJobs.php - https://phabricator.wikimedia.org/T160035#3847193 (10Legoktm) 05Open>03Resolved This was documented in {cc21479b24d3f3b452ead5bdcb44f37a31edd165}. [06:35:57] (03CR) 10jerkins-bot: [V: 04-1] Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [06:37:05] (03PS19) 10Samwilson: Convert Preferences class into PreferencesFactory service [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) [06:41:43] 10Easy, 10Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3847198 (10jayvdb) 05declined>03Open [06:41:56] 10Easy, 10Google-Code-In-2016: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2840322 (10jayvdb) [06:42:15] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2840322 (10jayvdb) [06:42:47] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2840322 (10jayvdb) [06:43:22] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2840322 (10jayvdb) Here is the task from last year: https://codein.withgoogle.com/archive/2016/organization/57098756864... [06:47:33] 10OOjs-UI, 10Browser-Support-Apple-Safari: Vertical scrollbar does not appear inside dialogs in Safari when system is set to always show scrollbars - https://phabricator.wikimedia.org/T181030#3847204 (10Volker_E) @Esanders This together with my comment on T154385#3847196 our original way out might need to be c... [06:53:08] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3847208 (10jayvdb) [06:54:42] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2840322 (10jayvdb) [06:55:25] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3847219 (10jayvdb) [06:56:25] 10MediaWiki-Codesniffer: Have PHPCS autofix some aliases to the more commonly used functions - https://phabricator.wikimedia.org/T183220#3847220 (10Legoktm) [06:59:33] 10MediaWiki-Codesniffer, 10Patch-For-Review: CodeSniffer to warn against usages of extract() - https://phabricator.wikimedia.org/T180398#3756493 (10Legoktm) a:03Legoktm [06:59:40] 10MediaWiki-Codesniffer, 10Patch-For-Review: Detect use of create_function with codesniffer - https://phabricator.wikimedia.org/T181865#3804825 (10Legoktm) a:03Legoktm [07:00:17] 10OOjs-UI, 10Browser-Support-Apple-Safari: Vertical scrollbar does not appear inside dialogs in Safari when system is set to always show scrollbars - https://phabricator.wikimedia.org/T181030#3847238 (10Volker_E) [07:00:20] 10OOjs-UI, 10Browser-Support-Apple-Safari: BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar - https://phabricator.wikimedia.org/T158610#3847241 (10Volker_E) [07:01:38] 10OOjs-UI, 10Browser-Support-Apple-Safari: BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar - https://phabricator.wikimedia.org/T158610#3041810 (10Volker_E) >>! In T181030#3838243, @Esanders wrote: > This is a Safari bug which is an issue with OOUI dialogs. If you turn off transform:... [07:02:04] 10OOjs-UI, 10Browser-Support-Apple-Safari: BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar when system is set to always show scrollbars - https://phabricator.wikimedia.org/T158610#3847246 (10Volker_E) [07:10:06] 10MediaWiki-Codesniffer: Split codesniffer repo into 2 (codesniffer & codesniffer-sniffs) - https://phabricator.wikimedia.org/T133011#3847248 (10Legoktm) 05Open>03declined At the time, this might have made sense, but today we follow the latest upstream PHPCS release pretty quickly, and take advantage of new... [07:23:25] 10ContentTranslation, 10ContentTranslation-Deployments, 10ContentTranslation-FY2017-18, 10Language-2018-Jan-Mar: Adapt CX configuration to use v1 and v2 at a same time - https://phabricator.wikimedia.org/T183139#3847253 (10KartikMistry) [07:25:43] https://github.com/eisenhaus335/wikilabels/blob/master/wikilabels/database/schema-testdata.sql [07:27:43] i am dont know the function of rev_id. i am know this are JSON but where is the file? [07:38:10] (03CR) 10Nikerabbit: Improve page display title handling for category pages (033 comments) [core] - 10https://gerrit.wikimedia.org/r/305991 (https://phabricator.wikimedia.org/T43720) (owner: 10Nikerabbit) [07:39:07] (03PS5) 10Nikerabbit: Improve page display title handling for category pages [core] - 10https://gerrit.wikimedia.org/r/305991 (https://phabricator.wikimedia.org/T43720) [07:41:20] (03CR) 10Nikerabbit: "Anyone can update the @since tags, I likely won't do it myself unless I see there is high change this patch will be marked. Similarly for " [core] - 10https://gerrit.wikimedia.org/r/305991 (https://phabricator.wikimedia.org/T43720) (owner: 10Nikerabbit) [08:10:52] (03CR) 10Freakolowsky: Trigger name changes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) (owner: 10Freakolowsky) [08:13:39] (03PS2) 10Freakolowsky: Trigger name changes [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) [08:15:49] (03CR) 10DCausse: [C: 032] Fix --ids option [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399103 (https://phabricator.wikimedia.org/T183197) (owner: 10Smalyshev) [08:16:25] (03CR) 10DCausse: [C: 032] Suppress phan warning for now [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399106 (owner: 10Smalyshev) [08:16:43] hey guys a doubt [08:17:37] (03CR) 10DCausse: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [08:18:12] how should i create a sandbox under the module:sandbox [08:18:32] when i try to create a sandbox it just creates one under my user page [08:19:09] Hii [08:19:22] I'm Siddarth of Chennai and I love racing. [08:19:33] The [08:19:39] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3847267 (10jayvdb) > The task description was wrong, I've upd... [08:20:30] I'm on a task given by google [08:21:15] *Google code-in [08:23:30] Any1 on this task [08:24:16] hey dude [08:24:27] i wason it [08:24:34] (03CR) 10DCausse: [C: 032] Update UTF-32 handing and CLI options in analyze_counts [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/398890 (owner: 10Tjones) [08:24:51] (03Merged) 10jenkins-bot: Update UTF-32 handing and CLI options in analyze_counts [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/398890 (owner: 10Tjones) [08:24:53] (03Merged) 10jenkins-bot: Suppress phan warning for now [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399106 (owner: 10Smalyshev) [08:25:10] (03Merged) 10jenkins-bot: Fix --ids option [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399103 (https://phabricator.wikimedia.org/T183197) (owner: 10Smalyshev) [08:26:05] (03CR) 10jerkins-bot: [V: 04-1] Use the INDEX_NAME constant in all the places. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [08:29:27] (03CR) 10TerraCodes: "Could someone please restore this patch? (I'm not able to)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/267550 (https://phabricator.wikimedia.org/T118637) (owner: 10BryanDavis) [08:43:14] 10ContentTranslation, 10ContentTranslation-Deployments, 10ContentTranslation-FY2017-18, 10Language-2018-Jan-Mar: Adapt CX configuration to use v1 and v2 at a same time - https://phabricator.wikimedia.org/T183139#3847290 (10santhosh) @mobrovac We have v1 and v2 apis in cxserver. v2 was recently added to sup... [08:51:37] (03PS3) 10Freakolowsky: Trigger name changes [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) [09:09:13] 10ContentTranslation, 10ContentTranslation-Deployments, 10ContentTranslation-FY2017-18, 10Language-2018-Jan-Mar: Adapt CX configuration to use v1 and v2 at a same time - https://phabricator.wikimedia.org/T183139#3847324 (10mobrovac) I don't agree with the premise of this ticket. If these are two separate A... [09:16:05] (03CR) 1001tonythomas: [C: 04-1] "I would say this query should follow this pattern." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [09:26:37] 10MediaWiki-Core-Tests, 10User-Addshore: RevisionRecordTest is empty - https://phabricator.wikimedia.org/T183219#3847354 (10Addshore) a:03Addshore [09:30:23] 10MediaWiki-Debug-Logger, 10MediaWiki-Documentation, 10Documentation: Document MediaWiki statsd metrics - https://phabricator.wikimedia.org/T183179#3847361 (10Addshore) Option 2 sounds like the nicest idea, keeping them inline will result in them being kept up to date and forgotten less I imagine! [09:35:02] 10Wikimedia-Wikimania-Scholarships: text content of scholarships.wikimedia.org is stale by 1 year in british english - https://phabricator.wikimedia.org/T157980#3847368 (10Niharika) @bd808, we took out translation files for languages which had missing translations last time. I can do it this time. You did it dir... [09:37:40] (03PS1) 10Divadsn: Add help link to special pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399150 (https://phabricator.wikimedia.org/T180980) [09:44:48] Good morning everyone and good afternoon refeed[m] :P [09:45:55] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3847379 (10Aklapper) Thank you! [09:47:07] 10ContentTranslation, 10Easy, 10Google-Code-in-2017, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Translation editor shows a gap between header and content - https://phabricator.wikimedia.org/T174139#3847384 (10divadsn) Thanks to @Santhosh for his help in revi... [09:47:49] I always feel ‘damnitㅡ [09:47:57] s/ㅡ/‘ [09:48:13] when wikibugs cut at revi...(ew) :-p [09:48:14] revi huh? :D [09:48:45] Oh hahahaha :D [09:48:59] Here you go, thanks revi... :P [09:49:08] haha [09:53:57] (03PS1) 10Amire80: Add HEBREW POINT METEG to the Hebrew special characters [core] - 10https://gerrit.wikimedia.org/r/399151 [10:01:15] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Could not load image - https://phabricator.wikimedia.org/T183217#3847417 (10Aklapper) 05Open>03stalled Hi @rantemario, thanks for taking the time to report this! If you click on the first link directly, can you access the image and is the image display... [10:05:29] (03CR) 10Cparle: [C: 032] Look at 3D objects from another angle [extensions/3D] - 10https://gerrit.wikimedia.org/r/398461 (https://phabricator.wikimedia.org/T179887) (owner: 10Matthias Mullie) [10:07:13] (03Merged) 10jenkins-bot: Look at 3D objects from another angle [extensions/3D] - 10https://gerrit.wikimedia.org/r/398461 (https://phabricator.wikimedia.org/T179887) (owner: 10Matthias Mullie) [10:08:01] 10Phabricator, 10Developer-Relations: Find best way to allow CoC committee to temporarily disable Phab user accounts - https://phabricator.wikimedia.org/T183116#3847422 (10Aklapper) Hmm, indeed maybe the actual underlying question to solve is "how to contact Phab admins in a private way". [10:11:44] 10MediaWiki-extensions-Newsletter: Special:Newsletter/id/subsribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3847425 (10Aklapper) @01tonythomas: I guess this could be a good #GCI-2017 task if someone mentors? :) [10:12:03] 10MediaWiki-jQuery-Tablesorter, 10CSS: Printable issue - https://phabricator.wikimedia.org/T183127#3847427 (10TheDJ) [10:12:08] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Get a place to arrange start hack - https://phabricator.wikimedia.org/T183225#3847428 (10Ainali) [10:12:13] 10MediaWiki-extensions-Newsletter: Special:Newsletter/id/subsribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3847439 (1001tonythomas) Yes yes. I can mentor. Lets make this happen. [10:12:31] 10MediaWiki-extensions-Quiz, 10Google-Code-in-2017: Quiz QuestionTest::testParseCategories tests are failing - https://phabricator.wikimedia.org/T182552#3847442 (10Aklapper) Anyone willing to mentor in #GCI2017? :) [10:12:39] 10MediaWiki-extensions-Quiz, 10Google-Code-in-2017, 10Wikimedia-log-errors: Question.php undefined variables - https://phabricator.wikimedia.org/T182940#3847444 (10Aklapper) Anyone willing to mentor in #GCI2017? :) [10:12:56] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subsribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3847446 (10Aklapper) [10:14:13] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subsribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3846233 (10divadsn) The question here is how are you supposed to manually remove the subscriber, by executing it in MySQL? [10:15:10] 10OOjs-UI, 10Browser-Support-Apple-Safari: BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar when system is set to always show scrollbars - https://phabricator.wikimedia.org/T158610#3847462 (10Elitre) >>! In T158610#3041920, @matmarex wrote: > I think OS X doesn't normally display scr... [10:15:41] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Arrange start hack for 3D2Commons - https://phabricator.wikimedia.org/T183227#3847463 (10Ainali) [10:16:12] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Get a place to arrange start hack - https://phabricator.wikimedia.org/T183225#3847475 (10Ainali) [10:16:37] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Language filters use 'All' as language code - https://phabricator.wikimedia.org/T182947#3847479 (10Pginer-WMF) I don't think we should expose users with an artificial language code to represents all languages. Using the translated version of... [10:16:39] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Arrange start hack for 3D2Commons - https://phabricator.wikimedia.org/T183227#3847463 (10Ainali) [10:16:41] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Get a place to arrange start hack - https://phabricator.wikimedia.org/T183225#3847428 (10Ainali) [10:18:03] 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: Misaligned table lines - https://phabricator.wikimedia.org/T183124#3844084 (10TheDJ) I wonder if maybe you have your browser window zoomed in (or out). You can reset this zoom, by choosing CTRL+ 0 in Microsoft browsers. Zooming i... [10:19:23] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555#3847489 (10Aklapper) [10:21:37] 10EasyTimeline, 10Easy, 10Google-Code-in-2017: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3847493 (10Aklapper) [10:26:40] 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Move namespaced extensions to use PSR-4 autoloading - https://phabricator.wikimedia.org/T182943#3847496 (10Aklapper) [10:26:55] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Language filters use 'All' as language code - https://phabricator.wikimedia.org/T182947#3839479 (10Amire80) >>! In T182947#3845184, @Petar.petkovic wrote: >>>! In T182947#3843655, @santhosh wrote: >> Note that the label "All" will be translat... [10:27:08] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Get a place to arrange start hack - https://phabricator.wikimedia.org/T183225#3847499 (10AxelPettersson_WMSE) Proposal sent to [[ https://www.goto10.se | GOTO10 ]] for a hackday 2018-01-12, 10-17. Waiting for approval. [10:28:47] 10MediaWiki-General-or-Unknown, 10CSS: Anchor problem - https://phabricator.wikimedia.org/T183122#3847502 (10TheDJ) 05Open>03Invalid No. It's inconsistent, because its a browser and not some sort desktop publishing format. Website technology is 'sloppy' like that. You won't believe how much trouble it take... [10:30:30] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Arrange start hack for 3D2Commons - https://phabricator.wikimedia.org/T183227#3847517 (10Ainali) [10:32:13] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3847526 (10Aklapper) [10:34:55] 10MediaWiki-jQuery-Tablesorter, 10CSS: Printable issue - https://phabricator.wikimedia.org/T183127#3847530 (10TheDJ) printonly is a English Wikipedia specific classname and not part of MediaWiki or Wikimedia in general. It's use is limited to citations (and has been ever since it was added in 2008). The docume... [10:37:39] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Arrange start hack for 3D2Commons - https://phabricator.wikimedia.org/T183227#3847542 (10AxelPettersson_WMSE) Invitation to Makerspace? [10:39:49] (03PS2) 10DCausse: Use the INDEX_NAME constant in all the places. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [10:41:15] 10Design, 10Page-Previews, 10Readers-Web-Backlog (Design): Hovercard could show an extract from the id downward when #IDname links are used - https://phabricator.wikimedia.org/T102280#3847549 (10SMcCandlish) [10:41:31] 10Technical-Collaboration-Guidance, 10Community-Liaisons (Oct-Dec 2017), 10Goal: Goal: Best practices of collaboration between product development teams and communities agreed and ready for adoption - https://phabricator.wikimedia.org/T176462#3847550 (10Qgil) a:05Keegan>03Elitre [10:41:55] 10EasyTimeline, 10Easy, 10Google-Code-in-2017: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3847552 (10Aklapper) Looking at other MediaWiki extensions using `
`, I see stuff like `$this->getOutput()->wrapWikiMsg( '
(03PS3) 10DCausse: Use the INDEX_NAME constant in all the places. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [10:42:36] (03PS1) 10Daniel Kinzler: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 [10:42:55] (03CR) 10jerkins-bot: [V: 04-1] Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [10:45:56] 10monitoring, 10Graphite, 10Performance-Team (Radar): Upgrade graphite from 0.9.x to 1.x - https://phabricator.wikimedia.org/T166173#3287449 (10fgiunchedi) graphite 1.1.0 now released as well https://graphite.readthedocs.io/en/latest/releases/1_1_0.html [10:57:37] (03CR) 10Ladsgroup: [C: 032] Unify SVG markup [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399133 (https://phabricator.wikimedia.org/T178867) (owner: 10VolkerE) [11:00:01] 10MediaWiki-Database: Improve how Mediawiki handles a DB host that is flaky rather than completely down - https://phabricator.wikimedia.org/T70062#3847570 (10jcrespo) [11:00:19] 10MediaWiki-extensions-Translate: Do not show source as 'Proofreading' - https://phabricator.wikimedia.org/T183230#3847571 (10MarcoAurelio) [11:01:03] 10MediaWiki-extensions-Translate: Do not show source as 'Proofreading' - https://phabricator.wikimedia.org/T183230#3847583 (10MarcoAurelio) [11:01:06] 10MediaWiki-extensions-Translate, 10Easy, 10User-MarcoAurelio: Status "proofreading" does not make sense for the source language in Special:(Language|MessageGroup)Stats - https://phabricator.wikimedia.org/T160511#3847585 (10MarcoAurelio) [11:01:42] (03Merged) 10jenkins-bot: Unify SVG markup [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399133 (https://phabricator.wikimedia.org/T178867) (owner: 10VolkerE) [11:02:09] 10MediaWiki-extensions-Translate, 10Easy, 10User-MarcoAurelio: Status "proofreading" does not make sense for the source language in Special:(Language|MessageGroup)Stats - https://phabricator.wikimedia.org/T160511#3101432 (10MarcoAurelio) Is this really #easy? [11:13:30] 10Design, 10Page-Previews, 10Readers-Web-Backlog (Design): Hovercard could show an extract from the id downward when #IDname links are used - https://phabricator.wikimedia.org/T102280#3847596 (10SMcCandlish) This is not an "edge case", it's how millions of links are done, and the hovercards can be at least f... [11:19:42] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3847603 (10Ainali) [11:19:56] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3847615 (10Ainali) [11:21:38] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3847603 (10Ainali) [11:22:49] 10MediaWiki-Page-editing, 10MediaWiki-extensions-WikibaseRepository, 10Community-Liaisons, 10Contributors-Team, and 5 others: Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org - https://phabricator.wikimedia.org/T161367#3847624 (10Elitre) >>! In T161367#3846794,... [11:24:25] (03CR) 10Florianschmidtwelzow: [C: 032] Add help link to special pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399150 (https://phabricator.wikimedia.org/T180980) (owner: 10Divadsn) [11:26:13] (03Merged) 10jenkins-bot: Add help link to special pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399150 (https://phabricator.wikimedia.org/T180980) (owner: 10Divadsn) [11:30:51] 10EasyTimeline, 10Easy, 10Google-Code-in-2017: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3839967 (10divadsn) >>! In T182968#3847552, @Aklapper wrote: > the student will have to thoroughly test the output! No problem, can you give me plea... [11:30:56] 10EasyTimeline, 10Easy, 10Google-Code-in-2017: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3847646 (10divadsn) a:03divadsn [11:31:51] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 3 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3847649 (10Florian) @Phantom42 That sounds good, too. That's a simple change, too, would you like to do that in your change in... [11:33:03] 10EasyTimeline, 10Easy, 10Google-Code-in-2017: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3847650 (10divadsn) According to this page (https://www.w3schools.com/tags/tag_tt.asp) the `tt` tag can be replaced with `samp` for computer output,... [11:34:03] 10MediaWiki-Configuration, 10Operations, 10discovery-system: [DRAFT] Use EtcdConfig in production to allow automation of a datacenter switch - https://phabricator.wikimedia.org/T182597#3847651 (10Volans) p:05Triage>03Normal [11:36:37] 10WMSE-This-is-My-Area-2016 (Wikiversity-portal): Instructions for chosing article - https://phabricator.wikimedia.org/T183233#3847661 (10SaraMortsell) [11:37:08] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Apart from the position of the code, it looks good already. Let's get this finished! :)" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [11:39:10] (03CR) 10Petar.petkovic: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/389648 (owner: 10Petar.petkovic) [11:50:53] (03CR) 10Esanders: [C: 04-1] "The problem appears to be that you are calling #focus immediately after #activate in ReplyWidget (and possibly elsewhere), but #activate i" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [11:51:17] (03CR) 10Florianschmidtwelzow: Add issue count column to Special:Newsletters (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) (owner: 10Pppery) [11:51:37] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), 10Patch-For-Review, 10User-Daniel: [Tracking] Fine-grained change notifications based on tracking from Lua getters via __index - https://phabricator.wikimedia.org/T172914#3847706 (10WMDE-lesz... [11:53:12] (03CR) 10Sbisson: "This introduced a regression in RCL: it made the target page and to/from parameters non-sticky again." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/395901 (owner: 10Mooeypoo) [11:54:43] 10UI-Standardization, 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3847710 (10Esanders) From discussion on the changeset, we are going with 13px. It should be basically indistinguishable from 13.3333px, and avoids rounding errors further down the chain. [11:56:06] (03CR) 10Esanders: "The idea is to ensure that the default across all skins is precisely 13px. Some of the problems we've had with the syntax highlight overla" [core] - 10https://gerrit.wikimedia.org/r/396005 (https://phabricator.wikimedia.org/T181324) (owner: 10Esanders) [11:56:36] (03PS4) 10Esanders: Standardize editfont size across browsers/OSes [core] - 10https://gerrit.wikimedia.org/r/396005 (https://phabricator.wikimedia.org/T181324) [11:57:37] 10UI-Standardization, 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3847711 (10Esanders) [11:58:52] (03PS3) 10Thiemo Kreuz (WMDE): Replace class_exists with proper extension registration checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/398794 (https://phabricator.wikimedia.org/T183096) [11:59:17] (03CR) 10Thiemo Kreuz (WMDE): Replace class_exists with proper extension registration checks (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/398794 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [12:00:33] (03CR) 10Esanders: [C: 031] Respect "Always use VE" and "Always use source editor" preferences (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394405 (https://phabricator.wikimedia.org/T178719) (owner: 10Catrope) [12:03:19] (03CR) 10Esanders: [C: 031] "yay" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398682 (owner: 10Catrope) [12:04:04] (03PS1) 10Sbisson: RCLFilters: make target and to/from parameters sticky again [core] - 10https://gerrit.wikimedia.org/r/399165 [12:04:25] (03CR) 10Esanders: [C: 031] Use new editor instead of old editor for undoing topic summary edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/398680 (owner: 10Catrope) [12:06:06] (03CR) 10Esanders: [C: 032] Require indentation of CASE statements in PHP code [core] - 10https://gerrit.wikimedia.org/r/397216 (https://phabricator.wikimedia.org/T182546) (owner: 10Huji) [12:14:52] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Language filters use 'All' as language code - https://phabricator.wikimedia.org/T182947#3847733 (10Petar.petkovic) >>! In T182947#3847479, @Pginer-WMF wrote: > For small screens it is ok if the text gets cropped with ellipsis if it becomes to... [12:15:09] 10ContentTranslation, 10Language-2017-Oct-Dec: dashboard: box-shadow between recently edited and suggestions - https://phabricator.wikimedia.org/T182193#3847734 (10Petar.petkovic) a:03Petar.petkovic [12:17:23] 10ContentTranslation, 10Language-2017-Oct-Dec: Dashboard: box-shadow visible between "New translation" dialog and suggestion/translation lists - https://phabricator.wikimedia.org/T182193#3847735 (10Petar.petkovic) [12:18:56] 10Accessibility, 10Design, 10UI-Standardization, 10ContentTranslation, and 4 others: CX source selector has no focus state - https://phabricator.wikimedia.org/T177402#3847737 (10Petar.petkovic) a:05Petar.petkovic>03Esanders [12:20:41] (03PS1) 10Thiemo Kreuz (WMDE): Enable Squiz.WhiteSpace.FunctionSpacing sniff and fix violations [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399166 [12:21:10] 10Design, 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Inline the 'discard translation' button - https://phabricator.wikimedia.org/T179248#3718189 (10Petar.petkovic) [12:22:02] (03Merged) 10jenkins-bot: Require indentation of CASE statements in PHP code [core] - 10https://gerrit.wikimedia.org/r/397216 (https://phabricator.wikimedia.org/T182546) (owner: 10Huji) [12:27:53] (03CR) 10Catrope: "I thought I had fixed this! Turns out it was because I did fix it in my rebase in PS2, but PS3 undid this rebase, and the re-rebase in PS4" [core] - 10https://gerrit.wikimedia.org/r/395901 (owner: 10Mooeypoo) [12:27:55] (03PS2) 10Daniel Kinzler: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 [12:28:01] (03CR) 10Catrope: [C: 032] RCLFilters: make target and to/from parameters sticky again [core] - 10https://gerrit.wikimedia.org/r/399165 (owner: 10Sbisson) [12:29:26] (03CR) 10Catrope: [C: 032] Add HEBREW POINT METEG to the Hebrew special characters [core] - 10https://gerrit.wikimedia.org/r/399151 (owner: 10Amire80) [12:29:29] RoanKattouw: hey! I see you are active... can you merge this revert, once it passes tests? https://gerrit.wikimedia.org/r/#/c/399156/2 [12:29:58] Sure [12:31:14] (03CR) 10jenkins-bot: Require indentation of CASE statements in PHP code [core] - 10https://gerrit.wikimedia.org/r/397216 (https://phabricator.wikimedia.org/T182546) (owner: 10Huji) [12:32:59] (03CR) 10Catrope: [C: 032] Remove duplicate editfont size definition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/397570 (owner: 10Esanders) [12:33:23] (03CR) 10WMDE-Fisch: [C: 031] "Nice, works as expected. I now can change the threshold in the LocalSettings.php e.g. by doing" (031 comment) [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/398094 (https://phabricator.wikimedia.org/T181404) (owner: 10Jkroll) [12:33:48] RoanKattouw: thanks. I'm a bit depressed about this. But with a change like this, I suppose issues were to be expected :) I just hoped they would be less arcane... [12:34:01] You chose a good time though, no deployment train for a few weeks [12:34:24] yes, that was indeed intentional [12:34:49] (03PS3) 10Addshore: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [12:35:00] (03Merged) 10jenkins-bot: RCLFilters: make target and to/from parameters sticky again [core] - 10https://gerrit.wikimedia.org/r/399165 (owner: 10Sbisson) [12:35:22] (03CR) 10Addshore: [C: 032] Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [12:35:32] Hellooo [12:35:54] (03PS4) 10Addshore: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [12:36:09] (03PS1) 10Zfilipin: Fix location of LocalSettings.php [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399168 (https://phabricator.wikimedia.org/T177262) [12:36:13] RoanKattouw: Aaron tried to help with investigating the chronology issue yesterday, but didn't get anywhere, it seems. That stuff is a bit esoterik to me... do you have an idea how to investigate? Basically, new revisions fail to load seconds after an edit. it *looks* like the page table is out iof sync with the revision table. But nobody knows how that can be. [12:36:40] ah, addshore merged the revert [12:36:50] I'll file a revert of the revert in a minute [12:36:54] not yet, just fixing the commit message [12:37:00] but gerrit has died for me [12:37:17] wffm [12:37:18] RoanKattouw: yes, the christmas time for merging and getting it on beta was the plan :) [12:37:41] addshore: we failed to consider that christmas is a bad time to get people to investigate arcane issues, though :) [12:37:47] aaron is gone for the holidays, i guess [12:37:49] indeed [12:38:08] i was expecting issues, but i was hoping they would be a bit more clear cut... [12:38:52] (03PS5) 10Addshore: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [12:39:01] haha yeah that's a problem [12:39:02] (03CR) 10Gilles: [C: 032] Smarter Varnish slow log [vagrant] - 10https://gerrit.wikimedia.org/r/395076 (https://phabricator.wikimedia.org/T181315) (owner: 10Gilles) [12:39:15] I don't know much about the chronology stuff so I don't really know how to investigate it [12:39:19] (03PS1) 10Thiemo Kreuz (WMDE): Fix all kinds of type safety warnings accross the code base [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399169 [12:39:41] I looked into it a bit the other day while investigating wikidata slowness, havn't had a chance to look at our issue yet though [12:39:45] (03CR) 10Daniel Kinzler: "This was the correct fix, thank you." [core] - 10https://gerrit.wikimedia.org/r/399132 (owner: 10Legoktm) [12:39:53] I guess you could try to figure out what the state of the DB is that the broken requests see (revision table entry referring to a nonexistent page table entry? or the reverse?) and try to figure out if the order of insertions might possibly be wrong [12:39:54] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847763 (10zeljkofilipin) I have tried running Selenium tests in Node.js for repositories that have them. Core is OK. ``` cd mediawiki npm i npm run selenium > @ selenium /Users/z/Documents/... [12:40:21] DanielK_WMDE: Just finished fixing the commit message issues, anything else we need to add to that revert? [12:40:34] RoanKattouw: no, thje page table references a revision that then fails to load (it may or may not be in the db, we don't know) [12:40:54] addshore: i don't think so [12:41:15] Hmm that's weird [12:41:31] One thing I wonder is how the page table row was able to be written then [12:41:41] Because you don't know the revision ID until after you've written the revision row [12:41:53] hmm, beta db is currently locked? [12:42:06] (03CR) 10jerkins-bot: [V: 04-1] Fix location of LocalSettings.php [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399168 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [12:42:08] Have you isolated a broken case? Do broken cases stay broken for a long-ish period of time, or only briefly? [12:42:21] RoanKattouw: I was about to say you can try it on beta, but the db is locked [12:42:21] Zppix helloooo [12:42:26] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847765 (10zeljkofilipin) Popups is OK. ``` vagrant roles enable popups vagrant provision echo 'include_once "$IP/extensions/Popups/tests/selenium/LocalSettings.php";' >> LocalSettings.php np... [12:42:34] RoanKattouw: it does get written. the revision is found once replicas catch up. it just fails to load right after the edit. [12:42:34] it happened in 100% of the cases when testing on beta, I tried about 10 times [12:43:22] (03Merged) 10jenkins-bot: Smarter Varnish slow log [vagrant] - 10https://gerrit.wikimedia.org/r/395076 (https://phabricator.wikimedia.org/T181315) (owner: 10Gilles) [12:43:23] RoanKattouw: while investigating, aaron found that replication weas broken on beta. we firt thought that that was all there was to it. but fixing replication didn't fix the issue. it's all a bit... obscure [12:44:29] RoanKattouw: to replicate, just edit. you get redirected to the "plain" url, and get an error (revision not found). you reload, and it works fine. [12:44:44] (03Merged) 10jenkins-bot: Add HEBREW POINT METEG to the Hebrew special characters [core] - 10https://gerrit.wikimedia.org/r/399151 (owner: 10Amire80) [12:44:46] (03CR) 10Zfilipin: "recheck" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399168 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [12:45:02] RoanKattouw, addshore: the relevant code in Article pre-fills the page with that error message. so that's the error you'll see if *anything* goes wrong. which means we don't actually know what goes wrong. [12:45:26] (03CR) 10jenkins-bot: Smarter Varnish slow log [vagrant] - 10https://gerrit.wikimedia.org/r/395076 (https://phabricator.wikimedia.org/T181315) (owner: 10Gilles) [12:46:13] divadsn: how are you? [12:46:19] DanielK_WMDE: I dont think the beta replication issue is fixed [12:46:19] "The database has been automatically locked while the replica database servers catch up to the master." [12:46:50] "You reload, and it works fine" --> so it's not a long-lasting issue, it's brief [12:46:55] That makes investigating it harder [12:46:56] (03PS1) 10Zfilipin: Fix location of LocalSettings.php [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/399170 (https://phabricator.wikimedia.org/T164024) [12:47:32] (03PS1) 10Divadsn: Replace deprecated tt tags with samp tag [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) [12:47:34] RoanKattouw: indeed. and MAYBE it's actually an issue with replication on beta, not with the code, as addshore just said... [12:47:39] addshore: Hmm if replication is *completely* broken, then maybe that explains it, but I feel like this should be working even when replication is broken (or at least when it's very slow) [12:47:45] 10MediaWiki-Page-editing, 10Parsoid, 10VisualEditor, 10User-Ryasmeen: Editing an invalid wikitext table with VE triggers "your revision matches the latest version of this page", does not save changes - https://phabricator.wikimedia.org/T123083#3847783 (10Deskana) [12:47:51] (03CR) 10jenkins-bot: RCLFilters: make target and to/from parameters sticky again [core] - 10https://gerrit.wikimedia.org/r/399165 (owner: 10Sbisson) [12:47:52] Well, let's see if the revert fixes it [12:47:57] https://deployment.wikimedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo&siprop=dbrepllag&sishowalldb= is the same as when arron looked yesterday [12:48:03] If it does, then your code is doing at least something wrong [12:48:06] wtf is up with beta [12:48:15] RoanKattouw: that indeed is a meaningful experiment :) [12:48:41] (03PS2) 10Divadsn: Replace deprecated tt tags with samp tag [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) [12:48:51] addshore: Hmm at that URL I see 0 lag right now [12:49:07] RoanKattouw: try creating a page though, it says the db is locked due to lag [12:49:38] I see [12:49:57] Very strange [12:50:30] The DB does appear to be read-only [12:50:35] Marking notifications as read doesn't stick [12:51:06] Would jenkins doing a scap cause that? [12:51:15] Zppix: the locking? no [12:51:22] RoanKattouw: maybe it's r/o for a reason that has nothing to do with replag? [12:51:23] No, something weird is going on [12:51:36] I checked $wgReadOnly and it's false, so that isn't it [12:51:43] DanielK_WMDE: when editing though the reason it shows says it is due to replag [12:51:44] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847786 (10zeljkofilipin) RelatedArticles is OK ``` vagrant roles reset vagrant roles enable mobilefrontend relatedarticles vagrant provision echo 'include_once "$IP/extensions/RelatedArticles/... [12:51:52] wfReadOnly() returns true, so let's see why [12:51:55] addshore: wtf? [12:52:07] https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/lastFailedBuild/console [12:52:26] Wikimedia\\Rdbms\\DBReplicationWaitError from line 369 of /srv/mediawiki-staging/php-master/includes/libs/rdbms/lbfactory/LBFactory.php: Could not wait for replica DBs to catch up to deployment-db03 [12:53:02] first failure is Build #22122 (18-Dec-2017 19:20:00) [12:53:58] Hello! [12:55:47] OK I can confirm that replication is broken on deployment-db04 [12:55:58] RoanKattouw: any idea how we can fix that? [12:56:08] https://www.irccloud.com/pastebin/tREOTlIr/ [12:56:35] (03CR) 10jenkins-bot: Add HEBREW POINT METEG to the Hebrew special characters [core] - 10https://gerrit.wikimedia.org/r/399151 (owner: 10Amire80) [12:56:53] ooooooh, well, it has things to do with externalstore and revisions / old text, could be related too the patch [12:56:58] addshore: I know like 1/3 of the theory and I haven't done it before [12:57:02] Hi Albert221 [12:57:13] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847788 (10zeljkofilipin) [12:57:26] Yeah the error that broke replication is a primary key collision in the text table, I hadn't realized that that could be related to MCR but you're right [12:57:42] The query itself specifies NULL as the old_id so that should have been fine [12:57:42] (If the extra chatter from me talking to students is distracting just tell me to shut up guys) [12:57:55] That actually could be a very big hint as to what is wrong [12:58:27] patch got merged, code started being run, replication broke, lag wasn't bad enough to cause a db lock for a while though, we keep seeing the same issue, and eventually the db locks up [12:58:52] If replication breaks completely, it should only take 5 minutes for the lag to shut everything down [12:59:03] At most; I'm not sure if MW detects this broken state specially and goes r/o immediately [12:59:28] But obviously if replication is broken but lag measurements still work, the lag will increase at a rate of 1 second per second, and the 300s lag threshold will be hit pretty quickly [13:00:07] (03PS3) 10Dvogel hallowelt: new sources [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/398477 [13:00:21] OK so I've looked at the text table on deployment-db04 which interestingly has IDs going all the way up to 20982, and has the auto_increment value correctly set to 20983 [13:00:24] So it doesn't look broken [13:00:28] Now going to look at that table on the master [13:01:18] Whoa, wtf [13:01:24] The text table on the master has FEWER entries [13:01:33] interesting....... urm :P [13:01:42] The highest old_id on the master is 20972 [13:01:52] Interesting.... [13:02:09] 10 entries less [13:02:31] and 10 edits have been made on deployment wiki since the code landed [13:02:38] OK something weird happened [13:02:48] The master and slave disagree on some rows: [13:03:07] Master: [13:03:08] https://www.irccloud.com/pastebin/mJeq37Zx/ [13:03:18] Slave: [13:03:22] https://www.irccloud.com/pastebin/sRtUJazL/ [13:03:33] RoanKattouw: it'S possible that my patch broke that. I tried to keep that logic untouched while moving it to a different class, but it's possible I broke that. [13:03:49] But it's also very possible that it's completely unrelated. I sure hope it is :) [13:03:58] Any idea whether the difference between nativeDataArray and utf-8 is related to your patch? [13:04:18] we defintly touched that area, so most likely [13:04:21] Also note that there is perfect non-overlap here [13:04:32] right, revert time it is [13:04:39] (03CR) 10Addshore: [C: 032] Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [13:04:45] The master and replica agree on everything up to oldid 20970 which has text address 8211 [13:05:02] What is oldid 20970? [13:05:08] RoanKattouw: nativeDataArray? What is that? Never heard of it. I moved the code that handles these flags. If the logic changed in the meantime, it's possible i accidentally reverted that, in an inconsistent way [13:05:12] Then the replica picked up 8212-8217, 8219-8223 and 8225 [13:05:16] Perhaps we could get a timeline? [13:05:22] And the master picked up 8218 and 8224 [13:05:30] RoanKattouw: what's the timestamp of that revision? [13:05:37] Which one, 20970? [13:05:41] The last one they agree on? [13:05:43] The patch was merged yesterday... I think around this time of day [13:05:59] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847799 (10zeljkofilipin) Problems enabling cirrussearch role. {P6484} [13:06:22] RoanKattouw: merged yesterday at 16:10 CET. [13:06:43] There is no row in the revision table with either rev_id=20970 or rev_text_id=20970 [13:06:45] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3847800 (10Kaartic) >>! In T182197#3844780, @bmansurov wrote: > @Kaartic thanks for the info.... [13:07:41] Merged @ Dec 18 15:10 PM UTC [13:07:52] Wait, on the MASTER there isn't, on the replica there is [13:08:00] ...what?! [13:08:02] The DBs also disagree on what's in the revision table [13:08:22] The 15 most recent revision table entries on the master: [13:08:24] 15:18 it is on the beta clster and scap has run [13:08:24] https://www.irccloud.com/pastebin/lnRPQI4Z/ [13:08:25] that sounds fubar... [13:08:28] And on the replica: [13:08:37] https://www.irccloud.com/pastebin/r7AxQfDT/ [13:08:57] 15:19 I have already spotted the issue https://usercontent.irccloud-cdn.com/file/Mc9x8ROA/image.png [13:09:08] that will be the first edit made with the new code [13:09:44] Oh wait that's not a disagreement, my bad [13:09:49] RoanKattouw: what is up with rev 7934 where does it appear & look like? [13:10:05] RoanKattouw: nativeDataArray seems to be an AbuseFilter thing. Poor man's content model from many years ago, it seems [13:10:13] There are strange gaps in the rev_id sequence, but the only real difference is the existence of rev_id 7944 on the master which seems reasonable [13:10:15] Aah OK [13:10:16] I didn't touch that. should still work as before. [13:10:26] Right and the query that broke replication had an AbuseFilter method in its comment [13:10:36] \O/ [13:10:42] | 7934 | 20972 | 20171218152013 | [13:10:50] Right [13:10:52] The two DBs agree on that [13:10:55] (03Merged) 10jenkins-bot: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [13:10:59] I wish i understood enough to help :( [13:11:00] Buuut.... that actually may indicate an issue with my patch. Maybe AbuseFilter is relying on internals that i now changed [13:11:06] maybe I broke compat with AF [13:11:07] That is actually exactly the same rev_text_id as in the replication error! [13:11:07] DanielK_WMDE: indeed [13:11:22] Last_SQL_Error: Error 'Duplicate entry '20972' for key 'PRIMARY'' on query. Default database: 'deploymentwiki'. Query: 'INSERT /* AbuseFilter::storeVarDump */ INTO `text` (old_id,old_text,old_flags) VALUES (NULL,'DB://cluster1/8224','nativeDataArray,gzip,external')' [13:11:30] RoanKattouw: right, and I believe that is the first time i spotted the issue / the first edit i made after the code landed [13:11:48] Welll... [13:11:48] 15:19, 18 December 2017 Addshore (talk | contribs | block) deleted page TXTTN (view/restore) [13:12:01] (diff | hist) . . N TXTTN‎; 15:20 . . (+7)‎ . . ‎Addshore (talk | contribs | block)‎ (Created page with "slakfa;") [13:12:01] the timestamp matches [13:12:26] addshore: Oh you deleted stuff, that could explain the rev_id gap [13:12:26] addshore: but why is there an edit by abusefilter?... you didn't edit a filter, did you? [13:12:27] and that rev i created at 15:20 is https://deployment.wikimedia.beta.wmflabs.org/w/index.php?title=TXTTN&oldid=7934 [13:12:53] * DanielK_WMDE feels an abuse filter rewrite coming on [13:13:04] RoanKattouw: yes, although in the UI i cant see what i deleted, or what timestamp or revid as the db is locked https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:Undelete/TXTTN [13:13:22] I have it [13:13:30] https://www.irccloud.com/pastebin/Lh4gkYeA/ [13:13:36] It helps that it was the most recently deleted thing [13:14:29] so, what was broken? AF or deletion? [13:14:31] so i created a page, and it worked, iu deleted it, it wokred, i recreated it and started seeing the issue [13:14:45] and that was due to abusefilter exploding during the first creation or deletion? [13:14:47] how can *any* of this break replication, btw? [13:15:16] addshore: why would abuse filter write revisions? [13:15:22] unless youedit a filter? [13:15:24] DanielK_WMDE: no idea [13:15:31] So, "nativeDataArray" is ONLY used in AbuseFilter [13:15:32] maybe someone else was editing a filter? [13:15:49] (and maybe this is a red herring)? [13:16:00] https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/includes/AbuseFilter.class.php#L1286 [13:16:45] *scrolls up to look at the flag mess we already discovered* [13:17:12] (03PS1) 10Daniel Kinzler: Deprecate and gut Revision class [DNM]. [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) [13:17:16] Hello everybody! [13:17:37] 20970 has no nativeDataArray flag on either slave or master, 20971 and 20972 have it on master but not on the slave [13:17:43] addshore: can you find the user & commit message associated with the nativeArrayData entries? [13:17:51] Phantom42: hello! [13:18:37] (03CR) 10Amritsreekumar: "Please do improve the commit message to something like "Replaced tag with as it has been deprecated with the migration to HTML" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [13:19:23] (03PS2) 10Daniel Kinzler: Deprecate and gut Revision class [DNM]. [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) [13:20:12] Yeah old_id 20972 points to completely different things on the master and the replica [13:20:20] Different flags but also different external store addresses [13:20:29] how the hell does that happen? [13:20:34] No idea [13:20:46] its almost like some code is somehow manging to write to the slave... [13:20:47] I'm digging though the binlogs right now trying to find out what other queries were run on the tex ttable [13:20:53] So far I've only found the one that killed replication [13:21:00] Hmm yeah maybe [13:21:12] it looks like abusefilter stuff manage to write to master only [13:21:19] I thought that maybe the master and replica had switched roles, but maybe the replica is writeable when it shouldn't be? That would break replication pretty quickly too [13:21:22] addshore: oooohhhh.... what would happen if you tried that? it should fail HARD! But does it? [13:21:44] DanielK_WMDE: I would have thought it would fail really hard, but perhaps not?> [13:21:46] RoanKattouw: maybe aaron switched them yesterday when trying to fix things? [13:21:49] (03CR) 10jenkins-bot: Revert "[MCR] Turn Revision into a proxy to new code." [core] - 10https://gerrit.wikimedia.org/r/399156 (owner: 10Daniel Kinzler) [13:21:56] Have you guys tried writing to the replicas directly? [13:22:01] That's possible [13:22:09] It should fail no? [13:22:10] I'll check if the replica is read-only [13:22:39] Welp, the replica is not read-only [13:23:11] Hmmm [13:23:16] That cant be good [13:23:33] (03PS3) 10Daniel Kinzler: MCR: Deprecate and gut Revision class [DNM] [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) [13:23:40] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 3 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3847827 (10Phantom42) @Florian yes, of course, I will add it now. I am also wondering if we should add `ext-curl` to Elastica... [13:23:41] so, what is the first insert / update / delete we see on the replica that is not on the master? [13:23:44] (if there is one) ? [13:24:12] I'm trying to figure that out now [13:25:09] The master's binlog file is 489MB [13:25:12] I'll filter out messages out of this IRC channel and dump the chat log somewhere nice to look at once we have finished here, I think this is all rather valuable info we don't want to have to go hunting for agian [13:25:24] So analyzing it is a bit slow [13:26:24] I'll look into making unit tests use a r/o wrapper for the DB REPLICA connection. That may not be easy, though [13:27:31] Hello everyone. I am Geet Asati, a pre high school student from Bhopal, India, participating in Google Code-in. I know a bit of Java programming language taught in my school studies, and I am new to open source. I really find wikipedia interesting, hence thought to contribute to wikimedia as my Google Codein tasks. [13:27:49] geetasati: Welcome! Good luck with your GCI tasks! [13:28:40] RoanKattouw, addshore: shall we move to #wikimedia-tech so we don't interfere with GCI? [13:28:45] Sure [13:28:47] sure [13:28:53] (why is GCI here where all the bot traffic is?) [13:28:54] geetasati: welcome [13:29:02] DanielK_WMDE: blame devrel [13:29:10] hmhm [13:29:31] DanielK_WMDE: im slightly joking just fyi [13:30:10] I'm German. Vee don't do jokes. [13:30:28] DanielK_WMDE: ja [13:30:35] 10Timeless, 10WMSE-Bug-Reporting-and-Translation-2017: Empty space above TOC - https://phabricator.wikimedia.org/T183240#3847843 (10Sebastian_Berlin-WMSE) [13:30:36] NEIN! [13:30:42] DanielK_WMDE: lol [13:31:19] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Currency selector dropdown: arrow overlaps last letter - https://phabricator.wikimedia.org/T181435#3847852 (10Pcoombe) 05Open>03Resolved [13:36:03] 10MediaWiki-extensions-WikibaseRepository, 10MediaWiki-extensions-WikibaseView, 10Wikidata, 10Patch-For-Review, and 4 others: References sections are not expanded anymore when viewing diffs - https://phabricator.wikimedia.org/T129836#3847856 (10thiemowmde) [13:40:54] (03PS4) 10Daniel Kinzler: MCR: Deprecate and gut Revision class [DNM] [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) [13:41:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Regression, 10User-thiemowmde: Can't see references on historic revisions of items on Wikidata - https://phabricator.wikimedia.org/T182767#3847882 (10thiemowmde) [13:41:51] reminds me of the ja-nein-halt algorithm for solving some kind of mathematical problem I was taught in the school [13:42:35] Lol [13:42:36] 10MediaWiki-Database: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3847885 (10Catrope) [13:43:26] I can't remember what exactly it was used for [13:44:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Regression, 10User-thiemowmde: Can't see references on historic revisions of items on Wikidata - https://phabricator.wikimedia.org/T182767#3847897 (10thiemowmde) I just realized this is exactly the same as T129836. I assume the issue came back becaus... [13:46:15] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3847913 (10daniel) p:05Triage>03High a:03daniel [13:47:15] Ich studiere Deutch in die Schule, aber ich spreche es nicht gut :) [13:47:29] (03CR) 10DCausse: [C: 032] "thanks!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [13:48:54] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection optianed with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3847918 (10daniel) p:05Triage>03Normal [13:48:55] ah my friend remembered it was about solving a differential equation [13:50:17] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, 10German-Community-Wishlist, and 4 others: Make change detection threshold configurable from php - https://phabricator.wikimedia.org/T181404#3847933 (10WMDE-Fisch) > Change 398094 had a related patch set uploaded (by Jkroll; owner: Jkroll): I tried tha... [13:55:41] (03Merged) 10jenkins-bot: Use the INDEX_NAME constant in all the places. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399128 (owner: 10Jonathanischoice) [13:57:45] (03CR) 10Phuedx: [C: 032] Fix location of LocalSettings.php [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399168 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [13:59:05] 10MediaWiki-Codesniffer: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546#3847948 (10Huji) @Esanders you merged this patch. Is it because someone else added the feature to CodeSniffer and I am not aware of it? If not, I'll try to work on the patch this weekend. [14:00:22] 10Timeless: Cannot correctly select text in chromium - https://phabricator.wikimedia.org/T183215#3847953 (10Isarra) Er, this is on linux (mouse clipboard), Chromium 63.0.3239.84, and when running out of SWAP. Yes, SWAP can be slow, but not this slow, and not// for this//, as evidenced by other skins not being af... [14:00:41] (03Merged) 10jenkins-bot: Fix location of LocalSettings.php [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399168 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [14:01:21] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3847885 (10Catrope) [14:01:23] 10MediaWiki-extensions-Translate, 10Easy, 10User-MarcoAurelio: Status "proofreading" does not make sense for the source language in Special:(Language|MessageGroup)Stats - https://phabricator.wikimedia.org/T160511#3101432 (10Nikerabbit) Not trivial one line change but I don't see why this would be very compli... [14:01:51] 10Timeless: Cannot correctly select text in chromium - https://phabricator.wikimedia.org/T183215#3847972 (10Isarra) Oh, also hardware acceleration is disabled, may or may not be related, but now we're getting into the general rabbit hole of chromium's utter instability. [14:04:35] (03CR) 10Nikerabbit: [C: 032] Add fallback to getting Preferences and Notifications URLs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/389648 (owner: 10Petar.petkovic) [14:05:50] (03PS1) 10DCausse: Remove ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) [14:06:18] (03PS5) 10Phantom42: Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) [14:06:25] 10MobileFrontend: {{Orphan}} template is quasi-visible on mobile web even when it's not visible on desktop - https://phabricator.wikimedia.org/T183246#3847978 (10Amire80) [14:06:27] 10Wikispeech, 10Wikispeech-STTS: Wikispeech test.html: The highlighting doesn't match up with the recitation for several of the sentences. - https://phabricator.wikimedia.org/T183247#3847988 (10HannaLindgren) [14:06:44] 10Wikispeech, 10Wikispeech-STTS: Wikispeech test.html: The highlighting doesn't match up with the recitation for several of the sentences. - https://phabricator.wikimedia.org/T183247#3847988 (10HannaLindgren) p:05Triage>03Low [14:07:54] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3847997 (10Zppix) [14:09:48] (03CR) 10jerkins-bot: [V: 04-1] Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [14:10:53] 10Collaboration-Community-Engagement, 10Global-Collaboration: Newsletters about Global Collaboration projects - https://phabricator.wikimedia.org/T183248#3848005 (10Trizek-WMF) [14:11:13] (03Merged) 10jenkins-bot: Add fallback to getting Preferences and Notifications URLs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/389648 (owner: 10Petar.petkovic) [14:11:16] 10Collaboration-Community-Engagement, 10Global-Collaboration: Newsletters about Global Collaboration projects - https://phabricator.wikimedia.org/T183248#3848016 (10Trizek-WMF) p:05Triage>03Normal [14:11:27] 10Collaboration-Community-Engagement, 10Global-Collaboration, 10Epic: Newsletters about Global Collaboration projects - https://phabricator.wikimedia.org/T183248#3848005 (10Trizek-WMF) [14:11:53] 10Collaboration-Community-Engagement, 10Global-Collaboration, 10Epic: December 2017 Global Collaboration newsletter - https://phabricator.wikimedia.org/T183250#3848032 (10Trizek-WMF) p:05Triage>03High [14:12:04] (03PS2) 10DCausse: Remove ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) [14:12:22] 10Collaboration-Community-Engagement, 10Global-Collaboration: January 2018 Global Collaboration newsletter - https://phabricator.wikimedia.org/T183251#3848046 (10Trizek-WMF) p:05Triage>03Normal [14:12:38] (03PS4) 10Petar.petkovic: Make Contributions ORES preference sticky [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398841 (https://phabricator.wikimedia.org/T182911) [14:13:53] (03CR) 10jerkins-bot: [V: 04-1] Make Contributions ORES preference sticky [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398841 (https://phabricator.wikimedia.org/T182911) (owner: 10Petar.petkovic) [14:14:58] (03PS6) 10Phantom42: Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) [14:17:22] (03PS5) 10Petar.petkovic: Make Contributions ORES preference sticky [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398841 (https://phabricator.wikimedia.org/T182911) [14:17:23] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3848083 (10Catrope) [14:17:31] (03CR) 10Phantom42: "Looks like jenkins does not have curl installed while running tests. Is there anything we could do about this?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [14:17:59] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3847918 (10Catrope) Why only in tests? It would be useful for the same thing to be done in development envi... [14:18:18] (03PS3) 10Divadsn: Replace deprecated tag with tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) [14:18:27] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [14:19:01] (03CR) 10jerkins-bot: [V: 04-1] Make Contributions ORES preference sticky [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398841 (https://phabricator.wikimedia.org/T182911) (owner: 10Petar.petkovic) [14:19:06] (03CR) 10jerkins-bot: [V: 04-1] Remove ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:19:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Regression, 10User-thiemowmde, 10Wikidata-Sprint-2017-12-20: Can't see references on historic revisions of items on Wikidata - https://phabricator.wikimedia.org/T182767#3848086 (10thiemowmde) We picked this for #wikidata-sprint-2017-12-20, but only... [14:21:18] (03CR) 10Divadsn: "Alright, the commit message should be now clear to everyone :)" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [14:22:06] DanielK_WMDE_: WAS? :D [14:22:43] (03CR) 10jerkins-bot: [V: 04-1] Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [14:22:54] 103D2Commons, 10WMSE-GLAM-2017 (National-Heritage-Board): Create and send out invitation to the hack - https://phabricator.wikimedia.org/T183231#3848091 (10Ainali) [14:23:22] can some one push me in the right direction for format time() with the current users locale? [14:24:19] (03PS2) 10Pmiazga: Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) [14:24:57] Guest76885: yes: http://php.net/manual/en/function.strftime.php [14:25:08] (03PS2) 10Hashar: Prevent puppeteer from downloading Chromium [services/chromium-render] - 10https://gerrit.wikimedia.org/r/398527 (https://phabricator.wikimedia.org/T179552) [14:25:17] (03CR) 10Hashar: "check experimental" [services/chromium-render] - 10https://gerrit.wikimedia.org/r/398527 (https://phabricator.wikimedia.org/T179552) (owner: 10Hashar) [14:25:56] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:26:26] Hi, I am Geet Asati, A pre high school student from Bhopal, India. I am performing a task in google code-in where I had to install a client for IRC but not the web version and thats the reason for the Re-introduction. Thanks [14:26:45] geetasati0560: Welcome! Good luck with your GCI tasks! [14:26:46] Welcome geetasati0560! [14:26:54] geetasati0560, which IRC client did you choose? :) [14:27:07] (03CR) 10Pmiazga: "bmansurov: I found the issue, there were two labels, in Chromium clicking on the first one worked, but on the wrapped one didn't work. Any" (031 comment) [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [14:27:16] (03CR) 10DCausse: "@zeljkof: could we drop the rake job from jenkins?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:27:27] 10MediaWiki-Page-editing, 10MediaWiki-extensions-WikibaseRepository, 10Community-Liaisons, 10Contributors-Team, and 6 others: Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org - https://phabricator.wikimedia.org/T161367#3848100 (10WMDE-leszek) [14:27:39] (03CR) 10Hashar: "Bad news: the tests are failing and I have no idea why" [services/chromium-render] - 10https://gerrit.wikimedia.org/r/394623 (owner: 10Bmansurov) [14:27:52] andre__, mIRC is the client name [14:27:58] (03CR) 10jerkins-bot: [V: 04-1] Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [14:28:19] geetasati0560, then you did not follow the GCI task instructions, I am afraid. :) It says to not use proprietary clients. [14:30:11] andre__, Oh! I see, I will download another open source client. [14:30:17] andre, but is there anything like a short date time format defined? [14:30:28] Guest76885, what is a "short date time format"? [14:30:37] andre, for different locales? [14:31:03] Guest76885: Do you mean ISO8601? [14:31:13] Guest76885, your question is too vague. [14:31:18] Do you have a specific example? [14:32:07] 10InteractionTimeline: Interaction Timeline returns only partial results on complex queries - https://phabricator.wikimedia.org/T182548#3848111 (10Huji) [14:32:08] (03CR) 10Zfilipin: "@DCausse sure, I'm working on it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:32:17] 10InteractionTimeline: Interaction Timeline: In-feature description of how the Timeline works - https://phabricator.wikimedia.org/T182153#3848112 (10Huji) [14:32:21] andre__, if anywhere in mediawiki a time stamp is displayed - how do i have to format it? with '%c' ? [14:32:30] 10InteractionTimeline: Create an API for Interaction Timeline - https://phabricator.wikimedia.org/T180546#3848113 (10Huji) [14:32:40] 10InteractionTimeline: Interaction Timeline V1: Logging - https://phabricator.wikimedia.org/T180088#3848114 (10Huji) [14:32:50] 10InteractionTimeline: Interaction Timeline V1: Header & footer - https://phabricator.wikimedia.org/T180089#3848115 (10Huji) [14:33:01] 10InteractionTimeline: Interaction Timeline V1: Interaction Summary box - https://phabricator.wikimedia.org/T180152#3848119 (10Huji) [14:33:10] 10InteractionTimeline: Interaction Timeline V1: Usernames above the columns should be pinned/stickied while you scroll - https://phabricator.wikimedia.org/T180245#3848121 (10Huji) [14:33:15] 10InteractionTimeline: Interaction Timeline: Include a filter to show edits where one user talks about the other user - https://phabricator.wikimedia.org/T181101#3848122 (10Huji) [14:33:31] 10InteractionTimeline: Interaction Timeline: Bundle multiple successive edits to the same by the same user - https://phabricator.wikimedia.org/T181566#3848123 (10Huji) [14:33:39] 10InteractionTimeline: Interaction Timeline: Currently easy to force additional usernames - https://phabricator.wikimedia.org/T182831#3848135 (10Huji) [14:33:47] 10InteractionTimeline: Interaction Timeline: Set importance of individual diffs (annotations) - https://phabricator.wikimedia.org/T180764#3848136 (10Huji) [14:33:59] 10InteractionTimeline: Interaction Timeline V1: Add important user links (userpage, user talk, contribs, logs, edit filter log, block log) - https://phabricator.wikimedia.org/T180722#3848137 (10Huji) [14:34:07] 10InteractionTimeline: Interaction Timeline V1: Byte change & minor edit - https://phabricator.wikimedia.org/T180415#3848138 (10Huji) [14:34:15] 10InteractionTimeline: Interaction Timeline V1: Better date picker - https://phabricator.wikimedia.org/T180406#3848139 (10Huji) [14:34:24] 10InteractionTimeline: Interaction Timeline V1: Parse and extract section name from edit summary & display it as § - https://phabricator.wikimedia.org/T180745#3848143 (10Huji) [14:34:34] (03CR) 10Amritsreekumar: "Avoid using URLs in commit messages, please do change it and refer to gerrit tutorial if you have doubt." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [14:35:40] 10MediaWiki-Codesniffer: CodeSniffer to warn against usages of extract() - https://phabricator.wikimedia.org/T180398#3848146 (10Ricordisamoa) [14:35:42] 10Collaboration-Community-Engagement, 10Global-Collaboration, 10Epic: Newsletters about Global Collaboration projects - https://phabricator.wikimedia.org/T183248#3848149 (10Trizek-WMF) [14:36:09] 10InteractionTimeline: Interaction Timeline V1 - https://phabricator.wikimedia.org/T179607#3848150 (10Huji) [14:36:10] 10MediaWiki-Codesniffer: Detect use of create_function with codesniffer - https://phabricator.wikimedia.org/T181865#3848151 (10Ricordisamoa) [14:37:05] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment, 10InteractionTimeline, 10Patch-For-Review: CentralAuth API list=globalallusers should capitalize the first letter - https://phabricator.wikimedia.org/T180858#3848157 (10Huji) [14:37:31] 10InteractionTimeline: Epic ⚡️ : Interaction Timeline - https://phabricator.wikimedia.org/T166807#3848158 (10Huji) [14:39:32] (03PS3) 10Zfilipin: Remove Ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:40:21] (03CR) 10Zfilipin: "PS #3 removes a few more Ruby related things" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:41:18] (03PS6) 10Petar.petkovic: Make Contributions ORES preference sticky [extensions/ORES] - 10https://gerrit.wikimedia.org/r/398841 (https://phabricator.wikimedia.org/T182911) [14:41:39] Hi, I am Geet Asati, a pre high school student from Bhopal, India.Actually I am performing a task in Google code-in and in it, I have to install a free source IRC client, So I chose XChat. Thanks! [14:42:10] Geet: You don't have to keep reintroducing yourself. Welcome, by the way! [14:43:19] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_ru_searching_for_when_text_has, clean_api_ru_searching_for_no_accent_and_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [14:43:51] Niharika, Hi! Sorry i get it. Thanks [14:43:55] Geet: Glad to meet you here :) [14:45:16] sanjay_tharagesh, Thanks! [14:45:58] andre__, thank you. [14:46:28] (03PS2) 10ItSpiderman: [WIP] Switch to Role model [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/398043 [14:46:46] (03CR) 10jerkins-bot: [V: 04-1] Remove Ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:48:46] andre__: Hi! I have a quick question. As I told before, I am planning to do some more improvements to wikimedia error page, but my previous patch to puppet ( https://gerrit.wikimedia.org/r/#/c/395552/ ) is still not merged. Shall I wait for it to get merged before I continue my work or I may just push additional changes to existing patch? [14:51:12] (03CR) 10Zfilipin: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [14:52:09] (03CR) 10Divadsn: "But w3schools.com is a site name, not an URL" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [14:52:44] Phantom42: we are in a deployment freeze meaning patches like that on puppet or anything with operations probably wont be done until after jan 8 [14:52:56] Unless emergency [14:54:50] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 3 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3848240 (10Phantom42) And one more thing: looks like after adding `ext-curl` to `composer.json` CI `mwext-php70-phan-docker` s... [14:56:06] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3848255 (10zeljkofilipin) [14:59:24] (03PS1) 10Addshore: [MCR] Fix SqlBlobStore using DB_REPLICA for writes [core] - 10https://gerrit.wikimedia.org/r/399188 (https://phabricator.wikimedia.org/T183242) [14:59:58] Zppix: Okay. Thanks for that information! Then I will wait until jan 8 for this change to get merged and after that create a separate patch for new changes. Or I will update existing patch and wait for jan 8 to get all these changes merged together :) [15:00:03] (03CR) 10Catrope: [C: 032] [MCR] Fix SqlBlobStore using DB_REPLICA for writes [core] - 10https://gerrit.wikimedia.org/r/399188 (https://phabricator.wikimedia.org/T183242) (owner: 10Addshore) [15:00:56] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_ru_searching_for_no_accent_and_lowercase, clean_api_ru_searching_with_ins" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:01:14] (03PS7) 10Tacsipacsi: Add GENDER support, make log using proper English [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/261168 [15:02:03] Phantom42: i suggest keep working on it if you need too, just so its less follow up [15:03:49] (03PS1) 10Anomie: ApiBlock: Improve username validation [core] - 10https://gerrit.wikimedia.org/r/399190 (https://phabricator.wikimedia.org/T183211) [15:03:59] (03CR) 10Zfilipin: [C: 031] "Looks like Cindy is not happy, but the rest of the jobs are green." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:05:28] (03Abandoned) 10Zfilipin: Selenium test: alerts and notices are visible after logging in [extensions/Echo] - 10https://gerrit.wikimedia.org/r/368409 (https://phabricator.wikimedia.org/T171848) (owner: 10Zfilipin) [15:05:38] (03CR) 10Amritsreekumar: "You don't have to mention the source of your information, commit messages only need to show the changes you have made and why you have mad" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [15:06:04] (03Merged) 10jenkins-bot: [MCR] Fix SqlBlobStore using DB_REPLICA for writes [core] - 10https://gerrit.wikimedia.org/r/399188 (https://phabricator.wikimedia.org/T183242) (owner: 10Addshore) [15:07:55] Zppix: In fact, that change is ready, I was just thinking about adding one additional thing possibly in a separate patch :) Anyway, thank you! [15:08:04] (03Abandoned) 10Zfilipin: WIP Run Cucumber+Selenium+Node.js in CI [core] - 10https://gerrit.wikimedia.org/r/391566 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [15:08:10] (03Abandoned) 10Zfilipin: WIP Run Cucumber+Selenium+Node.js in CI [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/391567 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [15:09:01] (03PS1) 10Rafidaslam: Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) [15:09:19] Phantom42: no worries remember if you have any questions feel free to always ping me if im online or any other mentors, If we cant answer it chances are well know who can [15:09:34] (03Abandoned) 10Zfilipin: WIP Upgrade WebdriverIO to 4.9.2 [core] - 10https://gerrit.wikimedia.org/r/390233 (https://phabricator.wikimedia.org/T161697) (owner: 10Zfilipin) [15:12:01] 10UI-Standardization, 10Front-end-Standards-Group, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867#3848318 (10Volker_E) [15:12:33] (03PS1) 10Rafidaslam: Add minus-x to "composer test" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) [15:14:05] (03PS10) 10Dbrant: Reading list database layer: a reimagining. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/397847 (https://phabricator.wikimedia.org/T182594) [15:14:07] (03CR) 10D3r1ck01: "recheck" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:14:13] (03CR) 10D3r1ck01: "recheck" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:17:25] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:18:17] 10Discovery, 10Wikimedia-Portals: Input focus not aligned to WikimediaUI - https://phabricator.wikimedia.org/T183262#3848347 (10Volker_E) [15:19:11] (03CR) 10jenkins-bot: [MCR] Fix SqlBlobStore using DB_REPLICA for writes [core] - 10https://gerrit.wikimedia.org/r/399188 (https://phabricator.wikimedia.org/T183242) (owner: 10Addshore) [15:20:07] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/399193 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:20:14] (03CR) 10DCausse: "thanks!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:20:40] 10MediaWiki-Special-pages: Contributions DateInputWidget doesn't always link to a user's newer contributions - https://phabricator.wikimedia.org/T183107#3848363 (10Wbm1058) The fundamental issue here is that `start=2016-03-10` is incompatible with `offset=20160311235959`. You can't start from two different date... [15:21:05] 10OOjs-UI, 10Patch-For-Review: Issues with OOUI menus/popups that open upwards being overlapped by things - https://phabricator.wikimedia.org/T183069#3842598 (10Nikerabbit) Does that fix also access echo popups becoming completely inaccessible on small screens? {F11934548} [15:24:02] (03PS23) 10Anomie: Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) [15:24:22] (03CR) 10jerkins-bot: [V: 04-1] Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [15:28:40] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_ru_searching_for_when_text_has, clean_api_ru_searching_for_no_accent_and_" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:28:58] 10MediaWiki-extensions-Linter, 10Parsoid, 10RemexHtml, 10Tidy: Create new high-priority linter category for multiple unclosed formatting tags whose effects accumulate - https://phabricator.wikimedia.org/T182170#3848392 (10ssastry) 05Open>03Resolved a:03ssastry [15:30:26] (03CR) 10Florianschmidtwelzow: [C: 04-1] "No, the missing curl-extension is nothing you can fix, unfortunately :(" (036 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [15:31:03] (03PS2) 10Zfilipin: Remove Ruby browser tests [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399130 (https://phabricator.wikimedia.org/T174589) (owner: 10Mattflaschen) [15:32:47] (03CR) 10Zfilipin: "PS #2 removes more Ruby code." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399130 (https://phabricator.wikimedia.org/T174589) (owner: 10Mattflaschen) [15:32:53] (03CR) 10Florianschmidtwelzow: "recheck" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:33:31] (03CR) 10Dbrant: "@Cooltey To address your previous comments:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/397847 (https://phabricator.wikimedia.org/T182594) (owner: 10Dbrant) [15:34:13] (03CR) 10jerkins-bot: [V: 04-1] Add minus-x to "composer test" [skins/Modern] - 10https://gerrit.wikimedia.org/r/399192 (https://phabricator.wikimedia.org/T175794) (owner: 10Rafidaslam) [15:35:38] (03CR) 10Zfilipin: [C: 032] Remove Ruby browser tests [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399130 (https://phabricator.wikimedia.org/T174589) (owner: 10Mattflaschen) [15:35:57] (03PS4) 10Anomie: Trigger name changes [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) (owner: 10Freakolowsky) [15:37:07] (03CR) 10Anomie: [C: 032] "Ok, let's go ahead with this. While I remain skeptical that Oracle is going to work reliably if it considers empty string to be null in so" [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) (owner: 10Freakolowsky) [15:37:47] (03PS1) 10Serraboof: fix adaptive icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) [15:38:01] (03Merged) 10jenkins-bot: Remove Ruby browser tests [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/399130 (https://phabricator.wikimedia.org/T174589) (owner: 10Mattflaschen) [15:39:16] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3848420 (10daniel) @Catrope yes, I see the point in that. But that should probably be a separate ticket. Th... [15:40:02] (03CR) 10Serraboof: "Pulled from GitHub PR: https://github.com/wikimedia/apps-android-wikipedia/pull/16" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) (owner: 10Serraboof) [15:41:12] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Donate with foreign IBAN w/o adding BIC - https://phabricator.wikimedia.org/T181151#3848428 (10kai.nissen) [15:41:37] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Donate with foreign IBAN w/o adding BIC - https://phabricator.wikimedia.org/T181151#3781276 (10kai.nissen) a:05kai.nissen>03None [15:42:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: [Task] Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare) - https://phabricator.wikimedia.org/T96124#3848445 (10thiemowmde) 05Open>03Resolved a:03thiemowmde It looks like this was... [15:43:01] (03PS2) 10Serraboof: fix adaptive icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) [15:44:19] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Write operations should fail on connections obtained for the DB_REPLICA index, even if there is only one database. - https://phabricator.wikimedia.org/T183265#3848454 (10daniel) p:05Triage>03Normal [15:45:08] (03Merged) 10jenkins-bot: Trigger name changes [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) (owner: 10Freakolowsky) [15:45:26] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3848479 (10daniel) Actually... no. This is all backwards. Hold on, I'll fix the tickets. [15:45:36] (03PS4) 10Divadsn: Replace deprecated tag with tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) [15:46:00] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3848485 (10daniel) 05Open>03Invalid no separate ticket needed for this. [15:46:08] 10MediaWiki-extensions-PageCuration, 10Browser-Tests, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review, 10User-zeljkofilipin: PageTriage: Remove Ruby browser tests - https://phabricator.wikimedia.org/T174589#3848488 (10zeljkofilipin) [15:46:17] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Unit tests should fail when code writes to a DB connection obtained with the DB_REPLICA flag. - https://phabricator.wikimedia.org/T183244#3848491 (10daniel) [15:46:20] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Write operations should fail on connections obtained for the DB_REPLICA index, even if there is only one database. - https://phabricator.wikimedia.org/T183265#3848490 (10daniel) [15:47:14] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Write operations should fail on connections to database replicas. - https://phabricator.wikimedia.org/T183265#3848495 (10daniel) [15:47:22] (03CR) 10Divadsn: "Ah now I get it, thank you :)" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [15:47:51] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, 10German-Community-Wishlist, and 5 others: Make change detection threshold configurable from php - https://phabricator.wikimedia.org/T181404#3848497 (10WMDE-Fisch) [15:47:53] 10MediaWiki-Database, 10Multi-Content-Revisions, 10Patch-For-Review, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3848499 (10daniel) [15:47:55] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Write operations should fail on connections to database replicas. - https://phabricator.wikimedia.org/T183265#3848454 (10daniel) [15:48:13] 10MediaWiki-extensions-PageCuration, 10Browser-Tests, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Patch-For-Review, 10User-zeljkofilipin: PageTriage: Remove Ruby browser tests - https://phabricator.wikimedia.org/T174589#3567090 (10zeljkofilipin) 05Open>03Resolved a:03zeljkofilipin [15:48:40] 10Readers-Web-Backlog (Design): Bump running text size up slightly - https://phabricator.wikimedia.org/T183105#3848504 (10ovasileva) [15:49:49] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3848526 (10zeljkofilipin) [15:50:39] (03PS4) 10EBernhardson: Remove Ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:50:42] (03CR) 10EBernhardson: Remove Ruby browser tests (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:50:48] (03CR) 10EBernhardson: [C: 032] Remove Ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:51:45] 10MediaWiki-Database, 10Multi-Content-Revisions, 10Patch-For-Review, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3848540 (10daniel) [15:52:08] 10MediaWiki-Database, 10Multi-Content-Revisions, 10User-Daniel: Write operations should fail on connections to database replicas. - https://phabricator.wikimedia.org/T183265#3848454 (10daniel) p:05Normal>03High [15:52:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10Patch-For-Review: [Bug] Diff does not show stored capitalisation of first letter - https://phabricator.wikimedia.org/T99664#3848546 (10thiemowmde) [15:52:39] 10MediaWiki-Database, 10Multi-Content-Revisions, 10Patch-For-Review, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242#3847885 (10daniel) p:05High>03Normal Reducing to normal prio, bumping {T183265} to high prio instead. [15:57:24] (03PS3) 10Pmiazga: Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) [15:57:49] anomie: 10x for the merge ... i'll update the MCR branch with new trigger names [15:58:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10Patch-For-Review: [Bug] Diff does not show stored capitalisation of first letter - https://phabricator.wikimedia.org/T99664#3848557 (10thiemowmde) In addition to what I already prepared in https://gerrit.wikimedia.org/r/39... [15:59:37] (03CR) 10jenkins-bot: Trigger name changes [core] - 10https://gerrit.wikimedia.org/r/398452 (https://phabricator.wikimedia.org/T182981) (owner: 10Freakolowsky) [15:59:46] (03Merged) 10jenkins-bot: Remove Ruby browser tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399178 (https://phabricator.wikimedia.org/T174103) (owner: 10DCausse) [15:59:56] (03PS1) 10DCausse: Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 [16:01:47] 10OOjs-UI, 10Patch-For-Review: Issues with OOUI menus/popups that open upwards being overlapped by things - https://phabricator.wikimedia.org/T183069#3848564 (10matmarex) Maybe. Can you file a separate task? [16:02:02] 10MediaWiki-extensions-LoginNotify, 10Community-Tech-Sprint: Investigation: LoginNotify false positives on dewiki - https://phabricator.wikimedia.org/T178619#3848565 (10Niharika) Here's what the current behavior is like: * The login attempt is considered to be from a "known device" if any of these matches: **... [16:03:28] 10UI-Standardization, 10Front-end-Standards-Group, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867#3848571 (10Volker_E) [16:04:48] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3848574 (10zeljkofilipin) [16:05:00] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 (owner: 10DCausse) [16:05:28] (03PS8) 10DCausse: Prepare replacement of selenium-CirrusSearch job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) [16:05:33] (03PS9) 10DCausse: Prepare replacement of selenium-CirrusSearch job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) [16:05:42] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Performance-Team (Radar): Optimize SVGs in data URIs - https://phabricator.wikimedia.org/T175318#3848580 (10Volker_E) [16:05:45] 10UI-Standardization, 10Front-end-Standards-Group, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867#3848579 (10Volker_E) [16:09:09] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Performance-Team (Radar): Optimize SVGs in data URIs - https://phabricator.wikimedia.org/T175318#3848587 (10Volker_E) [16:09:19] (03CR) 10Dbrant: [C: 04-1] "This is definitely the right logic for creating an adaptive icon, but a couple of questions:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) (owner: 10Serraboof) [16:09:22] (03CR) 10Addshore: "There was also a plan to have a cached and an uncached version of the store." [core] - 10https://gerrit.wikimedia.org/r/343632 (https://phabricator.wikimedia.org/T160062) (owner: 10Addshore) [16:09:51] (03PS14) 10Addshore: Add switch for readonly watchlists [core] - 10https://gerrit.wikimedia.org/r/343632 (https://phabricator.wikimedia.org/T160062) [16:10:19] (03PS2) 10DCausse: Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 [16:11:41] (03PS1) 10Daniel Kinzler: Prevent write operations to database replicas. [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) [16:11:46] 10Design, 10Revision-Slider, 10TCB-Team, 10WMDE-Design, and 3 others: Change title of revision slider to "Browse history interactively" - https://phabricator.wikimedia.org/T169323#3848595 (10WMDE-Fisch) [16:13:25] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 (owner: 10DCausse) [16:15:43] 10MediaWiki-Vagrant, 10Operations: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3848623 (10EBernhardson) @gehel It looks like we need to release stretch packages for all our custom elastic stuff (kibana, logstash, es, plugins?). My intuition is that since this is a... [16:18:09] (03PS2) 10Zfilipin: Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [16:19:09] FlorianSW and d3r1ck : are mwgate-composer-hhvm-docker and mwgate-composer-php55-docker check are new checks in jessie, I never saw them before. Those check are failing on `composer --ansi validate`, seems like we need to comply with composer's json schema now? [16:19:25] 10MediaWiki-Vagrant, 10Operations: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3842659 (10MoritzMuehlenhoff) >>! In T183071#3848623, @EBernhardson wrote: > @gehel It looks like we need to release stretch packages for all our custom elastic stuff (kibana, logstash,... [16:19:42] 10MediaWiki-Vagrant, 10Operations: Import kibana package from jessie into stretch - https://phabricator.wikimedia.org/T183071#3848646 (10Gehel) The elasticsearch / kibana / logstash packages have already been uploaded to our stretch repo (under the thirdparty/elastic55 component). This should fix the issue rep... [16:21:17] refeed[m]: Yeah! [16:21:21] (03PS3) 10DCausse: Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 [16:21:35] but maybe bd808 has more insights on this :) [16:22:48] 10MinervaNeue: Contents icon should feature an icon color aligned with text - https://phabricator.wikimedia.org/T183269#3848656 (10Volker_E) [16:22:53] 10monitoring, 10Graphite, 10Performance-Team (Radar): Upgrade graphite from 0.9.x to 1.x - https://phabricator.wikimedia.org/T166173#3848666 (10Imarlier) 1.1.0 has already been pulled, it looks like. 1.1.1 release notes are posted with a release date that's 2 days in the future: {F11935271} [16:23:19] (03PS3) 10Zfilipin: Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [16:25:26] Phantom42, I would wait if I was you. It's unfortunate but it's actually often the case that folks don't have enough time to review :-/ [16:25:33] Thanks for asking :) [16:28:01] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 (owner: 10DCausse) [16:29:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code fro and frm in Wikdiata - https://phabricator.wikimedia.org/T181823#3803439 (10StevenJ81) For LangCom: Approved. [16:29:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-Wishlist-Survey-2016, 10Goal: [Goal] Sitelinks to Incubator, OldWikisource and BetaWikiversity - https://phabricator.wikimedia.org/T54971#3848693 (10StevenJ81) @Samwilson, @ChristianKl and @MF-Warburg : If you are a "pure Wikidata"-type per... [16:30:39] (03CR) 10jerkins-bot: [V: 04-1] Remove Ruby browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399131 (https://phabricator.wikimedia.org/T171848) (owner: 10Mattflaschen) [16:32:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10User-Zoranzoki21: Add monolingual language code fro and frm in Wikdiata - https://phabricator.wikimedia.org/T181823#3848703 (10Zoranzoki21) a:03Zoranzoki21 [16:33:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer, 10User-Zoranzoki21: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3848709 (10Aklapper) [16:33:48] (03PS4) 10DCausse: Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 [16:34:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code fro and frm in Wikidata - https://phabricator.wikimedia.org/T181823#3848713 (10Zoranzoki21) a:05Zoranzoki21>03None [16:34:48] (03PS4) 10Niedzielski: WIP: add support for page transitions [marvin] - 10https://gerrit.wikimedia.org/r/398541 (https://phabricator.wikimedia.org/T179489) [16:35:16] (03CR) 10Catrope: [C: 032] Prevent write operations to database replicas. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [16:37:26] (03CR) 10Catrope: [C: 032] "Copying from IRC:" [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [16:38:25] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, 10German-Community-Wishlist, and 3 others: Investigate what the ideal change detection threshold would be - https://phabricator.wikimedia.org/T181494#3848723 (10WMDE-Fisch) I tried to fix some of these regressions from the regression ticket, with a val... [16:38:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "As far as I can see all the nitpicks about names Lucas and I had are resolved, and this might be ready to be merged. However, I think some" [core] - 10https://gerrit.wikimedia.org/r/392173 (https://phabricator.wikimedia.org/T173980) (owner: 10Smalyshev) [16:39:34] (03CR) 10Catrope: [C: 032] "...And Daniel correctly points out that this can't be done until master wrapping is done, because in the unit tests DB_REPLICA always retu" [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [16:40:22] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), 10UI-Standardization-Kanban: Mangle whitespace of OOUI in MediaWiki's HTMLForm - https://phabricator.wikimedia.org/T177668#3848731 (10Volker_E) [16:40:38] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 (owner: 10DCausse) [16:41:03] 10MediaWiki-Page-editing: Section "view source" on protected pages - https://phabricator.wikimedia.org/T11394#3848733 (10Xaosflux) 05Open>03stalled [16:41:42] (03PS1) 10Florianschmidtwelzow: Change path to $IP when using extension-dir too [core] - 10https://gerrit.wikimedia.org/r/399219 [16:42:57] Hi andre__ :) [16:44:47] (03Merged) 10jenkins-bot: Prevent write operations to database replicas. [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [16:45:55] (03CR) 10Lucas Werkmeister (WMDE): [C: 031] "Yeah, I think everything I commented on is resolved. Not sure why I didn’t give +1 earlier :)" [core] - 10https://gerrit.wikimedia.org/r/392173 (https://phabricator.wikimedia.org/T173980) (owner: 10Smalyshev) [16:45:57] (03CR) 10Serraboof: "Since I pulled this patch from GitHub I don't know exactly what the original author was thinking." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) (owner: 10Serraboof) [16:46:01] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3848748 (10Tbayer) >>! In T182235#3817656, @Jdlrobson wrote: > @tbayer can you take a look at this task and see if th... [16:47:05] @divadsn: do you've a question (you've pinged andre__, that's why I ask :))? :) [16:47:25] 10OOjs-UI: DropdownWidget: Background applied to wrong element in Apex - https://phabricator.wikimedia.org/T183271#3848751 (10Esanders) [16:47:35] (03PS24) 10Anomie: Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) [16:47:46] FlorianSW: I just wanted to tell him hi and ask if he already seen my task is on review for GCI :) [16:48:07] Hey. :) Meeting. Later I hope. Thanks! :-/ [16:48:09] divadsn: what task is it? [16:48:18] divadsn: ah, ok :) [16:48:34] Zppix: https://phabricator.wikimedia.org/T182968 and Andre is my mentor theoretically :D [16:49:32] Ok [16:50:09] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3848762 (10Tbayer) >>! In T182235#3837053, @phuedx wrote: > Given @pmiazga's additional information that the EventLog... [16:50:43] (03PS16) 10Imarlier: ext.NavigationTiming: Allow oversampling based on geography or user agent [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/394298 (https://phabricator.wikimedia.org/T181413) [16:51:11] (03PS5) 10DCausse: Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 [16:51:18] (03CR) 10Imarlier: ext.NavigationTiming: Allow oversampling based on geography or user agent (037 comments) [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/394298 (https://phabricator.wikimedia.org/T181413) (owner: 10Imarlier) [16:54:35] (03CR) 10jerkins-bot: [V: 04-1] Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [16:55:36] (03CR) 10jenkins-bot: Prevent write operations to database replicas. [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [16:57:18] 10MediaWiki-Special-pages: DateInputWidget on Special:Contributions doesn't always link to user's newer contributions (due to start= vs offset=) - https://phabricator.wikimedia.org/T183107#3848791 (10Aklapper) [16:57:57] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3848792 (10jayvdb) @Filip , can you add some Polish templates to the task description? [16:58:49] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3848794 (10jayvdb) [17:00:05] (03PS19) 10Catrope: Remove editor switching infrastructure in favor of VE's source mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) [17:01:15] (03CR) 10Catrope: "I just removed that focus call, it was completely unnecessary (because activate already auto-focuses if requested) and didn't appear anywh" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [17:01:19] 10Easy, 10Google-Code-In-2016, 10Google-Code-in-2017: Add TemplateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#3848799 (10jayvdb) [17:01:21] (03CR) 10Cparle: [C: 04-1] Add patent selection to Special:Upload (032 comments) [core] - 10https://gerrit.wikimedia.org/r/398845 (https://phabricator.wikimedia.org/T182683) (owner: 10Matthias Mullie) [17:01:25] (03PS1) 10VolkerE: Unify BetaFeatures SVG screenshot markup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399226 [17:01:42] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: "Login to Wikidata as QuickStatementsBot from a computer you have not recently used" - https://phabricator.wikimedia.org/T182867#3848800 (10Niharika) From the debug logs it seems like n... [17:03:53] (03CR) 10Bmansurov: "I think the code looks good. However, sometimes saving the settings doesn't work as intended. I cannot reliably reproduce the issue, but t" [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [17:08:23] (03CR) 10Catrope: [C: 032] Unify BetaFeatures SVG screenshot markup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399226 (owner: 10VolkerE) [17:08:33] (03CR) 10Aklapper: [C: 031] "CR+1. Leaving CR+2 to https://www.mediawiki.org/wiki/Contributors#Editing_team as per https://www.mediawiki.org/wiki/Developers/Maintainer" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:11:14] (03CR) 10Tjones: [C: 032] Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 (owner: 10DCausse) [17:11:16] 10Google-Code-in-2017: Lua Task 7 - Repeating code - https://phabricator.wikimedia.org/T182833#3836025 (10Clockery) Task 8 done, links to sandboxes: https://en.wikipedia.org/wiki/Module:Sandbox/Clockery https://en.wikipedia.org/wiki/User:Clockery/sandbox#Looping [17:16:19] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: "Login to Wikidata as QuickStatementsBot from a computer you have not recently used" - https://phabricator.wikimedia.org/T182867#3848821 (10Niharika) >>! In T182867#3845744, @Bawolff wr... [17:17:03] (03Merged) 10jenkins-bot: Unify BetaFeatures SVG screenshot markup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/399226 (owner: 10VolkerE) [17:17:21] 10Google-Code-in-2017: Pick an article about your favorite topic on English Wikipedia and make small edits to it - https://phabricator.wikimedia.org/T181594#3795501 (10Showherda) I edited the page: "Tenida", I corrected a few spelling mistakes and added Bengali translations of the relevant topics but there was... [17:18:22] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Allow rendering PDFs for mobile - https://phabricator.wikimedia.org/T181680#3848826 (10pmiazga) Also, do we want to be strict about `legal` size, different mobile devices have different width to height ratio. `Legal` might be not good for all. [17:19:28] (03Merged) 10jenkins-bot: Remove deprecated usage of Maintenance:error( $msg, $die ) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399204 (owner: 10DCausse) [17:19:42] 10MediaWiki-Vagrant, 10Wikidata, 10Wikidata-primary-sources: import-dump command fails due to sudo broken file permissions - https://phabricator.wikimedia.org/T183274#3848828 (10Hjfocs) [17:20:14] (03CR) 10Esanders: [C: 04-1] Remove editor switching infrastructure in favor of VE's source mode (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [17:20:27] (03PS10) 10DCausse: Prepare replacement of selenium-CirrusSearch job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) [17:22:07] 10Design, 10JADE, 10Scoring-platform-team: Design conceptual prototype of JADE integration with MediaWiki - https://phabricator.wikimedia.org/T182829#3848860 (10Halfak) [17:22:10] 10Design, 10JADE, 10Scoring-platform-team: Design conceptual prototype of JADE integration with MediaWiki - https://phabricator.wikimedia.org/T182830#3848862 (10Halfak) [17:22:58] 10MinervaNeue, 10Design (RW-Design-Debt): Contents icon should feature an icon color aligned with text - https://phabricator.wikimedia.org/T183269#3848864 (10Nirzar) [17:23:57] 10Page-Previews, 10Readers-Web-Backlog: Change copy on empty preview - https://phabricator.wikimedia.org/T183151#3848866 (10ovasileva) [17:24:38] 10Page-Previews, 10Readers-Web-Backlog: Change copy on empty preview - https://phabricator.wikimedia.org/T183151#3845157 (10ovasileva) [17:24:45] (03CR) 10He7d3r: [C: 04-1] "I don't think `` is appropriate here, because the extension is not showing "sample output from a computer program"¹ it displays an e" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:24:57] 10Page-Previews, 10Readers-Web-Backlog: Change copy on empty preview - https://phabricator.wikimedia.org/T183151#3845157 (10ovasileva) [17:24:58] (03CR) 10VolkerE: "Ok, I know my “hopes” were blocking this here. Let me try to propose the alternative way this week, if not, let's merge this begin of next" [core] - 10https://gerrit.wikimedia.org/r/372551 (https://phabricator.wikimedia.org/T171365) (owner: 10Jdlrobson) [17:25:54] (03CR) 10Divadsn: "But the example on Mozilla isn't really utilizing it as "sample output"." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:26:40] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3848870 (10Tbayer) >>! In T178278#3831062, @phuedx wrote: > @Tbayer: @pmiazga and I had discussed replaying a day's worth of logs from the... [17:27:03] 10Accessibility, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Easy, and 2 others: Fix insufficient difference between background colors for un/read notifications in the Echo flyout - https://phabricator.wikimedia.org/T78594#3848877 (10Volker_E) [17:27:10] (03CR) 10Esanders: [C: 04-1] Remove editor switching infrastructure in favor of VE's source mode (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [17:27:38] 10Accessibility, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Easy, and 2 others: Fix insufficient difference between background colors for un/read notifications in the Echo flyout - https://phabricator.wikimedia.org/T78594#848894 (10Volker_E) Thanks @Albert221! [17:28:21] (03PS5) 10Addshore: MCR: Deprecate and gut Revision class [DNM] [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) (owner: 10Daniel Kinzler) [17:28:44] Hi! I'm Akshat from India! Here for Google Code-in task. [17:29:10] (03PS1) 10VolkerE: Provide an appropriate comment [core] - 10https://gerrit.wikimedia.org/r/399232 [17:29:17] 10Page-Previews, 10Readers-Web-Backlog: Change copy on empty preview - https://phabricator.wikimedia.org/T183151#3848880 (10ovasileva) [17:29:24] (03CR) 10Divadsn: "Also, replicating the tt tag with a span + CSS would be also not possible, as the styling of tt is different depending on Browser and OS a" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:30:43] 10Accessibility, 10UI-Standardization, 10Technical-Debt, 10Tracking, 10UI-Standardization-Kanban: Replace abandoned colors in current WMF/Wikimedia products with WikimediaUI palette colors (tracking) - https://phabricator.wikimedia.org/T148708#3848883 (10Volker_E) [17:31:17] Hi, Akshat [17:32:45] 10Design, 10JADE, 10Scoring-platform-team: Design curation/suppression integration with MediaWiki - https://phabricator.wikimedia.org/T183276#3848884 (10Halfak) [17:33:27] 10Design, 10JADE, 10Scoring-platform-team: Design curation/suppression integration with MediaWiki - https://phabricator.wikimedia.org/T183276#3848884 (10Halfak) [17:33:45] 10Design, 10JADE, 10Scoring-platform-team: Design curation/suppression integration with MediaWiki (for JADE) - https://phabricator.wikimedia.org/T183276#3848884 (10Halfak) [17:35:03] 10Accessibility, 10UI-Standardization, 10Technical-Debt, 10Tracking, 10UI-Standardization-Kanban: Replace abandoned colors in current WMF/Wikimedia products with WikimediaUI palette colors (tracking) - https://phabricator.wikimedia.org/T148708#3848907 (10Volker_E) [17:35:06] 10UI-Standardization, 10MW-1.30-release-notes, 10MW-1.29-release-notes, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), 10User-notice: Align MediaWiki core UI elements with WikimediaUI color palette - https://phabricator.wikimedia.org/T152025#3848904 (10Volker_E) 05Open>03Resolved [17:36:03] (03CR) 10He7d3r: [C: 04-1] "> But the example on Mozilla isn't really utilizing it as "sample" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:37:14] (03CR) 10He7d3r: [C: 04-1] "> Also, replicating the tt tag with a span + CSS would be also not" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/399171 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [17:38:32] (03CR) 10Esanders: [C: 04-1] Remove editor switching infrastructure in favor of VE's source mode (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [17:39:10] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_update_weight_expect_failure_pages_weights_are_updated_when_links_are_rem" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [17:41:37] 10Accessibility, 10OOjs-UI: OOjs UI indexed dialogs / tabbed navigation is not accessible - https://phabricator.wikimedia.org/T148030#2712617 (10Volker_E) Note to myself: http://accessibleculture.org/research-files/aria-tabs/version2b.php [17:42:15] 10Community-Liaisons (Jan-Mar-2018): Work to establish practices of communal work on the wikitech ambassadors Phabricator workboard - https://phabricator.wikimedia.org/T183277#3848917 (10Trizek-WMF) [17:42:28] 10Proton, 10Readers-Web-Backlog: Performance test books on chromium rendering service - https://phabricator.wikimedia.org/T183161#3848928 (10ovasileva) @ovasileva to provide list of books for testing [17:43:28] 10Community-Liaisons (Jan-Mar-2018): Work to establish practices of communal work on the wikitech ambassadors Phabricator workboard - https://phabricator.wikimedia.org/T183277#3848929 (10Trizek-WMF) p:05Triage>03Low [17:44:07] 10Proton, 10Readers-Web-Backlog: Performance test books on chromium rendering service - https://phabricator.wikimedia.org/T183161#3848930 (10ovasileva) [17:45:00] 10Library-Card-Platform: Post-migration issues and priorities - https://phabricator.wikimedia.org/T170977#3848934 (10Samwalton9) [17:45:03] 10Library-Card-Platform: Notify coordinators of new applications - https://phabricator.wikimedia.org/T161821#3848933 (10Samwalton9) [17:45:09] 10Library-Card-Platform: Notify coordinators of new applications - https://phabricator.wikimedia.org/T161821#3144269 (10Samwalton9) p:05High>03Normal [17:47:44] 10Proton, 10Readers-Web-Backlog: Performance test books on chromium rendering service - https://phabricator.wikimedia.org/T183161#3848938 (10ovasileva) @ovasileva to clean up/recreate books epic (change from Electron to headless Chromium) [17:48:31] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3848939 (10phuedx) PS: I've plotted the data tracked in StatsD here: https://grafana.wikimedia.org/dashboard/db/mobil... [17:49:05] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Allow rendering PDFs for mobile - https://phabricator.wikimedia.org/T181680#3848940 (10Nirzar) Legal aspect ratio is closest to most devices. it comes close to common screen sizes than A4 or letter [17:50:20] 10Community-Liaisons (Jan-Mar-2018): Set up a Phabricator workboard/project for #techambassadors and experiment with it - https://phabricator.wikimedia.org/T183278#3848945 (10Elitre) [17:50:23] (03PS1) 10Addshore: Remove empty RevisionRecordTest [core] - 10https://gerrit.wikimedia.org/r/399235 (https://phabricator.wikimedia.org/T183219) [17:51:11] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3848963 (10brion) TimedMediaHandler is ok. [17:52:26] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [17:53:26] 10Community-Liaisons (Apr-Jun-2018): Top 25 wiki projects in terms of active contributors have at least one active tech ambassadors and one translator identified - https://phabricator.wikimedia.org/T176475#3848970 (10Elitre) [17:54:41] 10Community-Liaisons (Jan-Mar-2018): Work to establish practices of communal work on the wikitech ambassadors Phabricator workboard - https://phabricator.wikimedia.org/T183277#3848971 (10Elitre) https://phabricator.wikimedia.org/T183278 ! [17:56:34] 10Technical-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Add some unit tests to the new Reading List database layer. - https://phabricator.wikimedia.org/T183169#3848972 (10Sharvaniharan) a:03Sharvaniharan [17:58:03] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3848974 (10Tbayer) >>! In T182235#3848939, @phuedx wrote: > PS: I've plotted the data tracked in StatsD (see #2 in th... [17:59:53] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3848975 (10phuedx) >>! In T182235#3848974, @Tbayer wrote: > I guess that's basically the same graph as mentioned last... [18:05:11] 10ContentTranslation: Discarding Firefox "website has tried to open a pop-up" message drags me to the top of CX - https://phabricator.wikimedia.org/T183158#3848982 (10Trizek-WMF) Let's find someone using that browser on MacOS or Windows, then. @Etonkovidova? :) [18:06:30] 10Wikipedia-Android-App-Backlog, 10Epic, 10Reading Epics (Synchronized Reading Lists): Expose the 'default list' in the Android app - https://phabricator.wikimedia.org/T180239#3848987 (10RHo) [18:07:25] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Release 5.7.3. (1295) - https://phabricator.wikimedia.org/T182709#3848993 (10JoeWalsh) [18:08:26] (03CR) 10Aaron Schulz: Prevent write operations to database replicas. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [18:08:49] 10Community-Liaisons (Jan-Mar-2018): Set up a Phabricator workboard/project for #techambassadors and experiment with it - https://phabricator.wikimedia.org/T183278#3848999 (10Trizek-WMF) [18:08:51] 10Community-Liaisons (Jan-Mar-2018): Work to establish practices of communal work on the wikitech ambassadors Phabricator workboard - https://phabricator.wikimedia.org/T183277#3849001 (10Trizek-WMF) [18:08:54] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3849002 (10phuedx) >>! In T178278#3848870, @Tbayer wrote: > By the way, any particular reason for using `wmf_raw.webrequest` instead of the... [18:11:54] 10CirrusSearch, 10Discovery, 10Discovery-Search: Implement profile management in cirrus - https://phabricator.wikimedia.org/T183279#3849012 (10dcausse) [18:12:07] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work): Implement profile management in cirrus - https://phabricator.wikimedia.org/T183279#3849029 (10dcausse) [18:12:45] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work): Implement profile management in cirrus - https://phabricator.wikimedia.org/T183279#3849012 (10dcausse) p:05Triage>03Normal [18:13:07] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3849035 (10Hanna_Petruschat_WMDE) [18:13:20] 10CirrusSearch, 10Discovery, 10Discovery-Search: Convert CirrusSearch to use extension registration - https://phabricator.wikimedia.org/T87892#3849047 (10dcausse) [18:13:22] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work): Implement profile management in cirrus - https://phabricator.wikimedia.org/T183279#3849012 (10dcausse) [18:15:49] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work): Implement profile management in cirrus - https://phabricator.wikimedia.org/T183279#3849052 (10dcausse) [18:18:34] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3849055 (10Hanna_Petruschat_WMDE) @tmletzko I guess we should shorten the text for mobile. Probably to a version in which the "Fördermitglied werden... [18:21:37] 10Discovery, 10Discovery-Search (Current work): [Recurring task] CirrusSearch: what is updated during re-indexing - https://phabricator.wikimedia.org/T147505#3849059 (10debt) [18:24:16] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395872 (https://phabricator.wikimedia.org/T175179) (owner: 10DCausse) [18:24:48] 10MediaWiki-Language-converter: Request Latin-Cyrillic converter for Romanian wikis - https://phabricator.wikimedia.org/T169453#3849064 (10He7d3r) I don't know Romanian, but maybe someone could try to use a user script to play with this: https://en.wikipedia.org/wiki/Wikipedia:WikiProject_User_scripts/Scripts/La... [18:28:05] 10MediaWiki-General-or-Unknown, 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Feedback tool displays/links the wrong target for page link when it's cross-wiki, although it does post to the correct place - https://phabricator.wikimedia.org/T125400#1986578 (10matmarex) The current patch is a... [18:28:07] (03PS7) 10Bartosz Dziewoński: mw.Feedback: If the message is posted remotely, link the title correctly [core] - 10https://gerrit.wikimedia.org/r/267696 (https://phabricator.wikimedia.org/T125400) (owner: 10Jforrester) [18:33:34] 10EasyTimeline, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3839967 (10Daimona) I was looking right now at what caused some TT tags to appear on it.wiki and, as I realized that it was due... [18:36:09] 10Accessibility, 10Design, 10UI-Standardization, 10ContentTranslation, and 2 others: CX source selector has no focus state - https://phabricator.wikimedia.org/T177402#3849081 (10Petar.petkovic) [18:37:09] 10MediaWiki-Codesniffer: Investigate upstreaming some of our custom sniffs - https://phabricator.wikimedia.org/T103642#3849083 (10Ricordisamoa) [18:38:06] 10Discovery-Search: [epic] ELK upgrade to 6.x (elasticsearch, kibana, logstash) - https://phabricator.wikimedia.org/T183281#3849086 (10debt) p:05Triage>03Normal [18:38:26] 10MediaWiki-Codesniffer: Add sniff to prefer short is_int over is_integer - https://phabricator.wikimedia.org/T173175#3849098 (10Ricordisamoa) [18:38:48] 10Discovery-Search, 10Epic: [epic] Search cluster upgrade to 6.x - https://phabricator.wikimedia.org/T183282#3849100 (10debt) p:05Triage>03Normal [18:38:58] 10Discovery-Search, 10Epic: [epic] ELK upgrade to 6.x (elasticsearch, kibana, logstash) - https://phabricator.wikimedia.org/T183281#3849111 (10debt) [18:39:15] 10Discovery-Search, 10Epic: [epic] Logging cluster upgrade to 6.x - https://phabricator.wikimedia.org/T183283#3849112 (10debt) p:05Triage>03Normal [18:48:55] (03PS1) 10Fomafix: Start showing warnings for deprecated PHP entry point [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/399238 [18:51:04] 10QuickSurveys, 10Goal, 10Reading-Web-Planning, 10Reading-Web-Sprint-56-Four Lions, 10Surveys: [GOAL]: Develop a mechanism for quick surveys on desktop + mobile - https://phabricator.wikimedia.org/T104439#3849129 (10Whatamidoing-WMF) [18:51:09] 10MediaWiki-Page-editing, 10Community-Liaisons, 10QuickSurveys, 10Surveys: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#3849128 (10Whatamidoing-WMF) [18:54:33] (03PS7) 10Phantom42: Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) [18:57:37] 10MediaWiki-extensions-TranslationNotifications, 10Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects: Investigate if it is possible to send translation notifications via Echo - https://phabricator.wikimedia.org/T181139#3849133 (10Mattflaschen-WMF) [18:57:44] (03PS8) 10Phantom42: Fail gracefully if curl is not installed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) [18:58:26] (03CR) 10MarkAHershberger: "I totally understand your concerns. Did you have a chance to look at this, much shorter, patch: https://gerrit.wikimedia.org/r/#/c/398519" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger) [18:58:40] (03CR) 10Phantom42: "Thank you for code review!" (036 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:02:39] (03PS1) 10Ladsgroup: Make the extension fully comply with PSR-4, use proper autoloader [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) [19:04:36] (03CR) 10jerkins-bot: [V: 04-1] Make the extension fully comply with PSR-4, use proper autoloader [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) (owner: 10Ladsgroup) [19:05:14] (03CR) 10Cooltey: [C: 032] "@Dbrant: I see. The patch looks good! also agreed with you that we can create another ticket/patch to fix issues are not specific to this " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/397847 (https://phabricator.wikimedia.org/T182594) (owner: 10Dbrant) [19:07:21] (03PS2) 10Ladsgroup: Make the extension fully comply with PSR-4, use proper autoloader [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) [19:09:00] (03Merged) 10jenkins-bot: Reading list database layer: a reimagining. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/397847 (https://phabricator.wikimedia.org/T182594) (owner: 10Dbrant) [19:09:20] (03CR) 10jerkins-bot: [V: 04-1] Make the extension fully comply with PSR-4, use proper autoloader [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) (owner: 10Ladsgroup) [19:10:36] (03PS3) 10Ladsgroup: Make the extension fully comply with PSR-4, use proper autoloader [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/399239 (https://phabricator.wikimedia.org/T183260) [19:11:35] (03CR) 10jenkins-bot: Reading list database layer: a reimagining. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/397847 (https://phabricator.wikimedia.org/T182594) (owner: 10Dbrant) [19:18:15] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/398773 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:18:49] (03PS1) 10Phantom42: Add cURL PHP extension to the list of composer requirements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399241 (https://phabricator.wikimedia.org/T166355) [19:22:47] 10Community-Liaisons (Jan-Mar-2018): Set up a Phabricator workboard/project for #techambassadors and experiment with it - https://phabricator.wikimedia.org/T183278#3849160 (10Aklapper) See https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects if you want a project [19:25:36] (03CR) 10jerkins-bot: [V: 04-1] Add cURL PHP extension to the list of composer requirements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399241 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:26:33] Is there any way to download the coordinates and title of all the pages that contain coordinates? [19:30:04] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 3 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3849172 (10Phantom42) And that is another change, because we decided to modify `composer.json` in a separate one because of CI... [19:30:08] searching insource for {{coord| and {{coord | etc. will give you a list of pages - you then need a bot to scan those pages for what you want [19:30:28] LocationRipper: do you have a list of all the pages which contain coords? I imagine you could do an AWB pass of all pages which transclude a coord/Infobox country ? [19:30:38] (or, what Rexx said) [19:35:09] TheresNoTime I don't have anything yet, I'm just looking to crawl for every page that has a coordinate and then cURL the page name and the coordinates [19:37:02] RexxS: Is there any way then to sort those pages based on tags or something into useable folders essentially, so put all pages that have to do with sports venues into a sports venues folder like the list of sports venues? https://en.wikipedia.org/wiki/Lists_of_sports_venues [19:38:03] 04(no projects): Tạo Công Việc Mới - https://phabricator.wikimedia.org/T183286#3849189 (10Qtn1293) [19:39:38] you could also use the API to get a list of pages, https://www.mediawiki.org/wiki/API:Embeddedin, `action=query&format=json&list=embeddedin&eititle=Template:Coord` [19:42:58] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/399241 (https://phabricator.wikimedia.org/T166355) (owner: 10Phantom42) [19:43:29] (03PS7) 10Mooeypoo: RCFilters: Create one single source of truth for item display [core] - 10https://gerrit.wikimedia.org/r/397996 (https://phabricator.wikimedia.org/T182720) [19:46:41] (03PS8) 10Bartosz Dziewoński: mw.Feedback: If the message is posted remotely, link the title correctly [core] - 10https://gerrit.wikimedia.org/r/267696 (https://phabricator.wikimedia.org/T125400) (owner: 10Jforrester) [19:46:43] (03PS1) 10Bartosz Dziewoński: mw.Feedback: Remove weird unnecessary switch statements [core] - 10https://gerrit.wikimedia.org/r/399242 [19:47:22] (03CR) 10Bartosz Dziewoński: "PS8 fixes issues mentioned in code review, does some little tweaks, and also fixes the URL in the intro message (previously only the thank" [core] - 10https://gerrit.wikimedia.org/r/267696 (https://phabricator.wikimedia.org/T125400) (owner: 10Jforrester) [19:50:17] I think I'm being a bit dumb here, but could someone tell me why `list=blocks&bkip=170.24.138.0/24` isn't returning any results? Some of the IPs in that /24 *are* blocked [19:54:41] 10TimedMediaHandler, 10TimedMediaHandler-Player, 10Browser-Support-Microsoft-Edge: Play back VP9 video (and some audio) via MSE for MS Edge - https://phabricator.wikimedia.org/T114316#3849237 (10brion) Windows Insider build 17063 starts shipping the 'Web Media Extension' pack which includes Ogg, Vorbis, Theo... [19:58:46] (03CR) 10Esanders: [C: 032] mw.Feedback: Remove weird unnecessary switch statements [core] - 10https://gerrit.wikimedia.org/r/399242 (owner: 10Bartosz Dziewoński) [19:59:24] (https://en.wikipedia.org/w/api.php?action=query&format=json&list=blocks&bkip=170.24.138.0%2F24 being the call I'm trying) [20:01:09] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849256 (10pmiazga) @Kaartic, quoting: bmansurov: > We'll measure the system time right afte... [20:03:53] 10Discovery-Search, 10Epic: [epic] Search cluster upgrade to 6.x - https://phabricator.wikimedia.org/T183282#3849265 (10EBernhardson) Probably the biggest change I'm aware of is elasticsearch removing index types. We will need to come up with different solutions for what we have previously used those index typ... [20:04:45] (03Merged) 10jenkins-bot: mw.Feedback: Remove weird unnecessary switch statements [core] - 10https://gerrit.wikimedia.org/r/399242 (owner: 10Bartosz Dziewoński) [20:07:49] (03PS20) 10Catrope: Remove editor switching infrastructure in favor of VE's source mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) [20:08:37] (03CR) 10Catrope: Remove editor switching infrastructure in favor of VE's source mode (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [20:09:08] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849283 (10bmansurov) @pmiazga, what's the user agent of Galaxy S2's browser? Maybe my propos... [20:12:53] (03CR) 10Catrope: Prevent write operations to database replicas. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [20:13:32] (03PS5) 10Cooltey: Remove old framework for synchronizing user options. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398065 (owner: 10Dbrant) [20:14:08] (03PS1) 10Catrope: build: Update stylelint-config-wikimedia to 0.4.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399247 [20:14:55] (03CR) 10jenkins-bot: mw.Feedback: Remove weird unnecessary switch statements [core] - 10https://gerrit.wikimedia.org/r/399242 (owner: 10Bartosz Dziewoński) [20:16:05] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board: Allow rendering PDFs for mobile - https://phabricator.wikimedia.org/T181680#3849295 (10bmansurov) We talked about this during grooming today and the following two approaches were brought up: 1. Load a page using RESTBase and apply mobile print sty... [20:17:51] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849297 (10pmiazga) @bmansurov `Google Chrome 53.0.2785.124`, official build. Android v 4.1.2... [20:19:57] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849309 (10bmansurov) I agree, so we need to check both the Android version and Chrome version. [20:21:06] (03CR) 10jerkins-bot: [V: 04-1] build: Update stylelint-config-wikimedia to 0.4.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399247 (owner: 10Catrope) [20:26:15] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849348 (10pmiazga) so we talked about Chrome/Chromium itself. Now the question about differe... [20:29:21] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3849352 (1001tonythomas) Well, I see that the counts are getting updated on all sub/unsub from http://newsletter-test.wmflabs.org/wiki/Special... [20:33:41] 04(no projects): Requesting account expiration extension - https://phabricator.wikimedia.org/T183291#3849363 (10Jdcc-berkman) [20:34:28] (03CR) 10Bmansurov: [C: 032] "Yes, looks good!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [20:36:40] (03CR) 10jerkins-bot: [V: 04-1] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [20:37:52] (03CR) 10Bmansurov: [C: 031] Toggle the Beta toggle when user clicks on label [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/398889 (https://phabricator.wikimedia.org/T169807) (owner: 10Pmiazga) [20:39:47] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849378 (10bmansurov) OK, I'll follow up with user agents of those browsers. [20:42:23] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3849381 (10Pppery) Ok, there does seem to have been a misunderstanding. I was referring to manual edits to subscribers via Special:Newsletter/... [20:43:23] (03PS5) 10Niedzielski: WIP: add support for page transitions [marvin] - 10https://gerrit.wikimedia.org/r/398541 (https://phabricator.wikimedia.org/T179489) [20:43:31] 10UI-Standardization, 10MobileFrontend, 10Patch-For-Review, 10UI-Standardization-Kanban: Arrows for close icon and arrow icons are the wrong size MobileFrontend MMV overlay - https://phabricator.wikimedia.org/T108657#3849384 (10matmarex) [20:46:58] 10Marvin: Add immediate, short, long, and failure page transitions - https://phabricator.wikimedia.org/T179493#3849397 (10Niedzielski) [20:47:00] 10Design, 10Marvin, 10Epic: Page switching interaction - https://phabricator.wikimedia.org/T177004#3849398 (10Niedzielski) [20:47:02] 10Marvin, 10Patch-For-Review: Add support for page transitions - https://phabricator.wikimedia.org/T179489#3849394 (10Niedzielski) 05Open>03stalled a:05Niedzielski>03None I tried to make this library work for us but ultimately failed. There seem to be a number of weird timing bugs, particularly when ra... [20:47:25] (03CR) 10Dbrant: [C: 032] Remove old framework for synchronizing user options. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398065 (owner: 10Dbrant) [20:50:00] 10Marvin: Page URL should update on redirect - https://phabricator.wikimedia.org/T177681#3849413 (10Niedzielski) a:05Niedzielski>03None [20:51:11] (03Merged) 10jenkins-bot: Remove old framework for synchronizing user options. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398065 (owner: 10Dbrant) [20:51:57] (03PS4) 10Pppery: Add issue count column to Special:Newsletters [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399096 (https://phabricator.wikimedia.org/T180979) [20:53:35] (03CR) 10Hoo man: [C: 032] Replace class_exists with proper extension registration checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/398794 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [20:54:03] 10iOS-app-v5.7.3-Corgi-On-A-Moose: Release 5.7.3. (1296) - https://phabricator.wikimedia.org/T182709#3849431 (10JoeWalsh) [20:55:27] (03CR) 10jenkins-bot: Remove old framework for synchronizing user options. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398065 (owner: 10Dbrant) [20:55:57] (03Merged) 10jenkins-bot: Replace class_exists with proper extension registration checks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/398794 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [20:59:29] (03PS1) 10MaxSem: Add CodeMirror support [extensions/CharInsert] - 10https://gerrit.wikimedia.org/r/399257 (https://phabricator.wikimedia.org/T179287) [20:59:43] kaldari: ^ [21:00:17] (03PS5) 10MaxSem: Fix target detection for jquery.textSelection overrides [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/397631 (https://phabricator.wikimedia.org/T177175) [21:02:33] (03PS2) 10Esanders: build: Update stylelint-config-wikimedia to 0.4.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399247 (owner: 10Catrope) [21:05:41] 10MediaWiki-extensions-UniversalLanguageSelector: The language code 'de-DE' is ignored in Accept-Language HTTP header - https://phabricator.wikimedia.org/T183295#3849475 (10Fomafix) [21:06:58] 10OOjs-UI, 10Patch-For-Review: Release OOUI v0.24.4 with some backported patches - https://phabricator.wikimedia.org/T183195#3849487 (10matmarex) [21:08:04] (03CR) 10Esanders: [C: 032] Remove editor switching infrastructure in favor of VE's source mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [21:10:20] 10OOjs-UI, 10Patch-For-Review: Issues with OOUI menus/popups that open upwards being overlapped by things - https://phabricator.wikimedia.org/T183069#3842598 (10matmarex) [21:10:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/399258 (owner: 10L10n-bot) [21:10:56] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not update subscriber count - https://phabricator.wikimedia.org/T183189#3849506 (10Pppery) This task is looking a bit more complicated than I had originally reported it as. 1: Submitting the manual subscribers for... [21:11:24] 10Proton, 10Readers-Web-Backlog, 10Readers-Web-Kanban-Board, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3849507 (10bmansurov) Here are the list of user agents of that browsers that are based on Chr... [21:11:34] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not properly update subscriber count - https://phabricator.wikimedia.org/T183189#3849508 (10Pppery) [21:15:21] (03CR) 10Aaron Schulz: Prevent write operations to database replicas. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399208 (https://phabricator.wikimedia.org/T183265) (owner: 10Daniel Kinzler) [21:15:40] (03Merged) 10jenkins-bot: Remove editor switching infrastructure in favor of VE's source mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [21:15:54] (03CR) 10jenkins-bot: Remove editor switching infrastructure in favor of VE's source mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) (owner: 10Catrope) [21:20:16] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review, 10Regression: Scrolling the translation editor makes the publish button unreachable - https://phabricator.wikimedia.org/T174138#3849520 (10Esanders) >>! In T174138#3718982, @santhosh wrote: > This regression was caused by https://gerrit.wik... [21:24:24] (03CR) 10Bmansurov: "Marko, any ideas why we're getting these errors?" [services/chromium-render] - 10https://gerrit.wikimedia.org/r/394623 (owner: 10Bmansurov) [21:29:32] (03CR) 10Bmansurov: [C: 032] "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [21:31:53] (03CR) 10jerkins-bot: [V: 04-1] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [21:33:32] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3849533 (10Volker_E) [21:33:46] (03CR) 10jerkins-bot: [V: 04-1] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [21:35:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399284 (owner: 10L10n-bot) [21:38:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/399292 (owner: 10L10n-bot) [21:41:32] 10Patch-For-Review, 10Spike, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [SPIKE] Investigate framework for full-screen macro+screenshot tests. - https://phabricator.wikimedia.org/T176860#3849547 (10cooltey) Will look for some other apps also using the Espresso Tests for automated UI Tes... [21:48:38] 10MediaWiki-Codesniffer: phpcbf formatting error - https://phabricator.wikimedia.org/T183298#3849568 (10MarkAHershberger) [21:53:04] 10MediaWiki-General-or-Unknown, 10OOjs-UI: Replace and deprecate CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T183299#3849583 (10Volker_E) [21:55:53] (03PS3) 10Serraboof: fix adaptive icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/399198 (https://phabricator.wikimedia.org/T174301) [21:58:15] 10MediaWiki-API: Use list=blocks to return all single IP blocks in a CIDR - https://phabricator.wikimedia.org/T183300#3849598 (10Samtar) [21:59:19] (03PS3) 10Dbrant: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398883 (owner: 10L10n-bot) [22:00:33] 10MediaWiki-API: Use list=blocks to return all single IP blocks in a CIDR - https://phabricator.wikimedia.org/T183300#3849610 (10Samtar) [22:09:01] 10MediaWiki-Interwiki, 10MediaWiki-extensions-Interlanguage, 10MediaWiki-extensions-Interwiki, 10Wikimedia-Interwiki-links: be-tarask interlanguage link goes to be-x-old wiki rather than be-tarask wiki - https://phabricator.wikimedia.org/T183301#3849619 (10Dvorapa) [22:11:41] 10MediaWiki-General-or-Unknown, 10OOjs-UI: Replace and deprecate CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T183299#3849631 (10Volker_E) [22:11:44] 10Design, 10OOjs-UI, 10UI-Standardization: Improve tag component (“TagMultiselectWidget”, former “CapsuleMultiselectWidget“) - https://phabricator.wikimedia.org/T158400#3849630 (10Volker_E) [22:12:11] 10Phabricator, 10Developer-Relations: Find best way to allow CoC committee to temporarily disable Phab user accounts - https://phabricator.wikimedia.org/T183116#3849632 (10mmodell) Contacting a phab admin in a private way could be done via [[ /conpherence | conpherence ]] or private tasks somewhat like securit... [22:15:34] (03CR) 10Dbrant: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398883 (owner: 10L10n-bot) [22:18:02] 10MediaWiki-Interwiki, 10MediaWiki-Parser, 10MediaWiki-extensions-Interlanguage, 10MediaWiki-extensions-Interwiki, 10Wikimedia-Interwiki-links: be-tarask interlanguage link goes to be-x-old wiki rather than be-tarask wiki - https://phabricator.wikimedia.org/T183301#3849640 (10Dvorapa) [22:18:29] 10OOjs-UI, 10Tracking: TagMultiselectWidget (earlier CapsuleMultiselectWidget): UX and functionality improvements - https://phabricator.wikimedia.org/T119044#3849642 (10Volker_E) [22:19:22] (03PS1) 10Mooeypoo: RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 [22:19:26] 10MediaWiki-Parser, 10Wikimedia-Interwiki-links: be-tarask interlanguage link goes to be-x-old wiki rather than be-tarask wiki - https://phabricator.wikimedia.org/T183301#3849644 (10TTO) No need for all the projects, #wikimedia-interwiki-links is quite enough :) I wonder if we need to remove https://phabricat... [22:20:29] 10MediaWiki-Parser, 10Wikimedia-Interwiki-links: be-tarask interlanguage link goes to be-x-old wiki rather than be-tarask wiki - https://phabricator.wikimedia.org/T183301#3849655 (10TTO) >>! In T183301#3849644, @TTO wrote: > I wonder if we need to remove https://phabricator.wikimedia.org/diffusion/EWMA/browse/... [22:21:04] (03PS2) 10Mooeypoo: RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 [22:22:00] 10UI-Standardization, 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3849666 (10matmarex) [22:23:48] 10OOjs-UI, 10Tracking: TagMultiselectWidget (earlier CapsuleMultiselectWidget): UX and functionality improvements - https://phabricator.wikimedia.org/T119044#3849672 (10Volker_E) [22:23:50] 10OOjs-UI: Let you drag items in a CapsuleMultiselectWidget to re-order them - https://phabricator.wikimedia.org/T108490#3849670 (10Volker_E) 05Open>03declined [[ https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#TagMultiselectWidget-allowArbitrary-... [22:25:12] 10MediaWiki-Parser, 10Wikimedia-Interwiki-links: be-tarask interlanguage link goes to be-x-old wiki rather than be-tarask wiki - https://phabricator.wikimedia.org/T183301#3849674 (10TTO) [22:25:14] 10MediaWiki-extensions-WikimediaMaintenance, 10Wikimedia-Site-requests, 10Patch-For-Review, 10WMF-deploy-2015-09-01_(1.26wmf21), and 2 others: The href of be-tarask: interlanguage link points to the be-x-old domain - https://phabricator.wikimedia.org/T111853#3849677 (10TTO) [22:26:24] 10OOjs-UI: Let you specify that a TagMultiselectWidget has a fixed order - https://phabricator.wikimedia.org/T108491#3849678 (10Volker_E) [22:27:00] 10UI-Standardization, 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3849679 (10matmarex) I added before/after screenshots of monospaced/sans-serif edit field fonts to the description, for Windows and Ubuntu. (The labels say "Chrome" but technically it was... [22:27:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/398883 (owner: 10L10n-bot) [22:27:22] 10OOjs-UI: Let you specify that a TagMultiselectWidget has a fixed order - https://phabricator.wikimedia.org/T108491#1521804 (10Volker_E) In regards to T183299 let's focus on TagMultiselectWidget only. [22:28:06] (03CR) 10jerkins-bot: [V: 04-1] RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 (owner: 10Mooeypoo) [22:28:25] (03CR) 10Bartosz Dziewoński: [C: 032] Unify monospace font family stack [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:28:29] 10MediaWiki-General-or-Unknown, 10OOjs-UI: Replace and deprecate CapsuleMultiselectWidget - https://phabricator.wikimedia.org/T183299#3849583 (10Volker_E) [22:28:36] (03CR) 10Bartosz Dziewoński: "Wrong button :)" [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:29:00] (03PS2) 10Bartosz Dziewoński: Unify monospace font family stack [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:29:20] (03CR) 10Bartosz Dziewoński: "PS2 removes the part of this commit that is being handled in https://gerrit.wikimedia.org/r/#/c/396005/" [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:29:56] 10MediaWiki-Parser, 10MediaWiki-extensions-WikimediaMaintenance, 10Wikimedia-Interwiki-links, 10Wikimedia-Site-requests, and 4 others: The href of be-tarask: interlanguage link points to the be-x-old domain - https://phabricator.wikimedia.org/T111853#3849684 (10Dvorapa) [22:30:07] 10OOjs-UI, 10Tracking: TagMultiselectWidget (earlier CapsuleMultiselectWidget): UX and functionality improvements - https://phabricator.wikimedia.org/T119044#3849685 (10Volker_E) [22:30:10] 10Design, 10MediaWiki-General-or-Unknown, 10Multimedia, 10Tracking: Design improvements for mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115858#3849686 (10Volker_E) [22:30:27] 10OOjs-UI, 10Tracking: TagMultiselectWidget (earlier CapsuleMultiselectWidget): UX and functionality improvements - https://phabricator.wikimedia.org/T119044#1816467 (10Volker_E) Related to T115858, but not a parent task. [22:30:37] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 3 others: Detect when CirrusSearch is used without curl and fail gracefully - https://phabricator.wikimedia.org/T166355#3849691 (10Reedy) >>! In T166355#3848240, @Phantom42 wrote: > And one more thing: looks like after adding `ext-curl` to `compo... [22:31:32] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: Secure login notice on new vagrant install - https://phabricator.wikimedia.org/T183302#3849692 (10Smalyshev) p:05Triage>03Normal [22:34:06] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: https does not seem to be working on vagrant - bad gateway - https://phabricator.wikimedia.org/T183304#3849712 (10Smalyshev) p:05Triage>03Normal [22:34:45] (03PS5) 10Bartosz Dziewoński: Standardize editfont size across browsers/OSes [core] - 10https://gerrit.wikimedia.org/r/396005 (https://phabricator.wikimedia.org/T176636) (owner: 10Esanders) [22:34:51] (03PS3) 10Bartosz Dziewoński: Unify monospace font family stack [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:35:10] (03CR) 10Bartosz Dziewoński: [C: 032] Unify monospace font family stack [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:35:21] (03PS3) 10Mooeypoo: RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 [22:36:08] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: elasticsearch package missing for geodata_elastic role - https://phabricator.wikimedia.org/T183305#3849727 (10Smalyshev) p:05Triage>03Normal [22:36:43] (03PS4) 10Mooeypoo: RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 [22:37:38] (03CR) 10Chad: [C: 032] Help icon is a bit weirdly aligned [skins/Timeless] - 10https://gerrit.wikimedia.org/r/394132 (https://phabricator.wikimedia.org/T173186) (owner: 10Framawiki) [22:38:09] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: packages are missing for cirrussearch role - https://phabricator.wikimedia.org/T183306#3849740 (10Smalyshev) p:05Triage>03Normal [22:40:15] 10MediaWiki-Vagrant, 10Epic, 10User-zeljkofilipin: wikidata role produces error when trying to create item - https://phabricator.wikimedia.org/T183307#3849757 (10Smalyshev) p:05Triage>03Normal [22:40:28] 10MediaWiki-Vagrant, 10User-zeljkofilipin: wikidata role produces error when trying to create item - https://phabricator.wikimedia.org/T183307#3849757 (10Smalyshev) [22:40:28] Hello everyone! [22:40:49] 10MediaWiki-Vagrant, 10User-zeljkofilipin: Secure login notice on new vagrant install - https://phabricator.wikimedia.org/T183302#3849769 (10Smalyshev) [22:41:00] 10MediaWiki-Vagrant, 10User-zeljkofilipin: https does not seem to be working on vagrant - bad gateway - https://phabricator.wikimedia.org/T183304#3849770 (10Smalyshev) [22:41:10] 10MediaWiki-Vagrant, 10User-zeljkofilipin: elasticsearch package missing for geodata_elastic role - https://phabricator.wikimedia.org/T183305#3849771 (10Smalyshev) [22:41:23] 10MediaWiki-Vagrant, 10User-zeljkofilipin: packages are missing for cirrussearch role - https://phabricator.wikimedia.org/T183306#3849772 (10Smalyshev) [22:41:28] 10ContentTranslation, 10MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 10Patch-For-Review, 10WorkType-NewFunctionality: there is no comfortable way to insert a new category in ContentTranslation - https://phabricator.wikimedia.org/T134740#2275539 (10Volker_E) @santhosh This seems to be resol... [22:41:35] (03Merged) 10jenkins-bot: Unify monospace font family stack [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:42:15] (03CR) 10jerkins-bot: [V: 04-1] Help icon is a bit weirdly aligned [skins/Timeless] - 10https://gerrit.wikimedia.org/r/394132 (https://phabricator.wikimedia.org/T173186) (owner: 10Framawiki) [22:44:28] 10MediaWiki-Parser, 10Parsoid: Whitespace between == == headers should be insignificant - https://phabricator.wikimedia.org/T47803#3849781 (10matmarex) [22:44:42] (03CR) 10jerkins-bot: [V: 04-1] RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 (owner: 10Mooeypoo) [22:47:45] 10MediaWiki-Parser, 10Community-Liaisons, 10Parsoid, 10Tidy: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" - https://phabricator.wikimedia.org/T157418#3004575 (10matmarex) Long, long ago, I made this happen for headings: T47803 (the extra spaces were interfering... [22:52:15] 10Discovery, 10Discovery-Analysis (Current work): Search Relevance Survey test #3: analysis of test - https://phabricator.wikimedia.org/T175048#3849795 (10mpopov) Alrighty, here ya go! It's not as pretty as you were probably expecting! {F11939879} [22:52:23] (03CR) 10jenkins-bot: Unify monospace font family stack [core] - 10https://gerrit.wikimedia.org/r/381145 (https://phabricator.wikimedia.org/T176636) (owner: 10VolkerE) [22:52:28] (03CR) 10Smalyshev: "It's indeed 3 table merge, but with primary keys, so it should be OK (I checked it manually on the db and it worked ok for me). I could ru" [core] - 10https://gerrit.wikimedia.org/r/392173 (https://phabricator.wikimedia.org/T173980) (owner: 10Smalyshev) [22:55:17] 10MediaWiki-Parser, 10Community-Liaisons, 10Parsoid, 10Tidy: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" - https://phabricator.wikimedia.org/T157418#3849803 (10ssastry) >>! In T157418#3849785, @matmarex wrote: > Long, long ago, I made this happen for headings:... [22:56:49] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Regression: [BUG][REGRESSION] When offline in the feed, a message and call to action should be shown to attempt reload - https://phabricator.wikimedia.org/T183308#3849805 (10RHo) [22:57:32] (03PS4) 10EBernhardson: Silently drop unknown titles in completion search [core] - 10https://gerrit.wikimedia.org/r/398192 (https://phabricator.wikimedia.org/T115756) [22:57:36] (03PS1) 10EBernhardson: Push pagination decision for prefix search into SearchEngine [core] - 10https://gerrit.wikimedia.org/r/399312 [22:57:39] 10MediaWiki-Parser, 10Community-Liaisons, 10Parsoid, 10Tidy: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" - https://phabricator.wikimedia.org/T157418#3849822 (10ssastry) [22:57:49] (03PS1) 10SamanthaNguyen: Avoid use of $wgOut global in UserProfilePage [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/399313 [23:02:01] (03CR) 10VolkerE: [C: 032] build: Update stylelint-config-wikimedia to 0.4.2 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399247 (owner: 10Catrope) [23:02:48] Albert221: Hey! [23:03:38] (03PS5) 10Mooeypoo: RCFilters: Only normalize title with 'target' when it is needed [core] - 10https://gerrit.wikimedia.org/r/399310 [23:04:07] 10MediaWiki-Codesniffer: Detect use of create_function with codesniffer - https://phabricator.wikimedia.org/T181865#3849839 (10Legoktm) 05Open>03Resolved [23:04:21] 10MediaWiki-Codesniffer: CodeSniffer to warn against usages of extract() - https://phabricator.wikimedia.org/T180398#3849841 (10Legoktm) 05Open>03Resolved [23:04:26] 10MediaWiki-Codesniffer: Add sniff to prefer short is_int over is_integer - https://phabricator.wikimedia.org/T173175#3849842 (10Legoktm) 05Open>03Resolved [23:08:27] 10MediaWiki-Parser, 10Community-Liaisons, 10Parsoid, 10Tidy: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" - https://phabricator.wikimedia.org/T157418#3849847 (10matmarex) The space between the heading and the "[edit]" link would be larger. | {F11940412,size=ful... [23:09:17] (03Merged) 10jenkins-bot: build: Update stylelint-config-wikimedia to 0.4.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399247 (owner: 10Catrope) [23:09:31] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog: [Feature Request] Return current timestamp in /changes/since - https://phabricator.wikimedia.org/T182706#3831949 (10Tgr) First of all, the timestamps actually have second precision, not millisecond like the example suggests (but there was no way to... [23:09:33] (03CR) 10jenkins-bot: build: Update stylelint-config-wikimedia to 0.4.2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/399247 (owner: 10Catrope) [23:12:42] (03CR) 10Legoktm: [C: 032] Remove empty RevisionRecordTest [core] - 10https://gerrit.wikimedia.org/r/399235 (https://phabricator.wikimedia.org/T183219) (owner: 10Addshore) [23:18:49] (03Merged) 10jenkins-bot: Remove empty RevisionRecordTest [core] - 10https://gerrit.wikimedia.org/r/399235 (https://phabricator.wikimedia.org/T183219) (owner: 10Addshore) [23:20:22] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Regression: [BUG][REGRESSION] When offline in the feed, a message and call to action should be shown to attempt reload - https://phabricator.wikimedia.org/T183308#3849873 (10RHo) [23:22:14] 10MediaWiki-Parser, 10Community-Liaisons, 10Parsoid, 10Tidy: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" - https://phabricator.wikimedia.org/T157418#3849874 (10ssastry) >>! In T157418#3849847, @matmarex wrote: > The space between the heading and the "[edit]" li... [23:22:45] 10MediaWiki-Parser, 10Community-Liaisons, 10Parsoid, 10Tidy: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" - https://phabricator.wikimedia.org/T157418#3849877 (10ssastry) [23:24:05] 10ContentTranslation, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Dashboard: box-shadow visible between "New translation" dialog and suggestion/translation lists - https://phabricator.wikimedia.org/T182193#3849881 (10Petar.petkovic) [23:24:16] 10Wikimedia-Wikimania-Scholarships: text content of scholarships.wikimedia.org is stale by 1 year in british english - https://phabricator.wikimedia.org/T157980#3849883 (10bd808) @Niharika yes, in the past I've done `git rm ` and a local commit in the deploy directory on tin and then synced out again. [23:25:50] 04(no projects): Requesting account expiration extension - https://phabricator.wikimedia.org/T183291#3849884 (10Aklapper) Accounts where exactly? Which project is this about? :) [23:26:38] How can I get more results from this API query? /w/api.php?action=query&format=json&errorformat=bc&list=embeddedin&eititle=Template%3ACoord [23:27:02] (03CR) 10jenkins-bot: Remove empty RevisionRecordTest [core] - 10https://gerrit.wikimedia.org/r/399235 (https://phabricator.wikimedia.org/T183219) (owner: 10Addshore) [23:34:37] Can a mentor or maintainer run "recheck" for https://gerrit.wikimedia.org/r/#/c/399134/ ? [23:37:23] (03CR) 10EBernhardson: [C: 04-1] "I've added a patch in front of this one that adjusts how pagination is determined, so this patch no longer breaks prefix search pagination" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/398192 (https://phabricator.wikimedia.org/T115756) (owner: 10EBernhardson) [23:38:10] LocationCrawl: for this query, 'eilimit=max'. https://www.mediawiki.org/wiki/API:Embeddedin [23:38:15] treetor10145: done [23:38:39] thank you! [23:40:53] MatmaRex: Doing 'elicit=max' still only gives 4 results [23:41:57] LocationCrawl: eilimit=max, not elicit [23:42:10] LocationCrawl: if you're spelling it right and it gives only 4 results, then there are only 4 results [23:42:16] yeah typo in the message [23:47:40] (03CR) 10Pmiazga: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [23:49:14] (03Restored) 10BryanDavis: Add feature flag for Special:UsersWhoWillBeRenamed [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/267550 (https://phabricator.wikimedia.org/T118637) (owner: 10BryanDavis) [23:49:43] (03CR) 10jerkins-bot: [V: 04-1] Inline lists in new print styles should not have a smaller font size than surrounding content [skins/Vector] - 10https://gerrit.wikimedia.org/r/398445 (https://phabricator.wikimedia.org/T178667) (owner: 10Eflyjason) [23:50:07] (03CR) 10BryanDavis: "> Could someone please restore this patch? (I'm not able to)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/267550 (https://phabricator.wikimedia.org/T118637) (owner: 10BryanDavis) [23:53:13] 10MediaWiki-Vagrant, 10User-zeljkofilipin: Secure login notice on new vagrant install - https://phabricator.wikimedia.org/T183302#3849911 (10Tgr) `$wgSecureLogin` is set by the `https` role which also tries to override `$wgServer` to be protocol-relative (apparently unsuccessfully). The code block to debug is... [23:59:11] (03CR) 10MarkAHershberger: "The oldest currently supported version of MediaWiki is 1.27 which requires PHP 5.59. The new array syntax is supported in PHP 5.4+." [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/398520 (owner: 10MarkAHershberger)