[00:00:38] prtksxna, hey, are you there? :) [00:03:19] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 4 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824451 (10Reedy) Fancy testing that patch? [00:05:20] Volker_E, hey, are you here? :) [00:05:39] FlorianSW, hello! [00:06:15] (03CR) 10Kghbln: [C: 031] "Affirmative, the patch set works. I just successfully tested this on a MW 1.27. Thank you!" [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) (owner: 10Reedy) [00:07:30] (03PS2) 10Reedy: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) [00:07:57] (03CR) 10Reedy: [C: 032] "I'm confused why I missed that on the original backport :/" [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) (owner: 10Reedy) [00:08:12] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 4 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824470 (10Kghbln) > Fancy testing that patch? @Reedy Works for me! T... [00:08:37] 10MediaWiki-API, 10Reading-Infrastructure-Team-Backlog, 10TechCom: Handling of structured data input in MediaWiki APIs - https://phabricator.wikimedia.org/T182475#3824471 (10Tgr) [00:09:59] (03CR) 10Kghbln: "Do not worry. All fine now. :)" [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) (owner: 10Reedy) [00:11:41] 10Support-and-Safety, 10Wikimedia-Site-requests: Disable 2FA for EVinente - https://phabricator.wikimedia.org/T182373#3824490 (10Jalexander) 05Open>03Resolved done :) thanks RadiX [00:13:07] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 3 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824492 (10Reedy) 05Open>03Resolved a:03Reedy [00:14:12] (03Abandoned) 10Reedy: Revert "objectcache: Make WANObjectCache interim caching not interfere with ChronologyProtector" [core] - 10https://gerrit.wikimedia.org/r/396443 (https://phabricator.wikimedia.org/T182322) (owner: 10Reedy) [00:14:14] (03Abandoned) 10Reedy: Revert "Make ChronologyProtector actually use cpPosTime cookies" [core] - 10https://gerrit.wikimedia.org/r/396444 (https://phabricator.wikimedia.org/T182322) (owner: 10Reedy) [00:14:20] (03Abandoned) 10Reedy: Revert "Make ChronologyProtector actually use cpPosTime cookies" [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396446 (https://phabricator.wikimedia.org/T182322) (owner: 10Reedy) [00:14:24] (03Abandoned) 10Reedy: Revert "objectcache: Make WANObjectCache interim caching not interfere with ChronologyProtector" [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396445 (https://phabricator.wikimedia.org/T182322) (owner: 10Reedy) [00:14:30] (03Merged) 10jenkins-bot: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) (owner: 10Reedy) [00:16:12] 10MediaWiki-API, 10Reading-Infrastructure-Team-Backlog, 10TechCom: Handling of structured data input in MediaWiki APIs - https://phabricator.wikimedia.org/T182475#3824502 (10Tgr) [00:16:14] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog: Batch reading list operations - https://phabricator.wikimedia.org/T182052#3824501 (10Tgr) [00:17:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code nan-hani, cdo-hani, hak-hans, hak-hant, zh-nshu, ja-hant - https://phabricator.wikimedia.org/T180771#3824504 (10C933103) [00:20:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Easy, 10Need-volunteer: Add monolingual language code nan-hani, cdo-hani, hak-hans, hak-hant, zh-nshu, ja-hant - https://phabricator.wikimedia.org/T180771#3824506 (10C933103) [00:21:24] (03CR) 10jenkins-bot: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) (owner: 10Reedy) [00:21:38] How can I compile Less code in Echo extension? `grunt` only lints it [00:21:55] https://phabricator.wikimedia.org/diffusion/ECHO/browse/master/ [00:22:20] isn't it done on the fly, when you view pages? [00:24:24] (03PS1) 10EBernhardson: Port update_weight_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396552 [00:31:04] (03CR) 10Kaldari: "Needs a rebase" [core] - 10https://gerrit.wikimedia.org/r/391342 (https://phabricator.wikimedia.org/T138165) (owner: 10Dbarratt) [00:31:07] Reedy, hm, didn't think about that [00:31:09] 10OOjs-UI: ToggleSwitchWidget should be compatible with forms - https://phabricator.wikimedia.org/T182466#3824079 (10matmarex) The convention is that only widgets that are subclasses of InputWidget (and whose names end in 'InputWidget') are compatible with HTML `
`s. Note that even if we were to ignore thi... [00:31:33] is there any way I could generate a fake notification? [00:31:51] like CLI command or something? records in DB looks like to be too complicated for filling by hand [00:33:45] Depends what you're trying to do [00:33:54] Doesn't reverting edits cause notifications? [00:52:17] (03CR) 10Brian Wolff: [C: 04-1] Replace instances of rawParams() to plaintextParams() (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T180987) (owner: 10Divadsn) [00:52:57] (03CR) 10Divadsn: "Ah, ok, now I get it :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T180987) (owner: 10Divadsn) [00:53:28] (03PS2) 10Divadsn: Replace instances of rawParams() to plaintextParams() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T180987) [00:53:38] looks like this LESS code is somehow ran in the browser and somehow not. I cleared all the cache and temporary data and everything but I still don't see my change :( [00:54:11] divadsn: Also, I think you have the wrong bug number on that change [00:54:32] OH [00:54:47] Albert221: So LESS is converted to CSS in php, and then the CSS is given to browser [00:55:05] Albert221: So there is both MediaWiki's cache, and your browsers cache [00:55:34] Sometimes if you are using vagrant where all the files are over nfs cache clearing doesn't work right on mediawiki's side [00:55:45] Sorry, haven't noticed that, seems I have copy&pasted from a wrong URL bawolff ^^" [00:55:59] (03PS3) 10Divadsn: Replace instances of rawParams() to plaintextParams() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T182213) [00:56:02] I'm using XAMPP. My wikimedia-core/cache directory is empty [00:56:25] Albert221: The cache directory is for a different type of cache. which is disabled by default [00:56:47] Albert221: MediaWiki has like 6 billion caching layers [00:56:51] bawolff, I've fixed that, but is now gerritbot also deleting the comment on the other task? [00:57:03] Try and make an edit to LocalSettings.php, that often clears the cache [00:57:13] divadsn: no, but don't worry about that [00:57:45] Albert221: If making an edit to LocalSettings.php doesn't clear the cache, try switching to debug mode (add ?debug=1 or &debug=1 to the end of the url you are looking at) [00:58:33] Oh ok, nevermind, I will redo the same task with another extension tomorrow, now I got the difference between text, escaped, rawParams, and plaintextParams ^^ [00:58:51] okaay, ?debug=1 worked just fine [00:59:29] if I'll remove that parameter, CSS changes to its original state, nonetheless, change works [01:00:27] but I can't believe MediaWiki doesn't have any "Clear cache" button for LESS or everything. Only script for LESS i see is checkLess which just validates it [01:01:00] divadsn: hmm, I would normally use ->escaped() there, but ->parse() is probably fine too [01:01:22] Albert221: In this case it would be ResourceLoader cache [01:01:39] Albert221: In theory its supposed to autoclear [01:02:14] upon detection of the file timestamp changing [01:02:49] Maybe the cache clearing doesn't work properly on windows or something. [01:03:03] Didn't we have a global to make it always debug mode? [01:03:18] yeah, but I think that's not the solution for this problem [01:04:07] Yes it is [01:04:18] The cache will expire after a short amount of time [01:04:20] That's it's purpose [01:04:28] Yeah, there's a global somewhere [01:04:29] I meant for the lack of clearing cache [01:04:43] manually [01:04:54] There's various scripts for purging various caches [01:05:16] I searched, didn't found less's one [01:05:41] Because you don't need one [01:06:10] while ago I was in need of one :/ [01:06:59] $wgResourceLoaderDebug = true; [01:07:14] bawolff, what's the exact difference between parse and escaped? [01:07:48] And Reedy, can you tell me again how can I clone all extensions at once? I can't remember how it was from last year :D [01:08:01] checkout medawiki/extensions.git [01:08:04] *clone [01:08:07] divadsn: Parse treats things like wikitext - so if you do '''foo''' then foo become bold. If you do [[bar]] then bar becomes a link [01:08:10] git submodule update --init --recursive [01:08:23] ->escaped() is like doing ->text() and wrapping it in htmlspecialchars [01:08:36] (03PS1) 10EBernhardson: Port remaining dump_* features to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396553 [01:08:45] bawolff, ah alright, I think parse would be then a better option maybe, or are the links there always html? [01:08:53] So it replaces stuff like {{SITENAME}} or {{GENDER:...}} but it doesn't convert most wikitext stuff [01:09:17] Thanks Reedy :3 [01:09:17] I was thinking escape() because the message only contains ($1) [01:09:32] and normally you wouldn't want parentheses being parsed, I think [01:09:45] And its also a subtitle, so not somewhere people would normally insert wikitext [01:09:58] otoh, it doesn't really matter, and I could see arguments for both ways [01:10:13] Exactly that was what I wanted to say ^^ [01:10:48] (03PS2) 10EBernhardson: Port remaining dump_* features to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396553 [01:11:13] (03PS1) 10Albert221: Better color to represent read notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/396554 (https://phabricator.wikimedia.org/T78594) [01:11:48] 10Accessibility, 10Collaboration-Team-Triage, 10Notifications, 10Easy, and 2 others: Fix insufficient difference between background colors for un/read notifications in the Echo flyout - https://phabricator.wikimedia.org/T78594#3824543 (10Albert221) a:03Albert221 [01:12:52] (03PS1) 10Cooltey: [WIP] Fix: Randomizer page rotate issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396555 (https://phabricator.wikimedia.org/T181456) [01:14:13] bawolff, so I think according to my grep there are no more rawInput instances in Newsletter extension [01:14:43] But will do a total list of rawInput instances after all extensions are cloned [01:15:06] So it's easier to find an extension for example :) [01:20:12] divadsn: There are other rawParams() examples in Newsletter [01:21:00] e.g. ->rawParams( $this->getEscapedName() ); could in theory be replaced by ->plaintextParams( $this->newsletter->getName() ) [01:22:14] (03CR) 10Brian Wolff: [C: 032] Replace instances of rawParams() to plaintextParams() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T182213) (owner: 10Divadsn) [01:24:01] (03Merged) 10jenkins-bot: Replace instances of rawParams() to plaintextParams() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T182213) (owner: 10Divadsn) [01:29:50] Is there anyone using Xdebug to debug mediawiki? [01:31:10] We use it for deployments [01:31:20] To test before they truly go into production [01:32:12] Um... No we don't [01:33:09] refeed[m]: Various people have... What's up? [01:33:34] I go play some games and then to sleep. Good night :) [01:35:48] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3824556 (10Bawolff) >>! In T182426#3824373, @Volker_E wrote: > Also, the revert commit message mentions a completely different reason and I don't unterstand why it was accepted wi... [01:38:19] (03CR) 10Catrope: [C: 032] Better color to represent read notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/396554 (https://phabricator.wikimedia.org/T78594) (owner: 10Albert221) [01:39:30] Reedy: Oh ok, idk why, I can't connect to it via my editor (vscode with xdebug). Still reading some blogs in Google on how they handle it [01:40:03] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3824560 (10Peachey88) [01:41:47] refeed[m]: Its definitely possible [01:41:56] refeed[m]: xdebug installed into your webserver? [01:42:11] I think some people may have done it, and vagrant somehow auto sets it up [01:42:17] But I've never used it myself [01:42:28] As in, vagrant auto sets it up for use with gdb or something [01:43:08] Reedy: yeah I think, I've followed the instructions in https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Advanced_usage#MediaWiki_debugging_using_Xdebug_and_an_IDE_in_your_host [01:44:39] bawolff: then how do you debug mediawiki ? (I never debug php application before) [01:45:43] var_dump() && die [01:45:43] Real devs don't make mistakes, their code just comes out perfect :P [01:45:50] (that's a joke btw) [01:46:05] kek :P [01:46:07] yep var_dump() solves all problems [01:46:31] Mediawiki also has a debug logging feature, but honestly I find it useless for local debugging [01:47:34] bawolff: but it prints all of the information in the html right? [01:48:19] (03Merged) 10jenkins-bot: Better color to represent read notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/396554 (https://phabricator.wikimedia.org/T78594) (owner: 10Albert221) [01:48:52] yep [01:49:01] or var_dump() does [01:49:35] Mediawiki logging facilities can be configured to do a whole bunch of things, one of the options is print on page (or in $wgDebugToolbar, although the debug toolbar sometimes doesn't seem to capture the whole log) [01:51:52] euhm, that's fine, I can live with it [01:56:15] refeed[m]: I wrote https://www.mediawiki.org/wiki/Manual:How_to_debug/with_MediaWiki-Vagrant_and_PHPStorm recently which is a bit less horrible than the rest of the debugging documentation [01:56:47] it's PHPStorm-specific but most other IDEs should handle it in a similar way [01:59:22] tgr: wow, thanks, I'll try it. didn't know there's a xdebug extension for browser [01:59:46] basically, you either need to set path mappings (xdebug will say "execution started in /var/www/w/index.php" and your IDE has to know that's actually C:\Users\Refeed\mediawiki\Xampp\index.php) or tell your IDE to break immediately and then walk through files by hand (very time-consuming) [02:01:02] 10Accessibility, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Easy, and 3 others: Fix insufficient difference between background colors for un/read notifications in the Echo flyout - https://phabricator.wikimedia.org/T78594#3824581 (10Catrope) [02:01:23] okay [02:01:37] if you don't use vagrant then you probably don't need the path mapping part but might need to configure xdebug yourself [02:02:28] which basically just needs enabling it, all the complex stuff with ports and whatnot mentioned in the other wiki page is not really necessary [02:03:15] https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/php/manifests/remote_debug.pp is how vagrant does it, fwiw [02:03:30] I jusy realized... 🤦🏻‍♂️ [02:03:45] Im thinking of xWikimediaDebug [02:07:54] tgr: okay, thanks for the link (now I know how vagrant did it, aha ), btw I'm gonna continue my xdebug setup [02:08:23] Zppix: xWikimediaDebug ? is thing like that actually exist? [02:09:04] refeed[m]: it's entirely unrelated [02:09:29] it just lets you target a specific backend server in wikimedia production [02:10:15] oh okay [02:10:41] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Experiment using phan for static analysis - https://phabricator.wikimedia.org/T181660#3824596 (10Bawolff) [02:12:42] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Experiment using phan for static analysis - https://phabricator.wikimedia.org/T181660#3797288 (10Legoktm) Can we implement a way to suppress false positives, e.g. @codingStandardsLineIgnore ? (using a different tag or something). Assuming the false positive rat... [02:14:53] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Experiment using phan for static analysis - https://phabricator.wikimedia.org/T181660#3824599 (10Bawolff) >>! In T181660#3824597, @Legoktm wrote: > Can we implement a way to suppress false positives, e.g. @codingStandardsLineIgnore ? (using a different tag or s... [02:15:15] legoktm: Already, gci students have fixed about 30 false positives :) [02:16:25] :D [02:19:05] 04(no projects): Remove justification from CX suggestion descriptions - https://phabricator.wikimedia.org/T182479#3824602 (10Petar.petkovic) [02:19:43] 10ContentTranslation, 10Language-2017-Oct-Dec: Remove justification from CX suggestion descriptions - https://phabricator.wikimedia.org/T182479#3824617 (10Petar.petkovic) [02:23:38] 10ContentTranslation, 10Language-2017-Oct-Dec: Remove justification from CX suggestion descriptions - https://phabricator.wikimedia.org/T182479#3824618 (10Petar.petkovic) p:05Triage>03Normal This ticket is continuation of discussions from [[https://gerrit.wikimedia.org/r/#/c/394553/|this patch]]. @Esander... [02:24:09] 10Security-Team: Get securityCheckPlugin on packagist - https://phabricator.wikimedia.org/T182214#3816715 (10Legoktm) Since this isn't really used anywhere yet, I'd like for us to reconsider the name. Since this is a phan plugin, I think that needs to be in the package name, e.g. "phan-security-plugin" (similar... [02:24:14] bawolff: ^ [02:24:29] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Get securityCheckPlugin on packagist - https://phabricator.wikimedia.org/T182214#3824623 (10Legoktm) [02:25:33] I'm totally fine with renaming security-check-plugin to something else. SecurityCheckPlugin is literally the most uninspired name ever [02:26:12] are you planning to expand this to anything other than HTML escaping? [02:27:35] legoktm: It already detects SQLi, shell injection and unserialization injection [02:27:47] But its probably going to stay with detecting injection type vulns [02:27:48] heh, I'm behind! [02:29:03] (03PS1) 10Legoktm: Rename to "mediawiki/phan-security-plugin" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396557 [02:29:16] Putting it in the MediaWiki packagist namespace seems odd to me, as its not really about MediaWiki per se, just something very useful to MediaWiki, but I guess it doesn't really matter [02:29:44] (03PS3) 10Mholloway: Hygiene: Fix README section on sepia HTTP recording [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396409 [02:29:52] (03PS2) 10Legoktm: Rename to "mediawiki/phan-security-plugin" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396557 [02:30:26] (03PS4) 10Mholloway: Hygiene: Fix README section on sepia HTTP recording [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396409 [02:30:28] Of the code base, about 75% is generic, and 25% is MW specific [02:30:32] well, it's a tool related and mostly built for MediaWiki right? [02:30:45] I mean, your intentions [02:31:50] Well intention wise, I'd love to see it used outside of the MediaWiki ecosystem, if it proves useful to people [02:32:20] But, the primary motivation is for mediawiki extensions, as that's in scope of my job, and writing random security tools for not mediawiki stuff is outside scope [02:32:33] up to you - I can switch it back if you want [02:32:40] But the MediaWiki part is really almost a specific configuration on top of the base tool [02:34:08] I think it might be comparable that way to wikimedia/composer-merge-plugin ? [02:34:58] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Special:ContentTranslation page: Mobile UI layout issues - https://phabricator.wikimedia.org/T179148#3824626 (10Petar.petkovic) Most of the problems were caused by too big space around actual content. That space is made smaller on mobile scre... [02:35:17] composer-merge-plugin has 0 MediaWiki specific code [02:35:55] I just don't want people to think its only usable by MediaWiki [02:36:37] I guess if it was really divided up, there would be a mediawiki part as a separate library that depends on the base library [02:37:01] Parse error: ./tests/integration/multiassign/test2.php:36 [02:37:04] Fatal error: Cannot redeclare Foo::echoThing() [02:37:21] is that on purpose? [02:37:57] all the tests are supposed to be run separately from each other, but beyond that no [02:38:21] that class has two functions named echoThing() [02:38:24] which is a parse error [02:38:32] legoktm: on the other hand, you know the packagist stuff much better than I do, and it really is a bikeshed thing, so lets do the mediawiki namespace [02:39:04] that's probably me being stupid then :) [02:39:24] The tests are static analysis, so they technically don't have to actually be valid php [02:40:25] Umm, phplint was just added, and I hadn't actually run it yet [02:40:44] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Special:ContentTranslation page: Mobile UI layout issues - https://phabricator.wikimedia.org/T179148#3824629 (10Petar.petkovic) [02:44:39] ok, I remember what was up. It was testing to make sure things weren't taking stuff in text order and I copied and pasted a bunc of stuff in the test [02:45:44] Guess I should test other people's patches before merging [02:46:51] (03PS1) 10Brian Wolff: Fix test that didn't pass lint [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396559 [02:48:08] 10ContentTranslation, 10Language-2017-Oct-Dec: dashboard: box-shadow between recently edited and suggestions - https://phabricator.wikimedia.org/T182193#3824630 (10Petar.petkovic) [02:48:10] (03PS1) 10Legoktm: Fix indentation in .phpcs.xml [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396560 [02:48:38] (03CR) 10Brian Wolff: [V: 032 C: 032] Rename to "mediawiki/phan-security-plugin" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396557 (owner: 10Legoktm) [02:48:50] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog, 10Patch-For-Review: Replace Sepia with Replayer - https://phabricator.wikimedia.org/T182459#3824633 (10bearND) @Pchelolo Not sure if it's anything preq related. I pushed a small test project to https://github.com/berndsi/replayer-test. [02:49:08] Oh hmm, just noticed the README has the wrong php version requirement (phan doesn't support php 7.1) [02:49:24] it has to be 7.0? [02:49:34] Yeah, [02:50:42] phan 0.8 requires php 7.0. I think there's some change in php-ast that is not backwards compatible [02:50:58] I havent tested with newer versions of phan [02:51:59] originally I thought this would be deployed with the existing phan infrastructure for MW so i targetted the version we currently use in CI. Now it looks like it would probably be done as a separate check, so i guess that doesn't matter as much [02:52:35] But to make this all work, I had to depend pretty heavily on the various methods that phan exposes, and I have no idea how much of a stable api phan maintains [02:53:04] hmm [02:53:40] well it looks like once 1.31 has 7.0 as minimum, we can use the normal composer stuff for phan [02:53:53] oh, but it would still break on 7.1, so I guess not [02:54:18] also, any reason you didn't use an autoloader? [02:54:27] (03CR) 10BearND: [C: 032] Hygiene: Fix lint errors [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396544 (owner: 10Mholloway) [02:55:21] legoktm: Laziness. Originally I thought it was only going to be two files and I didn't see the point. Then it kind of grew to be more files [02:55:37] I'll submit a patch [02:55:43] Originally I thought it would be much less code then it ended up being [02:55:50] heh [02:56:18] (03Merged) 10jenkins-bot: Hygiene: Fix lint errors [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396544 (owner: 10Mholloway) [02:58:12] (03PS1) 10Brian Wolff: Version should be php 7.0 (7.1 not supported due to dependency) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396561 [02:59:23] (03PS1) 10Legoktm: Use an autoloader [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396562 [02:59:28] (03CR) 10BearND: [C: 032] Stop suppressing RESTBase redirect handling when requesting HTML [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 (owner: 10Mholloway) [02:59:58] 04(no projects): Create a Phabricator project for Interaction Timeline - https://phabricator.wikimedia.org/T182480#3824639 (10Huji) [03:00:46] 10Phabricator, 10Anti-Harassment: Create a Phabricator project for Interaction Timeline - https://phabricator.wikimedia.org/T182480#3824650 (10Huji) p:05Triage>03Normal [03:01:18] (03Merged) 10jenkins-bot: Stop suppressing RESTBase redirect handling when requesting HTML [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 (owner: 10Mholloway) [03:04:00] (03PS1) 10Brian Wolff: Add a note about how it can't validate certain types of SQL [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396563 [03:05:19] (03PS1) 10Legoktm: Fix some typos [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396564 [03:06:24] let me set up CI for it now [03:07:54] (03CR) 10BearND: [C: 04-1] Hygiene: Fix README section on sepia HTTP recording (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396409 (owner: 10Mholloway) [03:08:08] (03CR) 10BearND: [C: 04-1] WIP: Dev: Replace Sepia with Replayer [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396428 (https://phabricator.wikimedia.org/T182459) (owner: 10BearND) [03:09:33] (03CR) 10BearND: [C: 032] Media: Add section ID numbers [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396085 (https://phabricator.wikimedia.org/T177430) (owner: 10Mholloway) [03:09:57] (03CR) 10Legoktm: "recheck" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396563 (owner: 10Brian Wolff) [03:10:17] (03CR) 10BearND: [C: 032] Media: Remove unwanted selectors from the blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396420 (https://phabricator.wikimedia.org/T177430) (owner: 10Mholloway) [03:11:24] (03Merged) 10jenkins-bot: Media: Add section ID numbers [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396085 (https://phabricator.wikimedia.org/T177430) (owner: 10Mholloway) [03:11:34] (03CR) 10Legoktm: "recheck" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396560 (owner: 10Legoktm) [03:11:38] (03CR) 10Legoktm: "recheck" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396562 (owner: 10Legoktm) [03:11:40] (03CR) 10Legoktm: "recheck" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396564 (owner: 10Legoktm) [03:12:28] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3824662 (10Bawolff) [03:12:52] (03CR) 10jerkins-bot: [V: 04-1] Media: Remove unwanted selectors from the blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396420 (https://phabricator.wikimedia.org/T177430) (owner: 10Mholloway) [03:13:11] (03CR) 10BearND: [C: 032] Summary: fix geo coordinates [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396095 (owner: 10Mholloway) [03:13:13] Hmm, I was thinking of turning that bug into a gci task as the students seemed to want harder bugs, but after writing out all the steps you'd have to go through, I'm thinking it might be too much [03:13:43] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Experiment using phan for static analysis - https://phabricator.wikimedia.org/T181660#3824665 (10Legoktm) [03:13:46] 10MediaWiki-SecurityCheckPlugin, 10Continuous-Integration-Config, 10Security-Team, 10Patch-For-Review, 10User-MarcoAurelio: Make jenkins run composer test (with php7) on mediawiki/tools/phan/SecurityCheckPlugin.git - https://phabricator.wikimedia.org/T182199#3824663 (10Legoktm) 05Open>03Resolved a:0... [03:14:24] no one has taken up my "add phan to an extension" task yet [03:14:49] (03Merged) 10jenkins-bot: Summary: fix geo coordinates [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396095 (owner: 10Mholloway) [03:14:52] 10Google-Code-in-2017: [User Script] Change font color to red and font face to bold - https://phabricator.wikimedia.org/T182481#3824667 (10Tuxology) [03:15:24] bawolff: i got a good task suggestion if you want to write one. [03:15:41] Zppix: what is it [03:15:48] Let me go grab again real quick [03:15:57] No promises I'll actually write it though [03:16:50] bawolff: T165069 [03:16:51] T165069: Update namespaceDupes.php documentation - https://phabricator.wikimedia.org/T165069 [03:17:31] 10Google-Code-in-2017: User script to change change font color to red and font face to bold - https://phabricator.wikimedia.org/T182481#3824678 (10Tuxology) [03:17:55] 10MediaWiki-Shell: Shell\Command should support providing standard input - https://phabricator.wikimedia.org/T182463#3824681 (10Legoktm) [03:18:19] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10Security-Team, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Support restricted execution of external commands (via firejail) - https://phabricator.wikimedia.org/T173370#3824683 (10Legoktm) [03:18:23] Zppix: I'm not sure that more needs to be documented beyond what --help outputs [03:18:33] 10MediaWiki-Shell: Investigate using firejail to replace limits.sh if it's installed - https://phabricator.wikimedia.org/T179021#3824684 (10Legoktm) [03:18:48] And there does exist https://www.mediawiki.org/wiki/Manual%3aNamespaceDupes.php [03:19:09] bawolff: ok [03:19:55] 10Design, 10ContentTranslation: Use grey for option row hover colour - https://phabricator.wikimedia.org/T178330#3824686 (10Petar.petkovic) [[https://gerrit.wikimedia.org/r/#/c/396565/|This patch]] has hacky methods it's using to make up for inability to transition gradients, so that gradient could stay unnoti... [03:20:03] 10MediaWiki-Platform-Team, 10MediaWiki-Shell, 10Operations: Update limit.sh to support systemd-based cgroup management - https://phabricator.wikimedia.org/T136603#3824687 (10Legoktm) [03:22:10] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), 10Patch-For-Review: GitInfo shell restriction of whitelisting paths is broken for git submodules - https://phabricator.wikimedia.org/T181919#3824688 (10Legoktm) [03:24:06] (03CR) 10BearND: [C: 032] "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396420 (https://phabricator.wikimedia.org/T177430) (owner: 10Mholloway) [03:26:24] (03Merged) 10jenkins-bot: Media: Remove unwanted selectors from the blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396420 (https://phabricator.wikimedia.org/T177430) (owner: 10Mholloway) [03:27:42] 10Contributors-Analysis: Calculate monthly mobile Wikipedia edits for Major Gifts report [due Dec 6] - https://phabricator.wikimedia.org/T180541#3824691 (10Neil_P._Quinn_WMF) 05Open>03Resolved Done! As before, the results are in [this spreadsheet](https://docs.google.com/spreadsheets/d/10Scs3cIhrpZRCKsjIeE06... [03:28:40] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review, and 4 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3824693 (10Addshore) >>! In T182322... [03:29:51] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review, and 4 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3824694 (10Addshore) This was fixed... [03:30:55] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review, and 4 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3824695 (10Addshore) 05Open>03Re... [03:31:05] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), and 5 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3824698 (10Addshore) [03:34:51] yay! finally xdebug works in my IDE https://imgur.com/a/i6F37 [03:43:09] refeed[m]: good job! [03:43:51] btw, may I document this somewhere? [03:44:18] Hmm let me find the approiate page [03:44:24] Is this an ext? [03:45:00] Zppix: yeah [03:45:09] let me see one min [03:45:53] okay +1 [03:46:21] refeed[m]: perhaps here https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Advanced_usage#MediaWiki_debugging_using_Xdebug_and_an_IDE_in_your_host [03:46:33] legoktm: ^ is that right? [03:47:38] btw tgr has made a page in https://www.mediawiki.org/wiki/Manual:How_to_debug/with_MediaWiki-Vagrant_and_PHPStorm for phpstorm, maybe I need to create a new page for vscode ? [03:48:04] I have no issue with that [03:48:20] 10MediaWiki-Language-converter, 10I18n: Korean Hanja to Hangul unidirectional conversion tool on Korean wikisource? - https://phabricator.wikimedia.org/T182482#3824703 (10C933103) [03:48:49] okay o/ [03:49:04] Ty for improving our documentation refeed[m] :) [03:50:20] no problem, I have many free time rn :) [03:52:13] 10MediaWiki-Language-converter, 10I18n: Korean Hanja to Hangul unidirectional conversion tool on Korean wikisource? - https://phabricator.wikimedia.org/T182482#3824713 (10C933103) 05Open>03Invalid [03:59:38] (03PS45) 10BearND: Change reference endpoint to return structured reference sections [services/mobileapps] - 10https://gerrit.wikimedia.org/r/370296 (https://phabricator.wikimedia.org/T170690) [04:08:46] 10Phabricator (Upstream), 10Upstream: Provide thumbnail of attached mock in task view - https://phabricator.wikimedia.org/T100537#3824721 (10mmodell) 05Open>03declined [04:09:17] 10Phabricator (Upstream), 10Upstream: Provide thumbnail of attached mock in task view - https://phabricator.wikimedia.org/T100537#1315120 (10mmodell) This is something that should be pursued upstream, I don't see wikimedia implementing this as a local hack. [04:15:44] refeed[m]: just create a page and we can rename it later :) [04:16:19] legoktm: after we do T1 right? :P [04:16:19] T1: Get puppet runs into logstash - https://phabricator.wikimedia.org/T1 [04:16:29] ? [04:16:57] It was supposed to be a joke about how we all are about documenting stuff [04:25:02] (03PS7) 10Sharvaniharan: Add DatePicker on on-this-day full screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) [04:43:55] (03CR) 10Liangent: [C: 032] Chinese Conversion Table Update 2017-5 [core] - 10https://gerrit.wikimedia.org/r/385331 (owner: 10Chiefwei) [04:47:22] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Get securityCheckPlugin on packagist - https://phabricator.wikimedia.org/T182214#3824723 (10bd808) If a rename is in the offing, I'd also say that "security" is vague and "mediawiki/phan-taint-check-plugin" or something along those lines would be more descripti... [04:50:49] (03Merged) 10jenkins-bot: Chinese Conversion Table Update 2017-5 [core] - 10https://gerrit.wikimedia.org/r/385331 (owner: 10Chiefwei) [05:00:59] (03CR) 10jenkins-bot: Chinese Conversion Table Update 2017-5 [core] - 10https://gerrit.wikimedia.org/r/385331 (owner: 10Chiefwei) [05:38:46] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3824743 (10Nirzar) > If something is in beta but is configurable we still want to list it, correct? Yes! the mock looks good! can we... [06:00:20] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell: Add shell restriction to deny access to LocalSettings.php - https://phabricator.wikimedia.org/T182484#3824748 (10Legoktm) [06:02:23] (03PS4) 10Aaron Schulz: Replace cpPosTime cookie/parameter with cpPosIndex [core] - 10https://gerrit.wikimedia.org/r/396546 (https://phabricator.wikimedia.org/T182322) [06:05:25] (03PS2) 10Legoktm: shell: Add NO_LOCALSETTINGS restriction [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) [06:08:45] (03PS1) 10Legoktm: Add @covers for includes/shell/ tests [core] - 10https://gerrit.wikimedia.org/r/396567 [06:09:26] 04(no projects): zh falls back to zh-hans, why? - https://phabricator.wikimedia.org/T182485#3824763 (10CXuesong) [06:13:34] (03CR) 10Mxn: [C: 031] "Thanks for putting this together. I learned a thing or two about parts of the codebase I hadn’t been as involved with. I especially apprec" (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/396407 (https://phabricator.wikimedia.org/T182119) (owner: 10Jdrewniak) [06:24:37] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Create pretty landing page at https://doc.wikimedia.org/cover/ - https://phabricator.wikimedia.org/T146970#3824775 (10Legoktm) 05Open>03Resolved I changed my mind, I'm OK with the directory name... [06:26:00] 04(no projects): zh falls back to zh-hans, why? - https://phabricator.wikimedia.org/T182485#3824763 (10Liuxinyu970226) My guess is because in CLDR, the Simplified content are just using zh instead of zh_hans [06:27:33] (03CR) 10Gergő Tisza: [C: 032] Add @covers for includes/shell/ tests [core] - 10https://gerrit.wikimedia.org/r/396567 (owner: 10Legoktm) [06:33:15] (03CR) 10Gergő Tisza: "> The easy option is to just put "blacklist [...]/PrivateSettings.php"" [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [06:33:27] (03Merged) 10jenkins-bot: Add @covers for includes/shell/ tests [core] - 10https://gerrit.wikimedia.org/r/396567 (owner: 10Legoktm) [06:36:41] 10Design-Research, 10New-Editor-Experiences: Prepare framework for community idea generation - https://phabricator.wikimedia.org/T178967#3824779 (10Neil_P._Quinn_WMF) 05Open>03Resolved [06:42:57] (03CR) 10jenkins-bot: Add @covers for includes/shell/ tests [core] - 10https://gerrit.wikimedia.org/r/396567 (owner: 10Legoktm) [06:43:48] (03CR) 10Legoktm: "Do you mean something like Command::whitelistPaths()? That was my intention originally, but the implementation has some problems. Let me f" [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [06:57:40] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3732727 (10Gabe_Mitnick) I went full out with the "PAWS" name. My favorite is paws-01, but I created paws-02 in case 01 has the word "PAWS" too small and paws-03 if it needs to be more ser... [07:05:10] (03CR) 10Gergő Tisza: [C: 031] "Yeah, I missed that that already exists." [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [08:18:47] 10MediaWiki-Shell: Command::whitelistPaths() with firejail doesn't work exactly as expected - https://phabricator.wikimedia.org/T182486#3824782 (10Legoktm) [08:23:57] (03CR) 10Legoktm: "I tried to summarize the problems with whitelistPath's current implementation in T182486." [core] - 10https://gerrit.wikimedia.org/r/396080 (https://phabricator.wikimedia.org/T182484) (owner: 10Legoktm) [08:44:22] 10MediaWiki-Special-pages: -1 active users in Special:Statistics - https://phabricator.wikimedia.org/T172773#3824796 (10Reception123) 05Invalid>03Open The issue is back. (Version 1.29.2) [08:45:47] 10MediaWiki-Language-converter, 10I18n: Korean Hanja to Hangul unidirectional conversion tool on Korean wikisource? - https://phabricator.wikimedia.org/T182482#3824798 (10revi) #community-consensus-needed, if it wasn't closed. And please note Korean Wikisource does not consider Hanja to be in scope. [[https://... [08:47:26] 10MediaWiki-Internationalization: zh falls back to zh-hans, why? - https://phabricator.wikimedia.org/T182485#3824801 (10Aklapper) [08:54:40] (03PS1) 10Chiefwei: Chinese Conversion Table Update 2017-6 [core] - 10https://gerrit.wikimedia.org/r/396568 [08:56:57] hi [08:57:48] i am here for gci [08:58:32] anyone there ? [09:00:46] 10TechCom-RfC: Lack of freeform external access to MediaWiki data is a limitation - https://phabricator.wikimedia.org/T181257#3784413 (10Nemo_bis) I'm not sure what "freeform external access" even means. If I understood correctly, the proposer would like an API module with a "Google-like" search, where you input... [09:03:38] hi sahil613 [09:04:08] hi legoktm [09:27:59] 10MediaWiki-API, 10MediaWiki-JobQueue, 10Analytics, 10EventBus, and 3 others: Handling of structured data input in MediaWiki APIs - https://phabricator.wikimedia.org/T182475#3824833 (10mobrovac) We have the same need in the JobQueue migration project to be able to use Special:RunSignleJob, cf. {T182372} wh... [09:28:39] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Make Kafka JobQueue use Special:RunSingleJob - https://phabricator.wikimedia.org/T182372#3821757 (10mobrovac) [09:28:45] 10MediaWiki-API, 10MediaWiki-JobQueue, 10Analytics, 10EventBus, and 3 others: Handling of structured data input in MediaWiki APIs - https://phabricator.wikimedia.org/T182475#3824838 (10mobrovac) [09:31:16] 10MediaWiki-Language-converter, 10I18n: Korean Hanja to Hangul unidirectional conversion tool on Korean wikisource? - https://phabricator.wikimedia.org/T182482#3824840 (10C933103) # The linked discussion was about Hanmun = Classical Chinese documents, not documents written in Hanja-Hangul mixed script. # The t... [09:31:33] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Make Kafka JobQueue use Special:RunSingleJob - https://phabricator.wikimedia.org/T182372#3824841 (10mobrovac) This is effectively blocked by {T182475}, since we need `Special:RunSignleJob` to be able to read structured data (which i... [09:32:37] 10MediaWiki-Shell: The NO_EXECVE shell restriction doesn't work with firejail because of limit.sh - https://phabricator.wikimedia.org/T182489#3824856 (10Legoktm) [09:40:19] 10MediaWiki-Shell: The NO_EXECVE shell restriction doesn't work with firejail because of limit.sh - https://phabricator.wikimedia.org/T182489#3824871 (10Legoktm) Another option...we could run firejail inside of limit.sh! ``` km@km-pt:~$ /bin/bash '/srv/mediawiki/core/includes/shell/limit.sh' '/usr/local/bin/fir... [10:11:29] (03PS1) 10Legoktm: shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) [10:17:20] (03CR) 10jerkins-bot: [V: 04-1] shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [10:21:18] 10MediaWiki-Shell, 10Patch-For-Review: The NO_EXECVE shell restriction doesn't work with firejail because of limit.sh - https://phabricator.wikimedia.org/T182489#3824879 (10Legoktm) With the above patch I tested using NO_EXECVE with both abc2ly and timidity in Score and it ran fine. (lilypond requires execve b... [10:21:45] (03PS2) 10Legoktm: shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) [10:25:46] 10MediaWiki-extensions-UniversalLanguageSelector, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review, 10User-notice: Investigate and update webfonts where possible - https://phabricator.wikimedia.org/T180422#3824885 (10Liuxinyu970226) [10:28:15] 10MediaWiki-Shell: Implement shell restriction alternative to NO_NETWORK that only allows HTTP(S) traffic - https://phabricator.wikimedia.org/T182490#3824889 (10Legoktm) [10:30:05] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10Security-Team, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Support restricted execution of external commands (via firejail) - https://phabricator.wikimedia.org/T173370#3824900 (10Legoktm) The m... [10:41:58] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10Patch-For-Review: The NO_EXECVE shell restriction doesn't work with firejail because of limit.sh - https://phabricator.wikimedia.org/T182489#3824919 (10Legoktm) [10:42:41] 10MediaWiki-Configuration, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review, 10User-Daniel, 10User-thiemowmde: Extension registration should support using a PSR-4 autoloader - https://phabricator.wikimedia.org/T99865#1300641 (10Legoktm) a:03Legoktm [10:42:49] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-Shell, 10Patch-For-Review: The NO_EXECVE shell restriction doesn't work with firejail because of limit.sh - https://phabricator.wikimedia.org/T182489#3824856 (10Legoktm) a:03Legoktm [10:44:23] 10MediaWiki-Shell: Implement shell restriction alternative to NO_NETWORK that only allows HTTP(S) traffic - https://phabricator.wikimedia.org/T182490#3824928 (10Legoktm) firejail comes with `/etc/firejail/webserver.net`, which is a filter that only allows port 80 and 443 traffic. However we also need to set up a... [10:46:12] (03CR) 10MaxSem: [C: 04-1] shell: Run firejail inside limit.sh, make NO_EXECVE work (031 comment) [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [10:46:55] MaxSem: hmmm. [10:48:35] (03CR) 10Legoktm: shell: Run firejail inside limit.sh, make NO_EXECVE work (031 comment) [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [10:51:08] 10MediaWiki-extensions-ORES, 10Scoring-platform-team: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3824930 (10Ladsgroup) p:05Triage>03Unbreak! [10:51:49] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Wikimedia-log-errors: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3824933 (10Legoktm) @Ladsgroup is saying that people can't check or change their preferences on fawiki because of this. [10:54:47] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Wikimedia-log-errors: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3824937 (10Legoktm) ``` 2017-12-09 10:52:14 [WivAXgpAEKsAABFZlbQAAABQ] mw1216 fawiki 1.31.0-wmf.11 exception ERROR: [WivAXgpAEKsA... [10:57:32] (03PS1) 10Rafidaslam: SpecialGlobalUsers: Make GlobalUsersPager properly support gender [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396571 (https://phabricator.wikimedia.org/T182444) [11:01:39] 10Timeless, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), 10Patch-For-Review: Replace {{NUMBEROFPAGES}} by {{NUMBEROFARTICLES}} on `timeless-search-placeholder`, the search box text - https://phabricator.wikimedia.org/T176094#3824949 (10Framawiki) 05Open>03Resol... [11:05:03] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3824951 (10Framawiki) [11:06:39] (03CR) 10Ladsgroup: "That caused a huge regression: https://phabricator.wikimedia.org/T182354" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/392452 (https://phabricator.wikimedia.org/T180866) (owner: 10Petar.petkovic) [11:06:41] (03CR) 10D3r1ck01: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396571 (https://phabricator.wikimedia.org/T182444) (owner: 10Rafidaslam) [11:10:08] legoktm: hello, this LGTM: https://gerrit.wikimedia.org/r/#/c/396571, could you have a second look please? [11:12:32] (03CR) 10D3r1ck01: [C: 031] SpecialGlobalUsers: Make GlobalUsersPager properly support gender [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396571 (https://phabricator.wikimedia.org/T182444) (owner: 10Rafidaslam) [11:18:58] what a fast review [11:20:34] refeed[m] yay ^^ [11:21:11] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Wikimedia-log-errors: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3824960 (10Ladsgroup) Offending commit: https://gerrit.wikimedia.org/r/#/c/392452 CC @jmatazzoni @Catrope... [11:29:35] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Wikimedia-log-errors: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3824989 (10Legoktm) p:05Unbreak!>03High Disabled ORES on fawiki for now. This only affected fawiki beca... [11:29:47] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Regression, 10Wikimedia-log-errors: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3824991 (10Legoktm) [11:33:09] divadsn: heya! [11:40:03] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Regression, and 3 others: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3825002 (10Ladsgroup) [11:40:33] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Regression, and 3 others: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3821279 (10Ladsgroup) Made a comment about disabling ORES in [[https://fa.wikipedia.org/w/index.php?old... [11:41:18] 10GlobalBlocking, 10Stewards-and-global-tools, 10Wikimedia-log-errors: Blocker must be a local user or a name that cannot be a local user - https://phabricator.wikimedia.org/T182344#3825005 (10Legoktm) p:05Normal>03Unbreak! This is still happening on SUL wikis. @Anomie can you take a look at this? You ad... [11:47:47] 10AbuseFilter, 10TestMe: AbuseFilter's API do not return the filter id (but returns its name) for private filters - https://phabricator.wikimedia.org/T53180#3825012 (10He7d3r) I see the "permissiondenied" error if I'm not logged in, but I see this while logged in: ```lang=json { "batchcomplete": "", "c... [11:48:39] (03PS1) 10Yashasvi: Offline compilations : show size in MB when its less than 1 gb [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396573 (https://phabricator.wikimedia.org/T177879) [11:52:17] 10Wikimania-Hackathon-2017: Improving MediaWiki - What to do, when you’re new? - https://phabricator.wikimedia.org/T172102#3825017 (10Aklapper) @WMDE-Fisch: Anything left to do in this task / any followup tasks needed to create? Or should this task get closed as `resolved`? [11:53:40] (03CR) 10Ladsgroup: Add change_tag_statistics table to speed up tag hitcount retrieval (031 comment) [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [11:54:09] 10Android-app-feature-Compilations, 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review: Display storage space and file size in appropriate units - https://phabricator.wikimedia.org/T177879#3825023 (10yashasvi) @Dbrant , I've made the change, modified and added some strings in `strings.xml` (and a... [11:54:19] (03PS3) 10Legoktm: shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) [11:54:45] (03CR) 10jerkins-bot: [V: 04-1] Offline compilations : show size in MB when its less than 1 gb [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396573 (https://phabricator.wikimedia.org/T177879) (owner: 10Yashasvi) [11:55:41] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Get securityCheckPlugin on packagist - https://phabricator.wikimedia.org/T182214#3825024 (10Bawolff) SecurityCheckPlugin is a super uninspired name, so im totally fine naming it something else. Naming things is hard :) [11:56:44] 10Support-and-Safety, 10WMF-Legal: File an ISP complaint against Enzu, Inc. - https://phabricator.wikimedia.org/T181804#3825038 (10Aklapper) > Please also consider moving this task to S10 (and keep me able to see/comment here?) The latter is [[ https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_p... [11:59:04] bawolff: Welcome :) [11:59:12] Ji [11:59:14] hi [12:00:14] bawolff: we got a patch for that our task of yesterday: https://gerrit.wikimedia.org/r/#/c/396571/ [12:00:38] Yeah. It looks right, i was just going to test it [12:00:46] I reviewed and it looks okay to me [12:00:54] bawolff: Okay! [12:01:17] (03CR) 10jerkins-bot: [V: 04-1] shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) (owner: 10Legoktm) [12:01:18] bawolff: You have the almighty +2 rights, so if it's fine, you can merge and the student moves on :) [12:01:23] Thanks [12:02:47] 10Security-Team: Review access to security tasks - https://phabricator.wikimedia.org/T97869#3825046 (10Aklapper) a:05csteipp>03None Is this still wanted / needed? Resetting assignee. Also note that https://www.mediawiki.org/wiki/Wikimedia_Security_Team/Policy/Access_To_Security_Issues has been created in the... [12:05:58] 10Security-Team: Review access to security tasks - https://phabricator.wikimedia.org/T97869#3825049 (10Bawolff) 05Open>03Resolved a:03Bawolff Well it may make sense to reaudit the list, this bug is really old so if we were to do that, we would probably have to start from scratch anyways [12:06:36] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Regression, and 3 others: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3821279 (10Arash.pt) Do you check changes you implement in different configs and systems? Aren't there... [12:07:39] (03PS4) 10Legoktm: shell: Run firejail inside limit.sh, make NO_EXECVE work [core] - 10https://gerrit.wikimedia.org/r/396570 (https://phabricator.wikimedia.org/T182489) [12:16:01] 10Support-and-Safety, 10WMF-Legal: File an ISP complaint against Enzu, Inc. - https://phabricator.wikimedia.org/T181804#3825056 (10MarcoAurelio) >>! In T181804#3825038, @Aklapper wrote: >> Please also consider moving this task to S10 (and keep me able to see/comment here?) > The latter is [[ https://www.mediaw... [12:19:31] (03PS1) 10Tpt: Better extension description [extensions/Wikisource] - 10https://gerrit.wikimedia.org/r/396575 [12:24:29] hello all I'm sakshi, a student from India. I'm here for the wikimedia google code in task. Thanks! [12:24:49] (03CR) 10Brian Wolff: [C: 032] SpecialGlobalUsers: Make GlobalUsersPager properly support gender [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396571 (https://phabricator.wikimedia.org/T182444) (owner: 10Rafidaslam) [12:25:42] sakshi: Welcome! [12:27:40] (03Merged) 10jenkins-bot: SpecialGlobalUsers: Make GlobalUsersPager properly support gender [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396571 (https://phabricator.wikimedia.org/T182444) (owner: 10Rafidaslam) [12:28:08] 10TimedMediaHandler, 10Patch-For-Review, 10Schema-change: Expose file sizes of transcoded assets in API - https://phabricator.wikimedia.org/T57942#3825062 (10Sandraramirez3888) a:03Sandraramirez3888 [12:28:48] bawolff: Thanks for merging. Yeha! [12:29:03] 10MediaWiki-extensions-CentralAuth, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review, and 2 others: Make GlobalUsersPager properly support gender - https://phabricator.wikimedia.org/T182444#3825064 (10Bawolff) 05Open>03Resolved a:03rafidaslam [12:29:34] sakshi: hello [12:30:31] o/ [12:33:13] 10MediaWiki-Email, 10MediaWiki-extensions-GoogleLogin, 10Mail, 10Mobile-Content-Service, and 6 others: Section parsing bug on :en:Wikimedia Foundation - https://phabricator.wikimedia.org/T182349#3825071 (10Sandraramirez3888) a:03Sandraramirez3888 [12:35:42] (03Draft2) 10Pwirth: BSFoundation: Added bsg config to BsSpecialpage base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/396577 [12:36:39] sakshi, congratulations on completing the task :) [12:36:51] And welcome to IRC :D [12:40:26] Oh and does anyone here know on how to deal with PRs on GitHub like this here? I couldn't find a report button :/ https://github.com/Deletescape-Media/Lawnchair/pull/997 [12:40:50] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review, 10Regression, and 3 others: OresDamagingPref back-compatibility is logging exceptions - https://phabricator.wikimedia.org/T182354#3825082 (10awight) @Arash.pt Taking your questions at face value: Yes, yes and yes :). The issue here i... [12:42:22] divadsn: wew, that's a bad pr :/ . Perhaps here: https://github.com/contact/report-abuse [12:44:07] (btw that link is to report the user who spam, I have no idea with PR, just close the pr is fine I think) [12:44:42] duvadsn: just close it as clearly bad pr [12:44:50] I just don't wanna give him any attention, but also want to delete his PR [12:45:42] bawolff: hello [12:46:50] divadsn: Thanks! [12:48:15] refeed[m], thanks for the link, I send a report as the user account has been created today, so it's definetly someone who is really mad at me for some recent changes [12:48:55] (03PS3) 10Yashasvi: PageFragment : snackbar should be shown above actions tab [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/394754 (https://phabricator.wikimedia.org/T146091) [12:49:11] 90% I would tip it is a pirate who got upset that I introduced some piracy tools checks to prevent them from using illegally installed 3rd party apps like iconpacks [12:50:03] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review: [BUG] Snackbars should appear above article toolbar - https://phabricator.wikimedia.org/T146091#3825099 (10yashasvi) @RHo , Updated the patch. Let me know if anything else is needed. [12:57:37] you're welcome [12:59:26] 10Wikimedia-Site-requests: Blockers for Wikimedia wiki domain renaming - https://phabricator.wikimedia.org/T172035#3825104 (10C933103) Is it possible to do the renaming task for those wikis as of current status first and then deal with whatever bugs that would appear after the renaming is to be done? As mentione... [13:00:00] welcome sakshi ! [13:03:32] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017, 10User-Ryasmeen: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3825106 (10AnmolSingh) @Mvolz https://www.flaticon.com/free-icon/open-book_167755 . this is the icon page on flaticon. on clicking download it pre... [13:10:19] 10MediaWiki-Email, 10Mail, 10Mobile-Content-Service, 10Parsoid, 10Reading-Infrastructure-Team-Backlog (Kanban): Section parsing bug on :en:Wikimedia Foundation - https://phabricator.wikimedia.org/T182349#3825107 (10Aklapper) a:05Sandraramirez3888>03None [13:10:32] 10TimedMediaHandler, 10TimedMediaHandler-Transcode, 10Patch-For-Review, 10Schema-change: Expose file sizes of transcoded assets in API - https://phabricator.wikimedia.org/T57942#3825110 (10Aklapper) a:05Sandraramirez3888>03None [13:28:24] (03PS6) 10Pwirth: BSFoundation: Added basic ArticlePreviewImage module [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/394306 [13:34:04] 10MediaWiki-extensions-CLDR, 10Multimedia, 10UploadWizard: Many languages names in UploadWizard are not translated to Ukrainian - https://phabricator.wikimedia.org/T172219#3490762 (10Multichill) Someone asked about this on irc. In https://phabricator.wikimedia.org/diffusion/ECLD/browse/master/LocalNames/ we... [13:36:06] 10HHVM, 10Security-General: Create a whitelist of commands which HHVM may execute - https://phabricator.wikimedia.org/T101354#3825151 (10Aklapper) a:05csteipp>03None [13:37:04] 10Design, 10Africa-Wikimedia-Developers, 10MinervaNeue, 10Readers-Web-Backlog, and 3 others: Mobile infobox styles do not work well with multiple column infobox rows - https://phabricator.wikimedia.org/T168716#3825153 (10D3r1ck01) @Jdlrobson, removing #africa-wikimedia-developers tag as this features on #g... [13:37:45] 10Design, 10MinervaNeue, 10Readers-Web-Backlog, 10Google-Code-in-2017, and 2 others: Mobile infobox styles do not work well with multiple column infobox rows - https://phabricator.wikimedia.org/T168716#3825154 (10D3r1ck01) [13:38:01] 10PageImages, 10Readers-Web-Backlog, 10Easy, 10Google-Code-in-2017, and 2 others: Re-enable codesniffer sniffs disabled in PageImages - https://phabricator.wikimedia.org/T170583#3825156 (10D3r1ck01) Removing #africa-wikimedia-developers tag as it's done in #google-code-in-2017. [13:39:00] 10Design, 10Discovery, 10WMDE-Design, 10Wikidata, and 4 others: Imagegrid should lazy load - https://phabricator.wikimedia.org/T166216#3825160 (10D3r1ck01) Removing #africa-wikimedia-developers tag as task is put up for #google-code-in-2017. [13:40:32] 10Security-Team, 10Documentation: Document bug triage process - https://phabricator.wikimedia.org/T109106#3825165 (10Aklapper) a:05csteipp>03None What's left to do in https://www.mediawiki.org/wiki/Wikimedia_Security_Team/Prioritization_of_bugs ? Or is this solved? [13:40:48] 10Security-Team, 10Documentation: Create and document security training on mw.org, and document training processes - https://phabricator.wikimedia.org/T109094#3825167 (10Aklapper) a:05csteipp>03None [13:42:24] 10MediaWiki-General-or-Unknown, 10Security-Team, 10Technical-Debt: Refactor Title to make permission checking it's own class - https://phabricator.wikimedia.org/T75958#3825169 (10Aklapper) a:05csteipp>03None For the records, https://gerrit.wikimedia.org/r/#/c/166357/ is still WIP. [13:43:36] 10MediaWiki-extensions-MolHandler, 10Security-Reviews, 10Wikimedia-Extension-setup: Security review indigo-depict - https://phabricator.wikimedia.org/T66548#3825172 (10Aklapper) a:05csteipp>03None [13:45:12] 10Security-Team: Add code patterns that could impact privacy to MediaWiki secure code training. - https://phabricator.wikimedia.org/T110620#3825173 (10Aklapper) a:05csteipp>03None [13:45:42] 10Security-Team: Add code patterns that could impact privacy to MediaWiki secure code training. - https://phabricator.wikimedia.org/T110620#1582507 (10Aklapper) "MediaWiki secure code training" = https://www.mediawiki.org/wiki/Security_for_developers and subpages? Or something else? [13:50:05] 10Security-Team, 10Wikimedia-Site-requests: Implement results of enwiki Security review RfC - https://phabricator.wikimedia.org/T121186#3825182 (10Aklapper) a:05csteipp>03None [13:50:53] 10Wikimedia-Site-requests, 10Patch-For-Review: Delete mo.wikipedia and mo.wiktionary; set redirects to ro.wikipedia and ro.wiktionary afterwards - https://phabricator.wikimedia.org/T181923#3825186 (10MarcoAurelio) [13:58:20] 04(no projects): Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825190 (10Aklapper) 05Open>03stalled [Removing #Wikisource - see its project description.] Hi @Tiven2240, thanks for taking the time to report this! Unfortunately this report lacks some information. If... [13:59:04] 04(no projects): Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825193 (10Aklapper) [13:59:15] 10Security-Team, 10Wikimedia-Site-requests: Implement results of enwiki Security review RfC - https://phabricator.wikimedia.org/T121186#1871924 (10Bawolff) > Regular audits will take some work to get setup I don't think anyone ever decided what is meant by this (running hashcat against functionary password ha... [14:09:30] 10Wikimedia-General-or-Unknown: ReferenceError: getElementsByClassName is not defined at Function.Bawolff.Ticker.init - https://phabricator.wikimedia.org/T166978#3825200 (10Bawolff) It was broken by 0beaa51bb1030 - i fixed the enwikinews one https://en.wikinews.org/w/index.php?title=MediaWiki%3ATicker2.js&type=r... [14:17:16] 10Wikimedia-General-or-Unknown: ReferenceError: getElementsByClassName is not defined at Function.Bawolff.Ticker.init - https://phabricator.wikimedia.org/T166978#3825201 (10Aklapper) Local admins should also read https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#Keep_gadgets_central how to av... [14:18:22] 10Wikimedia-General-or-Unknown: ReferenceError: getElementsByClassName is not defined at Function.Bawolff.Ticker.init - https://phabricator.wikimedia.org/T166978#3825202 (10Bawolff) There's a list at https://meta.wikimedia.org/w/index.php?title=Special%3AGlobalUsers&username=&group=global-interface-editor&limit=50 [14:21:42] 10Wikimedia-General-or-Unknown, 10Need-volunteer: ReferenceError: getElementsByClassName is not defined at Function.Bawolff.Ticker.init - https://phabricator.wikimedia.org/T166978#3825205 (10Aklapper) p:05Triage>03Lowest [14:23:19] 04(no projects): Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825207 (10Aklapper) I go to https://mr.wikisource.org/wiki/अनुक्रमणिका:छन्दोरचना.djvu and I see no obvious problem. [14:24:37] 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 10Wikidata-Gadgets, 10Google-Code-in-2017: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata - https://phabricator.wikimedia.org/T107693#1501387 (10eflyjason) I guess... [14:28:13] 04(no projects): Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825210 (10Tiven2240) >>! In T182495#3825207, @Aklapper wrote: > I go to https://mr.wikisource.org/wiki/अनुक्रमणिका:छन्दोरचना.djvu and I see no obvious problem. Thanks for checking out. But as I see the page... [14:30:24] 04(no projects): Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825212 (10Tiven2240) [14:33:47] 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 10Wikidata-Gadgets, 10Google-Code-in-2017: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata - https://phabricator.wikimedia.org/T107693#3825215 (10Mvolz) You should... [14:35:57] (03PS8) 10Eflyjason: Parser: Ignore whitespaces between wiki table syntax and table content [core] - 10https://gerrit.wikimedia.org/r/395477 (https://phabricator.wikimedia.org/T182074) [14:47:09] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Easy, 10Google-Code-in-2017, and 3 others: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213#3825227 (10Bawolff) [14:47:26] divadsn: --^ I tried to clarify the descrition a little bit [14:48:57] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Easy, 10Google-Code-in-2017, and 3 others: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213#3816680 (10Bawolff) [14:49:17] *description [14:54:23] 10Dumps-Generation, 10Patch-For-Review: Move all cron jobs off of snapshots that are NOT dumps generation jobs - https://phabricator.wikimedia.org/T182303#3825230 (10ArielGlenn) They're all moved; I'll leave this open for a day to make sure they run, there was only one to be moved after all. [14:58:37] 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 10Wikidata-Gadgets, 10Google-Code-in-2017: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata - https://phabricator.wikimedia.org/T107693#3825232 (10eflyjason) https:/... [15:04:50] 10Community-consensus-needed, 10Wiki-Setup (Rename): Changing URL of Oriya/Odia Wikipedia Projects from "or" to "od" - https://phabricator.wikimedia.org/T175464#3825234 (10Liuxinyu970226) @Jnanaranjan_sahu: because we had a discussion at our community. I will convey the message and post update. [Where?] [15:04:53] 04(no projects): Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825087 (10Ankry) @Tiven2240 A mrwikisource admin should add a newline between "" and "{|" in the first line of https://mr.wikisource.org/wiki/%E0%A4%AE%E0%A4%BF%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4... [15:10:36] Hi i am from Google Code-in [15:10:50] rekjef: Hello :), Welcome! [15:11:59] rekjef: welcome! [15:19:27] 10MediaWiki-SecurityCheckPlugin, 10Security-Team: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3825245 (10Bawolff) [15:20:01] 10MediaWiki-SecurityCheckPlugin, 10Security-Team, 10Google-Code-in-2017: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3823484 (10Bawolff) [15:24:24] 10Community-consensus-needed, 10Wiki-Setup (Rename): Changing URL of Oriya/Odia Wikipedia Projects from "or" to "od" - https://phabricator.wikimedia.org/T175464#3825251 (10Jnanaranjan_sahu) @Liuxinyu970226 Thank you concern. We had a discussion at our community active members' facebook messenger group(We have... [15:29:25] 10MediaWiki-Parser, 10ProofreadPage: Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825253 (10Ankry) [15:30:38] 04(no projects): Update logrotate config for scb* boxes, to deal with ORES verbose logging - https://phabricator.wikimedia.org/T182497#3825254 (10awight) [15:33:21] 10Wikimedia-General-or-Unknown, 10Reading-Web-Local-Wiki-Issues: Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825264 (10Aklapper) 05Resolved>03Invalid >>! In T182495#3825246, @Ankry wrote: > So either I am misreading the description or your removal (without assign... [15:33:46] oh refeed you are in here too? [15:34:27] eisenhaus335: yeah, I'm here :) [15:34:40] GCI? [15:35:00] eisenhaus335: yup [15:35:30] looks like we are on the same page on same land wkwk [15:35:45] Hello [15:35:49] Hi [15:36:06] bawolff: how are you today [15:36:15] eisenhaus335: haha, yes xD [15:36:25] I'm good [15:36:26] hello! [15:36:27] same land? wkwk right? [15:37:31] eisenhaus335: yup [15:38:05] 10Wikimedia-Site-requests: Blockers for Wikimedia wiki domain renaming - https://phabricator.wikimedia.org/T172035#3825271 (10Liuxinyu970226) @C933103: >Is it possible to do the renaming task for those wikis as of current status first If that is possible, then we don't need this task, we can just rename those wi... [15:38:34] bawolff: in my time in dev here ive never seen this chan so active :) it makes me happy [15:38:45] 10MediaWiki-SecurityCheckPlugin, 10Security-Team, 10Google-Code-in-2017: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3825276 (10Aklapper) [15:38:56] Well gci advising people to go here is probably doing it [15:39:18] Zppix: This channel used to be very active when it was made as a channel where there were explicitly no bots [15:39:27] The original purpose was a place to escape from wikibugs [15:39:29] kind of ironic [15:39:33] Lol [15:41:37] 10Wikimedia-General-or-Unknown, 10Reading-Web-Local-Wiki-Issues: Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825277 (10Ankry) @Aklapper I think we have a bug in wikicode parser and/or ProofrreadPage here: IMO, my "fix" was a workaround that should not be required. Bu... [15:42:14] bawolff: i need to find more tasks to mentor, im running low :P [15:42:43] a long history huh? interesting [15:42:49] bawolff, yay, thanks, will look at it :) [15:44:46] eisenhaus335: If you mean this channel - originally it was created as #wikipedia_usability which was a channel for the people working on the Usability initiave, which was one of the first times the wikimedia foundation had actual money to hire people for product devlopment (Got us things like the Vector skin, UploadWizard). This was circa 2010 [15:46:32] Ok, now it's understandable bawolff, thank you :) [15:47:01] 10Wikimedia-General-or-Unknown, 10Reading-Web-Local-Wiki-Issues: Marathi Wikisource Index Namespace problem - https://phabricator.wikimedia.org/T182495#3825281 (10Tiven2240) 05Invalid>03Resolved I think it was a bug because as I mentioned it was working fine few days ago while documentation was updated a l... [15:47:05] divadsn: Sorry about that. I didn't expect that there would be so many instance of people using the wrong message format type in MW [15:47:11] I thought everything would be the first case [15:47:18] 10PageImages, 10Readers-Web-Backlog, 10Easy, 10Google-Code-in-2017, and 2 others: Re-enable codesniffer sniffs disabled in PageImages - https://phabricator.wikimedia.org/T170583#3825283 (10Pppery) not fully done, there are still three sniff violations remaining [15:50:18] 10Google-Code-in-2017: User script to change change font color to red and font face to bold - https://phabricator.wikimedia.org/T182481#3824667 (10Anooprao) to change font color you must add changes to https://en.wikipedia.org/wiki/Special:MyPage/common.css (.css not .js) ``` .mw-body-content { color: red !im... [15:51:11] 10MediaWiki-SecurityCheckPlugin, 10Security-Team, 10Google-Code-in-2017: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3825288 (10Bawolff) Imported in gci as https://codein.withgoogle.com/dashboard/tasks/4879638591438848/ [15:52:12] 10MediaWiki-SecurityCheckPlugin, 10Security-Team, 10Google-Code-in-2017: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3825293 (10Bawolff) [15:52:18] bawolff, no it's ok, it's good that I've found out that confusion so other students will now more likely do the task :) [15:52:45] :) [15:53:07] I did a mistake today by submitting my task foe review while jenkins gave -2 for a style issue ^^" [15:53:11] *for [15:54:27] who is mentor and GCI actually? [15:57:38] 10MediaWiki-extensions-Page_Forms: Error when using Special:RunQuery - "Parser state cleared while parsing" - https://phabricator.wikimedia.org/T68202#3825295 (10Jaideraf) 05Resolved>03Open This problem returned. Tested in PF 4.2, MW 1.30.0 Example: Edit some page and put ``` {{Special:RunQuery/SomeValidQu... [15:59:50] is there any list of admin/mentor. i might mistake it [16:00:18] eisenhaus335: yup, the GCI 2017 mentors are listed here: https://www.mediawiki.org/wiki/Google_Code-in/2017 [16:00:51] thanks refeed[m] [16:02:09] no problem :) [16:03:26] eisenhaus335: what task are you working on? [16:03:35] 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 10Wikidata-Gadgets, 10Google-Code-in-2017: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata - https://phabricator.wikimedia.org/T107693#3825308 (10eflyjason) https:/... [16:04:26] still doing my old task. introduce pytest to database/ database to pytest [16:04:42] eisenhaus335: ah [16:05:01] If you need help with that theres usually someone in #wikimedia-ai eisenhaus335 [16:05:06] awight: ^ [16:07:59] 10Timeless: Ditch most of the colors in Timeless - https://phabricator.wikimedia.org/T182388#3822142 (10MGChecker) I really appreciate the multi-color top line in widescreen view, as it's dividing the three columns timeless has in a really natural way. However, if your screen is smaller, it doesn't look this wel... [16:09:32] 10Timeless: Can't click on links in dropdowns in chromium - https://phabricator.wikimedia.org/T182499#3825313 (10Isarra) [16:09:49] from this point. its just grinding task. i am only ask that i might cannot find or my google fu skill not enough [16:14:06] 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 10Wikidata-Gadgets, 10Google-Code-in-2017: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata - https://phabricator.wikimedia.org/T107693#3825336 (10Sjoerddebruin) Gre... [16:14:47] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), and 5 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3825340 (10Envlh) As a user, it's back to n... [16:14:54] 85 [16:16:54] 10Wikimedia-Site-requests: Blockers for Wikimedia wiki domain renaming - https://phabricator.wikimedia.org/T172035#3825341 (10Verdy_p) T133548 is about certificates for HTTPS. if we create a CNAME of a subdomain project to another subdomain, it should have no impact if the certificate allows not just specific su... [16:19:32] 10Social-Tools, 10SocialProfile, 10Patch-For-Review, 10Technical-Debt: Convert SocialProfile to use extension registration - https://phabricator.wikimedia.org/T152865#3825342 (10SamanthaNguyen) @Legoktm: Thanks for the advice and for rebasing them, I'll make sure to keep this in mind for the future :) [16:23:36] 10MediaWiki-User-login-and-signup, 10Patch-For-Review: Display password requirements when changing a password or signing up - https://phabricator.wikimedia.org/T119583#3825350 (10Aklapper) a:05csteipp>03None [16:26:40] 10Wikimedia-General-or-Unknown, 10WorkType-NewFunctionality: Add Help:Logging_in to loginwiki - https://phabricator.wikimedia.org/T57425#3825354 (10Aklapper) 05Open>03Resolved https://login.wikimedia.org/w/index.php?title=Special:UserLogin links to "Help with logging in" at https://www.mediawiki.org/wiki/S... [16:32:34] (03CR) 10Fomafix: [C: 04-1] Parser: Ignore whitespaces between wiki table syntax and table content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/395477 (https://phabricator.wikimedia.org/T182074) (owner: 10Eflyjason) [16:40:09] 10MediaWiki-extensions-OAuth, 10Browser-Tests, 10User-zeljkofilipin: Add tests against beta to catch OAuth integration issues - https://phabricator.wikimedia.org/T78314#3825365 (10Aklapper) a:05csteipp>03None [16:42:39] 10Wikimedia-maintenance-script-run: Page with an unexpected value for the "page_latest" field on Wikipedia - https://phabricator.wikimedia.org/T182501#3825368 (10GeoffreyT2000) [16:43:40] 10MediaWiki-Configuration, 10Security-Team, 10TechCom-RfC, 10RfC: RFC: MediaWiki HTTPS policy - https://phabricator.wikimedia.org/T75953#3825378 (10Aklapper) a:05csteipp>03None [16:47:53] 10Google-Code-in-2017: User script to change change font color to red and font face to bold - https://phabricator.wikimedia.org/T182481#3825383 (10Tuxology) > to change font color you must add changes to https://en.wikipedia.org/wiki/Special:MyPage/common.css (.css not .js) > ``` > .mw-body-content { > color:... [16:50:03] 10Google-Code-in-2017: Custom style sheet to change change font color to red and font face to bold - https://phabricator.wikimedia.org/T182481#3825385 (10Tuxology) [17:02:57] 10Wikimedia-Site-requests: Blockers for Wikimedia wiki domain renaming - https://phabricator.wikimedia.org/T172035#3825391 (10C933103) >>As mentioned by others, it've been almost a decade since the issue was raised > Those "raising" actions are illegal, please see [[https://www.mediawiki.org/wiki/Bug_management/... [17:28:55] (03PS2) 10SamanthaNguyen: [DNM] Convert UserProfile to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) [17:31:12] (03CR) 10SamanthaNguyen: "Patchset 2: Manually rebased to resolve merge conflict" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392726 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [18:04:39] (03CR) 10Aklapper: "@Reedy: Not CR-1 anymore as the commit message got fixed?" [core] - 10https://gerrit.wikimedia.org/r/395148 (https://phabricator.wikimedia.org/T181673) (owner: 10Albert221) [18:05:33] 10MediaWiki-extensions-Score, 10Upstream: Add all instruments to Extension:Score - https://phabricator.wikimedia.org/T143500#3825407 (10Ebe123) p:05Triage>03Low @Trizek-WMF, could you provide an example where some instruments are missing? The listing is part of the MIDI standard, and both TiMidity++ and Li... [18:06:15] 10Wikimedia-Site-requests, 10Community-consensus-needed: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826#3825411 (10Aklapper) p:05Triage>03Low [18:10:21] 10MediaWiki-extensions-LinkedWiki: PAGEIRI - https://phabricator.wikimedia.org/T182502#3825413 (10Karima) [18:11:55] 10MediaWiki-extensions-Other, 10Easy: Convert WikiObjectModel extension to use extensions registration - https://phabricator.wikimedia.org/T155339#3825424 (10Aklapper) p:05Triage>03Lowest [18:13:53] 10MediaWiki-extensions-LinkedWiki: Case when the page is rename or delete - https://phabricator.wikimedia.org/T182503#3825427 (10Karima) [18:21:15] Reedy, two modules are missing in extensions, Athena and UniversalLanguageSelector, how can I remove them? [18:27:01] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#3825442 (10IZoid) 05stalled>03Resolved p:05Normal>03High [18:34:29] 10MediaWiki-User-login-and-signup, 10Regression: LoggedOut cookie not set anymore - https://phabricator.wikimedia.org/T142542#3825447 (10Aklapper) @tstarling: Could you provide your opinion please? See last comment by anomie. Thanks. [18:35:26] 10Phabricator (Upstream), 10Upstream: Let users configure date format in account settings - https://phabricator.wikimedia.org/T110#3825545 (10IZoid) [18:35:59] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#3825550 (10Ebe123) Eh, no. We still must wait for it to be released in their 2.20 (or 2.22 if there's bad luck) stable, and still have to implement it... [18:36:08] 10BetaFeatures: Can't disable a beta feature on Special:Preferences, gets re-enabled again after saving preferences - https://phabricator.wikimedia.org/T177508#3825585 (10Aklapper) [18:37:25] 10Wikimedia-Logstash: Get icinga alerts into logstash - https://phabricator.wikimedia.org/T7#3825779 (10Ebe123) [18:37:27] 10Wikimedia-Logstash, 10Patch-For-Review: Get puppet runs into logstash - https://phabricator.wikimedia.org/T1#3825780 (10Ebe123) [18:37:29] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#3825680 (10Ebe123) [18:37:31] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#516065 (10Ebe123) 05Resolved>03Open [18:38:26] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#3825782 (10Aklapper) p:05High>03Normal [18:39:59] 10MediaWiki-Templates, 10Bug-Report, 10Software-Licensing: Templates not bundled with MediaWiki - https://phabricator.wikimedia.org/T182504#3825783 (10robkam) [18:40:09] 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 10Wikidata-Gadgets, 10Google-Code-in-2017: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata - https://phabricator.wikimedia.org/T107693#3825793 (10Mvolz) >>! In T1... [18:47:08] 10Phabricator, 10Wikimedia Phabricator RfC: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84#3825794 (10Aklapper) More vandalism examples: https://phabricator.wikimedia.org/p/Ptrpov mass-merged a bunch of tasks on 20171201. https://phabricator.wikimedia.org/p/FiZie/ on... [18:50:27] 10AbuseFilter: After passing the CAPTCHA page after warning, user is sent back to the Abuse Filter warning page - https://phabricator.wikimedia.org/T179789#3825795 (10Aklapper) [18:52:28] 10Wikimedia-Site-requests, 10Patch-For-Review: Enable local file upload in Tulu Wikipedia - https://phabricator.wikimedia.org/T166763#3825800 (10Aklapper) >>! In T166763#3783047, @Dereckson wrote: > What would be valuable would be a statement from the community someone knowledgeable with the Indian copyright... [18:54:51] 10Wikimedia-General-or-Unknown, 10Tor: Tor hidden service for WMF websites - https://phabricator.wikimedia.org/T168218#3825801 (10Aklapper) [18:56:11] 10MediaWiki-Templates: Templates not bundled with MediaWiki - https://phabricator.wikimedia.org/T182504#3825803 (10Aklapper) [19:02:22] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: Allow preventing Commons images from displaying on Wikipedia home page (etc), to avoid vandalism - https://phabricator.wikimedia.org/T75631#3825805 (10Aklapper) [19:03:16] 10MediaWiki-Templates: Templates not bundled with MediaWiki - https://phabricator.wikimedia.org/T182504#3825807 (10Aklapper) > The worst example being after importing MediaWiki:Common.css when viewing the wiki with WebKit it displays Wikipedia's logo instead of its own. If you import a random page into your wiki... [19:03:28] 10MediaWiki-Templates: Templates not bundled with MediaWiki - https://phabricator.wikimedia.org/T182504#3825810 (10Aklapper) [19:03:30] 10MediaWiki-General-or-Unknown: Create a MediaWiki package for download which contain basic elements of the English Wikipedia - https://phabricator.wikimedia.org/T165195#3259545 (10Aklapper) [19:05:54] (03PS6) 10Ebe123: Add variables to score hash and add purging [extensions/Score] - 10https://gerrit.wikimedia.org/r/370428 (https://phabricator.wikimedia.org/T49448) [19:07:33] (03CR) 10jerkins-bot: [V: 04-1] Add variables to score hash and add purging [extensions/Score] - 10https://gerrit.wikimedia.org/r/370428 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [19:08:27] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown: Local user script on he.wikipedia.org to move a page triggered 8 page moves - https://phabricator.wikimedia.org/T182035#3825814 (10Aklapper) [19:09:44] 10MediaWiki-General-or-Unknown, 10MediaWiki-Releasing: Create a MediaWiki package for download which contain basic elements of the English Wikipedia - https://phabricator.wikimedia.org/T165195#3825816 (10Aklapper) [19:11:04] (03PS7) 10Ebe123: Add variables to score hash and add purging [extensions/Score] - 10https://gerrit.wikimedia.org/r/370428 (https://phabricator.wikimedia.org/T49448) [19:12:27] (03CR) 10jerkins-bot: [V: 04-1] Add variables to score hash and add purging [extensions/Score] - 10https://gerrit.wikimedia.org/r/370428 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [19:13:34] (03PS1) 10Phantom42: Using plaintextParams instead of rawParams for newsletter name [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396590 (https://phabricator.wikimedia.org/T182213) [19:15:24] (03PS8) 10Ebe123: Add variables to score hash and add purging [extensions/Score] - 10https://gerrit.wikimedia.org/r/370428 (https://phabricator.wikimedia.org/T49448) [19:17:24] (03CR) 10Ebe123: "I went back to using a global, as finding each Score directory with Wikipage is futile. I did however change where the global points to, m" [extensions/Score] - 10https://gerrit.wikimedia.org/r/370428 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [19:17:51] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Easy, 10Google-Code-in-2017, and 3 others: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213#3816680 (10Phantom42) The change I just submitted makes N... [19:23:17] 10Developer-Relations: Investigate handing out certificates to volunteer developers after certain achievements - https://phabricator.wikimedia.org/T173258#3825820 (10Aklapper) >>! In T173258#3659993, @Qgil wrote: > https://commons.wikimedia.org/wiki/File:Certificate_of_training_CWS.pdf I've [[ https://commons.w... [19:37:17] (03PS98) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [19:42:09] 10Timeless: Can't click on links in dropdowns in chromium - https://phabricator.wikimedia.org/T182499#3825823 (10Isarra) 05Open>03Invalid Okay, this is happening in every skin with css hover dropdowns (splash, vector, bluesky, etc - not greystuff because that one is actually js). Appears to just be a chromiu... [19:43:26] 10MediaWiki-Templates: Templates not bundled with MediaWiki - https://phabricator.wikimedia.org/T182504#3825825 (10robkam) >>! In T182504#3825807, @Aklapper wrote: > The first question is "Which underlying problem do you try to solve by importing MediaWiki:Common.css from some other website into your wiki site?"... [19:55:46] 10MediaWiki-Platform-Team, 10Community-Tech, 10Wikimedia-General-or-Unknown, 10Category, 10Community-Wishlist-Survey-2015: Central Global Repository for Templates, Lua modules, and Gadgets - https://phabricator.wikimedia.org/T121470#3825829 (10robkam) This should be treated as a MW bug, see T182504 [20:01:16] (03PS1) 10SamanthaNguyen: [DNM] Convert SocialProfile to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396591 [20:13:20] (03PS1) 10Umherirrender: Move class NostalgiaTemplate to own file [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/396592 [20:13:58] (03PS1) 10Umherirrender: Move class CologneBlueTemplate to own file [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/396593 [20:14:59] (03PS1) 10Umherirrender: Move class ModernTemplate to own file [skins/Modern] - 10https://gerrit.wikimedia.org/r/396594 [20:15:13] (03CR) 10jerkins-bot: [V: 04-1] Move class CologneBlueTemplate to own file [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/396593 (owner: 10Umherirrender) [20:20:13] (03CR) 10Umherirrender: "T155182" [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/396593 (owner: 10Umherirrender) [20:25:11] (03PS1) 10Umherirrender: Rename class MetrolookHooks to match file [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/396595 [20:29:13] (03PS1) 10Umherirrender: Rename file Timeless.skin.php to match class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/396596 [20:33:06] (03PS1) 10Umherirrender: Rename file Hooks.php to match class [skins/Vector] - 10https://gerrit.wikimedia.org/r/396597 [20:36:20] 10MediaWiki-Platform-Team, 10Community-Tech, 10Wikimedia-General-or-Unknown, 10Category, 10Community-Wishlist-Survey-2015: Central Global Repository for Templates, Lua modules, and Gadgets - https://phabricator.wikimedia.org/T121470#3825849 (10Aklapper) I'm afraid it won't change a thing if it's treated... [20:42:25] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) (owner: 10Qdinar) [20:45:48] 10MediaWiki-General-or-Unknown, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Security-Core: Create a tmp directory just for MediaWiki - https://phabricator.wikimedia.org/T179901#3825852 (10Legoktm) [20:47:03] (03CR) 10Brian Wolff: [C: 032] Using plaintextParams instead of rawParams for newsletter name [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396590 (https://phabricator.wikimedia.org/T182213) (owner: 10Phantom42) [20:47:14] 10MediaWiki-General-or-Unknown, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Security-Core: Create a tmp directory just for MediaWiki - https://phabricator.wikimedia.org/T179901#3739698 (10Legoktm) I tweaked the proposal to include the wikiid and a random string in the directory name. [20:48:21] (03CR) 10jerkins-bot: [V: 04-1] Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) (owner: 10Qdinar) [20:48:55] (03Merged) 10jenkins-bot: Using plaintextParams instead of rawParams for newsletter name [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396590 (https://phabricator.wikimedia.org/T182213) (owner: 10Phantom42) [20:58:22] (03PS1) 10Umherirrender: Rename classes to match file names [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/396599 [21:01:42] (03CR) 10jerkins-bot: [V: 04-1] Rename classes to match file names [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/396599 (owner: 10Umherirrender) [21:04:29] 10MediaWiki-extensions-Other, 10Easy: Convert WikiObjectModel to use extension registration - https://phabricator.wikimedia.org/T155339#3825857 (10MarcoAurelio) [21:05:11] 10MediaWiki-extensions-Other, 10Easy: Convert WikiObjectModel to use extension registration - https://phabricator.wikimedia.org/T155339#2940899 (10MarcoAurelio) Renamed so that wmflabs/extreg-wos can detect this task (it fetches the titles and if they don't follow their naming schema the tool ignores them). [21:05:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/396598 (owner: 10L10n-bot) [21:08:16] (03PS1) 10Umherirrender: Move maintenance script to own folder [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/396601 [21:13:55] (03CR) 10Isarra: [C: 032] Allow viewport zooming [skins/Timeless] - 10https://gerrit.wikimedia.org/r/393368 (https://phabricator.wikimedia.org/T181131) (owner: 10TheDJ) [21:14:23] (03PS1) 10Umherirrender: Rename file CollapsibleVector.hooks.php to match class [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/396602 [21:15:15] (03Merged) 10jenkins-bot: Allow viewport zooming [skins/Timeless] - 10https://gerrit.wikimedia.org/r/393368 (https://phabricator.wikimedia.org/T181131) (owner: 10TheDJ) [21:19:41] (03PS2) 10Umherirrender: Rename classes to match file names [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/396599 [21:20:45] 10Wikimedia-Site-requests: Run dumpInterwiki.php - https://phabricator.wikimedia.org/T182506#3825863 (10MarcoAurelio) p:05Triage>03Low [21:20:47] (03CR) 10Fomafix: [C: 032] Rename file Hooks.php to match class [skins/Vector] - 10https://gerrit.wikimedia.org/r/396597 (owner: 10Umherirrender) [21:22:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396614 (owner: 10L10n-bot) [21:23:10] (03Merged) 10jenkins-bot: Rename file Hooks.php to match class [skins/Vector] - 10https://gerrit.wikimedia.org/r/396597 (owner: 10Umherirrender) [21:24:07] 10MediaWiki-extensions-WikimediaMaintenance: dumpInterwiki.php: allow to run this from our clones - https://phabricator.wikimedia.org/T182508#3825886 (10MarcoAurelio) [21:28:31] (03PS1) 10Umherirrender: Rename file ApiQueryCnContributors.php to match class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/396628 [21:30:10] (03CR) 10jerkins-bot: [V: 04-1] Rename file ApiQueryCnContributors.php to match class [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/396628 (owner: 10Umherirrender) [21:34:59] (03PS1) 10Umherirrender: Move maintenance script to own folder [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/396629 [21:40:33] (03PS1) 10Umherirrender: Rename file DisableAccount_body.php to match class [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/396630 [21:47:12] (03PS2) 10Umherirrender: Rename file Timeless.skin.php to match class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/396596 [21:48:27] (03CR) 10jerkins-bot: [V: 04-1] Rename file Timeless.skin.php to match class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/396596 (owner: 10Umherirrender) [21:49:25] (03PS3) 10Umherirrender: Rename file Timeless.skin.php to match class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/396596 [21:49:41] (03CR) 10Umherirrender: "Patch Set 2 + 3: Rebased" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/396596 (owner: 10Umherirrender) [21:56:50] 10MediaWiki-extensions-WikimediaMaintenance: dumpInterwiki.php: allow to run this from our clones - https://phabricator.wikimedia.org/T182508#3825913 (10Aklapper) What are steps to reproduce the problem and get that provided output? I miss context - what is "this script"? Thanks... [22:00:13] (03PS1) 10Umherirrender: Rename classes to match file names [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/396631 [22:01:19] (03CR) 10jerkins-bot: [V: 04-1] Rename classes to match file names [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/396631 (owner: 10Umherirrender) [22:05:21] (03PS2) 10Umherirrender: Rename files to match classes [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/396631 [22:07:54] (03PS1) 10Umherirrender: Rename file Renameuser.hooks.php to match class [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/396632 [22:08:31] (03PS1) 10Pppery: Add proper PLURAL support to Template:Self header messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/396633 (https://phabricator.wikimedia.org/T40576) [22:09:22] (03CR) 10jerkins-bot: [V: 04-1] Rename file Renameuser.hooks.php to match class [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/396632 (owner: 10Umherirrender) [22:09:40] 10Google-Code-in-2017: Add basic Gerrit support to git-repo - https://phabricator.wikimedia.org/T180962#3825920 (10Phantom42) a:03Phantom42 Interesting task! I will work on it [22:11:57] 10Developer-Relations: Manually keeping the Phab project queries for areas on [[mw:Annoying little bugs]] up-to-date is cumbersome - https://phabricator.wikimedia.org/T122683#3825922 (10Aklapper) a:03Aklapper [22:14:29] (03PS2) 10Umherirrender: Rename file Renameuser.hooks.php to match class [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/396632 [22:15:26] 10MediaWiki-extensions-WikimediaMaintenance: dumpInterwiki.php: allow to run this from our clones - https://phabricator.wikimedia.org/T182508#3825923 (10MarcoAurelio) >>! In T182508#3825913, @Aklapper wrote: > What are steps to reproduce the problem and get that provided output? $ php path/to/dumpInterwiki.php... [22:15:53] (03PS1) 10Umherirrender: Rename file ResourceLoaderMuhoganModule.php to match class [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/396634 [22:16:43] Quite silent here for a weekend :D [22:17:46] (03CR) 10Pppery: "Corresponding edit to user of messages: https://commons.wikimedia.org/wiki/Special:Diff/271183748" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/396633 (https://phabricator.wikimedia.org/T40576) (owner: 10Pppery) [22:21:40] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)): Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579#3825926 (10Aklapper) >>! In T170579#3817282, @Jdlrobson wrote: > Looks like st... [22:21:56] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)): Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579#3825927 (10Aklapper) >>! In T170579#3823879, @Jdlrobson wrote: > @Aklapper you... [22:26:08] (03PS1) 10Umherirrender: Rename file PageAssessments.hooks.php to match class [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/396635 [22:27:21] 10TechCom-RfC: Lack of freeform external access to MediaWiki data is a limitation - https://phabricator.wikimedia.org/T181257#3825929 (10Smalyshev) If you want SPARQL access to Mediawiki data, you can use this project: https://www.mediawiki.org/wiki/MW2SPARQL though whether or not it's better depends on the task. [22:32:19] 10Design, 10MinervaNeue, 10Readers-Web-Backlog, 10Google-Code-in-2017, and 2 others: Mobile infobox styles do not work well with multiple column infobox rows - https://phabricator.wikimedia.org/T168716#3825930 (10Aklapper) [22:32:23] divadsn: Silence is golden :) But to be serious, it is night in Europe now, so a lot of people in here are having sleep. Maybe there will be more talk tomorrow [22:33:05] Phantom42, I thought the majority here is Asia and America ^^ [22:33:08] 10Design, 10MinervaNeue, 10Readers-Web-Backlog, 10Google-Code-in-2017, and 2 others: Mobile infobox styles do not work well with multiple column infobox rows - https://phabricator.wikimedia.org/T168716#3374574 (10Aklapper) Imported as https://codein.withgoogle.com/tasks/5830357251260416/ [22:37:42] Well, it is night or early morning in Asia too [22:37:54] And maybe people are busy during weekend doing things they can't do during working week. That's another possible explanation [22:41:37] (03PS1) 10Umherirrender: Move maintenance script to own folder [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/396636 [22:42:19] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017, 10Spike, 10Technical-Debt (RW-Tech-Debt): [Spike 4hrs] phpcs should complain when we use the global keyword without explicitly saying its okay - https://phabricator.wikimedia.org/T146312#3825933 (10Aklapper) Imported as https://codein.withgo... [22:43:16] divadsn: I wouldn't say Asia that much (apart from some folks in India)... more like European and American timezones would be my guess. I would *love* to be proven wrong though... [22:44:13] 10Developer-Relations (Jan-Mar-2018), 10Google-Code-in-2017: Google Code-in 2017: Collect Feedback and Lessons Learned - https://phabricator.wikimedia.org/T181738#3825935 (10Aklapper) >>! In T181738#3820055, @Bawolff wrote: > Private phab task? I went for this option. I will announce it in an email to GCI ment... [22:44:15] (03PS2) 10Umherirrender: Move maintenance script to own folder [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/396636 [22:46:09] (03PS1) 10Umherirrender: Rename file GlobalCssJs.hooks.php to match class [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/396637 [22:47:11] (03PS1) 10Umherirrender: Maintenance for .phpcs.xml [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/396638 [22:55:30] (03PS1) 10Umherirrender: Move maintenance script to own folder [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/396639 [23:01:17] 10Developer-Relations: Manually keeping the Phab project queries for areas on [[mw:Annoying little bugs]] up-to-date is cumbersome - https://phabricator.wikimedia.org/T122683#3825937 (10Aklapper) Certain meta-tags will "always" work, like #easy #documentation tasks. Or project that have exactly one tag, like #Hu... [23:03:03] (03PS1) 10Umherirrender: Rename class MostGloballyLinkedFilesPage to match file [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/396640 [23:04:36] 10MediaWiki-extensions-WikimediaMaintenance: dumpInterwiki.php: allow to run this from our clones - https://phabricator.wikimedia.org/T182508#3825938 (10Aklapper) @MarcoAurelio: Argh, I am sorry! Those who can read task summaries clearly have an advantage. It's been a long day... :-/ [23:04:57] (03PS1) 10Umherirrender: Maintenance for .phpcs.xml [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/396641 [23:14:59] (03PS1) 10Umherirrender: Rename file Newsletter.hooks.php to match class [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396642 [23:23:17] (03PS1) 10Umherirrender: Remove underscore from maintenance script to match class [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/396643 [23:24:57] (03PS1) 10Umherirrender: Rename file OATHAuth.hooks.php to match class [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/396644 [23:31:16] (03PS1) 10Umherirrender: Maintenance for .phpcs.xml [extensions/ReadingLists] - 10https://gerrit.wikimedia.org/r/396645 [23:37:55] 10Google-Code-in-2017: Pick an article about your favorite topic on English Wikipedia and make small edits to it - https://phabricator.wikimedia.org/T181594#3795501 (10Abigalekim) Hi! My name is Abigale Kim. I am a participant of Chicktech's Google Code-In Workshop. I edited the article "Lhasa Apso". I changed t... [23:42:33] (03PS1) 10Umherirrender: Rename maintenance scripts to match file name [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/396646 [23:45:11] 10Google-Code-in-2017: Pick an article about your favorite topic on English Wikipedia and make small edits to it - https://phabricator.wikimedia.org/T181594#3795501 (10Shchambless) Hi, my name is Shayna Chambless and I edited the "Sacred Heart Cathedral Preparatory" page. I linked the places that the choir has t... [23:46:56] 10Google-Code-in-2017: Pick an article about your favorite topic on English Wikipedia and make small edits to it - https://phabricator.wikimedia.org/T181594#3795501 (10AnaXella) I edited the article "Eraser" I changed the 3rd paragraph under History by changing the word, "durable" to "long - lasting." Current:... [23:47:53] 10Google-Code-in-2017: Pick an article about your favorite topic on English Wikipedia and make small edits to it - https://phabricator.wikimedia.org/T181594#3795501 (10Purplecitrus) My name is Jade Li. I am a participant of Chicktech's Google Code-In Workshop! I edited the Forrest Gump movie Wikipedia page by ad... [23:54:09] (03CR) 10Legoktm: [C: 032] Maintenance for .phpcs.xml [extensions/ReadingLists] - 10https://gerrit.wikimedia.org/r/396645 (owner: 10Umherirrender) [23:54:21] (03PS1) 10Umherirrender: Rename file TimeGateResourceFrom302TimeNegotiation.php to match class [extensions/Memento] - 10https://gerrit.wikimedia.org/r/396647 [23:54:23] (03CR) 10Legoktm: [C: 032] Maintenance for .phpcs.xml [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/396641 (owner: 10Umherirrender) [23:54:38] (03CR) 10Legoktm: [C: 032] Maintenance for .phpcs.xml [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/396638 (owner: 10Umherirrender) [23:55:50] (03Merged) 10jenkins-bot: Maintenance for .phpcs.xml [extensions/ReadingLists] - 10https://gerrit.wikimedia.org/r/396645 (owner: 10Umherirrender) [23:56:35] (03CR) 10Legoktm: [C: 032] Move class NostalgiaTemplate to own file [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/396592 (owner: 10Umherirrender) [23:57:28] (03CR) 10Legoktm: [C: 032] Move class ModernTemplate to own file [skins/Modern] - 10https://gerrit.wikimedia.org/r/396594 (owner: 10Umherirrender)