[00:00:19] jdlrobson, [00:00:30] Why do you need to wait? [00:01:16] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog, 10Patch-For-Review: Deploy Reading Lists Service to production - https://phabricator.wikimedia.org/T181107#3821803 (10Tgr) [00:01:25] (03PS10) 10Dmaza: Allow users to prevent new users from sending them email. [core] - 10https://gerrit.wikimedia.org/r/391342 (https://phabricator.wikimedia.org/T138165) (owner: 10Dbarratt) [00:01:26] (03CR) 10Cooltey: [C: 032] Clean up some code in Developer Preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396277 (owner: 10Dbrant) [00:02:33] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog, 10Patch-For-Review: Deploy Reading Lists Service to production - https://phabricator.wikimedia.org/T181107#3779919 (10Tgr) The MediaWiki part is now live everywhere. Follow-up item: fix {T157651} which caused a bit of headache. (I guess I deserve... [00:02:34] (03PS11) 10Dmaza: Allow users to prevent new users from sending them email. [core] - 10https://gerrit.wikimedia.org/r/391342 (https://phabricator.wikimedia.org/T138165) (owner: 10Dbarratt) [00:02:52] I want to ask him about the task's content. on GCI and Phab (T170579) it states that I should remove these four s, but it also says that those are s that differ from the MediaWiki one, which is not true. all of them are present in mediawiki-core/.phpcs.xml [00:02:53] T170579: Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579 [00:03:28] I wouldn't worry about that differing much [00:04:32] but there's anotehr thing [00:04:49] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog: Fix caching of external responses in npm test runs - https://phabricator.wikimedia.org/T152255#3821807 (10bearND) a:03bearND [00:05:07] (03Merged) 10jenkins-bot: Clean up some code in Developer Preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396277 (owner: 10Dbrant) [00:05:08] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog (Kanban): Fix caching of external responses in npm test runs - https://phabricator.wikimedia.org/T152255#2843221 (10bearND) [00:05:24] on the Phab it states that `phpcs` would give 334 errors without those s, but if I remove ALL s from .phpcs.xml it gives my only 166 errors [00:05:53] Some have been fixed? [00:07:15] 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint: "Wikitext syntax highlighting" feature asks the user "confirm that you want to leave" after clicking on the text and not making changes - https://phabricator.wikimedia.org/T177175#3649363 (10MaxSem) a:03MaxSem [00:07:43] (03CR) 10jenkins-bot: Clean up some code in Developer Preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396277 (owner: 10Dbrant) [00:07:54] Albert221: I think you're worrying about things too much [00:08:14] I just don't want to do what I shouldn't do for the third time :( [00:08:58] Sorry? [00:09:25] (03CR) 10Kaldari: [C: 032] "Tested and reviewed." [core] - 10https://gerrit.wikimedia.org/r/396007 (https://phabricator.wikimedia.org/T181503) (owner: 10Jon Harald Søby) [00:09:26] I misunderstood tasks goals two times already [00:09:49] and I just want to clearly understand what I should do to avoid that :) [00:10:24] What have you misunderstood about it? [00:10:46] I meant in previous tasks. I missunderstood two previous tasks already [00:11:28] And talking about this one, I don't know if I should remove only those four s specified on Phabricator or all of them [00:11:33] It'll happen [00:11:33] The worse thing is not asking [00:11:34] If you don't understand, just ask [00:11:38] Read it a few times [00:11:51] "The task should be timeboxed till 2-3hrs - work on re-enabling one sniff at a time. If you exceed the timebox push what you managed" [00:11:58] Do as many as you can [00:12:34] hmm, okay, thanks for help [00:12:56] The task only mentions those four. So do them [00:13:23] Some might never be fixable [00:15:32] 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint: "Wikitext syntax highlighting" feature asks the user "confirm that you want to leave" after clicking on the text and not making changes - https://phabricator.wikimedia.org/T177175#3821819 (10Quiddity) [00:16:46] (03Merged) 10jenkins-bot: Add custom collation for Northern Sami [core] - 10https://gerrit.wikimedia.org/r/396007 (https://phabricator.wikimedia.org/T181503) (owner: 10Jon Harald Søby) [00:23:40] 10MediaWiki-Email, 10Anti-Harassment, 10Mail: Email preferences should show as disabled/enabled, not hide/show (blocked by OOUI) - https://phabricator.wikimedia.org/T180729#3821830 (10TBolliger) >>! In T180729#3821825, @dmaza wrote: > As part of T138165 ([[ https://gerrit.wikimedia.org/r/#/c/391342 | patch h... [00:32:42] (03CR) 10jenkins-bot: Add custom collation for Northern Sami [core] - 10https://gerrit.wikimedia.org/r/396007 (https://phabricator.wikimedia.org/T181503) (owner: 10Jon Harald Søby) [00:38:25] (03PS1) 10Pppery: Clarify documentation of pithumbsize parameter [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) [00:48:08] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Wikimedia-maintenance-script-run: Run maintenance/cleanupUsersWithNoId.php on all wikis - https://phabricator.wikimedia.org/T181731#3800238 (10Graham87) Another complication relating to this script would be T2323, involving usernames stored with underlines, e... [00:50:08] (03CR) 10Jdlrobson: [C: 04-1] Clarify documentation of pithumbsize parameter (032 comments) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [00:52:19] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Wikimedia-maintenance-script-run: Run maintenance/cleanupUsersWithNoId.php on all wikis - https://phabricator.wikimedia.org/T181731#3821852 (10Graham87) Also, a relevant technical village pump thread: https://en.wikipedia.org/w/index.php?title=Wikipedia:Villa... [00:53:24] Albert221: hey sorry, i dont follow wikimedia-dev as gerrit makes it far too spammy, so I almost missed your comments. Do you still have problems or did you work them out? If so always feel free to ask on the ticket itself or in #wikimedia-mobile (i put that on my profile in GoogleCodeIn) - i'm usually pretty responsive there when I'm around :) [00:54:13] jdlrobson, I pinged you on that channel :) I think that Reedy gave me enough information :) [00:54:17] but yeh Reedy is right - don't worry too much. Try removing one of the ignored sniffs and fix errors that it opens up. There was a previous attempt on https://gerrit.wikimedia.org/r/394324 which hopefully will give you some ideas [00:54:32] Albert221: so you did. That was /my/ bad :) [00:55:04] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: [BUG] Invisible icons on toolbar when trying to long press and select texts in <= API 21 - https://phabricator.wikimedia.org/T180186#3821853 (10cooltey) Updated: Test again on Samsung Galaxy S6 (Verizon) - Android 5.02, this time I am... [00:55:21] (03PS2) 10Pppery: Clarify documentation of pithumbsize parameter [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) [00:57:04] (03CR) 10Jdlrobson: [C: 04-1] Clarify documentation of pithumbsize parameter (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [01:02:11] (03CR) 10Jdlrobson: [C: 032] Update RuboCop Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/395493 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [01:09:06] (03CR) 10Pppery: Clarify documentation of pithumbsize parameter (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [01:09:08] (03Merged) 10jenkins-bot: Update RuboCop Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/395493 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [01:10:59] 10MediaWiki-extensions-Score, 10VisualEditor: Use TitleInputWidget in the Score inspector for choosing overriding files - https://phabricator.wikimedia.org/T114798#3821859 (10Ebe123) [01:11:13] 10Support-and-Safety, 10Wikimedia-Site-requests: Disable 2FA for EVinente - https://phabricator.wikimedia.org/T182373#3821861 (10RuyP) [01:11:23] 10MediaWiki-extensions-Score, 10VisualEditor: Use TitleInputWidget in the Score inspector for choosing overriding files - https://phabricator.wikimedia.org/T114798#1706550 (10Ebe123) Took me a little while to understand the request. Updating description and title. [01:11:37] (03CR) 10jenkins-bot: Update RuboCop Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/395493 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [01:11:49] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog, 10Patch-For-Review: Deploy Reading Lists Service to production - https://phabricator.wikimedia.org/T181107#3821872 (10Tgr) @mobrovac @Pchelolo the MediaWiki side is now live. Any thoughts on scheduling the RESTBase deployment? [01:12:43] 04(no projects): fix needed for cases where users have multiple userids, such as user:0 on enwiki - https://phabricator.wikimedia.org/T182374#3821874 (10Graham87) [01:15:24] 04(no projects): fix needed for cases where users have multiple userids, such as user:0 on enwiki - https://phabricator.wikimedia.org/T182374#3821887 (10Graham87) Also, the script should probably increment user_editcount in the user table if that's not done automatically by some other process. [01:18:32] 10MediaWiki-Export-or-Import, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Cross-wiki imports should set correct rev_user, not 0 - https://phabricator.wikimedia.org/T111605#3821891 (10Graham87) >>! In T111605#3820127, @TheDJ wrote: > Tagging @Graham87 since he does a l... [01:34:41] (03PS1) 10Reedy: Fix missing if from $wgDBssl comment [core] - 10https://gerrit.wikimedia.org/r/396295 [01:38:35] looks like i could not finish my task. what happend then? [01:38:58] Depends [01:39:05] What's the task? Were you able to do some of it? [01:39:10] What was the reason you couldn't finish it? [01:42:12] introducing database to pytest. all of my work was bug probably. i could not finish because i might play too much, i am just newly learn python when got this task, i am not understand what the task and what is pytest 3 days ago [01:43:03] at least you asking whats the reason and thats it [01:46:05] (03PS1) 10Albert221: Fix phpcs issues and remove its s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 [01:46:57] (03PS2) 10Albert221: Fix phpcs issues and remove its s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) [01:47:06] (03CR) 10Reedy: [C: 04-1] "You should ask the task your working on to the commit summary" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) (owner: 10Albert221) [01:47:10] heh [01:47:11] Snap [01:47:12] 10Reading List Service, 10Reading-Infrastructure-Team-Backlog, 10Patch-For-Review: Deploy Reading Lists Service to production - https://phabricator.wikimedia.org/T181107#3821899 (10Pchelolo) @Tgr given that the next week is the last one before deployment freeze an dI assume you want to be able to test agains... [01:47:41] Reedy, you mean the lack of Bug? [01:47:45] Yup [01:47:53] fixed before you commented! :D [01:55:35] good night everyone :) [01:57:50] 10MinervaNeue, 10MobileApp, 10Wikipedia-Android-App-Backlog, 10CSS, and 3 others: "a.mw-selflink" links miss styling - https://phabricator.wikimedia.org/T181472#3821900 (10Od1n) I think returning a modified, different markup on mobile version is quite surprising, and a wide open door for bugs. As visible o... [02:02:22] 10MinervaNeue, 10MobileApp, 10Wikipedia-Android-App-Backlog, 10CSS, and 3 others: "a.mw-selflink" links miss styling - https://phabricator.wikimedia.org/T181472#3821901 (10Od1n) What I'm suggesting: * First, just add my CSS, * Then possibly, in a new ticket, transform to 10MinervaNeue, 10MobileApp, 10Wikipedia-Android-App-Backlog, 10CSS, and 3 others: "a.mw-selflink" links miss styling - https://phabricator.wikimedia.org/T181472#3821902 (10Od1n) Just noticed this: apparently, in the past, the generated elements were , then at some point it has been... [02:10:30] (03CR) 10Legoktm: [C: 032] Fix missing if from $wgDBssl comment [core] - 10https://gerrit.wikimedia.org/r/396295 (owner: 10Reedy) [02:10:52] (03CR) 10Legoktm: [C: 032] Make travis test against PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396288 (owner: 10Reedy) [02:11:31] (03CR) 10Legoktm: [C: 032] Preferences: Sort list of skins by internal name [core] - 10https://gerrit.wikimedia.org/r/396083 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [02:12:02] 10Android-app-feature-Feeds, 10Wikipedia-Android-App-Backlog: Panorama picture resolution too low - https://phabricator.wikimedia.org/T182375#3821903 (10Shizhao) [02:13:08] (03CR) 10Legoktm: [C: 032] Preferences: Display the default skin first in the list [core] - 10https://gerrit.wikimedia.org/r/396084 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [02:13:15] (03PS1) 10BearND: Bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) [02:18:16] (03Merged) 10jenkins-bot: Fix missing if from $wgDBssl comment [core] - 10https://gerrit.wikimedia.org/r/396295 (owner: 10Reedy) [02:18:39] (03Merged) 10jenkins-bot: Make travis test against PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396288 (owner: 10Reedy) [02:20:29] (03Merged) 10jenkins-bot: Preferences: Sort list of skins by internal name [core] - 10https://gerrit.wikimedia.org/r/396083 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [02:24:40] (03Merged) 10jenkins-bot: Preferences: Display the default skin first in the list [core] - 10https://gerrit.wikimedia.org/r/396084 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [02:26:12] gotta love git [02:26:13] https://owo.sh/43b280.png [02:29:59] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Support adaptive icon - https://phabricator.wikimedia.org/T182376#3821924 (10Shizhao) [02:30:31] (03CR) 10jenkins-bot: Fix missing if from $wgDBssl comment [core] - 10https://gerrit.wikimedia.org/r/396295 (owner: 10Reedy) [02:40:54] (03CR) 10jenkins-bot: Make travis test against PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396288 (owner: 10Reedy) [02:48:03] eisenhaus335: Sorry to hear that there are problems with your task. Is there any way we can help? For example, you may commit the part you have now and we may take a look and help you to fix issues you have or to explain things you don't fully understand. According to your messages so far, looks like your initial direction was right. So I think you can complete the task with a bit of help. [02:49:01] i am now understand it. just need more time to fix my mistake xD [02:50:22] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, 10NewPHP: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3821936 (10Reedy) [02:51:09] (03CR) 10jenkins-bot: Preferences: Sort list of skins by internal name [core] - 10https://gerrit.wikimedia.org/r/396083 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [02:51:13] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10NewPHP: unserialize() error in test*MetadataExtraction - https://phabricator.wikimedia.org/T182378#3821947 (10Reedy) [02:51:53] 10MediaWiki-Authentication-and-authorization, 10NewPHP: Session test failures in PHP 7.2 - https://phabricator.wikimedia.org/T182379#3821958 (10Reedy) [02:52:29] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10NewPHP: Upload test failures in PHP 7.2 - https://phabricator.wikimedia.org/T182380#3821968 (10Reedy) [02:53:59] 10MediaWiki-Core-Tests, 10NewPHP: WatchedItemIntegrationTest should suppress WatchedItem deprecated calls - https://phabricator.wikimedia.org/T182381#3821979 (10Reedy) [02:55:11] 10MediaWiki-Core-Tests, 10MediaWiki-Parser, 10NewPHP: ParserIntegrationTest failures on PHP 7.2 - https://phabricator.wikimedia.org/T182382#3821990 (10Reedy) [02:55:33] That's nice! Good luck with fixing the mistake! And if you will need some help - don't hesitate to ask. [02:57:48] 10MediaWiki-Core-Tests, 10NewPHP: XMP Tests failing on PHP 7.1 - https://phabricator.wikimedia.org/T182365#3822006 (10Reedy) Few more on PHP 7.2 too... ``` 2) XMPTest::testXMPParse with data set #0 ('\n', array(array('0/10', '9')), '[1.xmp] parseType=Resource test') [1.xm... [02:58:27] 10MediaWiki-Core-Tests, 10MediaWiki-File-management, 10Commons, 10Multimedia, 10NewPHP: XMP Tests failing on PHP 7.1 - https://phabricator.wikimedia.org/T182365#3822007 (10Reedy) [02:59:13] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10NewPHP: More file related test failures on PHP 7.2 - https://phabricator.wikimedia.org/T182383#3822009 (10Reedy) [02:59:38] (03CR) 10jenkins-bot: Preferences: Display the default skin first in the list [core] - 10https://gerrit.wikimedia.org/r/396084 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [03:00:44] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Support adaptive icon - https://phabricator.wikimedia.org/T182376#3822026 (10Dbrant) [03:00:46] 10Design, 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Mobile: Adaptive Icons for Android app - https://phabricator.wikimedia.org/T174301#3822024 (10Dbrant) [03:03:07] 10MediaWiki-Core-Tests, 10NewPHP: WatchedItemIntegrationTest should suppress WatchedItem deprecated calls - https://phabricator.wikimedia.org/T182381#3822028 (10Reedy) They were originally added in https://github.com/wikimedia/mediawiki/commit/ee7e5636faaf16462c330871cd51fb4ed18d837a Looks like they want movi... [03:07:02] (03PS1) 10Reedy: Stop using Deprecated WatchedItem::IGNORE_USER_RIGHTS [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/396298 [03:09:49] (03PS1) 10Reedy: Remove WatchedItem deprecated methods [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) [03:10:01] (03CR) 10Reedy: [C: 04-1] "Needs RELEASE-NOTES" [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) (owner: 10Reedy) [03:12:03] (03CR) 10Reedy: [C: 04-1] "https://gerrit.wikimedia.org/r/#/c/396298/1 was the last usage outside core" [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) (owner: 10Reedy) [03:15:23] 10MediaWiki-Core-Tests, 10NewPHP, 10Patch-For-Review: Remove Deprecated WatchedItem methods and constants - https://phabricator.wikimedia.org/T182381#3822032 (10Reedy) [03:15:57] 10MinervaNeue, 10MobileApp, 10Wikipedia-Android-App-Backlog, 10CSS, and 3 others: "a.mw-selflink" links miss styling - https://phabricator.wikimedia.org/T181472#3822034 (10Od1n) Here it is: T160480 ([[ https://gerrit.wikimedia.org/r/343204 | gerrit ]]). Also, along this patch the mobile styles were probabl... [03:22:49] (03PS2) 10Reedy: Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) [03:25:09] (03PS3) 10Reedy: Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) [03:27:38] 10MediaWiki-Maintenance-scripts: fix needed for cases where users have multiple userids, such as user:0 on enwiki - https://phabricator.wikimedia.org/T182374#3822037 (10Reedy) [03:28:38] (03CR) 10jerkins-bot: [V: 04-1] Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) (owner: 10Reedy) [03:29:05] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 2 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3822038 (10Reedy) [03:29:30] (03PS4) 10Reedy: Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) [03:35:05] (03CR) 10jerkins-bot: [V: 04-1] Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) (owner: 10Reedy) [03:35:54] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 19 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3822039 (10Reedy) Some, but not many to go! ``` reedy@ubuntu6... [03:38:11] (03PS5) 10Reedy: Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) [03:45:59] (03PS6) 10Legoktm: Remove WatchedItem constants and methods deprecated in REL1_27 [core] - 10https://gerrit.wikimedia.org/r/396299 (https://phabricator.wikimedia.org/T182381) (owner: 10Reedy) [03:47:03] (03CR) 10Legoktm: [C: 032] Stop using Deprecated WatchedItem::IGNORE_USER_RIGHTS [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/396298 (owner: 10Reedy) [03:48:49] (03Merged) 10jenkins-bot: Stop using Deprecated WatchedItem::IGNORE_USER_RIGHTS [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/396298 (owner: 10Reedy) [03:53:50] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 19 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3822042 (10Reedy) And possibly some false positives here? Ce... [03:56:24] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 19 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3822043 (10Reedy) ``` reedy@ubuntu64-web-esxi:/var/www/wiki/m... [03:56:58] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3822044 (10Reedy) [04:03:21] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3822050 (10Reedy) [04:14:57] (03Draft2) 10Yaron Koren: Skip 'replacement' tables in drilldown display, recreate script [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/396300 [04:16:34] (03CR) 10Yaron Koren: [C: 032] Skip 'replacement' tables in drilldown display, recreate script [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/396300 (owner: 10Yaron Koren) [04:18:28] (03Merged) 10jenkins-bot: Skip 'replacement' tables in drilldown display, recreate script [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/396300 (owner: 10Yaron Koren) [04:19:21] Hi~I'm a student from China. I just join the Google-Code-in-2017. [04:27:51] 10Patch-For-Review, 10Release, 10Train Deployments: MW-1.28.0-wmf.19 deployment blockers - https://phabricator.wikimedia.org/T143328#3822070 (10tstarling) [04:27:58] 10MediaWiki-extensions-WikibaseRepository, 10Scap, 10Wikidata, 10Beta-Cluster-reproducible, and 5 others: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes - https://phabricator.wikimedia.org/T145819#3822066 (10tstarling) 0... [04:42:04] thinker: Hi, Welcome [04:44:25] (03PS1) 10Tim Starling: Fix maintenance script failure when run as a child of a FastCGI worker [core] - 10https://gerrit.wikimedia.org/r/396301 (https://phabricator.wikimedia.org/T111441) [04:46:04] (03CR) 10Aklapper: [C: 031] "looks good to me" [core] - 10https://gerrit.wikimedia.org/r/395809 (owner: 10Freddy2001) [04:46:44] 10MediaWiki-Configuration, 10MediaWiki-Maintenance-scripts, 10Patch-For-Review, 10Wikimedia-Incident: SiteConfiguration::getConfig() does not work in Wikimedia production - https://phabricator.wikimedia.org/T111441#1603869 (10tstarling) Incredible how a single line of rubbish code I wrote in 2004 can have... [04:59:07] 10MediaWiki-extensions-LoginNotify, 10Android-app-Bugs, 10Community-Tech, 10Wikipedia-Android-App-Backlog: Notification of failed login attempt triggered by Wikipedia Android app (beta)? - https://phabricator.wikimedia.org/T178746#3822092 (10Niharika) >>! In T178746#3816121, @Dbrant wrote: > We're still no... [05:03:24] (03CR) 10BryanDavis: [V: 031 C: 032] "Tested with hhvm and php5:" [core] - 10https://gerrit.wikimedia.org/r/396301 (https://phabricator.wikimedia.org/T111441) (owner: 10Tim Starling) [05:12:00] 10MediaWiki-General-or-Unknown: Fatal error: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error - https://phabricator.wikimedia.org/T182387#3822106 (10Nischayn22) [05:12:28] 10MediaWiki-General-or-Unknown: Fatal error: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error - https://phabricator.wikimedia.org/T182387#3822116 (10Nischayn22) [05:13:17] (03Merged) 10jenkins-bot: Fix maintenance script failure when run as a child of a FastCGI worker [core] - 10https://gerrit.wikimedia.org/r/396301 (https://phabricator.wikimedia.org/T111441) (owner: 10Tim Starling) [05:14:00] 10MediaWiki-extensions-UniversalLanguageSelector, 10I18n, 10Upstream: Inverted comma character shown incorrectly on Burmese wikis - https://phabricator.wikimedia.org/T41627#469796 (10KartikMistry) Looks like no update in GitHub either. [05:15:01] 10MediaWiki-extensions-UniversalLanguageSelector, 10Language-Team, 10Tracking: Font support in Universal Language Selector (tracking) - https://phabricator.wikimedia.org/T55015#3822123 (10KartikMistry) [05:15:03] 10MediaWiki-extensions-UniversalLanguageSelector: Web fonts not displayed on Samsung Galaxy S II, Motorola Droid, Razr and HTC One X - https://phabricator.wikimedia.org/T51934#3822121 (10KartikMistry) 05Open>03declined >>! In T51934#2564087, @Nikerabbit wrote: > As far as I understand the listed devices are... [05:16:24] 10MediaWiki-extensions-UniversalLanguageSelector, 10Language-Team, 10Tracking: Font support in Universal Language Selector (tracking) - https://phabricator.wikimedia.org/T55015#562810 (10KartikMistry) [05:16:26] 10MediaWiki-extensions-UniversalLanguageSelector, 10I18n, 10Patch-For-Review: Add support for Runic - https://phabricator.wikimedia.org/T37408#3822125 (10KartikMistry) 05Open>03declined Runr is script, which can't be assigned to fonts in ULS. [05:21:24] (03CR) 10jenkins-bot: Fix maintenance script failure when run as a child of a FastCGI worker [core] - 10https://gerrit.wikimedia.org/r/396301 (https://phabricator.wikimedia.org/T111441) (owner: 10Tim Starling) [05:21:26] (03Draft2) 10Reception123: Archive SwiftCloudFiles extension [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/396302 (https://phabricator.wikimedia.org/T182384) [05:22:12] (03CR) 10jerkins-bot: [V: 04-1] Archive SwiftCloudFiles extension [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/396302 (https://phabricator.wikimedia.org/T182384) (owner: 10Reception123) [05:22:48] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3822130 (10Reception123) [05:27:01] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3822132 (10Reception123) Not sure why, but gerritbot didn't post the change: https://gerrit.wikimedia.org/r/#/c/396302/ [05:29:20] 10Developer-Relations (Oct-Dec 2017): Andre to provide "New Authors" 2017 data from Sept, Oct and Nov to Srishti soon - https://phabricator.wikimedia.org/T182037#3822133 (10Aklapper) Data on https://wikimedia.biterg.io/app/kibana#/dashboard/C_Gerrit_Demo is updated now. See https://wikimedia.biterg.io/goto/5bee... [05:35:16] (03PS1) 10Tim Starling: Split limit report out of Parser::parse() [core] - 10https://gerrit.wikimedia.org/r/396303 [05:49:25] 10MediaWiki-extensions-OATHAuth, 10Support-and-Safety, 10Security, 10Security-Extensions: Allow functionaries to reset second factor on low-risk accounts - https://phabricator.wikimedia.org/T180896#3822137 (10Tgr) [05:50:42] 10MediaWiki-General-or-Unknown: Fatal error: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error - https://phabricator.wikimedia.org/T182387#3822138 (10Nischayn22) On further debugging it seems that I have GD installed and the only problem is that the image size was somehow 0 bytes. I am usi... [06:01:44] (03CR) 10Niharika29: [C: 031] "Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/391751 (https://phabricator.wikimedia.org/T178842) (owner: 10Dbarratt) [06:08:36] 10Timeless: Ditch most of the colors in Timeless - https://phabricator.wikimedia.org/T182388#3822142 (10Harej) [06:11:17] 10Timeless: Make body text on Timeless bigger and with more space between lines - https://phabricator.wikimedia.org/T182389#3822151 (10Harej) [06:29:01] 10Page-Previews, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, 10Reading-Infrastructure-Team-Backlog (Kanban): Show HTML summaries on cswiki - https://phabricator.wikimedia.org/T182321#3822164 (10phuedx) [06:32:46] 10Page-Previews, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, 10Reading-Infrastructure-Team-Backlog (Kanban): Show HTML summaries on cswiki - https://phabricator.wikimedia.org/T182321#3822166 (10phuedx) Thanks for double-checking this, @Jdlrobson. As you note, the gateway that's currently in use is th... [06:32:57] (03CR) 10VolkerE: [C: 031] Avoid OOUI/download icon nameclash [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/396100 (https://phabricator.wikimedia.org/T182162) (owner: 10Jdlrobson) [06:39:19] (03PS4) 10Legoktm: Add 4 new high priority linter categories [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396128 (owner: 10C. Scott Ananian) [06:39:46] (03CR) 10Legoktm: [C: 032] "PS4: I got rid of the / in the i18n messages in favor of just writing out "or"" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396128 (owner: 10C. Scott Ananian) [06:42:14] (03Merged) 10jenkins-bot: Add 4 new high priority linter categories [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396128 (owner: 10C. Scott Ananian) [06:42:45] (03PS5) 10Legoktm: Move $hasNameCats into the information in extension.json [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396142 (owner: 10C. Scott Ananian) [06:42:47] (03CR) 10Legoktm: [C: 032] Move $hasNameCats into the information in extension.json [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396142 (owner: 10C. Scott Ananian) [06:44:12] (03CR) 10Legoktm: Move category IDs into the extension.json information (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396162 (owner: 10C. Scott Ananian) [06:44:34] (03Merged) 10jenkins-bot: Move $hasNameCats into the information in extension.json [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396142 (owner: 10C. Scott Ananian) [06:45:44] (03CR) 10Legoktm: "Doesn't this mean we'd to duplicate the category ID list in both Parsoid and Linter now?" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396280 (owner: 10C. Scott Ananian) [06:46:55] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3822178 (10Legoktm) [06:46:58] 10MediaWiki-Recent-changes, 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Regression: The current version of RC has the legend over first items - https://phabricator.wikimedia.org/T182357#3822180 (10Legoktm) [06:51:27] (03CR) 10Legoktm: [C: 032] Convert SystemGifts to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392361 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [06:53:10] (03Merged) 10jenkins-bot: Convert SystemGifts to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392361 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:02:38] (03PS3) 10Legoktm: Convert UserBoard to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392453 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:02:40] (03PS4) 10Legoktm: Convert UserRelationship to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392340 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:04:45] (03CR) 10Legoktm: [C: 032] Convert UserBoard to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392453 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:04:52] (03CR) 10Legoktm: [C: 032] Convert UserRelationship to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392340 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:05:20] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3822182 (10Nirmos) Found it. "Group changes by page in recent changes and watchlist" at Special:Preferences#mw-prefsection-rc causes this. [07:06:37] (03Merged) 10jenkins-bot: Convert UserBoard to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392453 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:06:48] (03Merged) 10jenkins-bot: Convert UserRelationship to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392340 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:10:39] (03PS3) 10Legoktm: Convert UserStats to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392526 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:10:50] 10OOjs-UI, 10UI-Standardization, 10UI-Standardization-Kanban: OOjs UI: Support Responsive Toolbars - https://phabricator.wikimedia.org/T175953#3822185 (10Volker_E) We should go with the hardest use case as demo foundation – 320px. Some of the prototypes seem not to be laid out for that. [07:10:53] (03CR) 10Legoktm: [C: 032] Convert UserStats to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392526 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:12:54] (03Merged) 10jenkins-bot: Convert UserStats to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392526 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:14:47] (03PS2) 10Legoktm: Convert UserGifts to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392693 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:15:32] (03CR) 10Legoktm: [C: 032] Convert UserGifts to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392693 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:17:20] (03Merged) 10jenkins-bot: Convert UserGifts to use extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/392693 (https://phabricator.wikimedia.org/T152865) (owner: 10SamanthaNguyen) [07:20:30] 10MediaWiki-Configuration, 10Goal, 10Patch-For-Review: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668#3822198 (10Legoktm) [07:20:32] 10Social-Tools, 10SocialProfile, 10Patch-For-Review, 10Technical-Debt: Convert SocialProfile to use extension registration - https://phabricator.wikimedia.org/T152865#3822196 (10Legoktm) 05stalled>03Open @SamanthaNguyen nice work so far! In the future I'd recommend just building a stack of patches (jus... [07:36:07] https://travis-ci.org/eisenhaus335/wikilabels/builds/313353024 [07:37:33] not sure this was bug or "unpurposed use" code [07:39:03] its said minconn and maxconn param is missing. but what i need to input then? [08:10:07] (03PS7) 10Pmiguelpirzer: BlueSpicePermissionManager: Change config [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/393763 [08:13:46] (03PS4) 10Pmiguelpirzer: BlueSpiceNamespaceManager: Change config [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/394030 [08:25:23] (03CR) 10Robert Vogel: [C: 031] "I'd like to have mglaser's vote here" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/389988 (owner: 10ItSpiderman) [08:26:59] 10InternetArchiveBot, 10Wiktionary: Wiktionary support - https://phabricator.wikimedia.org/T181879#3822205 (10jberkel) there's consensus to use IABot: https://en.wiktionary.org/wiki/Wiktionary:Beer_parlour#Inviting_IABot [08:35:52] eisenhaus335: I will check it now [08:36:27] andre__, I know that pinging a mentor isn't the right thing, but have you seen prtksxna recently? [08:37:30] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10German-Community-Wishlist, 10WMDE-QWERTY-Team-Board: Paragraph indicated as moved, though it wasn't - https://phabricator.wikimedia.org/T182300#3822212 (10Schnark) It even happens for paragraphs with nothing between them: https://de.wikipedia.org/w/index.php?titl... [08:37:36] lets find it together then :) [08:37:50] even though something might turn bad *joke [08:37:52] eisenhaus335: wikilabels/database/db.py:31: TypeError [08:38:06] Have you checked what's there? [08:39:38] (03PS3) 10Pmiguelpirzer: BlueSpiceReaders: Change config [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/394036 [08:39:39] error on line 31 but my file just 23 line? wait wut? [08:39:52] eisenhaus335: I think something is wrong when you are creating database with constructor. You need to provide some params. I will give more exact description in a few moments... [08:40:44] Phantom42, what are your role in here actually? just wondering [08:41:18] eisenhaus335: I am GCI participant (2017 and previously 2016) [08:41:19] (03PS4) 10Pmiguelpirzer: BlueSpiceReaders: Change config [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/394036 [08:42:05] eisenhaus335, line 31 shows this: *args, cursor_factory=RealDictCursor, **kwargs) [08:43:04] i dont look on file location [08:43:10] It seems you are missing args for ThreadedConnectionPool [08:43:12] http://initd.org/psycopg/docs/pool.html [08:43:20] There you go :) [08:43:50] Yes, and as I said those args need to be passed via constructor [08:43:58] but yeah thats the problem. i am finding what param needed [08:44:24] (03PS3) 10Pmiguelpirzer: BlueSpiceDashboards: Change config [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/394052 [08:45:09] the question what is mincoon and the maxcoon. if this search need long time i would like to set that both param as None/Null [08:46:22] Oh, I found [08:46:22] Instead of using constructor you need to call `DB.from_config` [08:46:31] minconn and maxconn are the min and max amount of connections [08:46:31] "New minconn connections are created automatically." [08:47:01] `from_config` uses infromation from config and sets values for `maxconn` and `minconn` [08:48:32] btw, default values are 1 for `minconn` and 5 for `maxconn` [08:51:22] oh! just found that method and the pattern is correct [08:53:02] So you loaded yaml database config file and passed it to `DB.from_config`? [08:54:50] because i am lazy person. i am just declare the minconn and maxconn and put it on constructor of db. its might work... [08:55:45] Well, don't forget about database user and password [08:58:10] 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Special:ContentTranslation page: Mobile UI layout issues - https://phabricator.wikimedia.org/T179148#3822230 (10Petar.petkovic) [09:15:18] 10Wikimedia-User-Group-Basque: Kabi@ Durango - Wikieguna antolatzen - https://phabricator.wikimedia.org/T175550#3596287 (10Gorkaazk) Etor eta biok hurbilduko gara mendebaldetik. Ideia bat photocall horretarako: Behin idazleei erretratua eskatuta, eskatzea libre denez, erakuts dezatela eskuan libururen bat. Hor... [09:19:38] 10MediaWiki-Internationalization, 10MediaWiki-User-preferences, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), 10Patch-For-Review: Sort skins by their ID and default position, not by their localised name - https://phabricator.wikimedia.org/T181112#3780079 (10Nikerabbit) I understand placi... [09:19:58] (03CR) 10Zfilipin: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/395025 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [09:20:44] (03CR) 10Nikerabbit: "Wouldn't it be easier to just prepend the default skin name after sorting?" [core] - 10https://gerrit.wikimedia.org/r/396084 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [09:23:17] (03PS3) 10Pmiguelpirzer: BlueSpicePagesVisited: Change config [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/394061 [09:24:40] (03Abandoned) 10Zfilipin: Update RuboCop Ruby gem in oojs-ui [vendor] - 10https://gerrit.wikimedia.org/r/396047 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [09:27:24] (03CR) 10jerkins-bot: [V: 04-1] Update RuboCop Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/395025 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [09:32:48] 10MediaWiki-extensions-UniversalLanguageSelector, 10translatewiki.net, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)): Simplified/Traditional Chinese not found when "Chinese" entered - https://phabricator.wikimedia.org/T73891#3822280 (10Nikerabbit) [09:33:50] divadsn: o/ [09:36:14] (03Abandoned) 10Zfilipin: Update RuboCop Ruby gem [wikimedia/education/WikiEduDashboard] - 10https://gerrit.wikimedia.org/r/396056 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [09:38:47] (03PS3) 10Pmiguelpirzer: BlueSpiceSmartList [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/394979 [09:41:43] (03CR) 10Zfilipin: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/389542 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [09:42:02] (03CR) 10Zfilipin: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/378499 (owner: 10Framawiki) [09:42:07] (03CR) 10Zfilipin: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/364175 (owner: 10Matthias Mullie) [09:42:12] (03CR) 10Zfilipin: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163032 (owner: 10MarkTraceur) [09:42:18] (03CR) 10Zfilipin: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169496 (owner: 10Gergő Tisza) [09:42:24] (03CR) 10jerkins-bot: [V: 04-1] Use CommonsMetadata title instead of filename [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169496 (owner: 10Gergő Tisza) [09:45:09] 10Proton, 10Readers-Web-Backlog (Design): Articles with tables larger than page will shrink aspect ratio and adjust font-size - https://phabricator.wikimedia.org/T175005#3822297 (10Nirzar) I tried a bunch of ways to break the table in print mode as well as all the @page props but none of it works. tried zoom a... [09:45:35] divadsn: I'll be reviewing your patch today. Thanks! [09:46:59] (03CR) 10jerkins-bot: [V: 04-1] Remove special color treatment of close icon on confirmation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/389542 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [09:47:20] (03CR) 10jerkins-bot: [V: 04-1] Retain image size when switching embed type [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163032 (owner: 10MarkTraceur) [09:47:53] (03CR) 10jerkins-bot: [V: 04-1] Instead of "About", use "About this interface" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/378499 (owner: 10Framawiki) [09:48:09] (03CR) 10jerkins-bot: [V: 04-1] Fix mw.storage typehint [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/364175 (owner: 10Matthias Mullie) [09:49:18] prtksxna, alright thanks, hope it looks good, have tested it carefully :) [09:49:41] divadsn: Great! Will take a look. [09:53:13] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822298 (10zeljkofilipin) [09:57:07] (03CR) 10Zfilipin: "mwext-qunit-jessie fails because of T182395" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/364175 (owner: 10Matthias Mullie) [09:57:12] (03CR) 10Zfilipin: "mwext-qunit-jessie fails because of T182395" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/378499 (owner: 10Framawiki) [09:57:16] (03CR) 10Zfilipin: "mwext-qunit-jessie fails because of T182395" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/163032 (owner: 10MarkTraceur) [09:57:20] (03CR) 10Zfilipin: "mwext-qunit-jessie fails because of T182395" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/389542 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [09:57:25] (03CR) 10Zfilipin: "mwext-qunit-jessie fails because of T182395" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169496 (owner: 10Gergő Tisza) [09:57:28] (03CR) 10Zfilipin: "mwext-qunit-jessie fails because of T182395" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/395025 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [10:00:22] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10User-zeljkofilipin: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822318 (10zeljkofilipin) p:05Triage>03Low [10:02:03] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10User-zeljkofilipin: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822298 (10zeljkofilipin) [10:02:56] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3822327 (10Nirzar) after trying for an hour, I think I found the regression and fix for this! {F11679370} It seems the font-family was the culprit == Fix... [10:03:51] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10User-zeljkofilipin: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822328 (10zeljkofilipin) [10:04:27] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog: Equations displaying too large in new print styles - https://phabricator.wikimedia.org/T181138#3822329 (10Nirzar) after trying for an hour, I think I found the regression and fix for this! {F11679370} It seems the font-family was the culprit == Fix ```... [10:06:21] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10User-zeljkofilipin: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822330 (10zeljkofilipin) @matthiasmullie, @Framawiki, @MarkTraceur, @Volker_E: you are the owners of the recent patches. Do you k... [10:08:00] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Design (RW-Design-Debt), 10Patch-For-Review, 10Readers-Web-Kanban-Board: Update the title alignment for special pages - https://phabricator.wikimedia.org/T180095#3822332 (10Nirzar) based on reading-web-stage {meme, src=votecat, above=looks, below=good} [10:10:09] 10TechCom-RfC (ArchCom-Approved): Handling of imported usernames - https://phabricator.wikimedia.org/T179832#3822334 (10daniel) This RFC has been approved for implementation as no objections have been raised during the last call period. [10:10:52] 10Design, 10MinervaNeue, 10Mobile-Web-Settings, 10MobileFrontend, and 2 others: Display namespace in mobile view of the page history - https://phabricator.wikimedia.org/T147722#3822335 (10Nirzar) >the distinction would only appear on talk namespaces? yes, extra label of namespace won't exist for other nam... [10:12:03] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Change font size controls to use small, regular, large and extra large buckets - https://phabricator.wikimedia.org/T169369#3822336 (10Nirzar) @Jdlrobson can we just show/hide the lock>checkmark based on the toggle and... [10:12:55] 10Research: Make HTML dumps available - https://phabricator.wikimedia.org/T182351#3822337 (10Cervisiarius) One reason why having the HTML dump (as opposed to plain wikitext) would be very useful is because HTML has all templates expanded, while wikitext doesn't, and I don't know of any easy and standard method o... [10:20:09] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10User-zeljkofilipin: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822359 (10zeljkofilipin) [10:24:36] 10TechCom-RfC: RfC: Introduce PlatformSettings.php - https://phabricator.wikimedia.org/T182020#3810242 (10daniel) @Legoktm This looks pretty straight forward to me. We discussed this at the TechCom meeting the other day, and were wondering whether we could even put this on last call without an IRC discussion. I... [10:28:31] (03CR) 10Zfilipin: "> Addshore" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/395514 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [10:39:18] 10Design, 10MinervaNeue, 10Mobile-Web-Settings, 10MobileFrontend, and 2 others: Display namespace in mobile view of the page history - https://phabricator.wikimedia.org/T147722#3822399 (10ovasileva) [10:41:13] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Design (RW-Design-Debt), 10Epic: [Epic] Improve special page template - https://phabricator.wikimedia.org/T169162#3822403 (10ovasileva) [10:41:16] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Design (RW-Design-Debt), 10Patch-For-Review, 10Readers-Web-Kanban-Board: Update the title alignment for special pages - https://phabricator.wikimedia.org/T180095#3822402 (10ovasileva) 05Open>03Resolved [10:41:46] 10TechCom-RfC: Lack of freeform external access to MediaWiki data is a limitation - https://phabricator.wikimedia.org/T181257#3822405 (10daniel) There are three big problems with allowing freeform queries: 1. sandboxing to prevent (intentional or unintentional) denial of service through resource hogging 2. schem... [10:43:06] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog: Equations displaying too large in new print styles - https://phabricator.wikimedia.org/T181138#3822407 (10ovasileva) thank you @Nirzar! [10:44:11] (03Draft3) 10Pwirth: Reworked BsExtensionManager into registry / factory services [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/396312 [10:46:44] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Replace {{NUMBEROFPAGES}} by {{NUMBEROFARTICLES}} in the search box text [skins/Timeless] - 10https://gerrit.wikimedia.org/r/395956 (https://phabricator.wikimedia.org/T176094) (owner: 10Eflyjason) [10:47:24] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822411 (10MER-C) [10:49:54] 10MediaWiki-Platform-Team, 10Operations, 10TechCom-RfC, 10HHVM, and 2 others: Migrate to PHP 7 in WMF production - https://phabricator.wikimedia.org/T176370#3623015 (10daniel) @tstarling According to TechCom notes, this was to enter Last Call on November 22, but that was never announced. What's the status? [10:51:18] 10Page-Previews, 10Readers-Web-Backlog: QA html previews on beta cluster - https://phabricator.wikimedia.org/T182399#3822423 (10ovasileva) p:05Triage>03Normal [10:51:33] 10Page-Previews, 10Readers-Web-Backlog: QA html previews on beta cluster - https://phabricator.wikimedia.org/T182399#3822423 (10ovasileva) @ABorbaWMF - here's a task to track the QA results. [10:53:52] (03CR) 10Hashar: [V: 032 C: 032] Update RuboCop Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/395025 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [10:58:40] 10Page-Previews, 10Readers-Web-Backlog: QA html previews on beta cluster - https://phabricator.wikimedia.org/T182399#3822453 (10phuedx) Is this a duplicate of {T171053} or the other way around? [10:58:53] (03CR) 10jenkins-bot: Update RuboCop Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/395025 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [10:59:23] 10MediaWiki-extensions-GlobalPreferences, 10TechCom-RfC, 10Community-Tech-Sprint, 10Patch-For-Review: RFC: How to modify all preferences? - https://phabricator.wikimedia.org/T178449#3822455 (10daniel) This RFC has been scheduled for public discussion on IRC on Wednesday, December 13. As always, the discuss... [10:59:27] 10MediaWiki-Debian: Upgrade RuboCop and Rubyzip in mediawiki/debian - https://phabricator.wikimedia.org/T182401#3822456 (10zeljkofilipin) [10:59:39] 10MediaWiki-Debian, 10User-zeljkofilipin: Upgrade RuboCop and Rubyzip in mediawiki/debian - https://phabricator.wikimedia.org/T182401#3822468 (10zeljkofilipin) [10:59:47] 10MediaWiki-Debian, 10User-zeljkofilipin: Upgrade RuboCop and Rubyzip in mediawiki/debian - https://phabricator.wikimedia.org/T182401#3822456 (10zeljkofilipin) p:05Triage>03Low [11:00:18] 10MediaWiki-extensions-GlobalPreferences, 10TechCom-RfC, 10Community-Tech-Sprint, 10Patch-For-Review: RFC: How to modify all preferences? - https://phabricator.wikimedia.org/T178449#3822471 (10Samwilson) Cool, thanks! [11:01:22] (03CR) 10Ljonka: [V: 032 C: 032] Initial commit [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/395935 (owner: 10Dvogel hallowelt) [11:01:58] 10MediaWiki-Debian, 10User-zeljkofilipin: Upgrade RuboCop and Rubyzip in mediawiki/debian - https://phabricator.wikimedia.org/T182401#3822476 (10zeljkofilipin) [11:03:38] 10Research: Make HTML dumps available - https://phabricator.wikimedia.org/T182351#3822488 (10flemmerich) Agreed, template extension was the main reason we used HTMLs from the API also in our research. In general, when investigating viewing behavior in Wikipedia, looking at the HTML is also just closest to what r... [11:04:53] (03CR) 10Pwirth: [C: 04-1] BlueSpicePagesVisited: Change config (031 comment) [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/394061 (owner: 10Pmiguelpirzer) [11:06:35] (03CR) 10Pwirth: [C: 032] BlueSpiceDashboards: Change config [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/394052 (owner: 10Pmiguelpirzer) [11:06:57] (03CR) 10Pwirth: [V: 032 C: 032] BlueSpicePageTemplates: Change config [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/393764 (owner: 10Pmiguelpirzer) [11:07:02] (03CR) 10Pwirth: [V: 032 C: 032] BlueSpiceBlog: Change config [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/393767 (owner: 10Pmiguelpirzer) [11:07:04] (03CR) 10Pwirth: [V: 032 C: 032] BlueSpiceContextMenu: Change config [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/393778 (owner: 10Pmiguelpirzer) [11:07:06] (03CR) 10Pwirth: [V: 032 C: 032] removed BSDebug::logVar() [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/395932 (owner: 10Dvogel hallowelt) [11:07:23] (03CR) 10Pwirth: [V: 032 C: 032] BlueSpiceDashboards: Change config [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/394052 (owner: 10Pmiguelpirzer) [11:08:16] (03CR) 10Zfilipin: "@Jforrester, @Addshore RuboCop should now run for this repo:" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/395514 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [11:08:18] (03CR) 10Zfilipin: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/395514 (https://phabricator.wikimedia.org/T180878) (owner: 10Zfilipin) [11:08:42] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3822503 (10ovasileva) As a general note, we would need: - current (and historical) number of users in the beta feat... [11:08:54] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog: Consolidate, simplify and cleanup data collection relating to Special:MobileOptions - https://phabricator.wikimedia.org/T182235#3822504 (10ovasileva) p:05Triage>03High [11:10:00] (03CR) 10Pwirth: [C: 04-1] BlueSpiceReaders: Change config (031 comment) [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/394036 (owner: 10Pmiguelpirzer) [11:10:37] 10MediaWiki-extensions-LoginNotify, 10Beta-Cluster-Infrastructure, 10Community-Tech, 10Wikimedia-Site-requests: Clarify LoginNotify emails are from beta - https://phabricator.wikimedia.org/T181908#3806293 (10EddieGP) >>! In T181908#3806943, @MarcoAurelio wrote: > Maybe those emails are using `{{SITENAME}}`... [11:13:27] (03CR) 10Pwirth: [V: 032 C: 032] BlueSpiceNamespaceManager: Change config [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/394030 (owner: 10Pmiguelpirzer) [11:13:36] 10Proton, 10Readers-Web-Backlog, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3822511 (10ovasileva) @Jdlrobson - I like your new description. I think we're looking for two things: - a list of browsers... [11:14:20] (03CR) 10Pwirth: [V: 032 C: 032] BlueSpicePermissionManager: Change config [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/393763 (owner: 10Pmiguelpirzer) [11:15:00] (03PS10) 10Petar.petkovic: Add overlay to list of changes [core] - 10https://gerrit.wikimedia.org/r/389753 (https://phabricator.wikimedia.org/T177626) [11:17:01] 10Proton, 10Readers-Web-Backlog, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3822514 (10ovasileva) [11:21:50] 10Page-Previews, 10Readers-Web-Backlog: QA html previews on beta cluster - https://phabricator.wikimedia.org/T182399#3822541 (10ovasileva) @phuedx - yup :) this one is more up to date, so I'll close the other one. [11:22:34] 10Page-Previews, 10Readers-Web-Backlog (Tracking): Complete entire page previews test plan for page summary api - https://phabricator.wikimedia.org/T171053#3822544 (10ovasileva) [11:22:36] 10Page-Previews, 10Readers-Web-Backlog: QA html previews on beta cluster - https://phabricator.wikimedia.org/T182399#3822547 (10ovasileva) [11:25:41] 10TechCom-RfC, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Wikimania-Hackathon-2015: Colorable SVG - https://phabricator.wikimedia.org/T106240#3822553 (10Nikerabbit) This kind of feature would be useful also in resource loader for some SVG images shipped in MediaWiki and extensions. It would need some... [11:26:55] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, and 2 others: Change text box into editor when the edit symbol was clicked - https://phabricator.wikimedia.org/T180974#3775029 (10WMDE-Fisch) a:03WMDE-Fisch [11:33:03] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822563 (10BethNaught) Similar behaviour confirmed on my various mobile devices. Inspecting the source, the
tag ( of class "oo-ui-widget oo-ui-widget-enab... [11:33:13] (03CR) 10Sbisson: [C: 032] Add overlay to list of changes [core] - 10https://gerrit.wikimedia.org/r/389753 (https://phabricator.wikimedia.org/T177626) (owner: 10Petar.petkovic) [11:33:15] (03CR) 10TTO: "The lack of 100% width on the textarea is being complained about at T182398." [core] - 10https://gerrit.wikimedia.org/r/395037 (https://phabricator.wikimedia.org/T180207) (owner: 10Albert221) [11:34:39] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822411 (10TTO) This is from {rMWfa718359e}. The textarea needs to be given width 100% somehow. [11:35:07] (03CR) 10Addshore: "Please see https://phabricator.wikimedia.org/T182322" [core] - 10https://gerrit.wikimedia.org/r/393983 (owner: 10Aaron Schulz) [11:35:54] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822581 (10TTO) >>! In T182398#3822563, @BethNaught wrote: > "width: 100%; max-width: 50em;" This is sensible behaviour for textareas that are part of forms an... [11:36:35] (03PS1) 10Fomafix: Add ul { margin-top: 0; margin-bottom: 0 } for multi-column [core] - 10https://gerrit.wikimedia.org/r/396323 [11:41:45] (03Merged) 10jenkins-bot: Add overlay to list of changes [core] - 10https://gerrit.wikimedia.org/r/389753 (https://phabricator.wikimedia.org/T177626) (owner: 10Petar.petkovic) [11:51:36] 10Wikimedia-Site-requests: Set Wikipedia v2 logo for zea.wikipedia - https://phabricator.wikimedia.org/T180338#3822588 (10EddieGP) 05Open>03Invalid https://zea.wikipedia.org/wiki/MediaWiki:Common.css has the following lines: ```lang=css /* Logo mee Zeêuwse tekst */ #p-logo a { background: url(//upload.wikim... [11:52:56] (03CR) 10jenkins-bot: Add overlay to list of changes [core] - 10https://gerrit.wikimedia.org/r/389753 (https://phabricator.wikimedia.org/T177626) (owner: 10Petar.petkovic) [11:53:11] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, 10Performance-Team-notice: API is (intermittently) very slow - https://phabricator.wikimedia.org/T182322#3822593 (10daniel) [11:54:29] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Check if $responseData['responses'] is set before use (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395883 (https://phabricator.wikimedia.org/T161283) (owner: 10Umherirrender) [11:56:19] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, 10Performance-Team-notice: API is (intermittently) very slow - https://phabricator.wikimedia.org/T182322#3822596 (10Addshore) So, I'm pretty sure reverting https://gerrit.wikimedia.org/r/#/c/393983/ would solve our problems here. This is to... [11:58:49] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, 10Performance-Team-notice: API is (intermittently) very slow - https://phabricator.wikimedia.org/T182322#3822600 (10daniel) Pinging @Krinkle for he merged the patch in question [11:58:52] 10Page-Previews, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Show HTML summaries on cswiki - https://phabricator.wikimedia.org/T182321#3822601 (10phuedx) Thanks, @EddieGP! [12:04:25] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, 10Performance-Team-notice: API is (intermittently) very slow - https://phabricator.wikimedia.org/T182322#3822604 (10Addshore) Thinking about this more this really really doesn't make sense for us (wikibase ui). # We edit and touch the db... [12:08:42] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, 10Performance-Team-notice: API is (intermittently) very slow - blocked waiting for cpPosTime cookie - https://phabricator.wikimedia.org/T182322#3822606 (10Addshore) [12:09:12] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, and 2 others: API is (intermittently) very slow - blocked waiting for cpPosTime cookie - https://phabricator.wikimedia.org/T182322#3819967 (10Addshore) [12:10:21] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822411 (10Bawolff) > Did anyone bother to test this? This is borderline unusable. Screen size is 1920x1080. For reference, I did test this and notice the narr... [12:12:22] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822411 (10Albert221) I'll work on that today in the evening [12:12:28] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822619 (10Albert221) a:03Albert221 [12:13:00] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, and 2 others: API is (intermittently) very slow - blocked waiting for cpPosTime cookie - https://phabricator.wikimedia.org/T182322#3822620 (10Addshore) If we want to revert it looks like we would have to revert both related changes: - https:/... [12:13:55] bawolff: Hi! Do you have a free minute? I have some questions about the task you are mentoring [12:14:03] Yep [12:14:36] Well, actually I am almost done. Just want to ask some final questions before submitting the patch. [12:15:44] ok, ask away :) [12:17:01] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10Patch-For-Review, 10Wikidata-Former-Sprint-Board: [Tracking] Track descriptions usages separately (Create a new description usage aspect "... - https://phabricator.wikimedia.org/T106287#3822622 [12:17:14] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Epic, 10Notice, and 2 others: [Epic] Track Wikidata entity usage on client pages - https://phabricator.wikimedia.org/T49288#3822627 (10Ladsgroup) [12:17:17] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), 10Wikidata-Former-Sprint-Board: [Tracking] Track descriptions usages separately (Create a new description usage aspect "D") - https://phabricator.wikimedia.org/T106287#1463783 (10Ladsgroup) 0... [12:17:19] The task was to change comment based markers (T180159). I acomplished that by changing couple of lines with marker strings to proposed variant. I also did the same with regular expressions used to replace those markers with actual links. Is this a right solution? Seems to be strangely easy for an "advanced" task [12:17:19] T180159: As a hardening measure, MW's various comment based strip markers (e.g. ) should include quotes to avoid being included in attributes - https://phabricator.wikimedia.org/T180159 [12:17:21] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Israel-Hackers: Improve usage tracking granularity to avoid irrelevant changes showing in the watchlist. - https://phabricator.wikimedia.org/T90436#3822626 (10Ladsgroup) [12:17:48] Anyway, I tested it - seems to work right [12:18:30] yep [12:18:46] Its marked as advanced because everyone around here is utterly terrified of the parser [12:19:28] It is a little harder than some of the other tasks that specificly tell you which lines you have to change [12:19:41] But yeah, its still not exactly "hard" [12:19:52] Oh. That's nice. Then I will submit a patch soon. Final question. I found code which replaces `` with table of contents, but I can't find any code which actually places this marker. Is it placed by user or on frontend side? [12:21:05] Its placed in 3947 of includes/Parser.php [12:21:16] the $text = $mw->replace( '', $text, 1 ); [12:21:38] replaces __TOC__ which is specified by the user with [12:22:19] oh, there is one complication [12:24:09] Anything in ParserOutput::getText() must support the old form too, for back compatability with cached pages [12:24:48] (03PS2) 10BearND: Bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) [12:25:59] Although the Parser::getOutput() one's were the html style tags, and those weren't really part of the task, so you probably don't have to worry about that [12:26:05] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10User-zeljkofilipin: mwext-qunit-jessie Jenkins job fails for MultimediaViewer - https://phabricator.wikimedia.org/T182395#3822631 (10matthiasmullie) It appears that OOJS-UI (now) has a hard requirement for a $floatableContainer in oo.ui.MenuOptionWidge... [12:26:20] (03CR) 10jerkins-bot: [V: 04-1] Bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [12:26:47] Thank you! I checked line 3947 and now I know where that marker is placed. It makes me sad that I am that inattentive :( As for complication - okay, I will check that compatability thing too. [12:27:39] I don't have any other questions now. Thank you for your help! [12:27:57] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/396326 [12:31:30] (03CR) 10Fomafix: [C: 04-1] "The category headings (

) still have a different top margin on the consecutive columns." [core] - 10https://gerrit.wikimedia.org/r/396323 (owner: 10Fomafix) [12:31:52] 10UI-Standardization, 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3822644 (10Esanders) [12:32:00] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/396327 [12:32:02] There will probably be harder tasks later on in gci. https://phabricator.wikimedia.org/T182212 will be a little more involved. [12:32:26] And your welcome to suggest bugs for gci if there is anything you want to work on [12:32:32] or even suggest areas or types of things [12:33:10] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/396328 [12:33:17] (03CR) 10jerkins-bot: [V: 04-1] PageContentSave WikiPage typehint [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/396328 (owner: 10Addshore) [12:33:21] I'm still kind of trying to figure out what level is considered hard vs easy for gci. This is the first year I've been involved as a mentor [12:33:42] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Show summarizing sentence after entering the donation form from a deep-link - https://phabricator.wikimedia.org/T180690#3822647 (10Jan_Dittrich) [12:34:48] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/396329 [12:35:50] Thanks! It is really interesting to work on harder tasks, so I will check if some appear. As for suggesting tasks - will try to do this if I will have some ideas [12:40:58] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822411 (10TheDJ) @Albert221 just as a note; this is NOT your fault. Regressions are always possible and we should have caught this in review. As a GCI student... [12:42:42] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3822667 (10Bawolff) >>! In T182398#3822665, @TheDJ wrote: > @Albert221 just as a note; this is NOT your fault. Regressions are always possible and we should hav... [12:43:07] thedj: Thanks for writing that. I should have said something to that affect immediately [12:47:30] bawolff: i only realized when he assigned it to himself that this needed to be said... [13:00:35] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Provide input related error messages to help peple to fix problems - https://phabricator.wikimedia.org/T182411#3822707 (10Jan_Dittrich) [13:01:10] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Provide input related error messages to help peple to fix problems - https://phabricator.wikimedia.org/T182411#3822718 (10Jan_Dittrich) [13:02:22] (03Draft2) 10Pwirth: BSFoundation: Added applied status to filter [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/396330 [13:07:54] (03PS1) 10Kghbln: Fix margin of #jump-to-nav [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396331 (https://phabricator.wikimedia.org/T176444) [13:10:11] (03CR) 10Kghbln: "This is also an issue with REL1_30 already. So I cherry picked into REL1_30 with https://gerrit.wikimedia.org/r/#/c/396331/" [core] - 10https://gerrit.wikimedia.org/r/384129 (https://phabricator.wikimedia.org/T176444) (owner: 10TheDJ) [13:10:56] (03CR) 10jerkins-bot: [V: 04-1] Fix margin of #jump-to-nav [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396331 (https://phabricator.wikimedia.org/T176444) (owner: 10Kghbln) [13:12:24] (03CR) 10Prtksxna: Add tabindex to Special:Upload in mw-editTools (031 comment) [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [13:15:45] (03PS4) 10Pmiguelpirzer: BlueSpiceSmartList [extensions/BlueSpiceSmartlist] - 10https://gerrit.wikimedia.org/r/394979 [13:16:29] 10MediaWiki-extensions-WikibaseClient, 10DBA, 10Wikidata, 10User-Daniel, 10Wikidata-Former-Sprint-Board: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#3822738 (10Ladsgroup) [13:18:46] prtksxna, good point! [13:19:00] Gonna fix that now ;) [13:19:27] (03CR) 10Umherirrender: "It seems more complex as I was thinking about. Needs deeper look what key is missing and where the array string conversion occurs." [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [13:23:34] (03PS7) 10Fomafix: Parser: Ignore whitespaces between wiki table syntax and table content [core] - 10https://gerrit.wikimedia.org/r/395477 (https://phabricator.wikimedia.org/T182074) (owner: 10Eflyjason) [13:24:13] (03PS7) 10Divadsn: Add tabindex to Special:Upload in mw-editTools [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) [13:24:39] 10Mobile-Web-Settings, 10Readers-Web-Backlog: Deploy `specialpages` feature branch (promote new Special:MobileOptions, fontchanger etc) - https://phabricator.wikimedia.org/T182217#3822748 (10ovasileva) [13:25:40] (03Abandoned) 10Addshore: PageContentSave WikiPage typehint [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/396328 (owner: 10Addshore) [13:26:25] prtksxna, fixed :) [13:26:32] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Change font size controls to use small, regular, large and extra large buckets - https://phabricator.wikimedia.org/T169369#3822762 (10ovasileva) [13:26:41] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/396332 [13:26:42] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3822764 (10zeljkofilipin) [13:26:53] 10OOjs-UI, 10UI-Standardization, 10Mobile-Web-Settings, 10Readers-Web-Backlog (Tracking): Dropdown widgets unusable on mobile - should use native SELECT element for better mobile compatibility - https://phabricator.wikimedia.org/T180730#3822765 (10ovasileva) [13:27:19] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/396333 [13:27:57] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/396334 [13:29:08] (03CR) 10jerkins-bot: [V: 04-1] Parser: Ignore whitespaces between wiki table syntax and table content [core] - 10https://gerrit.wikimedia.org/r/395477 (https://phabricator.wikimedia.org/T182074) (owner: 10Eflyjason) [13:30:32] (03PS2) 10Sbisson: RCLFilters: display target page as a title [core] - 10https://gerrit.wikimedia.org/r/395866 (https://phabricator.wikimedia.org/T182164) [13:31:34] (03CR) 10jerkins-bot: [V: 04-1] Add tabindex to Special:Upload in mw-editTools [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [13:32:55] (03CR) 10Sbisson: RCLFilters: display target page as a title (032 comments) [core] - 10https://gerrit.wikimedia.org/r/395866 (https://phabricator.wikimedia.org/T182164) (owner: 10Sbisson) [13:33:11] (03CR) 10Divadsn: "recheck" [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [13:37:00] 10Page-Previews, 10Readers-Web-Backlog: [Spike] Determine ways of counting page previews with highest sampling possible - https://phabricator.wikimedia.org/T182414#3822784 (10ovasileva) p:05Triage>03Normal [13:37:12] 10Page-Previews, 10Readers-Web-Backlog: [Spike] Determine ways of counting page previews with highest sampling possible - https://phabricator.wikimedia.org/T182414#3822797 (10ovasileva) p:05Normal>03High [13:40:54] andre__, is the limitation of max 1 task still a thing this year? :/ [13:41:20] divadsn: yes [13:41:35] Thats a google thing [13:41:44] Zppix, that's sad :( [13:41:50] (03PS3) 10Ladsgroup: Join decomposition of ores_model table queries [extensions/ORES] - 10https://gerrit.wikimedia.org/r/395811 (https://phabricator.wikimedia.org/T181334) [13:41:54] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Epic: [Epic] Show what features are included in Beta - https://phabricator.wikimedia.org/T67079#3822814 (10ovasileva) [13:41:55] It makes sense though divadsn [13:41:56] 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10Patch-For-Review: Promote expand all sections feature from beta - https://phabricator.wikimedia.org/T169257#3822813 (10ovasileva) [13:42:01] 10Developer-Relations (Oct-Dec 2017): Release "New Developers Quarterly Report" for October-December 2017 by January 1st 2018 - https://phabricator.wikimedia.org/T178627#3822817 (10Aklapper) [13:42:08] (03CR) 10Ladsgroup: "I thought about it but was too lazy, thanks for pointing out." (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/395811 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [13:42:12] divadsn: we dont want you claiming more than you could handle :) [13:42:22] But I'm underpowered :( [13:43:08] I made a task yesterday and now it's back in review because of one small suggestion from the review [13:43:30] divadsn: We do want to make sure that people finish what they start, and don't half start like 20 tasks but finish none of them [13:43:33] And I get it that mentors are quite busy [13:43:43] divadsn: Which of your task is currently wating review [13:43:44] ? [13:43:49] https://phabricator.wikimedia.org/T25238 [13:44:07] divadsn: yeah sadly even i end up having to wait for reviews for my tasks i do for wikimedia :) its just life really [13:44:54] oh js. Sorry, I'm more a php person [13:45:09] Zppix, well my life is usually not so much fun, I don't have any friends here where I live [13:45:29] divadsn: :/ [13:45:42] bawolff, oh, anyway thanks for the good intentions :) [13:46:11] 10MediaWiki-Core-Tests, 10MediaWiki-Database: Update list of needed database tables in parser tests for new comment table - https://phabricator.wikimedia.org/T182416#3822819 (10Umherirrender) [13:46:24] divadsn: you could look and see what you want to work on next just to have an idea on whats out there to do [13:46:25] I'm gonna sleep in the meantime, so I can work later maybe, that's a good idea ^^ [13:46:37] divadsn: you could read up on programming [13:46:44] divadsn: you could chat here :) [13:46:58] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/CategoryWatch] - 10https://gerrit.wikimedia.org/r/396336 [13:47:00] (03PS4) 10Umherirrender: Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 [13:47:05] Zppix: I was doing that last year, but ended up more frustrating to see those tasks be claimed when I wanted to start them ^^ [13:47:26] divadsn: yeah :/ [13:47:33] Zppix, that's also a good idea, but currently it's nothing happening here :/ [13:48:02] I could also maybe finish my Raspberry Pi Moonlight project ;) [13:48:06] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/396337 [13:48:19] Anyway, I will just wait patiently ^^ [13:48:40] Hmm, I can probably review that patch if i test it carefully [13:48:44] (03PS5) 10Pmiguelpirzer: BlueSpiceReaders: Change config [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/394036 [13:48:47] (03CR) 10Fomafix: "There are more top margin problems in multi-column areas. I created https://gerrit.wikimedia.org/r/396323." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394863 (https://phabricator.wikimedia.org/T181947) (owner: 10Fomafix) [13:48:48] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/396338 [13:49:25] bawolff: whats the patch for? [13:49:52] (03CR) 10Umherirrender: "Patch Set 4: Fixed array to string conversion, the reason was a variable name collision in the preprocessor ($flags is an argument to the " [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [13:49:58] Its adjusting how entering text in the "enter random non english characters" box on the upload form, works [13:50:00] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/396339 [13:50:52] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/EditcountAdditions] - 10https://gerrit.wikimedia.org/r/396340 [13:50:56] If you tab through it, it shouldn't take ages to get to the next thing on the page [13:51:29] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/396341 [13:51:49] (03PS4) 10Pmiguelpirzer: BlueSpicePagesVisited: Change config [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/394061 [13:51:50] 10MediaWiki-extensions-Babel, 10UI-Standardization, 10CSS, 10Patch-For-Review: Change class names to MediaWiki name conventions - https://phabricator.wikimedia.org/T182061#3811588 (10Nikerabbit) I'd rather avoid changing class names for one extensions unless there is a wide consensus for a convention. As o... [13:52:12] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/396342 [13:52:15] huh, edit tools does not show up in uselang=qqx [13:52:35] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396343 [13:52:53] Hello, small problem, the template function https://commons.wikimedia.org/wiki/Template:Str_endswith seems not working anymore, it e has 32337 inclusions. Maybe we should write it in Lua [13:52:55] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/396344 [13:53:10] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396345 [13:53:29] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog (Kanban): MCS summary endpoint unexpectedly returns 204 for :en:Wikimedia Foundation - https://phabricator.wikimedia.org/T182349#3822844 (10Mholloway) [13:53:33] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/396346 [13:53:39] (03CR) 10jerkins-bot: [V: 04-1] PageContentSave WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396343 (owner: 10Addshore) [13:53:55] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog (Kanban): MCS summary endpoint unexpectedly returns 204 for :en:Wikimedia Foundation - https://phabricator.wikimedia.org/T182349#3821120 (10Mholloway) [13:54:19] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/396348 [13:54:30] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, and 2 others: API is (intermittently) very slow - blocked waiting for cpPosTime cookie - https://phabricator.wikimedia.org/T182322#3822846 (10daniel) pinging @anomie for user related stuff [13:54:46] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog (Kanban): Section parsing bug on :en:Wikimedia Foundation - https://phabricator.wikimedia.org/T182349#3821120 (10Mholloway) [13:55:55] (03PS1) 10Umherirrender: Use utf-8 as name in iconv [core] - 10https://gerrit.wikimedia.org/r/396350 [13:57:15] Wow, how do the edittools even work on upload pages? [13:58:22] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/396351 [13:58:39] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/396352 [13:58:59] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/396353 [13:59:08] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/MOOC] - 10https://gerrit.wikimedia.org/r/396354 [13:59:37] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396355 [14:00:03] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/reCaptcha] - 10https://gerrit.wikimedia.org/r/396356 [14:00:44] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/396359 [14:00:55] (03CR) 10jerkins-bot: [V: 04-1] PageContentSave WikiPage typehint [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/396353 (owner: 10Addshore) [14:01:06] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/TopLists] - 10https://gerrit.wikimedia.org/r/396360 [14:01:48] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/396362 [14:01:54] 10Marvin: Scroll state should be reset when visiting a new page and restored when revisiting a prior page - https://phabricator.wikimedia.org/T182420#3822878 (10Niedzielski) [14:02:48] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), and 2 others: Add proper category collation for the Northern Sami Wikipedia - https://phabricator.wikimedia.org/T181503#3822888 (10jhsoby-WMNO) Thanks for the help... [14:03:40] (03CR) 10jerkins-bot: [V: 04-1] PageContentSave WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396355 (owner: 10Addshore) [14:05:01] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Athena] - 10https://gerrit.wikimedia.org/r/396363 [14:05:23] (03PS1) 10Niedzielski: Update: reset scroll position when visiting a new page [marvin] - 10https://gerrit.wikimedia.org/r/396364 (https://phabricator.wikimedia.org/T182420) [14:05:30] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/396365 [14:05:38] 10Marvin, 10Patch-For-Review: Scroll state should be reset when visiting a new page and restored when revisiting a prior page - https://phabricator.wikimedia.org/T182420#3822912 (10Niedzielski) a:03Niedzielski [14:06:37] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/396366 [14:07:04] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/396367 [14:07:33] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/396368 [14:07:57] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3822928 (10zeljkofilipin) [14:08:32] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396369 [14:08:58] ugh, for some reason my local wiki seems to have broken i18n mediawiki namespace... [14:09:24] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/396370 [14:11:15] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/396371 [14:11:35] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3822937 (10zeljkofilipin) [14:12:56] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/396373 [14:13:53] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Add proper category collation for the Northern Sami Wikipedia - https://phabricator.wikimedia.org/T181503#3822952 (10jhsoby-WMNO) [14:13:57] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/396374 [14:15:01] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3822953 (10zeljkofilipin) [14:15:07] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/396375 [14:15:38] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/396376 [14:16:18] 10MediaWiki-General-or-Unknown, 10Epic, 10MW-1.29-release-notes, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3751147 (10zeljkofilipin) [14:16:55] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/396378 [14:17:15] (03PS1) 10Addshore: PageContentSave WikiPage typehint [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/396379 [14:17:35] 10MediaWiki-extensions-GlobalPreferences, 10TechCom-RfC, 10Community-Tech-Sprint, 10Patch-For-Review: RFC: How to modify all preferences? - https://phabricator.wikimedia.org/T178449#3822960 (10Niharika) Thanks Daniel! [14:18:45] spam spam spam [14:20:05] (03PS20) 10Daniel Kinzler: [MCR] Introduce PageIdentity, and use it instead of Title. [core] - 10https://gerrit.wikimedia.org/r/392310 [14:20:25] addshore: beautiful spam, wonderful spam... [14:20:30] hehe [14:20:37] DanielK_WMDE: I hope that was one of the larger hooks ;) [14:20:52] (03PS12) 10Daniel Kinzler: [WIP][MCR] Split WikiPage class [core] - 10https://gerrit.wikimedia.org/r/392089 [14:21:53] addshore: i'll probably +2 them all tonight [14:22:03] whee :) [14:22:12] DanielK_WMDE: I'm only 1/3rd of the way through the hooks list for WikiPage ;) [14:22:14] 10MediaWiki-Core-Tests, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External), 10User-zeljkofilipin: WebdriverIO should run Chrome headlessly - https://phabricator.wikimedia.org/T167507#3822993 (10zeljkofilipin) [14:22:18] going hook by hook [14:22:30] 10OOjs-UI: OOUI readyOnly textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3822995 (10Bawolff) [14:22:33] addshore: maybe better go extension by extension? [14:22:38] less spam [14:22:49] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3823007 (10Bawolff) [14:23:00] I think that would take much longer :/ [14:23:06] oh god, using gerrit with train wifi is horrible. i'm amazed irc didn't time out yet [14:23:17] well, then don't [14:23:39] (03PS2) 10Addshore: PageContentSave WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396343 [14:24:07] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Introduce PageIdentity, and use it instead of Title. [core] - 10https://gerrit.wikimedia.org/r/392310 (owner: 10Daniel Kinzler) [14:25:11] (03CR) 10Harjotsingh: [C: 031] "Seems good :)" [core] - 10https://gerrit.wikimedia.org/r/395809 (owner: 10Freddy2001) [14:25:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP][MCR] Split WikiPage class [core] - 10https://gerrit.wikimedia.org/r/392089 (owner: 10Daniel Kinzler) [14:25:49] Gerrit is particularly bad on poor wifi. Everything goes to hell after a single timeout [14:27:47] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3823022 (10pmiazga) ##Testing round one. Type: synthetic test, set of 50 urls, no pauses. I focused mostly on concurrency/response rates,... [14:33:24] (03CR) 10Kghbln: [C: 031] "Those failures are obviously unrelated to the patch set." [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396331 (https://phabricator.wikimedia.org/T176444) (owner: 10Kghbln) [14:34:07] (03PS2) 10Addshore: PageContentSave WikiPage typehint [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/396353 [14:34:53] (03PS2) 10Addshore: PageContentSave WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396355 [14:35:58] 10OOjs-UI: OOUI drop downs do not change selection on an arrow keypress unlike native browser widget - https://phabricator.wikimedia.org/T182429#3823038 (10Bawolff) [14:36:06] 10MediaWiki-Vendor, 10NewPHP, 10Upstream: PHP-function each() has been deprecated - https://phabricator.wikimedia.org/T182177#3823048 (10Efellows) I can confirm that https://pear.php.net/bugs/ is the correct place for PEAR-bug-reports. For reporting bugs there you need either a confirmed account or need to c... [14:36:14] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3822050 (10Umherirrender) The reason sounds not correct, because the linked page says it is a mirror of gerrit. It is bad to say you have t... [14:37:38] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3823051 (10Reedy) [14:38:09] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3822050 (10Reedy) Late night copy paste fail. It's essentially a fork of https://github.com/omissis/php-cloudfiles that WMF doesn't use any... [14:38:42] (03CR) 10Mholloway: [C: 04-1] "This is looking good. Just some questions/comments and one or two small issues." (036 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/370296 (https://phabricator.wikimedia.org/T170690) (owner: 10BearND) [14:41:55] (03CR) 10Ema: "Nice! A few inline comments." (039 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/395076 (https://phabricator.wikimedia.org/T181315) (owner: 10Gilles) [14:42:31] (03PS1) 10Addshore: WikiPageDeletionUpdates WikiPage typehint [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/396383 [14:43:24] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#3823065 (10jhsoby-WMNO) [14:44:06] (03CR) 10jerkins-bot: [V: 04-1] WikiPageDeletionUpdates WikiPage typehint [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/396383 (owner: 10Addshore) [14:44:12] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#3823080 (10jhsoby-WMNO) [14:45:19] (03PS1) 10Addshore: ArticleEditUpdatesDeleteFromRecentchanges WikiPage typehint [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/396384 [14:46:59] (03CR) 10Mholloway: "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [14:47:30] (03PS1) 10Addshore: ArticleEditUpdateNewTalk WikiPage typehint [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/396385 [14:51:33] (03CR) 10Addshore: [V: 031] "Test failures are unrelated" [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/396383 (owner: 10Addshore) [14:57:03] (03PS1) 10Addshore: ArticleRollbackComplete WikiPage typehint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/396388 [14:57:29] andre__: Will like to help mentor a few task but can't add myself on GCI website [14:57:33] Can you help me do that? [14:57:39] (03PS1) 10Addshore: ArticleRollbackComplete WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396390 [14:58:27] andre__: https://codein.withgoogle.com/dashboard/tasks/6560560546054144/ [14:59:09] 10MediaWiki-extensions-Translate, 10translatewiki.net: Implement a stronger synchronization in RepoNG and Translate - https://phabricator.wikimedia.org/T182433#3823096 (10Nikerabbit) [14:59:33] (03PS1) 10Addshore: ArticleProtect WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396391 [15:00:03] andre__: https://codein.withgoogle.com/dashboard/tasks/4566242679586816/ [15:00:04] 10MediaWiki-extensions-Translate, 10translatewiki.net: Implement a stronger synchronization in RepoNG and Translate - https://phabricator.wikimedia.org/T182433#3823114 (10Nikerabbit) [15:00:44] (03PS1) 10Phantom42: Add quotes to comment based strip markers [core] - 10https://gerrit.wikimedia.org/r/396392 (https://phabricator.wikimedia.org/T180159) [15:01:15] bawolff: I checked everything again and pushed my change to Gerrit. Sorry for some delays [15:01:23] No worries [15:01:27] I'll have a look [15:03:27] andre__: I saw a button to do that, handled already :) [15:03:45] 10MediaWiki-General-or-Unknown, 10Tracking: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - https://phabricator.wikimedia.org/T41480#3823133 (10Nikerabbit) [15:03:49] 10MediaWiki-General-or-Unknown, 10translatewiki.net, 10I18n, 10Performance, 10Regression: At least one user is permanently unable to use Special:RecentChanges on translatewiki.net - https://phabricator.wikimedia.org/T74228#3823130 (10Nikerabbit) 05Open>03Resolved a:03Nikerabbit Closing per feedback. [15:04:20] (03PS1) 10Addshore: ArticleEditUpdates WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396395 [15:05:05] (03PS1) 10Addshore: ArticleEditUpdates WikiPage typehint [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/396396 [15:05:43] (03PS1) 10Addshore: ArticleEditUpdates WikiPage typehint [extensions/RestBaseUpdateJobs] - 10https://gerrit.wikimedia.org/r/396397 [15:06:05] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#3823147 (10jhsoby-WMNO) [15:06:06] Phantom42: just give me a few minutes to finish what I'm currently doing [15:06:47] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#3823065 (10jhsoby-WMNO) [15:07:03] (03PS1) 10Addshore: ArticleEditUpdates WikiPage typehint [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/396399 [15:07:04] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#3823065 (10jhsoby-WMNO) [15:08:18] (03PS2) 10Addshore: WikiPage hook typehints [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/396399 [15:08:40] (03CR) 10Mholloway: [C: 032] Bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [15:09:04] I wanted to try and finish reviewing Davidsn's patch, but my local mw has some weird bugs [15:09:37] bawolff: Okay. Unluckily, I will be away for some time now. But if there will be any issues, I will fix them as soon as I come back. [15:09:56] Ok [15:10:06] (03CR) 10BearND: [C: 04-2] "Just a minor typo" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [15:12:22] (03PS1) 10Addshore: NewRevisionFromEditComplete WikiPage typehint [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/396400 [15:13:23] (03PS1) 10Addshore: NewRevisionFromEditComplete WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396402 [15:13:44] (03PS1) 10Addshore: NewRevisionFromEditComplete WikiPage typehint [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/396403 [15:14:09] (03PS1) 10Addshore: NewRevisionFromEditComplete WikiPage typehint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/396404 [15:15:17] (03PS1) 10Addshore: NewRevisionFromEditComplete WikiPage typehint [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396405 [15:16:13] (03PS1) 10Addshore: NewRevisionFromEditComplete WikiPage typehint [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/396406 [15:16:31] (03PS1) 10Jdrewniak: Updating Portal documentation [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/396407 (https://phabricator.wikimedia.org/T182119) [15:16:40] (03CR) 10Yaron Koren: [C: 032] PageContentSave WikiPage typehint [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/396334 (owner: 10Addshore) [15:17:15] (03CR) 10jerkins-bot: [V: 04-1] NewRevisionFromEditComplete WikiPage typehint [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/396403 (owner: 10Addshore) [15:17:18] (03CR) 10jerkins-bot: [V: 04-1] NewRevisionFromEditComplete WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396402 (owner: 10Addshore) [15:17:51] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), 10UI-Standardization-Kanban: DateInputWidget is missing vertical alignment in monobook - https://phabricator.wikimedia.org/T182437#3823179 (10Xaosflux) p:05Triage>03Lowest [15:17:53] (03CR) 10Yaron Koren: [C: 032] WikiPage hook typehints [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/396399 (owner: 10Addshore) [15:19:48] (03Merged) 10jenkins-bot: PageContentSave WikiPage typehint [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/396334 (owner: 10Addshore) [15:21:36] (03Merged) 10jenkins-bot: WikiPage hook typehints [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/396399 (owner: 10Addshore) [15:22:29] (03CR) 10D3r1ck01: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396077 (https://phabricator.wikimedia.org/T181829) (owner: 10Rafidaslam) [15:23:00] (03PS1) 10Mholloway: Hygiene: Fix README section on sepia HTTP recording [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396409 [15:23:09] 10UI-Standardization: DateInputWidget uses multiple inconsistent date format hints - https://phabricator.wikimedia.org/T182438#3823199 (10Xaosflux) [15:24:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Need-volunteer, 10TestMe: Tooltips and menus not always visible - https://phabricator.wikimedia.org/T42836#3823212 (10matej_suchanek) [15:24:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] suggestions cut off if I am adding a statement at the bottom of the page - https://phabricator.wikimedia.org/T90897#3823215 (10matej_suchanek) [15:27:00] (03CR) 10Brian Wolff: [C: 04-1] "So this doesn't really work for me (Testing on firefox on mac)." [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [15:27:06] bawolff: This LGTM, what do you think: https://gerrit.wikimedia.org/r/#/c/396077 [15:28:27] (03CR) 10D3r1ck01: [C: 031] "LGTM" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396077 (https://phabricator.wikimedia.org/T181829) (owner: 10Rafidaslam) [15:29:17] (03CR) 10Kghbln: "Probably this should not be fixed but this should be reverted in MW 1.30 too: https://gerrit.wikimedia.org/r/#/c/376879/ ??? I am a bit co" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396331 (https://phabricator.wikimedia.org/T176444) (owner: 10Kghbln) [15:30:19] d3r1ck: At first glance it looks good. Let me just have a glance at the function docs as i'm not familar with that func [15:30:47] bawolff: Yeah, I looked at it too. But sure, take your time :) [15:30:55] 10LookupUser: Search user by email - https://phabricator.wikimedia.org/T182439#3823218 (10Tuxxic) [15:31:20] (03PS2) 10Mholloway: Hygiene: Fix README section on sepia HTTP recording [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396409 [15:31:43] (03PS7) 10DCausse: Port update_general_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/393694 (owner: 10EBernhardson) [15:31:59] (03CR) 10Zfilipin: "Tested here: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue-396287/" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/396287 (https://phabricator.wikimedia.org/T182202) (owner: 10Jdlrobson) [15:34:23] d3r1ck: I'm confused by the '#' as the fourth arg. That's supposed to be like a username. Although it seems like it was also wrong before [15:35:22] Which is appearently the default for the parameter too [15:36:31] I know the empty string makes it be current user in some contexts, no idea about '#' [15:36:50] bawolff: I'm also a bit confused with '#' username tbh (I'm the author of that CR) [15:36:54] bawolff: YHAP [15:36:59] although we have a user object here, as long as its not cached, we should be doing $this->getContext()->getUser() [15:37:13] err, $this->getContext()->getUser()->getName() [15:37:54] YHAP = you have a point [15:38:05] err, actually that's probably the wrong user object [15:38:06] (03CR) 10jerkins-bot: [V: 04-1] Port update_general_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/393694 (owner: 10EBernhardson) [15:38:10] (03CR) 10Zfilipin: "Apologies on being slow to review this, I was busy with other things. I'm looking at the code." [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/394539 (https://phabricator.wikimedia.org/T180777) (owner: 10Jdrewniak) [15:38:10] bawolff: And username is null by default [15:38:23] as that would be the person viewing the page, and we want the person who the page is about [15:38:32] 10MediaWiki-extensions-PageSchemas: HTTP ERROR 500 when trying to create schema - https://phabricator.wikimedia.org/T182441#3823247 (10Patrezp) [15:39:33] I guess $id is the global id, we could get the username from that [15:39:50] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, and 2 others: API is (intermittently) very slow - blocked waiting for cpPosTime cookie - https://phabricator.wikimedia.org/T182322#3823259 (10Anomie) There doesn't seem to be any real "user related stuff" here, or anything actually related to... [15:39:52] bawolff: yes, was looking at the $id variable too [15:40:08] Let me leave a comment on the patch. [15:40:10] but then the whole performance thing of doing a batch lookup goes out the winddow [15:40:24] refeed[m]: You authored the patch? [15:40:31] There should definitely be a username already loaded somewhere in this class [15:40:41] d3r1ck: yes I am [15:41:39] bawolff: I only see getUserId() [15:42:00] It does load gu_name, which is what we want [15:42:08] but it doesn't yet save it anywhere useful [15:42:29] Yes I see getGroupMemberName() [15:42:47] And then there is the question of if there even is a local account to do gender preferences for [15:42:54] hello! [15:42:57] I don't think that's something we have to care [15:43:00] Hi Albert221 [15:43:19] 10Page Content Service, 10Reading Epics (Platform JS CSS and HTML consolidation), 10Reading-Infrastructure-Team-Backlog (Kanban): Media: handle items that link to documents other than a File page - https://phabricator.wikimedia.org/T182329#3823264 (10Mholloway) Examining the href makes sense. The only cas... [15:44:27] Albert221: o/ how are you? [15:44:46] (03CR) 10Zfilipin: "First, this is amazing. `npm t` just works (tm)." [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/394539 (https://phabricator.wikimedia.org/T180777) (owner: 10Jdrewniak) [15:45:45] Albert221: heyo [15:45:49] d3r1ck / refeed[m] : So I think what would be the ideal solution here would be in doBatchLookups() (Where $this->globalIDGroups is set) also set a $this->globalIDNames, setting it as $this->globalIDNames[$row->gu_id] = $row->gu_name; and then passing the stored name to the UserGroupMembership::getLink() [15:45:53] bawolff: now I don't seem to see where username can be gotten :( [15:46:07] Zppix, veeeery sleepy, but fine! thanks :) and you? [15:46:12] Okay! Looking... [15:46:40] refeed[m]: But that's a little beyond what the original gci task specified, so I think what you have is fine, and we could make a follow up task about using the username [15:46:52] Albert221: im fine, really its early morning (9:46 AM utc-6) and ive not had my coffee [15:47:20] bawolff: Yeha! [15:47:28] bawolff: okay [15:48:00] bawolff: Maybe legoktm should have a second look then refeed[m] proceeds? [15:49:01] (03CR) 10Brian Wolff: [C: 032] "So technically this should actually specify the username - but that part was already broken before you - and its quite a bit beyond what t" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396077 (https://phabricator.wikimedia.org/T181829) (owner: 10Rafidaslam) [15:49:28] Oh, I should have probably actually tested the code before pressing +2 [15:50:08] bawolff: its friday no one will notice xD jk [15:50:23] except i don't have central auth locally right now [15:50:56] jdlrobson ping! [15:51:35] (03Merged) 10jenkins-bot: SpecialGlobalUsers: Replace User::makeGroupLinkWiki with newer function [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/396077 (https://phabricator.wikimedia.org/T181829) (owner: 10Rafidaslam) [15:51:47] Err wait, I was wrong umm, we could get the username much easier by passing it in formatRow() [15:55:07] (03PS1) 10Hashar: Add .gitreview [wmf-utils] - 10https://gerrit.wikimedia.org/r/396415 [15:55:22] (03CR) 10Hashar: [V: 032 C: 032] Add .gitreview [wmf-utils] - 10https://gerrit.wikimedia.org/r/396415 (owner: 10Hashar) [15:55:26] Albert221: About the ooui on Special:Undelete thing - I really want to emphasize that that is my fault for not catching it in code review [15:55:31] bawolff: Or is there a way we can use the userID to get the name? [15:56:04] d3r1ck: We could, but then we would do a db query for each user, and the class is trying to avoid that for efficiency reasons [15:56:09] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Epic, 10Tracking: [Epic] Wikidata watchlist improvements (client) - https://phabricator.wikimedia.org/T90435#3823293 (10matej_suchanek) [15:56:12] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Story: [Story] Clean up the code that formats Wikibase entries in recent changes - https://phabricator.wikimedia.org/T58664#3823292 (10matej_suchanek) [15:56:14] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Epic, 10User-notice, and 2 others: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - https://phabricator.wikimedia.org/T46874#3823294 (10matej_suchanek) [15:56:16] bawolff: :( [15:56:18] in formatRow() however, the username is available as $row->gu_name [15:56:49] bawolff, tbh I didn't know it wasn't intended. I thought that it is the intended appearance as for the OOUI element. but it's okay, I was working with this code so I'll get (or at least try) to fix that :) [15:57:19] Albert221: Well I thought it was the intended appearence too [15:57:31] I guess people just don't like the intended appearence ;) [15:57:48] bawolff: I don't see formatRow() defined in the class [15:57:54] Or is it somewhere else? [15:58:14] There are two classes in that file [15:58:30] (03PS1) 10Hashar: Add tox and flake8 [wmf-utils] - 10https://gerrit.wikimedia.org/r/396416 [15:58:41] formatRow is the function that calls getUserGroups [15:58:44] (03CR) 10jerkins-bot: [V: 04-1] Add tox and flake8 [wmf-utils] - 10https://gerrit.wikimedia.org/r/396416 (owner: 10Hashar) [15:58:49] err, wait i might be looking at an old version [15:59:18] nope, not looking at old version [15:59:37] Anyways, GlobalUsersPager::formatRow calls GlobalUsersPager::getUserGroups [15:59:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Technical-Debt: [Task] Replace base classes ApiWikibase, ModifyEntity, ModifyClaim, etc. with composable objects. - https://phabricator.wikimedia.org/T71001#3823312 (10matej_suchanek) [15:59:51] bawolff: I'm looking here: https://doc.wikimedia.org/mediawiki-core/master/php/classUserGroupMembership.html [15:59:52] So the correct fix is to make GlobalUsersPager::getUserGroups() to take another parameter [16:00:04] ah, I meant the page in central auth [16:00:09] Or maybe I'm the one looking at an old version? [16:00:42] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3823314 (10mobrovac) Thnx @pmiazga for this first round. One thing that could be also interesting to measure is how is the response latency... [16:00:49] bawolff, what particularly doesn't work? [16:01:10] Have you pressed space when the focus was on the editTools div? [16:01:26] I'll send you a video later when I'm home :) [16:01:27] refeed[m]: Approving on GCI [16:01:32] yeah, and nothing happened [16:01:50] d3r1ck: okay, thanks! [16:01:55] (03PS2) 10Hashar: Add tox and flake8 [wmf-utils] - 10https://gerrit.wikimedia.org/r/396416 [16:01:59] And i wasn't able to move to the next thing in the list of characters to insert [16:01:59] (03CR) 10Zfilipin: "Looks good to me in general. I have left a few comments. I will take another look on Monday." (036 comments) [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/394539 (https://phabricator.wikimedia.org/T180777) (owner: 10Jdrewniak) [16:02:29] (03CR) 10Hashar: [C: 032] Add tox and flake8 [wmf-utils] - 10https://gerrit.wikimedia.org/r/396416 (owner: 10Hashar) [16:02:35] My comment lists what I tried, what I expected to happen, and what did [16:02:44] (03Merged) 10jenkins-bot: Add tox and flake8 [wmf-utils] - 10https://gerrit.wikimedia.org/r/396416 (owner: 10Hashar) [16:02:58] divadsn: Always a possibility that different browsers affected it [16:03:05] I was testing on firefox 52 esr [16:03:47] divadsn: I don't know much about tabindex stuff, so if something weird is happening on only some browsers, the mentor on the task might be able to better explain what is wrong [16:04:42] I was testing on Firefox 57 and Chrome latest [16:05:07] (03PS1) 10Mholloway: Revert "Media: Update selector blacklist" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396417 [16:06:42] divadsn: Did you use the MediaWiki:edittools from commons? [16:07:06] I wasn't testing using any of the commons tool drop down box js thing, so that might be a difference [16:07:23] 10ELiSo: Help:Glossaries should be translated - https://phabricator.wikimedia.org/T152409#3823329 (10Psychoslave) https://www.mediawiki.org/wiki/User:Psychoslave/generic_glossary/eo [16:10:23] 10Google-Code-in-2017, 10I18n: Make GlobalUsersPager properly support gender - https://phabricator.wikimedia.org/T182444#3823332 (10Bawolff) [16:10:26] 04(no projects): Getting the "userName" to use in the UserGroupMembership::getLink() - https://phabricator.wikimedia.org/T182445#3823343 (10D3r1ck01) [16:10:51] d3r1ck: jinks [16:11:03] (03Abandoned) 10Mholloway: Revert "Media: Update selector blacklist" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396417 (owner: 10Mholloway) [16:11:23] d3r1ck: Do you mind if I merge your task into mine? [16:11:24] 04(no projects): Getting the "userName" to use in the UserGroupMembership::getLink() - https://phabricator.wikimedia.org/T182445#3823355 (10D3r1ck01) 05Open>03Invalid As @Bawolff has created T182444 already! [16:11:34] bawolff: Don't worry, I just marked it as invalid [16:11:46] I didn't know you were phabbing :D [16:11:53] 10Marvin: Changing pages should update page title - https://phabricator.wikimedia.org/T180465#3823359 (10Niedzielski) a:03Niedzielski [16:11:55] 04(no projects): Getting the "userName" to use in the UserGroupMembership::getLink() - https://phabricator.wikimedia.org/T182445#3823361 (10Bawolff) [16:11:57] 10Google-Code-in-2017, 10I18n: Make GlobalUsersPager properly support gender - https://phabricator.wikimedia.org/T182444#3823364 (10Bawolff) [16:11:59] oh well i already did [16:12:07] :D [16:12:13] bawolff: Okay! thanks [16:12:23] d3r1ck: Do you want to submit a version of that to the gci site? [16:12:42] bawolff: Adding the required tags to the ticket [16:13:09] 10MediaWiki-API, 10Performance-Team, 10Wikidata, 10Performance, and 3 others: API is (intermittently) very slow - blocked waiting for cpPosTime cookie - https://phabricator.wikimedia.org/T182322#3823365 (10Trizek-WMF) [16:13:33] 10MediaWiki-extensions-CentralAuth, 10Google-Code-in-2017, 10I18n, 10Technical-Debt, 10Wikimedia-log-errors: Make GlobalUsersPager properly support gender - https://phabricator.wikimedia.org/T182444#3823367 (10D3r1ck01) [16:14:04] (03PS1) 10Niedzielski: Update: browser window / tab title per page [marvin] - 10https://gerrit.wikimedia.org/r/396418 (https://phabricator.wikimedia.org/T180465) [16:14:04] bawolff: Yeah, can import it to GCI [16:14:11] refeed[m]: Will you work on it? I mean the follow up? [16:14:13] (03PS1) 10Mholloway: Media: Remove unwanted selectors from the blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396420 (https://phabricator.wikimedia.org/T177430) [16:16:00] 10Wikimedia-General-or-Unknown, 10Technical-Debt, 10Wikimedia-log-errors: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01 - https://phabricator.wikimedia.org/T181834#3823383 (10D3r1ck01) [16:16:02] 10MediaWiki-extensions-CentralAuth, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), 10Patch-For-Review, and 2 others: Remove deprecated User::makeGroupLinkWiki() calls in SpecialGlobalUsers - https://phabricator.wikimedia.org/T181829#3823379 (10D3r1ck01) 05Open>03... [16:16:52] d3r1ck: Well, I'm not too advanced in php thing, maybe when there's no one who wanna work on it [16:17:12] refeed[m]: That's totally fine! [16:17:40] :) [16:18:26] (03PS8) 10DCausse: Port update_general_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/393694 (owner: 10EBernhardson) [16:18:44] 10MediaWiki-extensions-CentralAuth, 10Google-Code-in-2017, 10I18n, 10Technical-Debt, 10Wikimedia-log-errors: Make GlobalUsersPager properly support gender - https://phabricator.wikimedia.org/T182444#3823389 (10D3r1ck01) Imported as: https://codein.withgoogle.com/dashboard/tasks/5477903577907200/. [16:18:59] bawolff: you can add yourself :) [16:18:59] https://codein.withgoogle.com/dashboard/tasks/5477903577907200/ [16:20:30] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech: Change logo image provided by payment provider Sofort - https://phabricator.wikimedia.org/T182112#3823391 (10kai.nissen) @Jan_Dittrich They recently rebranded. The logo you had in mind has been replaced. I guess, that the logo they use now... [16:20:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: [Task] Diff not implemented for Wikibase\ItemContent; override generateContentDiffBody to fix this (action=compare) - https://phabricator.wikimedia.org/T96124#3823392 (10matej_suchanek) [16:20:46] (03CR) 10C. Scott Ananian: "works for me, thanks" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396128 (owner: 10C. Scott Ananian) [16:20:47] 10MediaWiki-extensions-PageSchemas: HTTP ERROR 500 when trying to create schema - https://phabricator.wikimedia.org/T182441#3823394 (10Patrezp) 05Open>03Resolved a:03Patrezp I just downloaded master as I was using old release. It is fixed in master [16:20:51] 10Page-Previews, 10Readers-Web-Backlog: QA html previews on beta cluster - https://phabricator.wikimedia.org/T182399#3823397 (10ABorbaWMF) Page previews looks good so far. I noticed two small issues: the empty preview and the list preview don't seem to be working (no preview at all). It's hard to tell from the... [16:21:21] (03PS5) 10C. Scott Ananian: Move category IDs into the extension.json information [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396162 [16:23:32] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10WMDE-Fundraising-CN: Mobile impression drop on German Wikipedia - https://phabricator.wikimedia.org/T182446#3823400 (10DStrine) [16:24:40] d3r1ck: So then its just waiting for an admin to approve the task? [16:24:59] 10Mobile-Content-Service, 10Page Content Service, 10Reading-Infrastructure-Team-Backlog: Content service incorrectly reports article as "deleted" - https://phabricator.wikimedia.org/T181636#3823412 (10Mholloway) The linked responses look OK now. Did you happen to save a copy of the error JSON somewhere? I... [16:25:06] Yeah and publish [16:25:28] bawolff, I don't know, could you help me installing those so I can fix it in 1 hour? :) [16:25:42] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Winter Wanderland, 10WMDE-Fundraising-CN: Mobile impression drop on German Wikipedia - https://phabricator.wikimedia.org/T182446#3823413 (10DStrine) p:05Triage>03High [16:25:55] divadsn: Yeah, of course [16:26:16] CharInsert and ParserFunctions are two of the easier extensions to install [16:26:27] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Show summarizing sentence after entering the donation form from a deep-link - https://phabricator.wikimedia.org/T180690#3823415 (10gabriel-wmde) New PR is up: https://github.com/wmde/FundraisingFrontend/pull/1090 [16:27:55] is there anyone who worked in `mediawiki-vagrant` here? [16:28:27] (03PS6) 10C. Scott Ananian: Move category IDs into the extension.json information [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396162 [16:28:37] bd808 is the lord and master of vagrant ;) [16:29:05] But what's your question, and then people will be able to figure out if they know the answer or not [16:29:30] (03CR) 10C. Scott Ananian: Move category IDs into the extension.json information (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396162 (owner: 10C. Scott Ananian) [16:29:42] (03CR) 10DCausse: [C: 031] Port update_general_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/393694 (owner: 10EBernhardson) [16:33:11] (03CR) 10C. Scott Ananian: "> Doesn't this mean we'd to duplicate the category ID list in both" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396280 (owner: 10C. Scott Ananian) [16:33:40] bawolff: :D [16:33:46] (03PS5) 10C. Scott Ananian: Allow Parsoid to provide category ID hints [extensions/Linter] - 10https://gerrit.wikimedia.org/r/396280 [16:33:48] (03CR) 10Sharvaniharan: Add DatePicker on on-this-day full screen (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) (owner: 10Sharvaniharan) [16:34:05] bawolff: Not just master but "grand master" [16:34:31] (03PS1) 10Dbrant: Fix occasional bug in Randomizer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396424 [16:34:48] * Zppix is still using 2008 hardware and is still using x32 [16:37:13] kek, okay [16:39:22] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Add house number validation to cat17 - https://phabricator.wikimedia.org/T180042#3823430 (10kai.nissen) [16:40:07] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3823432 (10Sharvaniharan) @RHo Little unclear on the alpha changes on the calendar icon in th... [16:40:15] I have a problem when doing `vagrant provision`, here is the log: https://dpaste.de/ELNu , anyone know what's the problem ? [16:40:17] RuntimeException: The configuration setting 'wgVectorUseSimpleSearch' was already set by another extension, and cannot be set again. in /vagrant/mediawiki/includes/registration/ExtensionProcessor.php on line 494 [16:40:29] (03PS6) 10Mholloway: Media: Add section ID numbers [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396085 (https://phabricator.wikimedia.org/T177430) [16:44:05] (03CR) 10Brian Wolff: [C: 032] Add quotes to comment based strip markers [core] - 10https://gerrit.wikimedia.org/r/396392 (https://phabricator.wikimedia.org/T180159) (owner: 10Phantom42) [16:44:29] 10MediaWiki-Parser, 10Google-Code-in-2017, 10Patch-For-Review, 10Security: As a hardening measure, MW's various comment based strip markers (e.g. ) should include quotes to avoid being included in attributes - https://phabricator.wikimedia.org/T180159#3823438 (10Bawolff) 05Open>03Resolved [16:45:02] And btw about `mediawiki-vagrant` why not just print the error traceback when `vagrant provision` occurs, instead of just print `.... returned 255 instead of one of [0]`. [16:45:18] bd808: ^ ping [16:45:56] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3823439 (10pmiazga) @mobrovac I stored files as I want to verify that files are rendered correctly. Transfer rate is less than 1MB/s and my... [16:46:17] (03CR) 10Ema: Smarter Varnish slow log (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/395076 (https://phabricator.wikimedia.org/T181315) (owner: 10Gilles) [16:46:21] refeed[m]: He's out at a conference. File a task :) [16:46:51] (03PS1) 10Mholloway: Dev: Stop caching test HTTP responses by default [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396425 [16:47:42] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3823441 (10Isarra) That preference isn't exactly new, though. [16:48:01] refeed[m]: What extensions do you have on? [16:48:10] Maybe you have the same extension twice [16:48:34] refeed[m]: that's puppet, not vagrant, you shold be able to see the stack trace if you use PUPPET_DEBUG=1 vagrant provision [16:48:52] (03PS1) 10Anomie: ApiQueryBase: Fix addWhereFld for PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396426 (https://phabricator.wikimedia.org/T182377) [16:49:24] https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Provisioning [16:49:52] (03Merged) 10jenkins-bot: Add quotes to comment based strip markers [core] - 10https://gerrit.wikimedia.org/r/396392 (https://phabricator.wikimedia.org/T180159) (owner: 10Phantom42) [16:50:42] 10Electron-PDFs, 10Proton, 10Readers-Web-Backlog, 10Performance, 10Readers-Web-Kanban-Board: Performance test the service - https://phabricator.wikimedia.org/T178278#3823449 (10pmiazga) @bd808 -FYI, we're testing the newly created chromium service (http://chromium-pdf.wmflabs.org), don't get alarmed when... [16:51:27] refeed[m]: Or maybe you have an old version of the Vector/UsabilityInitiative extension installed with a modern version of the Vector skin installed [16:51:52] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3823451 (10Strainu) And yet, it's been ignored in almost every RC update in the last year - I remember at least 2 other bugs that were only reproducible with that setting. Be... [16:51:58] refeed[m]: Anyways, disable all your skins and extensions and try re-enabling one by one until the error goes away, to figure out which causes it [16:52:08] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017, 10User-Ryasmeen: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3823452 (10Mvolz) >>! In T179691#3821039, @AnmolSingh wrote: > @Mvolz done, icon is licensed as Creative Commons BY 3.0 Hi, I looked at the link... [16:52:20] Reedy: oh okay, maybe later when I found is this an issue with mediawiki-vagrant or not [16:53:13] (03CR) 10Dbrant: [C: 032] "Very clever, and a much better solution." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395902 (https://phabricator.wikimedia.org/T181459) (owner: 10Cooltey) [16:53:18] bawolff: lemme see first [16:53:19] mobrovac: okay, thanks [16:55:05] Phantom42: I can't mark your task as done until you mark it as submitted in GCI [16:55:19] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3823457 (10Albert221) A quick analysis: - This `width` is due to `max-width: 50em` in `.oo-ui-textInputWidget` class - This class is added here: https://gi... [16:55:56] 10MediaWiki-Special-pages, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3823458 (10Xaosflux) p:05Triage>03Normal [16:56:44] (03PS1) 10Anomie: Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat [core] - 10https://gerrit.wikimedia.org/r/396427 (https://phabricator.wikimedia.org/T182368) [16:56:53] (03Merged) 10jenkins-bot: Fix an external link issue after setup "always" while opening deep links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395902 (https://phabricator.wikimedia.org/T181459) (owner: 10Cooltey) [16:57:46] Albert221: I think the best solution for https://phabricator.wikimedia.org/T182398 is to just change the textbox back to being not ooui. there's also a complaint about grey text in monobook, and appearently the narrow width is intentional in OOUI most of the time, just not wanted here [16:59:30] (03CR) 10jenkins-bot: Add quotes to comment based strip markers [core] - 10https://gerrit.wikimedia.org/r/396392 (https://phabricator.wikimedia.org/T180159) (owner: 10Phantom42) [16:59:32] (03CR) 10jenkins-bot: Fix an external link issue after setup "always" while opening deep links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395902 (https://phabricator.wikimedia.org/T181459) (owner: 10Cooltey) [16:59:35] bawolff, :/ To be honest, when I was doing that task I thought, that I will find and do more OOUI tasks which would help MediaWiki be a little bit more pleasant to eye. I have to say, that the OOUIs one is much more beautiful than the previous one though :/ Should I just `git review` the revert of the textarea code? [16:59:48] 10Discovery: Search in "" does not distinguish between "ss" and "ß" - https://phabricator.wikimedia.org/T182447#3823464 (10JStrodt_WMDE) [17:00:02] I think so, we could always unrevert it once ooui is fixed [17:00:19] Keeps the Wikipedia lynch mob happy ;) [17:00:37] do you think anyone will remember it in the future? :O who/what is Wikipedia lynch mob? [17:00:47] (03PS3) 10BearND: Dev: bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) [17:00:49] (03PS1) 10BearND: WIP: Dev: Replace Sepia with Replayer [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396428 (https://phabricator.wikimedia.org/T152255) [17:01:17] (03CR) 10BearND: Dev: bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [17:01:50] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Create updated assets for Play store promotion of the Fortune cookie release - https://phabricator.wikimedia.org/T181532#3823477 (10RHo) [17:01:51] "Wikipedia lynch mob" is my very snide name for when users of wikipedia get angry about some change [17:02:26] You could file a separate bug for the other stuff so people remember [17:02:36] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Winter Wanderland, 10WMDE-Fundraising-CN: Mobile impression drop on German Wikipedia - https://phabricator.wikimedia.org/T182446#3823479 (10DStrine) @kai.nissen and @tmletzko are you having trouble with specific campaigns or... [17:02:47] (03CR) 10jerkins-bot: [V: 04-1] WIP: Dev: Replace Sepia with Replayer [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396428 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [17:03:50] (03CR) 10Mholloway: [C: 032] Dev: bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [17:03:57] 10Marvin: Add query parameter parser - https://phabricator.wikimedia.org/T178617#3823481 (10Niedzielski) a:03Niedzielski [17:04:14] (03CR) 10Pastakhov: [C: 032] WikiPageDeletionUpdates WikiPage typehint [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/396383 (owner: 10Addshore) [17:05:02] (03CR) 10EBernhardson: Check if $responseData['responses'] is set before use (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395883 (https://phabricator.wikimedia.org/T161283) (owner: 10Umherirrender) [17:05:22] (03CR) 10Pastakhov: [V: 032 C: 032] WikiPageDeletionUpdates WikiPage typehint [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/396383 (owner: 10Addshore) [17:05:35] (03Merged) 10jenkins-bot: Dev: bring back Sepia request caching [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396297 (https://phabricator.wikimedia.org/T152255) (owner: 10BearND) [17:07:31] 10Security-Team: Make securitycheckplugin detect double escaping - https://phabricator.wikimedia.org/T182448#3823484 (10Bawolff) [17:08:10] Hmm, maybe that could be a gci task [17:08:18] If some people want something more challenging [17:09:29] (03PS1) 10Kghbln: Revert #contentSub and #jump-to-nav margin changes [core] - 10https://gerrit.wikimedia.org/r/396429 (https://phabricator.wikimedia.org/T178626) [17:09:56] (03CR) 10jerkins-bot: [V: 04-1] Revert #contentSub and #jump-to-nav margin changes [core] - 10https://gerrit.wikimedia.org/r/396429 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:10:36] (03Abandoned) 10EBernhardson: [DNM] Test xgboost4j-spark with fast hist tree maker [search/xgboost] - 10https://gerrit.wikimedia.org/r/395856 (owner: 10EBernhardson) [17:10:37] bawolff : I just got it working disabling my installed skins, thanks [17:11:06] (03Abandoned) 10Kghbln: Fix margin of #jump-to-nav [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396331 (https://phabricator.wikimedia.org/T176444) (owner: 10Kghbln) [17:11:26] (03PS1) 10Albert221: Revert replacing textarea in Special:Undelete with OOUI [core] - 10https://gerrit.wikimedia.org/r/396430 (https://phabricator.wikimedia.org/T182398) [17:11:36] So it might be if you had a custom skin that copied and pasted from the Vector skin, that both set that $wgUseVectorSimpleSearch [17:12:31] is jenkins automatically checking for +2 if I'm on the whitelist? [17:12:39] or should I comment "recheck"? [17:12:40] bawolff: yeah I think so, I didn't look to the skin's code though [17:12:54] Albert221: It will be automatic [17:13:03] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Winter Wanderland, 10WMDE-Fundraising-CN: Mobile impression drop on German Wikipedia - https://phabricator.wikimedia.org/T182446#3823516 (10tmletzko) hi @DStrine we do not have access to your data analysis tools. We received... [17:13:40] Albert221: You probably shouldn't include "Bug: T182426" in the commit message of that change - as that bug is about the grey text in general, and not specificly about it on Special:Undelete [17:13:41] T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426 [17:13:44] (03CR) 10Sharvaniharan: [C: 032] Fix occasional bug in Randomizer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396424 (owner: 10Dbrant) [17:13:59] and the bug: footers are supposed to be for the bugs your patch fixes (not the one's that might be related) [17:14:53] (03CR) 10Kghbln: "This was supposed to got to REL1_30. I have currently no idea how to get this to REL1_30." [core] - 10https://gerrit.wikimedia.org/r/396429 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:15:04] (03PS1) 10Kghbln: Revert #contentSub and #jump-to-nav margin changes [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) [17:15:04] Albert221: You're using spaces instead of tabs :P [17:15:10] hm, okay, I thought, that T182426 related just to my previous patch, I'm fixing that [17:15:38] If you run composer fix prior to committing phpcbf will fix that automatically for you [17:15:41] (03PS1) 10DCausse: Port dump_action.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396432 [17:16:34] I always forget about the spaces [17:16:44] (03PS2) 10Albert221: Revert replacing textarea in Special:Undelete with OOUI [core] - 10https://gerrit.wikimedia.org/r/396430 (https://phabricator.wikimedia.org/T182398) [17:17:16] (03CR) 10Kghbln: "I have now cherry-picked this to REL1_30 however this feels like doing the wrong thing for the right reason. This is pretty frustrating. M" [core] - 10https://gerrit.wikimedia.org/r/396429 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:17:26] (03Merged) 10jenkins-bot: Fix occasional bug in Randomizer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396424 (owner: 10Dbrant) [17:17:29] I'm very used to tabs at this point, but I can never get over having a space between foreach and '(' and also for switch [17:18:04] I'm basically following PSR-2 and Wikimedia Code Style is really odd for me [17:18:14] (03CR) 10jerkins-bot: [V: 04-1] Revert #contentSub and #jump-to-nav margin changes [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:18:41] also bawolff, if you use PhpStorm you can just set the code style preset to PSR-2 and it'll probably fix those things for you [17:18:57] (03CR) 10Reedy: [C: 032] Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat [core] - 10https://gerrit.wikimedia.org/r/396427 (https://phabricator.wikimedia.org/T182368) (owner: 10Anomie) [17:19:05] 10Page-Previews, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Show HTML summaries on cswiki - https://phabricator.wikimedia.org/T182321#3823528 (10Jdlrobson) @phuedx my bad. I thought this task was about services switching out the o... [17:19:41] (03CR) 10Kghbln: "And this fails to. Time to goatify this patch set: I am a grump old goat now. :( All this mess just to get this breaking change out of REl" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:20:37] (03PS1) 10Mholloway: Hygiene: Remove NSP workaround for moment.js [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) [17:20:37] Albert221: But, vi forever!!! [17:20:55] emacs masterrace [17:21:04] bawolff, haha :D I'm trying from time to time to use vim, but I lack the knowledge of basic things [17:21:11] refeed[m]: :P [17:21:12] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396434 [17:21:22] but I know how to exit it so live not to die! [17:21:48] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396434 (owner: 10Dbrant) [17:21:56] Albert221: Use whatever you feel comfortable with. Some people start religious wars over text editors, but the most important thing is using what you find productive [17:22:06] And Phpstorm has lots of helpful features for writing php [17:22:20] (03CR) 10jerkins-bot: [V: 04-1] Port dump_action.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396432 (owner: 10DCausse) [17:22:24] refeed[m]: Except not emacs of course, that war is holy ;) [17:22:32] yesyesyes, of course, but sometimes I want to edit a file inside a terminal or on server/foreign computer [17:22:36] (03CR) 10jenkins-bot: Fix occasional bug in Randomizer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396424 (owner: 10Dbrant) [17:22:38] (03CR) 10Reedy: "Wikibase is known broken in REL1_30" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:22:42] and then vi(m) comes with the help [17:23:11] Most servers also have nano available, if your not familar with vim [17:23:17] and nano is very easy to use [17:23:20] bawolff: :P [17:23:30] ... but sometimes I just get really mad with vim and I end up editing it with nano xD [17:23:58] 10Design, 10WMDE-Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Fundraising-Funban-2: Show summarizing sentence after entering the donation form from a deep-link - https://phabricator.wikimedia.org/T180690#3823533 (10gabriel-wmde) @Jan_Dittrich : If we want to stay in the palette of the element... [17:24:09] 10Proton, 10Readers-Web-Backlog, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3823534 (10Kaartic) > What is the list of browser that are displaying the download button that are not Chrome? I guess the... [17:24:11] bawolff, can you delete those Gerrit's feed from T182426? [17:24:12] T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426 [17:24:31] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: Remove NSP workaround for moment.js [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) (owner: 10Mholloway) [17:24:51] Albert221: umm, no, but don't worry about it, there's gerritbot comments for the wrong bugs all over the place [17:25:00] (03CR) 10Kghbln: "So there is hope? I am ready to cheerfully de-goatify if necessary. :) Touching wood." [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:25:20] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396434 (owner: 10Dbrant) [17:25:23] (03CR) 10Anomie: [MCR] Introduce PageIdentity, and use it instead of Title. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/392310 (owner: 10Daniel Kinzler) [17:25:36] (03CR) 10Reedy: "T182336" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [17:25:47] refeed[m]: btw, if you use emacs, https://www.mediawiki.org/wiki/Manual:Coding_conventions#emacs_style might be useful to you [17:26:08] hexmode loves emacs and did a lot of work customizing his editor ;) [17:26:37] (03Merged) 10jenkins-bot: Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat [core] - 10https://gerrit.wikimedia.org/r/396427 (https://phabricator.wikimedia.org/T182368) (owner: 10Anomie) [17:28:56] 10Page-Previews, 10Readers-Web-Backlog: Show HTML summaries on all wikis - https://phabricator.wikimedia.org/T182319#3823543 (10phuedx) [17:29:11] 10Accuracy-Review-of-Wikipedias: Improve the UI design of the Accuracy Review of Wikipedias Flask app - https://phabricator.wikimedia.org/T141295#3823544 (10Snd96) {F11696398} {F11696399} {F11696412} {F11696417} Here are the files for each of the 4 tutorials I've made. A lot of the words have been repeated t... [17:29:41] (03CR) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/396434 (owner: 10Dbrant) [17:30:03] bawolff: https://gerrit.wikimedia.org/r/#/c/396430/ [17:31:38] 10Developer-Relations (Jan-Mar-2018), 10Google-Code-in-2017: Google Code-in 2017: Collect Feedback and Lessons Learned - https://phabricator.wikimedia.org/T181738#3823548 (10Aklapper) >>! In T181738#3820055, @Bawolff wrote: > Private phab task? > I wouldnt necessarily consider that a better tool than google do... [17:32:29] what should I do with some Gerrit patches that looks like no one cares? [17:32:30] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [BUG] Error when clicks on external links if set up "always" while opening wikipedia links in the other apps - https://phabricator.wikimedia.org/T181459#3823551 (10cooltey) [17:32:41] patches of mine [17:33:18] bawolff: well, I always wanted to use emacs tbh, but in order to configure it, I need to learn about lisp first, also I sometimes confused with the hotkeys. Btw good to know we have someone who uses emacs here, so I can ask him and then take a part of this holy war ;) [17:33:24] (03CR) 10Mholloway: "recheck" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) (owner: 10Mholloway) [17:33:27] Albert221: What are they for? [17:34:08] refeed[m]: I could never wrap my head around emacs, which is why I use vi :) [17:34:10] https://gerrit.wikimedia.org/r/#/c/394365/ and https://gerrit.wikimedia.org/r/#/c/395148/ [17:35:06] (03CR) 10Reedy: [C: 04-1] "Task/bug?" [core] - 10https://gerrit.wikimedia.org/r/395148 (owner: 10Albert221) [17:35:19] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: Remove NSP workaround for moment.js [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) (owner: 10Mholloway) [17:35:31] Albert221: I'd say just give it a little time for someone from the apps team to take a look [17:35:50] I don't like waitforslaves and waitforreplication.... [17:36:40] For the apps one that is [17:37:04] (03PS5) 10Albert221: Replace wfWaitForSlaves() with not deprecated method [core] - 10https://gerrit.wikimedia.org/r/395148 (https://phabricator.wikimedia.org/T181673) [17:37:13] bawolff: same :P, I still stay in the vi side right now [17:38:22] (03CR) 10Brian Wolff: [C: 032] Revert replacing textarea in Special:Undelete with OOUI [core] - 10https://gerrit.wikimedia.org/r/396430 (https://phabricator.wikimedia.org/T182398) (owner: 10Albert221) [17:38:42] (03CR) 10jenkins-bot: Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat [core] - 10https://gerrit.wikimedia.org/r/396427 (https://phabricator.wikimedia.org/T182368) (owner: 10Anomie) [17:39:59] 10Wiki-Loves-Monuments (2017): Ask partners and people for endorsment of the Instagram account - https://phabricator.wikimedia.org/T182237#3823565 (10MelodyKramer) Hi all, In recent months, we've been rethinking the Foundation's strategy on Instagram. It's a great medium for showcasing beautiful visual elements... [17:41:55] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Regression: Special:Undelete contains egregious white space after OOUI update - https://phabricator.wikimedia.org/T182398#3823568 (10Bawolff) Status update for the Wikipedians: We will go back to the old textbox on Monday. [17:44:20] (03PS2) 10Reedy: ApiQueryBase: Fix addWhereFld for PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396426 (https://phabricator.wikimedia.org/T182377) (owner: 10Anomie) [17:44:24] (03CR) 10Reedy: [C: 032] ApiQueryBase: Fix addWhereFld for PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396426 (https://phabricator.wikimedia.org/T182377) (owner: 10Anomie) [17:44:25] Albert221: So for the revert of the textarea. Since its negatively affecting wikipedia admins, and they are being uppity about it, we're probably going to deploy the revert early on Monday [17:45:27] okay okay :) btw how frequent are updates on Wikipedia.org? are they using master instead of stable? [17:45:47] They update once a week (On thursdays) [17:46:04] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 20 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3823569 (10Anomie) >>! In T153505#3822042, @Reedy wrote: > An... [17:46:18] Albert221: basically https://wikitech.wikimedia.org/wiki/Train [17:46:43] (03Merged) 10jenkins-bot: Revert replacing textarea in Special:Undelete with OOUI [core] - 10https://gerrit.wikimedia.org/r/396430 (https://phabricator.wikimedia.org/T182398) (owner: 10Albert221) [17:46:58] If you wanted to (but only if you want to) you could do the process of requesting the change be deployed early (Signing up for a swat window). Don't feel obliged if you don't want to, but if you're interested it might be interesting to you to see how the process works [17:48:23] The requirements, is that basically you have to be in #wikimedia-operations during the time of the swat window to answer any questions about the patch [17:49:03] And then you're asked to test it (there's a special browser extension you have to use to go to the test version of the site) [17:49:42] sounds interesting [17:50:16] If you wanted to do it, you would have to be available during one of the swat windows, which is either 14:00–15:00 utc or 19:00–20:00 utc [17:50:28] (03CR) 10Mholloway: "The failing test was broken by the 1.5.9 release of wikipedia-edits-scorer (relevant change: https://github.com/jdlrobson/wikipedia-edits-" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) (owner: 10Mholloway) [17:50:55] so looks like I am hour late for the late one [17:50:57] Albert221: There's more information at https://wikitech.wikimedia.org/wiki/SWAT_deploys [17:51:27] There's also 00:00-01:00 on the next day (tuesday utc, but maybe monday in your timezone depending) [17:51:32] 10Proton, 10Readers-Web-Backlog, 10Spike: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to? - https://phabricator.wikimedia.org/T182197#3823592 (10Jdlrobson) > I think we're looking for two things: Yup I agree with your list! This is my understanding too. >... [17:51:46] mine is UTC+1 [17:52:23] (03Merged) 10jenkins-bot: ApiQueryBase: Fix addWhereFld for PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396426 (https://phabricator.wikimedia.org/T182377) (owner: 10Anomie) [17:53:49] (03PS1) 10Mholloway: Hygiene: Fix tests [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396436 [17:53:56] so 2 am, that's probably a bad time for you ;) [17:54:04] 10GlobalBlocking, 10Stewards-and-global-tools, 10Wikimedia-log-errors: Blocker must be a local user or a name that cannot be a local user - https://phabricator.wikimedia.org/T182344#3823599 (10MarcoAurelio) Happened to me today. I cannot access Special:UserLogin at foundationwiki. Fatal error: `[WirRFApAICk... [17:54:06] err, 1 am. math is hard ;) [17:54:06] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Wikimedia-maintenance-script-run: Run maintenance/cleanupUsersWithNoId.php on all wikis - https://phabricator.wikimedia.org/T181731#3823600 (10Anomie) >>! In T181731#3821848, @Graham87 wrote: > Another complication relating to this script would be T2323, invo... [17:54:08] (03PS2) 10Mholloway: Hygiene: Remove NSP workaround for moment.js [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) [17:54:10] either way [17:54:45] tomorrow is a Saturday, I'll probably be sleeping for half the day, making up the sleep from the weekend... [17:55:16] This is for monday, but nonetheless [17:55:46] Albert221: No worries, I'll sign up for the swat window for that patch :) [17:55:48] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Change font size controls to use small, regular, large and extra large buckets - https://phabricator.wikimedia.org/T169369#3823601 (10Jdlrobson) @nirzar looking into this yesterday it seems we... [17:56:05] bawolff, I wouldn't manage to do it myself, thank you! :) [17:56:33] (03CR) 10jenkins-bot: Revert replacing textarea in Special:Undelete with OOUI [core] - 10https://gerrit.wikimedia.org/r/396430 (https://phabricator.wikimedia.org/T182398) (owner: 10Albert221) [17:57:03] No worries, this is definitely not your responsibility as a gci student (It is very far from being your responsibility). I just thought it might be interesting to you if you happened to be available at the time. [17:58:14] 10GlobalBlocking, 10Stewards-and-global-tools, 10Patch-For-Review, 10Wikimedia-log-errors: Blocker must be a local user or a name that cannot be a local user - https://phabricator.wikimedia.org/T182344#3820922 (10Reedy) ``` 2017-12-08 17:49:50 [WirQvgpAEK0AABOc-fYAAABK] mw1218 foundationwiki 1.31.0-wmf.11... [17:59:12] 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Replace settings checkboxes to ToggleSwitches - https://phabricator.wikimedia.org/T169807#3409204 (10Jdlrobson) It looks like the beta mode needs to be saved by submitting the form. @nirzar this creates problems as the ToggleSwitch is not... [17:59:22] 10GlobalBlocking, 10Stewards-and-global-tools, 10Wikimedia-log-errors: Blocker must be a local user or a name that cannot be a local user - https://phabricator.wikimedia.org/T182344#3823612 (10Reedy) [18:01:43] 10GlobalBlocking, 10Stewards-and-global-tools, 10Wikimedia-log-errors: Blocker must be a local user or a name that cannot be a local user - https://phabricator.wikimedia.org/T182344#3823617 (10MarcoAurelio) I think the issue comes when you try to log in and you're under an IP or CIDR which is globally blocked. [18:03:06] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [BUG] Incorrect behavior after rotating in the Randomizer page - https://phabricator.wikimedia.org/T181456#3823618 (10cooltey) a:03cooltey [18:03:21] 10CirrusSearch, 10Discovery, 10Discovery-Search: Search in "" does not distinguish between "ss" and "ß" - https://phabricator.wikimedia.org/T182447#3823619 (10Aklapper) -> #cirrussearch [18:04:12] 10CirrusSearch, 10Discovery, 10Discovery-Search: Search in "" does not distinguish between "ss" and "ß" - https://phabricator.wikimedia.org/T182447#3823623 (10Aklapper) [18:04:14] 10CirrusSearch, 10Discovery, 10Discovery-Search: ~"daß" should not match "dass" - https://phabricator.wikimedia.org/T87136#3823626 (10Aklapper) [18:04:25] 10CirrusSearch, 10Discovery, 10Discovery-Search: Search in "" does not distinguish between "ss" and "ß" - https://phabricator.wikimedia.org/T182447#3823464 (10Aklapper) See {T87136} - thanks! [18:04:39] (03CR) 10jenkins-bot: ApiQueryBase: Fix addWhereFld for PHP 7.2 [core] - 10https://gerrit.wikimedia.org/r/396426 (https://phabricator.wikimedia.org/T182377) (owner: 10Anomie) [18:05:21] hi [18:06:02] 10MediaWiki-extensions-PageSchemas: HTTP ERROR 500 when trying to create schema - https://phabricator.wikimedia.org/T182441#3823630 (10Aklapper) 05Resolved>03declined [18:06:32] hi unicorn2000 [18:07:01] what can i do here? [18:07:03] 10Wikimedia-Hackathon-2018-Organization: Communication plan - https://phabricator.wikimedia.org/T172821#3823633 (10Davidpar) [18:07:48] unicorn2000: What sort of stuff are you interested in [18:08:02] 10CirrusSearch, 10Discovery, 10Discovery-Search: Search in "" does not distinguish between "ss" and "ß" - https://phabricator.wikimedia.org/T182447#3823464 (10EBernhardson) For the moment, you can use this to get exact matches: insource:/umfaßt/ [18:08:11] unicorn2000: If you're between the age of 13-17, there's a content called GCI that's going on [18:08:40] (03PS3) 10Albert221: Fix phpcs issues and remove its s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) [18:09:15] If not, there's plenty of tasks around you could do [18:09:22] https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker has some more information on things to do [18:09:33] 10LookupUser: Allow searching user by email address - https://phabricator.wikimedia.org/T182439#3823638 (10Aklapper) [18:09:35] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3814578 (10Catrope) Looks like this is specific to the Timeless skin? [18:09:44] unicorn2000: However, it'd be easier if we knew a little about you (What your skills are, what you are interested in) [18:10:55] 10MediaWiki-General-or-Unknown, 10Easy: Fatal error: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error if the image size is somehow 0 bytes - https://phabricator.wikimedia.org/T182387#3823644 (10Aklapper) [18:12:05] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3823649 (10Catrope) Hmm not really, it's just that in Vector the results area is much wider and the results aren't usually wide enough to be overlapped by the legend, but it... [18:13:09] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3823651 (10RHo) hi @Sharvaniharan - the calendar icon is inactive (50% opacity) when the day-... [18:13:19] (03PS4) 10Albert221: Fix phpcs issues and remove its s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) [18:14:46] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3823653 (10Sharvaniharan) And when they return to today's date it goes back to 50% opacity? [18:15:28] (03CR) 10Anomie: [C: 04-1] "I'm wondering when someone would use this, getting a log file of the explains of the hundreds of queries MediaWiki can run during a single" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/393503 (owner: 10Gergő Tisza) [18:15:47] (03PS8) 10Divadsn: Add tabindex to Special:Upload in mw-editTools [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) [18:15:47] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3823654 (10Bawolff) -patch for review tag as that change isn't for this bug. [18:16:17] i am participating in GCI [18:17:11] unicorn2000: Awesome [18:17:12] 10TechCom-RfC, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Wikimania-Hackathon-2015: Colorable SVG - https://phabricator.wikimedia.org/T106240#3823656 (10Volker_E) @Nikerabbit Could you please specify such a use case? [18:17:14] I DONT HAVE ANY SPECIAL SKILLS [18:17:27] No worries, no special skills required [18:17:43] So there is a list of gci tasks on the gci website [18:17:57] yes [18:18:01] I take it you've claimed the get on to irc one? [18:18:10] yes [18:18:48] irc task [18:18:55] Awesome. Well you are here, so now you can chat with us and talk to the other gci students [18:19:18] thanks [18:19:24] Hey unicorn2000! Where are you from? :) [18:19:26] This would also be a good time to look through the other tasks and see if any look interesting, and maybe ask questions about any of them if you don't understand what they are talking about [18:19:36] unicorn2000, hey, there is no need to use caps ^^" [18:19:49] ya sry about that caps [18:20:16] unicorn2000: welcome [18:20:17] bawolf thanku [18:20:30] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Allow users to select other days to view from On this day - https://phabricator.wikimedia.org/T180372#3823657 (10RHo) Yes [18:21:15] * bawolff just got a roomba, and am running it for the first time, and am darting away from my laptop every time i hear a crash [18:21:15] what sort of tasks are provided [18:22:01] (03CR) 10Divadsn: "I removed the e.preventDefault() as it haven't prevented the browser from scrolling down, but also from interacting with the selected link" [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [18:24:45] * divadsn wonders what is a roomba, sounds like a dance for me :D [18:25:08] unicorn2000: There should be a list on the gci site, if you search for Wikimedia [18:25:14] bawolff: I am back. Sorry, I didn't mark gci task as submitted because I didn't expect patch to be merged from the first try :) [18:25:25] divadsn: Its a robot vaccum cleaner [18:25:31] divadsn: https://en.wikipedia.org/wiki/Roomba [18:25:35] ok [18:25:42] (03CR) 10Bartosz Dziewoński: "I tried that way at first but it seemed to be even more awkward. In addition to the awkwardness of dealing with ordered associative arrays" [core] - 10https://gerrit.wikimedia.org/r/396084 (https://phabricator.wikimedia.org/T181112) (owner: 10Bartosz Dziewoński) [18:25:44] (03PS4) 10Pwirth: BSFoundation: Reworked BsExtensionManager into registry / factory services [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/396312 [18:25:48] Aaaaaah ok :DD [18:25:59] that sucks right? :P [18:26:16] 10Research: Make HTML dumps available - https://phabricator.wikimedia.org/T182351#3823659 (10leila) [18:26:21] Only in the literal sense :P [18:26:23] :o [18:27:08] bawolff: i dont even know how to reply to that [18:27:41] divadsn: Just don't make a "your mum" joke [18:27:50] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3823661 (10Petar.petkovic) This is actually what's supposed to happen, after this change bc3f4d1b1860. Legend becomes absolutely positioned when grouping results by page is e... [18:27:52] 10Research: Make HTML dumps available - https://phabricator.wikimedia.org/T182351#3821170 (10leila) [18:27:56] Reedy: lol [18:27:59] Reedy lmao [18:28:10] That would be actually rude :D [18:28:15] So far it hasn't eaten any of the random crap i have on my floor (that's not dirt), nor has it gotten stuck, so i'm impressed [18:29:02] (03CR) 10Catrope: [C: 04-1] RCLFilters: display target page as a title (031 comment) [core] - 10https://gerrit.wikimedia.org/r/395866 (https://phabricator.wikimedia.org/T182164) (owner: 10Sbisson) [18:29:21] bawolff: isnt it a security risk i mean it could become self aware and take over your house [18:30:32] It's made by iRobot, but no where in the docs does it claim to be first law compliant [18:30:53] bawolff: I submitted the task. Hope you approve it soon [18:31:07] (03CR) 10Anomie: [C: 04-1] Add change_tag_statistics table to speed up tag hitcount retrieval (035 comments) [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [18:31:45] this task is fun [18:32:08] The most interesting thing for me about that robot is how powerful is it to clean effectively. The thing is that it is running on batteries... [18:32:43] Phantom42: approved [18:32:45] The most interesting thing for me about that robot is how powerful is it to clean effectively. The thing is that it is running on batteries... [18:32:45] Phantom42, does it have something like its charging place where it can charge itself by itself? [18:32:50] Phantom42 but it is smart enough to go autochargign ;) [18:32:55] *charging [18:33:12] Phantom42: that is true given how much power most vacumm cleaners take [18:33:17] bawolff: thank you! [18:33:58] Ah btw, does anyone had some issue with Travis CI recently? They are failing to build my app since yesterday :/ [18:34:00] The problem is not about the charging. I am wondering about how powerful is an engine used to create air flow. [18:34:24] Phantom42, I think it doesn't use air to suck it, it uses brushes I think [18:34:33] hi [18:35:53] (03CR) 10Anomie: [MCR] Break Revision into RevisionRecord and RevisionStore (031 comment) [core] - 10https://gerrit.wikimedia.org/r/374077 (https://phabricator.wikimedia.org/T174025) (owner: 10Daniel Kinzler) [18:35:53] divadsn: that could be a possible explanation. Then it is interesting how effective cleaning with brushes is. [18:40:13] (03PS5) 10Petar.petkovic: Remove live update feature flag [core] - 10https://gerrit.wikimedia.org/r/395530 [18:41:19] (03PS1) 10Jdlrobson: POC: Package page objects into a library [core] - 10https://gerrit.wikimedia.org/r/396440 [18:41:23] (03PS1) 10Jdlrobson: POC: Use mediawiki-selenium-pageobjects [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/396441 [18:43:28] (03CR) 10Anomie: ApiFeedWatchlist: Use guessSectionNameFromWikiText() [core] - 10https://gerrit.wikimedia.org/r/392989 (owner: 10Catrope) [18:43:31] (03CR) 10Anomie: [C: 032] ApiFeedWatchlist: Use guessSectionNameFromWikiText() [core] - 10https://gerrit.wikimedia.org/r/392989 (owner: 10Catrope) [18:45:21] (03CR) 10Anomie: [C: 032] "This should be good now." [core] - 10https://gerrit.wikimedia.org/r/392988 (owner: 10Catrope) [18:45:32] (03CR) 10jerkins-bot: [V: 04-1] POC: Use mediawiki-selenium-pageobjects [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/396441 (owner: 10Jdlrobson) [18:46:29] (03CR) 10Umherirrender: "When looking at the Response.php of Elastica (found in Elastica extensions vendor folder) the array is created from JSON::parse, but when " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395883 (https://phabricator.wikimedia.org/T161283) (owner: 10Umherirrender) [18:46:39] (03PS2) 10Jdlrobson: POC: Package page objects into a library [core] - 10https://gerrit.wikimedia.org/r/396440 [18:49:26] bawolff: I liked working with you, so I claimed one more task mentored by you! I don't have any questions right now. I will contact you in case I have some progress reports or questions. [18:49:36] Cool, cool [18:50:38] (03Merged) 10jenkins-bot: ApiFeedWatchlist: Use guessSectionNameFromWikiText() [core] - 10https://gerrit.wikimedia.org/r/392989 (owner: 10Catrope) [18:51:12] Phantom42 you lucky ^^ [18:51:49] I still have free time and I guess I won't see any feedback from my mentor, as in his timezone it's now 12am 9th December [18:52:13] wew [18:52:28] divadsn: I'm going to retest your patch as soon as i finish fixing GPL headers on my plugin [18:53:07] bawolff, cool, I don't know how thankful I should be, I mean you don't have to ^^" [18:53:09] * andre__ nevers knows what "12am" is. Noon and not midnight? [18:53:20] midnight [18:53:26] noon is 12pm [18:53:28] andre__, it's after 00:00 in German, so after midnight :) [18:53:38] (03CR) 10jerkins-bot: [V: 04-1] POC: Package page objects into a library [core] - 10https://gerrit.wikimedia.org/r/396440 (owner: 10Jdlrobson) [18:53:39] andre__: Time is stupid and none of it makes logical sense :P [18:53:48] divadsn: It happens sometimes. Both in this year GCI and in previous one I had to wait couple of days for my task to be reviewed. So it is normal I guess [18:53:50] Timezones are stupid too :P [18:53:54] heh [18:53:57] bawolff, +1000 :) [18:54:01] haha [18:54:02] Timezones are extra stupid [18:54:08] and frustrating [18:54:11] ya [18:54:20] bawolff, +>9000 ^^ [18:54:29] Having everyone wake up at a different hour of the day would be so much easier then having to convert times all over the place [18:54:37] (03PS2) 10Legoktm: Fix PageContentSaveComplete hook WikiPage typehint [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/396346 (owner: 10Addshore) [18:54:40] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete hook WikiPage typehint [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/396346 (owner: 10Addshore) [18:54:45] Who really cares if you wake up at 8 am or 3pm [18:55:00] addshore: your commit messages aren't even proper sentences >.> [18:55:04] true bawolff [18:55:12] The worst thing about time is that night owls like me have to wake up early as other people. That reduces productivity :( [18:55:38] same here phantom [18:55:41] Phantom42, I overslept yesterday because of that xD [18:55:53] Was working until 4 am and had to wake up at 6 am, ups ^^ [18:55:58] Well get a remote job and you won't have that problem. But then you'll have the problem of starting your work day at 4 am in the morning like i did the other day [18:56:01] :P [18:56:12] Luckily no one notices my abscence :P [18:56:22] bawolff, not possible at highschool ;P [18:56:26] Working from home requires... you to know yourself and how to deal with yourself. Yeah. :) [18:56:37] late night studies [18:57:05] ...or studies without any sleep. also happened in university times sometimes... [18:57:20] andre__: yeah, umm. I'm still working on the know thyself bit :) [18:57:26] heh [18:57:28] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete hook WikiPage typehint [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/396346 (owner: 10Addshore) [18:57:52] preparing for college enterance and high school exams is difficult [19:00:34] hi [19:00:38] unicorn2000, what age are you that you have final exams? I have mine next year when I'm 19 [19:00:55] i am 17 [19:01:20] (03CR) 10EBernhardson: [C: 032] Port update_general_api.feature to nodejs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/393694 (owner: 10EBernhardson) [19:01:24] this is my last year in high school [19:02:27] (03CR) 10jenkins-bot: ApiFeedWatchlist: Use guessSectionNameFromWikiText() [core] - 10https://gerrit.wikimedia.org/r/392989 (owner: 10Catrope) [19:02:31] Wow :O [19:02:37] I have my final exams this spring. divadsn, how many years is it left to study for you? [19:02:44] 1 year ^^ [19:02:57] I'm currently in my second year of highschool [19:03:09] And final exams are in the third last year [19:03:13] legoktm: they make sense :p [19:03:23] (03PS1) 10Brian Wolff: Add GPL license headers [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396442 [19:03:41] * divadsn is happy because andre__ thanked for my GCI wiki page edit, yay ^-^ [19:03:42] (03PS2) 10EBernhardson: Port dump_action.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396432 (owner: 10DCausse) [19:04:09] divadsn: Hm. That's interesting. Pretty different from what we have in Ukraine [19:05:09] Phantom42, In Germany you have 6 years primary school and 6 years secondary school, and you can finish education after 10 years when you passed the average education exams (MSA) [19:05:24] wow [19:05:30] 10Design-Research, 10New-Editor-Experiences: Plan concept evaluation workshop [epic] - https://phabricator.wikimedia.org/T179049#3711612 (10aripstra) [19:05:54] In Poland the old system has 6 years of primary school, 3 years secondary and 3 years high school and you must go to school until your 18th birthday [19:06:11] addshore: except for the ones where you put the wrong hook name in the commit message :< [19:06:28] (03PS3) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/396353 (owner: 10Addshore) [19:06:29] divadsn: And the new system? [19:06:35] in india 8years in primary education , 3 years middle school and 4 years in high schol [19:06:35] The new system tho has 8 years of primary and 4 years of secondary afaik, but I'm not affected by the changed system :D [19:06:41] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/396353 (owner: 10Addshore) [19:07:16] legoktm: ahh yes, lacking Complete? [19:07:20] divadsn: that's what I had when i went to school [19:07:22] (03PS3) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396355 (owner: 10Addshore) [19:07:25] I actually didn't realise until after :p [19:07:26] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396355 (owner: 10Addshore) [19:07:28] addshore: yeah [19:07:33] Anyway, wmde Christmas mean now ;) [19:07:39] (03PS4) 10Umherirrender: Check if $responseData['responses'] is set before use [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395883 (https://phabricator.wikimedia.org/T161283) [19:07:42] (03PS3) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396343 (owner: 10Addshore) [19:07:43] bawolff, where are you from? [19:07:46] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396343 (owner: 10Addshore) [19:07:46] They are all for the MCR work btw :) [19:07:50] we had kindergarten, then grade 1-8 as elementary, and then 9-12 high school [19:07:55] divadsn: Canada [19:07:57] divadsn: In Ukraine school is 11 years totally (it isn't really divided into primary/secondary/high) [19:07:59] its sometimes feels like i spent all my childhood in school [19:08:08] but it depends a lot on region [19:08:11] (03PS2) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/396375 (owner: 10Addshore) [19:08:14] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/396375 (owner: 10Addshore) [19:08:16] (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/396440 (owner: 10Jdlrobson) [19:08:16] Oh nice :) I know a lot of great people from Canada :D [19:08:23] (03PS2) 10Jdlrobson: POC: Use mediawiki-selenium-pageobjects [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/396441 [19:08:28] quebec only goes grade 11, and ontario goes to grade 13, but not for most people or something [19:08:28] (03PS2) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/396376 (owner: 10Addshore) [19:08:31] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/396376 (owner: 10Addshore) [19:08:35] But now Ukraine is switching to 12 years too as far as I know (however, it doesn't affect me) [19:08:35] For example the lead developer of substratum theme engine Nicholas is from Canada ^^ [19:08:39] and lots of places split out a middle school [19:08:42] wow [19:09:15] i am aimimg for cyber law [19:09:18] (03PS2) 10Legoktm: Add PageContentSave WikiPage typehint [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/396379 (owner: 10Addshore) [19:09:19] bawolff, so you seem also to have it regulated by region like Germany with it's Bundesländer? [19:09:21] (03CR) 10Legoktm: [C: 032] Add PageContentSave WikiPage typehint [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/396379 (owner: 10Addshore) [19:09:58] (03PS2) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/396378 (owner: 10Addshore) [19:10:02] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/396378 (owner: 10Addshore) [19:10:17] (03PS2) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/396374 (owner: 10Addshore) [19:10:22] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/396374 (owner: 10Addshore) [19:10:24] divadsn: in canada they have a split between things that are federal gov, and things that are provinces, and education is entirely provinces, so each one can do whatever it feels like [19:10:38] 10MediaWiki-Maintenance-scripts, 10Easy, 10Google-Code-in-2017: [Clonable] Cast block start to int in maintenance SQL - https://phabricator.wikimedia.org/T182209#3823686 (10Phantom42) a:03Phantom42 This should be easy to change. I will work on it. [19:11:03] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 3 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823688 (10IKhitron) Hello. I'm glad it works. Bu... [19:12:23] (03Merged) 10jenkins-bot: Port update_general_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/393694 (owner: 10EBernhardson) [19:12:25] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/396353 (owner: 10Addshore) [19:12:31] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/396355 (owner: 10Addshore) [19:12:33] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/396343 (owner: 10Addshore) [19:12:35] bawolff, so same as Germany, that's why I moved out from Berlin ^^ [19:12:36] (03PS1) 10Reedy: Revert "objectcache: Make WANObjectCache interim caching not interfere with ChronologyProtector" [core] - 10https://gerrit.wikimedia.org/r/396443 (https://phabricator.wikimedia.org/T182322) [19:12:37] (03PS1) 10Reedy: Revert "Make ChronologyProtector actually use cpPosTime cookies" [core] - 10https://gerrit.wikimedia.org/r/396444 (https://phabricator.wikimedia.org/T182322) [19:12:43] Holy Reedy spam :D [19:12:52] divadsn: 2 commits? [19:13:04] But it was so fast :D [19:13:05] You should've been here when I had 12 commits to 4 different branches at once... [19:13:05] wewwew [19:13:07] You should have seen that time I did 15 ina row [19:13:19] I already seen some of yours more ;) [19:13:29] where gerrit refused to let me, because it appearently has a limit of 10 at once [19:13:43] Should maybe do a PR to thelounge with a feature to hide messages from certain users ^^ [19:14:16] thanks ...its 1am here ...bye guys...enjoyed here :) [19:14:41] unicorn2000: Good night! [19:14:51] (03PS2) 10Legoktm: Fix PageContentSaveComplete WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396369 (owner: 10Addshore) [19:14:54] (03CR) 10Legoktm: [C: 032] Fix PageContentSaveComplete WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396369 (owner: 10Addshore) [19:15:19] (03PS2) 10Legoktm: Add PageContentSave WikiPage typehint [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/396373 (owner: 10Addshore) [19:15:22] (03CR) 10Legoktm: [C: 032] Add PageContentSave WikiPage typehint [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/396373 (owner: 10Addshore) [19:15:41] addshore: I'll review the rest later I guess [19:15:56] 10MediaWiki-extensions-Linter, 10Parsoid, 10Parsoid-Web-API, 10Patch-For-Review, 10Services (watching): Correctly redirect in Parsoid /transform/wikitext/to/lint endpoint - https://phabricator.wikimedia.org/T169006#3823694 (10ssastry) Interesting, I didn't know about this 302/307 distinction .. it appear... [19:16:12] (03CR) 10Bartosz Dziewoński: [C: 032] "I don't know what caused the issues you had with backporting this (I see a couple abandoned attempts), but this looks correct. I'll force-" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [19:16:46] (03CR) 10Bartosz Dziewoński: "Manually cherry-picked to REL1_30 in https://gerrit.wikimedia.org/r/#/c/396431/" [core] - 10https://gerrit.wikimedia.org/r/389282 (https://phabricator.wikimedia.org/T178626) (owner: 10Bartosz Dziewoński) [19:17:50] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/396375 (owner: 10Addshore) [19:17:52] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/396376 (owner: 10Addshore) [19:17:53] (03Merged) 10jenkins-bot: Add PageContentSave WikiPage typehint [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/396379 (owner: 10Addshore) [19:18:13] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/396378 (owner: 10Addshore) [19:18:26] (03CR) 10Bartosz Dziewoński: "I've seen worse spam ;) The REL1_30 cherry-pick looks correct, I'm merging that." [core] - 10https://gerrit.wikimedia.org/r/396429 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [19:18:34] (03Abandoned) 10Bartosz Dziewoński: Revert #contentSub and #jump-to-nav margin changes [core] - 10https://gerrit.wikimedia.org/r/396429 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [19:19:18] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/396374 (owner: 10Addshore) [19:19:29] What was i doing. oh right divadsn's patch [19:19:46] 10Design, 10MediaWiki-Interface, 10MW-1.30-release, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), and 2 others: #jump-to-nav margin elimination caused the indentation between the subtitle and the article content to disappear - https://phabricator.wikimedia.org/T178626#3823697 (10Legoktm) [19:19:51] (03PS1) 10Reedy: Revert "objectcache: Make WANObjectCache interim caching not interfere with ChronologyProtector" [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396445 (https://phabricator.wikimedia.org/T182322) [19:19:53] (03PS1) 10Reedy: Revert "Make ChronologyProtector actually use cpPosTime cookies" [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396446 (https://phabricator.wikimedia.org/T182322) [19:20:12] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3814578 (10Etonkovidova) The issue happens in all skins when, as @Nirmos pointed out: > "Group changes by page in recent changes and watchlist" at Special:Preferences#mw-pref... [19:21:10] 10Design-Research, 10New-Editor-Experiences: Plan concept evaluation workshop - https://phabricator.wikimedia.org/T179049#3823702 (10aripstra) [19:21:13] (03PS1) 10Aaron Schulz: Disable cpPosTime injection to LBFactory in Setup.php for now [core] - 10https://gerrit.wikimedia.org/r/396447 (https://phabricator.wikimedia.org/T182322) [19:21:49] Reedy: that should do it [19:22:02] (03Merged) 10jenkins-bot: Fix PageContentSaveComplete WikiPage typehint [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/396369 (owner: 10Addshore) [19:22:04] (03Merged) 10jenkins-bot: Add PageContentSave WikiPage typehint [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/396373 (owner: 10Addshore) [19:22:09] AaronSchulz: will phpcs like it? :P [19:22:27] 04(no projects): Make qacct less NFS-intensive - https://phabricator.wikimedia.org/T182451#3823704 (10zhuyifei1999) [19:22:28] that is always the question lately [19:24:26] We should have a bot that automatically runs phcbf on changes [19:24:36] so instead of jenkins failing, it would just fix your patch [19:24:42] (03PS1) 10Legoktm: UserGifts: Fix ext.socialprofile.usergifts.js definition [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396448 [19:24:44] (03PS1) 10Legoktm: UserGifts: Remove duplicate DefaultUserOptions block [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396449 [19:24:46] (03CR) 10jerkins-bot: [V: 04-1] Revert #contentSub and #jump-to-nav margin changes [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [19:24:59] hmm, I guess I could just set up a pre commit hook locally... [19:26:34] divadsn: Are you still here? [19:26:59] Yes, I haven't closed my web IRC client :) [19:27:05] Your patch is working better now, but i still have no way to going to the other characters in the edittools bar [19:27:22] (03CR) 10Bartosz Dziewoński: [V: 032 C: 032] Revert #contentSub and #jump-to-nav margin changes [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [19:27:28] I can tab to the first entry, and hit enter to select that, but I have no way of going to the next entry in the list of characters to insert [19:27:29] Huh, have you pressed space when you selected the editTools? [19:27:37] bawolff: yeah, I've never seen a case where auto-fix would fail, though it's still good to convey what the correct style *is* somehow, rather than silent autofixing [19:28:11] (03CR) 10Bartosz Dziewoński: "(For future reference: this was a manual cherry-pick of https://gerrit.wikimedia.org/r/389282)" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [19:28:20] AaronSchulz: If we had a bot that uploads to gerrit, it would be obvious because people would wonder why a bot is changing their patch [19:28:40] Reedy: funny, I *think* I noticed that CP bug a while ago just staring at the code for unrelated reasons, then put it on my mental to-do list [19:28:59] If you press enter on a selected character then you should be "tabbed" out of the editTools and the character should be inserted into the text field [19:29:06] didn't think about it in terms of the cookie change though [19:29:22] (03CR) 10EBernhardson: [C: 032] Port dump_action.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396432 (owner: 10DCausse) [19:29:23] divadsn: Yes, that happens, I just can't chose which character to select [19:29:29] it only lets me chose the first choice [19:30:20] So you say Firefox ESR? [19:30:23] Lemme start a VM [19:30:32] I tested it also on safari, and i got the same behaviour [19:31:03] Oh, Vagrant is showing the VM in Virtualbox? https://imgur.com/a/fdaHf [19:31:05] Hmm, testing on google chrome - it does work fine on google chrome [19:31:39] (03CR) 10Catrope: [C: 04-1] [EXPERIMENTAL] Using OOUI lazy-load for rudamentary reply (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/395664 (owner: 10Mooeypoo) [19:33:08] andre__, do you know maybe how can I access the devwiki from another VM or from my local network? [19:33:51] 10TechCom-RfC: Lack of freeform external access to MediaWiki data is a limitation - https://phabricator.wikimedia.org/T181257#3784413 (10Tgr) IMO this is way too vague to be useful for an RfC discussion. Things that I would like to see in such a proposal: * Use cases. It seems like any positive outcome of this R... [19:35:06] 10MediaWiki-Search, 10Discovery, 10Discovery-Search: Can't search for keywords beginning with a # - https://phabricator.wikimedia.org/T182452#3823726 (10EddieGP) [19:35:14] divadsn, no idea, sorry :( [19:35:39] 10MediaWiki-Search, 10Discovery, 10Discovery-Search: Can't search for keywords beginning with a # - https://phabricator.wikimedia.org/T182452#3823736 (10EddieGP) [19:35:41] divadsn: Depends on your network settings [19:35:44] No problem, I found out how, just changed the network adapter to NAT and got the gateway IP from ipconfig :) [19:35:57] (03CR) 10Umherirrender: [V: 032 C: 032] Archive SwiftCloudFiles extension [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/396302 (https://phabricator.wikimedia.org/T182384) (owner: 10Reception123) [19:36:43] (03PS1) 10Phantom42: Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) [19:36:46] Sometimes a try and fail method works better than google :D [19:36:57] (03PS1) 10Aaron Schulz: Disable cpPosTime injection to LBFactory in Setup.php for now [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396451 (https://phabricator.wikimedia.org/T182322) [19:37:55] divadsn: I'm going to guess that the problem comes down to, some browsers do not support dynamically re-ordering tab index in javascript [19:38:26] wait, I fired up Firefox ESR on Windows 7 now :) [19:38:40] 10Design-Research, 10New-Readers: Plan activities for new readers offsite (for annual planning) - https://phabricator.wikimedia.org/T182454#3823758 (10aripstra) [19:38:45] but my PC is a bit of struggling now, even tho I have 6 gb of RAM free [19:38:50] (03PS3) 10Jdlrobson: QA: Add additional steps to guard against slow test runs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/396287 (https://phabricator.wikimedia.org/T182202) [19:39:31] 10Design-Research: organize meeting for design researchers - https://phabricator.wikimedia.org/T181083#3823770 (10aripstra) [19:39:32] (03Merged) 10jenkins-bot: Port dump_action.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396432 (owner: 10DCausse) [19:39:39] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3823771 (10Reception123) [19:39:44] divadsn: https://www.alexlande.com/articles/cross-browser-tabindex-woes/ [19:39:52] (03Draft2) 10Umherirrender: Remove SwiftCloudFiles [extensions] - 10https://gerrit.wikimedia.org/r/396452 (https://phabricator.wikimedia.org/T182384) [19:39:59] (03CR) 10Umherirrender: [V: 032 C: 032] Remove SwiftCloudFiles [extensions] - 10https://gerrit.wikimedia.org/r/396452 (https://phabricator.wikimedia.org/T182384) (owner: 10Umherirrender) [19:40:02] "Firefox works similarly, with the exception that on OS X a elements aren’t tab-accessible by default, with or without tabindex" [19:40:21] Looks quite promising, lemme test: https://imgur.com/a/1eXeF [19:40:45] Works on my VM :/ [19:40:53] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3823773 (10Reception123) [19:41:00] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Browser-Support-Opera, 10Patch-For-Review: Stop serving SVG images to Opera 12 - https://phabricator.wikimedia.org/T87504#992963 (10Isarra) Since this being gone means I can't use oldopera for css editing anymore, does anyone know o... [19:41:02] Oh, so it's a issue with the OS, bawolff? [19:41:07] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3823777 (10Umherirrender) [19:41:12] divadsn: Maybe [19:42:34] 10MediaWiki-extensions-Other, 10Patch-For-Review: Convert SubpageFun to use extension registration - https://phabricator.wikimedia.org/T174663#3823778 (10Reception123) a:05Reception123>03None [19:42:39] 10MediaWiki-extensions-Other, 10Patch-For-Review: Convert SimpleChanges to use extension registration - https://phabricator.wikimedia.org/T174661#3823779 (10Reception123) a:05Reception123>03None [19:42:47] divadsn: So we could change to use , or we could say mac's can suck it [19:43:07] 10MediaWiki-File-management, 10DBA, 10Multimedia, 10Schema-change: Drop fj_new_sha1 field - https://phabricator.wikimedia.org/T51195#3823782 (10Ramsey-WMF) [19:43:11] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-MultiUpload, 10MediaWiki-extensions-NewUserNotif, 10MediaWiki-extensions-Other, and 19 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#3823781 (10Umherirrender) [19:43:20] Rather the other things, but both things aren't related with my patch actually, so I could raise the bug on Phabricator :) [19:43:20] 10MediaWiki-File-management, 10DBA, 10Schema-change: Drop fj_new_sha1 field - https://phabricator.wikimedia.org/T51195#3823784 (10Ramsey-WMF) [19:43:28] 10Design-Research: organize meeting for design researchers - https://phabricator.wikimedia.org/T181083#3823785 (10aripstra) @CSindersWMF Yes! January.. I fixed that mistake in the description of the task. Here are a few ideas for what to do in that time... I will send out an email today or Monday: Possible t... [19:43:34] I don't have a Macbook to test it out sadly :( [19:43:52] divadsn: Given that no other links are tabfocusable on mac, I think telling mac to suck it is a reasonable option [19:44:07] Pressing option+tab seems to work on safari, but not on firefox [19:45:29] Ok, here is the proof of working, bawolff: https://streamable.com/vg8id [19:45:54] Don't mind the Enpass window in the end, the keybase password isn't visible ^^ [19:46:08] (03PS2) 10Phantom42: Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) [19:46:40] I am leaving now the final verdict to you and the organizators :) [19:47:03] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 3 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823788 (10Aklapper) Please always provide specif... [19:47:35] I'm inclined to accept this, although I would really like prtksxna's opinion [19:47:43] Or at least a front-end dev's opinion [19:48:22] (03PS3) 10Phantom42: Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) [19:49:31] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 3 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823790 (10IKhitron) Yes, it is. Why do you need... [19:49:41] (03CR) 10Jdlrobson: [C: 04-1] Clarify documentation of pithumbsize parameter (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [19:49:59] (03CR) 10Jdlrobson: [C: 04-1] Clarify documentation of pithumbsize parameter [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [19:51:01] bawolff, I know, but I also don't want to ping other mentors here :) [19:51:05] (03CR) 10Mainframe98: [C: 031] "> > I actually found an unrelated bug" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/392081 (https://phabricator.wikimedia.org/T180818) (owner: 10MarcoAurelio) [19:52:16] MatmaRex has done a review of my patch, but he also seems to be not online here on IRC [19:53:56] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 3 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823791 (10Catrope) Hah, that class was removed c... [19:54:03] (03CR) 10Brian Wolff: [C: 031] "So it turns out I was confused, because Macs are weird and don't support tabbing on 's in general unless you enable something in your k" [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [19:55:06] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 3 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823794 (10IKhitron) >>! In T173614#3823791, @Cat... [19:56:42] (03CR) 10Aaron Schulz: [C: 032] Disable cpPosTime injection to LBFactory in Setup.php for now [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396451 (https://phabricator.wikimedia.org/T182322) (owner: 10Aaron Schulz) [19:57:12] (03CR) 10Legoktm: "recheck" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396035 (https://phabricator.wikimedia.org/T182245) (owner: 10Anomie) [19:57:20] (03PS1) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 [19:57:29] (03CR) 10Aaron Schulz: [C: 04-2] "I'll make a proper fix patch soon for master." [core] - 10https://gerrit.wikimedia.org/r/396447 (https://phabricator.wikimedia.org/T182322) (owner: 10Aaron Schulz) [19:58:21] 10MediaWiki-extensions-Other: Notice: Undefined offset: 1 in /vagrant/mediawiki/extensions/DeleteBatch/DeleteBatch.body.php on line 266 - https://phabricator.wikimedia.org/T182455#3823795 (10Mainframe98) [19:58:49] (03CR) 10Mainframe98: [C: 031] "See T182455" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/392081 (https://phabricator.wikimedia.org/T180818) (owner: 10MarcoAurelio) [19:59:07] 10MediaWiki-Cache: PHP memcached implementation stops working under HHVM - https://phabricator.wikimedia.org/T178242#3823806 (10Aklapper) so it this task still "high priority"? [19:59:34] (03Draft1) 10MarcoAurelio: Add .gitreview [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396456 [19:59:37] (03PS2) 10MarcoAurelio: Add .gitreview [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396456 [20:00:37] (03PS2) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 [20:01:06] (03CR) 10jerkins-bot: [V: 04-1] Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) (owner: 10Phantom42) [20:01:13] 10MediaWiki-Database, 10DBA, 10Tracking: Database replication lag issues (tracking) - https://phabricator.wikimedia.org/T3268#3823818 (10Aklapper) >>! In T3268#3799115, @Marostegui wrote: > Is there any point on keeping this open? It says tracking but the task is totally empty "empty" where? It has [[ https:... [20:01:28] 10TechCom-RfC: Lack of freeform external access to MediaWiki data is a limitation - https://phabricator.wikimedia.org/T181257#3784413 (10Bawolff) Allowing arbitrary complex queries does not seem appropriate as a mediawiki core interface. Most people won't want their site potentially DOSed. There are people who... [20:01:30] (03CR) 10jerkins-bot: [V: 04-1] QA: Add additional steps to guard against slow test runs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/396287 (https://phabricator.wikimedia.org/T182202) (owner: 10Jdlrobson) [20:01:48] (03PS1) 10Catrope: RCFilters: Add class back on "show new changes" link [core] - 10https://gerrit.wikimedia.org/r/396457 (https://phabricator.wikimedia.org/T173614) [20:02:01] (03PS1) 10Umherirrender: Empty moved extension [extensions/GitHub] - 10https://gerrit.wikimedia.org/r/396458 (https://phabricator.wikimedia.org/T182231) [20:02:33] (03CR) 10Umherirrender: [V: 032 C: 032] Empty moved extension [extensions/GitHub] - 10https://gerrit.wikimedia.org/r/396458 (https://phabricator.wikimedia.org/T182231) (owner: 10Umherirrender) [20:02:48] (03CR) 10jenkins-bot: Revert #contentSub and #jump-to-nav margin changes [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [20:03:11] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 4 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823830 (10Catrope) >>! In T173614#3823821, @gerr... [20:03:27] 10MediaWiki-extensions-Other: Notice: Undefined offset: 1 in /vagrant/mediawiki/extensions/DeleteBatch/DeleteBatch.body.php on line 266 - https://phabricator.wikimedia.org/T182455#3823831 (10MarcoAurelio) Yep, it seems to be the issue reported by @Zoranzoki21 on IRC a couple of days ago. Thanks for reporting! [20:03:42] (03CR) 10Jdlrobson: [C: 032] "This is definitely an improvement, but it's clear at some point in the future we should look at improving some of the documentation here." (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) (owner: 10Albert221) [20:03:56] 10Marvin: Add query parameter typing - https://phabricator.wikimedia.org/T178615#3823835 (10Niedzielski) a:03Niedzielski [20:04:01] (03PS4) 10Phantom42: Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) [20:04:39] 10MediaWiki-extensions-Other: Notice: Undefined offset: 1 in /vagrant/mediawiki/extensions/DeleteBatch/DeleteBatch.body.php on line 266 - https://phabricator.wikimedia.org/T182455#3823836 (10Mainframe98) This happens because of the ambiguity of https://translatewiki.net/wiki/MediaWiki:Deletebatch-help/en which d... [20:04:49] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: List of subscribers to a Newsletter is not presented logically - https://phabricator.wikimedia.org/T175895#3823837 (10Aklapper) 05Open>03Resolved a:03SimmeD >>! In T175895#3791725, @Q... [20:05:27] (03PS4) 10Jdlrobson: QA: Add additional steps to guard against slow test runs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/396287 (https://phabricator.wikimedia.org/T182202) [20:05:37] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 4 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3823841 (10IKhitron) >>! In T173614#3823830, @Cat... [20:06:32] (03PS5) 10Jdlrobson: QA: Add additional steps to guard against slow test runs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/396287 (https://phabricator.wikimedia.org/T182202) [20:06:36] (03Draft2) 10Umherirrender: Remove GitHub extension [extensions] - 10https://gerrit.wikimedia.org/r/396460 (https://phabricator.wikimedia.org/T182231) [20:06:40] (03CR) 10Umherirrender: [V: 032 C: 032] Remove GitHub extension [extensions] - 10https://gerrit.wikimedia.org/r/396460 (https://phabricator.wikimedia.org/T182231) (owner: 10Umherirrender) [20:07:35] (03PS3) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 [20:07:54] 10MediaWiki-extensions-Other: Notice: Undefined offset: 1 in /vagrant/mediawiki/extensions/DeleteBatch/DeleteBatch.body.php on line 266 - https://phabricator.wikimedia.org/T182455#3823844 (10Zoranzoki21) >>! In T182455#3823831, @MarcoAurelio wrote: > Yep, it seems to be the issue reported by @Zoranzoki21 on IRC... [20:08:18] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Continuous-Integration-Config, 10MW-1.30-release, and 2 others: mediawiki/core tests failing for REL1_30 due to Wikibase - https://phabricator.wikimedia.org/T182336#3823845 (10Legoktm) 05Open>03Resolved a:03Legoktm https://in... [20:10:02] (03Merged) 10jenkins-bot: Disable cpPosTime injection to LBFactory in Setup.php for now [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396451 (https://phabricator.wikimedia.org/T182322) (owner: 10Aaron Schulz) [20:10:03] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [BUG] Error stacks on Randomizer page after changing orientation - https://phabricator.wikimedia.org/T182457#3823851 (10cooltey) [20:10:41] (03PS1) 10Pppery: Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 [20:10:47] (03PS1) 10Niedzielski: Update: allow query parameters in URL [marvin] - 10https://gerrit.wikimedia.org/r/396463 (https://phabricator.wikimedia.org/T178617) [20:10:49] (03PS1) 10Niedzielski: Chore: add query parameter typing [marvin] - 10https://gerrit.wikimedia.org/r/396464 (https://phabricator.wikimedia.org/T178615) [20:10:50] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017, 10Patch-For-Review: Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579#3823864 (10Jdlrobson) [20:11:09] (03CR) 10Pppery: "Done in https://gerrit.wikimedia.org/r/#/c/396462/" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [20:11:45] (03Merged) 10jenkins-bot: Fix phpcs issues and remove its s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) (owner: 10Albert221) [20:12:21] (03PS1) 10Brian Wolff: Revert replacing textarea in Special:Undelete with OOUI [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396465 (https://phabricator.wikimedia.org/T182398) [20:13:17] (03PS4) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 [20:14:13] (03CR) 10MarcoAurelio: [C: 04-1] "Seems I messed with [] and {} on 'test'." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (owner: 10MarcoAurelio) [20:14:35] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017, 10Patch-For-Review: Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579#3823879 (10Jdlrobson) [20:14:51] 10Phabricator: Phabricator tag search seems to have regressed to prefix search - https://phabricator.wikimedia.org/T182458#3823881 (10Tgr) [20:14:53] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017, 10Patch-For-Review: Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579#3435683 (10Jdlrobson) [20:15:01] 10MobileFrontend, 10Readers-Web-Backlog, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in MobileFrontend - https://phabricator.wikimedia.org/T170579#3435683 (10Jdlrobson) a:05Albert221>03None @Aklapper you can re-import the remaining work as a new task now - I've updated the description. [20:15:36] (03CR) 10Jdlrobson: [C: 032] Clarify documentation of pithumbsize parameter [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [20:16:01] (03CR) 10Brian Wolff: [C: 032] Revert replacing textarea in Special:Undelete with OOUI [core] (wmf/1.31.0-wmf.11) - 10https://gerrit.wikimedia.org/r/396465 (https://phabricator.wikimedia.org/T182398) (owner: 10Brian Wolff) [20:16:20] 10Phabricator: Phabricator tag search seems to have regressed to prefix search - https://phabricator.wikimedia.org/T182458#3823898 (10Tgr) FWIW https://phabricator.wikimedia.org/project/query/ also gives poor results, but at least finds #mediawiki-api & co. [20:17:18] 10Android-app-feature-Compilations, 10Wikipedia-Android-App-Backlog, 10Easy: Display storage space and file size in appropriate units - https://phabricator.wikimedia.org/T177879#3823899 (10yashasvi) Hi @Dbrant , Sorry I missed this task earlier. Resumed it today and needed your help. The string that show... [20:17:25] bawolff: I am done with that cast variables task. Hope you can review it soon :) [20:17:28] (03CR) 10Jdlrobson: [C: 032] Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [20:17:40] yep, in a couple minutes [20:17:41] (03CR) 10MarcoAurelio: [C: 04-1] [WIP] build: update composer.json (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (owner: 10MarcoAurelio) [20:17:49] sorry, doing many things at once [20:18:23] 10MediaWiki-extensions-Score, 10Repository-Ownership-Requests: +2 for Ebe123 in mediawiki/extensions/Score - https://phabricator.wikimedia.org/T181904#3823900 (10Legoktm) 05Open>03Resolved a:03Legoktm Done! @Ebe123 please review https://www.mediawiki.org/wiki/Gerrit/%2B2 and congratulations :) [20:18:28] bawolff: It is okay. No rush here [20:18:48] btw, why did ChanServ quit? Some kind of maintenance? [20:19:20] 10MediaWiki-extensions-Linter, 10Parsing-Team, 10RESTBase-API, 10Services (blocked): Suggestion: API for fetching lint errors for a specific revision - https://phabricator.wikimedia.org/T164006#3823907 (10Arlolra) [20:19:24] 10MediaWiki-extensions-Linter, 10Parsoid, 10Parsoid-Web-API, 10Patch-For-Review, 10Services (watching): Correctly redirect in Parsoid /transform/wikitext/to/lint endpoint - https://phabricator.wikimedia.org/T169006#3823905 (10Arlolra) 05Open>03Resolved a:03Arlolra [20:20:03] (03CR) 10Brian Wolff: [C: 04-1] [WIP] build: update composer.json (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (owner: 10MarcoAurelio) [20:20:13] (03PS4) 10Sharvaniharan: Add DatePicker on on-this-day full screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) [20:20:14] Phantom42: yes [20:20:20] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog: Replace Sepia with Replayer - https://phabricator.wikimedia.org/T182459#3823908 (10bearND) [20:20:40] Phantom42: There was a global notice, they are moving it to a new server [20:20:41] Hm, that's interesting. Never seen anything like that before [20:20:57] (03CR) 10jerkins-bot: [V: 04-1] Add DatePicker on on-this-day full screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) (owner: 10Sharvaniharan) [20:21:09] 10MediaWiki-extensions-Score, 10Repository-Ownership-Requests: +2 for Ebe123 in mediawiki/extensions/Score - https://phabricator.wikimedia.org/T181904#3823920 (10Ebe123) Thank you! [20:21:22] Oh, yes. Looks like I missed that global notice. Now everything is clear [20:21:26] (03PS2) 10BearND: WIP: Dev: Replace Sepia with Replayer [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396428 (https://phabricator.wikimedia.org/T182459) [20:21:36] (03CR) 10jenkins-bot: Fix phpcs issues and remove its s [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) (owner: 10Albert221) [20:22:15] 04(no projects): [BUG] Unable to click the "Add to reading lists" button after changing orientation - https://phabricator.wikimedia.org/T182460#3823924 (10cooltey) [20:22:30] 10MediaWiki-extensions-SwiftCloudFiles, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive extension/SwiftCloudFiles - https://phabricator.wikimedia.org/T182384#3823933 (10Umherirrender) [20:22:32] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [BUG] Unable to click the "Add to reading lists" button after changing orientation - https://phabricator.wikimedia.org/T182460#3823934 (10cooltey) [20:23:02] Oops, I just noticed that T182209 was cloneable. But I modified all files mentioned in the task... [20:23:02] T182209: [Clonable] Cast block start to int in maintenance SQL - https://phabricator.wikimedia.org/T182209 [20:23:15] Phantom42: no worries [20:23:22] (03Merged) 10jenkins-bot: Clarify documentation of pithumbsize parameter [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396293 (https://phabricator.wikimedia.org/T178910) (owner: 10Pppery) [20:23:24] (03CR) 10jerkins-bot: [V: 04-1] Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [20:23:25] Just means i have to come up with more tasks :) [20:23:42] 10Mobile-Content-Service, 10Reading-Infrastructure-Team-Backlog, 10Patch-For-Review: Replace Sepia with Replayer - https://phabricator.wikimedia.org/T182459#3823950 (10bearND) Here's the WIP patch^. As you can see in the CI output: looks like all the tests making network requests fail now. This did not happ... [20:23:45] (03CR) 10jerkins-bot: [V: 04-1] WIP: Dev: Replace Sepia with Replayer [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396428 (https://phabricator.wikimedia.org/T182459) (owner: 10BearND) [20:24:18] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10wikimedia-page-library, 10Patch-For-Review: Image widening isn't working 100% correctly - https://phabricator.wikimedia.org/T163738#3823963 (10Mholloway) 05Open>03Resolved Image widening is fixed for RESTBase-loaded pages. Certain images still are... [20:24:34] Okay. More tasks would be great :) [20:24:51] (03PS2) 10Pppery: Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 [20:25:11] (03CR) 10Pppery: "Rebased, not exactly sure why these conflicted with eachother" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [20:25:30] (03CR) 10Huji: [C: 031] PageContentSave WikiPage typehint [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/396326 (owner: 10Addshore) [20:28:56] 10MediaWiki-General-or-Unknown: Shell\Command should support providing standard input - https://phabricator.wikimedia.org/T182463#3823970 (10Legoktm) [20:29:12] (03CR) 10Sbisson: [C: 032] RCFilters: Add class back on "show new changes" link [core] - 10https://gerrit.wikimedia.org/r/396457 (https://phabricator.wikimedia.org/T173614) (owner: 10Catrope) [20:29:52] (03PS5) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 [20:33:57] (03CR) 10Brian Wolff: [C: 032] Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) (owner: 10Phantom42) [20:34:59] 10MediaWiki-extensions-Other: Notice: Undefined offset: 1 in /vagrant/mediawiki/extensions/DeleteBatch/DeleteBatch.body.php on line 266 - https://phabricator.wikimedia.org/T182455#3823982 (10MarcoAurelio) Omitting the pipe looks good to me. After all we can already delete pages w/o putting a reason. [20:35:00] (03Merged) 10jenkins-bot: RCFilters: Add class back on "show new changes" link [core] - 10https://gerrit.wikimedia.org/r/396457 (https://phabricator.wikimedia.org/T173614) (owner: 10Catrope) [20:35:46] 04(no projects): ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3823985 (10FiZie) [20:36:14] 10MediaWiki-Maintenance-scripts, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: [Clonable] Cast block start to int in maintenance SQL - https://phabricator.wikimedia.org/T182209#3823987 (10Bawolff) 05Open>03Resolved [20:36:38] (03CR) 10Kghbln: "Thanks a ton! The issue is that I have no clue on how to do a patch set against a certain branch. Checking out a branch from master an bra" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [20:36:55] 04(no projects): Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3823988 (10FiZie) a:05Ejegg>03None [20:36:58] Phantom42: Awesome. Approved [20:37:19] 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 10Contributors-Team, 10VisualEditor, and 4 others: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3100391 (10Jdlrobson) "It's a pain to cope with and totally inelegant." Could... [20:37:31] 04(no projects): Itzulpenen kudeaketa - https://phabricator.wikimedia.org/T176658#3823995 (10FiZie) a:05Theklan>03None [20:38:01] 04(no projects): Jenkins isn't showing mediawiki-core-php70-phan-docker failure output - https://phabricator.wikimedia.org/T180630#3824002 (10FiZie) [20:38:18] (03PS6) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 [20:38:21] 04(no projects): ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3824004 (10FiZie) 05Open>03declined [20:38:33] 10PageImages, 10Readers-Web-Backlog, 10Documentation, 10Easy, and 2 others: Improve documentation of pithumbsize in MediaWiki's PageImages extension - https://phabricator.wikimedia.org/T178910#3824005 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson [20:38:35] bawolff: Thank you! You know the funny thing? I just claimed one more task mentored by you :) This time however I see that it is cloneable, so no more mistakes like in previous task. [20:38:37] 04(no projects): Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3346054 (10FiZie) 05Open>03declined [20:38:47] 04(no projects): Itzulpenen kudeaketa - https://phabricator.wikimedia.org/T176658#3632905 (10FiZie) 05Open>03declined [20:39:08] Just blocked them [20:39:13] (03CR) 10Jdlrobson: [C: 032] Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [20:40:11] (03CR) 10Brian Wolff: [V: 032 C: 032] Add .gitreview [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396456 (owner: 10MarcoAurelio) [20:40:17] 10Wikimedia-User-Group-Basque: Itzulpenen kudeaketa - https://phabricator.wikimedia.org/T176658#3824011 (10Reedy) 05declined>03Open a:03Theklan [20:40:30] 10Wikimedia-User-Group-Basque: Itzulpenen kudeaketa - https://phabricator.wikimedia.org/T176658#3632905 (10Reedy) [20:41:11] (03PS2) 10Niedzielski: Chore: add query parameter typing [marvin] - 10https://gerrit.wikimedia.org/r/396464 (https://phabricator.wikimedia.org/T178615) [20:41:52] 04(no projects): Updater got stuck on large update - https://phabricator.wikimedia.org/T182464#3824023 (10Smalyshev) [20:42:51] (03Merged) 10jenkins-bot: Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) (owner: 10Phantom42) [20:42:55] (03CR) 10jerkins-bot: [V: 04-1] Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [20:43:28] 10Readers-Web-Backlog: Why are the Popups browser tests failing? - https://phabricator.wikimedia.org/T182465#3824042 (10Jdlrobson) [20:43:31] 10CirrusSearch, 10Discovery, 10Elasticsearch, 10Discovery-Search (Current work), 10Epic: [epic] Upgrade to elastic 5.5.x - https://phabricator.wikimedia.org/T174662#3824055 (10debt) [20:44:15] 10CirrusSearch, 10Discovery, 10Elasticsearch, 10Discovery-Search (Current work), 10Epic: [epic] Upgrade to elastic 5.5.x - https://phabricator.wikimedia.org/T174662#3569366 (10debt) [20:44:17] 10CirrusSearch, 10Discovery, 10Elasticsearch, 10Discovery-Search (Current work), 10Patch-For-Review: Upgrade logstash cluster to elastic 5.5.x - https://phabricator.wikimedia.org/T178412#3824057 (10debt) 05Open>03Resolved a:03debt [20:44:55] Phantom42: the wfMessage() rawParams() is actually a clonable task [20:44:57] (03CR) 10Jdlrobson: [C: 032] Enable mobileoptions module in desktop target [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/395601 (owner: 10Jdlrobson) [20:45:16] I have no idea how many such things are in MediaWiki core and extensions [20:45:39] Right now the requirement is just to fix one, but in retrospect, I think that was too low [20:46:15] So I am allowed to fix more than one? [20:46:22] 10CirrusSearch, 10Discovery, 10Elasticsearch, 10Discovery-Search (Current work), 10Epic: [epic] Upgrade to elastic 5.5.x - https://phabricator.wikimedia.org/T174662#3824063 (10debt) 05Open>03Resolved Great job, everyone — woohoo! :) [20:47:42] Phantom42: You can.. But unless we create another task, you can't get more credit for it [20:47:56] 10OOjs-UI: OOUI drop downs do not change selection on an arrow keypress unlike native browser widget - https://phabricator.wikimedia.org/T182429#3823038 (10matmarex) Depending on the browser, pressing Tab can either confirm or cancel the choice in a dropdown. I compared a bunch of Windows browsers' behaviors a f... [20:48:03] Usually, in these cases... We do like a fix 1, fix 3, fix 5, fix 10 [20:48:09] 10OOjs-UI: OOUI drop downs do not change selection on an arrow keypress unlike native browser widget - https://phabricator.wikimedia.org/T182429#3824072 (10matmarex) [20:48:12] 10OOjs-UI: OOjs UI: Tab character in dropdown boxes should pick the current selection (like Enter does) - https://phabricator.wikimedia.org/T53229#545892 (10matmarex) [20:48:19] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work), 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: forceSearchIndex.php hangs at the end of the process when running on large wikis - https://phabricator.wikimedia.org/T181716#3824076 (10debt) 05Open>03Re... [20:49:33] Last person who claimed an instance of that task fixed 4 instances [20:49:46] (03CR) 10Isarra: [C: 032] UserGifts: Fix ext.socialprofile.usergifts.js definition [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396448 (owner: 10Legoktm) [20:49:46] 10OOjs-UI: ToggleSwitchWidget should be compatible with forms - https://phabricator.wikimedia.org/T182466#3824079 (10Jdlrobson) p:05Triage>03Normal [20:50:04] 10Discovery, 10Wikimedia-Portals, 10Discovery-Portal-Sprint, 10I18n, 10Patch-For-Review: the logo on www.wikipedia.org is misaligned for RTL languages on very small devices - https://phabricator.wikimedia.org/T179273#3824090 (10debt) 05Open>03Resolved [20:50:49] (03CR) 10jenkins-bot: RCFilters: Add class back on "show new changes" link [core] - 10https://gerrit.wikimedia.org/r/396457 (https://phabricator.wikimedia.org/T173614) (owner: 10Catrope) [20:51:02] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Patch-For-Review, 10Performance, and 3 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3824092 (10Aklapper) [20:51:05] (03CR) 10Isarra: [C: 032] UserGifts: Remove duplicate DefaultUserOptions block [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396449 (owner: 10Legoktm) [20:51:13] (03PS1) 10EBernhardson: port update_non_existent_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396470 [20:51:14] (03PS1) 10EBernhardson: Port update_redirect_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396471 [20:51:16] (03PS1) 10EBernhardson: port update_redirect_loop.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396472 [20:51:32] (03Merged) 10jenkins-bot: Enable mobileoptions module in desktop target [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/395601 (owner: 10Jdlrobson) [20:51:34] (03Merged) 10jenkins-bot: UserGifts: Fix ext.socialprofile.usergifts.js definition [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396448 (owner: 10Legoktm) [20:53:45] bawolff: thanks for those details [20:53:53] (03Merged) 10jenkins-bot: UserGifts: Remove duplicate DefaultUserOptions block [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/396449 (owner: 10Legoktm) [20:54:04] Reedy: thank you too! [20:54:18] We can create some more though [20:54:30] (03CR) 10jenkins-bot: Enable mobileoptions module in desktop target [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/395601 (owner: 10Jdlrobson) [20:54:33] We can always add more bugs [20:54:35] (03PS9) 10Jdlrobson: Upgrade checkboxes to ToggleSwitches on options form [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/394634 (https://phabricator.wikimedia.org/T169807) [20:54:39] :D [20:54:45] I wonder if there are any examples in extensions [20:54:56] At the very least, I know of at least a couple still in mediawiki core [20:55:56] * bawolff goes gets lunch [20:56:49] (03PS4) 10Jdlrobson: Cookie must be set on server side [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396082 (https://phabricator.wikimedia.org/T169369) [20:56:52] (03PS10) 10Jdlrobson: Upgrade checkboxes to ToggleSwitches on options form [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/394634 (https://phabricator.wikimedia.org/T169807) [20:56:55] (03PS2) 10Jdlrobson: Promote expand all sections and fontchanger to stable [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396284 (https://phabricator.wikimedia.org/T169257) [20:56:56] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Chinese-Sites: [BUG] Wikidata description for the specific Chinese language variant should be shown - https://phabricator.wikimedia.org/T173842#3541702 (10cscott) Some of the problem here is that historically LanguageConverter does not specifically tag t... [20:57:51] 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanban-Board: Replace settings checkboxes to ToggleSwitches - https://phabricator.wikimedia.org/T169807#3824101 (10Jdlrobson) a:05Nirzar>03None After chatting with @nirzar today we agreed that we will go ahead with making the beta toggle save on th... [20:57:57] (03CR) 10Bartosz Dziewoński: [C: 032] Add tabindex to Special:Upload in mw-editTools [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [20:58:15] (03CR) 10jerkins-bot: [V: 04-1] port update_non_existent_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396470 (owner: 10EBernhardson) [20:58:38] (03CR) 10jerkins-bot: [V: 04-1] Port update_redirect_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396471 (owner: 10EBernhardson) [20:58:41] (03CR) 10jerkins-bot: [V: 04-1] port update_redirect_loop.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396472 (owner: 10EBernhardson) [20:59:54] (03CR) 10jenkins-bot: Cast block start to int in maintenace SQL [core] - 10https://gerrit.wikimedia.org/r/396450 (https://phabricator.wikimedia.org/T182209) (owner: 10Phantom42) [21:01:11] 10Support-and-Safety, 10Wikimedia-Site-requests: Disable 2FA for EVinente - https://phabricator.wikimedia.org/T182373#3824110 (10Jalexander) a:03Jalexander [21:02:12] 10Wikimedia-Language-setup, 10Wiki-Setup (Rename): Rename zh-yue -> yue - https://phabricator.wikimedia.org/T30441#335030 (10cscott) Pinging this topic again, since identification of language variants in RESTBase/Parsoid requires distinguishing zh-yue (interpreted as using language converter to convert zh cont... [21:02:42] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10MediaWiki-extensions-Score, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Convert Score binaries to use MediaWiki shell restrictions - https://phabricator.wikimedia.org/T181535#3824116 (10Legoktm) 05Open>03Resolve... [21:02:44] 10MediaWiki-General-or-Unknown, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Security-Team, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), 10Patch-For-Review: Support restricted execution of external commands (via firejail) - https://phabricator.wikimedia.org/T173370#3824118 (10Le... [21:03:17] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [BUG] Unable to click the "Add to reading lists" button after changing orientation - https://phabricator.wikimedia.org/T182460#3824119 (10cooltey) a:03cooltey [21:03:41] (03PS1) 10Legoktm: Drop symfony/process dependency, use Shell\Command instead [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 [21:03:43] (03PS1) 10Legoktm: Use shell restrictions to contain pygments [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396477 [21:04:46] (03PS7) 10Ebe123: Output SVG in scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/370209 (https://phabricator.wikimedia.org/T49578) [21:04:48] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review, and 4 others: ChronologyProtector breaks if two requests write different sets of databases - https://phabricator.wikimedia.org/T182322#3819976 (10Darwinius) Not sure if i... [21:06:15] (03CR) 10Framawiki: [C: 031] Replace {{NUMBEROFPAGES}} by {{NUMBEROFARTICLES}} in the search box text [skins/Timeless] - 10https://gerrit.wikimedia.org/r/395956 (https://phabricator.wikimedia.org/T176094) (owner: 10Eflyjason) [21:06:17] 10CirrusSearch, 10Discovery, 10Discovery-Search: Can't search for keywords beginning with a # - https://phabricator.wikimedia.org/T182452#3824123 (10Aklapper) [21:06:34] (03Merged) 10jenkins-bot: Add tabindex to Special:Upload in mw-editTools [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [21:07:44] (03CR) 10Bartosz Dziewoński: "I usually use Gerrit's "Cherry Pick" button. In this case, I would have cherry-picked https://gerrit.wikimedia.org/r/#/c/384129/ first, me" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [21:09:06] (03CR) 10Isarra: [C: 032] Replace {{NUMBEROFPAGES}} by {{NUMBEROFARTICLES}} in the search box text [skins/Timeless] - 10https://gerrit.wikimedia.org/r/395956 (https://phabricator.wikimedia.org/T176094) (owner: 10Eflyjason) [21:10:11] (03CR) 10Bartosz Dziewoński: "If doing this from terminal, I'd use the "low-level" command `git push origin HEAD:refs/for/REL1_30` instead of `git review` – see https:/" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [21:10:26] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10SyntaxHighlight: Use Shell\Command in SyntaxHighlight instead of symfony/process - https://phabricator.wikimedia.org/T182467#3824133 (10Legoktm) [21:11:08] 10SyntaxHighlight: Update for symfony/process deprecations - https://phabricator.wikimedia.org/T181771#3824150 (10Legoktm) a:03Legoktm I'm "fixing" this by getting rid of symfony/process. [21:12:09] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10SyntaxHighlight: Restrict pygments with firejail - https://phabricator.wikimedia.org/T182468#3824154 (10Legoktm) [21:12:16] (03Merged) 10jenkins-bot: Replace {{NUMBEROFPAGES}} by {{NUMBEROFARTICLES}} in the search box text [skins/Timeless] - 10https://gerrit.wikimedia.org/r/395956 (https://phabricator.wikimedia.org/T176094) (owner: 10Eflyjason) [21:12:19] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10SyntaxHighlight: Use Shell\Command in SyntaxHighlight instead of symfony/process - https://phabricator.wikimedia.org/T182467#3824168 (10Legoktm) [21:12:22] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10SyntaxHighlight: Restrict pygments with firejail - https://phabricator.wikimedia.org/T182468#3824167 (10Legoktm) [21:12:29] 10Accessibility, 10MediaWiki-General-or-Unknown, 10Tracking: Special pages and other forms with initial focus of input nowhere or no tab order/tabindex set (tracking) - https://phabricator.wikimedia.org/T45562#3824173 (10matmarex) [21:12:30] (03PS2) 10Legoktm: Drop symfony/process dependency, use Shell\Command instead [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) [21:12:31] 10Accessibility, 10MediaWiki-Interface, 10Google-Code-in-2017: Add tabindex to Special:Upload - https://phabricator.wikimedia.org/T25238#3824170 (10matmarex) 05Open>03Resolved I didn't sign up as a Google Code-in mentor this year, so I can't mark this as completed on the GCI site – probably @Aklapper can... [21:12:35] (03PS2) 10Legoktm: Use shell restrictions to contain pygments [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396477 (https://phabricator.wikimedia.org/T182468) [21:15:59] 10MediaWiki-SecurityCheckPlugin: Update composer.json and add tests for PHP7 - https://phabricator.wikimedia.org/T182469#3824185 (10MarcoAurelio) [21:16:15] (03PS7) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) [21:16:27] (03PS8) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) [21:17:34] (03CR) 10Reedy: [C: 04-1] "maintenance/updateCSS.php needs updating too as that uses symfony/process" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) (owner: 10Legoktm) [21:17:56] (03CR) 10Reedy: [C: 04-1] "and maintenance/updateLexerList.php" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) (owner: 10Legoktm) [21:18:10] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 4 others: Graduate Live Update out of beta - https://phabricator.wikimedia.org/T173614#3824199 (10IKhitron) I'll confirm here after the... [21:20:20] 10MediaWiki-Vendor, 10SyntaxHighlight, 10Patch-For-Review: Remove symfony/process - https://phabricator.wikimedia.org/T181771#3824202 (10Reedy) [21:20:35] (03PS1) 10Reedy: Remove symfony/process [vendor] - 10https://gerrit.wikimedia.org/r/396483 (https://phabricator.wikimedia.org/T181771) [21:20:56] (03CR) 10jenkins-bot: Add tabindex to Special:Upload in mw-editTools [core] - 10https://gerrit.wikimedia.org/r/395999 (https://phabricator.wikimedia.org/T25238) (owner: 10Divadsn) [21:21:25] (03PS8) 10Matěj Suchánek: Use HistoryPageAddLink hook to add a log link to history pages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:21:27] (03CR) 10Ebe123: "recheck" [extensions/Score] - 10https://gerrit.wikimedia.org/r/370209 (https://phabricator.wikimedia.org/T49578) (owner: 10Ebe123) [21:23:21] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3822995 (10matmarex) To clarify, this is about read-only text fields, not disabled text fields; and it affects single-line fields too. In Apex theme (MonoBook skin), the text is g... [21:23:35] 10MediaWiki-Vendor, 10SyntaxHighlight, 10Patch-For-Review: Remove symfony/process from SyntaxHighlight - https://phabricator.wikimedia.org/T181771#3824210 (10Reedy) [21:23:53] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3824212 (10Strainu) >>! In T182156#3823700, @Etonkovidova wrote: > Can you give specific links for ? >>And yet, it's been ignored in almost every RC update in the last year -... [21:23:56] (03PS1) 10Jdlrobson: POC: List everything that's in beta (feature management FTW) [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396485 (https://phabricator.wikimedia.org/T182362) [21:24:03] (03CR) 10Reedy: "Possibly needed for donationinterface?" [vendor] - 10https://gerrit.wikimedia.org/r/396483 (https://phabricator.wikimedia.org/T181771) (owner: 10Reedy) [21:24:05] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3824219 (10matmarex) [21:24:10] (03CR) 10jerkins-bot: [V: 04-1] POC: List everything that's in beta (feature management FTW) [extensions/MobileFrontend] (specialpages) - 10https://gerrit.wikimedia.org/r/396485 (https://phabricator.wikimedia.org/T182362) (owner: 10Jdlrobson) [21:24:22] 10MediaWiki-General-or-Unknown: Shell\Command should support providing standard input - https://phabricator.wikimedia.org/T182463#3824220 (10Tgr) (aside: should we have a #mediawiki-shell project in Phabricator?) [21:24:33] 10Accessibility, 10MediaWiki-Interface, 10Google-Code-in-2017: Add tabindex to Special:Upload - https://phabricator.wikimedia.org/T25238#284858 (10Volker_E) Good work @divadsn! [21:24:49] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10SyntaxHighlight, 10Patch-For-Review: Use Shell\Command in SyntaxHighlight instead of symfony/process - https://phabricator.wikimedia.org/T182467#3824224 (10Tgr) [21:26:01] (03CR) 10jerkins-bot: [V: 04-1] Output SVG in scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/370209 (https://phabricator.wikimedia.org/T49578) (owner: 10Ebe123) [21:26:10] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3824226 (10Jdlrobson) patch demonstrates my idea of how to approach this (cc @pmiazga @bmansurov and @phuedx). We'd need to allow other... [21:26:16] (03CR) 10Reedy: "Nope, ignore that. It's a require-dev dependancy for a dependancy of DonationInterface" [vendor] - 10https://gerrit.wikimedia.org/r/396483 (https://phabricator.wikimedia.org/T181771) (owner: 10Reedy) [21:26:53] (03PS11) 10Matěj Suchánek: HistoryAction: Implement HistoryPageAddLink hook for adding more links [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:26:59] (03CR) 10jerkins-bot: [V: 04-1] Use HistoryPageAddLink hook to add a log link to history pages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:27:31] ty Reedy :D [21:27:54] One less thing to ship around/upgrade etc [21:27:55] :) [21:28:32] 10MediaWiki-General-or-Unknown: Shell\Command should support providing standard input - https://phabricator.wikimedia.org/T182463#3824239 (10Legoktm) >>! In T182463#3824220, @Tgr wrote: > (aside: should we have a #mediawiki-shell project in Phabricator?) Yes please :) Also T182467 doesn't strictly depend upon... [21:29:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/396479 (owner: 10L10n-bot) [21:29:40] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review: Show unconfigurable settings in mobile beta - https://phabricator.wikimedia.org/T182362#3824241 (10Jdlrobson) @nirzar - just a thought. If something is in beta but is configurable we still want to list it, correct? Otherwis... [21:30:36] (03PS5) 10Sharvaniharan: Add DatePicker on on-this-day full screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) [21:31:08] (03PS8) 10Ebe123: Output SVG in scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/370209 (https://phabricator.wikimedia.org/T49578) [21:31:17] (03PS1) 10Tjones: Update Analysis Analysis Tools [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/396487 [21:35:31] (03PS3) 10Legoktm: Drop symfony/process dependency, use Shell\Command instead [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) [21:35:33] (03PS3) 10Legoktm: Use shell restrictions to contain pygments [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396477 (https://phabricator.wikimedia.org/T182468) [21:35:34] 10MediaWiki-SecurityCheckPlugin, 10Patch-For-Review: Update composer.json and add tests for PHP7 - https://phabricator.wikimedia.org/T182469#3824246 (10MarcoAurelio) [21:35:50] 10MediaWiki-SecurityCheckPlugin, 10Patch-For-Review: Update composer.json and add tests for PHP7 - https://phabricator.wikimedia.org/T182469#3824185 (10MarcoAurelio) p:05Triage>03Normal [21:36:08] (03CR) 10Matěj Suchánek: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:36:55] (03CR) 10jerkins-bot: [V: 04-1] Drop symfony/process dependency, use Shell\Command instead [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) (owner: 10Legoktm) [21:37:09] (03CR) 10jerkins-bot: [V: 04-1] Use shell restrictions to contain pygments [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396477 (https://phabricator.wikimedia.org/T182468) (owner: 10Legoktm) [21:37:23] 10MediaWiki-SecurityCheckPlugin, 10Security-Team, 10Patch-For-Review: Make jenkins run `composer test` (with php7) on mediawiki/tools/phan/SecurityCheckPlugin.git - https://phabricator.wikimedia.org/T182199#3824251 (10MarcoAurelio) [21:38:10] 10MediaWiki-SecurityCheckPlugin, 10Patch-For-Review: Update composer.json - https://phabricator.wikimedia.org/T182469#3824252 (10MarcoAurelio) [21:38:26] (03PS4) 10Legoktm: Drop symfony/process dependency, use Shell\Command instead [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396476 (https://phabricator.wikimedia.org/T182467) [21:38:28] (03PS4) 10Legoktm: Use shell restrictions to contain pygments [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/396477 (https://phabricator.wikimedia.org/T182468) [21:38:53] 10MediaWiki-SecurityCheckPlugin, 10Continuous-Integration-Config, 10Security-Team, 10Patch-For-Review: Make jenkins run composer test (with php7) on mediawiki/tools/phan/SecurityCheckPlugin.git - https://phabricator.wikimedia.org/T182199#3816354 (10MarcoAurelio) p:05Triage>03Normal [21:38:55] 10Accessibility, 10MediaWiki-Interface, 10Google-Code-in-2017: Add tabindex to Special:Upload - https://phabricator.wikimedia.org/T25238#3824257 (10divadsn) Thank you @matmarex for your review :) [21:38:59] 10MediaWiki-Recent-changes, 10Regression: RecentChanges legend overlaps actual RecentChanges - https://phabricator.wikimedia.org/T182156#3824258 (10Etonkovidova) Thx, @Strainu I will re-check those task and re-triage them if necessary. [21:39:54] andre__, if you have time, could you mark my task on GCI as done please? :) [21:40:02] https://phabricator.wikimedia.org/T25238 [21:40:08] (03PS3) 10Matěj Suchánek: Don't allow invalid IP ranges to be entered in ip_in_range() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/275544 (https://phabricator.wikimedia.org/T124117) (owner: 10Glaisher) [21:40:22] (03CR) 10jerkins-bot: [V: 04-1] Use HistoryPageAddLink hook to add a log link to history pages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:40:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396509 (owner: 10L10n-bot) [21:42:05] (03PS9) 10Matěj Suchánek: Use HistoryPageAddLink hook to add a log link to history pages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/120809 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:42:35] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Improve user experience for Random - https://phabricator.wikimedia.org/T158788#3824265 (10RHo) LGTM [21:43:52] (03PS2) 10Legoktm: Remove symfony/process [vendor] - 10https://gerrit.wikimedia.org/r/396483 (https://phabricator.wikimedia.org/T181771) (owner: 10Reedy) [21:44:17] (03CR) 10Matěj Suchánek: "> We should probably pass in a LinkRenderer to the hook as well." [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:46:08] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [Feature request] 'Black' mode on Android - https://phabricator.wikimedia.org/T173319#3824273 (10RHo) LGTM on Nexus 5 (6.0.1) Wikipedia 2.7.220-alpha-2017-12-08. | Theme changer in Settings {F11702720} | Feed {F... [21:48:04] 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10SyntaxHighlight, 10Patch-For-Review: Restrict pygments with firejail - https://phabricator.wikimedia.org/T182468#3824279 (10Legoktm) [21:52:27] 10Android-app-Bugs, 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Images reloading unexpected when scrolling off and on screen - https://phabricator.wikimedia.org/T182043#3824289 (10RHo) LGTM on Nexus 5 (6.0.1) Wikipedia v2... [21:55:24] 10Design, 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes: Improve the marking of changes when using Advanced recent changes - https://phabricator.wikimedia.org/T29436#3824293 (10Strainu) [21:55:28] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Tracking: Watchlist and recent changes usability issues (tracking) - https://phabricator.wikimedia.org/T53942#3824294 (10Strainu) [21:55:49] (03PS9) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) [21:57:34] (03PS1) 10Reedy: Update RELEASE-NOTES-1.30 for backports [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396531 [21:59:00] (03PS1) 10Reedy: Bump $wgVersion [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396532 [21:59:36] 10Android-app-feature-Compilations, 10Wikipedia-Android-App-Backlog, 10Easy: Display storage space and file size in appropriate units - https://phabricator.wikimedia.org/T177879#3824296 (10Dbrant) @yashasvi Sure, just make another string resource for the `MB` case: - add a new string resource to `strings.xm... [21:59:58] divadsn, done [22:00:20] Thank you :) [22:00:40] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Add on-this-day card to the feed. - https://phabricator.wikimedia.org/T175995#3824301 (10RHo) All items on [[ https://docs.google.com/document/d/1RTrLQ-IF1FgcwBe7C2OjdOJzjMsWn45q8OAC... [22:01:15] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Allow users to customize feed content - https://phabricator.wikimedia.org/T141397#3824306 (10Dbrant) [22:01:17] 10Android-app-Bugs, 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Images reloading unexpected when scrolling off and on screen - https://phabricator.wikimedia.org/T182043#3824304 (10Dbrant) 05Open>03Resolved a:03Dbrant [22:01:19] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Create app-wide onboarding screens introducing new users to the app and its features - https://phabricator.wikimedia.org/T181149#3824303 (10Dbrant) 05Open>03Resolved [22:01:22] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Update behavior of when 'Continue reading' cards are shown on the feed - https://phabricator.wikimedia.org/T180528#3824308 (10Dbrant) 05Open>03Resolved [22:01:25] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [BUG] Feed page cannot be updated by swiping down after changing the search language - https://phabricator.wikimedia.org/T180529#3824307 (10Dbrant) 05Open>03Resolved [22:01:26] 10Patch-For-Review, 10Reading Epics (Feed 2.0), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Add on-this-day card to the feed. - https://phabricator.wikimedia.org/T175995#3824309 (10Dbrant) 05Open>03Resolved [22:01:29] 10Android-app-feature-Feeds, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): Improve user experience for Random - https://phabricator.wikimedia.org/T158788#3824311 (10Dbrant) 05Open>03Resolved [22:01:31] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie): [Feature request] 'Black' mode on Android - https://phabricator.wikimedia.org/T173319#3824310 (10Dbrant) 05Open>03Resolved [22:03:01] (03PS1) 10Reedy: Move RELEASE-NOTES-1.30 into HISTORY [core] - 10https://gerrit.wikimedia.org/r/396534 [22:04:19] (03PS2) 10EBernhardson: port update_non_existent_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396470 [22:04:21] (03PS2) 10EBernhardson: Port update_redirect_api.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396471 [22:04:23] (03PS2) 10EBernhardson: port update_redirect_loop.feature to nodejs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/396472 [22:06:41] (03CR) 10Chad: [C: 032] Update RELEASE-NOTES-1.30 for backports [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396531 (owner: 10Reedy) [22:07:57] (03CR) 10Legoktm: [C: 032] Move RELEASE-NOTES-1.30 into HISTORY [core] - 10https://gerrit.wikimedia.org/r/396534 (owner: 10Reedy) [22:12:48] (03Merged) 10jenkins-bot: Update RELEASE-NOTES-1.30 for backports [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396531 (owner: 10Reedy) [22:13:52] (03CR) 10Chad: [C: 032] Bump $wgVersion [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396532 (owner: 10Reedy) [22:17:07] (03Merged) 10jenkins-bot: Move RELEASE-NOTES-1.30 into HISTORY [core] - 10https://gerrit.wikimedia.org/r/396534 (owner: 10Reedy) [22:18:46] 10Front-end-Standards-Group, 10MobileFrontend, 10Documentation, 10Readers-Web-Backlog (Tracking), 10Technical-Debt (RW-Tech-Debt): Replace jsduck in favor of a better maintained alternative - https://phabricator.wikimedia.org/T138401#3824333 (10cscott) Just ran into this for Parsoid -- we want to start u... [22:19:51] oh I produced by file deletion a Fatal exception error of type "Wikimedia\Rdbms\DBQueryError" on Commons [22:20:14] Perhelion: Did you get an error code? [22:20:19] Like a random mix of numbers and letters? [22:20:43] no only this string WisPIwpAADoAAHf0y50AAADA [22:20:47] Yeah, that one [22:21:09] it was the huge file Test.svg [22:21:28] (03Merged) 10jenkins-bot: Bump $wgVersion [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396532 (owner: 10Reedy) [22:23:34] 10MediaWiki-Page-deletion, 10Commons, 10Multimedia: Unable to delete file pages on commons: MWException/LocalFileLockError: "Could not acquire lock" - https://phabricator.wikimedia.org/T132921#2272585 (10Reedy) ``` 2017-12-08 22:16:19 [WisPIwpAADoAAHf0y50AAADA] mw1263 commonswiki 1.31.0-wmf.11 exception ERRO... [22:25:28] (03CR) 10MarcoAurelio: "check experimental" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) (owner: 10MarcoAurelio) [22:25:48] (03CR) 10jenkins-bot: Update RELEASE-NOTES-1.30 for backports [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396531 (owner: 10Reedy) [22:28:02] (03PS2) 10Mholloway: Stop suppressing RESTBase redirect handling when requesting HTML [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 [22:28:54] (03CR) 10MarcoAurelio: [WIP] build: update composer.json (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) (owner: 10MarcoAurelio) [22:29:38] (03PS3) 10Mholloway: Stop suppressing RESTBase redirect handling when requesting HTML [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 [22:31:07] (03CR) 10Ppchelko: [C: 031] "Since we've got a test now as far as I can see, it a +1 from our side" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 (owner: 10Mholloway) [22:34:22] (03CR) 10jenkins-bot: Move RELEASE-NOTES-1.30 into HISTORY [core] - 10https://gerrit.wikimedia.org/r/396534 (owner: 10Reedy) [22:35:13] 10ContentTranslation, 10Dumps-Generation, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)): Content translation dumps failing due to excessive memory usage - https://phabricator.wikimedia.org/T180264#3824353 (10Nikerabbit) 05Open>03Resolved [22:35:47] 10MediaWiki-General-or-Unknown, 10MediaWiki-Shell: Shell\Command should support providing standard input - https://phabricator.wikimedia.org/T182463#3824355 (10Tgr) [22:36:37] (03CR) 10Mholloway: "Yeah, it's kind of tough to test generally for something not happening, but there was a test in test/features/mobile-sections/shared.js ab" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 (owner: 10Mholloway) [22:37:47] (03PS6) 10Sharvaniharan: [WIP] Add DatePicker on on-this-day full screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) [22:38:24] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add DatePicker on on-this-day full screen [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/395808 (https://phabricator.wikimedia.org/T180372) (owner: 10Sharvaniharan) [22:39:53] 10Contributors-Analysis: Calculate monthly mobile Wikipedia edits for Major Gifts report [due Dec 6] - https://phabricator.wikimedia.org/T180541#3824359 (10Neil_P._Quinn_WMF) Another update: I'm through the infrastructure automation, and now I'm actually running the queries. I should be finished by the end of th... [22:42:59] (03CR) 10jenkins-bot: Bump $wgVersion [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396532 (owner: 10Reedy) [22:44:32] (03CR) 10Kghbln: "This does not come as a surprise to me now. :) Thanks for the tip which I did now note!" [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/396431 (https://phabricator.wikimedia.org/T178626) (owner: 10Kghbln) [22:50:13] (03PS10) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) [22:51:22] 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Continuous-Integration-Config, 10MW-1.30-release, and 2 others: mediawiki/core tests failing for REL1_30 due to Wikibase - https://phabricator.wikimedia.org/T182336#3824369 (10hashar) ``` lang=python use_wikidata = ('REL1_27',... [22:51:40] (03PS11) 10MarcoAurelio: [WIP] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) [22:54:52] (03PS12) 10MarcoAurelio: build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) [22:55:29] I'm trying to get going with gerrit. I've managed to submit two patches using git-review, but I'm not sure how to make them go live in my project. [22:55:31] (03CR) 10Brian Wolff: [V: 032 C: 032] build: update composer.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) (owner: 10MarcoAurelio) [22:56:14] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3822995 (10Volker_E) @Bawolff Just to clarify what is acceptance criteria here from your perspective? Having such treatment? | WikimediaUI | Apex | -- | -- | {F11705862 size=ful... [22:56:38] For example https://gerrit.wikimedia.org/r/#/c/396540/ has now been reviewed. Do I now push from my local machine? [22:59:28] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3824373 (10Volker_E) Also, the revert commit message mentions a completely different reason and I don't unterstand why it was accepted without clearer communication about what is... [23:01:43] (03Draft1) 10MarcoAurelio: Follow-up on Ie9106c80 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396543 [23:01:46] (03PS2) 10MarcoAurelio: Follow-up on Ie9106c80 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396543 [23:03:31] (03CR) 10MarcoAurelio: "FIXME: trailing comma on Line 26; follow-up patch uploaded at I5ed486ef." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396455 (https://phabricator.wikimedia.org/T182469) (owner: 10MarcoAurelio) [23:04:04] 10OOjs-UI: OOUI MultilineTextInputWidget textboxes are grey in Monobook but not in vector - https://phabricator.wikimedia.org/T182426#3824374 (10Bawolff) Note, that vito made the original complaint, so he might be a better person to ask for acceptance criteria. My issue was that the behaviour was rather inconsi... [23:06:05] (03CR) 10Brian Wolff: [V: 032 C: 032] Follow-up on Ie9106c80 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/396543 (owner: 10MarcoAurelio) [23:07:02] 10MediaWiki-SecurityCheckPlugin, 10Patch-For-Review, 10User-MarcoAurelio: Update composer.json - https://phabricator.wikimedia.org/T182469#3824376 (10MarcoAurelio) 05Open>03Resolved a:03MarcoAurelio [23:08:30] (03PS1) 10Mholloway: Hygiene: Fix lint errors [services/mobileapps] - 10https://gerrit.wikimedia.org/r/396544 [23:09:59] (03PS4) 10Mholloway: Stop suppressing RESTBase redirect handling when requesting HTML [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395893 [23:12:11] 10MediaWiki-SecurityCheckPlugin, 10Patch-For-Review, 10User-MarcoAurelio: Update composer.json - https://phabricator.wikimedia.org/T182469#3824382 (10MarcoAurelio) Not sure if this is my PC or there's indeed an error here but: ``` $ composer install Loading composer repositories with package information Upd... [23:16:26] 10MediaWiki-Configuration: Allow extension registration to suggest optional extension/skin or MediaWiki version - https://phabricator.wikimedia.org/T182472#3824383 (10Umherirrender) [23:19:19] bawolff, how can I give CR+1 on Gerrit? [23:19:48] My project has two patches; one reviewed, one not. How do I try to submit only the reviewed patch? [23:20:03] Or rather, to push only the reviewed one. [23:20:54] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 3 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824408 (10Kghbln) It will really be nice to get a fix for this into 1... [23:20:57] 10MediaWiki-Installer, 10Easy, 10Google-Code-in-2017: Remove references to deleted $this->debug in installer - https://phabricator.wikimedia.org/T182210#3824411 (10Albert221) a:03Albert221 [23:21:00] 10MediaWiki-SecurityCheckPlugin, 10Patch-For-Review, 10User-MarcoAurelio: Update composer.json - https://phabricator.wikimedia.org/T182469#3824185 (10Bawolff) Its your computer. The plugin only supports exactly php 7.0 (not php7.1). And it needs the ast extension which you may have to install separately. [23:21:42] Albert221: choose the Reply button [23:21:46] Albert221: theres a button where you leave a comment [23:21:58] there you will have an option to give it a +1 in addition of a comment [23:22:12] i dont know where it is in the old patch screen, im using new patch screen [23:22:18] huh, all I see is textarea and Post and Cancel buttons:/ [23:22:30] bawolff, how to use one? [23:23:08] (03CR) 10Hashar: [C: 031] "I have hit the test failure while building a Docker container to run tests into." [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396436 (owner: 10Mholloway) [23:23:11] Albert221: are you looking at the current version of the patch? You cant +1 old prefs [23:23:25] new patch screen is an option in preferences [23:23:39] yes, I wanted to +1 this: https://gerrit.wikimedia.org/r/#/c/396465/ [23:24:12] (03CR) 10BearND: [C: 032] Hygiene: Fix tests [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396436 (owner: 10Mholloway) [23:24:19] (03PS1) 10Aaron Schulz: [WIP] Replace cpPosTime cookie/parameter with cpPosIndex [core] - 10https://gerrit.wikimedia.org/r/396546 [23:24:23] Im not sure why you cant [23:24:41] (03CR) 10BearND: [C: 032] Hygiene: Remove NSP workaround for moment.js [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) (owner: 10Mholloway) [23:24:56] but dont worry too much, the wmf branch stuff doesnt go through normal review process [23:25:07] hm, okay [23:25:11] it will get +2 shortly before deploy [23:25:48] (03PS2) 10Aaron Schulz: [WIP] Replace cpPosTime cookie/parameter with cpPosIndex [core] - 10https://gerrit.wikimedia.org/r/396546 (https://phabricator.wikimedia.org/T182322) [23:26:30] bawolff, is T182210 really just about getting rid of the debug stuff just in this one place? https://i.imgur.com/s9xCSHl.png [23:26:30] T182210: Remove references to deleted $this->debug in installer - https://phabricator.wikimedia.org/T182210 [23:26:36] (03Merged) 10jenkins-bot: Hygiene: Fix tests [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396436 (owner: 10Mholloway) [23:26:40] I've claimed the task [23:26:47] slashme_wiki: as long as they dont depend on each other you should be able to just do it. If they depend on each other you have to rebase so they dont (use git rebase -i origin/master) [23:27:11] bawolff, they're independent (two different files). [23:27:19] Albert221: yeah its fairly straightforward [23:27:56] slashme_wiki: dependent in the sense of is one the parent of the other (e.g. when doing git log) [23:28:34] (03Merged) 10jenkins-bot: Hygiene: Remove NSP workaround for moment.js [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396433 (https://phabricator.wikimedia.org/T181445) (owner: 10Mholloway) [23:28:56] (03CR) 10Kaldari: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/391751 (https://phabricator.wikimedia.org/T178842) (owner: 10Dbarratt) [23:29:15] Ah, well yes, they're dependent on each other, but I want to push the first one only, because that's the one that has been reviewed. [23:29:45] Albert221: just some dead code that needs cleaning up. And its causing a false positive in securitycheckplugin because the exception isnt escaped [23:30:42] Could I then just do a soft reset to point my HEAD at the one that's already been reviewed; push; and then point HEAD back at the more recent one? [23:31:22] It doesnt matter where head is pointed [23:31:32] thats local [23:31:57] Err actually wait, i misunderstood [23:32:24] that might work, i dont remember what git reset --soft actually does [23:32:40] but i would reccomend git rebase -i [23:33:10] OK, and my second question is how I'm supposed to push approved changes: using git review or git push? [23:33:19] or you could do it from web interface - press rebase button and put master in the box [23:33:47] (03PS1) 10Albert221: Remove references to deleted $this->debug in installer [core] - 10https://gerrit.wikimedia.org/r/396547 (https://phabricator.wikimedia.org/T182210) [23:34:35] Neither - you are supposed to press +2 in gerrit web interface and either jenkins merges if tests are set up, or you press submit [23:34:46] (03PS3) 10Aaron Schulz: [WIP] Replace cpPosTime cookie/parameter with cpPosIndex [core] - 10https://gerrit.wikimedia.org/r/396546 (https://phabricator.wikimedia.org/T182322) [23:34:51] (03Merged) 10jenkins-bot: Prevent new users from being sent emails [core] - 10https://gerrit.wikimedia.org/r/391751 (https://phabricator.wikimedia.org/T178842) (owner: 10Dbarratt) [23:35:16] bawolff, easiest patch to review? :D [23:35:43] OK, thanks! [23:35:53] (03CR) 10Brian Wolff: [C: 032] Remove references to deleted $this->debug in installer [core] - 10https://gerrit.wikimedia.org/r/396547 (https://phabricator.wikimedia.org/T182210) (owner: 10Albert221) [23:36:32] 10MediaWiki-Installer, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Remove references to deleted $this->debug in installer - https://phabricator.wikimedia.org/T182210#3824429 (10Bawolff) 05Open>03Resolved [23:36:51] Guess we need to get some more challenging tasks :p [23:37:08] It was just right in terms of difficulty xD [23:38:48] Hmm, I don't have tests set up, and I don't see a "submit" button. Where is it normally? [23:38:54] BTW, is here, on IRC, outside the GCI contest that crowded? I mean if let's say I'd like to contribute to Wikimedia after GCI, will there be that many people to possibly help me? [23:39:57] slashme_wiki: only visible after you left a comment setting verified and code-review both to +2 [23:40:09] (03PS1) 10Divadsn: Replace instances of rawParams() to plaintextParams() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/396548 (https://phabricator.wikimedia.org/T180987) [23:40:57] (03CR) 10Mholloway: "The apps teams don't seem to feel strongly about this. I know for sure pageid is not used in the Android app." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/395161 (owner: 10Mholloway) [23:40:59] bawolff, is T182213 really only about replace rawParams to plaintextParams where the value is already escaped? [23:40:59] T182213: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213 [23:41:17] Albert221: not in this channel. Usually people are in other channels (e.g. #mediawiki). Also its usually much quieter on weekends. But on week days its still quite busy [23:41:38] getting code review will probably be slower outside of gci [23:42:15] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Browser-Support-Opera, 10Patch-For-Review: Stop serving SVG images to Opera 12 - https://phabricator.wikimedia.org/T87504#3824433 (10Isarra) Nevermind, I think I found a new browser. [23:43:08] divadsn: its about replacing it any time its possible to replace. Cases where its already escaped is one such case (probably not the most common) [23:43:22] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396549 [23:43:40] bawolff, OK, I think I did that: at the top it says "Change 396540 - Ready to Submit", but I still don't see a submit button. [23:43:44] Alright hope I have done it right in my patch :) [23:44:02] Have tested it and checked the output with diff, no difference in the end ^^ [23:44:07] (03CR) 10jenkins-bot: Prevent new users from being sent emails [core] - 10https://gerrit.wikimedia.org/r/391751 (https://phabricator.wikimedia.org/T178842) (owner: 10Dbarratt) [23:44:14] (03PS3) 10Pppery: Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 [23:44:28] (03Merged) 10jenkins-bot: Remove references to deleted $this->debug in installer [core] - 10https://gerrit.wikimedia.org/r/396547 (https://phabricator.wikimedia.org/T182210) (owner: 10Albert221) [23:44:37] Divadsn: the most common case is when using ->text() where no escaping takes place so rawParams is identical to plaintextParams [23:45:07] Alright, then I've understood the task description :D [23:45:34] * bawolff will be back inabout an hour [23:45:54] * divadsn winks bye bye to bawolff [23:46:27] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/396549 (owner: 10Hashar) [23:47:29] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 3 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824438 (10Reedy) Can you post the sql it's failing on now? As with th... [23:48:44] (03CR) 10Pppery: "Well, even though the deprecated methods didn't change the actual result, it turns out they were still used in the tests." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 (owner: 10Pppery) [23:49:55] (03PS15) 10Catrope: Add change_tag_statistics table to speed up tag hitcount retrieval [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [23:49:59] (03CR) 10Catrope: Add change_tag_statistics table to speed up tag hitcount retrieval (035 comments) [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [23:51:28] (03PS4) 10Pppery: Remove old string-based API description functions [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/396462 [23:51:59] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 3 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824440 (10Reedy) Or not, in 1.27/1.28... Why did the field alias disa... [23:52:52] (03PS13) 10Catrope: Remove editor switching infrastructure in favor of VE's source mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/392569 (https://phabricator.wikimedia.org/T155861) [23:52:55] (03PS5) 10Catrope: Respect "Always use VE" and "Always use source editor" preferences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/394405 (https://phabricator.wikimedia.org/T178719) [23:53:18] OK, I've got two patches in "ready to submit" status, and I'm the project owner, but I can't find a "submit" button in gerrit. [23:54:31] (03PS1) 10Reedy: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/396551 (https://phabricator.wikimedia.org/T160298) [23:55:40] (03CR) 10jenkins-bot: Remove references to deleted $this->debug in installer [core] - 10https://gerrit.wikimedia.org/r/396547 (https://phabricator.wikimedia.org/T182210) (owner: 10Albert221) [23:56:59] 10MediaWiki-Special-pages, 10MW-1.27-release, 10MW-1.27-release-notes, 10MW-1.28-release-notes, and 4 others: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3824448 (10Kghbln) That's the current situation. Have not checked whet...