[00:04:01] 10MediaWiki-extensions-LoginNotify, 10Beta-Cluster-Infrastructure, 10Community-Tech, 10Wikimedia-Site-requests: Clarify LoginNotify emails are from beta - https://phabricator.wikimedia.org/T181908#3806307 (10Reedy) [00:10:46] 10AbuseFilter, 10Social-Tools, 10SocialProfile: SocialProfile broken - error 500 - https://phabricator.wikimedia.org/T181586#3806308 (10SpookyGhost8) I disabled extensions MassMessage, VoteNY, Comments, BlogPage and now the internal server error went away...any idea why this came to be? Everything is fine now. [00:11:05] 10AbuseFilter, 10Social-Tools, 10SocialProfile: SocialProfile broken - error 500 - https://phabricator.wikimedia.org/T181586#3806309 (10Reedy) >>! In T181586#3806225, @Reedy wrote: > The problem looks to be related to using the database as a localisation cache. Nothing specific to AbuseFilter or SocialProfil... [00:13:13] (03CR) 10Reedy: [C: 04-1] Compatible with php7.2 (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [00:13:36] 10BetaFeatures, 10Easy, 10Patch-For-Review: [BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) in PHP 7.2 - https://phabricator.wikimedia.org/T181821#3806312 (10Reedy) Not a PHP 7.2 bug [00:13:55] 10BetaFeatures, 10Easy, 10Patch-For-Review: Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) - https://phabricator.wikimedia.org/T181821#3806319 (10Reedy) [00:15:20] 10MediaWiki-Codesniffer: Create sniff to detect NULL rather than null - https://phabricator.wikimedia.org/T181909#3806325 (10Reedy) [00:16:26] (03CR) 10Reedy: [C: 04-1] "And the bug is nothing to do with PHP 7.2" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [00:17:21] 10AbuseFilter, 10Social-Tools, 10SocialProfile: SocialProfile broken - error 500 - https://phabricator.wikimedia.org/T181586#3806338 (10SpookyGhost8) Ok i'll look into getting cache set up properly [00:17:28] 10AbuseFilter, 10Social-Tools, 10SocialProfile: SocialProfile broken - error 500 - https://phabricator.wikimedia.org/T181586#3806339 (10SpookyGhost8) 05Open>03Resolved a:03SpookyGhost8 [00:25:46] (03PS1) 10BryanDavis: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] - 10https://gerrit.wikimedia.org/r/394819 [00:26:59] (03PS2) 10BryanDavis: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] - 10https://gerrit.wikimedia.org/r/394819 [00:30:38] hello! [00:31:32] hey [00:32:06] (03PS3) 10BryanDavis: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] - 10https://gerrit.wikimedia.org/r/394819 (https://phabricator.wikimedia.org/T51652) [00:38:48] (03CR) 10Gergő Tisza: [C: 032] Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] - 10https://gerrit.wikimedia.org/r/394819 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [00:39:45] (03Merged) 10jenkins-bot: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] - 10https://gerrit.wikimedia.org/r/394819 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [00:40:59] (03CR) 10jenkins-bot: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] - 10https://gerrit.wikimedia.org/r/394819 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [00:42:39] 10Accessibility, 10Discovery, 10Wikidata, 10Wikidata Query UI: Ctrl+Enter should only work inside text editor, not on links - https://phabricator.wikimedia.org/T175976#3806376 (10Smalyshev) [00:43:53] 10InternetArchiveBot, 10Wiktionary: Wiktionary support - https://phabricator.wikimedia.org/T181879#3806380 (10jberkel) [00:49:13] Reedy, if I forgot to do my stuff on a seperate branch and I already pushed my patch to Gerrit, then by updating the topic on Gerrit am I achieving the same result in the end? [00:49:37] This is the derped example of me: https://gerrit.wikimedia.org/r/#/c/394820/1 [00:49:43] pretty much [00:49:53] you'll just have to reset head, rather than git checkout master locally [00:50:21] (03PS2) 10Gergő Tisza: Fix "Left match operand must result in a String value" in service::node [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394762 [00:51:28] ok, thanks, it's late here in Poland so I'm not so much focused ^^ [00:51:56] but working at night is for me more fun :D [00:57:13] there is nothing bad in pushing to master. I did it accidentally couple of times and there were no problems later - code was merged without any issues. Creating separate branch simplifies some things, but it is not critical if you forget to do so I guess. [00:59:18] Even from a feature branch, it's still pushing to master [01:00:06] just whether you've gotta do `git checkout master` or `git reset HEAD~1 --hard` instead [01:31:09] (03PS1) 10Haikalizz: extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) [01:36:11] 10Wiki-Loves-Monuments (2017): Wiki Loves Monuments blog upgrade - https://phabricator.wikimedia.org/T172068#3806432 (10LilyOfTheWest) [01:36:24] 10Wiki-Loves-Monuments (2017): Wiki Loves Monuments blog upgrade - https://phabricator.wikimedia.org/T172068#3484529 (10LilyOfTheWest) a:05LilyOfTheWest>03Slaporte [01:37:21] (03Abandoned) 10Sophivorus: Respond to Reedy's code review [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/393440 (https://phabricator.wikimedia.org/T149766) (owner: 10Sophivorus) [01:37:24] 10Wiki-Loves-Monuments (2017): Wiki Loves Monuments blog upgrade - https://phabricator.wikimedia.org/T172068#3484529 (10LilyOfTheWest) @PGiner thanks for all the work. Slaporte has picked this up since last weekend and working on the first version of the blog based on your desing recommendations. We have some co... [01:44:08] (03PS1) 10BryanDavis: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394823 (https://phabricator.wikimedia.org/T51652) [01:44:55] (03CR) 10BryanDavis: [C: 032] Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394823 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [01:45:28] (03Merged) 10jenkins-bot: Replace libmysqlclient-dev with default-libmysqlclient-dev [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394823 (https://phabricator.wikimedia.org/T51652) (owner: 10BryanDavis) [01:49:00] (03CR) 10Legoktm: [C: 04-1] "Did you take a look at the example I linked on the bug ticket? the dieWithError() function takes the name of a localisation message - you " [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [01:52:44] (03CR) 10Reedy: "You don't need to abandon it to rebase..." [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/393440 (https://phabricator.wikimedia.org/T149766) (owner: 10Sophivorus) [01:56:35] (03PS2) 10Ryan10145: Added Internationalization For Some Strings [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 [01:58:17] 10MediaWiki-Codesniffer: Create sniff to detect NULL rather than null - https://phabricator.wikimedia.org/T181909#3806325 (10Legoktm) Unfortunately there's no specific token for null, it's just T_STRING. [01:58:59] (03CR) 10Sophivorus: "I'm not as skilled as you." [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/393440 (https://phabricator.wikimedia.org/T149766) (owner: 10Sophivorus) [02:00:39] (03CR) 10Legoktm: "recheck" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [02:01:58] (03CR) 10jerkins-bot: [V: 04-1] Compatible with php7.2 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [02:02:19] 10MediaWiki-Codesniffer: Create sniff to detect NULL rather than null - https://phabricator.wikimedia.org/T181909#3806445 (10Legoktm) 05Open>03Invalid The sniff already exists and runs properly, it just didn't run for that user since they aren't whitelisted yet: ``` 02:01:41 FILE: ...jessie/src/extensions/Be... [02:02:39] (03PS1) 10Sophivorus: Respond to Reedy's code review [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/394825 (https://phabricator.wikimedia.org/T149766) [02:04:21] (03CR) 10jerkins-bot: [V: 04-1] Respond to Reedy's code review [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/394825 (https://phabricator.wikimedia.org/T149766) (owner: 10Sophivorus) [02:04:48] (03CR) 10Sophivorus: "Rebased at https://gerrit.wikimedia.org/r/#/c/394825/" [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/393440 (https://phabricator.wikimedia.org/T149766) (owner: 10Sophivorus) [02:06:13] jdlrobson, are you there? :) [02:07:34] (03PS2) 10Haikalizz: extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) [02:07:36] (03PS2) 10Sophivorus: Respond to Reedy's code review [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/394825 (https://phabricator.wikimedia.org/T149766) [02:09:08] (03CR) 10Haikalizz: "> Did you take a look at the example I linked on the bug ticket? the" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [02:10:16] 10MediaWiki-extensions-WikipediaExtracts, 10Patch-For-Review: WikipediaExtracts code review - https://phabricator.wikimedia.org/T149766#3806451 (10Sophivorus) >>! In T149766#3787592, @Reedy wrote: > You probably need to update https://www.mediawiki.org/wiki/Extension:WikipediaExtracts again as I nuked your doc... [02:15:04] (03CR) 10Legoktm: [C: 04-1] "See inline comments" (032 comments) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [02:15:42] 10Wiki-Loves-Monuments (2017): Wiki Loves Monuments blog upgrade - https://phabricator.wikimedia.org/T172068#3806452 (10LilyOfTheWest) >>! In T172068#3610357, @Pginer-WMF wrote: > > Here are some mockups for the different page types, and some notes: > > **Gallery** > |{F9554769}|{F9554771}| > - Regarding the g... [02:16:56] (03PS1) 10BryanDavis: xmp: Lower severity of XMP parse failure log events [core] - 10https://gerrit.wikimedia.org/r/394826 (https://phabricator.wikimedia.org/T118799) [02:16:59] (03PS1) 10BryanDavis: XMPReader: Log filename if available [core] - 10https://gerrit.wikimedia.org/r/394827 (https://phabricator.wikimedia.org/T118799) [02:25:02] 10MediaWiki-User-preferences, 10OOjs-UI: Special:Preferences layout (with OOUI) has quite a bit of excess whitespace - https://phabricator.wikimedia.org/T181770#3806461 (10Anomalocaris) Jdforrester-WMF wrote, "AFAICT the problem is principally around using the Monobook skin; we've adjust the whitespace signifi... [02:27:57] (03PS3) 10Haikalizz: extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) [02:32:09] QWQ https://gerrit.wikimedia.org/r/#/c/394753/ I changed the Message again [02:36:53] (03PS3) 10BryanDavis: Fix "Left match operand must result in a String value" in service::node [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394762 (owner: 10Gergő Tisza) [02:36:57] (03CR) 10BryanDavis: [C: 032] Fix "Left match operand must result in a String value" in service::node [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394762 (owner: 10Gergő Tisza) [02:37:31] (03Merged) 10jenkins-bot: Fix "Left match operand must result in a String value" in service::node [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394762 (owner: 10Gergő Tisza) [02:45:33] (03PS1) 10BryanDavis: Revert "Replace libmysqlclient-dev with default-libmysqlclient-dev" [vagrant] - 10https://gerrit.wikimedia.org/r/394828 [02:45:53] (03Abandoned) 10BryanDavis: Revert "Replace libmysqlclient-dev with default-libmysqlclient-dev" [vagrant] - 10https://gerrit.wikimedia.org/r/394828 (owner: 10BryanDavis) [02:47:31] (03PS1) 10BryanDavis: Revert "Merge "Replace libmysqlclient-dev with default-libmysqlclient-dev"" [vagrant] - 10https://gerrit.wikimedia.org/r/394829 [02:48:09] (03CR) 10BryanDavis: [C: 032] Revert "Merge "Replace libmysqlclient-dev with default-libmysqlclient-dev"" [vagrant] - 10https://gerrit.wikimedia.org/r/394829 (owner: 10BryanDavis) [02:49:27] (03Merged) 10jenkins-bot: Revert "Merge "Replace libmysqlclient-dev with default-libmysqlclient-dev"" [vagrant] - 10https://gerrit.wikimedia.org/r/394829 (owner: 10BryanDavis) [02:51:08] (03CR) 10jenkins-bot: Revert "Merge "Replace libmysqlclient-dev with default-libmysqlclient-dev"" [vagrant] - 10https://gerrit.wikimedia.org/r/394829 (owner: 10BryanDavis) [02:52:40] (03CR) 10Legoktm: [C: 04-1] "Nearly there - you don't need the array() part of the function call, just (for example) $this->dieWithError( 'apierror-linter-invalid-ip'," [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [03:05:38] lengyue no you didnt [03:06:35] Zppix:Hmmmm [03:06:48] 10Design, 10Electron-PDFs, 10Operations, 10I18n, and 3 others: Use "Charter" as preferred typeface on Electron - https://phabricator.wikimedia.org/T181200#3806464 (10Nirzar) @mobrovac it worked when you had put it in beta cluster :( > https://phabricator.wikimedia.org/T181200#3783404 [03:06:54] lengyue: click this and edit it this way https://gerrit.wikimedia.org/r/#/c/394753/1//COMMIT_MSG,edit [03:07:11] Then click save and then go to gerrit page and click publish ediy [03:07:13] Edit* [03:07:40] divadsn: i saw you needed jdlrobson, but what do you need exactly? [03:08:21] (03PS1) 10BryanDavis: openjdk: Update to openjdk-8 [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394830 (https://phabricator.wikimedia.org/T181353) [03:09:03] (03PS2) 10Lengyue: maintenance/refreshLinks.php:Replace usage of wfWaitForSlaves. [core] - 10https://gerrit.wikimedia.org/r/394753 (https://phabricator.wikimedia.org/T181673) [03:09:23] Zppix, I have the task where I need to fix svg on IE8 for the Wikipedia logo, but apparently I can't find the repo where I am supposed to add that change, the task says the change would be required in the skins repo, but there I found only a reference for the page title. [03:09:32] Zppix:I forgot to published it, Thanks :D [03:09:44] lengyue: ok ill look in a sec [03:09:54] divadsn: link to task please [03:10:39] https://phabricator.wikimedia.org/T166684 Zppix [03:10:52] Ty looking... [03:12:18] I'm going to sleep now (it's 4 am), if you found something please leave it on Phabricator, as I might loose your message here :) [03:12:30] divadsn ill talk to your mentors [03:12:54] its "4 am" really [03:13:20] eisenhaus335: in some places. [03:13:26] eisenhaus335: are you for GCI? [03:13:29] Here* [03:13:52] yeah. i am make some joke though before [03:14:06] Sweet [03:14:14] eisenhaus335: what are you working on? [03:14:23] pytest for database module [03:14:26] divadsn: I mentioned it on the task just now, but https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/skins/MinervaNeue [03:14:53] bd808: thanks! I was confused myself [03:14:58] generally if you are hunting for a repo you can go to https://gerrit.wikimedia.org/r/#/admin/projects/ and search [03:15:20] bd808: your up really late no? [03:15:36] are you GCI too? Zppix [03:15:38] bd808, I already cloned that repo, but the only useful reference I found was the page title in the minerva.mustache [03:15:43] Zppix: 20:15 here, so not really :) [03:15:46] eisenhaus335: im a GCI mentor for wikimedia [03:16:02] bd808: your in SF arent you? [03:16:05] ooh... [03:16:39] Zppix: one timezone east of SF (where it is 19:16) [03:16:46] Ah rihjt [03:16:49] Right* [03:16:58] Im over in IL bd808 xD [03:17:49] (03PS4) 10Haikalizz: extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) [03:17:52] divadsn: hmmm.. so you need to find where to put the onerror handler I guess. I'll see if I can spot the right file [03:18:00] i am not sure what i need to work on. Do i make a test module for database or i edit db.py to get pytest. i was sure i need to make a new module for db test [03:18:20] eisenhaus335: is this for wikilabels? [03:18:29] yup [03:18:55] eisenhaus335: we want a new module if i remember right [03:20:16] ok i am think i know what to work. thanks [03:21:09] eisenhaus335: let me know if you need help (I am actually an admin on that repository) [03:27:35] (03CR) 10Zppix: "Good job on the commit message" [core] - 10https://gerrit.wikimedia.org/r/394753 (https://phabricator.wikimedia.org/T181673) (owner: 10Lengyue) [03:35:31] 10TemplateStyles, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Tracking), 10Reading-Infrastructure-Team-Backlog (Kanban): Deploy TemplateStyles to svwiki - https://phabricator.wikimedia.org/T176082#3806484 (10jhsoby) [03:39:36] 10MediaWiki-extensions-Score, 10Repository-Ownership-Requests: +2 for Ebe123 in mediawiki/extensions/Score - https://phabricator.wikimedia.org/T181904#3806488 (10Ebe123) Thanks for your nomination. I plan to maintain this extension while adding features to improve its usability and capabilities for sheet music. [03:40:57] 10TemplateStyles, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10Reading-Infrastructure-Team-Backlog (Kanban): Deploy TemplateStyles to svwiki - https://phabricator.wikimedia.org/T176082#3806489 (10jhsoby) Uploaded patch, but will wait for @Deskana's go before adding t... [03:51:03] (03PS1) 10Pppery: Parse "show/hide " labels on Watchlist and RecentChanges [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) [03:51:37] Zppix:So I can submit my task? [03:51:52] If you finished the requirements of the task yes lengyue [03:53:20] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Wikicode is not interpreted in system message - https://phabricator.wikimedia.org/T142406#3806494 (10Pppery) a:03Pppery [03:54:34] (03PS1) 10Aaron Schulz: Lower DatabaseMysqlBase::lock loggin to INFO [core] - 10https://gerrit.wikimedia.org/r/394833 (https://phabricator.wikimedia.org/T180793) [03:55:07] 10Reading-analysis: Pageview of hi.wikiversity on 27/11/17 was going high - https://phabricator.wikimedia.org/T181883#3806496 (10Jayprakash12345) [03:56:36] (03PS2) 10Aaron Schulz: Lower DatabaseMysqlBase::lock logging to INFO [core] - 10https://gerrit.wikimedia.org/r/394833 (https://phabricator.wikimedia.org/T180793) [03:56:54] 10Reading-analysis: Pageview of hi.wikiversity on 27/11/17 was going high - https://phabricator.wikimedia.org/T181883#3805346 (10Jayprakash12345) >>! In T181883#3806269, @Aklapper wrote: > Please describe what is "weird" and why, by following https://mediawiki.org/wiki/How_to_report_a_bug . > All I see are >3500... [03:59:55] 10MediaWiki-extensions-Score, 10TimedMediaHandler: Allow various audio filetypes in scores - https://phabricator.wikimedia.org/T181914#3806502 (10Ebe123) [04:01:03] (03CR) 10Pppery: [C: 04-1] "Discovered a bug involving spacing, still need to fix" [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) (owner: 10Pppery) [04:13:58] (03PS1) 10Lengyue: core:Replace usage of wfWaitForSlaves. [core] - 10https://gerrit.wikimedia.org/r/394834 [04:15:30] (03Abandoned) 10Lengyue: core:Replace usage of wfWaitForSlaves. [core] - 10https://gerrit.wikimedia.org/r/394834 (owner: 10Lengyue) [04:16:00] (03PS2) 10Pppery: Parse "show/hide " labels on Watchlist and RecentChanges [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) [04:30:58] (03CR) 10Pppery: "(Just to be clear, PS2 was to fix the space bug I identified in PS1, and this is now ready for review)" [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) (owner: 10Pppery) [04:35:06] (03CR) 10TTO: "Hi guys! I hope GCI is going well. I'm watching from the sidelines this time around :)" [core] - 10https://gerrit.wikimedia.org/r/394757 (https://phabricator.wikimedia.org/T172956) (owner: 10Pppery) [04:37:01] 10MediaWiki-User-preferences, 10Theme: Special:Preferences "Global default '' is invalid for field theme" MWException on 1.30 RC - https://phabricator.wikimedia.org/T181898#3805975 (10ashley) Is `$wgDefaultTheme` defined properly in the site's configuration file? The extension intentionally does **not** set it... [05:02:53] 10MediaWiki-Vagrant: Make php7 the default PHP on stretch - https://phabricator.wikimedia.org/T181915#3806522 (10bd808) [05:03:11] 10MediaWiki-Vagrant, 10Epic, 10Patch-For-Review: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3787138 (10bd808) p:05Triage>03Normal [05:40:00] 10InternetArchiveBot: Failing to detect redirect to 404 as dead ... - https://phabricator.wikimedia.org/T181916#3806537 (10SamB) [05:59:20] 10MediaWiki-Stakeholders-Group, 10Developer-Relations, 10Wikimedia-General-or-Unknown, 10Epic: Extension Store - Ideas and Requirements - https://phabricator.wikimedia.org/T118188#1793727 (10Tgr) See also {T155029} (which is in need of a data store to drop information extracted from extension.json etc. into) [06:05:05] 10MediaWiki-extension-requests: Support content delivery from static sources (files) into MediaWiki content for extensions - https://phabricator.wikimedia.org/T177496#3660786 (10Tgr) Somewhat different usecase, but MediaWiki-Vagrant imports documentation from puppet templates. See [[https://github.com/wikimedia/... [06:07:31] 10MediaWiki-Vagrant: Make php7 the default PHP on stretch - https://phabricator.wikimedia.org/T181915#3806557 (10bd808) a:03bd808 [06:08:41] 10MediaWiki-Vagrant: Fix redis for stretch - https://phabricator.wikimedia.org/T181917#3806559 (10bd808) [06:09:56] 10MediaWiki-Vagrant: Fix default .my.cnf/grants for vagrant user on Stretch - https://phabricator.wikimedia.org/T181918#3806574 (10bd808) [06:25:43] 10MediaWiki-extension-requests, 10AICaptcha, 10Outreach-Programs-Projects, 10Stewards-and-global-tools, and 3 others: Automatically detect spambot registration using machine learning (like invisible reCAPTCHA) - https://phabricator.wikimedia.org/T158909#3652590 (10Tgr) [06:25:44] 10Outreachy, 10Patch-For-Review: Outreachy microtask: collect captcha data from signup page (#1) - https://phabricator.wikimedia.org/T175330#3806592 (10Tgr) 05Open>03Resolved a:03Tgr [06:26:01] 10Outreachy: Outreachy microtask: collect captcha data from signup page (#2) - https://phabricator.wikimedia.org/T175331#3806594 (10Tgr) 05Open>03Resolved a:03Tgr [06:26:09] 10Outreachy: Outreachy microtask: analyze sample mouse movement data and extract feature vectors - https://phabricator.wikimedia.org/T177033#3806596 (10Tgr) 05Open>03Resolved a:03Tgr [06:27:57] 10ConfirmEdit (CAPTCHA extension), 10Outreachy, 10Patch-For-Review: Outreachy microtask: write a CAPTCHA plugin that can fall back to another algorithm - https://phabricator.wikimedia.org/T177034#3806598 (10Tgr) 05Open>03Resolved a:03Tgr See {T179635} for the real version of this task (which was too co... [06:28:17] 10AICaptcha, 10ConfirmEdit (CAPTCHA extension): Allow captchas to be stacked - https://phabricator.wikimedia.org/T179635#3806601 (10Tgr) [06:29:15] 10MediaWiki-extensions-reCaptcha, 10Internet-Archive, 10Outreachy (Round-15): Automatically detect spambot registration using machine learning like invisible reCAPTCHA (Vinitha V S) - https://phabricator.wikimedia.org/T178463#3806602 (10Tgr) [06:29:55] 10AICaptcha, 10Outreachy (Round-15): Automatically detect spambot registration using machine learning like invisible reCAPTCHA (Vinitha V S) - https://phabricator.wikimedia.org/T178463#3693183 (10Tgr) [06:33:54] 10MediaWiki-Vagrant: Fix redis for stretch - https://phabricator.wikimedia.org/T181917#3806605 (10Tgr) `systemctl restart redis` hangs forever (not immediately after a system reboot, but it always happens a couple attempts later), which also kills `vagrant provision`. Not sure if this is a redis problem or somet... [06:36:25] (03PS1) 10Gergő Tisza: Add systemd override for redis-service [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394835 (https://phabricator.wikimedia.org/T181917) [06:37:34] (03CR) 10Gergő Tisza: "The alternative would be to just kill redis::dir and let debian manage where RDB files end up. Not sure which is better." [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394835 (https://phabricator.wikimedia.org/T181917) (owner: 10Gergő Tisza) [06:40:58] (03CR) 10星耀晨曦: "> And the bug is nothing to do with PHP 7.2" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [06:45:08] (03PS2) 10星耀晨曦: Compatible with php7.2 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) [06:51:46] (03PS1) 10Gergő Tisza: Remove ack alias [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394836 (https://phabricator.wikimedia.org/T181353) [06:58:41] is there any documentation for database module? i am need to grinding to understand the module [07:07:34] (03CR) 10Legoktm: [C: 032] Remove ack alias [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394836 (https://phabricator.wikimedia.org/T181353) (owner: 10Gergő Tisza) [07:08:06] (03Merged) 10jenkins-bot: Remove ack alias [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/394836 (https://phabricator.wikimedia.org/T181353) (owner: 10Gergő Tisza) [07:19:04] 10MediaWiki-General-or-Unknown, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017): GitInfo shell restriction of whitelisting paths is broken for git submodules - https://phabricator.wikimedia.org/T181919#3806611 (10Legoktm) [07:19:48] (03PS1) 10Legoktm: GitInfo: Fix shell restrictions for submodules [core] - 10https://gerrit.wikimedia.org/r/394837 (https://phabricator.wikimedia.org/T181919) [07:21:26] (03PS1) 10Legoktm: .gitignore: Exclude Extension:Score generated files [core] - 10https://gerrit.wikimedia.org/r/394838 [07:34:08] (03PS1) 10Legoktm: Document mediawiki-jobrunner systemd unit in README.Debian [debian] - 10https://gerrit.wikimedia.org/r/394839 [07:38:03] eisenhaus335: you may take a look at this: https://m.mediawiki.org/wiki/Manual:Database_access [07:39:31] finally a clue thank you. [07:41:44] (03CR) 10Legoktm: [C: 032] Lower DatabaseMysqlBase::lock logging to INFO [core] - 10https://gerrit.wikimedia.org/r/394833 (https://phabricator.wikimedia.org/T180793) (owner: 10Aaron Schulz) [07:42:44] (03CR) 10Legoktm: [C: 032] xmp: Lower severity of XMP parse failure log events [core] - 10https://gerrit.wikimedia.org/r/394826 (https://phabricator.wikimedia.org/T118799) (owner: 10BryanDavis) [07:43:34] (03CR) 10Legoktm: "recheck" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [07:46:03] (03CR) 10jerkins-bot: [V: 04-1] extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [07:46:59] (03CR) 10Legoktm: "Based on https://3v4l.org/9kcf5 there's a warning, but no fatal." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [07:48:12] (03CR) 10Legoktm: [C: 04-1] extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [07:48:49] (03Merged) 10jenkins-bot: Lower DatabaseMysqlBase::lock logging to INFO [core] - 10https://gerrit.wikimedia.org/r/394833 (https://phabricator.wikimedia.org/T180793) (owner: 10Aaron Schulz) [07:48:55] (03Merged) 10jenkins-bot: xmp: Lower severity of XMP parse failure log events [core] - 10https://gerrit.wikimedia.org/r/394826 (https://phabricator.wikimedia.org/T118799) (owner: 10BryanDavis) [07:52:17] (03CR) 10Legoktm: [C: 032] Compatible with php7.2 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [07:54:05] (03Merged) 10jenkins-bot: Compatible with php7.2 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/394739 (https://phabricator.wikimedia.org/T181821) (owner: 10星耀晨曦) [07:59:39] (03CR) 10jenkins-bot: xmp: Lower severity of XMP parse failure log events [core] - 10https://gerrit.wikimedia.org/r/394826 (https://phabricator.wikimedia.org/T118799) (owner: 10BryanDavis) [08:01:24] 10MediaWiki-General-or-Unknown: Lists formatting does not work in image tag - https://phabricator.wikimedia.org/T181921#3806650 (10SerDIDG) [08:05:05] 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser: Lists formatting does not work in image tag - https://phabricator.wikimedia.org/T181921#3806664 (10SerDIDG) [08:08:42] (03CR) 10jenkins-bot: Lower DatabaseMysqlBase::lock logging to INFO [core] - 10https://gerrit.wikimedia.org/r/394833 (https://phabricator.wikimedia.org/T180793) (owner: 10Aaron Schulz) [08:20:43] (03PS2) 10Legoktm: Document mediawiki-jobrunner systemd unit in README.Debian [debian] - 10https://gerrit.wikimedia.org/r/394839 [08:29:09] 10BetaFeatures, 10Easy, 10MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), 10Patch-For-Review: Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) - https://phabricator.wikimedia.org/T181821#3806671 (1... [08:36:18] (03CR) 10Legoktm: [C: 032] Document mediawiki-jobrunner systemd unit in README.Debian [debian] - 10https://gerrit.wikimedia.org/r/394839 (owner: 10Legoktm) [08:36:32] (03CR) 10Legoktm: [C: 032] Document mediawiki-jobrunner systemd unit in README.Debian [debian] - 10https://gerrit.wikimedia.org/r/394839 (owner: 10Legoktm) [08:36:46] * legoktm eyes Gerrit [08:37:18] (03PS1) 10Legoktm: Finalize 1:1.27.4-3 changelog [debian] - 10https://gerrit.wikimedia.org/r/394841 [08:37:28] (03CR) 10Legoktm: [V: 032 C: 032] Finalize 1:1.27.4-3 changelog [debian] - 10https://gerrit.wikimedia.org/r/394841 (owner: 10Legoktm) [08:37:42] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3806673 (10AnmolSingh) Thanks for the feedback @Molvz Here is an updated version using curly brackets, and nimbus/aureole over "o". I'm not very confident about the c... [08:53:09] (03CR) 10D3r1ck01: "recheck" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 (owner: 10Ryan10145) [08:55:07] 10Genealogy: Permit tree regeneration by users without upload permission - https://phabricator.wikimedia.org/T176594#3806678 (10Reception123) [08:55:10] 10MediaWiki-Configuration, 10Goal, 10Patch-For-Review: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668#3806679 (10Reception123) [08:55:13] 10GraphViz, 10Patch-For-Review: Convert GraphViz to use extension registration - https://phabricator.wikimedia.org/T173209#3806676 (10Reception123) 05Open>03Resolved a:03Welterkj [08:55:15] 10MediaWiki-General-or-Unknown, 10Wikimedia-Israel-Hackers, 10CSS, 10Easy, 10Google-Code-in-2017: Table collapsing button is too close to the capture - add some CSS spacing - https://phabricator.wikimedia.org/T178998#3806680 (10D3r1ck01) @eflyjason, it would be good to use Gerrit Code Review(recommended)... [08:55:46] 10MediaWiki-General-or-Unknown, 10Wikimedia-Israel-Hackers, 10CSS, 10Easy, 10Google-Code-in-2017: Table collapsing button is too close to the capture - add some CSS spacing - https://phabricator.wikimedia.org/T178998#3806681 (10D3r1ck01) >>! In T178998#3805423, @eflyjason wrote: > With wiki code > ``` >... [08:55:53] 10MediaWiki-extensions-PageNotice, 10Patch-For-Review: Convert PageNotice to use extension registration - https://phabricator.wikimedia.org/T174657#3806682 (10Reception123) a:05Reception123>03None [09:07:32] (03CR) 10D3r1ck01: [C: 04-1] "See comments @Ryan, thanks." (038 comments) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 (owner: 10Ryan10145) [09:28:56] 10MediaWiki-Interface, 10CSS, 10JavaScript: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state) - https://phabricator.wikimedia.org/T42812#3806687 (10Pruem) On my local MediaWiki installation I solved this (for tables) by adding the followi... [09:37:14] Hey everyone i'm Morgan, I'm 14 this year [09:40:58] 10MediaWiki-Configuration, 10Goal, 10Patch-For-Review: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668#3806691 (10Samwilson) [09:41:00] 10Patch-For-Review: Convert FlickrAPI to use extension registration - https://phabricator.wikimedia.org/T171819#3806689 (10Samwilson) 05Open>03Resolved a:03Samwilson [09:42:30] alamo18: Hi Morgan, welcome ^^ [09:45:02] (03PS1) 10Samwilson: Add license-name to extension.json [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/394844 (https://phabricator.wikimedia.org/T123943) [09:48:22] 10MediaWiki-extensions-General: Errors with PhpFlickr library in Extension:FlickrAPI - https://phabricator.wikimedia.org/T181922#3806693 (10Samwilson) [09:50:18] (03PS4) 10Samwilson: Switch to fork of the phpflickr library [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/384642 (https://phabricator.wikimedia.org/T181922) [10:05:13] (03PS5) 10Haikalizz: extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) [10:26:58] 10GraphViz: PHP Fatal error: Call to a member function getFulltext() on null in GraphViz_body.php on line 500 - https://phabricator.wikimedia.org/T180376#3806714 (10Kghbln) In the meantime the publicly accessible test wiki was upgraded to: - MediaWiki 1.30.0-rc.0 (25caa3a) 05:31, 30 November 2017 - PHP 5.6.3... [10:30:30] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Cannot see images on Commons (due to Kaspersky being installed) - https://phabricator.wikimedia.org/T180661#3806715 (10Slaiden) Good day, thank you for your advice. I don't know how or why but after checking my PC by ccleaner, kasperksy's utility, malware.... [10:44:17] (03PS1) 10Divadsn: Use png as fallback when svg fails to load [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) [10:45:38] (03PS2) 10Divadsn: Use png as fallback when svg fails to load [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) [10:48:05] 10Wikimedia-Site-requests: Delete mo.wikipedia and mo.wiktionary - https://phabricator.wikimedia.org/T181923#3806722 (10MarcoAurelio) [10:48:26] 10Wikimedia-Site-requests: Delete mo.wikipedia and mo.wiktionary - https://phabricator.wikimedia.org/T181923#3806737 (10MarcoAurelio) [10:48:53] 10Wikimedia-Site-requests: Delete mo.wikipedia and mo.wiktionary; set redirects to ro.wikipedia and ro.wiktionary afterwards - https://phabricator.wikimedia.org/T181923#3806722 (10MarcoAurelio) [10:50:18] (03PS22) 10Fomafix: Substitute language codes that are not conform to BCP 47 [core] - 10https://gerrit.wikimedia.org/r/226040 (https://phabricator.wikimedia.org/T106367) (owner: 10Gerrit Patch Uploader) [10:52:35] (03CR) 10Fomafix: "Add mapping 'sr-ec' => 'sr-Cyrl', 'sr-el' => 'sr-Latn' because 'sr-EC' and 'sr-EL' are also not conform to BCP 47." [core] - 10https://gerrit.wikimedia.org/r/226040 (https://phabricator.wikimedia.org/T106367) (owner: 10Gerrit Patch Uploader) [10:58:11] 10Design, 10TCB-Team, 10WMDE-Design, 10German-Community-Wishlist: Connect moved paragraphs by arrows - https://phabricator.wikimedia.org/T140340#2461242 (10Alsee) The current demo uses curvy arrows pointing right and left. They strike me as kinda weird. I think it would be more natural and more clear if th... [11:00:29] 10MediaWiki-Codesniffer, 10Patch-For-Review: Only run one EndFileNewline.NotFound sniff, not two - https://phabricator.wikimedia.org/T179998#3806743 (10Umherirrender) 05Open>03Resolved p:05Triage>03Normal a:03Legoktm [11:02:18] (03PS2) 10Umherirrender: .gitignore: Exclude Extension:Score generated files [core] - 10https://gerrit.wikimedia.org/r/394838 (owner: 10Legoktm) [11:02:21] (03CR) 10Umherirrender: [C: 032] .gitignore: Exclude Extension:Score generated files [core] - 10https://gerrit.wikimedia.org/r/394838 (owner: 10Legoktm) [11:04:17] 10MediaWiki-extensions-DisplayTitle, 10Patch-For-Review: ErrorException from line 118 in DisplayTitleHooks.php: PHP Warning: get_class() expects parameter 1 to be object, integer given - https://phabricator.wikimedia.org/T181669#3806760 (10Kghbln) @CCicalese_WMF I have moved in patch-set 3 on sandbox.smw.o and... [11:07:41] Thank you very much for your last hint bd808, sometimes someone else spots something you might have overlooked :) [11:08:36] (03Merged) 10jenkins-bot: .gitignore: Exclude Extension:Score generated files [core] - 10https://gerrit.wikimedia.org/r/394838 (owner: 10Legoktm) [11:10:57] (03CR) 10Umherirrender: [C: 032] Rename CodeMirror.hooks.php to CodeMirrorHooks.php [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/394768 (owner: 10Fomafix) [11:11:06] (03CR) 10Kghbln: [C: 031] Add license-name to extension.json [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/394844 (https://phabricator.wikimedia.org/T123943) (owner: 10Samwilson) [11:11:58] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, 10German-Community-Wishlist, and 6 others: Show changes in moved text chunks (C++) - https://phabricator.wikimedia.org/T146781#2671010 (10Alsee) Thanks for working on this. I reviewed some of the sample diffs. [[ https://deployment.wikimedia.beta.wmfl... [11:12:07] (03CR) 10Umherirrender: [C: 032] Rename TocTree.hooks.php to TocTreeHooks.php [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/394766 (owner: 10Fomafix) [11:13:03] (03Merged) 10jenkins-bot: Rename CodeMirror.hooks.php to CodeMirrorHooks.php [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/394768 (owner: 10Fomafix) [11:13:47] (03Merged) 10jenkins-bot: Rename TocTree.hooks.php to TocTreeHooks.php [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/394766 (owner: 10Fomafix) [11:18:47] 10MediaWiki-Database: Kill mowiki and mowiktionary databases; scheduled for deletion - https://phabricator.wikimedia.org/T181925#3806781 (10Marostegui) I don't think we delete the databases directly in our databases, we should instead go thru MediaWiki to make that happen. [11:19:14] (03CR) 10jenkins-bot: .gitignore: Exclude Extension:Score generated files [core] - 10https://gerrit.wikimedia.org/r/394838 (owner: 10Legoktm) [11:19:31] 10MediaWiki-Database: Kill mowiki and mowiktionary databases; scheduled for deletion - https://phabricator.wikimedia.org/T181925#3806783 (10MarcoAurelio) @Marostegui Apparently you do: https://wikitech.wikimedia.org/wiki/Delete_a_wiki [11:23:11] (03PS1) 10Eflyjason: Component: Add some CSS spacing before table collapsing button [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) [11:23:21] 10GraphViz: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats - https://phabricator.wikimedia.org/T181926#3806791 (10Kghbln) [11:25:28] 10GraphViz: GraphViz no longer working in connection with SemanticMediaWiki and SemanticResultFormats - https://phabricator.wikimedia.org/T181926#3806791 (10Kghbln) @Samwilson Do you think this is a GraphViz or and SemanticResultFormat issue. In case of the latter this issue belongs to GitHub issue tracker for S... [11:28:47] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [11:29:32] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Change project namespace name on Walloon Wiktionary to "Wiccionaire" - https://phabricator.wikimedia.org/T181782#3806808 (10MarcoAurelio) Yes, you need to run that script afterwards or you'll have broken namespaces. This is im... [11:31:09] 10GraphViz: PHP Fatal error: Call to a member function getFulltext() on null in GraphViz_body.php on line 500 - https://phabricator.wikimedia.org/T180376#3806811 (10Kghbln) Well the reason for this error no longer happening is that GraphViz is no longer working at all in connection with SMW and SRF. So I prelim... [11:34:50] (03CR) 10jerkins-bot: [V: 04-1] Component: Add some CSS spacing before table collapsing button [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [11:35:00] 10MediaWiki-User-management: ip normalization makes pages inaccessable - https://phabricator.wikimedia.org/T180996#3806813 (10Umherirrender) p:05Triage>03Lowest API edit action does not allow to create such a page ``` /w/api.php?action=edit&format=json&title=User%3A128.220.231.02&text=This%20is%20a%20test%20... [11:39:28] TabbyCat: nice catch (._. [11:39:56] that reminded me revi to add -es translations there too [11:40:13] as for the v-1 of jerkinks-bot, no idea [11:40:18] and for Signed-off-by, git hook seem to be adding it above it [11:40:31] first it: Change-ID [11:40:50] and for v-1, seems Wikibase repo is failing on CI [11:41:38] 10MediaWiki-General-or-Unknown, 10Wikimedia-Israel-Hackers, 10CSS, 10Easy, and 2 others: Table collapsing button is too close to the capture - add some CSS spacing - https://phabricator.wikimedia.org/T178998#3806830 (10eflyjason) I think the "- mediawiki-phpunit-hhvm-jessie https://integration.wikimedia.or... [11:41:58] wikibase is always failing on CI [11:47:06] anyway commented for completeness [11:53:08] revi, it seems Wikibase\Repo\Tests\Actions\ViewEntityActionTest::testShowDiff is the problematic stuff [11:53:18] according to jenkins [11:53:21] anyway, no idea [11:53:29] but doesn't seem related to our patches [11:58:11] hey d3r1ck! [12:06:57] revi, filed T181928 [12:06:59] T181928: Wikibase\Repo\Tests\Actions\ViewEntityActionTest::testShowDiff failing on CI - https://phabricator.wikimedia.org/T181928 [12:07:01] got the mail [12:07:02] yeah [12:07:05] ah [12:07:11] well, we didn't touch anything related to that stuff [12:07:11] fast mail heh [12:07:16] haha [12:07:25] 10MediaWiki-Uploading, 10Multimedia, 10Easy, 10Google-Code-in-2017: Improve lock file error message for uploading - https://phabricator.wikimedia.org/T181453#3790863 (10Harjotsingh) I can mentor this [12:07:26] so not us to blame :$ [12:07:38] also phab notification [12:07:38] I shall nuke en masse all phabricator and gerrit emails from my inbox [12:07:52] I just 'archive' it in gmail [12:08:02] so it's gone from the inbox [12:08:04] I don't like to archive those [12:08:09] (03CR) 10Umherirrender: [C: 031] "When merging from subject namespace to talk namespace with the same dbkey there are some unneeded replaces. The MovePage works around this" [core] - 10https://gerrit.wikimedia.org/r/393378 (https://phabricator.wikimedia.org/T132130) (owner: 10Fomafix) [12:08:26] don't have anything interesting to me [12:08:36] so I just send it to trash and get deleted silently [12:10:07] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555#1743134 (10revi) [12:10:13] d'uh [12:10:43] I usually prefer to store all incoming mails unless that's spam [12:11:45] https://phabricator.wikimedia.org/T181929 <-- I can do that revi [12:11:59] if you can do that, that would be great [12:20:18] Zppix or d3r1ck, are any of you there? [12:23:14] 10MediaWiki-General-or-Unknown, 10MinervaNeue (3rd party support): BadMethodCallException from line 847 of SessionManager.php: Sessions are disabled for this entry point - https://phabricator.wikimedia.org/T181676#3806890 (10Kghbln) I have not worked my way through all modules, however these two are definitive... [12:30:17] revi, done [12:30:26] thanks <3 [12:32:01] TabbyCat: commented on the task, after doing herald feel free to resolve it [12:32:36] ok [12:33:54] 10MediaWiki-Database: Comment schema migration and foreign db repos not working well - https://phabricator.wikimedia.org/T181930#3806908 (10Umherirrender) [12:34:23] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555#3806926 (10MarcoAurelio) [12:34:47] revi, done as well [12:34:56] :D [12:34:58] enjoy [12:35:01] :D [12:35:02] Thanks! [12:37:33] I feel I did my good deed for today :) [12:38:00] indeed [12:41:21] (03PS8) 10Matěj Suchánek: HistoryAction: Implement HistoryPageAddLink hook for adding more links [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [12:42:29] :) [12:45:45] revi, not the first user I see they say will ignore Conpherence. Why? [12:46:09] I prefer emails :P [12:47:15] well I'm in wikimedia-site-req [12:47:28] I've got some stuff to SWAT but I don't want to go through all that bureaucracy yet again [12:47:52] 10AbuseFilter, 10Easy, 10Patch-For-Review: Add link to abuse filter log to page history's #contentSub - https://phabricator.wikimedia.org/T28934#3806941 (10matej_suchanek) a:03matej_suchanek [12:48:31] I just want non-group chat sent via email [12:48:48] group like wikimedia-site-request is fine [12:50:34] 10MediaWiki-extensions-LoginNotify, 10Beta-Cluster-Infrastructure, 10Community-Tech, 10Wikimedia-Site-requests: Clarify LoginNotify emails are from beta - https://phabricator.wikimedia.org/T181908#3806293 (10MarcoAurelio) Maybe those emails are using `{{SITENAME}}` (have not checked); so we could maybe jus... [12:51:42] (03PS9) 10Matěj Suchánek: HistoryAction: Implement HistoryPageAddLink hook for adding more links [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [12:53:39] (03PS10) 10Matěj Suchánek: HistoryAction: Implement HistoryPageAddLink hook for adding more links [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [13:15:17] 04(no projects): MediaWiki PHPUnit fails with PHP 7.2 - https://phabricator.wikimedia.org/T181931#3806953 (10JeroenDeDauw) [13:28:57] 10MediaWiki-Core-Tests, 10MediaWiki-General-or-Unknown, 10NewPHP: MediaWiki PHPUnit fails with PHP 7.2 - https://phabricator.wikimedia.org/T181931#3806964 (10Aklapper) [13:36:56] Hello everyone , im here because of Google Code In task :) [13:39:09] welcome michnak :) [13:39:44] michnak: Hello and welcome :) [13:45:50] (03CR) 10Eranroz: "Eflyjason thanks for this patch!" [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [14:01:30] 10Design, 10Africa-Wikimedia-Developers, 10Discovery, 10WMDE-Design, and 5 others: Imagegrid should lazy load - https://phabricator.wikimedia.org/T166216#3806967 (10Jonas) [14:11:16] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10Commons: Add SUL/CentralAuth variables to AbuseFilter - https://phabricator.wikimedia.org/T181932#3806977 (10Dispenser) [14:24:09] (03PS2) 10Eflyjason: Component: Add some CSS spacing before table collapsing button [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) [14:26:35] (03PS3) 10Eflyjason: Component: Add some CSS spacing before table collapsing button [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) [14:32:20] 10MediaWiki-General-or-Unknown, 10TechCom-RfC, 10RfC: Require either PHP 7.0+ or HHVM in MW 1.31 - https://phabricator.wikimedia.org/T172165#3806993 (10Reedy) [14:32:23] 10MediaWiki-Core-Tests, 10MediaWiki-General-or-Unknown, 10NewPHP: MediaWiki PHPUnit fails with PHP 7.2 - https://phabricator.wikimedia.org/T181931#3806992 (10Reedy) [14:33:40] 10AbuseFilter, 10Social-Tools, 10SocialProfile: SocialProfile broken - error 500 due to cache setup - https://phabricator.wikimedia.org/T181586#3806994 (10Aklapper) 05Resolved>03Invalid [14:35:57] 10MediaWiki-extensions-Other, 10Patch-For-Review: Errors with PhpFlickr library in Extension:FlickrAPI - https://phabricator.wikimedia.org/T181922#3806996 (10Aklapper) [14:40:53] 10MediaWiki-Core-Tests, 10MediaWiki-General-or-Unknown, 10NewPHP: MediaWiki PHPUnit fails with PHP 7.2 - https://phabricator.wikimedia.org/T181931#3806953 (10Reedy) So, this is "kinda" blocked on {T172165} See also {T177132} That being said... Is there any reason we can't have version options in composer.j... [14:50:00] (03PS1) 10Reedy: Allow PHPUnit 5 and 6 versions optionally in require-dev [core] - 10https://gerrit.wikimedia.org/r/394851 (https://phabricator.wikimedia.org/T181931) [14:53:37] (03CR) 10jerkins-bot: [V: 04-1] Allow PHPUnit 5 and 6 versions optionally in require-dev [core] - 10https://gerrit.wikimedia.org/r/394851 (https://phabricator.wikimedia.org/T181931) (owner: 10Reedy) [15:07:13] 10MediaWiki-extensions-UniversalLanguageSelector: ULS preferences (uls-preferences) are exposed in userinfo API as JSON-encoded string - https://phabricator.wikimedia.org/T173935#3807028 (10Nemo_bis) @Anomie do you think this preference should be removed from the userinfo API, or made "prettier"? [15:08:20] 10Dumps-Generation, 10Patch-For-Review: Simplify the xml/sql cleanup jobs and deploy everywhere - https://phabricator.wikimedia.org/T181895#3807034 (10ArielGlenn) Deployed on all hosts except for labstore1006, which appears to be in the middle of being reimaged, see T181431 [15:08:27] 10Dumps-Generation, 10Patch-For-Review: Simplify the xml/sql cleanup jobs and deploy everywhere - https://phabricator.wikimedia.org/T181895#3807037 (10ArielGlenn) 05Open>03Resolved [15:24:00] 10Discovery, 10Discovery-Search (Current work), 10I18n: Review Serbian Morphological Libraries - https://phabricator.wikimedia.org/T178926#3807040 (10Nemo_bis) [15:24:22] 10Discovery, 10Bengali-Sites, 10Discovery-Search (Current work), 10I18n, and 2 others: Language Analysis Morphological Library Research Spike - https://phabricator.wikimedia.org/T171652#3807043 (10Nemo_bis) [15:38:32] 10Readers-Web-Backlog, 10Design (RW-Design-Debt): [Epic] Improve special page template - https://phabricator.wikimedia.org/T169162#3389128 (10Nemo_bis) The description doesn't explain how this goes towards {T158181}. Besides, nearly all the "prominent special pages" listed are not even special pages in MediaWi... [15:48:09] (03PS2) 10Yashasvi: PageFragment : snackbar should be shown above actions tab [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/394754 (https://phabricator.wikimedia.org/T146091) [15:48:48] (03CR) 10jerkins-bot: [V: 04-1] PageFragment : snackbar should be shown above actions tab [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/394754 (https://phabricator.wikimedia.org/T146091) (owner: 10Yashasvi) [15:49:11] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review: [BUG] Snackbars should appear above article toolbar - https://phabricator.wikimedia.org/T146091#3807077 (10yashasvi) Hey, updated the patch and snackbar now shows on top of actions bar as per other screens in app. {F11159953... [15:52:17] Zppix: you there? [15:53:19] 10Dumps-Generation: Do pageslogging dumps in parallel pieces for at least wikidata wiki, perhaps others - https://phabricator.wikimedia.org/T181935#3807078 (10ArielGlenn) [15:53:28] Hello. I joined the channel to complete a Google Code-in task. My name is Mateo. [15:54:01] Albert221: yes [15:54:17] welcome endless :-) [15:54:17] endless: welcome! Hope you enjoy your time during Google Code In [15:55:46] 10Dumps-Generation: Test php7 on snapshot1001 for dumps - https://phabricator.wikimedia.org/T161509#3807093 (10ArielGlenn) [15:56:25] Zppix: soo, I claimed this task about moving OAuth errors from i18n directly to the code, but in some places it's not that easy and I would like to ask you how should I achieve it [15:56:35] maybe we should move to PMs not to bloat this chat? [15:57:00] Albert221: hmm i perfer to stay in here incase i get something wrong [15:57:37] okay. give me a while when I'll point out some things that I have problem with [15:57:45] Ok [15:58:26] hello endless [15:58:37] hi [16:00:57] endless: Welcome ! [16:01:36] 10Datasets-General-or-Unknown, 10Dumps-Generation: Give misc dump crons their own host - https://phabricator.wikimedia.org/T181936#3807102 (10ArielGlenn) [16:03:33] Zppix: So my first question is about this piece of code and similar in other places in that class. https://github.com/wikimedia/mediawiki-extensions-OAuth/blob/master/frontend/specialpages/SpecialMWOAuth.php#L204-L209 It uses internal method `showError` to show error regarding of the format specified and I could've just replaced this `wfMessage` with sprintf to get the error string, but this method expects a Message object so I'm unable to do [16:03:34] that, and looking at the `showError` method body it looks like that it really needs Message object because of the requirement of the error's key. Here's what I'd've done if not that Message issue. https://i.imgur.com/3ZHw3xC.png [16:05:21] Looking [16:07:59] Ok hmm i think what youve done is good but i am not 100% sure if this right based upon the task requirements [16:08:47] I will let you know when I see TabbyCat around here [16:08:47] @notify TabbyCat [16:09:09] Yeah that looks right [16:09:18] Your doing good Albert221 [16:09:46] But the problem is that the `$this->showError()` gets `Message` object as a first parameter and I am passing a `string` [16:10:25] And what I'm asking is what would be the best solution to resolve that problem [16:11:31] What I'd've done is to create a method called like `showRawError()` which takes a `string` as a first parameter and does exactly what `showError()` does except for the thing that it doesn't have an `error` field in `FormatJson` which it is returning [16:14:08] (03CR) 10Reedy: "Phan breaks because of the needed fixes on T177132" [core] - 10https://gerrit.wikimedia.org/r/394851 (https://phabricator.wikimedia.org/T181931) (owner: 10Reedy) [16:15:10] I took a look at that too. What about modifying `showError()` method a bit? I mean adding another `format` condition there [16:15:32] Id say go with what Phantom42 said albert [16:16:20] what about adding a third parameter which would indicate whether a `$message` is a `Message` object or a `string`? [16:16:53] Im not opposed to anything if it works :) as long as it doesnt overcomplicate things for future devs [16:17:07] And doesnt break anything [16:17:28] that parameter would have a default value which wouldn't change anything so BC is present [16:17:50] but to be honest code from these classes is a little bit complicated or just simply hard to understand [16:18:17] Albert221: yeah and lack of docs doesnt help [16:18:47] I really wish every method had a phpDoc with at least some words telling what this does :/ [16:19:05] Yeah... sadly documentation is something we struggle with [16:19:48] I am not sure about adding third parameter, as we can determine `$message` type based on `format` value. Anyway, I agree with Zppix. There is no difference if it works and does not overcomplicate things. [16:27:01] (03CR) 10Paladox: Allow PHPUnit 5 and 6 versions optionally in require-dev (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394851 (https://phabricator.wikimedia.org/T181931) (owner: 10Reedy) [16:27:55] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Add proper category collation for the Northern Sami Wikipedia - https://phabricator.wikimedia.org/T181503#3807152 (10jhsoby-WMNO) [16:28:43] (03CR) 10Reedy: "No, and no" [core] - 10https://gerrit.wikimedia.org/r/394851 (https://phabricator.wikimedia.org/T181931) (owner: 10Reedy) [16:30:28] Reedy: best cr ever [16:30:49] Zppix: I've trolled bd808 before in CR too... [16:32:45] 10Datasets-General-or-Unknown, 10Dumps-Generation: Give misc dump crons their own host - https://phabricator.wikimedia.org/T181936#3807158 (10ArielGlenn) This host will be snapshot1008, in eqiad. Specs needed: 16 cores would be nice, for growth. 32GB ram is plenty and we might make do with less. A couple... [16:36:23] (03CR) 10D3r1ck01: "See below;" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [16:36:31] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [16:39:01] Zppix: there comes another problem: this method in case of html format uses showErrorPage which needs i18n key or Message which does not exist anymore... https://i.imgur.com/FKzIWHU.png [16:39:46] and yes, I could've updated showErrorPage too, but it's in mediawiki-core [16:41:08] Hmm [16:41:15] d3r1ck: are you here? [16:41:38] * Reedy kicks gerritbot [16:42:20] (03CR) 10jerkins-bot: [V: 04-1] Component: Add some CSS spacing before table collapsing button [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [16:42:34] IMHO this whole task, I mean refactoring this OAuth extension to throw hardcoded text exceptions is good in theory, but the things that come along that make it really unprofitable in terms of code clarity, redability etc. and leads to overcomplicating things unnecessarily. If it's possible I would just blacklist this translation strings in translatewiki or would have done something like that [16:43:25] Reedy: can you help me out here im stumped with the issues Albert221 is facing. [16:43:47] What's up? [16:44:02] 10MediaWiki-Parser: List markup not parsed/interpreted when used as image caption parameter in [[File:]] - https://phabricator.wikimedia.org/T181921#3807186 (10Aklapper) [16:44:03] Look, I had to add theoretically unnecessary parameter to `showError()` method (and that's not even finished! looks like I'd've refactored the `OutputPage->showErrorPage()` what would be a bigger issue) [16:44:10] 10Dumps-Generation, 10Patch-For-Review: Do pageslogging dumps in parallel pieces for at least wikidata wiki, perhaps others - https://phabricator.wikimedia.org/T181935#3807188 (10ArielGlenn) On archive.org (https://archive.org/download/wikidatawiki-20170401) I see this: wikidatawiki-20170401-pages-logging.... [16:44:29] (03CR) 10D3r1ck01: "So Jenkins is not happy with the missing spaces in the parens. Check it out." [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [16:44:53] I refactored `MWOAuthSessionProvider::makeException` also to remove i18n of (AFAIR) TWO!!! strings [16:45:13] If it's not called an unnecessarily complicating things up I don't know how to call it :/ [16:45:36] That's my opinion of course and if you don't agree with that I'll do it anyways [16:45:44] 10MediaWiki-Parser: List markup not parsed/interpreted when used as image caption parameter in [[File:]] - https://phabricator.wikimedia.org/T181921#3806650 (10Aklapper) [16:45:46] 10MediaWiki-Parser: Wikitext in image captions displayed as plaintext - https://phabricator.wikimedia.org/T18768#3807193 (10Aklapper) [16:45:52] brb [16:46:12] 10MediaWiki-Parser: Allow specifying caption formatting options as part of File: syntax - https://phabricator.wikimedia.org/T162990#3807194 (10Aklapper) p:05Triage>03Lowest [16:46:17] Reedy: in stead of me repeating everything just read the scrollback and stuff please [16:46:34] That's easier said than done [16:46:39] Let me look [16:47:02] my first message was at 17:03 [16:47:09] (UTC+1) [16:47:16] 10MediaWiki-extensions-Scribunto, 10Easy, 10NewPHP: [Scribunto] Warning: count(): Parameter must be an array or an object that implements Countable in PHP 7.2 - https://phabricator.wikimedia.org/T181891#3807195 (10Aklapper) [16:47:41] Albert221: im sorry the all the issues youve been having, hopefully reedy can shed some light [16:47:49] I think to avoid changing `OutputPage->showErrorPage` you may try to do something like `$this->getOutput()->prepareErrorPage(.....)` directly from `showError`. But that starts to get too tricky. We need to check if there are more optimal solutions. [16:49:06] 10Dumps-Generation, 10Patch-For-Review: Do pageslogging dumps in parallel pieces for at least wikidata wiki, perhaps others - https://phabricator.wikimedia.org/T181935#3807210 (10ArielGlenn) T49415 is the ticket where we had various edits that were autpatrolled and filling up the logging table. Time to see wha... [16:49:36] Reedy: heres the GCI task for reference https://codein.withgoogle.com/tasks/5644495049719808/ [16:51:26] Do we have a commit in gerrit? [16:51:30] Or not got that far? [16:51:36] Albert221: ^ [16:52:09] brb, just gonna make a drink [16:59:33] No, I didn't commit anything but I can so you can take a look [16:59:51] should I do this? [17:00:09] Yeah, please [17:00:14] Might help see where you've got upto [17:00:24] Rather than trying to cross reference screenshots etc [17:00:31] And I/other people can leave code review in the correct place [17:04:45] 10MediaWiki-extensions-EducationProgram, 10CheckUser, 10Education-Collab: Bug in Education program Namespace - https://phabricator.wikimedia.org/T181889#3805702 (10Huji) I learned about this thanks to the note posted on CU-l. Can someone please add me to T112751 so I can start working on a patch? [17:06:01] 10Wikimedia-SVG-rendering, 10Wikimedia-Site-requests: Switch existing wiki's from high density logo's to svg - https://phabricator.wikimedia.org/T178942#3807224 (10Urbanecm) [17:06:06] 10MediaWiki-extensions-EducationProgram, 10CheckUser, 10Education-Collab: Bug in Education program Namespace - https://phabricator.wikimedia.org/T181889#3805702 (10Reedy) Done [17:06:10] 10InternetArchiveBot: Feature request for InternetArchiveBot: Dates in talk page section titles - https://phabricator.wikimedia.org/T181941#3807227 (10Ham_II) [17:06:29] 10Wikimedia-SVG-rendering, 10Wikimedia-Site-requests: Switch existing wiki's from high density logo's to svg - https://phabricator.wikimedia.org/T178942#3707851 (10Urbanecm) IMHO #Wikimedia-site-requests is more relevant than #mediawiki-configuration. Feel free to revert if you disagree @Paladox or everyone e... [17:07:25] (03PS1) 10Albert221: [WIP]Un-i18n of exception messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394859 (https://phabricator.wikimedia.org/T59181) [17:07:33] 10MediaWiki-ResourceLoader, 10Wikimedia-General-or-Unknown, 10Browser-Support-Firefox, 10Regression: CSS loading sometimes delayed in Firefox; FOUC reproducibly displayed - https://phabricator.wikimedia.org/T181877#3805184 (10Juergeen) I'm using FF ESR 52.4.0 64-bit with dewiki and enwiki and can ''not'' c... [17:07:39] ^^here's the commit [17:08:15] Albert221: So... Straight off, you've got some code style issues, that will be flagged [17:08:19] That aside... [17:08:26] I don't think we want to remove the messages [17:08:31] Just the links? [17:08:38] (03CR) 10Albert221: "I want to point out that this is under some heavy work in progress" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394859 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [17:08:52] (03CR) 10Reedy: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394859 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [17:08:59] What do you mean Reedy? [17:09:11] "About 10 OAuth messages point to MediaWiki pages such as https://www.mediawiki.org/wiki/Help:OAuth/Errors . These links don't really need to be translated, so they shouldn't be in the list of translatable messages. " [17:09:17] It doesn't say the messages, it says the links [17:09:45] ..oh my god, you gotta be kidding me... [17:10:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP]Un-i18n of exception messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394859 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [17:10:08] Oh wow i mentor that task and didnt read it that way either :/ [17:10:14] not being native sucks cuz you can miss these obvious things ;-; [17:10:30] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#604380 (10Reedy) @Amire80 For clarity, you want the https://www.mediawiki.org/wiki/Hel... [17:10:49] Generally, for messages displayed to users, hardcoding english is bad [17:10:57] If it's a command line script, it's "fine", and that's what we do [17:11:20] (I don't know if anyone has brought up that we should localise maintenance scripts...) [17:12:06] I understood this: " These links don't really need to be translated, so they shouldn't be in the messages." as that the links (links to the i18n strings, so just i18n messages itself) don't need to be translated, so they shouldn't be in the messages (file with translated strings) [17:12:10] Reedy: afaik no, but tbh should we? [17:12:18] Maybe. Maybe not [17:12:24] oh my god I feel so mad at myself right now [17:12:28] For years, we didn't translate the api documentation [17:12:37] Albert221: hey i didnt catch that either [17:12:49] Albert221: I will agree, the task isn't very clear (even more so if you're not familiar with MediaWiki) [17:16:40] so I should wait for Amire80 to respond, right? [17:17:04] You can... But he might not reply till tomorrow or later [17:17:33] nonono, I wasted already much time on this :/ I mean, I was having struggle with what I've mentioned here [17:17:59] Changing the URL to a parameter... [17:18:02] Should be a lot quicker [17:18:35] BTW can I hide wikibugs messages? [17:18:50] Most irc clients have an "ignore" function [17:18:57] So you should be able to ignore it [17:20:13] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/394838 (owner: 10Legoktm) [17:23:27] I read task's message again and now I hopefully understand it correctly [17:25:22] Okay, so I would like to create an utility class which would "translate" strings like "E001" into correct exception links and it would be used both in frontend/ and in backend/; where should I place this class? [17:25:29] I mean where in the directory tree? [17:25:49] Um... I don't think that's the task either [17:26:09] yes yes it is [17:26:19] "They [the links] should be inserted by the software." [17:26:29] But the description says [17:26:30] "such as https://www.mediawiki.org/wiki/Help:OAuth/Errors " [17:27:03] I would suggest there's potential of doing what you're suggesting, translating E001 to a message.. But that is not this task [17:27:17] Hey this is Sombuddha Chakravarty. I am here as a part of Google Code-In task by sugar labs [17:27:53] sombuddha2016: They told you to come visit us? :D [17:28:17] 10MediaWiki-extensions-MediaWikiAuth: Add option to toggle watchlist import - https://phabricator.wikimedia.org/T57641#3807274 (10Skizzerz) 05Open>03Resolved a:03Skizzerz Added $wgMediaWikiAuthImportWatchlist config var in v1.0.0 [17:29:07] Reedy, it's kind of like getting started with IRC task [17:29:25] Reedy: I'm sure I understand it now correctly and what I say is correct. Look at e.g. this: https://translatewiki.net/wiki/MediaWiki:Mwoauthserver-bad-consumer-key/en and hover over that E006 link - it points to the https://www.mediawiki.org/wiki/Help:OAuth/Errors which is what task says [17:29:26] sombuddha2016: Welcome to .. Wikimedia irc [17:29:47] Albert221: The issue is that having the big link text there is confusing to translators [17:30:01] So instead we want to just have $1 in the message [17:30:06] And have $1 be replaced with a link [17:30:10] ahhhhhh [17:30:18] all of that makes sense now! [17:30:29] sorry for my misunderstanding [17:30:53] Like I said above, the task isn't the best written :( [17:31:30] 10MediaWiki-extensions-MediaWikiAuth: Autoconfirm users on import - https://phabricator.wikimedia.org/T57656#3807278 (10Skizzerz) 05Open>03declined The user's registration date and edit count are maintained on import, and existing edits are reattributed (so the maint script which recounts edits won't wipe th... [17:32:09] You probably have to do something along the lines of wfMessage( 'whatever msg is' )->rawParams( Linker::makeExternalLink( 'url here', 'E001', true ) ) [17:32:17] Hi. [17:32:45] Hi Sam210 [17:33:17] (03Abandoned) 10Albert221: [WIP]Un-i18n of exception messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394859 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [17:35:19] I kind of wonder why we even link to error numbers, instead of just saying what the error is [17:40:22] 10MediaWiki-extensions-OAuth: Import errors from https://www.mediawiki.org/wiki/Help:OAuth/Errors and make them translatable - https://phabricator.wikimedia.org/T181943#3807282 (10Reedy) [17:40:28] task files [17:41:15] 10MediaWiki-extensions-OAuth, 10I18n: Import errors from https://www.mediawiki.org/wiki/Help:OAuth/Errors and make them translatable - https://phabricator.wikimedia.org/T181943#3807294 (10Reedy) [17:41:29] 10MediaWiki-extensions-AccessControl: AccessControl does not work with 1.29: "WikiPage.php: Invalid or virtual namespace -1 given" - https://phabricator.wikimedia.org/T172718#3807295 (10Reception123) 05Open>03Resolved a:03Reception123 No longer seems to be a problem in REL1_30. [17:44:43] Well, it was added by Chris in a2278163 [17:44:59] That was really annoying to git blame [17:45:16] https://phabricator.wikimedia.org/T58492 [17:45:28] git blame is annoying within itself [17:46:50] 10MediaWiki-extensions-OAuth, 10I18n: Import errors from https://www.mediawiki.org/wiki/Help:OAuth/Errors and make them translatable - https://phabricator.wikimedia.org/T181943#3807282 (10Bawolff) Looks like they were added in T58492. I guess the idea is that non-english users will encounter them, but when th... [17:47:08] I don't know, the rationale in T58492 doesn't overly make sense to me [17:47:08] T58492: Improve error message phrases - https://phabricator.wikimedia.org/T58492 [17:47:21] I guess it saves a dev from having to grep for the error message [17:47:42] :/ [17:47:45] heh [17:47:46] I think it'd be fine to just kill the error message [17:47:50] *error numbers [17:47:55] Dispay the error code, and the message then? [17:47:58] Saves the grepping [17:48:34] That's kind of what it does, the link goes to a page that's basically a copy paste of the current i18n message [17:49:04] err, nevermind [17:49:22] all the errors are: "Sorry, something went wrong, you'll need to contact the application author for help with this." [17:49:25] That's just stupid [17:51:04] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3807303 (10D3r1ck01) @Reedy, looking at other extensions, extension messages are hardc... [17:51:06] 10MediaWiki-extensions-OAuth, 10I18n: Import errors from https://www.mediawiki.org/wiki/Help:OAuth/Errors and make them translatable - https://phabricator.wikimedia.org/T181943#3807304 (10Bawolff) Having the separate error link seems silly. I think they should be merged into the i18n message. [17:55:35] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: הקובץ לא תקין - https://phabricator.wikimedia.org/T181003#3807314 (10Aklapper) 05Open>03declined Unfortunately closing this report as no further information has been provided. @Yywilk: After you have provided the information asked for and if this stil... [17:56:18] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#604380 (10Bawolff) >>! In T59181#3807303, @D3r1ck01 wrote: > @Reedy, looking at other... [17:57:07] 10MediaWiki-User-preferences, 10Anti-Harassment: Screenful occupied by email prevention textbox in Special:Preferences - https://phabricator.wikimedia.org/T180955#3807320 (10Aklapper) 05Open>03stalled @Nemo_bis: After you have provided the information asked for, please set the task status back to "Open" vi... [17:59:25] So I guess this leaves the question of how Albert221 should proceed with the task. Should we just convert T59181 into T181943? [17:59:25] T59181: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181 [17:59:25] T181943: Import errors from https://www.mediawiki.org/wiki/Help:OAuth/Errors and make them translatable - https://phabricator.wikimedia.org/T181943 [18:00:42] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Tracking: GIF Issues (tracking) - https://phabricator.wikimedia.org/T18456#3807327 (10Aklapper) [18:01:10] d3r1ck: thoughts on that? [18:01:34] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3807328 (10D3r1ck01) Okay @Bawolff, got it! @Albert221, do you understand the ticket b... [18:01:44] bawolff: On the ticket? [18:01:56] https://phabricator.wikimedia.org/T59181? [18:01:59] oh, I didn't see that [18:02:21] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3807330 (10Albert221) > That said, I don't understand why we link at all. I'm almost... [18:03:00] d3r1ck: I more meant, should we decline this task, and get Albert221 to just remove the links instead [18:03:20] Linking to an error message seems kind of silly compared to just saying what the error is [18:03:30] bawolff: I think that's a good point, we can do that. [18:03:34] Exactly, [18:03:36] Look at what I've linked about UX [18:03:39] 10MediaWiki-File-management, 10Commons, 10Multimedia: Superfluous border line in thumbnail - https://phabricator.wikimedia.org/T107742#3807332 (10Aklapper) 05Open>03declined >>! In T107742#3765419, @Aklapper wrote: > That testcase does not exist anymore as it got deleted on https://zh.wikipedia.org/wiki/... [18:03:46] Just a note: I have almost done the task [18:03:47] Albert221: Yeah, I am currently looking at that too [18:03:50] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: the picture in all pages is not displayed - https://phabricator.wikimedia.org/T180895#3807335 (10Aklapper) 05stalled>03declined Unfortunately closing this report as no further information has been provided. @Arseniy2003: After you have provided the in... [18:03:55] Albert221: yes, but I don't really understand how that makes for good UX [18:04:05] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: the picture in all pages is not displayed - https://phabricator.wikimedia.org/T180895#3807337 (10Aklapper) a:05Arseniy2003>03None [18:04:12] imho it makes user less confused about what went wrong [18:04:18] Why? [18:04:28] Here, go to a page with numerous error messages? [18:04:44] I think bawolff has a point [18:05:01] Why embed a link into an error code [18:05:35] Why not just remove the link and then say the error [18:06:15] Albert221: Imagine there were like ~100 errors? Or do you have some thoughts? Cc Reedy [18:07:08] Hmm, that page doesn't even have all of them (e.g. E001) [18:07:23] Yeah! E009 too :) [18:07:40] Maybe bd808 has an opinion on this, I think he touches OAuth occasionally [18:08:34] Okay! So maybe Albert221 can just pick a different ticket to work on while we get everyone's thought on this ticket? [18:08:40] Albert221: what do you think? [18:09:19] (03PS1) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [18:09:39] I've already done the task so it's up to you what you'd do with it :) [18:10:01] (03CR) 10Reedy: [C: 04-1] "Use tabs for indenting, not spaces" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:10:02] 10MediaWiki-General-or-Unknown, 10Wikimedia-Israel-Hackers, 10CSS, 10Easy, and 2 others: Table collapsing button is too close to the capture - add some CSS spacing - https://phabricator.wikimedia.org/T178998#3709793 (10Fomafix) The whitespace before `` and `` should removed from the parser.... [18:11:06] I honestly think we should remove the links ourself but give albert credit still has he did pour time into this [18:11:24] bawolff: boarding an airplane. Ask tgr about oauth ui/ux :) [18:11:27] 10Google-Code-in-2017: Write a user script to replace all images in an article with an image of your choice - https://phabricator.wikimedia.org/T181595#3795540 (10Bawolff) Not to be negative, but is this really a good task? Seems like something that has a high likelyhood to result in accidental vandalism of arti... [18:11:29] 10MediaWiki-extensions-FlaggedRevs: Special:RevisionReview not working : "You have requested an invalid special page." - https://phabricator.wikimedia.org/T151870#3807345 (10Aklapper) 05stalled>03Open [18:11:52] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3807347 (10Albert221) If you'll decide that the links should stay, above is the commit... [18:13:46] (03CR) 10Reedy: [C: 04-1] "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:14:19] what should I do about the GCI task? [18:14:49] Albert221: we will handle this, you have the ticket :) [18:14:56] (03CR) 10jerkins-bot: [V: 04-1] Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:15:03] d3r1ck: whats the plan then? [18:15:54] so I can submit GCI task so that I could work on other task? [18:16:03] I think this patch can be considered: https://gerrit.wikimedia.org/r/#/c/394860/ [18:16:10] Albert221: Can you fix it like Reedy said? [18:16:18] Use tabs to indent and not spaces [18:16:23] Albert221: fix it then yes. [18:16:27] (03CR) 10Brian Wolff: [C: 04-1] "I didn't test this, but I don't think this would work correctly, as the parameters need to be marked as a rawParam not a normal param so t" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:16:32] bawolff: Could we consider this? https://gerrit.wikimedia.org/r/#/c/394860/ [18:16:38] oh yes, sure [18:17:30] Albert221: and also bawolff just made another comment :) [18:17:33] Have a look at that [18:18:36] (03CR) 10Brian Wolff: [C: 04-1] "To clarify, I think what needs to be done is wrap the parameter in Message::rawParam" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:19:43] (03CR) 10Brian Wolff: [C: 04-1] "Additionally, the part should also be inserted by software (be part of the $1)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:20:28] I'm also fine with accepting this patch once the issues are fixed, and leaving it to someone else if they want to remove the links entirely [18:20:49] Indeed.. It's a step in the right direction [18:20:58] Whether we translate them fully later.. isn't an issue [18:21:07] Ugh, there's a lot of hidden gotchas with this [18:22:02] If the is immediately surrounding the link, then it should be part of the $1. But if there's other text inside the I wouldn't worry about it, just for ease of doing this [18:22:25] (03CR) 10Fomafix: Component: Add some CSS spacing before table collapsing button (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394847 (https://phabricator.wikimedia.org/T178998) (owner: 10Eflyjason) [18:22:35] not always surrounds the link so I think we should be consistent about this and leave all s in i18n [18:23:49] (03CR) 10Brian Wolff: [C: 04-1] "Re my prvious comment with the . That's only needed if the entire contents of the are a $1. (e.g. $1" (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [18:28:37] Generally the task is about removing anything that's not translatable from the message, and the is not translatable [18:29:50] 10MediaWiki-API, 10ProofreadPage, 10Wikisource: Cannot delete Page:Pywikibot_test_page_1/1 on en.wikisource.org - https://phabricator.wikimedia.org/T181944#3807348 (10Mpaa) [18:30:30] 10Google-Code-in-2017: Write a user script to replace all images in an article with an image of your choice - https://phabricator.wikimedia.org/T181595#3807360 (10Aklapper) Hmm,isn't this just about your //displaying// of images (via your personal `common.js`)? So "replace" here only means "render something diff... [18:31:34] 10Google-Code-in-2017: Write a user script to replace all images in an article with an image of your choice - https://phabricator.wikimedia.org/T181595#3807361 (10Bawolff) Oh. I assumed replace meant get wikitext of page, regex the images and save page. If its just a view thing, I withdraw my objections :) [18:36:59] TabbyCat: btw for conpherence, long ago phab had a button called "send a message" in profile page [18:37:10] I didn't want to receive a message that way [18:37:24] that's another reason it's there [18:37:33] (no conpherence message notice) [18:37:46] I don't think anyone wants to ever recieve messages via conpherence. They are soooo annoying ;) [18:37:57] Why? I kinda like it [18:38:10] I prefer email [18:38:18] so I have one source of search [18:38:25] revi, yes, but those were removed long ago [18:38:29] the buttons [18:38:34] I was too lazy to remove it [18:38:38] that simple xD [18:38:39] now you have to create "rooms" [18:38:49] (03PS3) 10Skizzerz: Reattribute edits to imported users. [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/394816 [18:38:56] better imo [18:39:03] in any case, I don't mind being contacted via Conph [18:40:26] 10MediaWiki-Uploading, 10Multimedia, 10Easy, 10Google-Code-in-2017: Improve lock file error message for uploading - https://phabricator.wikimedia.org/T181453#3807379 (10Aklapper) >>! In T181453#3806856, @Harjotsingh wrote: > I can mentor this, should I import it in GCI site ? @Harjotsingh: Yes, feel free... [18:46:23] bawolff: as an occassional translator I'd say puzzle messages where you have to translate the main message, the span content and the link text separately are about five times as annoying as having to copy "" into the translation [18:46:43] Extension:Translate handles copying quite well [18:47:03] (03PS1) 10Reedy: RepoGroup::findFile() can and will return false [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/394861 (https://phabricator.wikimedia.org/T181944) [18:47:53] tgr: Do you have thoughts on https://phabricator.wikimedia.org/T59181 in general ? [18:48:26] tgr: In that case, I would assume it would equally apply to copying the link url as well? In which case I'm not sure about the point of that bug [18:48:40] bawolff: look here: https://github.com/wikimedia/mediawiki-extensions-OAuth/blob/master/i18n/en.json#L212 [18:48:56] the element contains not only the link but normal text as well [18:49:31] I meant for the cases where it doesn't [18:50:09] are you really sure that this should not preserve a consistency? [18:50:28] that would result in s present both in i18n messages and in code [18:50:34] just replacing the link URL with $1 is harmless but also pointless IMO [18:51:39] I don't really think consistency of always including the really matters. If the goal is to remove extra untranslatable markup, might as well remove as much of it as possible if it doesn't affect translatable strings [18:51:48] That said, I don't really feel strongly [18:52:04] @seen hoo [18:52:04] TabbyCat: Last time I saw hoo they were quitting the network with reason: Quit: Leaving N/A at 12/3/2017 1:12:05 AM (17h39m59s ago) [18:52:08] * bawolff is not a translator [18:52:15] I will let you know when I see hoo around here [18:52:15] @notify hoo [18:52:44] bawolff, well, you don't have too, you can't translate from English to English :P [18:52:56] TabbyCat: But but en-CA [18:53:06] oh, you Canadian? [18:53:09] We need to put the "u" back in "honour" [18:53:11] yep [18:53:26] and about to aboot? :P [18:53:41] That said, I've never actually "translated" anything to en-CA [18:54:09] TabbyCat: :P [18:54:33] "View History, eh?" [18:54:59] I swear I have canadian friends, and I *never* hear them pronounce aboot [18:55:14] maybe that's for English-speaking people to notice [18:55:33] Yeah, I don't really know where the aboot thing came from. I've never heard anyone say "aboot" [18:55:45] We do say "eh" all the time though [18:56:07] Canada is also a big place, and different parts have different "accents" [18:56:37] West tends to be much more like northern USA, where the east kind of has there own thing. And Newfoundland is something else [18:57:08] lol [18:57:08] Doesn't quiddity say aboot when he's speaking? [18:57:31] I guess Prince Edward is also different [18:57:37] and Quebec [18:57:50] Québec est different [18:57:51] Well Quebec has the french thing [18:58:31] re: mw.org links in general, I think the idea there was to split the user-friendly part of the message from the part relevent to the application developer [18:58:32] yep [18:59:14] The native english part of quebec mostly have the same accent as the rest of english canada in my experiance [18:59:20] the application developer is not a MediaWiki developer so we don't want to force them to read the mediawiki source code [18:59:39] of course, the actual error descriptions on that page are fairly useless [18:59:51] No, especially that accents around Canada are quite different [19:00:37] Closer to Ontario I guess than the Maritimes [19:01:15] And then there is Cape Breton [19:02:28] Which side? [19:02:48] :) The west side is more french [19:03:28] I've never actually been to cape breton. I went to university in halifax, and I just remember anytime there was anyone I totally couldn't understand, they came from cape breton [19:04:36] I live in Halifax, and I've only been to CB once. I know more french people from the west part though [19:05:08] Dalhousie University [19:05:09] ? [19:05:57] yep, Dal [19:06:19] Yukon should be fun bawolff [19:06:30] or the Northwest Terr. [19:06:39] I visited the Yukon once with my family when I was younger [19:06:52] Was it in Winter? [19:06:57] alas no [19:07:03] with mooses :P [19:07:14] I grew up in Fort McMurray, I've had enough of northern winters [19:07:32] * TabbyCat likes cold snowy winters [19:08:13] When it goes down to -45, I no longer like the cold [19:08:28] Celsius or Farenheit? [19:08:32] You know it's cold when you don't have to specify [19:08:33] Celsius [19:08:36] (03PS12) 10Aude: MCR database schema [DNM] [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [19:08:40] wow, -45 [19:08:43] (03PS13) 10Aude: MCR database schema [DNM] [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [19:08:45] but -40 is the cross over point where they are the same [19:08:47] Doesn't matter near -40 [19:09:41] It wasn't that cold all the time, but there was usually a couple day of winter where it got down that far [19:09:54] And it is very miserable [19:10:41] At least it stayed as snow, unlike Halifax where you get inches of ice piling up [19:10:50] 10MediaWiki-extensions-OAuth, 10I18n: Import errors from https://www.mediawiki.org/wiki/Help:OAuth/Errors and make them translatable - https://phabricator.wikimedia.org/T181943#3807391 (10Tgr) The developers here are the people who wrote the OAuth client, so we don't necessarily want to expose them to MediaWik... [19:11:07] Halifax was so weird with the ice [19:11:39] before I went to halifax, I'd never seen the sides of buildings have layers of ice on them [19:12:56] Doesn't happen in Alberta? [19:13:26] I think its because of the moisture. Alberta is too dry for that [19:14:03] We get the water, you the fire it seems [19:14:18] (03CR) 10jerkins-bot: [V: 04-1] MCR database schema [DNM] [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [19:14:29] I guess you also need the temperture to be near the freezing point, so it half melts and freezes on the building - alberta tends not to hover near that point [19:14:38] I've never been to the Prairies [19:15:16] (But I'm going to Saskatoon in a week) [19:15:50] Moose Jaw, saskatchewan has really cool underground tunnels [19:16:08] And also wins for having really cool name [19:16:59] I wish I could visit Canada [19:17:07] no time right now [19:17:26] I've never actually left Canada, but I want to explore! [19:17:35] too much job in the office, too many bad guys [19:17:38] (03PS3) 10Ryan10145: Added Internationalization For Some Strings Bug: T96418 Change-Id: I2da4efff85b71379011026d18ed2129c89f9d2ce [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 (https://phabricator.wikimedia.org/T96418) [19:19:17] @Bawolff: Parlez-vous bien français? [19:19:32] no, I can't speak french [19:19:36] * Reedy grins [19:19:52] Which is kind of sad given I'm currently in montreal [19:21:00] "C'est pas grave tu sais, je t'aime quand-meme." :P [19:21:13] lol [19:21:28] I had to take french as a second language between grade 4 - 9 and none of it stuck. It was also terrible quality alberta french [19:21:38] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3807412 (10Tgr) Hardcoding URLs in the software doesn't seem nice - maybe some site wa... [19:21:42] (03CR) 10D3r1ck01: "recheck" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 (https://phabricator.wikimedia.org/T96418) (owner: 10Ryan10145) [19:23:58] As I'm Acadian, I got exceptions from French class [19:24:26] I like Alberta French though [19:24:37] $ git review [19:24:39] Could not connect to gerrit. [19:24:42] *grr* [19:25:20] What's the better alternative to Gerrit? (There isn't really-they all suck) [19:25:33] It's mostly preference [19:25:34] (03CR) 10D3r1ck01: "Minor fix while I make the check" (031 comment) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 (https://phabricator.wikimedia.org/T96418) (owner: 10Ryan10145) [19:25:40] We can use phabricators differential [19:25:45] Then there's gitlabs github clone thing [19:25:49] I prefer Gerrit over Differential [19:26:00] I rather not download another program [19:26:08] Arcanist I mean [19:26:19] The linux people seem to like using mailing lists [19:26:19] SamanthaNguyen: Around? [19:26:31] That gets rid of having other programs altogether! [19:26:51] 10MediaWiki-Special-pages, 10Timeless: Special:SpecialPages on skin Timeless has bad aligned two column layout - https://phabricator.wikimedia.org/T181947#3807416 (10Fomafix) [19:27:03] (03PS1) 10Fomafix: Move two-column to the
    element [core] - 10https://gerrit.wikimedia.org/r/394863 (https://phabricator.wikimedia.org/T181947) [19:28:24] I'd like to use plain git for Differential, to have everything on Phabricator without arc [19:28:40] (03CR) 10Fomafix: "Maybe the element
    can omitted and the class can added to
      ." [core] - 10https://gerrit.wikimedia.org/r/394863 (https://phabricator.wikimedia.org/T181947) (owner: 10Fomafix) [19:29:09] rlot: yeah, whats up? [19:29:25] But Gerrit is still better than Rietveld or Github for CR [19:30:12] why do you think Gerrit > GitHub in terms of CR? I'm curious [19:30:35] SamanthaNguyen: Could you take a look at https://phabricator.wikimedia.org/T156430 [19:31:48] Everything should be on phabricator, just can't do review there [19:31:57] Even abandoned patches in gerrit are on phabricator [19:33:20] Yeah. got a notification for it earlier, I was planning to look at it another day.. so I guess I'll look at it today [19:33:30] I dislike the extra forking step for the web, and then the features are just lacking, only simple actions (or useless ones) can be done. Gerrit can do much more [19:33:40] I'm most likely going to re-open the ticket [19:34:40] Phabricator can do review, just that migrating there would be quite involved [19:35:27] (03PS2) 10Fomafix: SpecialPages: Omit the
      element [core] - 10https://gerrit.wikimedia.org/r/394863 (https://phabricator.wikimedia.org/T181947) [19:35:53] Ebe123: svn/Extension:CodeReview -> git/gerrit was hardly simple :) [19:36:33] I hate them all [19:36:47] Precisely, it would be quite involved/complicated. (I wasn't actually developing back then...) [19:36:48] Extension:Codereview 4evah [19:36:58] Dislike them all as well [19:37:11] you know, the extension wasn't so bad [19:37:15] cc: bri on [19:37:25] aude, when you fix the wikidata ci issue, maybe you can re-grant +2 to https://gerrit.wikimedia.org/r/#/c/394848/ ? Thanks [19:38:58] (03CR) 10Brian Wolff: [C: 04-1] "Sorry to be picky" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/394753 (https://phabricator.wikimedia.org/T181673) (owner: 10Lengyue) [19:40:34] Ebe123: bonjour alors, depuis Paris :) [19:41:18] Ah, je n'ai jamais été à Paris :( [19:41:43] apergos: I certainly got my commits merged faster ;) [19:41:50] lol [19:42:00] well that might have to do with the size of the community back in the day [19:42:10] and having an in with the person doing the merges :-P [19:43:34] Well and not having a review step [19:43:37] Does qqq have some syntax guidelines or just "$1 - doing x" for parameters? [19:43:58] Its basically wikitext [19:44:12] so you can do \n* $1 - description of parameter [19:44:45] We can see a lot of people who live all over the world in this community [19:47:12] Making our patches merged slower /s [19:47:18] (03PS1) 10Brian Wolff: Avoid duplication in output [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/394865 [19:47:21] (03PS1) 10Brian Wolff: Make error messages from hooks be in extension instead of core [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/394866 [19:47:22] (03PS1) 10Brian Wolff: Make unit tests for extension.json always work [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/394867 [19:47:25] (03PS1) 10Brian Wolff: Add ARRAY_OK flag for functions that are safe with arrays [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/394868 [19:47:27] (03PS1) 10Brian Wolff: Fix bug where non-local variables are treated like local [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/394869 [19:47:29] (03PS1) 10Brian Wolff: Add support for IDatabase::select style arguments [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/394870 [19:47:48] --^ see its like E:CodeReview days all over again [19:51:43] Mind looking at gerrit.wikimedia.org/r/375618 ? 3 months for a very small thing! [19:52:48] (03PS2) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [19:53:23] bawolff, Zppix: take a look! https://gerrit.wikimedia.org/r/#/c/394860/ [19:53:59] Albert221: looking [19:54:10] oh, I see there is still issue with tabs :/ [19:54:18] dammit you PhpStorm [19:54:53] Albert221: fix that then ping me again please [19:55:00] 10Design, 10TCB-Team, 10WMDE-Design, 10German-Community-Wishlist: Connect moved paragraphs by arrows - https://phabricator.wikimedia.org/T140340#3807440 (10daniel) @Alsee I thought so too, until I clicked one of the arrows. [19:55:51] Ebe123: I'm not sure I understand why we would show the protect log in that case [19:56:16] oh nevermind, I see now [19:56:27] I was reading too fast [19:56:45] bawolff: i got an (probably stupid) question... can you tell me what you guys look for when reviewing exts for security issues? [19:57:00] You can pm if you need [19:57:02] (03PS3) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [19:57:03] Zppix: Security issues! [19:57:06] jk [19:57:10] That's the stupid answer [19:57:20] To give a serious answer [19:57:33] Mostly we look through all the code to make sure it makes sense [19:58:01] https://www.mediawiki.org/wiki/Security_for_developers lists some stuff. [19:58:05] If i don't understand what the code is doing, than theres a possibility the part i don't understand is exploitable [19:58:40] Then after that, we look for specific issues - XSS - make sure everything is escaped. Make sure i18n messages use ->escaped() where appropriate and ->text() where appropriate [19:58:49] Check all the db accesses for sql injection [19:59:05] If it does its own form handling, check the it checks edit tokens, requires post on form submit [19:59:42] (03PS4) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [19:59:56] bawolff: sweet thanks! [20:00:03] Zppix, bawolff: done, without any tab issues this time [20:00:04] The biggest thing to check for is XSS. Usually that's the most likely part where people make a mistake [20:00:17] Albert221: looking [20:00:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I'm also not really sure, if that change has some side-effects somewhere :/" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) (owner: 10Pppery) [20:00:35] (03CR) 10Zppix: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:01:04] 10MediaWiki-Internationalization, 10translatewiki.net, 10I18n: Rebuild all message files - https://phabricator.wikimedia.org/T162009#3807444 (10Nikerabbit) a:03Nikerabbit There has likely multiple causes for files not getting exported. Special codes such as `en-gb` need to be added to the `always-export-la... [20:01:06] andre__: ty as well [20:01:38] * Albert221 is sitting with fingers crossed. [20:01:48] (03CR) 10jerkins-bot: [V: 04-1] Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:03:26] (03CR) 10Florianschmidtwelzow: [C: 04-1] "some minor things :)" (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) (owner: 10Divadsn) [20:03:26] Albert221: 20:01:45 129 | WARNING | Line exceeds 100 characters; contains 117 characters [20:03:55] extensions/OAuth/api/MWOAuthSessionProvider.php [20:04:03] how can I run these tests by myself? [20:04:24] (03PS2) 10Brian Wolff: Show protection log on every use of moveddeleted-notice [core] - 10https://gerrit.wikimedia.org/r/375618 (https://phabricator.wikimedia.org/T174889) (owner: 10Ebe123) [20:05:06] Albert221: composer phpcs [20:05:15] Also, if you do [20:05:18] composer fix [20:05:27] it will auto fix certain issues (not all of them) [20:06:27] 10ContentTranslation, 10Dumps-Generation, 10Language-2017-Oct-Dec, 10MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)): Content translation dumps failing due to excessive memory usage - https://phabricator.wikimedia.org/T180264#3807447 (10ArielGlenn) Results after deployement of the above fix:... [20:06:32] Zppix, sure sure, yw :) [20:09:13] andre__: also (sorry for pinging again) on that etherpad my irc channel suggestion wasnt added to it so i went ahead and added that i hope that was okay. [20:10:15] (03PS5) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [20:10:37] Zppix: fixed [20:11:04] (03CR) 10Zppix: "Recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:11:13] Zppix, sure, thank you for following up! [20:11:18] No [20:11:20] Problem [20:13:47] (03CR) 10Zppix: [C: 031] "Ready from my POV, lets wait for a second opinion though." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:14:08] d3r1ck: bawolff Reedy want to review ^ [20:15:28] just a minute [20:24:14] Zppix: Let me have a look :) [20:26:17] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3807451 (10Mvolz) >>! In T179691#3806673, @AnmolSingh wrote: > Thanks for the feedback @Molvz > Here is an updated version using curly brackets, and nimbus over "o".... [20:28:43] (03PS3) 10Divadsn: Use png as fallback when svg fails to load [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) [20:29:19] (03CR) 10Brian Wolff: [C: 032] "Hmm, the "This page has been deleted" part is a bit misleading, but I guess its ok." [core] - 10https://gerrit.wikimedia.org/r/375618 (https://phabricator.wikimedia.org/T174889) (owner: 10Ebe123) [20:30:47] (03CR) 10Divadsn: "Thanks for pointing out, I was using " to avoid escaping, but forgot about the code style ^^" (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) (owner: 10Divadsn) [20:32:36] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3807464 (10Mvolz) >>! In T179691#3806093, @Framawiki wrote: > I've edited the task description to be consistent with {T179677}. @Framawiki Thanks - is there a reason... [20:35:06] (03CR) 10jerkins-bot: [V: 04-1] Use png as fallback when svg fails to load [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) (owner: 10Divadsn) [20:35:17] (03Merged) 10jenkins-bot: Show protection log on every use of moveddeleted-notice [core] - 10https://gerrit.wikimedia.org/r/375618 (https://phabricator.wikimedia.org/T174889) (owner: 10Ebe123) [20:35:38] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3807467 (10Framawiki) >>! In T179691#3807464, @Mvolz wrote: > > @Framawiki Thanks - is there a reason why we're uploading to phab instead of commons in the initial s... [20:35:58] FlorianSW, about those minor code style issues, should I maybe remove those whitespaces between the brackets too? [20:36:25] Oh, Jenkins downvoted it, nevermind :) [20:37:10] divadsn: yes, I think so :) This is inline-JavaScript, so having a code-style there increases the size of the delivered code (not that much, but it does) :) [20:37:10] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3807468 (10AnmolSingh) Thanks for your feedback about books, it helped alot. I will submit it now! Cheers [20:37:17] 10MediaWiki-History-or-Diffs, 10Patch-For-Review: Deletion notice box on history pages shows "protection" at the top, even though the actual log is not - https://phabricator.wikimedia.org/T174889#3807469 (10Ebe123) [20:37:28] (03CR) 10D3r1ck01: [C: 031] "LGTM" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:37:30] 10MediaWiki-History-or-Diffs, 10Patch-For-Review: Deletion notice box on history pages shows "protection" at the top, even though the actual log is not - https://phabricator.wikimedia.org/T174889#3576006 (10Ebe123) 05Open>03Resolved a:03Ebe123 [20:37:33] 10Accuracy-Review-of-Wikipedias: Improve the UI design of the app - https://phabricator.wikimedia.org/T141295#3807472 (10Jsalsman) a:05prnk28>03None @Aklapper I got that. Sahith (@SND96 on Github) produced a speech-enabled training system to help people use @prnk28's system last summer, but couldn't get it w... [20:37:35] (03CR) 10Brian Wolff: [C: 04-1] Move links from i18n to software (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:37:47] 10MediaWiki-extensions-WikibaseRepository, 10Discovery, 10Elasticsearch, 10Wikidata, and 4 others: Emptying description on Wikidata doesn't remove it from ElasticSearch database used by wbsearchentities - https://phabricator.wikimedia.org/T180382#3807474 (10Sjoerddebruin) This is still happening when mass-... [20:38:36] 10Accuracy-Review-of-Wikipedias: Improve the UI design of the Accuracy Review of Wikipedias Flask app - https://phabricator.wikimedia.org/T141295#3807479 (10Jsalsman) [20:39:26] (03PS4) 10Divadsn: Use png as fallback when svg fails to load [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) [20:40:18] bawolff: oh, that solution makes it completely right! Maybe it should be added here: https://www.mediawiki.org/wiki/Manual:Messages_API ? [20:40:28] (03PS14) 10Aude: MCR database schema [DNM] [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [20:40:31] I was looking at this documentation for some escaping method but didn't find any [20:41:07] Its kind of a frowned upon way of doing things, but its better than duplicating all of that other function [20:41:44] yes, you are totally right [20:41:45] ! [20:41:46] Hello, I'm wm-bot. The database for this channel is published at http://wm-bot.wmflabs.org/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [20:42:26] (03PS6) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [20:42:28] (03CR) 10Divadsn: "Now it should be ok, Gerrit isn't optimized well on mobile devices." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) (owner: 10Divadsn) [20:43:06] bawolff: can I create an issue somewhere to state that this method should be added to docs? [20:43:37] I'm not sure if its intentionally undocumented in order to discourage people from using it when ->rawParams() is an option [20:43:40] FlorianSW, ok, will do it now :) [20:43:43] (03CR) 10jenkins-bot: Show protection log on every use of moveddeleted-notice [core] - 10https://gerrit.wikimedia.org/r/375618 (https://phabricator.wikimedia.org/T174889) (owner: 10Ebe123) [20:43:44] but, yeah, feel free to file a bug [20:44:52] (03PS5) 10Divadsn: Use png as fallback when svg fails to load [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/394845 (https://phabricator.wikimedia.org/T166684) [20:45:53] andre__, is the beta version of Gerrit still available with the optimized mobile view? [20:45:54] 10Documentation: Missing docs of Message::rawParam - https://phabricator.wikimedia.org/T181949#3807483 (10Albert221) [20:46:13] bawloff: I fixed that fyi [20:46:30] (03CR) 10jerkins-bot: [V: 04-1] MCR database schema [DNM] [core] - 10https://gerrit.wikimedia.org/r/378724 (https://phabricator.wikimedia.org/T174028) (owner: 10Daniel Kinzler) [20:51:36] Hi [20:51:40] hello! [20:52:20] I have problem, so I think, that maybe you can help me. [20:52:22] EliteBook__: Hello! [20:52:30] EliteBook__: whats the matter? [20:52:32] what is the problem? [20:53:05] So, do you know Docker CE? [20:53:09] I know [20:53:24] I have problem with him [20:53:30] docker ce? [20:53:35] ya [20:53:36] ce [20:53:40] what is your problem exactly? [20:53:53] What is that?/ [20:54:11] community edition [20:54:13] it is a containerization tool [20:54:25] Oh [20:54:26] used by everyone basically [20:54:30] Albert221: has someone added you to the CI whitelist already? [20:54:35] I just realized 🤦‍♂️ [20:54:43] tgr: i was going to [20:54:51] tgr: I don't know, probably not [20:54:57] I double click on installer and nothing [20:54:58] thx Zppix [20:55:25] what was that Emoji because I see a bush? :D [20:56:36] 10Design, 10Citoid, 10VisualEditor, 10Google-Code-in-2017, 10User-Ryasmeen: Propose a logo for the Citoid service - https://phabricator.wikimedia.org/T179691#3807495 (10Mvolz) 05Open>03Resolved [20:56:45] (03CR) 10Gergő Tisza: [C: 04-1] "Please don't change $exception->msg after it has been already created. It won't change the exception message (as seen by PHP) and probably" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [20:57:36] ^now I know the solution on how to fix this [20:58:07] Solution for me? [21:02:15] (03CR) 10Gergő Tisza: [C: 04-1] Move links from i18n to software (032 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [21:02:31] tgr: Albert221 https://gerrit.wikimedia.org/r/#/c/394872/ [21:02:53] Albert221: it was a facepalm [21:03:29] EliteBook__: do you have a problem with the MediaWiki docker container? [21:04:05] (03PS1) 10Chad: Revert "Special:Preferences: Use OOjs UI" and follow-ups [core] (wmf/1.31.0-wmf.10) - 10https://gerrit.wikimedia.org/r/394874 (https://phabricator.wikimedia.org/T117781) [21:04:16] What should I do with that: https://gerrit.wikimedia.org/r/#/c/394860/6/frontend/specialpages/SpecialMWOAuth.php@138 ? [21:04:26] Nope, I have problem with Docker CE for Windows (docker documentation) [21:04:32] https://docs.docker.com/ [21:04:37] This [21:04:48] probably better to ask on a Docker support forum then [21:05:09] Ok ok [21:05:10] thanks [21:08:10] Albert221: create a new message [21:12:41] 10MediaWiki-extensions-Babel, 10MediaWiki-extensions-WikibaseRepository, 10GlobalUserPage, 10Wikidata, and 3 others: [Story] Setting languages with Babel boxes does not work for global user page - https://phabricator.wikimedia.org/T95877#1202430 (10Envlh) Sorry, I didn't see this task as I wasn't added to... [21:13:25] (03PS7) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [21:15:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/394873 (owner: 10L10n-bot) [21:15:05] BTW, why Wikimedia CS insists spaces surrounding params? I've never met with that before anywhere except in WordPress [21:16:37] in hindsight the better advice would have been "just get rid of it" [21:16:53] that whole "contact support" thing makes no sense whatsoever [21:18:19] we don't have any real support, to the extent we do that link is completely unhelpful in finding it, and that error is not typically something we can help with anyway [21:21:46] (03CR) 10Gergő Tisza: Move links from i18n to software (032 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [21:22:24] (03CR) 10Legoktm: [C: 04-1] "We should probably pass in a LinkRenderer to the hook as well. Otherwise this looks good to me. I'd like to see the AbuseFilter patch upda" [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [21:22:40] tgr: you are Gergo, right? [21:22:53] yeah [21:22:55] (03CR) 10Legoktm: [C: 032] Format filter IDs as numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/390621 (owner: 10Matěj Suchánek) [21:23:12] (03CR) 10Legoktm: "recheck" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [21:23:15] do you think we should just get rid of the sentence that tells about the support? [21:24:15] yes, just replace it with something like "contact the application author" with no link [21:24:51] You could make it so the application author could supply a link? [21:24:57] (03CR) 10jerkins-bot: [V: 04-1] extensions/Linter: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [21:26:36] (03CR) 10Tpt: [C: 032] RepoGroup::findFile() can and will return false [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/394861 (https://phabricator.wikimedia.org/T181944) (owner: 10Reedy) [21:26:52] in that secific error we probably don't know which application we are talking about [21:26:52] (03PS3) 10Pppery: Parse "show/hide " labels on Watchlist and RecentChanges [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) [21:26:55] (03Abandoned) 10Tpt: Do not fail if no image is built from the Page: page name [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/394770 (https://phabricator.wikimedia.org/T181868) (owner: 10Tpt) [21:28:27] (03CR) 10Legoktm: "recheck" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [21:28:59] (03CR) 10Pppery: "Every change I make seems to have at least one small mistake in it" [core] - 10https://gerrit.wikimedia.org/r/394832 (https://phabricator.wikimedia.org/T142406) (owner: 10Pppery) [21:29:21] (03Merged) 10jenkins-bot: Format filter IDs as numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/390621 (owner: 10Matěj Suchánek) [21:29:23] (03Merged) 10jenkins-bot: RepoGroup::findFile() can and will return false [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/394861 (https://phabricator.wikimedia.org/T181944) (owner: 10Reedy) [21:33:47] (03PS8) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [21:34:25] Would "Contact the application's manufacturer." be any good? [21:38:13] Albert221: no [21:38:18] Albert221: developer [21:38:53] (03PS9) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [21:43:49] 10MediaWiki-extensions-WikibaseRepository, 10Discovery, 10Elasticsearch, 10Wikidata, and 4 others: Emptying description on Wikidata doesn't remove it from ElasticSearch database used by wbsearchentities - https://phabricator.wikimedia.org/T180382#3807523 (10Smalyshev) 05Resolved>03Open Indeed, https://... [21:54:08] can someone take a look? Zppix, d3r1ck, tgr? https://gerrit.wikimedia.org/r/#/c/394860/ [21:56:29] (03CR) 10Zppix: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [21:56:35] Looking [21:57:10] Albert221: looks good to me. Any reason you skipped the other E messages? [21:58:11] Lgtm [21:58:21] (03CR) 10Gergő Tisza: Move links from i18n to software (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [21:58:24] (03CR) 10Zppix: [C: 031] "LGTM" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [22:01:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/394887 (owner: 10L10n-bot) [22:13:49] (03PS10) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [22:13:57] ^pushed and I'm submitting GCI task :) [22:17:57] Zppix, tgr [22:18:28] Ill approve it [22:18:35] tgr that patch okay? [22:20:20] the parameters for mwoauth-bad-request-missing-params should be updated I think [22:20:30] the parameters in qqq I mean [22:20:46] (03PS4) 10Ryan10145: Added Internationalization For Some Strings [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/394777 (https://phabricator.wikimedia.org/T96418) [22:20:59] tgr you're absolutely right [22:21:03] let me fix it quickly [22:21:31] Albert221: while you are there can you fix the parameter documentation for mwoauth-bad-request-invalid-action-contact ? [22:21:45] (03PS11) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [22:22:00] oh, too fast, but yes [22:22:09] $1 is an URL but $2 is a link [22:23:05] (03PS12) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [22:23:50] eh, please tell me that having that many Patch Sets is nothing wrong [22:24:37] the record is around 200 I think? [22:24:49] okay so I'm still safe I guess [22:25:07] (03PS13) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [22:25:26] ^that is finally a final link to finally finnish the task [22:26:04] your changes are not coming through [22:26:15] did you forget to git add something? [22:26:44] *facepalm* sorry I didn't sleep much yesterday and it's somewhat late now [22:27:06] (03PS14) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [22:27:44] ^okay, this patch is more final than the previous one [22:28:33] Albert221: FWIW, numerous patches aren't a problem. As long as you're listening to what people are telling you, and making the changes etc :) [22:28:35] the parameter for mwoauth-bad-request-missing-params is $2 [22:30:24] (03PS15) 10Albert221: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) [22:30:35] I'll do 10 push-ups if it's not done now [22:31:43] (03CR) 10Reedy: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [22:31:48] Let's add our lord and hater [22:31:57] (03CR) 10Gergő Tisza: [C: 032] Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [22:32:32] Albert221: are you going to work on the other EXXX messages as well? [22:32:46] not tonight [22:32:58] heh [22:33:08] Albert221: approved [22:33:12] if there are other things to do, sure, just leave me an url so I can claim the task [22:33:18] Zppix: ohhhh, finally <3 [22:33:28] Your patch finally got merged ;) [22:33:34] (03Merged) 10jenkins-bot: Move links from i18n to software [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/394860 (https://phabricator.wikimedia.org/T59181) (owner: 10Albert221) [22:33:50] Sorry for the long long long line of fix that fix this Albert221 [22:34:33] I dont think this task should of been made accessiable yet, it was so unclear :/ [22:36:50] 10MediaWiki-extensions-OAuth, 10Easy, 10Google-Code-in-2017, 10I18n, 10Patch-For-Review: OAuth messages that point to error descriptions in mediawiki.org need to be simplified - https://phabricator.wikimedia.org/T59181#3807533 (10Tgr) The other three messages with EXXX error codes in them should probably... [22:37:19] thank you for your patience, have a good night :) [22:37:26] thanks for the patch! [22:37:47] Albert221: night! [22:38:13] i wonder how many other gci tasks are unclear.... [22:38:30] Probably many [22:38:34] It always happens [22:38:53] if other tasks which I'll claim will be unclear, I will definetely let you know! [22:39:09] Reedy: yes but I dont want students wasting time on doing something that the task doesnt say to [22:39:10] Yeah, please do [22:39:19] It happens [22:39:26] It always happens [22:39:38] Language barriers and such [22:39:41] how many tasks do you have available for us, the students? [22:39:43] Albert221: if no one is around when that happens just say something on the task page and someone should see that [22:39:57] Albert221: let me look [22:39:58] Zppix: okay dokey! [22:40:14] Tasks 1-100 of 194 [22:40:43] Albert221: roughly 100+ some arent published due to gci guidelines or other reasons [22:41:30] woah, if in 14 days 100+ tasks are done, will this other "100+" be enough for the rest of GCI contest? [22:42:04] Albert221: we have thousands of tasks on our bugreporter im sure we could source some more tasks if for some reason we get low [22:44:11] I'm just curious, how does your dashboard look like? [22:44:23] I really like the UX of GCI website [22:45:29] Albert221: nothing real special really [22:48:09] Albert221: its just an activity feed, stats on students waiting for review, how many students are working on tasks you mentor, how many tasks you mentor are left to claim, how many tasks youve interacted with, a roadmap like calender of the contest schedule, i can also access a list of students who have claimed tasks in the organization, i can see all wikimedia tasks, create tasks, see each students tasks "instance" (where i approve, ask for [22:48:10] more work, add time, etc) [23:26:45] (03PS6) 10Legoktm: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [23:27:15] (03CR) 10Legoktm: [C: 032] "I made a slight adjustment to the commit message. I tested the patch and it looks good, congrats, and thanks for the contribution!" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [23:27:37] 10Wikimedia-General-or-Unknown, 10Technical-Debt, 10Wikimedia-log-errors: Fix MediaWiki deprecated calls in Wikimedia production, 2017-12-01 - https://phabricator.wikimedia.org/T181834#3807568 (10Legoktm) [23:27:39] 10MediaWiki-extensions-Linter, 10Google-Code-in-2017, 10Patch-For-Review, 10Wikimedia-log-errors: Stop using deprecated ApiBase::dieUsage() in Linter extension - https://phabricator.wikimedia.org/T181758#3807566 (10Legoktm) 05Open>03Resolved a:03Haikalizz [23:28:46] (03Merged) 10jenkins-bot: Replace deprecated usage of ApiBase::dieUsage() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/394821 (https://phabricator.wikimedia.org/T181758) (owner: 10Haikalizz) [23:30:46] 10MediaWiki-Cache, 10MediaWiki-Vagrant, 10Performance-Team (Radar), 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: MediaWiki core Selenium tests fail when targeting Vagrant - https://phabricator.wikimedia.org/T180035#3744406 (10greg) it's in our respective done columns, so is it resolved? :)... [23:32:54] Hi! My name is Jakub and im from Poland. Im here to complete Google Code In challenge. [23:35:37] :) [23:36:12] TakiTam: welcome [23:39:30] TakiTam: Welcome!