[00:02:09] (03Merged) 10jenkins-bot: Add documentation for 'autoFocus' and 'width' [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/376854 (owner: 10Mattflaschen) [00:02:13] (03CR) 10jenkins-bot: Add documentation for 'autoFocus' and 'width' [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/376854 (owner: 10Mattflaschen) [00:06:40] Krinkle: hey... quick cross-browser cors-related question... I'm getting an error on Mobile Safari when trying to log an event using EventLogging. Loading from the mobile URL, but the event log URL has the desktop hostname. The error I get is, "Origin [desktop URL] is not allowed by Access-Control-Allow-Origin." [00:07:15] (03PS3) 10Legoktm: registration: Improve error message for invalid "callback" in extension.json [core] - 10https://gerrit.wikimedia.org/r/376338 (owner: 10Umherirrender) [00:07:23] (03CR) 10Legoktm: [C: 032] "It looks good enough to me." [core] - 10https://gerrit.wikimedia.org/r/376338 (owner: 10Umherirrender) [00:07:38] Not sure which request could be setting a header wrong, or if maybe it's a Safari bug or quirk [00:13:48] (03Merged) 10jenkins-bot: registration: Improve error message for invalid "callback" in extension.json [core] - 10https://gerrit.wikimedia.org/r/376338 (owner: 10Umherirrender) [00:19:37] (03PS1) 10Legoktm: Avoid using the deprecated ParserCache::singleton() [core] - 10https://gerrit.wikimedia.org/r/376855 [00:22:56] (03CR) 10jenkins-bot: registration: Improve error message for invalid "callback" in extension.json [core] - 10https://gerrit.wikimedia.org/r/376338 (owner: 10Umherirrender) [00:24:48] (03PS1) 10Mooeypoo: RCFilters: Add an initialization hook [core] - 10https://gerrit.wikimedia.org/r/376857 [00:29:55] 10MediaWiki-Database, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593348 (10aaron) [00:36:08] 10Design, 10MediaWiki-Interface, 10UI-Standardization, 10Patch-For-Review: inconsistent close icon "X" in MediaWiki interfaces - https://phabricator.wikimedia.org/T50067#3593361 (10Volker_E) [00:39:37] (03CR) 10Catrope: [C: 032] Prioritize the secondary link, so it shows (without needing ... menu) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/376646 (https://phabricator.wikimedia.org/T174927) (owner: 10Mattflaschen) [00:39:42] (03CR) 10Mattflaschen: [C: 04-1] RCFilters: Add an initialization hook (032 comments) [core] - 10https://gerrit.wikimedia.org/r/376857 (owner: 10Mooeypoo) [00:39:52] (03CR) 10Mooeypoo: RCFilters: Add introduction tour when RCFilters comes out of beta (033 comments) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/375097 (https://phabricator.wikimedia.org/T169613) (owner: 10Mooeypoo) [00:40:03] (03PS15) 10Mooeypoo: RCFilters: Add introduction tour when RCFilters comes out of beta [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/375097 (https://phabricator.wikimedia.org/T169613) [00:41:04] (03Merged) 10jenkins-bot: Prioritize the secondary link, so it shows (without needing ... menu) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/376646 (https://phabricator.wikimedia.org/T174927) (owner: 10Mattflaschen) [00:42:46] (03CR) 10Mooeypoo: RCFilters: Add an initialization hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/376857 (owner: 10Mooeypoo) [00:51:43] (03PS2) 10Mooeypoo: RCFilters: Add an initialization hook [core] - 10https://gerrit.wikimedia.org/r/376857 [00:52:33] legoktm: anyone familiar with the PG updater changes lately? I guess I can tried to debug it. [00:52:52] (03PS3) 10Mooeypoo: RCFilters: Add an initialization hook [core] - 10https://gerrit.wikimedia.org/r/376857 [00:53:00] comment stuff was done by anomie [00:54:34] 10MediaWiki-History-or-Diffs, 10MediaWiki-Recent-changes: Improve [rolblack] logic when it encounters null edits - https://phabricator.wikimedia.org/T175437#3593376 (10aaron) [00:56:25] (03PS4) 10Mooeypoo: RCFilters: Add an initialization hook [core] - 10https://gerrit.wikimedia.org/r/376857 [00:57:06] 10MediaWiki-Core-Tests: Do not initialise the database in tests when not needed - https://phabricator.wikimedia.org/T155147#2935390 (10Tgr) Another annoying thing with unnecessary DB initialization is that it can generate lots of DB errors when tests exit in unexpected ways. E.g. right now I am getting a bunch o... [01:02:22] 10Phabricator, 10Scap: scap should provide a way to skip symlink-swapping in promote - https://phabricator.wikimedia.org/T172486#3593385 (10mmodell) [01:04:08] (03PS1) 10EBernhardson: Only show human relevance survey to a browser every 2 days [extensions/WikimediaEvents] (wmf/1.30.0-wmf.16) - 10https://gerrit.wikimedia.org/r/376858 [01:04:35] (03PS1) 10MarkAHershberger: replace parent::execute with something that makes more sense. [extensions/WhoIsWatching] (REL1_28) - 10https://gerrit.wikimedia.org/r/376859 [01:04:42] (03PS1) 10MaxSem: Deprecate wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/376860 [01:04:56] AaronSchulz, ^ [01:05:37] (03CR) 10jerkins-bot: [V: 04-1] replace parent::execute with something that makes more sense. [extensions/WhoIsWatching] (REL1_28) - 10https://gerrit.wikimedia.org/r/376859 (owner: 10MarkAHershberger) [01:05:52] (03CR) 10EBernhardson: [C: 032] Only show human relevance survey to a browser every 2 days [extensions/WikimediaEvents] (wmf/1.30.0-wmf.16) - 10https://gerrit.wikimedia.org/r/376858 (owner: 10EBernhardson) [01:06:33] (03PS1) 10EBernhardson: Only show human relevance survey to a browser every 2 days [extensions/WikimediaEvents] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376861 [01:06:52] (03Abandoned) 10EBernhardson: Only show human relevance survey to a browser every 2 days [extensions/WikimediaEvents] (wmf/1.30.0-wmf.16) - 10https://gerrit.wikimedia.org/r/376858 (owner: 10EBernhardson) [01:07:12] (03CR) 10MarkAHershberger: [V: 032 C: 032] replace parent::execute with something that makes more sense. [extensions/WhoIsWatching] (REL1_28) - 10https://gerrit.wikimedia.org/r/376859 (owner: 10MarkAHershberger) [01:07:55] (03PS1) 10Mooeypoo: Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) [01:08:12] 10MediaWiki-History-or-Diffs, 10MediaWiki-Recent-changes: Improve [rolblack] logic when it encounters null edits - https://phabricator.wikimedia.org/T175437#3593391 (10aaron) [01:08:19] (03CR) 10jerkins-bot: [V: 04-1] replace parent::execute with something that makes more sense. [extensions/WhoIsWatching] (REL1_28) - 10https://gerrit.wikimedia.org/r/376859 (owner: 10MarkAHershberger) [01:08:48] (03CR) 10EBernhardson: [C: 032] Only show human relevance survey to a browser every 2 days [extensions/WikimediaEvents] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376861 (owner: 10EBernhardson) [01:09:10] * Note: PHP might die due to parsing errors in some cases before it ever [01:09:10] * manages to call this function, such is life [01:09:53] (03PS1) 10MarkAHershberger: replace parent::execute with something that makes more sense. [extensions/WhoIsWatching] (REL1_27) - 10https://gerrit.wikimedia.org/r/376863 [01:10:02] (03CR) 10MarkAHershberger: [V: 032 C: 032] replace parent::execute with something that makes more sense. [extensions/WhoIsWatching] (REL1_27) - 10https://gerrit.wikimedia.org/r/376863 (owner: 10MarkAHershberger) [01:10:04] (03CR) 10Legoktm: [C: 032] "This is pretty unrealistic to have ever been useful because PHP would have probably bailed out on some syntax problem before making it tha" [core] - 10https://gerrit.wikimedia.org/r/376860 (owner: 10MaxSem) [01:10:19] (03Merged) 10jenkins-bot: Only show human relevance survey to a browser every 2 days [extensions/WikimediaEvents] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376861 (owner: 10EBernhardson) [01:13:50] (03CR) 10jerkins-bot: [V: 04-1] Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [01:14:40] (03PS2) 10Mooeypoo: Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) [01:19:34] 10Discovery, 10Discovery-Analysis (Current work): API usage: break out internal vs external - https://phabricator.wikimedia.org/T172452#3593393 (10chelsyx) From the [[ http://discovery-beta.wmflabs.org/metrics/#referer_breakdown | API usage by referrer dashboard]], we can see half of the API calls are referre... [01:19:57] (03Merged) 10jenkins-bot: Deprecate wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/376860 (owner: 10MaxSem) [01:22:53] 10MediaWiki-extensions-DynamicPageList2: DPL throws several warnings for fwrite() and fclose() - https://phabricator.wikimedia.org/T174086#3593395 (10Peachey88) [01:31:19] (03CR) 10jenkins-bot: Deprecate wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/376860 (owner: 10MaxSem) [01:35:36] (03PS1) 10MaxSem: Remove deprecated function wfFixSessionID() [core] - 10https://gerrit.wikimedia.org/r/376865 [01:35:38] (03PS1) 10MaxSem: Hard deprecate wfRunHooks() [core] - 10https://gerrit.wikimedia.org/r/376866 [01:37:07] (03CR) 10Mattflaschen: [C: 04-1] "Quick note, I'll review later." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [01:40:40] 10MediaWiki-extensions-Newsletter, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Patch-For-Review: Don't hide the View newsletter link? - https://phabricator.wikimedia.org/T174927#3593402 (10Mattflaschen-WMF) >>! In T174927#3590088, @Mattflaschen-WMF wrote: > @jmatazzoni Als... [01:41:44] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate wfRunHooks() [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [01:44:05] (03PS2) 10MaxSem: Hard deprecate wfRunHooks() [core] - 10https://gerrit.wikimedia.org/r/376866 [01:46:17] (03CR) 10Legoktm: Hard deprecate wfRunHooks() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [01:54:38] (03PS1) 10MaxSem: wfRunHooks --> Hooks::run [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/376867 [01:57:18] (03PS3) 10MaxSem: Hard deprecate wfRunHooks() [core] - 10https://gerrit.wikimedia.org/r/376866 [01:57:22] (03CR) 10MaxSem: Hard deprecate wfRunHooks() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [02:08:32] 10Design, 10MediaWiki-Interface, 10UI-Standardization, 10Patch-For-Review: inconsistent close icon "X" in MediaWiki interfaces - https://phabricator.wikimedia.org/T50067#3593405 (10Volker_E) [02:15:38] (03PS1) 10MaxSem: Simplify OutputPage constructor [core] - 10https://gerrit.wikimedia.org/r/376868 [02:16:23] legoktm, more sacrifice for the deprecation god! [02:16:44] 10Reading-analysis: Estimate the daily number of mobile devices who already visited on the preceding day - https://phabricator.wikimedia.org/T169378#3593406 (10Tbayer) 05Open>03Resolved Closing this now, as the main requests were all done back in July for the occasion at which they were needed, I haven't had... [02:18:33] 10Reading-analysis: Editor distribution analysis for wikidata desc editing - https://phabricator.wikimedia.org/T170218#3593410 (10Tbayer) 05Open>03Resolved a:03Tbayer See https://www.mediawiki.org/wiki/Wikimedia_Apps/Short_descriptions/Research and notebook linked there [02:21:02] 10Reading-analysis: Prepare Wikimania presentation on global readership metrics - https://phabricator.wikimedia.org/T169596#3593413 (10Tbayer) 05Open>03Resolved Slides: https://commons.wikimedia.org/wiki/File:Readership_metrics._Trends_and_stories_from_our_global_traffic_data_(Wikimania_2017_presentation).pdf [02:21:49] 10Reading-analysis: Publish results of impact of wikidata description rollout - https://phabricator.wikimedia.org/T170217#3593416 (10Tbayer) 05Open>03Resolved Added to https://www.mediawiki.org/wiki/Wikimedia_Apps/Short_descriptions/Research [02:25:02] 10Refreshed, 10Patch-For-Review: Echo badges don’t appear on mobile on MediaWiki 1.29+ - https://phabricator.wikimedia.org/T170773#3593419 (10MacFan4000) I just added some of them to the reviewer list. It’s kinda been open for a few weeks. [02:25:32] 10Reading-analysis: Update Audiences page and Key Product Metrics with September 2017 Readers data - https://phabricator.wikimedia.org/T175440#3593421 (10Tbayer) [02:26:08] 10Reading-analysis: Update Audiences page and Key Product Metrics with October 2017 Readers data - https://phabricator.wikimedia.org/T175441#3593434 (10Tbayer) [02:29:13] 10Page-Previews, 10Readers-Web-Backlog, 10Reading-analysis, 10Readers-Web-Kanban-Board, 10Spike: [Spike] Isolate the source of Popups event duplication - https://phabricator.wikimedia.org/T167391#3593453 (10Tbayer) [02:29:15] 10Reading-analysis: Examine several sessions which contained duplicate events - https://phabricator.wikimedia.org/T169582#3593449 (10Tbayer) 05Open>03declined This became obsolete shortly afterwards per T170018 [02:29:40] 10Page-Previews, 10Readers-Web-Backlog, 10Reading-analysis, 10Readers-Web-Kanban-Board, 10Spike: [Spike] Isolate the source of Popups event duplication - https://phabricator.wikimedia.org/T167391#3332080 (10Tbayer) [02:29:42] 10Reading-analysis: Histogram for the number of duplicated events per browser session - https://phabricator.wikimedia.org/T169581#3593454 (10Tbayer) 05Open>03declined This became obsolete shortly afterwards per T170018 [02:31:03] 10Page-Previews, 10Readers-Web-Backlog, 10Reading-analysis: Verify EventLogging instrumentation/bucketing for the enwiki/dewiki A/B test - https://phabricator.wikimedia.org/T175377#3593459 (10Tbayer) [02:58:51] 10Discovery, 10Discovery-Analysis (Current work): Search Relevance Survey test #3: analysis of test - https://phabricator.wikimedia.org/T175048#3593462 (10EBernhardson) Rather than continuing to pester you at 8pm on a friday about the WIP report, a few comments on the text: >The “MLR (20)” experimental group... [03:05:15] (03CR) 10Legoktm: [C: 032] Remove deprecated function wfFixSessionID() [core] - 10https://gerrit.wikimedia.org/r/376865 (owner: 10MaxSem) [03:08:40] (03CR) 10Legoktm: [C: 04-1] "Guess which Wikimedia-deployed extension still calls wfRunHooks()? No cheating!" [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [03:09:38] (03CR) 10Jeroen De Dauw: "What really wastes developers time is changing a global function to a static function "because global functions are evil". Years later you" [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [03:11:06] (03Merged) 10jenkins-bot: Remove deprecated function wfFixSessionID() [core] - 10https://gerrit.wikimedia.org/r/376865 (owner: 10MaxSem) [03:12:46] (03CR) 10Legoktm: [C: 04-1] "The benefits were pointed out back in January 2015: ." [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [03:21:59] (03CR) 10jenkins-bot: Remove deprecated function wfFixSessionID() [core] - 10https://gerrit.wikimedia.org/r/376865 (owner: 10MaxSem) [03:31:23] 10MinervaNeue: Empty branches - https://phabricator.wikimedia.org/T175442#3593463 (10alex-mashin) [03:41:48] 10Design, 10MediaWiki-Interface, 10UI-Standardization, 10Patch-For-Review: Inconsistent close icon "x" in MediaWiki interfaces - https://phabricator.wikimedia.org/T50067#3593475 (10Volker_E) [03:46:40] (03PS2) 10C. Scott Ananian: Fix link prefix/suffixes around Category and Language links (take 2). [core] - 10https://gerrit.wikimedia.org/r/376441 (https://phabricator.wikimedia.org/T2087) [03:46:42] (03PS1) 10C. Scott Ananian: Remove "only newlines in trailer" special case for category/language links [core] - 10https://gerrit.wikimedia.org/r/376872 (https://phabricator.wikimedia.org/T175416) [03:54:14] 10MediaWiki-Vagrant: Vagrant errors with new VM and fresh host vagrant directory (Windows 7) - https://phabricator.wikimedia.org/T97091#1232865 (10Veenasankar) Same error on Mac. What is the fix? [03:57:12] (03CR) 10MaxSem: "Weee, and of course that extension had to obfuscate its calls so that they wouldn't be findable with IDEA's "Find usages"." [core] - 10https://gerrit.wikimedia.org/r/376866 (owner: 10MaxSem) [04:04:18] (03PS2) 10MaxSem: Simplify OutputPage constructor [core] - 10https://gerrit.wikimedia.org/r/376868 [04:04:20] 10MediaWiki-Vagrant: Vagrant errors with new VM and fresh host vagrant directory (Windows 7) - https://phabricator.wikimedia.org/T97091#3593482 (10Veenasankar) I read another post and re-ran the command - ``` ./setup.sh ``` Then ran ``` vagrant up ``` and it worked immediately. See [[ https://phabricator.wiki... [04:06:04] (03PS4) 10MaxSem: Hard deprecate wfRunHooks() [core] - 10https://gerrit.wikimedia.org/r/376866 [04:08:51] 10MediaWiki-Internationalization, 10I18n: Use "ar-u-nu-latn" instead "ar" for whole Arabic Wikipedia or just for its - https://phabricator.wikimedia.org/T64725#3593483 (10Helmoony) @Meno25 + sister projects are notified : https://ar.wikinews.org/wiki/%D9%88%D9%8A%D9%83%D9%8A_%D8%A7%D9%... [04:33:53] (03PS22) 10MaxSem: Replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 [04:39:36] (03CR) 10jerkins-bot: [V: 04-1] Replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 (owner: 10MaxSem) [04:39:51] rrrrrr [04:40:38] rrrr? [04:40:53] Ah, rrrrr [04:49:58] (03PS23) 10MaxSem: Replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 [04:56:11] 10Discovery, 10Discovery-Analysis (Current work): API usage: break out internal vs external - https://phabricator.wikimedia.org/T172452#3593486 (10chelsyx) For now, I will add a note to this [[ http://discovery-beta.wmflabs.org/metrics/#referer_breakdown | dashboard ]] to explain the definition of each referre... [05:11:35] 10WikiCon-Francophone-2017: kit de survie de la WikiConvention 2017 - https://phabricator.wikimedia.org/T162296#3593487 (10Pyb) https://commons.wikimedia.org/wiki/File:Wikimedia_Conference_Guide_2017.pdf [05:54:07] (03PS1) 10VolkerE: postEdit: Use standard close icon [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) [05:57:58] 10Reading-analysis, 10Discovery-Analysis (Current work): Investigate mobile search dashboard data - https://phabricator.wikimedia.org/T174396#3593489 (10Tbayer) [05:58:35] 10MediaWiki-API: API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593490 (10Fastily) [05:59:23] (03CR) 10jerkins-bot: [V: 04-1] postEdit: Use standard close icon [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [05:59:30] 10Reading-analysis, 10Discovery-Analysis (Current work): Investigate mobile search dashboard data - https://phabricator.wikimedia.org/T174396#3560345 (10Tbayer) @chelsyx and I talked a bit about this today and she gave me some additional explanations; I will try to check the queries next week. [06:02:26] 10Accessibility, 10UI-Standardization, 10Technical-Debt, 10Tracking, 10UI-Standardization-Kanban: Replace abandoned colors in current WMF/Wikimedia products with WikimediaUI palette colors (tracking) - https://phabricator.wikimedia.org/T148708#3593505 (10Volker_E) [06:02:28] 10Accessibility, 10UI-Standardization, 10Technical-Debt, 10UI-Standardization-Kanban: Replace abandoned colors with WikimediaUI palette ones in ULS - https://phabricator.wikimedia.org/T174237#3593503 (10Volker_E) 05Open>03Resolved [06:03:26] 04(no projects): File History: Comments missing for non-current versions - https://phabricator.wikimedia.org/T175444#3593506 (10Jeff_G) [06:10:05] (03PS2) 10VolkerE: postEdit: Use standard close icon [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) [06:10:28] (03PS1) 10MaxSem: WIP: dependency-inject Shell\Command [core] - 10https://gerrit.wikimedia.org/r/376874 [06:11:19] 10MediaWiki-API: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593517 (10Fastily) [06:12:34] 10MediaWiki-extensions-StopForumSpam: Support StopForumSpam's IPv6 blocklists - https://phabricator.wikimedia.org/T173399#3593518 (10Legoktm) p:05Triage>03Lowest SFS barely has any IPv6 addresses for whatever reason. [06:15:11] (03CR) 10jerkins-bot: [V: 04-1] WIP: dependency-inject Shell\Command [core] - 10https://gerrit.wikimedia.org/r/376874 (owner: 10MaxSem) [06:16:09] (03CR) 10jerkins-bot: [V: 04-1] postEdit: Use standard close icon [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [06:29:34] (03CR) 10Fomafix: [C: 04-1] postEdit: Use standard close icon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [06:32:41] (03CR) 10Legoktm: "Forgot to git add?" [core] - 10https://gerrit.wikimedia.org/r/376874 (owner: 10MaxSem) [06:38:01] (03CR) 10MaxSem: "...and then amended and forgot to submit." [core] - 10https://gerrit.wikimedia.org/r/376874 (owner: 10MaxSem) [06:38:03] (03PS2) 10MaxSem: WIP: dependency-inject Shell\Command [core] - 10https://gerrit.wikimedia.org/r/376874 [06:38:21] 10Outreach-Programs-Projects, 10Outreachy (Round-15): Improvements to Grants review and Wikimania scholarships web apps - https://phabricator.wikimedia.org/T174759#3593521 (10SushmaK12) Hi, I am Sushma Kukkadapu. I want to participate in round 15. I want to get started with this project "Develop a tool for dis... [06:43:33] (03CR) 10jerkins-bot: [V: 04-1] WIP: dependency-inject Shell\Command [core] - 10https://gerrit.wikimedia.org/r/376874 (owner: 10MaxSem) [07:00:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Need-volunteer: Wikidata allows invalid URIs to be entered as units - https://phabricator.wikimedia.org/T167565#3593526 (10Smalyshev) Another example here: https://www.wikidata.org/w/index.php?title=Q4679732&diff=552439126&oldid=552439107 `http://www... [07:08:11] 10Wikimedia-General-or-Unknown: French translation of Transparency Report features wrong paths & doesn't seem to be indexed - https://phabricator.wikimedia.org/T175445#3593527 (10Volker_E) [07:14:32] 10MediaWiki-API: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593490 (10TTO) @Anomie has been doing some comment-related stuff recently... [07:24:32] (03CR) 10Umherirrender: "recheck" [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/366032 (owner: 10Umherirrender) [07:37:13] (03PS1) 10VolkerE: Add `alt` attributes and provide text [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/376875 (https://phabricator.wikimedia.org/T173629) [07:39:32] (03PS3) 10VolkerE: postEdit: Use standard close icon [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) [07:40:40] (03CR) 10VolkerE: "Eurgh, one of the most nerve-wrecking stylelint settings. Fixed in PS 3." [core] - 10https://gerrit.wikimedia.org/r/376873 (https://phabricator.wikimedia.org/T50067) (owner: 10VolkerE) [07:41:31] 10Accessibility, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Fix accessibility bugs of Transparency Report - https://phabricator.wikimedia.org/T173629#3593564 (10Volker_E) p:05Triage>03High [07:45:56] 10MediaWiki-API: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593490 (10TheDJ) Yeah, i'm guessing this is a bug caused by the epic reworking of how all the editsummaries are stores. {T166732} and {T166733} [08:05:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Need-volunteer: Wikidata allows invalid URIs to be entered as units - https://phabricator.wikimedia.org/T167565#3593580 (10Mbch331) >>! In T167565#3593526, @Smalyshev wrote: > Another example here: > > https://www.wikidata.org/w/index.php?title=Q46797... [08:23:47] (03PS1) 10Legoktm: Refactor blacklist storage to generate a PHP file [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/376876 [08:24:57] (03CR) 10jerkins-bot: [V: 04-1] Refactor blacklist storage to generate a PHP file [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/376876 (owner: 10Legoktm) [08:28:48] (03PS1) 10VolkerE: Replace outdated greys with WCAG conformant WikimediaUI palette ones [core] - 10https://gerrit.wikimedia.org/r/376877 (https://phabricator.wikimedia.org/T152025) [08:42:08] (03PS1) 10VolkerE: FancyCaptcha: Align to WikimediaUI Style Guide [core] - 10https://gerrit.wikimedia.org/r/376878 (https://phabricator.wikimedia.org/T152025) [08:49:39] (03CR) 10Pwirth: [C: 032] wfRunHooks --> Hooks::run [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/376867 (owner: 10MaxSem) [08:50:43] (03Merged) 10jenkins-bot: wfRunHooks --> Hooks::run [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/376867 (owner: 10MaxSem) [08:51:31] (03CR) 10Pwirth: [C: 032] FileSystemHelper: use msg objects instead of plain after user language is not available at this point [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/376260 (owner: 10Ljonka) [08:53:03] (03CR) 10Pwirth: [C: 04-1] "Needs manual merge" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/376476 (owner: 10Pwirth) [08:53:15] (03Merged) 10jenkins-bot: FileSystemHelper: use msg objects instead of plain after user language is not available at this point [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/376260 (owner: 10Ljonka) [09:00:48] 10Connected-Open-Heritage-Wikidata-migration (Ir_fa), 10Wiki-Loves-Monuments (2017): Move WLM-IR data to Wikidata - https://phabricator.wikimedia.org/T174966#3593585 (10Lokal_Profil) We'll move them either way. The main decision is if a new item is always created or if, when there is a blue link, the statement... [09:03:43] (03PS1) 10VolkerE: Remove contentSub from layout when empty [core] - 10https://gerrit.wikimedia.org/r/376879 [09:04:20] 10Connected-Open-Heritage-Wikidata-migration (Ir_fa), 10Wiki-Loves-Monuments (2017): Move WLM-IR data to Wikidata - https://phabricator.wikimedia.org/T174966#3593586 (10Lokal_Profil) @LilyOfTheWest Follow up question on street addresses. Are these mainly real addresses or also "how to get there" descriptions?... [09:11:26] (03PS1) 10Legoktm: LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175443) [09:12:25] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/376881 [09:12:48] 04(no projects): arbcom-fi.wikipedia.org doesn't have a functioning mobile website - https://phabricator.wikimedia.org/T175447#3593590 (10Ejs-80) [09:16:20] (03CR) 10Ladsgroup: [C: 032] Replace outdated greys with WCAG conformant WikimediaUI palette ones [core] - 10https://gerrit.wikimedia.org/r/376877 (https://phabricator.wikimedia.org/T152025) (owner: 10VolkerE) [09:16:44] (03CR) 10Ladsgroup: [C: 031] "If there is a screen shot of before and after, I +2 it :)" [core] - 10https://gerrit.wikimedia.org/r/376878 (https://phabricator.wikimedia.org/T152025) (owner: 10VolkerE) [09:17:00] (03CR) 10jerkins-bot: [V: 04-1] LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175443) (owner: 10Legoktm) [09:20:03] (03PS1) 10VolkerE: ReorderTopicsWidget: Remove hack and custom padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376882 [09:21:58] (03Merged) 10jenkins-bot: Replace outdated greys with WCAG conformant WikimediaUI palette ones [core] - 10https://gerrit.wikimedia.org/r/376877 (https://phabricator.wikimedia.org/T152025) (owner: 10VolkerE) [09:29:05] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/376883 [09:30:26] (03CR) 10jenkins-bot: Replace outdated greys with WCAG conformant WikimediaUI palette ones [core] - 10https://gerrit.wikimedia.org/r/376877 (https://phabricator.wikimedia.org/T152025) (owner: 10VolkerE) [09:30:57] (03PS2) 10Legoktm: LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175443) [09:56:53] (03PS1) 10Tpt: Small code cleanup of the page quality edit widget [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/376884 [09:59:11] (03CR) 10MarcoAurelio: "Hi. Can we have this reviewed and merged, please? Thank you!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/376490 (https://phabricator.wikimedia.org/T169547) (owner: 10Melos) [10:00:21] (03CR) 10Tpt: [C: 032] Small code cleanup of the page quality edit widget [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/376884 (owner: 10Tpt) [10:00:55] 10MediaWiki-API, 10Patch-For-Review: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593490 (10Legoktm) I put together a patch that fixed the issue for me locally, and passes tests. How impactful is this API regression? Does it require an emergency deploy over... [10:01:21] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593611 (10Legoktm) [10:02:16] (03Merged) 10jenkins-bot: Small code cleanup of the page quality edit widget [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/376884 (owner: 10Tpt) [10:07:06] (03PS1) 10Umherirrender: Improve some function documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/376887 [10:14:58] 10MediaWiki-Cache, 10Commons: File page not purged after deletion - https://phabricator.wikimedia.org/T104711#1425134 (10Ciencia_Al_Poder) I have the same problem. We use redis as the main cache. MediaWiki 1.29 Several images were deleted normally by the web interface. However, one of them is stuck: The file... [10:26:17] 10MediaWiki-Cache, 10Commons: File page not purged after deletion - https://phabricator.wikimedia.org/T104711#3593615 (10Ciencia_Al_Poder) I've tried also to `$f->invalidateCache();` (from eval.php) but it didn't remove it from the cache neither. I had to execute `$r->getMasterDB()->commit();` for it to be rem... [10:55:02] !class PoolCounterWorkViaCallback [10:55:02] See https://doc.wikimedia.org/mediawiki-core/master/php/classPoolCounterWorkViaCallback.html [10:57:41] -r/c [11:06:35] (03CR) 10Umherirrender: "As hint: All other extensions using fixed version to avoid broken tests, when there are changes to the modules. The mediawiki-codesniffer " [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/373182 (owner: 10Samwilson) [11:12:35] 10Connected-Open-Heritage-Wikidata-migration: Investigate ID numbers of monuments in Ireland - https://phabricator.wikimedia.org/T156896#3593641 (10Alicia_Fagerving_WMSE) >>! In T156896#3591665, @Lokal_Profil wrote: > Can this be abandoned with Yarls import of the Ireland data? Yes. [11:31:49] (03CR) 10Samwilson: "You're right, especially as we're using pre-release software. On the other hand, that software *should* now be post-1.0, and at least medi" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/373182 (owner: 10Samwilson) [11:36:17] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/376888 [11:40:55] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): Change "new editors" filter in New Pages Feed to be non-extended confirmed - https://phabricator.wikimedia.org/T175225#3587125 (10Rentier) I think adding the "AC but not EC" filter next to the existing one makes the... [11:41:59] (03CR) 10Ladsgroup: "ping" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/344820 (https://phabricator.wikimedia.org/T28256) (owner: 10Ladsgroup) [12:20:07] 10Connected-Open-Heritage-Wikidata-migration: Investigate ID numbers of monuments in Ireland - https://phabricator.wikimedia.org/T156896#3593663 (10Lokal_Profil) 05Open>03declined [12:32:35] (03PS1) 10Ebrahim: i18n: use correct lang and dir [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 [12:33:27] (03PS1) 10Esanders: Add some devs with significant contributions to core [core] - 10https://gerrit.wikimedia.org/r/376895 [12:34:05] (03CR) 10jerkins-bot: [V: 04-1] i18n: use correct lang and dir [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 (owner: 10Ebrahim) [12:38:49] (03CR) 10jerkins-bot: [V: 04-1] Add some devs with significant contributions to core [core] - 10https://gerrit.wikimedia.org/r/376895 (owner: 10Esanders) [12:43:57] (03CR) 10Ebrahim: "Fixes couple of issues can be seen on this link:" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 (owner: 10Ebrahim) [12:45:04] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3593664 (10MarcoAurelio) Can we please reactivate the gerrit repo so I can empty it and add an `OBSOLETE` file as @Legoktm has suggested for this kind of tasks? Thank you. [12:46:44] 04(no projects): File History: Comments missing for non-current versions - https://phabricator.wikimedia.org/T175444#3593666 (10Aklapper) Thanks for reporting this. Please provide a test case. [12:50:02] 04(no projects): Arwiki - commonscat.py - https://phabricator.wikimedia.org/T175207#3593667 (10Xqt) p:05Triage>03Normal [12:51:40] 10MediaWiki-extensions-LoginNotify, 10Community-Tech-Sprint: Successful login notification gets sent out sometimes - https://phabricator.wikimedia.org/T174220#3593671 (10Aklapper) [12:51:56] 10MediaWiki-History-or-Diffs, 10MediaWiki-Recent-changes: Improve [rollback] logic when it encounters null edits - https://phabricator.wikimedia.org/T175437#3593672 (10Aklapper) [12:53:51] 10MinervaNeue: Empty branches - https://phabricator.wikimedia.org/T175442#3593673 (10Aklapper) @Alex-mashin: That looks like two very different topics which should be not in one single task? [12:55:34] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3593674 (10MarcoAurelio) [12:58:48] 10MinervaNeue: Empty branches - https://phabricator.wikimedia.org/T175442#3593695 (10alex-mashin) There is one topic here: empty branches. That `master` requires //MobileFrontend// 2.0 is not necessarily an error itself, it just makes using `master` branch instead of `REL1_29` impossible. [13:02:19] (03PS2) 10Esanders: Add some devs with significant contributions to core [core] - 10https://gerrit.wikimedia.org/r/376895 [13:04:49] 10Wikimedia-General-or-Unknown, 10I18n: French translation of Transparency Report features wrong paths & doesn't seem to be indexed - https://phabricator.wikimedia.org/T175445#3593700 (10Aklapper) [13:10:51] 10MediaWiki-Special-pages, 10Easy: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3593708 (10Kghbln) Anybody up for at least triaging this database query issue? [13:25:38] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Add abusefilter-view-private to rollbackers in zhwiki - https://phabricator.wikimedia.org/T174978#3578688 (10MarcoAurelio) This shoul've be added, IMHO, to https://phabricator.wikimedia.org/source/mediawiki-config/browse/master/wmf-config/abusef... [13:31:11] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593490 (10Umherirrender) See also T175444, it seems to affect also the file history page [13:33:25] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Regression: Un-saving a page has no apparent effect; it remains stored on disk and available for loading - https://phabricator.wikimedia.org/T164585#3593728 (10Mholloway) 05Resolved>03Open [13:39:53] 10MediaWiki-Database, 10MediaWiki-JobQueue: LogicException from line 136 of ... JobQueueGroup.php: Domain ... recognized. - https://phabricator.wikimedia.org/T174017#3593742 (10mwjames) @aaron I was patiently awaiting (two weeks+) this issue to be triaged since this is clearly a regression since 1.29! [13:40:23] 04(no projects): File History: Comments missing for non-current versions - https://phabricator.wikimedia.org/T175444#3593506 (10Umherirrender) It is not about the normal history[1], about the filehistory on the file page[2] [1] https://commons.wikimedia.org/wiki/File:Example.jpg?action=history [2] https://co... [13:41:15] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Regression: Un-saving a page has no apparent effect; it remains stored on disk and available for loading - https://phabricator.wikimedia.org/T164585#3593747 (10Mholloway) While working on T166596 I confirmed in the debugger that pages a... [13:46:08] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/376900 [13:52:22] (03PS2) 10Umherirrender: Improve some parameter docs [skins/Vector] - 10https://gerrit.wikimedia.org/r/376887 [13:54:53] 10LDAP-Access-Requests, 10Patch-For-Review: LDAP access for group 'nda' for knissen - https://phabricator.wikimedia.org/T168046#3593750 (10kai.nissen) Login works. Thanks a lot! [13:57:40] (03PS1) 10Umherirrender: Improve some parameter docs [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/376901 [14:06:18] (03PS1) 10Umherirrender: Improve some parameter docs [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/376902 [14:17:00] 04(no projects): En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593758 (10Izno) [14:17:27] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593769 (10Izno) [14:17:41] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593758 (10Izno) [14:17:56] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593758 (10Izno) [14:19:32] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): Change "new editors" filter in New Pages Feed to be non-extended confirmed - https://phabricator.wikimedia.org/T175225#3593773 (10TonyBallioni) After reading the above, I concur with @Rentier . If ACTRIAL is made pe... [14:43:55] 04(no projects): Arwiki - commonscat.py - https://phabricator.wikimedia.org/T175207#3593789 (10Aklapper) Hi @alanajjar, thanks for taking the time to report this! Unfortunately I do not know what code base this task is about If you have time and can still reproduce the problem: Please [[ https://www.mediawiki.o... [14:50:08] 10MediaWiki-History-or-Diffs, 10Datasets-General-or-Unknown, 10Regression: File History: Comments missing for non-current versions - https://phabricator.wikimedia.org/T175444#3593790 (10Aklapper) [14:50:24] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown, 10Regression: File History: Comments missing for non-current versions - https://phabricator.wikimedia.org/T175444#3593506 (10Aklapper) [14:51:33] (03CR) 10Bartosz Dziewoński: [C: 031] "Thanks :o" [core] - 10https://gerrit.wikimedia.org/r/376895 (owner: 10Esanders) [15:03:42] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593758 (10ssastry) Let us take a look at [[Streptomyces carpinensis]]. I effectively run it through expandtemplates API call and see this in the output `''''''''Stre... [15:03:53] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593809 (10ssastry) p:05Triage>03Normal [15:10:07] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593810 (10ssastry) You will see on https://en.wikipedia.org/wiki/Streptomyces_carpinensis that the listing under binomial name is not in bold at all. Only the italics is preserved. The two... [15:18:31] (03PS2) 10Ebrahim: i18n: use correct lang and dir [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 [15:20:40] (03PS3) 10Ebrahim: i18n: use correct language and direction [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 [15:22:00] (03PS4) 10Ebrahim: i18n: use correct language and direction [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 [15:30:56] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown, 10Regression: File History: Comments missing for non-current versions - https://phabricator.wikimedia.org/T175444#3593814 (10Jeff_G) >>! In T175444#3593744, @Umherirrender wrote: > It is not about the normal history[1], about the filehistory on th... [15:32:58] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown, 10Regression: File History: Comments are not displayed anymore for non-current versions - https://phabricator.wikimedia.org/T175444#3593815 (10Aklapper) [15:40:18] 10MediaWiki-Database, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593348 (10Reedy) Do you know what file it's running? Or it thinks it's running... I see the following in mysql's patch-comment-table.sql ```lang=sql ALTER TABLE /*_*/revision A... [15:46:12] 10MediaWiki-Database, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593819 (10Paladox) @Reedy it's not running from a file. Doing a GitHub search results in php is executing it based on what function is used. https://github.com/wikimedia/mediawik... [15:46:42] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593820 (10Izno) Excellent, thanks. We'll talk it over onwiki about what to do. You can close this, unless you want to track a case where Parsoid should/could be tracking a misnested issue... [15:48:53] 10MediaWiki-Core-Tests: PHPUnit finds many errors in the current MediaWiki HEAD - https://phabricator.wikimedia.org/T175397#3592426 (10Reedy) Config varies between wikis. It can provide different results. It's almost impossible to test all configuration options ``` 7) ResourcesTest::testMissingDependencies The... [15:48:55] 10MediaWiki-extensions-Linter: En.WP Template:Taxobox -- where is the error? :D - https://phabricator.wikimedia.org/T175452#3593823 (10ssastry) 05Open>03Resolved a:03ssastry >>! In T175452#3593820, @Izno wrote: > Excellent, thanks. We'll talk it over onwiki about what to do. Great. > You can close this,... [15:49:22] 10WMF-CTO-Team-Backlog: Set up Google Team Drive for Tech - https://phabricator.wikimedia.org/T175410#3593826 (10Reedy) [15:49:47] 10MediaWiki-Database, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593348 (10saper) SQL injection? We do not quote $default at all? [15:54:13] 10MediaWiki-Database, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593835 (10Paladox) i think '' could be turning into false. maybe if we did $default = '', by default that may fix the problem. [15:54:25] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown, 10Regression: File History: Comments are not displayed anymore for non-current versions - https://phabricator.wikimedia.org/T175444#3593506 (10Jack_who_built_the_house) My case: uploaded a new version of [[ https://commons.wikimedia.org/wiki/File:... [16:00:04] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown, 10Regression: File History: Comments are not displayed anymore for non-current versions - https://phabricator.wikimedia.org/T175444#3593506 (10Reedy) Did this start on Wednesday? When .17 was rolled out to commonswiki? If so, it's very likely htt... [16:01:50] (03PS1) 10Umherirrender: Improve some parameter docs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/376906 [16:11:28] 10MediaWiki-Gallery, 10Multimedia, 10JavaScript: Gallery mode slideshow forces http: URLs if $wgUploadBaseUrl is protocol-relative - https://phabricator.wikimedia.org/T175455#3593841 (10Ciencia_Al_Poder) [16:11:50] 10MediaWiki-Database, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593856 (10Reedy) >>! In T175439#3593835, @Paladox wrote: > i think '' could be turning into false. maybe if we did $default = '', by default that may fix the problem. No it won't... [16:12:06] (03PS1) 10Reedy: Quote $default in PostgresUpdater::setDefault [core] - 10https://gerrit.wikimedia.org/r/376907 (https://phabricator.wikimedia.org/T175439) [16:13:23] (03CR) 10Paladox: [C: 031] Quote $default in PostgresUpdater::setDefault [core] - 10https://gerrit.wikimedia.org/r/376907 (https://phabricator.wikimedia.org/T175439) (owner: 10Reedy) [16:15:23] 10MediaWiki-Database, 10Patch-For-Review, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593861 (10saper) Thanks @reedy! [16:15:30] 10MediaWiki-Database, 10Patch-For-Review, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593862 (10Reedy) Add quotes should handle things like null fine too... ```lang=php > var_dump( "Foo " . $db->addQuotes( '' ) ); /var/www/wiki/mediawiki/core... [16:16:15] 10InternetArchiveBot: Incomplete URL marked as invalid with template Dode link - https://phabricator.wikimedia.org/T175456#3593863 (10Smile4ever) [16:16:59] 10InternetArchiveBot: Incomplete URL marked as invalid with template Dode link - https://phabricator.wikimedia.org/T175456#3593863 (10Smile4ever) Reverted unwanted changes: https://nl.wikipedia.org/w/index.php?title=Packet_sniffer&type=revision&diff=49893269&oldid=49892876 [16:17:59] (03CR) 10jerkins-bot: [V: 04-1] Quote $default in PostgresUpdater::setDefault [core] - 10https://gerrit.wikimedia.org/r/376907 (https://phabricator.wikimedia.org/T175439) (owner: 10Reedy) [16:18:16] 10MediaWiki-Database, 10Patch-For-Review, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593876 (10Reedy) I also note.. There's a lot of dodgy other wheel reinventing for handling this in other PostgresUpdater code... https://github.com/wikimedi... [16:18:57] (03PS2) 10Reedy: Quote $default in PostgresUpdater::setDefault [core] - 10https://gerrit.wikimedia.org/r/376907 (https://phabricator.wikimedia.org/T175439) [16:20:23] (03CR) 10Umherirrender: [C: 031] Convert AccountInfo.alias.php to use PHP short array syntax (031 comment) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/375536 (owner: 10MarcoAurelio) [16:22:36] 10MediaWiki-Database, 10Patch-For-Review, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593877 (10Reedy) We should probably be quoting `$table` and `$field`. But with where it should be generally called from... It's less of an issue, ish [16:28:26] (03PS1) 10Reedy: Reuse $db->makeList() rather than reinventing the wheel [core] - 10https://gerrit.wikimedia.org/r/376908 [16:31:33] 10MediaWiki-Database, 10Patch-For-Review, 10PostgreSQL: SQL error with postgres during 1.30 update.php run - https://phabricator.wikimedia.org/T175439#3593880 (10Reedy) I guess that lot should be filed in a separate ticket [16:34:17] (03CR) 10Paladox: [C: 031] Quote $default in PostgresUpdater::setDefault [core] - 10https://gerrit.wikimedia.org/r/376907 (https://phabricator.wikimedia.org/T175439) (owner: 10Reedy) [16:35:19] 10MediaWiki-Special-pages, 10Easy, 10Technical-Debt: "Special:ActiveUsers" throws database query error with sql_mode=only_full_group_by - https://phabricator.wikimedia.org/T160298#3593887 (10Ciencia_Al_Poder) @aaron should probably reply T160298#3094400, or somebody just write a patch to remove the $dbr->imp... [16:52:47] (03PS1) 10Umherirrender: Improve some parameter docs [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376909 [17:45:48] (03PS1) 10VolkerE: FeedbackDialog: Improve alignment [core] - 10https://gerrit.wikimedia.org/r/376910 [17:47:22] (03CR) 10VolkerE: "After state: https://phabricator.wikimedia.org/F9419303" [core] - 10https://gerrit.wikimedia.org/r/376910 (owner: 10VolkerE) [17:51:26] 10Design, 10MediaWiki-Interface, 10UI-Standardization, 10Patch-For-Review: Inconsistent close icon "x" in MediaWiki interfaces - https://phabricator.wikimedia.org/T50067#3593894 (10Volker_E) [17:51:54] 10Design, 10MediaWiki-Interface, 10UI-Standardization, 10Patch-For-Review: Inconsistent close icon "x" in MediaWiki interfaces - https://phabricator.wikimedia.org/T50067#526612 (10Volker_E) [18:10:18] (03PS1) 10Umherirrender: Improve some parameter docs [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/376911 [18:31:58] (03PS2) 10VolkerE: Remove contentSub from layout when empty [core] - 10https://gerrit.wikimedia.org/r/376879 [18:37:23] (03CR) 10jerkins-bot: [V: 04-1] Remove contentSub from layout when empty [core] - 10https://gerrit.wikimedia.org/r/376879 (owner: 10VolkerE) [18:48:44] (03PS1) 10Cicalese: Allow anonymous comments. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/376912 [19:01:01] (03PS2) 10Cicalese: Allow anonymous comments. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/376912 [19:16:54] (03PS1) 10VolkerE: Align board overflow menu with WikimediaUI Style Guide [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376913 [19:30:37] (03PS3) 10Legoktm: LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175444) [19:40:24] (03PS4) 10Reedy: LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175444) (owner: 10Legoktm) [19:40:28] (03CR) 10Reedy: [C: 032] LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175444) (owner: 10Legoktm) [19:40:47] (03PS1) 10Reedy: LocalFile: Fix setting $this->description after CommentStore changes [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376915 (https://phabricator.wikimedia.org/T175444) [19:41:33] (03CR) 10Reedy: [C: 032] LocalFile: Fix setting $this->description after CommentStore changes [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376915 (https://phabricator.wikimedia.org/T175444) (owner: 10Reedy) [19:41:46] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3593674 (10Bawolff) Oversighters should already be able to do this. Is that not the case? [19:45:30] 04(no projects): API: Missing comment data for files in query imageinfo with iiprog=comment. - https://phabricator.wikimedia.org/T175458#3593930 (10Wdwd) [19:46:19] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593943 (10Legoktm) [19:46:21] 04(no projects): API: Missing comment data for files in query imageinfo with iiprog=comment. - https://phabricator.wikimedia.org/T175458#3593945 (10Legoktm) [19:46:23] 04(no projects): API: Missing comment data for files in query imageinfo with iiprog=comment. - https://phabricator.wikimedia.org/T175458#3593946 (10Reedy) [19:46:27] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593947 (10Reedy) [19:46:37] (03Merged) 10jenkins-bot: LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175444) (owner: 10Legoktm) [19:48:39] (03Merged) 10jenkins-bot: LocalFile: Fix setting $this->description after CommentStore changes [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376915 (https://phabricator.wikimedia.org/T175444) (owner: 10Reedy) [19:57:30] (03CR) 10jenkins-bot: LocalFile: Fix setting $this->description after CommentStore changes [core] - 10https://gerrit.wikimedia.org/r/376880 (https://phabricator.wikimedia.org/T175444) (owner: 10Legoktm) [20:05:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/376917 (owner: 10L10n-bot) [20:05:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/376916 (owner: 10L10n-bot) [20:08:22] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3593953 (10MarcoAurelio) >>! In T175450#3593928, @Bawolff wrote: > Oversighters should... [20:13:40] (03PS1) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] - 10https://gerrit.wikimedia.org/r/376920 [20:14:54] (03PS2) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] - 10https://gerrit.wikimedia.org/r/376920 [20:17:32] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3593674 (10Legoktm) >>! In T175450#3593953, @MarcoAurelio wrote: >>>! In T175450#35939... [20:18:08] (03PS1) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 [20:20:57] (03CR) 10jerkins-bot: [V: 04-1] LocalFile: Fallback to 'img_description' for cached entries [core] - 10https://gerrit.wikimedia.org/r/376920 (owner: 10Legoktm) [20:21:45] (03PS3) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] - 10https://gerrit.wikimedia.org/r/376920 [20:23:32] (03CR) 10jerkins-bot: [V: 04-1] LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 (owner: 10Legoktm) [20:23:54] (03PS2) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 [20:25:30] (03CR) 10Legoktm: [C: 032] LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 (owner: 10Legoktm) [20:25:59] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/376932 [20:27:30] (03CR) 10jerkins-bot: [V: 04-1] LocalFile: Fallback to 'img_description' for cached entries [core] - 10https://gerrit.wikimedia.org/r/376920 (owner: 10Legoktm) [20:27:44] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/Athena] - 10https://gerrit.wikimedia.org/r/376939 [20:28:09] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/376941 [20:28:27] (03PS4) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] - 10https://gerrit.wikimedia.org/r/376920 [20:28:29] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/376944 [20:28:38] (03PS3) 10Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 [20:28:41] (03CR) 10Legoktm: [C: 032] LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 (owner: 10Legoktm) [20:29:10] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/EditcountAdditions] - 10https://gerrit.wikimedia.org/r/376945 [20:29:28] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/376946 [20:31:43] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/376951 [20:32:13] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/ImageRating] - 10https://gerrit.wikimedia.org/r/376953 [20:32:29] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/376956 [20:32:46] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [tools/grabbers] - 10https://gerrit.wikimedia.org/r/376957 [20:34:30] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/376960 [20:36:37] (03PS8) 10Niedzielski: Chore: replace page with custom router [marvin] - 10https://gerrit.wikimedia.org/r/374923 (https://phabricator.wikimedia.org/T173323) [20:37:44] (03Merged) 10jenkins-bot: LocalFile: Fallback to 'img_description' for cached entries [core] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376921 (owner: 10Legoktm) [20:38:02] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3593960 (10demon) Done (I do think OBSOLETE files are silly though) [20:38:08] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/376944 (owner: 10SamanthaNguyen) [20:38:09] 04(no projects): change blocked user's edit tabs to view source tabs - https://phabricator.wikimedia.org/T175459#3593961 (10UpsandDowns1234) [20:38:27] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3593973 (10demon) Also: let's write a goddamn tool for this. This process is far too manual. [20:38:35] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/376946 (owner: 10SamanthaNguyen) [20:38:41] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/376956 (owner: 10SamanthaNguyen) [20:40:20] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/376944 (owner: 10SamanthaNguyen) [20:40:49] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/376946 (owner: 10SamanthaNguyen) [20:41:38] (03CR) 10Jack Phoenix: "This is technically correct and perfectly valid but there's no real reason to +2 this at the moment since MediaWikiAuth is currently unsup" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/376960 (owner: 10SamanthaNguyen) [20:41:55] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/376941 (owner: 10SamanthaNguyen) [20:42:00] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/376956 (owner: 10SamanthaNguyen) [20:42:15] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/ImageRating] - 10https://gerrit.wikimedia.org/r/376953 (owner: 10SamanthaNguyen) [20:42:32] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/376951 (owner: 10SamanthaNguyen) [20:42:48] Protip: next time push batch changes like that with the +2 attached. [20:42:48] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/EditcountAdditions] - 10https://gerrit.wikimedia.org/r/376945 (owner: 10SamanthaNguyen) [20:42:50] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/376976 [20:43:05] (03CR) 10Aaron Schulz: Avoid using the deprecated ParserCache::singleton() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/376855 (owner: 10Legoktm) [20:43:07] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/376932 (owner: 10SamanthaNguyen) [20:43:43] (03CR) 10Legoktm: "This is deployed on Wikimedia sites. Unsure whether master needs it." [core] - 10https://gerrit.wikimedia.org/r/376920 (owner: 10Legoktm) [20:44:52] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/376941 (owner: 10SamanthaNguyen) [20:44:53] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/ImageRating] - 10https://gerrit.wikimedia.org/r/376953 (owner: 10SamanthaNguyen) [20:44:57] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 3 others: [BUG] API:Imageinfo returns null for &iiprop=comment - https://phabricator.wikimedia.org/T175443#3593992 (10Legoktm) 05Open>03Resolved a:03Legoktm This should be fixed now. Cached entries for images on Commons might... [20:45:03] 10MediaWiki-History-or-Diffs, 10Wikimedia-General-or-Unknown, 10Patch-For-Review, 10Regression: File History: Comments are not displayed anymore for non-current versions - https://phabricator.wikimedia.org/T175444#3593996 (10Legoktm) 05Open>03Resolved a:03Legoktm This should be fixed now. [20:45:26] no_justification: Sorry, I'll try to do that next time. I guess I'm unaware though, are you saying there's a way to push batch changes and have them auto+2'd on submit? [20:45:35] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/376951 (owner: 10SamanthaNguyen) [20:45:50] SamanthaNguyen: Yes [20:46:01] `git push origin HEAD:refs/for/master%l=Code-Review+2` [20:46:06] (03CR) 10Jack Phoenix: [C: 031] "If this is *the* definitive Athena repo (which I guess it is, since the GitHub version hasn't been touched since late 2016), we really sho" [extensions/Athena] - 10https://gerrit.wikimedia.org/r/376939 (owner: 10SamanthaNguyen) [20:46:16] I have that aliased to `git push-for-merge` locally :) [20:46:39] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3594002 (10MarcoAurelio) >>! In T174864#3593973, @demon wrote: > Also: let's write a goddamn tool for this. This process is far too manual. +1 from me. @demon Just a question, is it possible for non-admins t... [20:46:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376955 (owner: 10L10n-bot) [20:46:59] (03CR) 10Jack Phoenix: [C: 032] "You'll probably wanna update the on-wiki docs ([[mw:Manual:Grabbers]]) to say that MW 1.29+ is now required for these scripts." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/376957 (owner: 10SamanthaNguyen) [20:47:20] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3594006 (10demon) Owners of a repository can. [20:47:32] (03CR) 10Jack Phoenix: [V: 032 C: 032] DB_SLAVE to DB_REPLICA [extensions/EditcountAdditions] - 10https://gerrit.wikimedia.org/r/376945 (owner: 10SamanthaNguyen) [20:47:37] no_justification: OK, thanks for the advice :) [20:47:56] You're welcome [20:48:09] (03CR) 10Jack Phoenix: [C: 032] DB_SLAVE to DB_REPLICA [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/376976 (owner: 10SamanthaNguyen) [20:48:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/376969 (owner: 10L10n-bot) [20:49:30] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3594019 (10MarcoAurelio) Newsletter's can be oversighted, but suppressed titles of new... [20:50:12] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/376932 (owner: 10SamanthaNguyen) [20:50:31] (03PS1) 10Umherirrender: Fix return in ParserTestTopLevelSuite::debug [core] - 10https://gerrit.wikimedia.org/r/376982 [20:51:49] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/376976 (owner: 10SamanthaNguyen) [20:52:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/376971 (owner: 10L10n-bot) [20:52:44] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3594021 (10Bawolff) Is that actually correct? I was under the impression for normal pa... [20:53:03] (03CR) 10Jack Phoenix: [V: 032 C: 032] DB_SLAVE to DB_REPLICA [tools/grabbers] - 10https://gerrit.wikimedia.org/r/376957 (owner: 10SamanthaNguyen) [20:54:48] (03PS1) 10Umherirrender: Fix return in Preprocessor::cacheSetTree [core] - 10https://gerrit.wikimedia.org/r/376994 [20:55:14] (03PS1) 10MarcoAurelio: Archive the AWS extension [extensions/AWS] - 10https://gerrit.wikimedia.org/r/376996 (https://phabricator.wikimedia.org/T174864) [20:55:20] (03CR) 10jerkins-bot: [V: 04-1] Archive the AWS extension [extensions/AWS] - 10https://gerrit.wikimedia.org/r/376996 (https://phabricator.wikimedia.org/T174864) (owner: 10MarcoAurelio) [20:56:14] (03CR) 10MarcoAurelio: "Requires manual CR2, V2 and submit. Ignore jenkins." [extensions/AWS] - 10https://gerrit.wikimedia.org/r/376996 (https://phabricator.wikimedia.org/T174864) (owner: 10MarcoAurelio) [20:57:25] 10Cleanup, 10Repository-Admins, 10Patch-For-Review: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3594027 (10MarcoAurelio) @demon Thanks. https://gerrit.wikimedia.org/r/#/c/376996/ empties the repo and adds an `OBSOLETE` file. When that is merged you can mark the repo as read-only aga... [20:57:29] (03CR) 10Legoktm: [C: 032] Fix return in ParserTestTopLevelSuite::debug [core] - 10https://gerrit.wikimedia.org/r/376982 (owner: 10Umherirrender) [20:57:46] (03PS1) 10Aaron Schulz: Remove use of implicitGroupby() in WikiPage [core] - 10https://gerrit.wikimedia.org/r/376999 [20:58:57] (03PS26) 10Daniel Kinzler: [WIP] Break Revision into RevisionRecord and RevisionStore. [core] - 10https://gerrit.wikimedia.org/r/374077 (https://phabricator.wikimedia.org/T174025) [20:59:34] (03CR) 10Chad: [V: 032 C: 032] Archive the AWS extension [extensions/AWS] - 10https://gerrit.wikimedia.org/r/376996 (https://phabricator.wikimedia.org/T174864) (owner: 10MarcoAurelio) [20:59:40] (03CR) 10jerkins-bot: [V: 04-1] Archive the AWS extension [extensions/AWS] - 10https://gerrit.wikimedia.org/r/376996 (https://phabricator.wikimedia.org/T174864) (owner: 10MarcoAurelio) [21:01:45] 04(no projects): change blocked user's edit tabs to view source tabs - https://phabricator.wikimedia.org/T175459#3593961 (10Framawiki) I can reproduce the problem. Note that "View source" tab is been present on protected pages. [21:02:25] 10MediaWiki-General-or-Unknown: change blocked user's edit tabs to view source tabs - https://phabricator.wikimedia.org/T175459#3594032 (10Framawiki) [21:02:35] 10Cleanup, 10Repository-Admins, 10Patch-For-Review: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3594033 (10MarcoAurelio) Do we care about branches: https://phabricator.wikimedia.org/diffusion/EAWS/branches/master/ ? [21:03:16] (03Merged) 10jenkins-bot: Fix return in ParserTestTopLevelSuite::debug [core] - 10https://gerrit.wikimedia.org/r/376982 (owner: 10Umherirrender) [21:06:06] (03PS1) 10Aaron Schulz: Remove implicitGroupby() use in ImageListPager [core] - 10https://gerrit.wikimedia.org/r/377000 [21:07:43] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3594035 (10MarcoAurelio) https://test.wikipedia.org/w/index.php?title=Special%3ALog&ty... [21:08:23] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Break Revision into RevisionRecord and RevisionStore. [core] - 10https://gerrit.wikimedia.org/r/374077 (https://phabricator.wikimedia.org/T174025) (owner: 10Daniel Kinzler) [21:09:44] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/377001 [21:09:46] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/377001 (owner: 10SamanthaNguyen) [21:09:54] 10Cleanup, 10Repository-Admins, 10Patch-For-Review: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3594038 (10demon) No. [21:11:18] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/MessageCommons] - 10https://gerrit.wikimedia.org/r/377001 (owner: 10SamanthaNguyen) [21:12:41] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3594041 (10MarcoAurelio) [21:13:09] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/NumberOfWikis] - 10https://gerrit.wikimedia.org/r/377003 [21:13:13] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/NumberOfWikis] - 10https://gerrit.wikimedia.org/r/377003 (owner: 10SamanthaNguyen) [21:13:22] 10Cleanup, 10Repository-Admins: Archive the AWS extension - https://phabricator.wikimedia.org/T174864#3575316 (10MarcoAurelio) 05Open>03Resolved I've taken care of Diffusion as well. Done I think. [21:13:44] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/377004 [21:13:46] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/377004 (owner: 10SamanthaNguyen) [21:14:21] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/377005 [21:14:24] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/377005 (owner: 10SamanthaNguyen) [21:14:26] (03CR) 10jenkins-bot: Fix return in ParserTestTopLevelSuite::debug [core] - 10https://gerrit.wikimedia.org/r/376982 (owner: 10Umherirrender) [21:14:33] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/NumberOfWikis] - 10https://gerrit.wikimedia.org/r/377003 (owner: 10SamanthaNguyen) [21:14:36] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/377006 [21:14:38] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/377006 (owner: 10SamanthaNguyen) [21:15:08] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/377004 (owner: 10SamanthaNguyen) [21:15:36] SamanthaNguyen: just fyi, the next MW codesniffer version will automatically do that if you don't want to do it manually [21:15:59] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/377005 (owner: 10SamanthaNguyen) [21:17:02] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/377006 (owner: 10SamanthaNguyen) [21:20:05] Legoktm: Oh neat, I didn't know that. There's left 10 I already did a little bit ago that so I'm just going to push them out, but I guess it'd be useful to look into updating to the next version for these repos (thanks for informing me!) [21:20:25] (03PS2) 10Legoktm: Avoid using the deprecated ParserCache::singleton() [core] - 10https://gerrit.wikimedia.org/r/376855 [21:20:57] (03CR) 10Legoktm: Avoid using the deprecated ParserCache::singleton() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/376855 (owner: 10Legoktm) [21:21:25] there's a few extensions I modified that I don't have rights to but Jack does, so I'll do that after the rest of these [21:22:55] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/376888 (owner: 10Umherirrender) [21:23:16] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/376883 (owner: 10Umherirrender) [21:23:41] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/376881 (owner: 10Umherirrender) [21:24:35] (03CR) 10Legoktm: [C: 032] Improve some parameter docs [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/376902 (owner: 10Umherirrender) [21:24:47] (03CR) 10Legoktm: [C: 032] Improve some parameter docs [skins/Vector] - 10https://gerrit.wikimedia.org/r/376887 (owner: 10Umherirrender) [21:25:01] SamanthaNguyen: sounds good then [21:25:12] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/376888 (owner: 10Umherirrender) [21:25:25] (03CR) 10MarcoAurelio: Convert AccountInfo.alias.php to use PHP short array syntax (032 comments) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/375536 (owner: 10MarcoAurelio) [21:27:01] (03CR) 10Legoktm: [C: 032] Convert AccountInfo.alias.php to use PHP short array syntax [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/375536 (owner: 10MarcoAurelio) [21:28:07] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/377007 [21:28:09] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/377007 (owner: 10SamanthaNguyen) [21:28:18] (03CR) 10Legoktm: [C: 032] build: Always exclude vendor and node_modules [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/376776 (owner: 10Umherirrender) [21:28:39] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/377008 [21:28:41] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/377008 (owner: 10SamanthaNguyen) [21:28:54] (03CR) 10Legoktm: [C: 032] build: Always exclude vendor and node_modules [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/376765 (owner: 10Umherirrender) [21:29:35] (03PS23) 10Dbarratt: Allow users to restrict who can send them direct emails via Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) [21:29:37] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/377009 [21:29:39] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/377009 (owner: 10SamanthaNguyen) [21:30:16] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/377010 [21:30:18] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/377010 (owner: 10SamanthaNguyen) [21:30:22] 10MediaWiki-extensions-Newsletter, 10Stewards-and-global-tools, 10Security, 10Security-Extensions, 10WorkType-NewFunctionality: Support suppression (oversight) of newsletters - https://phabricator.wikimedia.org/T175450#3594045 (10QuimGil) p:05Triage>03Low [21:30:30] (03CR) 10Dbarratt: "> Needs release notes. Also some minor nitpicks." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) (owner: 10Dbarratt) [21:30:48] (03PS1) 10Gergő Tisza: Make warnings_as_errors role throw exceptions [vagrant] - 10https://gerrit.wikimedia.org/r/377011 [21:30:53] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/377012 [21:30:56] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/377012 (owner: 10SamanthaNguyen) [21:31:33] (03PS2) 10Gergő Tisza: Make warnings_as_errors role throw exceptions [vagrant] - 10https://gerrit.wikimedia.org/r/377011 [21:31:45] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/376883 (owner: 10Umherirrender) [21:32:12] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/376881 (owner: 10Umherirrender) [21:32:23] (03Merged) 10jenkins-bot: Improve some parameter docs [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/376902 (owner: 10Umherirrender) [21:32:55] (03CR) 10Umherirrender: [C: 031] Convert AccountInfo.alias.php to use PHP short array syntax (031 comment) [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/375536 (owner: 10MarcoAurelio) [21:33:07] (03CR) 10Esanders: "Apparently there will still be cursoring issues in RTL, see T170001" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/376894 (owner: 10Ebrahim) [21:34:19] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/377013 [21:34:21] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/377013 (owner: 10SamanthaNguyen) [21:34:39] (03Merged) 10jenkins-bot: Improve some parameter docs [skins/Vector] - 10https://gerrit.wikimedia.org/r/376887 (owner: 10Umherirrender) [21:35:15] (03PS1) 10EBernhardson: Try even harder to not show survey multiple times [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/377014 (https://phabricator.wikimedia.org/T171740) [21:36:11] (03PS1) 10Aaron Schulz: Remove use of implicitGroupBy() in ActiveUsersPager [core] - 10https://gerrit.wikimedia.org/r/377015 (https://phabricator.wikimedia.org/T160298) [21:36:14] (03PS1) 10Aaron Schulz: Deprecate IDatabase::implicitGroupby() [core] - 10https://gerrit.wikimedia.org/r/377016 [21:37:20] (03CR) 10Aaron Schulz: [C: 032] Avoid using the deprecated ParserCache::singleton() [core] - 10https://gerrit.wikimedia.org/r/376855 (owner: 10Legoktm) [21:37:22] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/377017 [21:37:23] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/377017 (owner: 10SamanthaNguyen) [21:37:33] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/377018 [21:37:35] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/377018 (owner: 10SamanthaNguyen) [21:37:43] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/TopLists] - 10https://gerrit.wikimedia.org/r/377019 [21:37:45] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/TopLists] - 10https://gerrit.wikimedia.org/r/377019 (owner: 10SamanthaNguyen) [21:37:52] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/Video] - 10https://gerrit.wikimedia.org/r/377020 [21:37:54] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/Video] - 10https://gerrit.wikimedia.org/r/377020 (owner: 10SamanthaNguyen) [21:38:00] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/377021 [21:38:02] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/377021 (owner: 10SamanthaNguyen) [21:38:16] (03PS1) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/377022 [21:38:18] (03CR) 10SamanthaNguyen: [C: 032] DB_SLAVE to DB_REPLICA [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/377022 (owner: 10SamanthaNguyen) [21:39:23] 10Wikimedia-IEG-grant-review: Pagination is not working on Aggregated reports page - https://phabricator.wikimedia.org/T116259#1744722 (10bd808) The pagination buttons will actually be displayed if you add `?items=5` (or some other number less then the total number of proposals in the campaign), but it does not... [21:39:55] 10Outreach-Programs-Projects, 10Outreachy (Round-15): Improvements to Grants review and Wikimania scholarships web apps - https://phabricator.wikimedia.org/T174759#3594056 (10bd808) >>! In T174759#3593521, @SushmaK12 wrote: > Hence, I need some help in getting started here, how to start with micro-tasks mentio... [21:40:25] (03PS2) 10EBernhardson: Try even harder to not show survey multiple times [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/377014 (https://phabricator.wikimedia.org/T171740) [21:45:01] (03PS2) 10SamanthaNguyen: DB_SLAVE to DB_REPLICA [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/377007 [21:46:12] (03CR) 10SamanthaNguyen: "(another change I meant for another patchset slid in here)" [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/377007 (owner: 10SamanthaNguyen) [21:48:05] (03CR) 10Reedy: "Doesn't this effectively just revert https://gerrit.wikimedia.org/r/#/c/147647/ and therefore reopen https://phabricator.wikimedia.org/T70" [core] - 10https://gerrit.wikimedia.org/r/377015 (https://phabricator.wikimedia.org/T160298) (owner: 10Aaron Schulz) [21:52:37] did someone break jenkins :S all the graphs on https://integration.wikimedia.org/zuul/ spiked and results are taking forever [21:53:18] ebernhardson: SamanthaNguyen merged a lot of patches [21:53:37] Though, it does kinda look like it's stopped doing anything [21:54:56] ebernhardson: Sorry :( [21:57:27] nodepool graph does look suspicious. 9 nodes building (being created), 9 delete, 2 ready, 3 used, 2 free [21:57:39] but i know nothing about nodepool beyond the pretty graph :P [21:58:52] 20 minutes ago all 25 servers (25 is the cap on instances) were in the delete state. [22:01:57] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikimedia-General-or-Unknown, and 5 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3594059 (10Josve05a) [22:09:10] yea looks like jenkins is busted, no nodes for running tests are active, and none have succesfully built in the last 30 minutes :( [22:17:33] (03PS1) 10Umherirrender: Fix return of Interwiki::invalidateCache [core] - 10https://gerrit.wikimedia.org/r/377024 [22:33:07] (03PS24) 10Dbarratt: Allow users to restrict who can send them direct emails via Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) [22:33:24] (03CR) 10jerkins-bot: [V: 04-1] Allow users to restrict who can send them direct emails via Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) (owner: 10Dbarratt) [22:37:48] (03CR) 10MaxSem: Allow users to restrict who can send them direct emails via Special:EmailUser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) (owner: 10Dbarratt) [22:40:00] (03PS25) 10Dbarratt: Allow users to restrict who can send them direct emails via Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) [22:40:27] 10MediaWiki-extensions-Newsletter: Protection does not function on newsletters - https://phabricator.wikimedia.org/T154615#3594065 (10Pppery) The solution in that case is to make it impossible to protect newsletters in the first place, whereas it currently is possible to protect them, without effect. [22:44:22] (03CR) 10Dbarratt: Allow users to restrict who can send them direct emails via Special:EmailUser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) (owner: 10Dbarratt) [22:45:03] (03PS1) 10Umherirrender: Add missing @return to function docs [core] - 10https://gerrit.wikimedia.org/r/377026 [22:50:26] (03CR) 10TTO: Allow users to restrict who can send them direct emails via Special:EmailUser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) (owner: 10Dbarratt) [22:52:30] (03CR) 10Dbarratt: "@TTO & @MaxSem So... any changes?" [core] - 10https://gerrit.wikimedia.org/r/374361 (https://phabricator.wikimedia.org/T138166) (owner: 10Dbarratt) [23:07:40] (03PS1) 10Legoktm: [WIP] Split URL generation functions out of Title into a separate service [core] - 10https://gerrit.wikimedia.org/r/377027 [23:07:52] 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: Investigation: See if there is a better way to handle VE tab control than bypassing the no article page - https://phabricator.wikimedia.org/T175460#3594066 (10kaldari) [23:08:13] 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: Investigation: See if there is a better way to handle VE tab control than bypassing the no article page - https://phabricator.wikimedia.org/T175460#3594078 (10kaldari) p:05Triage>03High [23:19:04] (03PS3) 10VolkerE: Remove contentSub from layout when empty [core] - 10https://gerrit.wikimedia.org/r/376879 [23:32:18] (03CR) 10Umherirrender: [C: 032] DB_SLAVE to DB_REPLICA [extensions/RandomFeaturedUser] - 10https://gerrit.wikimedia.org/r/377007 (owner: 10SamanthaNguyen) [23:35:39] (03CR) 10Umherirrender: [C: 032] DB_SLAVE to DB_REPLICA [extensions/Athena] - 10https://gerrit.wikimedia.org/r/376939 (owner: 10SamanthaNguyen) [23:39:54] (03CR) 10Legoktm: [C: 04-1] "I'm also wondering whether this would fit better in the electron PDF extension..?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/376486 (https://phabricator.wikimedia.org/T171838) (owner: 10Gergő Tisza) [23:40:51] (03CR) 10Umherirrender: "It was backported to 1.27 with I1f014ea7432ab7ceda60443f7633b0806a48bf13 and should work with 1.28" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/376960 (owner: 10SamanthaNguyen) [23:42:09] (03CR) 10Legoktm: [C: 032] Minor fixes to ParsoidVirtualRESTService [core] - 10https://gerrit.wikimedia.org/r/376485 (owner: 10Gergő Tisza) [23:44:36] (03PS1) 10Umherirrender: Fix return in HttpStatus::header [core] - 10https://gerrit.wikimedia.org/r/377029 [23:52:31] (03PS1) 10Umherirrender: Always return bool from MysqlUpdater::doInterwikiUpdate [core] - 10https://gerrit.wikimedia.org/r/377030 [23:53:22] (03Merged) 10jenkins-bot: Convert AccountInfo.alias.php to use PHP short array syntax [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/375536 (owner: 10MarcoAurelio) [23:54:23] (03Merged) 10jenkins-bot: build: Always exclude vendor and node_modules [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/376776 (owner: 10Umherirrender) [23:55:14] (03CR) 10Umherirrender: "It seems each function handle it different with a return value. Have no idea of the best way to resolve it. Return bool from all or from n" [core] - 10https://gerrit.wikimedia.org/r/377030 (owner: 10Umherirrender) [23:59:48] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/377008 (owner: 10SamanthaNguyen) [23:59:50] (03CR) 10jerkins-bot: [V: 04-1] build: Always exclude vendor and node_modules [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/376765 (owner: 10Umherirrender) [23:59:52] (03Merged) 10jenkins-bot: DB_SLAVE to DB_REPLICA [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/377009 (owner: 10SamanthaNguyen)