[00:02:46] 10MediaWiki-extensions-GettingStarted, 05MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), 13Patch-For-Review, 07Unplanned-Sprint-Work, 15User-zeljkofilipin: GettingStarted failing on Jenkins due to CAPTCHA bypass - https://phabricator.wikimedia.org/T155797#3129733 (10Mattflaschen-WMF) >>! In T155... [00:08:33] (03CR) 10Zppix: "Recheck" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/344726 (owner: 10Harjotsingh) [00:15:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 07Regression, 03Wikidata-Sprint: Wikidata does not accept characters ending in \x85 (Cyrillic х, Armenian Յ, Arabic م etc.) in labels/aliases/descriptions - https://phabricator.wikimedia.org/T161263#3126886 (10NickK) Do I understa... [00:18:02] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-blocking, 06Support-and-Safety, 03Community-Tech-Sprint: Test cookie blocking on Test Wikipedia - https://phabricator.wikimedia.org/T158129#3129745 (10kaldari) 05Open>03Resolved Sounds like it's basically working, but perhaps not as foolpro... [00:18:08] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-blocking, 06Community-Tech, 06Support-and-Safety, and 2 others: Send a cookie with each block - https://phabricator.wikimedia.org/T5233#3129747 (10kaldari) [00:27:29] 10MediaWiki-extensions-Scribunto: Unknown exception from Thomas Mann page on rowiki - https://phabricator.wikimedia.org/T161361#3129752 (10EBernhardson) [00:35:25] 10MediaWiki-User-blocking, 06Support-and-Safety, 10Wikimedia-Site-requests, 03Community-Tech-Sprint, 13Patch-For-Review: Enable and test cookie blocking on English Wikipedia - https://phabricator.wikimedia.org/T152076#3129765 (10kaldari) This should actually happen soon, as all blockers are cleared and w... [00:37:20] (03PS1) 10Krinkle: qunit: Remove experimental CompletenessTest feature [core] - 10https://gerrit.wikimedia.org/r/344731 (https://phabricator.wikimedia.org/T155194) [00:38:06] 10MediaWiki-Unit-tests, 06Performance-Team, 10Developer-Wishlist (2017), 13Patch-For-Review, 07Technical-Debt: Remove QUnit CompletenessTest - https://phabricator.wikimedia.org/T155194#3129768 (10Krinkle) [00:39:25] (03CR) 10Jforrester: [C: 031] Tour: Fix initialize() race condition [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/343779 (owner: 10Krinkle) [00:45:09] 10MediaWiki-Email, 10MediaWiki-extensions-GPGMail, 05MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), 05MW-1.27-release-notes, 07Privacy: Encrypt emails with GnuPG (GPG) - https://phabricator.wikimedia.org/T12453#3129770 (10Platonides) What should we do if the PGP key expires? I see three main op... [00:47:14] (03CR) 10Jforrester: [C: 032] qunit: Remove experimental CompletenessTest feature [core] - 10https://gerrit.wikimedia.org/r/344731 (https://phabricator.wikimedia.org/T155194) (owner: 10Krinkle) [00:47:25] 10MediaWiki-extensions-Scribunto: Unknown exception from Thomas Mann page on rowiki - https://phabricator.wikimedia.org/T161361#3129771 (10EBernhardson) Currently able to reproduce this in mwrepl with: ``` break Scribunto_LuaSandboxInterpreter::callFunction() $ctx = new RequestContext();$ctx->setTitle(Title::ne... [00:48:43] 10MediaWiki-Unit-tests, 06Performance-Team, 10Developer-Wishlist (2017), 07Technical-Debt: Remove QUnit CompletenessTest - https://phabricator.wikimedia.org/T155194#3129773 (10Jdforrester-WMF) 05Open>03Resolved [00:49:54] (03CR) 10Jforrester: [C: 032] Check for string initialization in lcfirst() for HHVM 3.18 [core] - 10https://gerrit.wikimedia.org/r/344617 (https://phabricator.wikimedia.org/T161095) (owner: 10Hashar) [00:51:56] 10MediaWiki-extensions-Scribunto: Unknown exception from Thomas Mann page on rowiki - https://phabricator.wikimedia.org/T161361#3129752 (10Platonides) It doesn't have debug symbols for /usr/lib/x86_64-linux-gnu/liblua5.1-c++.so.0 Those are provided by the liblua5.1-0-dbg package. [00:52:26] ^ ebernhardson [00:52:47] (03CR) 10Jforrester: Add @since tags to WikiRevision (031 comment) [core] - 10https://gerrit.wikimedia.org/r/343010 (owner: 10Addshore) [00:53:14] (03PS5) 10Jforrester: Add @since tags to WikiRevision [core] - 10https://gerrit.wikimedia.org/r/343010 (owner: 10Addshore) [00:54:10] (03CR) 10Jforrester: [C: 032] Add missing @group Database tags in tests [core] - 10https://gerrit.wikimedia.org/r/343529 (owner: 10Aude) [00:54:42] (03CR) 10Jforrester: [C: 031] Only do database test setup when tests require database (needsDB) [core] - 10https://gerrit.wikimedia.org/r/343526 (owner: 10Aude) [00:54:52] Platonides: sure, but i can't just go installing things on terbium [00:55:31] it also doesn't have debugging symbols for our luasandbox hhvm module [00:56:50] (03PS3) 10Samwilson: Fix various docblock formatting [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/344301 [00:57:30] those might not be needed [00:58:08] i'd bet $0.02 that the bug itself is in luasandbox's usage of liblua, and not liblua itself. Knowing what in luasandbox.so called lua and with what arguments is probably whats needed [00:58:38] (03Merged) 10jenkins-bot: qunit: Remove experimental CompletenessTest feature [core] - 10https://gerrit.wikimedia.org/r/344731 (https://phabricator.wikimedia.org/T155194) (owner: 10Krinkle) [00:58:39] although it could also be that some previous usage got lua into a bad state, and this call just triggers that bad state [00:59:18] (03CR) 10Jforrester: [C: 031] Apply image styling to mw:Video / mw:Audio for Parsoid content [core] - 10https://gerrit.wikimedia.org/r/340911 (owner: 10Arlolra) [00:59:18] that seems less likely [00:59:41] I'd like to have a look at it, but i don't have a proper setup [01:01:56] maybe it could be reproduced on beta [01:02:10] (03CR) 10Jforrester: [C: 032] "Not un-useful." [core] - 10https://gerrit.wikimedia.org/r/343010 (owner: 10Addshore) [01:03:25] (03Merged) 10jenkins-bot: Check for string initialization in lcfirst() for HHVM 3.18 [core] - 10https://gerrit.wikimedia.org/r/344617 (https://phabricator.wikimedia.org/T161095) (owner: 10Hashar) [01:04:33] 10TimedMediaHandler: Deal with no longer used noicon/noplayer mode of TMH - https://phabricator.wikimedia.org/T134880#2280653 (10Jdforrester-WMF) I think flagging them as bogus options will be a nice fix. Beyond that I don't think we need to worry about them for Parsoid, and should drop special-casing them from... [01:08:25] 10MediaWiki-extensions-LoginNotify, 03Community-Tech-Sprint, 13Patch-For-Review: Investigation: Config settings for LoginNotify in production - https://phabricator.wikimedia.org/T160094#3129785 (10kaldari) @Bawolff: Would love to get your assent on the settings above before moving forward with this in produc... [01:10:09] 10MediaWiki-extensions-Scribunto: Unknown exception from Thomas Mann page on rowiki - https://phabricator.wikimedia.org/T161361#3129788 (10EBernhardson) [01:13:56] (03Merged) 10jenkins-bot: Add missing @group Database tags in tests [core] - 10https://gerrit.wikimedia.org/r/343529 (owner: 10Aude) [01:14:20] (03Merged) 10jenkins-bot: Add @since tags to WikiRevision [core] - 10https://gerrit.wikimedia.org/r/343010 (owner: 10Addshore) [01:17:56] (03CR) 10Krinkle: [C: 032] Move IDatabase/IMaintainableDatabase to Rdbms namespace [core] - 10https://gerrit.wikimedia.org/r/336371 (owner: 10Aaron Schulz) [01:26:45] (03CR) 10jenkins-bot: qunit: Remove experimental CompletenessTest feature [core] - 10https://gerrit.wikimedia.org/r/344731 (https://phabricator.wikimedia.org/T155194) (owner: 10Krinkle) [01:29:34] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Allow drag and drop of images into a gallery (to move the image into a gallery), out of it (to move an image from the gallery to the text), and both (to move an i... - https://phabricator.wikimedia.org/T158839#3049107 [01:30:22] 10MediaWiki-extensions-LoginNotify, 07Privacy: Do a Privacy Check-In for LoginNotify extension - https://phabricator.wikimedia.org/T161362#3129813 (10kaldari) [01:31:51] 10MediaWiki-extensions-LoginNotify, 07Privacy: Do a Privacy Check-In for LoginNotify extension - https://phabricator.wikimedia.org/T161362#3129830 (10kaldari) [01:31:59] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 06Community-Tech, 07User-notice: Send notification to account owner on multiple unsuccessful login attempts - https://phabricator.wikimedia.org/T11838#3129831 (10kaldari) [01:32:04] 10MediaWiki-extensions-LoginNotify, 07Privacy: Do a Privacy Check-In for LoginNotify extension - https://phabricator.wikimedia.org/T161362#3129813 (10kaldari) p:05Triage>03High [01:32:16] (03CR) 10jerkins-bot: [V: 04-1] Move IDatabase/IMaintainableDatabase to Rdbms namespace [core] - 10https://gerrit.wikimedia.org/r/336371 (owner: 10Aaron Schulz) [01:32:18] 10MediaWiki-extensions-LoginNotify, 06Community-Tech, 07Privacy: Do a Privacy Check-In for LoginNotify extension - https://phabricator.wikimedia.org/T161362#3129813 (10kaldari) [01:35:32] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: Consider redesigning the integration of VisualEditor to keep the page title/subtitle above the toolbar - https://phabricator.wikimedia.org/T159913#3129848 (10Jdforrester-WMF) [01:39:21] (03CR) 10Krinkle: [C: 032] Decode '0'-valued user options to integer 0 [core] - 10https://gerrit.wikimedia.org/r/343861 (owner: 10Anomie) [01:41:17] (03CR) 10jenkins-bot: Check for string initialization in lcfirst() for HHVM 3.18 [core] - 10https://gerrit.wikimedia.org/r/344617 (https://phabricator.wikimedia.org/T161095) (owner: 10Hashar) [01:50:58] (03Merged) 10jenkins-bot: Decode '0'-valued user options to integer 0 [core] - 10https://gerrit.wikimedia.org/r/343861 (owner: 10Anomie) [01:52:17] (03CR) 10Krinkle: [C: 031] build: karma now reports with mocha formatter [core] - 10https://gerrit.wikimedia.org/r/341377 (owner: 10Hashar) [01:54:51] (03CR) 10jenkins-bot: Add missing @group Database tags in tests [core] - 10https://gerrit.wikimedia.org/r/343529 (owner: 10Aude) [02:10:03] (03CR) 10jenkins-bot: Add @since tags to WikiRevision [core] - 10https://gerrit.wikimedia.org/r/343010 (owner: 10Addshore) [02:24:01] (03CR) 10jenkins-bot: Decode '0'-valued user options to integer 0 [core] - 10https://gerrit.wikimedia.org/r/343861 (owner: 10Anomie) [02:26:49] (03PS1) 10Krinkle: WikiPage: Remove unused doPurge flags [core] - 10https://gerrit.wikimedia.org/r/344737 [02:27:26] (03PS1) 10Smalyshev: Move request switches handling into Searcher [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/344738 [02:27:29] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Outreach-Programs-Projects, and 4 others: Article Reminder - https://phabricator.wikimedia.org/T161364#3129947 (10Adedayomatt) [02:31:27] (03CR) 10Krinkle: [C: 04-1] Rename CategorySelector to CategorySelectorWidget (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344588 (https://phabricator.wikimedia.org/T161285) (owner: 10Prtksxna) [02:32:00] (03CR) 10Krinkle: [C: 031] ForeignStructuredUpload.BookletLayout: Use CategorySelectorWidget [core] - 10https://gerrit.wikimedia.org/r/344592 (https://phabricator.wikimedia.org/T161285) (owner: 10Prtksxna) [02:32:34] (03PS2) 10Smalyshev: Move request switches handling into Searcher [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/344738 [02:33:04] 10MediaWiki-Database, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-WikibaseClient, 06Performance-Team, and 2 others: Reduce ChronologyProtector init cost for load.php - https://phabricator.wikimedia.org/T160678#3107420 (10Krinkle) p:05Triage>03Normal [02:39:49] (03CR) 10jerkins-bot: [V: 04-1] Move request switches handling into Searcher [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/344738 (owner: 10Smalyshev) [02:44:29] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/344738 (owner: 10Smalyshev) [02:50:59] (03CR) 10Krinkle: "One minor nit." (031 comment) [extensions/PerformanceInspector] - 10https://gerrit.wikimedia.org/r/343852 (https://phabricator.wikimedia.org/T159419) (owner: 10Phedenskog) [02:56:44] (03PS1) 10Subramanya Sastry: Tweak CSS for Parsoid
s [core] - 10https://gerrit.wikimedia.org/r/344739 [02:57:22] (03CR) 10Krinkle: [C: 031] [WIP] Defer calling ChronologyProtector::initLB() until connecting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344573 (https://phabricator.wikimedia.org/T160678) (owner: 10Aaron Schulz) [02:59:14] (03CR) 10Krinkle: "This is essentially a fixup following up to e7a4daf76a527a9935fe6de3b88ae334731d5c0a - which only recently changed these colours, but negl" [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [03:00:51] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3130007 (10Mattflaschen-WMF) >>! In T2582#3127346, @Eugene233 wrote: > Ok that's nice. please I wish to wor... [03:02:32] (03CR) 10Subramanya Sastry: "Ah well .. I've now started running mass visual diff tests .. so, such regressions will hopefully get caught sooner." [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [03:05:45] 10MediaWiki-Gallery, 10MediaWiki-Templates: Cannot use templates in caption - https://phabricator.wikimedia.org/T33517#3130021 (10Jdforrester-WMF) 05Open>03declined We're not intending to do this. Ideally we'd block the `#tag` hack as well. [03:09:21] 10Graphs, 13Patch-For-Review: Display graph preview while editing in dialog - https://phabricator.wikimedia.org/T151127#3130034 (10Jdforrester-WMF) [03:19:50] (03CR) 10Aaron Schulz: Send integer ms to DB lag time guage instead of seconds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344472 (https://phabricator.wikimedia.org/T149210) (owner: 10Aaron Schulz) [03:23:18] (03PS1) 10Krinkle: resourceloader: Optimise getMimeType() for common case [core] - 10https://gerrit.wikimedia.org/r/344741 [03:24:15] (03CR) 10Krinkle: [C: 031] Tweak CSS for Parsoid
s [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [03:27:14] 10Improving-access, 06Research-and-Data-Backlog, 07Epic: [Epic] Link recommendation - https://phabricator.wikimedia.org/T128244#2068380 (10Jdforrester-WMF) [03:27:54] (03CR) 10Krinkle: Send integer ms to DB lag time guage instead of seconds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344472 (https://phabricator.wikimedia.org/T149210) (owner: 10Aaron Schulz) [03:28:27] (03CR) 10Krinkle: "Fatal error: Cannot use IDatabase as IDatabase because the name is already in use in /home/jenkins/workspace/mediawiki-phpunit-php55-trust" [core] - 10https://gerrit.wikimedia.org/r/336371 (owner: 10Aaron Schulz) [03:28:51] 10Page-Previews: Page Preview prevents you from clicking link - https://phabricator.wikimedia.org/T161366#3130090 (10kaldari) [03:29:28] (03CR) 10Jforrester: "Ping. What's the status of this? Is it just waiting for someone to have time to make small fixes and merge? Is the change subject to dispu" [core] - 10https://gerrit.wikimedia.org/r/292041 (https://phabricator.wikimedia.org/T136641) (owner: 10Eranroz) [03:29:36] (03PS2) 10Krinkle: Revert Message dependency from DB exception classes [core] - 10https://gerrit.wikimedia.org/r/339659 (owner: 10Aaron Schulz) [03:29:59] (03PS3) 10Krinkle: Move DB errors to Rdbms namespace [core] - 10https://gerrit.wikimedia.org/r/339658 (owner: 10Aaron Schulz) [03:30:08] (03PS3) 10Krinkle: Revert Message dependency from DB exception classes [core] - 10https://gerrit.wikimedia.org/r/339659 (owner: 10Aaron Schulz) [03:30:17] 10Android-app-Bugs, 06Reading-Web-Backlog, 10Reading-Web-Local-Wiki-Issues, 10TextExtracts, and 2 others: Content intended to be hidden appears in text extract - https://phabricator.wikimedia.org/T126331#3130105 (10kaldari) [03:30:57] (03CR) 10Krinkle: "This is obsolete now with the improved edit stashing, right?" [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [03:33:44] (03PS6) 10Krinkle: [WIP] startup: Drop JavaScript support for ES3-only browsers [core] - 10https://gerrit.wikimedia.org/r/340893 (https://phabricator.wikimedia.org/T128115) (owner: 10Jforrester) [03:34:02] (03PS1) 10Kaldari: Adding sortkey class to ExtractsRemoveClasses [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/344742 (https://phabricator.wikimedia.org/T161194) [03:36:58] (03CR) 10Jforrester: [C: 032] Remove trailing space from json [extensions/VIKI] - 10https://gerrit.wikimedia.org/r/344495 (owner: 10Umherirrender) [03:37:07] (03CR) 10Jforrester: [C: 032] Remove trailing space and fix spaces in json [extensions/RelatedLinks] - 10https://gerrit.wikimedia.org/r/344494 (owner: 10Umherirrender) [03:37:14] (03CR) 10Jforrester: [C: 032] Fix indent in json [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/344493 (owner: 10Umherirrender) [03:37:47] (03CR) 10Kaldari: [C: 032] Complete documentation of config variables [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/344661 (https://phabricator.wikimedia.org/T160094) (owner: 10MusikAnimal) [03:38:01] 10MediaWiki-extensions-Linter, 10Wikimedia-Extension-setup, 13Patch-For-Review, 07User-notice: Review and deploy Linter extension to Wikimedia wikis - https://phabricator.wikimedia.org/T148609#2727699 (10Jdforrester-WMF) When will this come to other wikis? I particularly want to get started on fixing enwik... [03:38:23] (03CR) 10jerkins-bot: [V: 04-1] Revert Message dependency from DB exception classes [core] - 10https://gerrit.wikimedia.org/r/339659 (owner: 10Aaron Schulz) [03:38:26] (03CR) 10jerkins-bot: [V: 04-1] Move DB errors to Rdbms namespace [core] - 10https://gerrit.wikimedia.org/r/339658 (owner: 10Aaron Schulz) [03:39:57] 10MediaWiki-Page-editing, 06Community-Liaisons, 06Editing-Department, 10Wikidata, 07User-notice: Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org - https://phabricator.wikimedia.org/T161367#3130114 (10Jdforrester-WMF) [03:40:32] (03Merged) 10jenkins-bot: Remove trailing space from json [extensions/VIKI] - 10https://gerrit.wikimedia.org/r/344495 (owner: 10Umherirrender) [03:40:34] (03Merged) 10jenkins-bot: Remove trailing space and fix spaces in json [extensions/RelatedLinks] - 10https://gerrit.wikimedia.org/r/344494 (owner: 10Umherirrender) [03:40:51] (03Merged) 10jenkins-bot: Fix indent in json [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/344493 (owner: 10Umherirrender) [03:40:53] (03PS1) 10Krinkle: Use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 [03:41:39] 10Wikimedia-Site-requests, 07Community-consensus-needed: Change time zone in all sa.wiki* WMF projects - https://phabricator.wikimedia.org/T160496#3130129 (10NehalDaveND) Community found other solution. So we don't do this task. Thank you. [03:41:57] 10MediaWiki-General-or-Unknown, 06Performance-Team, 07JavaScript, 13Patch-For-Review: Adopt direct use of ES5 methods in core - https://phabricator.wikimedia.org/T160953#3130130 (10Krinkle) [03:42:52] (03Merged) 10jenkins-bot: Complete documentation of config variables [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/344661 (https://phabricator.wikimedia.org/T160094) (owner: 10MusikAnimal) [03:42:54] (03PS1) 10Krinkle: resourceloader: Use Date.now() for mw.now() instead of '+new Date' [core] - 10https://gerrit.wikimedia.org/r/344744 (https://phabricator.wikimedia.org/T160953) [03:43:09] (03CR) 10Jforrester: [C: 032] Tweak CSS for Parsoid
s [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [03:43:33] (03PS2) 10Krinkle: Use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 [03:43:45] (03PS3) 10Krinkle: Use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 [03:44:24] (03PS4) 10Jforrester: Ensure we use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 (owner: 10Krinkle) [03:44:28] (03CR) 10Jforrester: [C: 032] Ensure we use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 (owner: 10Krinkle) [03:45:06] (03CR) 10Jforrester: [C: 04-2] "Rebase onto I95400637d" [core] - 10https://gerrit.wikimedia.org/r/344744 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [03:46:01] (03PS2) 10Krinkle: resourceloader: Use Date.now() for mw.now() instead of '+new Date' [core] - 10https://gerrit.wikimedia.org/r/344744 (https://phabricator.wikimedia.org/T160953) [03:53:41] (03Merged) 10jenkins-bot: Tweak CSS for Parsoid
s [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [03:56:15] (03Merged) 10jenkins-bot: Ensure we use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 (owner: 10Krinkle) [04:08:38] (03CR) 10jenkins-bot: Tweak CSS for Parsoid
s [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [04:20:55] (03PS1) 10Krinkle: resourceloader: Use Array#map instead of jQuery#map for arrays [core] - 10https://gerrit.wikimedia.org/r/344745 [04:23:20] (03CR) 10jenkins-bot: Ensure we use mw.now() instead of 'new Date' for relative measurement [core] - 10https://gerrit.wikimedia.org/r/344743 (owner: 10Krinkle) [04:23:58] (03PS1) 10Krinkle: resourceloader: Use Object.keys() instead of map() to get keys [core] - 10https://gerrit.wikimedia.org/r/344746 [04:24:38] (03PS2) 10Krinkle: resourceloader: Use Array#map instead of jQuery#map for arrays [core] - 10https://gerrit.wikimedia.org/r/344745 (https://phabricator.wikimedia.org/T160953) [04:24:40] (03PS2) 10Krinkle: resourceloader: Use Object.keys() instead of map() to get keys [core] - 10https://gerrit.wikimedia.org/r/344746 [04:24:52] (03PS3) 10Krinkle: resourceloader: Use Object.keys() instead of map() to get keys [core] - 10https://gerrit.wikimedia.org/r/344746 (https://phabricator.wikimedia.org/T160953) [04:26:08] (03PS5) 10Krinkle: Replace deprecated jQuery.isArray by Array.isArray [core] - 10https://gerrit.wikimedia.org/r/343249 (https://phabricator.wikimedia.org/T160953) (owner: 10Fomafix) [04:27:36] James_F: https://gerrit.wikimedia.org/r/344745 - see gist, interestingly es5 map is 10% slower than jq map on V8. On all other browsers, es5 is faster though [04:27:44] (upto 50-60% even) [04:28:01] also jq3 map is slower than jq1 map, due to iOS hacks [04:28:13] Huh. [04:28:24] That's a little sad. [04:28:46] See isArrayLike implementation [04:28:54] they should probably check isArray() before the other variables [04:29:13] anyhow, it's pretty marginal [04:29:16] about 1-5% slower [04:30:11] After these patches, there is almost no use of jQuery in mediawiki.js, besides $.Callbacks()/$.Deferred(), which are fair for now. [04:31:16] Would loading jQuery in parallel with MediaWiki.js speed things up much? [04:33:33] combining them will most likely be faster than in paralel [04:34:05] still single threaded [04:34:23] and browsers already stream parse [04:36:03] (03PS3) 10Prtksxna: Rename CategorySelector to CategorySelectorWidget [core] - 10https://gerrit.wikimedia.org/r/344588 (https://phabricator.wikimedia.org/T161285) [04:36:12] (03CR) 10Prtksxna: Rename CategorySelector to CategorySelectorWidget (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344588 (https://phabricator.wikimedia.org/T161285) (owner: 10Prtksxna) [04:38:27] (03CR) 10Prtksxna: "Thanks for the explanation Timo. I knew I was doing something funny." [core] - 10https://gerrit.wikimedia.org/r/344588 (https://phabricator.wikimedia.org/T161285) (owner: 10Prtksxna) [04:42:51] (03CR) 10Jforrester: [C: 031] resourceloader: Use Array#map instead of jQuery#map for arrays [core] - 10https://gerrit.wikimedia.org/r/344745 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [04:43:54] (03CR) 10Jforrester: [C: 031] resourceloader: Use Object.keys() instead of map() to get keys [core] - 10https://gerrit.wikimedia.org/r/344746 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [04:44:08] (03CR) 10Jforrester: [C: 031] resourceloader: Use Date.now() for mw.now() instead of '+new Date' [core] - 10https://gerrit.wikimedia.org/r/344744 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [04:44:48] 10Security-Reviews, 10Timeless: Security review for Timeless skin - https://phabricator.wikimedia.org/T158011#3130152 (10Isarra) Ah feck, I should have done this before refactoring the entire thing. >.> [04:45:36] (03CR) 10Jforrester: "For those following along, we're planning to do this soon after I95400637d (requiring ES5 clients)." [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [04:48:22] buggerdebuggy bug [05:01:08] 10Security-Reviews, 10Timeless: Security review for Timeless skin - https://phabricator.wikimedia.org/T158011#3130178 (10Isarra) > "TimelessTemplate.php" line 300 - Run the id through Sanitizer::escapeId just in case. Even in the case that we know the value is safe, if the value comes from a different function... [05:02:22] 10Timeless: Optimise icons - https://phabricator.wikimedia.org/T161369#3130179 (10Isarra) [05:02:35] (03CR) 10Prtksxna: "IE testing pending, will do on Monday." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/343441 (https://phabricator.wikimedia.org/T58471) (owner: 10Prtksxna) [05:03:45] 10Timeless: Convert icons to use ResourceLoaderImageModule for variants etc - https://phabricator.wikimedia.org/T161370#3130191 (10Isarra) [05:04:58] 10Timeless: Make search placeholder text shorter - https://phabricator.wikimedia.org/T160647#3130203 (10Isarra) Was 'Search the text of approximately $1 pages'. Is now 'Search approximately $1 pages'. May still be too long. [05:07:35] (03CR) 10KartikMistry: [C: 031] build: karma now reports with mocha formatter [core] - 10https://gerrit.wikimedia.org/r/341377 (owner: 10Hashar) [06:19:19] 10Wikimedia-General-or-Unknown, 07JavaScript: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software - https://phabricator.wikimedia.org/T71550#3130225 (10Prtksxna) [06:20:41] (03CR) 10VolkerE: "Thanks for catching those!" [core] - 10https://gerrit.wikimedia.org/r/344739 (owner: 10Subramanya Sastry) [06:30:51] 06Brickimedia, 10Refreshed: Refreshed should integrate native-support for VisualEditor - https://phabricator.wikimedia.org/T134668#3130272 (10Isarra) [06:43:30] 10Timeless: Better category handling - https://phabricator.wikimedia.org/T160645#3130275 (10Isarra) Generally: reconsider TimelessTemplate::getCategories. What is the point of this, really? [06:44:54] (03PS1) 10Isarra: Refactor TimelessTemplate.php [skins/Timeless] - 10https://gerrit.wikimedia.org/r/344748 [06:46:43] (03CR) 10jerkins-bot: [V: 04-1] Refactor TimelessTemplate.php [skins/Timeless] - 10https://gerrit.wikimedia.org/r/344748 (owner: 10Isarra) [08:34:06] (03CR) 10Umherirrender: NamespaceManager: API Unittest (032 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/344157 (owner: 10ItSpiderman) [08:42:40] 10MediaWiki-Gallery: Adjustable widths for galleries in slideshow mode - https://phabricator.wikimedia.org/T154013#3130433 (10StarWarden) Hey. Could I get an answer if this is something that is going to be worked on (and possibly added) in MediaWiki 1.29? I wouldn't like to insist much on it, but it's something... [08:43:41] 10MediaWiki-extensions-AutoCreateCategoryPage: Change AutoCreateCategoryPages to not have to grab entire namespace - https://phabricator.wikimedia.org/T161387#3130447 (10Reception123) [08:49:02] 10MediaWiki-extensions-AutoCreateCategoryPage: Change AutoCreateCategoryPages to not have to grab entire namespace - https://phabricator.wikimedia.org/T161387#3130461 (10labster) Hi, I'm here, a little. Just going to say that caching the entire category namespace sounds like a nightmare, if only because of the... [09:14:04] (03CR) 10Mvolz: [C: 04-1] Put Html code of Answer in Question.php into mustache template (031 comment) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/344726 (owner: 10Harjotsingh) [09:47:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 07Regression, 03Wikidata-Sprint: Wikidata does not accept characters ending in \x85 (Cyrillic х, Armenian Յ, Arabic م etc.) in labels/aliases/descriptions - https://phabricator.wikimedia.org/T161263#3130615 (10Lydia_Pintscher) [09:48:19] (03PS1) 10Umherirrender: Use tabs in json [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/344752 [09:48:45] (03PS1) 10Umherirrender: Use tabs in json [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/344753 [09:49:20] (03PS1) 10Umherirrender: Use tabs in json [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/344754 [09:51:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 07Regression, 03Wikidata-Sprint: Wikidata does not accept characters ending in \x85 (Cyrillic х, Armenian Յ, Arabic م etc.) in labels/aliases/descriptions - https://phabricator.wikimedia.org/T161263#3130619 (10Lydia_Pintscher) htt... [09:55:23] (03PS1) 10Umherirrender: Use tabs in json [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344755 [09:55:45] (03PS1) 10Umherirrender: Use tabs in json [extensions/reCaptcha] - 10https://gerrit.wikimedia.org/r/344756 [09:56:47] (03PS1) 10Umherirrender: Use tabs in json [extensions/StlHandler] - 10https://gerrit.wikimedia.org/r/344758 [09:57:06] (03PS1) 10Umherirrender: Use tabs in json [extensions/UserPageEditProtection] - 10https://gerrit.wikimedia.org/r/344759 [09:57:25] (03PS1) 10Umherirrender: Use tabs in json [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/344760 [09:58:19] 10Wikimedia-General-or-Unknown, 07JavaScript: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software - https://phabricator.wikimedia.org/T71550#3130622 (10Prtksxna) >>! From the **description**: > [ ] MediaWiki:Gadget-featured-articles-links.js, used by a few wikis to add icons to the sideba... [10:14:25] (03PS2) 10Umherirrender: Use tabs in json [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/344752 [10:16:11] (03PS2) 10Umherirrender: Use tabs in json [extensions/GPGMail] - 10https://gerrit.wikimedia.org/r/344754 [10:16:38] (03PS1) 10Umherirrender: Use tabs in json [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/344762 [10:22:19] 10MediaWiki-extensions-AutoCreateCategoryPage: Change AutoCreateCategoryPages to not have to grab entire namespace - https://phabricator.wikimedia.org/T161387#3130447 (10FreedomFighterSparrow) Hmm, yes, that makes a *lot* of sense :-) I'll update the code soon. Thank you very much! [10:24:47] 10MediaWiki-extensions-AutoCreateCategoryPage: Change AutoCreateCategoryPages to not have to grab entire namespace - https://phabricator.wikimedia.org/T161387#3130631 (10Reception123) @FreedomFighterSparrow Thank you for helping! [10:48:15] 10MediaWiki-extensions-AutoCreateCategoryPage: Change AutoCreateCategoryPages to not have to grab entire namespace - https://phabricator.wikimedia.org/T161387#3130653 (10FreedomFighterSparrow) Sure, this is my responsiblity to maintain, after all. @labster, any particular form of credit? Currently it's just a l... [10:49:26] (03CR) 10Raimond Spekking: [C: 031] "i18 review" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/344355 (owner: 10Ljonka) [10:50:38] (03CR) 10HarriA: [C: 032] Use tabs in json [extensions/StlHandler] - 10https://gerrit.wikimedia.org/r/344758 (owner: 10Umherirrender) [10:52:05] (03CR) 10HarriA: [V: 032 C: 032] Use tabs in json [extensions/StlHandler] - 10https://gerrit.wikimedia.org/r/344758 (owner: 10Umherirrender) [10:58:16] 10Single-Image-Batch-Upload: User Interface for Single Image Batch Upload - https://phabricator.wikimedia.org/T161328#3130655 (10Kamsuri5) a:03Kamsuri5 [11:14:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 07Regression, 03Wikidata-Sprint: Wikidata does not accept characters ending in \x85 (Cyrillic х, Armenian Յ, Arabic م etc.) in labels/aliases/descriptions - https://phabricator.wikimedia.org/T161263#3130656 (10NickK) >>! In T16126... [11:20:46] (03PS1) 10Seb35: Fix bug about empty lists/objects in composer.json [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344766 [11:25:24] (03CR) 10Seb35: [C: 032] Fix bug about empty lists/objects in composer.json [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344766 (owner: 10Seb35) [11:30:32] (03Merged) 10jenkins-bot: Fix bug about empty lists/objects in composer.json [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344766 (owner: 10Seb35) [11:31:53] (03PS1) 10Umherirrender: Use tabs in json [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/344767 [11:32:08] (03PS1) 10Umherirrender: Use tabs in json [skins/Modern] - 10https://gerrit.wikimedia.org/r/344768 [11:32:17] (03PS1) 10Umherirrender: Use tabs in json [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/344769 [11:32:39] (03PS1) 10Umherirrender: Use tabs in json [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/344770 [11:33:23] (03PS1) 10Umherirrender: Use tabs in json [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/344771 [11:33:49] (03PS1) 10Umherirrender: Use tabs in json [extensions/NewUserActions] - 10https://gerrit.wikimedia.org/r/344772 [11:34:08] (03PS1) 10Umherirrender: Use tabs in json [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/344773 [11:34:22] (03CR) 10jerkins-bot: [V: 04-1] Use tabs in json [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/344771 (owner: 10Umherirrender) [11:34:41] nice, we have a load-balanced wikibugs :P [11:35:03] (03PS1) 10Umherirrender: Use tabs in json [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/344776 [11:35:19] (03PS1) 10Umherirrender: Use tabs in json [extensions/SwiftMailer] - 10https://gerrit.wikimedia.org/r/344777 [11:35:36] (03PS1) 10Umherirrender: Use tabs in json [extensions/WebPlatformAuth] - 10https://gerrit.wikimedia.org/r/344778 [11:35:53] (03PS1) 10Umherirrender: Use tabs in json [extensions/WindowsAzureSDK] - 10https://gerrit.wikimedia.org/r/344779 [11:37:27] (03CR) 10jerkins-bot: [V: 04-1] Use tabs in json [extensions/NewUserActions] - 10https://gerrit.wikimedia.org/r/344772 (owner: 10Umherirrender) [11:40:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Ladsgroup, 03Wikidata-Sprint: Refactor RdfBuilder to handle properties metadata properly - https://phabricator.wikimedia.org/T160382#3130662 (10thiemowmde) p:05Triage>03Normal [11:51:08] (03CR) 10Bartosz Dziewoński: "Looks like this would also resolve the problem solved by https://gerrit.wikimedia.org/r/#/c/284427/ ?" [core] - 10https://gerrit.wikimedia.org/r/344741 (owner: 10Krinkle) [11:55:28] (03CR) 10Bartosz Dziewoński: [C: 032] Use tabs in json [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/344769 (owner: 10Umherirrender) [11:55:30] (03CR) 10Bartosz Dziewoński: [C: 032] Use tabs in json [skins/Modern] - 10https://gerrit.wikimedia.org/r/344768 (owner: 10Umherirrender) [11:55:32] (03CR) 10Bartosz Dziewoński: [C: 032] Use tabs in json [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/344767 (owner: 10Umherirrender) [11:57:16] (03Merged) 10jenkins-bot: Use tabs in json [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/344769 (owner: 10Umherirrender) [11:57:29] (03Merged) 10jenkins-bot: Use tabs in json [skins/Modern] - 10https://gerrit.wikimedia.org/r/344768 (owner: 10Umherirrender) [11:57:39] (03Merged) 10jenkins-bot: Use tabs in json [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/344767 (owner: 10Umherirrender) [11:58:25] 10MobileFrontend, 07I18n, 07RTL: using an LTR wiki in an RTL language aligns infobox labels incorrectly - https://phabricator.wikimedia.org/T161399#3130699 (10Amire80) [12:00:17] (03CR) 10Seb35: [C: 032] Use tabs in json [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344755 (owner: 10Umherirrender) [12:02:30] 10MediaWiki-Special-pages, 10UI-Standardization, 06Front-end-Standards-Group, 07Epic: Convert Special:Preferences to OOUI - https://phabricator.wikimedia.org/T117781#3130712 (10matmarex) I haven't looked into this, but it will probably be a large endeavor. The preferences form is probably the biggest, fanc... [12:05:18] (03Merged) 10jenkins-bot: Use tabs in json [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344755 (owner: 10Umherirrender) [12:05:19] 10MediaWiki-Special-pages, 10UI-Standardization, 06Front-end-Standards-Group, 07Epic: Convert Special:Preferences to OOUI - https://phabricator.wikimedia.org/T117781#3130715 (10matmarex) (To change just the buttons, like T161288 asks for, you could instead comparably easily just customize it a bit further,... [12:08:17] (03PS1) 10Seb35: Fix bug when a mwcomposer was used but no Composer-managed extension is activated [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344781 [12:11:09] (03CR) 10jerkins-bot: [V: 04-1] Fix bug when a mwcomposer was used but no Composer-managed extension is activated [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344781 (owner: 10Seb35) [12:13:03] (03CR) 10Seb35: "recheck" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344781 (owner: 10Seb35) [12:16:20] (03CR) 10Seb35: [C: 032] Fix bug when a mwcomposer was used but no Composer-managed extension is activated [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344781 (owner: 10Seb35) [12:18:52] (03CR) 10jerkins-bot: [V: 04-1] Fix bug when a mwcomposer was used but no Composer-managed extension is activated [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344781 (owner: 10Seb35) [12:19:19] (03CR) 10Bartosz Dziewoński: [C: 032] "This now depends on I95400637d1b85d2c607cd91bcb39ce21733295c8 and is safe to merge as soon as that one is merged." [core] - 10https://gerrit.wikimedia.org/r/343249 (https://phabricator.wikimedia.org/T160953) (owner: 10Fomafix) [12:20:02] (03CR) 10Bartosz Dziewoński: [C: 032] "This depends on I95400637d1b85d2c607cd91bcb39ce21733295c8 and is safe to merge as soon as that one is merged." [core] - 10https://gerrit.wikimedia.org/r/344745 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [12:20:07] (03CR) 10Bartosz Dziewoński: [C: 032] "This depends on I95400637d1b85d2c607cd91bcb39ce21733295c8 and is safe to merge as soon as that one is merged." [core] - 10https://gerrit.wikimedia.org/r/344746 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [12:20:11] (03CR) 10Seb35: [V: 032 C: 032] Fix bug when a mwcomposer was used but no Composer-managed extension is activated [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344781 (owner: 10Seb35) [12:20:54] (03CR) 10Prtksxna: "After the major refactor that the reading team has undertaken I am not sure how much of this useful. Ricordisamoa, should we abandon this " [extensions/Popups] - 10https://gerrit.wikimedia.org/r/189167 (https://phabricator.wikimedia.org/T67114) (owner: 10Ricordisamoa) [12:22:32] (03CR) 10Bartosz Dziewoński: [C: 032] "This depends on I95400637d1b85d2c607cd91bcb39ce21733295c8 and is safe to merge as soon as that one is merged." [core] - 10https://gerrit.wikimedia.org/r/344744 (https://phabricator.wikimedia.org/T160953) (owner: 10Krinkle) [12:28:33] 07Design, 10Page-Previews, 13Patch-For-Review, 06Reading-Web-Backlog (Design): Hovercards: Show cards for references - https://phabricator.wikimedia.org/T67114#3130734 (10Prtksxna) [12:28:36] (03PS6) 10Bartosz Dziewoński: Remove support for jquery.placeholder shim [core] - 10https://gerrit.wikimedia.org/r/341845 (https://phabricator.wikimedia.org/T159911) (owner: 10Krinkle) [12:29:08] (03CR) 10Bartosz Dziewoński: "PS6: Manual rebase (trivial conflicts in Resources.php, mediawiki/page/ready.js)." [core] - 10https://gerrit.wikimedia.org/r/341845 (https://phabricator.wikimedia.org/T159911) (owner: 10Krinkle) [12:29:17] (03CR) 10Bartosz Dziewoński: [C: 032] "This depends on I95400637d1b85d2c607cd91bcb39ce21733295c8 and is safe to merge as soon as that one is merged." [core] - 10https://gerrit.wikimedia.org/r/341845 (https://phabricator.wikimedia.org/T159911) (owner: 10Krinkle) [12:40:59] (03CR) 10Bartosz Dziewoński: "If we're renaming it… shouldn't it be CategoryMultiselectWidget for consistency? We have a UsersMultiselectWidget, for example." [core] - 10https://gerrit.wikimedia.org/r/344588 (https://phabricator.wikimedia.org/T161285) (owner: 10Prtksxna) [12:43:22] (03CR) 10Bartosz Dziewoński: [C: 031] Linker: Render selflinks as href-less classed s, not s [core] - 10https://gerrit.wikimedia.org/r/343204 (https://phabricator.wikimedia.org/T160480) (owner: 10Jforrester) [12:43:57] (03CR) 10Pwirth: [C: 031] Use tabs in json [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/344752 (owner: 10Umherirrender) [12:46:09] (03CR) 10Pwirth: [C: 032] Review: Move Hooks to extension.json, add edit on review handling [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/344355 (owner: 10Ljonka) [12:47:09] (03Merged) 10jenkins-bot: Review: Move Hooks to extension.json, add edit on review handling [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/344355 (owner: 10Ljonka) [12:54:59] (03CR) 10Esanders: [C: 031] Linker: Render selflinks as href-less classed s, not s [core] - 10https://gerrit.wikimedia.org/r/343204 (https://phabricator.wikimedia.org/T160480) (owner: 10Jforrester) [12:55:23] 10MediaWiki-Debug-Logger, 10MediaWiki-Unit-tests: Error in all tests "ReflectionException: Property singletons does not exist" - https://phabricator.wikimedia.org/T161401#3130737 (10Seb35) [12:57:52] 10MediaWiki-Gallery: Adjustable widths for galleries in slideshow mode - https://phabricator.wikimedia.org/T154013#3130750 (10Aklapper) p:05Triage>03Low If you (or anyone) feel like providing a patch to add such functionality, you are very welcome to use [[ https://www.mediawiki.org/wiki/Developer_access | d... [12:58:46] (03PS3) 10Harjotsingh: Put Html code of Answer in Question.php into mustache template [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/344726 [12:59:48] 10Wikimedia-Site-requests, 07Community-consensus-needed: Change time zone in all sa.wiki* WMF projects - https://phabricator.wikimedia.org/T160496#3130752 (10Aklapper) @NehalDaveND: Please share and describe your other solution. Thanks. [13:03:56] (03CR) 10Harjotsingh: ">" (031 comment) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/344726 (owner: 10Harjotsingh) [13:04:21] (03CR) 10Harjotsingh: "Recheck" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/344726 (owner: 10Harjotsingh) [13:05:58] (03PS20) 10Paladox: Migrate usertext_timestamp to ar_usertext_timestamp on wiki's lower then 1.28 [core] - 10https://gerrit.wikimedia.org/r/344452 (https://phabricator.wikimedia.org/T104756) [13:06:03] (03CR) 10Hashar: [C: 032] "Thanks !" [core] - 10https://gerrit.wikimedia.org/r/341377 (owner: 10Hashar) [13:10:29] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I tried to rebase the tests I wrote in If985f33 on top of this, and indeed, this fixes the issue of valid SVG files being misreported as "" [core] - 10https://gerrit.wikimedia.org/r/344741 (owner: 10Krinkle) [13:18:19] (03Merged) 10jenkins-bot: build: karma now reports with mocha formatter [core] - 10https://gerrit.wikimedia.org/r/341377 (owner: 10Hashar) [13:21:36] (03PS1) 10Seb35: Restore 100% code coverage [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344784 [13:23:15] (03PS4) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [13:26:30] (03CR) 10Seb35: [C: 032] Restore 100% code coverage [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344784 (owner: 10Seb35) [13:29:27] (03Merged) 10jenkins-bot: Restore 100% code coverage [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344784 (owner: 10Seb35) [13:30:59] (03CR) 10jerkins-bot: [V: 04-1] Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [13:31:43] (03CR) 10Bartosz Dziewoński: [C: 031] resourceloader: Optimise getMimeType() for common case [core] - 10https://gerrit.wikimedia.org/r/344741 (owner: 10Krinkle) [13:31:53] 04(no projects): Throttle rule for BordeauxJS - https://phabricator.wikimedia.org/T161402#3130770 (10Dereckson) a:03Dereckson [13:32:10] (03CR) 10jenkins-bot: build: karma now reports with mocha formatter [core] - 10https://gerrit.wikimedia.org/r/341377 (owner: 10Hashar) [13:33:05] 04(no projects): Throttle rule for BordeauxJS - https://phabricator.wikimedia.org/T161402#3130774 (10Dereckson) p:05Triage>03Unbreak! [13:33:14] 10MediaWiki-Gallery: Adjustable widths for galleries in slideshow mode - https://phabricator.wikimedia.org/T154013#3130777 (10StarWarden) I am but a simple mediawiki user. If I were a developer, I would have already tried to work on that functionality, thus this is why I opened a task for it instead. [13:33:16] 10Wikimedia-Site-requests: Throttle rule for BordeauxJS - https://phabricator.wikimedia.org/T161402#3130778 (10Dereckson) [13:38:07] (03CR) 10Fomafix: "Minor typo." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/343204 (https://phabricator.wikimedia.org/T160480) (owner: 10Jforrester) [13:41:19] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Article Reminder - https://phabricator.wikimedia.org/T161364#3130790 (10Aklapper) [13:41:23] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Article Reminder - https://phabricator.wikimedia.org/T161364#3130792 (10Aklapper) Hi @Adedayomatt! Please see https://www.mediawiki.org/wiki/Outreach_programs/Life_of_a_s... [13:41:42] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Article Reminder - https://phabricator.wikimedia.org/T161364#3130793 (10Aklapper) a:03Adedayomatt [13:44:00] (03PS5) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [13:44:08] 10Wikimedia-Site-requests, 13Patch-For-Review: Throttle rule for BordeauxJS - https://phabricator.wikimedia.org/T161402#3130797 (10Dereckson) [13:44:15] 10Wikimedia-Site-requests, 13Patch-For-Review: Throttle rule for BordeauxJS - https://phabricator.wikimedia.org/T161402#3130770 (10Dereckson) 05Open>03Resolved [13:45:07] 10Wikimedia-Site-requests, 13Patch-For-Review: Throttle rule for BordeauxJS - https://phabricator.wikimedia.org/T161402#3130770 (10Dereckson) [13:47:42] (03PS6) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [13:52:02] 06Strategy-Coordinators: Watching, facilitating, and summarising Cycle 1 talk - https://phabricator.wikimedia.org/T161404#3130812 (10Base) [13:53:22] (03PS7) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [13:56:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'm sorry, I'm not entirely happy with this change. I feel bad making you work on it in your free time, so I will be amending it myself." [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [13:57:59] (03PS1) 10Fomafix: Use tabs instead of spaces for indenting [skins/Vector] - 10https://gerrit.wikimedia.org/r/344787 [13:58:01] (03CR) 10Paladox: "I see why this is failing now. It's using the wrong url. 0.0.0.0 instead of localhost." [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [13:58:42] 10UI-Standardization, 06Editing-Department, 13Patch-For-Review, 15User-Ladsgroup, 07User-notice: Convert EditPage.php to use OOUI rather than MW UI - https://phabricator.wikimedia.org/T111088#3130826 (10matmarex) Before we enable this on Wikimedia wikis, we should also update WMF-deployed extensions that... [13:59:25] 07Design, 10UI-Standardization, 10OOjs-UI: Implement a way to display tooltips (using PopupWidget) on hover/focus rather than on click - https://phabricator.wikimedia.org/T88630#3130828 (10matmarex) [14:00:25] (03PS8) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [14:01:38] (03PS28) 10Bartosz Dziewoński: Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [14:01:42] 10UI-Standardization, 06Editing-Department, 13Patch-For-Review, 15User-Ladsgroup, 07User-notice: Convert EditPage.php to use OOUI rather than MW UI - https://phabricator.wikimedia.org/T111088#3130829 (10Ladsgroup) I will take care of that. [14:01:44] (03PS29) 10Bartosz Dziewoński: Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [14:02:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(Mentioned co-authors in commit message, so that this isn't lost.)" [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [14:03:27] (03CR) 10Paladox: "Seems it is even broken with 1.1.1 release." [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [14:04:35] (03CR) 10Ladsgroup: "The unrelated stuff are rebase errors. They are (probably) already in master. Thanks for wokring on this." [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [14:05:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(Looks like the contentModel stuff was a merge conflict problem, it disappeared after rebasing – the changes were actually part of 49aa4cf" [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [14:09:08] (03CR) 10jerkins-bot: [V: 04-1] Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [14:09:17] (03PS6) 10Mholloway: Overhaul WikiErrorView and use only predefined error messages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343942 (https://phabricator.wikimedia.org/T157361) [14:09:19] (03PS6) 10Mholloway: Update EditSectionActivity to use the standard WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343943 (https://phabricator.wikimedia.org/T154805) [14:09:21] (03PS6) 10Mholloway: Update LoginActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343944 (https://phabricator.wikimedia.org/T157361) [14:09:23] (03PS6) 10Mholloway: Update CreateAccountActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343945 (https://phabricator.wikimedia.org/T157361) [14:09:25] (03PS6) 10Mholloway: Update GalleryActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343946 (https://phabricator.wikimedia.org/T157361) [14:09:27] (03PS4) 10Mholloway: Update resources to accommodate the page offline screen design [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344156 (https://phabricator.wikimedia.org/T157361) [14:09:29] (03PS4) 10Mholloway: Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) [14:09:31] (03PS4) 10Mholloway: Disable page action tabs (except add to reading list) when offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344403 (https://phabricator.wikimedia.org/T157361) [14:09:33] (03PS2) 10Mholloway: Update: Handle missing pages correctly in the full page view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344721 (https://phabricator.wikimedia.org/T157361) [14:31:21] (03CR) 10jerkins-bot: [V: 04-1] Update resources to accommodate the page offline screen design [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344156 (https://phabricator.wikimedia.org/T157361) (owner: 10Mholloway) [14:33:28] (03CR) 10jerkins-bot: [V: 04-1] Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) (owner: 10Mholloway) [14:39:08] (03PS9) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [14:43:59] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#3130843 (10thiemowmde) [14:44:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Introduce a setting for entity types supported by Special:EntitiesWithoutLabel/ Special:EntitiesWithoutDescription - https://phabricator.wikimedia.org/T147638#3130840 (10thiemowmde) 05Open>03Resolved I believe this was resolved with https://gerrit.wiki... [14:44:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, 03Wikidata-Sprint: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service - https://phabricator.wikimedia.org/T140891#3130842 (10thiemowmde) [14:44:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Introduce a setting for entity types supported by Special:EntitiesWithoutLabel/ Special:EntitiesWithoutDescription - https://phabricator.wikimedia.org/T147638#3130845 (10thiemowmde) [14:45:47] (03PS5) 10Mholloway: Update resources to accommodate the page offline screen design [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344156 (https://phabricator.wikimedia.org/T157361) [14:45:47] (03PS5) 10Mholloway: Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) [14:45:49] (03PS5) 10Mholloway: Disable page action tabs (except add to reading list) when offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344403 (https://phabricator.wikimedia.org/T157361) [14:45:51] (03PS3) 10Mholloway: Update: Handle missing pages correctly in the full page view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344721 (https://phabricator.wikimedia.org/T157361) [14:46:51] (03CR) 10jerkins-bot: [V: 04-1] Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [14:49:26] (03PS10) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [14:53:17] (03CR) 10jerkins-bot: [V: 04-1] Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) (owner: 10Mholloway) [14:53:59] (03PS11) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [14:57:52] (03PS12) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [15:03:55] (03PS13) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [15:05:43] (03PS6) 10Mholloway: Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) [15:05:45] (03PS6) 10Mholloway: Disable page action tabs (except add to reading list) when offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344403 (https://phabricator.wikimedia.org/T157361) [15:05:47] (03PS4) 10Mholloway: Update: Handle missing pages correctly in the full page view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344721 (https://phabricator.wikimedia.org/T157361) [15:09:02] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, and 2 others: Article Reminder - https://phabricator.wikimedia.org/T161364#3130858 (10Adedayomatt) [15:10:01] (03CR) 10Thiemo Mättig (WMDE): [WIP] startup: Drop JavaScript support for ES3-only browsers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/340893 (https://phabricator.wikimedia.org/T128115) (owner: 10Jforrester) [15:11:20] (03CR) 10Bartosz Dziewoński: [C: 032] Use tabs instead of spaces for indenting [skins/Vector] - 10https://gerrit.wikimedia.org/r/344787 (owner: 10Fomafix) [15:13:26] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, and 2 others: Article Reminder - https://phabricator.wikimedia.org/T161364#3130873 (10Adedayomatt) >>! In T161364#3130792, @Aklapper wrote: > Hi @Adedayomatt! > Please see https://www.mediawiki.org/wiki... [15:13:46] (03CR) 10jerkins-bot: [V: 04-1] Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [15:14:52] (03PS14) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [15:14:54] (03Merged) 10jenkins-bot: Use tabs instead of spaces for indenting [skins/Vector] - 10https://gerrit.wikimedia.org/r/344787 (owner: 10Fomafix) [15:15:55] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I checked all callers I have in my local dev environment and can confirm the parameter is not used. I believe I can also confirm the remov" [core] - 10https://gerrit.wikimedia.org/r/344737 (owner: 10Krinkle) [15:22:07] !class Skin [15:22:07] See https://doc.wikimedia.org/mediawiki-core/master/php/classSkin.html [15:22:58] (03CR) 10jerkins-bot: [V: 04-1] Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [15:24:47] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [15:33:48] (03PS15) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [15:34:45] 10wikimaps-warper: Wikmaps Warper - Migrate / Upgrade maps-warper from Precise to Trusty - https://phabricator.wikimedia.org/T159846#3130877 (10Chippyy) 05Open>03Resolved maps-warper has been deleted now. [15:37:12] Isarra: I created the required config change, but I don't know *how* to add a *skin* to labs, process is only documented for *extensions* [15:37:52] For example, the first step is to ensure weekly wmf branches are created for your skin [15:39:09] (03PS16) 10Paladox: Update karma to 1.5.0 [core] - 10https://gerrit.wikimedia.org/r/343719 [15:39:30] Isarra: but surprise, https://phabricator.wikimedia.org/diffusion/MREL/browse/master/make-wmf-branch/config.json contains only extensions, not skins [15:39:58] hmmmmmmm er .... my *local copy* from 2 years ago of this repo didn't contain skin [15:40:13] apparently now it list them too [15:40:17] problem solved so [15:47:37] (03PS17) 10Paladox: Update karma to 1.5.0, Update karma-firefox-launcher to 1.0.1 [core] - 10https://gerrit.wikimedia.org/r/343719 [16:01:49] (03CR) 10Zppix: "Recheck" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/344726 (owner: 10Harjotsingh) [16:02:46] (03PS9) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [16:02:57] (03CR) 10Paladox: [C: 032] Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 (owner: 10Paladox) [16:03:33] (03PS1) 10Gerrit Patch Uploader: Remove broken plaintext section markers [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/344791 (https://phabricator.wikimedia.org/T92628) [16:03:35] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/344791 (https://phabricator.wikimedia.org/T92628) (owner: 10Gerrit Patch Uploader) [16:04:02] (03Merged) 10jenkins-bot: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 (owner: 10Paladox) [16:04:17] (03CR) 10Artoria2e5: [C: 04-1] "Hmm, what is this..." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/344791 (https://phabricator.wikimedia.org/T92628) (owner: 10Gerrit Patch Uploader) [16:04:29] (03PS11) 10Gerrit Patch Uploader: Remove broken plaintext section markers [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/343216 (https://phabricator.wikimedia.org/T92628) [16:04:31] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/343216 (https://phabricator.wikimedia.org/T92628) (owner: 10Gerrit Patch Uploader) [16:04:55] Dereckson: Hah, thanks. [16:07:03] So you just add a thing to the lest and it magically makes the branches? [16:07:23] (03Draft1) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [16:07:26] (03PS2) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [16:07:38] Isarra: seems os [16:07:40] so [16:07:48] (03PS3) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [16:07:49] well, we also need to run make wmf branch [16:08:10] I'll check the detail in one or two hours, must go [16:08:14] Right. [16:08:16] Thanks! [16:10:05] (03CR) 10jerkins-bot: [V: 04-1] Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [16:10:15] (03PS4) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [16:22:26] 10MediaWiki-extensions-MultimediaViewer: MMV lacks support for HiDPI displays - https://phabricator.wikimedia.org/T161346#3130907 (10Isarra) HiDPI means higher pixel density, which means more pixels, which means you need larger (higher-resolution) versions of the image. These need to be offered alongside the r... [16:28:22] 10MediaWiki-extensions-MultimediaViewer: Black background has horrible contrast with light checkered background applied to transparent images - https://phabricator.wikimedia.org/T161347#3130908 (10Isarra) I recommend seeing what else oojs does for selections in various widgets and using one of those. If nothing... [16:31:59] (03PS30) 10Bartosz Dziewoński: Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [16:32:01] (03PS1) 10Bartosz Dziewoński: EditPage: Minor code style improvements [core] - 10https://gerrit.wikimedia.org/r/344793 [16:32:43] 10MediaWiki-extensions-MultimediaViewer: Black background has horrible contrast with light checkered background applied to transparent images - https://phabricator.wikimedia.org/T161347#3130909 (10Isarra) Wait, crap, mmv isn't actually using oojs, is it? Eh, just set the general background to something like #44... [16:32:43] (03CR) 10Bartosz Dziewoński: "PS30 removes unrelated changes (I split out some to https://gerrit.wikimedia.org/r/344793), fixes various minor bugs (some missing or dupl" [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [16:33:18] (03CR) 10Bartosz Dziewoński: "(Still working on the checkbox hook stuff. In the meantime, I found that this patch somehow breaks VisualEditor's handling of those checkb" [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [16:40:58] (03CR) 10Bartosz Dziewoński: EditPage: Minor code style improvements (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344793 (owner: 10Bartosz Dziewoński) [16:44:33] 10Wiki-Loves-Monuments (2017): Prepare a list of reimbursments for WMIT - https://phabricator.wikimedia.org/T161407#3130910 (10LilyOfTheWest) [16:44:45] 10Wiki-Loves-Monuments (2017): Prepare a list of reimbursments for WMIT - https://phabricator.wikimedia.org/T161407#3130910 (10LilyOfTheWest) p:05Triage>03High [16:50:15] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3130945 (10Isarra) [16:51:16] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3130945 (10Zppix) Wouldn't that use up uneeded precious server storage space? [16:51:49] (03PS5) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [16:53:27] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3130964 (10LilyOfTheWest) [16:53:35] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3130978 (10LilyOfTheWest) p:05Triage>03Normal [16:55:39] (03CR) 10Paladox: [C: 032] Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [16:56:19] (03CR) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [16:57:43] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3130982 (10Isarra) >>! In T161409#3130957, @Zppix wrote: > Wouldn't that use up uneeded precious server storage space? No. [16:58:29] (03PS6) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [16:59:05] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3130983 (10Zppix) Maybe we should instead of making constant compatibility changes, we think about incorporating this into core? [16:59:25] 10Wiki-Loves-Monuments (2017): Write article for Europa Nostra magazine on WLM 2017 - https://phabricator.wikimedia.org/T160065#3130984 (10LilyOfTheWest) Here is the angle I'm thinking that we focus on (also brought up by effeietsanders earlier): We put the focus of the piece on the fact that we're collecting t... [17:00:35] (03CR) 10jerkins-bot: [V: 04-1] Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [17:02:12] (03PS7) 10Paladox: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) [17:04:39] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: Consider redesigning the integration of VisualEditor to keep the page title/subtitle above the toolbar - https://phabricator.wikimedia.org/T159913#3130985 (10Isarra) Esanders noted that the title is currently greyed out to indicate it isn't editab... [17:05:11] (03CR) 10Paladox: [C: 032] Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [17:06:07] (03CR) 10Kelson: [V: 032 C: 032] Modify access rules [openzim] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/344685 (owner: 10Paladox) [17:06:09] (03Merged) 10jenkins-bot: Add a scroll offset when a table of contents anchor link is clicked [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344792 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [17:07:33] (03CR) 10Paladox: "thanks." [openzim] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/344685 (owner: 10Paladox) [17:09:35] (03CR) 10Mglaser: [C: 032] Use tabs in json [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/344752 (owner: 10Umherirrender) [17:11:22] (03CR) 10Mglaser: [C: 031] BSSmartList: Fixed I18N; Added tag aliases [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/344590 (owner: 10Robert Vogel) [17:11:45] (03Merged) 10jenkins-bot: Use tabs in json [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/344752 (owner: 10Umherirrender) [17:12:28] 10Android-app-Bugs, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Link preview offline error message is shown for missing pages that return a 404 HTTP status - https://phabricator.wikimedia.org/T161008#3130988 (10Mholloway) Do we want to disable navigating to the article from the link preview... [17:13:52] (03PS1) 10Paladox: Modify access rules [openzim] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/344794 [17:15:07] (03CR) 10Kelson: [V: 032 C: 032] Modify access rules [openzim] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/344794 (owner: 10Paladox) [17:15:17] (03CR) 10Paladox: "Thanks." [openzim] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/344794 (owner: 10Paladox) [17:19:33] (03PS2) 10Fomafix: Remove attribute lang from #firstHeading [skins/Vector] - 10https://gerrit.wikimedia.org/r/318043 [17:20:35] (03CR) 10Fomafix: "Rebased after merge conflict." [skins/Vector] - 10https://gerrit.wikimedia.org/r/318043 (owner: 10Fomafix) [17:22:07] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3130997 (10Isarra) >>! In T161409#3130983, @Zppix wrote: > Maybe we should instead of making constant compatibility changes, we think about incorporating MMV into core? Are you planning... [17:24:48] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3131000 (10Zppix) @isarra I'd be willing to help, but I'm not able to do it all myself. However I think we will need to see if we need to hold an RfC or archcom meeting or something befor... [17:32:40] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3131002 (10Isarra) Then go do that. [17:52:02] (03PS4) 10Mholloway: Show an accurate message in the link preview when a page doesn't exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344687 (https://phabricator.wikimedia.org/T161008) [17:52:04] (03PS7) 10Mholloway: Overhaul WikiErrorView and use only predefined error messages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343942 (https://phabricator.wikimedia.org/T157361) [17:52:06] (03PS7) 10Mholloway: Update EditSectionActivity to use the standard WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343943 (https://phabricator.wikimedia.org/T154805) [17:52:08] (03PS7) 10Mholloway: Update LoginActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343944 (https://phabricator.wikimedia.org/T157361) [17:52:10] (03PS7) 10Mholloway: Update CreateAccountActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343945 (https://phabricator.wikimedia.org/T157361) [17:52:12] (03PS7) 10Mholloway: Update GalleryActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343946 (https://phabricator.wikimedia.org/T157361) [17:52:14] (03PS6) 10Mholloway: Update resources to accommodate the page offline screen design [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344156 (https://phabricator.wikimedia.org/T157361) [17:52:16] (03PS7) 10Mholloway: Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) [17:52:18] (03PS7) 10Mholloway: Disable page action tabs (except add to reading list) when offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344403 (https://phabricator.wikimedia.org/T157361) [17:52:20] (03PS5) 10Mholloway: Update: Handle missing pages correctly in the full page view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344721 (https://phabricator.wikimedia.org/T157361) [17:55:10] (03Draft1) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 [17:55:12] (03Draft2) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 [18:04:58] (03CR) 10Umherirrender: [V: 032 C: 032] "No code in this repo" [extensions/NewUserActions] - 10https://gerrit.wikimedia.org/r/344772 (owner: 10Umherirrender) [18:22:27] 10MediaWiki-extensions-MediaWikiFarm: Differentiate wikis per-path in addition of per-domain - https://phabricator.wikimedia.org/T161413#3131037 (10Seb35) [18:23:11] 10MediaWiki-extensions-MediaWikiFarm: Differentiate wikis per-path in addition of per-domain - https://phabricator.wikimedia.org/T161413#3131050 (10Seb35) p:05Triage>03Normal [18:24:12] 10MediaWiki-extensions-MediaWikiFarm: Differentiate wikis per-path in addition of per-domain - https://phabricator.wikimedia.org/T161413#3131037 (10Zppix) Why fix something thats not broken? [18:27:05] (03PS2) 10Umherirrender: Use tabs in json [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/344771 [18:30:27] (03CR) 10Mholloway: "rfr" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343942 (https://phabricator.wikimedia.org/T157361) (owner: 10Mholloway) [18:37:17] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Prevent saving nonexistent pages to a reading list - https://phabricator.wikimedia.org/T161415#3131069 (10Mholloway) [18:38:07] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Prevent saving nonexistent pages to a reading list - https://phabricator.wikimedia.org/T161415#3131085 (10Mholloway) [18:43:19] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Prevent saving nonexistent pages to a reading list - https://phabricator.wikimedia.org/T161415#3131087 (10Mholloway) [18:43:23] 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog, 13Patch-For-Review: Red links displayed as regular links when Restbase enabled. - https://phabricator.wikimedia.org/T119266#3131086 (10Mholloway) [18:45:49] (03PS2) 10Isarra: Refactor TimelessTemplate.php [skins/Timeless] - 10https://gerrit.wikimedia.org/r/344748 [18:46:08] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3131091 (10LilyOfTheWest) A first version is ready at https://docs.google.com/presentation/d/1KfptI0-M9Ndj5lOEp7-LLu8mvR9UPIquENoJV0MKKy8/edit#slide=id.g1d4316b793_0_159... [18:47:08] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3130964 (10LilyOfTheWest) @Yarl While I'm fine-tuning this presentation: do we have a good place in the Commons page to start collecting all the presentations we will hav... [18:47:33] (03CR) 10jerkins-bot: [V: 04-1] Refactor TimelessTemplate.php [skins/Timeless] - 10https://gerrit.wikimedia.org/r/344748 (owner: 10Isarra) [18:50:45] Reedy: question would wanting to incorperate mmv into mwcore require rfc or archcom (see T161409) [18:50:46] T161409: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409 [18:52:51] (03PS3) 10Isarra: Refactor TimelessTemplate.php [skins/Timeless] - 10https://gerrit.wikimedia.org/r/344748 [19:00:05] (03CR) 10Fomafix: [C: 031] EditPage: Minor code style improvements [core] - 10https://gerrit.wikimedia.org/r/344793 (owner: 10Bartosz Dziewoński) [19:09:42] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3131098 (10LilyOfTheWest) @Effeietsanders can you go over the slides real quick and see if I should add any attribution to make it Commons-compatible? I want to upload th... [19:10:40] 10Phabricator: "Security" field is invisible, but still exists, and the value can't be changed, causing Herald problems - https://phabricator.wikimedia.org/T153742#3131101 (10matmarex) Another problem caused by this: the incorrect #security project can't be removed from T161403 after someone vandalized it by cli... [19:22:09] 07Wikimedia-log-errors: Undefined index: 1.5x in ResourceLoaderSkinModule on ff.wikipedia - https://phabricator.wikimedia.org/T161416#3131105 (10Dereckson) [19:23:35] 07Wikimedia-log-errors: Undefined index: 1.5x in ResourceLoaderSkinModule on ff.wikipedia - https://phabricator.wikimedia.org/T161416#3131119 (10Dereckson) This is caused by a typo in the configuration: ` 'ffwiki' => [ '2.5x' => '/static/images/project-logos/ffwiki-1.5x.png', '2x' => '/static/images/project-... [19:24:53] 07Wikimedia-log-errors: Undefined index: 1.5x in ResourceLoaderSkinModule on ff.wikipedia - https://phabricator.wikimedia.org/T161416#3131120 (10Dereckson) a:03Dereckson Introduced in rOMWC7339e6e62aec4496cd81a303c6b9acc51ee6f6f2 to solve T150618 [19:29:15] 13Patch-For-Review, 07Wikimedia-log-errors: Undefined index: 1.5x in ResourceLoaderSkinModule on ff.wikipedia - https://phabricator.wikimedia.org/T161416#3131130 (10Dereckson) I'm going to prepare too a unit test to detect further occurrences of this issue. [19:32:57] (03CR) 10Seb35: "Thanks for the tip!" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344610 (owner: 10Seb35) [19:35:28] 10Wiki-Loves-Monuments (2017): Proposal(s) for Wikimania 2017 - https://phabricator.wikimedia.org/T157910#3131131 (10LilyOfTheWest) Thanks for kicking this off, effeietsanders. Below are some comments/questions. To be clear: I don't have a fixed proposal in my mind atm, trying to brainstorm here to find the best... [19:36:20] 10Phabricator: "Security" field is invisible, but still exists, and the value can't be changed, causing Herald problems - https://phabricator.wikimedia.org/T153742#3131133 (10Aklapper) Yeah. I'm also puzzled by what Matmarex reported. :-( [19:37:52] 10MediaWiki-extensions-Linter, 10Wikimedia-Extension-setup, 13Patch-For-Review, 07User-notice: Review and deploy Linter extension to Wikimedia wikis - https://phabricator.wikimedia.org/T148609#3131135 (10Legoktm) We're mostly blocked on T160573, I'm still investigating that. [19:41:07] 10MediaWiki-extensions-AutoCreateCategoryPage: Change AutoCreateCategoryPages to not have to grab entire namespace - https://phabricator.wikimedia.org/T161387#3131137 (10labster) That credit works for me. I guess on thinking about it a little further, at this stage of the parse, shouldn't all of the category... [19:41:29] 10Phabricator: "Security" field is invisible, but still exists, and the value can't be changed, causing Herald problems - https://phabricator.wikimedia.org/T153742#2889322 (10Luke081515) H141 is blocking that. On the other hand, we may have Security tasks without #security, so we can: * a) Disable H141, and have... [19:42:55] (03PS1) 10Seb35: Exclude .git in phpcs.xml instead of command line argument [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344797 [19:46:28] (03CR) 10Seb35: [C: 032] Exclude .git in phpcs.xml instead of command line argument [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344797 (owner: 10Seb35) [19:47:17] (03CR) 10Seb35: "Improved in I6d8e2a4242f0." [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344610 (owner: 10Seb35) [19:51:23] (03Merged) 10jenkins-bot: Exclude .git in phpcs.xml instead of command line argument [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/344797 (owner: 10Seb35) [20:02:53] 10MediaWiki-extensions-Scribunto, 07Wikimedia-log-errors: Unknown exception from Thomas Mann page on rowiki - https://phabricator.wikimedia.org/T161361#3131141 (10Aklapper) [20:03:32] 10MediaWiki-ResourceLoader, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined index: 1.5x in ResourceLoaderSkinModule on ff.wikipedia - https://phabricator.wikimedia.org/T161416#3131143 (10Aklapper) [20:03:43] 10MediaWiki-ResourceLoader, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined index: 1.5x in ResourceLoaderSkinModule on ff.wikipedia - https://phabricator.wikimedia.org/T161416#3131156 (10Urbanecm) Thank you @Dereckson.. You may ignore my question in gerrit then. [20:08:23] (03PS7) 10Eranroz: Fix directionality of TiteOptionWidget [core] - 10https://gerrit.wikimedia.org/r/292041 (https://phabricator.wikimedia.org/T136641) [20:09:11] (03PS3) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 [20:09:54] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3131170 (10Aklapper) We're neither running out of disk space nor are there reasons to move such extensions into core. > For compatibility with older browsers. Do we have any data which... [20:11:28] (03CR) 10jerkins-bot: [V: 04-1] Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (owner: 10Paladox) [20:11:55] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, and 2 others: Article Reminder - https://phabricator.wikimedia.org/T161364#3131171 (10Aklapper) Advice is the link that I posted. :) If anything is unclear on that page about the procedure and proposal/a... [20:12:13] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3131172 (10Aklapper) [20:31:28] (03CR) 10Anomie: "I've had I526fd4e0 going for a while to remove all that mess, but Lego said we need to deprecate it first since it snuck into 1.28." [core] - 10https://gerrit.wikimedia.org/r/344737 (owner: 10Krinkle) [20:33:12] (03CR) 10Eranroz: "I don't think the change is disputed (please fix me if I'm wrong), but it looks like some other change introduced meanwhile already fix th" [core] - 10https://gerrit.wikimedia.org/r/292041 (https://phabricator.wikimedia.org/T136641) (owner: 10Eranroz) [20:33:40] (03CR) 10Krinkle: [C: 04-1] Update karma to 1.5.0, Update karma-firefox-launcher to 1.0.1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [20:34:18] (03CR) 10Krinkle: [C: 04-1] "If it uses the wrong url, most likely the env variables you have for Karma are not correctly correctly, or the proxy is misconfigured in G" [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [20:35:54] (03CR) 10Krinkle: "@Thiemo: Thanks, sounds good to me!" [core] - 10https://gerrit.wikimedia.org/r/344741 (owner: 10Krinkle) [20:41:01] (03CR) 10Krinkle: [WIP] startup: Drop JavaScript support for ES3-only browsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/340893 (https://phabricator.wikimedia.org/T128115) (owner: 10Jforrester) [20:43:02] (03Abandoned) 10Krinkle: WikiPage: Remove unused doPurge flags [core] - 10https://gerrit.wikimedia.org/r/344737 (owner: 10Krinkle) [20:44:22] (03CR) 10Krinkle: Deprecate "Avoid page_touched update for HTTP GET action=purge requests" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/335455 (https://phabricator.wikimedia.org/T145649) (owner: 10Anomie) [20:52:39] (03CR) 10Paladox: Update karma to 1.5.0, Update karma-firefox-launcher to 1.0.1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [20:53:05] (03CR) 10Paladox: "> If it uses the wrong url, most likely the env variables you have" [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [20:56:22] (03CR) 10Krinkle: [C: 04-1] "@Paladox: No, karma 1.1 *allows* cross origin, it does not *use* cross origin." [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [20:57:43] (03CR) 10Paladox: "@Krinkles see https://github.com/karma-runner/karma/pull/2318/files and https://github.com/karma-runner/karma/commit/5690ffe82bb7ff195576f" [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [20:58:30] (03CR) 10Paladox: "the tests fail when the config is enabled but pass when we set the config to false." [core] - 10https://gerrit.wikimedia.org/r/343719 (owner: 10Paladox) [21:00:57] (03PS8) 10Jforrester: TitleOptionWidget: Fix directionality [core] - 10https://gerrit.wikimedia.org/r/292041 (https://phabricator.wikimedia.org/T136641) (owner: 10Eranroz) [21:04:04] 10Wiki-Loves-Monuments (2017): Find a UX Designer for the international team - https://phabricator.wikimedia.org/T160861#3131223 (10Yarl) Great, @LilyOfTheWest ping me regarding call/hangout. [21:06:48] (03PS7) 10Jforrester: startup: Drop JavaScript support for ES3-only browsers [core] - 10https://gerrit.wikimedia.org/r/340893 (https://phabricator.wikimedia.org/T128115) [21:07:39] (03CR) 10Jforrester: [C: 04-2] startup: Drop JavaScript support for ES3-only browsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/340893 (https://phabricator.wikimedia.org/T128115) (owner: 10Jforrester) [21:08:41] (03PS1) 10Isarra: Add some common functions to BaseTemplate [core] - 10https://gerrit.wikimedia.org/r/344804 [21:10:49] (03CR) 10Jforrester: [C: 031] resourceloader: Optimise getMimeType() for common case [core] - 10https://gerrit.wikimedia.org/r/344741 (owner: 10Krinkle) [21:12:07] (03PS2) 10Isarra: Add some common functions to BaseTemplate [core] - 10https://gerrit.wikimedia.org/r/344804 [21:19:51] 10MediaWiki-extensions-Linter, 10Wikimedia-Extension-setup, 13Patch-For-Review, 07User-notice: Review and deploy Linter extension to Wikimedia wikis - https://phabricator.wikimedia.org/T148609#3131226 (10Jdforrester-WMF) Oh, right. I thought that was "just" the vagaries of ChangeProp/whatever and wasn't go... [21:20:30] 10MediaWiki-extensions-Linter, 10ChangeProp: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors - https://phabricator.wikimedia.org/T160573#3131228 (10Jdforrester-WMF) [21:20:32] 10MediaWiki-extensions-Linter, 10Wikimedia-Extension-setup, 13Patch-For-Review, 07User-notice: Review and deploy Linter extension to Wikimedia wikis - https://phabricator.wikimedia.org/T148609#3131227 (10Jdforrester-WMF) [21:24:46] (03CR) 10Jforrester: Linker: Render selflinks as href-less classed s, not s (031 comment) [core] - 10https://gerrit.wikimedia.org/r/343204 (https://phabricator.wikimedia.org/T160480) (owner: 10Jforrester) [21:28:22] (03PS31) 10Bartosz Dziewoński: Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [21:28:24] (03PS1) 10Bartosz Dziewoński: EditPage: Refactor getCheckboxes() to allow changing the format [core] - 10https://gerrit.wikimedia.org/r/344805 [21:32:10] (03PS8) 10Mholloway: Update EditSectionActivity to use the standard WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343943 (https://phabricator.wikimedia.org/T154805) [21:32:12] (03PS8) 10Mholloway: Update LoginActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343944 (https://phabricator.wikimedia.org/T157361) [21:32:14] (03PS8) 10Mholloway: Update CreateAccountActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343945 (https://phabricator.wikimedia.org/T157361) [21:32:16] (03PS8) 10Mholloway: Update GalleryActivity to use WikiErrorView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/343946 (https://phabricator.wikimedia.org/T157361) [21:32:18] (03PS7) 10Mholloway: Update resources to accommodate the page offline screen design [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344156 (https://phabricator.wikimedia.org/T157361) [21:32:20] (03PS8) 10Mholloway: Update WikiErrorView for PageActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344269 (https://phabricator.wikimedia.org/T157361) [21:32:22] (03PS8) 10Mholloway: Disable page action tabs (except add to reading list) when offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344403 (https://phabricator.wikimedia.org/T157361) [21:32:24] (03PS6) 10Mholloway: Update: Handle missing pages correctly in the full page view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/344721 (https://phabricator.wikimedia.org/T157361) [21:32:39] (03CR) 10Jforrester: "Nice. Very much what we were talking about within the realm of T157658." [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [21:32:51] (03PS3) 10Isarra: Add some common functions to BaseTemplate [core] - 10https://gerrit.wikimedia.org/r/344804 [21:37:43] (03CR) 10jerkins-bot: [V: 04-1] Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [21:37:53] (03CR) 10jerkins-bot: [V: 04-1] EditPage: Refactor getCheckboxes() to allow changing the format [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [21:38:08] (03CR) 10Jforrester: EditPage: Refactor getCheckboxes() to allow changing the format (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [21:38:48] 10MediaWiki-extensions-MultimediaViewer: MMV lacks support for HiDPI displays - https://phabricator.wikimedia.org/T161346#3131239 (10Tgr) I know what HiDPI means (and if I did not, I could Google it), I am just not sure what specific features you are missing. `srcset` does not make sense for script-generated ima... [21:41:13] 10MediaWiki-extensions-MultimediaViewer: MMV: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161409#3131241 (10Tgr) [21:41:15] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Browser-Support-Internet-Explorer: SVG icons in MediaViewer should have a fallback - https://phabricator.wikimedia.org/T72933#3131244 (10Tgr) [21:44:53] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Browser-Support-Internet-Explorer: SVG icons in MediaViewer should have a fallback - https://phabricator.wikimedia.org/T72933#3131245 (10Tgr) 05Open>03declined Declining per T72932. [21:44:54] 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: MediaViewer does not support IE8 - https://phabricator.wikimedia.org/T72932#756828 (10Tgr) [21:45:13] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Browser-Support-Internet-Explorer: SVG icons in MediaViewer should have a fallback - https://phabricator.wikimedia.org/T72933#3131255 (10Tgr) [21:45:17] 07Design, 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: MediaViewer's SVG icons cannot be automatically transformed to PNG - https://phabricator.wikimedia.org/T72654#3131251 (10Tgr) 05Open>03declined Declining per T72932. [21:45:29] (03CR) 10jerkins-bot: [V: 04-1] Add some common functions to BaseTemplate [core] - 10https://gerrit.wikimedia.org/r/344804 (owner: 10Isarra) [21:45:47] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3131256 (10Effeietsanders) @LilyOfTheWest attributions look good, except slide 11 (and the logos & map). I'd add a slide at the end with those attributions. [21:48:18] (03PS4) 10Isarra: Add some common functions to BaseTemplate [core] - 10https://gerrit.wikimedia.org/r/344804 [21:49:13] 10Wiki-Loves-Monuments (2017): Find a UX Designer for the international team - https://phabricator.wikimedia.org/T160861#3131257 (10LilyOfTheWest) sure @Yarl. For now I sent some more information about Montage, Monumental, and other aspects of the projects we have: landing pages, blog posts, etc. and asked her t... [21:54:12] (03CR) 10Isarra: "Really we should just add a general beforeFooter hook. Hook into BaseTemplate::getFooter, add it to the beginning of that..." [skins/Vector] - 10https://gerrit.wikimedia.org/r/330935 (owner: 10Jack Phoenix) [21:54:21] 10Wiki-Loves-Monuments (2017): Proposal(s) for Wikimania 2017 - https://phabricator.wikimedia.org/T157910#3131258 (10Effeietsanders) I think there are two types of questions: those that are helpful for anyone, and those very specific to a country/situation. For the latter, I would be a fan of arranging conversat... [21:55:55] 10Wiki-Loves-Monuments (2017): Create a 5-10 min presentation about WLM for Art+Feminism Editathon - https://phabricator.wikimedia.org/T161410#3131259 (10Effeietsanders) (ps: WLM logo no attribution obligated, it has been released into the public domain. If you want, you can though: Lusitana) [21:57:56] 10MediaWiki-extensions-MultimediaViewer: Black background has horrible contrast with light checkered background applied to transparent images - https://phabricator.wikimedia.org/T161347#3131261 (10Tgr) MMV is using OOJS but you probably meant OOUI, and it's not using that (for the canvas, at least) because it's... [21:59:09] 10Wiki-Loves-Monuments (2017): Write article for Europa Nostra magazine on WLM 2017 - https://phabricator.wikimedia.org/T160065#3131263 (10Effeietsanders) If I read that angle from the perspective of a heritage expert, I would be curious to explore this set of monument data - will we be far enough to publish a l... [22:01:12] 10Wiki-Loves-Monuments (2017): Create WMCON Berlin slides for WLM - https://phabricator.wikimedia.org/T160455#3099185 (10Effeietsanders) For inspiration/slide re-use, there's a bunch of presentations available here: https://commons.wikimedia.org/wiki/Category:Wiki_Loves_Monuments_presentations [22:06:44] (03PS1) 10Paladox: Revert "Simplify definition of 'ext.echo.badgeicons' module" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344806 [22:07:03] (03PS2) 10Paladox: Revert "Simplify definition of 'ext.echo.badgeicons' module" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344806 [22:07:51] (03Abandoned) 10Paladox: Revert "Simplify definition of 'ext.echo.badgeicons' module" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344806 (owner: 10Paladox) [22:11:12] (03CR) 10Bartosz Dziewoński: "PS31 does checkboxes in a way I'm mostly happy with. Also, it adds the ability to use &ooui=true / &ooui=false to enable/disable the new s" [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [22:11:38] (03CR) 10Bartosz Dziewoński: "(Note that most of the code is in https://gerrit.wikimedia.org/r/#/c/344805/)" [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [22:11:56] (03PS1) 10Isarra: Fix stuff I broke, also changes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/344807 [22:15:00] (03PS2) 10Bartosz Dziewoński: EditPage: Refactor getCheckboxes() to allow changing the format [core] - 10https://gerrit.wikimedia.org/r/344805 [22:15:02] (03PS32) 10Bartosz Dziewoński: Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [22:15:34] (03CR) 10Bartosz Dziewoński: "PS2:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [22:16:13] 10MediaWiki-ResourceLoader, 06Collaboration-Team-Triage, 10Notifications: Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45 - https://phabricator.wikimedia.org/T161420#3131279 (10Paladox) [22:17:33] 10Wiki-Loves-Monuments (2017): Write article for Europa Nostra magazine on WLM 2017 - https://phabricator.wikimedia.org/T160065#3131293 (10LilyOfTheWest) >>! In T160065#3131263, @Effeietsanders wrote: > If I read that angle from the perspective of a heritage expert, I would be curious to explore this set of monu... [22:18:55] (03PS2) 10Isarra: Fix stuff I broke, also changes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/344807 [22:20:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] EditPage: Refactor getCheckboxes() to allow changing the format [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [22:27:21] !class User [22:27:21] See https://doc.wikimedia.org/mediawiki-core/master/php/classUser.html [22:28:22] (03CR) 10Isarra: [C: 032] Fix stuff I broke, also changes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/344807 (owner: 10Isarra) [22:29:46] (03Merged) 10jenkins-bot: Fix stuff I broke, also changes [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/344807 (owner: 10Isarra) [22:32:15] 10Timeless, 10Wikimedia-Extension-setup, 07Community-consensus-needed: Review and deploy Timeless skin - https://phabricator.wikimedia.org/T154371#3131318 (10Dereckson) [22:34:37] 06Discovery, 10Wikimedia-Portals: www.wikipedia.org copies Wikidata descriptions and page images from other search results - https://phabricator.wikimedia.org/T161422#3131323 (10PrimeHunter) [22:43:13] 10Timeless, 10Wikimedia-Extension-setup, 07Community-consensus-needed: Review and deploy Timeless skin - https://phabricator.wikimedia.org/T154371#3131340 (10Legoktm) [22:43:15] 10Timeless, 13Patch-For-Review: Deploy Timeless to betawiki - https://phabricator.wikimedia.org/T160643#3131338 (10Legoktm) 05Open>03Resolved https://en.wikipedia.beta.wmflabs.org/wiki/Special:Version?useskin=timeless [22:45:02] 10Timeless: Infoboxes missing padding - https://phabricator.wikimedia.org/T161423#3131341 (10Isarra) [22:45:46] (03PS3) 10Bartosz Dziewoński: EditPage: Refactor getCheckboxes() to allow changing the format [core] - 10https://gerrit.wikimedia.org/r/344805 [22:45:47] (03PS33) 10Bartosz Dziewoński: Convert EditPage buttons and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [22:46:18] (03PS1) 10Bartosz Dziewoński: Update to use EditPageGetCheckboxesDefinition hook [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/344808 [22:46:35] (03CR) 10Bartosz Dziewoński: "* Replaced 'title' with 'title-message'" [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [22:47:28] (03CR) 10Bartosz Dziewoński: "Example backwards-compatible update for this change (FlaggedRevs): https://gerrit.wikimedia.org/r/344808" [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [22:56:50] 10Timeless, 10Wikimedia-Extension-setup, 07Community-consensus-needed: Review and deploy Timeless skin - https://phabricator.wikimedia.org/T154371#3131359 (10Dereckson) [23:02:47] (03PS34) 10Bartosz Dziewoński: Convert EditPage buttons, checkboxes and summary input to OOUI [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [23:04:02] (03CR) 10Bartosz Dziewoński: [C: 031] "Updated commit message and added release notes. I'm done. I think this is okay now, but someone else should review." [core] - 10https://gerrit.wikimedia.org/r/231600 (https://phabricator.wikimedia.org/T111088) (owner: 10Florianschmidtwelzow) [23:07:30] (03PS1) 10Gergő Tisza: MWHttpRequest: optionally add original request data [core] - 10https://gerrit.wikimedia.org/r/344809 (https://phabricator.wikimedia.org/T161029) [23:13:11] (03CR) 10Bartosz Dziewoński: "I don't think this actually helps much for T157658, the new method (and the new hook) still require an EditPage. But it might help a bit w" [core] - 10https://gerrit.wikimedia.org/r/344805 (owner: 10Bartosz Dziewoński) [23:17:43] (03CR) 10jerkins-bot: [V: 04-1] MWHttpRequest: optionally add original request data [core] - 10https://gerrit.wikimedia.org/r/344809 (https://phabricator.wikimedia.org/T161029) (owner: 10Gergő Tisza) [23:23:08] (03PS4) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) [23:25:11] (03CR) 10jerkins-bot: [V: 04-1] Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [23:25:35] 10Metrolook, 13Patch-For-Review: In Metrolook, scrolling to anchor links (ex. clicking a table of contents item to go to the page section) doesn't take the fixed header into account - https://phabricator.wikimedia.org/T157532#3131377 (10Paladox) @smkent hi, i tried your fix but it failed. Using the above ^^ fi... [23:27:17] (03PS5) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) [23:29:16] (03CR) 10jerkins-bot: [V: 04-1] Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [23:40:06] (03PS1) 10Mobrovac: Add .gitreview [3d2png/deploy] - 10https://gerrit.wikimedia.org/r/344810 [23:42:26] (03PS6) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) [23:42:47] (03PS7) 10Paladox: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) [23:46:01] (03CR) 10Paladox: [C: 032] Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [23:47:01] (03Merged) 10jenkins-bot: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/344795 (https://phabricator.wikimedia.org/T157532) (owner: 10Paladox) [23:55:11] (03CR) 10GICodeWarrior: "Looks good overall. Thanks for sticking with it." (033 comments) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/327891 (owner: 10Jrchamp) [23:59:20] 10MediaWiki-Authentication-and-authorization, 06Reading-Infrastructure-Team, 13Patch-For-Review: Update Auth_remoteuser to use AuthManager - https://phabricator.wikimedia.org/T110292#3131413 (10GICodeWarrior) Thanks @Enst80. Lots of great updates. :-D I left a couple comments on the patchset. If you have...