[00:39:58] (03PS4) 10MarkAHershberger: Refactor and fix long lines [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236697 [00:40:04] (03CR) 10jerkins-bot: [V: 04-1] Refactor and fix long lines [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236697 (owner: 10MarkAHershberger) [00:48:22] 10MediaWiki-Parser, 06Parsing-Team, 13Patch-For-Review: Add non-breaking spaces in additional places automatically - https://phabricator.wikimedia.org/T15619#2940668 (10matmarex) [00:48:25] 10MediaWiki-Parser, 07Easy, 13Patch-For-Review: Automatically convert spaces after section markers (§) into non-breaking spaces - https://phabricator.wikimedia.org/T119463#2940667 (10matmarex) [00:58:11] (03CR) 10Bartosz Dziewoński: [C: 032] Added "autoHideSeconds" setting in mw.notify() [core] - 10https://gerrit.wikimedia.org/r/331989 (https://phabricator.wikimedia.org/T155228) (owner: 10Filip) [01:00:01] (03CR) 10MtDu: "Thanks Bartosz!" [core] - 10https://gerrit.wikimedia.org/r/331989 (https://phabricator.wikimedia.org/T155228) (owner: 10Filip) [01:01:49] tonythomas: around? [01:05:20] (03PS1) 10MtDu: Extend floating dialog duration to 10s [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/332090 (https://phabricator.wikimedia.org/T154763) [01:07:40] (03Merged) 10jenkins-bot: Added "autoHideSeconds" setting in mw.notify() [core] - 10https://gerrit.wikimedia.org/r/331989 (https://phabricator.wikimedia.org/T155228) (owner: 10Filip) [01:10:27] 10MediaWiki-Uploading, 06Multimedia: Remove the useless "may contain malicious content" warning on some uploaded files - https://phabricator.wikimedia.org/T155288#2940677 (10matmarex) I'm not sure if it's entirely meaningless. It just means that MediaWiki knows nothing about the file type. We don't display it... [01:11:30] 10MediaWiki-File-management, 06Multimedia, 13Patch-For-Review, 07Security-General: .txt files "may contain malicious content" - https://phabricator.wikimedia.org/T153843#2892878 (10matmarex) We have a different, more explicit warning for PDF files. [01:11:53] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Identify, research, and document open-source team communication & collaboration tools - https://phabricator.wikimedia.org/T154002#2940681 (10divadsn) a:05srishakatux>03None I have included researches done by @SacredWKnight for Zuli... [01:14:16] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Identify, research, and document open-source team communication & collaboration tools - https://phabricator.wikimedia.org/T154002#2940683 (10divadsn) a:03srishakatux [01:18:29] (03CR) 10jenkins-bot: Added "autoHideSeconds" setting in mw.notify() [core] - 10https://gerrit.wikimedia.org/r/331989 (https://phabricator.wikimedia.org/T155228) (owner: 10Filip) [01:18:55] 10MediaWiki-Redirects, 06Discovery: Redirects should (?) set canonical URL differently - https://phabricator.wikimedia.org/T155266#2940684 (10matmarex) >>! In T155266#2938909, @Peteforsyth wrote: > Here's a question: Is there any circumstance you can imagine where a Google search should return the redirect pag... [01:21:09] (03PS5) 10MarkAHershberger: Refactor and fix long lines [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236697 [01:21:28] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Identify, research, and document open-source team communication & collaboration tools - https://phabricator.wikimedia.org/T154002#2940686 (10divadsn) Kandan seems to be abandonded, so I won't do a research onto that. [01:22:05] (03CR) 10jerkins-bot: [V: 04-1] Refactor and fix long lines [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236697 (owner: 10MarkAHershberger) [01:26:35] (03PS6) 10MarkAHershberger: Refactor and fix long lines [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236697 [02:10:43] (03PS4) 10MarkAHershberger: Move getComparisonCond to utility class [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236698 [02:11:38] (03CR) 10jerkins-bot: [V: 04-1] Move getComparisonCond to utility class [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236698 (owner: 10MarkAHershberger) [02:11:45] (03Abandoned) 10MarkAHershberger: Add "allns" for all namespaces, use comparison condition [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236699 (owner: 10MarkAHershberger) [02:13:40] (03PS5) 10MarkAHershberger: Move getComparisonCond to utility class [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236698 [02:14:41] (03CR) 10jerkins-bot: [V: 04-1] Move getComparisonCond to utility class [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236698 (owner: 10MarkAHershberger) [02:18:40] 10MediaWiki-General-or-Unknown, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): mw.notify() should have "autoHideSeconds" option settable. - https://phabricator.wikimedia.org/T155228#2940688 (10matmarex) 05Open>03Resolved [02:20:26] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Handle 404 status code in Android app - https://phabricator.wikimedia.org/T155192#2940691 (10Mholloway) [02:20:28] 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Red links displayed as regular links when Restbase enabled. - https://phabricator.wikimedia.org/T119266#2940694 (10Mholloway) [02:22:58] (03PS6) 10MarkAHershberger: Move getComparisonCond to utility class [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236698 [02:40:31] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Easy, 07I18n: Extension WebPlatformSearchAutocomplete failing tests due to missing apihelp messages - https://phabricator.wikimedia.org/T155033#2940697 (10SamanthaNguyen) [02:42:55] (03Abandoned) 10MarkAHershberger: I hate one-line if statements [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236711 (owner: 10MarkAHershberger) [02:48:10] (03PS4) 10MarkAHershberger: update gitignore with a couple of emacs bits [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/239580 [02:57:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] Add help messages, refactor forms a bit (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/331921 (https://phabricator.wikimedia.org/T149024) (owner: 10Isarra) [02:58:04] (03CR) 10Bartosz Dziewoński: Add help messages, refactor forms a bit [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/331921 (https://phabricator.wikimedia.org/T149024) (owner: 10Isarra) [03:05:16] 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 07Documentation: ArticleAfterFetchContent and ArticleAfterFetchContentObject hooks... one is deprecated... the other's not. - https://phabricator.wikimedia.org/T154672#2940709 (10SamanthaNguyen) [03:12:55] musikanimal, hi, around? [03:14:09] 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 07Documentation: ArticleAfterFetchContent and ArticleAfterFetchContentObject hooks... one is deprecated... the other's not. - https://phabricator.wikimedia.org/T154672#2940712 (10TTO) @Reedy deprecated ArticleAfterFetchContentObject in 97d9916a3d16.... [03:16:15] 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 07Documentation, 05MW-1.29-release: ArticleAfterFetchContent and ArticleAfterFetchContentObject hooks... one is deprecated... the other's not. - https://phabricator.wikimedia.org/T154672#2940715 (10TTO) [04:46:04] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.4), 13Patch-For-Review, 03UI-Standardization-Kanban: InputWidgets' Indicator- and LabelElements sometimes make focus visually disappear when actively clicked - https://phabricator.wikimedia.org/T154829#2940722 (10Volker_E) [04:48:12] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.4), 03UI-Standardization-Kanban: InputWidgets' Indicator- and LabelElements in PHP make focus visually disappear when actively clicked - https://phabricator.wikimedia.org/T154829#2940724 (10Volker_E) [04:48:18] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.4), 03UI-Standardization-Kanban: InputWidgets' Indicator- and LabelElements in PHP make focus visually disappear when actively clicked - https://phabricator.wikimedia.org/T154829#2925057 (10Volker_E) 05Open>03Resolved [04:49:16] 10UI-Standardization, 03UI-Standardization-Kanban, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7), 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Replace deprecated mediawiki.UI Less variables with current ones - https://phabricator.wikimedia.org/T154362#2940729 (10Volker_E) p:05High>03Triage [05:33:56] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.4), 03UI-Standardization-Kanban: Improve form layouts in OOUI MW core forms for better user experience - https://phabricator.wikimedia.org/T136790#2940740 (10Volker_E) [06:15:47] 10UI-Standardization, 03UI-Standardization-Kanban: Remove 3D box-shadow for flat element PanelLayout and harmonize inner padding - https://phabricator.wikimedia.org/T155335#2940742 (10Volker_E) [06:24:10] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: Remove 3D box-shadow for flat element PanelLayout and harmonize inner padding - https://phabricator.wikimedia.org/T155335#2940757 (10Volker_E) [06:25:21] (03PS1) 10Brian Wolff: Move title validation for Special:CreateCollaborationHub to that field [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332114 [06:26:35] (03CR) 10jerkins-bot: [V: 04-1] Move title validation for Special:CreateCollaborationHub to that field [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332114 (owner: 10Brian Wolff) [06:31:10] 10Wikimedia-Site-requests, 07Community-consensus-needed: Change the name "Wikipedia" from Latin to Cyrillic "Википедия" on Avar Wikipedia - https://phabricator.wikimedia.org/T155321#2940759 (10Al-Gimravi) Yes, the community informed. [06:31:35] (03PS2) 10Brian Wolff: Move title validation for Special:CreateCollaborationHub to that field [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332114 [06:38:14] (03PS3) 10Brian Wolff: Move title validation for Special:CreateCollaborationHub to that field [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332114 [06:38:39] (03PS1) 10Brian Wolff: Add period to end of error messages. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332115 [06:38:43] (03CR) 10Brian Wolff: [C: 032] Move title validation for Special:CreateCollaborationHub to that field [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332114 (owner: 10Brian Wolff) [06:39:07] (03CR) 10Brian Wolff: [C: 032] Add period to end of error messages. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332115 (owner: 10Brian Wolff) [06:40:38] (03Merged) 10jenkins-bot: Move title validation for Special:CreateCollaborationHub to that field [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332114 (owner: 10Brian Wolff) [06:40:47] (03Merged) 10jenkins-bot: Add period to end of error messages. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332115 (owner: 10Brian Wolff) [06:51:14] (03PS1) 10Brian Wolff: Fix warning about static.name and fix for widget name change [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332116 [06:51:59] (03PS1) 10Brian Wolff: Give early error message in Special:CreateCollaborationHub if not allowed [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332117 [06:53:18] (03PS2) 10Brian Wolff: Fix warning about static.name not being set in OOUI windows [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332116 [06:53:27] (03CR) 10Brian Wolff: [C: 032] Fix warning about static.name not being set in OOUI windows [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332116 (owner: 10Brian Wolff) [06:53:48] (03CR) 10Brian Wolff: [C: 032] Give early error message in Special:CreateCollaborationHub if not allowed [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332117 (owner: 10Brian Wolff) [06:55:30] (03Merged) 10jenkins-bot: Fix warning about static.name not being set in OOUI windows [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332116 (owner: 10Brian Wolff) [06:55:39] (03Merged) 10jenkins-bot: Give early error message in Special:CreateCollaborationHub if not allowed [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332117 (owner: 10Brian Wolff) [07:00:56] 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 07Documentation, 05MW-1.29-release: ArticleAfterFetchContent and ArticleAfterFetchContentObject hooks... one is deprecated... the other's not. - https://phabricator.wikimedia.org/T154672#2940768 (10Reedy) Hmm. I don't think ArticleAfterFetchContent... [07:01:28] (03PS1) 10TTO: [WIP] Skip over bot-flagged and minor edits in the old-style watchlist [core] - 10https://gerrit.wikimedia.org/r/332119 [07:02:22] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#142799 (10TTO) I analysed the existing behaviour of the watchlist (with the enhanced watchlist turned off). This was what I found: # If the most recent edit... [07:07:27] (03PS1) 10Reedy: Un-deprecate ArticleAfterFetchContentObject hook [core] - 10https://gerrit.wikimedia.org/r/332120 [07:07:53] (03PS2) 10Reedy: Un-deprecate ArticleAfterFetchContentObject hook [core] - 10https://gerrit.wikimedia.org/r/332120 (https://phabricator.wikimedia.org/T154672) [07:08:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Skip over bot-flagged and minor edits in the old-style watchlist [core] - 10https://gerrit.wikimedia.org/r/332119 (owner: 10TTO) [07:12:48] (03PS1) 10Reedy: Un-deprecate ArticleAfterFetchContentObject hook [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/332121 (https://phabricator.wikimedia.org/T154672) [07:15:44] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2940776 (10Doc_James) I am happy with either. [07:18:34] 10UI-Standardization, 10OOjs-UI, 13Patch-For-Review, 03UI-Standardization-Kanban: Remove 3D box-shadow for flat element PanelLayout and harmonize inner padding - https://phabricator.wikimedia.org/T155335#2940777 (10Volker_E) [07:18:39] (03CR) 10jerkins-bot: [V: 04-1] Un-deprecate ArticleAfterFetchContentObject hook [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/332121 (https://phabricator.wikimedia.org/T154672) (owner: 10Reedy) [07:22:06] (03PS1) 10Brian Wolff: Clarify the rendering option code, and fix a wfMessage call. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332122 [07:25:41] (03CR) 10Brian Wolff: [C: 032] Clarify the rendering option code, and fix a wfMessage call. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332122 (owner: 10Brian Wolff) [07:26:49] (03Merged) 10jenkins-bot: Clarify the rendering option code, and fix a wfMessage call. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332122 (owner: 10Brian Wolff) [07:41:13] 10MediaWiki-extensions-CategoryTree: CategoryTree shows dropdown when subcategory size is negative - https://phabricator.wikimedia.org/T155336#2940778 (10labster) [07:43:20] (03PS5) 10Phuedx: Vary cog click behavior [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328675 (https://phabricator.wikimedia.org/T146889) [07:43:22] (03PS8) 10Phuedx: Send blob to everyone [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328500 (https://phabricator.wikimedia.org/T146889) [07:43:24] (03PS4) 10Phuedx: Make settings reducer control footer link [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328674 (https://phabricator.wikimedia.org/T146889) [07:52:31] 07Design, 06Reading-Web-Backlog, 10Page-Previews (2016-17-Q3-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-89-🎂: A preference for hovercards appears on user preferences page - https://phabricator.wikimedia.org/T146889#2699071 (10phuedx) {3c5515c0b7971f6176d254a5b8c91e356f8a9b44}, {7b9682d0059c62537cbed... [07:56:03] (03CR) 10Phuedx: [C: 032] Remove wfIncrStats logging from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/332085 (https://phabricator.wikimedia.org/T132134) (owner: 10MtDu) [07:56:55] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 07Technical-Debt (RW-Tech-Debt): Remove wfIncrStats logging from Special:MobileOptions - https://phabricator.wikimedia.org/T132134#2940795 (10phuedx) >>! In T132134#2940619, @MtDu wrote: > Note: There are also some calls in includes/MobileContext.php and inc... [07:57:19] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, 07Technical-Debt (RW-Tech-Debt): Remove wfIncrStats logging from Special:MobileOptions - https://phabricator.wikimedia.org/T132134#2940797 (10phuedx) [07:57:43] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, 07Technical-Debt (RW-Tech-Debt): Remove wfIncrStats logging from Special:MobileOptions - https://phabricator.wikimedia.org/T132134#2189399 (10phuedx) [08:03:28] 10MediaWiki-Parser, 07Easy, 13Patch-For-Review: Automatically convert spaces after section markers (§) into non-breaking spaces - https://phabricator.wikimedia.org/T119463#1827078 (10seth) >>! In T119463#2939686, @gerritbot wrote: > Change 332037 had a related patch set uploaded (by Harjotsingh): [...] > >... [08:04:17] (03Merged) 10jenkins-bot: Remove wfIncrStats logging from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/332085 (https://phabricator.wikimedia.org/T132134) (owner: 10MtDu) [08:12:37] (03CR) 10jenkins-bot: Remove wfIncrStats logging from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/332085 (https://phabricator.wikimedia.org/T132134) (owner: 10MtDu) [08:18:28] (03PS1) 10Brian Wolff: Hide headers and inactive members from Hub page [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332123 (https://phabricator.wikimedia.org/T141184) [08:18:47] (03CR) 10Brian Wolff: [C: 032] Hide headers and inactive members from Hub page [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332123 (https://phabricator.wikimedia.org/T141184) (owner: 10Brian Wolff) [08:19:06] 10MediaWiki-extensions-CollaborationKit, 13Patch-For-Review: Automatically sort member lists between active and inactive members - https://phabricator.wikimedia.org/T141184#2940804 (10Bawolff) 05Open>03Resolved [08:20:17] (03Merged) 10jenkins-bot: Hide headers and inactive members from Hub page [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/332123 (https://phabricator.wikimedia.org/T141184) (owner: 10Brian Wolff) [08:30:23] (03PS2) 10Seth: Parser: Correct white space in German abbreviation [core] - 10https://gerrit.wikimedia.org/r/328847 (https://phabricator.wikimedia.org/T15619) [08:35:55] (03CR) 10TTO: Fix extension UIFeedback failing tests (031 comment) [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332036 (https://phabricator.wikimedia.org/T155048) (owner: 10DatGuy) [08:37:42] (03CR) 10TTO: "For those who are interested in such things:" [core] - 10https://gerrit.wikimedia.org/r/332119 (owner: 10TTO) [09:08:55] (03PS2) 10Harjotsingh: Convert space after § to non-breaking spaces [core] - 10https://gerrit.wikimedia.org/r/332037 (https://phabricator.wikimedia.org/T119463) [09:09:59] 10MediaWiki-Parser, 07Easy, 13Patch-For-Review: Automatically convert spaces after section markers (§) into non-breaking spaces - https://phabricator.wikimedia.org/T119463#2940811 (10Harjotsingh) @seth Yes it was deleting the next character and backreference was needed. I've done the necessary changes. Than... [09:35:14] (03CR) 10Fomafix: [C: 04-1] "Such replacements adds additional problem. For example in the following table the § is not symmetric:" [core] - 10https://gerrit.wikimedia.org/r/332037 (https://phabricator.wikimedia.org/T119463) (owner: 10Harjotsingh) [09:44:10] (03CR) 10Bartosz Dziewoński: "Wait, so, I've never actually looked at why you wanted this feature. But the message here is just "You have subscribed to "Newsletter name" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/332090 (https://phabricator.wikimedia.org/T154763) (owner: 10MtDu) [09:45:08] (03CR) 10Bartosz Dziewoński: "(I'm not a maintainer of this, just commenting. Code-wise this change is correct.)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/332090 (https://phabricator.wikimedia.org/T154763) (owner: 10MtDu) [09:53:29] (03CR) 10Nemo bis: "Meanwhile there's also https://translatewiki.net/wiki/Thread:Portal_talk:Ca/Joining_forces_with_Occitan , but I'm not sure that blocks thi" [core] - 10https://gerrit.wikimedia.org/r/329393 (owner: 10Nemo bis) [10:09:51] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2940824 (10JEumerus) I'd probably prefer B. I don't think logged actions and edits should bury each other. Other people may disagree. [10:25:19] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10TimedMediaHandler: Ogg Vorbis has negative length displayed, cannot be played - https://phabricator.wikimedia.org/T108665#2940828 (10zhuyifei1999) 05Open>03Resolved a:03zhuyifei1999 Reupload. Whatever the past issue that caused the negative leng... [10:29:29] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Handle 404 status code in Android app - https://phabricator.wikimedia.org/T155192#2940834 (10Tacsipacsi) 05duplicate>03Open This is not only about red links in articles, the user can come from anywhere: for example, the app is registered as the handler o... [10:30:18] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10TimedMediaHandler: Ogg audio file on Commons not listed with correct duration metadata - https://phabricator.wikimedia.org/T87619#995268 (10zhuyifei1999) For the record: reuploading doesn't work. ffprobe version `2.8.10-0ubuntu0.16.04.1` says: ``` In... [10:31:03] (03CR) 10Filip: "Hmm, previously, this message was longer. I'm not sure. But this way, we want to set it at 5 seconds. Thanks for doing this, MtDu!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/332090 (https://phabricator.wikimedia.org/T154763) (owner: 10MtDu) [10:33:35] (03CR) 10DatGuy: Fix extension UIFeedback failing tests (031 comment) [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332036 (https://phabricator.wikimedia.org/T155048) (owner: 10DatGuy) [10:37:56] DatGuy, sorry, I should have been clearer. It was completely wrong before you changed it [10:38:15] I was suggesting that, rather than make translators translate a broken example, it would be better to just remove it [10:39:10] so, was the query broken? [10:39:18] or is it the message? [10:40:10] DatGuy: The query relates to a totally different action with parameters that are not implemented by that module [10:41:01] ah alright. is it fine if I remove the message and parameter, but leave the function for later use (But remove the function's content) [10:43:44] Just make it return an empty array [10:45:25] yeah that's what I meant :D [10:46:48] tto http://pastebin.com/9VS1CrvD [10:46:58] then remove the example line from en and qqq? [10:47:05] DatGuy, just return []; would be enough [10:47:31] return array( [] ); ? [10:49:22] 10MediaWiki-Documentation, 07Documentation: Documentation of MW special pages - https://phabricator.wikimedia.org/T155069#2940844 (10Iniquity) @Aklapper, I think this is 'tracking' task. The task can be resolved if we will have complite documentation pages for MW's special pages. Are you saying I was wrong? [10:53:09] DatGuy, [] is an alternative syntax for array(). I guess if the rest of the extension uses array(), then return array(); would be better [10:53:29] ah yes [10:57:26] (03PS4) 10DatGuy: Fix extension UIFeedback failing tests [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332036 (https://phabricator.wikimedia.org/T155048) [10:59:23] is it good now? [11:02:29] 07Design, 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Subscribe/Unsubscribe newsletter floating dialog disappears too soon - https://phabricator.wikimedia.org/T154763#2940845 (10FilipGCI) @01tonythomas: @QuimGil: @MtDu: After T155228 we wanted to modify this setting, but I... [11:03:07] DatGuy, looks good, but tests are still failing. I can merge, but if your point was to make the tests pass, then there might be some more work to do [11:06:44] hm, I wonder why [11:07:15] 10MediaWiki-ContentHandler, 05MW-1.28-release-notes, 05MW-1.29-release-notes, 13Patch-For-Review, 07Technical-Debt: Clean up ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T145728#2691330 (10FilipGCI) We only need to resolve T154498 , and everything will be done. [11:07:25] where do you see that the tests are failing? [11:07:53] Reedy: Hi! Are you here? [11:07:55] found it [11:08:12] @seen Reedy [11:08:12] rlot: Reedy is in here, right now [11:19:07] (03CR) 10DatGuy: "check experimental" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332036 (https://phabricator.wikimedia.org/T155048) (owner: 10DatGuy) [11:20:00] tto I thin k there's an error unrelated to my patch? [11:21:27] (03CR) 10TTO: [C: 032] Fix extension UIFeedback failing tests [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332036 (https://phabricator.wikimedia.org/T155048) (owner: 10DatGuy) [11:21:34] (03Merged) 10jenkins-bot: Fix extension UIFeedback failing tests [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332036 (https://phabricator.wikimedia.org/T155048) (owner: 10DatGuy) [11:21:53] DatGuy: Seems to be [11:22:15] Should I close the phab ticket? Not sure if it will still work [11:22:58] DatGuy: It might be because the extension is called UIFeedback, but the entry point is called UiFeedback.php [11:23:03] Note the different casing [11:23:11] Just an idea, no idea if that is the actual issue [11:24:10] if I put a gerrit patch and 'check experimental' it, would it work? Or should I do it in a private wiki? [11:24:51] DatGuy: I'm trying a patch in Gerrit, we'll see [11:25:08] (03Draft2) 10TTO: Insert the description of the change. [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 [11:25:17] oops, forgot to enter a description :) [11:26:52] MatmaRex: Thanks for merging this 'autoHideSeconds' patch! [11:27:05] seems like it kinda worked [11:27:16] I'll do the bonus test thing [11:27:36] (03CR) 10DatGuy: [C: 031] "check experimental" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (owner: 10TTO) [11:28:20] I might've done it wrong :P [11:28:31] but aside from the commit message, it should be good? [11:28:39] (03CR) 10Harjotsingh: "> Such replacements adds additional problem. For example in the" [core] - 10https://gerrit.wikimedia.org/r/332037 (https://phabricator.wikimedia.org/T119463) (owner: 10Harjotsingh) [11:29:11] (03PS3) 10TTO: Rename extension entry point so tests pass [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) [11:29:40] (03CR) 10TTO: "check experimental" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) (owner: 10TTO) [11:30:08] yeah I did it wrong :P. Also the api one is lowercase. should it be changed, or does it work? [11:30:40] DatGuy: It's only the actual entry point that should matter, fingers crossed [11:30:58] there's one failure. not sure if it matters [11:31:04] something package file [11:32:21] (03PS1) 10Umherirrender: Add StrappingTemplate to autoloader [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/332127 [11:32:57] We can ignore the npm one I think [11:33:57] it would still be nice to have a package.json file. its not a must though [11:36:17] (03CR) 10TTO: [C: 032] Rename extension entry point so tests pass [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) (owner: 10TTO) [11:36:28] seems good :D [11:37:16] 10MediaWiki-General-or-Unknown, 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 07Tracking: Let ApiDocumentationTest structure test pass on all repos - https://phabricator.wikimedia.org/T154838#2940872 (10DatGuy) [11:37:19] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Easy, 07I18n, 13Patch-For-Review: Extension UIFeedback failing tests due to missing apihelp messages - https://phabricator.wikimedia.org/T155048#2940870 (10DatGuy) 05Open>03Resolved Thanks to TTO, it works now. [11:39:29] 10MediaWiki-Configuration: Category:Noindexed_pages should be non-indexed by default - https://phabricator.wikimedia.org/T155302#2940874 (10XXN) [11:45:21] (03Merged) 10jenkins-bot: Rename extension entry point so tests pass [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) (owner: 10TTO) [11:45:44] (03CR) 10TTO: "Thanks for the feedback :)" [core] - 10https://gerrit.wikimedia.org/r/332031 (https://phabricator.wikimedia.org/T135575) (owner: 10TTO) [11:49:25] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Easy, 07I18n: Extension WikiObjectModel failing tests due to missing apihelp messages - https://phabricator.wikimedia.org/T155034#2940880 (10FilipGCI) a:03FilipGCI [11:49:28] (03PS3) 10TTO: Allow CJK languages to specify flag spacing for enhanced change lists [core] - 10https://gerrit.wikimedia.org/r/332031 (https://phabricator.wikimedia.org/T135575) [11:53:04] tto: How I can run full php test? [11:53:28] rlot: Would you like to run PHPUnit on your local machine? Or do you mean something else? [11:53:38] tto: Yeah, phpunit on local machine [11:54:02] tto: phpunit runs this on one file [11:54:46] What happens if you do phpunit tests/phpunit/phpunit.php? [11:55:15] tto: Theres no such file. [11:55:22] tto: Its in extension [11:55:57] (03PS2) 10Umherirrender: Remove and add autoload entries [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/332049 [11:56:02] Does it work if you load the extension into your installation of core using wfLoadExtension() or require_once and try running that file? [11:56:11] Have to be honest, I've never run PHPUnit tests for an extension before [11:56:21] (at least not together with the core tests) [11:58:14] rlot: If you can't get that to work, there's no shame in uploading a patch to Gerrit and looking at jenkins' output :) [11:58:37] tto: Eh, thats not a good way [12:01:12] 10MediaWiki-extensions-Other, 07Easy: Convert extension WikiObjectModel to use extensions registry. - https://phabricator.wikimedia.org/T155339#2940899 (10FilipGCI) [12:09:04] 10MediaWiki-extensions-Contributors: api module contributors from extension Contributors conflicts with core module contributors - https://phabricator.wikimedia.org/T155341#2940935 (10Umherirrender) [12:10:43] (03PS1) 10Mschwarzer: Implement A/B test to measure Citolytics performance as readMoreSource [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/332129 [12:12:18] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Easy, 07I18n: Extension WikiObjectModel failing tests due to missing apihelp messages - https://phabricator.wikimedia.org/T155034#2940966 (10FilipGCI) a:05FilipGCI>03None [12:13:35] 10MediaWiki-extensions-Other, 07Easy: Convert extension WikiObjectModel to use extensions registry. - https://phabricator.wikimedia.org/T155339#2940982 (10FilipGCI) a:03FilipGCI [12:14:05] 10Wikimedia-Site-requests, 07Community-consensus-needed: Change the name "Wikipedia" from Latin to Cyrillic "Википедия" on Avar Wikipedia - https://phabricator.wikimedia.org/T155321#2940983 (10MarcoAurelio) a:05RobH>03None Unassingning from @RobH as I suspect he was added without checking with him first. P... [12:15:41] tto: Do you think we can deprecate mediawiki 1.25? [12:15:42] https://phabricator.wikimedia.org/T155339#2940899 [12:16:41] rlot: 1.25 is no longer supported, if that's what you mean [12:17:05] In fact, 1.26 isn't supported either. But 1.23 still is supported for a few more months [12:17:24] tto: So I can use extension registry in this extension? [12:17:41] rlot: I don't see why not [12:18:44] rlot, not sure if it's worth bothering with that extension. It looks really old and dusty, may not work anymore [12:19:46] tto: Just wanted to to practice this :) And, I have a lot of function in entry point. Like http://pastebin.com/b1736XcP - I need to contain them in other php file? [12:20:45] Yeah, you'd have to migrate them to their own file, although most of wfWOMSetupExtension would go to extension.json [12:23:33] tto: If theres "wfWOMInitLanguage" in wfWOMSetupExtension, How can I run it from extension.json? [12:25:25] Not sure off the top of my head. I'm sure there will be docs somewhere on what to do with wgExtensionFunctions functions [12:25:47] (because effectively wfWOMInitLanguage is an extension function, being the only bit of interesting logic in wfWOMSetupExtension) [12:26:38] (03CR) 10Bartosz Dziewoński: Replace HTMLForm info fields with definition lists on management interface (032 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/309924 (https://phabricator.wikimedia.org/T96154) (owner: 10Gergő Tisza) [12:36:02] 10MobileFrontend, 07JavaScript: mw.hook fires multiple times on mobile site - https://phabricator.wikimedia.org/T155304#2940989 (10Nirmos) Yes, you're absolutely right. Special:MyPage/minerva.js is executed twice. Updating title and description accordingly. [12:37:58] 10MobileFrontend, 07JavaScript: Special:MyPage/minerva.js is executed twice - https://phabricator.wikimedia.org/T155304#2940990 (10Nirmos) [12:39:17] 10Phabricator, 10Diffusion, 15User-Josve05a: Getting 404 when pressing "Edit Maniphest Tasks" on commits - https://phabricator.wikimedia.org/T140535#2940992 (10Paladox) This broke in https://github.com/wikimedia/phabricator/commit/2a7545a452b0336701b5ce95fd5f2d63da42ec11#diff-9495e74ad0d171cd0458b341cfc622d9... [12:46:37] 10MobileFrontend, 07JavaScript: Special:MyPage/minerva.js is executed twice - https://phabricator.wikimedia.org/T155304#2940994 (10Nirmos) [12:48:24] 10MediaWiki-extensions-Other, 07Easy: Convert extension WikiObjectModel to use extensions registry. - https://phabricator.wikimedia.org/T155339#2940995 (10FilipGCI) a:05FilipGCI>03None [12:55:11] (03PS1) 10Bartosz Dziewoński: mw.htmlform: Fix 'hide-if' disabling OOUI fields [core] - 10https://gerrit.wikimedia.org/r/332130 [12:55:23] (03CR) 10Fomafix: [C: 04-1] "This place of the parser is the complete wrong place to to such replacements. The current replacements at this place already make some pro" [core] - 10https://gerrit.wikimedia.org/r/332037 (https://phabricator.wikimedia.org/T119463) (owner: 10Harjotsingh) [12:56:11] (03CR) 10Bartosz Dziewoński: "Whoops, it seems I can't code the simplest thing right. Follow-up: https://gerrit.wikimedia.org/r/#/c/332130/" [core] - 10https://gerrit.wikimedia.org/r/311463 (https://phabricator.wikimedia.org/T145440) (owner: 10Bartosz Dziewoński) [12:58:00] (03CR) 10TTO: "I firmly disagree with that interpretation, Fomafix. It's not at all easy to type or identify non-breaking spaces in an editor, so this on" [core] - 10https://gerrit.wikimedia.org/r/332037 (https://phabricator.wikimedia.org/T119463) (owner: 10Harjotsingh) [13:00:36] 10MediaWiki-extensions-OAuth: Impossible to create owner-only consumer - https://phabricator.wikimedia.org/T155344#2940997 (10matmarex) [13:02:34] 04(no projects): Request for a temporary lift of account creation cap on IP - https://phabricator.wikimedia.org/T155345#2941009 (10SubodhKulkarni) [13:06:17] 10MediaWiki-extensions-OAuth: Impossible to create owner-only consumer - https://phabricator.wikimedia.org/T155344#2941020 (10matmarex) The error comes from MWOAuthSubmitControl::validateFields(): ```lang=php protected function validateFields( array $required ) { foreach ( $required as $field => $validator )... [13:08:45] everything is horrible :( [13:14:12] (03CR) 10Fomafix: [C: 04-1] "> I firmly disagree with that interpretation, Fomafix. It's not at" [core] - 10https://gerrit.wikimedia.org/r/332037 (https://phabricator.wikimedia.org/T119463) (owner: 10Harjotsingh) [13:16:11] Is it just me or did Phabricator send me a bunch of spam emails with previous commits under MtDuTest? [13:17:12] MtDu_: Hi! [13:17:30] (03PS1) 10Umherirrender: Fix load of alias file in extension.json [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/332132 [13:17:51] MtDu_: What do you thing about this Newsletter time patch? Anyway, this should be reverted to 5sec timer [13:18:33] MatmaRex: If we remove hooks after deprecation, we should also remove code like: [13:18:38] ContentHandler::runLegacyHooks( 'ArticleInsertComplete', $params, '1.21' ); [13:18:41] rlot: yeah during testing, I realized how long it was. I think it should be abandoned but let's see what tonythomas says. [13:18:41] 10MediaWiki-extensions-OAuth: Can't create owner-only OAuth consumer - https://phabricator.wikimedia.org/T154846#2925965 (10matmarex) My apologies, I broke it with a recent refactoring of how forms work in MediaWiki core :( I'll get this fixed as soon as possible. As a workaround, you should be able to complete... [13:18:52] (03PS2) 10Umherirrender: Fix load of alias file in extension.json [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/332132 [13:18:53] 10MediaWiki-extensions-OAuth: Can't create owner-only OAuth consumer - https://phabricator.wikimedia.org/T154846#2941024 (10matmarex) [13:18:55] 10MediaWiki-extensions-OAuth: Impossible to create owner-only consumer - https://phabricator.wikimedia.org/T155344#2941027 (10matmarex) [13:19:03] yes [13:20:06] 10MobileFrontend, 07JavaScript: Special:MyPage/minerva.js is executed twice - https://phabricator.wikimedia.org/T155304#2941028 (10Nirmos) If it is of any help, the first one comes from load.php?debug=false&lang=sv&modules=mobile.usermodule&only=scripts&skin=minerva&user=Nirmos&version=0zycl1h:1 14 ms later a... [13:21:55] 10MediaWiki-ContentHandler, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt: Remove remaining ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T154498#2941030 (10FilipGCI) a:03FilipGCI [13:22:50] 10MediaWiki-ContentHandler, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt: Remove remaining ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T154498#2913309 (10FilipGCI) @MtDu: WIll clean up functions, I'll do hooks [13:27:20] (03PS1) 10Bartosz Dziewoński: Unbreak creation of owner-only consumers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/332133 (https://phabricator.wikimedia.org/T155344) [13:29:41] 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Impossible to create owner-only consumer - https://phabricator.wikimedia.org/T155344#2941036 (10matmarex) I am not sure if this is the right fix. It seems to work fine, and I think it makes sense, but I'm not familiar with this code. And there might be other fi... [13:29:54] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IP - https://phabricator.wikimedia.org/T155345#2941037 (10Ciencia_Al_Poder) [13:44:48] (03CR) 10TTO: [C: 032] Update .mailmap for the generation of CREDITS [core] - 10https://gerrit.wikimedia.org/r/331209 (owner: 10TTO) [13:45:18] (03CR) 10Fomafix: [C: 04-1] "The rename of file UiFeedback.php to UIFeedback.php was done in https://gerrit.wikimedia.org/r/332126." [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/266809 (owner: 10Paladox) [13:45:41] (03CR) 10TTO: "Actually didn't mean to +2 this yet! Unless anyone objects in the next few days, I will merge it though." [core] - 10https://gerrit.wikimedia.org/r/331209 (owner: 10TTO) [13:46:16] (03Abandoned) 10Paladox: Change main php file name from UiFeedback to UIFeedback this fixes jenkins [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/266809 (owner: 10Paladox) [14:01:18] 10Phabricator, 10Diffusion, 15User-Josve05a: Getting 404 when pressing "Edit Maniphest Tasks" on commits - https://phabricator.wikimedia.org/T140535#2941040 (10Paladox) [14:04:38] (03CR) 10Paladox: Update .mailmap for the generation of CREDITS (033 comments) [core] - 10https://gerrit.wikimedia.org/r/331209 (owner: 10TTO) [14:05:20] 10Phabricator, 10Diffusion, 15User-Josve05a: Getting 404 when pressing "Edit Maniphest Tasks" on commits - https://phabricator.wikimedia.org/T140535#2941046 (10Paladox) This is now under Edit Related Objects... -> Edit Tasks [14:06:30] (03CR) 10TTO: Update .mailmap for the generation of CREDITS (033 comments) [core] - 10https://gerrit.wikimedia.org/r/331209 (owner: 10TTO) [14:11:26] 10Phabricator, 10Diffusion, 15User-Josve05a: Getting 404 when pressing "Edit Maniphest Tasks" on commits - https://phabricator.wikimedia.org/T140535#2941055 (10Paladox) Looks like this was removed upstream in https://github.com/phacility/phabricator/commit/dc9283b85d713a9e8530ae3a3a2007e97da054a3#diff-aa95cb... [14:20:53] (03CR) 10Liuxinyu970226: [C: 031] Allow CJK languages to specify flag spacing for enhanced change lists [core] - 10https://gerrit.wikimedia.org/r/332031 (https://phabricator.wikimedia.org/T135575) (owner: 10TTO) [14:23:54] (03CR) 10Paladox: Update .mailmap for the generation of CREDITS (031 comment) [core] - 10https://gerrit.wikimedia.org/r/331209 (owner: 10TTO) [14:26:14] (03CR) 10Paladox: [C: 031] Update .mailmap for the generation of CREDITS [core] - 10https://gerrit.wikimedia.org/r/331209 (owner: 10TTO) [14:34:03] (03CR) 10Umherirrender: "This makes problems on windows machine, because there two filenames cannot differ just on case (so this already worked before). Would be n" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) (owner: 10TTO) [14:36:21] (03CR) 10TTO: "Hm, annoying... I wonder if it would be better to revert this and make an exception to the CI config for this extension?" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) (owner: 10TTO) [14:39:01] (03CR) 10TTO: "Also, I'm sorry for self-merging this. For some reason I thought this extension was abandoned, but looking at the commit history it seems " [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/332126 (https://phabricator.wikimedia.org/T155048) (owner: 10TTO) [14:41:21] 04(no projects): Musica test - https://phabricator.wikimedia.org/T155346#2941056 (10Klay79) [14:45:22] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Allow configuration of the mobilefrontend menu and allow it to apply to any skin in mobile mode - https://phabricator.wikimedia.org/T65459#1442896 (10Nirmos) Most of the discussion here and on https://www.mediawiki.org/wiki/Extension_t... [14:45:44] 10jQuery-Client, 07CSS, 07JavaScript: There should be a space between span.mw-collapsible-toggle and its preceding content - https://phabricator.wikimedia.org/T155347#2941070 (10Od1n) [14:55:02] 10jQuery-Client, 07CSS, 07JavaScript: There should be a space between span.mw-collapsible-toggle and its preceding content - https://phabricator.wikimedia.org/T155347#2941083 (10Od1n) Probably a better fix, as it would work on more cases: add a CSS `margin-left:0.3em` You can try it on [[ https://www.mediaw... [14:59:02] (03PS1) 10Jack Phoenix: Removed the majority of ListPages CSS, it's unwanted [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/332135 [15:02:17] (03CR) 10Jack Phoenix: [C: 032] Removed the majority of ListPages CSS, it's unwanted [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/332135 (owner: 10Jack Phoenix) [15:03:54] (03Merged) 10jenkins-bot: Removed the majority of ListPages CSS, it's unwanted [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/332135 (owner: 10Jack Phoenix) [15:17:44] (03CR) 10Jack Phoenix: [C: 032] v3.4 - Fix the height of the image upload frame in QuizGame special page [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/332074 (https://phabricator.wikimedia.org/T155325) (owner: 10SamanthaNguyen) [15:18:56] (03Merged) 10jenkins-bot: v3.4 - Fix the height of the image upload frame in QuizGame special page [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/332074 (https://phabricator.wikimedia.org/T155325) (owner: 10SamanthaNguyen) [15:22:13] 10QuizGame, 10Social-Tools, 07CSS, 07Easy: QuizGame image upload frame doesn't fully show - https://phabricator.wikimedia.org/T155325#2941129 (10ashley) 05Open>03Resolved [15:26:03] 04(no projects): Automatically open the panel "More details" at high resolutions - https://phabricator.wikimedia.org/T155352#2941143 (10putnik) [15:26:53] (03CR) 10VolkerE: Replace HTMLForm info fields with definition lists on management interface (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/309924 (https://phabricator.wikimedia.org/T96154) (owner: 10Gergő Tisza) [15:42:11] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: "Register" newsletters instead of "Create" - https://phabricator.wikimedia.org/T154761#2941204 (10Qgil) Yes, I think it is a good idea to eliminate the concept of "creation" from the UI, and offer the clearer concept of "registrati... [16:00:08] 10Social-Tools, 10SocialProfile, 07CSS: Remove inline styling from SocialProfile module: UserStats - https://phabricator.wikimedia.org/T147263#2941211 (10SamanthaNguyen) a:03SamanthaNguyen [16:08:07] 10MediaWiki-extensions-Newsletter: Log in subscription to newsletter activity - https://phabricator.wikimedia.org/T155273#2941212 (10Qgil) I think this idea deserves discussion before starting any implementation: * If we look at Internet practices, it is fair to expect that most users will assume some privacy h... [16:09:37] 10TimedMediaHandler-Transcode, 07Upstream: Transcoding hangs for no apparent reason, then timeouts - https://phabricator.wikimedia.org/T155247#2941214 (10Aklapper) [16:13:12] 10FanBoxes, 10Social-Tools, 07Documentation: Have better documentation for FanBoxes - https://phabricator.wikimedia.org/T155272#2941215 (10Aklapper) @DatGuy: Without any links or a clearer problem description (which documentation where? when is it "good enough") I neither see how this is #i18n nor #easy. Hen... [16:19:10] 10MediaWiki-Database, 07Tracking: Microsoft SQL Server/MSSQL support (tracking) - https://phabricator.wikimedia.org/T11767#2941219 (10Aklapper) [16:19:15] 10MediaWiki-extensions-Cargo, 13Patch-For-Review: Cargo not creating tables with MS SQLServer database - https://phabricator.wikimedia.org/T155260#2941218 (10Aklapper) [16:21:16] @seen andre__ [16:21:16] MtDu_: Last time I saw andre__ they were quitting the network with reason: Client Quit N/A at 1/10/2017 1:37:20 AM (5d14h43m56s ago) [16:22:01] 10FanBoxes, 10Social-Tools, 07Documentation: Have better documentation for FanBoxes - https://phabricator.wikimedia.org/T155272#2941233 (10DatGuy) Here is a better, more explained version. Feel free to update the task description with it: I think this fits more as i18n than documentation. As can be seen in... [16:22:16] Hey buddy! Going to miss your multimedia panel :( [16:23:33] Oh sorry thought this was a private chat with Yuri [16:40:54] 10Phabricator (Upstream), 07Upstream: [Feature request] See Maniphest user contributions in Advanced Search - https://phabricator.wikimedia.org/T155215#2941237 (10Aklapper) p:05Triage>03Lowest [16:41:12] 10Phabricator (Upstream), 07Upstream: Allow seeing Maniphest user contributions per project in Advanced Search - https://phabricator.wikimedia.org/T155215#2941240 (10Aklapper) [16:47:51] 10MediaWiki-extensions-Newsletter: Autoconfirmed users with `newsletter-create` right can move newsletters - https://phabricator.wikimedia.org/T154383#2941243 (10Aklapper) [16:51:26] 10Phabricator, 10Elasticsearch, 06Release-Engineering-Team: Add support for elasticsearch 5 - https://phabricator.wikimedia.org/T155299#2941245 (10Aklapper) This task's summary only provides a potential solution ("Add support for elasticsearch 5" = enhancement request) and does not describe any problem to so... [16:58:38] 10PictureGame, 10PollNY, 10QuizGame, 10Social-Tools, and 2 others: Consider merging QuizGame, PictureGame, and PollNY extensions together - https://phabricator.wikimedia.org/T155327#2941268 (10SamanthaNguyen) [17:00:33] 10MediaWiki-extensions-LiquidThreads: [BUG] liquidthreads fatal in wmf 1.28-wmf.23 - https://phabricator.wikimedia.org/T149283#2747554 (10Ciencia_Al_Poder) A user on pt.wikibooks [[ https://pt.wikibooks.org/w/index.php?title=Especial:Contribui%C3%A7%C3%B5es/Dante_Cardoso_Pinto_de_Almeida&dir=prev&offset=20170115... [17:03:04] tonythomas: around? [17:08:46] 10MediaWiki-extensions-LiquidThreads: [BUG] liquidthreads fatal in wmf 1.28-wmf.23 - https://phabricator.wikimedia.org/T149283#2941276 (10Paladox) p:05Triage>03High Changing to high as i can reproduce by going to the link given. [17:09:41] 10MediaWiki-extensions-LiquidThreads, 07Wikimedia-log-errors: [BUG] liquidthreads fatal in wmf 1.28-wmf.23 - https://phabricator.wikimedia.org/T149283#2941278 (10Paladox) [17:13:08] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Identify, research, and document open-source team communication & collaboration tools - https://phabricator.wikimedia.org/T154002#2941279 (10srishakatux) @divadsn sounds good! comment here or on the GCI task whenever you are done addin... [17:13:12] 10MediaWiki-extensions-LiquidThreads, 07Wikimedia-log-errors: [BUG] liquidthreads fatal in wmf 1.28-wmf.23 - https://phabricator.wikimedia.org/T149283#2941280 (10Paladox) The setFragment function was introduced in https://phabricator.wikimedia.org/rELQT82a06a80045a4b2e4a351ff6793ca0a4b8383c14 [17:15:02] 10MediaWiki-File-management, 06Commons, 06Multimedia: PHP Notice: Undefined offset: 0 in /.../includes/media/FormatMetadata.php on line 1057 - https://phabricator.wikimedia.org/T87572#994387 (10Cavila) > In 1.26 we are on line 1035 for this. I'm on MW 1.28 and still getting said issue on line 1045. [17:18:21] MtDu_: yes. go on [17:20:09] tonythomas: did you see qgils comment? [17:20:20] tonythomas: he thinks we should change all to register [17:20:39] ah. yes. I see that. okey - then I think I should give that patch a test [17:21:00] I can give one right now [17:21:47] tonythomas: great. Let's get this cleaned up. :) [17:22:15] MtDu_: right. thanks for the wakeup call [17:23:29] tonythomas: no problem. Let me know if I can be of any help, especially for documentation. [17:25:18] MtDu_: Thank you. let me pull this thing [17:30:04] (03Draft1) 10Paladox: Switch from calling setFragment to Title::makeTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/332136 (https://phabricator.wikimedia.org/T149283) [17:30:08] (03Draft2) 10Paladox: Switch from calling setFragment to Title::makeTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/332136 (https://phabricator.wikimedia.org/T149283) [17:30:28] (03CR) 1001tonythomas: [C: 04-1] "After this patch, all I get is "An error occured while trying to register a new newsletter. Please try again." on trying to create a new n" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/331389 (https://phabricator.wikimedia.org/T154761) (owner: 10Borisfba) [17:30:35] Reviewed. [17:34:21] (03PS3) 10Paladox: Switch from calling setFragment to Title::makeTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/332136 (https://phabricator.wikimedia.org/T149283) [17:36:06] 10MediaWiki-ContentHandler, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt, 15User-Daniel: Remove remaining ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T154498#2941298 (10daniel) [17:38:37] 10Phabricator (Upstream), 07Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555#2941312 (10Aklapper) (According to https://secure.phabricator.com/T5793#206322 this has become less likely to get implemented.) [17:40:50] tonythomas: does borisfba still have the task? If not, I can try to see what's wrong in a few hours. [17:41:06] MtDu_: Thank you. I just dont feel it has something to do with my instance [17:41:47] tonythomas: yeah I don't think it does. Has borisfba still claimed the task or not? If he has, I will let him finish it. [17:42:17] MtDu_: borisba do not have the task linked to him as of now afaik [17:47:41] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Actions to grow the diversity of our technical community - https://phabricator.wikimedia.org/T148598#2941320 (10Qgil) p:05Triage>03Normal [17:49:32] 10MediaWiki-Interface: mediawiki.searchSuggest: Support user search namespace preferences - https://phabricator.wikimedia.org/T26214#2941324 (10Paladox) https://phabricator.wikimedia.org/rMW8f52f912f37f397c09748ddfe83d7214dcf73dd9 So if we replace the 0 with '' will that work for getting it to search all namesp... [17:56:07] (03PS2) 10Phuedx: actions: Merge LINK_ABANDON_* + PREVIEW_ABANDON_* [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/331806 [17:57:00] 10Nimbus, 07Easy, 07JavaScript: Nimbus gate-and-submit fails on jshint - https://phabricator.wikimedia.org/T154802#2924444 (10SamanthaNguyen) [18:02:06] MtDu: MtDu_: Are you here? [18:02:31] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [18:02:31] @notify Reedy [18:02:35] rlot: yes but on mobile. [18:03:20] MtDu_: Will you do these functions and "The rest of the hooks and function on T145728 should be marked as removed on the mediawiki.org Hook manual pages" [18:03:20] T145728: Clean up ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T145728 [18:03:34] Will cleanup hooks [18:04:52] rlot: we've already removed all of the usages right? [18:05:52] MtDu_: Yeah, usages are removed [18:06:06] Just cleanup core code. (Adding to relase notes, etc) [18:06:36] Yep. I'll do in few hours. [18:07:24] I'll check with Reedy on marking things as removed so I do it correctly. :) [18:07:44] MtDu_: Have you seen Reedy? [18:08:06] Thanks for helping with this! [18:09:20] (03PS5) 10Phuedx: Make settings reducer control footer link [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328674 (https://phabricator.wikimedia.org/T146889) [18:11:27] (03PS7) 10MarkAHershberger: Simplify parameters to getMatchingTitles [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236692 [18:11:29] (03PS9) 10MarkAHershberger: Refactor for readability and use MW conventions [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236694 [18:11:31] (03PS5) 10MarkAHershberger: Address MW naming inconsistancies [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236696 [18:13:30] (03PS7) 10MarkAHershberger: Refactor and fix long lines [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/236697 [18:20:01] (03PS1) 10Paladox: Add support for searching namespaces other then NS_MAIN [core] - 10https://gerrit.wikimedia.org/r/332137 (https://phabricator.wikimedia.org/T26214) [18:20:02] MtDu_: Hook ArticleSaveComplete is related to function Article::doEdit [18:20:28] Will just remove this code, you need to document that [18:21:21] 07Design, 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: Use consistent cursor for checkbox/radio labels - https://phabricator.wikimedia.org/T131919#2941382 (10Volker_E) Extending Widget.js rather radically by replacing ```lang=html