[00:00:00] I'm not even sure if the remote branch I want to submit to was actually created. [00:00:17] Any insights on creating a remote branch and then submitting a patchset to it? [00:00:28] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Investigate tuning CirrusSearch parameters with optimisation algorithms - https://phabricator.wikimedia.org/T149047#2921816 (10EBernhardson) Applied the above weights (CA_NDCG@10_013.model.txt) and ran through relevance for... [00:03:16] Ha! It is there [00:03:52] https://gerrit.wikimedia.org/r/#/admin/projects/research/ores/wheels,branches [00:04:04] Oh well. I think this is a good time to call it a night. [00:04:09] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2921829 (10Tgr) [00:04:16] o/ [00:04:17] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2921832 (10Tgr) [00:04:30] 06Discovery, 06Discovery-Analysis: External traffic dashboard - update with notation for Safari internal referrers - https://phabricator.wikimedia.org/T154722#2921836 (10debt) [00:05:39] (03CR) 10TTO: [C: 032] Update Maintenance scripts to use $this->requireExtension() [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/330461 (https://phabricator.wikimedia.org/T152139) (owner: 10Georggi199) [00:06:11] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2921857 (10Tgr) Apologies for taking so long to look at this. It's the same issue as T151770: a cross-domain request is made to some gadget, that results in a bunch of new cookies being set, and the br... [00:07:04] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2921861 (10Tgr) [00:07:11] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2827539 (10Tgr) [00:07:38] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work): Wikipedia.org: add app links to Portal dashboard - https://phabricator.wikimedia.org/T154634#2921865 (10debt) [00:08:28] (03Merged) 10jenkins-bot: Update Maintenance scripts to use $this->requireExtension() [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/330461 (https://phabricator.wikimedia.org/T152139) (owner: 10Georggi199) [00:10:49] 10MediaWiki-extensions-OATHAuth, 06Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10iOS-app-feature-Login, and 2 others: Update login interface - https://phabricator.wikimedia.org/T150985#2921868 (10JMinor) [00:11:21] 10MediaWiki-extensions-OATHAuth, 06Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10iOS-app-feature-Login, and 2 others: Update login interface - https://phabricator.wikimedia.org/T150985#2803668 (10JMinor) [00:12:35] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2921874 (10jcrespo) I am adding the #user-notice tag so users may be able to know t... [00:15:57] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2921907 (10Tgr) >>! In T151770#2916526, @Anomie wrote: > I wonder if there are brow... [00:16:08] andre__: Around? [00:16:58] (03PS12) 10Dbrant: Echo notifications for description edits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) [00:17:44] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2921910 (10MtDu) @qgil, The beginnings of this page are here. https://www.mediawiki.org/wiki/Help:Extension:Newsletter. Please take a look when you can... [00:20:28] 10MediaWiki-Parser: ref name with non ascii characters and no quote is incorrectly parsed - https://phabricator.wikimedia.org/T124776#2921913 (10xcombelle) It looks like it was a transient issue and was fixed since, [00:21:33] (03PS1) 10Georggi199: Update Maintenance scripts to use $this->requireExtension() [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/330827 (https://phabricator.wikimedia.org/T152139) [00:22:04] (03PS1) 10Mhurd: Removed some ES6 bits incompatible with production node version. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330828 [00:23:09] shrishakatux: Around? [00:24:51] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default - https://phabricator.wikimedia.org/T154534#2921918 (10MtDu) Thanks to the admin who published it! [00:26:50] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2921938 (10chelsyx) Done! :) https://wikimedia-research.github.io/Discovery-Search-2ndTest-BM25_jazhth/ [00:27:41] 10MediaWiki-History-or-Diffs: Diff highlights some changes in bold, but not all - https://phabricator.wikimedia.org/T152921#2921940 (10scfc) Another example (https://wikitech.wikimedia.org/w/index.php?title=Nova_Resource%3ATools%2FRules&type=revision&diff=1267829&oldid=284098): {F5239182} [00:28:41] 07Design, 06Discovery, 10Reading-UX-Research, 10Wikimedia-Portals, and 4 others: [EPIC] Wikipedia.org Portal: add app download badge - https://phabricator.wikimedia.org/T135441#2921941 (10debt) Based on the results the long term test of the addition of the Wikipedia / Wikimedia app links to the [[ https://... [00:28:56] (03CR) 10TTO: [C: 032] Update Maintenance scripts to use $this->requireExtension() [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/330827 (https://phabricator.wikimedia.org/T152139) (owner: 10Georggi199) [00:29:44] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia/Wikimedia apps availability test: analyze results - https://phabricator.wikimedia.org/T146807#2921962 (10debt) Thanks for the updated numbers! I've requested that we start track... [00:30:21] (03Merged) 10jenkins-bot: Update Maintenance scripts to use $this->requireExtension() [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/330827 (https://phabricator.wikimedia.org/T152139) (owner: 10Georggi199) [00:31:48] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: Wikipedia.org Portal: (concern about) adding app download badge - suggestions for postponing - https://phabricator.wikimedia.org/T138878#2921969 (10debt) Based on the results the long term test (T135441) of the addition of the Wikipedia / Wikimedia... [00:32:51] 07Design, 06Discovery, 10Reading-UX-Research, 10Wikimedia-Portals, and 4 others: [EPIC] Wikipedia.org Portal: add app download badge - https://phabricator.wikimedia.org/T135441#2298891 (10debt) [00:32:54] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: Wikipedia.org Portal: (concern about) adding app download badge - suggestions for postponing - https://phabricator.wikimedia.org/T138878#2921990 (10debt) 05Open>03declined [00:32:59] (03CR) 10Dbrant: Echo notifications for description edits. (0317 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [00:35:27] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: Wikipedia.org Portal: (concern about) adding app download badge - availability at known locations for download (walled garden) - https://phabricator.wikimedia.org/T138877#2921992 (10debt) 05Open>03declined With the comments below (from T135441)... [00:35:29] 07Design, 06Discovery, 10Reading-UX-Research, 10Wikimedia-Portals, and 4 others: [EPIC] Wikipedia.org Portal: add app download badge - https://phabricator.wikimedia.org/T135441#2298963 (10debt) [00:37:51] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: Wikipedia.org Portal: (concern about) adding app download badge - display location on the page - https://phabricator.wikimedia.org/T138876#2922017 (10debt) 05Open>03declined With the comments below (from T135441) and the earlier comments in thi... [00:37:53] 07Design, 06Discovery, 10Reading-UX-Research, 10Wikimedia-Portals, and 4 others: [EPIC] Wikipedia.org Portal: add app download badge - https://phabricator.wikimedia.org/T135441#2299280 (10debt) [00:38:18] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia/Wikimedia apps availability test: analyze results - https://phabricator.wikimedia.org/T146807#2922027 (10debt) 05Open>03Resolved [00:38:20] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia.org Portal Test: add information for Wikipedia / Wikimedia apps availablity - https://phabricator.wikimedia.org/T137495#2922029 (10debt) [00:39:52] 10MediaWiki-extensions-OATHAuth, 06Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10iOS-app-feature-Login, and 2 others: Update login interface - https://phabricator.wikimedia.org/T150985#2803668 (10JMinor) Thanks @Mhurd. I created subtasks based on this breakdown and put them into Needs Sync. For 2FA specific... [00:40:44] 07Design, 06Discovery, 10Reading-UX-Research, 10Wikimedia-Portals, and 4 others: [EPIC] Wikipedia.org Portal: add app download badge - https://phabricator.wikimedia.org/T135441#2922056 (10debt) [00:40:46] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia.org Portal Test: add information for Wikipedia / Wikimedia apps availablity - https://phabricator.wikimedia.org/T137495#2922049 (10debt) 05Open>03Resolved Closing this ticket as successfully completed. Here are c... [00:47:10] 06WMF-NDA-Requests: Volunteer NDA for zhuyifei1999 - https://phabricator.wikimedia.org/T154641#2922082 (10zhuyifei1999) >>! In T154641#2919999, @Aklapper wrote: > I've made @zhuyifei1999 a member of #WMF-NDA-Requests. @zhuyifei1999 should be able to sign L2 now. Thanks. Done. [00:53:50] 10MediaWiki-General-or-Unknown, 10Flow, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2922105 (10jmatazzoni) [00:54:14] 10MediaWiki-Special-pages, 10Thanks, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 13Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#2922107 (10jmatazzoni) [00:55:29] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): VisualEditor: License text in save dialog is light gray, giving it a 'disabled' appearance - https://phabricator.wikimedia.org/T52904#2922113 (10Jdforrester-WMF) [01:03:14] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2827539 (10Johan) @jcrespo Thanks, I'll include it in the next issue (delivered on... [01:09:04] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2922145 (10Volker_E) [01:21:00] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2922168 (10jmatazzoni) [01:25:25] 10MediaWiki-Codesniffer: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#2922176 (10Samwilson) [01:26:31] 10MediaWiki-extensions-LiquidThreads, 06Collaboration-Team-Triage, 10Flow, 07Regression: LiquidThreads page throws exception during conversion - https://phabricator.wikimedia.org/T146437#2922190 (10jmatazzoni) [01:27:09] 04(no projects): Exception in thread "Ruby-0-Thread-18: /opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.20/lib/stud/buffer.rb:92" java.lang.UnsupportedOperationException - https://phabricator.wikimedia.org/T154732#2922192 (10bd808) [01:27:51] (03PS1) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [01:28:44] (03CR) 10Krinkle: "See I8be497 in core." [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/325589 (https://phabricator.wikimedia.org/T152030) (owner: 10Ottomata) [01:29:09] (03CR) 10Krinkle: "See I8be497c623c5 in core." [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/325589 (https://phabricator.wikimedia.org/T152030) (owner: 10Ottomata) [01:29:42] (03PS2) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [01:30:16] 04(no projects): Exception in thread "Ruby-0-Thread-18: /opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.20/lib/stud/buffer.rb:92" java.lang.UnsupportedOperationException - https://phabricator.wikimedia.org/T154732#2922215 (10bd808) This is the same stacktrace we saw on logstash1001 in T154388 [01:30:30] 10Wikimedia-Logstash: Exception in thread "Ruby-0-Thread-18: /opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.20/lib/stud/buffer.rb:92" java.lang.UnsupportedOperationException - https://phabricator.wikimedia.org/T154732#2922217 (10bd808) [01:32:41] 07Design, 06Collaboration-Team-Triage, 10Edit-Review-Improvements: Explore ideas for Contribution review - https://phabricator.wikimedia.org/T138939#2922224 (10jmatazzoni) [01:33:25] (03PS3) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [01:33:54] (03PS4) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [01:34:44] 10MediaWiki-Codesniffer: Release v0.8.0 - https://phabricator.wikimedia.org/T154715#2922243 (10Samwilson) [01:34:45] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#2922242 (10Samwilson) [01:34:56] 10Wikimedia-Logstash: Exception in thread "Ruby-0-Thread-18: /opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.20/lib/stud/buffer.rb:92" java.lang.UnsupportedOperationException - https://phabricator.wikimedia.org/T154732#2922244 (10Paladox) Could be related https://github.com/elastic/logstash/issues/3400 Caus... [01:36:25] 07Design, 10MediaWiki-extensions-InputBox: Can't tell what's a button in search forms (mw-inputbox-input and mw-ui-button look identical) - https://phabricator.wikimedia.org/T131810#2922245 (10kaldari) Cool. Thanks for fixing it! I hope one day we can get over this flat ultra-minimalist design fad that... [01:39:41] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 (owner: 10Krinkle) [01:40:52] (03PS5) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [01:42:35] 10MediaWiki-Codesniffer: Release v0.8.0 - https://phabricator.wikimedia.org/T154715#2921575 (10Samwilson) Not that it's related, but in testing the upgrade to 2.7.1 I came across T154731, which should probably be merged before a new release (if it's valid). [01:44:28] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2922253 (10Tgr) Maybe "//Due to a [[https://bugzilla.mozilla.org/show_bug.cgi?id=13... [01:44:59] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 (owner: 10Krinkle) [01:45:47] (03PS6) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [01:45:49] 10MediaWiki-Codesniffer: Release v0.8.0 - https://phabricator.wikimedia.org/T154715#2922254 (10Paladox) yes, thanks, we should merge your change + the phpcs upgrade at the same time. Thanks for testing it. [01:48:02] 10Wikimedia-Logstash: Exception in thread "Ruby-0-Thread-18: /opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.20/lib/stud/buffer.rb:92" java.lang.UnsupportedOperationException - https://phabricator.wikimedia.org/T154732#2922255 (10Paladox) Could the LS_HEAP_SIZE need increasing? [01:48:51] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2922260 (10Daniel_Mietchen) That workaround does not work for me - my about:config... [01:51:17] 07Design, 10MediaWiki-extensions-InputBox: Can't tell what's a button in search forms (mw-inputbox-input and mw-ui-button look identical) - https://phabricator.wikimedia.org/T131810#2179160 (10Isarra) >>! In T131810#2920363, @Volker_E wrote: > After https://phabricator.wikimedia.org/rMW673f6f2e9d3d1a357a67e921... [01:52:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 (owner: 10Krinkle) [01:52:28] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2922265 (10Daniel_Mietchen) >>! In T151770#2922253, @Tgr wrote: > Maybe "//Due to a... [01:54:27] 06Discovery, 06Discovery-Analysis (Current work), 13Patch-For-Review: Portal dashboard: Mexico shouldn't be listed as being in South America - https://phabricator.wikimedia.org/T153716#2888339 (10mpopov) On beta: http://discovery-beta.wmflabs.org/portal/#all_country Will be deployed to production tomorrow o... [01:54:37] 06Discovery, 06Discovery-Analysis (Current work), 13Patch-For-Review: Portal dashboard heading "No. Events by Country" could be clearer - https://phabricator.wikimedia.org/T153715#2888324 (10mpopov) On beta: http://discovery-beta.wmflabs.org/portal/#all_country Will be deployed to production tomorrow or ear... [01:54:51] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 07Epic, 13Patch-For-Review: [EPIC] Wikipedia Portal Dashboard: expand "other" countries data display - https://phabricator.wikimedia.org/T138107#2922271 (10mpopov) On beta: http://discovery-beta.wmflabs.org/portal/#all_country Will b... [01:58:37] 06Discovery, 06Discovery-Analysis (Current work), 07Epic: [EPIC] Detect bots from searches (and learn C++/Rcpp) - https://phabricator.wikimedia.org/T149440#2922278 (10mpopov) @TJones, @chelsyx, and I discussed this today and we're starting to think it would be more useful to instead classify users as "typica... [02:02:09] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#2922281 (10Samwilson) I've found some other errors of a similar type. Will send new patch. [02:02:19] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#2922282 (10Samwilson) p:05Triage>03Normal [02:02:24] (03PS7) 10Mooeypoo: [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) [02:02:33] (03PS5) 10Kaldari: Adding support for task forces to the assessment processing code [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/330185 (https://phabricator.wikimedia.org/T154216) [02:02:46] (03CR) 10jerkins-bot: [V: 04-1] [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) (owner: 10Mooeypoo) [02:02:48] (03CR) 10jerkins-bot: [V: 04-1] Adding support for task forces to the assessment processing code [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/330185 (https://phabricator.wikimedia.org/T154216) (owner: 10Kaldari) [02:04:05] (03Abandoned) 10Mooeypoo: [wip] RecentChanges Dynamic Filters [extensions/ORES] - 10https://gerrit.wikimedia.org/r/319251 (https://phabricator.wikimedia.org/T144448) (owner: 10Mooeypoo) [02:04:23] 06Developer-Relations (Jan-Mar-2017), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2922287 (10Thatwhichendureth) [02:04:55] 06Developer-Relations (Jan-Mar-2017), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2544589 (10Thatwhichendureth) [02:05:12] 06Developer-Relations (Jan-Mar-2017), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2544589 (10Thatwhichendureth) [02:05:33] (03PS4) 10Kaldari: Add database support for subprojects [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/329386 (https://phabricator.wikimedia.org/T154216) [02:05:35] (03PS6) 10Kaldari: Adding support for task forces to the assessment processing code [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/330185 (https://phabricator.wikimedia.org/T154216) [02:07:02] 06Developer-Relations (Jan-Mar-2017), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2922290 (10Thatwhichendureth) [02:07:10] (03CR) 10jerkins-bot: [V: 04-1] Adding support for task forces to the assessment processing code [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/330185 (https://phabricator.wikimedia.org/T154216) (owner: 10Kaldari) [02:07:11] (03PS7) 10Krinkle: [WIP] Refactor RCFeed configuration (backwards compatible) [core] - 10https://gerrit.wikimedia.org/r/330833 [02:09:41] (03PS8) 10Mooeypoo: [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) [02:11:41] 06Developer-Relations (Jan-Mar-2017), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2922292 (10Thatwhichendureth) [02:14:54] 10Internet-Archive, 10InternetArchiveBot: Unable to modify URL via UI - https://phabricator.wikimedia.org/T154734#2922294 (10Green_Cardamom) a:03Cyberpower678 [02:15:26] (03PS1) 10Niedzielski: New: add last 5 days of pageviews to most-read response [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330836 (https://phabricator.wikimedia.org/T148445) [02:18:09] (03CR) 10jerkins-bot: [V: 04-1] [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) (owner: 10Mooeypoo) [02:25:13] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox, 07Upstream, 07User-notice: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2922330 (10Tgr) >>! In T151770#2922260, @Daniel_Mietchen wrote: > That workaround d... [02:30:22] (03PS7) 10Kaldari: Adding support for task forces to the assessment processing code [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/330185 (https://phabricator.wikimedia.org/T154216) [02:34:46] (03PS9) 10Mooeypoo: [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) [02:47:04] (03CR) 10Krinkle: Avoid master queries when old filter checks are viewed (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/330466 (https://phabricator.wikimedia.org/T154554) (owner: 10Aaron Schulz) [02:51:02] 10MediaWiki-extensions-TranslationNotifications, 06Collaboration-Team-Triage, 10Flow: Use server-side MessagePoster in TranslationNotifications - https://phabricator.wikimedia.org/T154736#2922333 (10Mattflaschen-WMF) [02:52:02] 10MediaWiki-General-or-Unknown, 10Flow, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#1931581 (10Mattflaschen-WMF) [02:52:12] (03CR) 10Awu42: "How do I commit edits in the Video extension? git status doesn't check for changes in extensions/Video." [core] - 10https://gerrit.wikimedia.org/r/330594 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [02:53:04] (03CR) 10Mattflaschen: "> I thought it would also be needed for PageTriage, but it turns out that just needed client-side MessagePoster. I expect more future use" [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [02:53:50] (03CR) 10TTO: "> How do I commit edits in the Video extension? git status doesn't" [core] - 10https://gerrit.wikimedia.org/r/330594 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [02:54:06] 10MediaWiki-extensions-TranslationNotifications, 06Collaboration-Team-Triage, 10Flow: Use server-side MessagePoster in TranslationNotifications to fix Flow - https://phabricator.wikimedia.org/T154736#2922350 (10Mattflaschen-WMF) [02:56:01] 10MediaWiki-extensions-TranslationNotifications, 06Collaboration-Team-Triage, 10Flow: Use server-side MessagePoster in TranslationNotifications to fix Flow - https://phabricator.wikimedia.org/T154736#2922333 (10Mattflaschen-WMF) [02:56:11] (03CR) 10MtDu: "@awu42, Please see https://www.mediawiki.org/wiki/Gerrit/Getting_started for more information. Use git commit --all --amend in this case t" [core] - 10https://gerrit.wikimedia.org/r/330594 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [02:56:52] 10InternetArchiveBot (v1.3): InternetArchiveBot mishandles refs that have names that look like URLs - https://phabricator.wikimedia.org/T151183#2922354 (10Cyberpower678) 05Open>03Resolved This has been fixed in v1.3. [02:57:37] (03PS6) 10Krinkle: Include JS variable for NewPP report [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:00:13] (03PS7) 10Krinkle: Include JS variable for NewPP report [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:01:47] (03PS8) 10Krinkle: Include JS variable for NewPP report [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:04:42] (03PS10) 10Krinkle: Avoid races in MessageCache::replace() [core] - 10https://gerrit.wikimedia.org/r/318489 (https://phabricator.wikimedia.org/T144952) (owner: 10Aaron Schulz) [03:10:10] (03CR) 10Krinkle: [C: 032] "LGTM. Verified with PerformanceInspector." [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:12:23] (03PS9) 10Krinkle: Include JS variable for NewPP report [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:17:49] (03CR) 10Krinkle: [C: 032] "Added release notes." [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:22:58] (03PS12) 10Krinkle: [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) [03:28:00] (03Merged) 10jenkins-bot: Include JS variable for NewPP report [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:30:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [03:39:57] (03CR) 10jenkins-bot: Include JS variable for NewPP report [core] - 10https://gerrit.wikimedia.org/r/320861 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [03:42:44] 10MediaWiki-Database: Need for further link table in page DB - https://phabricator.wikimedia.org/T154666#2922389 (10PerfektesChaos) 05Open>03Resolved a:03PerfektesChaos Oooops, I just detected ##iwlinks## containing not only local but also //"prefix": "doi"// information and is available via API, too; that... [03:48:09] 10ArchCom-RfC, 07RfC: RFC: Accessing page properties from wiki pages - https://phabricator.wikimedia.org/T154738#2922393 (10MZMcBride) [03:50:12] 10ArchCom-RfC, 07RfC: RFC: Accessing page properties from wiki pages - https://phabricator.wikimedia.org/T154738#2922409 (10MZMcBride) I'd like to meet to discuss the options listed on the wiki page and any other ideas that would resolve the linked tasks. [03:50:37] 10Internet-Archive, 07Chinese-Sites, 07Tracking: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130#2922411 (10Shizhao) [03:51:14] 10MediaWiki-Database: Need for further link table in page DB - https://phabricator.wikimedia.org/T154666#2922412 (10PerfektesChaos) Reaason might have been that [[https://www.mediawiki.org/wiki/Special:PermaLink/1958914?title=API:Iwlinks | mw:API:Iwlinks]] tells “to get for each //interlanguage// link” but thes... [03:52:30] 10MediaWiki-extensions-Translate: Special:Translate fails to save translations on testwiki - https://phabricator.wikimedia.org/T153418#2922413 (10TTO) >>! In T153418#2886973, @Nikerabbit wrote: > The page is not known as translatable page. Translate is clearly enabled on https://test.wikipedia.org/wiki/Translat... [03:53:08] (03PS1) 10Awu42: Replaced usage of Linker::getLinkAttributesInternal [extensions/Video] - 10https://gerrit.wikimedia.org/r/330840 (https://phabricator.wikimedia.org/T61113) [03:54:28] (03CR) 10Awu42: "I have no idea if I did this right: https://gerrit.wikimedia.org/r/330840" [core] - 10https://gerrit.wikimedia.org/r/330594 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [03:55:40] 10MediaWiki-extensions-Newsletter, 10Security-Reviews, 06Security-Team: Security review of Newsletter extension - https://phabricator.wikimedia.org/T115095#2922416 (10MZMcBride) The rewrite to use ContentHandler may be significant enough to require a new security review. I guess that would be up to @dpatrick... [04:01:50] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: Wikipedia.org Portal: (concern about) adding app download badge - availability at known locations for download (walled garden) - https://phabricator.wikimedia.org/T138877#2922421 (10MZMcBride) Have the various concerns raised at 10MediaWiki-extensions-ContentTranslation: Can't adapt infobox (or other template): Uncaught TypeError: Cannot set property 'wt' of undefined - https://phabricator.wikimedia.org/T154739#2922422 (10KartikMistry) [04:04:04] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work): Wikipedia.org: add app links to Portal dashboard - https://phabricator.wikimedia.org/T154634#2918375 (10MZMcBride) I posted this question at T138877#2922421 before realizing that there are many Maniphest tasks about portal concerns in the... [04:05:18] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work): Wikipedia.org: add app links to Portal dashboard - https://phabricator.wikimedia.org/T154634#2922439 (10MZMcBride) Oh, nope, this task is about the portal dashboard. I want {T135441}, I think. [04:05:52] 07Design, 06Discovery, 10Reading-UX-Research, 10Wikimedia-Portals, and 4 others: [EPIC] Wikipedia.org Portal: add app download badge - https://phabricator.wikimedia.org/T135441#2299350 (10MZMcBride) Third time's the charm. Have the various concerns raised at https://www.mediawiki.org/wiki/Talk:Wikipedia.o... [04:08:15] 10Phabricator (Upstream), 07Upstream: Task description diffs sometimes don't show all changes - https://phabricator.wikimedia.org/T154667#2922442 (10Jay8g) Even stranger: {F5240215} {F5240216} It's as if that text is completely missing in the diff view... [04:12:19] 10InternetArchiveBot (v1.3): InternetArchiveBot inserted a redundant copy of already-archived link into a reference - https://phabricator.wikimedia.org/T151185#2922449 (10Cyberpower678) 05Open>03Invalid I am unable to replicate this bug. If it does happen on again on the current version, please re-report. [04:15:19] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2922466 (10MZMcBride) Hi @Opabinia_regalis and @Stevietheman. >>! In T11790#1799601, @Quiddity wrote: > (IIUC) What is //actually// wanted, is a preference... [04:30:53] 10UI-Standardization: Delete or re-create mwui.wmflabs.org - https://phabricator.wikimedia.org/T154616#2922486 (10Prtksxna) I think we can delete it. [04:33:27] 07Design, 10Wikimedia-General-or-Unknown: WMF logo in wikimedia.org should be moved to the footer - https://phabricator.wikimedia.org/T41842#2922487 (10MZMcBride) I don't think this task is resolved, but I'll leave it to @waldyrious to re-open if he'd like. [04:40:40] 10MediaWiki-Internationalization, 06Language-Team, 07I18n: Add dz, ja, ko, my, ps, ur, and zh to IcuCollation::$tailoringFirstLetters - https://phabricator.wikimedia.org/T154510#2922508 (10Bawolff) To be clear, when I said complicated, I meant would take me more than 30 seconds to figure out - so it may not... [04:58:38] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments: Setup new Labs instance for CX - https://phabricator.wikimedia.org/T154740#2922534 (10KartikMistry) [05:04:13] andre__: Hey ! I have marked my upload for deletion : https://commons.wikimedia.org/wiki/File:Creating_Tasks_In_Phabricator.webm [05:05:58] andre__: I have edited my video to add project and a short description and I have uploaded it as the new version of the old video : https://commons.wikimedia.org/wiki/File:Explanation_on_creating_a_task.webm [05:11:49] Deleted. [05:12:34] But then, we downsample the resolution from 1,920 × 1,080 to 1280x720 :/ [05:12:57] ooooooooooops [05:13:03] * Dereckson restore [05:13:19] The two videos have a different content. In such case, Commons policy is to keep both. [05:13:21] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 07Epic, 13Patch-For-Review: [EPIC] Wikipedia Portal Dashboard: expand "other" countries data display - https://phabricator.wikimedia.org/T138107#2922565 (10chelsyx) Thank you @mpopov !!! [05:14:49] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Unclear which rectangle is being annotated - https://phabricator.wikimedia.org/T154742#2922566 (10Prtksxna) [05:17:29] andre__: so if you wish to use the new video, please use https://commons.wikimedia.org/wiki/File:Creating_Tasks_In_Phabricator.webm as URL and update https://www.mediawiki.org/wiki/Phabricator/Help pages [05:19:21] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Add annotation button takes up too much attention - https://phabricator.wikimedia.org/T154743#2922583 (10Prtksxna) [05:21:28] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Experiment with images and text in the annotation list below the image - https://phabricator.wikimedia.org/T154744#2922598 (10Prtksxna) [05:24:30] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Annotations show and hide erratically - https://phabricator.wikimedia.org/T154745#2922615 (10Prtksxna) [05:25:29] (03CR) 10VolkerE: [C: 04-1] "@Isarra I'm definitely for this change to align to the color palette for consistency. Still, users are very sensitive to color/visual chan" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 (https://phabricator.wikimedia.org/T153049) (owner: 10Ladsgroup) [05:26:02] (03CR) 10TTO: [C: 032] "Tested." [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [05:27:28] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Use crosshair cursor when asking the user to draw a rectangle - https://phabricator.wikimedia.org/T154746#2922635 (10Prtksxna) [05:29:04] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2922650 (10Volker_E) @Legoktm @siebrand @bd808 Any inputs on the importance of coloring “yes“ or the priority of t... [05:31:54] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Search: Guide user during empty state - https://phabricator.wikimedia.org/T154747#2922652 (10Prtksxna) [05:32:45] (03Abandoned) 10TTO: Remove WikiRevision::getText() [core] - 10https://gerrit.wikimedia.org/r/326193 (owner: 10MtDu) [05:34:32] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Search: In the universal search, collapse the same concepts together - https://phabricator.wikimedia.org/T154748#2922667 (10Prtksxna) [05:34:46] (03Merged) 10jenkins-bot: Add tagging support to imagerotate, revisiondelete, and tag API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [05:37:17] 10UI-Standardization: Delete or re-create mwui.wmflabs.org - https://phabricator.wikimedia.org/T154616#2922683 (10Volker_E) It seems, I've mixed those up with http://tools.wmflabs.org/styleguide/ which also still exists. @Prtksxna what I was actually intending in my question if there is any public instance left... [05:37:59] 10UI-Standardization: Delete or re-create mwui.wmflabs.org - https://phabricator.wikimedia.org/T154616#2922684 (10Volker_E) @Mattflaschen-WMF And yes, let's delete this one. [05:39:06] (03CR) 10TTO: "We kind of already did this refactoring in I42e74ed3bcd0bfa9ec0c344ba67668210450c975... I didn't know this patch was here." [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [05:39:29] (03CR) 10TTO: "The API now includes this check, so it would be nice to have consistency in the UI." [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05) [05:41:11] 10UI-Standardization, 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2922685 (10Volker_E) 05Open>03Resolved a:03Pginer-WMF I think we can resolve this… bold stays bold. [05:45:54] (03CR) 10jenkins-bot: Add tagging support to imagerotate, revisiondelete, and tag API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [05:57:18] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#2922689 (10Samwilson) I'm getting different results for the same file when running it as part of a whole set of directories vs running it ju... [06:03:36] (03CR) 10Isarra: [C: 031] "Do you have an actual reason why this is bad, or are you just blocking this because you want everything to be perfect and don't think incr" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 (https://phabricator.wikimedia.org/T153049) (owner: 10Ladsgroup) [06:09:52] Hey Volker_E o/ [06:18:32] (03PS2) 10Awu42: Removed deprecated Linker functions [core] - 10https://gerrit.wikimedia.org/r/330594 (https://phabricator.wikimedia.org/T61113) [06:23:33] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2867522 (10Isarra) Some info on what this actually is: Forward: setting to allow chaining interwikis together lik... [06:38:18] (03CR) 10TTO: [C: 04-1] "I imported all of enwiki's tags and MediaWiki:Tag-* messages into my local test installation, and it worked a treat." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [06:39:54] 10MediaWiki-Internationalization, 06Language-Team, 07Chinese-Sites, 07I18n: Add dz, ja, ko, my, ps, ur, and zh to IcuCollation::$tailoringFirstLetters - https://phabricator.wikimedia.org/T154510#2922694 (10Shizhao) [06:45:04] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 07Chinese-Sites: Change ZhConversion conversion tables to JSON - https://phabricator.wikimedia.org/T129499#2922695 (10Shizhao) [06:50:19] 10AbuseFilter: AbuseFilter needs a better tag selection UI - https://phabricator.wikimedia.org/T154749#2922698 (10TTO) [06:50:42] 10MobileFrontend, 06Reading-Web-Backlog, 07Mobile, 07Regression: Mobile mentions should lead to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922715 (10Dvorapa) [06:52:32] 10MobileFrontend, 06Reading-Web-Backlog, 07Mobile, 07Regression: Mobile mentions should lead to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922715 (10Dvorapa) [06:53:04] 10MobileFrontend, 06Reading-Web-Backlog, 07Mobile, 07Regression: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922729 (10Dvorapa) [06:55:31] 10MediaWiki-Internationalization, 10MediaWiki-Language-converter, 07Chinese-Sites: New API change has a pending question about language variants - https://phabricator.wikimedia.org/T47376#2922730 (10Shizhao) [06:55:34] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#2922731 (10Samwilson) Sad to say I've not figured it out, but I've uploaded a patch that does fix it. (The worst sort of patch, I know.) Se... [07:07:31] 10MediaWiki-Internationalization, 03Google-Code-In-2016: Create a {{PAGELANGUAGE}} magic word - https://phabricator.wikimedia.org/T59603#607273 (10Psychoslave) Actually, you might have several languages in the same sentence. For example in this [Esperanto translation of the Perligata paper](https://beta.wikive... [07:16:48] 10CirrusSearch, 06Discovery, 06Discovery-Search: Timeout even if not complicated regex query - https://phabricator.wikimedia.org/T154751#2922743 (10Dvorapa) [07:21:29] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: No indication on how to edit/undo the annotation that was just addded - https://phabricator.wikimedia.org/T154752#2922756 (10Prtksxna) [07:22:55] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 2: Floating green button is confusing and non-standard - https://phabricator.wikimedia.org/T154753#2922771 (10Prtksxna) [07:25:27] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Search: Show smart suggestions befor the user types a query - https://phabricator.wikimedia.org/T154754#2922786 (10Prtksxna) [07:29:47] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotation prototype 1: Consider changing the part of the image that the user annotates - https://phabricator.wikimedia.org/T154755#2922801 (10Prtksxna) [07:30:17] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotation prototype 1: Consider changing the part of the image that the user annotates - https://phabricator.wikimedia.org/T154755#2922816 (10Prtksxna) [07:32:58] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Confusion in the modes/states of the extension - https://phabricator.wikimedia.org/T154756#2922817 (10Prtksxna) [07:39:44] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2922832 (10QuimGil) Very good! After a first read, the only big question mark I have is that "User rights" section in the middle of the instructions. If... [07:41:50] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: The wikitext button doesn't explain what its for - https://phabricator.wikimedia.org/T154757#2922833 (10Prtksxna) [07:52:58] 10MediaWiki-Internationalization, 03Google-Code-In-2016: Create a {{PAGELANGUAGE}} magic word - https://phabricator.wikimedia.org/T59603#2922849 (10TTO) >>! In T59603#2922741, @Psychoslave wrote: > Actually, you might have several languages in the same sentence. This task is asking for a magic word/variable... [09:05:55] buffer 11 [09:08:45] 10MobileFrontend, 06Reading-Web-Backlog, 07Mobile, 07Regression: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922881 (10phuedx) @Dvorapa: Thanks for the bug report! --- While the experience isn't broken, it's not the most performant: tapping... [09:09:39] 10MediaWiki-Internationalization, 03Google-Code-In-2016: Create a {{PAGELANGUAGE}} magic word - https://phabricator.wikimedia.org/T59603#2922894 (10Psychoslave) Actually, as far I as can see, for translation units, content with several language should be a problem. But maybe others might see some problems I'm... [09:10:10] FlorianSW: Are you here? [09:10:16] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [09:10:16] @notify FlorianSW [09:12:56] 07Design, 06Collaboration-Team-Triage, 10Notifications: Reduce usage of red icon in Echo (use other colors) - https://phabricator.wikimedia.org/T57359#2922900 (10Pginer-WMF) 05Open>03Resolved a:03Pginer-WMF >>! In T57359#2920893, @Volker_E wrote: > @Pginer-WMF Still an issue…? Thanks for catching this... [09:13:34] 07Design, 06Collaboration-Team-Triage, 10Notifications: Reduce usage of red icon in Echo (use other colors) - https://phabricator.wikimedia.org/T57359#2922907 (10Pginer-WMF) [09:18:40] (03CR) 10Phuedx: [C: 031] "This LGTM but I haven't yet tested it locally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/330812 (owner: 10Mholloway) [09:21:38] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Actions to grow the diversity of our technical community - https://phabricator.wikimedia.org/T148598#2922922 (10Psychoslave) Thank you @cscott for your feedback. I fail to see what you might be suggesting, if anything, wi... [09:26:01] 10MediaWiki-Internationalization, 13Patch-For-Review: missing language code uz-latn - https://phabricator.wikimedia.org/T44397#2922931 (10Liuxinyu970226) [09:32:11] hi all. how can i checkout changes from gerrit? $git review --download gives me a 404 error (/changes/ not found) [09:35:33] mschwarzer, have you run git review -s ? Have you checked that the URLs in git remote -v are correct? [09:35:40] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Unclear which rectangle is being annotated - https://phabricator.wikimedia.org/T154742#2922938 (10Prtksxna) Fade out other rectangles when the mouse is over one particular one |Without fade|With fade| |--|--| |{F5240940}|{F5240942}| [09:37:12] mschwarzer, https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 [09:37:38] so I'd say you're doing it right, hmm. [09:39:30] i'm just using the vagrant vm, so i guess everything should be correctly setup. $git remote -v: origin https://gerrit.wikimedia.org/r/p/mediawiki/extensions/CirrusSearch.git (fetch) ... [09:40:19] which change ID? I wonder if I can reproduce [09:40:35] from this review: https://gerrit.wikimedia.org/r/#/c/329626/ [09:41:11] both 329626 and I7525eef60c60ce747d194321c552a3df22d96d8f aren't working [09:41:27] Yeah. Can reproduce. [09:41:48] $:a\> git review --download 329629 [09:41:48] Cannot query patchset information [09:41:52] The following command failed with exit code 104 [09:41:52] "GET https://gerrit.wikimedia.org/changes/?q=329629&o=CURRENT_REVISION" [09:42:11] mschwarzer: you've lost the local repo that you used to push your change? [09:42:37] yes [09:43:17] I'd suggest switching to ssh remotes, I encoutered issues that I could not explain when something changed in the .gitreview config few months ago [09:46:27] It looks like the latest Gerrit update broke things? [09:48:46] 10UI-Standardization, 03UI-Standardization-Kanban: Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component - https://phabricator.wikimedia.org/T127405#2922972 (10Pginer-WMF) >>! In T127405#2920531, @Volker_E wrote: > Another one in Flow using the color that sho... [09:49:36] dcausse: thanks. ssh remotes work! [09:51:04] (03Restored) 10Hashar: Jenkins test [search/highlighter] - 10https://gerrit.wikimedia.org/r/330661 (owner: 10Hashar) [09:51:08] (03CR) 10Hashar: "recheck" [search/highlighter] - 10https://gerrit.wikimedia.org/r/330661 (owner: 10Hashar) [09:52:51] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Add annotation button takes up too much attention - https://phabricator.wikimedia.org/T154743#2922976 (10Prtksxna) [09:52:53] (03PS3) 10Phuedx: API: Make empty pageprops array associative [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/330812 (owner: 10Mholloway) [09:53:19] (03CR) 10jerkins-bot: [V: 04-1] Jenkins test [search/highlighter] - 10https://gerrit.wikimedia.org/r/330661 (owner: 10Hashar) [09:54:05] (03CR) 10Phuedx: [C: 031] "I updated a test for Page.newFromJSON, which inspects the value of the pageprops property." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/330812 (owner: 10Mholloway) [09:55:46] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Experiment with images and text in the annotation list below the image - https://phabricator.wikimedia.org/T154744#2922984 (10Prtksxna) [09:57:11] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: "Register" newsletters instead of "Create" - https://phabricator.wikimedia.org/T154761#2922998 (10QuimGil) [09:57:43] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Annotations show and hide erratically - https://phabricator.wikimedia.org/T154745#2923011 (10Prtksxna) I am having trouble with Hype and the mouse in and out events. They seem to not be triggering in order and causing behavior. Can't see... [09:57:50] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2923012 (10JEumerus) @MZMcBride : Point #1 is right. Point #2 would need a bit more discussion, especially about whether "revert" means "any revert" or just... [09:59:27] 10MediaWiki-Internationalization, 03Google-Code-In-2016: Create a {{PAGELANGUAGE}} magic word - https://phabricator.wikimedia.org/T59603#2923015 (10TTO) >>! In T59603#2922894, @Psychoslave wrote: > So, probably the most interesting thing here regarding this thread, is the {{#translation:}} magic word. I had a... [10:03:08] (03CR) 10Hashar: "recheck" [search/highlighter] - 10https://gerrit.wikimedia.org/r/330679 (owner: 10DCausse) [10:04:56] (03Abandoned) 10Hashar: Jenkins test [search/highlighter] - 10https://gerrit.wikimedia.org/r/330661 (owner: 10Hashar) [10:07:57] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Search: Guide user during empty state - https://phabricator.wikimedia.org/T154747#2923051 (10Prtksxna) [10:08:23] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Search: Guide user during empty state - https://phabricator.wikimedia.org/T154747#2922652 (10Prtksxna) Do we want to take this space to explain the full spectrum of what is possible with annotations or just help the user type something in... [10:10:53] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Annotations show and hide erratically - https://phabricator.wikimedia.org/T154745#2923064 (10Pginer-WMF) >>! In T154745#2923011, @Prtksxna wrote: > I am having trouble with Hype and the mouse in and out events. They seem to not be trigge... [10:12:33] 07Design, 10MediaWiki-extensions-Newsletter: Subscribe/Unsubscribe newsletter floating dialog disappears too soon - https://phabricator.wikimedia.org/T154763#2923065 (10QuimGil) [10:12:47] 07Design, 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Subscribe/Unsubscribe newsletter floating dialog disappears too soon - https://phabricator.wikimedia.org/T154763#2923077 (10QuimGil) [10:13:24] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: If a translation target title exists as a redirect, it should be shown as such - https://phabricator.wikimedia.org/T154764#2923078 (10Amire80) [10:14:08] 10CirrusSearch, 06Discovery, 06Discovery-Search, 10Elasticsearch: Make elasticsearch more resilient to small network hiccups - https://phabricator.wikimedia.org/T154765#2923090 (10dcausse) [10:14:49] 07Design, 06Community-Liaisons, 10Wikimedia-Developer-Summit (2017): Discuss creating a UI/UX design hub - https://phabricator.wikimedia.org/T154545#2923103 (10Aklapper) @Moushira: So please feel free to do it? :) [10:17:26] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype 1: Annotations show and hide erratically - https://phabricator.wikimedia.org/T154745#2923113 (10Prtksxna) I am pretty sure I tried that. Will attempt again on an empty project to make sure that something else that I am doing does not affect... [10:17:32] 06WMF-NDA-Requests: Volunteer NDA for Eranroz - https://phabricator.wikimedia.org/T154688#2923114 (10Aklapper) I've made @eranroz a member of #WMF-NDA-Requests. @eranroz should be able to sign L2 now. [10:20:40] 06WMF-NDA-Requests: Volunteer NDA for zhuyifei1999 - https://phabricator.wikimedia.org/T154641#2923120 (10Aklapper) Confirming that [[ https://phabricator.wikimedia.org/legalpad/signatures/2/ | zhuyifei1999 has signed L2 ]]. Next in https://wikitech.wikimedia.org/wiki/Volunteer_NDA is "Get sign off by a C-level... [10:20:46] 06WMF-NDA-Requests: Volunteer NDA for Quiddity - https://phabricator.wikimedia.org/T154628#2923121 (10Aklapper) Confirming that [[ https://phabricator.wikimedia.org/legalpad/signatures/2/ | Quiddity has signed L2 ]]. Next in https://wikitech.wikimedia.org/wiki/Volunteer_NDA is "Get sign off by a C-level staff of... [10:49:08] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Better code review processes for reviewers - https://phabricator.wikimedia.org/T149639#2923145 (10Aklapper) [10:55:18] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: ContentTranslation adapts references only partially in "Sonno negli animali" - https://phabricator.wikimedia.org/T99934#2923148 (10Effeietsanders) Confirmed, the bug is still there: references in translations are still very messy. Some problems... [10:58:09] 07Design, 10MobileFrontend: In MobileFrontend account creation form the "Go" button in mobile touch keyboards must not submit the form if the required fields aren't full - https://phabricator.wikimedia.org/T154767#2923150 (10Amire80) [11:05:20] 06WMF-NDA-Requests: Volunteer NDA for Eranroz - https://phabricator.wikimedia.org/T154688#2923162 (10eranroz) Signed. [11:06:44] (03PS1) 10Legoktm: libzim.pc: Add "Requires" field [openzim] - 10https://gerrit.wikimedia.org/r/330857 [11:09:28] (03CR) 10Legoktm: "OK, I submitted Change-Id: I0710aefa8f706067c5e6cb11c70da785c7956608 to add the "Requires: liblzma" line. It's unclear to me whether we sh" [openzim] - 10https://gerrit.wikimedia.org/r/329759 (owner: 10Legoktm) [11:09:39] (03CR) 10Legoktm: "There is some discussion about this on https://gerrit.wikimedia.org/r/#/c/329759/" [openzim] - 10https://gerrit.wikimedia.org/r/330857 (owner: 10Legoktm) [11:14:31] dcausse: in my cirrussearch review you said that i could access the elastic connection from $context, but how? from the feature class I don't see a way to access the current connection instance. i only could create a new instance. [11:16:04] 07Design, 10FileAnnotations, 06Multimedia: FileAnnotations prototype: Search: Guide user during empty state - https://phabricator.wikimedia.org/T154747#2923163 (10Pginer-WMF) >>! In T154747#2923051, @Prtksxna wrote: > Do we want to take this space to explain the full spectrum of what is possible with annotat... [11:17:41] mschwarzer: indeed I was wrong... you could probably get a Connection with Connection::getPool( $context->getConfig() ); [11:18:16] this is not idea but might work for now [11:18:22] *ideal [11:19:02] ok. thanks! [11:26:06] (03PS1) 10Legoktm: Support running tests with "make check" [openzim] - 10https://gerrit.wikimedia.org/r/330859 [11:27:01] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/330713 (owner: 10Umherirrender) [11:28:35] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/ParentPage] - 10https://gerrit.wikimedia.org/r/330711 (owner: 10Umherirrender) [11:28:56] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/Link_Attributes] - 10https://gerrit.wikimedia.org/r/330710 (owner: 10Umherirrender) [11:29:07] Should~/phabricator/arcanist/bin/arc be ~/phabricator/arcanist/bin in https://www.mediawiki.org/wiki/Phabricator/Arcanist#Using_git_.28recommended.29 [11:29:09] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/ImportArticles] - 10https://gerrit.wikimedia.org/r/330708 (owner: 10Umherirrender) [11:29:25] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use https when linking www.mediawiki.org [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/330706 (owner: 10Umherirrender) [11:29:41] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/330705 (owner: 10Umherirrender) [11:29:56] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use https when linking www.mediawiki.org [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/330704 (owner: 10Umherirrender) [11:30:09] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/330703 (owner: 10Umherirrender) [11:30:25] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Standarize desc message in qqq.json [extensions/Athena] - 10https://gerrit.wikimedia.org/r/330701 (owner: 10Umherirrender) [11:30:41] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/330713 (owner: 10Umherirrender) [11:30:43] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/ParentPage] - 10https://gerrit.wikimedia.org/r/330711 (owner: 10Umherirrender) [11:30:45] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/Link_Attributes] - 10https://gerrit.wikimedia.org/r/330710 (owner: 10Umherirrender) [11:30:47] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/ImportArticles] - 10https://gerrit.wikimedia.org/r/330708 (owner: 10Umherirrender) [11:30:49] (03Merged) 10jenkins-bot: Use https when linking www.mediawiki.org [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/330706 (owner: 10Umherirrender) [11:30:59] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/330705 (owner: 10Umherirrender) [11:31:19] (03Merged) 10jenkins-bot: Use https when linking www.mediawiki.org [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/330704 (owner: 10Umherirrender) [11:31:21] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/330703 (owner: 10Umherirrender) [11:31:23] (03Merged) 10jenkins-bot: Standarize desc message in qqq.json [extensions/Athena] - 10https://gerrit.wikimedia.org/r/330701 (owner: 10Umherirrender) [11:33:50] (03PS1) 10Legoktm: Provide time gap between uuid generation during tests [openzim] - 10https://gerrit.wikimedia.org/r/330861 [11:38:25] (03PS1) 10Nschaaf: Fix items query for related_articles [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/330862 [11:39:54] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "These messages are unused, as far as I can see. I can not find any code for a "csQueryChildCount" API module. Also see https://github.com/" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 (owner: 10Umherirrender) [11:41:03] 10MediaWiki-extensions-ContentTranslation, 06Language-Team, 07Easy, 07I18n, and 2 others: Restore icon should point backwards - https://phabricator.wikimedia.org/T128457#2923185 (10Pginer-WMF) >>! In T128457#2918588, @MtDu wrote: > Is this still a problem? @Pginer-WMF I'd be interested in learning how to d... [11:41:15] 10MediaWiki-extensions-ContentTranslation, 06Language-Team, 07Epic: Design polishing for Content Translation - https://phabricator.wikimedia.org/T127695#2923189 (10Pginer-WMF) [11:41:17] 10MediaWiki-extensions-ContentTranslation, 06Language-Team, 07Easy, 07I18n, and 2 others: Restore icon should point backwards - https://phabricator.wikimedia.org/T128457#2923187 (10Pginer-WMF) 05Open>03Resolved a:03Pginer-WMF [11:41:44] (03CR) 10Nschaaf: [C: 032] Fix items query for related_articles [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/330862 (owner: 10Nschaaf) [11:42:41] (03Merged) 10jenkins-bot: Fix items query for related_articles [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/330862 (owner: 10Nschaaf) [11:44:23] 10Recommendation-API: Create user interface for related articles recommendations - https://phabricator.wikimedia.org/T153443#2880597 (10schana) a:03schana [11:45:14] qgil: Around? [11:55:09] 10MediaWiki-Internationalization, 06Language-Team, 07I18n, 07Regression: Message overrides not working on no.wikibooks.org - https://phabricator.wikimedia.org/T151247#2923209 (10TTO) >>! In T151247#2883353, @Krinkle wrote: > * Also, until we hardcode something somewhere in wmf-config somehow, `deleteEqualM... [11:55:25] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2923210 (10MtDu) >>! In T154222#2922832, @QuimGil wrote: > Very good! After a first read, the only big question mark I have is that "User rights" sectio... [11:56:19] FlorianSW: Are you here? [11:58:35] rlot, He's probably at work, but there's a chance. :) [12:07:52] Dereckson: The two videos do NOT have a different content. [12:08:11] Dereckson: And I explicitly asked Subins2000 to upload a new version of the same file. [12:08:40] I see no sense in having outdated tutorial videos for UIs that do not exist anymore and having to manually update a link in a wiki page. [12:09:04] Refering to https://www.mediawiki.org/wiki/File:Explanation_on_creating_a_task.webm [12:10:34] Dereckson: so I'd like to revert your revert. [12:14:18] (03PS5) 10Blackspirit96: API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) [12:14:56] andre__: Thanks! You're awesome! [12:15:09] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2923217 (10Aklapper) Task on the GCI site approved as per Quim's comment in T154222#2923210. I'll leave it to Tony and Quim here in Phab to resolve or n... [12:15:42] rlot: I have not done much :P [12:22:27] andre__: I understand the concerns regarding having two videos on the same topic. However, commons has a guideline of https://commons.wikimedia.org/wiki/Commons:Overwriting_existing_files#Files_with_current_data [12:22:53] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default - https://phabricator.wikimedia.org/T154534#2923222 (10FilipGCI) a:03FilipGCI Will do it as GCI task [12:24:14] I think we can either use file redirects or apply {{current}} on the filepage [12:25:14] (03PS1) 10Nschaaf: (in progress) generic UI [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/330868 (https://phabricator.wikimedia.org/T153443) [12:26:09] I see no value in keeping old videos except for attribution purposes, which is what the file history does [12:26:25] 10MediaWiki-extensions-Scribunto: When "Erreur Lua : attempt to call a string value", where? - https://phabricator.wikimedia.org/T154769#2923228 (10Rical) [12:26:50] old videos on separate filenames may get eventually deleted [12:27:30] afaik, we don't delete old files for no reason [12:28:04] isn't cleanup a reason? [12:28:34] note we're talking about mediawiki.org, not commons [12:29:08] Vulpix: the fle is in fact on commons https://commons.wikimedia.org/wiki/File:Explanation_on_creating_a_task.webm [12:29:45] oh, I missed that [12:30:04] mediawiki.org may have cleanups regularly, but I'm not that involved on that wiki so I can't be sure [12:34:52] zhuyifei1999_: Yeah, I'd be happy to host on mediawiki.org if that Commons rules was applicable. [12:35:24] zhuyifei1999_: Keeping outdated "how-to" videos for UI's that don't exist anymore and not allowing to update them is... I'm not sure how to call that. [12:36:14] ....as I have to edit a wikipage linking to that video to update the embedded filename, only to waste my time. [12:36:32] it's not that we don't allow updates, but we are making sure old use cases are applicable even after the overwrite [12:36:46] (03PS1) 10Gilles: Enable Thumbor PoolCounter support [vagrant] - 10https://gerrit.wikimedia.org/r/330870 (https://phabricator.wikimedia.org/T151066) [12:37:07] the thing is, commons isn't for mediawiki.org docs only [12:37:10] zhuyifei1999_, there are no old usecases left. :) [12:37:12] sure. [12:37:22] I understand it may be suitable for commons to have both filenames if the old one can be used somehow, maybe on a tutorial about phabricator in general? I'm not sure if that would be the case [12:37:24] (03CR) 10Gilles: [C: 032] Enable Thumbor PoolCounter support [vagrant] - 10https://gerrit.wikimedia.org/r/330870 (https://phabricator.wikimedia.org/T151066) (owner: 10Gilles) [12:37:30] zhuyifei1999_, That's why https://commons.wikimedia.org/wiki/Commons:Overwriting_existing_files#Files_with_current_data says "in many cases". [12:37:33] and not "in all cases". [12:37:34] (03Merged) 10jenkins-bot: Enable Thumbor PoolCounter support [vagrant] - 10https://gerrit.wikimedia.org/r/330870 (https://phabricator.wikimedia.org/T151066) (owner: 10Gilles) [12:37:57] also, the name is too generic to be kept for old data [12:38:04] yep there's an "except" [12:38:12] (03CR) 10jenkins-bot: Enable Thumbor PoolCounter support [vagrant] - 10https://gerrit.wikimedia.org/r/330870 (https://phabricator.wikimedia.org/T151066) (owner: 10Gilles) [12:38:21] *"however" [12:38:41] and that one applies here :) [12:38:56] hence I asked Dereckson to revert his revert... [12:40:08] well, if Dereckson agrees, sure. I'm not opposing it [12:40:34] the problem I would see about overwrite here, is that license and author information should be updated. It's not a subtle change to an existing video (applying effects, cut parts of it, etc) but just a new recording [12:40:46] exactly [12:41:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 13Patch-For-Review, and 2 others: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2923250 (10Micru) @Jonas If your patch adds a new datatype for Commons datasets, could you please update the ticket... [12:42:01] MtDu, now yes. [12:43:17] (03PS1) 10Filip: Restrict "newsletter-create" to sysop group [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/330871 (https://phabricator.wikimedia.org/T154536) [12:43:31] tonythomas: ^^ [12:44:10] qgil, You mentioned some "minor things" in the phab task. Could you enlighten me on those? I will fix those anyway. :) [12:44:23] (03CR) 10jerkins-bot: [V: 04-1] Restrict "newsletter-create" to sysop group [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/330871 (https://phabricator.wikimedia.org/T154536) (owner: 10Filip) [12:45:49] rlot, looks like you have to update the tests to reflect the change. [12:57:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923258 (10WMDE-leszek) [12:57:53] (03PS1) 10Gilles: Set Age: 0 for RL requests served by Varnish [vagrant] - 10https://gerrit.wikimedia.org/r/330874 (https://phabricator.wikimedia.org/T105657) [13:00:29] (03CR) 10Gilles: "To test this, enable the Varnish role and access the dev wiki via port 6081 instead of port 8080. ResourceLoader requests should go throug" [vagrant] - 10https://gerrit.wikimedia.org/r/330874 (https://phabricator.wikimedia.org/T105657) (owner: 10Gilles) [13:00:57] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Newsletter extension doesn't explain how notifications will be received - https://phabricator.wikimedia.org/T154770#2923263 (10QuimGil) [13:01:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923275 (10WMDE-leszek) @daniel @Ladsgroup @Jakob_WMDE: I've edited a task description addin... [13:01:43] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Newsletter extension doesn't explain how notifications will be received - https://phabricator.wikimedia.org/T154770#2923278 (10QuimGil) [13:01:45] 07Design, 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Subscribe/Unsubscribe newsletter floating dialog disappears too soon - https://phabricator.wikimedia.org/T154763#2923277 (10QuimGil) [13:02:21] 07Design, 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Subscribe/Unsubscribe newsletter floating dialog disappears too soon - https://phabricator.wikimedia.org/T154763#2923065 (10QuimGil) Maybe we don't need this task if {T154770} is implemented and the text of these dialog is significantly redu... [13:02:38] (03PS1) 10Addshore: DNM output unparsable input in phan postprocess [core] - 10https://gerrit.wikimedia.org/r/330877 [13:06:00] MtDu: Yep, got it [13:08:21] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 [13:08:44] (03PS2) 10Filip: Restrict "newsletter-create" to sysop group [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/330871 (https://phabricator.wikimedia.org/T154536) [13:11:11] (03PS2) 10Addshore: DNM output unparsable input in phan postprocess [core] - 10https://gerrit.wikimedia.org/r/330877 [13:12:14] (03PS1) 10MtDu: Add a reason field to Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) [13:12:28] (03PS3) 10Filip: Restrict "newsletter-create" to sysop group [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/330871 (https://phabricator.wikimedia.org/T154534) [13:16:24] tonythomas: Ok, done! [13:16:48] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 [13:17:53] (03PS2) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 [13:20:38] 07Design, 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Subscribe/Unsubscribe newsletter floating dialog disappears too soon - https://phabricator.wikimedia.org/T154763#2923323 (10QuimGil) Also, I just realized that this floating dialog is the same that appears when marking a page as patrolled. I... [13:20:49] (03PS2) 10MtDu: Add a reason fields to both Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) [13:21:18] MtDu, don't worry, it takes more time to explain what and why than to just review the page. [13:22:02] I think a task about adding screenshots to the Help and Extension pages would be a better use of GCi time. [13:22:47] qgil, But right now, should we add those even without it being deployed? [13:23:05] qgil, I guess we could just screenshot from the test instance. [13:23:08] andre__, you might have noticed that I have created three GCi tasks about the Newsletter extension. [13:24:08] Yes, those screenshots help improve our docs, and this helps getting this extension better understood and hopefully more desired by Wikimedians and other MediaWiki users. [13:24:23] If one day we have a nicer UI, then we can refresh the screenshots. [13:25:13] MtDu_: Where is special language? [13:25:27] want to test it out [13:27:55] (03PS3) 10MtDu: Add a reason fields to both Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) [13:28:05] MtDu: [13:28:18] rlot, the api? [13:28:30] rlot, or the SpecialPage? [13:28:36] SpecialPage [13:28:47] rlot, I didn't right that. Are you testing the reason? [13:28:53] write* [13:28:55] Its not Special:PageLanguage [13:29:00] It is. [13:29:13] (03PS1) 10Reedy: Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) [13:29:14] No such special page [13:29:14] You have requested an invalid special page. [13:29:14] A list of valid special pages can be found at Special pages. [13:29:19] http://localhost/core/index.php/Special:PageLanguage [13:29:34] MtDu_: Maybe my wiki its not up-to-date [13:29:46] I got that error too [13:30:01] (03PS1) 10Reedy: Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) [13:30:04] rlot, I'm not sure why, but go to SpecialPageFactory and remove the if. part of SpecialPageLanguage [13:30:53] rlot, No, that's wrong. [13:31:01] rlot, Try enabling $wgPageLanguageUseDB in your LocalSettings.php [13:31:04] And see if that works. [13:31:53] MtDu_: Hmm, i'm admin and it still does not work [13:31:59] permission error [13:33:13] (03CR) 10Anomie: [C: 031] "Seems sane, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) (owner: 10MtDu) [13:33:28] rlot, what error? [13:35:22] (03CR) 10Reedy: [C: 032] Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [13:36:59] MtDu_: No permission [13:38:03] MtDu_ Nevermind [13:40:29] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/330887 [13:41:53] (03PS4) 10MtDu: Add a reason field to both Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) [13:42:28] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330888 [13:45:02] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/330889 [13:46:30] (03CR) 10TTO: [C: 032] Add a reason field to both Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) (owner: 10MtDu) [13:47:17] (03CR) 10jerkins-bot: [V: 04-1] Replace $( document ).ready(...) by $(...) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/330889 (owner: 10Fomafix) [13:47:38] (03Merged) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [13:47:53] (03PS1) 10Niharika29: Replace block trigger string by bool to indicate whether it was a cookie block [core] - 10https://gerrit.wikimedia.org/r/330890 (https://phabricator.wikimedia.org/T146230) [13:48:08] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Wikimedia Foundation Technology and Product Q&A - https://phabricator.wikimedia.org/T153063#2923358 (10Qgil) [13:48:37] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Wikimedia Foundation Technology and Product Q&A - https://phabricator.wikimedia.org/T153063#2868255 (10Qgil) After 25 days, 40 questions, and 2480 votes, the results are... https://www.mediawiki.org/wiki/Wikimedia_Developer_Summit/2017/... [13:49:59] (03CR) 10Gilles: "Works fine for me. "vagrant up" works without errors and the wiki appears to be running fine without roles enabled." [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [13:50:40] (03CR) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330884 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [13:51:38] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Better UI for adding / removing Newsletter publishers - https://phabricator.wikimedia.org/T131492#2923360 (10Phantom42) Currently I am working at this task. Here is what I have at this point. Appearance Firstly, we have two ways of how this can look l... [13:52:15] 10MediaWiki-extensions-Scribunto: When "Erreur Lua : attempt to call a string value", where? - https://phabricator.wikimedia.org/T154769#2923228 (10Anomie) Each time someone reports a bug, they can and must provide reproduction instructions. Well, not really "must", but it sure does help if you do so. Without t... [13:52:53] (03CR) 10Gilles: [C: 032] Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) (owner: 10BryanDavis) [13:53:05] 06Developer-Relations: Who are the top 50 independent contributors and what do they need from the WMF? - https://phabricator.wikimedia.org/T85600#2923365 (10Aklapper) AFAICS this isn't blocked by anything on wikimedia.biterg.io: data is in place and can be filtered by whatever criteria is wanted. Hence removing... [13:53:31] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/330892 [13:56:18] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/330893 [13:57:03] (03PS6) 10Anomie: API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [13:57:15] (03CR) 10Anomie: [C: 032] API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [13:57:53] (03CR) 10Mgautierfr: "As you imply in https://gerrit.wikimedia.org/r/#/c/329759/ this is not enough." [openzim] - 10https://gerrit.wikimedia.org/r/330857 (owner: 10Legoktm) [13:58:13] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Better UI for adding / removing Newsletter publishers - https://phabricator.wikimedia.org/T131492#2168647 (10MtDu) Personally, I like the second option. I think it looks nicer, but the first does look more like a classic newsletter. In terms of code, it... [13:58:53] (03PS1) 10MtDu: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330894 (https://phabricator.wikimedia.org/T153994) [14:00:04] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-blocking, 06Community-Tech, 06Support-and-Safety, and 2 others: Set-up EventLogging to see how often blocked users are blocked via cookie - https://phabricator.wikimedia.org/T146230#2923371 (10Niharika) I'll amend the schema and events hook if... [14:01:23] (03PS1) 10MtDu: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) [14:03:04] (03CR) 10jerkins-bot: [V: 04-1] Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [14:03:27] I will let you know when I see tonythomas around here [14:03:27] @notify tonythomas [14:03:41] (03PS1) 10TTO: Fix parsing of
 tags generated by extension tag hooks [core] - 10https://gerrit.wikimedia.org/r/330896
[14:04:08] 	 (03PS1) 10MtDu: Migrate away from UtfNormal in core to external UtfNormal library [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/330897 (https://phabricator.wikimedia.org/T153994)
[14:05:02] 	 (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330888 (owner: 10Fomafix)
[14:06:39] 	 (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330888 (owner: 10Fomafix)
[14:07:51] 	 04(no projects): [RfC] Abandon support for Python 2.6 - https://phabricator.wikimedia.org/T154771#2923377 (10Magul)
[14:07:56] 	 (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/330900
[14:07:58] 	 (03Merged) 10jenkins-bot: Add a reason field to both Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) (owner: 10MtDu)
[14:10:05] 	 (03Merged) 10jenkins-bot: API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96)
[14:10:14] 	 (03CR) 10Jforrester: [C: 032] Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy)
[14:11:53] 	 10MediaWiki-API, 10MediaWiki-Special-pages, 03Google-Code-In-2016, 13Patch-For-Review: Special:PageLanguage doesn't allow the user to enter a reason/comment - https://phabricator.wikimedia.org/T154644#2923391 (10TTO) 05Open>03Resolved a:03MtDu
[14:12:02] 	 (03PS1) 10MtDu: DO NOT MERGE (Checking tests) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330901
[14:13:23] 	 (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE (Checking tests) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330901 (owner: 10MtDu)
[14:14:35] 	 (03PS3) 10ArielGlenn: Major refactoring * Migration to Java 8 * Spring added * Modular structure introduced * Obsolete gui classes removed * Some unit tests added * Some bugfixes [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/309314 (owner: 10Adam.slaski)
[14:15:09] 	 (03CR) 10Anomie: [C: 04-1] "Needs a manual rebase. I think the automatic rebase is going to screw things up by putting the code inside changePageLanguage() instead of" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05)
[14:15:58] 	 (03PS4) 10ArielGlenn: Major refactoring * Migration to Java 8 * Spring added * Modular structure introduced * Obsolete gui classes removed * Some unit tests added * Some bugfixes [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/309314 (owner: 10Adam.slaski)
[14:16:16] 	 04(no projects): Broken Tests in FoxWay Extension - https://phabricator.wikimedia.org/T154772#2923398 (10MtDu)
[14:17:16] 	 (03CR) 10ArielGlenn: "Sorry for the bonus rebase.  The new patchset makes this compile, for me at least.  I can't get it to run because I'm too lame to figure o" [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/309314 (owner: 10Adam.slaski)
[14:17:25] 	 (03CR) 10TTO: "I'll give it a manual rebase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05)
[14:17:41] 	 (03PS3) 10TTO: Switch  to output HTML 
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 [14:19:08] 10MediaWiki-extensions-Other: Broken Tests in FoxWay Extension - https://phabricator.wikimedia.org/T154772#2923410 (10Aklapper) [14:19:43] 10MediaWiki-extensions-Other: Broken Tests in FoxWay Extension - https://phabricator.wikimedia.org/T154772#2923398 (10Aklapper) https://www.mediawiki.org/wiki/Extension:Foxway says it's archived hence not sure this is worth it? [14:19:49] (03CR) 10jerkins-bot: [V: 04-1] Major refactoring * Migration to Java 8 * Spring added * Modular structure introduced * Obsolete gui classes removed * Some unit tests added * Some bugfixes [tools/mwdumper] - 10https://gerrit.wikimedia.org/r/309314 (owner: 10Adam.slaski) [14:20:01] (03PS2) 10MtDu: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) [14:22:51] (03PS14) 10TTO: Special:PageLanguage: Ensure the user has permission to edit the page [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05) [14:22:58] 10MediaWiki-extensions-PhpTags: Broken Tests in PhpTags Extension - https://phabricator.wikimedia.org/T154773#2923418 (10MtDu) [14:23:07] (03CR) 10jerkins-bot: [V: 04-1] Special:PageLanguage: Ensure the user has permission to edit the page [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05) [14:23:50] 10MediaWiki-extensions-Other: Broken Tests in FoxWay Extension - https://phabricator.wikimedia.org/T154772#2923432 (10Reedy) Guess we should properly archive it? Empty the git repo, and remove from CI then? :) [14:24:21] (03Abandoned) 10MtDu: DO NOT MERGE (Checking tests) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330901 (owner: 10MtDu) [14:24:53] (03Merged) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [14:25:09] 10MediaWiki-extensions-Other: Broken Tests in FoxWay Extension - https://phabricator.wikimedia.org/T154772#2923398 (10TTO) See T93724 for some discussion of what to do with this extension. [14:25:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923441 (10Aleksey_WMDE) Vote for dropping "callback" suffix. [14:26:03] (03CR) 10jenkins-bot: Fix wgMessagesDirs in php entry point [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330882 (https://phabricator.wikimedia.org/T154110) (owner: 10Reedy) [14:26:41] 10MediaWiki-API: Add userid versions of `rvuser` and `rvexcludeuser` - https://phabricator.wikimedia.org/T154774#2923442 (10Anomie) [14:26:44] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth: Add guiuserid for meta=globaluserinfo - https://phabricator.wikimedia.org/T154775#2923455 (10Anomie) [14:26:56] 10MediaWiki-API: Make user IDs more readily available with the API - https://phabricator.wikimedia.org/T21195#2923470 (10Anomie) [14:26:59] 10MediaWiki-API, 13Patch-For-Review: API should allow querying user contribs by userid - https://phabricator.wikimedia.org/T114465#1696284 (10Anomie) [14:27:01] 10MediaWiki-API: Add userid versions of `rvuser` and `rvexcludeuser` - https://phabricator.wikimedia.org/T154774#2923442 (10Anomie) [14:27:07] 10MediaWiki-API: Make user IDs more readily available with the API - https://phabricator.wikimedia.org/T21195#241534 (10Anomie) [14:27:09] 10MediaWiki-API, 13Patch-For-Review: API should allow querying user contribs by userid - https://phabricator.wikimedia.org/T114465#1696284 (10Anomie) [14:27:11] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth: Add guiuserid for meta=globaluserinfo - https://phabricator.wikimedia.org/T154775#2923455 (10Anomie) [14:27:41] 10MediaWiki-API: Make user IDs more readily available with the API - https://phabricator.wikimedia.org/T21195#241534 (10Anomie) [14:27:44] 10MediaWiki-API, 13Patch-For-Review: API should allow querying user contribs by userid - https://phabricator.wikimedia.org/T114465#1696284 (10Anomie) 05Open>03Resolved The original report here is now resolved. I've created subtasks for the tangentially-related bits that weren't done here. [14:28:17] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 13Patch-For-Review, 15User-Ladsgroup, 03Wikidata-Sprint-2016-11-15: Inject dependencies to SpecialPagesWithBadges - https://phabricator.wikimedia.org/T154474#2923479 (10Addshore) 05Open>03Resolved [14:28:22] (03CR) 10jenkins-bot: Add a reason field to both Special:PageLanguage and ApiSetPageLanguage [core] - 10https://gerrit.wikimedia.org/r/330880 (https://phabricator.wikimedia.org/T154644) (owner: 10MtDu) [14:32:51] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 (owner: 10Fomafix) [14:32:53] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [14:33:50] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/330900 (owner: 10Fomafix) [14:34:22] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/330892 (owner: 10Fomafix) [14:34:39] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/330893 (owner: 10Fomafix) [14:34:50] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/330887 (owner: 10Fomafix) [14:35:01] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/330737 (owner: 10Fomafix) [14:35:12] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330888 (owner: 10Fomafix) [14:37:00] (03CR) 10Addshore: "Ideally this patch would be split in 2." [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [14:40:02] (03CR) 10Addshore: [C: 032] Migrate away from UtfNormal in core to external UtfNormal library [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330894 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [14:40:47] (03CR) 10TTO: "Note that this is duplicative of Id10552e117ce2b231504e41627b44f8cfb0d4329" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/266595 (https://phabricator.wikimedia.org/T124117) (owner: 10MtDu) [14:41:35] (03PS1) 10Addshore: Bump requirement to MW 1.25+ [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330905 [14:42:31] (03CR) 10MtDu: [C: 031] "Thanks for the follow up!" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330905 (owner: 10Addshore) [14:43:21] (03Abandoned) 10MtDu: Check whether IP is valid in ip_in_range() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/266595 (https://phabricator.wikimedia.org/T124117) (owner: 10MtDu) [14:43:23] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 (owner: 10Fomafix) [14:43:55] (03PS1) 10Addshore: Bump requirement to MW 1.25+ [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330906 [14:44:11] (03CR) 10jenkins-bot: API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [14:44:35] (03CR) 10jerkins-bot: [V: 04-1] Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [14:45:16] (03PS3) 10TTO: Automatic line numbering functionality for [extensions/Poem] - 10https://gerrit.wikimedia.org/r/328888 (https://phabricator.wikimedia.org/T15644) [14:45:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923483 (10daniel) @Aleksey it seems a bit redundant here, but we use it for other callbacks... [14:50:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923489 (10WMDE-leszek) The more important question I think I failed to make more promiment... [14:51:29] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/330900 (owner: 10Fomafix) [14:51:31] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/330892 (owner: 10Fomafix) [14:52:27] (03PS3) 10MtDu: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) [14:52:34] 10MediaWiki-Configuration: Add a new type of code to extension registeration that allows us to add configs and things that can't be in a callback or extension function - https://phabricator.wikimedia.org/T125310#2923490 (10Reedy) [14:53:22] (03CR) 10jerkins-bot: [V: 04-1] Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [14:53:39] (03CR) 10Anomie: "PS14 Looks good except for the merge conflict." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05) [14:54:43] (03PS2) 10Umherirrender: Remove apihelp for non existing module csQueryChildCount [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 [14:55:52] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/330893 (owner: 10Fomafix) [14:55:54] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/330887 (owner: 10Fomafix) [14:55:56] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/330737 (owner: 10Fomafix) [14:55:58] (03CR) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330878 (owner: 10Fomafix) [14:56:06] (03CR) 10Anomie: "> We kind of already did this refactoring in I42e74ed3bcd0bfa9ec0c344ba67668210450c975..." [core] - 10https://gerrit.wikimedia.org/r/143049 (owner: 10Kunalgrover05) [14:56:08] (03PS1) 10MtDu: Disable the following phpunit tests as they are failing * testRun_foreach_9 * testRun_foreach_10 * testRun_foreach_11 [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330911 [14:56:39] (03CR) 10Umherirrender: "Makes sense, I see no reason why there were added with Idbc0c57c569d10c21fcd5ada6953dc1526d8e5dc" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 (owner: 10Umherirrender) [14:57:16] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330888 (owner: 10Fomafix) [14:58:06] (03CR) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/330893 (owner: 10Fomafix) [14:58:52] (03Merged) 10jenkins-bot: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330894 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [15:03:30] (03PS4) 10Addshore: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [15:03:40] (03PS2) 10Addshore: Bump requirement to MW 1.25+ [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330906 [15:03:42] (03PS1) 10MtDu: Bump requirement to MW 1.25+ [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/330915 [15:04:28] Reedy: chance you are around ? [15:04:33] (03CR) 10Huji: "Except that this one could be merged ;)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/266595 (https://phabricator.wikimedia.org/T124117) (owner: 10MtDu) [15:04:34] =o [15:04:39] addshore: ahahah - you are here [15:04:48] tonythomas: I am kinda. I really need to move from my seat and use a bathroom though :P [15:04:56] ooh, tonythomas ill be in berlin for a week from jan 22nd [15:05:04] (03CR) 10Addshore: [C: 032] Bump requirement to MW 1.25+ [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/330915 (owner: 10MtDu) [15:05:10] addshore: ah. That exact week, I am moving back to India. why god, why [15:05:16] HAH! [15:05:22] of course :p [15:05:36] (03PS1) 10Fomafix: Replace $( document ).ready(...) by $(...) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/330916 [15:05:55] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/330916 (owner: 10Fomafix) [15:06:09] hehe. in case you guys got time, I want you to take a look at https://phabricator.wikimedia.org/T131492#2923360 Reedy , addshore. I got 0 idea on how complicated it can turn out to be, but that needs appreciation! [15:06:18] (03Merged) 10jenkins-bot: Bump requirement to MW 1.25+ [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/330915 (owner: 10MtDu) [15:06:28] (03PS1) 10MtDu: Bump requirement to MW 1.25+ [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/330917 [15:06:48] tonythomas: The second design seems to be getting more common; GCI, Phab etc [15:06:56] (03CR) 10Addshore: [C: 032] Bump requirement to MW 1.25+ [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/330917 (owner: 10MtDu) [15:07:16] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks like Cicalese is actively maintaining this, so let him decide." [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 (owner: 10Umherirrender) [15:07:18] I agree with Reedy [15:07:20] (03CR) 10Reedy: [C: 032] Disable the following phpunit tests as they are failing * testRun_foreach_9 * testRun_foreach_10 * testRun_foreach_11 [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330911 (owner: 10MtDu) [15:07:32] Reedy: I would say it was inspired from GCI of course :D and we do not have any OOJS thingy to do that, etc right ? Sometyhing which can be less hackyu [15:07:35] (03CR) 10Addshore: [C: 032] Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [15:08:22] addshore: ahah. Now I got things to paste in the comment area! [15:08:43] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/330916 (owner: 10Fomafix) [15:08:45] "The second mockup looks great as Reedy> tonythomas: The second design seems to be getting more common; GCI, Phab etc and addshore agreed with Reedy on it without second thoughts" [15:08:45] (03Merged) 10jenkins-bot: Bump requirement to MW 1.25+ [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/330917 (owner: 10MtDu) [15:08:47] (03Merged) 10jenkins-bot: Disable the following phpunit tests as they are failing * testRun_foreach_9 * testRun_foreach_10 * testRun_foreach_11 [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330911 (owner: 10MtDu) [15:08:49] (03Merged) 10jenkins-bot: Migrate away from UtfNormal in core to external UtfNormal library [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330895 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [15:09:09] (03CR) 10Dbrant: Check for notifications only for 1 day after last description edit. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 (owner: 10Dbrant) [15:11:04] (03CR) 10Cicalese: [C: 032] Remove apihelp for non existing module csQueryChildCount [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 (owner: 10Umherirrender) [15:11:18] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Better UI for adding / removing Newsletter publishers - https://phabricator.wikimedia.org/T131492#2923506 (1001tonythomas) Wow. Great to see this coming up. Let me paste something here for your reference, and a green flag for the second one (personally... [15:12:03] (03CR) 10Cicalese: [C: 032] "Thanks for finding that! Those messages were left over from an early API module that is no longer necessary." [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 (owner: 10Umherirrender) [15:12:08] (03Merged) 10jenkins-bot: Remove apihelp for non existing module csQueryChildCount [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/330695 (owner: 10Umherirrender) [15:12:10] (03CR) 10Jack Phoenix: [V: 032 C: 032] Replace $( document ).ready(...) by $(...) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/330889 (owner: 10Fomafix) [15:12:53] (03CR) 1001tonythomas: [C: 032] Restrict "newsletter-create" to sysop group [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/330871 (https://phabricator.wikimedia.org/T154534) (owner: 10Filip) [15:13:22] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default - https://phabricator.wikimedia.org/T154534#2923509 (1001tonythomas) 05Open>03Resolved Nice work, thank you! [15:14:23] (03CR) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/330916 (owner: 10Fomafix) [15:14:46] (03Merged) 10jenkins-bot: Restrict "newsletter-create" to sysop group [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/330871 (https://phabricator.wikimedia.org/T154534) (owner: 10Filip) [15:15:24] 10MediaWiki-extensions-Other: Foxway: Module 'ext.Foxway.DebugLoops' must not depend on 'jquery' - https://phabricator.wikimedia.org/T93724#1144370 (10MtDu) The dependency on JQuery was removed in https://gerrit.wikimedia.org/r/#/c/330727/. [15:16:11] (03CR) 10Anomie: Add parameter to API modules to apply change tags to log entries (033 comments) [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [15:17:10] (03CR) 10Jack Phoenix: "Great, thank you for the patch! One tiny nitpick inline, otherwise looks good to me." (031 comment) [extensions/Video] - 10https://gerrit.wikimedia.org/r/330840 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [15:23:43] (03CR) 10Hashar: [C: 032] Update composer.json file to match vector's, also add phpcs [skins/Timeless] - 10https://gerrit.wikimedia.org/r/330741 (owner: 10Paladox) [15:23:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Bump requirement to MW 1.25+ [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330906 (owner: 10Addshore) [15:25:09] (03CR) 10Dbrant: Allow description editing only for pages with wikibase ID. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [15:25:33] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Bump requirement to MW 1.25+ [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330905 (owner: 10Addshore) [15:26:28] (03Merged) 10jenkins-bot: Update composer.json file to match vector's, also add phpcs [skins/Timeless] - 10https://gerrit.wikimedia.org/r/330741 (owner: 10Paladox) [15:26:31] (03Merged) 10jenkins-bot: Bump requirement to MW 1.25+ [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/330906 (owner: 10Addshore) [15:27:33] (03PS3) 10Hashar: Change ParserFunctions license to GPL-2.0+ [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/267520 (https://phabricator.wikimedia.org/T125322) (owner: 10Platonides) [15:29:27] (03CR) 10Hashar: [C: 032] "This has been stalled for a year now, and I dont think anyone will object from now on. We have ample consensus on T125322 and the main aut" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/267520 (https://phabricator.wikimedia.org/T125322) (owner: 10Platonides) [15:29:53] 10MediaWiki-extensions-ParserFunctions, 13Patch-For-Review, 07Software-Licensing: Change ParserFunctions license to GPL-2.0+ - https://phabricator.wikimedia.org/T125322#2923534 (10hashar) 05Open>03Resolved a:03hashar Been bold. I have CR+2 the change. [15:30:04] 10MediaWiki-extensions-ParserFunctions, 13Patch-For-Review, 07Software-Licensing: Change ParserFunctions license to GPL-2.0+ - https://phabricator.wikimedia.org/T125322#2923537 (10hashar) a:05hashar>03Platonides [15:30:48] (03CR) 10Mhurd: "> It's inappropriate an unsustainable to hardcode such wiki-specific" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330820 (https://phabricator.wikimedia.org/T143408) (owner: 10Mhurd) [15:31:05] (03CR) 10Aklapper: [C: 031] "lgtm" [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/330897 (https://phabricator.wikimedia.org/T153994) (owner: 10MtDu) [15:34:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923538 (10Ladsgroup) I just made a new patchset with this following: 1- The definition in a... [15:35:55] (03Merged) 10jenkins-bot: Bump requirement to MW 1.25+ [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/330905 (owner: 10Addshore) [15:36:56] (03CR) 10Anomie: Add password validation to Special:ChangeCredentials (033 comments) [core] - 10https://gerrit.wikimedia.org/r/324970 (owner: 10Anomie) [15:37:05] (03PS6) 10Anomie: Add password validation to Special:ChangeCredentials [core] - 10https://gerrit.wikimedia.org/r/324970 [15:37:28] (03PS6) 10Anomie: Update account creation form validation [core] - 10https://gerrit.wikimedia.org/r/324969 [15:37:38] (03PS7) 10Anomie: Add password validation to Special:ChangeCredentials [core] - 10https://gerrit.wikimedia.org/r/324970 [15:39:27] 10CirrusSearch, 06Discovery, 06Discovery-Search: Timeout even if not complicated regex query - https://phabricator.wikimedia.org/T154751#2922743 (10matej_suchanek) Well, this is not only about the regex itself but about the whole query. In order to make it less expensive, the `i` flag shouldn't be used and t... [15:42:41] (03Merged) 10jenkins-bot: Change ParserFunctions license to GPL-2.0+ [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/267520 (https://phabricator.wikimedia.org/T125322) (owner: 10Platonides) [15:47:40] Still bashing my head against this problem of submitting a patchset to a non-master branch of a gerrit repo [15:49:03] halfak: https://www.mediawiki.org/wiki/Gerrit/Getting_started ? [15:49:31] Vulpix, where does this show how to submit a patchset against a specific, non-master branch? [15:50:39] BTW, I'd like to submit a patch to `wmflabs` in https://gerrit.wikimedia.org/r/#/admin/projects/research/ores/wheels,branches [15:51:11] halfak, pushing it? That would be https://www.mediawiki.org/wiki/Gerrit/Tutorial#Push_to_a_branch_different_than_master [15:51:37] Submitting: https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Submitting_a_change_to_a_branch_for_review_.28.22backporting.22.29 [15:52:14] andre__, ahh yes. so "git review " fails. [15:52:25] * halfak gets error [15:52:45] (03PS3) 10Mhurd: Enwiki "On This Day" endpoints. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330820 (https://phabricator.wikimedia.org/T143408) [15:52:49] Are you already on the right branch? [15:53:00] http://pastebin.ca/3753822 [15:53:00] git checkout wmflabs [15:53:05] "ready"? [15:53:05] git checkout -b mypatchforwmflabs [15:53:10] you usually git review -d or git checkout , not git review [15:54:14] (03Abandoned) 10Mhurd: Removed some ES6 bits incompatible with production node version. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330828 (owner: 10Mhurd) [15:54:21] Vulpix, how might git review know that the patch is submitted against a branch that isn't "master" [15:54:49] the gerrit change id has this information [15:54:49] Reedy, I'm working from a branch called "update_libraries" that is one commit ahead of "wmflabs" [15:55:13] Vulpix, sorry, I'm not following. [15:55:35] "git review -d" is for downloading, so it downloads and checkouts to the correct branch [15:55:50] I'm not reviewing. I'm submitting [15:56:06] I've downloaded the "wmflabs" branch and created a new commit on top of it. [15:56:11] submit is merging [15:56:12] (03CR) 10Mholloway: Allow description editing only for pages with wikibase ID. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [15:56:17] reviewing is sending to gerrit [15:56:22] Reedy, sure sorry [15:56:26] :) [15:56:31] "submit for review" [15:56:46] gerrit just had to have it's own language. [15:56:49] Was the pastebin just a git review? [15:56:52] no parameters [15:57:16] Reedy, yes, but here's what's in my .git/config [15:57:25] [gerrit]\n defaultbranch=wmflabs [15:57:37] I think it depends on what branch you were (your previous git checkout) before making the changes. [15:57:42] Tried this and explicitly giving it on the command line. [15:58:02] Vulpix, was on wmflabs, checked out a new branch and made changes. [15:58:09] Normal flow for master, except with wmflabs. [15:58:22] which git checkout did you use? [15:58:31] git checkout -b update_libraries [15:58:45] ok, so that should be vaguely right [15:58:50] before that was: git checkout wmflabs; git pull; [15:59:19] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Better UI for adding / removing Newsletter publishers - https://phabricator.wikimedia.org/T131492#2923569 (10Qgil) Second option is nicer indeed! Let's go for that. [15:59:29] yeah [15:59:50] (03PS1) 10Mholloway: Hygiene: Remove obsolete check for JSONArray when checking page protection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330924 [16:00:05] https://github.com/wikimedia/research-ores-wheels ? [16:00:19] halfak: I see the problem [16:00:19] Yup [16:00:23] There's no .gitreview file [16:00:44] Been submitting against this repo for a while :S [16:01:03] git push origin HEAD:refs/for/wmflabs [16:01:05] Does that work? [16:01:13] (though, I'd still suggest adding .gitreview) [16:01:15] been looking at this warning for a while. I guess it is related: [16:01:16] Using global/system git-review config files (/home/halfak/.config/git-review/git-review.conf) is deprecated [16:01:28] Shouldn't be [16:01:31] Deprecated, not removed [16:01:35] (I still use a similar config) [16:02:30] Reedy, same error as above "! [remote rejected] HEAD -> refs/for/wmflabs (no new changes)" [16:03:32] FWIW: My commit is 7d02d52 and comes right after the last commit on wmflabs (63fe882). [16:03:55] So I'm confused by the "no new changes" [16:04:03] git log origin/wmflabs..HEAD [16:04:07] Does that show the change? [16:04:21] hmm... it does [16:04:28] O.o [16:04:52] Could it have somehow been pushed without review? [16:05:15] Oh wait... HEAD is local, right? [16:05:23] yeah [16:05:35] * halfak feels slightly less crazy now [16:05:38] (03PS1) 10Umherirrender: Add missing messages to qqq.json [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330925 [16:06:48] (03PS5) 10DCausse: Workaround timeout limitation [search/extra] - 10https://gerrit.wikimedia.org/r/328644 (https://phabricator.wikimedia.org/T152895) [16:08:51] (03PS3) 10Hashar: Unregister Semantic* extensions [extensions] - 10https://gerrit.wikimedia.org/r/330689 (https://phabricator.wikimedia.org/T151968) (owner: 10Umherirrender) [16:09:00] (03CR) 10Hashar: [V: 032 C: 032] Unregister Semantic* extensions [extensions] - 10https://gerrit.wikimedia.org/r/330689 (https://phabricator.wikimedia.org/T151968) (owner: 10Umherirrender) [16:09:17] (03PS5) 10Hashar: Unregister archived and moved extensions [extensions] - 10https://gerrit.wikimedia.org/r/330690 (owner: 10Umherirrender) [16:09:31] (03CR) 10Hashar: [V: 032 C: 032] Unregister archived and moved extensions [extensions] - 10https://gerrit.wikimedia.org/r/330690 (owner: 10Umherirrender) [16:10:47] (03CR) 10Hashar: [V: 032 C: 032] Fix permission denied [extensions/ConfirmAccount] (REL1_26) - 10https://gerrit.wikimedia.org/r/323688 (https://phabricator.wikimedia.org/T121119) (owner: 10Seb35) [16:11:33] 10MediaWiki-extensions-ConfirmAccount, 13Patch-For-Review: Unable to save a CV/resume with some configurations - https://phabricator.wikimedia.org/T121119#1869893 (10hashar) I have landed @seb35 backport of the patch for REL1_26. [16:12:29] (03PS1) 10Umherirrender: Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) [16:12:50] 10MediaWiki-extensions-OAuth: Flow board (or maybe just a topic) for discussion about each OAuth consumer proposal - https://phabricator.wikimedia.org/T154777#2923579 (10Halfak) [16:13:37] (03PS1) 10Umherirrender: Standarize desc and right message in qqq.json [extensions/StaffEdits] - 10https://gerrit.wikimedia.org/r/330928 [16:14:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923592 (10Aleksey_WMDE) As soon as we don't need to wrap it in a closure I don't see a reas... [16:17:00] Reedy, any other ideas? Maybe you know of a repo that has more than one active branch maintained that I could review? [16:18:09] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Content Translation feedback link should automatically post information about articles being translated and about the browser - https://phabricator.wikimedia.org/T154778#2923596 (10Amire80) [16:18:51] (03PS1) 10Umherirrender: Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 [16:22:22] (03Abandoned) 10DCausse: [WIP] Extract feature scores [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/323550 (owner: 10DCausse) [16:26:52] RoanKattouw: hola! could please take a brief look at : https://phabricator.wikimedia.org/T154395 [16:27:08] (03CR) 10Addshore: [C: 032] Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [16:37:30] (03Merged) 10jenkins-bot: Replace $( document ).ready(...) by $(...) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/330881 (owner: 10Fomafix) [16:38:23] (03Abandoned) 10Hashar: Adding composer.json as per suggestion and coding standard [extensions/ZoomableImages] - 10https://gerrit.wikimedia.org/r/321229 (owner: 10Nephron) [16:39:19] (03PS1) 10Umherirrender: Standarize messages in qqq.json [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/330933 [16:41:04] (03PS5) 10Hashar: Upload first version of the files [extensions/ZoomableImages] - 10https://gerrit.wikimedia.org/r/320724 (owner: 10Nephron) [16:41:55] (03CR) 10Hashar: [C: 04-1] "I have added the composer.json file from another change. You can reproduce the build using:" [extensions/ZoomableImages] - 10https://gerrit.wikimedia.org/r/320724 (owner: 10Nephron) [16:42:02] (03CR) 10jerkins-bot: [V: 04-1] Upload first version of the files [extensions/ZoomableImages] - 10https://gerrit.wikimedia.org/r/320724 (owner: 10Nephron) [16:43:06] 10MediaWiki-extensions-MultimediaViewer: Could not load an image in zh.wikipedia.org - https://phabricator.wikimedia.org/T154780#2923652 (10Lxylxy123456) [16:45:36] 10Wikimedia-General-or-Unknown, 13Patch-For-Review, 07Technical-Debt: Use wfLoadExtension where appropriate in CommonSettings.php - https://phabricator.wikimedia.org/T139801#2923673 (10Jdforrester-WMF) p:05Triage>03Normal [16:47:39] 07Design, 10MediaWiki-User-login-and-signup, 10MobileFrontend: In MobileFrontend account creation form the "Go" button in mobile touch keyboards must not submit the form if the required fields aren't full - https://phabricator.wikimedia.org/T154767#2923682 (10Amire80) [16:48:31] (03PS1) 10Jack Phoenix: New MonoBookAfterContent and MonoBookAfterToolbox hooks [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/330934 [16:49:11] (03PS1) 10Jack Phoenix: New VectorAfterToolbox and VectorBeforeFooter hooks [skins/Vector] - 10https://gerrit.wikimedia.org/r/330935 [16:50:18] 06Reading-Web-Backlog, 10Page-Previews (2016-17-Q3-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-89-🎂: Add preview type to hovercards schema - https://phabricator.wikimedia.org/T152004#2923698 (10jhobs) I guess it's lucky this didn't get resolved last sprint then. @tbayer there's no need for logging it... [16:50:50] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2923701 (10Stevietheman) I wouldn't distinguish any revert from any bot. Whatever it reverts should be taken as bot edits to hide. After all, I believe th... [16:53:13] 10MediaWiki-extensions-PhpTags: Broken Tests in PhpTags Extension - https://phabricator.wikimedia.org/T154773#2923704 (10Umherirrender) [16:55:42] (03PS1) 10Jack Phoenix: Swap $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330938 [16:56:26] 10Research-management: management training - https://phabricator.wikimedia.org/T154782#2923722 (10aripstra) [16:56:38] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default - https://phabricator.wikimedia.org/T154534#2914960 (10Qgil) [16:56:40] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2923735 (10Qgil) [16:56:58] 06Design-Research, 10Research-management: management training - https://phabricator.wikimedia.org/T154783#2923737 (10aripstra) [16:57:24] 10MediaWiki-extensions-Newsletter, 10Security-Reviews, 06Security-Team: Security review of Newsletter extension - https://phabricator.wikimedia.org/T115095#2923756 (10Qgil) [16:57:28] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904679 (10Qgil) 05Open>03Resolved a:03Qgil Agreed (only sysops will be able to create newsletters initially) and implement... [16:58:30] (03CR) 10Jack Phoenix: [C: 032] Swap $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330938 (owner: 10Jack Phoenix) [16:58:59] 07Design, 10MediaWiki-User-login-and-signup, 10ConfirmEdit (CAPTCHA extension): Correctly filled CAPTCHA must not be requested again, even if something else in a form is incorrect - https://phabricator.wikimedia.org/T154784#2923758 (10Amire80) [16:59:23] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2923770 (10QuimGil) Yes, let's close it. The page is good and further improvements can be done in the regular wiki way. Thank you very much @MtDu ! [17:00:14] (03CR) 10Niedzielski: [C: 04-1] "Looks good! Just one request about the naming of test methods inline" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:00:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923773 (10Ladsgroup) AFAIK it's the plan to wrap it up in a closure ([[ https://github.com/... [17:01:22] 10Android-app-feature-Description-Editing, 06Wikipedia-Android-App-Backlog (Kanban): Limit description editing to 5 anonymous edits before requiring login. - https://phabricator.wikimedia.org/T154785#2923774 (10Dbrant) [17:05:10] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2923791 (10JEumerus) I don't think that all reverts by a bot by default imply that the reverted edit can be hidden. Since rollback is usually applied to van... [17:08:21] 10Android-app-feature-Description-Editing, 10Android-app-goals-2016-Oct-Dec-Q2, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Notify a user if their edit to a wikidata description gets reverted - https://phabricator.wikimedia.org/T150477#2923809 (10Dbrant) a:03Dbrant [17:08:32] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-LoginNotify, 03Community-Tech-Sprint: Investigation: What would be the best way to support loginwiki from LoginNotify - https://phabricator.wikimedia.org/T154064#2923810 (10Niharika) a:03Niharika [17:08:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2923812 (10daniel) >>! In T152491#2923592, @Aleksey_WMDE wrote: > If we need to wrap it in a... [17:14:25] 10Research-management: management training - https://phabricator.wikimedia.org/T154782#2923821 (10Aklapper) @aripstra: Is this a duplicate of T154783 ? Or something different? [17:16:34] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2923824 (10Ciencia_Al_Poder) >>! In T11790#2923791, @JEumerus wrote: > I don't think that all reverts by a bot by default imply that the reverted edit can b... [17:19:07] 10Android-app-feature-Description-Editing, 06Wikipedia-Android-App-Backlog (Kanban): Show helpful message upon tapping Revert notification. - https://phabricator.wikimedia.org/T154787#2923827 (10Dbrant) [17:22:25] (03CR) 10Niedzielski: [C: 04-1] Check for notifications only for 1 day after last description edit. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 (owner: 10Dbrant) [17:24:18] (03PS1) 10Jack Phoenix: Keep it Simple, Stupid [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/330939 [17:25:26] (03CR) 10jerkins-bot: [V: 04-1] Keep it Simple, Stupid [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/330939 (owner: 10Jack Phoenix) [17:25:28] (03PS2) 10Dbrant: Allow description editing only for pages with wikibase ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) [17:26:47] (03PS5) 10Jack Phoenix: Comments of the day cleaned up & unconditionally enabled [extensions/Comments] - 10https://gerrit.wikimedia.org/r/275198 (https://phabricator.wikimedia.org/T100024) [17:26:54] (03CR) 10Jack Phoenix: [V: 032 C: 032] Comments of the day cleaned up & unconditionally enabled [extensions/Comments] - 10https://gerrit.wikimedia.org/r/275198 (https://phabricator.wikimedia.org/T100024) (owner: 10Jack Phoenix) [17:29:59] 06Wikipedia-Android-App-Backlog, 07Technical-Debt: Always request an edit token before page edit - https://phabricator.wikimedia.org/T153104#2923846 (10bearND) [17:31:18] (03CR) 10Dbrant: Allow description editing only for pages with wikibase ID. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:31:22] 10MediaWiki-extensions-ContentTranslation: Accept and explain spamblacklist & titleblacklist errors - https://phabricator.wikimedia.org/T154788#2923849 (10Framawiki) [17:31:33] (03PS1) 10Jack Phoenix: jQuery 3.0 readiness [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/330940 [17:33:18] (03CR) 10Mholloway: [C: 031] Allow description editing only for pages with wikibase ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:33:26] (03CR) 10Jack Phoenix: [C: 032] jQuery 3.0 readiness [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/330940 (owner: 10Jack Phoenix) [17:33:33] (03CR) 10Niedzielski: [C: 031] "Ready to merge pending dependencies" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:33:49] andre__: Please add more video/screencast related tasks to GCI :) [17:34:20] (03Merged) 10jenkins-bot: jQuery 3.0 readiness [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/330940 (owner: 10Jack Phoenix) [17:35:22] (03CR) 10Mholloway: [C: 032] Allow description editing only for pages with wikibase ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:35:34] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/330941 [17:36:10] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Better UI for adding / removing Newsletter publishers - https://phabricator.wikimedia.org/T131492#2168647 (10FilipGCI) @01tonythomas @MtDu : Yeah, second option is more user-friendly. [17:36:55] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/330942 [17:37:54] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Bringing "Enterprise MediaWiki" to the Wikimedia Foundation - https://phabricator.wikimedia.org/T149612#2923865 (10MarkAHershberger) I know I'm late to this, and my contribution is going to be tangential, but... >>! In T149612#2823896,... [17:38:47] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/330943 [17:39:19] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/330944 [17:39:55] 10MediaWiki-Codesniffer: Closure formatting is ugly - https://phabricator.wikimedia.org/T154789#2923866 (10Aleksey_WMDE) [17:39:58] (03Merged) 10jenkins-bot: Allow description editing only for pages with wikibase ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:39:59] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2923878 (10Deskana) @chelsyx Thanks! Please also upload the report to Wikimedia Commons; it's important our reports go there so that they're easy to access and refer to from our... [17:40:51] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330945 [17:41:18] (03CR) 10Jack Phoenix: [V: 032 C: 032] Swap $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330938 (owner: 10Jack Phoenix) [17:41:36] 06Discovery-Search (Current work), 13Patch-For-Review: Refactor TextCat for ambiguity detection and add additional params - https://phabricator.wikimedia.org/T153105#2923883 (10Deskana) p:05Triage>03Normal [17:41:51] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: Investigate Improvements and Confidence Measures for TextCat Language Detection - https://phabricator.wikimedia.org/T140289#2923885 (10Deskana) [17:41:54] 06Discovery-Search (Current work), 13Patch-For-Review: Refactor TextCat for ambiguity detection and add additional params - https://phabricator.wikimedia.org/T153105#2869903 (10Deskana) 05Open>03Resolved [17:43:25] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/330941 (owner: 10Jack Phoenix) [17:43:27] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/330942 (owner: 10Jack Phoenix) [17:43:29] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/330943 (owner: 10Jack Phoenix) [17:43:31] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/330944 (owner: 10Jack Phoenix) [17:43:35] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330945 (owner: 10Jack Phoenix) [17:43:38] (03CR) 10jenkins-bot: Allow description editing only for pages with wikibase ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330586 (https://phabricator.wikimedia.org/T154032) (owner: 10Dbrant) [17:43:58] (03PS3) 10Mholloway: Get wikibase item ID in MW API page lead requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330819 (https://phabricator.wikimedia.org/T154032) [17:44:11] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/330946 [17:44:14] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/330941 (owner: 10Jack Phoenix) [17:44:27] 10MediaWiki-Codesniffer: Closure formatting is ugly - https://phabricator.wikimedia.org/T154789#2923886 (10Aleksey_WMDE) It is of course up to discussion, but I would suggest to allow one line closures, because some times there is a need to pass empty closure as an argument and then you always have to chop down... [17:44:38] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/330942 (owner: 10Jack Phoenix) [17:44:40] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/330943 (owner: 10Jack Phoenix) [17:44:42] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/330944 (owner: 10Jack Phoenix) [17:44:44] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330945 (owner: 10Jack Phoenix) [17:44:52] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: [Epic] Allow extensions to register simple keyword features - https://phabricator.wikimedia.org/T152517#2923887 (10Deskana) 05Open>03Resolved [17:45:36] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/330947 [17:46:00] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/330948 [17:46:04] (03PS13) 10Dbrant: Echo notifications for description edits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) [17:46:06] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: [Epic] Allow extensions to register simple keyword features - https://phabricator.wikimedia.org/T152517#2851556 (10Deskana) [17:46:08] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Move geo-search keywords to GeoData extension - https://phabricator.wikimedia.org/T152730#2923888 (10Deskana) 05Open>03Resolved [17:47:44] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/330949 [17:48:31] 10MediaWiki-extensions-ConfirmAccount, 13Patch-For-Review: Unable to save a CV/resume with some configurations - https://phabricator.wikimedia.org/T121119#2923890 (10Paladox) @hashar thanks :) [17:48:31] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/330947 (owner: 10Jack Phoenix) [17:48:33] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/330948 (owner: 10Jack Phoenix) [17:49:14] 10MediaWiki-extensions-ConfirmAccount, 13Patch-For-Review: Unable to save a CV/resume with some configurations - https://phabricator.wikimedia.org/T121119#2923891 (10Paladox) This should now be resolved with @Reedy's change on the master branch. [17:49:25] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/330951 [17:49:29] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/330947 (owner: 10Jack Phoenix) [17:49:40] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/330948 (owner: 10Jack Phoenix) [17:49:45] (03PS21) 10Mholloway: Make article header consistently reflect the updated description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325072 (https://phabricator.wikimedia.org/T152207) [17:49:47] (03PS6) 10Mholloway: Add test for cached page description updating [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328561 (https://phabricator.wikimedia.org/T152207) [17:49:50] (03PS1) 10Paladox: Replace FSRepo with FileRepo [extensions/ConfirmAccount] (REL1_28) - 10https://gerrit.wikimedia.org/r/330952 [17:50:23] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/330946 (owner: 10Jack Phoenix) [17:50:27] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/330949 (owner: 10Jack Phoenix) [17:50:29] (03CR) 10jerkins-bot: [V: 04-1] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/330951 (owner: 10Jack Phoenix) [17:50:58] (03CR) 10Jack Phoenix: [V: 032 C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/330951 (owner: 10Jack Phoenix) [17:51:17] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/330946 (owner: 10Jack Phoenix) [17:51:26] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/330949 (owner: 10Jack Phoenix) [17:52:28] 10MediaWiki-extensions-ConfirmAccount, 13Patch-For-Review: Unable to save a CV/resume with some configurations - https://phabricator.wikimedia.org/T121119#2923893 (10Paladox) Fixed by https://gerrit.wikimedia.org/r/#/c/324352/ [17:54:35] 06MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit (2017): #mwstake meeting at the Developers Summit - https://phabricator.wikimedia.org/T149586#2923906 (10Qgil) I guess the MediaWiki Stakeholders Group wants this meeting to happen? If so, please follow @srishakatux's instructions above. [17:54:40] (03PS1) 10Jack Phoenix: jQuery 3.0 readiness: swap .bind() (deprecated in jQuery 1.7) to .on() [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330953 [17:56:24] 10MediaWiki-File-management, 06Commons, 10Commons-Datasets, 06Multimedia, and 4 others: Media, Visualizations, and Layout at Wikidev'17 - https://phabricator.wikimedia.org/T151952#2923907 (10cscott) @brion -- ping. Can you pull together 10-ish slides on {T147604} or A/V in general? I'll write up no-more-... [17:56:32] (03CR) 10Jack Phoenix: [C: 032] jQuery 3.0 readiness: swap .bind() (deprecated in jQuery 1.7) to .on() [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330953 (owner: 10Jack Phoenix) [17:57:06] (03PS1) 10Bearloga: Deploy all-country breakdown on Portal dash [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/330954 [17:57:11] 10Social-Tools, 10Video (non-WMF), 10Wikimedia-Video: Cross-functional support for rich media - https://phabricator.wikimedia.org/T147604#2923909 (10cscott) @brion, can you come up with no-more-than-ten slides to introduce & overview this topic? [17:58:22] (03CR) 10jerkins-bot: [V: 04-1] jQuery 3.0 readiness: swap .bind() (deprecated in jQuery 1.7) to .on() [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330953 (owner: 10Jack Phoenix) [17:58:29] (03PS1) 10DCausse: Add support for extra regex timeout [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330955 (https://phabricator.wikimedia.org/T152895) [17:58:56] (03CR) 10Bearloga: [V: 032 C: 032] "LGTM" [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/330954 (owner: 10Bearloga) [18:00:12] (03CR) 10Jack Phoenix: [V: 032 C: 032] jQuery 3.0 readiness: swap .bind() (deprecated in jQuery 1.7) to .on() [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330953 (owner: 10Jack Phoenix) [18:00:28] (03PS14) 10Dbrant: Echo notifications for description edits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) [18:00:48] (03CR) 10Mholloway: "Testing this manually now that Dmitry's patch is merged, Retrofit/Gson doesn't actually seem to have a problem handling the empty array in" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330819 (https://phabricator.wikimedia.org/T154032) (owner: 10Mholloway) [18:01:06] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/330956 [18:02:58] (03CR) 10Jack Phoenix: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/330956 (owner: 10Jack Phoenix) [18:03:12] 10MediaWiki-extensions-MultimediaViewer: Could not load an image in zh.wikipedia.org - https://phabricator.wikimedia.org/T154780#2923924 (10Aklapper) There were known issues serving images around the time this was reported. Things should be recovering now. Can this still be reproduced (because I cannot)? [18:04:14] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/330956 (owner: 10Jack Phoenix) [18:04:57] (03CR) 10BearND: [C: 04-1] "Mhurd: some comments for you inline." (0314 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330820 (https://phabricator.wikimedia.org/T143408) (owner: 10Mhurd) [18:04:59] (03PS1) 10BryanDavis: Change default branch for this feature branch [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/330958 [18:05:31] bearND: oh cool thanks! will check feedback later today [18:05:33] (03CR) 10BryanDavis: [C: 032] Change default branch for this feature branch [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/330958 (owner: 10BryanDavis) [18:05:45] (03Merged) 10jenkins-bot: Change default branch for this feature branch [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/330958 (owner: 10BryanDavis) [18:06:24] (03CR) 10jenkins-bot: Change default branch for this feature branch [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/330958 (owner: 10BryanDavis) [18:06:51] 10MediaWiki-extensions-MultimediaViewer: Cache and media (images) issues on all Wikimedia wikis - creates problems on upload, display and generation of thumbnails and files - https://phabricator.wikimedia.org/T154780#2923925 (10jcrespo) [18:07:04] 10MediaWiki-extensions-Scribunto: When "Erreur Lua : attempt to call a string value", where? - https://phabricator.wikimedia.org/T154769#2923926 (10Aklapper) Hi @Rical, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce the proble... [18:07:26] (03CR) 10Catrope: [C: 032] "PS11 is a rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [18:08:25] (03CR) 10Catrope: [C: 032] Throw when unserializing invalid Flow workflow metadata JSON [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330624 (https://phabricator.wikimedia.org/T154623) (owner: 10Mattflaschen) [18:08:27] (03PS54) 10Paladox: Add extension.json, empty PHP entry point [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/208523 (https://phabricator.wikimedia.org/T100425) [18:09:45] (03PS1) 10Jack Phoenix: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [skins/Tempo] - 10https://gerrit.wikimedia.org/r/330960 [18:10:04] 06WMF-NDA-Requests: Volunteer NDA for Eranroz - https://phabricator.wikimedia.org/T154688#2923959 (10Aklapper) Confirming that eranroz has signed L2. Next in https://wikitech.wikimedia.org/wiki/Volunteer_NDA is "Get sign off by a C-level staff of the Wikimedia Foundation." [18:10:10] 10MediaWiki-API: rcnamespace=* does not include negative namespaces - https://phabricator.wikimedia.org/T154319#2923960 (10Anomie) a:03Anomie [18:10:18] 10MediaWiki-extensions-ConfirmAccount: Unable to save a CV/resume with some configurations - https://phabricator.wikimedia.org/T121119#2923963 (10Paladox) [18:10:26] (03CR) 10jerkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/208523 (https://phabricator.wikimedia.org/T100425) (owner: 10Paladox) [18:10:48] (03PS1) 10Anomie: API: Allow finding log events and links to special pages [core] - 10https://gerrit.wikimedia.org/r/330961 (https://phabricator.wikimedia.org/T154319) [18:11:27] (03PS55) 10Paladox: Add extension.json, empty PHP entry point [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/208523 (https://phabricator.wikimedia.org/T100425) [18:11:38] (03CR) 10Niedzielski: [C: 04-1] "The only thing that's really hanging me out is the purpose of the Service in this patch. It seems like the BroadcastReceiver can manage it" (036 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [18:15:50] (03CR) 10BearND: [C: 04-1] "one more" (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330820 (https://phabricator.wikimedia.org/T143408) (owner: 10Mhurd) [18:16:28] (03Merged) 10jenkins-bot: Throw when unserializing invalid Flow workflow metadata JSON [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330624 (https://phabricator.wikimedia.org/T154623) (owner: 10Mattflaschen) [18:16:46] (03CR) 10jenkins-bot: Throw when unserializing invalid Flow workflow metadata JSON [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330624 (https://phabricator.wikimedia.org/T154623) (owner: 10Mattflaschen) [18:17:33] (03PS1) 10Jack Phoenix: jQuery 3.0 compatibility fixes [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/330962 [18:19:00] (03PS1) 10BryanDavis: Add a .gitreview file [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330963 [18:19:29] halfak: well... It worked for me. [18:19:34] ^^ [18:19:56] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330955 (https://phabricator.wikimedia.org/T152895) (owner: 10DCausse) [18:20:17] o/ bd808 [18:20:23] What worked for you? [18:20:42] I pushed a new changeset to the wmflabs branch using git-review [18:21:09] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330955 (https://phabricator.wikimedia.org/T152895) (owner: 10DCausse) [18:21:13] bd808, I wonder if it's related to me pushing this exact change to gerrit as a patchset of master before I abandoned it. [18:21:19] I did that with a different branch name. [18:21:31] but would have been the came commit hash [18:21:45] * halfak tries to think of something else that is worth changing [18:21:47] ah. that may be. same change-id too? [18:22:53] 06Discovery, 06Discovery-Search, 10Elasticsearch, 10Wikimedia-Logstash: Increase heap size for logstash - https://phabricator.wikimedia.org/T154793#2924000 (10Paladox) [18:22:56] (03PS1) 10Halfak: Bumps revscoring to 1.3.3, pywikibase to 0.0.3, deltas to 0.4.2, and mwapi to 0.5.1. [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330964 [18:23:01] (03CR) 10BryanDavis: "Not sure if this is actually useful or not. The repo doesn't seem to have a .gitreview on master either." [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330963 (owner: 10BryanDavis) [18:23:02] OMG it worked! [18:23:17] I changed something and ammended the commit! [18:23:18] (03CR) 10Addshore: [C: 032] jQuery 3.0 compatibility fixes [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/330962 (owner: 10Jack Phoenix) [18:23:22] 10Wikimedia-Logstash: Exception in thread "Ruby-0-Thread-18: /opt/logstash/vendor/bundle/jruby/1.9/gems/stud-0.0.20/lib/stud/buffer.rb:92" java.lang.UnsupportedOperationException - https://phabricator.wikimedia.org/T154732#2922192 (10Paladox) [18:23:24] 06Discovery, 06Discovery-Search, 10Elasticsearch, 10Wikimedia-Logstash: Increase heap size for logstash - https://phabricator.wikimedia.org/T154793#2924019 (10Paladox) [18:23:31] bd808: <3 thanks for your help [18:23:39] * bd808 is a good rubber duck [18:24:05] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Better recommending of tasks suitable for new technical contributors - https://phabricator.wikimedia.org/T149564#2924023 (10Miriya52) [18:24:10] :P I dunno if this was a rubber duck solution [18:24:19] (03Merged) 10jenkins-bot: jQuery 3.0 compatibility fixes [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/330962 (owner: 10Jack Phoenix) [18:24:49] (03CR) 10Halfak: [V: 032 C: 032] Bumps revscoring to 1.3.3, pywikibase to 0.0.3, deltas to 0.4.2, and mwapi to 0.5.1. [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330964 (owner: 10Halfak) [18:25:33] (03CR) 10Isarra: [C: 032] Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [skins/Tempo] - 10https://gerrit.wikimedia.org/r/330960 (owner: 10Jack Phoenix) [18:25:56] (03Merged) 10jenkins-bot: Swapped $( document ).ready( someFunc ) to $( someFunc ) since .ready will be deprecated in jQuery 3.0 [skins/Tempo] - 10https://gerrit.wikimedia.org/r/330960 (owner: 10Jack Phoenix) [18:25:58] 06Discovery, 06Discovery-Search, 10Elasticsearch, 10Wikimedia-Logstash: Increase heap size for logstash - https://phabricator.wikimedia.org/T154793#2924026 (10Paladox) [18:27:12] 10MediaWiki-extensions-Quiz, 10Possible-Tech-Projects: Provide some love to the Quiz extension - https://phabricator.wikimedia.org/T148969#2924042 (10Harjotsingh) @Mvolz Will this task be available for Gsoc 2017 ? Please add some microtasks. I'm interested in working on this. [18:27:16] (03CR) 10Niedzielski: [C: 04-1] Enwiki "On This Day" endpoints. (034 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330820 (https://phabricator.wikimedia.org/T143408) (owner: 10Mhurd) [18:28:51] (03Abandoned) 10BryanDavis: Add a .gitreview file [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330963 (owner: 10BryanDavis) [18:31:40] 10MediaWiki-extensions-ParserFunctions, 13Patch-For-Review, 07Software-Licensing, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Change ParserFunctions license to GPL-2.0+ - https://phabricator.wikimedia.org/T125322#2924043 (10Huji) No objections to +2. [18:34:22] 10MediaWiki-extensions-CheckUser, 07Availability: CheckUser opens DB master connection when email is sent - https://phabricator.wikimedia.org/T154795#2924044 (10Catrope) [18:34:38] 10MediaWiki-General-or-Unknown, 07Availability, 05MW-1.28-release-notes, 13Patch-For-Review, 07Wikimedia-Multiple-active-datacenters: Fix problematic database master queries performed on HTTP GET/HEAD - https://phabricator.wikimedia.org/T92357#2924057 (10Catrope) [18:34:41] 10MediaWiki-extensions-CheckUser, 07Availability: CheckUser opens DB master connection when email is sent - https://phabricator.wikimedia.org/T154795#2924056 (10Catrope) [18:35:35] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Newsletter extension doesn't explain how notifications will be received - https://phabricator.wikimedia.org/T154770#2924058 (10Peteforsyth) Elegant solution, @QuimGil. One tiny adjustment, I'd remove the word "been," so it reads simply: > You have subs... [18:38:34] 06Reading-analysis: Readership metrics report - https://phabricator.wikimedia.org/T148261#2924061 (10Zareenf) [18:38:43] (03PS1) 10Halfak: Removes deltas & mwapi duplicates. [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330966 [18:38:58] (03CR) 10Halfak: [V: 032 C: 032] Removes deltas & mwapi duplicates. [research/ores/wheels] (wmflabs) - 10https://gerrit.wikimedia.org/r/330966 (owner: 10Halfak) [18:41:03] (03CR) 10Mholloway: [C: 04-1] "Just got the following crash while testing manually:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [18:41:54] (03CR) 10Mhurd: "Thanks for the code review! :) Hope to have time later today to start fixing the issues raised." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330820 (https://phabricator.wikimedia.org/T143408) (owner: 10Mhurd) [18:44:03] (03PS1) 10VictorPorton: switched to ParserAfterParse hook, does not work yet [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/330967 [18:46:06] (03PS1) 10Catrope: Defer the DB write in updateCUEmailData [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/330968 (https://phabricator.wikimedia.org/T154795) [18:47:22] (03CR) 10Catrope: "I'm not sure if this is the right approach: should we instead just make all code paths that send email declare that they are going to perf" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/330968 (https://phabricator.wikimedia.org/T154795) (owner: 10Catrope) [18:47:24] (03PS2) 10Dbrant: Check for notifications only for 1 day after last description edit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 [18:49:16] 10MediaWiki-extensions-CheckUser, 07Availability, 13Patch-For-Review: CheckUser opens DB master connection when email is sent - https://phabricator.wikimedia.org/T154795#2924079 (10Catrope) [18:51:21] 10MediaWiki-Internationalization, 03Google-Code-In-2016: Create a {{PAGELANGUAGE}} magic word - https://phabricator.wikimedia.org/T59603#2924080 (10divadsn) a:03divadsn [18:51:27] (03PS1) 10Sbisson: Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) [18:53:48] (03CR) 10Catrope: [C: 032] Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) (owner: 10Sbisson) [18:56:29] nuria: Aha, we added a param to that schema recently so it looks like we may have screwed that up, thanks for flagging [18:56:59] RoanKattouw: ok, you know how to fix and all? [18:57:20] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924088 (10Stevietheman) OK, I'm trying to understand. At this point, I don't understand why a rollback would be different from an undo of the directly pre... [18:57:20] nuria: Hmm I'm confused about why your example doesn't validate [18:57:28] Is it because "0" is a string rather than an integer? [18:57:57] (03CR) 10BearND: [C: 04-1] "It does look cleaner. Turns out that most of the api.checkResponseStatus are not needed anymore since preq checks that already. The one in" (034 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330583 (owner: 10Niedzielski) [18:57:59] RoanKattouw: yes, i think so, it is easy to test locally or even in beta cluster [18:58:06] OK [18:58:47] RoanKattouw: let me send you a link [18:59:02] I'm using MWV, how do I get to the validation errors log? [19:00:00] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint, 07I18n, 07RTL: language and direction are not set at the wikimedia.org portal - https://phabricator.wikimedia.org/T154349#2924091 (10debt) p:05Triage>03Normal [19:00:07] Sigh, Gerrit just went down [19:00:27] Good time for me to get ready and go into the office I guess [19:00:34] Oh, nope, it's back up [19:00:46] (03CR) 10BearND: [C: 032] Hygiene: simplify most-read-filter.filterBotTraffic() [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330617 (owner: 10Niedzielski) [19:00:54] (03Draft1) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/330972 (https://phabricator.wikimedia.org/T1) [19:01:24] RoanKattouw: https://wikitech.wikimedia.org/wiki/Analytics/EventLogging/TestingOnBetaCluster [19:01:26] (03Merged) 10jenkins-bot: Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) (owner: 10Sbisson) [19:01:28] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924095 (10daniel) @Stevietheman I think one major difference is that only admins can revert, but anyone can undo. So reverts are more likely to be trustwor... [19:01:46] (03CR) 10jenkins-bot: Make 'hidepageedits' filter out all Flow changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330970 (https://phabricator.wikimedia.org/T154486) (owner: 10Sbisson) [19:01:48] RoanKattouw: beta cluster set up is less than perfect, if things are not working ping us and we will look at it [19:01:55] OK [19:01:57] (03Abandoned) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/330972 (https://phabricator.wikimedia.org/T1) (owner: 10Paladox) [19:03:33] (03CR) 10Mholloway: "+1 to Niedzielski's comment, otherwise LGTM" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 (owner: 10Dbrant) [19:04:07] (03PS1) 10Catrope: onChangesListSpecialPageFilters: Actually treat namespace as an integer [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/330973 (https://phabricator.wikimedia.org/T154395) [19:04:26] nuria: I think that --^^ should do it, but I'll test in beta later today [19:04:40] RoanKattouw: k [19:07:46] 10MediaWiki-extensions-CheckUser, 06Collaboration-Team-Triage, 10Flow: Flow links formatting fail on Special:CheckUser - https://phabricator.wikimedia.org/T154796#2924116 (10SBisson) [19:08:35] 06MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit (2017): #mwstake meeting at the Developers Summit - https://phabricator.wikimedia.org/T149586#2924128 (10MarkAHershberger) [19:10:03] 06MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit (2017): #mwstake meeting at the Developers Summit - https://phabricator.wikimedia.org/T149586#2757062 (10MarkAHershberger) [19:10:53] 06MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit (2017): #mwstake meeting at the Developers Summit - https://phabricator.wikimedia.org/T149586#2924134 (10MarkAHershberger) >>! In T149586#2923906, @Qgil wrote: > I guess the MediaWiki Stakeholders Group wants this meeting to happen? If so, please fol... [19:11:03] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924138 (10Anomie) @Stevietheman: This task was originally fairly simple: there's an existing option to hide bot edits, which behaves as "show the most rece... [19:12:43] (03PS11) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [19:14:24] (03PS10) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [19:15:53] (03CR) 10VictorPorton: [C: 04-1] "https://lists.wikimedia.org/pipermail/wikitech-l/2017-January/087358.html" [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/330967 (owner: 10VictorPorton) [19:17:44] (03CR) 10BryanDavis: [C: 032] Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [19:20:44] (03PS1) 10Umherirrender: Use https when linking www.mediawiki.org [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/330977 [19:21:11] (03Merged) 10jenkins-bot: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [19:21:40] (03CR) 10Aaron Schulz: [C: 04-1] Defer the DB write in updateCUEmailData (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/330968 (https://phabricator.wikimedia.org/T154795) (owner: 10Catrope) [19:21:58] (03PS1) 10Jack Phoenix: Coding style and documentation format tweaks [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/330978 [19:22:12] (03CR) 10jenkins-bot: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [19:23:09] 06Developer-Relations (Jan-Mar-2017): A process to use available information about new and leaving technical contributors - https://phabricator.wikimedia.org/T137214#2924162 (10Aklapper) [19:23:11] (03CR) 10jerkins-bot: [V: 04-1] Coding style and documentation format tweaks [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/330978 (owner: 10Jack Phoenix) [19:23:12] (03PS15) 10Dbrant: Echo notifications for description edits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) [19:23:37] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2924164 (10Aklapper) [19:24:15] (03PS2) 10Jack Phoenix: Coding style and documentation format tweaks [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/330978 [19:25:20] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924167 (10JEumerus) So in other words, a two pronged fix: Have the watchlist display the latest non-bot edit and prod the operators of bots who roll back u... [19:28:28] (03CR) 10Dbrant: "r4r! Also resolved Michael's crash (and added a test)." (036 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [19:29:21] (03PS3) 10Dbrant: Check for notifications only for 1 day after last description edit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 [19:31:55] 10MediaWiki-extensions-Quiz, 10Possible-Tech-Projects: Provide some love to the Quiz extension - https://phabricator.wikimedia.org/T148969#2924199 (10Mvolz) [19:33:40] 06Discovery, 06Discovery-Analysis (Current work): Maps Dashboard - add notation for increased tile usage - https://phabricator.wikimedia.org/T154717#2924200 (10mpopov) Yup, that checks out: {F5243456} ```lang=R, lines=4 library(magrittr) query <- "SELECT CONCAT('2016/11/', day) AS date, CASE WHEN IN... [19:34:01] (03CR) 10Dbrant: Check for notifications only for 1 day after last description edit. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 (owner: 10Dbrant) [19:34:02] 10Android-app-Bugs, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] NPE at org.wikipedia.edit.preview.Wikitext$Query.wikitext() - https://phabricator.wikimedia.org/T152982#2924202 (10Mholloway) a:03Mholloway [19:37:56] 10Android-app-Bugs, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] NPE at org.wikipedia.edit.preview.Wikitext$Query.wikitext() - https://phabricator.wikimedia.org/T152982#2924208 (10Mholloway) Hmm, I've found a way to induce a crash (by disappearing the section the user intends to edit... [19:38:45] (03CR) 10Niedzielski: [C: 031] Check for notifications only for 1 day after last description edit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 (owner: 10Dbrant) [19:41:02] 04(no projects): check rsync of dumps to labs, there seems to be a delay - https://phabricator.wikimedia.org/T154798#2924211 (10ArielGlenn) [19:41:22] (03PS1) 10Bearloga: Note pkget tile usage [wikimedia/discovery/wetzel] - 10https://gerrit.wikimedia.org/r/330980 (https://phabricator.wikimedia.org/T154717) [19:41:44] (03CR) 10Bearloga: [V: 032 C: 032] Note pkget tile usage [wikimedia/discovery/wetzel] - 10https://gerrit.wikimedia.org/r/330980 (https://phabricator.wikimedia.org/T154717) (owner: 10Bearloga) [19:42:46] (03CR) 10Niedzielski: [C: 031] Echo notifications for description edits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [19:42:57] (03PS1) 10Bearloga: Add pkget tile usage note to Maps dash [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/330981 (https://phabricator.wikimedia.org/T154717) [19:43:03] (03CR) 10Bearloga: [V: 032 C: 032] Add pkget tile usage note to Maps dash [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/330981 (https://phabricator.wikimedia.org/T154717) (owner: 10Bearloga) [19:43:10] 10InternetArchiveBot (v1.3): Stray dead link template - https://phabricator.wikimedia.org/T154541#2924236 (10Green_Cardamom) In regards to the stray dead link problem: I've written a module to WaybackMedic which checks for and removes dead link templates when there is an existing archive URL. It completed a run... [19:43:25] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924237 (10Stevietheman) @daniel, If an approved bot does a rollback or an undo of directly preceding edits, I assume it's performing an approved task and t... [19:46:03] (03PS1) 10Divadsn: Add a new {{PAGELANGUAGE}} variable for use in wikitext [core] - 10https://gerrit.wikimedia.org/r/330982 (https://phabricator.wikimedia.org/T59603) [19:46:44] 06Discovery, 06Discovery-Analysis (Current work): Maps Dashboard - add notation for increased tile usage - https://phabricator.wikimedia.org/T154717#2924255 (10mpopov) Noted in production: http://discovery.wmflabs.org/maps/#tiles_summary [19:48:19] 10MediaWiki-Internationalization, 03Google-Code-In-2016, 13Patch-For-Review: Create a {{PAGELANGUAGE}} magic word - https://phabricator.wikimedia.org/T59603#2924262 (10divadsn) I was not able to create a test in tests/parser/parserTests.txt, as my editor was crashing each time I tried to change the file on m... [19:49:56] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924270 (10daniel) @Stevietheman Oh, are we talking about bot edits only? If a *bot* does it, I don't see a difference between a revert and an undo. [19:50:09] (03CR) 10jerkins-bot: [V: 04-1] Add a new {{PAGELANGUAGE}} variable for use in wikitext [core] - 10https://gerrit.wikimedia.org/r/330982 (https://phabricator.wikimedia.org/T59603) (owner: 10Divadsn) [19:51:31] 10MediaWiki-Database, 05MW-1.28-release, 05MW-1.28-release-notes, 05MW-1.29-release-notes, and 3 others: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2728214 (10Ninjavz) Just to post the error of today. Seems not fixed yet. This... [19:53:07] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924278 (10Stevietheman) @JEumerus - that sounds right. I just wonder if there ''are'' any bots using undo instead of rollback for directly preceding edits... [19:57:40] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924283 (10Stevietheman) @daniel, yes. Now, I guess we have a different discussion with regards to 'Hide my edits' and 'Hide minor edits', the former being... [19:58:27] (03Abandoned) 10Niedzielski: Demo: encapsulate DescriptionEditTutorialPageView children [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325859 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [20:01:46] (03PS1) 10Smalyshev: fix typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330987 [20:02:50] (03CR) 10Umherirrender: [C: 032] fix typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330987 (owner: 10Smalyshev) [20:03:09] (03PS3) 10Niedzielski: WIP: Allow hacks.less inclusion to be configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326192 (https://phabricator.wikimedia.org/T94102) [20:03:31] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2924297 (10Volker_E) Thanks @Isarra for the insights, this sheds a light on the color coding in use. One more wor... [20:04:59] (03CR) 10VolkerE: [C: 032] Align colors with Wikimedia color palette. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 (https://phabricator.wikimedia.org/T153049) (owner: 10Ladsgroup) [20:06:46] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#2924298 (10Stevietheman) @Anomie, I edited my response to you above for (hopefully) clarity. [20:07:39] (03PS1) 10Umherirrender: Add grunt-jsonlint and grunt-banana-checker [skins/CustomPage] - 10https://gerrit.wikimedia.org/r/330989 (https://phabricator.wikimedia.org/T94547) [20:07:49] (03PS2) 10Divadsn: Add a new {{PAGELANGUAGE}} variable for use in wikitext [core] - 10https://gerrit.wikimedia.org/r/330982 (https://phabricator.wikimedia.org/T59603) [20:08:24] (03PS1) 10Umherirrender: Add grunt-jsonlint and grunt-banana-checker [skins/erudite] - 10https://gerrit.wikimedia.org/r/330990 (https://phabricator.wikimedia.org/T94547) [20:08:55] (03PS1) 10Umherirrender: Add grunt-jsonlint and grunt-banana-checker [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/330991 (https://phabricator.wikimedia.org/T94547) [20:09:09] (03PS1) 10Umherirrender: Add grunt-jsonlint and grunt-banana-checker [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) [20:09:21] (03PS1) 10Umherirrender: Add grunt-jsonlint and grunt-banana-checker [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/330993 (https://phabricator.wikimedia.org/T94547) [20:09:36] (03PS1) 10Umherirrender: Add grunt-jsonlint and grunt-banana-checker [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330994 (https://phabricator.wikimedia.org/T94547) [20:09:47] (03Merged) 10jenkins-bot: fix typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330987 (owner: 10Smalyshev) [20:10:25] (03CR) 10VolkerE: [C: 032] "@Isarra I hope that aiming at things to improve over the former version when we're already revisiting them isn't seen as a negative attitu" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 (https://phabricator.wikimedia.org/T153049) (owner: 10Ladsgroup) [20:10:48] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2924305 (10Volker_E) 05Open>03Resolved [20:11:05] (03Merged) 10jenkins-bot: Align colors with Wikimedia color palette. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 (https://phabricator.wikimedia.org/T153049) (owner: 10Ladsgroup) [20:11:19] 10Dumps-Generation: check rsync of dumps to labs, there seems to be a delay - https://phabricator.wikimedia.org/T154798#2924309 (10Aklapper) #Dumps-Generation, I guess? :) [20:11:23] (03PS1) 10Smalyshev: Alphabetize hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330995 [20:12:37] 06Reading-Web-Backlog, 10Page-Previews (2016-17-Q3-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-89-🎂: Add preview type to hovercards schema - https://phabricator.wikimedia.org/T152004#2924316 (10Tbayer) >>! In T152004#2923698, @jhobs wrote: .... > @tbayer there's no need for logging it during settings c... [20:12:40] (03CR) 10Mholloway: [C: 04-1] "Please bear with me while I keep rooting out probable corner cases :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [20:15:00] (03CR) 10Mholloway: [C: 031] Check for notifications only for 1 day after last description edit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/330693 (owner: 10Dbrant) [20:18:21] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330987 (owner: 10Smalyshev) [20:19:59] 10InternetArchiveBot (v1.3): Spacing in external links - https://phabricator.wikimedia.org/T152102#2924327 (10Cyberpower678) 05Open>03Resolved Fixed in v1.3. [20:20:16] 10InternetArchiveBot (v1.3): InternetArchiveBot erroneously changed a tag by a tag - https://phabricator.wikimedia.org/T151905#2924329 (10Cyberpower678) p:05Triage>03Normal [20:20:35] (03CR) 10Umherirrender: "check experimental" [skins/CustomPage] - 10https://gerrit.wikimedia.org/r/330989 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:20:37] (03CR) 10Umherirrender: "check experimental" [skins/erudite] - 10https://gerrit.wikimedia.org/r/330990 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:20:39] (03CR) 10Umherirrender: "check experimental" [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/330991 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:20:41] (03CR) 10Umherirrender: "check experimental" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:20:44] (03CR) 10Umherirrender: "check experimental" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330994 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:20:46] (03CR) 10Umherirrender: "check experimental" [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/330993 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:21:07] (03CR) 10jerkins-bot: [V: 04-1] Add a new {{PAGELANGUAGE}} variable for use in wikitext [core] - 10https://gerrit.wikimedia.org/r/330982 (https://phabricator.wikimedia.org/T59603) (owner: 10Divadsn) [20:25:03] (03CR) 10Hashar: "recheck" [skins/CustomPage] - 10https://gerrit.wikimedia.org/r/330989 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:25:05] (03CR) 10Hashar: "recheck" [skins/erudite] - 10https://gerrit.wikimedia.org/r/330990 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:25:08] (03CR) 10Hashar: "recheck" [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/330991 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:25:11] (03CR) 10Hashar: "recheck" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:25:15] (03CR) 10Hashar: "recheck" [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/330993 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:25:18] (03CR) 10Hashar: "recheck" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330994 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:28:30] (03CR) 1020after4: [C: 031] remove "show block log for user" button [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/214023 (https://phabricator.wikimedia.org/T11315) (owner: 10Microchip08) [20:30:41] 06Reading-Infrastructure-Team, 10Wikimedia-Video: inconsistent behaviour for video display in different formats - https://phabricator.wikimedia.org/T154800#2924330 (10eranroz) [20:33:12] (03CR) 10Hashar: [C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/CustomPage] - 10https://gerrit.wikimedia.org/r/330989 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:33:34] (03CR) 10Hashar: [C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/erudite] - 10https://gerrit.wikimedia.org/r/330990 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:33:49] (03CR) 10Hashar: [C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/330991 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:33:57] (03PS4) 10Niedzielski: New: allow hacks.less inclusion to be configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326192 (https://phabricator.wikimedia.org/T94102) [20:34:11] (03CR) 10Hashar: [C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:34:17] (03Merged) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/CustomPage] - 10https://gerrit.wikimedia.org/r/330989 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:34:19] (03CR) 10Hashar: [C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/330993 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:34:31] (03CR) 10Hashar: [C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330994 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:35:18] (03CR) 10Niedzielski: "@bmansurov @jdlrobson, thanks and done!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326192 (https://phabricator.wikimedia.org/T94102) (owner: 10Niedzielski) [20:35:20] (03CR) 10Hashar: [C: 032] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:35:27] (03Merged) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/erudite] - 10https://gerrit.wikimedia.org/r/330990 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:35:44] (03Merged) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/330991 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:36:26] (03Merged) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/330993 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:36:43] (03Merged) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330994 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:36:58] (03CR) 10jerkins-bot: [V: 04-1] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:37:10] (03CR) 10Hashar: [C: 032] Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 (owner: 10Umherirrender) [20:37:14] 10Wikimedia-Video: inconsistent behaviour for video display in different formats - https://phabricator.wikimedia.org/T154800#2924348 (10Anomie) [20:37:19] (03CR) 10jerkins-bot: [V: 04-1] Add grunt-jsonlint and grunt-banana-checker [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:38:16] (03CR) 10jerkins-bot: [V: 04-1] Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 (owner: 10Umherirrender) [20:38:31] (03CR) 10Hashar: [V: 032 C: 032] Add grunt-jsonlint and grunt-banana-checker [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:38:37] (03CR) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/330994 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:39:31] (03CR) 10Hashar: [V: 032 C: 032] Remove non-exist descriptionmsg key [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/330445 (owner: 10Umherirrender) [20:39:47] (03CR) 10Hashar: [C: 032] Remove non-exist descriptionmsg key [extensions/StringFunctionsEscaped] - 10https://gerrit.wikimedia.org/r/330699 (owner: 10Umherirrender) [20:41:53] (03CR) 10jenkins-bot: Add grunt-jsonlint and grunt-banana-checker [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/330993 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:42:36] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330995 (owner: 10Smalyshev) [20:42:38] (03CR) 10jerkins-bot: [V: 04-1] Remove non-exist descriptionmsg key [extensions/StringFunctionsEscaped] - 10https://gerrit.wikimedia.org/r/330699 (owner: 10Umherirrender) [20:42:55] (03CR) 10Hashar: [C: 032] Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 (owner: 10Umherirrender) [20:43:39] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/330995 (owner: 10Smalyshev) [20:43:41] (03CR) 10Hashar: [C: 032] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:43:54] (03CR) 10jerkins-bot: [V: 04-1] Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 (owner: 10Umherirrender) [20:45:37] (03CR) 10jerkins-bot: [V: 04-1] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:46:50] (03CR) 1020after4: [C: 031] Add scap3 control files [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326872 (https://phabricator.wikimedia.org/T129134) (owner: 10BryanDavis) [20:46:59] (03CR) 10Hashar: [C: 032] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:49:05] (03CR) 10jerkins-bot: [V: 04-1] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:49:46] (03CR) 10Hashar: [C: 032] Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:50:25] (03PS16) 10Dbrant: Echo notifications for description edits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) [20:50:44] (03Merged) 10jenkins-bot: Activate grunt-banana-checker [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/330927 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [20:51:04] (03CR) 10Hashar: [C: 032] Remove non-exist descriptionmsg key [extensions/StringFunctionsEscaped] - 10https://gerrit.wikimedia.org/r/330699 (owner: 10Umherirrender) [20:51:10] (03CR) 10Hashar: [C: 032] Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 (owner: 10Umherirrender) [20:52:04] (03Merged) 10jenkins-bot: Remove non-exist descriptionmsg key [extensions/StringFunctionsEscaped] - 10https://gerrit.wikimedia.org/r/330699 (owner: 10Umherirrender) [20:52:15] 10MobileFrontend, 10Reading-Community-Engagement, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Change the search bar width and placement on tablets - https://phabricator.wikimedia.org/T152459#2924386 (10Nirzar) @Jdlrobson the non JS experience looks okay. dedicated search page. this solves an... [20:52:21] (03Merged) 10jenkins-bot: Add missing message to qqq.json [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/330929 (owner: 10Umherirrender) [20:54:32] (03PS1) 10Catrope: CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) [20:54:49] 10MediaWiki-extensions-JsonConfig, 10Commons-Datasets: Double wrapped error message for Commons tabular data - https://phabricator.wikimedia.org/T154561#2924396 (10debt) [20:55:39] 10MediaWiki-extensions-JsonConfig, 10Commons-Datasets, 03Interactive-Sprint: Double wrapped error message for Commons tabular data - https://phabricator.wikimedia.org/T154561#2915800 (10debt) p:05Triage>03Normal [20:56:57] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2924409 (10Isarra) >>! In T153049#2924297, @Volker_E wrote: > One more word on consistency, consistency is good, but if the pattern unde... [20:56:58] (03CR) 10Hashar: [C: 032] Use https when linking www.mediawiki.org [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/330977 (owner: 10Umherirrender) [20:57:07] (03Merged) 10jenkins-bot: Use https when linking www.mediawiki.org [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/330977 (owner: 10Umherirrender) [20:57:41] (03CR) 10Hashar: [C: 032] Standarize messages in qqq.json [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/330933 (owner: 10Umherirrender) [20:57:47] (03Merged) 10jenkins-bot: Standarize messages in qqq.json [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/330933 (owner: 10Umherirrender) [20:57:59] (03CR) 10Hashar: [C: 032] Standarize desc and right message in qqq.json [extensions/StaffEdits] - 10https://gerrit.wikimedia.org/r/330928 (owner: 10Umherirrender) [20:58:21] (03PS2) 10Hashar: Add missing messages to qqq.json [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330925 (owner: 10Umherirrender) [20:58:50] (03Merged) 10jenkins-bot: Standarize desc and right message in qqq.json [extensions/StaffEdits] - 10https://gerrit.wikimedia.org/r/330928 (owner: 10Umherirrender) [20:59:31] (03PS9) 10Anomie: Add $wgSoftBlockRanges [core] - 10https://gerrit.wikimedia.org/r/324214 [21:00:09] (03CR) 10BryanDavis: "> Looks fine (but might be worth checking out base::service_unit from" [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329619 (https://phabricator.wikimedia.org/T154273) (owner: 10BryanDavis) [21:01:04] (03PS3) 10BryanDavis: Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) [21:01:11] (03CR) 10BryanDavis: [V: 032] Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) (owner: 10BryanDavis) [21:01:15] 10Technical-Collaboration-Guideline, 06Community-Liaisons (Jan-Mar 2017), 10Wikimedia-Developer-Summit (2017): Technical Collaboration Guideline: A Collaboration - https://phabricator.wikimedia.org/T148878#2924421 (10jmatazzoni) [21:01:25] (03CR) 10BryanDavis: [C: 032] Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) (owner: 10BryanDavis) [21:01:35] (03Merged) 10jenkins-bot: Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) (owner: 10BryanDavis) [21:01:43] 07Design, 06Collaboration-Team-Triage, 10Flow: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#2924424 (10Catrope) 05Resolved>03declined Per T154762 the lack of a gap was deliberate, and has been restored. [21:02:48] * AaronSchulz just notices there is a win10 Wikipedia app [21:03:36] (03CR) 10jenkins-bot: Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) (owner: 10BryanDavis) [21:03:42] 07Design, 06Collaboration-Team-Triage, 10Flow: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#2924431 (10Catrope) 05declined>03Open Hmm, I see the concern here was not just about the gap but also about the fact that there are touching boxes that have rounded corners. I'l... [21:04:05] 10MediaWiki-extensions-Scribunto: When "Erreur Lua : attempt to call a string value", where? - https://phabricator.wikimedia.org/T154769#2924435 (10Rical) * To protect central modules T135845 against runing errors which "kill" pages my antiCollapse() function masks the error, add a category-alert and replace the... [21:04:20] (03PS1) 10Hashar: Update npm dependencies to latest [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/331001 [21:04:51] 10UI-Standardization, 03UI-Standardization-Kanban: Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component - https://phabricator.wikimedia.org/T127405#2924438 (10Volker_E) [21:05:54] (03CR) 10Dbrant: "@MHolloway Corner case(s) addressed! As for your first comment, I'm not sure it's new to this patch, and it's also a thorny issue to conte" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [21:07:00] 10MediaWiki-Unit-tests, 10MediaWiki-extensions-General-or-Unknown, 07Easy: Extension Comments failing tests due to missing apihelp messages - https://phabricator.wikimedia.org/T154604#2924440 (10Umherirrender) [21:07:02] (03PS1) 10Hashar: build: add npm based test tools [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 [21:07:10] (03CR) 10Hashar: [C: 032] Add missing messages to qqq.json [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330925 (owner: 10Umherirrender) [21:07:18] [13composer-merge-plugin] 15legoktm pushed 2 new commits to 06master: 02https://github.com/wikimedia/composer-merge-plugin/compare/e8aa6a9684f2...e24d531a2904 [21:07:18] 13composer-merge-plugin/06master 14f505c8d 15Bryan Davis: Register callbacks with highest priority... [21:07:18] 13composer-merge-plugin/06master 14e24d531 15Kunal Mehta: Merge pull request #131 from bd808/bug/99... [21:07:18] (03Merged) 10jenkins-bot: Add missing messages to qqq.json [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/330925 (owner: 10Umherirrender) [21:07:50] 06Research-and-Data: Hash IPs on webrequest table - https://phabricator.wikimedia.org/T150545#2924442 (10Nuria) [21:08:05] (03PS2) 10Awu42: Replaced usage of Linker::getLinkAttributesInternal [extensions/Video] - 10https://gerrit.wikimedia.org/r/330840 (https://phabricator.wikimedia.org/T61113) [21:08:17] (03PS1) 10Ladsgroup: Small adjustment in "soft" color to make it more aligned with the color palette [extensions/ORES] - 10https://gerrit.wikimedia.org/r/331003 [21:09:00] (03CR) 10Hashar: "CI change is https://gerrit.wikimedia.org/r/#/c/331004/" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [21:09:13] 10MediaWiki-Unit-tests, 10MediaWiki-extensions-MultiUpload, 07Easy: Extension MultiUpload failing tests due to apihelp message missing - https://phabricator.wikimedia.org/T154606#2924443 (10Umherirrender) [21:09:52] 10Nimbus, 07Easy, 07JavaScript: Nimbus gate-and-submit fails on jshint - https://phabricator.wikimedia.org/T154802#2924444 (10Umherirrender) [21:10:27] (03CR) 10Umherirrender: "Created T154802 for the failing test on gate-and-submit" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/330992 (https://phabricator.wikimedia.org/T94547) (owner: 10Umherirrender) [21:14:32] wikimedia/composer-merge-plugin#233 (master - e24d531 Kunal Mehta): The build passed. - https://travis-ci.org/wikimedia/composer-merge-plugin/builds/189635430 [21:18:10] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): every edit save fails, Invalid CSRF token - https://phabricator.wikimedia.org/T154414#2910656 (10jeremyb-phone) thanks for triaging. can someone give me an idea if there's any more info I can provide or should I resume the log out and log back in d... [21:27:16] 10MediaWiki-Unit-tests, 10MediaWiki-extensions-AjaxLogin, 07Easy: AjaxLogin failing tests due to apihelp-ajaxlogin-description message missing - https://phabricator.wikimedia.org/T126415#2924473 (10Umherirrender) [21:28:32] 10MediaWiki-Unit-tests, 10Other-skins: ResourcesTest fails on Skin CustomPage - https://phabricator.wikimedia.org/T154803#2924477 (10Umherirrender) [21:31:14] (03PS1) 10Reedy: Require software-properties-common package on ubuntu [vagrant] - 10https://gerrit.wikimedia.org/r/331006 [21:31:53] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Use MediaWiki API for non-mainspace or main page pages - https://phabricator.wikimedia.org/T154593#2924502 (10Mholloway) Should we close this as declined? It was based on my faulty premise that MW API was giving us everything we wanted and stuff yet to be i... [21:33:10] (03CR) 10BryanDavis: [C: 032] Require software-properties-common package on ubuntu [vagrant] - 10https://gerrit.wikimedia.org/r/331006 (owner: 10Reedy) [21:33:34] (03Merged) 10jenkins-bot: Require software-properties-common package on ubuntu [vagrant] - 10https://gerrit.wikimedia.org/r/331006 (owner: 10Reedy) [21:33:43] 04(no projects): Improve user notifications for section editing errors - https://phabricator.wikimedia.org/T154805#2924503 (10Mholloway) [21:33:59] 06Wikipedia-Android-App-Backlog: Improve user notifications for section editing errors - https://phabricator.wikimedia.org/T154805#2924514 (10Mholloway) [21:34:08] (03CR) 10jenkins-bot: Require software-properties-common package on ubuntu [vagrant] - 10https://gerrit.wikimedia.org/r/331006 (owner: 10Reedy) [21:36:15] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924515 (10Umherirrender) [21:36:36] (03CR) 10Gergő Tisza: [C: 04-2] "This should happen in WikimediaEvents, not User. Someone else might want to track XFF blocks or whatever." [core] - 10https://gerrit.wikimedia.org/r/330890 (https://phabricator.wikimedia.org/T146230) (owner: 10Niharika29) [21:43:05] (03PS1) 10Umherirrender: Add class to autoloader [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/331011 [21:43:27] (03CR) 10Gergő Tisza: [C: 032] Add $wgSoftBlockRanges [core] - 10https://gerrit.wikimedia.org/r/324214 (owner: 10Anomie) [21:43:31] (03CR) 10Umherirrender: "check experimental" [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/331011 (owner: 10Umherirrender) [21:44:16] 06Wikipedia-Android-App-Backlog: Ensure that all MWAPI Retrofit requests return a MwQueryResponse or MwPostResponse - https://phabricator.wikimedia.org/T154807#2924527 (10Mholloway) [21:44:52] 06Wikipedia-Android-App-Backlog: Ensure that all MWAPI Retrofit requests return a MwQueryResponse or MwPostResponse - https://phabricator.wikimedia.org/T154807#2924542 (10Mholloway) [21:45:26] 06Wikipedia-Android-App-Backlog: Ensure that all MWAPI Retrofit clients expect a MwQueryResponse or MwPostResponse - https://phabricator.wikimedia.org/T154807#2924527 (10Mholloway) [21:45:32] (03CR) 10Umherirrender: "check experimental" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [21:47:14] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924515 (10SamanthaNguyen) I wasn't aware that it's somehow possible to be able to include it via test configuration, which resulted in a p... [21:47:24] (03CR) 10Umherirrender: [C: 031] Update npm dependencies to latest [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/331001 (owner: 10Hashar) [21:48:59] 10MediaWiki-extensions-ContentTranslation: Accept and explain spamblacklist & titleblacklist errors - https://phabricator.wikimedia.org/T154788#2924549 (10Framawiki) [21:51:08] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924554 (10Umherirrender) The normal way to define dependencies is composer.json or something in the zuul config files. I did not know if p... [21:51:37] 06Wikipedia-Android-App-Backlog: Improve user notifications for section editing errors - https://phabricator.wikimedia.org/T154805#2924555 (10Mholloway) Beyond improving error messages, it would be nice to reload the page and prompt the user to try again in the cases of errors like nosuchsection, which would lik... [21:51:50] 06Wikipedia-Android-App-Backlog: Improve handling of section editing errors - https://phabricator.wikimedia.org/T154805#2924556 (10Mholloway) [21:53:31] (03CR) 10Umherirrender: build: add npm based test tools (031 comment) [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [21:53:42] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924569 (10hashar) Subscribed a few people which I believe interacted with mediawiki/skins/Refreshed at some point. That is rather annoyin... [21:54:26] 10MediaWiki-extensions-ContentTranslation: Accept and explain spamblacklist & titleblacklist errors - https://phabricator.wikimedia.org/T154788#2924571 (10Framawiki) [21:54:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/331007 (owner: 10L10n-bot) [21:54:49] (03CR) 10Gergő Tisza: Update account creation form validation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324969 (owner: 10Anomie) [21:55:28] (03Merged) 10jenkins-bot: Add $wgSoftBlockRanges [core] - 10https://gerrit.wikimedia.org/r/324214 (owner: 10Anomie) [21:55:56] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924573 (10hashar) A note: mediawiki/extensions/VisualEditor has a similar issue so it would benefit from having submodules to be processed... [21:57:43] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924578 (10SamanthaNguyen) I don't know that much about either Composer or Zuul (only a little about the former), so I'll have to do more r... [21:58:16] (03PS1) 10Hashar: Update submodule wikifont to canonical URL [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/331012 (https://phabricator.wikimedia.org/T154806) [21:59:21] (03PS1) 10Umherirrender: Add class to autoloader [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 [21:59:54] (03CR) 10Umherirrender: "check experimental" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 (owner: 10Umherirrender) [22:00:56] (03CR) 10Gergő Tisza: Add password validation to Special:ChangeCredentials (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324970 (owner: 10Anomie) [22:01:47] (03CR) 10SamanthaNguyen: [C: 032] Update submodule wikifont to canonical URL [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/331012 (https://phabricator.wikimedia.org/T154806) (owner: 10Hashar) [22:02:16] (03PS1) 10Mholloway: Make WikitextClient expect a MwQueryResponse [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331014 (https://phabricator.wikimedia.org/T152982) [22:04:31] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924591 (10SamanthaNguyen) [22:05:24] (03CR) 10VolkerE: [C: 032] CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) (owner: 10Catrope) [22:06:27] (03CR) 10jerkins-bot: [V: 04-1] Make WikitextClient expect a MwQueryResponse [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331014 (https://phabricator.wikimedia.org/T152982) (owner: 10Mholloway) [22:07:11] 10UI-Standardization, 03UI-Standardization-Kanban: Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component - https://phabricator.wikimedia.org/T127405#2924594 (10Volker_E) Ok, so in deriving a solution for the Flow message some kind of yellow background was amo... [22:07:31] (03CR) 10jenkins-bot: Add $wgSoftBlockRanges [core] - 10https://gerrit.wikimedia.org/r/324214 (owner: 10Anomie) [22:09:15] 10UI-Standardization, 03UI-Standardization-Kanban: Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component - https://phabricator.wikimedia.org/T127405#2924598 (10Volker_E) [22:09:33] (03PS2) 10Mholloway: Make WikitextClient expect a MwQueryResponse [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331014 (https://phabricator.wikimedia.org/T152982) [22:10:17] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924619 (10hashar) Composer is a package manager for PHP. Lets one easily define a list of dependencies (in a file `composer.json`) that ar... [22:11:16] 10Wikimedia-Developer-Summit, 06Developer-Relations (Jan-Mar-2017): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2924622 (10Rfarrand) [22:11:48] 07Design, 06Brickimedia, 10Refreshed: Refreshed skin doesn't automatically include WikiFont git submodule - https://phabricator.wikimedia.org/T134683#2273325 (10hashar) >>! In T134683#2612647, @Volker_E wrote: > I'm not quite sure if that's needed, I'd probably just include the font files in your skin and up... [22:12:08] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924515 (10hashar) From the other task: >>! In T134683#2612647, @Volker_E wrote: > I'm not quite sure if that's needed, I'd probably just i... [22:12:36] (03PS1) 10Jack Phoenix: Potential fix for a potential problem [extensions/Comments] - 10https://gerrit.wikimedia.org/r/331059 [22:13:16] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): Convert editing tests to MockWebServer-based unit tests - https://phabricator.wikimedia.org/T154809#2924630 (10Mholloway) [22:13:47] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Follow up on Session Request Forms turned it at Wikimedia Developer Summit - https://phabricator.wikimedia.org/T154810#2924647 (10Rfarrand) [22:13:48] (03CR) 10jerkins-bot: [V: 04-1] Potential fix for a potential problem [extensions/Comments] - 10https://gerrit.wikimedia.org/r/331059 (owner: 10Jack Phoenix) [22:13:50] (03Merged) 10jenkins-bot: CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) (owner: 10Catrope) [22:14:04] (03CR) 10jenkins-bot: CanNotEditWidget: Hide properly when not active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/330999 (https://phabricator.wikimedia.org/T154762) (owner: 10Catrope) [22:14:14] 06Developer-Relations, 10Wikimedia-Developer-Summit: Help participants at the developer summit build meaningful connections with each other - https://phabricator.wikimedia.org/T150156#2924663 (10Rfarrand) [22:14:16] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create "Session Followup Request Template" for Dev Summit - https://phabricator.wikimedia.org/T151485#2924661 (10Rfarrand) 05Open>03Resolved This is complete. All forms have been printed and signs have bene created for the turn in locatio... [22:14:23] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): Convert editing tests to MockWebServer-based unit tests - https://phabricator.wikimedia.org/T154809#2924664 (10Mholloway) [22:16:39] 10Wikimedia-Developer-Summit, 06Developer-Relations (Jan-Mar-2017): Social Event Plan: Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141934#2924693 (10Rfarrand) 05Open>03Resolved This information has been added to the program. Srishti will be editing the table to fix the formatting. I ha... [22:16:41] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T141926#2924695 (10Rfarrand) [22:17:22] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T141926#2517012 (10Rfarrand) [22:17:24] 10Wikimedia-Developer-Summit, 06Developer-Relations (Jan-Mar-2017): Wikimedia Developer Summit Signage - https://phabricator.wikimedia.org/T154339#2924698 (10Rfarrand) 05Open>03Resolved I spent about 6 hours creating and printing signs, role cards, and print outs. This is completely done. Closing task. [22:17:28] 10Navigation-Popups: Show edit summaries and contributors for diffs - https://phabricator.wikimedia.org/T138899#2924701 (10APerson) [22:17:39] (03CR) 10Jack Phoenix: [V: 032 C: 032] Potential fix for a potential problem [extensions/Comments] - 10https://gerrit.wikimedia.org/r/331059 (owner: 10Jack Phoenix) [22:17:53] (03PS1) 10Jack Phoenix: Finally make the "comments of the day" feature work again [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/331082 (https://phabricator.wikimedia.org/T100024) [22:18:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/331038 (owner: 10L10n-bot) [22:18:22] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Follow up on Session Request Forms turned in at Wikimedia Developer Summit - https://phabricator.wikimedia.org/T154810#2924708 (10Rfarrand) [22:18:44] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Follow up on Session Request Forms turned in at Wikimedia Developer Summit - https://phabricator.wikimedia.org/T154810#2924647 (10Rfarrand) p:05Normal>03Low Changing to low, no attention needed until after summit [22:19:30] 10Wikimedia-Hackathon-2017-Organization, 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Drawing in new MW tech volunteers with Hackathons, and then what - https://phabricator.wikimedia.org/T148557#2924712 (10Rfarrand) p:05Normal>03Low moving all tasks unrelated to dev summit t... [22:19:37] 10MediaWiki-Unit-tests, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924714 (10SamanthaNguyen) >>! In T154806#2924619, @hashar wrote: > Composer is a package manager for PHP. Lets one easily define a list of... [22:19:44] 06Developer-Relations (Jan-Mar-2017): Open call for hosts for Wikimedia Hackathon 2018 - https://phabricator.wikimedia.org/T153997#2924715 (10Rfarrand) p:05High>03Low moving all tasks unrelated to dev summit to low, will readjust after summit. [22:20:04] 06Developer-Relations (Jan-Mar-2017): Publish Lessons Learned from Wikimania Hackathon 2016 - https://phabricator.wikimedia.org/T138989#2924717 (10Rfarrand) p:05Normal>03Low moving all tasks unrelated to dev summit to low, will readjust after summit. [22:20:27] 10Wikimedia-Hackathon-2017-Organization, 06Developer-Relations (Jan-Mar-2017): Changes for Next Wikimania Hackathon - https://phabricator.wikimedia.org/T138497#2924719 (10Rfarrand) p:05Normal>03Low moving all tasks unrelated to dev summit to low, will readjust after summit. [22:20:44] 06Developer-Relations (Jan-Mar-2017), 07RfC: Discussion: Redefine Wikimedia Hackathons? - https://phabricator.wikimedia.org/T124262#2924721 (10Rfarrand) p:05Normal>03Low moving all tasks unrelated to dev summit to low, will readjust after summit. [22:20:58] 06Developer-Relations (Jan-Mar-2017): Hackathons: Help people connect and start collaborating in advance of Hackathons - https://phabricator.wikimedia.org/T120092#2924723 (10Rfarrand) p:05Normal>03Low moving all tasks unrelated to dev summit to low, will readjust after summit. [22:25:30] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 15User-Ladsgroup, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2924726 (10Isarra) Agh, I'm sorry. This is coming out way too harshly and I really shouldn't b... [22:25:58] anomie: ping [22:28:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/331050 (owner: 10L10n-bot) [22:28:28] 06Wikipedia-Android-App-Backlog, 07Easy, 07Technical-Debt: Retrofit NearbyFetchTask - https://phabricator.wikimedia.org/T152400#2924729 (10Niedzielski) [22:30:17] 06Wikipedia-Android-App-Backlog, 07Easy, 07Technical-Debt: Retrofit NearbyFetchTask - https://phabricator.wikimedia.org/T152400#2924734 (10Niedzielski) @Mholloway, I added slightly more detail and marked this task as Easy. I think our data client patterns are starting to become clear enough that a volunteer... [22:32:36] 06Wikipedia-Android-App-Backlog: App login state may be consistent with the site - https://phabricator.wikimedia.org/T154813#2924738 (10Mholloway) [22:32:47] 06Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site - https://phabricator.wikimedia.org/T154813#2924751 (10Mholloway) [22:33:16] 06Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site - https://phabricator.wikimedia.org/T154813#2924738 (10Mholloway) [22:33:25] subbu, https://phabricator.wikimedia.org/T154709 o.o [22:33:26] 06Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site - https://phabricator.wikimedia.org/T154813#2924738 (10Mholloway) [22:33:39] (03PS25) 10Bearloga: Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 (https://phabricator.wikimedia.org/T150915) [22:34:06] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Name tags for late registrations - https://phabricator.wikimedia.org/T154814#2924754 (10Rfarrand) [22:35:19] 06Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site(s) - https://phabricator.wikimedia.org/T154813#2924769 (10Mholloway) [22:35:47] 06Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site(s) - https://phabricator.wikimedia.org/T154813#2924738 (10Mholloway) [22:35:57] (03PS1) 10VictorPorton: URL XSS issue corrected [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331083 [22:37:38] 10MediaWiki-File-management, 06Commons, 10Commons-Datasets, 06Multimedia, and 2 others: Media, Visualizations, and Layout at Wikidev'17 - https://phabricator.wikimedia.org/T151952#2924773 (10SamanthaNguyen) From my understanding, it seems like this is just related to Wikimedia Video's stuff, so I'm removin... [22:37:41] (03CR) 10VictorPorton: [V: 032 C: 032] "An XSS issue corrected." [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331083 (owner: 10VictorPorton) [22:43:12] (03CR) 10MtDu: "I have no idea how to write parserTests, so I can't help you there. I left a comment in the Parser.php file." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/330982 (https://phabricator.wikimedia.org/T59603) (owner: 10Divadsn) [22:43:44] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Pre-Developer Summit Communication Plan - https://phabricator.wikimedia.org/T152451#2924784 (10Rfarrand) 05Open>03Resolved No more expected communications in advance of the event! all three emails to participants can be found here: https... [22:48:31] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Collect and transport all Dev Summit equipment from WMF to Golden Gate Club - https://phabricator.wikimedia.org/T154815#2924788 (10Rfarrand) [22:48:38] 06Discovery, 06Discovery-Analysis (Current work), 13Patch-For-Review: Portal dashboard: Mexico shouldn't be listed as being in South America - https://phabricator.wikimedia.org/T153716#2924802 (10debt) 05Open>03Resolved Yay - it's been deployed: http://discovery.wmflabs.org/portal/#all_country {F5244215} [22:48:40] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 07Epic, 13Patch-For-Review: [EPIC] Wikipedia Portal Dashboard: expand "other" countries data display - https://phabricator.wikimedia.org/T138107#2924804 (10debt) [22:49:21] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 07Epic, 13Patch-For-Review: [EPIC] Wikipedia Portal Dashboard: expand "other" countries data display - https://phabricator.wikimedia.org/T138107#2390571 (10debt) [22:49:23] 06Discovery, 06Discovery-Analysis (Current work), 13Patch-For-Review: Portal dashboard heading "No. Events by Country" could be clearer - https://phabricator.wikimedia.org/T153715#2924806 (10debt) 05Open>03Resolved This has been deployed! http://discovery.wmflabs.org/portal/#all_country [22:52:09] (03CR) 10BearND: [C: 04-1] New: add last 5 days of pageviews to most-read response (036 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330836 (https://phabricator.wikimedia.org/T148445) (owner: 10Niedzielski) [22:52:59] 10MediaWiki-Unit-tests, 06Brickimedia, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2924813 (10SamanthaNguyen) [22:53:29] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: [Epic] Allow extensions to register simple keyword features - https://phabricator.wikimedia.org/T152517#2924815 (10Deskana) [22:53:32] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Refactor search context to eliminate single search type - https://phabricator.wikimedia.org/T152543#2924814 (10Deskana) 05Open>03Resolved [22:53:35] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Store SearchContext::$syntaxUsed in the CirrusSearchRequestSet payload - https://phabricator.wikimedia.org/T147045#2924816 (10Deskana) 05Open>03Resolved [22:53:37] (03PS1) 10VictorPorton: Now it works thanks to ParserAfterTidy hook [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331086 [22:54:49] (03PS1) 10Niedzielski: Hygiene: remove unused string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331087 [22:54:50] 10CirrusSearch, 06Discovery, 07Chinese-Sites, 06Discovery-Search (Current work): Test the ICU tokenizer on ja, th and zh with relcomp - https://phabricator.wikimedia.org/T151743#2924822 (10Deskana) 05Open>03Resolved [22:54:57] (03PS1) 10VictorPorton: logging removed [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331088 [22:55:31] (03CR) 10VictorPorton: [V: 032 C: 032] logging removed [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331088 (owner: 10VictorPorton) [22:55:44] (03CR) 10VictorPorton: [V: 032 C: 032] Now it works thanks to ParserAfterTidy hook [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331086 (owner: 10VictorPorton) [22:56:57] (03PS2) 10BryanDavis: Update ::ruby for Jessie [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329617 (https://phabricator.wikimedia.org/T154273) [22:57:47] (03PS2) 10BryanDavis: Update ::browsertests for Jessie [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329618 (https://phabricator.wikimedia.org/T154273) [22:58:10] (03CR) 10Kaldari: [C: 032] "Let's give it a shot." [core] - 10https://gerrit.wikimedia.org/r/329493 (https://phabricator.wikimedia.org/T139110) (owner: 10Bartosz Dziewoński) [23:00:53] (03CR) 10Mholloway: "OK, thanks and user talk page notifications are working for me, but I still can't get a notification for having a description edit reverte" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325627 (https://phabricator.wikimedia.org/T150477) (owner: 10Dbrant) [23:01:05] (03CR) 10Hashar: "recheck" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 (owner: 10Umherirrender) [23:01:51] (03PS1) 10Niedzielski: Hygiene: replace DrawableUtil with DrawableCompat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331089 [23:02:25] 10MediaWiki-extensions-Scribunto: When "Erreur Lua : attempt to call a string value", where? - https://phabricator.wikimedia.org/T154769#2924834 (10Anomie) 05Open>03Invalid I don't see the text "attempt to call a string value" being output anywhere in that page. A 1 MB module that isn't a test case, much le... [23:03:12] (03CR) 10Mholloway: [C: 032] Hygiene: remove unused string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331087 (owner: 10Niedzielski) [23:03:30] 10Wikimedia-Logstash: Upgrade Logstash to v2.2.2 - https://phabricator.wikimedia.org/T127676#2050293 (10Paladox) I think we can merge this into T154473 ? [23:04:03] (03CR) 10Kaldari: [C: 032] phpunit: Use assertEquals(, $delta) in UserTest instead of greater/lessThan [core] - 10https://gerrit.wikimedia.org/r/330363 (owner: 10Krinkle) [23:05:15] (03CR) 10Hashar: [C: 04-1] "I have copy pasted from the BoilerPlate extension :D so yeah definitely wrong." [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [23:05:57] 10MediaWiki-Export-or-Import, 06Collaboration-Team-Triage, 10Flow: Migrate ORES_paper flow board from Meta to Mediawiki.org - https://phabricator.wikimedia.org/T154816#2924843 (10Halfak) [23:06:57] (03CR) 10Mholloway: [C: 032] Hygiene: replace DrawableUtil with DrawableCompat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331089 (owner: 10Niedzielski) [23:07:28] 10MediaWiki-Export-or-Import, 06Collaboration-Team-Triage, 10Flow: Migrate ORES_paper flow board from Meta to Mediawiki.org - https://phabricator.wikimedia.org/T154816#2924859 (10Halfak) [23:07:31] 10MediaWiki-extensions-OAuth: Flow board (or maybe just a topic) for discussion about each OAuth consumer proposal - https://phabricator.wikimedia.org/T154777#2923579 (10Tgr) Ideally each consumer should be presented as a wiki page, not a bunch of (poorly cross-linked) special pages with separate entries for eac... [23:07:58] (03Merged) 10jenkins-bot: CollationFa: Third time's the charm [core] - 10https://gerrit.wikimedia.org/r/329493 (https://phabricator.wikimedia.org/T139110) (owner: 10Bartosz Dziewoński) [23:08:01] (03Merged) 10jenkins-bot: Hygiene: remove unused string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331087 (owner: 10Niedzielski) [23:08:42] (03PS2) 10Hashar: build: add npm based test tools [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 [23:08:51] (03CR) 10BryanDavis: [C: 04-2] "tore out too much stuff" (031 comment) [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329617 (https://phabricator.wikimedia.org/T154273) (owner: 10BryanDavis) [23:10:59] 10MediaWiki-extensions-OAuth: Flow board (or maybe just a topic) for discussion about each OAuth consumer proposal - https://phabricator.wikimedia.org/T154777#2924892 (10Tgr) [23:11:01] 10MediaWiki-extensions-OAuth, 07Epic: Improve OAuth application approval workflow - https://phabricator.wikimedia.org/T103587#2924893 (10Tgr) [23:11:24] (03PS3) 10Umherirrender: Fix param values in apihelp [extensions/Configure] - 10https://gerrit.wikimedia.org/r/330045 [23:12:03] (03CR) 10jenkins-bot: Hygiene: remove unused string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331087 (owner: 10Niedzielski) [23:14:37] (03PS2) 10Hashar: Add class to autoloader [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 (owner: 10Umherirrender) [23:14:49] 10MediaWiki-API, 06Multimedia, 10UploadWizard: UploadWizard errors are a mix of two languages - https://phabricator.wikimedia.org/T154781#2924935 (10matmarex) p:05Triage>03Normal This is probably a bug in the upload API, since we've recently switched UploadWizard to just displaying the API output for err... [23:15:45] (03Merged) 10jenkins-bot: phpunit: Use assertEquals(, $delta) in UserTest instead of greater/lessThan [core] - 10https://gerrit.wikimedia.org/r/330363 (owner: 10Krinkle) [23:15:47] (03Merged) 10jenkins-bot: Hygiene: replace DrawableUtil with DrawableCompat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331089 (owner: 10Niedzielski) [23:16:07] (03CR) 10Hashar: [C: 032] Add class to autoloader [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 (owner: 10Umherirrender) [23:16:10] (03CR) 10jenkins-bot: CollationFa: Third time's the charm [core] - 10https://gerrit.wikimedia.org/r/329493 (https://phabricator.wikimedia.org/T139110) (owner: 10Bartosz Dziewoński) [23:16:49] (03CR) 10Hashar: [C: 032] "I just edited the commit message to remove the link to the Jenkins build." [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 (owner: 10Umherirrender) [23:17:13] (03Merged) 10jenkins-bot: Add class to autoloader [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331013 (owner: 10Umherirrender) [23:17:50] (03CR) 10Hashar: "check experimental" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [23:17:53] (03CR) 10BearND: [C: 04-1] "Some questions inline" (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/330616 (owner: 10Niedzielski) [23:18:48] (03CR) 10Hashar: "I have commented out jscs and jshint which fail. My main motivation is to enable the CI configuration and add the banana i18n checker. j" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [23:19:05] (03CR) 10jenkins-bot: Hygiene: replace DrawableUtil with DrawableCompat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/331089 (owner: 10Niedzielski) [23:19:25] (03PS2) 10Umherirrender: Add class to autoloader [skins/p2wiki] - 10https://gerrit.wikimedia.org/r/331011 [23:25:19] 07Design, 10MediaWiki-extensions-InputBox: Can't tell what's a button in search forms (mw-inputbox-input and mw-ui-button look identical) - https://phabricator.wikimedia.org/T131810#2924981 (10kaldari) @Isarra: The button now has a faint grey background as well. [23:29:12] Hi all [23:29:31] Where can I found the template parameters into the parsing code? [23:29:31] (03CR) 10jenkins-bot: phpunit: Use assertEquals(, $delta) in UserTest instead of greater/lessThan [core] - 10https://gerrit.wikimedia.org/r/330363 (owner: 10Krinkle) [23:29:53] (03CR) 10Umherirrender: [C: 032] build: add npm based test tools [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [23:30:56] (03Merged) 10jenkins-bot: build: add npm based test tools [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/331002 (owner: 10Hashar) [23:31:38] Aoineko: could you clarify what you mean? templates are expanded in the preprocessor stage [23:32:33] (03PS12) 10Paladox: Add primary key lc_lang, lc_key to l10n_cache [core] - 10https://gerrit.wikimedia.org/r/318553 (https://phabricator.wikimedia.org/T146591) [23:32:44] I would like to create an extension that display the parameters of a template while the template is parse into an other page [23:33:08] I added a Magic word, but I can't find where the template parameters are stored [23:33:37] (03PS13) 10Paladox: Add primary key lc_lang, lc_key to l10n_cache [core] - 10https://gerrit.wikimedia.org/r/318553 (https://phabricator.wikimedia.org/T146591) [23:33:52] 07Design, 10MediaWiki-extensions-InputBox: Can't tell what's a button in search forms (mw-inputbox-input and mw-ui-button look identical) - https://phabricator.wikimedia.org/T131810#2925028 (10Isarra) Ah, I see it on this one, but you might want to make it less faint. I couldn't even tell on my laptop, and tha... [23:33:56] 10MediaWiki-Parser, 10ArchCom-RfC, 07ArchCom-Has-shepherd: [RfC] Future of magic links - https://phabricator.wikimedia.org/T145604#2925027 (10Legoktm) >>! In T145604#2897174, @SlimVirgin wrote: > Could someone say what the status of this is, please? See T145604#2695311 and https://lists.wikimedia.org/piperm... [23:35:49] (03PS26) 10Bearloga: Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 (https://phabricator.wikimedia.org/T150915) [23:37:43] 10MediaWiki-Database, 05MW-1.27-release-notes, 13Patch-For-Review: Quotes needed for timestamps in PostgreSQL - https://phabricator.wikimedia.org/T121743#2925029 (10Paladox) 05Open>03Resolved a:03Jjanes [23:39:21] 10MediaWiki-Database, 05MW-1.29-release-notes, 07NewPHP, 13Patch-For-Review, and 2 others: Remove old mysql extension support in favor of mysqli - https://phabricator.wikimedia.org/T120333#1851262 (10Paladox) we could possibly do this for mw 1.30 or mw 1.31? We should have one last lts release that support... [23:40:27] (03PS2) 10Brian Wolff: Now it works thanks to ParserAfterTidy hook [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331086 (owner: 10VictorPorton) [23:40:29] (03PS2) 10Brian Wolff: logging removed [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331088 (owner: 10VictorPorton) [23:40:37] 10MediaWiki-Unit-tests, 06Brickimedia, 10Continuous-Integration-Config, 10Refreshed: Skin Refreshed sub repo does not handled in test config - https://phabricator.wikimedia.org/T154806#2925034 (10ashley) I have no strong feelings either way, but probably bundling WikiFont is the easiest option (not (just)... [23:40:58] legoktm, for example, if I write a {{test|a=1|0|3=x}} in a page, I would like to get "a=1|0|3=x" (no matter the format) if I put my Magic word into the template {{test}} [23:41:18] (03CR) 10jerkins-bot: [V: 04-1] Add primary key lc_lang, lc_key to l10n_cache [core] - 10https://gerrit.wikimedia.org/r/318553 (https://phabricator.wikimedia.org/T146591) (owner: 10Paladox) [23:41:28] (03CR) 10Brian Wolff: [V: 032 C: 032] "[Victor asked for help making this merge]" [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331086 (owner: 10VictorPorton) [23:41:44] (03CR) 10Brian Wolff: [V: 032] logging removed [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331088 (owner: 10VictorPorton) [23:42:31] (03PS14) 10Paladox: Add primary key lc_lang, lc_key to l10n_cache [core] - 10https://gerrit.wikimedia.org/r/318553 (https://phabricator.wikimedia.org/T146591) [23:43:55] * stephend waves hello to phedenskog [23:44:43] (03CR) 10Brian Wolff: [C: 04-1] URL XSS issue corrected (031 comment) [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/331083 (owner: 10VictorPorton) [23:45:45] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: InputWidgets' Indicator- and LabelElements sometimes make focus visually disappear when actively clicked - https://phabricator.wikimedia.org/T154829#2925057 (10Volker_E) [23:49:36] 10MediaWiki-Parser, 10ArchCom-RfC, 07ArchCom-Has-shepherd: [RfC] Future of magic links - https://phabricator.wikimedia.org/T145604#2925073 (10SlimVirgin) Hi Legoktm, you wrote that it was open for discussion because several places were notified, but none of these are where Wikimedia writers tend to hang out,... [23:50:51] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: InputWidgets' Indicator- and LabelElements sometimes make focus visually disappear when actively clicked - https://phabricator.wikimedia.org/T154829#2925074 (10Volker_E) [23:52:58] (03PS1) 10Catrope: mediawiki.rcfilters: Add the remaining MW core filters [core] - 10https://gerrit.wikimedia.org/r/331094 (https://phabricator.wikimedia.org/T149452) [23:57:53] (03CR) 10Divadsn: "It should actually fallback to the user language I think, I will double check it." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/330982 (https://phabricator.wikimedia.org/T59603) (owner: 10Divadsn) [23:59:02] 10MediaWiki-Special-pages, 03Community-Tech-Sprint, 07IPv6: Create new Special:RangeContributions page to support viewing contributions across an IP range - https://phabricator.wikimedia.org/T145912#2925079 (10MusikAnimal) For development and testing we'll need a bunch of edits from random IPs within a query... [23:59:12] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.rcfilters: Add the remaining MW core filters [core] - 10https://gerrit.wikimedia.org/r/331094 (https://phabricator.wikimedia.org/T149452) (owner: 10Catrope) [23:59:32] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: InputWidgets' Indicator- and LabelElements sometimes make focus visually disappear when actively clicked - https://phabricator.wikimedia.org/T154829#2925080 (10Volker_E)