[00:02:07] 10BlueSpice: Replace FSRepo in BlueSpice* - https://phabricator.wikimedia.org/T154343#2907967 (10Paladox) [00:03:20] 10BlueSpice: Replace FSRepo in BlueSpice* - https://phabricator.wikimedia.org/T154343#2907979 (10Paladox) [00:04:13] 10BlueSpice: Replace FSRepo in BlueSpice* - https://phabricator.wikimedia.org/T154343#2907967 (10Paladox) https://github.com/wikimedia/mediawiki-extensions-BlueSpiceExtensions/search?utf8=✓&q=FSRepo [00:10:19] (03Draft1) 10Paladox: Replace FSRepo with FileRepo [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329717 (https://phabricator.wikimedia.org/T154343) [00:10:21] (03Draft2) 10Paladox: Replace FSRepo with FileRepo [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329717 (https://phabricator.wikimedia.org/T154343) [00:10:32] (03PS1) 10UltrasonicNXT: Jump to latest [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329718 [00:12:46] (03CR) 10Paladox: "check experimental" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329717 (https://phabricator.wikimedia.org/T154343) (owner: 10Paladox) [00:19:23] 10InternetArchiveBot: Bot deleted a large part of a page, twice - https://phabricator.wikimedia.org/T154344#2907987 (10Bamyers99) a:03Cyberpower678 [00:24:30] 10MediaWiki-extensions-TitleBlacklist, 10Wikimedia-General-or-Unknown: Editing session issue (TitleBlacklist related?) on *.wikipedia.org for Kvardek du - https://phabricator.wikimedia.org/T154112#2908000 (10Tgr) There are multiple TitleBlacklist issues here, which are completely unrelated to the session loss... [00:25:00] (03PS1) 10Paladox: Remove duplicate manifest_version from UserManager/extension.json [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329719 [00:45:17] (03CR) 10Paladox: "> Does this fix any bug or why do you think it should be backported." [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329124 (owner: 10Paladox) [00:54:51] (03CR) 10Paladox: [C: 031] Removed unneeded apihelp messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329677 (owner: 10Umherirrender) [00:55:15] (03CR) 10Paladox: [C: 031] Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329684 (owner: 10Umherirrender) [01:01:22] (03CR) 10Paladox: "recheck" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/309292 (owner: 10Robert Vogel) [01:03:37] (03PS4) 10Paladox: Remove uneeded subscribe [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326216 [01:06:42] (03PS2) 10Paladox: Add new modifyTable function to DatabaseUpdater [core] - 10https://gerrit.wikimedia.org/r/320087 [01:09:08] (03Abandoned) 10Paladox: Replace ArticleSaveComplete hook usage [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/315110 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:09:26] (03PS3) 10Paladox: Update tests/phpunit/MediaWikiTestCase.php with support for apcu [core] - 10https://gerrit.wikimedia.org/r/315513 [01:10:42] (03Abandoned) 10Paladox: Replace ArticleSaveComplete hook usage [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/315112 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:11:18] (03Abandoned) 10Paladox: Replace ArticleSaveComplete hook usage [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/315125 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:11:45] (03Abandoned) 10Paladox: Replace ArticleSaveComplete hook usage [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/315188 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:12:18] (03PS4) 10Paladox: Add new config $wgSphinxSearchHitCounter to choose index based on if HitCounter is installed [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/313421 (https://phabricator.wikimedia.org/T146995) [01:13:05] (03PS4) 10Paladox: Add check to make sure sphinxapi.php file exist, if not doin't load the file [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/313425 [01:13:25] (03PS8) 10Paladox: Update videojs to 5.15.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314731 [01:14:50] (03PS3) 10Paladox: Replace DB begin()/commit() with startAtomic()/endAtomic() as needed [extensions/LiveTranslate] (REL1_27) - 10https://gerrit.wikimedia.org/r/312802 (https://phabricator.wikimedia.org/T120791) [01:15:19] (03PS3) 10Paladox: Remove begin()/commit() calls that can break outer transactions [extensions/Survey] (REL1_27) - 10https://gerrit.wikimedia.org/r/312801 (https://phabricator.wikimedia.org/T120791) [01:17:37] (03PS6) 10Paladox: Move all functions into hooks file in preparation for extension.json [extensions/Collection] - 10https://gerrit.wikimedia.org/r/304206 (https://phabricator.wikimedia.org/T87899) [01:17:58] (03PS6) 10Paladox: Add extension.json, empty entry point [extensions/Collection] - 10https://gerrit.wikimedia.org/r/304226 (https://phabricator.wikimedia.org/T87899) [01:19:37] (03PS12) 10Paladox: Update php code style [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/264960 [01:36:46] 10MediaWiki-General-or-Unknown: Composer version 1.3.0 causes a "Undefined index: hash" in includes/libs/composer/ComposerLock.php on line 19 - https://phabricator.wikimedia.org/T154345#2908030 (10mwjames) [01:37:07] (03PS1) 10MtDu: Add 'UnblockUser' and 'UnblockUserComplete' hooks to Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/329725 (https://phabricator.wikimedia.org/T50546) [01:40:27] 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 10MediaWiki-extensions-ParserFunctions, 10MediaWiki-extensions-Scribunto, 07Easy: Provide "wikitext" means of accessing arbitrary wiki page's default category sort key - https://phabricator.wikimedia.org/T154346#2908048 (10MZMcBride) [01:41:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Reference section remains the same size when collapsed (after expanding) - https://phabricator.wikimedia.org/T98318#2908061 (10Ethanreese) I didn't notice this problem testing on test.wikidata.org in the Chrome browser on macOS. On Loading: {F517954... [01:42:13] 10MediaWiki-General-or-Unknown, 07Composer: Composer version 1.3.0 causes a "Undefined index: hash" in includes/libs/composer/ComposerLock.php on line 19 - https://phabricator.wikimedia.org/T154345#2908063 (10Paladox) [01:43:12] (03Draft1) 10Paladox: Remove hash from composer.lock [vendor] - 10https://gerrit.wikimedia.org/r/329726 (https://phabricator.wikimedia.org/T154345) [01:43:16] (03Draft2) 10Paladox: Remove hash from composer.lock [vendor] - 10https://gerrit.wikimedia.org/r/329726 (https://phabricator.wikimedia.org/T154345) [01:43:48] (03CR) 10TTO: [C: 032] Add 'UnblockUser' and 'UnblockUserComplete' hooks to Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/329725 (https://phabricator.wikimedia.org/T50546) (owner: 10MtDu) [01:51:15] (03Merged) 10jenkins-bot: Add 'UnblockUser' and 'UnblockUserComplete' hooks to Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/329725 (https://phabricator.wikimedia.org/T50546) (owner: 10MtDu) [02:01:53] (03CR) 10jenkins-bot: Add 'UnblockUser' and 'UnblockUserComplete' hooks to Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/329725 (https://phabricator.wikimedia.org/T50546) (owner: 10MtDu) [02:22:55] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Do a research on the communication tools Zulip and Mattermost, and document the pros and cons of using them - https://phabricator.wikimedia.org/T154001#2908074 (10jayvdb) >>! In T154001#2903816, @sumanah wrote: > @srishakatux As you're... [02:28:55] 10MediaWiki-Export-or-Import, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#2908075 (10TTO) >>! In T17000#2907375, @Joe wrote: > But I have a more fundamental question: why do you all think this issu... [02:30:30] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2908076 (10Glrx) Failure to canonize in getAvailableLanguages(). Go to Commons... [02:34:36] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Wikimedia Developer Summit Signage - https://phabricator.wikimedia.org/T154339#2908078 (10Peachey88) [02:39:20] 10MediaWiki-Export-or-Import, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#191958 (10Peachey88) Don't we already have maintenance scripts that allow these large ones to be done server side? [02:45:08] (03PS1) 10MtDu: Add a 'ChangeUserGroups' hook in Special:Userrights [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) [02:47:52] (03CR) 10TTO: Add a 'ChangeUserGroups' hook in Special:Userrights (032 comments) [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) (owner: 10MtDu) [02:52:44] (03CR) 10Ladsgroup: [C: 04-1] Use OOUI for Special:UserRights (031 comment) [core] - 10https://gerrit.wikimedia.org/r/225536 (https://phabricator.wikimedia.org/T117884) (owner: 10Florianschmidtwelzow) [02:53:45] (03PS2) 10MtDu: Add a 'ChangeUserGroups' hook in Special:Userrights [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) [02:58:42] 10MediaWiki-Parser, 07Tracking: Tracking categories (tracking) - https://phabricator.wikimedia.org/T35033#2908086 (10Ladsgroup) [02:58:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Easy, 03Google-Code-In-2016, and 3 others: #property: calls for non-existent properties should add a tracking category - https://phabricator.wikimedia.org/T50799#2908085 (10Ladsgroup) 05Open>03Resolved [02:59:04] (03CR) 10TTO: [C: 04-1] Add a 'ChangeUserGroups' hook in Special:Userrights (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) (owner: 10MtDu) [03:00:50] (03CR) 10Reedy: [C: 04-1] AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [03:00:55] I cannot login into gerrit with my wikimedia login. [03:01:24] ravi, What do you mean? What's the problem? [03:01:46] MtDu, I'm getting wrong Username/password error. [03:02:05] (03PS3) 10MtDu: Add a 'ChangeUserGroups' hook in Special:Userrights [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) [03:02:09] You shouldn't be able to [03:02:16] You login to gerrit with your wikitech login [03:02:42] ravi, Are you sure you're not entering in something wrong? [03:03:55] ravi: You need to use your wikitech wiki login, If it still errors, try changing the capalization in your login name (example: Peachey88 compared to peachey88) [03:04:41] 04(no projects): collapsible keeps switching/moving - https://phabricator.wikimedia.org/T154301#2908090 (101u) thx, didn't find that one. [03:04:47] Is wikitech login different from wikimedia login? [03:04:52] (03CR) 10TTO: [C: 032] Add a 'ChangeUserGroups' hook in Special:Userrights [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) (owner: 10MtDu) [03:05:06] ravi: Yes, it is separate [03:05:17] You need to create an account at wikitech to be able to use Gerrit [03:11:28] srishakatux: Around? [03:11:41] 10MediaWiki-User-blocking, 03Google-Code-In-2016, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Hooks on blocking, but not for unblocking. - https://phabricator.wikimedia.org/T50546#2908097 (10TTO) 05Open>03Resolved a:03MtDu Added `UnblockUser` and `UnblockUserComplete` hooks. [03:12:22] 10MediaWiki-Special-pages, 13Patch-For-Review: Add hook before changing of userrights - https://phabricator.wikimedia.org/T49338#2908103 (10MtDu) 05Open>03Resolved a:03MtDu Patch has been merged here. https://gerrit.wikimedia.org/r/#/c/329727/ Hence closing as resolved. Thanks! [03:14:48] (03Merged) 10jenkins-bot: Add a 'ChangeUserGroups' hook in Special:Userrights [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) (owner: 10MtDu) [03:22:47] 10UI-Standardization, 05Goal, 07Tracking: Convert all extensions/skins to OOUI - https://phabricator.wikimedia.org/T122014#2908110 (10Volker_E) [03:26:51] (03CR) 10jenkins-bot: Add a 'ChangeUserGroups' hook in Special:Userrights [core] - 10https://gerrit.wikimedia.org/r/329727 (https://phabricator.wikimedia.org/T49338) (owner: 10MtDu) [03:27:30] (03CR) 10VolkerE: "@MtDu So is this patch not any more about T149352? IMO it is." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [03:28:24] 10UI-Standardization, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, and 2 others: Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#2908113 (10Volker_E) 05Resolved>03Open Re-opening as patch s... [03:28:59] RoanKattouw: Around? [03:29:13] Volker_E: I see your point. Sorry about that! [03:30:22] MtDu: Yup [03:30:42] RoanKattouw: I'm probably going to rebase this one https://gerrit.wikimedia.org/r/#/c/320948/ [03:30:48] Because it hasn't been merged yet. [03:30:52] MtDu: no worries! Re-opening isn't that bad. As long as we don't leave patch sets behind forever, everything's fine :) [03:31:09] MtDu: No that change is merged [03:31:10] RoanKattouw: Not that one sorry [03:31:17] https://gerrit.wikimedia.org/r/#/c/320947/ [03:31:18] That one [03:32:01] Hmm didn't I say I was going to abandon that change? [03:32:15] RoanKattouw: Don't we still need to add them there? [03:32:26] Oh, hold on [03:32:29] Those aren't the green-ltr/rtl ones. [03:32:32] I was too quick to merge your other change [03:32:40] The green ones are the ones that needed to be in 320948 [03:33:03] Wait, can you explain that again? [03:33:07] Why which one goes in which [03:33:24] Well, eventually both the green 30x30 ones and the black 24x24 ones should be in Thanks [03:33:35] Oh the green one is the main one [03:33:36] I see [03:33:36] But the black 24x24 ones are secondary link icons which we don't have infra for yet [03:33:38] Yeah [03:33:49] So new change? [03:33:58] But after you revert the other right? [03:34:09] Well or just make a follow-up [03:34:25] For thanks right? [03:34:26] That deletes the old icons, adds the new ones, and updates the icon names in Thanks.hooks.php [03:34:28] Yeah [03:34:53] * RoanKattouw will be more careful +2ing changes from his phone in the fuutre [03:35:25] 10UI-Standardization, 10OOjs-UI, 13Patch-For-Review, 03UI-Standardization-Kanban: ButtonWidgets should use `box-sizing: border-box` - https://phabricator.wikimedia.org/T146962#2908118 (10Volker_E) @Esanders @Catrope Feedback highly appreciated. Patch set is around for nearly three months and IMO sensible w... [03:35:37] 10UI-Standardization, 10OOjs-UI, 13Patch-For-Review, 03UI-Standardization-Kanban: ButtonWidgets should use `box-sizing: border-box` - https://phabricator.wikimedia.org/T146962#2908120 (10Volker_E) p:05Triage>03Normal [03:37:11] RoanKattouw: Sorry about that, internet went down for some reason. [03:37:15] legoktm: around? [03:37:24] Did I miss a message RoanKattouw? [03:37:54] yes [03:38:02] 19:34:25 For thanks right? [03:38:02] 19:34:27 <@RoanKattouw> That deletes the old icons, adds the new ones, and updates the icon names in Thanks.hooks.php [03:38:02] 19:34:29 <@RoanKattouw> Yeah [03:38:02] 19:34:53 — @RoanKattouw will be more careful +2ing changes from his phone in the fuutre [03:38:25] Lol +2ing from phone [03:41:44] 10UI-Standardization, 10OOjs-UI, 13Patch-For-Review, 03UI-Standardization-Kanban: ButtonWidgets should use `box-sizing: border-box` - https://phabricator.wikimedia.org/T146962#2908121 (10Catrope) Seems fine to me. The only external breakage that would cause would be for people writing ButtonWidget subclass... [03:43:57] 10MediaWiki-Special-pages, 13Patch-For-Review: Add hook before changing of userrights - https://phabricator.wikimedia.org/T49338#2908123 (10TTO) 05Resolved>03Open This isn't done yet... we still need to add the possibility to allow the hook to abort the process if it wants to. I'll do this after the user r... [03:44:30] RoanKattouw: Where can I download the files? [03:44:51] Probably easiest if you git review -d my Echo patch [03:46:52] 10UI-Standardization, 10OOjs-UI, 13Patch-For-Review, 03UI-Standardization-Kanban: ButtonWidgets should use `box-sizing: border-box` - https://phabricator.wikimedia.org/T146962#2908125 (10Volker_E) @Catrope Yes, only on buttons. Excerpt from the patch's elements/ButtonElement.less file: ```lang=less .oo-u... [03:52:24] (03PS1) 10MtDu: Replaced thanks-ltr/rtl (secondary) icons with larger thanks-green-ltr/rtl (main) icons [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/329729 (https://phabricator.wikimedia.org/T149352) [03:52:32] RoanKattouw: Sorry for that. Should be good. [03:53:02] (03CR) 10Catrope: [C: 032] Replaced thanks-ltr/rtl (secondary) icons with larger thanks-green-ltr/rtl (main) icons [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/329729 (https://phabricator.wikimedia.org/T149352) (owner: 10MtDu) [03:53:14] (03Abandoned) 10Catrope: Use SVG for Thanks notification icon instead of PNG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320947 (https://phabricator.wikimedia.org/T149352) (owner: 10Catrope) [03:54:07] RoanKattouw: Just make a new change for that one? [03:55:12] For what? [03:55:21] The one you just abandoned [03:55:22] I abandoned that one because it's no longer needed [03:55:27] 10MediaWiki-API: Wikimedia api doesn't return "request ID" with the "open search" action - https://phabricator.wikimedia.org/T154337#2908130 (10Anomie) 05Open>03Invalid The [[http://www.opensearch.org/Specifications/OpenSearch/Extensions/Suggestions/1.1|OpenSearch Suggestions extension]] does not allow for a... [03:55:37] RoanKattouw, so don't add the small ones? [03:55:47] Your Thanks change + follow-up does the same thing that that one did, just in a differnet repo [03:56:11] The smaller ones are in Echo already and they need to stay there until we have secondary link icon registration infrastructure [03:56:21] They're already in Echo? [03:56:35] Oh I see. [03:56:40] Gotcha gotcha [03:57:24] 10MediaWiki-extensions-Nuke, 15User-Ladsgroup: Change button value to clearer description like “List pages” - https://phabricator.wikimedia.org/T154347#2908132 (10Volker_E) [03:59:42] think this task can now be successfully be labelled “resolved” – MtDu_ RoanKattouw ? :) [04:00:00] Yes [04:00:16] Volker_E: Want me to go ahead and fix this? https://phabricator.wikimedia.org/T154347#2908132 [04:01:30] 10UI-Standardization, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 03UI-Standardization-Kanban, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#2908147 (10Volker_E) 05Ope... [04:01:46] 10UI-Standardization, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 03UI-Standardization-Kanban, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#2908150 (10MtDu) Patchset h... [04:01:52] Beat me to it Volker_E ;) [04:02:30] MtDu_: I'm not familiar with this extension. This is just me reading/trying to understand the form as provided in the screenshots. Would like to get more feedback before changing it… :} [04:03:37] MtDu_: Amir1 has started the conversion to OOjs UI and I thought now (before the patch is merged) is a good time to bring this up [04:03:41] (03Merged) 10jenkins-bot: Replaced thanks-ltr/rtl (secondary) icons with larger thanks-green-ltr/rtl (main) icons [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/329729 (https://phabricator.wikimedia.org/T149352) (owner: 10MtDu) [04:05:03] 10MediaWiki-General-or-Unknown, 07Easy, 03Google-Code-In-2016, 05MW-1.29-release-notes, and 3 others: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#2908152 (10MtDu) Updated grep list: Justin@Du MINGW64 ~/Downloads/core (master) $ git grep '&$this,' * docs/h... [04:05:56] Volker_E: Alrighty. Thanks for the reminder. I'll see you around. [04:06:04] RoanKattouw: Thanks for the review! [04:06:25] MtDu_: Thank you for your help to sort that out so fast! [04:06:32] 10MediaWiki-extensions-Quiz, 10MOOC-Interface, 10Possible-Tech-Projects, 10Outreachy (Round-13), 07Pywikibot-Wikidata: Create new Python library to serialize Wikimedia Quiz format, GIFT quiz format, and allow round-trip conversions between the two formats. - https://phabricator.wikimedia.org/T89761#2908153... [04:33:25] I configured everything, but am getting an error on typing 'git review -s' [04:33:26] 10MediaWiki-extensions-ParserFunctions: add tracking category for expression errors - https://phabricator.wikimedia.org/T25959#2908159 (10Liuxinyu970226) [04:33:41] 10MediaWiki-extensions-ParserFunctions: add tracking category for time errors - https://phabricator.wikimedia.org/T63425#2908161 (10Liuxinyu970226) [04:39:01] ravi: What's the error? [04:39:02] (03PS1) 10TTO: Improve strings for the contentmodel log [core] - 10https://gerrit.wikimedia.org/r/329730 [04:39:18] I'm getting no message. [04:39:48] How can I check if everything is fine? [04:40:35] That's strange. So you type git review -s and you just get blankness? [04:41:41] yes [04:47:08] (03PS1) 10VolkerE: Replace deprecated color variable with current [extensions/Flow] - 10https://gerrit.wikimedia.org/r/329732 [04:54:58] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Do a research on the communication tools Zulip and Mattermost, and document the pros and cons of using them - https://phabricator.wikimedia.org/T154001#2897987 (10MtDu) I made some edits to the grammar for better English here https://m... [05:00:11] ravi: Not sure what the matter could be. Sometimes it is very slow, as in it takes a few minutes. Did you give it time to run? [05:00:20] yes [05:02:11] 10MediaWiki-Special-pages: Special:WantedCategories on eswiki - "Fatal exception of type "Wikimedia\Assert\ParameterAssertionException"" - https://phabricator.wikimedia.org/T146778#2670924 (10TTO) ``` MariaDB [eswiki_p]> SELECT /* WantedCategoriesPage::reallyDoQuery TTO */ 14 AS `namespace`,cl_to AS `title`,COUN... [05:02:32] ravi: If you try to download a patch using git review -d 123456, does it work? [05:04:57] yes. but, it finally gave: fatal, could not find remote ... [05:05:13] Can you paste the full error message somewhere? [05:05:15] like dpaste.de [05:05:56] fatal, could not find remote ref refs/changes/56/123456/1 [05:06:30] OK, so it seems to be able to connect to Gerrit. That error is probably because Gerrit change 123456 is for a different repository [05:06:43] Have you tried submitting a patch using git review -R? [05:07:23] No changes between HEAD and origin/master. [05:08:17] OK. It seems to be working as expected. [05:08:34] (I'm guessing you haven't committed any changes yet?) [05:09:27] Yes, thanks. How to start fixing bugs? [05:10:58] ravi: Have you found a task or bug you would like to fix? [05:11:06] no [05:11:58] ravi: Take a look at https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [05:12:00] See if it helps you [05:27:01] 10MediaWiki-Special-pages, 10MediaWiki-extensions-Babel: Special:WantedCategories on eswiki - "Fatal exception of type "Wikimedia\Assert\ParameterAssertionException"" - https://phabricator.wikimedia.org/T146778#2908168 (10TTO) The immediate cause is the Babel call `{{#babel:pt-br-1}}`. The problem seems to be... [05:37:00] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Do a research on the communication tools Zulip and Mattermost, and document the pros and cons of using them - https://phabricator.wikimedia.org/T154001#2908170 (10jayvdb) Here is good, or on the talk page. [05:38:40] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Identify, research, and document open-source team communication & collaboration tools - https://phabricator.wikimedia.org/T154002#2908172 (10jayvdb) Should this task include or exclude research on MatterMost and Zulip, which is covered... [05:47:18] (03PS1) 10TTO: TitleValue: Include the invalid DB key in the message when throwing [core] - 10https://gerrit.wikimedia.org/r/329734 (https://phabricator.wikimedia.org/T146778) [05:57:15] 10MediaWiki-Internationalization, 10Pywikibot-i18n, 06Wikipedia-iOS-App-Backlog, 03Google-Code-In-2016, 07I18n: [CGI template easy task] Find and fix syntax errors in translated messages - https://phabricator.wikimedia.org/T148121#2908178 (10jayvdb) [05:59:23] 10MediaWiki-extensions-Babel, 13Patch-For-Review: Babel categorises rating of zero as meaning ability to speak a language - https://phabricator.wikimedia.org/T146909#2908180 (10TTO) 05Open>03Resolved a:03Legoktm Patch was merged, appears to be resolved. [06:00:55] 10MediaWiki-Internationalization, 10Pywikibot-i18n, 06Wikipedia-iOS-App-Backlog, 03Google-Code-In-2016, 07I18n: [CGI template easy task] Find and fix syntax errors in translated messages - https://phabricator.wikimedia.org/T148121#2908183 (10jayvdb) [06:05:25] 10MediaWiki-Internationalization, 10Pywikibot-i18n, 06Wikipedia-iOS-App-Backlog, 03Google-Code-In-2016, 07I18n: [CGI template easy task] Find and fix syntax errors in translated messages - https://phabricator.wikimedia.org/T148121#2908184 (10jayvdb) Hiya @PratyyaGhosh, the task is to fix a **technical**... [06:06:35] 10MediaWiki-Special-pages, 10MediaWiki-extensions-Babel, 13Patch-For-Review: Special:WantedCategories on eswiki - "Fatal exception of type "Wikimedia\Assert\ParameterAssertionException"" - https://phabricator.wikimedia.org/T146778#2908185 (10TTO) Once the Babel patch is merged and deployed, a null edit of th... [06:19:31] 10MediaWiki-Internationalization, 07I18n, 07Schema-change: Specify default language on a per-page basis - https://phabricator.wikimedia.org/T11360#2908188 (10TTO) [06:19:33] 10MediaWiki-Internationalization, 07I18n: Special:PageLanguage does not tag page html output correctly - https://phabricator.wikimedia.org/T74940#2908186 (10TTO) 05Open>03Resolved This seems fixed nowadays. https://meta.wikimedia.org/wiki/Wikim%C3%A9dia_France has French as its content language, and we hav... [06:22:20] 10MediaWiki-Export-or-Import, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#2908189 (10TTO) >>! In T17000#2908079, @Peachey88 wrote: > Don't we already have maintenance scripts that allow these large... [06:26:37] 10Phabricator (Upstream), 07Upstream: Can't see and choose from all of the visibility options on smaller screens - https://phabricator.wikimedia.org/T154333#2908190 (10Peachey88) [06:31:40] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2908192 (10jayvdb) [06:37:29] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2908206 (10jayvdb) @mvolz, I notice you were focusing on the citation templates, which is a great idea, and I added some bahasa ones (and increa... [06:39:30] 10MediaWiki-Internationalization, 07I18n: Special:PageLanguage does not tag page html output correctly - https://phabricator.wikimedia.org/T74940#2908208 (10Liuxinyu970226) [06:39:40] 10MediaWiki-Internationalization: Use 'de-CH' instead of 'de-ch' for attribute lang in HTML - https://phabricator.wikimedia.org/T74939#747649 (10Liuxinyu970226) [06:41:01] 06Discovery, 10Wikimedia-Portals, 07I18n, 07RTL: language and direction are not set at the wikimedia.org portal - https://phabricator.wikimedia.org/T154349#2908214 (10Amire80) [06:42:01] (03CR) 10Legoktm: [C: 04-2] "This has nothing to do with the bug." [vendor] - 10https://gerrit.wikimedia.org/r/329726 (https://phabricator.wikimedia.org/T154345) (owner: 10Paladox) [06:42:33] 06Discovery, 10Wikimedia-Portals, 07I18n: "Wikipedia apps are now available" at the wikipedia.org portal is not translatable - https://phabricator.wikimedia.org/T154350#2908227 (10Amire80) [06:46:19] 10MediaWiki-General-or-Unknown, 07Composer, 13Patch-For-Review: Composer version 1.3.0 causes a "Undefined index: hash" in includes/libs/composer/ComposerLock.php on line 19 - https://phabricator.wikimedia.org/T154345#2908240 (10Legoktm) 05Open>03declined REL1_26 is EOL and no longer supported. This bug... [06:49:23] 10MediaWiki-Internationalization, 10Pywikibot-i18n, 06Wikipedia-iOS-App-Backlog, 03Google-Code-In-2016, 07I18n: [CGI template easy task] Find and fix syntax errors in translated messages - https://phabricator.wikimedia.org/T148121#2908242 (10jayvdb) [06:50:36] 06Discovery, 10Wikimedia-Portals, 07I18n, 07RTL: language and direction are not set at the wikimedia.org portal - https://phabricator.wikimedia.org/T154349#2908243 (10Amire80) [06:50:46] 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 10MediaWiki-extensions-ParserFunctions, 10MediaWiki-extensions-Scribunto, 07Easy: Provide "wikitext" means of accessing arbitrary wiki page's default category sort key - https://phabricator.wikimedia.org/T154346#2908245 (10Legoktm) > Add a function or p... [06:51:55] 10MediaWiki-Internationalization, 10Pywikibot-i18n, 06Wikipedia-iOS-App-Backlog, 03Google-Code-In-2016, 07I18n: [CGI template easy task] Find and fix syntax errors in translated messages - https://phabricator.wikimedia.org/T148121#2715443 (10MtDu) @PratyyaGhosh 1. You need to find a syntax error in a me... [06:53:30] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint, 13Patch-For-Review: [Recurring Task] Wikipedia.org Portal: update with new files from translatewiki - https://phabricator.wikimedia.org/T142582#2540109 (10Amire80) >>! In T142582#2881624, @debt wrote: > Also - the app links are purposely not tran... [06:56:58] (03PS13) 10TTO: Special:PageLanguage: Ensure the user has permission to edit the page [core] - 10https://gerrit.wikimedia.org/r/143015 (https://phabricator.wikimedia.org/T74965) (owner: 10Kunalgrover05) [06:59:46] (03CR) 10Legoktm: "I don't think there are any maint scripts that call this - it should be fine. I think merging it as is (well, see my inline comment for a " (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/329213 (owner: 10Matěj Suchánek) [07:55:39] 10MediaWiki-General-or-Unknown, 07Composer, 13Patch-For-Review: Composer version 1.3.0 causes a "Undefined index: hash" in includes/libs/composer/ComposerLock.php on line 19 - https://phabricator.wikimedia.org/T154345#2908270 (10Legoktm) (The original ticket was {T147189}, for reference). [08:04:55] 10MediaWiki-Releasing: make-release.py should generate gitinfo.json files for extensions/skins so VCS information shows up in Special:Version - https://phabricator.wikimedia.org/T154352#2908272 (10Legoktm) [08:16:04] (03CR) 10Legoktm: [C: 032] Improve strings for the contentmodel log [core] - 10https://gerrit.wikimedia.org/r/329730 (owner: 10TTO) [08:16:27] * tto waves at legoktm [08:16:32] hi tto :) [08:19:26] (03CR) 10Gergő Tisza: "Probably screen miscalibration is less of a problem on mobile devices since they tend to have less flexible display settings?" [core] - 10https://gerrit.wikimedia.org/r/327849 (https://phabricator.wikimedia.org/T152532) (owner: 10VolkerE) [08:25:32] (03Merged) 10jenkins-bot: Improve strings for the contentmodel log [core] - 10https://gerrit.wikimedia.org/r/329730 (owner: 10TTO) [08:26:21] 10Connected-Open-Heritage-Wikidata-migration (se-arbetsl): Request WD property for museum ID number - https://phabricator.wikimedia.org/T153433#2908286 (10Alicia_Fagerving_WMSE) Property has been marked as ready for creation: https://www.wikidata.org/wiki/Wikidata:Property_proposal/ArbetSam_ID [08:34:43] (03CR) 10jenkins-bot: Improve strings for the contentmodel log [core] - 10https://gerrit.wikimedia.org/r/329730 (owner: 10TTO) [08:38:21] Reedy, are you here? [08:45:32] (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated attribute "width" with CSS "width" property [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329701 (https://phabricator.wikimedia.org/T42211) (owner: 10MtDu) [08:45:42] 10MediaWiki-extensions-FlaggedRevs, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: FlaggedRevs uses deprecated attribute "width" on diff pages - https://phabricator.wikimedia.org/T42211#2908288 (10Florian) 05Open>03Resolved [08:49:26] Please accomplish my requests for PagePopups and NamespacePopups at https://www.mediawiki.org/wiki/Git/New_repositories/Requests [08:49:53] (03Merged) 10jenkins-bot: Replace deprecated attribute "width" with CSS "width" property [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329701 (https://phabricator.wikimedia.org/T42211) (owner: 10MtDu) [08:54:41] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> just in case it fixes something" [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329124 (owner: 10Paladox) [09:11:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/329751 (owner: 10L10n-bot) [09:13:20] 10MediaWiki-Vagrant, 10Gerrit, 13Patch-For-Review: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2908307 (10Tgr) I also get the `TLS packet with unexpected length` error when doing a new checkout (MW master, jessie, git 2.11.0). [09:20:56] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2908308 (10Sophivorus) Thanks for the research! Could you create a task for this bug? I'd do it myself but I'm travelling without my computer.. El vie. 30/12/2016, 16:51, Cumbril 10MediaWiki-extensions-CentralAuth, 10DBA, 10GlobalRename, 10Wikimedia-Site-requests: Rename user SSTflyer to Feminist - https://phabricator.wikimedia.org/T154262#2908313 (10JEumerus) Seems more like a task for a database-involving project, thus tentatively added #dba under the assumption that supervising... [09:31:08] 10MediaWiki-extensions-CentralAuth, 10DBA, 10GlobalRename, 10Wikimedia-Site-requests: Rename user Candlewicke to CLWE - https://phabricator.wikimedia.org/T154323#2908316 (10JEumerus) Per T154262#2908313 [09:31:32] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Rename user SSTflyer to Feminist - https://phabricator.wikimedia.org/T154262#2908320 (10Legoktm) >>! In T154262#2908313, @JEumerus wrote: > Seems more like a task for a database-involving project, thus tentatively added #dba under... [09:31:48] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Rename user Candlewicke to CLWE - https://phabricator.wikimedia.org/T154323#2908322 (10Legoktm) [09:35:06] (03CR) 10Robert Vogel: [C: 032] Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329684 (owner: 10Umherirrender) [09:35:17] (03PS1) 10Robert Vogel: Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329757 [09:35:32] (03Merged) 10jenkins-bot: Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329684 (owner: 10Umherirrender) [09:36:07] (03CR) 10Robert Vogel: [C: 032] Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329757 (owner: 10Robert Vogel) [09:36:21] (03CR) 10Robert Vogel: [C: 032] Remove duplicate manifest_version from UserManager/extension.json [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329719 (owner: 10Paladox) [09:36:30] (03PS2) 10Robert Vogel: Remove duplicate manifest_version from UserManager/extension.json [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329719 (owner: 10Paladox) [09:36:33] (03Merged) 10jenkins-bot: Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329757 (owner: 10Robert Vogel) [09:36:37] (03CR) 10DatGuy: [C: 04-1] "I'm trying to get this started again. First of all, is it just me or is there a lot of excess, useless whitespace? Second thing is that I'" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/288752 (https://phabricator.wikimedia.org/T100263) (owner: 10Sethakill) [09:37:04] 10MediaWiki-Vagrant, 10Gerrit, 13Patch-For-Review: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2908323 (10Tgr) [09:37:49] (03CR) 10Robert Vogel: [C: 032] Removed unneeded apihelp messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329677 (owner: 10Umherirrender) [09:38:49] (03Merged) 10jenkins-bot: Removed unneeded apihelp messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329677 (owner: 10Umherirrender) [09:38:51] (03CR) 10Robert Vogel: [C: 032] Add installer to MessagesDirs [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/329676 (owner: 10Umherirrender) [09:40:14] (03Merged) 10jenkins-bot: Add installer to MessagesDirs [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/329676 (owner: 10Umherirrender) [09:45:48] 04(no projects): qwerghjkl;' - https://phabricator.wikimedia.org/T154354#2908324 (10TTO) [09:46:00] 04(no projects): qwerghjkl;' - https://phabricator.wikimedia.org/T154354#2908335 (10TTO) 05Open>03Invalid Sorry!! [09:48:58] Reedy: Will there be another tasks? [09:56:18] (03PS1) 10Legoktm: Add libzim.pc for pkg-config [openzim] - 10https://gerrit.wikimedia.org/r/329759 [09:56:42] tto: you need to explain now :) [09:57:49] legoktm: I was going through my open tabs, and a new task form was open. I couldn't remember why it was there so I ran my finger across the keyboard while trying to think, and finished up on the Enter key :) [09:57:57] heh [09:58:14] Are you on vacation at the moment? [10:02:15] (03CR) 10Kelson: [V: 032 C: 032] Add libzim.pc for pkg-config [openzim] - 10https://gerrit.wikimedia.org/r/329759 (owner: 10Legoktm) [10:02:58] (03CR) 10Gergő Tisza: [C: 04-1] Convert statsd to systemd (031 comment) [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) (owner: 10BryanDavis) [10:03:59] (03CR) 10Kelson: "It's unclear to me what this patch is for:" [openzim] - 10https://gerrit.wikimedia.org/r/328341 (owner: 10Mgautierfr) [10:04:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] Remove WebRequest::checkSessionCookie() method as being deprecated (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [10:05:03] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2908339 (10jayvdb) [10:10:41] (03PS8) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [10:11:45] (03CR) 10jerkins-bot: [V: 04-1] AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [10:12:34] (03PS9) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [10:12:37] (03PS6) 10Florianschmidtwelzow: Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) [10:13:30] legoktm, I guess Reedy is busy right now, may I ask you to review this change? https://gerrit.wikimedia.org/r/329242 [10:13:40] (03PS2) 10Florianschmidtwelzow: Make sure, that "Prompt me when entering a blank edit summary" works with Hooks [core] - 10https://gerrit.wikimedia.org/r/295603 (https://phabricator.wikimedia.org/T12729) [10:14:18] (03PS6) 10Florianschmidtwelzow: Remove Special:UnlinkAccounts functionality [core] - 10https://gerrit.wikimedia.org/r/292833 (https://phabricator.wikimedia.org/T136000) [10:14:56] (03PS2) 10Florianschmidtwelzow: Add Backlinks to Special:(Change|Remove)Credentials [core] - 10https://gerrit.wikimedia.org/r/292832 [10:16:40] And also, legoktm, Akismet.class.php contains 5 different classes and in the task it is required to convert it to autoloader, how to do that properly? [10:17:45] Georggi: just add those class names to "AutoloadClasses" [10:17:59] Each separatly but with the same file? [10:18:42] yes [10:19:48] (03CR) 10Legoktm: [C: 031] "Looks good, just needs the autoloader stuff as discussed on IRC." (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [10:20:09] (03PS10) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [10:21:22] Georggi: and remove the require_once? [10:21:27] Oups [10:21:46] (03PS11) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [10:27:58] (03PS2) 10Florianschmidtwelzow: Remove doubled title on Special:MIMESearch [core] - 10https://gerrit.wikimedia.org/r/290493 [10:30:39] 10MediaWiki-Special-pages, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Add hook before changing of userrights - https://phabricator.wikimedia.org/T49338#2908342 (10matej_suchanek) a:05MtDu>03None [10:32:24] (03CR) 10TTO: [C: 032] Remove doubled title on Special:MIMESearch [core] - 10https://gerrit.wikimedia.org/r/290493 (owner: 10Florianschmidtwelzow) [10:43:58] (03Merged) 10jenkins-bot: Remove doubled title on Special:MIMESearch [core] - 10https://gerrit.wikimedia.org/r/290493 (owner: 10Florianschmidtwelzow) [10:54:56] (03CR) 10jenkins-bot: Remove doubled title on Special:MIMESearch [core] - 10https://gerrit.wikimedia.org/r/290493 (owner: 10Florianschmidtwelzow) [11:02:58] (03CR) 10Florianschmidtwelzow: [C: 032] TitleValue: Include the invalid DB key in the message when throwing [core] - 10https://gerrit.wikimedia.org/r/329734 (https://phabricator.wikimedia.org/T146778) (owner: 10TTO) [11:03:48] legoktm, what does $msg->plain() convert into when conveting from Linker:link()? Isn't it just stays plain()? [11:09:02] tto: hi :) If you fix the failed tests at https://gerrit.wikimedia.org/r/#/c/329733/2 I'll merge it :D [11:09:24] FlorianSW_: I'm working on it right now. The tests actually helped catch a subtle bug :) [11:09:38] :P [11:10:48] (03Merged) 10jenkins-bot: TitleValue: Include the invalid DB key in the message when throwing [core] - 10https://gerrit.wikimedia.org/r/329734 (https://phabricator.wikimedia.org/T146778) (owner: 10TTO) [11:11:38] Georggi: if I understand your question correctly: yes :P [11:13:46] I will let you know when I see MtDu around here [11:13:46] @notify MtDu [11:17:09] tonythomas: Btw, this will be imported as GCI? https://phabricator.wikimedia.org/T154342 [11:17:17] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [11:17:17] @notify tonythomas [11:18:19] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [11:18:19] @notify Reedy [11:23:37] (03CR) 10jenkins-bot: TitleValue: Include the invalid DB key in the message when throwing [core] - 10https://gerrit.wikimedia.org/r/329734 (https://phabricator.wikimedia.org/T146778) (owner: 10TTO) [11:27:39] (03PS1) 10Divadsn: Replace Linker::link() with LinkRenderer [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/329763 (https://phabricator.wikimedia.org/T149346) [11:38:04] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2908349 (10Cumbril) @Sophivorus Sure, I will create a task. Wasn't sure if this is a bug or feature... [11:40:08] FlorianSW, I fixed the patch [11:40:09] (03CR) 10Paladox: "Thanks." [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329719 (owner: 10Paladox) [11:40:48] (03CR) 10Paladox: "@Robert Vogel you should be able to c+2 now without force merging. Fixed merging last night :)" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329719 (owner: 10Paladox) [11:40:56] (03PS8) 10Florianschmidtwelzow: Display Parsoid version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) [11:41:07] I take a look! :) [11:41:13] (03CR) 10jerkins-bot: [V: 04-1] Display Parsoid version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [11:41:27] (03CR) 10Paladox: "oh not sure." [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329124 (owner: 10Paladox) [11:42:25] (03CR) 10Paladox: "recheck" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/214023 (owner: 10Microchip08) [11:45:55] (03PS8) 10Paladox: remove "show block log for user" button [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/214023 (https://phabricator.wikimedia.org/T11315) (owner: 10Microchip08) [11:46:08] tto: Have you uploaded a new patchset? :) [11:46:12] (03CR) 10Georggi199: "Except those last lines in two files changed(Why they are?), everything looks fine." (032 comments) [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/329763 (https://phabricator.wikimedia.org/T149346) (owner: 10Divadsn) [11:46:39] FlorianSW: It's up to PS5 [11:46:47] PS5 got a Jenkins +2 [11:47:15] (03Abandoned) 10Paladox: Remove hash from composer.lock [vendor] - 10https://gerrit.wikimedia.org/r/329726 (https://phabricator.wikimedia.org/T154345) (owner: 10Paladox) [11:47:28] ah, damn, I missed to put myself as a Reviewer into the change, that's why I got no e-mail from gerrit :P [11:48:40] 10Wikimedia-General-or-Unknown: Sidebar is located under text field on ru.wp (due to mistake in MediaWiki:Newarticletext) - https://phabricator.wikimedia.org/T154326#2908379 (10Aklapper) [11:50:42] FlorianSW hi, im wondering would you be able to review https://gerrit.wikimedia.org/r/#/c/329698/ and https://gerrit.wikimedia.org/r/#/c/329698/ please? These patches are backports from the master branch (mw core) [11:52:12] FlorianSW: Thanks :) [11:52:49] (03PS2) 10Victorbarbu: Remove WebRequest::checkSessionCookie() method as being deprecated [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) [11:52:54] (03CR) 10Victorbarbu: Remove WebRequest::checkSessionCookie() method as being deprecated (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [11:54:57] tto: you're welcome! :) [11:55:11] @paladox: have you read: https://www.mediawiki.org/wiki/Backporting_fixes#Backports_to_stable.2Fsupported_release ? Is there a task for this bug? [11:55:58] you should also change the RELASE-NOTES file [11:56:32] FloranSW nope no task, i only cherry picked the commit from master. Reading the commit msg and it saying theres a bug in php 5, i thought i should cherry pick it to the stable branches as those releases are the ones that are going to support php 5 the longest. [11:57:38] Oh, what do i put in RELEASE-NOTES?, do i copy the first commit msg ( [11:57:39] PHPSessionHandler: Workaround PHP5 bug), and put it under the bug fix section? [11:58:05] (03PS3) 10Paladox: Replace FSRepo with FileRepo [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329717 (https://phabricator.wikimedia.org/T154343) [11:58:10] paladox: I know, and I'm happy to merge them, however, we should create a task for this and add the release project tags so it shows up for the release managament team, which then can deceide when and if a new release is created :) [11:58:24] oh [11:58:39] put it under the bug fix section, but with a reasonable and a probably more understandable message. [11:58:44] Ok [11:59:10] (03CR) 10Divadsn: "@Georggi199 don't ask me why, probably because Atom removed the last empty newline. But this shouldn't be a problem I think." [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/329763 (https://phabricator.wikimedia.org/T149346) (owner: 10Divadsn) [11:59:42] Something like "Increase compatibility of PHPSessionHandler for PHP 5" or something like this [12:00:56] 04(no projects): PHP5 has a bug in handling boolean return values for SessionHandlerInterface methods - https://phabricator.wikimedia.org/T154356#2908383 (10Paladox) [12:00:56] (03PS1) 10Seb35: Replace mocks of DatabaseMysql by DatabaseMysqli [core] - 10https://gerrit.wikimedia.org/r/329764 (https://phabricator.wikimedia.org/T120333) [12:01:02] FlorianSW https://phabricator.wikimedia.org/T154356 [12:01:29] 10MediaWiki-General-or-Unknown, 05MW-1.27-release, 05MW-1.28-release: PHP5 has a bug in handling boolean return values for SessionHandlerInterface methods - https://phabricator.wikimedia.org/T154356#2908396 (10Paladox) [12:02:32] 10MediaWiki-General-or-Unknown, 05MW-1.27-release, 05MW-1.28-release: PHP5 has a bug in handling boolean return values for SessionHandlerInterface methods - https://phabricator.wikimedia.org/T154356#2908398 (10Florian) [12:03:34] paladox: could you please mention the task in the commit messages of the backports (the "Bug: TXXXX" line)? And please add a line in the RELEASE-NOTES [12:03:48] Yep, doing now :) [12:04:56] 10MediaWiki-Database, 07NewPHP, 13Patch-For-Review, 07Technical-Debt: Remove old mysql extension support in favor of mysqli - https://phabricator.wikimedia.org/T120333#2908399 (10Seb35) The two patches in mediawiki/core are independent, as long as there is no hard-deprecation or removal. [12:05:06] (03PS2) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) [12:05:15] FlorianSW ^^ [12:05:56] (03PS2) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [12:07:09] (03CR) 10Florianschmidtwelzow: [C: 032] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:07:26] FlorianSW thanks :) [12:07:34] (03CR) 10Florianschmidtwelzow: [C: 032] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:07:42] :) [12:07:46] paladox: you're welcome [12:07:53] :) [12:08:23] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: User-group autoreview should be in the implicitgroups (API output) if editor - https://phabricator.wikimedia.org/T153548#2908404 (10Umherirrender) >>! In T153548#2907758, @Perhelion wrote: > In which case should the Autoreview group be removed... [12:11:57] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::link() with LinkRenderer [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/329763 (https://phabricator.wikimedia.org/T149346) (owner: 10Divadsn) [12:13:15] (03CR) 10Reedy: [C: 04-1] PHPSessionHandler: Workaround PHP5 bug (032 comments) [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:13:35] (03CR) 10jerkins-bot: [V: 04-1] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:13:45] (03CR) 10Reedy: [C: 04-1] PHPSessionHandler: Workaround PHP5 bug (032 comments) [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:13:57] (03CR) 10jerkins-bot: [V: 04-1] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:14:51] (03PS3) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [12:15:20] (03CR) 10Paladox: PHPSessionHandler: Workaround PHP5 bug (032 comments) [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:15:58] Reedy, please review my change: https://gerrit.wikimedia.org/r/#/c/329242/ [12:17:07] (03Merged) 10jenkins-bot: Replace Linker::link() with LinkRenderer [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/329763 (https://phabricator.wikimedia.org/T149346) (owner: 10Divadsn) [12:18:26] (03PS1) 10Divadsn: Removed deprecated functions in includes/Revision.php [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) [12:22:49] (03CR) 10jerkins-bot: [V: 04-1] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:24:34] FlorianSW, one question about Gerrit and merge conflicts, what if two changes have lines added to the same file? Are these changes merged into one using diff? [12:25:25] hä? :D [12:25:35] they're not merged automatically, if you mean that :) [12:25:36] (03CR) 10jerkins-bot: [V: 04-1] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:26:16] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated functions in includes/Revision.php [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:26:44] (03CR) 10Reedy: [C: 032] AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [12:27:13] (03CR) 10TTO: AkismetKlik extension cleanup (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [12:27:32] (03PS2) 10Divadsn: Removed deprecated functions in includes/Revision.php [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) [12:27:44] (03Merged) 10jenkins-bot: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [12:27:49] Thanks Reedy. [12:28:43] (03CR) 10Divadsn: "Reverting removal of Revision::userWasLastToEdit(), as it is being used in EditPage." [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:30:08] (03PS1) 10Georggi199: Replaced deprecated Linker::link() usages [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/329767 (https://phabricator.wikimedia.org/T149346) [12:30:23] (03CR) 10TTO: Removed deprecated functions in includes/Revision.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:31:17] (03PS1) 10Georggi199: Replaced deprecated Linker::link() usages [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/329768 (https://phabricator.wikimedia.org/T149346) [12:31:34] (03CR) 10Divadsn: "Will revert the removal now." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:32:33] (03PS1) 10Georggi199: Replaced deprecated Linker::link() usages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329769 (https://phabricator.wikimedia.org/T149346) [12:33:02] (03PS3) 10Divadsn: Removed deprecated functions in includes/Revision.php [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) [12:35:50] (03CR) 10Divadsn: "I had to reset my local repos as they were not up-to-date, so my previous work was abandonded." [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:36:06] (03CR) 10Reedy: [C: 04-2] "I know my repos are out of date on my laptop, but I'm fairly sure all of these won't have been fixed in all extensions..." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:38:42] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated functions in includes/Revision.php [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:39:02] (03CR) 10Divadsn: "So we are waiting until these usages has been removed in all extensions? And btw, is there a way how to clone all available extensions, to" [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:42:21] (03CR) 10TTO: "I use GitHub code search: https://github.com/search?q=user%3Awikimedia+getrawuser&type=Code&utf8=%E2%9C%93" [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:43:08] (03CR) 10Reedy: [C: 04-2] "git clone ssh://gerrit.wikimedia.org:29418/mediawiki/extensions" [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:43:47] (03CR) 10Reedy: [C: 04-2] "The github search is only useful for the greppable ones; ie when it's a function name that's unique." [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:45:51] 10ProveIt-Gadget: proveit-tag not applied after 'Show preview' or 'Show changes' - https://phabricator.wikimedia.org/T154357#2908412 (10Cumbril) [12:46:23] (03CR) 10Divadsn: "Thanks for the tip @Reedy :)" [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [12:47:08] (03PS3) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) [12:47:30] (03CR) 10Paladox: PHPSessionHandler: Workaround PHP5 bug (032 comments) [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:58:19] (03CR) 10Paladox: "recheck" [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [12:59:29] (03Abandoned) 10Divadsn: Removed deprecated functions in includes/Revision.php [core] - 10https://gerrit.wikimedia.org/r/329766 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:02:04] (03PS4) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [13:05:09] 10MediaWiki-extensions-Nuke, 15User-Ladsgroup: Change button value to clearer description like “List pages” - https://phabricator.wikimedia.org/T154347#2908425 (10Ladsgroup) I'm not a native English speaker but I think the "Go" in it was made to make it feel more like "nuking". We can make it serious but not s... [13:05:49] (03CR) 10jerkins-bot: [V: 04-1] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [13:07:15] 10Wikimedia-Site-requests: Set $wgAbuseFilterNotificationsPrivate = true; on Meta-Wiki - https://phabricator.wikimedia.org/T154358#2908427 (10MarcoAurelio) [13:07:49] (03CR) 10Paladox: "recheck" [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [13:08:24] 10MediaWiki-extensions-Nuke, 15User-Ladsgroup: Change button value to clearer description like “List pages” - https://phabricator.wikimedia.org/T154347#2908132 (10TTO) >>! In T154347#2908425, @Ladsgroup wrote: > I'm not a native English speaker but I think the "Go" in it was made to make it feel more like "nuk... [13:08:59] (03PS5) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [13:09:42] Reedy: Will there be more tasks? [13:09:57] Probably [13:10:06] Just need to find some time to get them made up [13:10:18] (03PS6) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [13:10:29] Reedy: Great, there's nothing to do now, except wikiedudashboard [13:13:56] 10Wikimedia-Site-requests, 13Patch-For-Review: Remove the 'technican' usergroup on tr.wikiquote - https://phabricator.wikimedia.org/T152911#2908445 (10MarcoAurelio) [13:14:21] 10Wikimedia-Site-requests, 13Patch-For-Review: Remove the 'technican' usergroup on tr.wikiquote - https://phabricator.wikimedia.org/T152911#2863271 (10MarcoAurelio) The community [[ https://tr.wikiquote.org/w/index.php?title=Vikis%C3%B6z:K%C3%B6y_%C3%A7e%C5%9Fmesi&oldid=145629#About_the_.27technican.27_user_gr... [13:14:24] (03CR) 10Reedy: [C: 04-2] "Needs RELEASE-NOTES" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [13:15:11] rlot: There's various contenthandler ones that could be turned into tasks quite easily at least [13:15:34] Reedy: Would be awesome! [13:19:04] (03PS1) 10Divadsn: Removed deprecated class ImageGallery [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) [13:19:14] (03CR) 10jerkins-bot: [V: 04-1] PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [13:19:41] (03CR) 10Paladox: "recheck" [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) (owner: 10Paladox) [13:20:58] (03CR) 10Reedy: [C: 04-1] Removed deprecated class ImageGallery (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:22:03] (03CR) 10Divadsn: "@Reedy will remove the usages in the extensions after my local machine has cloned the repos." [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:22:19] (03CR) 10Reedy: [C: 04-1] "(Y)" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:22:49] Reedy: Btw, in this akismet klik extension, should we keep backward compatibility? [13:22:57] Which back compat? [13:23:35] Reedy: It replaces old .php file with extension registration [13:23:53] Yeah, but what back compat are you talking about? [13:24:06] >1.25 [13:24:19] Now its >1.13 [13:24:29] 1.13 is ancient [13:24:32] 1.23 is old enough [13:24:38] We don't need back compat anywhere near that far [13:25:02] Reedy: But extension registration was introduced in 1.25 [13:25:07] Doesn't matter [13:25:18] We have extension branches for this reason [13:25:31] (03PS2) 10Awu42: Removed deprecated functions in includes/Title.php [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) [13:25:33] Reedy: So we need to update wiki [13:25:35] after merge [13:25:40] Feel free :) [13:25:50] Reedy: Oh, merged. I'll do it [13:26:16] (03PS7) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 (https://phabricator.wikimedia.org/T154356) [13:26:37] GCI site is sucking again :( [13:26:54] (03CR) 10Divadsn: "@Reedy, there are no usages in the core" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:26:56] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated class ImageGallery [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:27:33] (03CR) 10Reedy: [C: 04-1] "Apparently it's used in some comments though in core" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:27:56] (03CR) 10Divadsn: "Should we fix these comments?" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:28:38] (03CR) 10Reedy: [C: 04-1] "Of course! as otherwise they're referencing a class that doesn't exist anymore" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [13:29:20] 04(no projects): Mobile version small formulas iOS 8.1 - https://phabricator.wikimedia.org/T154360#2908474 (10Yanpas) [13:30:09] rlot: soon, yes [13:33:38] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2908485 (10Reedy) https://codein.withgoogle.com/dashboard/tasks/66... [13:35:06] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Research the usage of NewsletterDeletionUpdate (and probably remove it) - https://phabricator.wikimedia.org/T154341#2908488 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/4888252748136448/ waiting for one of the admins to ap... [13:35:26] 10MediaWiki-Database, 10MediaWiki-Installer, 07TestMe: 0 for the SQLite database name (as in 0.sqlite) breaks installation without warnings - https://phabricator.wikimedia.org/T42966#2908490 (10Paladox) [13:36:18] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remove redundant and unnecessary logging from the Newsletter Extension - https://phabricator.wikimedia.org/T154342#2908492 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5151321374064640/ waiting for one of the admins to appr... [13:38:24] (03PS1) 10Divadsn: Fix wrong class names in comments [core] - 10https://gerrit.wikimedia.org/r/329776 [13:40:04] (03PS2) 10Divadsn: Fix wrong class name for ImageGalleryBase in comments [core] - 10https://gerrit.wikimedia.org/r/329776 [13:41:49] FlorianSW: andre__: ^^ [13:42:18] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2908496 (10Reedy) doEdit in https://codein.withgoogle.com/dashboar... [13:43:45] 10MediaWiki-Uploading, 06Multimedia: Refuse uploading JPEG files with extra junk at the end. - https://phabricator.wikimedia.org/T48921#2908497 (10zhuyifei1999) FYI: [[https://commons.wikimedia.org/wiki/Commons:Bots/Requests/Embedded_Data_Bot|I have coded (or I am coding) a bot]] to automatically detect such f... [13:45:05] (03PS3) 10Awu42: Removed deprecated functions in includes/Title.php [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) [13:45:14] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2908498 (10Reedy) And revision::getText is only in SemanticPageMak... [13:46:09] rlot: I just created 5 more tasks, but they need publishing [13:46:31] Reedy: Thanks, will do it next year :) [13:46:38] (03PS10) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [13:46:41] rlot: But there's a whole day left! ;) [13:46:45] well, half [13:46:49] (03CR) 10Paladox: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [13:47:12] (03PS1) 10Divadsn: Remove deprecated usages of ImageGallery [extensions/intersection] - 10https://gerrit.wikimedia.org/r/329777 [13:48:31] 10MediaWiki-General-or-Unknown, 05MW-1.27-release, 05MW-1.28-release, 13Patch-For-Review: Backport patch from git master for bug in handling boolean return values for SessionHandlerInterface methods - https://phabricator.wikimedia.org/T154356#2908499 (10Aklapper) [13:48:50] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2908500 (10Reedy) Still various hooks to re-evaluate and do too [13:51:04] 04(no projects): Add $wgWhitelistSpecialPages option - https://phabricator.wikimedia.org/T154361#2908502 (10Reception123) [13:52:13] (03PS11) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [13:52:14] 10MediaWiki-General-or-Unknown: Add $wgWhitelistSpecialPages option - https://phabricator.wikimedia.org/T154361#2908513 (10Reedy) [13:57:15] (03PS1) 10Divadsn: Remove deprecated usages of ImageGallery [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329778 [13:58:44] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated usages of ImageGallery [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329778 (owner: 10Divadsn) [13:59:04] (03CR) 10jerkins-bot: [V: 04-1] Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:00:11] (03PS2) 10Divadsn: Remove deprecated usages of ImageGallery [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329778 [14:00:57] (03PS1) 10Divadsn: Remove deprecated usages of ImageGallery [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/329779 [14:02:21] (03CR) 10Reedy: [C: 032] Remove deprecated usages of ImageGallery [extensions/intersection] - 10https://gerrit.wikimedia.org/r/329777 (owner: 10Divadsn) [14:02:34] (03PS1) 10Divadsn: Remove deprecated usages of ImageGallery [extensions/Video] - 10https://gerrit.wikimedia.org/r/329781 [14:03:00] (03Merged) 10jenkins-bot: Remove deprecated usages of ImageGallery [extensions/intersection] - 10https://gerrit.wikimedia.org/r/329777 (owner: 10Divadsn) [14:03:11] (03CR) 10Bartosz Dziewoński: [C: 031] Cache global filter names [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/329213 (owner: 10Matěj Suchánek) [14:03:33] 10UI-Standardization, 03UI-Standardization-Kanban: Replace deprecated mediawiki.UI Less variables with current ones - https://phabricator.wikimedia.org/T154362#2908538 (10Volker_E) [14:03:36] (03CR) 10Bartosz Dziewoński: [C: 031] "(waiting for response to Legoktm)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/329213 (owner: 10Matěj Suchánek) [14:04:26] 10UI-Standardization, 07Accessibility, 07Tracking, 03UI-Standardization-Kanban: Replace abandoned colors in current WMF/Wikimedia products - https://phabricator.wikimedia.org/T148708#2730698 (10Volker_E) [14:05:26] (03CR) 10Divadsn: "I removed all usages found by you and the changes are on Gerrit with the topic deprecated-ImageGallery, see: https://gerrit.wikimedia.org/" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [14:13:06] (03CR) 10Reedy: [C: 032] Fix wrong class name for ImageGalleryBase in comments [core] - 10https://gerrit.wikimedia.org/r/329776 (owner: 10Divadsn) [14:13:38] (03PS12) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:13:41] 10MediaWiki-General-or-Unknown, 07Easy, 03Google-Code-In-2016, 05MW-1.29-release-notes, and 4 others: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113#636198 (10divadsn) >>! In T61113#2908461, @gerritbot wrote: > Change 329773 had a related patch set upl... [14:16:42] Reedy doint forget to add an extra second to the day [14:16:44] lol [14:18:55] legoktm: Around? [14:19:51] (03CR) 10jerkins-bot: [V: 04-1] Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:19:57] (03PS13) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:20:56] (03Merged) 10jenkins-bot: Fix wrong class name for ImageGalleryBase in comments [core] - 10https://gerrit.wikimedia.org/r/329776 (owner: 10Divadsn) [14:25:07] (03CR) 10jerkins-bot: [V: 04-1] Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:32:20] (03PS14) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:32:46] (03CR) 10jenkins-bot: Fix wrong class name for ImageGalleryBase in comments [core] - 10https://gerrit.wikimedia.org/r/329776 (owner: 10Divadsn) [14:34:19] (03CR) 10Reedy: [C: 032] Remove deprecated usages of ImageGallery [extensions/Video] - 10https://gerrit.wikimedia.org/r/329781 (owner: 10Divadsn) [14:34:21] (03CR) 10Reedy: [C: 032] Remove deprecated usages of ImageGallery [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/329779 (owner: 10Divadsn) [14:34:59] (03PS15) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:35:29] (03Merged) 10jenkins-bot: Remove deprecated usages of ImageGallery [extensions/Video] - 10https://gerrit.wikimedia.org/r/329781 (owner: 10Divadsn) [14:35:56] (03Merged) 10jenkins-bot: Remove deprecated usages of ImageGallery [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/329779 (owner: 10Divadsn) [14:36:48] 10MediaWiki-extensions-MultiUpload, 03Google-Code-In-2016: Kill off SpecialUpload.1.21.3 - https://phabricator.wikimedia.org/T154363#2908568 (10Reedy) [14:37:10] (03PS16) 10Paladox: Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:38:03] (03PS1) 10MtDu: Replace deprecated Article::doEdit() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/329783 (https://phabricator.wikimedia.org/T151973) [14:38:33] 10MediaWiki-extensions-MultiUpload, 03Google-Code-In-2016: Kill off SpecialUpload.1.21.3 - https://phabricator.wikimedia.org/T154363#2908581 (10Reedy) https://codein.withgoogle.com/dashboard/tasks/5595241409150976/ [14:39:15] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2906330 (10MarcoAurelio) I'm looking at the files and I don't see patrolling enabled for ruwiki. The automatic edit patrol done by sysops is not removable I think. [14:40:45] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908584 (10MaxBioHazard) https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%96%D1%83%D1%80%D0%BD%D0%B0%D0%BB%D1%8B&type=patrol&user=Oude-rusman&page=&tagfilter=... [14:42:04] 06MediaWiki-Stakeholders-Group: Contact rianjs about their hg mediawiki branch - https://phabricator.wikimedia.org/T1030#2908585 (10Seb35) [14:43:33] 06MediaWiki-Stakeholders-Group: Contact rianjs about their hg mediawiki branch - https://phabricator.wikimedia.org/T1030#17887 (10Seb35) I wondered what was this task so I’ve added some links. [14:44:29] (03CR) 10jerkins-bot: [V: 04-1] Installation script: Allow $wgCapitalLinks to be set to false [core] - 10https://gerrit.wikimedia.org/r/242420 (https://phabricator.wikimedia.org/T113879) (owner: 10Purodha) [14:45:59] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908590 (10Base) What happens to the new page patrol logs and patroller flag related user right log entries in case the task is resolved? [14:47:10] (03PS1) 10MtDu: Replace deprecated Article::doEdit() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) [14:47:15] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2906330 (10Urbanecm) So you wish to unassign autopatrol from all users? @MarcoAurelio Old patrolling is enabled for files, wgUseFilePatrol in IS. [14:47:43] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated Article::doEdit() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [14:48:30] (03PS1) 10Filip: Replaced deprecated Article::doEdit( [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329787 (https://phabricator.wikimedia.org/T151973) [14:48:38] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908595 (10MaxBioHazard) >So you wish to unassign autopatrol from all users? Exactly. [14:50:02] (03CR) 10Filip: "Looks like someone already used doEditContent, but forgot abount changing to doEditContent instead of doEdit. Wierd" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329787 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:54:32] (03PS1) 10MtDu: Replace deprecated Article::doEdit() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) [14:55:15] (03CR) 10MtDu: "@Reedy, please take a look before I fix the syntax issue." (031 comment) [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [14:56:04] (03PS1) 10Filip: Replaced deprecated "Article::doEdit(" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/329789 (https://phabricator.wikimedia.org/T151973) [14:56:44] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908598 (10Urbanecm) >>! In T154285#2908590, @Base wrote: > What happens to the new page patrol logs and patroller flag related user right log entries in case the task is resolved? I think nothing. History can'... [14:56:57] (03CR) 10Reedy: [C: 032] Remove deprecated usages of ImageGallery [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329778 (owner: 10Divadsn) [14:57:29] (03Merged) 10jenkins-bot: Remove deprecated usages of ImageGallery [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329778 (owner: 10Divadsn) [14:57:31] lol whut, MultiUpload [14:57:41] that piece of junk isn't even maintained really [14:57:41] (03CR) 10Reedy: [C: 04-1] "CR -1 staying as you need to remove it from the autoloader too :)" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [14:57:54] (mind you, I should push an updated version out there one of these days) [14:58:35] ashley: pfft [14:58:41] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908600 (10MaxBioHazard) No, I didn't thought it should be discussed. [14:58:47] I noticed the clusterfuck that was the 1.21.3 SpecialUpload [14:59:00] no, the clusterfuck is called MultiUpload :) [14:59:04] and it totally should be in core [14:59:07] lool [14:59:13] so that that "someone else" would have to maintain it ;) [14:59:31] Make it so. [14:59:49] (03PS1) 10Filip: Removed deprecated "Article::doEdit(" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/329790 (https://phabricator.wikimedia.org/T151973) [15:01:04] I don't have the energy for that and nobody else probably feels that *Media*Wiki should have decent *media* capabilities that many users want (because, let's be real, users are often wrong. but in this case I'm inclined to agree with them. whether MultiUpload is or isn't the ideal implementation is subjective, but there definitely oughta be some sort of support for uploading multiple files... [15:01:06] ...at once in core.) [15:01:28] that being said, the API module is very hairy and very UNIX-specific; just to highlight one of this extension's many, many issues [15:01:58] @seen FlorianSW [15:01:58] subins2000: FlorianSW is in here, right now [15:02:36] FlorianSW: Hey ! I just have this doubt : Would $this->msg("key") return null if it doesn't exist ? [15:02:50] The API doc says it returns string [15:03:12] Uhm.. I mean $this->msg("key")->text() [15:03:22] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908615 (10Urbanecm) I think it should. Also please discuss if you wish to disable the old-style file patrolling too (it seems to be handled in FlaggedRevs too). [15:03:38] subins2000: it returns if there's no such message [15:04:02] (well, nowadays core uses some fancier characters instead of < and > for security reasons, but you get the idea) [15:04:41] the Message class is one of those things that's actually well-documented ;-) see https://www.mediawiki.org/wiki/Manual:Messages_API [15:04:46] So I should do if ( $this->msg("key")->text() !== "key" ) for checking whether it exist [15:05:25] subins2000: Looks like it. [15:05:32] you'll probably want if ( !$this->msg( 'key' )->isDisabled() ) { instead [15:05:49] Oops, I see there's a ->exists() function. That would work [15:06:16] subins2000: Sometimes, a message key exists, but is disabled. I think ashley is right. [15:06:16] isDisabled() or exists(). Which is better ? [15:06:25] isDisabled() it is [15:06:28] ashley:^ [15:06:31] Please confirm [15:07:49] I think isDisabled() is better, it checks that the message is defined (in some JSON file) and that its value is neither empty nor - (certain system messages can be disabled by settings their value to a -) [15:08:06] whereas exists() checks merely that the message is defined and nothing else [15:08:50] (03PS2) 10Divadsn: Removed deprecated class ImageGallery [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) [15:10:22] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908618 (10MaxBioHazard) But https://ru.wikipedia.org/wiki/special:listgrouprights says that patrol right withdrawn from all usergroups, including admins. [15:11:08] Reedy: I don't suppose you'd know whom I should bug about https://phabricator.wikimedia.org/T153849 ? for whatever reason the jobs aren't being inserted into the DB (some DB transaction weirdness, but I've no idea how to debug it further, let alone fix it...) which leads into *very* messy RecentChanges as well as issues with tools like Special:Nuke which rely on the recentchanges table and... [15:11:10] ...assume its data is somewhat up-to-date [15:12:33] Reedy: OK, made it this year :) [15:12:34] (03PS1) 10VolkerE: Replace deprecated mediawiki.UI Less variables with current ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329793 (https://phabricator.wikimedia.org/T154362) [15:12:36] http://linkbun.ch/04kw6 [15:12:52] ^^ Bunched, i'll dont sent all of these links [15:14:33] (03CR) 10Divadsn: "Thanks @Reedy, I forgot to do a grep in the core directory ^^" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [15:17:27] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908635 (10Urbanecm) Strange, I can't see it in config files... For example https://bg.wikipedia.org/wiki/Специални:Групови_права doesn't show autopatrol at all for the sysop group. [15:18:36] 10MediaWiki-extensions-MultiUpload, 03Google-Code-In-2016: Kill off SpecialUpload.1.21.3 - https://phabricator.wikimedia.org/T154363#2908568 (10ashley) I don't think that this -- or any other task related to the MultiUpload extension for that matter -- is a suitable GCI task. MultiUpload has a lot of issues an... [15:22:24] (03CR) 10Florianschmidtwelzow: [C: 031] "haven't tested, but looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329793 (https://phabricator.wikimedia.org/T154362) (owner: 10VolkerE) [15:29:43] (03PS2) 10VolkerE: Replace deprecated mediawiki.UI Less variables with current ones [extensions/Flow] - 10https://gerrit.wikimedia.org/r/329732 (https://phabricator.wikimedia.org/T154362) [15:31:43] Reedy: Also fixed intend here: https://gerrit.wikimedia.org/r/#/c/329791/ [15:31:49] Its all, submited on GCI site [15:32:27] (03PS1) 10MtDu: Replace deprecated Article::doEdit() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/329795 (https://phabricator.wikimedia.org/T151973) [15:32:39] 10MediaWiki-extensions-TitleBlacklist, 10Wikimedia-General-or-Unknown: Editing session issue (TitleBlacklist related?) on *.wikipedia.org for Kvardek du - https://phabricator.wikimedia.org/T154112#2908654 (10bd808) >>! In T154112#2908000, @Tgr wrote: > @bd808 any thoughts about shoving such errors into a separ... [15:33:17] the way the job queue is being bloated for simple tasks like rc deletion is just ridiculous [15:33:21] (03CR) 10Filip: [C: 031] "Looks good" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/329795 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:34:48] (03CR) 10Filip: [C: 04-1] Replace deprecated Article::doEdit() (031 comment) [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:36:28] (03PS2) 10MtDu: Replace deprecated Article::doEdit() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) [15:36:46] Why does $this->getLanguage()->getMessage("key") and $this->msg("key")->text() output different messages when uselang=qqx [15:36:55] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated Article::doEdit() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:36:56] (03CR) 10Filip: [C: 04-1] Replace deprecated Article::doEdit() (031 comment) [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:37:12] I get "wikibase-diffview-link$*" when getLanguage()... is used [15:37:30] (03CR) 10Filip: [C: 031] "Looks good" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/329783 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:37:31] whereas msg("key")->text() gives "wikibase-diffview-link" [15:38:29] (03PS3) 10MtDu: Replace deprecated Article::doEdit() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) [15:38:32] MtDu: MtDu_: Made comments on gerrit [15:39:22] (03CR) 10Filip: [C: 031] "Great, looks good for me now!" [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:39:55] MtDu: MtDu_: Btw, Article class is not deprecated, you don't need to replace it [15:41:09] (03PS2) 10MtDu: Replace deprecated Article::doEdit() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) [15:42:00] rlot: Your commit messages are all missing a ')' :) [15:42:32] Happy New Year's Eve everyone. Enjoy it. :) [15:42:54] MtDu: Thanks! You too! [15:43:02] Btw, when you have New Year? [15:44:54] (03CR) 10Filip: [C: 031] Replace deprecated Article::doEdit() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [15:45:20] 6 hours later than you. :P [15:45:42] andre__: UTC+7? [15:48:09] (03PS3) 10Matěj Suchánek: Support limited anon notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329374 (https://phabricator.wikimedia.org/T58828) (owner: 10Cen.temp) [15:48:24] (03CR) 10Alex Monk: [C: 032] Replaced deprecated Article::doEdit( [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329787 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:49:29] (03Merged) 10jenkins-bot: Replaced deprecated Article::doEdit( [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329787 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:51:54] !class FileRepo [15:51:54] See https://doc.wikimedia.org/mediawiki-core/master/php/classFileRepo.html [16:08:20] 06MediaWiki-Stakeholders-Group: Contact rianjs about their hg mediawiki branch - https://phabricator.wikimedia.org/T1030#2908672 (10Seb35) a:03Seb35 I just contacted him, asking some questions about his past experience of running an hg repository of MediaWiki, and if there are still interested users. If the la... [16:16:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Reference section remains the same size when collapsed (after expanding) - https://phabricator.wikimedia.org/T98318#2908675 (10Aklapper) Shall we assume this problem has magically vanished and decline this task? [16:21:04] 10Graphs: Softer transition for Graph title on :hover? - https://phabricator.wikimedia.org/T154366#2908676 (10Volker_E) [16:25:34] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2908690 (10MarcoAurelio) What a mess :-) * Sysops at ruwiki have patrol and autopatrol permissions. Both are (IIRC) standard in mediawiki core. * wgUseRCPatrol is set to false by default, and there's no override... [16:29:17] 10Phabricator (Upstream), 07Upstream: Improve Phabricator log message - https://phabricator.wikimedia.org/T154367#2908691 (10MarcoAurelio) [16:30:55] 10Phabricator (Upstream), 07Upstream: Phabricator log message misses previous (default) name of Paste after renaming a Paste - https://phabricator.wikimedia.org/T154367#2908706 (10Aklapper) p:05Triage>03Lowest [16:32:02] 10Phabricator (Upstream), 07Upstream: Phabricator log message misses previous (default) name of Paste after renaming a Paste - https://phabricator.wikimedia.org/T154367#2908708 (10MarcoAurelio) Thanks @Aklapper for your fast fixing of the title. I sometimes can't find the words. Happy new year by the way. [16:44:39] 10MediaWiki-extensions-MultiUpload, 03Google-Code-In-2016: Kill off SpecialUpload.1.21.3 - https://phabricator.wikimedia.org/T154363#2908709 (10Reedy) AFAIS, the file just wants deleting, and the conditional "autoloading" wants removing [16:48:51] (03CR) 10Reedy: [C: 04-1] Removed deprecated functions in includes/Title.php (038 comments) [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [16:49:02] (03CR) 10Paladox: "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/324274 (owner: 10L10n-bot) [16:51:27] (03CR) 10Paladox: "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/324274 (owner: 10L10n-bot) [16:52:42] i am new to wikimedia can you please provide me the link for starting my contribution [16:54:56] (03CR) 10Reedy: [C: 04-1] Replace deprecated Article::doEdit() (031 comment) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/329795 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [16:56:38] (03CR) 10Reedy: [C: 032] Replace deprecated Article::doEdit() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/329783 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [16:57:43] (03Merged) 10jenkins-bot: Replace deprecated Article::doEdit() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/329783 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [16:59:21] (03PS2) 10MtDu: Replace deprecated Article::doEdit() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/329795 (https://phabricator.wikimedia.org/T151973) [17:00:19] (03CR) 10Reedy: [C: 04-1] Replace deprecated Article::doEdit() (032 comments) [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:01:12] (03CR) 10Reedy: [C: 032] Replace deprecated Article::doEdit() (031 comment) [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:02:08] (03CR) 10Reedy: [C: 032] Replace deprecated Article::doEdit() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/329795 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:02:10] (03Merged) 10jenkins-bot: Replace deprecated Article::doEdit() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/329786 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:03:02] (03Merged) 10jenkins-bot: Replace deprecated Article::doEdit() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/329795 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:04:24] (03CR) 10Reedy: Add tagging support to imagerotate, revisiondelete, and tag API modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [17:06:06] (03CR) 10Reedy: [C: 04-1] Replaced deprecated "Article::doEdit(" (032 comments) [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/329789 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:07:56] (03PS2) 10Reedy: Removed deprecated "Article::doEdit" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/329790 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:07:59] (03CR) 10Reedy: [C: 032] Removed deprecated "Article::doEdit" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/329790 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:08:02] (03PS2) 10Filip: Replaced deprecated "Article::doEdit" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/329789 (https://phabricator.wikimedia.org/T151973) [17:09:13] (03Merged) 10jenkins-bot: Removed deprecated "Article::doEdit" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/329790 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:09:55] Reedy: Fixed [17:14:54] (03PS3) 10MtDu: Replace deprecated Article::doEdit() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) [17:16:04] (03CR) 10Reedy: [C: 032] Replace deprecated Article::doEdit() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:16:36] (03Merged) 10jenkins-bot: Replace deprecated Article::doEdit() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329788 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [17:20:28] (03CR) 10Reedy: [C: 032] Replaced deprecated "Article::doEdit" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/329789 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:21:21] (03Merged) 10jenkins-bot: Replaced deprecated "Article::doEdit" [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/329789 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:27:41] (03CR) 10Reedy: Remove deprecated usages of ImageGallery (031 comment) [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/329779 (owner: 10Divadsn) [17:30:16] 10MediaWiki-extensions-MultiUpload: Kill off SpecialUpload.1.21.3 - https://phabricator.wikimedia.org/T154363#2908750 (10Reedy) [17:31:19] (03PS1) 10Reedy: Remove old SpecialUpload.1.21.3.php [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329798 (https://phabricator.wikimedia.org/T154363) [17:31:25] (03CR) 10jerkins-bot: [V: 04-1] Remove old SpecialUpload.1.21.3.php [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329798 (https://phabricator.wikimedia.org/T154363) (owner: 10Reedy) [17:34:06] (03PS2) 10Reedy: Remove old SpecialUpload.1.21.3.php [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/329798 (https://phabricator.wikimedia.org/T154363) [17:37:01] (03CR) 10Reedy: "Change itself looks fine... Cutting it a little close with removal... But we are on the 1.29 development cycle, and no usages seen" [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [17:37:06] (03PS3) 10Reedy: Remove WebRequest::checkSessionCookie() method as being deprecated [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [17:37:11] (03CR) 10Reedy: [C: 032] Remove WebRequest::checkSessionCookie() method as being deprecated [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [17:44:26] andre__: Why does $this->getLanguage()->getMessage("key") and $this->msg("key")->text() output different messages when uselang=qqx. I get "wikibase-diffview-link$*" when getLanguage()... is used whereas msg("key")->text() gives "wikibase-diffview-link" [17:44:42] tonythomas: Are you here? [17:44:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Reference section remains the same size when collapsed (after expanding) - https://phabricator.wikimedia.org/T98318#1264622 (10matej_suchanek) Well, those screenshots are not relevant. They show the top section whereas this task is about references. [17:46:08] (03PS4) 10MtDu: Add tagging support to imagerotate, revisiondelete, and tag API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) [17:47:09] (03Merged) 10jenkins-bot: Remove WebRequest::checkSessionCookie() method as being deprecated [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [17:47:15] rlot: it says hes afk. :P [17:48:33] (03Draft1) 10Paladox: Move Page Tools to the left side [skins/Timeless] - 10https://gerrit.wikimedia.org/r/329799 [17:48:35] (03Draft2) 10Paladox: Move Page Tools to the left side [skins/Timeless] - 10https://gerrit.wikimedia.org/r/329799 [17:49:38] subins2000: why would you call $this->getLanguage()->getMessage() in the first place? [17:49:51] normal code shouldn't be calling it [17:50:00] ashley: I'm not the one who did that. It's in WikiBase [17:50:11] * subins2000 Wikibase extension [17:50:39] ah, that would explain a few things, yes...I fully expect that code to a lot of crazy things [17:51:41] So is that the same ? wikibase-diffview-link$* and wikibase-diffview-link [17:55:19] 10MediaWiki-Maintenance-scripts: Create script for moving orphaned revisions to the archive table - https://phabricator.wikimedia.org/T154370#2908774 (10GeoffreyT2000) [17:57:11] (03CR) 10jenkins-bot: Remove WebRequest::checkSessionCookie() method as being deprecated [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) (owner: 10Victorbarbu) [18:02:50] 10MediaWiki-General-or-Unknown, 10Timeless, 10Wikimedia-Site-requests: Add Timeless skin to wmf wiki's - https://phabricator.wikimedia.org/T154371#2908791 (10Paladox) [18:03:09] 10MediaWiki-Maintenance-scripts: Create script for retroactively generating old "delete_redir" log entries - https://phabricator.wikimedia.org/T154372#2908802 (10GeoffreyT2000) [18:08:35] (03PS4) 10Awu42: Removed deprecated function in includes/Title.php [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) [18:08:47] 10MediaWiki-Maintenance-scripts: Create script for converting deletion log entries to "delete_redir" - https://phabricator.wikimedia.org/T154373#2908819 (10GeoffreyT2000) [18:08:47] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated function in includes/Title.php [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [18:15:33] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Gather feedback from GCI mentors after GCI 2016 (around 2017-01-14 to 2017-01-18) - https://phabricator.wikimedia.org/T154374#2908835 (10Aklapper) [18:15:37] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Wikimedia org admins to choose GCI 2016 Grand Prize winners between 2017-01-18 and 2017-01-23 - https://phabricator.wikimedia.org/T154375#2908847 (10Aklapper) [18:16:52] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Wikimedia org admins to choose GCI 2016 Grand Prize winners between 2017-01-18 and 2017-01-23 - https://phabricator.wikimedia.org/T154375#2908847 (10Aklapper) [18:16:54] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Gather feedback from GCI mentors after GCI 2016 (around 2017-01-14 to 2017-01-18) - https://phabricator.wikimedia.org/T154374#2908835 (10Aklapper) [18:16:57] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Organize and coordinate Wikimedia's participation in Google Code-In 2016 - https://phabricator.wikimedia.org/T144273#2908865 (10Aklapper) [18:17:14] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Organize and coordinate Wikimedia's participation in Google Code-In 2016 - https://phabricator.wikimedia.org/T144273#2594465 (10Aklapper) [18:17:28] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Organize and coordinate Wikimedia's participation in Google Code-In 2016 - https://phabricator.wikimedia.org/T144273#2594465 (10Aklapper) p:05Normal>03Low [18:25:46] 10Timeless, 10Wikimedia-Site-requests: Add Timeless skin to wmf wiki's - https://phabricator.wikimedia.org/T154371#2908873 (10Aklapper) (Task is unrelated to the MediaWiki code base, hence removing that tag.) https://www.mediawiki.org/wiki/Skin:Timeless [18:27:17] 06Developer-Relations (Jan-Mar-2017), 10Phabricator (Upstream), 07Upstream: Complete the round of Phabricator improvements funded by Wikimedia - https://phabricator.wikimedia.org/T136213#2908875 (10Aklapper) [18:27:20] 10Timeless, 10Wikimedia-Site-requests, 07Community-consensus-needed: Add Timeless skin to wmf wiki's - https://phabricator.wikimedia.org/T154371#2908877 (10Reedy) [18:30:12] 06Developer-Relations (Jan-Mar-2017), 13Patch-For-Review: Sort out PdfBook extension fork situation: Disable Wikimedia repo; link to GitHub repo - https://phabricator.wikimedia.org/T124978#2908879 (10Aklapper) Postponing one last time; set an arbitrary deadline in https://phabricator.wikimedia.org/T143684 (blo... [18:32:06] 06Developer-Relations (Jan-Mar-2017), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2908883 (10Aklapper) [18:34:03] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Gather feedback from GCI mentors after GCI 2016 (around 2017-01-14 to 2017-01-18) - https://phabricator.wikimedia.org/T154374#2908888 (10Aklapper) p:05Triage>03Low [18:34:08] 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Wikimedia org admins to choose GCI 2016 Grand Prize winners between 2017-01-18 and 2017-01-23 - https://phabricator.wikimedia.org/T154375#2908889 (10Aklapper) p:05Triage>03Low [18:35:21] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Better code review processes for reviewers - https://phabricator.wikimedia.org/T149639#2908890 (10Aklapper) [18:35:24] 06Developer-Relations (Jan-Mar-2017), 10Wikimedia-Developer-Summit (2017): Better recommending of tasks suitable for new technical contributors - https://phabricator.wikimedia.org/T149564#2908892 (10Aklapper) [18:51:37] (03CR) 10Reedy: "I guess RELEASE-NOTES conflicts and as such, needs a rebase" [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [18:52:44] (03CR) 10Reedy: [C: 04-1] Removed deprecated function in includes/Title.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [19:10:11] 06Developer-Relations (Jan-Mar-2017): Actively encourage "best" Google Code-In 2016 students to attend a Hackathon - https://phabricator.wikimedia.org/T154376#2908911 (10Aklapper) [19:11:34] 06Developer-Relations (Jan-Mar-2017): Actively encourage "best" Google Code-In 2016 students to attend a Hackathon - https://phabricator.wikimedia.org/T154376#2908911 (10Aklapper) p:05Triage>03Lowest [19:22:15] (03PS1) 10Awu42: Removed deprecated Title::moveNoAuth function [core] - 10https://gerrit.wikimedia.org/r/329801 (https://phabricator.wikimedia.org/T61113) [19:29:05] (03CR) 10Divadsn: "Anyone can merge this? :)" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [19:46:19] (03Abandoned) 10Fomafix: SpecialMovepage: Add redirect=no for links to redirects [core] - 10https://gerrit.wikimedia.org/r/242269 (owner: 10Gerrit Patch Uploader) [19:58:49] 10MediaWiki-extensions-Quiz, 03Google-Code-In-2016, 07Regression: [REGRESSION] Submit button on a single quiz grades all quizzes on the page - https://phabricator.wikimedia.org/T152398#2908945 (10Aklapper) Imported as https://codein.withgoogle.com/tasks/5113911135174656/ [20:00:40] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Research the usage of NewsletterDeletionUpdate (and probably remove it) - https://phabricator.wikimedia.org/T154341#2908947 (10Pppery) a:03Pppery [20:01:08] 10PerformanceInspector: Make PerformanceInspector show LUA logs - https://phabricator.wikimedia.org/T148616#2908948 (10Aklapper) Looks like noone replies unfortunately (who could also judge if this would be #easy enough) hence removing GCI tag. :( [20:03:08] 10UI-Standardization, 03Google-Code-In-2016, 13Patch-For-Review, 13Patch-Needs-Improvement: Convert Special:Tags to OOUI - https://phabricator.wikimedia.org/T117742#2908962 (10Aklapper) Wondering if @Florian or @Legoktm (once available) could imagine mentoring this in GCI...? [20:03:38] 10MediaWiki-Watchlist, 07Epic: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790#142799 (10Opabinia_regalis) This problem is becoming disruptive on enwiki. It is precipitating a lot of mutual frustration between some bot operators perfor... [20:05:36] 10utfnormal, 07Easy, 03Google-Code-In-2016, 07Technical-Debt: Migrate extensions off core UtfNormal - https://phabricator.wikimedia.org/T153994#2908965 (10Aklapper) [20:09:36] (03CR) 10Divadsn: Remove deprecated usages of ImageGallery (031 comment) [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/329779 (owner: 10Divadsn) [20:09:56] (03PS1) 10Pppery: Remove unnecessary class NewsletterDeletionUpdate [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329804 (https://phabricator.wikimedia.org/T154341) [20:10:59] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Research the usage of NewsletterDeletionUpdate (and probably remove it) - https://phabricator.wikimedia.org/T154341#2908969 (10Pppery) The class is indeed redundant; the functionality it provides it also implemented in Newsletter.h... [20:12:28] (03CR) 10MtDu: [C: 031] "This looks good! Thanks for picking this up. I agree that this should be totally removed, as it's not used anywhere. Let's have @01tonytho" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329804 (https://phabricator.wikimedia.org/T154341) (owner: 10Pppery) [20:15:14] 10The-Wikipedia-Library: Server errors in reviewing applications - https://phabricator.wikimedia.org/T154378#2908970 (10Nikkimaria) [20:18:13] (03CR) 10MtDu: [C: 04-1] "@awu42, I see the new change you have uploaded. When this happens, make sure you abandon your old change so we know that we don't need to " [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) (owner: 10Awu42) [20:20:09] (03CR) 10MtDu: [C: 04-1] "@divadsn," [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [20:22:38] (03CR) 10MZMcBride: "I guess this is better?" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) (owner: 10DatGuy) [20:23:45] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2908984 (10Pppery) [20:30:11] 10Phabricator, 06Developer-Relations (Jan-Mar-2017), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2908997 (10Aklapper) p:05Normal>03Low Quick progress update: * Disabled: H189,H147,H61,H120,H107,H119,H55,H75,H115,H202,H156. * Contacted author of H... [20:51:38] 10MediaWiki-extensions-Newsletter: MWException raised when the ContentModel of a page is changed to NewsletterContent - https://phabricator.wikimedia.org/T154380#2909009 (10Pppery) [20:52:58] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909022 (10Pppery) [20:53:00] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2909021 (10Pppery) [20:53:38] 10MediaWiki-extensions-Newsletter: MWException raised when the ContentModel of a page is changed to NewsletterContent - https://phabricator.wikimedia.org/T154380#2909024 (10Pppery) [20:53:41] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2401078 (10Pppery) [20:56:24] (03CR) 10Paladox: [C: 04-1] AntiSpoof: Simplify word in en and en-gb. (031 comment) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) (owner: 10DatGuy) [20:56:52] (03CR) 10Paladox: [C: 04-1] "recheck" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) (owner: 10DatGuy) [21:14:00] (03PS2) 10DatGuy: Multiple i18n changes [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) [21:19:59] 06MediaWiki-Stakeholders-Group: Draft bylaws for incorporation - https://phabricator.wikimedia.org/T150007#2909029 (10LawExplorer) A second draft of the proposed bylaws is available at https://docs.google.com/document/d/18xh-P9SENXsL_ywhLaGq9XLJRVVQ0fO6aRa1YHVD0HE/edit#. [21:27:56] (03PS3) 10DatGuy: Multiple i18n changes [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) [21:28:29] (03CR) 10Paladox: [C: 031] Multiple i18n changes [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) (owner: 10DatGuy) [21:55:37] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909039 (1001tonythomas) Is it being thrown up as an Exception, or as a fatal error (like white screen with this line) ? [21:58:51] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909041 (10Pppery) An MWException [22:04:20] (03PS1) 10Jack Phoenix: Fix display bug with floats on Special:UserBoxes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329808 [22:06:55] (03CR) 10Jack Phoenix: [C: 032] Fix display bug with floats on Special:UserBoxes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329808 (owner: 10Jack Phoenix) [22:07:23] (03Merged) 10jenkins-bot: Fix display bug with floats on Special:UserBoxes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329808 (owner: 10Jack Phoenix) [22:23:51] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909058 (1001tonythomas) >>! In T154379#2909041, @Pppery wrote: > An MWException; the main background with navigation links and such still appears, and a stack trace... [22:26:12] 10MediaWiki-extensions-Newsletter: MWException raised when the ContentModel of a page is changed to NewsletterContent - https://phabricator.wikimedia.org/T154380#2909059 (1001tonythomas) Well, we cannot fix this (other than maybe showing a better error message, or even stopping the transacation from happening).... [22:32:45] (03CR) 1001tonythomas: [C: 032] "Lets kill it. Looks good :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329804 (https://phabricator.wikimedia.org/T154341) (owner: 10Pppery) [22:33:26] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2909077 (1001tonythomas) [22:33:29] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Research the usage of NewsletterDeletionUpdate (and probably remove it) - https://phabricator.wikimedia.org/T154341#2909075 (1001tonythomas) 05Open>03Resolved Killed with fire :D Thank you! [22:34:10] (03Merged) 10jenkins-bot: Remove unnecessary class NewsletterDeletionUpdate [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329804 (https://phabricator.wikimedia.org/T154341) (owner: 10Pppery) [22:39:16] tonythomas: thanks for the final review! Happy New Year! [22:40:10] MtDu_: heh. ^^ you might like that one https://usercontent.irccloud-cdn.com/file/wpeDfmx9/happyNewYear2017.jpg [22:40:39] Haha probably so. :) [22:40:57] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909079 (10Pppery) Except that it seems to only require Autoconfirmed rights to move a newsletter (?) [22:40:58] MtDu_: :) [22:41:40] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909080 (1001tonythomas) >>! In T154379#2909079, @Pppery wrote: > Except that it seems to only require Autoconfirmed rights to move a newsletter (?) Hmm. That sounds... [22:41:46] Hello from the future:)) [22:42:30] Georggi: roger that. [22:43:37] 10MediaWiki-extensions-Newsletter: MWException raised when the ContentModel of a page is changed to NewsletterContent - https://phabricator.wikimedia.org/T154380#2909081 (10Pppery) I think you are confusing my two tasks here. This one is about content models, and the content model change does not happen after th... [22:45:36] 10MediaWiki-extensions-Newsletter: MWException raised when the ContentModel of a page is changed to NewsletterContent - https://phabricator.wikimedia.org/T154380#2909082 (1001tonythomas) >>! In T154380#2909081, @Pppery wrote: > I think you are confusing my two tasks here. This one is about content models, and th... [22:50:54] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909083 (10Pppery) The ? in the above comment meant "How odd", not "Maybe; unconfirmed"; I had already tested this before saying it. [22:55:39] 10MediaWiki-extensions-Newsletter: Autoconfirmed users can move newsletters - https://phabricator.wikimedia.org/T154383#2909084 (10Pppery) [22:56:35] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909097 (10Pppery) T154383 [22:56:40] (03CR) 10Divadsn: "Well, damn... rebase is coming next year probably :P" [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) (owner: 10Divadsn) [23:00:02] Aaaand Happy New Year most of Europe! Welcome to the future:)) [23:00:35] 10MediaWiki-extensions-Newsletter: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters) - https://phabricator.wikimedia.org/T154384#2909099 (10Pppery) [23:01:03] 10MediaWiki-extensions-Newsletter: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters) - https://phabricator.wikimedia.org/T154384#2909111 (10Pppery) Will I ever stop finding new bugs? [23:13:34] (03Draft1) 10Paladox: Add intro/summery text on top of Special:GlobalRenameUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) [23:13:38] (03Draft2) 10Paladox: Add intro/summery text on top of Special:GlobalRenameUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) [23:13:41] (03Draft3) 10Paladox: Add intro/summery text on top of Special:GlobalRenameUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) [23:16:09] (03CR) 10DatGuy: "Please change globalrenamerequest-pretext to globalrenameuser-pretext. The former was just for testing." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) (owner: 10Paladox) [23:17:33] (03PS4) 10Paladox: Add intro/summery text on top of Special:GlobalRenameUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) [23:17:40] (03CR) 10Paladox: "> Please change globalrenamerequest-pretext to globalrenameuser-pretext." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) (owner: 10Paladox) [23:18:50] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 07Easy, 13Patch-For-Review: Create intro/summary for Special:GlobalRenameUser - https://phabricator.wikimedia.org/T138919#2909146 (10DatGuy) a:03Paladox [23:21:37] 10MediaWiki-extensions-Newsletter: Bizzare behavior when newsletter moved outside Newsletter namespace - https://phabricator.wikimedia.org/T154379#2909147 (1001tonythomas) >>! In T154379#2909083, @Pppery wrote: >>>in T154379#2909079, @Pppery wrote: >>>Except that it seems to only require Autoconfirmed rights to... [23:25:08] (03CR) 10DatGuy: "Instead of directly embedding the template, could you embed MediaWiki:Globalrenameuser-text?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) (owner: 10Paladox) [23:25:10] (03PS3) 10Divadsn: Removed deprecated class ImageGallery [core] - 10https://gerrit.wikimedia.org/r/329773 (https://phabricator.wikimedia.org/T61113) [23:26:28] (03CR) 10Paladox: "> Instead of directly embedding the template, could you embed" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) (owner: 10Paladox) [23:28:34] (03CR) 10DatGuy: [C: 031] "Seems good." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329810 (https://phabricator.wikimedia.org/T138919) (owner: 10Paladox) [23:50:02] 10MediaWiki-extensions-Newsletter: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters) - https://phabricator.wikimedia.org/T154384#2909152 (10Aklapper) >>! In T154384#2909111, @Pppery wrote: > Will I ever stop finding new bugs? In general that's very unlikely. Welcome to t...