[00:00:30] Uh oh. [00:00:35] Let me take a look. [00:09:01] 10MediaWiki-extensions-CollaborationKit: js broken on specialcreatecollaborationhub - https://phabricator.wikimedia.org/T154304#2906828 (10Isarra) [00:13:20] (03PS1) 10Brian Wolff: Use class to set theme for CollaborationHub edit page. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329645 [00:15:34] (03CR) 10Brian Wolff: [C: 032] Use class to set theme for CollaborationHub edit page. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329645 (owner: 10Brian Wolff) [00:16:51] (03Merged) 10jenkins-bot: Use class to set theme for CollaborationHub edit page. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329645 (owner: 10Brian Wolff) [00:20:53] 10MediaWiki-User-preferences: Disable images in signatures - https://phabricator.wikimedia.org/T68006#2906844 (10AlvaroMolina) There are several users (including me) who use an image as part of their signature, I believe that this aspect should not be banned altogether (at least not at the software level). I per... [00:21:49] (03PS3) 10Kaldari: Add database support for subprojects [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/329386 (https://phabricator.wikimedia.org/T154216) [00:28:39] 10MediaWiki-extensions-PageAssessments, 06Community-Tech, 13Patch-For-Review: Add support for task forces to PageAssessments - https://phabricator.wikimedia.org/T154216#2906846 (10kaldari) [00:30:33] 10Wikimedia-SVG-rendering: the language-switcher on SVG file isn't working - https://phabricator.wikimedia.org/T154256#2906848 (10Cwek) >>! In T154256#2905644, @Glrx wrote: > Problem 1 (Language switching at ImagePage.php) is improper handling of URL lang arg on Commons File pages. Selecting a language with mixe... [00:36:51] 10MediaWiki-General-or-Unknown: Formatting of media player broken inside Listen template - https://phabricator.wikimedia.org/T73601#2906852 (10Ethanreese) 05Open>03Resolved a:03Ethanreese Going to the link on wikipedia in the chrome browser on macOS Sierra showed that the alignment error was fixed, and now... [00:45:43] (03PS1) 10UltrasonicNXT: Only show username & avatar once when a user sends multiple messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329648 [00:57:22] (03CR) 10UltrasonicNXT: [C: 032] Only show username & avatar once when a user sends multiple messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329648 (owner: 10UltrasonicNXT) [00:58:22] (03Merged) 10jenkins-bot: Only show username & avatar once when a user sends multiple messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329648 (owner: 10UltrasonicNXT) [00:59:27] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review: If person sends multiple messages in a row, display the username and avatar only once in MediaWikiChat - https://phabricator.wikimedia.org/T146232#2906861 (10UltrasonicNXT) 05Open>03Resolved btw, once this is merged, any feedback/alteration to the graph... [01:17:40] 06Brickimedia: Downtime 0100 30 dec 16 - https://phabricator.wikimedia.org/T154305#2906868 (10UltrasonicNXT) [01:19:21] 06Brickimedia: Downtime 0100 30 dec 16 - https://phabricator.wikimedia.org/T154305#2906879 (10Ajraddatz) Oh yes, that was me trying to reboot. But then I realized that it wasn't a server issue. [01:20:23] 06Brickimedia: Downtime 0100 30 dec 16 - https://phabricator.wikimedia.org/T154305#2906880 (10UltrasonicNXT) ooh, also, I'll need to update and re-enable those extensions I disabled (just putting it here so I remember) [01:36:35] 10MediaWiki-jQuery-Tablesorter: Table class "sortable" incorrectly sorts a column when mixing numbers and non-numbers - https://phabricator.wikimedia.org/T154307#2906895 (10maiden_taiwan) [01:36:54] (03PS3) 10Cen.temp: Refactor maybeMakeEditReviewed to handle all self-reverts, avoid db hits [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329545 (https://phabricator.wikimedia.org/T133442) [01:36:55] (03PS1) 10Cen.temp: Remove reliance on baseRevId and altBaseRevId for FlaggablePageView [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329649 [01:49:58] 06Brickimedia: Downtime 0100 30 dec 16 - https://phabricator.wikimedia.org/T154305#2906910 (10SamanthaNguyen) IRC? You can visit #brickimedia on the Freenode server. [01:50:12] 10MediaWiki-jQuery-Tablesorter: Table class "sortable" incorrectly sorts a column when mixing numbers and non-numbers - https://phabricator.wikimedia.org/T154307#2906895 (10TTO) https://test.wikipedia.org/wiki/T154307 [01:55:48] 06Brickimedia, 10MediaWikiChat: If person sends multiple messages in a row, display the username and avatar only once in MediaWikiChat - https://phabricator.wikimedia.org/T146232#2906914 (10SamanthaNguyen) \o/ [02:06:30] (03PS25) 10MtDu: Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [02:09:15] 10MediaWiki-Vagrant: Make lxc provider work with a Jessie base image - https://phabricator.wikimedia.org/T154294#2906918 (10bd808) The version of LXC that is being installed on our Trusty labs instances (1.0.8-0ubuntu0.4) does not support running containers with systemd init (https://github.com/lxc/lxc/issues/68... [02:11:02] 10MediaWiki-jQuery-Tablesorter: Table class "sortable" incorrectly sorts a column when mixing numbers and non-numbers - https://phabricator.wikimedia.org/T154307#2906919 (10maiden_taiwan) Thank you, TTO! [02:46:52] 10MediaWiki-General-or-Unknown: Provide history UI to undo multiple edits - https://phabricator.wikimedia.org/T154308#2906930 (10Cenarium) [03:03:02] (03PS1) 10Cen.temp: Add wpBaseRevision to edit request from 'undoafter' param [core] - 10https://gerrit.wikimedia.org/r/329651 (https://phabricator.wikimedia.org/T154263) [03:11:49] (03PS1) 10Cen.temp: Use 'wpUndidRevision' instead of 'undidRev', remove the latter [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329652 [03:46:09] @seen Nikerabbit [03:46:09] MtDu: Nikerabbit is in here, right now [03:46:52] (03PS1) 10MtDu: Add tags support to the following API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) [03:50:09] legoktm: Around? [03:52:48] MtDu: not really [03:54:04] legoktm: Busy? Just quick question. Has ArticleFeedback been converted to LinkRenderer? [03:54:10] (03CR) 10jerkins-bot: [V: 04-1] Add tags support to the following API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [03:55:13] legoktm, I had these patches a while back. https://gerrit.wikimedia.org/r/#/c/327140/ and https://gerrit.wikimedia.org/r/#/c/329653/. But I think they've both been converted. Want to make sure before I abandon. [04:02:49] (03PS2) 10MtDu: Add tags support to the following API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) [04:14:30] (03Draft2) 10Yaron Koren: Improved RL loading of timeline JS [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/329655 [04:19:56] (03CR) 10Yaron Koren: [C: 032] Improved RL loading of timeline JS [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/329655 (owner: 10Yaron Koren) [04:24:17] Hello you lovely Wikipedians, I'm planning to develop an open-source argument/discussion webapp. I could imagine it becoming a suitable replacement (/embed) for an article's talk page as well. Hence I'd like to gather feedback/opinion from active users of the talk page. Would that be possible and if so, what'd be the best way to initiate contact? [05:02:50] (03CR) 10TTO: Add tags support to the following API modules (034 comments) [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [05:10:59] Gregor[m]: I'd try to build a prototype and demonstrate it to the en./fa./fr./de. village pumps. [05:11:32] Gregor[m]: village pumps is a "wild and large" relevant place to initiate such contacts to gather use cases [05:13:11] Gregor[m]: if you build your feature on the top of Flow, you also wish to discuss with Flow developers to coordinate, they are located on #wikimedia-collaboration [05:15:56] 10MediaWiki-Special-pages: Scrolling through user groups on Special:ActiveUsers makes list disappear - https://phabricator.wikimedia.org/T154210#2906972 (10GeoffreyT2000) It disappears in Internet Explorer 11. [05:16:54] Dereckson: Great thanks! Didn't know about village pumps nor flow. I'm looking into it now. [05:26:18] (03CR) 10BryanDavis: [C: 04-1] "hhvm doesn't start on reboot due to missing /var/run/hhvm directory." (031 comment) [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [05:52:29] 10MediaWiki-Vagrant: Make lxc provider work with a Jessie base image - https://phabricator.wikimedia.org/T154294#2906980 (10bd808) I've manually hacked up a testing instance in Labs. I upgraded the LXC install using `sudo apt-get -t trusty-backports install lxc lxc-templates`. Unfortunately Puppet's `package` de... [05:52:59] 10MediaWiki-Vagrant, 15User-bd808: Make lxc provider work with a Jessie base image - https://phabricator.wikimedia.org/T154294#2906981 (10bd808) a:03bd808 [06:48:27] (03PS1) 10Amire80: Change the punctuation of apierror-baddiff [core] - 10https://gerrit.wikimedia.org/r/329658 [06:53:21] 10Wikimedia-Site-requests: Merge three different accounts into one - https://phabricator.wikimedia.org/T154290#2906988 (10Tulsi_Bhagat) Ah... I also don't want to corrupt histories and logs. Okay anyways, Thank you :-) [07:01:22] 10MediaWiki-Recent-changes: Tag filter in Special:RecentChanges should have auto-completion - https://phabricator.wikimedia.org/T154310#2906989 (10SamanthaNguyen) [07:05:30] 10MediaWiki-extensions-Translate, 07Regression: the "sortable" URL parameter is reversed in Special:MessageGroupStats - https://phabricator.wikimedia.org/T154311#2907001 (10Amire80) [07:21:43] 10MediaWiki-extensions-Translate, 07Easy, 07Regression: the "sortable" URL parameter is reversed in Special:MessageGroupStats - https://phabricator.wikimedia.org/T154311#2907015 (10Nikerabbit) The sorting code url thing has been unchanged at least since 2013. So either it is not a regression or the regressio... [07:24:03] 10MediaWiki-extensions-Translate, 07Easy, 07Regression: the "sortable" URL parameter is reversed in Special:MessageGroupStats - https://phabricator.wikimedia.org/T154311#2907020 (10Amire80) >>! In T154311#2907015, @Nikerabbit wrote: > The sorting code url thing has been unchanged at least since 2013. So eith... [07:42:38] (03CR) 10Nikerabbit: [C: 032] Change the punctuation of apierror-baddiff [core] - 10https://gerrit.wikimedia.org/r/329658 (owner: 10Amire80) [07:53:12] (03Merged) 10jenkins-bot: Change the punctuation of apierror-baddiff [core] - 10https://gerrit.wikimedia.org/r/329658 (owner: 10Amire80) [07:54:13] 04(no projects): Request for a temporary lift of account creation cap on IPs - https://phabricator.wikimedia.org/T154312#2907031 (10Mahitgar) [07:56:36] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IPs - https://phabricator.wikimedia.org/T154312#2907042 (10Peachey88) [07:57:03] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IPs (2017-01-04) - https://phabricator.wikimedia.org/T154312#2907031 (10Peachey88) [07:57:59] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IPs (2017-01-04,2017-01-06,2017-01-10) - https://phabricator.wikimedia.org/T154312#2907031 (10Peachey88) [08:04:25] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IPs (2017-01-04,2017-01-06,2017-01-10) - https://phabricator.wikimedia.org/T154312#2907045 (10Peachey88) [08:06:14] (03CR) 10jenkins-bot: Change the punctuation of apierror-baddiff [core] - 10https://gerrit.wikimedia.org/r/329658 (owner: 10Amire80) [09:10:56] 04(no projects): Add support for importing labels of existing claims in harvest_template.py - https://phabricator.wikimedia.org/T154313#2907056 (10eranroz) [09:25:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/329660 (owner: 10L10n-bot) [10:07:51] 10MediaWiki-Recent-changes: Tag filter in Special:RecentChanges should have auto-completion - https://phabricator.wikimedia.org/T154310#2907072 (10TTO) [10:07:57] 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 07Easy, 13Patch-For-Review: Add a drop-down list for the tags in Recentchanges and Newpages - https://phabricator.wikimedia.org/T27909#2907075 (10TTO) [10:32:04] 10MediaWiki-Vagrant, 13Patch-For-Review, 15User-bd808: Replace upstart with systemd unit in ::xvfb - https://phabricator.wikimedia.org/T154273#2905935 (10hashar) I have switched xvfb to use our define `base::service_unit` and it thus support both Upstart and Systemd. Will have to look again whether the Trus... [10:33:03] (03CR) 10TTO: [C: 04-1] "This looks like it can be rebased on top of master, which would be very nice to do." (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [10:33:51] (03CR) 10TTO: [C: 04-1] "(I see it already had been rebased on master... I mistakenly thought it depended on an unmerged patch)" [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [10:35:41] 10Phabricator: Author cannot edit their Herald rule anymore if condition includes custom field which has been deactivated in the meantime - https://phabricator.wikimedia.org/T153455#2907078 (10Aklapper) @FaFlo: Can you archive these rules (and re-create them merged into a single rule, if still wanted), or do you... [10:37:48] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IPs (2017-01-04,2017-01-06,2017-01-10) - https://phabricator.wikimedia.org/T154312#2907080 (10Urbanecm) p:05Triage>03Normal [10:38:24] 10MediaWiki-API, 07Tracking: API hookaborted error should be clearer (tracking) - https://phabricator.wikimedia.org/T37331#2907084 (10TTO) [10:38:27] 10MediaWiki-API, 07Tracking: Extension can't pass error information back to user in API call (tracking) - https://phabricator.wikimedia.org/T16261#2907085 (10TTO) [10:38:29] 10MediaWiki-User-blocking: Aborting a block using BlockIp hook shows on the block form - https://phabricator.wikimedia.org/T24922#2907082 (10TTO) 05Open>03Resolved This appears to have been done exactly as the previous commenter suggested. From SpecialBlock.php: ``` lang=php $reason = [ 'hoo... [10:42:09] 10Wikimedia-Site-requests: Activate write API on production wikis - https://phabricator.wikimedia.org/T16210#2907096 (10TTO) [10:42:11] 10MediaWiki-API, 07Tracking: Extension can't pass error information back to user in API call (tracking) - https://phabricator.wikimedia.org/T16261#2907090 (10TTO) 05Open>03Resolved All subtasks of this tracking task are now resolved. There are certainly still improvements to be made in this arena, such as... [10:45:22] 10MediaWiki-Special-pages, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#2907097 (10TTO) Sorry Faidon... I'm adding Ops back per my previous comment. Otherwise this will be stalled forever. [10:46:26] 10MediaWiki-Export-or-Import, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#2907102 (10TTO) [10:59:46] 10MobileFrontend-Feature-requests, 07Mobile: Link to top of page - https://phabricator.wikimedia.org/T154314#2907105 (10Wargo) [11:25:50] (03PS1) 10Umherirrender: Fix $wgMessagesDirs for InterlanguageCentral [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/329667 [11:33:38] 10Wikimedia-General-or-Unknown: Most watchlist emails (enotifwatchlist) don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2907140 (10Tacsipacsi) I regularly (usually every day) go through my on-wiki watchlist, see the edits I haven’t got email about (minor/bot edits) and at the end, I click on “... [11:47:49] (03PS1) 10VictorPorton: Initial version 0.0.1 of PagePopups extension [extensions] - 10https://gerrit.wikimedia.org/r/329668 [11:55:10] 06Brickimedia: Open database dumps access for Brickimedia to other trusted, active system administrators - https://phabricator.wikimedia.org/T142896#2907175 (10UltrasonicNXT) Sure, if the people who want access can give me their email address I can share the folder with them [11:55:46] 10MobileFrontend, 07Mobile: Redirect diff pages to mobile diff on mobile phones - https://phabricator.wikimedia.org/T154227#2907176 (10AlexMonk-WMF) [11:56:08] (03CR) 10TTO: "Hi Victor, and thanks for your contribution. Unfortunately this isn't the right place to store this extension. Each extension has its own " [extensions] - 10https://gerrit.wikimedia.org/r/329668 (owner: 10VictorPorton) [12:00:25] 10Mail, 10Wikimedia-General-or-Unknown: Most watchlist emails (enotifwatchlist) don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2907183 (10Aklapper) [12:00:59] 10MediaWiki-Export-or-Import, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#2907184 (10Nemo_bis) If ops don't answer, I think it's reasonable to proceed by trial and error. The first step would be to... [12:01:38] 10Wikimedia-Site-requests: Request for a temporary lift of account creation cap on IPs (2017-01-04,2017-01-06,2017-01-10) - https://phabricator.wikimedia.org/T154312#2907189 (10Aklapper) Thanks for creating this ticket. @Mahitgar: Please see [[ https://meta.wikimedia.org/wiki/Mass_account_creation#Requesting_tem... [12:05:27] 10Mail, 10Wikimedia-General-or-Unknown: Most watchlist emails (enotifwatchlist) don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2907191 (10Nemo_bis) You could try GMX or one of those: https://www.prxbx.com/email/ (and set up a forward to your other email address too). Of course the test is... [12:10:29] 06Editing-Analysis, 10Wikimedia-General-or-Unknown, 07Chinese-Sites: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2907192 (10Nemo_bis) >>! In T123313#2906329, @Shizhao wrote: > To solve this problem need to start from two... [12:14:35] 10MediaWiki-Special-pages: Scrolling through user groups on Special:ActiveUsers makes list disappear - https://phabricator.wikimedia.org/T154210#2907193 (10Aklapper) @GeoffreyT2000: Which other browsers did you test and what was the result? [12:15:23] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-editing: Provide history UI to undo multiple edits - https://phabricator.wikimedia.org/T154308#2907194 (10Aklapper) p:05Triage>03Low [12:17:59] 04(no projects): collapsible keeps switching/moving - https://phabricator.wikimedia.org/T154301#2907198 (10Aklapper) [12:18:08] 04(no projects): collapsible keeps switching/moving - https://phabricator.wikimedia.org/T154301#2906741 (10Aklapper) Hi @1u, thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system as T71729, but please feel free to report any further issues you... [12:18:35] 10Wikimedia-SVG-rendering: the language-switcher on SVG file isn't working - https://phabricator.wikimedia.org/T154256#2907206 (10Aklapper) [12:18:37] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2907209 (10Aklapper) [12:27:13] 10Wikimedia-General-or-Unknown: Problem with JavaScript cache invalidation? On svwp, gadgets stay active after disabling; JS changes not applied - https://phabricator.wikimedia.org/T154298#2907212 (10Aklapper) [12:39:49] (03PS1) 10UltrasonicNXT: Fix bug with the columns getting out of alignment [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329670 [12:43:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Browser-Support-Apple-Safari: "TypeError: undefined is not an object (evaluating 'mw.util.addPortletLink')" while opening item in new tab (on background) in Safari - https://phabricator.wikimedia.org/T146069#2649608 (10abian) I think that I experience... [12:46:06] (03CR) 10UltrasonicNXT: [C: 032] Fix bug with the columns getting out of alignment [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329670 (owner: 10UltrasonicNXT) [12:47:13] (03Merged) 10jenkins-bot: Fix bug with the columns getting out of alignment [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329670 (owner: 10UltrasonicNXT) [12:50:54] 10MediaWiki-HTMLForm, 10OOjs-UI: The star marking required field overlaps with scrollbar in OOJS ui - https://phabricator.wikimedia.org/T154318#2907216 (10Nikerabbit) [12:50:58] (03PS1) 10Umherirrender: Fix $wgMessagesDirs for OmegaWiki [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/329671 [12:51:15] (03CR) 10jerkins-bot: [V: 04-1] Fix $wgMessagesDirs for OmegaWiki [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/329671 (owner: 10Umherirrender) [12:56:37] (03CR) 10Umherirrender: "lint failure unrelated, there is a problem with a folder contains spaces, which seems to split the command line argument and treated as tw" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/329671 (owner: 10Umherirrender) [13:05:48] 10MediaWiki-jQuery-Tablesorter: Table class "sortable" incorrectly sorts a column when mixing numbers and non-numbers - https://phabricator.wikimedia.org/T154307#2906895 (10TheDJ) Yeah, anything that isn't valid gets value 0. I've been meaning to change that to -Infinity. Lemme submit that real quick... [13:09:31] 10MediaWiki-jQuery-Tablesorter: Table class "sortable" incorrectly sorts a column when mixing numbers and non-numbers - https://phabricator.wikimedia.org/T154307#2907237 (10TheDJ) Also, whenever you use sortable, you should really just tell it what datatype you expect in the column, using "data-sort-type". That... [13:12:59] (03PS1) 10Umherirrender: Remove duplicate manifest_version from UserManager/extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329672 [13:13:35] (03PS1) 10TheDJ: jquery.tablersorter: Sort invalid elements as -Infinity [core] - 10https://gerrit.wikimedia.org/r/329673 (https://phabricator.wikimedia.org/T154307) [13:16:50] 10MediaWiki-jQuery-Tablesorter, 13Patch-For-Review: Table class "sortable" incorrectly sorts a column when mixing numbers and non-numbers - https://phabricator.wikimedia.org/T154307#2907262 (10TheDJ) p:05Triage>03Lowest [13:19:07] (03PS2) 10TheDJ: jquery.tablesorter: Sort invalid elements as -Infinity [core] - 10https://gerrit.wikimedia.org/r/329673 (https://phabricator.wikimedia.org/T154307) [13:19:36] 10Wikimedia-General-or-Unknown: Problem with JavaScript cache invalidation? On svwp, gadgets stay active after disabling; JS changes not applied - https://phabricator.wikimedia.org/T154298#2907264 (10Nirmos) Ok, I've done a lot more digging now and I actually have found a real bug (I will create another task soo... [13:20:18] 10Wikimedia-General-or-Unknown: On svwp, gadgets stay active after disabling; JS changes not applied - https://phabricator.wikimedia.org/T154298#2907267 (10Nirmos) [13:21:51] (03PS3) 10MtDu: Add tagging support to imagerotate, revisiondelete, and tag API modules [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) [13:23:37] 10MediaWiki-Language-converter, 07Chinese-Sites, 07I18n, 07SEO: Canonical URL should include language variant - https://phabricator.wikimedia.org/T54429#2907282 (10Liuxinyu970226) [13:23:54] 10MediaWiki-Interface, 13Patch-For-Review: Canonical links may be in fallback encoding - https://phabricator.wikimedia.org/T71026#719827 (10Liuxinyu970226) [13:26:10] (03CR) 10Mglaser: [C: 032] Remove duplicate manifest_version from UserManager/extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329672 (owner: 10Umherirrender) [13:30:29] (03PS2) 10Umherirrender: Remove duplicate manifest_version from UserManager/extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329672 [13:30:48] (03CR) 10Umherirrender: "Rebased to remove the unneeded parent" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329672 (owner: 10Umherirrender) [13:33:33] 04(no projects): rcnamespace=* does not include negative namespaces - https://phabricator.wikimedia.org/T154319#2907291 (10Nirmos) [13:34:48] 10Wikimedia-General-or-Unknown: On svwp, gadgets stay active after disabling; JS changes not applied - https://phabricator.wikimedia.org/T154298#2907303 (10Nirmos) I have created T154319 about the issue that I misdiagnosed. [13:36:27] 04(no projects): rcnamespace=* does not include negative namespaces - https://phabricator.wikimedia.org/T154319#2907291 (10Nirmos) [13:38:00] (03PS1) 10UltrasonicNXT: MediaWiki:Smileys syntax [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329674 [13:38:06] (03CR) 10jerkins-bot: [V: 04-1] MediaWiki:Smileys syntax [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329674 (owner: 10UltrasonicNXT) [13:40:47] (03PS1) 10Umherirrender: Add LinkedWikiConfig to MessagesDirs [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/329675 [13:41:38] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review: AkismetKlik cleanup - https://phabricator.wikimedia.org/T154107#2907309 (10FilipGCI) @Reedy: @Georggi1999 Hmm, should we keep backward compatibility? Now, AkismentKlik supports 1.19+ so we shouldn't remove this AkismentKlik... [13:41:42] Reedy: Are you here? [13:41:45] (03CR) 10Umherirrender: "Fixes for jenkins with I54f6e22c4627364e4a8d7ea5a8952ab2f00c0631" [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/329675 (owner: 10Umherirrender) [13:41:52] Reedy: Will there be new tasks? [13:41:54] (03CR) 10jerkins-bot: [V: 04-1] Add LinkedWikiConfig to MessagesDirs [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/329675 (owner: 10Umherirrender) [13:42:09] (03PS2) 10Umherirrender: Add LinkedWikiConfig to MessagesDirs [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/329675 [13:42:13] (03PS2) 10UltrasonicNXT: MediaWiki:Smileys syntax [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329674 [13:43:48] 10MediaWiki-API: rcnamespace=* does not include negative namespaces - https://phabricator.wikimedia.org/T154319#2907314 (10Aklapper) [13:44:19] (03CR) 10UltrasonicNXT: [C: 032] MediaWiki:Smileys syntax [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329674 (owner: 10UltrasonicNXT) [13:45:18] (03Merged) 10jenkins-bot: MediaWiki:Smileys syntax [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329674 (owner: 10UltrasonicNXT) [13:45:40] 10Wikimedia-General-or-Unknown: On svwp, gadgets stay active after disabling - https://phabricator.wikimedia.org/T154298#2907317 (10Nirmos) [13:47:10] 06Parsing-Team, 06Community-Liaisons (Oct-Dec-2016): Support the Parsing team with the "Remove Tidy dependency from MediaWiki output" goal - https://phabricator.wikimedia.org/T145530#2907318 (10Elitre) 05Open>03Resolved Work for this quarter is done, as the FAQ page is marked for translation. We'll work mo... [13:52:09] 06Parsing-Team, 06Community-Liaisons (Jan-Mar 2017): Support the Parsing team with update to image markup output/update CSS for Cite - https://phabricator.wikimedia.org/T154320#2907321 (10Elitre) [13:56:23] 06Community-Liaisons (Jan-Mar 2017): Phases 4, 5 in building the visual editor taskforce - https://phabricator.wikimedia.org/T147174#2907335 (10Elitre) [14:05:13] (03PS1) 10Umherirrender: Add installer to MessagesDirs [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/329676 [14:06:47] 10MediaWiki-Database, 07NewPHP, 07Technical-Debt: Remove old mysql extension support in favor of mysqli - https://phabricator.wikimedia.org/T120333#2907337 (10Seb35) a:03Seb35 Ok, I try to follow the process in the soon-official RfC Deprcation policy T146965. First, as stated by my comment above, only a v... [14:07:07] 10MediaWiki-Database, 07NewPHP, 07Technical-Debt: Remove old mysql extension support in favor of mysqli - https://phabricator.wikimedia.org/T120333#2907341 (10Seb35) p:05Triage>03Normal [14:10:18] (03PS2) 10WMDE-Fisch: Get conflict results from diff3 [core] - 10https://gerrit.wikimedia.org/r/329610 (https://phabricator.wikimedia.org/T151320) [14:12:36] 10MediaWiki-History-or-Diffs, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 13Patch-For-Review, 03WMDE-QWERTY-Team-Board: Mark conflicting lines - https://phabricator.wikimedia.org/T151320#2907346 (10Nemo_bis) [14:13:02] (03CR) 10TTO: [C: 031] "I'll let Anomie have the final say here." [core] - 10https://gerrit.wikimedia.org/r/329653 (https://phabricator.wikimedia.org/T97720) (owner: 10MtDu) [14:14:44] (03PS1) 10Umherirrender: Removed unneeded apihelp messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329677 [14:15:08] (03PS2) 10Umherirrender: Removed unneeded apihelp messages [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329677 [14:15:09] 04(no projects): Figure out how to deal with the "Internal Roles, Responsibilities and Interactions" problem between CLs and PMs - https://phabricator.wikimedia.org/T154321#2907347 (10Elitre) [14:15:11] (03CR) 10WMDE-Fisch: "Thanks for the review. Creating a service for this is probably a good idea. Will think about it depending on my next steps here." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329610 (https://phabricator.wikimedia.org/T151320) (owner: 10WMDE-Fisch) [14:15:28] 06Community-Liaisons (Jan-Mar 2017), 06Developer-Relations (Jan-Mar-2017): Technical Collaboration quarterly check in for January – March 2017 - https://phabricator.wikimedia.org/T150658#2907360 (10Elitre) [14:16:05] 06Community-Liaisons (Jan-Mar 2017), 06Developer-Relations (Jan-Mar-2017): Technical Collaboration quarterly check in for January – March 2017 - https://phabricator.wikimedia.org/T150658#2792447 (10Elitre) I left out something else I want to do because I don't think private tasks are welcome. [14:21:50] (03PS1) 10Umherirrender: Add empty @metadata to i18n file [extensions/Memento] - 10https://gerrit.wikimedia.org/r/329678 [14:23:50] 10MediaWiki-API, 10MediaWiki-Change-tagging, 05MW-1.27-release-notes, 13Patch-For-Review: Add a tags parameter to API modules creating a logentry - https://phabricator.wikimedia.org/T97720#2907365 (10MtDu) [14:25:54] 10MediaWiki-API: rcnamespace=* does not include negative namespaces - https://phabricator.wikimedia.org/T154319#2907291 (10Anomie) Other modules probably have the same issue. In a quick search, * ApiQueryLogEvents * ApiQueryLinks – we don't currently record wikilinks to Special pages (see T19597) but it wouldn't... [14:28:54] 10MediaWiki-extensions-OATHAuth, 06Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10iOS-app-feature-Login, and 2 others: Update login interface to support 2FA and password reset - https://phabricator.wikimedia.org/T150985#2803668 (10Kaartic) I just wanted to make a little suggestion. I saw that the //[[ https:... [14:33:18] (03CR) 10Luke081515: "recheck" [core] - 10https://gerrit.wikimedia.org/r/329651 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [14:33:42] (03CR) 10TTO: "@Anomie I think this might have dropped off your radar. Any chance you could give this another look over?" [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [14:35:38] tonythomas: Are you here? What do you think about this? https://phabricator.wikimedia.org/T153911 [14:37:10] 10MediaWiki-Export-or-Import, 06Operations, 10Wikimedia-General-or-Unknown: Special:Import error: "Import failed: Could not open import file" - https://phabricator.wikimedia.org/T17000#191958 (10Joe) >>! In T17000#2907184, @Nemo_bis wrote: > If ops don't answer, I think it's reasonable to proceed by trial an... [14:37:24] 10MediaWiki-extensions-Newsletter: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907377 (10FilipGCI) [14:38:33] 10MediaWiki-extensions-Newsletter: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2894644 (10FilipGCI) [14:40:00] tonythomas: Btw, when this be imported? https://phabricator.wikimedia.org/T154230 [14:49:15] rlot: hey! let me take a look [14:49:46] https://phabricator.wikimedia.org/T153911 -- If you have a solution, you can comment it over there so that we can think about it and make it/do not make it a GCI task [14:50:29] tonythomas: I'm talking about https://phabricator.wikimedia.org/T153911 [14:50:55] (03CR) 10Cen.temp: "Yeah, I think we can do without tag appearance, as Echo does, https://github.com/wikimedia/mediawiki-extensions-Echo/blob/c7bd07fc0c53c521" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [14:51:22] hmm. I am not sure saving a history like that looks like a good enough approach :-( [14:51:42] rlot: I can try importing https://phabricator.wikimedia.org/T154230 straightaway [14:52:50] tonythomas: Yes, looks like good task [14:53:03] Could be make bulk with all of these doc mismatch [14:59:40] 10MediaWiki-HTMLForm, 10OOjs-UI: The star marking required field overlaps with scrollbar in OOJS ui - https://phabricator.wikimedia.org/T154318#2907216 (10matmarex) Please provide steps to reproduce. This does not occur for me. [15:01:26] (03PS1) 10Fomafix: Add ->text() to prevent double HTML escaping [core] - 10https://gerrit.wikimedia.org/r/329679 [15:04:03] (03CR) 10Bartosz Dziewoński: [C: 032] Add ->text() to prevent double HTML escaping [core] - 10https://gerrit.wikimedia.org/r/329679 (owner: 10Fomafix) [15:09:06] (03PS1) 10Filip: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) [15:09:16] 10MediaWiki-Database, 07NewPHP, 07Technical-Debt: Remove old mysql extension support in favor of mysqli - https://phabricator.wikimedia.org/T120333#2907391 (10Seb35) I also researched `DatabaseMysql` (the class name which will be removed) and `mysql_` (the functions of the PHP extension mysql). **Class Data... [15:09:17] (03PS1) 10UltrasonicNXT: Tidy up parsing mechanism a bit [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329681 [15:09:36] tonythomas: Made https://gerrit.wikimedia.org/r/329680 (Its not for GCI) [15:10:04] 10Phabricator: Merging a task notifies other subscribers twice - https://phabricator.wikimedia.org/T154322#2907392 (10Kaartic) [15:11:17] (03CR) 10UltrasonicNXT: [C: 032] Tidy up parsing mechanism a bit [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329681 (owner: 10UltrasonicNXT) [15:12:15] (03CR) 1001tonythomas: [C: 04-1] "minor nit" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) (owner: 10Filip) [15:12:29] rlot: If you wait for couple of minutes, I can try get that imported to GCI asap [15:14:49] tonythomas: You don't need [15:14:52] (03Merged) 10jenkins-bot: Add ->text() to prevent double HTML escaping [core] - 10https://gerrit.wikimedia.org/r/329679 (owner: 10Fomafix) [15:14:54] (03Merged) 10jenkins-bot: Tidy up parsing mechanism a bit [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329681 (owner: 10UltrasonicNXT) [15:15:44] rlot: well. When you deserve GCI credits, you should ask for it and get it! [15:15:44] (03PS1) 10Seb35: Soft deprecation of DatabaseMysql [core] - 10https://gerrit.wikimedia.org/r/329682 (https://phabricator.wikimedia.org/T120333) [15:15:57] as this competition is going on, and we are happy to give it! [15:17:03] (03PS2) 10Filip: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) [15:17:12] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2894644 (1001tonythomas) Impoted Newsletter cleanup 1/2 [NewsletterEditPage, NewsletterStore] as https://codein.withgoogle.com/dashboard/tasks/5454349838843904/ waiting for admins to approve! [15:17:36] FlorianSW_: hey! you around ? [15:21:07] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed - https://phabricator.wikimedia.org/T154230#2904697 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5442425130582016/ [15:23:09] (03CR) 10jerkins-bot: [V: 04-1] Soft deprecation of DatabaseMysql [core] - 10https://gerrit.wikimedia.org/r/329682 (https://phabricator.wikimedia.org/T120333) (owner: 10Seb35) [15:26:59] (03PS1) 10Umherirrender: Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329684 [15:27:12] (03PS2) 10Umherirrender: Fix descriptionmsg of PermissionManager in extension.json [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329684 [15:27:16] (03CR) 10jenkins-bot: Add ->text() to prevent double HTML escaping [core] - 10https://gerrit.wikimedia.org/r/329679 (owner: 10Fomafix) [15:27:22] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Rename user Candlewicke to CLWE - https://phabricator.wikimedia.org/T154323#2907412 (10K6ka) [15:27:49] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Rename user SSTflyer to Feminist - https://phabricator.wikimedia.org/T154262#2907424 (10K6ka) [15:30:08] tonythomas: hey, what's up? [15:30:50] FlorianSW_: Great. I hope you are one of the GCI admins :D Got couple of tasks to be pushed live! [15:31:18] FlorianSW_: https://codein.withgoogle.com/dashboard/tasks/5454349838843904/ and https://codein.withgoogle.com/dashboard/tasks/5442425130582016/ [15:32:25] tonythomas: yeah, I'll take a look! :) [15:33:04] FlorianSW_: danke. I hope andre would take few more hours to be back as he was here in Berlin yesterday night all the way till 4:00 in the morning :D [15:33:28] hehe, probably he's still sleeping now :P [15:33:32] I published both :) [15:34:50] FlorianSW_: Thank you! probably! [15:36:27] (03CR) 10Florianschmidtwelzow: [C: 032] Use NS_* constants instead of hardcoding [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329201 (owner: 10Legoktm) [15:36:52] (03CR) 10Florianschmidtwelzow: [C: 032] Make SpecialPage::getLinkRenderer() public [core] - 10https://gerrit.wikimedia.org/r/329025 (owner: 10Legoktm) [15:38:37] tonythomas: Should convert UserArray to Array of users? [15:40:34] tonythomas: Loop throught ids, and create array? [15:43:34] (03CR) 10Florianschmidtwelzow: [C: 04-1] Use OOUI for Special:UserRights (031 comment) [core] - 10https://gerrit.wikimedia.org/r/225536 (https://phabricator.wikimedia.org/T117884) (owner: 10Florianschmidtwelzow) [15:45:18] (03PS1) 10UltrasonicNXT: Fix bug when starting a message like ":) hi" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329685 [15:46:20] (03Merged) 10jenkins-bot: Use NS_* constants instead of hardcoding [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329201 (owner: 10Legoktm) [15:46:30] (03PS2) 10UltrasonicNXT: Fix bug when starting a message like ":) hi" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329685 [15:46:56] (03CR) 10Florianschmidtwelzow: "Sorry for the late reply! :]" (033 comments) [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/319911 (https://phabricator.wikimedia.org/T150053) (owner: 10Florianschmidtwelzow) [15:47:33] (03PS2) 10Seb35: Soft deprecation of DatabaseMysql [core] - 10https://gerrit.wikimedia.org/r/329682 (https://phabricator.wikimedia.org/T120333) [15:47:41] (03Merged) 10jenkins-bot: Make SpecialPage::getLinkRenderer() public [core] - 10https://gerrit.wikimedia.org/r/329025 (owner: 10Legoktm) [15:47:55] (03CR) 10UltrasonicNXT: [C: 032] Fix bug when starting a message like ":) hi" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329685 (owner: 10UltrasonicNXT) [15:49:52] (03PS3) 10Seb35: Soft deprecation of DatabaseMysql [core] - 10https://gerrit.wikimedia.org/r/329682 (https://phabricator.wikimedia.org/T120333) [15:49:58] (03Merged) 10jenkins-bot: Fix bug when starting a message like ":) hi" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329685 (owner: 10UltrasonicNXT) [15:50:21] 10MediaWiki-API: ApiLogin returns failure on re-login by same user - https://phabricator.wikimedia.org/T154324#2907429 (10RobinHood70) [15:53:49] (03PS2) 10Florianschmidtwelzow: Add a possibility to add a "cite this page" link without adding the NS as a content namespace [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/319911 (https://phabricator.wikimedia.org/T150053) [15:55:10] tonytomas: Around? [15:55:18] (03PS3) 10Florianschmidtwelzow: Add a possibility to add a "cite this page" link without adding the NS as a content namespace [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/319911 (https://phabricator.wikimedia.org/T150053) [15:55:44] (03CR) 10jenkins-bot: Use NS_* constants instead of hardcoding [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329201 (owner: 10Legoktm) [15:55:52] tonythomas: Are you here? [15:56:25] (03PS3) 10Filip: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) [15:57:13] (03Abandoned) 10Florianschmidtwelzow: WIP: registration: Add possibility to set CONTENT_MODEL_ and CONTENT_FORMAT_ constants [core] - 10https://gerrit.wikimedia.org/r/325120 (https://phabricator.wikimedia.org/T108285) (owner: 10Florianschmidtwelzow) [15:57:53] (03PS4) 10Filip: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) [15:58:25] rlot: back! whats up ? [15:58:31] tonythomas ^^ [15:58:35] ? [15:58:45] tonythomas: Made patchset for this [15:58:55] GCI task [15:59:02] tonythomas: "EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed (Wikimedia)" [15:59:08] (03CR) 10jenkins-bot: Make SpecialPage::getLinkRenderer() public [core] - 10https://gerrit.wikimedia.org/r/329025 (owner: 10Legoktm) [15:59:56] 10Wikimedia-Site-requests, 07I18n, 07Upstream: Kurdish Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T48235#2907443 (10Ghybu) @kaldari: A new request was made with additional information: http://unicode.org/cldr/trac/ticket/9964 [16:00:17] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2907444 (10UltrasonicNXT) a:03UltrasonicNXT Having just implemented that, I actually think that ``` * >:-/ >:/ >:( >:-( >:O... [16:00:18] rlot: why are you using return iterator_to_array there ? [16:00:31] tonythomas: UserArray is iterator [16:00:34] should return array [16:00:53] rlot: " should return array" why ? [16:00:58] 10MediaWiki-Parser: Problem with templates returning an initial asterisk inside an #if - https://phabricator.wikimedia.org/T153848#2907446 (10Umherirrender) I did not know about a parser change in this area or for this wikitext. In my opinion this is happen since years. One possible things changed is that HTML... [16:01:17] ragesoss: Omg, return type not return [16:01:28] tonythomas: Sorry [16:01:42] tonythomas: Should fix docs? [16:01:48] :D the bug is to just fixd the docs, yes. [16:01:52] and maybe separate commits, pelase [16:01:57] (03PS3) 10Florianschmidtwelzow: PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [16:02:00] Ok, i'll do it [16:02:14] and the commit message explaining what exactly you fixed, rather than ' This commit does some Newsletter cleanup' [16:02:19] :D [16:02:55] (03PS5) 10Filip: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) [16:03:15] 10MediaWiki-API: ApiLogin returns failure on re-login by same user - https://phabricator.wikimedia.org/T154324#2907429 (10Anomie) Is there a reason you need to do this? [16:03:43] tonythomas: tonythomas: In this patchset "https://gerrit.wikimedia.org/r/#/c/329680/" message is ok? [16:06:23] (03PS3) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [16:06:30] (03PS1) 10Filip: Updated docs in EchoNewsletterUserLocator [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329686 (https://phabricator.wikimedia.org/T154230) [16:06:40] tonythomas: Ok, here is it [16:09:31] (03PS1) 10UltrasonicNXT: Newer smiley registration method [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329687 [16:09:37] (03CR) 10jerkins-bot: [V: 04-1] PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [16:12:06] tonythomas: https://gerrit.wikimedia.org/r/#/c/329686/ [16:13:08] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907457 (10Florian) [16:13:21] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2894644 (10Florian) ANd published! :D [16:13:22] (03CR) 10UltrasonicNXT: [C: 032] Newer smiley registration method [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329687 (owner: 10UltrasonicNXT) [16:13:42] (03CR) 10jerkins-bot: [V: 04-1] PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 (owner: 10Florianschmidtwelzow) [16:14:26] (03Merged) 10jenkins-bot: Newer smiley registration method [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329687 (owner: 10UltrasonicNXT) [16:14:41] (03PS1) 10Nemo bis: Add reciprocal language fallback for nn and nb (Norwegian) [core] - 10https://gerrit.wikimedia.org/r/329688 [16:17:00] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed - https://phabricator.wikimedia.org/T154230#2907464 (10FilipGCI) a:03FilipGCI [16:17:24] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2907465 (10UltrasonicNXT) ahh typed in the wrong bug number, new commit is here https://gerrit.wikimedia.org/r/#/c/329687/ [16:17:48] (03CR) 10UltrasonicNXT: "Oops wrong commit message, should be T146561" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329687 (owner: 10UltrasonicNXT) [16:20:53] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2905071 (10Stryn) I've got this error since October or November, and last time some minutes ago at https://meta.wikimedia.org/w/index.php?title=Tech&diff=prev&oldid=16194... [16:23:04] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review: AkismetKlik cleanup - https://phabricator.wikimedia.org/T154107#2907468 (10Reedy) Most extension master versions don't need to support all MW versions; that's why we branch extensions when we branch MW core, to try and keep... [16:23:59] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2907483 (10UltrasonicNXT) 05Open>03Resolved done and working [16:24:22] (03PS4) 10Florianschmidtwelzow: PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [16:24:28] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [16:24:28] @notify tonythomas [16:28:29] (03CR) 10Reedy: "I really don't see any point keeping support in master. The extension isn't actively developed, so there's not going to be any feature ben" [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [16:29:44] 10MediaWiki-Interface: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907486 (10MaxBioHazard) [16:31:13] (03PS5) 10Florianschmidtwelzow: PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [16:31:31] (03PS1) 10Ottomata: Specify charset in Content-Type header [services/eventstreams] - 10https://gerrit.wikimedia.org/r/329689 [16:31:33] (03PS4) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [16:34:49] (03Abandoned) 10Ottomata: Specify charset in Content-Type header [services/eventstreams] - 10https://gerrit.wikimedia.org/r/329689 (owner: 10Ottomata) [16:35:14] 10MediaWiki-API: ApiLogin returns failure on re-login by same user - https://phabricator.wikimedia.org/T154324#2907515 (10RobinHood70) Now that I've understood what's going on, and adjusted my bot to compensate, no, but it was an unexpected point of failure, and the error message was uniquely unhelpful in figuri... [16:37:21] (03CR) 10jerkins-bot: [V: 04-1] PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 (owner: 10Florianschmidtwelzow) [16:38:45] tonythomas: Are you there? [16:53:02] (03PS1) 10Daniel Kinzler: Introduce HookRunner [core] - 10https://gerrit.wikimedia.org/r/329691 [16:59:06] 10MediaWiki-Vagrant, 13Patch-For-Review, 15User-bd808: Replace upstart with systemd unit in ::xvfb - https://phabricator.wikimedia.org/T154273#2907538 (10bd808) >>! In T154273#2907076, @hashar wrote: > I have switched xvfb to use our define `base::service_unit` and it thus support both Upstart and Systemd.... [16:59:58] (03CR) 10jerkins-bot: [V: 04-1] Introduce HookRunner [core] - 10https://gerrit.wikimedia.org/r/329691 (owner: 10Daniel Kinzler) [17:00:48] (03PS5) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [17:01:16] (03PS1) 10Awu42: Replaced &$this with $this [core] - 10https://gerrit.wikimedia.org/r/329692 (https://phabricator.wikimedia.org/T153505) [17:02:59] (03PS6) 10Florianschmidtwelzow: PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [17:03:04] (03PS6) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [17:04:41] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed - https://phabricator.wikimedia.org/T154230#2907541 (10FilipGCI) @01tonythomas Updated docs. [17:06:54] (03PS1) 10UltrasonicNXT: Some cleanup to the parser [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329693 [17:08:56] (03CR) 10UltrasonicNXT: [C: 032] Some cleanup to the parser [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329693 (owner: 10UltrasonicNXT) [17:09:02] (03PS2) 10Florianschmidtwelzow: [DO NOT MERGE] Example usage of ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327314 [17:09:05] (03CR) 10jerkins-bot: [V: 04-1] PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [17:09:25] (03CR) 1001tonythomas: [C: 04-1] Updated docs in EchoNewsletterUserLocator (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329686 (https://phabricator.wikimedia.org/T154230) (owner: 10Filip) [17:09:58] (03Merged) 10jenkins-bot: Some cleanup to the parser [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329693 (owner: 10UltrasonicNXT) [17:10:02] (03CR) 10Florianschmidtwelzow: [C: 032] Replaced &$this with $this [core] - 10https://gerrit.wikimedia.org/r/329692 (https://phabricator.wikimedia.org/T153505) (owner: 10Awu42) [17:10:08] tonythomas: Oh, looked at wrong MW version [17:10:43] (03PS2) 10Filip: Updated docs in EchoNewsletterUserLocator [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329686 (https://phabricator.wikimedia.org/T154230) [17:10:48] tonythomas: Fixed [17:11:11] (03CR) 10jerkins-bot: [V: 04-1] PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 (owner: 10Florianschmidtwelzow) [17:12:31] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed - https://phabricator.wikimedia.org/T154230#2907542 (10FilipGCI) @01tonythomas Oh. looked at wrong MW docs. Fixed! [17:16:49] (03CR) 10jerkins-bot: [V: 04-1] [DO NOT MERGE] Example usage of ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327314 (owner: 10Florianschmidtwelzow) [17:19:05] 10MediaWiki-extensions-FlaggedRevs, 07Easy, 03Google-Code-In-2016: FlaggedRevs uses deprecated attribute "width" on diff pages - https://phabricator.wikimedia.org/T42211#2907546 (10Aklapper) Imported as https://codein.withgoogle.com/tasks/6310064090513408/ [17:19:49] (03Merged) 10jenkins-bot: Replaced &$this with $this [core] - 10https://gerrit.wikimedia.org/r/329692 (https://phabricator.wikimedia.org/T153505) (owner: 10Awu42) [17:24:16] (03CR) 10Florianschmidtwelzow: Display Parsoid version on Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [17:28:33] (03CR) 10Robert Vogel: added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [17:28:40] (03CR) 10Robert Vogel: [C: 032] added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [17:30:53] (03CR) 10jenkins-bot: Replaced &$this with $this [core] - 10https://gerrit.wikimedia.org/r/329692 (https://phabricator.wikimedia.org/T153505) (owner: 10Awu42) [17:34:55] (03CR) 10UltrasonicNXT: [C: 031] "Code wise, it looks great, this code was old and bad before, this is much better" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/275198 (https://phabricator.wikimedia.org/T100024) (owner: 10Jack Phoenix) [17:35:11] (03PS1) 10Paladox: Modify access rules [extensions/BlueSpiceFoundation] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329694 [17:36:48] (03CR) 10Robert Vogel: [C: 032] Modify access rules [extensions/BlueSpiceFoundation] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329694 (owner: 10Paladox) [17:37:08] 06Brickimedia, 10MediaWikiChat: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2907551 (10SamanthaNguyen) [17:37:16] (03CR) 10Robert Vogel: [V: 032 C: 032] Modify access rules [extensions/BlueSpiceFoundation] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329694 (owner: 10Paladox) [17:37:37] (03CR) 10Paladox: "@Robert Vogel need to press the submit button please." [extensions/BlueSpiceFoundation] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329694 (owner: 10Paladox) [17:38:08] (03CR) 10Paladox: "thanks." [extensions/BlueSpiceFoundation] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329694 (owner: 10Paladox) [17:42:29] (03PS1) 10Paladox: Modify access rules [extensions/BlueSpiceExtensions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329695 [17:47:17] 10MediaWiki-Vagrant, 06Analytics-Kanban: Enable 'analytics_cluster' role on Labs instance - https://phabricator.wikimedia.org/T151861#2907558 (10mschwarzer) Thanks! Can you recommend any Oozie starting point? Is there already a workflow that uses Wikipedia XML dumps? Or one that writes to ES? [17:50:37] (03PS1) 10Umherirrender: Remove non-exist descriptionmsg key [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/329696 [17:59:51] (03CR) 10Paladox: [C: 031] "@Robert Vogel could you c+2 and v+2 this please? Also press the submit button please :)" [extensions/BlueSpiceExtensions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329695 (owner: 10Paladox) [18:00:14] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10MediaWiki-Configuration: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows - https://phabricator.wikimedia.org/T152502#2907576 (10Aklapper) [18:07:03] (03PS7) 10Florianschmidtwelzow: Display Parsoid version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) [18:07:45] (03CR) 10Florianschmidtwelzow: "Probably, I should move the new services to a separate change and rebase this one on top of it? :/" [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [18:08:40] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10MediaWiki-Configuration: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows - https://phabricator.wikimedia.org/T152502#2907580 (10Paladox) Your correct, according to http://php.net/manual/en/class.sessi... [18:10:50] (03PS7) 10Florianschmidtwelzow: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [18:11:45] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2907581 (10Aklapper) Do you use Firefox 50.0.1 or newer? Or some different browser? [18:12:00] (03PS7) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [18:12:03] (03Draft1) 10Paladox: Make some functions in PHPSessionHandler.php abstracts [core] - 10https://gerrit.wikimedia.org/r/329697 (https://phabricator.wikimedia.org/T152502) [18:12:06] (03Draft2) 10Paladox: Make some functions in PHPSessionHandler.php abstracts [core] - 10https://gerrit.wikimedia.org/r/329697 (https://phabricator.wikimedia.org/T152502) [18:13:04] 10MediaWiki-Vagrant, 06Analytics-Kanban: Enable 'analytics_cluster' role on Labs instance - https://phabricator.wikimedia.org/T151861#2907585 (10Ottomata) Discovery folks will have to comment on Oozie + ES. You could poke around in here: https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/discovery/anal... [18:13:43] 10Phabricator (Upstream), 07Upstream: Merging a task notifies other subscribers twice in web UI - https://phabricator.wikimedia.org/T154322#2907587 (10Aklapper) p:05Triage>03Lowest [18:13:43] (03CR) 10Robert Vogel: [V: 032 C: 032] Modify access rules [extensions/BlueSpiceExtensions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/329695 (owner: 10Paladox) [18:14:23] (03CR) 10jerkins-bot: [V: 04-1] Display Parsoid version on Special:Version [core] - 10https://gerrit.wikimedia.org/r/243269 (https://phabricator.wikimedia.org/T108226) (owner: 10Florianschmidtwelzow) [18:14:24] 10MonoBook: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907604 (10Aklapper) [18:14:26] 10Hovercards, 07I18n, 07RTL: flip the disabling explanation image for Hovercards in RTL languages - https://phabricator.wikimedia.org/T154330#2907591 (10Amire80) [18:14:47] (03CR) 10Robert Vogel: [C: 032] NamespaceManager: Fixed issue with delete options [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [18:15:03] 10Hovercards, 07I18n, 07RTL: flip the disabling explanation image for Hovercards in RTL languages - https://phabricator.wikimedia.org/T154330#2907605 (10Amire80) [18:15:28] (03Abandoned) 10Paladox: Make some functions in PHPSessionHandler.php abstracts [core] - 10https://gerrit.wikimedia.org/r/329697 (https://phabricator.wikimedia.org/T152502) (owner: 10Paladox) [18:16:24] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10MediaWiki-Configuration, 13Patch-For-Review: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows - https://phabricator.wikimedia.org/T152502#2907607 (10Paladox) @Jongfeli hi, try restarting apache pleas... [18:18:19] (03PS8) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [18:19:04] (03PS1) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329698 [18:19:08] I'm a newbie, and want to start contributing to wikimedia. How should I start? [18:19:25] 06Community-Liaisons (Jan-Mar 2017), 06Developer-Relations (Jan-Mar-2017): Technical Collaboration quarterly check in for January – March 2017 - https://phabricator.wikimedia.org/T150658#2907622 (10Aklapper) For the records, you can add access restricted task IDs as they won't be links for anyone who cannot ac... [18:19:36] (03PS1) 10Paladox: PHPSessionHandler: Workaround PHP5 bug [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/329699 [18:20:08] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2907623 (10Stryn) I have now Firefox 50.1.0. I have always the newest Firefox. [18:20:30] Hello everybody [18:20:48] 06Community-Liaisons (Jan-Mar 2017): Figure out how to deal with the "Internal Roles, Responsibilities and Interactions" problem between CLs and PMs - https://phabricator.wikimedia.org/T154321#2907624 (10Aklapper) [18:22:47] ravi: Hello! Is it your first time here? Welcome. :) [18:23:07] yes, I'm here for first time. [18:23:31] 10MonoBook: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907629 (10Aklapper) I can reproduce in Firefox 50.1 with https://ru.wikipedia.org/w/index.php?title=aijalksdjaslkd&action=edit&useskin=monobook&debug=true [18:23:36] ravi, Nice to see you here. Let us know if you have any questions. :) [18:23:41] (03PS2) 10Paladox: NamespaceManager: Fixed issue with delete options [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [18:24:09] I want to start contributing. How do I start? [18:24:32] (03CR) 10Paladox: "@Robert Vogel hi, could you try c+2 please?" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [18:24:46] ravi, What kind of contributions are you interested in making? [18:25:07] (03CR) 10Robert Vogel: [C: 032] NamespaceManager: Fixed issue with delete options [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [18:25:16] ravi, First off, you will need a development environment. Vagrant is easy to set up and use. See here: https://www.mediawiki.org/wiki/MediaWiki-Vagrant [18:28:09] (03Draft1) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 [18:28:30] (03PS2) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 [18:29:49] 10MediaWiki-Vagrant, 10Gerrit, 13Patch-For-Review: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2907635 (10Mainframe98) I'm still getting errors when I try setting up vagrant with a specific release instead of the master (`vagrant hiera mediawiki::... [18:30:07] ravi, Then you will need to set up git https://help.github.com/articles/set-up-git/. [18:30:25] I have already set up git :) [18:30:32] ravi, Great. :) [18:30:57] ravi: Create developer account [18:30:59] ravi, Then create an account on phabricator (where we track bugs) and gerrit (gerrit.wikimedia.org is where we push aptches) [18:31:17] ravi, Then, configure your git for gerrit https://www.mediawiki.org/wiki/Gerrit/Getting_started. (Mainly adding ssh keys and setting up git review) [18:31:46] ravi, Once you are done with that, you can pick a bug and start working on it! [18:32:09] By the way, typing a user's name, like ravi, allows you to "ping" them on IRC, so a notification of sorts. [18:32:39] (03CR) 10Paladox: "@Robert Vogel could you try c+2 on this please?" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [18:33:12] ravi: Also, lots of projects are on github. You can just make pull request [18:33:49] thanks a lot, MtDu and rlot :) [18:34:13] ravi, No problem. Let us know if you have any more questions. Glad to have you here. :) [18:34:57] MtDu, Should I make an account on Phabricator "For Projects"? [18:36:34] ravi: sorry. Create an account for mediawiki first here. https://www.mediawiki.org/w/index.php?title=Special:CreateAccount&returnto=Special:OAuth/authorize&returntoquery=oauth_token%3Db6d01ec7e921aab2bcd0cd9c12c6a0e2%26oauth_consumer_key%3D038ec949b263dc807b0079fd88538f37&campaign=loginCTA [18:37:20] ravi: then go to phabricator.wikimedia.org and login with mediawiki [18:37:21] (03CR) 10Paladox: [C: 031] Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [18:42:45] (03PS8) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [18:46:48] Do I have to make another account for gerrit, or wikimedia account will do? [18:47:01] ravi: Its wikimedia developer account [18:47:09] You can login to phab/etc via this [18:49:01] I logged into phabricator [18:50:39] (03CR) 10Robert Vogel: [C: 032] Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [18:51:26] ravi: Now login into gerrit [18:51:38] https://gerrit.wikimedia.org [18:52:01] ravi: Its home of being contributor. Its where code is reviewed [18:52:16] 10MediaWiki-Vagrant, 06Analytics-Kanban: Enable 'analytics_cluster' role on Labs instance - https://phabricator.wikimedia.org/T151861#2907638 (10Physikerwelt) @mschwarzer I think we need the wikitext of the latest page revision, or is there anything else citolytics extracts from the dump? [18:52:20] You can make changes here via git [18:53:01] (03Abandoned) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [18:53:06] tonythomas: Around? [18:54:54] (03PS1) 10MtDu: Replace deprecated attribute "width" with CSS "width" property [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329701 (https://phabricator.wikimedia.org/T42211) [18:56:21] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2907642 (10Stryn) Again I got the error, now when tried to save my changes to a page. Now I happened to get a .har file per instructions given at the task "Frequent loss... [18:59:13] 10MediaWiki-Authentication-and-authorization, 06Editing-Department, 07Browser-Support-Firefox: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2907645 (10Stryn) Got the error, and uploaded a F5194468 if someone wants to look. [19:03:10] (03PS2) 10MtDu: Replace deprecated attribute "width" with CSS "width" property [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329701 (https://phabricator.wikimedia.org/T42211) [19:14:53] 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 07Easy, 13Patch-For-Review: Add a drop-down list for the tags in Recentchanges and Newpages - https://phabricator.wikimedia.org/T27909#2907651 (10matej_suchanek) [19:17:35] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10MediaWiki-Configuration, 13Patch-For-Review: Fatal error: Class MediaWiki\Session\PHPSessionHandler with Zend OPcache under MS Windows - https://phabricator.wikimedia.org/T152502#2907653 (10Jongfeli) Hello @Paladox, thanks for your fix. I u... [19:29:16] 10Phabricator: Can't see and choose from all of the visibility options on smaller screens - https://phabricator.wikimedia.org/T154333#2907669 (10Stryn) [19:30:10] (03PS1) 10BryanDavis: Switch to Debian Jessie base image [vagrant] - 10https://gerrit.wikimedia.org/r/329703 (https://phabricator.wikimedia.org/T154130) [19:30:12] (03PS1) 10BryanDavis: Enable Jessie LXC container [vagrant] - 10https://gerrit.wikimedia.org/r/329704 (https://phabricator.wikimedia.org/T154294) [19:32:00] (03Abandoned) 10BryanDavis: Switch to Debian Jessie base image [vagrant] - 10https://gerrit.wikimedia.org/r/329703 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [19:32:49] (03Abandoned) 10BryanDavis: Enable Jessie LXC container [vagrant] - 10https://gerrit.wikimedia.org/r/329704 (https://phabricator.wikimedia.org/T154294) (owner: 10BryanDavis) [19:35:37] (03PS1) 10BryanDavis: Enable Jessie LXC container [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329705 (https://phabricator.wikimedia.org/T154294) [19:40:23] (03CR) 10Fomafix: [C: 031] Replace deprecated attribute "width" with CSS "width" property [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329701 (https://phabricator.wikimedia.org/T42211) (owner: 10MtDu) [19:51:38] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2907689 (10Cumbril) @Sophivorus I played around some with tagging and noticed that the tag is only applied if you press 'Save changes' button straight after editing article with ProveIt. If you pre... [20:03:53] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2907699 (10Aklapper) That makes me think that this might be again T151770... [20:06:15] 10MediaWiki-extensions-FlaggedRevs, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: FlaggedRevs uses deprecated attribute "width" on diff pages - https://phabricator.wikimedia.org/T42211#2907702 (10MtDu) a:03MtDu @Florian, @Aklapper, I have pushed a patch. See above. Thanks to @Fomafix for the review!... [20:11:16] (03PS2) 10Daniel Kinzler: Introduce HookRunner [core] - 10https://gerrit.wikimedia.org/r/329691 [20:34:12] (03PS2) 10Paladox: BSReview: Yearly mail fixes [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326971 (owner: 10Pwirth) [20:38:48] (03CR) 10Matěj Suchánek: "I will try to explain my intentions, perhaps we'll get to a decision to abandon." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/329213 (owner: 10Matěj Suchánek) [20:40:00] (03Draft1) 10Paladox: Update BlueSpiceExtensions (REL1_27) commit [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) [20:40:02] (03Draft2) 10Paladox: Update BlueSpiceExtensions (REL1_27) commit [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) [20:42:08] anyone with c+2 rights for ^^ that repo, could you merge it please. Im looking into T153079 and think it may be related to the auto submodules in gerrit. [20:42:08] T153079: Merge/Submit error on Gerrit: "org.eclipse.jgit.errors.MissingObjectException: Missing unknown" for BlueSpiceExtensions' REL1_27 branch - https://phabricator.wikimedia.org/T153079 [20:43:54] 10MonoBook: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907486 (10matmarex) Doesn't happen if you change the language, e.g. https://ru.wikipedia.org/w/index.php?title=Участник:Йо_Асакура&action=edit&redlink=1&useskin=monobook&uselang=en – I think this is caused by... [20:44:30] 10MonoBook: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907728 (10matmarex) [20:47:51] 10MonoBook: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907730 (10matmarex) Also, this is causing issues with Vector too (https://ru.wikipedia.org/w/index.php?title=Участник:Йо_Асакура&action=edit&redlink=1&useskin=vector), it's just a bit less visible – but note... [20:50:39] (03CR) 10Matěj Suchánek: "So could we proceed to a +2, then?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/328522 (https://phabricator.wikimedia.org/T153607) (owner: 10Matěj Suchánek) [20:52:35] 10Wikimedia-General-or-Unknown: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907745 (10matmarex) [20:54:34] 10Wikimedia-General-or-Unknown: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907746 (10matmarex) 05Open>03Resolved a:03matmarex Caused by this edit: https://ru.wikipedia.org/w/index.php?title=MediaWiki:Newarticletext&diff=82750355&oldid=82730672 Fixed with t... [20:55:43] 10Wikimedia-General-or-Unknown: Sidebar is located under text field on Monobook - https://phabricator.wikimedia.org/T154326#2907486 (10Jack_who_built_the_house) Sorry, my bad. Forgot the closing tag when changing from
to
. [[https://ru.wikipedia.org/w/index... [21:14:03] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: User-group autoreview should be in the implicitgroups (API output) if editor - https://phabricator.wikimedia.org/T153548#2907758 (10Perhelion) Thanks for comment, but maybe I understand you wrong. In which case should the Autoreview group be r... [21:17:42] rlot: back. reviewing it now [21:18:12] tonythomas: Hi [21:18:25] rlot: hey! [21:25:53] 10Wiki-Loves-Monuments (2017): Team offsite planning - https://phabricator.wikimedia.org/T146544#2907761 (10LilyOfTheWest) [21:26:19] tonythomas: ? [21:26:23] (03CR) 1001tonythomas: [C: 032] Updated docs in EchoNewsletterUserLocator [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329686 (https://phabricator.wikimedia.org/T154230) (owner: 10Filip) [21:26:25] 10Wiki-Loves-Monuments (2017): Team offsite planning - https://phabricator.wikimedia.org/T146544#2664539 (10LilyOfTheWest) [21:26:39] tonythomas: Thanks! [21:26:52] rlot: :Nice work, Thank yoU! [21:27:04] tonythomas: By the way, claimed this task [21:27:12] 10Wiki-Loves-Monuments (2017): Team offsite planning - https://phabricator.wikimedia.org/T146544#2664539 (10LilyOfTheWest) @Effeietsanders WMIT has confirmed that they can be the fiscal sponsor. I'm working with them on the venue/accommodation now. [21:27:13] which I made [21:27:25] rlot: link ? [21:27:35] (03Merged) 10jenkins-bot: Updated docs in EchoNewsletterUserLocator [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329686 (https://phabricator.wikimedia.org/T154230) (owner: 10Filip) [21:27:36] tonythomas: My prev. patchset [21:27:54] 10MediaWiki-Installer: Need a download LocalSettings.php link when upgrading wihle installing new version - https://phabricator.wikimedia.org/T154335#2907766 (10MarkAHershberger) [21:28:06] tonythomas: https://gerrit.wikimedia.org/r/#/c/329680/ [21:29:23] tonythomas: Can you submit it on GCI? Will claim this one ^^ [21:34:36] rlot: its already published as https://codein.withgoogle.com/dashboard/tasks/5454349838843904/ in GCI ? [21:34:43] the website is a bit buggy atm, though [21:35:32] Yes [21:35:50] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907781 (1001tonythomas) [21:35:52] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed - https://phabricator.wikimedia.org/T154230#2907779 (1001tonythomas) 05Open>03Resolved Nice work, Thank you! [21:37:08] tonythomas: Ok, claimed. Can you look at this PS? [21:40:04] (03CR) 1001tonythomas: [C: 04-1] "Minor.nit" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) (owner: 10Filip) [21:40:56] (03PS6) 10Filip: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) [21:41:06] tonythomas: ^^ [21:46:24] (03CR) 1001tonythomas: [C: 032] "Nice work, Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) (owner: 10Filip) [21:46:52] rlot: can you [x] the tasks which are completed in the description of https://phabricator.wikimedia.org/T153906 ? [21:47:07] tonythomas: Ok [21:47:49] (03Merged) 10jenkins-bot: Newsletter cleanup [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329680 (https://phabricator.wikimedia.org/T153906) (owner: 10Filip) [21:49:42] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907800 (10FilipGCI) [21:52:26] tonythomas: X'ed [21:55:50] rlot: Thank you! [21:56:58] tonythomas: Around? [21:57:06] MtDu: yup! tell! [21:57:10] (03CR) 10Gergő Tisza: [C: 032] Copy button for attribution text in download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/329495 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [21:57:47] tonythomas: Should iDatabase be changed to DatabaseMssql according to https://doc.wikimedia.org/mediawiki-core/1.26.0/php/classDatabaseMssql.html#a137c4ffecfc05cf51bf6b1ee2674b20c? [21:58:12] tonythomas: For this, that is. https://phabricator.wikimedia.org/T153906 [21:58:32] MtDu: let met take a look at the file [21:58:56] (03Merged) 10jenkins-bot: Copy button for attribution text in download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/329495 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [21:59:43] MtDu: I see that we are calling $this->mDb->tableName( 'nl_subscriptions' ); [22:00:29] Yes. [22:00:40] I looked up the docs to see which class has that function [22:01:14] MtDu: I see that long list there too .Sounds a bit confusing to me! [22:01:28] let me power up the phpstorm. [22:01:43] tonythomas: Ha. Nice. I don't have that. :) [22:01:53] legoktm: Around? [22:03:42] (03PS1) 10Awu42: Removed deprecated functions in includes/Title.php [core] - 10https://gerrit.wikimedia.org/r/329710 (https://phabricator.wikimedia.org/T61113) [22:06:37] (03CR) 10jenkins-bot: Copy button for attribution text in download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/329495 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [22:08:02] (03CR) 10Paladox: [C: 031] "@Mglaser could you merge this please by doing c+2 and v+2 and pressing submit please?" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:08:04] MtDu: I think 'Database' is the best class there for $mDb [22:10:21] tonythomas: For the reason fix, I don't think there is a reason, do I pass an empty string? [22:10:49] MtDu: Pass null [22:12:15] well. Maybe please create in a new i18n message there or something ? [22:12:20] so that it wont show up as null ? [22:13:46] tonythomas: So deleted newsletter? [22:14:01] tonythomas: Maybe 'Deleted newsletter $1' where $1 is newsletter name? [22:14:11] Or just delete. as the reason [22:14:40] MtDu: hmm. strange. can you check when this method is actually called ? [22:14:41] (03CR) 10Mglaser: [C: 032] Update BlueSpiceExtensions (REL1_27) commit [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:14:49] I get a strange feeling it might not be during the deletion process [22:14:56] (03CR) 10Mglaser: [V: 032 C: 032] Update BlueSpiceExtensions (REL1_27) commit [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:15:06] It's not [22:15:11] (03CR) 10Paladox: "Thanks." [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:15:28] It's in NewsletterDeletionUpdate [22:15:59] (03CR) 10Paladox: "@Mglaser could you try merging a change in BlueSpiceExtensions repo please, to see if this actually works." [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:16:02] (03CR) 10Mglaser: "Yay!! This got merged. Paladox, you are a hero!" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:17:06] (03CR) 10Paladox: "Yep, this is on the mediawiki/extensions repo, we just need to confirm now that BlueSpiceExtensions can merge again :)" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:17:21] It's in NewsletterDeletionUpdate [22:17:24] tonythomas:^ [22:17:29] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907810 (1001tonythomas) The part 2/2 was already imported as https://codein.withgoogle.com/dashboard/task-instances/4517194148872192/ I missed this, and created a d... [22:17:49] MtDu: I meant, when that function gets called/executed [22:18:06] (03Restored) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [22:18:10] I don't think it gets called. [22:18:12] (03PS1) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329712 [22:18:14] tonythomas:^ [22:18:30] 10MediaWiki-API: Wikimedia api doesn't return "request ID" with the "open search" action - https://phabricator.wikimedia.org/T154337#2907811 (10Etokheim) [22:18:35] https://www.irccloud.com/pastebin/WEB6okkJ/ [22:18:47] (03CR) 10Paladox: "@Mglaser could you do a c+2 on https://gerrit.wikimedia.org/r/#/c/329712/ please?" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329708 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:21:11] tonythomas: That just declares the class and passes it the name? [22:21:36] (03CR) 10Paladox: [C: 031] "@Mglaser could you c+2 please?" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [22:21:37] MtDu: its actually implementing one of its parent functions. [22:21:43] tonythomas: Oh, you want me to like see if I can pass the comment through [22:21:48] so I would safely pass a standard message tehre [22:21:48] tonythomas: From the wikipage? [22:22:04] Oh I see what you're saying? [22:22:17] (03PS3) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 [22:22:50] This is just for the logging's sake. You can just create a new message, and pass it on as $reason. [22:22:51] tonythomas: So what would the default message be? [22:22:58] Yeah that's what I'm saying [22:23:05] Did you see my message above about the proposal? [22:23:14] MtDu: I think we might have that somewhere in the code (probably before we removed the newsletter/id/delete) [22:23:26] tonythomas: Let me check [22:23:40] MtDu: yeah. you might have to revert your repo to ancient times, and take a look [22:23:58] tonythomas: I'll just look at the patch. :) [22:24:15] MtDu: heh. hope you might be able to find it somewhere! [22:25:50] tonythomas: This was the previous success message. [22:25:54] tonythomas: 'Newsletter \"$1\" has been deleted.' [22:26:04] MtDu: well. alright, go for it :D [22:26:14] But that's to the user. If we're logging it as reason, maybe something like 'Delete Newsletter $1' instead? [22:26:33] (03PS60) 10Cen.temp: Drop down menu for selecting tags [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [22:26:56] tonythomas:^ [22:27:16] MtDu: well, I am not sure we are storing it as reason thingy (as we have action=delete asking the admin to enter in a custom delete reason anyway). This one is just for Special:Log [22:27:47] So keep the same one as before? [22:28:08] tonythomas:^ [22:28:55] MtDu: yup! [22:29:26] tonythomas: I don't wanna make the line too long. Can I make a local variable newsletterName? [22:30:16] MtDu: the source code is yours man, go for it. Better give it a nicer variable name, though [22:32:20] tonythomas, is name for message 'newsletter-delete-log' ok? [22:32:26] or do I need to add the success? [22:32:47] 10MediaWiki-Vagrant, 13Patch-For-Review, 15User-bd808: Replace upstart with systemd unit in ::xvfb - https://phabricator.wikimedia.org/T154273#2907825 (10hashar) //whistles// Sorry I got confused! I thought the task referred to operations/puppet.git :-} [22:33:26] (03CR) 10Cen.temp: Drop down menu for selecting tags (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [22:35:40] MtDu: 'newsletter-delete-log' is fine, I guess. [22:35:56] tonythomas: Would you prefer the message be made in the call to the function's function or the function itself? [22:36:08] (03Abandoned) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329712 (owner: 10Paladox) [22:36:16] Could I access the wfMessage function in the NewsletterDeletionUpdate class? [22:36:46] MtDu: I would recommend you to take time and explore :D (that means I am not sure :D) [22:37:08] "function's function or the function itself?" ? [22:37:29] so getDeletionUpdates in NewsletterContent [22:37:45] that creates an instance of the class NewsletterDeletionUpdate. [22:38:00] My question is do you want me to create the message in getDeletionUpdates or in the class itself? [22:38:24] MtDu: why do you want to create that in the class ? :o [22:38:28] tonythomas: Wait I'm stupid. [22:38:34] tonythomas: We don't need to pass the reason [22:38:48] Because if we pass the name, we can just create the message and pass the name in during the call itself [22:38:58] If that makes sense. [22:39:37] MtDu: ahgah - now I see why you were asking about NewsletterName variable there! [22:39:47] tonythomas: :) [22:39:50] yeah, you must be able to make a wfMessage one line above [22:40:03] and then pass that variable compeltely as $reason [22:40:31] So inside the function doUpdate is better then right? [22:40:59] MtDu: right [22:41:14] so I'll just declare it as $reason to make it explicit [22:41:46] so $newsletterName is fine right? [22:42:08] Or do I not need to declare it anymore since I'm only passing one thing? [22:42:56] Sorry, thinking out loud. I know what to do [22:44:27] 10The-Wikipedia-Library: Reword application data (for sending) page - https://phabricator.wikimedia.org/T150291#2907827 (10Nikkimaria) The answer is "sometimes" - we have pushed back on some details in the past, and sometimes that has been no problem and other times they've specifically requested the data. We've... [22:46:30] tonythomas: How's this for a qqq.json message description? Default message passed to the logentry as a comment when a newsletter is deleted in NewsletterDeletionUpdate [22:47:54] (03CR) 10Gergő Tisza: "It would be nice to have a plan of how we eventually arrive to an architecture where hook calls happen via methods with a proper signature" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/329691 (owner: 10Daniel Kinzler) [22:50:10] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Social Event Plan: Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141934#2907828 (10Rfarrand) Tuesday catering and brewing finalized. Catering contract has been submitted & brewing contract will be submitted after the event.... [22:50:30] tonythomas: Also, in the NewsletterDeletionUpdate, I can't access the $newsletterName passed to the class during construction in doUpdate right? [22:50:40] I'll just have to get it using $this->newsletter->getName() [22:51:29] (03PS61) 10Cen.temp: Drop down menu for selecting tags [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [22:51:34] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 4 others: Replace Linker::link() usage with LinkRenderer in XX extension (clonable) - https://phabricator.wikimedia.org/T149346#2907841 (10jo12bar) [22:52:25] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Contracting for Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141928#2907844 (10Rfarrand) [22:52:27] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Developer Summit Catering Orders Complete - https://phabricator.wikimedia.org/T141929#2907842 (10Rfarrand) 05Open>03Resolved Mon - Wed lunch final Tuesday dinner final Wednesday dinner final Closing task - all contracts are with finance [22:52:30] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 4 others: Replace Linker::link() usage with LinkRenderer in XX extension (clonable) - https://phabricator.wikimedia.org/T149346#2749587 (10jo12bar) Started work on extension `VisualEditor` [22:53:13] (03PS2) 10BryanDavis: Enable Jessie LXC container [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329705 (https://phabricator.wikimedia.org/T154294) [22:54:42] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Contracting for Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141928#2907850 (10Rfarrand) [22:54:44] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Furniture set-up and order for Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141932#2907848 (10Rfarrand) 05Open>03Resolved Closing task Specifics for participants can be found here: https://www.mediawiki.org/wiki/Wikimed... [22:55:31] tonythomas: Around? [22:55:43] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): A/V and wifi contracted - https://phabricator.wikimedia.org/T141930#2907851 (10Rfarrand) A/v contract returned to vendor a second time for final revisions. My deadline to submit to finance is Sunday evening. [22:55:45] MtDu: just get it with $this->newsletter->getName() ? [22:56:03] Yeah. [22:56:13] tonythomas: Are you asking me what that means? [22:56:15] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Contracting for Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141928#2517043 (10Rfarrand) Very close... [22:56:25] no no. it works! [22:56:59] MtDu: on a side note, you are always welcome to hack it anyway you want it, and one of the reviewers would take a look and comment! [22:57:10] (03Draft1) 10Paladox: Update BlueSpiceFoundations commit (REL1_27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) [22:57:12] (03Draft2) 10Paladox: Update BlueSpiceFoundations commit (REL1_27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) [22:57:21] tonythomas: Alrighty. Could you take a look at my comment above about the message in qqq? [22:57:43] (03CR) 10Paladox: [C: 031] "@Mglaser could you c+2 and v+2 and press submit please?" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [22:57:54] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 2 others: Add "copy to clipboard" button to boilerplate text fields - https://phabricator.wikimedia.org/T77295#2907854 (10Tgr) 05Open>03Resolved Thanks, @Sn1per, it looks great! [22:57:56] MtDu: it looks good, man. go for it. [22:58:45] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Wikimedia Developer Summit Signage - https://phabricator.wikimedia.org/T154339#2907856 (10Rfarrand) [22:58:58] (03PS3) 10Paladox: Update BlueSpiceFoundations commit (REL1_27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) [22:59:47] tonythomas: Pushing a patch soon then. :) [23:01:22] tonythomas: Do you prefer using ->params() over just passing it into wfMessage? [23:04:29] (03PS1) 10MtDu: Clean up a few things in the Newsletter extension [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329715 (https://phabricator.wikimedia.org/T153096) [23:04:38] tonythomas: Let's see what you think! ^ [23:05:41] MtDu: looks good. [23:05:51] tonythomas: Submit it? [23:06:15] MtDu: you can submit in GCI, while I test it out [23:06:20] tonythomas: Cooleo [23:07:16] 10MediaWiki-Vagrant, 06Labs, 07Puppet, 15User-bd808: Make role::labs::mediawiki_vagrant work on Debian Jessie host systems - https://phabricator.wikimedia.org/T154340#2907871 (10bd808) [23:07:50] tonythomas: Done. [23:07:51] 10MediaWiki-Vagrant, 06Labs, 07Puppet, 15User-bd808: Make role::labs::mediawiki_vagrant work on Debian Jessie host systems - https://phabricator.wikimedia.org/T154340#2907885 (10bd808) [23:08:27] 10MediaWiki-Vagrant, 06Labs, 07Puppet, 15User-bd808: Make role::labs::mediawiki_vagrant work on Debian Jessie host systems - https://phabricator.wikimedia.org/T154340#2907871 (10bd808) One prior blocker was fixed by {T122734} [23:11:45] 10MediaWiki-API, 10Analytics: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321#2907899 (10bd808) [23:12:22] 10MediaWiki-API, 10Analytics, 06Developer-Relations, 06Reading-Admin, and 3 others: Metrics about the use of the Wikimedia web APIs - https://phabricator.wikimedia.org/T102079#2907900 (10bd808) [23:14:47] MtDu: hmm. It seems like that entire section might not be used one of these days after the contenthandler change [23:14:59] 10MediaWiki-Vagrant, 15User-bd808: Test Vagrant 1.9.1 for Labs hosts - https://phabricator.wikimedia.org/T122735#2907903 (10bd808) [23:15:40] 10MediaWiki-Vagrant, 06Labs, 07Puppet, 15User-bd808: Make role::labs::mediawiki_vagrant work on Debian Jessie host systems - https://phabricator.wikimedia.org/T154340#2907907 (10bd808) [23:15:42] 10MediaWiki-Vagrant, 15User-bd808: Test Vagrant 1.9.1 for Labs hosts - https://phabricator.wikimedia.org/T122735#1912379 (10bd808) [23:16:06] tonythomas: We can remove it later? Don't want to leave code to be confusing to users? [23:16:10] tonythomas: I submitted btw. [23:18:21] MtDu: yeah. can you create a task in phab titled "Checking in usage of NewsletterDeletionUpdate, and probably remove it" or something like that [23:18:31] but I guess its connected to ContentHandler at some point [23:18:44] Yeah. Because I mean the only usage is in ContentHandler. [23:18:54] So it must have some connection. [23:18:55] and maybe one more task which would be "Remove redundant logging in Newsletter extension" [23:19:23] (03CR) 1001tonythomas: [C: 032] "Looks good. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329715 (https://phabricator.wikimedia.org/T153096) (owner: 10MtDu) [23:20:04] tonythomas: Still wnat me to create the first one? [23:20:15] tonythomas: I guess so, since we're saying check in the usage of it? [23:20:17] (03Merged) 10jenkins-bot: Clean up a few things in the Newsletter extension [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329715 (https://phabricator.wikimedia.org/T153096) (owner: 10MtDu) [23:20:17] ;) [23:20:18] MtDu: yeah - that would be good enough to explore [23:20:25] Haha. [23:20:43] damn. phab down ? https://phabricator.wikimedia.org/T153096 [23:21:00] 10MediaWiki-extensions-TitleBlacklist, 10Wikimedia-General-or-Unknown: Editing session issue (TitleBlacklist related?) on *.wikipedia.org for Kvardek du - https://phabricator.wikimedia.org/T154112#2907908 (10Tgr) The errors in readable format: ``` ErrorException: PHP Notice: A session had already been started... [23:21:50] (03CR) 1001tonythomas: "Well. Wrong phab message here! https://phabricator.wikimedia.org/T153906 is the correct one." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329715 (https://phabricator.wikimedia.org/T153096) (owner: 10MtDu) [23:22:08] (03PS3) 10Mglaser: UEModulePDF: Removed unit test hook as there are no tests [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 [23:22:23] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907909 (1001tonythomas) @MtDu please mark the ones you have completed in the task description as well, and resolve this thing! [23:22:29] tonythomas: Woops. Rip. Haha [23:22:32] ;) [23:23:13] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2907912 (10MtDu) [23:23:50] 10MediaWiki-extensions-Newsletter, 06Community-Liaisons, 05Goal: Goal: Deploy Newsletter extension in Wikimedia - https://phabricator.wikimedia.org/T110170#2907916 (10MtDu) [23:23:53] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2894644 (10MtDu) 05Open>03Resolved All errors have been fixed. Hence closing as resolved! Thanks! [23:24:11] (03CR) 10Paladox: "Try a c+2 @Mglaser :)" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:24:13] MtDu: the new tasks, you can create as blockers to https://phabricator.wikimedia.org/T138462 after oepning this one up [23:25:13] (03CR) 10Mglaser: [C: 032] UEModulePDF: Removed unit test hook as there are no tests [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:25:42] (03Merged) 10jenkins-bot: UEModulePDF: Removed unit test hook as there are no tests [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:25:59] (03CR) 10Paladox: "Yay it worked" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:26:22] (03CR) 10Mglaser: "This is great!" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:26:41] (03CR) 10Mglaser: "@Paladox, so many thanks!" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:27:20] (03CR) 10Paladox: "Your welcome :)" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327744 (owner: 10Mglaser) [23:28:05] (03Abandoned) 10Paladox: Simple test for gerri's ui [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329700 (owner: 10Paladox) [23:29:02] 10MediaWiki-extensions-Newsletter: Research the usage of NewsletterDeletionUpdate (and probably remove it) - https://phabricator.wikimedia.org/T154341#2907919 (10MtDu) [23:29:04] (03CR) 10Mglaser: [C: 032] Update BlueSpiceFoundations commit (REL1_27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [23:29:09] (03CR) 10Mglaser: [V: 032 C: 032] Update BlueSpiceFoundations commit (REL1_27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [23:29:22] (03CR) 10Paladox: "Thanks :)" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [23:29:40] (03CR) 10Mglaser: "Worked!" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [23:30:12] (03PS2) 10Mglaser: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326899 (owner: 10Pwirth) [23:30:46] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2907933 (10MtDu) [23:30:49] 10MediaWiki-extensions-Newsletter: Research the usage of NewsletterDeletionUpdate (and probably remove it) - https://phabricator.wikimedia.org/T154341#2907932 (10MtDu) [23:30:51] (03CR) 10Paladox: ":)" [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329713 (https://phabricator.wikimedia.org/T153079) (owner: 10Paladox) [23:31:42] (03CR) 10Mglaser: [C: 032] BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326899 (owner: 10Pwirth) [23:32:05] (03CR) 10Paladox: "You should be able to merge now :)" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [23:32:13] 10MediaWiki-extensions-Newsletter: Remove redundant and unnecessary logging from the Newsletter Extension - https://phabricator.wikimedia.org/T154342#2907934 (10MtDu) [23:32:13] (03Merged) 10jenkins-bot: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326899 (owner: 10Pwirth) [23:32:18] (03CR) 10Paladox: "You should be able to merge now :)" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326971 (owner: 10Pwirth) [23:32:37] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2401078 (10MtDu) [23:32:39] 10MediaWiki-extensions-Newsletter: Remove redundant and unnecessary logging from the Newsletter Extension - https://phabricator.wikimedia.org/T154342#2907946 (10MtDu) [23:32:45] tonythomas: Do those look good? [23:33:01] (03PS3) 10Mglaser: NamespaceManager: Fixed issue with delete options [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 [23:34:03] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Add newsletter description to log messages - https://phabricator.wikimedia.org/T132018#2907953 (1001tonythomas) [23:34:06] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Special:Newsletter fatals if the newsletter main page is deleted - https://phabricator.wikimedia.org/T119058#2907954 (1001tonythomas) [23:34:09] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2907950 (1001tonythomas) 05Resolved>03Open Heh. Flippiing it open agian! [23:34:11] 10MediaWiki-extensions-Newsletter, 06Community-Liaisons, 05Goal: Goal: Deploy Newsletter extension in Wikimedia - https://phabricator.wikimedia.org/T110170#2907955 (1001tonythomas) [23:34:14] (03CR) 10Mglaser: [C: 032] NamespaceManager: Fixed issue with delete options [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [23:34:41] (03Merged) 10jenkins-bot: NamespaceManager: Fixed issue with delete options [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/328906 (owner: 10Mglaser) [23:34:50] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2907957 (1001tonythomas) [23:34:53] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Special:Newsletter fatals if the newsletter main page is deleted - https://phabricator.wikimedia.org/T119058#1816837 (1001tonythomas) [23:35:23] (03PS3) 10Mglaser: BSReview: Yearly mail fixes [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326971 (owner: 10Pwirth) [23:36:28] (03CR) 10Mglaser: [C: 032] BSReview: Yearly mail fixes [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326971 (owner: 10Pwirth) [23:36:54] (03Merged) 10jenkins-bot: BSReview: Yearly mail fixes [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326971 (owner: 10Pwirth) [23:41:35] 10MediaWiki-Debug-Logger, 10Wikimedia-Logstash, 13Patch-For-Review, 07Wikimedia-log-errors: normalized_message is a JSON dump of the whole event for exceptions in beta logstash - https://phabricator.wikimedia.org/T136849#2907959 (10Tgr) The `error-json` channel has similar issues, but unlike `exception-jso... [23:42:36] (03CR) 10Mglaser: [C: 032] Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329464 (owner: 10Umherirrender) [23:43:10] (03Merged) 10jenkins-bot: Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329464 (owner: 10Umherirrender) [23:43:46] (03PS1) 10Mglaser: Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329716 [23:45:06] (03CR) 10Mglaser: [C: 032] Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329716 (owner: 10Mglaser) [23:45:34] (03Merged) 10jenkins-bot: Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/329716 (owner: 10Mglaser) [23:54:23] (03CR) 10Paladox: "recheck" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329464 (owner: 10Umherirrender) [23:55:14] (03CR) 10Paladox: "check experimental" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329464 (owner: 10Umherirrender) [23:56:38] @seen tto [23:56:38] MtDu: tto is in here, right now [23:56:54] (03CR) 10jenkins-bot: Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329464 (owner: 10Umherirrender)