[00:00:00] For the four actions you can see listed in the includes/api directory [00:01:53] tto: That seems interesting and complicated. I will get it to it when I can. Are you a mentor this year? [00:02:41] MtDu: Yes, but I haven't done anything GCI-related yet [00:02:56] I've been struggling to find tasks to put in the system. That might be a good one for me to add [00:03:32] tto: Is there a certain action that's simpler than others so I can get started on it? [00:03:37] I guess I could try to do one now. :) [00:03:49] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2905552 (1001tonythomas) 05Open>03Resolved Everything is set here, I guess. Closing this one as resolved! Thank you! [00:03:56] tto: Will you be available for the next hour? If so, could you give me a general overview of what needs to be done? [00:05:00] MtDu: I'll be back in maybe half an hour or three quarters of an hour [00:05:07] Need to go in a moment [00:05:23] Alrighty. Before you leave, is there any specific one that's easier than the others for me to try to implement? [00:06:09] tto, ^ [00:06:58] MtDu: Probably not. They are most likely all of equivalent difficulty I'd say [00:07:24] I'll try to get started on one then. [00:08:12] 10Gamepress: Replace images and image sprites in Gamepress with CSS - https://phabricator.wikimedia.org/T154255#2905540 (10SamanthaNguyen) [00:08:38] 10Gamepress: Hardcoded username in resources/js/twitter.js - https://phabricator.wikimedia.org/T154106#2905558 (10SamanthaNguyen) a:03SamanthaNguyen [00:09:51] (03CR) 10Jack Phoenix: [C: 032] Remove support for (03Merged) 10jenkins-bot: Remove support for 10Truglass, 07Browser-Support-Internet-Explorer, 07Browser-Support-Opera: Get rid of support for IE7 and below and Opera 9.5 and below for Truglass - https://phabricator.wikimedia.org/T154201#2905560 (10SamanthaNguyen) 05Open>03Resolved [00:13:41] 10MediaWiki-API, 10MediaWiki-Change-tagging, 05MW-1.27-release-notes, 13Patch-For-Review: Add a tags parameter to API modules creating a logentry - https://phabricator.wikimedia.org/T97720#2905562 (10MtDu) [00:14:00] 10MediaWiki-API, 10MediaWiki-Change-tagging, 05MW-1.27-release-notes, 13Patch-For-Review: Add a tags parameter to API modules creating a logentry - https://phabricator.wikimedia.org/T97720#1250748 (10MtDu) action=delete appears to be done in https://github.com/wikimedia/mediawiki/commit/db3d429036eab1d7167... [00:14:03] (03CR) 10Jack Phoenix: [C: 032] Organize CSS, deleting stylesheets, remove old IE support [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/329383 (https://phabricator.wikimedia.org/T154200) (owner: 10SamanthaNguyen) [00:15:34] (03Merged) 10jenkins-bot: Organize CSS, deleting stylesheets, remove old IE support [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/329383 (https://phabricator.wikimedia.org/T154200) (owner: 10SamanthaNguyen) [00:16:04] 10DeskMessMirrored, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer, 07Easy: Get rid of support for IE6 and below and Firefox 2 for DeskMessMirrored - https://phabricator.wikimedia.org/T154200#2905565 (10SamanthaNguyen) 05Open>03Resolved [00:18:44] (03PS1) 10SamanthaNguyen: Remove unused script, make description more i18n-friendly [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/329530 (https://phabricator.wikimedia.org/T154106) [00:20:13] (03CR) 10Jack Phoenix: [C: 032] Remove unused script, make description more i18n-friendly [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/329530 (https://phabricator.wikimedia.org/T154106) (owner: 10SamanthaNguyen) [00:20:19] (03Merged) 10jenkins-bot: Remove unused script, make description more i18n-friendly [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/329530 (https://phabricator.wikimedia.org/T154106) (owner: 10SamanthaNguyen) [00:21:12] 10Gamepress, 07Easy: Hardcoded username in resources/js/twitter.js - https://phabricator.wikimedia.org/T154106#2905571 (10SamanthaNguyen) 05Open>03Resolved [00:59:03] (03PS1) 10Cdentinger: update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/329536 [01:01:20] (03CR) 10Cdentinger: [C: 032] update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/329536 (owner: 10Cdentinger) [01:03:45] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: Support a responsive grid system - https://phabricator.wikimedia.org/T90687#1065006 (10bd808) I've only glanced at {rMW87381cb} but it looks to me like it is mostly the mixins that would be handy for doing layout on a special page following the [[... [01:07:42] (03Merged) 10jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/329536 (owner: 10Cdentinger) [01:11:30] 10Wikimedia-SVG-rendering: the language-switcher on SVG file isn't working - https://phabricator.wikimedia.org/T154256#2905578 (10Cwek) [01:21:28] 10Wikimedia-SVG-rendering, 07Chinese-Sites, 07I18n: SVG image wikisyntax can't use "lang=zh-hant" - https://phabricator.wikimedia.org/T154237#2905597 (10Liuxinyu970226) [01:21:31] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2905596 (10Liuxinyu970226) [01:24:33] 06Editing-Analysis, 10Wikimedia-General-or-Unknown, 07Chinese-Sites: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2905598 (10Liuxinyu970226) [01:26:55] 04(no projects): simple form without "results in PHP Notice - https://phabricator.wikimedia.org/T154257#2905605 (10MarkAHershberger) [01:27:02] (03PS1) 10UltrasonicNXT: Change the loading dots to a GIF [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329537 [01:27:49] (03CR) 10UltrasonicNXT: "Looks good! What's the current status with this? Can I help?" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/275198 (https://phabricator.wikimedia.org/T100024) (owner: 10Jack Phoenix) [01:29:01] (03CR) 10UltrasonicNXT: [C: 032] Change the loading dots to a GIF [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329537 (owner: 10UltrasonicNXT) [01:29:59] (03Merged) 10jenkins-bot: Change the loading dots to a GIF [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329537 (owner: 10UltrasonicNXT) [01:31:09] 10ProveIt-Gadget: Change citation names in text when changing reference name - https://phabricator.wikimedia.org/T154258#2905620 (10Cumbril) [01:31:16] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review: Chat CPU usage - https://phabricator.wikimedia.org/T147270#2905632 (10UltrasonicNXT) 05Open>03Resolved I've changed the animated dots to a loading gif, so there should be no CPU drain now. [01:31:36] 10ProveIt-Gadget: Change citation names in text when changing reference name - https://phabricator.wikimedia.org/T154258#2905620 (10Cumbril) [01:34:56] 10MediaWiki-extensions-Page_Forms: simple form without "for template" results in PHP Notice - https://phabricator.wikimedia.org/T154257#2905635 (10MarkAHershberger) a:03MarkAHershberger [01:42:26] 06Brickimedia, 10MediaWikiChat: Chat CPU usage - https://phabricator.wikimedia.org/T147270#2905643 (10SamanthaNguyen) [01:42:51] 10Wikimedia-SVG-rendering: the language-switcher on SVG file isn't working - https://phabricator.wikimedia.org/T154256#2905578 (10Glrx) Problem 1 (Language switching at ImagePage.php) is improper handling of URL lang arg on Commons File pages. Selecting a language with mixed case langtag will fail. Same problem... [01:50:28] 10MediaWiki-extensions-UniversalLanguageSelector, 06translatewiki.net, 07Chinese-Sites: Simplified/Traditional Chinese not found when "Chinese" entered - https://phabricator.wikimedia.org/T73891#2905658 (10Liuxinyu970226) To be honesty, I can confirm on zhwiki that: By using zh, zh-hans, zh-hant, zh-mo, and... [02:19:49] 10MediaWiki-extensions-Page_Forms: Superfluous \n in PageForms changes how checkboxes render inside a table - https://phabricator.wikimedia.org/T154259#2905665 (10MarkAHershberger) [02:19:59] (03PS14) 10Paladox: Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 (https://phabricator.wikimedia.org/T153756) [02:20:33] (03CR) 10Paladox: "> What is the advantage of doing this? Does this fix bugs we've?" [core] - 10https://gerrit.wikimedia.org/r/328113 (https://phabricator.wikimedia.org/T153756) (owner: 10Paladox) [02:25:52] (03CR) 10jerkins-bot: [V: 04-1] Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 (https://phabricator.wikimedia.org/T153756) (owner: 10Paladox) [02:27:35] 10MediaWiki-extensions-FlaggedRevs: Auto-accept pending revision when user self-reverts to reviewed version - https://phabricator.wikimedia.org/T133442#2905682 (10Cenarium) a:03Cenarium Same as T59073 but for self-reverts. [02:28:42] (03CR) 10Paladox: "@Hashar hi im wondering do you know why this keeps failing? As it is failing with the same error we had before but that was fixed in wikib" [core] - 10https://gerrit.wikimedia.org/r/328113 (https://phabricator.wikimedia.org/T153756) (owner: 10Paladox) [02:33:15] 06Brickimedia, 10Refreshed, 06ShoutWiki: Make Refreshed skin less specific to Brickimedia - https://phabricator.wikimedia.org/T134669#2905693 (10SamanthaNguyen) [02:33:15] 06Brickimedia, 10Refreshed, 07Easy: Make Refreshed less specific to Brickimedia: Remove studs-tile-refreshed.png from the source code - https://phabricator.wikimedia.org/T146008#2905690 (10SamanthaNguyen) 05Open>03Resolved a:03SamanthaNguyen Done in https://gerrit.wikimedia.org/r/#/c/329364/ [02:35:57] 10MediaWiki-extensions-Newsletter: Should "view subscribers" be part of "manage" in the Newsletter extension? - https://phabricator.wikimedia.org/T154144#2902295 (10Pppery) However, merging in subscribers to the manage page would break consistency between view and edit by making the edit page allow information t... [02:53:50] (03PS2) 10Kaldari: Add parent and banner fields to projects table [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/329386 (https://phabricator.wikimedia.org/T154216) [02:54:43] 10MediaWiki-extensions-Page_Forms, 13Patch-For-Review: simple form without "for template" results in PHP Notice - https://phabricator.wikimedia.org/T154257#2905605 (10Yaron_Koren) I merged in the patch, although I don't see why you would have an "input" tag without a "for template" tag - that looks like an error. [02:56:25] 10MediaWiki-extensions-Page_Forms, 13Patch-For-Review: Superfluous \n in PageForms changes how checkboxes render inside a table - https://phabricator.wikimedia.org/T154259#2905711 (10Yaron_Koren) 05Open>03Resolved Thanks! [02:57:54] 10Web-APIs-Hub: API sandboxes for the Developer Hub - https://phabricator.wikimedia.org/T302#2905713 (10Anomie) a:05Anomie>03None [03:03:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905731 (10daniel) @Yurik this task is about defining a Wikibase datatype that allows us to reference GeoJSON pages. [03:04:36] 10MediaWiki-API, 10MediaWiki-Database: Using both rvuser and rvcontinue with prop=revisions causes database error on pages with a lot of revisions - https://phabricator.wikimedia.org/T88084#2905733 (10Anomie) a:05Anomie>03None [03:04:56] 10AbuseFilter, 13Patch-For-Review: AbuseFilter needs better tag name validation - https://phabricator.wikimedia.org/T92956#2905734 (10Anomie) a:05Anomie>03None [03:06:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905735 (10Yurik) @daniel Ah, thanks, I misunderstood. Do you want to handle these pages the same way you handle images on Commons, or do you... [03:10:41] qgil: around? [03:10:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905737 (10daniel) @Yurik yes, indeed, we want to treat them similar to how we handle commons media. It's not exactly the same though, so it... [03:13:35] (03PS1) 10SamanthaNguyen: Make desc more i18n friendly, consistent tabbing [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329540 [03:13:39] 10Gamepress, 07Easy: Hardcoded username in resources/js/twitter.js - https://phabricator.wikimedia.org/T154106#2905738 (10labster) Thanks for the quick turnaround! [03:16:13] 10MediaWiki-Interwiki, 10Wikidata, 06Wikisource: interwiki links to/from https://wikisource.org - https://phabricator.wikimedia.org/T138332#2905739 (10Liuxinyu970226) [03:16:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Sitelinks to Incubator, OldWikisource and BetaWikiversity - https://phabricator.wikimedia.org/T54971#2905740 (10Liuxinyu970226) [03:16:48] tto: Around? [03:16:55] 10Gamepress, 07Easy: Hardcoded username in resources/js/twitter.js - https://phabricator.wikimedia.org/T154106#2905741 (10SamanthaNguyen) Of course, glad to help :) [03:17:01] MtDu: I'm here :) [03:17:23] tto: Got time to guide me through one of them? May take some patience and explaining on your end. ;) [03:17:51] MtDu: Sure, let's talk in a personal chat [03:17:55] Alrighty. [03:18:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905742 (10Yurik) @daniel, thanks. Will you want to group them together, or have one datatype per the content handler? For now, we have `.ma... [03:20:57] 10MediaWiki-API, 07Epic: Better separate logic/data classes from API modules to encourage internal use - https://phabricator.wikimedia.org/T93897#2905743 (10Anomie) a:05Anomie>03None The current title of this task makes it a duplicate of {T89889}: The API modules are the "presentation" side while the logic... [03:21:12] 10MediaWiki-API, 07Epic: Better separate logic/data classes from API modules to encourage internal use - https://phabricator.wikimedia.org/T93897#2905746 (10Anomie) [03:21:14] 10ArchCom-RfC, 07RfC, 07Service-Architecture: RFC: Business Layer Architecture on budget - https://phabricator.wikimedia.org/T95654#2905749 (10Anomie) [03:22:59] 10MediaWiki-extensions-Scribunto, 07I18n: Scribunto console is in English instead of the site language - https://phabricator.wikimedia.org/T126308#2905750 (10Anomie) a:05Anomie>03None [03:27:06] 10MediaWikiChat: Fullscreen MediaWiki chat container isn't being styled - https://phabricator.wikimedia.org/T154261#2905751 (10SamanthaNguyen) [03:28:21] 10MediaWikiChat: Fullscreen MediaWikiChat container isn't being styled - https://phabricator.wikimedia.org/T154261#2905751 (10SamanthaNguyen) [03:28:46] (03PS2) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [03:29:58] (03CR) 10Jack Phoenix: "> Looks good! What's the current status with this? Can I help?" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/275198 (https://phabricator.wikimedia.org/T100024) (owner: 10Jack Phoenix) [03:30:51] (03CR) 10Jack Phoenix: [C: 032] Make desc more i18n friendly, consistent tabbing [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329540 (owner: 10SamanthaNguyen) [03:31:17] (03CR) 10jerkins-bot: [V: 04-1] Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [03:31:31] 10ProveIt-Gadget, 07I18n: Localization - https://phabricator.wikimedia.org/T148335#2905767 (10Sophivorus) [03:31:33] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2905764 (10Sophivorus) 05Open>03Resolved a:03Sophivorus @Cumbril Cool, I'm closing this task as completed then, thanks again! [03:32:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905768 (10aude) @Yurik think they need to be separate datatypes (at least geo separate from other data) [03:33:47] 10ProveIt-Gadget: Change citation names in text when changing reference name - https://phabricator.wikimedia.org/T154258#2905771 (10Sophivorus) p:05Triage>03High Definitely, I'll take care asap, but that will probably mean in February, because tomorrow I'm leaving for a one-month holiday. Cheers! [03:34:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905773 (10Yurik) @aude what would be the benefit? I'm guessing the property would need to be restricted to a specific target type, but can w... [03:35:40] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Rename user SSTflyer to Feminist - https://phabricator.wikimedia.org/T154262#2905774 (10K6ka) [03:35:59] (03PS3) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [03:36:15] 10MediaWikiChat: Fullscreen MediaWikiChat container isn't being styled - https://phabricator.wikimedia.org/T154261#2905787 (10ashley) Caused by efe370457b21 which fixes T145308, probably some ResourceLoader madness going on again. Maybe we'd want `$out->setArticleBodyOnly( true );` instead of `$out->disable();`?... [03:39:44] 10MediaWiki-Uploading, 06Multimedia: Support for GPS eXchange Format (GPX) - https://phabricator.wikimedia.org/T55023#2905791 (10Liuxinyu970226) [03:39:55] (03CR) 10jerkins-bot: [V: 04-1] Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [03:40:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905794 (10aude) @yurik think it would be easier to search/query if they were separate, and also display and handle other aspects differently [03:43:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905796 (10Yurik) agree, visualization aspect is important (i wonder if visualization should be per-property though). As for searching - do w... [03:49:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905797 (10aude) @yurik Wikibase doesn't know about what properties there are but can handle things at the data type level. not sure I unde... [03:51:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905798 (10Yurik) Ah, gotcha. Yep, totally makes sense for searching :) Thanks for explaining! [03:52:50] 10MediaWiki-API, 10MediaWiki-Change-tagging, 05MW-1.27-release-notes, 13Patch-For-Review: Add a tags parameter to API modules creating a logentry - https://phabricator.wikimedia.org/T97720#2905799 (10TTO) [03:54:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905801 (10aude) or all polygons, with instance of (P31) of something, that include a particular point, etc. [03:59:04] 10MediaWiki-extensions-Page_Forms, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): simple form without "for template" results in PHP Notice - https://phabricator.wikimedia.org/T154257#2905802 (10MarkAHershberger) >>! In T154257#2905708, @Yaron_Koren wrote: > I merged in the patch, although I don'... [04:03:20] (03CR) 10Cen.temp: Add echo notification when deferred (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316957 (https://phabricator.wikimedia.org/T153284) (owner: 10Cenarium) [04:05:36] (03CR) 10Cen.temp: Notify users of reviews (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [04:13:28] 04(no projects): Deprecate ArticleRollbackComplete hook - https://phabricator.wikimedia.org/T154263#2905805 (10Cenarium) [04:16:09] 10MediaWiki-API, 05MW-1.28-release-notes: Deprecate and remove use of API action=purge with GET requests - https://phabricator.wikimedia.org/T145649#2905816 (10Anomie) [04:56:44] (03PS1) 10BryanDavis: crm::dash: Fix Puppet lint errors [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329544 [04:56:55] (03CR) 10BryanDavis: [C: 032] crm::dash: Fix Puppet lint errors [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329544 (owner: 10BryanDavis) [04:57:07] (03Merged) 10jenkins-bot: crm::dash: Fix Puppet lint errors [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329544 (owner: 10BryanDavis) [04:57:55] (03PS4) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [04:58:10] 06Wikipedia-Android-App-Backlog, 07Easy, 07WorkType-NewFunctionality: Improve error handling in Featured Article widget. - https://phabricator.wikimedia.org/T121410#2905817 (10FleetAdmiral) @Kaartic Sorry, didn't realise that! Regardless, i've begun work on the bug. [04:59:54] (03CR) 10jenkins-bot: crm::dash: Fix Puppet lint errors [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329544 (owner: 10BryanDavis) [05:00:48] (03CR) 10jerkins-bot: [V: 04-1] Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) (owner: 10BryanDavis) [05:02:56] (03PS5) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [05:11:09] 10MediaWiki-Vagrant: Replace upstart with systemd unit in crm::dash - https://phabricator.wikimedia.org/T154264#2905818 (10bd808) [05:12:56] 10MediaWiki-Vagrant: Replace upstart with systemd unit in eventlogging::devserver and eventlogging::service - https://phabricator.wikimedia.org/T154265#2905831 (10bd808) [05:14:17] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::sentry - https://phabricator.wikimedia.org/T154266#2905844 (10bd808) [05:16:05] 10MediaWiki-Vagrant: Replace upstart with systemd unit in service::node - https://phabricator.wikimedia.org/T154267#2905857 (10bd808) [05:17:08] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::statsd - https://phabricator.wikimedia.org/T154268#2905870 (10bd808) [05:18:31] 10MediaWiki-Vagrant: Replace upstart with systemd unit in swift::service - https://phabricator.wikimedia.org/T154269#2905883 (10bd808) [05:19:44] 10MediaWiki-Vagrant: Replace upstart with systemd unit in thumbor::service - https://phabricator.wikimedia.org/T154270#2905896 (10bd808) [05:21:04] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::trafficserver - https://phabricator.wikimedia.org/T154271#2905909 (10bd808) [05:22:25] (03PS1) 10Cen.temp: Refactor maybeMakeEditReviewed to handle all self-reverts, avoid db hits [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329545 [05:22:42] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::varnish - https://phabricator.wikimedia.org/T154272#2905922 (10bd808) [05:23:56] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::xvfb - https://phabricator.wikimedia.org/T154273#2905935 (10bd808) [05:25:03] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::zotero - https://phabricator.wikimedia.org/T154274#2905948 (10bd808) [05:26:00] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::zotero - https://phabricator.wikimedia.org/T154274#2905948 (10bd808) Probably should be updated to use `service::node` after {T154267} is complete. [05:30:08] 10MediaWiki-Vagrant, 10Fundraising-Backlog: Replace upstart with systemd unit in crm::dash - https://phabricator.wikimedia.org/T154264#2905964 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:33:03] 10MediaWiki-Vagrant, 10Analytics, 10Analytics-EventLogging: Replace upstart with systemd unit in eventlogging::devserver and eventlogging::service - https://phabricator.wikimedia.org/T154265#2905966 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:34:13] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::sentry - https://phabricator.wikimedia.org/T154266#2905969 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:34:42] 10MediaWiki-Vagrant, 06Services: Replace upstart with systemd unit in service::node - https://phabricator.wikimedia.org/T154267#2905970 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:35:04] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::statsd - https://phabricator.wikimedia.org/T154268#2905972 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:35:52] 10MediaWiki-Vagrant: Replace upstart with systemd unit in swift::service - https://phabricator.wikimedia.org/T154269#2905973 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:36:15] 10MediaWiki-Vagrant: Replace upstart with systemd unit in thumbor::service - https://phabricator.wikimedia.org/T154270#2905975 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:37:07] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::trafficserver - https://phabricator.wikimedia.org/T154271#2905977 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:37:31] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::varnish - https://phabricator.wikimedia.org/T154272#2905979 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:37:42] 10MediaWiki-Vagrant: Replace upstart with systemd unit in ::xvfb - https://phabricator.wikimedia.org/T154273#2905981 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:40:46] 10MediaWiki-Vagrant, 10Citoid, 10VisualEditor: Replace upstart with systemd unit in ::zotero - https://phabricator.wikimedia.org/T154274#2905982 (10bd808) Patches should be submitted to the `jessie-migration` gerrit branch. [05:44:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Verified: special page to list all items without description in a given language - https://phabricator.wikimedia.org/T44102#2905987 (10Paucabot) [06:19:08] (03CR) 10BryanDavis: "matt_flaschen: I can't find any config in any mediawiki-vagrant role that creates the 'steward' group. Was there some other change that wa" [vagrant] - 10https://gerrit.wikimedia.org/r/280802 (owner: 10Mattflaschen) [06:22:43] (03PS6) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [06:22:45] (03PS1) 10BryanDavis: Convert statsd to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329546 (https://phabricator.wikimedia.org/T154268) [06:25:00] 10MediaWiki-Vagrant, 13Patch-For-Review, 15User-bd808: Replace upstart with systemd unit in ::statsd - https://phabricator.wikimedia.org/T154268#2906007 (10bd808) a:03bd808 [07:14:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Easy, 03Google-Code-In-2016, 07I18n: [Bug] Strings "name" and "badges" are not translatable in diffs - https://phabricator.wikimedia.org/T111016#2906013 (10Ladsgroup) Changing DiffView doesn't sound crazy but you can try rendering templates to make... [07:17:45] 10Wiki-Loves-Monuments (2016): Send confirmation emails to the international top-15 winners - https://phabricator.wikimedia.org/T154179#2906014 (10Effeietsanders) Emails sent, now collecting the info. [07:18:58] 10Wiki-Loves-Monuments (2016): Design & make the certificates for the top-15 - https://phabricator.wikimedia.org/T154178#2906017 (10Effeietsanders) Collecting the required info through T154179 [07:28:06] 04(no projects): Shift key - https://phabricator.wikimedia.org/T154275#2906019 (10Trackinfo) [07:32:50] (03PS2) 10Ladsgroup: Ask for confirmation when nuking [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/329387 (https://phabricator.wikimedia.org/T131975) [07:33:01] 10Wikimedia-General-or-Unknown: Most whatchlist emails don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2906030 (10Nemo_bis) > The big problem is that most huwiki emails don't arrive lately. But with the information provided we don't know whether this is really a delivery bug. For instance, if... [07:33:03] 10MediaWiki-extensions-Nuke: Nuke keeps previously deleted pages as to-be-deleted when run repeatedly - https://phabricator.wikimedia.org/T32584#357169 (10Nikerabbit) Just noting here that I saw this too, still. [07:33:28] (03CR) 10Ladsgroup: Ask for confirmation when nuking (034 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/329387 (https://phabricator.wikimedia.org/T131975) (owner: 10Ladsgroup) [07:33:46] 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Add CAPTCHA feature to Nuke extension - https://phabricator.wikimedia.org/T131975#2906033 (10Ladsgroup) >>! In T131975#2904609, @IKhitron wrote: > @Ladsgroup, please, add the number of deleted pages into the confirmation message. The problem is almost always whe... [07:34:14] 10MediaWiki-extensions-Nuke: Pattern field is broken - https://phabricator.wikimedia.org/T154276#2906034 (10Nikerabbit) [07:40:07] 10MediaWiki-Language-converter, 10Collection, 10Internet-Archive, 07Chinese-Sites, 07I18n: Language conversion is not applied in documents delivered by the Collection extension - https://phabricator.wikimedia.org/T36919#2906048 (10Liuxinyu970226) [07:40:52] 10Wikimedia-Site-requests: Import old revisions from dump to restore missing revisions - https://phabricator.wikimedia.org/T41008#2906052 (10Liuxinyu970226) [07:41:41] 07Privacy, 05Security: Set channel cmode +S for wikimedia private IRC-Channels - https://phabricator.wikimedia.org/T152926#2906055 (10Legoktm) You're now saying something entirely different, which has nothing to do this task. [07:42:46] 10MediaWiki-extensions-Nuke: Pattern field is broken - https://phabricator.wikimedia.org/T154276#2906034 (10Nemo_bis) Verified on https://www.mediawiki.org/wiki/Special:Nuke Steps to reproduce: 1) Find a new page title in https://www.mediawiki.org/wiki/Special:NewPages (open a page, copy the title from the URL... [07:42:56] 10MediaWiki-extensions-Nuke: Pattern field is broken - https://phabricator.wikimedia.org/T154276#2906058 (10Nemo_bis) p:05Triage>03High [07:43:44] 10Commons-Datasets: Allow multiple data pages to reuse the same header structure declaration - https://phabricator.wikimedia.org/T134835#2906059 (10Yurik) After some more pondering: * each dataset MUST have column's `name` and `type`, but MAY have localized `title` * a dataset MAY reference an external translati... [07:43:59] (03CR) 10Nikerabbit: [C: 032] "I don't see it double escaped, but this is the right thing to do." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329461 (owner: 10Fomafix) [07:45:18] (03Merged) 10jenkins-bot: Explicit convert the Message object to string [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329461 (owner: 10Fomafix) [07:52:15] 10MediaWiki-Internationalization, 06Language-Team, 07Tracking: getHumanTimestamp issues (tracking) - https://phabricator.wikimedia.org/T66430#2906062 (10Nemo_bis) [07:52:17] 10MediaWiki-Internationalization, 07Epic: Make MediaWiki consistent in how it displays time - https://phabricator.wikimedia.org/T31235#2906061 (10Nemo_bis) [07:54:50] 10MediaWiki-Special-pages, 03Community-Tech-Sprint, 07Community-Wishlist-Survey-2015, 05MW-1.28-release-notes, and 2 others: Improve date range searches on Special:Contributions - https://phabricator.wikimedia.org/T120733#2906064 (10Nemo_bis) >>! In T120733#2900858, @Sn1per wrote: > `DateInputWidget` uses... [07:55:47] 10MediaWiki-Internationalization, 07Epic: Make MediaWiki consistent in how it displays time - https://phabricator.wikimedia.org/T31235#339404 (10Nemo_bis) I just learnt the situation is getting even worse, due to the inclusion of yet another date formatting system i.e. moment.js (in [DateinputWidget](https://w... [07:58:14] (03CR) 10Nemo bis: "If you want your translations to be under this name in l10n files, I can rename your account on translatewiki.net. It's vastly easier than" (031 comment) [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/329385 (owner: 10SamanthaNguyen) [08:11:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: DispatchingServiceFactory must provide a (Dispatching)TermSearchInteractor - https://phabricator.wikimedia.org/T153793#2906071 (10WMDE-leszek) a:03WMDE-leszek [08:27:41] 10MediaWiki-extensions-RelatedSites, 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 07Technical-Debt: De-deploy the RelatedSites extension - https://phabricator.wikimedia.org/T128326#2906073 (10Nemo_bis) [08:36:29] 10MediaWiki-extensions-Newsletter: Should "view subscribers" be part of "manage" in the Newsletter extension? - https://phabricator.wikimedia.org/T154144#2906075 (10QuimGil) 05Open>03declined Too many questions for a improvement that is not even a clear improvement. Let's decline this task and reopen if real... [08:39:41] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2906078 (10Aklapper) > I've hidden the security field from the 'advanced' task form. https://wikitech.wikimedia.org/wiki/Operations_requests#Domain_requests welcomes an update by #Ops. [08:55:44] 04(no projects): "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2906079 (10Reception123) @Aklapper It is happening on multiple browsers. I tried on most recent versions of Chrome and Mozilla Firefox and it does happen. The wiki farm is Miraheze and it has been r... [08:58:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/329557 (owner: 10L10n-bot) [08:59:58] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2906101 (10Aklapper) Does clearing all related web browser cookies help? Also wondering if capturing the HTTP requests and responses might provide some more info here... [09:00:56] 04(no projects): Deprecate ArticleRollbackComplete hook - https://phabricator.wikimedia.org/T154263#2906106 (10Aklapper) Hi @Cenarium. Please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task to allow others to find this task when searching in... [09:03:43] 04(no projects): Shift key - https://phabricator.wikimedia.org/T154275#2906107 (10Aklapper) Hi @Trackinfo, thanks for taking the time to report this! > Edit an article. Is this about classic wikitext editor? Or VisualEditor? I fail to reproduce - does this also happen with other browsers? Which ones did you t... [09:03:54] 10MediaWiki-Page-editing: Shift key - https://phabricator.wikimedia.org/T154275#2906108 (10Aklapper) [09:04:25] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2906109 (10Reception123) @Aklapper I will try that. I'm not sure how I could get the HTTP requests and responses? If it's a log on a server some of the other sysadmins ca... [09:08:24] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth: CentralAuth login attempt gives "No active login attempt is in progress for your session" - https://phabricator.wikimedia.org/T141482#2906111 (10Reception123) @Aklapper This could be similar to the problem I reported. Any ideas o... [09:08:44] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Rename user SSTflyer to Feminist - https://phabricator.wikimedia.org/T154262#2906112 (10Aklapper) 05Open>03Invalid That is handled at https://meta.wikimedia.org/wiki/Steward_requests/Username_changes and not in Phabricator, I think. :) Please request this... [09:09:41] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Rename user SSTflyer to Feminist - https://phabricator.wikimedia.org/T154262#2906115 (10Legoktm) 05Invalid>03Open @Aklapper: This is a request for a sysadmin to supervise the rename due to its size. Maybe it needs a #wikimedia-site-requests tag too or som... [09:10:58] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2906119 (10Aklapper) See info for [[ https://developer.mozilla.org/en-US/docs/Tools/Web_Console | Firefox ≥24 ]]; [[ http://msdn.microsoft.com/en-us/library/ie/dn255006 |... [09:12:09] 10MediaWiki-Authentication-and-authorization: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2906121 (10Reception123) @Aklapper Thank you. I will report once I get the error again (it doesn't always happen). [09:17:22] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth: CentralAuth login attempt gives "No active login attempt is in progress for your session" - https://phabricator.wikimedia.org/T141482#2906122 (10Reception123) I also point out we are now running REL1_28 , 1.28 and PHP 5.6.29 [09:26:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/329570 (owner: 10L10n-bot) [09:27:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329567 (owner: 10L10n-bot) [09:36:25] (03CR) 10Tpt: [C: 032] Fixes ProofreadPage parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/329059 (https://phabricator.wikimedia.org/T145724) (owner: 10Tpt) [09:38:00] (03Merged) 10jenkins-bot: Fixes ProofreadPage parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/329059 (https://phabricator.wikimedia.org/T145724) (owner: 10Tpt) [09:39:41] (03PS6) 10Tpt: Use ContentHandler for index pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/328543 [09:46:25] (03CR) 10Fomafix: "MediaWiki:Gadgetusage-default with the content" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329461 (owner: 10Fomafix) [09:49:35] 10MediaWiki-Page-editing: Shift key - https://phabricator.wikimedia.org/T154275#2906129 (10Trackinfo) I tested this also on Chrome with exactly the same results. This is what I believe is the classic editor. I am not doing anything fancy. I don't know anything about the visual editor. [09:58:49] 10Wikimedia-Site-requests: Temporary IP Cap Lift on mai.wiki - https://phabricator.wikimedia.org/T154278#2906130 (10biplabanand) [10:18:18] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Cannot load a saved translation, JS error from Sizzle at $section.data( 'source' ) - https://phabricator.wikimedia.org/T154279#2906155 (10Amire80) [10:18:35] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Cannot load a saved translation, JS error from Sizzle at $section.data( 'source' ) - https://phabricator.wikimedia.org/T154279#2906168 (10Amire80) p:05Triage>03High [10:18:50] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Cannot load a saved translation, JS error from Sizzle at $section.data( 'source' ) - https://phabricator.wikimedia.org/T154279#2906155 (10Amire80) [10:19:36] 10MediaWiki-Page-editing: Shift key - https://phabricator.wikimedia.org/T154275#2906019 (10TTO) Appears to be the same issue as {T154169}, which was noticed in an unspecified version of Internet Explorer. @Trackinfo: Have you only noticed this issue at English Wikipedia? Does it occur if you edit a page on anot... [10:42:42] 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Add CAPTCHA feature to Nuke extension - https://phabricator.wikimedia.org/T131975#2906189 (10IKhitron) Thanks a lot. [10:44:38] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 06Operations: Rename user TextworkerBot to VladiBot on ru.wiki - https://phabricator.wikimedia.org/T153602#2885305 (10Vladis13) I'm original requestor. I thought that for renaming should change the only one row in the database. Ok, if it is problematic then... [10:45:26] 10MediaWiki-Categories: hook to page links in categorypage.php - https://phabricator.wikimedia.org/T23463#2906195 (10TTO) 05Open>03Resolved a:03TTO This was done in {rMW8bf4496869181fd40f0284fade2ffaa5f234b39f} [10:45:38] 10MediaWiki-Categories: hook to page links in categorypage.php - https://phabricator.wikimedia.org/T23463#2906199 (10TTO) a:05TTO>03EBernhardson [10:52:07] 10MediaWiki-Vagrant, 10Citoid, 10VisualEditor, 15User-mobrovac: Replace upstart with systemd unit in ::zotero - https://phabricator.wikimedia.org/T154274#2906201 (10mobrovac) a:03mobrovac >>! In T154274#2905948, @bd808 wrote: > Probably should be updated to use `service::node` after {T154267} is complete... [10:52:23] (03PS1) 10Mobrovac: Zotero: Migrate to SystemD [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329599 (https://phabricator.wikimedia.org/T154274) [10:54:31] (03PS2) 10Mobrovac: service::node: Migrate to systemd [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329598 (https://phabricator.wikimedia.org/T154267) [10:55:34] 10MediaWiki-Core-Team, 10MediaWiki-Page-editing, 07I18n, 13Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#2906207 (10MaxBioHazard) 05Resolved>03Open https://ru.wikipedia.org/w/index.php?diff=8... [10:57:23] 10MediaWiki-Change-tagging, 05MW-1.28-release-notes, 13Patch-For-Review: Add a hook after updating change tags - https://phabricator.wikimedia.org/T118698#2906210 (10TTO) What more is there left to do here? Can this task be closed? [11:03:17] 10Wikimedia-General-or-Unknown: Most whatchlist emails don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2906224 (10Tacsipacsi) Bot edits is [[//phabricator.wikimedia.org/T150177|another problem]] (I would assume that if I get email about every minor edit, I also get about bot edits—but not; I h... [11:06:46] 10MediaWiki-User-blocking: False date in Category:Requests for Unblock - https://phabricator.wikimedia.org/T148648#2906226 (10TTO) 05Open>03Invalid It looks like Cyberbot issues are not tracked on Phabricator. If you wish to follow this up, I would suggest posting on Cyberpower678's talk page. [11:11:23] andre__, FlorianSW__, does https://codein.withgoogle.com/dashboard/tasks/4618439278723072/ look like a good publishable GCI task? [11:38:24] Hey, Reedy, can you please extend my timeline by 12 hours? I was unexpectedly busy last 2 days. I will finish my task today's evening. [11:43:29] (03PS3) 10Nemo bis: Add fr (French) language fallback for br, nrm, oc [core] - 10https://gerrit.wikimedia.org/r/329391 [12:02:21] 10MediaWiki-User-blocking: False date in Category:Requests for Unblock - https://phabricator.wikimedia.org/T148648#2906252 (10Cyberpower678) 05Invalid>03Open [12:21:03] 10MediaWiki-File-management, 06Commons, 06Multimedia: Make the defs for image formatting according to viewport from client hints - https://phabricator.wikimedia.org/T154283#2906272 (10jeblad) [12:30:29] 10MediaWiki-File-management, 06Commons, 06Multimedia: Make the defs for image formatting according to viewport from client hints - https://phabricator.wikimedia.org/T154283#2906291 (10jeblad) [12:32:33] (03PS1) 10Seb35: Version 0.3.0 [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/329601 [12:34:48] (03CR) 10jerkins-bot: [V: 04-1] Version 0.3.0 [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/329601 (owner: 10Seb35) [12:50:24] 10MobileFrontend, 06Reading-Web-Backlog: Temporary section collapsing code is leaking to other skins - https://phabricator.wikimedia.org/T152009#2835145 (10TheDJ) I noticed this too today. [13:11:16] Hi! [13:11:43] Has anyone connected to vagrant installation of mediawiki from outside the host computer,like laptop or ipad? [13:12:49] sirdevsalot: Should work. Just connect to your PC's ip [13:17:31] 10MediaWiki-Email, 10MediaWiki-Internationalization, 07Chinese-Sites, 07I18n: E-mail notifications (enotifs) are not sent in the recipient's user interface language - https://phabricator.wikimedia.org/T4592#2906308 (10Liuxinyu970226) @Cwek I'm not very sure what's the reason of your recently action... [13:17:58] ive tried this, cant connect to server. i also added ports to firwall exception, but still nothing [13:48:43] sirdevsalot, it won't work because Vagrant uses NAT Host-only adapter to create nfs shares :/ [13:49:07] :/ [13:49:14] the best option is to install a vnc server on your host machine and connect to it when you need a browser output ^^ [13:50:04] and if you wanna access the mediawiki source from outside, you can install samba and create a share ;) [13:50:35] Is samtar currently online? :) [13:50:57] no i dont need to access the source, just want to test with tablet [13:51:00] (03CR) 10Daniel Kinzler: [C: 04-1] "The commit message does not match the changes made by this patch." [core] - 10https://gerrit.wikimedia.org/r/329037 (owner: 10Mynk-96) [13:52:02] sirdevsalot, there is a easier approach then using a real device :D [13:52:30] what is? [13:53:06] Using dev tools in your browser like here: http://irly.li/55s7/1eviu7.gif [13:53:13] *http://i.rly.li/55s7/1eviu7.gif [13:54:06] And you can even rotate your screen and much more ^^ [13:56:19] cool stuff [14:00:57] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#2906321 (10FilipGCI) [14:01:00] 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata, 07Easy, and 2 others: Unhelpful error message on Special:MergeItems if items are already merged - https://phabricator.wikimedia.org/T130642#2906319 (10FilipGCI) 05Open>03Resolved Resolved. [14:01:57] 10MediaWiki-extensions-ContentTranslation, 07Easy, 03Google-Code-In-2016, 07I18n, and 3 others: the header text at Special:ContentTranslation and Special:ContentTranslationStats is the same - https://phabricator.wikimedia.org/T117191#2906322 (10FilipGCI) 05Open>03Resolved [14:03:20] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#2906324 (10Esc3300) [14:05:19] cause the vnc viewer deosnt rellay help in my case i dont think [14:05:43] because i want to test toucheventlisteners [14:06:14] and vnc just transmits my touches as mouseclicks on host [14:09:55] sirdevsalot which browser? And do you have direct access to the test machine? [14:10:22] what do you mean which browser? [14:10:50] im using chome dev tools to simulate touches now [14:12:05] i was just saying the remote connection doesnt work that way if I want to simulate touches, pinch to zoom, two finger rotate etc [14:12:07] With Chrome it should work as VNC does transmit your mouse hold normally [14:12:30] Ah, now I get what do you want to test. hm. [14:13:03] well, my best bet is to rent web hosting somewhere and upload it there. [14:13:08] well, easiest [14:13:16] not really [14:13:38] just setup a second environment outside vagrant on your host machine [14:13:52] (03PS2) 10Seb35: Version 0.3.0 [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/329601 [14:14:17] which will use vagrant as base htdocs directory [14:15:04] or you can try to forward ports from vboxnet0 to wlan0/eth0 (depending which adapter do you use to connect your machine to LAN) [14:15:49] If your test machine is using ubuntu then with ufw it's easy to do. Otherwise you have to use iptables ^^ [14:15:50] (03CR) 10jerkins-bot: [V: 04-1] Version 0.3.0 [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/329601 (owner: 10Seb35) [14:15:51] 06Editing-Analysis, 10Wikimedia-General-or-Unknown, 07Chinese-Sites: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2906329 (10Shizhao) >>! In T123313#2904565, @Aklapper wrote: >>>! In T123313#2904454, @Shizhao wrote: >> Thi... [14:23:03] 10MediaWiki-Configuration, 10MediaWiki-Patrolling: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2906330 (10MaxBioHazard) [14:26:14] 06Editing-Analysis, 10Wikimedia-General-or-Unknown, 07Chinese-Sites: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2906342 (10Liuxinyu970226) @Shizhao: > For 2, I think we should start from Export and Import: > * Suggest a... [14:29:04] (03PS3) 10Seb35: Version 0.3.0 [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/329601 [14:32:18] 10MediaWiki-Special-pages: Fatal exception of type MWException on en:Special:GlobalUserrights - https://phabricator.wikimedia.org/T154185#2903588 (10abian) Not only en.wikipedia.org, but all the Wikimedia projects... * * 10MediaWiki-Special-pages: Fatal exception of type MWException on all the Special:GlobalUserrights pages - https://phabricator.wikimedia.org/T154185#2906347 (10abian) [14:35:58] 10MediaWiki-Special-pages: Fatal exception of type MWException on all the Special:GlobalUserRights pages - https://phabricator.wikimedia.org/T154185#2903588 (10abian) [14:36:45] 10MediaWiki-Special-pages, 06Operations: Fatal exception of type MWException on all the Special:GlobalUserRights pages - https://phabricator.wikimedia.org/T154185#2903588 (10abian) [14:39:53] 10MediaWiki-Core-Team, 10MediaWiki-Page-editing, 07I18n, 13Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#2906350 (10Umherirrender) 05Open>03Resolved >>! In T85700#2906207, @MaxBioHazard wrote... [14:40:02] 10The-Wikipedia-Library: Improve behaviour of description and collections fields - https://phabricator.wikimedia.org/T149997#2906353 (10ThatAndromeda) [14:40:12] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2906355 (10ThatAndromeda) [14:40:15] 10The-Wikipedia-Library: Improve behaviour of description and collections fields - https://phabricator.wikimedia.org/T149997#2771377 (10ThatAndromeda) 05Open>03Resolved [14:44:00] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: [Task] Split EntityTitleLookup interface into actual "Title" and "Entity store" lookups - https://phabricator.wikimedia.org/T152498#2906356 (10WMDE-leszek) All p... [14:44:43] 10The-Wikipedia-Library: Reword application data (for sending) page - https://phabricator.wikimedia.org/T150291#2906357 (10ThatAndromeda) I want to clarify something here. When I say 'what is required', I mean that I'm displaying the information that each partner //requires editors to submit// in order to apply... [14:47:19] (03PS1) 10Umherirrender: Truncate for whole multibyte characters [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329609 [14:49:25] (03PS2) 10Umherirrender: Truncate for whole multibyte characters [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329609 [14:50:03] (03PS1) 10WMDE-Fisch: Get conflict results from diff3 [core] - 10https://gerrit.wikimedia.org/r/329610 (https://phabricator.wikimedia.org/T151320) [14:51:49] (03PS3) 10Umherirrender: Truncate for whole multibyte characters [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329609 (https://phabricator.wikimedia.org/T97883) [14:52:18] 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Reject summary for FlaggedRevs gets cut of badly for multibyte chars - https://phabricator.wikimedia.org/T97883#2906366 (10Umherirrender) a:03Umherirrender [14:57:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-11-15: Document JSON serialization format of ChangeOp serialization (used in data parameter of API action wbeditentity) - https://phabricator.wikimedia.org/T154286#2906367 (10WMDE-leszek) [14:58:20] sirdevsalot, use vagrant config --all [14:58:39] there should be an option about setting the IP to 0.0.0.0 or something like that which should allow you to access it outside [15:00:02] 10MediaWiki-Special-pages, 07Wikimedia-log-errors: Fatal exception of type MWException on all the Special:GlobalUserRights pages - https://phabricator.wikimedia.org/T154185#2906380 (10abian) [15:00:08] https://github.com/wikimedia/mediawiki-vagrant/blob/b072a101d106dd904546bda356f143c2a2bce000/lib/mediawiki-vagrant/settings/definitions.rb#L39 <<<< this one [15:08:43] 10MediaWiki-General-or-Unknown, 07I18n: {{int:nstab-talk}} should display the localized text instead of "⧼nstab-talk⧽" - https://phabricator.wikimedia.org/T153867#2906394 (10Umherirrender) 05Open>03Invalid https://pt.wikipedia.org/wiki/MediaWiki:Nstab-talk does not exists and cannot shown with {{int:}}. Th... [15:09:13] (03PS1) 10Esanders: Introduce eslint and bump dependencies [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/329614 [15:09:52] 10MediaWiki-Special-pages, 07Wikimedia-log-errors: Fatal exception of type MWException on all the Special:GlobalUserRights pages - https://phabricator.wikimedia.org/T154185#2906401 (10jcrespo) [15:09:55] (03PS2) 10Esanders: Introduce eslint and bump dependencies [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/329614 [15:09:56] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Chinese-Sites, 13Patch-For-Review, and 2 others: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2906399 (10jcrespo) [15:11:47] 10MediaWiki-JobQueue, 10MediaWiki-Recent-changes, 06ShoutWiki: Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28 - https://phabricator.wikimedia.org/T153849#2906403 (10Umherirrender) With MediaWiki 1.28 the deletion of rows in the recent changes was moved to the JobQueue [15:16:02] 10MediaWiki-Parser: Problem with templates returning an initial asterisk inside an #if - https://phabricator.wikimedia.org/T153848#2893000 (10Umherirrender) That sounds like T14974 and there was nothing changed in the last weeks For your problem on itwiki: Maybe there was a template changed to include a new #if... [15:27:18] 10MediaWiki-extensions-TemplateSandbox, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor - https://phabricator.wikimedia.org/T153367#2878418 (10Esanders) This is the API call we'll need to use: ``` { "action":... [15:27:53] (03PS1) 10BryanDavis: Update ::ruby for Jessie [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329617 (https://phabricator.wikimedia.org/T154273) [15:27:55] (03PS1) 10BryanDavis: Update ::browsertests for Jessie [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329618 (https://phabricator.wikimedia.org/T154273) [15:27:57] (03PS1) 10BryanDavis: Replace upstart with systemd unit in ::xvfb [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329619 (https://phabricator.wikimedia.org/T154273) [15:32:08] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: User-group autoreview should be in the implicitgroups (API output) if editor - https://phabricator.wikimedia.org/T153548#2883869 (10Umherirrender) Technical the group editor does not include the group autoreview Technical the group editor inc... [15:32:22] 10MediaWiki-General-or-Unknown: Deprecate ArticleRollbackComplete hook - https://phabricator.wikimedia.org/T154263#2906421 (10Cenarium) [15:34:19] 10MediaWiki-Change-tagging, 06Collaboration-Team-Triage, 10Notifications, 07Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#2906431 (10Cenarium) [15:34:21] 10MediaWiki-Change-tagging, 05MW-1.28-release-notes, 13Patch-For-Review: Add a hook after updating change tags - https://phabricator.wikimedia.org/T118698#2906429 (10Cenarium) 05Open>03Resolved Yes it can be closed, I'm doing so. [15:37:00] 10MediaWiki-Vagrant, 13Patch-For-Review, 15User-bd808: Replace upstart with systemd unit in ::xvfb - https://phabricator.wikimedia.org/T154273#2906432 (10bd808) a:03bd808 [15:40:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 15User-Daniel, 03Wikidata-Sprint-2016-11-15: Document JSON serialization format of ChangeOp serialization (used in data parameter of API action wbeditentity) - https://phabricator.wikimedia.org/T154286#2906434 (10daniel) [15:42:49] (03PS2) 10Cen.temp: Refactor maybeMakeEditReviewed to handle all self-reverts, avoid db hits [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/329545 (https://phabricator.wikimedia.org/T133442) [15:50:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2906444 (10WMDE-leszek) [15:53:18] (03CR) 10Daniel Kinzler: [C: 031] "Looks good to me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329610 (https://phabricator.wikimedia.org/T151320) (owner: 10WMDE-Fisch) [16:00:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Technical-Debt, 03Wikidata-Sprint-2016-11-15: Factor ChangeOps instantiation logic out of Api\EdtiEntity - https://phabricator.wikimedia.org/T154288#2906449 (10WMDE-leszek) [16:00:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Technical-Debt, 03Wikidata-Sprint-2016-11-15: Factor ChangeOps instantiation logic out of Api\EdtiEntity - https://phabricator.wikimedia.org/T154288#2906449 (10WMDE-leszek) [16:00:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 15User-Daniel, and 2 others: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2850119 (10WMDE-leszek) [16:13:54] 10The-Wikipedia-Library: Filtering is not working on some application review tabs - https://phabricator.wikimedia.org/T152983#2906486 (10ThatAndromeda) 05Open>03Resolved OK, I have this fixed locally now. As with a lot of things, the deploy is being held up until I set up a testing server and push the 1.8 ch... [16:18:39] 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, 07Mobile: Make links to xy.wikipedia automatically redirect to xy.m.wikipedia if user is on a mobile phone - https://phabricator.wikimedia.org/T154227#2906489 (10Dvorapa) [16:19:25] 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, 10MediaWiki-Redirects, 07Mobile: Make links to xy.wikipedia automatically redirect to xy.m.wikipedia if user is on a mobile phone - https://phabricator.wikimedia.org/T154227#2904582 (10Dvorapa) [16:20:16] 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, 10MediaWiki-Redirects, 07Mobile: Make links to xy.wikipedia automatically redirect to xy.m.wikipedia if user is on a mobile phone - https://phabricator.wikimedia.org/T154227#2904582 (10Dvorapa) >>! In T154227#2905422, @AlexMonk-WMF wrote: > If you want... [16:41:13] 10Wikimedia-Site-requests: Turn off patrolling in ruwiki - https://phabricator.wikimedia.org/T154285#2906494 (10MarcoAurelio) [16:42:54] 10MediaWiki-extensions-EducationProgram: Redirects to EducationProgram pages appear at BrokenRedirects page - https://phabricator.wikimedia.org/T154235#2906495 (10MarcoAurelio) As promised. The initial report [[ https://es.wikipedia.org/w/index.php?title=Usuario_discusi%C3%B3n:MarcoAurelio&oldid=95866035#WP:WMVE... [17:04:00] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#2906507 (10Lydia_Pintscher) [17:11:37] (03Draft1) 10Mschwarzer: Add Citolytics query prefix [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/329626 [17:21:04] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/dump_mapping.feature:3 features/boost_template_api.feature:3:7:11:15:19:23" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/329626 (owner: 10Mschwarzer) [17:22:16] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran phan static analysis and there were some errors: /srv/mediawiki-vagrant/mediawiki/extensions/CirrusSearch/includes/Search/ResultsTyp" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/329626 (owner: 10Mschwarzer) [17:37:40] Reedy, are you here? [17:42:19] 10MediaWiki-Parser, 10ArchCom-RfC, 07ArchCom-Has-shepherd: [RfC] Future of magic links - https://phabricator.wikimedia.org/T145604#2635698 (10Ningauble) >>! In T145604#2897174, @SlimVirgin wrote: > Could someone say what the status of this is, please? The status of the MediaWiki RfC (https://www.mediawiki.o... [17:46:57] Georggi: having trouble with that akismetik thing? I can help if needed. [17:48:05] Well, the only thing is as I understand, task requires to move Akimset.class.php to autoloader?(It's just it has like 5 or 6 classes in it) [17:49:38] That's the only thing that concerns me [17:50:57] 10MediaWiki-User-blocking: False date in Category:Requests for Unblock - https://phabricator.wikimedia.org/T148648#2906518 (10Aklapper) @Cyberpower678: Do you know whether this is a Cyberbot issue or not? [17:53:53] 10Wikimedia-Site-requests: Merge three different accounts into one - https://phabricator.wikimedia.org/T154290#2906519 (10Tulsi_Bhagat) [17:54:07] Georggi: use @notify Reedy [17:54:12] (03PS4) 10Georggi199: Converted AkismetKlik extension to new registration system [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [17:54:29] 10MediaWiki-User-blocking: False date in Category:Requests for Unblock - https://phabricator.wikimedia.org/T148648#2906531 (10Cyberpower678) >>! In T148648#2906518, @Aklapper wrote: > @Cyberpower678: Do you know whether this is a Cyberbot issue or not? I can't say for certain 46 Years ago was 1970, which is uni... [17:54:39] Well, I think the only thing left is to remove that require_once() [17:55:03] 10Wikimedia-Site-requests: Merge three different accounts into one - https://phabricator.wikimedia.org/T154290#2906532 (10Tulsi_Bhagat) [17:55:14] (03CR) 10jerkins-bot: [V: 04-1] Converted AkismetKlik extension to new registration system [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [17:55:26] (03CR) 10Filip: "Its not only registration system, lets name it for example "AkismetKlik cleanup"" [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [17:56:58] 10Wikimedia-Site-requests: Merge three different accounts into one - https://phabricator.wikimedia.org/T154290#2906519 (10Tulsi_Bhagat) [17:57:30] (03PS5) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [17:58:11] Come on... Line exceeds 100 characters; contains 101 characters [17:58:29] (03CR) 10jerkins-bot: [V: 04-1] AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [18:02:52] (03PS6) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [18:12:56] (03CR) 10MtDu: [C: 04-1] "@Reedy, not sure if we should just use manifest_version 1 here. Is that still important or not? You mentioned that that was just for like " (036 comments) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [18:14:32] Georggi: I posted some stuff. But we should let Reedy or legoktm take a look too. :) [18:16:14] manifest_veersion 2 was created by that script, when I tested with one, it said it was deprecated [18:16:25] Ok. [18:16:45] 10MediaWiki-Parser: Problem with templates returning an initial asterisk inside an #if - https://phabricator.wikimedia.org/T153848#2906538 (10Rotpunkt) @Umherirrender, as I have already written, I wrote an example of the problem here: * http://en.wikipedia.org/wiki/User:Rotpunkt/sandbox As you can see the proble... [18:17:17] And that first part inside if IS for back-compatability, in case it's earlier version, so it doesn't use extension.json in that case I think [18:27:48] (03CR) 10Filip: "Why deprecate MW<1.25? Its still used" (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [18:28:49] (03CR) 10Filip: "We should keep AkismetKlick.php, and support older MW versions." [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [18:31:01] 10MediaWiki-Page-editing: Shift key - https://phabricator.wikimedia.org/T154275#2906541 (10Trackinfo) I tried an edit on the fr.wikipedia and it did not produce the same error. Curiously it also did not produce the long term error I described (about the cursor outside of the text area). So apparently both of... [18:41:34] (03PS7) 10Georggi199: AkismetKlik extension cleanup [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) [18:50:39] (03PS1) 10Brian Wolff: Fix function documentation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329631 [18:50:58] (03CR) 10Brian Wolff: [C: 032] Fix function documentation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329631 (owner: 10Brian Wolff) [18:52:28] (03Merged) 10jenkins-bot: Fix function documentation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329631 (owner: 10Brian Wolff) [18:56:53] (03PS1) 10Brian Wolff: Fix CodeEditor JS error on CollaborationHub edit page [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329632 (https://phabricator.wikimedia.org/T151701) [18:57:19] (03CR) 10Brian Wolff: [C: 032] Fix CodeEditor JS error on CollaborationHub edit page [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329632 (https://phabricator.wikimedia.org/T151701) (owner: 10Brian Wolff) [18:57:34] 10MediaWiki-extensions-CollaborationKit, 13Patch-For-Review: CollaborationKit JS conflicts with WikiEditor extension - https://phabricator.wikimedia.org/T151701#2906568 (10Bawolff) 05Open>03Resolved [18:59:02] (03Merged) 10jenkins-bot: Fix CodeEditor JS error on CollaborationHub edit page [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329632 (https://phabricator.wikimedia.org/T151701) (owner: 10Brian Wolff) [19:02:28] 10Wikimedia-Site-requests: Merge three different accounts into one - https://phabricator.wikimedia.org/T154290#2906570 (10Dereckson) 05Open>03Invalid **Analysis** The accounts Tulsi Bhagat and Tulsi Aryan both contributed to Wikidata. All three contributed to Commons. A //merge// would mean here to edit t... [19:02:42] 10Wikimedia-Site-requests: Merge three different accounts into one - https://phabricator.wikimedia.org/T154290#2906572 (10Dereckson) a:03Dereckson [19:02:53] (03PS7) 10BryanDavis: Switch to Debian Jessie base image [vagrant] (jessie-migration) - 10https://gerrit.wikimedia.org/r/329209 (https://phabricator.wikimedia.org/T154130) [19:17:28] 10MediaWiki-Vagrant: Make vmware_fusion provider work with a Jessie base image - https://phabricator.wikimedia.org/T154292#2906580 (10bd808) [19:18:08] 10MediaWiki-Vagrant: Make hyperv provider work with a Jessie base image - https://phabricator.wikimedia.org/T154293#2906593 (10bd808) [19:18:43] 10MediaWiki-Vagrant: Make lxc provider work with a Jessie base image - https://phabricator.wikimedia.org/T154294#2906606 (10bd808) [19:19:27] 10MediaWiki-Vagrant: Make parallels provider work with a Jessie base image - https://phabricator.wikimedia.org/T154295#2906619 (10bd808) [19:20:02] 10MediaWiki-Vagrant: Make libvert provider work with a Jessie base image - https://phabricator.wikimedia.org/T154296#2906632 (10bd808) [19:34:06] (03PS1) 10Umherirrender: Add empty @metadata to i18n file for banana check [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/329633 [19:43:08] (03CR) 10Paladox: "recheck" [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326971 (owner: 10Pwirth) [19:47:43] 10MediaWiki-extensions-ContentTranslation, 10Parsoid, 07WorkType-Maintenance: "Main Page" is frequently shown when auto-adapting templates that use {{PAGENAME}}, instead of the actual page name - https://phabricator.wikimedia.org/T154297#2906646 (10Amire80) [19:50:26] hi all. how can I run the tests, that Cindy-the-browser-test-bot runs, locally in Vagrant? [19:51:04] (03PS2) 10Paladox: added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [19:52:24] (03CR) 10Paladox: "@Robert Vogel hi could you try re c+2 please?" [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [19:56:15] 10MediaWiki-Special-pages, 13Patch-For-Review: Easy date selection for Special:NewFiles - https://phabricator.wikimedia.org/T13836#2906663 (10Sn1per) or we could avoid the problem entirely by just having the page show an error if start date comes after end date. [19:57:21] (03PS1) 10Brian Wolff: Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) [19:57:36] (03CR) 10Brian Wolff: [C: 032] Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) (owner: 10Brian Wolff) [19:58:12] (03CR) 10Mglaser: [C: 032] added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [19:58:28] (03CR) 10jerkins-bot: [V: 04-1] Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) (owner: 10Brian Wolff) [19:59:13] (03CR) 10jerkins-bot: [V: 04-1] Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) (owner: 10Brian Wolff) [20:02:22] (03CR) 10Mglaser: [C: 032] "Paladox, should I try to submit?" [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [20:02:42] (03CR) 10Paladox: "Yes please." [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [20:05:02] (03PS2) 10Brian Wolff: Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) [20:06:10] (03CR) 10jerkins-bot: [V: 04-1] Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) (owner: 10Brian Wolff) [20:12:19] (03PS3) 10Brian Wolff: Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) [20:21:35] (03CR) 10Paladox: "@ Mglaser does force pushing this commit work? Ie checkout this patch on the REL1_27 branch and git push origin HEAD:refs/heads/REL1_27 or" [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [20:23:35] (03CR) 10MarkAHershberger: [C: 032] added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [20:26:35] (03CR) 10Aaron Schulz: [C: 032] Database: Avoid internal use of ignoreErrors() [core] - 10https://gerrit.wikimedia.org/r/239532 (owner: 10PleaseStand) [20:28:05] 04(no projects): Problem with JavaScript cache invalidation - https://phabricator.wikimedia.org/T154298#2906684 (10Nirmos) [20:28:12] (03CR) 10Aaron Schulz: [C: 032] "retry" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [20:29:40] 04(no projects): Problem with JavaScript cache invalidation - https://phabricator.wikimedia.org/T154298#2906684 (10Dereckson) Does that work when you add `?debug=true` to the URL? [20:30:40] (03CR) 10Seb35: "This is a proper implementation of the Composer extensions. A preliminary Work In Progress is available in I027251fabb32d6." [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/329601 (owner: 10Seb35) [20:32:22] (03CR) 10Seb35: "The "better-architectured change" mentionned here is" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/328347 (owner: 10Seb35) [20:33:04] (03CR) 10MarkAHershberger: "pardon me for stepping on toes.... I'll keep my hands to myself." [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [20:33:21] 04(no projects): Problem with JavaScript cache invalidation - https://phabricator.wikimedia.org/T154298#2906697 (10Nirmos) No. [20:38:29] (03Merged) 10jenkins-bot: Database: Avoid internal use of ignoreErrors() [core] - 10https://gerrit.wikimedia.org/r/239532 (owner: 10PleaseStand) [20:39:27] (03Merged) 10jenkins-bot: ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [20:39:29] (03Merged) 10jenkins-bot: ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) (owner: 10Catrope) [20:39:45] (03CR) 10jenkins-bot: ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 (owner: 10Catrope) [20:39:58] (03CR) 10jenkins-bot: ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) (owner: 10Catrope) [20:43:26] 10MediaWiki-General-or-Unknown: Use UTF-8 encoding instead of HTML entity for 'NO-BREAK SPACE' (U+00A0) - https://phabricator.wikimedia.org/T154300#2906715 (10Fomafix) [20:43:47] (03PS1) 10Fomafix: Use \xc2\xa0 instead of   or   [core] - 10https://gerrit.wikimedia.org/r/329639 (https://phabricator.wikimedia.org/T154300) [20:51:16] (03CR) 10jenkins-bot: Database: Avoid internal use of ignoreErrors() [core] - 10https://gerrit.wikimedia.org/r/239532 (owner: 10PleaseStand) [21:08:32] (03PS1) 10Ottomata: Properly use topic from kafkaMessage in meta [services/eventstreams] - 10https://gerrit.wikimedia.org/r/329640 [21:12:37] (03CR) 10Ottomata: [V: 032 C: 032] Properly use topic from kafkaMessage in meta [services/eventstreams] - 10https://gerrit.wikimedia.org/r/329640 (owner: 10Ottomata) [21:15:22] (03PS1) 10Ottomata: Update eventstreams to cec9064 [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/329641 [21:15:43] (03CR) 10Ottomata: [V: 032 C: 032] Update eventstreams to cec9064 [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/329641 (owner: 10Ottomata) [21:20:44] AaronSchulz: here? [21:25:59] (03CR) 10Mglaser: [C: 032] "Sry for the latency, am in a bar with no internet ;) I just tried, but no luck. Still the same error" [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [21:33:30] (03CR) 10Paladox: "i think the is related to the index as it is a coincidence that after applying a couple of upstream patches (after upgrading to gerrit 2.1" [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [21:34:51] 10MediaWikiChat: Fullscreen MediaWikiChat container isn't being styled - https://phabricator.wikimedia.org/T154261#2906737 (10UltrasonicNXT) hmm, I can't reproduce this on chrome [21:44:12] (03CR) 10Brian Wolff: [C: 032] Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) (owner: 10Brian Wolff) [21:45:32] (03Merged) 10jenkins-bot: Fix edit and delete js on multicolumn [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/329636 (https://phabricator.wikimedia.org/T149042) (owner: 10Brian Wolff) [22:13:53] @seen RoanKattouw [22:13:53] MtDu: RoanKattouw is in here, right now [22:14:08] RoanKattouw: Got time? I need help rebasing something. [22:14:18] or Reedy [22:16:15] MtDu: what kind of help do you need? Do you have a tricky conflict to resolve? [22:16:29] bd808: Just trying to rebase a pretty old patch. One moment. Let me link it [22:17:15] bd808: Trying to rebase https://gerrit.wikimedia.org/r/#/c/266181/. It needs a review. [22:18:25] 04(no projects): collapsible keeps switching/moving - https://phabricator.wikimedia.org/T154301#2906741 (101u) [22:18:31] MtDu: do you use git-review locally? [22:18:37] bd808: Yes [22:19:37] cool. So the basic way to rebase manually is something like: git review --download 266181; git rebase origin/master [22:20:19] if you are lucky then your local git will figure out the parts that are too tricky for gerrit's rebase [22:21:14] but if not it will leave you with conflict markers in the files "<<<<<<<", "=======", ">>>>>>>" and you have to edit the local files to resolve them [22:21:42] then you "git add" the fixes and finish with "git rebase --continue" [22:24:14] the tricky parts are usually the ones that give conflicts :S [22:24:29] 10MediaWiki-Cache, 07I18n: LocalisationCache seems to make too many system calls on every request - https://phabricator.wikimedia.org/T152371#2906753 (10Nemo_bis) 05Open>03Invalid So far the information we have is that perhaps we could go from 0.64 % of the time spent to a bit less; this is not "too many... [22:33:04] (03PS21) 10BryanDavis: Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [22:33:18] bd808: noooooooo [22:33:25] MtDu_: ^ rebased. [22:33:29] bd808: I was supposed to do for a GCI task. :( [22:33:34] heh. did I steal your fun? [22:33:36] Well part of it at least. [22:33:52] No. I just wanted to learn. My internet a bit slow fetching the changes. [22:34:57] bd808: did running git rebase origin/master do the job? [22:35:10] MtDu_: I can undo that and let you take a shot :) [22:35:18] Yes please. :) [22:35:20] there were 3 files that have real conflicts. [22:35:28] bd808: ^ [22:36:18] bd808: Sorry for the inconvenience. [22:36:26] no worries :) [22:36:27] bd808: but I really want to learn it. [22:37:48] 10LinkFilter, 10Social-Tools: Clean up CSS for LinkFilter - https://phabricator.wikimedia.org/T154061#2906774 (10SamanthaNguyen) [22:37:50] 10LinkFilter, 10Social-Tools: Get rid of !important declarations throughout LinkFilter/LinkFilter.css - https://phabricator.wikimedia.org/T154033#2906772 (10SamanthaNguyen) [22:40:00] 10MediaWiki-Email, 07Documentation: Minor bot edits don't trigger email notifications even with "E-mail me also for minor edits of pages" selected, and prevent subsequent notifications from any edit - https://phabricator.wikimedia.org/T40874#2906779 (10Nemo_bis) [22:40:03] 10MediaWiki-Email, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Minor edit emails go for Wikidata edits, but not for on-wiki bot edits - https://phabricator.wikimedia.org/T150177#2906781 (10Nemo_bis) [22:40:12] 10Wikimedia-General-or-Unknown: Most watchlist emails (enotifwatchlist) don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2906782 (10Nemo_bis) [22:41:02] (03PS22) 10BryanDavis: Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [22:41:22] (03CR) 10jerkins-bot: [V: 04-1] Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [22:41:58] (03CR) 10BryanDavis: "PS22 reverts the rebase I did in PS21" [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [22:54:21] 10Wikimedia-General-or-Unknown: Most watchlist emails (enotifwatchlist) don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2906806 (10Nemo_bis) All those edits were preceded by a minor edit and/or minor bot edit, are you sure you visited the page before those edits and after the previous edit (or... [22:54:34] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2858591 (10georgebarnick) Occurred when trying to view http://en.brickimedia.org/wiki/10255_Assembly_Square. Took 3 refreshes to access the page. Not sure if I'd call thi... [22:55:09] (03PS3) 10Isarra: Style custom edit forms a bit [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/325888 (https://phabricator.wikimedia.org/T148943) [22:59:03] (03CR) 10Cen.temp: Notify users of reviews (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [23:09:18] 06Brickimedia, 10MediaWikiChat: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2906813 (10UltrasonicNXT) I might suggest something more like ``` * >:-/ * >:/ * >:( * >:-( * >:O * >:-O NE24.gif * :) * :-) smile.gif ``` as it wo... [23:19:51] I am writing an extension. I can do either one extension or two extensions, one depending on the other. What should I prefer? [23:21:17] The first part is popup with rendered HTML pages. The second one is replacing every link A:X -> link A:X + popup B:X for namespaces A=>B as mapped in LocalSettings.php [23:22:29] bd808: Trying now. :) [23:22:55] one argument is that if I split into two extensions, I don't register an unnecessary hook which takes CPU time by processing every link in the page [23:23:22] porton: What are these said extensions for? [23:24:45] MtDu: I want to popup subwords a word in Hebrew Bible may be split into, for probing my hypothesis about secret codes in God's word Hebrew Bible [23:25:04] MtDu: But other people may find other applications [23:25:04] porton, That sounds interesting. Good luck! [23:25:55] MtDu: so, one or two extensions? [23:26:13] porton, I am not the one to ask about this. Perhaps Reedy or legoktm or bd808 can help you. [23:29:10] MtDu: My extension may be very useful for annotating long pages with short popup pages [23:29:18] porton: if you don't have concrete use cases for the popup extension other than as a part of your second extension I'd recommend just making one. [23:29:21] ... outside of Bible study [23:30:04] bd808: It may be probably useful in Wikipedia (after my bugs fixed) [23:30:39] bd808: these are not _concrete_ use cases, but some abstract use cases seem legible [23:31:27] bd808: well, no, maybe it is not good for Wikipedia, being a little too specialized [23:31:57] bd808: I yet doubt [23:32:12] my advice is based mostly on personal history. Making general purpose tools is difficult and you are more likely to do a better job on making your core idea work [23:32:37] if it turns out that you made something along the way that is useful for other purposes you can always extract it out [23:32:58] bd808: what do you mean by "can always extract it out"? [23:33:08] bd808: I see conflicts. So I go to those files and then fix them? Look for the arrows right? [23:33:48] MtDu: yes. look at the parts between the conflict makers and figure out what to keep and what to get rid of. [23:34:05] That may mean keeping bits of both sections [23:34:06] bd808: Do I understand correctly that you advise me make one not two extensions? [23:35:40] porton: by "extract it out" I mean that you could latter use https://en.wikipedia.org/wiki/Code_refactoring techniques to make your extension #1 from the code you that wrote for extension #2 [23:35:50] and then fix #2 to depend on #1 [23:36:23] (03CR) 10Isarra: [C: 032] "Problems appear to be unrelated to this patch. Styles work in target skins." [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/325888 (https://phabricator.wikimedia.org/T148943) (owner: 10Isarra) [23:36:33] Extension #2 is nearly finished (but not yet uploaded outside my PC). I am going to start the work on #1 [23:37:11] However there is some bugs in my code for #2 (which I do not know how to fix) [23:37:23] (it mostly works however) [23:37:41] (03Merged) 10jenkins-bot: Style custom edit forms a bit [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/325888 (https://phabricator.wikimedia.org/T148943) (owner: 10Isarra) [23:38:20] sounds like a good start then. Getting the code in public version control and asking for help might get you past your blockers. :) [23:38:40] See https://www.mediawiki.org/wiki/Review_queue if you are interested in Wikimedia deployment at some point [23:39:07] bd808: these are not blockers, as I've said "it mostly works" that is is usable despite of some bugs [23:42:48] bd808: What do I do once I git rebase --continue? [23:42:54] I need to git add all of them again? [23:43:28] git add the files you fixed and then git rebase --continue [23:43:33] 06Brickimedia, 10MediaWikiChat: If person sends multiple messages in a row, display the username and avatar only once in MediaWikiChat - https://phabricator.wikimedia.org/T146232#2906816 (10UltrasonicNXT) a:03UltrasonicNXT [23:44:30] bd808: Then git commit --all --amend and git review? [23:45:01] 06Brickimedia, 10MediaWikiChat: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2906817 (10SamanthaNguyen) I'm fine with that solution :) [23:45:02] the rebase should end up commit everything [23:45:20] git commit would make a new commit on top of the old one [23:45:21] so just git review? [23:45:24] bd808:^ [23:45:26] yeah [23:45:44] (03PS23) 10MtDu: Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [23:46:53] bd808: I think it's right. [23:46:57] bd808: Could you check? [23:47:39] * bd808 looks [23:47:50] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2906819 (10Glrx) getAvailableLanguages() should return lowercased langtags rath... [23:50:13] (03CR) 10jerkins-bot: [V: 04-1] Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [23:50:50] (03CR) 10BryanDavis: [C: 04-1] "A few issues from the manual rebase noted inline." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [23:53:04] git commit --all --amend now? [23:53:05] bd808:^ [23:53:20] MtDu: yes [23:53:53] (03PS24) 10MtDu: Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous) [23:55:20] * unicornisaurous is glad someone finally rebased that patch. thanks MtDu and bd808! [23:55:54] unicornisaurous: yw. MtDu did the hard parts. [23:56:13] now we just have to find someone who can review the actual substance of the change [23:58:12] anomie: ^? [23:59:39] (03CR) 10jerkins-bot: [V: 04-1] Add parameter to API modules to apply change tags to log entries [core] - 10https://gerrit.wikimedia.org/r/266181 (https://phabricator.wikimedia.org/T97720) (owner: 10Unicornisaurous)