[00:03:30] (03PS1) 10SamanthaNguyen: Making some minor changes like making license consistent, removing brickimedia-specific file, etc. [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 [00:03:32] (03PS1) 10SamanthaNguyen: Remove unnecessary script.sh file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329365 [00:04:56] (03CR) 10Jack Phoenix: [C: 032] Remove unnecessary script.sh file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329365 (owner: 10SamanthaNguyen) [00:05:08] (03PS2) 10SamanthaNguyen: Remove brickimedia-specific file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 [00:05:26] (03CR) 10SamanthaNguyen: "Er sorry, wrong commit message from earlier." [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 (owner: 10SamanthaNguyen) [00:16:45] (03CR) 10Jack Phoenix: [C: 032] Remove brickimedia-specific file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 (owner: 10SamanthaNguyen) [00:23:12] 10Dusk, 07Browser-Support-Internet-Explorer, 07Browser-Support-Opera: Get rid of support for IE6 and below and Opera 7 and below for Dusk skin - https://phabricator.wikimedia.org/T154199#2904162 (10SamanthaNguyen) 05Open>03Resolved a:03SamanthaNguyen [00:29:50] 10DeskMessMirrored, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer, 07Easy: Get rid of support for IE6 and below and Firefox 2 for DeskMessMirrored - https://phabricator.wikimedia.org/T154200#2904165 (10SamanthaNguyen) a:03SamanthaNguyen [00:29:57] 10Truglass, 07Browser-Support-Internet-Explorer, 07Browser-Support-Opera: Get rid of support for IE7 and below and Opera 9.5 and below for Truglass - https://phabricator.wikimedia.org/T154201#2904166 (10SamanthaNguyen) a:03SamanthaNguyen [00:37:08] rlot, [00:46:30] (03CR) 10SamanthaNguyen: [V: 032 C: 032] Fix my author name and make the author list alphabetical [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329056 (owner: 10SamanthaNguyen) [00:46:45] (03CR) 10SamanthaNguyen: [V: 032] Making licensing consistent throughout repo [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329060 (https://phabricator.wikimedia.org/T136563) (owner: 10SamanthaNguyen) [00:47:07] (03CR) 10SamanthaNguyen: [V: 032] Remove brickimedia-specific file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 (owner: 10SamanthaNguyen) [00:47:14] (03CR) 10SamanthaNguyen: [V: 032] Remove unnecessary script.sh file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329365 (owner: 10SamanthaNguyen) [00:49:23] p_d: You need some help or something? [00:50:38] MtDu, can you check this bower install output http://pastebin.com/XB566S1G thou there is no sign of error but the download of all these packages/things are not completed. [00:56:54] p_d: you can run the command again. :) [00:57:16] 10Phabricator, 06Project-Admins, 10Social-Tools: Organize Social-Tools project - https://phabricator.wikimedia.org/T154166#2904191 (10SamanthaNguyen) > Anybody can disable the workboard of a project. :) Oh okay cool! I just found that option after looking a little harder. I'll keep it enabled just in case t... [01:00:40] MtDu_, result- http://pastebin.com/cJm3txGf [01:01:53] p_d: check out #wikimedia-ed and ask ragesoss [01:06:09] MtDu_, okay [01:11:07] 10MediaWiki-History-or-Diffs, 06Multimedia: Provide source code diff view for Vector Graphics files (SVG) for file overwrites - https://phabricator.wikimedia.org/T154176#2904195 (10Josve05a) >>! In T154176#2903642, @Aklapper wrote: > I don't see anything [[ https://phabricator.wikimedia.org/project/profile/111... [01:12:09] (03PS1) 10Phantom42: Update outdated libraries [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 [01:17:48] 10Phabricator, 06Project-Admins, 10Social-Tools: Organize Social-Tools project - https://phabricator.wikimedia.org/T154166#2904196 (10SamanthaNguyen) Just got an OK from @ashley in PM, so I think I might disable it. I'm also considering whether or not to organize workboards instead by priorities like: * Unbr... [01:18:47] 10MediaWiki-Special-pages: Scrolling through user groups on Special:ActiveUsers makes list disappear - https://phabricator.wikimedia.org/T154210#2904198 (10GeoffreyT2000) [01:20:03] 06Security-Team: K4-713 access to Security Items - https://phabricator.wikimedia.org/T154211#2904213 (10Reedy) [01:22:00] 10MediaWiki-extensions-Quiz, 07Easy: Update node libraries in quiz extension - https://phabricator.wikimedia.org/T146021#2904226 (10Phantom42) a:03Phantom42 All libraries are now updated to the most recent versions. There are no more deprecated warnings during the installation. All tests still continue to pa... [01:22:56] 05Security: K4-713 access to Security Items - https://phabricator.wikimedia.org/T154211#2904228 (10Reedy) [01:24:59] (03CR) 10SamanthaNguyen: [C: 031] "Just tested it, it works! thanks for the patch :)" [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329308 (owner: 10Jack Phoenix) [01:27:01] (03CR) 10Jack Phoenix: [C: 032] Fix an E_NOTICE and an E_WARNING that were showing up on a brand new wiki w/o any categories [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329308 (owner: 10Jack Phoenix) [01:27:36] (03Merged) 10jenkins-bot: Fix an E_NOTICE and an E_WARNING that were showing up on a brand new wiki w/o any categories [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/329308 (owner: 10Jack Phoenix) [01:29:25] (03CR) 10MtDu: "I have verified the versions are the most up to date. However, should we be using 1.0.0 or 1.0.1 for grunt? 1.0.1 is developmental, 1.0.0 " [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (owner: 10Phantom42) [01:31:22] legoktm: around? Please review https://gerrit.wikimedia.org/r/329341 when you can. :) [01:34:51] (03PS2) 10Phantom42: Update outdated libraries [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) [01:35:54] (03CR) 10Phantom42: "You are right. Fixed that." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) (owner: 10Phantom42) [01:36:00] (03CR) 10jerkins-bot: [V: 04-1] Update outdated libraries [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) (owner: 10Phantom42) [01:42:52] (03CR) 10Phantom42: "Well, looks like it fails because of this issue: https://github.com/gruntjs/grunt/issues/1499" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) (owner: 10Phantom42) [01:45:10] (03CR) 10MtDu: "@phantom42, The solution to the linked github issue is to use 1.0.1. let's see what others say. :)" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) (owner: 10Phantom42) [01:46:31] (03PS3) 10Phantom42: Update outdated libraries [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) [01:49:34] (03CR) 10Phantom42: "I changed it back to 1.0.1" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) (owner: 10Phantom42) [01:52:33] (03PS4) 10Phantom42: Update outdated libraries [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/329366 (https://phabricator.wikimedia.org/T146021) [02:03:16] 10Internet-Archive, 10InternetArchiveBot: InternetArchiveBot adds unavailable links (robots.txt restricted?) - https://phabricator.wikimedia.org/T154212#2904238 (10Jhawkinson) a:03Cyberpower678 [02:15:30] (03Draft2) 10Yaron Koren: Added remote autocompletion within Special:Drilldown [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/329367 [02:19:25] (03CR) 10Yaron Koren: [C: 032] Added remote autocompletion within Special:Drilldown [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/329367 (owner: 10Yaron Koren) [02:20:32] (03Merged) 10jenkins-bot: Added remote autocompletion within Special:Drilldown [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/329367 (owner: 10Yaron Koren) [02:23:54] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 07Easy: Create intro/summary for Special:GlobalRenameUser - https://phabricator.wikimedia.org/T138919#2904264 (10Glaisher) >>! In T138919#2903742, @Aklapper wrote: > @Glaisher: Would this need to happen in https://phabricator.wikimedia.org/diffusion/ECAU/b... [02:40:32] (03PS3) 10Jack Phoenix: Making licensing consistent throughout repo [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329060 (https://phabricator.wikimedia.org/T136563) (owner: 10SamanthaNguyen) [02:40:41] (03CR) 10Jack Phoenix: [V: 032 C: 032] Making licensing consistent throughout repo [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329060 (https://phabricator.wikimedia.org/T136563) (owner: 10SamanthaNguyen) [02:40:58] (03PS3) 10Jack Phoenix: Remove brickimedia-specific file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 (owner: 10SamanthaNguyen) [02:41:01] (03CR) 10Jack Phoenix: [V: 032 C: 032] Remove brickimedia-specific file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329364 (owner: 10SamanthaNguyen) [02:41:23] (03PS2) 10Jack Phoenix: Remove unnecessary script.sh file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329365 (owner: 10SamanthaNguyen) [02:41:26] (03CR) 10Jack Phoenix: [V: 032 C: 032] Remove unnecessary script.sh file [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329365 (owner: 10SamanthaNguyen) [02:43:36] (03PS1) 10Cen.temp: Support limited anon notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329374 [02:46:49] (03PS2) 10Jack Phoenix: Author list updates and sorting [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329056 (owner: 10SamanthaNguyen) [02:47:18] (03CR) 10Jack Phoenix: [V: 032 C: 032] Author list updates and sorting [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/329056 (owner: 10SamanthaNguyen) [02:55:45] 10MediaWiki-Parser, 13Patch-For-Review: ISBN, RFC and PMID "magic links" might support non-breaking spaces ( ) too - https://phabricator.wikimedia.org/T30950#325554 (10MZMcBride) Is this task resolved? [02:56:01] 10MediaWiki-Parser, 13Patch-For-Review: Magic links are inconsistent with common parser rules - https://phabricator.wikimedia.org/T31025#2904276 (10MZMcBride) Is this task resolved? [02:58:36] 10MediaWiki-Special-pages, 13Patch-For-Review: linkify ISBN: foo and ISBN: foo, bar, etc. beside ISBN foo_bar - https://phabricator.wikimedia.org/T14900#176460 (10MZMcBride) >>! In T14900#842273, @cscott wrote: > Hm. Magic links are the red-headed stepchildren of the parser. They are latin-alphabet specific... [03:00:21] 10MediaWiki-General-or-Unknown: Automatic DOI linking, similar to PMID, RFC, and ISBN - https://phabricator.wikimedia.org/T22832#251457 (10MZMcBride) I think we should close this task. [03:03:58] 10MediaWiki-Special-pages: Special:LinkSearch should support magic links - https://phabricator.wikimedia.org/T55348#550086 (10MZMcBride) We now have tracking categories for magic links (e.g., ), with the intention of eventually removing magic li... [03:06:53] 10MediaWiki-User-blocking, 06Community-Tech, 06Support-and-Safety: Add cookie when blocking anonymous users - https://phabricator.wikimedia.org/T152462#2904307 (10Ladsgroup) We badly need this for fawiki returning vandals. I'm not super familiar with the code base but is there anything I can do to help? [03:09:48] 10BlueSpice, 07I18n: [[MediaWiki:Bs-usermanager-user-deleted/en]] i18n issue - https://phabricator.wikimedia.org/T154170#2902993 (10Liuxinyu970226) >>! In T154170#2903813, @MtDu wrote: > Is this necessary? The message says $1 users.. How can we add gender if there are multiple users? i.e. for Bs-usermanager-u... [03:16:51] 10MediaWiki-extensions-Newsletter, 06Community-Liaisons, 05Goal: Goal: Deploy Newsletter extension in Wikimedia - https://phabricator.wikimedia.org/T110170#2904312 (10ResMar) Yes, please do. There is still one thing I want to see, which is what the notification will look like when a new issue is announced.... [03:19:21] 10MediaWiki-User-blocking, 06Community-Tech, 06Support-and-Safety: Add cookie when blocking anonymous users - https://phabricator.wikimedia.org/T152462#2904314 (10MusikAnimal) >>! In T152462#2904307, @Ladsgroup wrote: > We badly need this for fawiki returning vandals. I'm not super familiar with the code bas... [03:22:33] FlorianSW_: Up early? ;) [03:31:43] (03PS5) 10MtDu: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) [03:34:56] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages, 07Chinese-Sites, 07I18n: [[MediaWiki:And/fr]] uses encoded leading space (wrong for some East Asian languages) - https://phabricator.wikimedia.org/T132307#2904316 (10Liuxinyu970226) >>! In T132307#2903847, @Verdy_p wrote: >>>! In T132307#2416577, @... [03:42:06] (03PS6) 10MtDu: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) [03:42:45] 06Brickimedia, 10Refreshed, 07Software-Licensing: What is the license? - https://phabricator.wikimedia.org/T136563#2904320 (10SamanthaNguyen) 05Open>03Resolved [03:45:46] 07Design, 10MediaWiki-Interface, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Backgrounds of framed images should be white, not grey - https://phabricator.wikimedia.org/T154077#2904322 (10kaldari) Now that the patch is merged, the custom CSS on English Wikipedia should be removed on Jan... [03:51:09] (03CR) 10jerkins-bot: [V: 04-1] Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [03:51:44] (03PS7) 10MtDu: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) [03:52:55] (03PS3) 10Reedy: Add composer.json including phpcs package [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/305676 (https://phabricator.wikimedia.org/T134933) (owner: 10Devirk) [03:53:50] (03CR) 10jerkins-bot: [V: 04-1] Add composer.json including phpcs package [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/305676 (https://phabricator.wikimedia.org/T134933) (owner: 10Devirk) [04:01:44] (03CR) 10jerkins-bot: [V: 04-1] Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:02:49] (03PS8) 10MtDu: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) [04:06:56] (03PS2) 10Cen.temp: Support limited anon notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329374 [04:13:15] (03CR) 10jerkins-bot: [V: 04-1] Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:14:33] legoktm: Around? [04:14:46] (03PS9) 10MtDu: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) [04:22:58] 10MediaWiki-User-preferences, 07I18n: Change "Real name" to "Display name" - https://phabricator.wikimedia.org/T154177#2904327 (10Amire80) Nice question, but way out of the scope of this task. This task is ONLY about the label of the preference. Should be discussed separately. [04:28:11] (03PS10) 10Reedy: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:30:39] (03PS11) 10Reedy: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:31:45] go to bed Reedy [04:31:50] (03CR) 10jerkins-bot: [V: 04-1] Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:32:40] (03PS12) 10Reedy: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:36:17] (03CR) 10Reedy: [C: 032] Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:40:40] 10MediaWiki-extensions-ContentTranslation, 03Language-2017 Sprint 1, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: Reorganize the CX classes using OOJS - https://phabricator.wikimedia.org/T152586#2904332 (10santhosh) >>! In T152586#2899123, @Nemo_bis wrote: > I... [04:43:20] (03CR) 10Reedy: [C: 04-1] Converted AkismetKlik extension to new registration system (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329242 (https://phabricator.wikimedia.org/T154107) (owner: 10Georggi199) [04:46:02] 10MediaWiki-extensions-CodeMirror: Integrate a spell checker to CodeMirror - https://phabricator.wikimedia.org/T95104#2904334 (10Pastakhov) Yes, you are right. Have no idea why it still does not work in CodeMirror in this case... [04:46:57] (03Merged) 10jenkins-bot: Added a composer.json file in order to lint the PHP [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/329236 (https://phabricator.wikimedia.org/T154147) (owner: 10MtDu) [04:48:04] 10MediaWiki-extensions-Other, 03Google-Code-In-2016, 13Patch-For-Review: Lint the PHP in the LifeWeb Extension - https://phabricator.wikimedia.org/T154147#2904336 (10MtDu) 05Open>03Resolved a:03MtDu Patch has been merged. Thus closing as resolved. :) [05:06:27] 10MediaWiki-HTMLForm, 10UI-Standardization: multiselect should allow some options to be disabled - https://phabricator.wikimedia.org/T154167#2902876 (10Volker_E) @Ladsgroup Sounds like a duplicate of T153927 [05:06:39] (03PS1) 10SamanthaNguyen: Organize CSS, deleting stylesheets, remove old IE support [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/329383 (https://phabricator.wikimedia.org/T154200) [05:08:22] (03PS2) 10SamanthaNguyen: Organize CSS, deleting stylesheets, remove old IE support [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/329383 (https://phabricator.wikimedia.org/T154200) [05:10:18] 07Design, 10MediaWiki-HTMLForm, 13Patch-For-Review: OOjs UI should allow `disabled` to contain an array - https://phabricator.wikimedia.org/T153927#2904348 (10Ladsgroup) [05:10:21] 10MediaWiki-HTMLForm, 10UI-Standardization: multiselect should allow some options to be disabled - https://phabricator.wikimedia.org/T154167#2904350 (10Ladsgroup) [05:10:44] 07Design, 10MediaWiki-HTMLForm, 13Patch-For-Review: OOjs UI should allow `disabled` to contain an array - https://phabricator.wikimedia.org/T153927#2895238 (10Ladsgroup) Thanks @Volker_E for pointing out to this task [05:16:38] 10UI-Standardization, 06Multimedia, 10TimedMediaHandler-Player, 13Patch-For-Review: Align Wikimedia's video/audio player with WikimediaUI color palette - https://phabricator.wikimedia.org/T154072#2900239 (10Volker_E) Screenshots are not clear, there are other visual changes between the two aside of the col... [05:22:45] 10MediaWiki-Cache, 10MediaWiki-General-or-Unknown: Localisation cache tmp file assumes tmp path is unique - https://phabricator.wikimedia.org/T154215#2904354 (10Bertvandepoel) [05:24:02] (03PS1) 10SamanthaNguyen: Remove support for (03PS1) 10SamanthaNguyen: Fix my author name [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/329385 [05:36:25] (03CR) 10SamanthaNguyen: [C: 032] Fix my author name [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/329385 (owner: 10SamanthaNguyen) [05:38:13] (03Merged) 10jenkins-bot: Fix my author name [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/329385 (owner: 10SamanthaNguyen) [05:41:06] 10MediaWiki-extensions-PageAssessments, 06Community-Tech: Add support for task forces to PageAssessments - https://phabricator.wikimedia.org/T154216#2904383 (10kaldari) [05:41:16] 10MediaWiki-extensions-PageAssessments, 06Community-Tech: Add support for task forces to PageAssessments - https://phabricator.wikimedia.org/T154216#2904369 (10kaldari) p:05Triage>03Normal [05:41:51] (03PS1) 10Kaldari: Add parent and banner fields to projects table [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/329386 (https://phabricator.wikimedia.org/T154216) [05:49:46] (03CR) 10VolkerE: "@Bartosz Yes, you're right. Thanks @Jo12bar for your contribution!" [core] - 10https://gerrit.wikimedia.org/r/329234 (https://phabricator.wikimedia.org/T148457) (owner: 10Jo12bar) [05:50:57] 07Design, 06Brickimedia, 10Refreshed: Refreshed skin doesn't automatically include WikiFont git submodule - https://phabricator.wikimedia.org/T134683#2904389 (10SamanthaNguyen) 05stalled>03declined Right, I'm closing this as DECLINED. Installing WikiFont only takes a few steps. :) [06:03:29] (03PS3) 10Ladsgroup: Convert Special:Nuke prompt form to OOUI [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/328850 (https://phabricator.wikimedia.org/T153988) [06:04:09] (03CR) 10Ladsgroup: "It now uses HTMLForm" [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/328850 (https://phabricator.wikimedia.org/T153988) (owner: 10Ladsgroup) [06:21:02] 07Design, 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Special:Nuke — space separation between select toggles and the delete button - https://phabricator.wikimedia.org/T145346#2627230 (10Ladsgroup) I think this should be closed now. Right? [06:42:13] 06Brickimedia, 10Snippet: Slowly deprecate and/or archive Snippets extension in favour of TextExtracts - https://phabricator.wikimedia.org/T154220#2904437 (10SamanthaNguyen) [06:43:48] 06Brickimedia, 10Snippet: Slowly deprecate and/or archive Snippets extension in favour of TextExtracts - https://phabricator.wikimedia.org/T154220#2904437 (10SamanthaNguyen) [06:56:58] 06Editing-Analysis, 10Wikimedia-General-or-Unknown, 07Chinese-Sites: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2904454 (10Shizhao) >>! In T123313#2903638, @Aklapper wrote: > @Shizhao: Why did you add #Wikisource (lookin... [06:57:27] 10MediaWiki-Export-or-Import, 06Editing-Analysis, 10Wikimedia-General-or-Unknown, 07Chinese-Sites: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2904455 (10Shizhao) [07:03:19] 07Chinese-Sites, 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2904468 (10Shizhao) >>! In T152159#2903654, @Aklapper wrote: > @Shizhao: This task is related to //any// site - why did you a... [07:07:42] 10UI-Standardization, 07Easy, 03Google-Code-In-2016, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Mediawiki UI: Inputs: Explicitly define text color - https://phabricator.wikimedia.org/T148457#2904469 (10Prtksxna) >>! In T148457#2903470, @matmarex wrote: > @Aklapper The GCI task can b... [07:10:40] (03CR) 10Prtksxna: [C: 031] "Looks good. Need to test once before +2ing." [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [07:32:12] (03CR) 10Legoktm: [C: 032] Replaced deprecated "Linker::link" [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/329342 (https://phabricator.wikimedia.org/T149346) (owner: 10Filip) [07:33:19] (03Merged) 10jenkins-bot: Replaced deprecated "Linker::link" [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/329342 (https://phabricator.wikimedia.org/T149346) (owner: 10Filip) [07:39:15] (03CR) 10Legoktm: [C: 031] "Nice work, just going to amend the commit message a bit." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329341 (https://phabricator.wikimedia.org/T153505) (owner: 10MtDu) [07:39:31] (03PS2) 10Legoktm: EditPage: Avoid use of &$this in hooks [core] - 10https://gerrit.wikimedia.org/r/329341 (https://phabricator.wikimedia.org/T153505) (owner: 10MtDu) [07:39:51] (03CR) 10Legoktm: [C: 032] EditPage: Avoid use of &$this in hooks [core] - 10https://gerrit.wikimedia.org/r/329341 (https://phabricator.wikimedia.org/T153505) (owner: 10MtDu) [07:47:37] (03Merged) 10jenkins-bot: EditPage: Avoid use of &$this in hooks [core] - 10https://gerrit.wikimedia.org/r/329341 (https://phabricator.wikimedia.org/T153505) (owner: 10MtDu) [07:49:56] 10MediaWiki-extensions-Nuke: add nuke to Special:Block - https://phabricator.wikimedia.org/T34179#365286 (10Ladsgroup) I think adding a link when the block has been successfully made is enough. I made a edit request in [[https://en.wikipedia.org/wiki/MediaWiki_talk:Blockipsuccesstext#Protected edit request on 28... [07:56:59] (03CR) 10jenkins-bot: EditPage: Avoid use of &$this in hooks [core] - 10https://gerrit.wikimedia.org/r/329341 (https://phabricator.wikimedia.org/T153505) (owner: 10MtDu) [08:06:58] 10MediaWiki-Language-converter, 07Chinese-Sites, 07RfC: A generalized language conversion engine - https://phabricator.wikimedia.org/T17161#2904491 (10Beeyan) Such an interesting idea, but it'll be hard for language that don't even have a space in their writing. Javanese has several writings, two of them are... [08:16:26] (03PS1) 10Ladsgroup: Ask for confirmation when nuking [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/329387 (https://phabricator.wikimedia.org/T131975) [08:16:50] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2904495 (10QuimGil) [08:17:42] 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Add CAPTCHA feature to Nuke extension - https://phabricator.wikimedia.org/T131975#2184772 (10Ladsgroup) I added a patch which makes Nuke asks for confirmation. CAPTCHA would be too much as pointed out by @Jackmcbarn [08:17:54] (03CR) 10jerkins-bot: [V: 04-1] Ask for confirmation when nuking [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/329387 (https://phabricator.wikimedia.org/T131975) (owner: 10Ladsgroup) [08:20:34] (03PS1) 10Nemo bis: Add release notes for recent language fallback additions [core] - 10https://gerrit.wikimedia.org/r/329388 [08:22:07] 10MediaWiki-extensions-General-or-Unknown: Allow default value for PATH variable in wfShellExec - https://phabricator.wikimedia.org/T136575#2904509 (10Legoktm) I've posted builds for trusty and xenial on my test ppa: https://launchpad.net/~legoktm/+archive/ubuntu/legoktm-test/ if you want to test it on those pla... [08:26:33] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Verify https://www.mediawiki.org/wiki/Extension:Newsletter - https://phabricator.wikimedia.org/T154223#2904510 (10QuimGil) [08:29:21] 10MediaWiki-extensions-CLDR, 06Language-Team, 10Wikidata, 07Chinese-Sites, 07I18n: Add English names for languages which don't yet have one - https://phabricator.wikimedia.org/T151269#2904524 (10Liuxinyu970226) @Lydia_Pintscher Is Shizhao's action above valid? The main topic of this task looks like about... [08:44:55] 10MediaWiki-Internationalization, 10Wikidata, 07I18n: Chechen style for lists requires "a" after every list item - https://phabricator.wikimedia.org/T154030#2899105 (10Liuxinyu970226) If this means that in Chechen, we should also add the word "and" after the last item of an array-like sentense, then why can'... [08:52:21] (03PS1) 10Nemo bis: Add fr (French) language fallback for br, nrm, oc [core] - 10https://gerrit.wikimedia.org/r/329391 [08:56:15] (03PS1) 10Nemo bis: Add language fallback from eu (Basque) to es (Spanish) [core] - 10https://gerrit.wikimedia.org/r/329393 [08:57:00] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Verify https://www.mediawiki.org/wiki/Extension:Newsletter contains up-to date information - https://phabricator.wikimedia.org/T154223#2904536 (10Peachey88) [08:58:20] (03CR) 10jerkins-bot: [V: 04-1] Add fr (French) language fallback for br, nrm, oc [core] - 10https://gerrit.wikimedia.org/r/329391 (owner: 10Nemo bis) [08:59:48] (03PS2) 10Nemo bis: Add fr (French) language fallback for br, nrm, oc [core] - 10https://gerrit.wikimedia.org/r/329391 [09:04:08] 10MediaWiki-extensions-Interwiki, 10Wikimedia-Site-requests: Update interwiki map, following edit - https://phabricator.wikimedia.org/T154225#2904553 (10Billinghurst) [09:10:59] 06Editing-Analysis, 10Wikimedia-General-or-Unknown: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2904565 (10Aklapper) >>! In T123313#2904454, @Shizhao wrote: > This problem is because user who import content with wrong times... [09:16:24] 10MediaWiki-Internationalization, 10Wikidata, 07I18n: Chechen style for lists requires "a" after every list item - https://phabricator.wikimedia.org/T154030#2899105 (10TTO) >>! In T154030#2904533, @Liuxinyu970226 wrote: > If this means that in Chechen, we should also add the word "and" after the last item of... [09:24:50] (03PS1) 10Nemo bis: [WIP] Add language fallback to tl (Tagalog/Filipino) for several languages [core] - 10https://gerrit.wikimedia.org/r/329396 [09:25:12] (03PS2) 10Nemo bis: [WIP] Add language fallback to tl (Tagalog/Filipino) for several languages [core] - 10https://gerrit.wikimedia.org/r/329396 [09:28:21] 10MediaWiki-extensions-Newsletter: Subscribing users to newsletters automatically when certain conditions are matched - https://phabricator.wikimedia.org/T154228#2904593 (10QuimGil) [09:29:07] 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Add CAPTCHA feature to Nuke extension - https://phabricator.wikimedia.org/T131975#2904609 (10IKhitron) @Ladsgroup, please, add the number of deleted pages into the confirmation message. The problem is almost always when somebody wants to delete five pages but de... [09:34:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/329394 (owner: 10L10n-bot) [09:39:25] 10MediaWiki-Vagrant, 06Analytics-Kanban: Enable 'analytics_cluster' role on Labs instance - https://phabricator.wikimedia.org/T151861#2904610 (10Gehel) For the elasticsearch side, we use the role "elasticsearch::cirrus", which simply includes the role "elasticsearch::common". If you are just experimenting, you... [09:52:37] Reedy: Are you here? [09:54:46] jayvdb: Hi! In "Pywikibot: Add missing unit tests for pywikibot library" How much functions/lines i need to add? [09:59:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/329408 (owner: 10L10n-bot) [10:04:57] 06Editing-Analysis, 10Wikimedia-General-or-Unknown: Some revisions on Chinese Wikisource have timestamps from January 1970 and January 2001 - https://phabricator.wikimedia.org/T123313#2904625 (10Liuxinyu970226) >>! In T123313#2904565, @Aklapper wrote: >>>! In T123313#2904454, @Shizhao wrote: >> This problem is... [10:05:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/329416 (owner: 10L10n-bot) [10:06:47] 10MediaWiki-extensions-Newsletter, 06Community-Liaisons, 05Goal: Goal: Deploy Newsletter extension in Wikimedia - https://phabricator.wikimedia.org/T110170#2904627 (10Qgil) @ResMar , thank you for these very reasonable questions and suggestions. @01tonythomas' reply made me think that we need to {T154222} as... [10:08:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329415 (owner: 10L10n-bot) [10:17:52] rlot: I am, kinda [10:18:07] (03CR) 10Reedy: [C: 032] Add release notes for recent language fallback additions [core] - 10https://gerrit.wikimedia.org/r/329388 (owner: 10Nemo bis) [10:18:39] Reedy: Hmm, will there be more tasks? [10:18:58] Are we running a bit low? [10:19:06] Reedy: Yes [10:19:16] There's certainly more ContentHandler stuff to be done [10:19:38] Reedy: There's no much code tasks [10:20:08] andre__: ^ [10:26:05] (03Merged) 10jenkins-bot: Add release notes for recent language fallback additions [core] - 10https://gerrit.wikimedia.org/r/329388 (owner: 10Nemo bis) [10:26:48] (03PS1) 10Fomafix: Convert PHP syntax from array() to [] [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329443 [10:34:32] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2904631 (10PhiLiP) I'm glad that this issue is brought back to table by someone... [10:35:47] FlorianSW: Hmm [10:36:08] FlorianSW: I'm making GCI task " [10:36:08] Don't show the "Go to top" icon for iOS users" [10:36:15] And its no longer showing [10:36:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] ApiSandbox: Display params as JSON on request page (032 comments) [core] - 10https://gerrit.wikimedia.org/r/328900 (https://phabricator.wikimedia.org/T130501) (owner: 10Esanders) [10:37:45] FlorianSW: Or no [10:37:53] nvm [10:38:21] (03PS3) 10Bartosz Dziewoński: ApiSandbox: Display params as JSON on request page [core] - 10https://gerrit.wikimedia.org/r/328900 (https://phabricator.wikimedia.org/T130501) (owner: 10Esanders) [10:38:26] (03CR) 10Bartosz Dziewoński: [C: 031] ApiSandbox: Display params as JSON on request page [core] - 10https://gerrit.wikimedia.org/r/328900 (https://phabricator.wikimedia.org/T130501) (owner: 10Esanders) [10:39:28] 10MediaWiki-Search, 06Discovery, 06Discovery-Search: "Did you mean . . ." search feature to automatically spellcheck all search terms - https://phabricator.wikimedia.org/T2974#2904635 (10TTO) >>! In T2974#983305, @Nemo_bis wrote: > Advanced search features are what Lucene, ElasticSearch etc. are for; it's no... [10:39:55] FlorianSW: Hmm, looks like its not working on AgentSwitchers [10:40:04] (03CR) 10jenkins-bot: Add release notes for recent language fallback additions [core] - 10https://gerrit.wikimedia.org/r/329388 (owner: 10Nemo bis) [10:40:06] jdlrobson: ? [10:40:29] 10MediaWiki-extensions-CLDR, 06Language-Team, 10Wikidata, 07Chinese-Sites, 07I18n: Add English names for languages which don't yet have one - https://phabricator.wikimedia.org/T151269#2904636 (10Lydia_Pintscher) It doesn't hurt I guess :) [10:40:50] 10MediaWiki-User-preferences, 07I18n: Change "Real name" to "Display name" - https://phabricator.wikimedia.org/T154177#2904637 (10Base) Ah I think I have skipped the last paragraph, sorry. Well, in that case the change of the label itself makes sense to me, though it is not important a change. [10:41:15] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2904638 (10Qgil) Thank you for *your* partience, @01tonythomas! [10:41:38] 10MediaWiki-General-or-Unknown: Provide an easy way to localize links to some projects' main pages on the sidebar - https://phabricator.wikimedia.org/T154181#2904639 (10Base) @Amire80 I think it is connected to that language conjugation stuff you were doing, is it not? [10:43:48] 10MediaWiki-General-or-Unknown: Provide an easy way to localize links to some projects' main pages on the sidebar - https://phabricator.wikimedia.org/T154181#2904641 (10Base) Ah, no, my bad. I thought it is about names of all the wikis, like the ones used in Echo. Well but anyway bringing a l10n guy here is a go... [10:43:50] (03PS1) 10Fomafix: Use setPageTitle() instead of setPagetitle() [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329445 [10:47:39] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Add AbuseFilter integration to Extension:Newsletter - https://phabricator.wikimedia.org/T132022#2904642 (10Qgil) Could someone post an update about the situation of this task? I could not tell by reading the comments in the patch. I am not even sure about... [10:47:51] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Newsletter: Should newsletter be storing in data both in contenthandler and in the database - https://phabricator.wikimedia.org/T153532#2904643 (1001tonythomas) 05Open>03Invalid >>! In T153532#2884875, @Legoktm wrote: > In general storing data from the pag... [10:48:58] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: Full Zoom Feature in Media Viewer - https://phabricator.wikimedia.org/T77151#2904645 (10matmarex) [10:49:00] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: Basic Zoom for Media Viewer - https://phabricator.wikimedia.org/T77423#2904646 (10matmarex) [10:49:07] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2904649 (1001tonythomas) 05Resolved>03Open Looks like we got more subtasks coming in! [10:49:23] 10MediaWiki-extensions-Translate: Investigate ways to ease the marking and the deletion of translation units - https://phabricator.wikimedia.org/T154183#2904651 (10Base) > There's a gadget in Wikidata that they use to tag items for deletion. I > shall have a look at it and see if its use could be extended to Met... [10:49:35] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2904652 (1001tonythomas) [10:49:37] 10MediaWiki-extensions-Newsletter: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2904653 (1001tonythomas) [10:50:08] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: Improve the Media Viewer UI on tablets (zoom/scroll) - https://phabricator.wikimedia.org/T77620#2904654 (10matmarex) [10:54:42] (03CR) 10Bartosz Dziewoński: "Whenever you introduce a cache with no cache invalidation, you accept that the information will in some circumstances be outdated… I'm not" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/329213 (owner: 10Matěj Suchánek) [10:55:47] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 05MW-1.28-release-notes, 05MW-1.29-release-notes, and 2 others: uca-fa collation shows pages starting with ا incorrectly under ء - https://phabricator.wikimedia.org/T139110#2904663 (10matmarex) I do not see how that would help. (Although I also do n... [10:57:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07I18n: Provide an easy way to localize links to some projects' main pages on the sidebar - https://phabricator.wikimedia.org/T154181#2904664 (10Amire80) If I understand correctly, this is probably an issue to be resolved in the client part of the Wikibase e... [10:58:16] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2904667 (1001tonythomas) You can reuse the code currently we have to notify users on new issues to newsletteres at... [11:09:26] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [11:09:26] @notify andre__ [11:09:34] 10MediaWiki-extensions-Newsletter: Better UI for adding / removing Newsletter publishers - https://phabricator.wikimedia.org/T131492#2904672 (1001tonythomas) Is there some method which would give us autocomplete and single-line, and etc, like this one here in the GCI site: {F5168510} [11:10:26] 10Wikimedia-Site-requests, 07Community-consensus-needed: Set $wgMFEditorOptions['anonymousEditing'] = true for kowiki - https://phabricator.wikimedia.org/T119823#2904673 (10revi) a:03revi Per [[https://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EC%82%AC%EB%9E%91%EB%B0%A9_(%EA%B8%B0%EC%88%A0)... [11:12:40] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904679 (10QuimGil) [11:13:05] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904694 (10QuimGil) [11:13:08] 10MediaWiki-extensions-Newsletter, 10Security-Reviews, 06Security-Team: Security review of Newsletter extension - https://phabricator.wikimedia.org/T115095#1714753 (10QuimGil) [11:16:26] (03CR) 10Harjotsingh: "> @Harjotsingh that's great! This should now be much easier to test!" [core] - 10https://gerrit.wikimedia.org/r/320612 (owner: 10Harjotsingh) [11:17:47] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed - https://phabricator.wikimedia.org/T154230#2904697 (10Devirk) [11:18:03] tonythomas: Hmm, why duplicate code? [11:18:10] rlot: where ? [11:18:19] tonythomas "Newsletter extension should send a notification to users un/subscribed" [11:18:20] duplication is a no-no aynwhere :D [11:18:29] rlot: there is no existing code for that ? [11:18:35] Therer is [11:19:13] we have a notification which go when a user is added as a publisher, right ? [11:19:21] not as a subscriber (or am I missing something) ? [11:20:05] tonythomas: Oh, got it [11:24:04] andre__: If I abadoned task, 30min after claiming, becouse more intresting task got published, is it wrong? [11:25:00] tonythomas: Subscriber adding is just a textarea? [11:25:41] rlot: no, you are free to do what you want :) [11:26:10] andre__:Thanks! In morning there wasn't too much intresting tasks [11:28:38] (03CR) 10Umherirrender: [C: 032] Use setPageTitle() instead of setPagetitle() [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329445 (owner: 10Fomafix) [11:29:56] (03Merged) 10jenkins-bot: Use setPageTitle() instead of setPagetitle() [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329445 (owner: 10Fomafix) [11:30:01] (03PS1) 10Thiemo Mättig (WMDE): Fix typos and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329449 [11:30:08] tonythomas: Hmm, SpecialNewsletter.php should be splited to files [11:30:15] 10MediaWiki-extensions-Newsletter: Should "view subscribers" be part of "manage" in the Newsletter extension? - https://phabricator.wikimedia.org/T154144#2902295 (1001tonythomas) @Reedy: Since we do not want usual publishers to see this form, I presume we might need multiple forms on the same page ? Previously t... [11:30:22] rlot: why do you think so ? [11:30:30] Its really chaoitc [11:31:01] rlot: as far as it works, chaotic is kinda okey, I guess :D [11:32:50] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: NewsletterContent: Return type for doLinkCacheQuery to be changed - https://phabricator.wikimedia.org/T154233#2904751 (10Devirk) [11:33:16] tonythomas: There should be 2 foreach loops near 475, one for added and one to removed? [11:33:29] tonythomas: And execute echo in these loops? [11:34:26] rlot: I am not sure :-( but I think Echo new notification can take in a userarray or something ? You got time to explore, rlot :D [11:34:49] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904766 (10QuimGil) I have mentioned this task in https://meta.wikimedia.org/wiki/Meta:Requests_for_help_from_a_sysop_or_bureaucr... [11:36:49] 10MediaWiki-extensions-Newsletter, 06Community-Liaisons, 05Goal: Goal: Deploy Newsletter extension in Wikimedia - https://phabricator.wikimedia.org/T110170#2904768 (1001tonythomas) >>! In T110170#2904312, @ResMar wrote: > Yes, please do. There is still one thing I want to see, which is what the notification... [11:41:22] 10MediaWiki-extensions-Newsletter: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2904771 (10Reedy) FYI @Devirk You don't have to create tasks for each individual one You can put multiple commits against this bug if you want [11:47:27] tonythomas: I need to create new notification type? [11:47:53] tonythomas: Or just use 'newsletter-announce' [11:54:13] (03CR) 10Umherirrender: [C: 04-1] Fix typos and incomplete PHPDoc tags (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329449 (owner: 10Thiemo Mättig (WMDE)) [11:57:30] (03PS2) 10Thiemo Mättig (WMDE): Fix typos and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329449 [12:02:34] (03PS1) 10Zfilipin: Updated mediawiki_selenium Ruby gem [core] - 10https://gerrit.wikimedia.org/r/329454 (https://phabricator.wikimedia.org/T154232) [12:02:46] tonythomas: This should be title? [12:02:47] You have been subscribed to the $Newsletter" newsletter by an administrator. [12:03:22] (03CR) 10Umherirrender: [C: 032] Fix typos and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329449 (owner: 10Thiemo Mättig (WMDE)) [12:03:42] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904797 (10QuimGil) [12:04:26] (03PS2) 10Zfilipin: Updated mediawiki_selenium Ruby gem [core] - 10https://gerrit.wikimedia.org/r/329454 (https://phabricator.wikimedia.org/T154232) [12:09:41] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904799 (10QuimGil) Er... silly me, the first wiki will be mediawiki.org, not Meta (T116271#2344835). I have mentioned this task... [12:11:06] (03Merged) 10jenkins-bot: Fix typos and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329449 (owner: 10Thiemo Mättig (WMDE)) [12:12:31] (03CR) 10jenkins-bot: Fix typos and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329449 (owner: 10Thiemo Mättig (WMDE)) [12:16:55] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2904805 (10Aklapper) Could this be split into a bunch of GCI tasks? Obviously, very good knowledge of English language and its proper spelling && previo... [12:23:46] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07I18n: Provide an easy way to localize links to some projects' main pages on the sidebar - https://phabricator.wikimedia.org/T154181#2904819 (10Aklapper) [12:23:48] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Story: [Story] In the "other projects" sidebar on multilingual wikis, link to wikis in the user language - https://phabricator.wikimedia.org/T111913#2904822 (10Aklapper) [12:24:17] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07I18n: Provide an easy way to localize links to some projects' main pages on the sidebar - https://phabricator.wikimedia.org/T154181#2903435 (10Aklapper) This particular topic has already been reported into our bug tracking system as T111913, but please fee... [12:25:00] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Story: [Story] In the "other projects" sidebar on multilingual wikis, link to wikis in the user language - https://phabricator.wikimedia.org/T111913#1619759 (10Aklapper) [12:27:55] (03PS4) 10Esanders: ApiSandbox: Display params as JSON on request page [core] - 10https://gerrit.wikimedia.org/r/328900 (https://phabricator.wikimedia.org/T130501) [12:28:31] 10MediaWiki-extensions-Interwiki, 10Wikimedia-Site-requests: Update interwiki map, following edit - https://phabricator.wikimedia.org/T154225#2904827 (10Aklapper) What "unfreeze of deployments"? What requires an update of the interwiki map? More information would allow judging urgency and priority. Also see ht... [12:31:14] 05Security: Give Katie Horn (K4-713) access to restricted Security tasks - https://phabricator.wikimedia.org/T154211#2904828 (10Aklapper) @Peachey88: This has nothing to do with #Ops-Access-Requests; please see its project description [12:32:41] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Story: [Story] In the "other projects" sidebar on multilingual wikis, link to wikis in the user language - https://phabricator.wikimedia.org/T111913#2904832 (10Piramidion) I think that the way the issue is described here is incorrect. See the correct and m... [12:34:52] 05Security: Give Katie Horn (K4-713) access to restricted Security tasks - https://phabricator.wikimedia.org/T154211#2904834 (10Aklapper) 05Open>03Resolved a:03Aklapper @K4-713 is already a member of #WMF-NDA (and hence the validity of their Phabricator account has been checked) and there's been a recent t... [12:35:32] 10MediaWiki-extensions-Newsletter, 10Wikimedia-Site-requests: Agree first user group that will be able to create newsletters in Wikimedia - https://phabricator.wikimedia.org/T154229#2904679 (10MarcoAurelio) I'd say initial phase should be restricted to administrators and that 'newsletter-create' should be part... [12:36:58] (03CR) 10Bartosz Dziewoński: [C: 031] ApiSandbox: Display params as JSON on request page [core] - 10https://gerrit.wikimedia.org/r/328900 (https://phabricator.wikimedia.org/T130501) (owner: 10Esanders) [12:39:19] 10MediaWiki-extensions-Newsletter, 10Security-Reviews, 06Security-Team: Security review of Newsletter extension - https://phabricator.wikimedia.org/T115095#2904840 (10MarcoAurelio) Has the suppression (oversight) of newsletters being considered? If not, the option should be added to avoid leaks of private in... [12:40:42] (03PS1) 10Filip: [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [12:40:52] tonythomas ^^ [12:41:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [12:44:35] (03PS2) 10Filip: [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [12:45:08] (03CR) 10Filip: "Need to add presenter, and more messages. Just wanted for @01tonythomas to take a look." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [12:45:20] I will let you know when I see tonythoams around here [12:45:20] @notify tonythoams [12:45:29] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [12:45:29] @notify tonythomas [12:49:28] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2902248 (10FilipGCI) Need to add presenter class, but wanted to @01tonythomas to take a look. [12:51:57] wm-bot: liar again :/ [12:51:57] Hi tonythomas, there is an error, I'm a stupid bot and not intelligent enough to hold a conversation with you :-) [12:52:06] rlot: you need a new presentationclass, yes [12:52:10] like EchoNewsletterPublisherPresentationModel! good goin! [12:52:28] tonythomas: But code looks good for now? [12:52:56] rlot: yes, I guess [12:53:42] tonythomas: But do i need to add flyout? [12:54:31] tonythomas: Jesus, theres lots of messages to do here [12:54:41] And my english is [12:55:14] rlot: I thought you were asking for a challenging task ? (pun intended) [12:56:10] Yeah, its really intresting! tonythomas: [12:57:12] (03PS2) 10Fomafix: Convert PHP syntax from array() to [] [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329443 [12:57:14] (03PS1) 10Fomafix: Explicit convert the Message object to string [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329461 [13:00:46] (03CR) 10Umherirrender: [C: 032] Convert PHP syntax from array() to [] [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329443 (owner: 10Fomafix) [13:01:57] (03Merged) 10jenkins-bot: Convert PHP syntax from array() to [] [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/329443 (owner: 10Fomafix) [13:02:37] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/329462 [13:02:54] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/Athena] - 10https://gerrit.wikimedia.org/r/329463 [13:03:08] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/329464 [13:03:24] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/329465 [13:03:37] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/329466 [13:04:02] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/329468 [13:04:10] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/329469 [13:04:47] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/329470 [13:04:58] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/329471 [13:05:06] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/329472 [13:05:16] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/Poll] - 10https://gerrit.wikimedia.org/r/329473 [13:05:52] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/329474 [13:06:08] (03PS1) 10Umherirrender: Fix case of OutputPage::setPageTitle [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/329475 [13:06:47] (03CR) 10Fomafix: [C: 032] Fix case of OutputPage::setPageTitle [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/329468 (owner: 10Umherirrender) [13:07:54] (03Merged) 10jenkins-bot: Fix case of OutputPage::setPageTitle [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/329468 (owner: 10Umherirrender) [13:09:52] 10MediaWiki-extensions-ContentTranslation, 10Citoid, 10ContentTranslation-CXserver, 10ContentTranslation-Deployments, and 9 others: Depool and repool SCB services during deploys - https://phabricator.wikimedia.org/T144602#2904866 (10mobrovac) [13:10:16] (03CR) 10jerkins-bot: [V: 04-1] Fix case of OutputPage::setPageTitle [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/329475 (owner: 10Umherirrender) [13:11:59] tonythomas: Params are passed in presentation model? [13:14:23] 06Brickimedia, 10MediaWikiChat: Offline messaging support in MediaWikiChat - https://phabricator.wikimedia.org/T144773#2609857 (10UltrasonicNXT) Right hold on, those examples there are referring to using sockets to send messages (this is when the client and the server keep an open connection on which messages... [13:15:08] (03CR) 10Umherirrender: "Test failure are unrelated, no idea to fix it" [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/329475 (owner: 10Umherirrender) [13:15:26] 10Wikimedia-Site-requests: Not broken redirect appears at BrokenRedirects page at eswiki - https://phabricator.wikimedia.org/T154235#2904875 (10MarcoAurelio) [13:17:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I don't know enough about this extension and the task. But the problem with the current implementation is that there is no way to disable " (034 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/329387 (https://phabricator.wikimedia.org/T131975) (owner: 10Ladsgroup) [13:17:14] 10AbuseFilter: AbuseFilter statistics - https://phabricator.wikimedia.org/T153604#2904887 (10MarcoAurelio) I'd not mind displaying that at the main page. Just the number of conditions used should be added to the page then. [13:19:27] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Also note that this patch does the *opposite* of what was asked for in T131975#2184844." [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/329387 (https://phabricator.wikimedia.org/T131975) (owner: 10Ladsgroup) [13:19:46] 06Brickimedia: Create a database dump for Customs, Ideas, and Meta - https://phabricator.wikimedia.org/T143380#2904890 (10UltrasonicNXT) Right, as George said, there's a daily DB backup which is stored on our server, and then on my dropbox. I'm happy to share these with anyone, the ones on the server are at `/ho... [13:21:37] 06Brickimedia, 10MediaWikiChat: MediaWikiChat should save old private messages sent recently - https://phabricator.wikimedia.org/T148259#2718636 (10UltrasonicNXT) This is technically quite hard to implement, given the way MWC stores messages at the moment [13:23:16] 10MediaWikiChat, 10Social-Tools: Separate the emoticons function from MediaWikiChat into it's own extension - https://phabricator.wikimedia.org/T151514#2904895 (10UltrasonicNXT) Sounds like a good idea [13:23:18] (03PS3) 10Filip: [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [13:23:44] 06Brickimedia, 10MediaWikiChat: MediaWikiChat should allow sub-bulleted lists in MediaWiki:Smileys for intuitive syntax - https://phabricator.wikimedia.org/T146561#2904897 (10UltrasonicNXT) could be implemented into T151514 [13:23:59] 06Brickimedia, 10MediaWikiChat: Feature request: Ability to disable emojis in Special:Preferences for MediaWikiChat - https://phabricator.wikimedia.org/T144147#2904900 (10UltrasonicNXT) could be implemented in T151514 [13:24:23] tonythomas: Looks like thats it [13:24:39] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [13:27:05] (03PS4) 10Filip: [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [13:27:27] tonythomas: Ok, it looks good now [13:27:42] tonythomas: But I need to retest it locally, my database died [13:28:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [13:28:30] 10MediaWiki-extensions-Interwiki, 10Wikimedia-Site-requests: Update interwiki map, following edit - https://phabricator.wikimedia.org/T154225#2904904 (10Billinghurst) When standard deployments resume in January, just need to update the interwiki file from meta. Nothing urgent, just link updates. Usually this... [13:29:03] 10MediaWiki-extensions-Translate: Special:MessageGroupStats shows wrong information after page move - https://phabricator.wikimedia.org/T145295#2904905 (10Samdvorak) I tried that in different ways but it didn't help, situation is still the same. Any other suggestions on how to fix that? (PS Sorry for my slow res... [13:29:54] 07Design, 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Special:Nuke — space separation between select toggles and the delete button - https://phabricator.wikimedia.org/T145346#2904908 (10Billinghurst) 05Open>03Resolved a:03Billinghurst has been done [13:29:59] (03PS5) 10Filip: [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [13:30:06] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [13:30:06] @notify tonythomas [13:31:04] 07Design, 10MediaWiki-extensions-Nuke, 13Patch-For-Review: Special:Nuke — space separation between select toggles and the delete button - https://phabricator.wikimedia.org/T145346#2904911 (10Billinghurst) a:05Billinghurst>03Glaisher [13:31:09] RoanKattouw: Around? [13:31:27] 06Brickimedia: Brickimedia: Sites backups size and space - https://phabricator.wikimedia.org/T151141#2904913 (10UltrasonicNXT) 05Open>03Resolved a:03UltrasonicNXT All the current DBs are backed up, and they come to a total of 803MB, although that does include some older ones like nl, dev, answers, etc [13:31:53] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [13:32:06] jenkinsss [13:32:23] FlorianSW: Around? [13:33:09] MtDu: Here now :) [13:34:27] RoanKattouw: Trying to add some GENDER support. :) https://phabricator.wikimedia.org/T145439 But I can't seem to find where echo-email-footer-default-html and echo-email-footer-default are passed parameters. Is it the agent thing? [13:34:46] (03PS6) 10Filip: [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [13:34:58] Hmm [13:35:38] (03CR) 10DatGuy: [C: 031] "I'm trying to get this started again. First of all, is it just me or is there a lot of excess, useless whitespace? Second thing is that I'" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/288752 (https://phabricator.wikimedia.org/T100263) (owner: 10Sethakill) [13:35:41] Besides those two, I can add the rest, if you think it's ok that those two don't have it. [13:36:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [13:36:18] MtDu: Hmm it may be those messages are no longe rused [13:36:26] Stephane rewrote the email formatter a while ago [13:36:40] RoanKattouw: Should I just remove them? [13:37:28] Yeah I think so [13:37:37] I mean I can't find anywhere that they're being used [13:37:56] Do ask Stephane to review the patch, he'll know if those messages are really unused [13:38:08] (He probably won't respond until Jan 3 or later though) [13:38:12] RoanKattouw: Also, look in EchoHtmlEmailFormatter, in getfooter. I'm looking at echo-email-html-footer-with-link. [13:38:24] RoanKattouw: I don't have that long.... :p [13:38:35] RoanKattouw: Would passing the user as such https://dpaste.de/E4dF be right? [13:38:51] RoanKattouw: Since a user is already given since it extends echoeventformatter? [13:38:56] Well adding GENDER support to the messages that are actually being used could be done faster [13:39:03] Then removing the unused ones can wait, right? [13:39:13] RoanKattouw: Yeah, I'll do that. [13:39:13] 06Brickimedia: Check if line 254 + line 255 which were left behind from SiteMatrix from Brickimedia/LocalSettings/LocalSettings_ext.php can be safely removed without breaking the site - https://phabricator.wikimedia.org/T146241#2654730 (10UltrasonicNXT) ooh cor, ```$wgLocalDatabases = array( "en", "customs", "gb... [13:40:14] (03PS7) 10Filip: Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [13:40:19] That pastie would work, but two things [13:40:41] 1) you need $this->user instead of $user (see e.g. EventFormatter line 58) [13:41:13] 2) if you pass $user before $preferenceLink, then you need to change the parameter numbering in the message ($1 becomes $2), and messages that aren't updated would break [13:41:30] So it's better to keep $1 as the link and make the user $2 [13:41:32] Rip. Yeah. I was reading line 17 wrong. [13:41:56] So I would just do ->Params() or is that a thing? [13:42:04] tonythomas: Jenkins succed! [13:42:08] Otherwise an outdated translation would result in stuff like "To control which emails we send you, MtDu" instead of "To control which emails we send you, [link]" [13:42:14] Yeah ->params() [13:42:31] Alrighty. I'll get to work. Will you be around in 1 hour to review a patch? [13:42:36] Sure [13:42:49] Alrighty. Btw, back in the states yet? Hope you had a Happy Holidays. :) [13:42:54] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2904924 (10FilipGCI) a:03FilipGCI @01tonythomas Added presenter class. [13:43:29] Not yet, heading back tomorrow [13:43:46] Hope your holidays were happy too [13:49:53] 10MediaWiki-General-or-Unknown: Investigate what is the deal with [[m:Meta:TrainingPages]] - https://phabricator.wikimedia.org/T154236#2904932 (10Base) [13:50:21] 10MediaWiki-General-or-Unknown: Investigate what is the deal with [[m:Meta:TrainingPages]] - https://phabricator.wikimedia.org/T154236#2904944 (10Base) [13:52:09] 10MediaWiki-General-or-Unknown: Investigate what is the deal with [[m:Meta:TrainingPages]] - https://phabricator.wikimedia.org/T154236#2904932 (10Base) (I got it returned in ``` select CONCAT("[[:{{ns:",page_namespace,"}}:",page_title,"]]") from metawiki_p.page where metawiki_p.page.page_len = 0 and page_namespa... [13:52:59] 06Brickimedia, 10MediaWikiChat: Chat CPU usage - https://phabricator.wikimedia.org/T147270#2904947 (10UltrasonicNXT) This is a little DIY loading GIF which is set to visible in the time between sending your message and it appearing on the screen. On a fast wiki like en .bm this is a very small period of time,... [13:53:05] 06Brickimedia, 10MediaWikiChat: Chat CPU usage - https://phabricator.wikimedia.org/T147270#2904948 (10UltrasonicNXT) a:03UltrasonicNXT [13:53:31] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Not broken redirect appears at BrokenRedirects page at eswiki - https://phabricator.wikimedia.org/T154235#2904950 (10Urbanecm) Isn't this just the cache? Adding project about EP. [13:54:43] 10MediaWiki-General-or-Unknown: Investigate what is the deal with [[m:Meta:TrainingPages]] - https://phabricator.wikimedia.org/T154236#2904952 (10Base) [13:57:45] (03PS1) 10Mobrovac: Scap: Depool and repool PDFRender during restarts [services/electron-render/deploy] - 10https://gerrit.wikimedia.org/r/329481 (https://phabricator.wikimedia.org/T144602) [13:58:07] (03CR) 10Mobrovac: [V: 032 C: 032] Scap: Depool and repool PDFRender during restarts [services/electron-render/deploy] - 10https://gerrit.wikimedia.org/r/329481 (https://phabricator.wikimedia.org/T144602) (owner: 10Mobrovac) [14:04:02] (03PS1) 10Mobrovac: Scap: Depool and repool MobileApps during restarts [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/329482 (https://phabricator.wikimedia.org/T144602) [14:04:14] (03CR) 10Mobrovac: [V: 032 C: 032] Scap: Depool and repool MobileApps during restarts [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/329482 (https://phabricator.wikimedia.org/T144602) (owner: 10Mobrovac) [14:06:15] (03PS1) 10UltrasonicNXT: Code style [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329483 [14:08:18] 10MediaWiki-extensions-ContentTranslation, 10Citoid, 10ContentTranslation-CXserver, 10ContentTranslation-Deployments, and 10 others: Depool and repool SCB services during deploys - https://phabricator.wikimedia.org/T144602#2904965 (10mobrovac) [14:08:28] (03PS1) 10Mobrovac: Scap: Depool and repool Trending Edits during restarts [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/329484 (https://phabricator.wikimedia.org/T144602) [14:08:41] (03CR) 10UltrasonicNXT: [C: 032] Code style [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329483 (owner: 10UltrasonicNXT) [14:09:35] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2904967 (10UltrasonicNXT) Right, confirmed to happen in PMs. This is a little bit scary from a security point of view. [14:09:36] (03CR) 10Mobrovac: [V: 032 C: 032] Scap: Depool and repool Trending Edits during restarts [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/329484 (https://phabricator.wikimedia.org/T144602) (owner: 10Mobrovac) [14:09:59] (03Merged) 10jenkins-bot: Code style [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329483 (owner: 10UltrasonicNXT) [14:13:36] (03PS1) 10UltrasonicNXT: Code style [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329485 [14:14:47] (03CR) 10UltrasonicNXT: [C: 032] Code style [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329485 (owner: 10UltrasonicNXT) [14:15:49] (03Merged) 10jenkins-bot: Code style [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329485 (owner: 10UltrasonicNXT) [14:16:19] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2904972 (10Pppery) a:05Pppery>03FilipGCI [14:20:40] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Not broken redirect appears at BrokenRedirects page at eswiki - https://phabricator.wikimedia.org/T154235#2904975 (10MarcoAurelio) I doubt it, because some weeks ago I was approached by an admin there complaining that my bot repeatedly tagged... [14:22:34] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Not broken redirect appears at BrokenRedirects page at eswiki - https://phabricator.wikimedia.org/T154235#2904875 (10matmarex) Visiting https://es.wikipedia.org/wiki/WP:WMVE does not redirect to https://es.wikipedia.org/wiki/Programa_educativo... [14:23:01] 10MediaWiki-extensions-EducationProgram: Redirects to EducationProgram pages appear at BrokenRedirects page - https://phabricator.wikimedia.org/T154235#2904979 (10matmarex) [14:23:29] (03PS1) 10Mobrovac: Scap: Depool and repool EventStreams during restarts [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/329488 (https://phabricator.wikimedia.org/T144602) [14:23:33] tonythomas: YEEY! Works, I need to commit it to gerrit [14:23:40] 10MediaWiki-General-or-Unknown, 10MediaWiki-History-or-Diffs: Investigate what is the deal with [[m:Meta:TrainingPages]] - https://phabricator.wikimedia.org/T154236#2904983 (10Base) [14:24:04] (03CR) 10Mobrovac: [V: 032 C: 032] Scap: Depool and repool EventStreams during restarts [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/329488 (https://phabricator.wikimedia.org/T144602) (owner: 10Mobrovac) [14:25:33] 10MediaWiki-extensions-ContentTranslation, 10Citoid, 10ContentTranslation-CXserver, 10ContentTranslation-Deployments, and 9 others: Depool and repool SCB services during deploys - https://phabricator.wikimedia.org/T144602#2904985 (10mobrovac) 05Open>03Resolved Completed. All of the SCB services are now... [14:26:38] (03PS8) 10Filip: Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [14:28:32] (03CR) 10Filip: "Tested locally, everything works fine" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [14:32:49] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 05MW-1.28-release-notes, 05MW-1.29-release-notes, and 2 others: uca-fa collation shows pages starting with ا incorrectly under ء - https://phabricator.wikimedia.org/T139110#2904992 (10matmarex) I spent some time today setting up a Ubuntu 14 virtual... [14:39:39] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2905011 (10FilipGCI) @01tonythomas: @QuimGil Here's screenshots of both unsubscribe and subs... [15:12:43] (03PS1) 10Bartosz Dziewoński: CollationFa: Third time's the charm [core] - 10https://gerrit.wikimedia.org/r/329493 (https://phabricator.wikimedia.org/T139110) [15:17:20] 07Design: Restless #right-navigation bar - https://phabricator.wikimedia.org/T154239#2905030 (10abian) [15:17:34] Can anyone merge it? Patch from dec 3 [15:17:34] https://gerrit.wikimedia.org/r/#/c/325092/ [15:17:59] (03PS13) 10WMDE-Fisch: Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:18:25] (03PS14) 10WMDE-Fisch: Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:18:41] rlot: ask on #mediawiki-i18n [15:19:08] rlot: that's the channel where the extension developers are [15:19:23] (03CR) 10WMDE-Fisch: Introduce SpecialPageFatalTest (032 comments) [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:20:14] 07Design: Restless #right-navigation bar - https://phabricator.wikimedia.org/T154239#2905043 (10matmarex) [15:24:57] (03CR) 10jerkins-bot: [V: 04-1] Introduce SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/279367 (owner: 10Addshore) [15:47:47] PING tonythomas [15:49:02] (03PS2) 10MtDu: Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/314686 (https://phabricator.wikimedia.org/T145439) (owner: 10Mounicamergify) [15:49:10] (03CR) 10jerkins-bot: [V: 04-1] Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/314686 (https://phabricator.wikimedia.org/T145439) (owner: 10Mounicamergify) [15:52:40] Hey, I'm a GCI student [15:52:45] How do I set up Wikidata ? [15:52:56] Just extension? [15:53:04] In LocalSettings.php [15:53:14] I did that [15:53:17] append "wfLoadExtension( 'WikiBase' )" [15:53:22] WikiData is project [15:53:27] wikibase is one of extensions [15:53:49] How can I make my mediawiki installation WikiData ? [15:54:06] It does not make sense [15:54:29] You want to install WikiBase? [15:54:35] Just like other extensions [15:54:41] clone/activate [15:54:43] thats al [15:54:44] My task is to fix a bug in WikiData ; https://phabricator.wikimedia.org/T111016 [15:56:26] you first need to install WikiData extension to mediawiki [15:56:30] In WikiData, when you edit a page, you'll see a page of editing the properties (attributes) of data [15:57:03] I installed WikiData extension, enabled it. But when I'm making a new page, I'm seeing the normal edit page [16:00:22] did you set up an item namespace? [16:00:53] https://www.mediawiki.org/wiki/Extension:Wikibase_Repository#Items_in_a_dedicated_item_namespace [16:01:48] I created it now [16:02:25] going to a page in that namespace should show that interface [16:03:21] I got it ! [16:03:54] :) [16:04:39] Platonides: Thanks :) [16:04:52] you are welcome, subins2000 [16:14:55] @seen RoanKattouw [16:14:55] MtDu: RoanKattouw is in here, right now [16:15:06] RoanKattouw: Available? [16:15:55] MtDu: Yup, sorry, just got home [16:16:06] (03CR) 10Fomafix: Fix the uppercase issue of "lang" parameter in ImagePage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/269108 (https://phabricator.wikimedia.org/T125710) (owner: 10PhiLiP) [16:16:11] RoanKattouw: No probs. I need to rebase. Haven't done it in a while. [16:16:18] (well, not home home, that's tomorrow) [16:16:34] Yeah that can be confusing [16:16:43] Which patch do you need to rebase? [16:16:54] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/314686/ [16:17:49] You can take a look at it first before though. :) [16:17:57] Ooh this commit has multiple parents [16:18:12] That could get "interesting" [16:19:01] rlot: back now. checking it [16:20:06] The commit LGTM [16:20:13] tonythomas: Hi! [16:20:43] Rebasing it might be a bit of an adventure, it's a merge commit and I haven't rebased one of those before [16:21:14] You could try git fetch ; git rebase origin/master and see where that takes you [16:22:49] git fetch what? [16:23:03] Currently, I fetched the commit, and checkout -b AddGender [16:23:10] So just run git rebase origin/master? [16:23:16] Yeah [16:23:32] You could run git fetch first to ensure you have the latest master [16:24:23] Woops. Just ran git rebase origin/master and it gave me this. https://dpaste.de/Nebd Not sure if it did anything [16:25:42] RoanKattouw:^ [16:25:45] Hmm, did it output anything else? What does git log --oneline -2 show? [16:26:51] What does that command do? [16:27:51] MtDu: I would have expected that it also showed some more lines [16:28:06] git log lists the most recent commits, --oneline asks for condensed output with one line per commit, -2 means only the most recent two commits [16:28:51] And yes I would also have expected more output from git rebase [16:29:05] Platonides: Hi. Nice to meet you. :) [16:29:15] hi MtDu [16:29:28] My friend theopolisme knows you from a few years back. ;) [16:29:51] Anyhow, that's all that was outputted for me. I'm not sure if something is wrong on my end. [16:30:19] The commit is weird, I think that was caused by the previous uploader [16:30:20] I don't think I remember him with just that information [16:30:32] It's a merge commit with changes on top [16:31:07] RoanKattouw: Should I abandon that and then just upload a new patch? [16:31:28] That would be easiest [16:32:15] Transforming that commit into something useful requires advanced git surgery that I don't quite know how to do [16:32:39] RoanKattouw: Could you abandon it, or should I? I don't think I can. [16:32:47] I will [16:33:02] Right, you're not the owner so you can't abandon it [16:33:08] 04(no projects): "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2905071 (10Reception123) [16:34:05] (03Abandoned) 10Catrope: Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/314686 (https://phabricator.wikimedia.org/T145439) (owner: 10Mounicamergify) [16:35:05] (03PS1) 10Sn1per: Copy button for attribution text in download dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/329495 (https://phabricator.wikimedia.org/T77295) [16:35:54] 10Calendar: MsCalendar extension - https://phabricator.wikimedia.org/T154242#2905084 (10Amanda) [16:35:56] RoanKattouw, quick question. When do you add yourself to the author's list in en and qqq? Only when you add, reword a message or something right? [16:36:03] Just something I would like to know for future reference. [16:36:08] 10Calendar: MsCalendar extension - https://phabricator.wikimedia.org/T154242#2905097 (10Amanda) p:05Triage>03Normal [16:36:53] 10MediaWiki-Cache: "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2905098 (10Reception123) [16:36:59] I'm not sure what the conventions are for that exactly [16:37:13] I usually forget to add myself [16:37:25] rlot: code looks good from this distance. Now trying it live [16:37:30] The thing is, I don't want to add myself unless I'm supposed to so I never do it. [16:37:42] But if I remembered I think I'd do it for writing a new message but not for adding gender [16:37:52] That's what I would think. [16:38:13] That said I don't think I've ever added myself, I always forget [16:39:10] for en.json, the authors appear on the git log [16:45:11] (03PS1) 10MtDu: Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329496 (https://phabricator.wikimedia.org/T145439) [16:45:43] i don't think anyone cares about the authors list in en.json [16:46:06] the authors list in CREDITS is supposed to be regenerated with some script occasionally [16:46:18] (based on Git history) [16:46:24] MatmaRex: Hey! [16:46:48] Are there any forms that needed to be converted to OOUI still? I still haven't gotten an opportunity to do so, and would like to do one. [16:47:21] RoanKattouw: I pushed the patch. Review when you can. Thanks! :) [16:47:52] MtDu: i'm sure there are plenty. i'm not really following that anymore. [16:52:33] tonythomas: And how is it? [16:52:47] rlot: oops. lost focus in btw. checking it now [16:55:47] rlot: works too. wow. Checking the code again [16:56:38] tonythomas, rlot I tested it too. Works for me. :) [16:57:09] tonythomas: MtDu_: Thanks! I hard checked this code, so it should work [16:57:52] rlot: should be OK. Most of it was already in the existing EchoModel, so just required a few changes. Most of work was in the logic you added. [17:01:50] (03CR) 10Catrope: [C: 032] Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329496 (https://phabricator.wikimedia.org/T145439) (owner: 10MtDu) [17:03:08] RoanKattouw: thanks. :) [17:05:03] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2905105 (10UltrasonicNXT) Can't work out how this is happening, as the code is identical... [17:05:12] RoanKattouw: When you get back, I'd be down to tackle that secondary icon thing. [17:05:25] RoanKattouw: want me to close the Phabrucator task? [17:05:47] tonythomas: And how is it? [17:06:39] MtDu_: yeah go ahead and close the task [17:07:29] 10MediaWiki-Parser, 07I18n, 07Tracking: GENDER (tracking) - https://phabricator.wikimedia.org/T32443#2905108 (10MtDu) [17:08:31] I'd be happy to help with the secondary icon thing, not sure exactly when yet [17:09:33] I might be on line around this time the day after tomorrow, but only if my response to jet lag is to wake up early, which only happens about half the time [17:10:06] RoanKattouw: no problem. Take your rest. Any other echo things that need to be do that I'd be able to do? [17:10:31] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2905110 (10ashley) >>! In T152332#2905105, @UltrasonicNXT wrote: > Can't work out how this is happening, as the code is identical... Perhaps this is related to the [[https://www... [17:12:10] (03Merged) 10jenkins-bot: Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329496 (https://phabricator.wikimedia.org/T145439) (owner: 10MtDu) [17:13:26] (03CR) 10jenkins-bot: Add GENDER support to a few Echo messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329496 (https://phabricator.wikimedia.org/T145439) (owner: 10MtDu) [17:14:21] MtDu_: nothing comes to mind, but I haven't worked on Echo for a while. You might find things by digging through the task backlog, there are lots of tasks tagged with Echo [17:14:23] tonythomas: ? [17:14:43] I'll look through the backlog some time later this evening [17:14:58] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2905112 (10UltrasonicNXT) Ooh I wonder if it's because the message is not being escaped on the user side when it is displayed, rather than when it is added to the DB server side [17:15:08] RoanKattouw: cool. Preferably something that I haven't done before that I could learn from. :) [17:20:06] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2905113 (10UltrasonicNXT) yup looks like it's that [17:21:23] legoktm: around? [17:23:09] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2905114 (10UltrasonicNXT) Ah no, it's here https://github.com/wikimedia/mediawiki-extensions-MediaWikiChat/blob/master/api/GetNewWorker.php#L89 [17:25:41] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [17:25:41] @notify tonythomas [17:26:03] 10MediaWiki-extensions-Quiz, 03Google-Code-In-2016, 07Regression: [REGRESSION] Submit button on a single quiz grades all quizzes on the page - https://phabricator.wikimedia.org/T152398#2905115 (10Mvolz) p:05Unbreak!>03High [17:31:58] 10MediaWiki-extensions-Quiz, 03Google-Code-In-2016, 07Regression: [REGRESSION] Submit button on a single quiz grades all quizzes on the page - https://phabricator.wikimedia.org/T152398#2905118 (10Mvolz) [17:36:49] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2905135 (10QuimGil) In the notifications, does "Foobar" point to the newsletter info page? [17:38:32] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2905136 (10FilipGCI) @QuimGil: Yes, whole notification points to newsletter page. [17:39:38] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Echo formatter calls wrong newsletter URL in Newsletter extension Echo presentation model - https://phabricator.wikimedia.org/T154244#2905137 (1001tonythomas) [17:42:23] (03CR) 1001tonythomas: [C: 04-1] "minor nit. Looks Gut!" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [17:42:40] 10Wikimedia-Site-requests: Account creation throttle exemption for en.wp on 13 and 20 January - https://phabricator.wikimedia.org/T154245#2905149 (10Richard_Nevell_WMUK) [17:43:22] (03PS9) 10Filip: Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) [17:43:32] tonythomas: DOne [17:47:57] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2905167 (10FilipGCI) @tonythomas: Updated on gerrit. [17:50:03] rlot: Looks good [17:50:19] (03CR) 1001tonythomas: [C: 032] "Looks Good. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [17:51:30] (03Merged) 10jenkins-bot: Added notifications to manually added users [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329456 (https://phabricator.wikimedia.org/T154143) (owner: 10Filip) [17:51:55] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Echo formatter calls wrong newsletter URL in Newsletter extension Echo presentation model - https://phabricator.wikimedia.org/T154244#2905173 (1001tonythomas) [17:52:10] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2905176 (1001tonythomas) [17:52:12] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Newsletter extension should send a notification to users un/subscribed via the admin interface - https://phabricator.wikimedia.org/T154143#2905174 (1001tonythomas) 05Open>03Resolved Thank You! [17:56:14] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Echo formatter calls wrong newsletter URL in Newsletter extension Echo presentation model - https://phabricator.wikimedia.org/T154244#2905178 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5007922750816256/ - waiting for one... [17:58:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 07Story: [Story] Add a new datatype for geoshapes - https://phabricator.wikimedia.org/T57549#2905182 (10Yurik) The Commons Datasets with GeoJSON support has been enabled 2 weeks ago. See [[ https://www.mediawiki.org/wiki/Help:Map_Data... [18:01:15] (03PS1) 10UltrasonicNXT: Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 [18:01:18] 07Privacy, 05Security: Set channel cmode +S for wikimedia private IRC-Channels - https://phabricator.wikimedia.org/T152926#2905190 (10Luke081515) >>! In T152926#2869441, @Legoktm wrote: > `#mediawiki_security` is explicitly named with an _ so GCs don't have control over it. Then, it does not belongs to a regis... [18:01:21] (03CR) 10jerkins-bot: [V: 04-1] Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 (owner: 10UltrasonicNXT) [18:02:05] (03PS2) 10UltrasonicNXT: Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 [18:02:11] (03CR) 10jerkins-bot: [V: 04-1] Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 (owner: 10UltrasonicNXT) [18:03:18] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Create Newsletter Extension Help page - https://phabricator.wikimedia.org/T154222#2904495 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/6511407166128128/ and https://codein.withgoogle.com/dashboard/tasks... [18:05:53] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review, 05Security: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2905196 (10SamanthaNguyen) [18:06:16] (03PS3) 10UltrasonicNXT: Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 [18:06:25] 06Brickimedia, 10MediaWikiChat, 13Patch-For-Review, 05Security: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2844897 (10SamanthaNguyen) p:05Triage>03Normal [18:09:20] (03PS4) 10UltrasonicNXT: Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 [18:12:12] 06Brickimedia, 10Snippet: Snippet API parameter "set" for action=snippet should be renamed so it isn't specific to Brickipedia - https://phabricator.wikimedia.org/T153785#2905206 (10UltrasonicNXT) 05Open>03declined snippet was really created specifically for Brickipedia, and given T154220, I'm never gonna... [18:12:44] 07Privacy, 05Security: Set channel cmode +S for wikimedia private IRC-Channels - https://phabricator.wikimedia.org/T152926#2905211 (10Legoktm) >>! In T152926#2905190, @Luke081515 wrote: >>>! In T152926#2869441, @Legoktm wrote: >> `#mediawiki_security` is explicitly named with an _ so GCs don't have control ove... [18:13:12] (03CR) 10UltrasonicNXT: [C: 032] Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 (owner: 10UltrasonicNXT) [18:14:09] (03Merged) 10jenkins-bot: Prevent s being parsed [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/329501 (owner: 10UltrasonicNXT) [18:14:39] 10MediaWiki-extensions-Page_Forms: preg_replace error in page forms when previewing or saving a page's template call from form - https://phabricator.wikimedia.org/T153915#2905213 (10Tenbergen) Here is the form definition: ``` This is the 'Data Element' partial form. {{#forminput:form=Data element}}... [18:17:27] 07Privacy, 05Security: Set channel cmode +S for wikimedia private IRC-Channels - https://phabricator.wikimedia.org/T152926#2905217 (10Luke081515) If a channel does not belong to a group directly, freenode will not transfer the control to another person, even if the channel is expired, etc. [18:17:30] 10MediaWiki-extensions-Page_Forms: preg_replace error in page forms when previewing or saving a page's template call from form - https://phabricator.wikimedia.org/T153915#2905218 (10Tenbergen) Template Data Element is as follows. I initially had all the fields of it in the form but took all but one out as part o... [18:23:25] 04(no projects): MsCalendar extension - https://phabricator.wikimedia.org/T154242#2905084 (10SamanthaNguyen) Sorry, Calendar is ShoutWiki's Calendar extension (source at https://github.com/ShoutWiki/Calendar ), so I renamed that project to "ShoutWiki Calendar" - sorry for the confusion! I've filed another ticke... [18:27:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Easy, 03Google-Code-In-2016, 07I18n: [Bug] Strings "name" and "badges" are not translatable in diffs - https://phabricator.wikimedia.org/T111016#1592069 (10subins2000) Hey ! I've been trying to fix this for the past 3 hours and is in a zigzag. The... [19:08:27] 10MediaWiki-extensions-Newsletter: Subscribing users to newsletters automatically when certain conditions are matched - https://phabricator.wikimedia.org/T154228#2905268 (10QuimGil) No, both are complementary features. [19:12:53] 04(no projects): MsCalendar extension: Allow restricting adding/editing/deleting events - https://phabricator.wikimedia.org/T154242#2905270 (10Aklapper) [19:16:22] FlorianSW_: Thanks. :) [19:16:45] MtDu: you're welcome! Sorry, that I haven't responded earlier :( [19:16:52] No problem. [19:17:23] (03CR) 10Blackspirit96: [C: 031] "I tested it at my local server. There are proof images at the phabricator issue :)" [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [19:20:17] tonythomas: Around? [19:22:25] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Echo formatter calls wrong newsletter URL in Newsletter extension Echo presentation model - https://phabricator.wikimedia.org/T154244#2905275 (10Florian) Published :) [19:29:55] tonythomas: Should I change the name of the function too? [19:31:02] (03PS4) 10Paladox: Update pygments to 2.1.3 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/305861 [19:32:31] 10MediaWiki-extensions-MsCalendar: MsCalendar extension: Allow restricting adding/editing/deleting events - https://phabricator.wikimedia.org/T154242#2905299 (10MarcoAurelio) [19:32:32] (03CR) 10jerkins-bot: [V: 04-1] Update pygments to 2.1.3 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/305861 (owner: 10Paladox) [19:32:45] 10SyntaxHighlight, 07HHVM: Unexpected output from Pygments encountered - https://phabricator.wikimedia.org/T151523#2905302 (10Nemo_bis) [19:34:33] 10Wikimedia-Site-requests: Enable image renaming on WMF wikis - https://phabricator.wikimedia.org/T17842#2905308 (10Tacsipacsi) [19:35:46] tonythomas: Because it's not pointing to Special:Newsletter/id anymore, can I change name from getSpecialNewsletterUrl to getNewsletterUrl? [19:37:13] MtDu: don't ask, just change :D [19:37:20] Alrighty. :) [19:38:21] (03PS1) 10MtDu: Make Echo formatter point to Newsletter:NewsletterName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329504 (https://phabricator.wikimedia.org/T154244) [19:38:32] tonythomas: ^ :) [19:39:38] tonythomas: Makes me think we should try to remove the getNewsletterId function from there as well sometime. :) [19:39:41] (03CR) 10jerkins-bot: [V: 04-1] Make Echo formatter point to Newsletter:NewsletterName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329504 (https://phabricator.wikimedia.org/T154244) (owner: 10MtDu) [19:40:31] MtDu: check if it's called somewhere.if no, just kill [19:40:40] It is right now. [19:40:57] (03PS7) 10Paladox: Update videojs to 5.15.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314731 [19:41:27] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2905333 (10Aklapper) >>! In T152159#2904468, @Shizhao wrote: > see Description A Chinese site listed as //examples// does not //affect// those... [19:43:32] 10Wikimedia-SVG-rendering, 07Chinese-Sites, 07I18n: SVG image wikisyntax can't use "lang=zh-hant" - https://phabricator.wikimedia.org/T154237#2905335 (10Aklapper) [19:43:47] 10Wikimedia-SVG-rendering, 07I18n, 13Patch-For-Review, 07Upstream: systemLanguage process issues in SVG.php - https://phabricator.wikimedia.org/T125710#2905337 (10Aklapper) [19:43:50] 10Wikimedia-SVG-rendering, 07Chinese-Sites, 07I18n: SVG image wikisyntax can't use "lang=zh-hant" - https://phabricator.wikimedia.org/T154237#2904993 (10Aklapper) [19:45:03] (03PS2) 10MtDu: Make Echo formatter point to Newsletter:NewsletterName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329504 (https://phabricator.wikimedia.org/T154244) [19:45:56] 04(no projects): "Problem with login session" getting this repeatedly - https://phabricator.wikimedia.org/T154241#2905339 (10Aklapper) Please provide browser and browser version information, and MediaWiki version information. Please see https://mediawiki.org/wiki/How_to_report_a_bug for future reference. Thanks! [19:47:32] tonythomas: See new patch. :) [19:47:53] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2905341 (10Glrx) @Shizhao Please explain the SVG wikisyntax issue. If it cannot... [19:50:43] 10MediaWiki-History-or-Diffs, 06Multimedia: Provide source code diff view for Vector Graphics files (SVG) for file overwrites - https://phabricator.wikimedia.org/T154176#2905343 (10Aklapper) [offtopic] @josve05a: Then its project description is maybe misleading ("if the task is not actually specific to Commons... [19:58:50] (03CR) 1001tonythomas: [C: 032] "Looks good. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329504 (https://phabricator.wikimedia.org/T154244) (owner: 10MtDu) [19:59:34] MtDu: ^^ [19:59:49] tonythomas: Thanks! Submitted. :) [19:59:56] (03Merged) 10jenkins-bot: Make Echo formatter point to Newsletter:NewsletterName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329504 (https://phabricator.wikimedia.org/T154244) (owner: 10MtDu) [19:59:59] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Echo formatter calls wrong newsletter URL in Newsletter extension Echo presentation model - https://phabricator.wikimedia.org/T154244#2905347 (1001tonythomas) 05Open>03Resolved a:03MtDu Thank you! [20:00:10] tonythomas: Do you think we can remove the getnewsletterid usage? [20:00:45] tonythomas: In basechopresentationmodel. [20:00:47] MtDu: I was thinking exactly that, but that would involve changes with the notification hooks as well. But as far as its not used to render a URL, I think it would be fine [20:01:41] tonythomas: Create a phab task for it? Also, what do you mean notification hooks? [20:03:04] MtDu: return (int)$this->event->getExtraParam( 'newsletter-id' ); -- we might need that to be changed to newsletter name for every notification. But I think that would be an overkill, and not as useful as we think [20:03:21] Ah ok. Yeah that's what I was going to propose. Just change it to newsletter-name. [20:03:35] getNewsletterName() that is. [20:03:54] MtDu: well, then we will have to pass the name to create all notifications (pass it as a param, so that the formatter class can pick it) [20:03:59] which all seems overkill [20:04:54] MtDu: and that was the 30th GCI task of newsletter which you just fixed (and I was mentoring) yay! [20:05:05] That's awesome. :) [20:05:25] I remember in 2015, I just mentored 1 and that was like one huge postfix something :\ [20:05:37] I think it was something with bouncehandler? Getting e-mails to bounce. [20:05:40] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-LoginNotify, 06Community-Tech: Investigation: What would be the best way to support loginwiki from LoginNotify - https://phabricator.wikimedia.org/T154064#2905370 (10kaldari) [20:05:58] 10MediaWiki-extensions-LoginNotify, 10Security-Reviews: Security Review of LoginNotify extension - https://phabricator.wikimedia.org/T140167#2905372 (10kaldari) [20:06:13] MtDu: exactly. basically, getting emails NOT to bounce :P [20:06:35] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-LoginNotify, 06Community-Tech: Update LoginNotify for AuthManager - https://phabricator.wikimedia.org/T135270#2905373 (10kaldari) [20:06:53] tonythomas: What's the point of this? https://phabricator.wikimedia.org/T154233 [20:07:11] tonythomas: The return whouldn't do anything useful would it? [20:07:56] MtDu: heh. the task is actually just to change the function doc. see https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/b738bb0e68ae3cbbc85ac45afa5fa7d306149085/includes/content/NewsletterContent.php#L311 [20:08:23] tonythomas: I'll do it real quick then. I found a typo too. I'll fix that. :) [20:08:40] MtDu: I would wait till it get imported to GCI (if you need GCI credits for it) [20:08:43] FlorianSW_: Could you import https://phabricator.wikimedia.org/T154233 [20:08:55] tonythomas: Also, I see documentation needs to be updated. ;) [20:09:26] MtDu: feel free to fire in tasks! [20:09:49] Or andre__:^ [20:09:59] Just kidding, he's not here. :p [20:14:48] tonythomas: What does returning UserArrayFromResult do? Is it an actual array? [20:14:55] According to https://doc.wikimedia.org/mediawiki-core/1.26.1/php/classUserArrayFromResult.html, it's an object? [20:15:18] MtDu: its an object array or something ? I am not sure [20:15:30] Because I can't really tell from the docs... [20:15:32] :( [20:16:13] MtDu: are you looking for UserArrayFromResult::$res ? [20:16:27] because UserArrayFromResult is a class, and you might be looking for one of its functions [20:19:20] tonythomas: It just constructs a UserArrayFromResult object with $res according to https://doc.wikimedia.org/mediawiki-core/1.26.1/php/UserArrayFromResult_8php_source.html. [20:19:25] tonythomas: What is res anyhow? [20:20:18] it should be a db query result, I guess [20:23:10] tonythomas: Could you explain how those work? I'm not really that familiar with the backend, and dbs. [20:24:52] MtDu: This is my guess: Probably you select in some numbers ( $res = somewrapper[1,2,3] ) and pass it to this UserArrayFromResult::$res and it would return an array of user objects which match with those userids. Like $user = User::newFromId(1); etc would be done for all values in $res and put into one array, and you get it. phew [20:25:28] tonythomas: Ah. Thank you. [20:25:45] wait. you need to double check it btw. hopefully Reedy can help! [20:28:03] 10MediaWiki-Special-pages: Special:LonelyPages (Orphaned Pages) does not contain lonely pages with selflink - https://phabricator.wikimedia.org/T150138#2905379 (10kaldari) @JAnD: Thanks for the explanations. I think I understand this better now. It sounds like the case of an article only linking to itself is fai... [20:30:42] 10Wikimedia-Site-requests: Update interwiki map, following edit - https://phabricator.wikimedia.org/T154225#2905383 (10Krenair) yeah, these are routine. someone will do it when deployments resume, likely dereckson. that extension is slightly unhelpfully named, it's tag is not needed here [20:38:38] (03PS1) 10Nemo bis: Add language fallback from rup (Aromanian) to ro (Romanian) [core] - 10https://gerrit.wikimedia.org/r/329506 [20:47:15] 10MediaWiki-Internationalization, 10Wikidata, 07I18n: Chechen style for lists requires "a" after every list item - https://phabricator.wikimedia.org/T154030#2905409 (10Nemo_bis) >>! In T154030#2904568, @TTO wrote: >>>! In T154030#2904533, @Liuxinyu970226 wrote: >> If this means that in Chechen, we should als... [20:48:05] legoktm, are you around? [20:48:43] legoktm, sorry for not solving that task yet, I wasn't home [20:48:48] I've just came [20:52:34] (03PS2) 10Victorbarbu: Replace some usages of &$this in Hooks::run [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) [20:59:05] (03CR) 10MtDu: [C: 04-1] "Why the addition of the logo.png file? Also, please add this comment before each edit: // Avoid PHP 7.1 warning of passing $this by refere" [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:00:22] (03CR) 10Victorbarbu: "> Why the addition of the logo.png file? Also, please add this" [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:00:27] MtDu, are you around? [21:01:30] 10MediaWiki-Internationalization, 10Wikidata, 07I18n: Chechen style for lists requires "a" after every list item - https://phabricator.wikimedia.org/T154030#2905415 (10Umar) Here you yourself have written everything correctly - Chechen style for lists requires "a" after every list item. [21:01:42] victorbarbu, yep. :) [21:02:37] MtDu, I have that file logo.png. When I say "git status", it always comes up as untracked, but I don't want it. If I add it to gitignore, there will be another file that I have to ignore when I "git add" [21:02:59] It says it's untracked? [21:03:06] I mean, I want to be able to say "git add --all" without that logo.png or anything else related to it (like a specific gitignore rule) [21:03:23] well, now it's not untracked, because I added it by mistake with git add --all [21:03:30] victorbarbu: What you can do is now, you can edit it directly on gerrit and manually remove that file. [21:03:39] victorbarbu, you can also just git rm that file. [21:03:47] 10Wikimedia-General-or-Unknown: [[m:Meta:TrainingPages]] has 0 revisions in its history - https://phabricator.wikimedia.org/T154236#2905419 (10Aklapper) [21:03:49] yeah, I will git rm it [21:04:29] 10Wikimedia-General-or-Unknown: [[m:Meta:TrainingPages]] has 0 revisions in its history - https://phabricator.wikimedia.org/T154236#2904932 (10Aklapper) Removed #MediaWiki-History-or-Diffs, #MediaWiki-General-or-Unknown as this looks like ancient database stuff on WMF servers and not like MediaWiki code behaving... [21:05:35] victorbarbu, I'm going to leave soon. I'll try to review your patch later. I think everything else looks good. Just be sure to add those comments in. :) [21:07:45] 10MediaWiki-Internationalization, 10Wikidata, 07I18n: Chechen style for lists requires "a" after every list item - https://phabricator.wikimedia.org/T154030#2905423 (10Umar) Now so: Ангола, Луанда, Африка, Андорра, Андорра-ла-Велья, Европа, Антигуа, Сент-Джонс, Северная Америка, Аргентина, Буэнос-Айрес А Южн... [21:08:20] (03PS3) 10Victorbarbu: Replace some usages of &$this in Hooks::run [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) [21:08:25] I pushed it just now [21:09:22] MtDu, if you're still around [21:09:30] Yep. Taking a look now. [21:09:31] :) [21:09:44] thanks [21:09:54] (03CR) 10VolkerE: "@Huji and @Gergő “Zebra” wasn't meant literally, it is just the name for this technique when it came up several years ago." [core] - 10https://gerrit.wikimedia.org/r/327849 (https://phabricator.wikimedia.org/T152532) (owner: 10VolkerE) [21:12:06] (03CR) 10MtDu: "One small naming issue." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:12:14] victorbarbu: Small thing. ^ [21:13:17] MtDu, done [21:13:18] (03PS4) 10Victorbarbu: Replace some usages of &$this in Hooks::run [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) [21:14:05] 10MediaWiki-extensions-Nuke, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Migrate Special:Nuke to OOUI - https://phabricator.wikimedia.org/T153988#2897526 (10Volker_E) @Ladsgroup Is this a local wiki that hasn't been updated in a while – wondering about the look of the dropdown widget (not h... [21:14:09] 10MediaWiki-extensions-Newsletter: Should "view subscribers" be part of "manage" in the Newsletter extension? - https://phabricator.wikimedia.org/T154144#2902295 (10Pppery) @01tonythomas What? Why do you do "not want usual publishers to see this form"? The conditions I coded for the subscribers form are the sam... [21:14:20] victorbarbu, may want to update commit message to say why you're pushing the patch, but legoktm will probably do that before merging. [21:14:24] For now, it looks good to me. :) [21:14:51] MtDu, and why am I pushing the patch? [21:15:11] Because the passing of &$this by reference throws errors in PHP 7.1 [21:15:21] 10Phabricator, 06Project-Admins, 10Social-Tools: Organize Social-Tools project - https://phabricator.wikimedia.org/T154166#2905433 (10Aklapper) [[ https://www.mediawiki.org/wiki/Phabricator/Project_management | See the docs ]] for info about workboards. If you don't have a definition of a problem to solve I... [21:15:53] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Wikimedia-SVG-rendering, 07Chinese-Sites: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags - https://phabricator.wikimedia.org/T154132#2905434 (10Glrx) I don't know what I'm doing, but researching the lang issue I... [21:16:03] victorbarbu, So ex. You would say what category hooks you replaced (Mainly api stuff), and then below, maybe do something like * This triggers warnings in PHP 7.1 [21:16:11] You can look at mine https://gerrit.wikimedia.org/r/#/c/329341/ [21:16:24] but I put a reference to the bug [21:16:33] (03CR) 10MtDu: [C: 031] "Code looks good on my end. Maybe an update to commit message to reflect why the patch is here (triggers warning in PHP 7.1)" [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:16:57] victorbarbu, True. I think it should be fine. Let's have legoktm or FlorianSW_ take a final look. :) [21:17:11] (03CR) 10MtDu: [C: 031] "@legoktm, @Florian, please take a final look. :)" [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:18:34] yup [21:18:44] you can give me a +1, right? :D [21:19:09] I did. :) [21:19:17] victorbarbu, ^ [21:19:27] (03PS5) 10Florianschmidtwelzow: Replace some usages of &$this in hook parameters [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:19:31] (03CR) 10Florianschmidtwelzow: [C: 032] Replace some usages of &$this in hook parameters [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:19:46] MtDu, I blocked gerrit-bot [21:19:55] it annoys me [21:19:59] Oh ok. FlorianSW_ to the rescue. :) [21:20:10] victorbarbu: He just +2ed it. You should be able to submit GCI task now. :) [21:20:30] FlorianSW_, could you also approve my gci task? [21:20:31] please? [21:20:42] victorbarbu: already did that :P [21:20:48] oh, nice [21:20:51] I didn't get an email [21:20:52] GCI isn't as fast as I sometimes want :D [21:21:13] why aren't there too many tasks...? [21:21:17] 10WikiArticleFeeds, 07Easy, 03Google-Code-In-2016: WikiArticleFeeds extension calls Article::getContent() which is deprecated - https://phabricator.wikimedia.org/T154203#2905436 (10Aklapper) Indeed, https://gerrit.wikimedia.org/r/#/c/327308/ did not cover this occurrence. [21:21:23] (03PS2) 10Nemo bis: [WIP] Add language fallback from eu (Basque) to es (Spanish) [core] - 10https://gerrit.wikimedia.org/r/329393 [21:21:41] 04(no projects): Most whatchlist emails don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2905440 (10Tacsipacsi) [21:21:58] they are pretty... not stupid, but not really php as expected from wikimedia [21:22:35] victorbarbu, You can propose your own if you find one you like. :) [21:24:50] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: NewsletterContent: Return type for doLinkCacheQuery to be changed - https://phabricator.wikimedia.org/T154233#2904751 (10Florian) What should be the return value? Currently, the only usage of this function (the function is private) doesn't use the retu... [21:26:38] 10Wikimedia-General-or-Unknown: Most whatchlist emails don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2905454 (10Nemo_bis) What is your email provider? How do you know that the missing notifications are random? Can you make a list of edits for which you think you should have received a notif... [21:26:58] tonythomas: Around? [21:27:37] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: NewsletterContent: Return type for doLinkCacheQuery to be changed - https://phabricator.wikimedia.org/T154233#2905456 (10Florian) p:05Triage>03Low [21:27:53] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: NewsletterContent: Return type for doLinkCacheQuery to be changed - https://phabricator.wikimedia.org/T154233#2904751 (10Florian) Imported as: https://codein.withgoogle.com/dashboard/tasks/6439209327919104/ [21:30:25] (03Merged) 10jenkins-bot: Replace some usages of &$this in hook parameters [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:36:18] 10Wikimedia-General-or-Unknown: Most whatchlist emails don't arrive on huwiki - https://phabricator.wikimedia.org/T154252#2905463 (10Tacsipacsi) I have a family email provider (jnet.hu) so I just asked the sysop face to face. :) I don't know what software it has, but I know it runs on Debian. Normally, these mis... [21:37:18] (03PS1) 10MtDu: Remove unnecessary doc for doLinkCacheQuery and fix a small typo [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329510 (https://phabricator.wikimedia.org/T154233) [21:38:20] (03CR) 10Florianschmidtwelzow: [C: 032] Remove unnecessary doc for doLinkCacheQuery and fix a small typo [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329510 (https://phabricator.wikimedia.org/T154233) (owner: 10MtDu) [21:38:36] 10MediaWiki-extensions-Newsletter: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2905469 (10Florian) [21:38:39] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: NewsletterContent: Return type for doLinkCacheQuery to be changed - https://phabricator.wikimedia.org/T154233#2905467 (10Florian) 05Open>03Resolved a:03MtDu [21:40:20] (03Merged) 10jenkins-bot: Remove unnecessary doc for doLinkCacheQuery and fix a small typo [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329510 (https://phabricator.wikimedia.org/T154233) (owner: 10MtDu) [21:42:33] (03PS1) 10Victorbarbu: Remove WebRequest::checkSessionCookie() method as being deprecated [core] - 10https://gerrit.wikimedia.org/r/329511 (https://phabricator.wikimedia.org/T61113) [21:44:49] (03CR) 10jenkins-bot: Replace some usages of &$this in hook parameters [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) (owner: 10Victorbarbu) [21:45:26] 07Design, 10MediaWiki-HTMLForm, 13Patch-For-Review: OOjs UI should allow `disabled` to contain an array - https://phabricator.wikimedia.org/T153927#2905473 (10Volker_E) [21:45:31] 10UI-Standardization, 13Patch-For-Review, 13Patch-Needs-Improvement, 15User-Ladsgroup: Convert Special:UserRights to OOUI - https://phabricator.wikimedia.org/T117884#2905472 (10Volker_E) [21:52:19] 10MediaWiki-Cache, 10MediaWiki-Internationalization: Localisation cache tmp file assumes tmp path is unique - https://phabricator.wikimedia.org/T154215#2905474 (10Aklapper) [21:53:24] 10Phabricator, 06Project-Admins, 10Social-Tools: Organize Social-Tools project - https://phabricator.wikimedia.org/T154166#2905475 (10SamanthaNguyen) 05Open>03declined Right, I'll mark this as declined. Thanks for the assistance! [21:57:48] 10MediaWiki-Special-pages: Scrolling through user groups on Special:ActiveUsers makes list disappear - https://phabricator.wikimedia.org/T154210#2905477 (10Aklapper) > When one tries to scroll through user groups in Special:ActiveUsers, the entire list disappears. I go to https://meta.wikimedia.org/wiki/Specia... [22:10:19] 10MediaWiki-extensions-Newsletter, 07Documentation, 03Google-Code-In-2016: Verify https://www.mediawiki.org/wiki/Extension:Newsletter contains up-to date information - https://phabricator.wikimedia.org/T154223#2905510 (10Aklapper) [22:20:03] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2905519 (10Cumbril) Added it to the list of gadgets of Estonian Wikipedia. Initialization code is here: https://et.wikipedia.org/wiki/MediaWiki:Gadget-ProveIt.js Does revision tag require anything... [22:31:14] 10Wikimedia-SVG-rendering, 07Chinese-Sites, 07I18n: SVG image wikisyntax can't use "lang=zh-hant" - https://phabricator.wikimedia.org/T154237#2905521 (10Glrx) There is a problem, but it is not with wikisyntax but rather librsvg. See T154132 which shows that different PNG filenames are generated for zh-hans a... [22:46:13] (03PS1) 10SamanthaNguyen: Remove unused stylesheet [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/329518 [22:47:14] (03PS2) 10SamanthaNguyen: Remove unused stylesheet [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/329518 [22:57:12] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2905531 (10Sophivorus) @Cumbril Awesome! Adding the revision tag to Special:Tags and to the config should suffice. I just tested the gadget on a [[ https://et.wikipedia.org/wiki/Kasutaja:Felipe_Sch... [22:57:30] (03CR) 10Jack Phoenix: "This is referenced -- but not used -- in Nimbus.skin.php, function setupSkinUserCss(), lines 53-54. You might want to also remove those li" [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/329518 (owner: 10SamanthaNguyen) [22:59:02] (03PS3) 10SamanthaNguyen: Remove unused stylesheet [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/329518 [22:59:21] (03CR) 10Jack Phoenix: [C: 032] Remove unused stylesheet [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/329518 (owner: 10SamanthaNguyen) [23:00:59] (03Merged) 10jenkins-bot: Remove unused stylesheet [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/329518 (owner: 10SamanthaNguyen) [23:00:59] 10Wikimedia-Site-requests: Update interwiki map, following edit - https://phabricator.wikimedia.org/T154225#2905534 (10Billinghurst) If there is a preferred/better means to request these updates then please let me know and we can put that information to administrators at Meta. [23:10:04] 10ProveIt-Gadget, 07I18n, 13Patch-For-Review: Estonian localization - https://phabricator.wikimedia.org/T154142#2905535 (10Cumbril) @Sophivorus Yes, I just checked, and now it shows that edits have ProveIt tag. Just took some time to take effect. [23:33:01] 10MediaWiki-extensions-Nuke, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Migrate Special:Nuke to OOUI - https://phabricator.wikimedia.org/T153988#2905536 (10Ladsgroup) @Volker_E Yes, my localhost OOUI is a little bit outdated. [23:39:01] (03CR) 10Ladsgroup: [C: 031] CollationFa: Third time's the charm [core] - 10https://gerrit.wikimedia.org/r/329493 (https://phabricator.wikimedia.org/T139110) (owner: 10Bartosz Dziewoński) [23:46:04] tto: Around? [23:46:15] MtDu: Hello there [23:46:23] tto: I hope you're doing well. [23:46:37] I'm not bad! [23:47:02] tto: I'm interested in pursuing some of these, https://phabricator.wikimedia.org/T97720. However, I don't really understand the purpose of the task and why it's there. Could you help me and give me some background? [23:48:12] MtDu: Sure. The idea is that you can apply "change tags" to the log entry that is created when you take an action, like deleting a page or assigning someone user rights. This tag could reflect the tool, script, or gadget you used to make the edit, for example [23:48:37] Currently, for most API modules you have to apply change tags "after the fact" using a separate API call. However, it is desired to make it possible to do it all in one go [23:49:15] A number of these API actions were already completed in GCI 2015, so if you wish to work on these, you can use those patches as models [23:50:07] Yep. I'm looking at them now for reference. [23:50:23] tto: Is it ok if I ask you some questions about one that's already been done? [23:50:29] For example, https://gerrit.wikimedia.org/r/#/c/265230/13/includes/api/ApiBase.php [23:50:33] That whole patch. [23:52:00] MtDu: That was infrastructure to make the other patches possible. It added a new API parameter type for change tags, and switched over the modules that were already accepting change tags to use this parameter type [23:56:39] 10Nimbus: Replace images and image sprites in Nimbus with CSS - https://phabricator.wikimedia.org/T154255#2905540 (10SamanthaNguyen) [23:58:43] tto: How come this never got merged? https://gerrit.wikimedia.org/r/#/c/266181/20 [23:59:19] MtDu: Not sure. I reckon Anomie forgot about it [23:59:40] tto: So that patch adds support for just one api action or multiple?