[00:14:28] !class HTMLForm [00:14:29] See https://doc.wikimedia.org/mediawiki-core/master/php/classHTMLForm.html [00:15:38] (03PS25) 10SamanthaNguyen: [WIP] Convert to newer extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) [00:26:04] (03CR) 10Jack Phoenix: [WIP] Convert to newer extension registration (034 comments) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) (owner: 10SamanthaNguyen) [00:30:09] (03PS2) 10Divadsn: Add id attribute to error message "mw-error-cannotundelete" [core] - 10https://gerrit.wikimedia.org/r/328943 (https://phabricator.wikimedia.org/T20819) [00:30:48] (03PS3) 10Divadsn: Add id attribute to error message "mw-error-cannotundelete" [core] - 10https://gerrit.wikimedia.org/r/328943 (https://phabricator.wikimedia.org/T20819) [00:49:22] (03PS26) 10SamanthaNguyen: [WIP] Convert to newer extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) [00:49:32] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Convert to newer extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) (owner: 10SamanthaNguyen) [00:52:02] (03CR) 10Reedy: [WIP] Convert to newer extension registration (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) (owner: 10SamanthaNguyen) [00:53:13] (03PS27) 10SamanthaNguyen: [WIP] Convert to newer extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) [01:05:46] (03CR) 10Legoktm: [C: 032] Add missing properties to MailAddress class [core] - 10https://gerrit.wikimedia.org/r/328915 (owner: 10Addshore) [01:06:06] legoktm: xmas merge :P [01:06:36] merry 25th december! [01:07:35] (03PS2) 10Legoktm: Ensure OutputPage::setFileVersion() is called in diff view [core] - 10https://gerrit.wikimedia.org/r/306664 (https://phabricator.wikimedia.org/T95261) (owner: 10Robert Vogel) [01:07:55] addshore: still 24th here :) [01:08:04] oh yeh .... [01:08:41] legoktm: well, in that case, mind looking at https://gerrit.wikimedia.org/r/#/c/328912/ ? :P [01:09:20] * legoktm hands addshore https://gerrit.wikimedia.org/r/329025 in exchange [01:09:50] (03CR) 10Legoktm: [C: 032] Allow PHAN location to be read from PATH [core] - 10https://gerrit.wikimedia.org/r/328912 (owner: 10Addshore) [01:10:44] legoktm: if you rebase you php7.0 -> php phan patch on that I'll +2 it too! :) [01:13:20] zomg cr cabal [01:15:53] (03Merged) 10jenkins-bot: Add missing properties to MailAddress class [core] - 10https://gerrit.wikimedia.org/r/328915 (owner: 10Addshore) [01:16:19] zomg Reedy cabal [01:16:34] * Reedy finds Noddy Holder to shout at addshore [01:18:19] [= [01:20:38] (03Merged) 10jenkins-bot: Allow PHAN location to be read from PATH [core] - 10https://gerrit.wikimedia.org/r/328912 (owner: 10Addshore) [01:26:08] (03CR) 10jenkins-bot: Add missing properties to MailAddress class [core] - 10https://gerrit.wikimedia.org/r/328915 (owner: 10Addshore) [01:34:31] (03CR) 10jenkins-bot: Allow PHAN location to be read from PATH [core] - 10https://gerrit.wikimedia.org/r/328912 (owner: 10Addshore) [01:41:53] (03CR) 10Jack Phoenix: [WIP] Convert to newer extension registration (039 comments) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) (owner: 10SamanthaNguyen) [01:42:50] 06Stewards-and-global-tools, 06WMF-Legal, 10Wikimedia-Extension-setup: Undeploy DisableAccount extension - https://phabricator.wikimedia.org/T106067#2901187 (10MarcoAurelio) Can/Should the 'inactive' user group go as well? If so it should be removed from the accounts that have it first. [02:40:18] 07Design, 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: MultimediaViewer should not leave so many history entries when closed - https://phabricator.wikimedia.org/T64266#667022 (10wil93) Why not add an option in the media viewer itself? In that way every user can opt-in (or opt-out) and deci... [03:24:14] (03PS28) 10SamanthaNguyen: [WIP] Convert to newer extension registration [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) [03:40:21] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Tracking: MediaViewer URL and history issues (tracking) - https://phabricator.wikimedia.org/T78224#2901212 (10Tgr) [03:40:25] 07Design, 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: MultimediaViewer should not leave so many history entries when closed - https://phabricator.wikimedia.org/T64266#2901210 (10Tgr) 05declined>03stalled I'd rather keep this open - it's one of the most popular requests about MediaView... [03:51:39] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2901213 (10AndyRussG) More indications that this is due to bots: - The Unknown region in Ireland also the lowest rate... [04:07:21] (03CR) 10Gergő Tisza: [C: 04-1] Add button to copy share/embed text to clipboard (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [04:08:31] Volker_E: any thoughts on the comment in https://gerrit.wikimedia.org/r/#/c/328696/4/resources/mmv/ui/mmv.ui.reuse.share.less ? [04:13:55] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: Add "copy to clipboard" button to share/embed fields - https://phabricator.wikimedia.org/T77295#2901218 (10Tgr) @Pginer-WMF what do you think, can we remove the select-on-click behavior afte... [04:28:02] tgr, if the copy fails should I just continue or should some error appear? [04:31:14] (03PS2) 10Tim Landscheidt: WIP: Use wfParseUrl() in Http::isValidURI() and fix tests [core] - 10https://gerrit.wikimedia.org/r/171542 [04:38:30] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use wfParseUrl() in Http::isValidURI() and fix tests [core] - 10https://gerrit.wikimedia.org/r/171542 (owner: 10Tim Landscheidt) [04:46:39] (03PS3) 10Tim Landscheidt: Add missing PostgreSQL updater for af_group [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/23933 [04:47:59] (03CR) 10Tim Landscheidt: [C: 04-1] "Just rebase; the issues above still apply." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/23933 (owner: 10Tim Landscheidt) [04:49:36] (03PS3) 10Tim Landscheidt: WIP: Use wfParseUrl() in Http::isValidURI() and fix tests [core] - 10https://gerrit.wikimedia.org/r/171542 [04:55:08] [13php-cssjanus] 15ricordisamoa opened pull request #10: travis: Add PHP 7.1 (06master...06php71) 02https://github.com/cssjanus/php-cssjanus/pull/10 [04:55:34] (03PS2) 10TTO: Proper handling of invalid/unknown time zones [core] - 10https://gerrit.wikimedia.org/r/329039 (https://phabricator.wikimedia.org/T137182) [04:55:37] (03CR) 10TTO: "Done." [core] - 10https://gerrit.wikimedia.org/r/329039 (https://phabricator.wikimedia.org/T137182) (owner: 10TTO) [04:58:23] (03PS8) 10Mynk-96: Fixed whitespaces in BilioPlus [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/329041 [05:07:17] can anyone tell me how to claim a task? [05:20:37] (03PS4) 10Mynk-96: Moved Exception classes from ContentHandler.php to their respective files in exception. [core] - 10https://gerrit.wikimedia.org/r/329045 (https://phabricator.wikimedia.org/T153243) [05:30:16] If i amn't eligible for gci ,should i still solve gci tasks and submit for patches or look for bugs other than gci tags? [05:30:48] If i amn't eligible for gci ,should i still solve gci tasks and submit patches or look for bugs other than gci tags? [05:48:15] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2901254 (10Arpna) a:03Arpna [06:09:36] mynk-96: to claim a task, assign it to yourself [06:10:53] you're free to look and fix other bugs I believe [06:19:37] mynk-96: are you participating in CGI? [06:19:42] GCI* I mean [06:19:55] i am not eligible [06:20:00] 19 years old [06:22:39] (03CR) 10Legoktm: [C: 032] Replaced Linker::link() usages with LinkRenderer [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/328670 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [06:23:05] mynk-96: ok. Please don't do GCI tasks then, there should be plenty of other bugs out there that need someone to work on them :) [06:23:23] okay thank you [06:23:46] (03Merged) 10jenkins-bot: Replaced Linker::link() usages with LinkRenderer [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/328670 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [06:23:55] (03CR) 10Legoktm: [C: 032] Replaced Linker::link() usages with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/328489 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [06:24:36] (03CR) 10Legoktm: [C: 032] Replaced Linker::link() usages with LinkRenderer [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/328641 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [06:24:58] (03Merged) 10jenkins-bot: Replaced Linker::link() usages with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/328489 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [06:25:32] (03Merged) 10jenkins-bot: Replaced Linker::link() usages with LinkRenderer [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/328641 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [06:29:39] (03CR) 10Legoktm: [C: 04-1] Replaced Linker deprecated functions with LinkRenderer (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329052 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:35:27] (03CR) 10Legoktm: [C: 04-1] "Nice work, this was a pretty tough extension to convert." (032 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329032 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:41:36] (03Abandoned) 10Legoktm: Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/329036 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:41:41] (03Abandoned) 10Legoktm: Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/329034 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:56:16] 10MediaWiki-extensions-InputBox: New parameter: "searchtemplate" - https://phabricator.wikimedia.org/T21955#235091 (10TTO) This is actually slightly non-trivial, as the input box `
` can no longer submit directly to Special:Search if a search template is provided. [07:54:22] @seen legoktm [07:54:22] subins2000: legoktm is in here, right now [07:54:55] legoktm: Hey ! If I get LinkRenderer from createFromLegacyOptions( $options ). What function should I call next ? makeLink() ? [07:57:05] OH-: just ignore it [07:57:33] if it fails, the browser probably can't copy to the clipboard and there is no point in bothering the user about it [08:03:04] subins2000: yeah [08:03:41] (03PS4) 10Subins2000: Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329032 (https://phabricator.wikimedia.org/T149346) [08:04:03] legoktm: Thanks :) I submitted my new patch [08:10:57] (03PS3) 10Subins2000: Replaced Linker deprecated functions with LinkRenderer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329052 (https://phabricator.wikimedia.org/T149346) [08:22:48] (03CR) 10Gergő Tisza: "I'm not sure this is a good idea. When the local password provider has the loginOnly flag set, it will remove the password automatically w" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/328930 (https://phabricator.wikimedia.org/T153985) (owner: 10Florianschmidtwelzow) [08:37:48] (03PS25) 10Victorbarbu: Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [08:38:29] (03CR) 10Fomafix: [C: 04-1] WIP: Use wfParseUrl() in Http::isValidURI() and fix tests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/171542 (owner: 10Tim Landscheidt) [08:45:48] (03CR) 10Fomafix: [V: 04-1] "I get the following exception on Special:RecentChanges" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [08:46:57] (03CR) 10Victorbarbu: "> I get the following exception on Special:RecentChanges" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [09:00:55] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2901285 (10jcrespo) Firefox 50.0.1, which many users seem to have problems with, was released on 28 November, and https://www.mozilla.org/en-US... [09:06:07] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2901286 (10jcrespo) According to open bug https://bugzilla.mozilla.org/show_bug.cgi?id=1319403 There could be a new limit per main domain, an a... [09:09:29] 10MediaWiki-Codesniffer: Add/enable rule for spaces before array indices - https://phabricator.wikimedia.org/T154103#2901287 (10scfc) [09:12:42] (03CR) 10Tim Landscheidt: WIP: Use wfParseUrl() in Http::isValidURI() and fix tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/171542 (owner: 10Tim Landscheidt) [09:13:14] (03PS4) 10Tim Landscheidt: WIP: Use wfParseUrl() in Http::isValidURI() and fix tests [core] - 10https://gerrit.wikimedia.org/r/171542 [10:01:35] (03CR) 10Filip: "Please, claim https://codein.withgoogle.com/tasks/6226746632306688/" (031 comment) [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/329041 (owner: 10Mynk-96) [10:08:06] (03CR) 10Filip: [C: 031] Moved Exception classes from ContentHandler.php to their respective files in exception. [core] - 10https://gerrit.wikimedia.org/r/329045 (https://phabricator.wikimedia.org/T153243) (owner: 10Mynk-96) [10:15:15] (03CR) 10jerkins-bot: [V: 04-1] Moved Exception classes from ContentHandler.php to their respective files in exception. [core] - 10https://gerrit.wikimedia.org/r/329045 (https://phabricator.wikimedia.org/T153243) (owner: 10Mynk-96) [10:20:44] In wikipage, should i use "#" comments, or "//" comments? [10:20:57] *MediaWiki code [10:21:17] If code, with I edit uses # which is deprecated [10:21:20] Reedy: ? [10:24:17] (03CR) 10Filip: [C: 04-1] Moved Exception classes from ContentHandler.php to their respective files in exception. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/329045 (https://phabricator.wikimedia.org/T153243) (owner: 10Mynk-96) [10:25:34] (03PS1) 10Filip: Replaced deprecated hook usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/329121 (https://phabricator.wikimedia.org/T151973) [10:29:30] 10MediaWiki-General-or-Unknown: MWExceptionRenderer::reportOutageHTML() produces invalid HTML - https://phabricator.wikimedia.org/T154076#2901337 (10labster) OK @Aklapper, I'll bite. Convince me that the second part is a separate task, and I'll open another task. I'm rather thinking that if the call to `report... [10:33:39] It doesn't really matter I believe [10:33:49] but double check the coding conventions [10:34:14] I would imagine that using whatever is in the file that your editing isn't a bad idea [10:34:47] p858snake: Hmm, I used # becouse it was in this whole file [10:43:51] Reedy, are you here?:) [10:44:45] It's probably close to christmas eve for Reedy [10:44:57] if not already christmas [10:45:07] I think it's already christmas:) [10:46:50] 10Gamepress: Hardcoded username in resources/js/twitter.js - https://phabricator.wikimedia.org/T154106#2901341 (10labster) [10:48:07] Ah, for a moment I thought "Gamepress" was about Gamepedia [10:50:38] (03PS1) 10Filip: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) [10:52:16] (03PS2) 10Filip: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) [10:54:47] p858snake: Close to Christmas eve? :P [10:55:39] Reedy: you should know by know I I don't pay attention to my own timezone let alone BST [10:55:46] It's not summer [10:55:48] We're on UTC [10:55:51] rlot: Usually, if the file is using # use #, if it's using // using // [10:55:58] Christmas has been and gone for me [10:56:23] How was the beach? [10:56:30] Georggi: I am now [10:56:55] I didn't go to the beach [10:58:00] Reedy, how to get context from wikiPage? [10:58:41] Georggi: I guess you can't... You need to use RequestContext::getMain() or similar [11:04:22] (03PS1) 10Georggi199: Replaced deprecated hook usage [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/329123 (https://phabricator.wikimedia.org/T151973) [11:04:24] (03PS6) 10TTO: Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [11:04:30] (03CR) 10TTO: [C: 032] Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [11:06:26] rlot: Thanks for CR'ing other peoples commits too btw :) [11:07:25] 10MediaWiki-Database: MSSQL: Database error after upgrading to 1.28.0 - https://phabricator.wikimedia.org/T153876#2901358 (10Paladox) Adding @aaron since it seems that the fixes we did to postgres need to be applied to mssqlplease. [11:09:23] (03CR) 10Reedy: [C: 032] Replaced deprecated hook usage (031 comment) [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/329123 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [11:10:45] Reedy: Can you take a look? https://gerrit.wikimedia.org/r/#/c/329122/ [11:10:56] I am just looking now, yes :P [11:11:12] (03CR) 10Reedy: [C: 032] Replaced deprecated hook usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/329121 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:11:42] (03PS1) 10Paladox: Depedency inject remappedTableName() map via MWLBFactory [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/329124 [11:12:17] rlot, are you using PHPStorm or something similar? [11:12:51] Georggi: Nope, just atom editor [11:13:00] Georggi: Or vim [11:13:20] Georggi: I don't like all of these IDE's [11:13:32] (03Merged) 10jenkins-bot: Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [11:13:34] (03Merged) 10jenkins-bot: Replaced deprecated hook usage [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/329123 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [11:13:36] (03Merged) 10jenkins-bot: Replaced deprecated hook usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/329121 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:13:47] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hook usage (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:15:24] I like IDE's for navigation and static analysis [11:15:24] (03CR) 10Georggi199: [C: 04-1] Replaced deprecated hook usage (032 comments) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:15:32] Reedy: Is line ** Needed? [11:15:35] 99 [11:15:53] I think it has to be moved down [11:16:13] Georggi: Hmm, this code uses content now [11:17:04] (03PS3) 10Filip: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) [11:17:18] Yeah, but you still have one thing that has $text as input, and also I feel like there is unassigned variable there when you firstly set $text as preg_replace() [11:17:40] Georggi: Thanks, fixed [11:18:05] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:18:08] (03CR) 10Georggi199: [C: 04-1] Replaced deprecated hook usage (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:18:27] Argh, just 3 seconds after jenkins [11:19:32] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: AkismetKlick cleanup - https://phabricator.wikimedia.org/T154107#2901363 (10Reedy) [11:20:32] (03PS4) 10Filip: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) [11:21:17] Uh, let me clone this one, there may be one more thing to be done [11:21:46] Georggi: ? [11:21:48] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: AkismetKlik cleanup - https://phabricator.wikimedia.org/T154107#2901389 (10Reedy) [11:21:53] Georggi: See also T154107 I filed above :P [11:21:54] T154107: AkismetKlik cleanup - https://phabricator.wikimedia.org/T154107 [11:22:49] If someone wants to do that next... I'm happy to push it as a rough and ready GCI task [11:23:13] (03PS1) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [11:23:13] rlot, name of function is $akismet->setCommentContent( $text ), it is Content so there may be something to be simplified [11:24:07] Reedy, if you review my task:) [11:24:19] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:24:25] Georggi: It wasn't submitted when I last refreshed ;) [11:24:35] 10MediaWiki-Database, 05MW-1.28-release-notes, 05MW-1.29-release-notes, 13Patch-For-Review: $wgDBmwschema = "mediawiki" breaks wiki on git HEAD using mysql - https://phabricator.wikimedia.org/T148956#2901392 (10Paladox) This should now be fixed. Can we close this as resolved? [11:24:54] rlot, sorry, I was wring, nothing else to be done. [11:25:07] setCommentContent was a bit missleading:) [11:25:07] Georggi: Yep, it uses text [11:25:30] Georggi: It need text content [11:26:13] (03PS2) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [11:26:28] (03CR) 10Filip: "@Reedy: Looks unrelated ?" [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:26:41] I mean, setCommentText would be more understandable [11:27:18] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:27:50] rlot, why is the whole file set as changed? [11:28:24] (03CR) 10jenkins-bot: Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [11:28:38] Web Editor? [11:28:54] (03CR) 10Reedy: "Looks to be, but the problem seems to be XmlContent isn't in the AutoLoader... Want to fix that as you're going through? :)" [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:28:55] Georggi: For this one, yes [11:29:26] Reedy: Ok, I'll fix it [11:30:48] BTW, why are you using web editor? [11:30:59] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901393 (10Reedy) [11:31:16] Georggi: For this one, its simplier to fix whitespace error [11:31:24] heh [11:31:35] I just don't like when it shows whole file changed. [11:32:25] Reedy, did you publish the task? [11:32:32] Georggi: Nope [11:32:50] Can if you want... Though, we should get rlot's patch merged before so not to conflict it :) [11:33:05] Oh, crap [11:33:07] I can create tasks [11:33:10] I can't publish them though [11:33:12] * Reedy grumbles [11:33:15] (03PS3) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [11:33:35] Reedy: Ok, got it [11:34:01] rlot: Hopefully :). It's good practice to fix little things like that in passing if we can [11:34:12] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:34:15] If it was a seriously broken test, or required a lot of other work, I wouldn't expect you to do so [11:34:15] lol [11:34:45] Reedy: Hmm [11:34:50] rlot: Forgot to git add the file you added the autoload entry in? [11:35:03] Should be added to XMLContentExtension.php [11:35:06] Uhh, so many style issues in it:) [11:35:08] Reedy: Yeah, forgoted [11:35:11] :D [11:35:22] Georggi: I don't mind tabs or spaces [11:35:26] I just hate when they're mixed [11:35:36] Pick one [11:35:37] Just be consistent [11:35:43] (03PS4) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [11:36:05] Reedy: TABS is simplier to use [11:36:36] heh [11:36:41] Do we know who else are GCI admins? [11:36:57] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:36:59] other than andre [11:37:12] Well, not only them, I also mean like spaces in brackets before and after variables [11:37:20] Nemo and Florian? [11:37:25] I believe [11:37:56] Not sure [11:38:03] I thought Nemo wasn't this year? [11:40:01] What's the better way, other then just ask him?:) [11:40:10] i did [11:40:11] um [11:41:17] I mean, tag them, Nemo_bis? [11:44:45] (03CR) 10Reedy: "recheck" [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:46:04] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:46:12] Georggi: I can't approve the task but as usual you can do it and it will be approved/counted later [11:46:27] Or at least I saw some mentors do it this year too [11:47:02] Andre has been cautious about having students have code uploaded before the task was there [11:47:33] There have been cases of duplicate work and fights for tasks, which is not pleasant [11:47:53] Georggi: of course if you also fix spacing to respect https://www.mediawiki.org/wiki/CC/PHP completely people won't be unhappy :) [11:49:03] helpful.. https://www.mediawiki.org/wiki/Google_Code-in_2016 doesn't list admins [11:49:49] Reedy: Hmm [11:52:01] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2901405 (10IKhitron) I have always the last Firefox, but I don't see such problems, so it's not for all FF users. [11:53:57] My dev wiki isn't playing nice today [11:54:05] (03PS1) 10Tim Landscheidt: Do not ignore .mli files [extensions/Math] - 10https://gerrit.wikimedia.org/r/329126 [11:54:16] (03PS5) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [11:54:47] Reedy: I think that should fix it [11:54:52] (03CR) 10Tim Landscheidt: "The .mli files are not compiled sources; I have submitted I1eee6b46f8f81a7a0085901f602eb7a1f4ae6fd4 to fix that." [extensions/Math] - 10https://gerrit.wikimedia.org/r/3720 (owner: 10TheDJ) [11:55:13] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2901406 (10Reedy) Got it again ``` ( ! ) Fatal error: Maximum execution time of 120 seconds exceeded in /var/www/wiki/medi... [11:55:22] Reedy: Someone forgot to change class name [11:55:27] heh [11:55:29] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:55:34] Nope [11:55:36] or no [11:55:46] rlot: There can be many links to the same file for different classes [11:55:56] (03CR) 1001tonythomas: [C: 04-1] "Still need fixes from @Reedys previous comments." (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) (owner: 10Pppery) [11:56:07] (03CR) 10Tim Landscheidt: "TIL: "git rm -r --cached . && git add . && git status"." [extensions/Math] - 10https://gerrit.wikimedia.org/r/329126 (owner: 10Tim Landscheidt) [11:56:13] ReedyL There's only one class in this file [11:56:19] Ok, sure :) [11:56:28] (03PS6) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [11:56:55] Reedy: Maybe its was in wrong order [11:56:59] Order doesn't matter [11:57:06] rlot: Tried running the core tests on your wiki with the extension enabled? [11:57:24] Reedy: php test? [11:57:32] yeah, phpunit [11:57:35] (03CR) 10jerkins-bot: [V: 04-1] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:57:41] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-preferences, 13Patch-For-Review, 07Wikimedia-log-errors: Users with unknown or bad timezones can't log in - https://phabricator.wikimedia.org/T137182#2901407 (10TTO) a:03TTO [11:57:47] (03CR) 1001tonythomas: [C: 04-1] Make `Special:Newsletter/id/subscribers` editable. (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) (owner: 10Pppery) [11:57:59] Reedy: Its unrelated to my changes. Hmm [11:58:05] I know it is [11:58:07] But it'd be nice to get it fixed [11:58:15] Reedy: Yep, I know [11:58:18] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 07I18n: Allow users to code in localized programming languages - https://phabricator.wikimedia.org/T150417#2901410 (10Psychoslave) Thank you @MZMcBride for taking time to invistigate and report about this topic. For complete reference it see... [11:58:51] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901411 (10Reedy) [11:59:18] Reedy: If class is auto-loaded, there's no need to import it? [11:59:31] import is only needed if it's namespaced [11:59:37] And you don't want to use the full qualified name [12:00:14] XmlContent.class.php is in the same file as XmlContentHandler.php [12:00:23] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901393 (10Reedy) [12:00:33] same folder [12:00:44] Reedy: So there should be access via XmlContent( [12:01:56] 10MediaWiki-API, 06Commons: Make limited information from filearchive available to everyone - https://phabricator.wikimedia.org/T60993#2901415 (10zhuyifei1999) This has long since available on the replicas, see eg. {T71088} What's the blocker here? [12:03:43] rlot: I.. can't reproduce it locally [12:03:56] Reedy: Jenkins? [12:04:07] Reedy: But its wierd [12:04:17] Jenkins should run on the same configuration [12:04:25] Oh, wait [12:04:27] Yeah I can [12:04:32] apparently wildcards don't work [12:04:40] 1) ContentHandlerSanityTest::testMakeEmptyContent with data set #11 (XmlContentHandler Object (...)) [12:04:40] Error: Class 'XmlContent' not found [12:04:44] well, that's without your patch :P [12:04:50] let's bring that in [12:05:20] yup, still broken [12:05:54] Reedy: Hmm, files are loaded in XMLContentExtension.php [12:06:05] cat /var/www/wiki/mediawiki/extensions/XMLContentExtension/include/XMLContent.class.php [12:06:05] cat: /var/www/wiki/mediawiki/extensions/XMLContentExtension/include/XMLContent.class.php: No such file or directory [12:06:07] (03CR) 10Paladox: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329080 (owner: 10L10n-bot) [12:06:09] rlot: Have you typoed? [12:06:10] 10MediaWiki-API, 06Commons: Make limited information from filearchive available to everyone - https://phabricator.wikimedia.org/T60993#2901432 (10zhuyifei1999) Uh nevermind this task is about the API [12:06:21] (03CR) 10Paladox: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329080 (owner: 10L10n-bot) [12:06:26] rlot: XML != Xml [12:06:47] Ohh, [12:06:51] always the same [12:06:52] The extension is very inconsistent [12:06:54] some XML [12:06:55] some xml [12:06:58] :) [12:08:02] (03PS7) 10Filip: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) [12:08:46] That's better [12:08:48] Reedy: Always, when something don't work, I spent hours on searching, asking stackoverflow, itp. And its just typo [12:09:29] Reedy: Ok, can you take a look at https://gerrit.wikimedia.org/r/#/c/329122/ [12:09:43] Yaay [12:10:06] Reedy: succeeded! [12:10:23] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901435 (10Reedy) [12:11:46] (03CR) 10Reedy: [C: 032] Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:12:57] (03Merged) 10jenkins-bot: Replaced deprecated hook usage [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329125 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:13:01] Reedy: Submited on GCI [12:14:17] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hook usage (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:14:29] :P [12:14:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329080 (owner: 10L10n-bot) [12:14:58] (03PS5) 10Filip: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) [12:15:31] Reedy: Ok, When these cleanup task will be published? [12:15:38] Dunno [12:15:43] andre__: Are you here? [12:15:44] I need to find someone who can publish them :( [12:15:49] He's not in the channel, no [12:15:58] I will let you know when I see andre__ around here [12:15:58] @notify andre__ [12:16:03] Hence asking who else is a GCI admin [12:16:39] FlorianSW! [12:16:43] That was creepy [12:16:48] Reedy1 [12:16:52] What? [12:16:56] FlorianSW: Are you a GCI admin? :P [12:17:06] Reedy: possible :P [12:17:16] Apparently Georggi and rlot don't want to stop today [12:17:29] ;) [12:17:36] [12:16:03] Hence asking who else is a GCI admin [12:17:36] [12:16:18] --> FlorianSW (~FlorianSW@wikimedia/florianschmidtwelzow) has joined #wikimedia-dev [12:17:36] [12:16:39] FlorianSW! [12:17:41] stop doing what? [12:18:02] Stop doing GCI tasks [12:19:54] Reedy: Fixed "AkismetKlik" [12:20:36] Reedy: but isn't that a good thing :D Probably they should take some time with the family, it's christmas time :D @rlot @Georggi :P [12:20:50] FlorianSW: Depends if I'm allowed a day off [12:20:54] I am from Ukraine, we don't have Christmas right now:)) [12:21:01] FlorianSW: I'm just annoyed I can't publish tasks for them ;) [12:21:13] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hook usage (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:21:26] That wasn't supposed to be a C: -1 [12:21:30] (as an answer to [12:16:03] Hence asking who else is a GCI admin) Ok, I swear I joined just because I started my PC, but that's really creepy :P [12:21:39] heh [12:21:48] FlorianSW: Not see my bat signal!? [12:21:50] :( [12:22:13] Reedy: This line seems really unneeded [12:22:26] I just see a big "R" in the air :( :P [12:22:34] (03PS6) 10Filip: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) [12:22:44] Reedy: Ok, got it also [12:22:46] Reedy: can I publish some tasks for you? :P [12:23:11] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901444 (10Reedy) https://codein.withgoogle.com/dashboard/tasks/4755614267867136/ [12:24:32] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: AkismetKlik cleanup - https://phabricator.wikimedia.org/T154107#2901445 (10Reedy) https://codein.withgoogle.com/dashboard/tasks/6429019358625792/ [12:24:40] FlorianSW: ^ Those two for now would be great [12:25:32] (03CR) 10Reedy: [C: 032] Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:25:56] rlot: You need to resubmit the task on GCI [12:26:14] Reedy: done [12:26:40] (03Merged) 10jenkins-bot: Replaced deprecated hook usage [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:27:33] FlorianSW: I do also have two other tasks outstanding... https://codein.withgoogle.com/dashboard/tasks/5203015877263360/ and https://codein.withgoogle.com/dashboard/tasks/5670259598032896/ [12:28:42] So much for german efficiency [12:28:49] (03CR) 10TheDJ: [C: 032] Use OOUI for confirm dialog [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/326121 (owner: 10Esanders) [12:30:19] (03Merged) 10jenkins-bot: Use OOUI for confirm dialog [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/326121 (owner: 10Esanders) [12:30:35] rlot: Have you seen https://codein.withgoogle.com/dashboard/org-students/ ? :P [12:34:36] Reedy, I believe it is for mentors:) [12:34:50] aha [12:35:07] Yeah, empty list for me [12:36:04] Reedy: Hmm, empty for me [12:36:07] rlot is a long way ahead [12:36:09] haha [12:36:28] Georggi: You're in joint third :) [12:36:40] Well, numbers are not the main thing [12:36:56] No, it's not [12:37:05] But unfortunately, that is how prizes are dished out [12:37:18] Still plenty of time :) [12:37:18] Reedy: I try to make all of tasks quality [12:37:57] Reedy, are they, I believe admins also decide on communication as well as quality and other things [12:37:59] Unfortunately, the task doesn't really tell you how much complexity... [12:38:26] It's just that you have to be in top-10 by tasks, in order to be eligible for being a finalist [12:38:42] (At least it was like this last year) [12:38:52] Yeah [12:38:58] It can't just be done on quantity [12:39:14] Never really been involved in the judging [12:39:19] (03PS3) 10TheDJ: Use OOUI for prompt dialog [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/326128 (owner: 10Esanders) [12:39:41] Reedy, what is with that task? is it up? [12:39:47] I'm waiting on FlorianSW [12:39:51] * Reedy coughs LOUDLY [12:40:08] Got a few of my tasks to be published [12:40:17] I can review some other peoples ones too [12:40:33] Reedy What tasks? Links, links, I need links! :D [12:40:37] FlorianSW: I sent [12:40:39] You timed out [12:40:42] I cried [12:40:49] and I reconnected :P [12:40:54] FlorianSW: I do also have two other tasks outstanding... https://codein.withgoogle.com/dashboard/tasks/5203015877263360/ and https://codein.withgoogle.com/dashboard/tasks/5670259598032896/ [12:40:57] FlorianSW: [12:41:03] https://codein.withgoogle.com/dashboard/tasks/4755614267867136/ https://codein.withgoogle.com/dashboard/tasks/6429019358625792/ https://codein.withgoogle.com/dashboard/tasks/5203015877263360/ https://codein.withgoogle.com/dashboard/tasks/5670259598032896/ [12:43:29] Reedy: the first two ones are now published (even if I agree with andre, that the SimpleSecurity may be waste of time, however, it's a good chance to learn for GCI students :)) [12:43:47] Yeah... It's an easy [12:43:48] But meh [12:44:31] But these clean-up tasks sounds intresting [12:44:39] agreed! I also published the other ones :) [12:44:54] FlorianSW: It's funny, getting people to do GCI tasks are finding more [12:45:27] "AkismetKlik cleanup" claimed [12:45:29] I'm glad to see both, you and our GCI students, having fun with this! That's why I don't want to block you all :P [12:45:36] Georggi: Tasks are up! [12:45:53] FlorianSW: Are you in SF btw? [12:45:57] (in Jan) [12:46:08] I've claimed one already [12:46:24] There's more ContentHandler stuff to be done... [12:46:28] Not many functions [12:46:31] But loads of hooks [12:46:34] Reedy: not yet, but in January, yes :D [12:46:48] and you? [12:46:49] ay [12:46:52] yay [12:47:13] I set off on the 5th [12:47:15] (03CR) 10Jack Phoenix: [WIP] Convert to newer extension registration (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) (owner: 10SamanthaNguyen) [12:47:18] Reedy: In akismetKlik? I preffer codeing, than making tabs/spaces conversions :) [12:47:31] going via Scotland... Oslo, Helsinki [12:48:02] and back to the UK again before going to the USA [12:48:02] xD [12:48:30] (03CR) 10TheDJ: [C: 032] Do not ignore .mli files [extensions/Math] - 10https://gerrit.wikimedia.org/r/329126 (owner: 10Tim Landscheidt) [12:48:59] rlot: tab -> spaces or back is easy with the right tool ;) [12:49:02] (03CR) 10Jack Phoenix: "Oops, missed one thing." (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329027 (https://phabricator.wikimedia.org/T152862) (owner: 10SamanthaNguyen) [12:49:07] Ohh, rlot, oups, somebody forgot to rename $editPage in phpdocs:) [12:49:23] Didn't that get done? [12:49:28] I'm sure I asked for it to be fixed.... [12:49:30] Georggi: Fixed [12:49:37] Georggi: You look at wrong ps [12:49:59] I look at what I pulled from master branch;) [12:50:37] rlot: Georggi is right [12:50:37] https://gerrit.wikimedia.org/r/#/c/329122/6/AkismetKlik.php [12:50:48] (03CR) 10Georggi199: Replaced deprecated hook usage (031 comment) [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/329122 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:50:48] I thought it had been [12:50:50] Reedy: I tought i fixed that [12:50:51] Not a big deal :P [12:50:58] I'll upload new patchset [12:51:00] I'll fix it [12:51:08] It is already merged [12:51:26] (03CR) 10TheDJ: [C: 032] Function docs for Hooks [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/327013 (owner: 10Reedy) [12:51:32] can be fixed while doing the cleanup ;) [12:51:47] (03PS1) 10Tim Landscheidt: Fix "make texvccheck" in top-level Makefile [extensions/Math] - 10https://gerrit.wikimedia.org/r/329127 [12:52:07] Georggi: Do you claimed this akisment task? I clicked button, but its not showing [12:52:18] I did [12:52:30] Georggi: Great [12:52:41] Georggi: So i'll do this Xml [12:53:25] Georggi: Reedy: Don't trust web editor [12:53:58] heh [12:56:35] (03Merged) 10jenkins-bot: Do not ignore .mli files [extensions/Math] - 10https://gerrit.wikimedia.org/r/329126 (owner: 10Tim Landscheidt) [12:56:37] (03Merged) 10jenkins-bot: Function docs for Hooks [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/327013 (owner: 10Reedy) [12:58:04] (03PS1) 10Tim Landscheidt: Remove unused Makefile variable "DIRS" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329128 [12:58:42] (03CR) 10Reedy: [C: 032] Sync video.js version in package.json to what's in the repo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/326434 (owner: 10Reedy) [12:58:46] (03PS2) 10Reedy: Sync video.js version in package.json to what's in the repo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/326434 [13:01:46] 10MediaWiki-extensions-Other, 06Community-Tech, 07Technical-Debt: LoginNotify cleanup - https://phabricator.wikimedia.org/T151414#2901452 (10Aklapper) [13:04:17] FlorianSW: Well, that's keeping the kids quiet for a bit [13:04:18] xD [13:04:48] :D [13:04:51] Great work! :P [13:09:09] Reedy: Looks like most of code files use tab intend [13:09:12] I'll use it [13:12:23] (03PS4) 10TheDJ: Edit stash: Simplify with postWithToken [core] - 10https://gerrit.wikimedia.org/r/296189 (owner: 10Majr) [13:12:36] 10MediaWiki-Export-or-Import: Special:Export should return 404 on non-existent pages - https://phabricator.wikimedia.org/T5161#2901455 (10TTO) [13:13:13] 10MediaWiki-Export-or-Import: Special:Export should return 404 on non-existent pages - https://phabricator.wikimedia.org/T5161#75246 (10TTO) If so, we need some way to allow export of just the site metadata. Sure, you can get it from the API these days, but not in the same format as the XML dumps. [13:14:39] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901459 (10FilipGCI) a:03FilipGCI [13:15:42] (03CR) 10TheDJ: [C: 032] Fix "make texvccheck" in top-level Makefile [extensions/Math] - 10https://gerrit.wikimedia.org/r/329127 (owner: 10Tim Landscheidt) [13:15:57] 10MediaWiki-Categories, 10Wikimedia-Site-requests, 07Upstream: Improve sorting on Swedish Wikipedia - https://phabricator.wikimedia.org/T125341#2901460 (10Lejonel) [13:16:17] Reedy: Also replace it in ace folder? [13:16:36] ? [13:16:46] Reedy: Jn XMLContentExtension [13:16:53] Its not "Extension" code [13:17:01] so i'll keep it as-is [13:17:17] Reedy: Lots of minified code [13:17:25] Which file? [13:17:50] js/ace/* - all of these files [13:18:03] Merry Christmas to all! :) [13:18:11] MtDu: U2! [13:18:17] Oh.. [13:18:43] Are they just copy pasted in? [13:18:59] Reedy: Looks like that [13:19:09] Reedy: These extension is really [13:19:10] .. [13:19:11] . [13:19:15] 10MediaWiki-Language-converter, 06Reading-Web-Backlog, 10Wikidata, 10Wikidata-Page-Banner, and 2 others: [Spike] Title and TOC not converted for Wikidata page banner language variants - https://phabricator.wikimedia.org/T114734#2901461 (10Liuxinyu970226) [13:19:16] (03CR) 10TheDJ: [C: 032] Remove unused Makefile variable "DIRS" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329128 (owner: 10Tim Landscheidt) [13:19:24] We have a lot of shit in gerrit [13:19:56] Reedy: So, i'll keep these libs as-is [13:19:59] (03Abandoned) 10TheDJ: Don't use img SVGs on Opera 9 and earlier [extensions/Math] - 10https://gerrit.wikimedia.org/r/315654 (https://phabricator.wikimedia.org/T137765) (owner: 10TheDJ) [13:20:03] Yeah, generally don't touch them :) [13:20:13] Going AFK for a while... My little sister wants to go to the nearby pokestop [13:20:26] Reedy, Got any santa claus pikachus? ;) [13:20:29] (03PS1) 10Tim Landscheidt: Remove broken test script texvccheck/test.pl [extensions/Math] - 10https://gerrit.wikimedia.org/r/329129 [13:20:31] MtDu: I did already [13:20:33] I got two! [13:20:38] Never caught a pickachu before [13:20:51] Reedy, what about the Pichus? haha. Apparently there's increased chances today. [13:20:59] Togapei too [13:21:01] Anyways, have fun! [13:21:01] A friend got one [13:21:26] (03CR) 10Tim Landscheidt: ""#!/usr/bin/perl -w", "use strict;", "use warnings;" – always :-)." [extensions/Math] - 10https://gerrit.wikimedia.org/r/329129 (owner: 10Tim Landscheidt) [13:22:59] Reedy: Btw, these libs are don't used anywhere [13:23:00] wierd code [13:23:03] really wierd [13:23:23] XMLContentExtension.resources.php [13:23:39] rlot: it is [13:23:40] $output->addModules('ace'); [13:24:12] (03Merged) 10jenkins-bot: Fix "make texvccheck" in top-level Makefile [extensions/Math] - 10https://gerrit.wikimedia.org/r/329127 (owner: 10Tim Landscheidt) [13:24:14] (03CR) 10jerkins-bot: [V: 04-1] Remove unused Makefile variable "DIRS" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329128 (owner: 10Tim Landscheidt) [13:24:22] (03CR) 10Aklapper: "Indeed https://phabricator.wikimedia.org/T149637#2896031 got merged in the meantime. In terms of this Gerrit patch it is your (shared) bus" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [13:27:55] Reedy: XMLContentExtension is not in extension registry [13:27:58] Add that? [13:32:03] 10UI-Standardization, 06Multimedia, 10TimedMediaHandler-Player, 13Patch-For-Review: Align Wikimedia's video/audio player with WikimediaUI color palette - https://phabricator.wikimedia.org/T154072#2900239 (10TheDJ) It's less stalled than the old player is ;) [13:32:59] (03CR) 10Tim Landscheidt: "@TheDJ: Thanks, that was quick :-). Unfortunately, it means that I must admit in a follow-up commit that I did not see texvccheck/.gitign" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329126 (owner: 10Tim Landscheidt) [13:34:03] (03PS3) 10TheDJ: Use styles to hide player controls [extensions/Score] - 10https://gerrit.wikimedia.org/r/289323 (https://phabricator.wikimedia.org/T135537) [13:34:33] (03CR) 10Fomafix: [V: 04-1 C: 04-1] "Therefor you made a mistake on rebase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [13:35:34] (03PS2) 10Tim Landscheidt: Remove unused Makefile variable "DIRS" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329128 [13:35:45] What type of extension is AkismetKlik(Where to see that?) [13:39:04] Georggi: Is it not on gerrit project list? [13:39:14] Maybe check the github, and see if it's instead hosted over there. [13:40:05] (03PS1) 10Tim Landscheidt: Do not ignore all .mli files in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/329130 [13:40:52] Don't see anything refarding type of it. [13:40:54] (03PS1) 10Filip: XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) [13:42:54] Reedy: Woow, jenkins passed [13:43:41] (Why jenkins messages are not showing now in wikibugs IRC)? [13:46:30] Georggi: If type is not specified, you can just use type: other [13:46:42] Well, did that already [13:47:00] 10MediaWiki-Watchlist: Watchlist entries from the logs cannot be marked as visited - https://phabricator.wikimedia.org/T100905#2901470 (10Stevietheman) I can confirm this issue with respect to an IP user I am watching. I can't get rid of the block log entry in my watchlist, and I don't want to use the "nuclear... [13:47:43] How is my gerrit account linked with my github? [13:48:08] Uploaded code to gerrit, code get merged, and now I see i contribute to this repo on my git account [13:48:12] Amazing [13:51:38] 10MediaWiki-Page-protection: Incorrect label used in tabs/menus about creation protection: Says "protect" instead of "change protection" - https://phabricator.wikimedia.org/T154046#2901476 (10Aklapper) [13:51:45] How to use reqire_once in extension registry script? [14:01:45] (03PS8) 10Pppery: Make `Special:Newsletter/id/subscribers` editable. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) [14:15:08] (03CR) 10TheDJ: [C: 032] Do not ignore all .mli files in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/329130 (owner: 10Tim Landscheidt) [14:17:51] 10Phabricator (Upstream), 07Upstream: T118874 has duplicate actions (closing the task twice) - https://phabricator.wikimedia.org/T154066#2901484 (10Aklapper) p:05Triage>03Lowest Mid-air collision - both actions show the same time: "Fri, Dec 23, 21:35". Duplicate of {T78236} ? [14:20:39] (03CR) 10TheDJ: [C: 032] Remove unused Makefile variable "DIRS" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329128 (owner: 10Tim Landscheidt) [14:24:49] (03Merged) 10jenkins-bot: Do not ignore all .mli files in texvccheck [extensions/Math] - 10https://gerrit.wikimedia.org/r/329130 (owner: 10Tim Landscheidt) [14:28:38] (03Merged) 10jenkins-bot: Remove unused Makefile variable "DIRS" [extensions/Math] - 10https://gerrit.wikimedia.org/r/329128 (owner: 10Tim Landscheidt) [14:32:33] MtDu: Do you use any IRC bouncer? [14:32:47] rlot: No, I just use an IRC client. [14:33:00] MtDu: I'm trying to setup ZNC on my raspberry pi zero [14:36:23] Trying to modify code, to blink a led when pinged [14:51:09] test [15:14:52] (03PS6) 10TheDJ: Don't allow scratch tokens when enrolling for 2 auth. [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) [15:17:34] (03CR) 10TheDJ: "@Reedy I found the cause. verifyToken assumes that the user is already enrolled whenever a scratch code is used. It was persisting the new" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) (owner: 10TheDJ) [15:33:30] (03CR) 10TheDJ: [WIP] Use AuthManager data change methods (032 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/294861 (https://phabricator.wikimedia.org/T110457) (owner: 10Gergő Tisza) [15:47:46] (03CR) 10Fomafix: Don't allow scratch tokens when enrolling for 2 auth. (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) (owner: 10TheDJ) [15:52:18] 10Wikimedia-Wikimania-Scholarships: Create a means to separate links and other non-translated content from messages - https://phabricator.wikimedia.org/T152974#2865197 (10Wargo) Wsa-form-intro-faq has bad link - double colon. [15:55:06] (03CR) 10Fomafix: Add button to copy share/embed text to clipboard (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [16:02:01] rlot: Email address. If you have it linked on your github account, it shows up :) [16:02:36] Reedy: How'd it go? [16:02:49] MtDu: She'd run out of pokeballs already [16:02:53] RIP [16:02:56] So was kinda pissed off she couldn't catch anything [16:03:07] Lol. $1 for 20 balls. [16:03:07] But she got maybe 5 or 6 pokestop visits [16:03:09] And some eggs [16:03:13] Nah, don't spend money on it [16:03:23] Ever heard of GPS Spoofing? [16:03:29] My friends all got banned caz of it haha. [16:03:41] It doesn't seem to work on Android [16:03:50] I use Fly GPS [16:03:56] When I actually played. [16:03:59] apparently, it works alright on rooted [16:04:09] But on non rooted, the os exposes that it's a fake location through it's API [16:04:12] They took it off play store. But I downloaded it before then, so I still have it. [16:04:27] Well, I haven't tried for a month or two. [16:05:14] It'd be an easy fix for them [16:05:19] Sure you can find the APK if you really wanted [16:05:34] I've got a physical GPS device... But not good for faking ;) [16:08:28] 10The-Wikipedia-Library: Implement minimum wikipedia account quality for account creation on TWL - https://phabricator.wikimedia.org/T147439#2901494 (10ThatAndromeda) Yes, we can get this from OAuth and Alex Stinson confirmed for me a while ago that it is a good plan. It is hard to make this customizable by too... [16:11:13] Do I have CR to do? [16:11:49] (03CR) 10Reedy: "Thanks :) I'll test it again in a bit!" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) (owner: 10TheDJ) [16:17:50] (03CR) 10Reedy: [C: 04-1] XMLContentExtension cleanup (032 comments) [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) (owner: 10Filip) [16:20:41] (03CR) 10Reedy: [C: 031] "recheck" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:21:41] (03CR) 10jerkins-bot: [V: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:27:42] (03PS2) 10Filip: XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) [16:27:55] Reedy: Ok, got it [16:29:14] Reedy: Btw, what editor do you use? [16:29:22] Depends what I'm doing [16:29:27] Mostly nano and/or PhpStorm [16:29:49] Reedy: Do you use linux? [16:30:00] I use Windows, macOS and Linux regularly [16:30:07] vim rulez [16:34:06] (03PS1) 10MtDu: Add missing API i18n messages: [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) [16:35:16] (03CR) 10jerkins-bot: [V: 04-1] Add missing API i18n messages: [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) (owner: 10MtDu) [16:37:05] Reedy: Btw, why is the code in NSFunctions.php commented? [16:43:50] (03CR) 10Filip: "Those jenkins fails are unrelated, something in this extension is broken. https://gerrit.wikimedia.org/r/#/c/327305/" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) (owner: 10MtDu) [16:44:48] (03CR) 10Reedy: [C: 04-1] XMLContentExtension cleanup (031 comment) [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) (owner: 10Filip) [16:46:09] (03CR) 10Reedy: "No, that's what he's trying to fix, by adding/moving the messages to replace the ones that are showing as missing" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) (owner: 10MtDu) [16:51:52] (03PS3) 10Filip: XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) [16:52:04] Reedy: Ok, i think thats it [16:52:47] (03CR) 10jerkins-bot: [V: 04-1] XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) (owner: 10Filip) [16:53:28] rlot: jerkins says no :P [16:53:45] Reedy: Looking now, i used auto indent so its possible [16:56:15] Reedy "PHP Parse error: syntax error, unexpected '' (T_ENCAPSED_AND_WHITESPACE), expecting identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in XMLContentExtension.hooks.php on line 553" [16:56:24] Reedy: But line 553 looks good for me [16:56:50] if(isset($GLOBALS['templateObj'])) { [16:57:43] sometimes, it's not the line you expect [16:58:43] rlot: php -l locally on that file? [16:59:15] Reedy: Same [16:59:22] let's see what phpstorm says [16:59:29] Reedy: I think its issue with these html code [16:59:32] probably [17:01:10] rlot: try... [17:01:13] unintent after << to the EOD; [17:01:24] unindent completely [17:01:31] in one line? [17:01:44] 531-543 [17:02:16] Reedy: Thanks you! [17:02:27] <<< is magic syntax [17:02:36] (03PS4) 10Filip: XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) [17:02:46] Reedy: ^^ [17:03:02] wait for jenkins to say yay or nay [17:04:07] Reedy: passed [17:04:11] :) [17:04:16] I'll give it another look over [17:09:57] (03CR) 10Reedy: [C: 032] XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) (owner: 10Filip) [17:10:06] Reedy: Yeey! [17:10:24] Reedy: Submited on GCI [17:10:58] (03Merged) 10jenkins-bot: XMLContentExtension cleanup [extensions/XMLContentExtension] - 10https://gerrit.wikimedia.org/r/329131 (https://phabricator.wikimedia.org/T154109) (owner: 10Filip) [17:12:39] 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review: XMLContentExtension cleanup - https://phabricator.wikimedia.org/T154109#2901504 (10Reedy) 05Open>03Resolved [17:13:11] Reedy "(NewsletterStore|NewsletterDb)::(addSubscription|removeSubscription) should take in an array of user_ids (Wikimedia)" [17:13:22] Yeah? [17:13:27] Oh... [17:13:34] Did the other patch get merged? [17:13:43] Reedy: No [17:13:54] Reedy: This subscribers... [17:14:06] I think we can still do it [17:14:17] Reedy: Cherry-pick? [17:14:26] Well, you can do it ontop of that patch [17:14:34] Or, if we get yours merged, we can fix the other quite easily [17:16:02] (03CR) 10Reedy: [C: 032] Sync video.js version in package.json to what's in the repo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/326434 (owner: 10Reedy) [17:16:04] (03PS2) 10MtDu: Add missing API i18n messages: [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) [17:19:21] (03CR) 10Reedy: [C: 032] Add missing API i18n messages: [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) (owner: 10MtDu) [17:26:03] (03Merged) 10jenkins-bot: Sync video.js version in package.json to what's in the repo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/326434 (owner: 10Reedy) [17:26:05] (03Merged) 10jenkins-bot: Add missing API i18n messages: [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/329132 (https://phabricator.wikimedia.org/T153264) (owner: 10MtDu) [17:37:33] Welcome back [17:38:10] Reedy: What, if someone upload new patchset? [17:38:29] rlot2_: On what? [17:38:57] Reedy: on https://gerrit.wikimedia.org/r/#/c/329055/6/includes/specials/SpecialNewsletter.php [17:39:25] Anyone else can do that [17:39:37] If you want to fix that up after [17:39:55] Reedy: I should cherry-pick this patch? [17:39:59] You don't have to [17:40:03] You can just do yours on master [17:40:07] We can merge it, and fix up theirs [17:40:22] Reedy: Ok! Thanks [17:41:20] (03CR) 10Florianschmidtwelzow: [C: 032] "Thanks for your contribution! Just for a little bit of background information:" [core] - 10https://gerrit.wikimedia.org/r/329117 (https://phabricator.wikimedia.org/T112693) (owner: 10Phantom42) [17:41:49] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 3 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#2901507 (10Florian) 05Open>03Resolved a:03Phantom42 [17:42:33] 10Social-Tools, 10SocialProfile, 03Google-Code-In-2016, 07I18n, 13Patch-For-Review: SocialProfile missing api i18n messages - https://phabricator.wikimedia.org/T153264#2901509 (10Reedy) 05Open>03Resolved a:03MtDu [17:45:28] Apparently I have 30 open tasks to mentor [17:48:12] nope. 5 instances [17:49:54] (03Merged) 10jenkins-bot: Fix rendering issues on RecentChanges Special page [core] - 10https://gerrit.wikimedia.org/r/329117 (https://phabricator.wikimedia.org/T112693) (owner: 10Phantom42) [17:58:24] (03CR) 10jenkins-bot: Fix rendering issues on RecentChanges Special page [core] - 10https://gerrit.wikimedia.org/r/329117 (https://phabricator.wikimedia.org/T112693) (owner: 10Phantom42) [18:03:04] 10AntiSpoof: Adding "ı" as an i alternative in antispoof - https://phabricator.wikimedia.org/T149785#2762601 (10DatGuy) Has this not always been an alternative? See [[ https://gerrit.wikimedia.org/r/#/c/38902/2/maintenance/equivset.php | equivset ]] [18:03:28] Reedy: removeSubscription( Should'nt accept npw "User" [18:04:02] Just swap it to userids? Yeah [18:04:08] User objects don't add anything [18:15:41] Reedy: database->delete( can take array of arrays? [18:15:58] Depends [18:16:18] Reedy: [18:16:19] for conds... [18:16:19] foreach ( $user_ids as $user_id ) { [18:16:19] $rowData += array( [18:16:36] [ 'colname' => [ 1, 2, 3, 4 ] ] [18:16:58] tbh [18:17:06] for the patch we'll need to change.. [18:17:12] we'll already have an array of user ids [18:17:25] so we can just pass it through and into the db query quite easily [18:21:20] Reedy: Hmm, so i can pass array to 'nls_subscriber_id' => [18:21:29] yup [18:22:47] Reedy: Btw, add_subscriptions should also use array of ids [18:22:59] Reedy: Also fix it? [18:23:00] rlot2_: Hence the title [18:23:23] (NewsletterStore|NewsletterDb)::(addSubscription|removeSubscription) [18:23:28] rlot2_: It's vaguely regex :) [18:23:38] Oh, missed it! Thanks [18:24:01] heh [18:24:11] Basically, when you work out how to do one, doing it for hte other is trivial :) [18:26:14] (03CR) 10Phantom42: "Thank you for your explanation! As I see, everything is just as I thought." [core] - 10https://gerrit.wikimedia.org/r/329117 (https://phabricator.wikimedia.org/T112693) (owner: 10Phantom42) [18:27:35] Reedy: Unsubscribe in Newsletter.php? [18:27:44] ? [18:28:14] Reedy: Also uses user only for getId() [18:28:46] What are you wanting me to look at? [18:29:21] Reedy: I'll paste pastebin [18:29:48] Reedy: Nevermind, it uses also other functions [18:36:21] (03PS3) 10Reedy: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [18:38:10] Reedy: Looks like [18:38:11] $rowData = array( [18:38:11] 'nls_newsletter_id' => $newsletter->getId(), [18:38:11] 'nls_subscriber_id' => $user_ids [18:38:11] ); [18:38:37] Reedy: Can't just pass array [18:38:48] Why can't you? [18:39:08] Oh.. [18:39:11] For add... [18:39:55] (03PS1) 10MtDu: Move a few SimpleSecurity classes to separate files [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/329135 (https://phabricator.wikimedia.org/T153266) [18:41:00] Reedy: ? [18:41:39] You change it to not doing all the seperate inserts [18:43:18] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [18:44:19] Reedy: Its called only once [18:44:25] Yes, currently [18:44:26] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [18:44:36] In the patch we were talking about, it's called in a loop [18:44:51] Reedy: So why it don't work. I'm testing just subscribe functionality [18:44:55] (03CR) 10Victorbarbu: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [18:45:00] Because you did it wrong? :) [18:45:52] you'll need to pass to insert() for the second parameter... [ [ newsletterid, userid ], [ newsletterid, userid2 ] ] [18:46:07] Reedy: Loop it? [18:46:19] Ah, got it [18:46:52] hmm [18:46:54] maybe not quite [18:47:16] needs some keys [18:48:12] Syntax is a bit funky [18:48:35] Reedy: Hmm, passed array of arrays, still wrong [18:49:20] [ [ 'colname' => value, 'col2name' => value2 ], [ 'colname' => value, 'col2name' => value3 ] ] [18:49:53] yeah, that looks right [18:50:18] pass the newsletter id and a list of user ids through [18:50:19] so its array( array( newsletter_id, subscriber_id ), array( ... ) ... ) [18:50:26] 10MediaWiki-extensions-TitleBlacklist, 10Wikimedia-General-or-Unknown: Editing session issue (TitleBlacklist related?) on *.wikipedia.org for Kvardek du - https://phabricator.wikimedia.org/T154112#2901543 (10Dereckson) [18:50:32] newsletter id only once? [18:50:40] yeah [18:50:49] where MW is going to do the insert... foreach over it and build the eventual rows to inser [18:50:53] $rows = []; [18:51:29] foreach( $user as $u ) { $rows[] = [ 'newsletter_id' => $newsID, 'user_id' => $u ]; } [18:51:40] then you can call insert once [18:51:55] (03PS5) 10Sn1per: Add button to copy share/embed text to clipboard [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) [18:52:39] (03CR) 10Reedy: [C: 032] Move a few SimpleSecurity classes to separate files [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/329135 (https://phabricator.wikimedia.org/T153266) (owner: 10MtDu) [18:52:58] 10MediaWiki-extensions-SimpleSecurity, 03Google-Code-In-2016, 13Patch-For-Review: Move SimpleSecurity classes to separate files - https://phabricator.wikimedia.org/T153266#2901555 (10Reedy) 05Open>03Resolved a:03MtDu [18:53:50] (03Merged) 10jenkins-bot: Move a few SimpleSecurity classes to separate files [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/329135 (https://phabricator.wikimedia.org/T153266) (owner: 10MtDu) [18:54:03] (03PS1) 10Fomafix: Remove attribute lang from #firstHeading [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/329136 [18:54:36] FlorianSW, hi [18:54:44] merry christmas guys [18:54:49] victorbarbu: hi :) [18:55:18] Merry Christmas to you too! victorbarbu [18:55:25] MtDu_, thank you! [18:55:29] Reedy: Looks like its wrong [18:55:31] (03CR) 10Florianschmidtwelzow: [C: 031] Replaced Linker::link() & Linker::linkKnown() with LinkRenderer (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329032 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [18:55:34] FlorianSW, thank you for approving that! [18:56:12] rlot2_: ? [18:56:18] Reedy: Hmm, maybe array( newsl_id, array( subs_id ) ) [18:56:27] eh, its also not working [18:56:41] (03CR) 10Florianschmidtwelzow: [C: 032] Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329032 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [18:57:11] victorbarbu: you're welcome! Unfortunately, I wasn't the person who did that, because I wasn't that active over the christmas days :/ [18:57:29] andre__, thank you! [18:57:50] (03Merged) 10jenkins-bot: Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/329032 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [18:58:09] FlorianSW, I hope you'll be active over the next few days [18:58:18] I claimed another of your tasks :P [18:58:23] rlot2_: You want something like https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/backend/CodeRevision.php#L1071-L1085 [18:59:46] (03CR) 10Fomafix: [C: 04-1] Add button to copy share/embed text to clipboard (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [19:01:27] (03PS6) 10Sn1per: Add button to copy share/embed text to clipboard [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) [19:02:22] 10MediaWiki-extensions-TitleBlacklist, 10Wikimedia-General-or-Unknown: Editing session issue (TitleBlacklist related?) on *.wikipedia.org for Kvardek du - https://phabricator.wikimedia.org/T154112#2901560 (10Dereckson) [19:02:22] (03CR) 10Florianschmidtwelzow: Replaced Linker deprecated functions with LinkRenderer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329052 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [19:02:29] (03CR) 10Florianschmidtwelzow: [C: 032] Replaced Linker deprecated functions with LinkRenderer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329052 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [19:04:27] (03CR) 10Florianschmidtwelzow: [C: 032] Add id attribute to error message "mw-error-cannotundelete" [core] - 10https://gerrit.wikimedia.org/r/328943 (https://phabricator.wikimedia.org/T20819) (owner: 10Divadsn) [19:07:52] Reedy: Hmm, looks like thats not a problem [19:08:02] (03CR) 10Fomafix: [V: 04-1 C: 04-1] "When I readd the commented line then the exception does not occur anymore." [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [19:08:06] Reedy: Still don't work [19:08:26] (03CR) 10Sn1per: "Instead of catching any errors from "copy" command not being supported, the copy button isn't included unless the browser claims to suppor" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) (owner: 10Sn1per) [19:08:55] victorbarbu: heh, you are very welcome :) [19:08:56] rlot2_: Wanna upload what you've got? [19:09:13] ...and merry christmas to those who celebrate christmas :) [19:09:37] andre__: U2! [19:09:45] andre__, \o/ [19:09:58] Reedy: I need to make research, looks like my database died [19:11:16] Unrelated: https://gerrit.wikimedia.org/r/#/c/328308/ might welcome a review (JS stuff) [19:13:56] (03Merged) 10jenkins-bot: Replaced Linker deprecated functions with LinkRenderer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329052 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [19:17:23] (03Merged) 10jenkins-bot: Add id attribute to error message "mw-error-cannotundelete" [core] - 10https://gerrit.wikimedia.org/r/328943 (https://phabricator.wikimedia.org/T20819) (owner: 10Divadsn) [19:18:21] 10MediaWiki-Page-editing, 10CharInsert: [[MediaWiki:Edittools]] should be loaded only with old editor (classic toolbar) - https://phabricator.wikimedia.org/T39657#419922 (10Ciencia_Al_Poder) `{{strong oppose}}` {icon thumbs-down color=red}{icon thumbs-down color=red}: MediaWiki-Edittools can contain common tem... [19:18:23] Reedy: Yaay! That was typo [19:18:41] $rowsData and $rows [19:18:55] andre__ is asking for reviews ;) [19:23:53] (03CR) 10jenkins-bot: Replaced Linker deprecated functions with LinkRenderer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329052 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [19:24:11] lol [19:24:56] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2901584 (10Aklapper) a:05Arpna>03None [19:25:39] FlorianSW, how many occurrences do I have to replace? [19:25:42] (03PS1) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [19:26:05] (03CR) 10jenkins-bot: Add id attribute to error message "mw-error-cannotundelete" [core] - 10https://gerrit.wikimedia.org/r/328943 (https://phabricator.wikimedia.org/T20819) (owner: 10Divadsn) [19:26:35] Reedy: Here is it! https://gerrit.wikimedia.org/r/#/c/329137/ [19:26:46] victorbarbu: over 9000 [19:26:55] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:26:58] or no [19:27:17] Reedy, that would take my entire life [19:27:19] so nope [19:27:28] and I am serious here :/ [19:27:45] legoktm, are you around? [19:29:27] (03CR) 10Reedy: [C: 04-1] "Does other code in the extension use underscores in the variables?" (035 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:29:39] victorbarbu: lego isn't [19:30:01] victorbarbu: RTFM? ;) [19:30:02] "Your task is to find at least two usages of $this passed by reference" [19:30:05] at least 2 [19:30:07] >= 2 [19:30:27] well, that's what I forgot, and I was too lazy to open the task again [19:30:32] the codein site is slow... [19:30:45] heh [19:31:05] Reedy, don't you think? [19:31:10] It is, yeah [19:31:25] If only Google knew how to write software... [19:33:56] (03CR) 10Reedy: [C: 04-1] "Plus test failure:" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:34:47] Reedy: Hmm, this jenkins fail is wierd [19:35:31] Reedy: It should be array [19:37:07] Reedy: Ah, forgot about (array) [19:38:01] 10MediaWiki-Special-pages, 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): "What links here" and "Page information" should not appear on Special:Ne... - https://phabricator.wikimedia.org/T152319#2901591 [19:38:20] (03PS2) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [19:38:33] (03PS1) 10Victorbarbu: Replace some usages of &$this in Hooks::run [core] - 10https://gerrit.wikimedia.org/r/329138 (https://phabricator.wikimedia.org/T153505) [19:39:27] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:40:07] !class SpecialPage [19:40:07] See https://doc.wikimedia.org/mediawiki-core/master/php/classSpecialPage.html [19:41:14] !wgUseMediaWikiUIEverywhere [19:41:19] !wg UseMediaWikiUIEverywhere [19:41:19] https://www.mediawiki.org/wiki/Manual:%24wgUseMediaWikiUIEverywhere [19:41:33] (03PS3) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [19:41:48] (03CR) 10Reedy: Subscription functions now take user ids array (034 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:41:54] kik [19:41:55] lol [19:42:40] 10MediaWiki-extensions-SemanticQueryInterface: Fix some typos in SemanticMediaWiki messages - https://phabricator.wikimedia.org/T151721#2901597 (10MtDu) [19:42:44] 10MediaWiki-extensions-SemanticQueryInterface, 07I18n: [[MediaWiki:Smw-smwadmin-dbsetup-disabled/pt]] typo - https://phabricator.wikimedia.org/T151707#2901594 (10MtDu) 05Open>03Resolved a:03MtDu This task has already been resolved. [19:42:44] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:43:08] (03PS4) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [19:44:08] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:45:55] Reedy: Can you take a look at this jenkins fail? [19:47:39] Reedy: Need to rewrite test? [19:47:42] I think so [19:48:17] line 39.. [19:48:18] 'nls_subscriber_id' => $user->getId() [19:48:25] 'nls_subscriber_id' => [ $user->getId() ] [19:48:45] (03PS5) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [19:48:45] replace the first with the second [19:49:15] Reedy: Got it ( array( $user-getId() ) ) [19:49:31] tonythomas: please replace array() with [] [19:49:31] :P [19:49:46] Reedy: Btw, should I use array( or [] ? [19:49:50] array() [19:49:55] the extension hasn't been converted, yet [19:50:03] Ok, let me fix it [19:50:07] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:51:52] (03PS6) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [19:53:14] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [19:53:16] rlot2_: Did you just swap array() for []? [19:53:40] Reedy: Yep [19:53:44] Why? :) [19:53:54] Reedy: ... [19:54:02] [19:49:46] Reedy: Btw, should I use array( or [] ? [19:54:02] [19:49:50] array() [19:54:02] [19:49:55] the extension hasn't been converted, yet [19:54:07] Reedy: But in both cases jenkins fail [19:54:14] Yeah, it's not causing the failur [19:54:26] tonythomas: please replace array() with [] [19:54:29] XD [19:54:33] Yeah [19:54:35] On mass [19:54:56] hmm [19:54:58] Reedy: [19:54:58] array( 'nls_subscriber_id' => [ $user->getId() ], 'nls_newsletter_id' => 1 ) [19:55:07] so its array. [19:56:55] Ah [19:57:15] array( 'nls_subscriber_id' => [ $user->getId() ], 'nls_newsletter_id' => 1 ) [19:57:15] to [19:57:26] array( array( 'nls_subscriber_id' => array( $user->getId() ), 'nls_newsletter_id' => 1 ) ) [20:00:31] (03PS7) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [20:00:43] Reedy: Should work [20:01:46] (03CR) 10jerkins-bot: [V: 04-1] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [20:02:00] lol [20:02:31] 20:01:45 - 'nls_subscriber_id' => Array (...) [20:02:31] 20:01:45 + 'nls_subscriber_id' => 3 [20:03:15] rlot2_: one too many arrays [20:03:23] array( array( 'nls_subscriber_id' => $user->getId(), 'nls_newsletter_id' => 1 ) ) [20:03:31] It's not an array when we get the insert rows :) [20:04:14] (03PS8) 10Filip: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) [20:04:20] Reedy: don e [20:07:01] yay [20:07:36] (03CR) 10Reedy: [C: 032] Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [20:08:33] (03Merged) 10jenkins-bot: Subscription functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329137 (https://phabricator.wikimedia.org/T154095) (owner: 10Filip) [20:08:37] Reedy: submited on GCI [20:11:22] Reedy: Thanks! [20:12:45] (03PS9) 10Reedy: Make `Special:Newsletter/id/subscribers` editable. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) (owner: 10Pppery) [20:13:16] (03CR) 10Reedy: "Rebased ontop of https://gerrit.wikimedia.org/r/329137 and updated to match" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) (owner: 10Pppery) [20:14:43] 10MediaWiki-Special-pages, 07TestMe: Don't show pagination for small results - https://phabricator.wikimedia.org/T47190#2901605 (10matej_suchanek) [20:18:09] (03CR) 10Reedy: [C: 032] Make `Special:Newsletter/id/subscribers` editable. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) (owner: 10Pppery) [20:19:15] (03Merged) 10jenkins-bot: Make `Special:Newsletter/id/subscribers` editable. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329055 (https://phabricator.wikimedia.org/T154080) (owner: 10Pppery) [20:31:40] 10MediaWiki-Watchlist: Remove double space from watchlist options - https://phabricator.wikimedia.org/T154114#2901610 (10Jack_who_built_the_house) [20:33:27] 04(no projects): pagetriagelist API does not list any pages - https://phabricator.wikimedia.org/T154115#2901622 (10Gryllida) [20:36:28] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Content Translation does not publish the translation - https://phabricator.wikimedia.org/T154116#2901633 (10Arbnos) [20:47:11] 10MediaWiki-extensions-ContentTranslation: Content Translation does not publish the translation - https://phabricator.wikimedia.org/T154116#2901645 (10Ciencia_Al_Poder) [20:53:13] 10Outreachy, 06Developer-Relations (Jan-Mar-2017), 03Google-Code-In-2016: Do a research on the communication tools Zulip and Mattermost, and document the pros and cons of using them - https://phabricator.wikimedia.org/T154001#2901647 (10srishakatux) [21:11:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/329139 (owner: 10L10n-bot) [21:22:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/329168 (owner: 10L10n-bot) [21:22:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/329163 (owner: 10L10n-bot) [21:30:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/329175 (owner: 10L10n-bot) [21:38:12] (03PS1) 10DatGuy: AntiSpoof: Simplify word in en and en-gb. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) [21:47:52] (03CR) 10Samtar: [C: 031] AntiSpoof: Simplify word in en and en-gb. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/329197 (https://phabricator.wikimedia.org/T94959) (owner: 10DatGuy) [21:50:09] Reedy: yay! Thanks for that one. Looks like christmas for the newsletter-extension! :D [21:54:05] maybe because it's Christmas? (: [21:58:03] Platonides: apparantly yes :D Well, people are online here - so unless someone change the channel header or something, chances are low people would notice :P [21:59:38] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage: pagetriagelist API does not list any pages - https://phabricator.wikimedia.org/T154115#2901672 (10Reedy) [22:09:12] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2901676 (10Pppery) [22:09:15] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletter/id/subscribers should allow an admin to edit subscribers - https://phabricator.wikimedia.org/T154080#2901674 (10Pppery) 05Open>03Resolved a:03Pppery [22:09:31] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#1309329 (10Pppery) 05Open>03Resolved a:03Pppery [22:26:47] 10AntiSpoof: Adding "ı" as an i alternative in antispoof - https://phabricator.wikimedia.org/T149785#2901681 (10Billinghurst) [22:26:49] 10AntiSpoof, 05Security: Add some more characters to AntiSpoof mappings for usage in TitleBlacklists - https://phabricator.wikimedia.org/T153021#2901684 (10Billinghurst) [22:27:46] 10AntiSpoof: Adding "ı" as an i alternative in antispoof - https://phabricator.wikimedia.org/T149785#2762601 (10Billinghurst) It was used, so uncertain why it failed the. Either way it is part of the bigger task. [22:33:57] 10MediaWiki-extensions-Newsletter: Fatal on adding in new Newsletter subscribers - https://phabricator.wikimedia.org/T154118#2901686 (1001tonythomas) [22:42:00] 10AntiSpoof: Adding "ı" as an i alternative in antispoof - https://phabricator.wikimedia.org/T149785#2901701 (10Ciencia_Al_Poder) 05duplicate>03Invalid If it's already on the list of characters, it won't be added //again// `ccnorm('ı') == ccnorm('i')` returns true in Special:AbuseFilter/tools It would be m... [22:44:40] 10MediaWiki-extensions-Newsletter: Fatal on adding in new Newsletter subscribers - https://phabricator.wikimedia.org/T154118#2901686 (10Reedy) ``` $removed = array_diff( $oldSubscribersIds, $newSubscribersIds ); ``` has apparently returned an empty array? I guess, we should wrap removeSubscription in an if ( $... [22:48:44] Reedy: I think $store->addSubscription( $this->newsletter, $added ); and $store->removeSubscription( $this->newsletter, $removed ); where executed one after the other on the same data or something [22:48:45] testing it now [22:49:05] $added = array_diff( $newSubscribersIds, $oldSubscribersIds ); [22:49:05] $removed = array_diff( $oldSubscribersIds, $newSubscribersIds ); [22:49:11] Maybe a bit fragile [22:50:40] Reedy: I just put an if on it, and it works. Pushing in now [22:50:45] you can take a look from gerrit. [22:50:47] just on the removed? [22:50:53] Reedy: on both. [22:51:12] Shouldn't be needed on the add [22:51:18] as the insert (with the IGNORE) does [22:51:19] if ( !count( $a ) ) { [22:51:19] return true; [22:51:19] } [22:51:24] So if no rows, won't insert anyway [22:51:32] But no harm not going that deep [22:51:38] Reedy: okey. then removing that now! [22:52:11] tonythomas: Something to unit test? [22:52:30] Reedy: I think so, yeah. Calls for a new task, and a GCI thingy too :D [22:53:17] Reedy: yeah. it works perfect even without the if on added() [22:54:58] (03PS1) 1001tonythomas: Check if $removed was set, before calling in the removeSubscriptions() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329198 (https://phabricator.wikimedia.org/T154118) [22:55:52] Reedy: ^^ https://gerrit.wikimedia.org/r/#/c/329198/ [22:56:16] (03CR) 10Reedy: [C: 032] Check if $removed was set, before calling in the removeSubscriptions() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329198 (https://phabricator.wikimedia.org/T154118) (owner: 1001tonythomas) [22:56:57] Reedy: :) [22:57:14] but "but if he was subscribed to begin with.. He should've been there in the diff?" is still of interest! [22:57:16] (03Merged) 10jenkins-bot: Check if $removed was set, before calling in the removeSubscriptions() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/329198 (https://phabricator.wikimedia.org/T154118) (owner: 1001tonythomas) [22:58:09] 10MediaWiki-extensions-Newsletter: Fatal on adding in new Newsletter subscribers - https://phabricator.wikimedia.org/T154118#2901705 (1001tonythomas) 05Open>03Resolved a:0301tonythomas https://gerrit.wikimedia.org/r/#/c/329198/ - fix this one! [22:59:50] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: (NewsletterStore|NewsletterDb)::(addSubscription|removeSubscription) should allow for multiple users - https://phabricator.wikimedia.org/T154095#2901708 (1001tonythomas) 05Open>03Resolved a:03FilipGCI Thank you! [23:01:02] 10MediaWiki-extensions-Newsletter: Subtitle should show "delete" option. - https://phabricator.wikimedia.org/T153879#2901711 (1001tonythomas) 05Open>03declined Closing as declined, due to this: >>! In T153879#2897294, @Qgil wrote: > I had reported this problem myself, and @01tonythomas convinced me to give... [23:08:13] 10InternetArchiveBot: Template inserted into br tag - https://phabricator.wikimedia.org/T154119#2901713 (10Jonesey95) a:03Cyberpower678 [23:09:57] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remove unused SpecialNewsletter:getNewsletterActionButtons() - https://phabricator.wikimedia.org/T154120#2901726 (1001tonythomas) [23:12:51] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remove unused SpecialNewsletter:getNewsletterActionButtons() - https://phabricator.wikimedia.org/T154120#2901740 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5720240635772928/ waiting for one of the admins to approve it. It... [23:30:19] (03PS1) 10Divadsn: Replace &$this with $this in MediaWiki/core hook system [core] - 10https://gerrit.wikimedia.org/r/329199 (https://phabricator.wikimedia.org/T153505) [23:30:36] (03CR) 10jerkins-bot: [V: 04-1] Replace &$this with $this in MediaWiki/core hook system [core] - 10https://gerrit.wikimedia.org/r/329199 (https://phabricator.wikimedia.org/T153505) (owner: 10Divadsn) [23:36:42] 05Security: Grrrit-wm quits if you mention it in bans or quiets - https://phabricator.wikimedia.org/T148789#2901787 (10Luke081515) > (Also not sure why this was ever private tbh.) Because you can in theory "play" with the bot, by kicking him out and out again. But thanks for that solution. [23:51:22] 05Security: Grrrit-wm quits if you mention it in bans or quiets - https://phabricator.wikimedia.org/T148789#2901791 (10Peachey88) [23:54:50] (03CR) 10Physikerwelt: [C: 032] Remove broken test script texvccheck/test.pl [extensions/Math] - 10https://gerrit.wikimedia.org/r/329129 (owner: 10Tim Landscheidt) [23:55:57] (03PS2) 10Divadsn: Replace &$this with $this in MediaWiki/core hook system [core] - 10https://gerrit.wikimedia.org/r/329199 (https://phabricator.wikimedia.org/T153505)