[00:03:06] 10MediaWiki-Vagrant, 06Reading-Infrastructure-Team, 06Reading-Web-Backlog, 13Patch-For-Review: Add vagrant roles for extensions maintained by WMF Reading - https://phabricator.wikimedia.org/T152036#2895151 (10bd808) a:05bmansurov>03Tgr [00:03:29] (03CR) 10Kaldari: [C: 04-1] "Still need to switch $supportedLangCollations per Brian." [core] - 10https://gerrit.wikimedia.org/r/327762 (https://phabricator.wikimedia.org/T47611) (owner: 10Niharika29) [00:16:59] 10Internet-Archive, 10InternetArchiveBot: Saved wrong link - https://phabricator.wikimedia.org/T153872#2895207 (10Cyberpower678) >>! In T153872#2894825, @Green_Cardamom wrote: > Yeah this is really great. I hope editors will begin using it a lot. The talk page notice should direct editors to the tool and clari... [00:19:17] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2895209 (10Rfarrand) The remote participation email was sent to 99 recipients who registered for the event and were unable to atten... [00:19:30] (03PS19) 10Mholloway: Make article header consistently reflect the updated description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325072 (https://phabricator.wikimedia.org/T152207) [00:19:40] (03CR) 10Mholloway: Make article header consistently reflect the updated description (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325072 (https://phabricator.wikimedia.org/T152207) (owner: 10Mholloway) [00:22:49] (03CR) 10Mholloway: "As for the flicker, I wonder if that's a visual artifact of swapping out the subtitle on page load complete? Or does it seem to affect mo" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325072 (https://phabricator.wikimedia.org/T152207) (owner: 10Mholloway) [00:24:21] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2895213 (10Rfarrand) The same email linked in my last comment was sent through meetup.com to all Wikimedia Tech meetup group member... [00:26:39] 10New-Readers: Update Wikilater to use Electron service in production - https://phabricator.wikimedia.org/T149627#2895222 (10GWicke) [00:26:42] 10Electron-PDFs, 07German-Community-Wishlist-Main-Wishes, 06TCB-Team (Oct2016-March2017): Show tables in pdfs (#9) - https://phabricator.wikimedia.org/T135643#2895223 (10GWicke) [00:32:50] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 07I18n: Allow users to code in localized programming languages - https://phabricator.wikimedia.org/T150417#2895236 (10MZMcBride) I agree with most of T150417#2791161. In general, I think tasks like this can be useful to suss out and articul... [00:35:41] 07Design, 10MediaWiki-HTMLForm: OOjs UI should allow `disabled` to contain an array - https://phabricator.wikimedia.org/T153927#2895238 (10Huji) [00:35:57] Hello qchris [00:36:40] ? [00:37:24] (03PS1) 10Huji: HTMLMultiSelect should allow a parameter specifying which options are disabled [core] - 10https://gerrit.wikimedia.org/r/328603 (https://phabricator.wikimedia.org/T153751) [00:38:42] (03PS2) 10Huji: HTMLMultiSelect should allow a parameter specifying which options are disabled [core] - 10https://gerrit.wikimedia.org/r/328603 (https://phabricator.wikimedia.org/T153751) [00:39:23] (03PS4) 10Mholloway: Add test for cached page description updating [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328561 (https://phabricator.wikimedia.org/T152207) [00:41:17] 07Design, 10MediaWiki-HTMLForm, 13Patch-For-Review: OOjs UI should allow `disabled` to contain an array - https://phabricator.wikimedia.org/T153927#2895278 (10Huji) Using the patch above and code like this: ``` 'grants' => [ 'type' => 'multiselect', 'options' => [ 'Alphas' => 'alpha', 'Bravos' =>... [00:41:46] Hello aude_ [00:41:54] (03PS3) 10Huji: HTMLMultiSelect should allow a parameter specifying which options are disabled [core] - 10https://gerrit.wikimedia.org/r/328603 (https://phabricator.wikimedia.org/T153751) [00:43:00] (03CR) 10Huji: "As hairy as it might be, I took a stab at it. Required changes to HTMLForm and OOjs UI. I created subtasks and submitted patches." [core] - 10https://gerrit.wikimedia.org/r/325778 (https://phabricator.wikimedia.org/T150079) (owner: 10Huji) [00:43:49] 06Design-Research-Backlog, 06Research-and-Data, 10Research-outreach: Discuss workshop strategy for the second half of the year - https://phabricator.wikimedia.org/T147102#2895284 (10DarTar) Cost estimate request sent to Travel. @leila you can neglect that item, since we're coordinating via the mailing list. [00:44:04] 06Design-Research-Backlog, 06Research-and-Data, 10Research-outreach: Discuss workshop strategy for the second half of the year - https://phabricator.wikimedia.org/T147102#2895285 (10DarTar) [00:46:29] 06Design-Research-Backlog, 06Research-and-Data, 10Research-outreach: Discuss workshop strategy for the second half of the year - https://phabricator.wikimedia.org/T147102#2895300 (10DarTar) [01:02:24] (03CR) 10TTO: "I guess I was actually thinking of this (User potentially implementing various "little" interfaces) as a good direction to move in. I mean" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/188516 (https://phabricator.wikimedia.org/T88510) (owner: 10Legoktm) [01:02:46] (03PS8) 10TTO: Add common interface for User and UserRightsProxy [core] - 10https://gerrit.wikimedia.org/r/188516 (https://phabricator.wikimedia.org/T88510) (owner: 10Legoktm) [01:04:19] (03PS1) 10Ejegg: Update path to fr-tools requirements.txt [vagrant] - 10https://gerrit.wikimedia.org/r/328605 [01:05:14] (03PS1) 10Kaldari: Adding $writing param to match param signature of parent function [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328606 [01:06:17] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Impressions slow to update on jaJP dsk campaign - https://phabricator.wikimedia.org/T145446#2895339 (10AndyRussG) I guess we've been assuming for a while that this is a duplicate of T144952. Apologies for not... [01:08:59] (03CR) 10Cdentinger: [C: 032] Update path to fr-tools requirements.txt [vagrant] - 10https://gerrit.wikimedia.org/r/328605 (owner: 10Ejegg) [01:09:09] (03Merged) 10jenkins-bot: Update path to fr-tools requirements.txt [vagrant] - 10https://gerrit.wikimedia.org/r/328605 (owner: 10Ejegg) [01:12:14] (03CR) 10Divadsn: "@Reedy because I think that the if does not make a difference whether the extension is enabled or not." [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) (owner: 10Divadsn) [01:12:56] (03CR) 10Pmiazga: "bmansurov: no, it should work, please that Hovercards are not visible as Beta feature, maybe you have to set up PopupsBetaFeature switch t" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328430 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [01:14:55] (03CR) 10Reedy: "It would cause a difference in what is shown on the API help page, as the defined parameters of the module depend on this." [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) (owner: 10Divadsn) [01:16:14] (03CR) 10Reedy: "That way of disabling dates back to 2011..." [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) (owner: 10Divadsn) [01:24:58] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07FR-2016-17-Q2-Campaign-Support, 07Spike: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2895370 (10AndyRussG) Here's an etherpad with some brief notes we started on:... [01:26:20] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07FR-2016-17-Q2-Campaign-Support, 07Spike: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2895371 (10AndyRussG) ...and here's notes on Collab: https://collab.wikimedia... [01:28:32] 07Design, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2895372 (10Etonkovidova) Checked in betalabs - IE11, Windows 7, Chrome... [01:32:26] (03PS3) 10Tim Starling: Allow HTML tags in LanguageConverter output. [core] - 10https://gerrit.wikimedia.org/r/327778 (https://phabricator.wikimedia.org/T54192) (owner: 10C. Scott Ananian) [01:45:43] (03CR) 10Tim Starling: [C: 032] "Philip was probably just trying to do security escaping, in which case I should have done this in 465e50e8e7b81a238dfee2d1c8daf82ba12b76b1" [core] - 10https://gerrit.wikimedia.org/r/327778 (https://phabricator.wikimedia.org/T54192) (owner: 10C. Scott Ananian) [01:47:09] (03CR) 10Kaldari: [C: 032] "Tested and works fine." [core] - 10https://gerrit.wikimedia.org/r/328353 (https://phabricator.wikimedia.org/T153347) (owner: 10Samwilson) [01:54:17] (03Merged) 10jenkins-bot: Allow HTML tags in LanguageConverter output. [core] - 10https://gerrit.wikimedia.org/r/327778 (https://phabricator.wikimedia.org/T54192) (owner: 10C. Scott Ananian) [01:54:22] (03CR) 10jerkins-bot: [V: 04-1] Default block-cookies to 24 hours only [core] - 10https://gerrit.wikimedia.org/r/328353 (https://phabricator.wikimedia.org/T153347) (owner: 10Samwilson) [02:00:30] (03PS2) 10Samwilson: Default block-cookies to 24 hours only [core] - 10https://gerrit.wikimedia.org/r/328353 (https://phabricator.wikimedia.org/T153347) [02:02:02] (03PS3) 10Kaldari: Default block-cookies to 24 hours only [core] - 10https://gerrit.wikimedia.org/r/328353 (https://phabricator.wikimedia.org/T153347) (owner: 10Samwilson) [02:14:34] (03CR) 10Kaldari: [C: 032] Default block-cookies to 24 hours only [core] - 10https://gerrit.wikimedia.org/r/328353 (https://phabricator.wikimedia.org/T153347) (owner: 10Samwilson) [02:15:06] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2895391 (10kaldari) [02:16:04] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2895393 (10Rfarrand) I have taken a first shot at creating the remote participation support page. It still needs plenty of work - b... [02:22:41] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016: Add "copy to clipboard" button to share/embed fields - https://phabricator.wikimedia.org/T77295#2895394 (10Sn1per) a:03Sn1per [02:22:43] (03Merged) 10jenkins-bot: Default block-cookies to 24 hours only [core] - 10https://gerrit.wikimedia.org/r/328353 (https://phabricator.wikimedia.org/T153347) (owner: 10Samwilson) [02:44:56] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 07I18n: Allow users to code in localized programming languages - https://phabricator.wikimedia.org/T150417#2895398 (10Tgr) [02:47:42] (03PS2) 10Huji: Properly use "the" article in AbuseFilter messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/325618 (https://phabricator.wikimedia.org/T152535) [02:58:56] 10MediaWiki-History-or-Diffs, 07I18n, 07RTL: Diffs on MediaWiki:Spam-blacklist must always show in LTR - https://phabricator.wikimedia.org/T153934#2895401 (10Huji) [03:00:58] 10MediaWiki-History-or-Diffs, 10SpamBlacklist, 07I18n, 07RTL: Diffs on MediaWiki:Spam-blacklist must always show in LTR - https://phabricator.wikimedia.org/T153934#2895415 (10Legoktm) [03:10:11] (03PS1) 10Aaron Schulz: Avoid pointless use of isset() in LBFactoryMulti() [core] - 10https://gerrit.wikimedia.org/r/328615 [03:19:47] (03PS1) 10Gergő Tisza: Make mediawiki/core cloning shallow by default [vagrant] - 10https://gerrit.wikimedia.org/r/328617 (https://phabricator.wikimedia.org/T153578) [03:23:23] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2895425 (10Tgr)... [03:23:58] (03PS2) 10Gergő Tisza: Make mediawiki/core cloning shallow by default [vagrant] - 10https://gerrit.wikimedia.org/r/328617 (https://phabricator.wikimedia.org/T152801) [04:14:24] (03CR) 10BryanDavis: [C: 032] Make mediawiki/core cloning shallow by default [vagrant] - 10https://gerrit.wikimedia.org/r/328617 (https://phabricator.wikimedia.org/T152801) (owner: 10Gergő Tisza) [04:14:37] (03Merged) 10jenkins-bot: Make mediawiki/core cloning shallow by default [vagrant] - 10https://gerrit.wikimedia.org/r/328617 (https://phabricator.wikimedia.org/T152801) (owner: 10Gergő Tisza) [04:35:52] 10Wikimedia-Wikimania-Scholarships: Add a web link to the welcome email - https://phabricator.wikimedia.org/T151379#2895441 (10Niharika) 05Open>03Resolved a:03Niharika [04:36:49] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Change Attendance and involvement in Wikimania section - https://phabricator.wikimedia.org/T151366#2895443 (10Niharika) 05Open>03Resolved a:03Niharika [04:37:04] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Link to CentralAuth page for users in review interface - https://phabricator.wikimedia.org/T151380#2895445 (10Niharika) 05Open>03Resolved a:03Niharika [04:37:18] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Change all relevant dates and links on application form to reflect new 2017 information - https://phabricator.wikimedia.org/T151401#2895447 (10Niharika) 05Open>03Resolved [04:37:30] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Add new questions regarding staff/board status - https://phabricator.wikimedia.org/T151371#2895448 (10Niharika) 05Open>03Resolved a:03Niharika [04:37:33] (03CR) 10Tim Starling: [C: 04-1] "That state machine is pretty hairy, this is hard to verify just by looking at it. Test coverage is not very good, considering that all tes" [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) (owner: 10C. Scott Ananian) [04:37:44] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Make people who are under 18 stand out when reviewing submissions - https://phabricator.wikimedia.org/T151375#2895450 (10Niharika) 05Open>03Resolved a:03Niharika [04:37:55] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Remove "Final: Full" report from review system - https://phabricator.wikimedia.org/T151377#2895452 (10Niharika) 05Open>03Resolved a:03Niharika [04:44:20] (03CR) 10Tim Starling: [C: 032] Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) (owner: 10C. Scott Ananian) [04:46:07] (03PS1) 10Aaron Schulz: Add a caught_by context field to exceptions [core] - 10https://gerrit.wikimedia.org/r/328619 [04:47:45] kaldari: back from embargo-land? [04:49:40] (03CR) 10MtDu: "@Florian, @legoktm, I had pushed a patch for this already here: https://gerrit.wikimedia.org/r/#/c/327140/3. If @LukBukkit's doing it for " [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/328489 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [04:54:57] (03CR) 10Tobias Gritschacher: [C: 031] Split simple and js-based styles [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 (owner: 10Ladsgroup) [05:08:55] 06Stewards-and-global-tools, 10Wikimedia-Site-requests: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2895474 (10Jogi_don) SO how can i get access that account. [05:13:13] (03PS1) 10Brian Wolff: Attempt to optimize api prop=contributors [core] - 10https://gerrit.wikimedia.org/r/328623 [05:21:31] (03CR) 10Brian Wolff: "@jcrespo I'd appreciate feedback as to if this is a useful optimization, or if I'm out to lunch. For reference, explain's to follow:" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [05:38:14] 06Stewards-and-global-tools, 10Wikimedia-Site-requests: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2879998 (10Urbanecm) Simply register it. [05:40:46] (03CR) 10BryanDavis: [C: 032] Add a caught_by context field to exceptions [core] - 10https://gerrit.wikimedia.org/r/328619 (owner: 10Aaron Schulz) [05:43:57] 06Discovery-Analysis: Create usage stats for WDQS LDF endpoint - https://phabricator.wikimedia.org/T153936#2895479 (10Smalyshev) [05:44:29] 06Discovery, 06Discovery-Analysis: Create usage stats for WDQS LDF endpoint - https://phabricator.wikimedia.org/T153936#2895493 (10Smalyshev) [05:47:35] (03CR) 10BryanDavis: [C: 032] Remove FileRepoStatus references [core] - 10https://gerrit.wikimedia.org/r/328464 (owner: 10Aaron Schulz) [05:47:52] bd808: thanks. Hopefully that can replace the system of "ask people who know the code if this is *probably* just caught/logged silently or blowing up on people". :) [05:48:22] yeah, it seems like a good idea [05:48:24] 10Phlogiston (Technical Debt): Recategorization function can take hours or even a day - https://phabricator.wikimedia.org/T138024#2895495 (10JAufrecht) 05Open>03Resolved This is happening less often or not at all. Recategorization was rewritten substantially in the last few months. [05:48:28] I originally wanted to segregate out rpc/RunJobs.php and maintenance type stuff but held off...easy enough to filter on those afaik [05:50:32] (03Merged) 10jenkins-bot: Add a caught_by context field to exceptions [core] - 10https://gerrit.wikimedia.org/r/328619 (owner: 10Aaron Schulz) [05:53:28] (03CR) 10Brian Wolff: "Hmm, I just stumbled across T102532, so this optimization might not be all that useful for actual WMF on wikis without the page_user_times" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [05:53:40] 10MediaWiki-Installer, 07HHVM: Stop using realpath to set $IP in WebStart - https://phabricator.wikimedia.org/T153882#2895512 (10SamanthaNguyen) I believe this is the correct project tag, please correct me if I'm wrong :) [05:58:05] (03Merged) 10jenkins-bot: Remove FileRepoStatus references [core] - 10https://gerrit.wikimedia.org/r/328464 (owner: 10Aaron Schulz) [05:58:53] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2895514 (10Physikerwelt) @Bmansurov please do not self merge your changes. [06:04:41] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2895520 (10Physikerwelt) In general, I think it's a good idea to add an element name to the outermost HTML element generated by the... [06:12:40] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2895521 (10Physikerwelt) I just tested on beta, but I could not see an effect from the change. {F5131986} {F5131987} (It's intere... [06:15:04] (03PS1) 10Aaron Schulz: Code style and IDEA warning fixes for CentralAuthUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328627 [06:15:47] 10MediaWiki-Page-protection, 05Security: Don't allow non-admins to remove semi-protection from pages by just moving back and forth - https://phabricator.wikimedia.org/T137018#2895523 (10Bawolff) [06:15:55] 10MediaWiki-Page-protection, 05Security: Don't allow non-admins to remove semi-protection from pages by just moving back and forth - https://phabricator.wikimedia.org/T137018#2895526 (10Bawolff) >>! In T137018#2895437, @Pokefan95 wrote: > T128624 is now resolved, can this task be visible to the public now? Tha... [06:18:05] (03PS2) 10Aaron Schulz: Code style and IDEA warning fixes for CentralAuthUser [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328627 [06:38:41] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 13Patch-For-Review, and 2 others: [Tracker] Fix all stylelint errors and integrate stylelint test to CI - https://phabricator.wikimedia.org/T152079#2895542 (10KartikMistry) [06:44:24] 10MediaWiki-extensions-ContentTranslation, 10Continuous-Integration-Config, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2895543 (10Arrbee) 05Open>03Resolved a:0... [06:52:01] 06Discovery, 06Discovery-Analysis (Current work): Search Metrics Dashboard: Investigate recent spike in user engagement - https://phabricator.wikimedia.org/T153887#2895546 (10chelsyx) The schema changed from TestSearchSatisfaction2_15700292 to TestSearchSatisfaction2_15922352 on Oct 25, so we ended up having 7... [06:52:09] 07Design, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2895547 (10Pginer-WMF) >>! In T142454#2895372, @Etonkovidova wrote: > @... [06:59:38] (03CR) 10Gergő Tisza: "Wouldn't it be better to mark logException as internal and remove callers? They can always use a PSR-3 logger to report exceptions, with s" [core] - 10https://gerrit.wikimedia.org/r/328619 (owner: 10Aaron Schulz) [07:00:47] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5: Content Translation help documents need review and update - https://phabricator.wikimedia.org/T152591#2895549 (10Amire80) I updated all the help and product pages that I could, including t... [07:02:11] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Update CX technical documentation - https://phabricator.wikimedia.org/T153939#2895550 (10Amire80) [07:21:35] 10MediaWiki-extensions-ContentTranslation, 03Language-2017 Sprint 1, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: Reorganize the CX classes using OOJS - https://phabricator.wikimedia.org/T152586#2895569 (10Arrbee) [07:25:39] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Write CX template editor illustrated translatable help page - https://phabricator.wikimedia.org/T152590#2895573 (10Arrbee) 05Open>03Resolved [07:30:28] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5: Content Translation help documents need review and update - https://phabricator.wikimedia.org/T152591#2853461 (10Arrbee) 05Open>03Resolved [07:43:11] 10Datasets-General-or-Unknown, 10Dumps-Generation: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2895596 (10ArielGlenn) p:05Triage>03Normal [07:46:48] 10Datasets-General-or-Unknown, 10Dumps-Generation: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2895089 (10ArielGlenn) Can you give the command you were running with the exact arguments, and also a file containing the XML entry for the page causing the problem (and the xml namespa... [07:53:59] 07Design, 10MediaWiki-extensions-ContentTranslation, 03Language-2017 Sprint 1, 05Language-team January-March 2017, 07WorkType-NewFunctionality: Provide a way to convert inline templates in regular text when translating templates - https://phabricator.wikimedia.org/T151033#2895602 (10Arrbee) [07:54:20] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Better communicate that changes when editing a template won't be lost on closing - https://phabricator.wikimedia.org/T150953#2895603 (10Arrbee) a:05Amire80>03None [07:54:31] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Provide better education and guidance for template editing - https://phabricator.wikimedia.org/T151030#2895605 (10Arrbee) a:05Amire80>03None [07:54:45] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Clarify the access to editing mode when translating templates - https://phabricator.wikimedia.org/T150952#2895607 (10Arrbee) a:05Amire80>03None [08:08:42] 10MediaWiki-Interface, 07I18n, 07Tracking: Messages needing PLURAL support (tracking) - https://phabricator.wikimedia.org/T40781#2895619 (10Nemo_bis) I don't see a benefit in such proposal. [08:08:54] 10MediaWiki-Parser, 07I18n, 07Tracking: GENDER (tracking) - https://phabricator.wikimedia.org/T32443#2895620 (10Nemo_bis) >>! In T32443#2869816, @MarcoAurelio wrote: > (WARNING) Please see {T150665} for the discussion to convert this tracking Task to a Tag. Thank you. I don't see a benefit in such proposal. [08:11:42] 10MediaWiki-General-or-Unknown, 15User-Daniel, 15User-Nikerabbit: Unable to overwrite services using MediaWikiServices hook - https://phabricator.wikimedia.org/T153256#2895627 (10Nemo_bis) [08:18:15] 10MediaWiki-General-or-Unknown, 07HHVM: Stop using realpath to set $IP in WebStart - https://phabricator.wikimedia.org/T153882#2895628 (10SamanthaNguyen) [08:20:42] (03CR) 10LukBukkit: "Oh sorry, I didn't see your patch, but yes I'm doing it for GCI." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/328489 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [08:24:22] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Warn if localSiteID is not a known site ID - https://phabricator.wikimedia.org/T153854#2895629 (10thiemowmde) p:05Unbreak!>03Normal a:03thiemowmde [08:41:50] (03CR) 10TTO: "Thanks Brad as always for the thorough review!" (0332 comments) [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [08:48:45] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2895640 (10Qgil) Thank you! An email to wikitech-l and mediawiki-l cannot harm. [08:49:26] 06Developer-Relations (Jan-Mar-2017): Publish Lessons Learned from Wikimania Hackathon 2016 - https://phabricator.wikimedia.org/T138989#2895641 (10Qgil) [08:50:09] 06Developer-Relations (Jan-Mar-2017): Publish Lessons Learned from Wikimania Hackathon 2016 - https://phabricator.wikimedia.org/T138989#2416223 (10Qgil) [08:54:24] (03CR) 10Zfilipin: "#31 creates users and pages using random strings generated by securerandom." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [08:54:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus) - https://phabricator.wikimedia.org/T146792#2895654 (10thiemowmde) [08:57:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Remove (seemingly) unused wb-status page prop (EntityContent::getEntityStatus) - https://phabricator.wikimedia.org/T146792#2895663 (10thiemowmde) [08:58:19] 10MediaWiki-extensions-Newsletter: Newsletter cleanup - https://phabricator.wikimedia.org/T153906#2894644 (10Qgil) Wow, thank you very much @Reedy ! [09:02:03] 10MediaWiki-extensions-ContentTranslation, 10Continuous-Integration-Config, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2895683 (10Nikerabbit) For context: the tests... [09:10:11] 10MediaWiki-General-or-Unknown, 07I18n: {{int:nstab-talk}} should display the localized text instead of "⧼nstab-talk⧽" - https://phabricator.wikimedia.org/T153867#2895685 (10Nikerabbit) {{INT}} will show in qqx you any name you pass to it. If you mean the tab itself, it uses a special mechanism where it tries... [09:10:52] (03PS1) 10LukBukkit: Replaced Linker::link() usages with LinkRenderer [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/328641 (https://phabricator.wikimedia.org/T149346) [09:19:01] (03PS2) 10Divadsn: The Configure extension misses API i18n messages [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) [09:19:04] (03CR) 10Ljonka: "Thats a good point, how about using the existing group "bot", it will be easy to include it here: https://gerrit.wikimedia.org/r/#/c/32723" [extensions/Contributors] (REL1_27) - 10https://gerrit.wikimedia.org/r/327488 (owner: 10Ljonka) [09:19:54] (03CR) 10Divadsn: "@Reedy, I see, I will revert this small change and upload a new patch set :)" [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) (owner: 10Divadsn) [09:22:49] (03CR) 10TTO: "Fixed those things. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:22:53] (03PS7) 10TTO: User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) [09:22:55] (03PS3) 10TTO: Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) [09:23:09] (03CR) 10jerkins-bot: [V: 04-1] User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:23:27] (03CR) 10jerkins-bot: [V: 04-1] Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:23:56] Reedy, are you around? [09:29:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-11-15: Show text from Wikidata usage instructions property (P2559) when auto-suggesting properties or items - https://phabricator.wikimedia.org/T140131#2895702 (10thiemowmde) p:05Triage>03High [09:30:22] 10MediaWiki-Vagrant, 10Gerrit, 13Patch-For-Review: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2860585 (10hashar) I have dig in Gerrit server side logs, and just before Bryan message from Dec 20th 3:20am UTC: ``` [2016-12-20 03:01:04,202] WARN /... [09:30:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Provide another way to surface usage instructions besides tacking them onto descriptions - https://phabricator.wikimedia.org/T97566#2895707 (10thiemowmde) p:05Triage>03High [09:34:33] 10MediaWiki-extensions-ContentTranslation, 10Continuous-Integration-Config, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2895710 (10hashar) Most like yes. The random... [09:34:34] (03CR) 10Phuedx: [C: 032] "Since my change to PS3 was a minor/trivial change to a unit test and updating the commit message, I'm happy to merge this." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328430 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [09:34:54] (03PS8) 10TTO: User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) [09:34:56] (03PS4) 10TTO: Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) [09:35:00] (03CR) 10TTO: "PS8 is a rebase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:35:55] (03PS1) 10Georggi199: Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) [09:37:16] (03Merged) 10jenkins-bot: Inject preference option directly after skin select [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328430 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [09:38:19] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [09:39:45] (03PS1) 10DCausse: Workaround timeout limitation [search/extra] - 10https://gerrit.wikimedia.org/r/328644 (https://phabricator.wikimedia.org/T152895) [09:40:22] (03CR) 10jerkins-bot: [V: 04-1] Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:42:06] (03CR) 10Gergő Tisza: [C: 032] Title: Fix subpage move error reporting [core] - 10https://gerrit.wikimedia.org/r/328209 (owner: 10Anomie) [09:42:08] (03PS2) 10DCausse: Workaround timeout limitation [search/extra] - 10https://gerrit.wikimedia.org/r/328644 (https://phabricator.wikimedia.org/T152895) [09:42:23] (03CR) 10jerkins-bot: [V: 04-1] User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:43:05] (03CR) 10Georggi199: Removed deprecated hook usage (031 comment) [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [09:46:08] (03PS9) 10TTO: User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) [09:46:11] (03PS5) 10TTO: Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) [09:52:14] (03PS1) 10Georggi199: Replaced deprecated hook usage [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) [09:54:01] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: CI tests throw warning "Cannot find site mywiki in sites table" - https://phabricator.wikimedia.org/T153729#2895730 (10daniel) >>! In T153729#2894421, @Tgr wrote: > XDebug warnings show up (since last weeke... [09:54:09] (03Merged) 10jenkins-bot: Title: Fix subpage move error reporting [core] - 10https://gerrit.wikimedia.org/r/328209 (owner: 10Anomie) [09:54:25] (03CR) 10jerkins-bot: [V: 04-1] User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:56:35] (03CR) 10Georggi199: Replaced deprecated hook usage (031 comment) [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [09:56:47] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-Translate: Extend Lua libraries with Extension Translate related features - https://phabricator.wikimedia.org/T153874#2895732 (10Nikerabbit) For reference the docs are at https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#Writing_Scr... [09:57:08] (03CR) 10jerkins-bot: [V: 04-1] Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [09:58:50] (03PS1) 10Georggi199: Removed deprecated hook usage [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) [09:59:34] (03CR) 10Georggi199: Removed deprecated hook usage (031 comment) [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [10:24:58] 06Repository-Ownership-Requests: +2 for Fomafix in mediawiki/* - https://phabricator.wikimedia.org/T153177#2895736 (10Legoktm) 05Open>03Resolved a:03Legoktm Added to mediawiki group. @Fomafix, please review , and congrats! :) [10:24:59] (03PS3) 10DCausse: Workaround timeout limitation [search/extra] - 10https://gerrit.wikimedia.org/r/328644 (https://phabricator.wikimedia.org/T152895) [10:25:51] (03CR) 10jerkins-bot: [V: 04-1] Workaround timeout limitation [search/extra] - 10https://gerrit.wikimedia.org/r/328644 (https://phabricator.wikimedia.org/T152895) (owner: 10DCausse) [10:25:56] 10Datasets-General-or-Unknown, 10Dumps-Generation: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2895739 (10Vituzzu) I was importing latest it.wiki's xml pages' dump, namely itwiki-20161201-pages-meta-current.xml.bz2 (MD5 checked). I think you can more efficently look for the relev... [10:26:44] (03PS4) 10DCausse: Workaround timeout limitation [search/extra] - 10https://gerrit.wikimedia.org/r/328644 (https://phabricator.wikimedia.org/T152895) [10:31:34] (03PS2) 10Robert Vogel: Initial commit [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/327207 [10:35:29] 10MediaWiki-General-or-Unknown, 07HHVM: Stop using realpath to set $IP in WebStart - https://phabricator.wikimedia.org/T153882#2894009 (10Legoktm) > It seems it would be possible to override this with an environment variable, but I am not sure how to pass it to HHVM. https://serverfault.com/questions/351696/h... [10:45:31] (03CR) 10Aleksey Bekh-Ivanov (WMDE): ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328524 (owner: 10Aleksey Bekh-Ivanov (WMDE)) [10:45:46] 07Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 13Patch-For-Review, 03UI-Standardization-Kanban: mw.widgets.DateInputWidget does not match the design of other widgets in MediaWiki theme - https://phabricator.wikimedia.org/T149270#2895755 (10Volker_E) Updated screen from M101 without round... [10:46:06] 07Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 13Patch-For-Review, 03UI-Standardization-Kanban: mw.widgets.DateInputWidget does not match the design of other widgets in MediaWiki theme - https://phabricator.wikimedia.org/T149270#2895756 (10Volker_E) p:05Triage>03Normal [10:46:24] (03PS2) 10Aleksey Bekh-Ivanov (WMDE): Fix tests that don't check composer's autoloader [core] - 10https://gerrit.wikimedia.org/r/328524 [10:46:47] 10Datasets-General-or-Unknown, 10Dumps-Generation: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2895089 (10hoo) You actually ran across https://chars.suikawiki.org/char/1D50A as far as I see. The page in question would be https://it.wikipedia.org/wiki/Discussioni_utente:%F0%9D%94%... [10:50:52] 10MediaWiki-extensions-CLDR, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Include "special" languages in language selector for monolingual text - https://phabricator.wikimedia.org/T153850#2895759 (10Nikki) It seems that codes added for both labels and monolingual text ([[https://phabricator.wikimed... [10:51:23] 10Phabricator-Bot-Requests: Requesting a bot account for @MarcoAurelio - https://phabricator.wikimedia.org/T153191#2872284 (10Legoktm) >>! In T153191#2888618, @MarcoAurelio wrote: > What I'd like to avoid is people complaining that their email inboxes are full of emails saying that a tracking bug has been replac... [10:53:50] (03PS1) 10Subins2000: Remove &$this usage [core] - 10https://gerrit.wikimedia.org/r/328651 (https://phabricator.wikimedia.org/T153505) [10:58:27] 10MediaWiki-extensions-WikibaseRepository, 10DataValues, 10Wikidata: Wrong coordinate display in wikidata page - https://phabricator.wikimedia.org/T150085#2895765 (10thiemowmde) p:05Triage>03Normal I added test cases for this in https://github.com/DataValues/Geo/pull/92. I can understand the confusion, b... [10:58:58] (03CR) 10Gergő Tisza: "Caused T153578. A less drastic approach would be to log the exception instead of throwing it (LoggerFactory::getLogger('MapCacheLRU')->log" [core] - 10https://gerrit.wikimedia.org/r/325623 (owner: 10Chad) [10:59:14] tonythomas: Is there possibiliy, of making something like: IF BOOL THEN UNIQUIE? [10:59:20] Reedy: ? [11:03:18] rlot: I really wish we could've something like that personllay though :D [11:06:53] tonythomas: Hmm, I don't have any idea then. Maybe we should add another column "inactive_main_page_id", and when we deactve newsletter, mainpage id goes to this colummn, and orginal one is changed to ''. main_page_id can be unique in that case. [11:07:01] 10Utilities-mwdumper: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2895771 (10hoo) [11:07:59] I'll describe it more clean on phab [11:09:08] 10Utilities-mwdumper: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2895772 (10Vituzzu) I'm still puzzled, it seems to be a true 4byte char trying to be insert in a column whose encoding is 3byte. [11:09:48] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2895774 (10Tgr)... [11:11:45] 10MediaWiki-extensions-Newsletter: Strange chance of fatal after latest changes in Newsletter extension - https://phabricator.wikimedia.org/T153911#2895775 (10FilipGCI) @tonythomas: Hmm, maybe we should add another, not UNIQUE colummn: "deactive_main_page_id". In that case, when user deletes newsletter, "main_pa... [11:12:59] 10MediaWiki-extensions-CLDR, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 15User-Daniel: Include "special" languages in language selector for monolingual text - https://phabricator.wikimedia.org/T153850#2895776 (10daniel) [11:20:49] (03PS3) 10Robert Vogel: Initial commit [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/327207 [11:22:20] 04(no projects): add_text.py should add text above {{DEFAULTSORT}} - https://phabricator.wikimedia.org/T153942#2895778 (10JAnD) [11:25:19] (03PS6) 10VolkerE: Align mw.widgets.DateInputWidget to OOjs UI's MediaWiki theme widgets [core] - 10https://gerrit.wikimedia.org/r/318485 (https://phabricator.wikimedia.org/T149270) [11:28:35] (03CR) 10VolkerE: "Updated styles according to feedback on task for day selection." [core] - 10https://gerrit.wikimedia.org/r/318485 (https://phabricator.wikimedia.org/T149270) (owner: 10VolkerE) [11:34:47] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Split simple and js-based styles (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 (owner: 10Ladsgroup) [11:35:07] (03PS3) 10TTO: Handle missing namespace prefix in XML dumps more gracefully [core] - 10https://gerrit.wikimedia.org/r/246815 (https://phabricator.wikimedia.org/T114115) [11:36:04] (03CR) 10TTO: "@DanielK any chance of another look at this?" [core] - 10https://gerrit.wikimedia.org/r/246815 (https://phabricator.wikimedia.org/T114115) (owner: 10TTO) [11:38:55] (03CR) 10Reedy: [C: 032] The Configure extension misses API i18n messages [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) (owner: 10Divadsn) [11:47:28] (03CR) 10Mobrovac: "I see, I wasn't aware of the other patch. Removing my -1." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [11:48:38] (03Merged) 10jenkins-bot: The Configure extension misses API i18n messages [extensions/Configure] - 10https://gerrit.wikimedia.org/r/328594 (https://phabricator.wikimedia.org/T153585) (owner: 10Divadsn) [11:48:47] 10Phabricator (Upstream), 07Upstream: Author cannot edit their Herald rule anymore if condition includes custom field which has been deactivated in the meantime - https://phabricator.wikimedia.org/T153455#2895847 (10Aklapper) p:05Triage>03Lowest Oh well, for some reason, `isdc:sprint:storypoints` completel... [11:49:49] 10Phabricator: Author cannot edit their Herald rule anymore if condition includes custom field which has been deactivated in the meantime - https://phabricator.wikimedia.org/T153455#2895850 (10Aklapper) [11:52:48] (03CR) 10Robert Vogel: [C: 032] Initial commit [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/327207 (owner: 10Robert Vogel) [11:55:48] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong id used for 'colspan' in content/NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153531#2883400 (10divadsn) Hasn't this been already fixed with T153530? See https://phabricator.wikimedia.org/rENLTca47570a1121f9dd008496eaadd3307bfdf99... [12:00:57] 10UI-Standardization, 10OOjs-UI, 10Vector, 07Accessibility, and 3 others: styles in Vector conflict with OOUI - https://phabricator.wikimedia.org/T149587#2895860 (10Volker_E) [12:02:16] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong id used for 'colspan' in content/NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153531#2895862 (10divadsn) 05Open>03Resolved a:03divadsn [12:07:52] (03CR) 10VolkerE: Improve visual association of elements in OOjs UI HTMLForm matrix (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327849 (https://phabricator.wikimedia.org/T152532) (owner: 10VolkerE) [12:11:50] (03PS2) 10Ladsgroup: Split simple and js-based styles [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 [12:12:15] (03CR) 10Ladsgroup: Split simple and js-based styles (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 (owner: 10Ladsgroup) [12:14:02] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Some more things to do :)" (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/328651 (https://phabricator.wikimedia.org/T153505) (owner: 10Subins2000) [12:20:29] (03CR) 10Reedy: [C: 04-1] Removed deprecated hook usage (032 comments) [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [12:22:34] (03CR) 10Reedy: Replaced deprecated hook usage (031 comment) [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [12:23:03] (03CR) 10Reedy: Removed deprecated hook usage (031 comment) [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [12:23:21] (03CR) 10Reedy: [C: 04-1] "Hook assignment needs changing too... Did you forget to git add?" [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [12:26:43] 10MediaWiki-extensions-Configure, 03Google-Code-In-2016, 13Patch-For-Review: The Configure extension misses API i18n messages - https://phabricator.wikimedia.org/T153585#2895880 (10Reedy) 05Open>03Resolved [12:31:38] 10MediaWiki-Internationalization, 10Wikimedia-Language-setup, 05MW-1.28-release-notes, 13Patch-For-Review, 07Tamil-Sites: Tamil sort order - https://phabricator.wikimedia.org/T75453#2895887 (10MarcoAurelio) [12:31:40] 10Wikimedia-Extension-setup, 07Tamil-Sites: Activating File Upload Wizard in ta.wiki - https://phabricator.wikimedia.org/T65863#2895890 (10MarcoAurelio) [12:31:42] 06Wikipedia-Android-App-Backlog, 07Tamil-Sites: Allow change of interface language - https://phabricator.wikimedia.org/T70299#2895889 (10MarcoAurelio) [12:31:44] 10Wikimedia-Site-requests, 07Tamil-Sites: Tamil + Malayalam Wiktionary: Namespace link broken for Main page, no link to go back to main page - https://phabricator.wikimedia.org/T41826#2895892 (10MarcoAurelio) [12:31:46] 10Wikimedia-General-or-Unknown, 07Tamil-Sites: ShortUrl does not work on non wikipedia projects - https://phabricator.wikimedia.org/T40905#2895894 (10MarcoAurelio) [12:31:50] 10MediaWiki-extensions-ShortUrl, 07Tamil-Sites: ShortUrls giving 404 unless force reloading page - https://phabricator.wikimedia.org/T40952#2895893 (10MarcoAurelio) [12:31:51] 10MediaWiki-extensions-ShortUrl, 07Tamil-Sites: ShortUrl fails for particular url - https://phabricator.wikimedia.org/T40861#2895896 (10MarcoAurelio) [12:31:55] 07Design, 10MediaWiki-extensions-ShortUrl, 13Patch-For-Review, 07Tamil-Sites: Put the shorturl in a better place: current design is extremely ugly and confusing - https://phabricator.wikimedia.org/T40863#2895895 (10MarcoAurelio) [12:31:57] 10Wikimedia-Extension-setup, 07Tamil-Sites: Enable AFTv5 on ta.wikipedia.org - https://phabricator.wikimedia.org/T40774#2895897 (10MarcoAurelio) [12:31:59] 10MediaWiki-extensions-Narayam, 07Tamil-Sites: Fix Tamil Transliteration rules for ஸ்ரீ க்ஷ் - https://phabricator.wikimedia.org/T40138#2895898 (10MarcoAurelio) [12:32:01] 10Wikimedia-Extension-setup, 07Tamil-Sites: Enable Collection Extension on tawiki - https://phabricator.wikimedia.org/T39277#2895899 (10MarcoAurelio) [12:32:03] 10Wikimedia-Site-requests, 07Tamil-Sites: Change Wikisource namespace for Tamil wikisource - https://phabricator.wikimedia.org/T39237#2895900 (10MarcoAurelio) [12:32:05] 10MediaWiki-Parser, 07I18n, 07Tamil-Sites: canonicalurl: Permanent URL on Special:Cite page should encode URL in unicode - https://phabricator.wikimedia.org/T39207#2895901 (10MarcoAurelio) [12:32:07] 07Tamil-Sites: Wiktionary on mobile doesnt device detect and redirect to mobile version - https://phabricator.wikimedia.org/T38152#2895903 (10MarcoAurelio) [12:32:10] 10Wikimedia-Site-requests, 07I18n, 07Tamil-Sites: Modify Collection format variables from PDF to ODT for Tamil Wikiprojects - https://phabricator.wikimedia.org/T39154#2895902 (10MarcoAurelio) [12:32:12] 10Wikimedia-Site-requests, 07Tamil-Sites: Enable e-mail notifications for watchlist (EnotifWatchlist) on tawiki - https://phabricator.wikimedia.org/T37878#2895904 (10MarcoAurelio) [12:32:14] 07Tamil-Sites: Left alligned images should come alongside text - https://phabricator.wikimedia.org/T36686#2895905 (10MarcoAurelio) [12:32:16] 07Design, 10MediaWiki-extensions-MoodBar, 06Collaboration-Team-Triage, 07Tamil-Sites: Feedback text overlaps with personal bar on Tamil Wikipedia - https://phabricator.wikimedia.org/T36681#2895906 (10MarcoAurelio) [12:32:20] 10Wikimedia-Extension-setup, 07Tamil-Sites: Moodbar on ta.wikipedia - https://phabricator.wikimedia.org/T36560#2895910 (10MarcoAurelio) [12:32:22] 10MediaWiki-General-or-Unknown, 07Tamil-Sites: Ability to hide bot edits on history page - https://phabricator.wikimedia.org/T36265#2895911 (10MarcoAurelio) [12:32:25] 10MediaWiki-extensions-MoodBar, 06Collaboration-Team-Triage, 07I18n, 07Tamil-Sites: Increase allowable feedback text length - https://phabricator.wikimedia.org/T36586#2895908 (10MarcoAurelio) [12:32:27] 10Wikimedia-Site-requests, 07Tamil-Sites: Disable Moodbar on Tamil Wikipedia - https://phabricator.wikimedia.org/T36615#2895907 (10MarcoAurelio) [12:32:29] 10Wikimedia-Site-requests, 07Tamil-Sites: Translation of project namespace and site-name for ta.wikiquote - https://phabricator.wikimedia.org/T36009#2895912 (10MarcoAurelio) [12:32:31] 10MediaWiki-extensions-WebFonts, 07I18n, 07Tamil-Sites, 07Upstream: Lohit-Tamil Font improvements - https://phabricator.wikimedia.org/T35085#2895914 (10MarcoAurelio) [12:32:33] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Remove Bamini from Narayam on Tamil Wikiprojects AND Comments on Tamil Inscript - https://phabricator.wikimedia.org/T34766#2895916 (10MarcoAurelio) [12:32:35] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n, 07Tamil-Sites: Search suggestion highlighting does not respect grapheme clusters causing wrong rendering for Arabic and Indic scripts - https://phabricator.wikimedia.org/T35242#2895913 (10MarcoAurelio) [12:32:37] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Narayam should default to Tamil-only on Tamil Wiki projects - https://phabricator.wikimedia.org/T34257#2895920 (10MarcoAurelio) [12:32:39] 10Wikimedia-Site-requests, 07Tamil-Sites: Translation of project namespace and sitename for tawikibooks - https://phabricator.wikimedia.org/T34340#2895918 (10MarcoAurelio) [12:32:41] 10Wikimedia-Extension-setup, 07I18n, 07Tamil-Sites: Enable WebFonts extension on all Tamil Wiki Projects - https://phabricator.wikimedia.org/T33936#2895919 (10MarcoAurelio) [12:32:43] 10Wikimedia-Extension-setup, 07I18n, 07Tamil-Sites: Enable Narayam extension on Commons - https://phabricator.wikimedia.org/T34619#2895917 (10MarcoAurelio) [12:32:45] 10MediaWiki-extensions-UniversalLanguageSelector, 07I18n, 07Tamil-Sites, 07Upstream: Bamini keyboard map needs fix + Unit Tests - https://phabricator.wikimedia.org/T33904#2895921 (10MarcoAurelio) [12:32:47] 10MediaWiki-extensions-WebFonts, 07I18n, 07Tamil-Sites: Include more Tamil webfonts - https://phabricator.wikimedia.org/T33889#2895922 (10MarcoAurelio) [12:32:49] 10Wikimedia-Site-requests, 07Tamil-Sites: New logo for Tamil Wikibooks - https://phabricator.wikimedia.org/T33862#2895923 (10MarcoAurelio) [12:32:51] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Tamil 99 scheme has a bug - https://phabricator.wikimedia.org/T33774#2895924 (10MarcoAurelio) [12:32:53] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Add new layout for Tamil in Narayam - https://phabricator.wikimedia.org/T33665#2895927 (10MarcoAurelio) [12:32:55] 10Wikimedia-Extension-setup, 07Tamil-Sites: Install Gadgets on Tamil wikiprojects - https://phabricator.wikimedia.org/T33145#2895928 (10MarcoAurelio) [12:32:57] 10MediaWiki-extensions-WebFonts, 07I18n, 07Tamil-Sites: Preference to choose default Webfont - https://phabricator.wikimedia.org/T33693#2895925 (10MarcoAurelio) [12:32:59] 10Wikimedia-Extension-setup, 07I18n, 07Tamil-Sites: Narayam Installation Request - https://phabricator.wikimedia.org/T33538#2895926 (10MarcoAurelio) [12:33:01] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Update tamil typing rules - https://phabricator.wikimedia.org/T33141#2895930 (10MarcoAurelio) [12:33:03] 10Wikimedia-Extension-setup, 07Tamil-Sites: Narayam Install request - https://phabricator.wikimedia.org/T33142#2895929 (10MarcoAurelio) [12:33:05] 10MediaWiki-extensions-Narayam, 07Tamil-Sites: Shortcut CTRTL+M is not always the correct shortcut - https://phabricator.wikimedia.org/T33026#2895931 (10MarcoAurelio) [12:33:07] 10MediaWiki-extensions-Narayam, 07Tamil-Sites: Update tamil typing rules - https://phabricator.wikimedia.org/T32801#2895933 (10MarcoAurelio) [12:33:09] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Narayam Tamil Transliteration Bug - https://phabricator.wikimedia.org/T33025#2895932 (10MarcoAurelio) [12:33:11] 10MediaWiki-extensions-Narayam, 07Tamil-Sites: Set transliteration as default for Tamil in Narayam - https://phabricator.wikimedia.org/T32178#2895934 (10MarcoAurelio) [12:33:13] 10Wikimedia-Extension-setup, 07Tamil-Sites: Install Narayam on Tamil wiki projects - https://phabricator.wikimedia.org/T31798#2895936 (10MarcoAurelio) [12:33:15] 10MediaWiki-extensions-InputBox, 07Tamil-Sites: Support to Typing tools / Narayam in Inputbox - https://phabricator.wikimedia.org/T31776#2895937 (10MarcoAurelio) [12:33:17] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Update tamil typing rules - https://phabricator.wikimedia.org/T31816#2895935 (10MarcoAurelio) [12:33:19] 10Wikimedia-General-or-Unknown, 07Bengali-Sites, 07Tamil-Sites: "Main Page" link is removed in vectorTabs - https://phabricator.wikimedia.org/T31076#2895938 (10MarcoAurelio) [12:33:21] 10Collection, 10Internet-Archive, 07I18n, 07Tamil-Sites: PDF generation does not support Complex Script Wikis (e.g. Indic languages) and needs to be re-written - https://phabricator.wikimedia.org/T30206#2895939 (10MarcoAurelio) [12:33:23] 10Wikimedia-Site-requests, 07Tamil-Sites: Change name of Portal talk namespace on Tamil Wikipedia - https://phabricator.wikimedia.org/T25048#2895940 (10MarcoAurelio) [12:33:25] 10Wikimedia-Site-requests, 07Tamil-Sites: Adding logo to Tamil Wikinews - https://phabricator.wikimedia.org/T21619#2895941 (10MarcoAurelio) [12:33:27] 10Wikimedia-Site-requests, 07Tamil-Sites: Request Portal Namespace - https://phabricator.wikimedia.org/T15221#2895943 (10MarcoAurelio) [12:33:29] 10Wikimedia-Site-requests, 07Tamil-Sites: Set Wikipedia namespace for ta.wp - https://phabricator.wikimedia.org/T15220#2895944 (10MarcoAurelio) [12:33:31] 10Wikimedia-Site-requests, 07Tamil-Sites: Site name translated to Tamil (ta) - https://phabricator.wikimedia.org/T15222#2895942 (10MarcoAurelio) [12:33:33] 10Wikimedia-Site-requests, 07Tamil-Sites: Request for setting up tamil wikisource site - https://phabricator.wikimedia.org/T8982#2895945 (10MarcoAurelio) [12:33:37] 10MediaWiki-Internationalization, 07Tamil-Sites: Image talk pages treated as separate articles - https://phabricator.wikimedia.org/T6889#2895946 (10MarcoAurelio) [12:33:39] 10MediaWiki-Internationalization, 07Tamil-Sites: Some namespaces are not translated in LanguageTa.php (Tamil) - https://phabricator.wikimedia.org/T4753#2895950 (10MarcoAurelio) [12:33:41] 10MediaWiki-Internationalization, 07Tamil-Sites: Linktrail for Tamil (ta) - https://phabricator.wikimedia.org/T4981#2895949 (10MarcoAurelio) [12:33:43] 10Wikimedia-Language-setup, 07I18n, 07Tamil-Sites: Support dynamic fonts (CSS 3 @font-face, ttf/otf/eot, web fonts, WOFF) - https://phabricator.wikimedia.org/T4361#2895951 (10MarcoAurelio) [12:34:05] (03CR) 10Catrope: [C: 032] Special:RC filter: userExpLevel [core] - 10https://gerrit.wikimedia.org/r/321744 (https://phabricator.wikimedia.org/T149637) (owner: 10Sbisson) [12:34:27] 10MediaWiki-extensions-Narayam, 07Tamil-Sites: Set transliteration as default for Tamil in Narayam - https://phabricator.wikimedia.org/T32178#2895999 (10MarcoAurelio) [12:34:29] 10MediaWiki-extensions-Narayam, 07I18n, 07Tamil-Sites: Update tamil typing rules - https://phabricator.wikimedia.org/T31816#2896000 (10MarcoAurelio) [12:34:31] 10Wikimedia-Extension-setup, 07Tamil-Sites: Install Narayam on Tamil wiki projects - https://phabricator.wikimedia.org/T31798#2896001 (10MarcoAurelio) [12:34:33] 10MediaWiki-extensions-InputBox, 07Tamil-Sites: Support to Typing tools / Narayam in Inputbox - https://phabricator.wikimedia.org/T31776#2896002 (10MarcoAurelio) [12:34:36] 10Wikimedia-General-or-Unknown, 07Bengali-Sites, 07Tamil-Sites: "Main Page" link is removed in vectorTabs - https://phabricator.wikimedia.org/T31076#2896003 (10MarcoAurelio) [12:34:38] 10Wikimedia-Site-requests, 07Tamil-Sites: Change name of Portal talk namespace on Tamil Wikipedia - https://phabricator.wikimedia.org/T25048#2896005 (10MarcoAurelio) [12:34:41] 10Collection, 10Internet-Archive, 07I18n, 07Tamil-Sites: PDF generation does not support Complex Script Wikis (e.g. Indic languages) and needs to be re-written - https://phabricator.wikimedia.org/T30206#2896004 (10MarcoAurelio) [12:34:43] 10Wikimedia-Site-requests, 07Tamil-Sites: Adding logo to Tamil Wikinews - https://phabricator.wikimedia.org/T21619#2896006 (10MarcoAurelio) [12:34:45] 10Wikimedia-Site-requests, 07Tamil-Sites: Site name translated to Tamil (ta) - https://phabricator.wikimedia.org/T15222#2896007 (10MarcoAurelio) [12:34:47] 10MediaWiki-Internationalization, 07Tamil-Sites: Image talk pages treated as separate articles - https://phabricator.wikimedia.org/T6889#2896011 (10MarcoAurelio) [12:34:49] 10Wikimedia-Site-requests, 07Tamil-Sites: Set Wikipedia namespace for ta.wp - https://phabricator.wikimedia.org/T15220#2896009 (10MarcoAurelio) [12:34:51] 10Wikimedia-Site-requests, 07Tamil-Sites: Request for setting up tamil wikisource site - https://phabricator.wikimedia.org/T8982#2896010 (10MarcoAurelio) [12:34:53] 10Wikimedia-Site-requests, 07Tamil-Sites: Request Portal Namespace - https://phabricator.wikimedia.org/T15221#2896008 (10MarcoAurelio) [12:34:55] 10MediaWiki-Internationalization, 07Tamil-Sites: Linktrail for Tamil (ta) - https://phabricator.wikimedia.org/T4981#2896013 (10MarcoAurelio) [12:35:00] 10Wikimedia-General-or-Unknown, 07Tracking: Tamil Wiki projects (tracking) - https://phabricator.wikimedia.org/T34578#2895953 (10MarcoAurelio) [12:35:02] 10Wikimedia-Language-setup, 07I18n, 07Tamil-Sites: Support dynamic fonts (CSS 3 @font-face, ttf/otf/eot, web fonts, WOFF) - https://phabricator.wikimedia.org/T4361#2896015 (10MarcoAurelio) [12:35:25] Reedy: Are you here? [12:35:39] Yup [12:35:52] In IcuCOllation.php [12:35:54] $this->mainCollator = Collator::create( $locale ); [12:36:04] Theres lotts of calls to this calss [12:36:06] class [12:36:14] 10Wikimedia-General-or-Unknown, 07Tracking: Tamil Wiki projects (tracking) - https://phabricator.wikimedia.org/T34578#2896023 (10MarcoAurelio) 05Open>03Invalid p:05Normal>03Lowest a:05Logicwiki>03None This tracking task has been superseded by #Tamil-Sites. Please use/watch that project instead. Tha... [12:36:16] includes/collation/IcuCollation.php:257 PhanUndeclaredClassMethod Call to method create from undeclared class \Collator [12:36:24] Reedy: It triggers phan [12:37:07] Reedy: Can i fix it by "$collator = new Collator()" [12:37:18] and call to $colattor [12:37:19] I imagine not [12:37:47] rlot: Collator comes from php-intl [12:37:53] Install that if you haven't already [12:38:04] 07Tracking: [DO NOT USE] Tamil Wiki projects (tracking) [superseded by #Tamil-Sites] - https://phabricator.wikimedia.org/T34578#2896025 (10MarcoAurelio) [12:38:06] Reedy: Ok, thanks! [12:38:16] https://secure.php.net/manual/en/collator.create.php [12:38:24] rlot: Are you using vagrant? [12:38:29] https://secure.php.net/manual/en/class.collator.php [12:38:33] Reedy: Nope, local set up [12:38:37] Ah, ok [12:38:45] I was gonna say, if vagrant isn't installing php-intl... :D [12:39:10] (03CR) 10Robert Vogel: [V: 032 C: 032] Initial commit [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/327207 (owner: 10Robert Vogel) [12:41:27] Reedy: Normally, without changing anything in config.php, phan should'nt show warnings [12:41:37] Nope [12:41:43] Usually it means other "misconfiguration" [12:41:47] /missing dependancies [12:41:47] (03Merged) 10jenkins-bot: Special:RC filter: userExpLevel [core] - 10https://gerrit.wikimedia.org/r/321744 (https://phabricator.wikimedia.org/T149637) (owner: 10Sbisson) [12:42:37] Reedy: Oh, 200 errors here... [12:42:45] Oh aye? [12:42:55] I've not run it locally, so no idea [12:44:19] rlot: Such as? [12:44:39] I believe, everything under normal circumstances should've been suppressed [12:44:46] So the test can be run, and things fixed up [12:46:19] Reedy: Why is that code made like that: [12:46:20] static $reservedUsernames = false; [12:46:20] if ( !$reservedUsernames ) { [12:46:20] $reservedUsernames = $wgReservedUsernames; [12:46:20] Hooks::run( 'UserGetReservedNames', [ &$reservedUsernames ] ); [12:46:20] } [12:46:22] // Certain names may be reserved for batch processes. [12:46:26] foreach ( $reservedUsernames as $reserved ) { [12:46:35] Which bit? [12:46:36] The static? [12:46:36] its declared to statis [12:46:46] Yep, and then passed to foreach [12:47:19] It's to make sure the hook is only called once, in any instantiation of the class [12:48:12] (03CR) 10MtDu: [C: 031] Replaced Linker::link() usages with LinkRenderer [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/328641 (https://phabricator.wikimedia.org/T149346) (owner: 10LukBukkit) [12:48:23] Reedy: I'm getting includes/user/User.php:871 PhanTypeMismatchForeach bool passed to foreach instead of array [12:48:40] rlot: I guess, it's a false positive [12:49:09] Reedy: So i need to skip it? [12:49:27] I'm trying to think if there's another way to do it [12:49:34] Can you force an annotation that it's an array? [12:50:26] $wgReservedUsernames should be array [12:50:39] it is [12:50:54] But I guess, it's hard for the code to know that $reservedUsernames is gonna become a bool [12:51:04] And just setting it to [] and looking at count isn't going to work well [12:51:10] As there may be no reserved usernames [12:51:27] and as such, we'd run it multiple times [12:51:42] rlot: The other option, is to add whatever the phan ignore syntax comments are [12:52:17] Reedy: Is there any documentation of this syntax? [12:52:25] 10MediaWiki-extensions-CentralNotice: Ability to add a CentralNotice banner to a campaign through the banner view - https://phabricator.wikimedia.org/T31845#2896032 (10Aklapper) [12:52:32] would be helpful for this task [12:53:22] Indeed [12:53:48] (03PS10) 10TTO: User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) [12:53:50] (03PS6) 10TTO: Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) [12:54:28] Reedy: @suppress ? [12:54:50] @supress PhanTypeMismatchForeach [12:54:55] Should be ok [12:55:41] looks sensible [12:55:46] Try it :) [12:56:00] Reedy: Or /** @var array */ [12:56:22] [12:49:34] Can you force an annotation that it's an array? [12:56:23] ;) [12:56:36] That's probably a better fix [12:56:56] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Cannot find site jenkins_u3_mw - https://phabricator.wikimedia.org/T121083#2896033 (10daniel) Well yea. We no longer override the default side ID with "mywiki", so now it's the database name. Setting $wgWBClientSettings['siteGroup'] should fix it. [13:00:22] (03CR) 10jerkins-bot: [V: 04-1] User group memberships that expire [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [13:03:40] (03CR) 10jerkins-bot: [V: 04-1] Disregard expired user_group rows in special page and API DB queries [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [13:04:34] Reedy: Same error "$mmfl = [ 'setupFiles' => [] ];" "Foreach $mmfl['setupfiles'] as $..." [13:04:48] $mmfl is delared as array here [13:04:49] Well... that's obviously an array [13:05:41] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896036 (10Kaartic) [13:06:11] Reedy: its interpreted as string [13:06:19] That sounds like a bug [13:06:44] Reedy: Ignore with @supress? [13:10:08] 10MediaWiki-extensions-FlaggedRevs, 07Easy, 03Google-Code-In-2016: FlaggedRevs uses deprecated attribute "width" on diff pages - https://phabricator.wikimedia.org/T42211#2896049 (10Aklapper) [13:10:25] 10Wikispeech: Improve utterance storage - https://phabricator.wikimedia.org/T153841#2896052 (10Sebastian_Berlin-WMSE) I've experimented with an AJAX solution (I think, I'm still not entirely sure of the definition) that seems to work. I've added a `prop` to `action=query` which gets the HTML (using a FauxReques... [13:11:04] 10MediaWiki-extensions-FlaggedRevs, 07Easy, 03Google-Code-In-2016: FlaggedRevs uses deprecated attribute "width" on diff pages - https://phabricator.wikimedia.org/T42211#436714 (10Aklapper) [13:11:35] (03PS1) 10TTO: Make CentralAuth work with expiring user groups in core [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328662 [13:11:57] 10MediaWiki-extensions-FlaggedRevs, 07Easy, 03Google-Code-In-2016: FlaggedRevs uses deprecated attribute "width" on diff pages - https://phabricator.wikimedia.org/T42211#436714 (10Aklapper) ("align" seems to have gotten replaced in the meantime since this task was created.) I'll mentor this in GCI 2016. [13:12:48] 04(no projects): Weird screen shown when clicking the - https://phabricator.wikimedia.org/T153946#2896056 (10Kaartic) [13:13:26] 04(no projects): Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896067 (10Kaartic) [13:14:08] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896036 (10Urbanecm) You can change this yourself. Simply add ?uselang=qqx (or if ? is present in the URL, use &uselang=qqx) and at the... [13:14:32] (03CR) 10jerkins-bot: [V: 04-1] Make CentralAuth work with expiring user groups in core [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328662 (owner: 10TTO) [13:35:49] 10MediaWiki-Special-pages: Special:GlobalUserRights returns 500 everywhere - https://phabricator.wikimedia.org/T153920#2896097 (10Aklapper) [13:35:54] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2896100 (10Aklap... [13:37:12] 06Community-Liaisons, 10Wikimedia-Hackathon-2017-Organization, 06Developer-Relations (Jan-Mar-2017): Create language stickers for international events - https://phabricator.wikimedia.org/T128722#2896101 (10Aklapper) Yes. Everything else is covered by ____ that people can fill in. :) [13:38:09] (03PS4) 10Niharika29: Make language-appropriate collations default during install [core] - 10https://gerrit.wikimedia.org/r/327762 (https://phabricator.wikimedia.org/T47611) [13:38:33] Reedy: Is it ok? $plRes, $tlRes, $ilRes = []; [13:38:43] will it be interpreted as array? [13:38:55] I don't think plRes and $tlRes will be interpretted as anything [13:38:59] they've not got anything assigned [13:39:18] Reedy: [13:39:19] if ( $fetchlinks ) { [13:39:19] $plRes = $queryFunc( $dbr, 'pagelinks', 'pl_from' ); [13:39:19] } [13:39:19] if ( !$hidetrans ) { [13:39:19] $tlRes = $queryFunc( $dbr, 'templatelinks', 'tl_from' ); [13:39:21] } [13:39:23] if ( !$hideimages ) { [13:39:25] $ilRes = $queryFunc( $dbr, 'imagelinks', 'il_from' ); [13:39:29] } [13:39:34] I have that code, and these var. are interpreted as null [13:40:06] Because it's almost impossible to decipher statically [13:40:10] Reedy: So i need to assign it by calling $plRes = []; $tlRes = []; $ilRes = []; [13:40:13] Only at runtime are values apparent [13:40:36] But, when i'll use this code, it will be assigned to that? [13:40:44] Or just supress it [13:41:00] I think explicitly defining them as arrays is sensible [13:41:17] As they're only conditionally defined like that [13:41:17] (03CR) 10Bartosz Dziewoński: [C: 032] Align mw.widgets.DateInputWidget to OOjs UI's MediaWiki theme widgets [core] - 10https://gerrit.wikimedia.org/r/318485 (https://phabricator.wikimedia.org/T149270) (owner: 10VolkerE) [13:41:50] Reedy: So this $plRes = []; $tlRes = []; $ilRes = []; is correct? (Btw, can it be inline) [13:44:13] Reedy: How i can assign it inline? [13:44:54] Reedy: $plRes = $tlRes = $ilRes = []; [13:44:56] ? [13:46:25] 07Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 03UI-Standardization-Kanban: mw.widgets.DateInputWidget does not match the design of other widgets in MediaWiki theme - https://phabricator.wikimedia.org/T149270#2896106 (10matmarex) 05Open>03Resolved a:03Volker_E [13:46:27] Just do it on three lines [13:49:59] (03Merged) 10jenkins-bot: Align mw.widgets.DateInputWidget to OOjs UI's MediaWiki theme widgets [core] - 10https://gerrit.wikimedia.org/r/318485 (https://phabricator.wikimedia.org/T149270) (owner: 10VolkerE) [13:51:44] 04(no projects): Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896056 (10MarcoAurelio) Projects please :-) [13:54:07] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hook usage [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [13:54:14] (03CR) 10Reedy: [C: 04-1] Removed deprecated hook usage [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [14:03:57] @seen FlorianSW [14:03:57] subins2000: FlorianSW is in here, right now [14:04:07] FlorianSW: So, what should I do about this : https://gerrit.wikimedia.org/r/#/c/328651/1/includes/user/User.php@2074 ? [14:06:46] (03PS2) 10Subins2000: Remove &$this usage [core] - 10https://gerrit.wikimedia.org/r/328651 (https://phabricator.wikimedia.org/T153505) [14:14:10] 10Utilities-mwdumper: Error while importing xml dump - https://phabricator.wikimedia.org/T153922#2896120 (10Vituzzu) I eventually managed to fix it: WMF's install actually uses VARBINARY(255) instead of VACHAR(255) (as for mediawiki's default) for page_title column. An ALTER table 'page' CHANGE COLUMN 'page_titl... [14:15:40] (03PS1) 10Robert Vogel: Changed gerrit default branch [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328668 [14:16:37] 04(no projects): Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896122 (10Aklapper) Hi @Kaartic, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce th... [14:16:43] (03CR) 10Robert Vogel: [C: 032] Changed gerrit default branch [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328668 (owner: 10Robert Vogel) [14:17:05] (03CR) 10jerkins-bot: [V: 04-1] Changed gerrit default branch [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328668 (owner: 10Robert Vogel) [14:18:07] (03CR) 10Robert Vogel: [V: 032 C: 032] Changed gerrit default branch [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328668 (owner: 10Robert Vogel) [14:18:13] 10MediaWiki-General-or-Unknown, 07Technical-Debt: Duplicate code in SiteConfiguration - https://phabricator.wikimedia.org/T39238#2896123 (10Aklapper) Removing #easy as the previous patch has shown that it's not clear for a contributor how to refactor. [14:19:24] subins2000: you should check, if any extension actually need the user object as a reference. If so, anything is fine, otherwise change the function to now pass it by reference :) [14:19:52] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Easy, 07I18n, 07RTL: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#2896126 (10Aklapper) [14:20:02] (03PS1) 10Robert Vogel: Fixed hook handler signature [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328669 [14:20:39] (03CR) 10Robert Vogel: [V: 032 C: 032] Fixed hook handler signature [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328669 (owner: 10Robert Vogel) [14:21:08] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Easy, 07I18n, 07RTL: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#406919 (10Aklapper) [14:21:10] 10MediaWiki-Interface, 07JavaScript: Include a time picker widget module in core - https://phabricator.wikimedia.org/T38794#2896130 (10Aklapper) [14:21:16] 06Wikipedia-Android-App-Backlog: Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896132 (10Kaartic) [14:21:28] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Easy, 07I18n, 07RTL: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#406919 (10Aklapper) [14:21:30] 10MediaWiki-Interface, 07JavaScript: Include a time picker widget module in core - https://phabricator.wikimedia.org/T38794#407046 (10Aklapper) [14:21:33] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.3), 03UI-Standardization-Kanban: Improve form layouts in OOUI MW core forms for better user experience - https://phabricator.wikimedia.org/T136790#2896134 (10matmarex) Yeahhh. [14:21:37] (03PS1) 10LukBukkit: Replaced Linker::link() usages with LinkRenderer [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/328670 (https://phabricator.wikimedia.org/T149346) [14:21:51] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07I18n, 07RTL: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#406919 (10Aklapper) @awight: Blocked by T38794 hence not an #easy task. [14:24:06] 06Wikipedia-Android-App-Backlog: Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896142 (10Kaartic) >>! In T153946#2896111, @MarcoAurelio wrote: > Projects please :-) >>! In T153946#2896122, @Aklapper wrote: > Hi @Kaartic, thanks for... [14:28:15] 06Developer-Relations, 07I18n: Offering internationalized programming facilities within WM environment - https://phabricator.wikimedia.org/T150933#2896143 (10Psychoslave) Sorry if the message on mailing lists didn't match you expectation, I didn't thought you had question in mind when saying "What are the gene... [14:33:41] 06Editing-Analysis: Refine definition of active editors metric - https://phabricator.wikimedia.org/T151507#2896147 (10ezachte) I also responded on the talk page. And actually reconsidered while doing so. It seemed adding extensive code to detect internationalized redirects wasn't worth the trouble for filtering... [14:35:32] 04(no projects): thumbnail script should respect imgAuthBeforeStream - https://phabricator.wikimedia.org/T153948#2896148 (10MarkAHershberger) [14:35:42] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896160 (10Kaartic) >>! In T153945#2896068, @Urbanecm wrote: > You can change this yourself That's surprising! I didn't know you could e... [14:42:35] (03PS3) 10Mholloway: Make Google Maps use the coordinates supplied by Wikipedia app [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322293 (https://phabricator.wikimedia.org/T120275) (owner: 10Kunalgrover05) [14:43:53] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896164 (10Urbanecm) 05Open>03Invalid >>! In T153945#2896160, @Kaartic wrote: > Yes, of course. That's great! Only a small note. It... [14:48:29] (03CR) 10Mholloway: "This would be great to get across the finish line, so I made the final change. Kunal, if you disagree with this last change, please let u" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322293 (https://phabricator.wikimedia.org/T120275) (owner: 10Kunalgrover05) [14:48:38] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2844897 (10UltrasonicNXT) When you say parses the input element, you mean it uses the wikitext parser on any messages sent right? This is meant to happen, so users can easily ins... [14:49:47] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: Using the shortcut pipe trick for links doesn't output correctly in MediaWikiChat - https://phabricator.wikimedia.org/T145943#2645906 (10UltrasonicNXT) Ooh I didn't even know that was a thing in normal wikitext... :D I'll have a look, I would have expected that... [14:50:30] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: MediaWikiChat kicking doesn't remove the offending person from the sidebar - https://phabricator.wikimedia.org/T145309#2626175 (10UltrasonicNXT) Hmm, I'm pretty sure I remember there being some code for this, so I'll have a look. [14:51:40] 10MediaWiki-Special-pages, 06Community-Tech, 13Patch-For-Review, 07Schema-change, 06Stewards-and-global-tools (Temporary-UserRights): Setting a temporary usergroup (allow expiry of user rights via Special:UserRights form) - https://phabricator.wikimedia.org/T12493#2896172 (10MarcoAurelio) Hello: * How th... [14:51:56] 06Community-Liaisons, 10Wikimedia-Hackathon-2017-Organization, 06Developer-Relations (Jan-Mar-2017): Create language stickers for international events - https://phabricator.wikimedia.org/T128722#2896173 (10intracer) So far I came up with https://meta.wikimedia.org/wiki/User:Ilya/pl-logos [14:56:36] (03PS1) 10MarkAHershberger: thumbnail script should respect imgAuthBeforeStream [core] - 10https://gerrit.wikimedia.org/r/328672 (https://phabricator.wikimedia.org/T153948) [14:57:15] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Allow searching by performer in Special:GlobalRenameQueue - https://phabricator.wikimedia.org/T153919#2896197 (10MarcoAurelio) [14:57:17] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 06Stewards-and-global-tools: [GlobalRenameQueue] Provide better search - https://phabricator.wikimedia.org/T111837#2896199 (10MarcoAurelio) [14:57:20] 06Wikipedia-Android-App-Backlog: Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896200 (10Kaartic) [14:57:41] (03CR) 10MarkAHershberger: "not yet tested." [core] - 10https://gerrit.wikimedia.org/r/328672 (https://phabricator.wikimedia.org/T153948) (owner: 10MarkAHershberger) [14:58:33] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 06Stewards-and-global-tools: [GlobalRenameQueue] Provide better search - https://phabricator.wikimedia.org/T111837#1617491 (10MarcoAurelio) Merging the task above of mine regarding the same issue. It'd be good to have more search options enabled as stated a... [14:59:28] (03CR) 10Mholloway: "Anirudh, sorry we dropped the ball on this! Yes, I think dev_settings_strings.xml would be a fine place to add these." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/318042 (https://phabricator.wikimedia.org/T109618) (owner: 10Anirudh24seven) [15:00:39] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896208 (10Kaartic) >>! In T153945#2896164, @Urbanecm wrote: > > That's great! Only a small note. It won't be changed automatically at... [15:00:44] Why im getting "The outstanding commits are" [15:00:52] multiple commits? [15:00:56] Yes [15:01:04] not git pulled? [15:01:10] How can i stash them, and commit only my [15:01:22] I pulled, i'll try this again [15:01:40] 10MediaWiki-Special-pages, 06Community-Tech, 13Patch-For-Review, 07Schema-change, 06Stewards-and-global-tools (Temporary-UserRights): Setting a temporary usergroup (allow expiry of user rights via Special:UserRights form) - https://phabricator.wikimedia.org/T12493#2896209 (10jcrespo) Not only NULL is pre... [15:01:49] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 06Stewards-and-global-tools: Create more search fields in GlobalRenameQueue - https://phabricator.wikimedia.org/T111837#2896210 (10MarcoAurelio) [15:02:12] Reedy: Btw, when I pull, i'm getting editor in "Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core [15:02:13] " [15:02:14] Wierd [15:03:29] Reedy: Pulled, still gettting "" [15:03:31] 828a994 (HEAD -> Fix) Fixed PHP issues found by phan [15:03:31] 8766c4f Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core [15:03:31] 4a9d2a5 (T1513252) Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core [15:03:31] 94d017d Replaced &$this with $this [15:03:40] (03PS2) 10Phuedx: Send blob to everyone [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328500 (https://phabricator.wikimedia.org/T146889) [15:03:42] (03PS1) 10Phuedx: Make settings reducer control footer link [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328674 (https://phabricator.wikimedia.org/T146889) [15:03:44] (03PS1) 10Phuedx: Clicking cog sends user to Special:Preferences [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328675 (https://phabricator.wikimedia.org/T146889) [15:03:47] rebase? [15:06:13] (03Abandoned) 10Mholloway: Update gradlew to version 3.1 T144252 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321104 (owner: 10Adi1133) [15:06:23] Reedy: Still. Can i remove these unneeded commits? [15:06:28] yeah [15:06:31] the merges aren't neeed [15:06:47] and this last commit is alerady merged [15:06:57] *commited [15:08:25] (03PS1) 10Catrope: [WIP] RC filters: AJAX and pushState/popState [core] - 10https://gerrit.wikimedia.org/r/328676 (https://phabricator.wikimedia.org/T153949) [15:08:29] (03Abandoned) 10Mholloway: Cleanup unused theme styles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321102 (owner: 10Adi1133) [15:09:03] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896221 (10Kaartic) @Urbanecm I found something weird in english version [[ https://translatewiki.net/wiki/Special:Preferences#mw-prefse... [15:09:08] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896224 (10Kaartic) @Urbanecm I found something weird in english version [[ https://translatewiki.net/wiki/Special:Preferences#mw-prefse... [15:09:50] (03CR) 10Mholloway: "I vote EventLogging" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/284226 (owner: 10BearND) [15:10:26] Reedy: Can i review only one commit? [15:10:45] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: Using the shortcut pipe trick for links doesn't output correctly in MediaWikiChat - https://phabricator.wikimedia.org/T145943#2896226 (10UltrasonicNXT) hmm, looks like there is some sort of pre-parsing for this trick: https://en.wikipedia.org/wiki/Help:Pipe_trick [15:15:06] (03PS1) 10Robert Vogel: Fixed SHA-1 lookup [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328678 [15:16:01] (03CR) 10jerkins-bot: [V: 04-1] Fixed SHA-1 lookup [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328678 (owner: 10Robert Vogel) [15:16:37] rlot_: review or revert? [15:16:47] sounds like you're looking for a git manual? :) [15:16:54] (03CR) 10Robert Vogel: [V: 032 C: 032] Fixed SHA-1 lookup [extensions/NSFileRepo] (REL1_23) - 10https://gerrit.wikimedia.org/r/328678 (owner: 10Robert Vogel) [15:19:30] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896233 (10Urbanecm) I'll have look at it. As English version is the source it can't be translated using translatewiki.net. [15:20:48] (03PS1) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [15:21:31] (03CR) 10Catrope: [C: 04-1] Adding new interface for review filters to RecentChanges (036 comments) [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) (owner: 10Mooeypoo) [15:21:55] Reedy: andre__: Yeeh! Got it. checkout'ed master, then rebased to origin/master and cherry-picked this commit to new branch [15:22:07] Reedy: Can you take a look at this patch? [15:22:27] Reedy: https://gerrit.wikimedia.org/r/#/c/328679/ [15:22:44] (03PS8) 10Mholloway: Add basic 2FA support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322366 (https://phabricator.wikimedia.org/T150900) [15:24:09] 10MediaWiki-General-or-Unknown, 13Patch-For-Review: thumbnail script should respect imgAuthBeforeStream - https://phabricator.wikimedia.org/T153948#2896238 (10Aklapper) [15:24:18] (03CR) 10jerkins-bot: [V: 04-1] Add basic 2FA support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322366 (https://phabricator.wikimedia.org/T150900) (owner: 10Mholloway) [15:25:19] (03PS1) 10Anomie: When authorizing, differentiate mwoauth-authonlyprivate from mwoauth-authonly or basic [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/328680 [15:28:07] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [15:32:55] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896245 (10Urbanecm) Got it. This is caused by https://translatewiki.net/wiki/MediaWiki:Smw-prefs-ask-options-collapsed-default. This ov... [15:35:04] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896246 (10Urbanecm) Was deleted. Please check it. [15:37:34] FlorianSW: Wouldn't I have to check each and every extensions to see it they need it by reference ? [15:37:55] FlorianSW: I'm keeping it that way. Don't want to break up anything :) [15:38:42] subins2000: Look for that hook on mediawiki. There's list of extensions using hooks [15:40:07] (03PS9) 10Mholloway: Add basic 2FA support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322366 (https://phabricator.wikimedia.org/T150900) [15:40:46] Reedy: Can you look at this error? [15:40:49] On gerrit [15:41:14] rlot_: Let me see... [15:41:58] (03CR) 10jerkins-bot: [V: 04-1] Add basic 2FA support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322366 (https://phabricator.wikimedia.org/T150900) (owner: 10Mholloway) [15:43:52] (03CR) 10Anomie: Fixed PHP issues found by phan (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [15:45:41] (03PS10) 10Mholloway: Add basic 2FA support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322366 (https://phabricator.wikimedia.org/T150900) [15:48:43] 10MediaWiki-Page-editing, 07Easy, 07User-notice: Allow posting new sections to top of page on a per-page basis - https://phabricator.wikimedia.org/T33919#2896266 (10Aklapper) [15:49:31] (03CR) 10Anomie: Make CentralAuth work with expiring user groups in core (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328662 (owner: 10TTO) [15:52:07] (03CR) 10Anomie: Disregard expired user_group rows in special page and API DB queries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328491 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [15:53:30] (03CR) 10Kunalgrover05: [C: 031] "Ah yes sorry, I thought I had sent the CR. Thanks!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322293 (https://phabricator.wikimedia.org/T120275) (owner: 10Kunalgrover05) [15:55:13] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 13Patch-For-Review, and 2 others: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2896271 (10Pcoombe) Looks good to me. Thanks! [15:56:14] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2896273 (10MZMcB... [15:56:49] (03PS2) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [15:57:31] (03CR) 10Filip: "@anomie: Thanks! It does now trigger warnings now" [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [15:58:48] (03PS3) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [15:59:42] 10MediaWiki-History-or-Diffs, 10MediaWiki-Recent-changes, 07Easy: Keep classes such as "diff-addedline" and "diff-deletedline" on diffs on RSS feeds - https://phabricator.wikimedia.org/T36800#2896283 (10Aklapper) [16:00:33] (03PS1) 10Umherirrender: Fix $wgMessagesDirs in old entry point [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/328684 [16:02:29] 04(no projects): Create namespace redirection "DW:" for fr.wp - https://phabricator.wikimedia.org/T153952#2896304 (10Benoit_Rochon) [16:02:49] (03PS1) 10Jkroll: [WIP] Extend WikiDiff2 to show changes inside moved paragraphes [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/328685 [16:02:52] 10MediaWiki-History-or-Diffs, 10MediaWiki-Recent-changes, 07Easy: Keep classes such as "diff-addedline" and "diff-deletedline" on diffs on RSS feeds - https://phabricator.wikimedia.org/T36800#2896315 (10Aklapper) [16:03:32] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work): Do not depend on spaces to activate proximity rescoring (phrase rescore) - https://phabricator.wikimedia.org/T152094#2896318 (10dcausse) a:03dcausse Will start to work on this as it may help Erik with its LTR plugin. [16:05:00] 10MediaWiki-API, 07Documentation: Auto-generated API documentation should mention equivalent UI page - https://phabricator.wikimedia.org/T37234#2896324 (10Aklapper) > For example, a user searching the page for the equivalent of "Special:WhatLinksHere" can't easily discover that such functionality is tucked awa... [16:05:06] Reedy: Ok, works now! [16:06:01] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [16:06:33] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Evaluate using SERP click throughs to build a search feedback loop - https://phabricator.wikimedia.org/T148811#2896326 (10Nuria) [16:06:42] 10Wikimedia-Site-requests: Create namespace redirection "DW:" for fr.wp - https://phabricator.wikimedia.org/T153952#2896327 (10Aklapper) Setting project to #Wikimedia-Site-requests, as this request is about settings / configuration of a Wikimedia website. For more information about how to request these kinds o... [16:08:10] 10MediaWiki-extensions-CLDR, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 15User-Daniel: Include "special" languages in language selector for monolingual text - https://phabricator.wikimedia.org/T153850#2896333 (10Micru) @Nikki Thanks for the query, I have completed the missing information and no... [16:08:18] legoktm: Reedy: Can you look at this jenkins error? https://gerrit.wikimedia.org/r/#/c/328679/ [16:10:41] (03PS9) 10C. Scott Ananian: Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) [16:10:43] (03PS10) 10C. Scott Ananian: Protect -{...}- variant constructs in definition lists. [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) [16:10:45] (03PS3) 10C. Scott Ananian: Preserve null bytes in LanguageConverter conversions. [core] - 10https://gerrit.wikimedia.org/r/327779 [16:10:48] (03PS25) 10C. Scott Ananian: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [16:10:51] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "The changes in PS2 look very good. I will merge this tomorrow. Just want to give others a chance to see this." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 (owner: 10Ladsgroup) [16:12:52] (03CR) 10Parent5446: Fixed PHP issues found by phan (036 comments) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [16:20:36] (03CR) 10C. Scott Ananian: [C: 032] "Re-applying Tim's C+2 after cherry-pick." [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) (owner: 10C. Scott Ananian) [16:23:01] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2896365 (10bmansurov) > In general, I think it's a good idea to add an element name to the outermost HTML element generated by the... [16:24:48] (03CR) 10jerkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [16:30:36] 10MediaWiki-extensions-ContentTranslation: Add Spanish alias to ContentTranslation - https://phabricator.wikimedia.org/T153954#2896372 (10MarcoAurelio) [16:32:51] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 07I18n: Allow users to code in localized programming languages - https://phabricator.wikimedia.org/T150417#2896387 (10Psychoslave) It indeed works well, thank you @Yair_rand and @Reedy :) [16:35:47] (03Merged) 10jenkins-bot: Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) (owner: 10C. Scott Ananian) [16:39:58] 07Easy, 03Google-Code-In-2016: Create a gadget that displays the Wikidata ID of a page near the title - https://phabricator.wikimedia.org/T148596#2896392 (10Strainu) 05Open>03Resolved Now, there is one more available :) https://ro.wikipedia.org/wiki/MediaWiki:Gadget-wikidata-id.js [16:40:10] (03PS4) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [16:41:00] 10MediaWiki-Recent-changes, 07Easy, 13Patch-For-Review: Function applyDiffStyle uses regexes which do not detect CSS classes appropriately - https://phabricator.wikimedia.org/T36801#2896394 (10Aklapper) [16:41:04] (03CR) 10Anomie: "If you simply change "rev_page = '1'" to "rev_page = 1" in the query, that also gets rid of the filesort. Fun MySQL/MariaDB weirdness, I'l" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [16:42:46] Reedy: Are you here? [16:42:55] 10MediaWiki-Recent-changes, 07Easy, 13Patch-For-Review: Function applyDiffStyle uses regexes which do not detect CSS classes appropriately - https://phabricator.wikimedia.org/T36801#388381 (10Aklapper) Wonderin if http://stackoverflow.com/questions/28572450/php-regex-matches-html-tags-contain-a-certain-class... [16:43:25] rlot_: I am, just catching up on emails and stuff [16:46:10] (03PS1) 10Umherirrender: Readd $wgMessagesDirs [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/328687 [16:47:37] 06Stewards-and-global-tools, 10Wikimedia-Site-requests, 13Patch-For-Review: Allow private.dblist wikis to manage more permissions internally - https://phabricator.wikimedia.org/T152489#2896398 (10MarcoAurelio) 05Open>03declined [16:47:50] 06Stewards-and-global-tools, 10Wikimedia-Site-requests: Allow private.dblist wikis to manage more permissions internally - https://phabricator.wikimedia.org/T152489#2850067 (10MarcoAurelio) [16:47:57] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [16:48:42] Reedy: Ok! Can you look at jenkins fail ^^^ Should i fix it? [16:48:46] 10Wikimedia-Site-requests: On wikis where uploads are fully disabled remove upload rights on any group - https://phabricator.wikimedia.org/T143789#2896400 (10MarcoAurelio) 05Open>03declined [16:50:07] 10MediaWiki-extensions-FlaggedRevs, 07Easy: Use ResourceLoader/mw.config for jsReviewNeedsChange variable - https://phabricator.wikimedia.org/T36716#2896403 (10Aklapper) [16:50:31] rlot_: If you haven't fixed all the "PhanTypeMismatchForeach", you don't want to disable it in your commit [16:50:36] Just update the // approximate error count: 16 [16:51:01] Or are they new from your changes? [16:51:20] Reedy: Looks like its not PhanTypeMismatchForeach [16:51:24] 10MediaWiki-Watchlist: Tool tip / mouse over on changed number of bytes in watchlist (saying e.g. "144 characters less") - https://phabricator.wikimedia.org/T36496#2896406 (10Aklapper) [16:51:30] I tried to fix all Of PhanTypeMismatchForeach [16:52:03] Reedy: But maybe its it. I'll update it, and submit on GCI [16:55:30] Reedy: Its unrelated for me [16:55:46] rlot_: Well, you've changed something that's causing it to break [16:55:50] Even if it's just disabling that warning [16:55:53] (03CR) 10Jcrespo: "> If you simply change "rev_page = '1'" to "rev_page = 1"" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [16:55:58] 10MediaWiki-extensions-Page_Forms: "missing argument" error in page form extension when creating class - https://phabricator.wikimedia.org/T153914#2894909 (10Yaron_Koren) This looks like a problem with the AccessLog extension (or sub-extension) - I suggest you contact whoever is in charge of it. [16:57:51] 10MediaWiki-Vagrant, 10Gerrit, 13Patch-For-Review: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2896426 (10Mainframe98) >>! In T152801#2889065, @bd808 wrote: > Another possible workaround would be to `git clone -b master --single-branch https://ger... [16:57:53] (03PS5) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [16:58:45] (03PS6) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [16:58:47] 10MediaWiki-extensions-Page_Forms: preg_replace error in page forms when previewing or saving a page's template call from form - https://phabricator.wikimedia.org/T153915#2894926 (10Yaron_Koren) Could you paste the form definition here? [16:59:32] Reedy: Ok, i think thats its. I'll wait for jenkins, and can you review it? [16:59:36] 10Wikimedia-Site-requests, 13Patch-For-Review, 07Performance: Raise $wgAbuseFilterConditionLimit for Meta-Wiki - https://phabricator.wikimedia.org/T147063#2896431 (10MarcoAurelio) 05stalled>03declined If we need this again feel free to reopen. [17:00:00] (03CR) 10Jcrespo: "@Brian Wolff Your ping didn't notify me, I just run into this by accident. The idea looks good. Let me do some testing with actual metrics" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [17:00:32] (03PS1) 10Umherirrender: Add $wgMessagesDirs [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/328689 [17:03:05] 10Phabricator (Upstream), 07Upstream: Allow pastes to be deleted or to expire - https://phabricator.wikimedia.org/T145752#2896435 (10MarcoAurelio) 05Open>03declined [17:03:10] 10UI-Standardization, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 03UI-Standardization-Kanban: Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#2896436 (10Volker_E) [17:04:23] 10UI-Standardization, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 03UI-Standardization-Kanban: Echo Notifications Thank You uses outdated PNG icon instead of SVG - https://phabricator.wikimedia.org/T149352#2749556 (10Volker_E) a:05Volker_E>03MtDu [17:04:46] 10MediaWiki-Database, 10DBA, 07Performance: revision page_user_timestamp index problematic on large wikis - https://phabricator.wikimedia.org/T102532#2896440 (10jcrespo) [17:06:23] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [17:07:36] Reedy: Wierd, can you take a look at it? ^^ [17:09:01] (03CR) 10Jcrespo: "@Brian Wolff Re:T102532 work is ongoing to unify and sync revision table. I feel like an archaeologist who is discovering missing pieces o" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [17:11:31] 10MediaWiki-File-management, 10MediaWiki-General-or-Unknown, 06Commons, 06Multimedia: Provide meaningful error messages for notice/error showing on view or attemnt to create a page in namespace File lacking file extension in its title - https://phabricator.wikimedia.org/T153865#2896444 (10MarkTraceur) p:0... [17:12:50] 10MediaWiki-Vagrant, 10Gerrit, 13Patch-For-Review: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2896448 (10bd808) >>! In T152801#2896426, @Mainframe98 wrote: > However, when upgrading to 2.11.0, it does work. Does this mean that Vagrant can't clone... [17:13:36] @Reedy: "Call to method numRows on non-class type array [17:13:36] " [17:13:54] @Reedy: Looks like it should be just @suppress [17:15:17] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: Using the shortcut pipe trick for links doesn't output correctly in MediaWikiChat - https://phabricator.wikimedia.org/T145943#2896453 (10UltrasonicNXT) Okay, this is T4700 [17:15:44] 10MediaWiki-File-management, 10MediaWiki-General-or-Unknown, 06Commons, 06Multimedia: Disable possibility to create extensionless File namespace pages - https://phabricator.wikimedia.org/T153864#2893380 (10MarkTraceur) Sooooo... As a matter of principle on *WMF* wikis, I agree, this would be a useful chan... [17:15:49] (03PS7) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [17:15:56] Reedy: Should fix it [17:17:22] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: Using the shortcut pipe trick for links doesn't output correctly in MediaWikiChat - https://phabricator.wikimedia.org/T145943#2645906 (10ashley) You'll probably want `Parser`'s `preSaveTransform`. Quick example code you can run in `/maintenance/eval.php` to tr... [17:19:43] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2896459 (10ashley) I can't remember for sure, but I think this ticket was about MWC parsing a literal `` into, well, HTML. Needless to say that if you write `` on a... [17:20:58] (03PS1) 10BryanDavis: Install latest git client from PPA; upgrade git-review [vagrant] - 10https://gerrit.wikimedia.org/r/328691 (https://phabricator.wikimedia.org/T152801) [17:21:24] (03Draft3) 10Base: Adding i18n for the Module tab [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/328590 [17:21:33] 10MediaWiki-File-management, 06Multimedia, 07Security-General: .txt files "may contain malicious content" - https://phabricator.wikimedia.org/T153843#2896465 (10MarkTraceur) p:05Triage>03Low You can "fix" this by doing the following in LocalSettings.php: $wgTrustedMediaFormats[] = 'text/plain'; If yo... [17:25:35] (03PS1) 10Kaldari: Add check for extension installation to maintenance script [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/328692 [17:26:22] 10MediaWiki-extensions-FlaggedRevs: Edits made by whitelist members listed as pending changes - https://phabricator.wikimedia.org/T78407#2896480 (10Superyetkin) [[ https://tr.wikipedia.org/w/index.php?title=K%C4%B1zlar_Erkeklerden_Ne_%C4%B0ster%3F&type=revision&diff=14908211&oldid=13028449 | Here ]] is an example. [17:27:20] 06Research-and-Data, 10Research-outreach, 10WikiCite: Dates/locations/hosts for WikiCite 2017 - https://phabricator.wikimedia.org/T141640#2896481 (10DarTar) @Lydia_Pintscher @Daniel_Mietchen @Claudia.Garad @Rfarrand and I met today to kick off planning for the event. ([[ https://docs.google.com/document/d/1o... [17:27:57] 06Research-and-Data, 10Research-outreach, 10WikiCite, 03Research-and-Data-2016-17-Q3: Dates/locations/hosts for WikiCite 2017 - https://phabricator.wikimedia.org/T141640#2896486 (10DarTar) [17:28:23] 06Research-and-Data-Backlog, 10WikiCite, 07Epic, 03Research-and-Data-2016-17-Q3: Organize WikiCite 2017 - https://phabricator.wikimedia.org/T144291#2896489 (10DarTar) [17:28:50] (03CR) 10Brian Wolff: "The sql abstraction layer does force strings on the assumption it doesnt matter. However we can override it with raw sql on a case by case" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [17:28:54] 06Research-and-Data, 10Research-management, 10WikiCite: WikiCite 2017 fundraising - https://phabricator.wikimedia.org/T144292#2896490 (10DarTar) [17:29:31] 06Research-and-Data, 10Research-outreach, 10WikiCite, 03Research-and-Data-2016-17-Q3: WikiCite 2017: venue and local organization - https://phabricator.wikimedia.org/T141640#2505685 (10DarTar) [17:30:04] 06Research-and-Data, 10Research-management, 10WikiCite, 03Research-and-Data-2016-17-Q2: WikiCite 2017 fundraising - https://phabricator.wikimedia.org/T144292#2595210 (10DarTar) [17:30:10] (03PS1) 10Subramanya Sastry: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/328693 [17:30:34] 10MediaWiki-Uploading, 06Multimedia: Unexpected error "This SVG file contains an illegal namespace" for xmlns:rdfs attribute value - https://phabricator.wikimedia.org/T153285#2896494 (10MarkTraceur) p:05Triage>03Normal [17:30:38] (03PS1) 10Bmansurov: Fix the math element class name [extensions/Math] - 10https://gerrit.wikimedia.org/r/328694 (https://phabricator.wikimedia.org/T134281) [17:36:18] 10MediaWiki-File-management, 10CirrusSearch, 06Commons, 06Discovery, and 2 others: Ogg Opus-File should be classified as audio not multimedia-Files. - https://phabricator.wikimedia.org/T151352#2896512 (10MarkTraceur) @MichaelSchoenitzer_WMDE could you give an example of a file that produces this result? I... [17:36:48] (03CR) 10Brian Wolff: "It just occured to me. I wonder if it would be more efficient to push all the where conditions other than rev_page into a subquery so that" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [17:42:49] Reedy: Fixed it, can you review this/submit? [17:44:16] (03CR) 10Anomie: User group memberships that expire (0319 comments) [core] - 10https://gerrit.wikimedia.org/r/328377 (https://phabricator.wikimedia.org/T12493) (owner: 10TTO) [17:45:27] (03CR) 10Arlolra: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/328693 (owner: 10Subramanya Sastry) [17:45:54] (03CR) 10MZMcBride: "Is $wgUsePigLatinVariant really necessary? Isn't there some existing array of localizations or variations that we can append "en-x-piglati" [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [17:46:58] 10MediaWiki-Uploading, 06Multimedia: Update mediawiki.Upload.BookletLayout.js for recent API error message changes - https://phabricator.wikimedia.org/T153200#2896524 (10MarkTraceur) p:05Triage>03High [17:50:09] Reedy: legoktm: Submited task on GCI [17:50:20] (03PS1) 10Gehel: Checkstyle - add the WhitespaceAround rule [search/highlighter] - 10https://gerrit.wikimedia.org/r/328695 [17:56:29] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/328693 (owner: 10Subramanya Sastry) [17:58:17] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2896535 (10MarkAHershberger) [17:59:48] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2707386 (10MarkAHershberger) [18:00:30] Reedy: Partent's advices are incorrect, warn [18:01:16] (03PS1) 10Sn1per: Add button to copy share/embed text to clipboard [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) [18:03:01] (03CR) 10Brian Wolff: "By which I mean, if we did a query like:" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [18:03:36] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2896567 (10MarkAHershberger) >>! In T147892#2890975, @srishakatux wrote: > edit the task description by referring to the template of... [18:04:04] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2896568 (10TameeshB) @bmansurov I dont think applying the css to the span and the img tags would work as i've checked doing that in... [18:05:04] 10Wikimedia-Site-requests, 07Tamil-Sites: [Suggestion] Change the text for "Move" option in tamil wiki from நகர்த்து to இடம் பெயர் - https://phabricator.wikimedia.org/T153945#2896569 (10Kaartic) >>! In T153945#2896246, @Urbanecm wrote: > Was deleted. Please check it. >>! In T153945#2896246, @Urbanecm wrote... [18:05:42] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2896570 (10cicalese) [18:06:21] (03PS2) 10Sn1per: Add button to copy share/embed text to clipboard [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) [18:07:30] (03CR) 10Cicalese: "Warning: Missing argument 2 for wfStreamThumb(), called in .../thumb.php on line 37 and defined in .../thumb.php on line 91" [core] - 10https://gerrit.wikimedia.org/r/328672 (https://phabricator.wikimedia.org/T153948) (owner: 10MarkAHershberger) [18:07:59] (03CR) 10Legoktm: [C: 04-1] "See inline comments. And please add a comment like was done in https://gerrit.wikimedia.org/r/#/c/328446/1/includes/skins/SkinTemplate.php" (039 comments) [core] - 10https://gerrit.wikimedia.org/r/328651 (https://phabricator.wikimedia.org/T153505) (owner: 10Subins2000) [18:08:52] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2896571 (10bmansurov) Hmm, that's weird. It works for me. [18:09:11] (03CR) 10Legoktm: [C: 032] "No worries, thanks for the patch!" [core] - 10https://gerrit.wikimedia.org/r/328524 (owner: 10Aleksey Bekh-Ivanov (WMDE)) [18:09:30] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2896573 (10TJones) >>! In T132637#2894519, @Wikitiki89 wrote: > I can speak for Russian, that folding и/й would not really be that annoying. I think that in... [18:09:56] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: MediaWikiChat kicking doesn't remove the offending person from the sidebar - https://phabricator.wikimedia.org/T145309#2896575 (10UltrasonicNXT) a:03UltrasonicNXT [18:10:16] Hi everyone. I am Shivam Luthra , a computer science undergraduate. i wanted to start up contributing to Wikimedia foundation. Can anyone guide me how to start from scratch ? [18:10:16] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.3), 03UI-Standardization-Kanban: Improve form layouts in OOUI MW core forms for better user experience - https://phabricator.wikimedia.org/T136790#2896576 (10Volker_E) @matmarex Tried to catch the OOjs UI side in https://www.mediawiki.org/wiki/OOjs_UI/Layouts/Fie... [18:10:36] legoktm: FlorianSW reviewed to not do &$user-> and you're saying to do that. I'm confused. Isn't doing $this-> better ? [18:10:54] subins2000: let me see what he wrote [18:11:30] subins2000: ok, so the bug report is only about plain $this [18:11:43] things like &$this->mBlahBlah should stay exactly the same [18:11:55] My comment is that the & was removed from those types of uses [18:11:59] and the & needs to be there [18:12:00] (03PS5) 10Mholloway: API: Surface dimensions when requesting original image info [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325044 (https://phabricator.wikimedia.org/T152163) [18:12:29] (03PS11) 10C. Scott Ananian: Protect -{...}- variant constructs in definition lists. [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) [18:12:31] (03PS4) 10C. Scott Ananian: Preserve null bytes in LanguageConverter conversions. [core] - 10https://gerrit.wikimedia.org/r/327779 [18:12:33] (03PS26) 10C. Scott Ananian: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [18:12:36] (03PS1) 10C. Scott Ananian: Don't bail on single-line definition list due to excess close tags. [core] - 10https://gerrit.wikimedia.org/r/328697 [18:12:45] legoktm: Okay, also, should the inline comment // Avoid PHP 7.1 warning of passing $this by reference nece be put everywhere ? [18:12:47] 10MediaWiki-extensions-FlaggedRevs: Edits made by whitelist members listed as pending changes - https://phabricator.wikimedia.org/T78407#2896582 (10Cenarium) 05Open>03Invalid The change was [[https://tr.wikipedia.org/w/index.php?title=%C3%96zel:G%C3%BCnl%C3%BCk&page=K%C4%B1zlar+Erkeklerden+Ne+%C4%B0ster%3F&h... [18:12:49] or just once [18:13:04] everywhere you do a $user = $this; please [18:13:13] (03CR) 10jerkins-bot: [V: 04-1] API: Surface dimensions when requesting original image info [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325044 (https://phabricator.wikimedia.org/T152163) (owner: 10Mholloway) [18:14:01] legoktm: Okay :) [18:14:07] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: Add "copy to clipboard" button to share/embed fields - https://phabricator.wikimedia.org/T77295#2896584 (10Sn1per) What it looks like now: {F5134601} [18:15:10] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2896585 (10greg... [18:15:44] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2896615 (10greg... [18:16:38] (03CR) 10Legoktm: "The two solutions aren't mutually exclusive right? We could do the update.php one to unblock the installer changes, and then implement the" [core] - 10https://gerrit.wikimedia.org/r/272419 (https://phabricator.wikimedia.org/T146341) (owner: 10Brian Wolff) [18:17:24] (03CR) 10Catrope: [C: 032] Split simple and js-based styles [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 (owner: 10Ladsgroup) [18:17:33] legoktm: Can you take a look at: https://gerrit.wikimedia.org/r/#/c/328679/ [18:17:36] ? [18:17:47] (03CR) 10Catrope: [C: 031] "Sorry, meant to +1 per Thiemo" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/328576 (owner: 10Ladsgroup) [18:18:29] 10Reading-Web-Trending-Service: Recovery: Trending service should be able to replay last 1hr of edits - https://phabricator.wikimedia.org/T145571#2896622 (10phuedx) [18:18:38] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Please review latest version of Definition of Embedded [Max] - https://phabricator.wikimedia.org/T153694#2896625 (10MBinder_WMF) One comment on "pithy naming" remains, but I'm OK to ship it [18:18:46] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Please review latest version of Definition of Embedded [Max] - https://phabricator.wikimedia.org/T153694#2896627 (10MBinder_WMF) a:05MBinder_WMF>03None [18:18:53] yes, that was next on my list :) [18:18:54] (03PS1) 10Gehel: adding findbugs to the build [search/highlighter] - 10https://gerrit.wikimedia.org/r/328699 [18:19:08] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2896629 (10AndyRussG) Here's the rough data for the above... See the second sheet and the ugly chart there... {F5134641} [18:20:16] (03Merged) 10jenkins-bot: Fix tests that don't check composer's autoloader [core] - 10https://gerrit.wikimedia.org/r/328524 (owner: 10Aleksey Bekh-Ivanov (WMDE)) [18:21:57] (03CR) 10jerkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [18:22:28] (03PS6) 10Mholloway: API: Surface dimensions when requesting original image info [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325044 (https://phabricator.wikimedia.org/T152163) [18:23:04] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2896661 (10greg) [18:23:20] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 13Patch-For-Review, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2896665 (10Krena... [18:23:30] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 15User-Urbanecm: Special:GlobalUserRights shows an error at meta.wikimedia.org - https://phabricator.wikimedia.org/T153961#2896631 (10Krenair) [18:25:01] (03CR) 10C. Scott Ananian: "@tstarling: ok, test cases added and I verified they triggered all but one of your code coverage paths. The remaining one isn't actually " [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) (owner: 10C. Scott Ananian) [18:26:06] 06Front-end-Standards-Group, 10MobileFrontend, 06Reading-Web-Backlog, 07Documentation, and 2 others: Compare the features offered by jsduck and jsdoc - https://phabricator.wikimedia.org/T153890#2894261 (10phuedx) [18:27:32] (03CR) 10C. Scott Ananian: "Failures are because wikibase makes bad assumptions about English, apparently. I'll try to fix that in wikibase." [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [18:28:25] 10UI-Standardization, 10OOjs-UI, 10Vector, 07Accessibility, and 2 others: styles in Vector conflict with OOUI - https://phabricator.wikimedia.org/T149587#2896696 (10Volker_E) [18:28:39] 10MediaWiki-File-management, 10CirrusSearch, 06Commons, 06Discovery, and 2 others: Ogg Opus-File should be classified as audio not multimedia-Files. - https://phabricator.wikimedia.org/T151352#2896698 (10thiemowmde) @MarkTraceur, almost all files in https://commons.wikimedia.org/wiki/Special:Search/filetyp... [18:30:28] (03CR) 10Legoktm: [C: 04-1] "See inline comments" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [18:30:31] (03PS3) 10Subins2000: Remove &$this usage [core] - 10https://gerrit.wikimedia.org/r/328651 (https://phabricator.wikimedia.org/T153505) [18:32:12] legoktm: Can i use "@var $metadata['FileNames'] Array" [18:32:12] ? [18:33:11] no [18:33:16] (03PS2) 10Alex Monk: Adding $writing param to match param signature of parent function [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328606 (https://phabricator.wikimedia.org/T152247) (owner: 10Kaldari) [18:33:18] You can put it in a separate variable though [18:33:49] (03PS2) 10Blackspirit96: API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) [18:33:51] (03PS1) 10Blackspirit96: Add check that prevents someone from combining the userprefix, userids, user parameters [core] - 10https://gerrit.wikimedia.org/r/328703 [18:33:53] (03PS1) 10Blackspirit96: Remove redundant code The param field will always be either an array or null when the param field is null the guard at line 72 kills the execution of the request and returns a missing parameter error [core] - 10https://gerrit.wikimedia.org/r/328704 [18:33:56] (03PS1) 10Blackspirit96: Fix styling [core] - 10https://gerrit.wikimedia.org/r/328705 [18:33:59] (03PS1) 10Blackspirit96: Negative uids are invalid user ids too [core] - 10https://gerrit.wikimedia.org/r/328706 [18:34:02] (03PS1) 10Blackspirit96: The values should never be null because the guard at line 72 will kill the request before the execution will reach those points [core] - 10https://gerrit.wikimedia.org/r/328707 [18:34:05] (03PS1) 10Blackspirit96: Syntax fix in response message and removed comment that makes no sense [core] - 10https://gerrit.wikimedia.org/r/328708 [18:34:08] (03PS1) 10Blackspirit96: Add i18n messages support [core] - 10https://gerrit.wikimedia.org/r/328709 [18:34:10] legoktm: Btw, its it "Array" or "array"? [18:34:15] rlot_: loewrcase array [18:34:21] thanks [18:34:32] legoktm: And is there string[]? [18:34:49] yeah, that's okay too [18:34:53] in fact, preferred [18:35:31] 10TPG-FY2016-17-Q2-Embedded-Support, 10TPG-Epics (Administer and process Team Practices Customer Satisfaction survey for FY 2016-17 Q2 (Oct-Dec 2016)), 06Team-Practices (This-Week): Share Q2 CSAT results with TPG - https://phabricator.wikimedia.org/T153873#2896713 (10JAufrecht) 05Open>03Resolved [18:35:50] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Definition of "embedded" - https://phabricator.wikimedia.org/T151232#2896718 (10ksmith) [18:35:52] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Please review latest version of Definition of Embedded [Arthur] - https://phabricator.wikimedia.org/T153695#2896717 (10ksmith) 05Open>03Resolved [18:37:33] 10MediaWiki-API, 13Patch-For-Review: API should allow querying user contribs by userid - https://phabricator.wikimedia.org/T114465#2896724 (10Blackspirit96) I made a patch for code review, but I believe I messed up with the commit messages, sorry! [18:37:36] 10TPG-Essential-Functions, 10TPG-FY2016-17-Q2-Embedded-Support, 10TPG-Epics (Administer and process Team Practices Customer Satisfaction survey for FY 2016-17 Q2 (Oct-Dec 2016)), 06Team-Practices (This-Week): Update CSAT wiki to include instructions for fut... - https://phabricator.wikimedia.org/T152112#2896725 [18:37:38] 10TPG-Essential-Functions, 10TPG-Epics (Determine Phate of Phlogiston), 06Team-Practices (This-Week): Review and synthesize Phate of Phlogiston data - https://phabricator.wikimedia.org/T151267#2812697 (10JAufrecht) a:05Awjrichards>03KLans_WMF If Done includes sharing with TPG, then this is waiting for KL... [18:37:49] (03CR) 10Alex Monk: [C: 032] Adding $writing param to match param signature of parent function [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328606 (https://phabricator.wikimedia.org/T152247) (owner: 10Kaldari) [18:37:53] 10TPG-FY2016-17-Q2-Design-Collaboration, 10TPG-Epics (Design Statement of Purpose (Phase 2 & 3)), 06Team-Practices (This-Week): Publish 'statement of purpose of design at the WMF' publicly - https://phabricator.wikimedia.org/T139999#2896729 (10ksmith) 05Open>03Resolved We wanted to give @Awjrichards the... [18:38:20] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Please review latest version of Definition of Embedded [Kevin] - https://phabricator.wikimedia.org/T153697#2896735 (10ksmith) 05Open>03Resolved [18:38:22] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Definition of "embedded" - https://phabricator.wikimedia.org/T151232#2896736 (10ksmith) [18:38:24] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Definition of "embedded" - https://phabricator.wikimedia.org/T151232#2896738 (10MBinder_WMF) [18:38:26] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Please review latest version of Definition of Embedded [Max] - https://phabricator.wikimedia.org/T153694#2896737 (10MBinder_WMF) 05Open>03Resolved [18:40:17] (03CR) 10Parent5446: Fixed PHP issues found by phan (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [18:40:22] (03PS1) 10Blackspirit96: Update date [core] - 10https://gerrit.wikimedia.org/r/328710 (https://phabricator.wikimedia.org/T114465) [18:40:29] (03CR) 10Legoktm: [C: 032] When authorizing, differentiate mwoauth-authonlyprivate from mwoauth-authonly or basic [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/328680 (owner: 10Anomie) [18:40:32] 10MediaWiki-extensions-CLDR, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 15User-Daniel: Include "special" languages in language selector for monolingual text - https://phabricator.wikimedia.org/T153850#2896749 (10Lydia_Pintscher) [18:40:37] (03Merged) 10jenkins-bot: Adding $writing param to match param signature of parent function [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328606 (https://phabricator.wikimedia.org/T152247) (owner: 10Kaldari) [18:40:48] (03CR) 10Chad: "Yeah we've been logging that warning for ever and nobody gives a shit. Maybe now that it's an exception they will." [core] - 10https://gerrit.wikimedia.org/r/325623 (owner: 10Chad) [18:41:44] (03Merged) 10jenkins-bot: When authorizing, differentiate mwoauth-authonlyprivate from mwoauth-authonly or basic [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/328680 (owner: 10Anomie) [18:42:18] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328703 (owner: 10Blackspirit96) [18:42:18] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328704 (owner: 10Blackspirit96) [18:42:22] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328705 (owner: 10Blackspirit96) [18:42:25] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328706 (owner: 10Blackspirit96) [18:42:28] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328707 (owner: 10Blackspirit96) [18:42:31] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328708 (owner: 10Blackspirit96) [18:42:34] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328709 (owner: 10Blackspirit96) [18:42:37] (03CR) 10Legoktm: [C: 04-1] Fixed PHP issues found by phan (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [18:42:50] (03PS4) 10BearND: Add revision support to mobile content service [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [18:44:10] (03CR) 10Anomie: [C: 04-1] "All the issues from PS1 remain. The rebase introduced some additional issues." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [18:44:51] (03PS3) 10Sn1per: Add button to copy share/embed text to clipboard [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/328696 (https://phabricator.wikimedia.org/T77295) [18:45:06] 10Wikispeech: Improve utterance storage - https://phabricator.wikimedia.org/T153841#2896761 (10Lokal_Profil) True. The actionApi was not part of our original plan but it would make a lot of sense to expose e.g.utterances to anyone who wants to use it for other purposes. There is some relatively simple example c... [18:45:19] (03CR) 10Anomie: [C: 04-2] "This is not how you amend a patch set. Abandon this, go back to Id4f4fb76, and do it correctly." [core] - 10https://gerrit.wikimedia.org/r/328710 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [18:47:34] 10Phabricator, 10Wikidata: Create a WikibaseLexeme tag - https://phabricator.wikimedia.org/T153963#2896776 (10Amire80) [18:49:22] 10TPG-Essential-Functions, 10Wikimedia-Developer-Summit, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Compose a checklist of what to bring to set up physical Coaching Clinic space at the Dev Summit - https://phabricator.wikimedia.org/T153714#2896810 (10ggellerman) [18:49:24] 10TPG-Essential-Functions, 10Wikimedia-Developer-Summit, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Set up physical Coaching Clinic space at the Dev Summit - https://phabricator.wikimedia.org/T151253#2896808 (10ksmith) [18:52:24] 06Wikipedia-Android-App-Backlog: Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896821 (10Kaartic) I have created a paste that contains the logcat output that was logged when I see that overlapping. It's P4673 A exception that I foun... [18:52:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Show text from Wikidata usage instructions property (P2559) when auto-suggesting properties or items - https://phabricator.wikimedia.org/T140131#2896822 (10Lydia_Pintscher) p:05High>03Normal [18:54:04] 06Wikipedia-Android-App-Backlog: Weird screen shown when clicking the "Show tabs" icon when the device is offline - https://phabricator.wikimedia.org/T153946#2896825 (10Kaartic) [18:54:06] (03CR) 10Mainframe98: [C: 031] "I tested this with a brand new virtual machine, and while it took much, much longer than usual (1702.74 seconds), it does work." [vagrant] - 10https://gerrit.wikimedia.org/r/328691 (https://phabricator.wikimedia.org/T152801) (owner: 10BryanDavis) [18:54:36] legoktm: correct? if ( inset( $metadata['translations'] ) && is_array( $metadata['translations'] ) ) { [18:56:12] rlot_: typo in isset() but otherwise yeah [18:56:42] (03Abandoned) 10Blackspirit96: Update date [core] - 10https://gerrit.wikimedia.org/r/328710 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [18:57:44] (03PS1) 10EBernhardson: Provide id-filtering to runSearch.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 [19:01:27] (03PS2) 10BryanDavis: Install latest git client from PPA; upgrade git-review [vagrant] - 10https://gerrit.wikimedia.org/r/328691 (https://phabricator.wikimedia.org/T152801) [19:01:34] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#1642839 (10Phantom42) Do I understand correctly, that the task can be completed just by addin... [19:04:10] (03PS8) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [19:04:19] legoktm: Ok, heres the patch [19:05:15] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#1642839 (10Legoktm) Instead of hiding it why not fix it to display nicely...? Maybe even coll... [19:05:35] (03CR) 10jerkins-bot: [V: 04-1] Provide id-filtering to runSearch.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [19:08:25] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#2896844 (10Phantom42) The task says: > .mw-changeslist-legend should be hidden in this skin... [19:12:52] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [19:14:10] (03CR) 10MaxSem: [C: 032] geoFeatures: Remove dead code and minor optimisations [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/328454 (owner: 10Krinkle) [19:14:12] (03PS3) 10Blackspirit96: API should allow querying user contribs by userid [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) [19:14:36] Krinkle, thanks for ^ [19:14:54] MaxSem: yw :) [19:14:57] (03Abandoned) 10Blackspirit96: Add i18n messages support [core] - 10https://gerrit.wikimedia.org/r/328709 (owner: 10Blackspirit96) [19:15:06] (03CR) 10Anomie: "I note that this patch causes these tests no longer actually test that the class can be auto-loaded at all, just that the class happens to" [core] - 10https://gerrit.wikimedia.org/r/328524 (owner: 10Aleksey Bekh-Ivanov (WMDE)) [19:15:28] (03Merged) 10jenkins-bot: geoFeatures: Remove dead code and minor optimisations [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/328454 (owner: 10Krinkle) [19:16:01] (03PS5) 10Anomie: Update account creation form validation [core] - 10https://gerrit.wikimedia.org/r/324969 [19:16:04] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: EPIC: Plan to enable BM25 on fulltext search - https://phabricator.wikimedia.org/T139575#2896866 (10Deskana) [19:16:11] 10MediaWiki-Search, 06Discovery, 06Discovery-Search (Current work), 07I18n, and 2 others: Enable ICU folding on Hebrew wikis - https://phabricator.wikimedia.org/T3836#2896864 (10Deskana) 05Open>03Resolved @Wikitiki89 I'm glad it's an improvement, at least. Since we enabled ICU folding, which was the sc... [19:16:25] (03PS5) 10Anomie: Add password validation to Special:ChangeCredentials [core] - 10https://gerrit.wikimedia.org/r/324970 [19:16:33] (03Abandoned) 10Blackspirit96: Syntax fix in response message and removed comment that makes no sense [core] - 10https://gerrit.wikimedia.org/r/328708 (owner: 10Blackspirit96) [19:16:48] (03Abandoned) 10Blackspirit96: The values should never be null because the guard at line 72 will kill the request before the execution will reach those points [core] - 10https://gerrit.wikimedia.org/r/328707 (owner: 10Blackspirit96) [19:16:56] (03Abandoned) 10Blackspirit96: Negative uids are invalid user ids too [core] - 10https://gerrit.wikimedia.org/r/328706 (owner: 10Blackspirit96) [19:16:58] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/boost_template_api.feature:3:7:11:15:19:23 features/combined_filters_api.f" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [19:17:00] (03Abandoned) 10Blackspirit96: Fix styling [core] - 10https://gerrit.wikimedia.org/r/328705 (owner: 10Blackspirit96) [19:17:03] (03Abandoned) 10Blackspirit96: Remove redundant code The param field will always be either an array or null when the param field is null the guard at line 72 kills the execution of the request and returns a missing parameter error [core] - 10https://gerrit.wikimedia.org/r/328704 (owner: 10Blackspirit96) [19:17:08] (03Abandoned) 10Blackspirit96: Add check that prevents someone from combining the userprefix, userids, user parameters [core] - 10https://gerrit.wikimedia.org/r/328703 (owner: 10Blackspirit96) [19:17:50] 10MediaWiki-API, 13Patch-For-Review: API should allow querying user contribs by userid - https://phabricator.wikimedia.org/T114465#2896873 (10Blackspirit96) I applied the patch correctly https://gerrit.wikimedia.org/r/#/c/324338/ :D [19:18:19] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran phan static analysis and there were some errors: /srv/mediawiki-vagrant/mediawiki/extensions/CirrusSearch/includes/Elastica/LtrQuery" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [19:20:15] 10Wiki-Loves-Monuments, 13Patch-For-Review: Set-up Sentry for Heritage API - https://phabricator.wikimedia.org/T137882#2896886 (10Lokal_Profil) Thanks for setting this up @JeanFred and @Tgr for reviewing. Would it be possible to add a line to the readme about it for those of us who are unfamiliar to sentry/ra... [19:22:30] legoktm: Can you look at jenkins in my task? [19:22:56] oh, got it [19:22:57] typo [19:25:07] (03PS9) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [19:25:10] (03CR) 10Jackmcbarn: "Where are these messages used in code?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/328590 (owner: 10Base) [19:25:19] legoktm: Ok, can you check it? [19:26:13] (03CR) 10BearND: [C: 032] Add revision support to mobile content service [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [19:28:23] (03CR) 10Anomie: [C: 04-1] API should allow querying user contribs by userid (033 comments) [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [19:28:28] (03Merged) 10jenkins-bot: Add revision support to mobile content service [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [19:30:36] (03CR) 10Aklapper: "Blackspirit96: Please also check out https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews#Test_your_changes - thanks!" [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [19:32:52] legoktm: Jenkins verified +2 [19:39:16] Reedy: Can you take a look at gerrit [19:39:29] (03PS1) 10Edward Chernenko: Don't create the test DB if the test doesn't need it. [core] - 10https://gerrit.wikimedia.org/r/328718 [19:42:03] (03Draft2) 10Yaron Koren: Added "text color" parameter for "calendar" format [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/328717 [19:42:16] (03CR) 10BearND: [C: 04-1] "Would you add more reasons on what was wrong with the old code? On IRC you mentioned that this caused the header to be hidden behind a 'wi" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328414 (owner: 10Mholloway) [19:43:10] (03PS2) 10Edward Chernenko: Don't create the test DB if the test doesn't need it. [core] - 10https://gerrit.wikimedia.org/r/328718 [19:43:22] (03CR) 10jerkins-bot: [V: 04-1] Added "text color" parameter for "calendar" format [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/328717 (owner: 10Yaron Koren) [19:44:25] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Create config more intuitive aliases for filetype: search - https://phabricator.wikimedia.org/T150887#2896925 (10Deskana) 05Open>03Resolved The infrastructure was added, but I don't want to announce... [19:44:58] jerkins-bot? lol [19:45:45] how did that happen 0_o [19:47:23] legoktm? [19:47:42] 04(no projects): Clicking the "History" or "Nearby" icon shows "Unfortunately, WIkipedia Alpha has stopped" message in 2 - https://phabricator.wikimedia.org/T153968#2896930 (10Kaartic) [19:49:01] https://github.com/wikimedia/labs-tools-wikibugs2/blob/54181a0aadaf3ab6ec249e03c7ab654ddca4720b/grrrrit.py#L110 ohh [19:50:17] (03CR) 10Ejegg: "Running drush dpm from the command line, I see it hang after between 500 and 1000 messages are imported. If I break the 4000-line Donation" [vagrant] - 10https://gerrit.wikimedia.org/r/328228 (https://phabricator.wikimedia.org/T153802) (owner: 10Ejegg) [19:51:13] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Desired activity toolbar is obscured behind a Wikipedia toolbar - https://phabricator.wikimedia.org/T153969#2896948 (10Mholloway) [19:51:41] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Desired activity toolbar is obscured behind a Wikipedia toolbar - https://phabricator.wikimedia.org/T153969#2896962 (10Mholloway) [19:52:52] I was about to add a note in quips, but it's down, what happened? :( https://tools.wmflabs.org/bash/ [19:53:14] (03CR) 10Brian Wolff: "Meh, further testing of the subquery idea seems to indicate it doesn't work. So back to this. Given Anomie's comment about int in rev_page" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [19:53:20] (03PS2) 10Mholloway: Fix DescriptionEditActivity layout [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328414 (https://phabricator.wikimedia.org/T153969) [19:53:38] bd808: what happened to https://tools.wmflabs.org/bash/ ? [19:54:31] 06Wikipedia-Android-App-Backlog: Clicking the "History" or "Nearby" icon shows "Unfortunately, WIkipedia Alpha has stopped" message in 2.4.184-alpha-2016-12-23 - https://phabricator.wikimedia.org/T153968#2896966 (10Kaartic) [19:54:43] (03CR) 10Mholloway: "Added a phab task (see the updated commit msg) with screenshots." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328414 (https://phabricator.wikimedia.org/T153969) (owner: 10Mholloway) [19:56:20] 06Wikipedia-Android-App-Backlog: Clicking the "History" or "Nearby" icon shows "Unfortunately, WIkipedia Alpha has stopped" message in 2.4.184-alpha-2016-12-23 - https://phabricator.wikimedia.org/T153968#2896930 (10Kaartic) [19:56:54] Vulpix: dunno. looking into it now [19:57:07] thanks, no hurry! [19:58:47] (03PS3) 10Yaron Koren: Added "text color" parameter for "calendar" format [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/328717 [19:59:49] 10MediaWiki-extensions-ContributionTracking, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Spike: ContributionTracking sometimes fails to insert rows - https://phabricator.wikimedia.org/T153730#2888867 (10Ejegg) > If the previous statement retu... [20:00:24] (03CR) 10Yaron Koren: [C: 032] Added "text color" parameter for "calendar" format [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/328717 (owner: 10Yaron Koren) [20:00:58] 06Wikipedia-Android-App-Backlog: Clicking the "History" or "Nearby" icon shows "Unfortunately, WIkipedia Alpha has stopped" message in 2.4.184-alpha-2016-12-23 - https://phabricator.wikimedia.org/T153968#2896976 (10Mholloway) I have run into similar crashes recently when running an emulator with Jelly Bean. T... [20:03:35] (03CR) 10Yaron Koren: "@IvanFon and @Reedy - this patch should not have been checked in, because (as I just discovered) requireExtension() was only added in MW 1" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [20:08:30] https://tools.wmflabs.org/bash/quip/AVKLGrDHVcowl-ZznG9o is alive again [20:13:03] (03PS2) 10Brian Wolff: Attempt to optimize api prop=contributors [core] - 10https://gerrit.wikimedia.org/r/328623 [20:13:23] 10MediaWiki-extensions-ContributionTracking, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Spike: ContributionTracking sometimes fails to insert rows - https://phabricator.wikimedia.org/T153730#2896996 (10Ejegg) Huh, turns out DonationInterface... [20:15:54] (03CR) 10Reedy: "Generally, it's accepted that extensions branches should be used with the relevant MW core branch..." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [20:17:38] Reedy: Are you here? [20:17:54] (03Draft2) 10Yaron Koren: Fix for 097df1167cec [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/328720 [20:18:56] 10MediaWiki-API, 07Documentation: Auto-generated API documentation should mention equivalent UI page - https://phabricator.wikimedia.org/T37234#2896997 (10Reedy) >>! In T37234#2896324, @Aklapper wrote: > For this specific example, what is the expectation? Do have a line "This resembles Special:WhatLinksHere."... [20:18:58] (03CR) 10jerkins-bot: [V: 04-1] Attempt to optimize api prop=contributors [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [20:19:32] (03CR) 10BryanDavis: [C: 032] Install latest git client from PPA; upgrade git-review [vagrant] - 10https://gerrit.wikimedia.org/r/328691 (https://phabricator.wikimedia.org/T152801) (owner: 10BryanDavis) [20:19:44] (03Merged) 10jenkins-bot: Install latest git client from PPA; upgrade git-review [vagrant] - 10https://gerrit.wikimedia.org/r/328691 (https://phabricator.wikimedia.org/T152801) (owner: 10BryanDavis) [20:20:11] (03CR) 10Brian Wolff: "New query is now same as the old, except using real ints for rev_page:" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [20:21:04] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature-flag media viewer swipe functionality - https://phabricator.wikimedia.org/T153971#2897001 (10bmansurov) [20:25:36] (03PS1) 10Bmansurov: Hygiene: rename a variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328721 (https://phabricator.wikimedia.org/T147944) [20:25:43] (03CR) 10Edward Chernenko: "Note: even if we decide that "test db" is needed by default," [core] - 10https://gerrit.wikimedia.org/r/328718 (owner: 10Edward Chernenko) [20:26:04] (03CR) 10Brian Wolff: "As an additional aside, when I ran SELECT rev_page AS `page`,rev_user AS `user`,MAX(rev_user_text) AS `username` FROM `revision_userindex`" [core] - 10https://gerrit.wikimedia.org/r/328623 (owner: 10Brian Wolff) [20:26:34] (03PS2) 10BryanDavis: Clone only the master branch of mediawiki/core.git by default [vagrant] - 10https://gerrit.wikimedia.org/r/328335 (https://phabricator.wikimedia.org/T152801) [20:27:41] (03PS3) 10Brian Wolff: Attempt to optimize api prop=contributors [core] - 10https://gerrit.wikimedia.org/r/328623 [20:28:08] 10MediaWiki-ResourceLoader: "Unknown dependency" error should not stop mw.loader.load from loading other modules - https://phabricator.wikimedia.org/T36853#2897021 (10Peter) a:03Peter [20:29:29] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2897022 (10Ejegg) [20:29:54] (03CR) 10Brian Wolff: "Yeah, we definitely could" [core] - 10https://gerrit.wikimedia.org/r/272419 (https://phabricator.wikimedia.org/T146341) (owner: 10Brian Wolff) [20:30:28] 10MediaWiki-ResourceLoader: Add support for URLs to mw.loader.using - https://phabricator.wikimedia.org/T27962#2897036 (10Peter) a:03Peter [20:32:12] (03CR) 10Filip: [C: 031] "Looks good, great job!" [core] - 10https://gerrit.wikimedia.org/r/328651 (https://phabricator.wikimedia.org/T153505) (owner: 10Subins2000) [20:32:44] (03CR) 10Yaron Koren: [C: 032] Fix for 097df1167cec [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/328720 (owner: 10Yaron Koren) [20:32:55] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2897040 (10Ejegg) a:03cwdent Should be fine to do the spinner in a different patch - seems like i... [20:33:08] (03PS1) 10Catrope: When authorizing, differentiate mwoauth-authonlyprivate from mwoauth-authonly or basic [extensions/OAuth] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/328722 [20:33:17] (03CR) 10Catrope: [C: 032] When authorizing, differentiate mwoauth-authonlyprivate from mwoauth-authonly or basic [extensions/OAuth] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/328722 (owner: 10Catrope) [20:33:25] (03CR) 10Yaron Koren: "The system of MediaWiki version branches doesn't work for me - and I can't imagine that it works for any non-Wikimedia extension developer" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [20:34:51] (03Merged) 10jenkins-bot: When authorizing, differentiate mwoauth-authonlyprivate from mwoauth-authonly or basic [extensions/OAuth] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/328722 (owner: 10Catrope) [20:35:39] Reedy, so it's fine to do $content = (some string)? [20:35:55] Where? [20:36:15] or do makeContent()? [20:36:23] In transliterator [20:37:36] 10SiteMetrics, 10Social-Tools, 07Easy, 07I18n: Lowercase i18n strings for consistency with other extensions in SiteMetrics - https://phabricator.wikimedia.org/T153551#2897045 (10SamanthaNguyen) a:03SamanthaNguyen Will write a patch for this today :) [20:38:21] I guess use makeContent there. [20:38:39] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897049 (10bmansurov) [20:39:26] Georggi: makeContent makes sense if you want to turn a string into a Content object [20:40:18] Yeah, just seems a bit weird firstly converting Content object into a string, adding one part to it and converting it back to Content [20:40:49] 10MediaWiki-General-or-Unknown, 13Patch-For-Review, 05Security: thumbnail script should respect imgAuthBeforeStream - https://phabricator.wikimedia.org/T153948#2897068 (10Bawolff) [20:40:49] It does.. [20:40:59] But I don't see any sort of "append" on a textcontent [20:42:04] 10MediaWiki-ResourceLoader: Add support for URLs to mw.loader.using - https://phabricator.wikimedia.org/T27962#2897069 (10Peter) a:05Peter>03None [20:42:57] 10MediaWiki-extensions-FlaggedRevs: Reviewing a new page in FlaggedRevs shouldn't patrol it - https://phabricator.wikimedia.org/T153974#2897072 (10Catrope) [20:43:46] 10MediaWiki-extensions-Page_Forms: "missing argument" error in page form extension when creating class - https://phabricator.wikimedia.org/T153914#2897084 (10Yaron_Koren) 05Open>03Invalid I changed the status to "Invalid" - feel free to change it back if you think it's a Page Forms issue. [20:43:46] (03PS2) 10Georggi199: Removed deprecated hook usage [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) [20:45:10] 10MediaWiki-extensions-ContentTranslation, 13Patch-For-Review: Add Spanish alias to ContentTranslation - https://phabricator.wikimedia.org/T153954#2897087 (10MarcoAurelio) 05Open>03Resolved [20:45:19] (03PS1) 10Bmansurov: Remove unneeded padding from Special:Mobiledif [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328723 (https://phabricator.wikimedia.org/T147944) [20:45:49] (03PS2) 10Georggi199: Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) [20:46:43] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [20:49:46] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Make toggling code not depend on the beta context - https://phabricator.wikimedia.org/T153975#2897093 (10bmansurov) [20:50:33] Reedy, in premoderation extension, hook is assigned in the same file(renamed it if you look) [20:51:11] Georggi: Theres no hook assign in this file [20:51:19] 10MediaWiki-ResourceLoader, 06Performance-Team: Collect mw.loader.store statistics - https://phabricator.wikimedia.org/T120893#2897108 (10Peter) a:05Krinkle>03Peter [20:51:31] Uh? $wgHooks['PageContentSave'][] = 'Premoderation::processEditRequest'; [20:51:52] Which line? [20:51:55] line 9 [20:52:49] Georggi: Whoops, you're right! Btw, its really wierd way to do this [20:52:53] (03PS2) 10Georggi199: Replaced deprecated hook usage [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) [20:53:15] 06Community-Liaisons (Jan-Mar 2017), 06Developer-Relations (Jan-Mar-2017): Technical Collaboration quarterly check in for January – March 2017 - https://phabricator.wikimedia.org/T150658#2897124 (10Whatamidoing-WMF) [20:53:26] Well, using throw new... to send a message is also weird. [20:53:41] Reedy, jenkins doesn't seem to like that throw statement. [20:53:53] Indeed [20:53:55] It's very very weird [20:54:19] Was it made before jenkins? (How could it get into the code then) [20:54:21] :) [20:54:37] 07Design, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2897129 (10Etonkovidova) Thx @Pginer-WMF . I filed {T153976} [20:55:48] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Resultswitchers: process return before busting out of frames - https://phabricator.wikimedia.org/T153972#2897022 (10ggellerman) p:05Triage>03High [20:56:15] 04(no projects): Cleanup WebPageTest drilldown dashboard - https://phabricator.wikimedia.org/T153977#2897134 (10Peter) [20:56:48] (03CR) 10Base: "https://test.wikidata.org/wiki/Special:Random/Module?uselang=qqx the tab and hover the mouse over it to see another one. They are not used" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/328590 (owner: 10Base) [20:57:39] Georggi: You can always force code through [20:57:42] And ignore jenkins [20:57:43] (03CR) 10Filip: [C: 04-1] Removed deprecated hook usage (031 comment) [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [20:58:04] ignore jerkins, continue writing good code [20:58:05] Georggi: Don't use mTitle, theres function for it [20:59:27] Georggi: Just use ->getTitle, look at my comment [21:00:47] (03CR) 10Filip: [C: 031] "Looks good" [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:01:31] I mean, it doesn't really matter whether it's getting a variable or getting a variable through another function... [21:01:50] It's better practice [21:01:56] Georggi: When theres lots of calls to "mContent", "mTitle" [21:02:00] Generally, direct member variable access should be avoided [21:02:01] etc, code is so chaotic [21:02:11] function are made specially for this. [21:03:08] I would guess that throw new should be a wfMessage or something like that? [21:03:35] Georggi: Which line? [21:03:39] 10MediaWiki-Page-editing, 10VisualEditor, 06Community-Liaisons (Jan-Mar 2017): CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#2897173 (10Whatamidoing-WMF) [21:03:44] 74 [21:03:54] Which jenkins doesn't like [21:04:28] 10MediaWiki-Parser, 10ArchCom-RfC, 07ArchCom-Has-shepherd: [RfC] Future of magic links - https://phabricator.wikimedia.org/T145604#2635698 (10SlimVirgin) Could someone say what the status of this is, please? There has been very little discussion about it on enwiki. Editors who don't use citation templates us... [21:04:42] Georggi: Its correct. When you want to make error page, you should use ErrorPageError [21:04:43] There is also problem, that somewhere there is wrong variable passed(has to be string, was array), not sure what is passed to database though [21:04:57] No it's wrong, jenkins complains about it lol. [21:05:39] At the very least, it is written wrong, there even was a return true; after it(which was unreachable) [21:06:11] Georggi: Jenkins is not a 100% check, but you're right - lots of these extensions are written really bad. [21:06:43] Georggi: Its not related to your change for it. Just don't worry about it [21:06:54] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897179 (10Nirzar) @bmansurov we have a different behavior on everyone else?? where do we show the spinner for regular users? [21:07:12] Using throw new to create success page is weird nontheless. [21:07:45] Reedy, do you want me to do anything to it, or just leave it be? [21:08:22] Georggi: Look at my comment [21:08:33] Georggi: I wouldn't bother fixing the exception throwing, no [21:08:49] Get back return true;? [21:09:22] Nah, that line is unreachable [21:09:29] Might aswell leave it removed [21:09:34] So, it's the throw that is executed [21:09:49] (03PS3) 10Georggi199: Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) [21:09:55] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328209 (owner: 10Anomie) [21:10:27] (03CR) 10Filip: [C: 031] "Great job!" [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:10:59] Reedy: Btw, can you look at my patch in free time? [21:11:06] (03CR) 10jerkins-bot: [V: 04-1] Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:11:32] Georggi: Is everything working on your local setup? [21:11:38] (03PS1) 10Sbisson: Use the right counter for the right badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328730 (https://phabricator.wikimedia.org/T142454) [21:12:16] I mean, as Reedy previously said, these are kinda hard to test. All I can see is code analysis by PHPStorm. [21:13:09] (03PS9) 10Smalyshev: Move geosearch features to GeoData extension. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/326039 (https://phabricator.wikimedia.org/T152730) [21:13:27] (03CR) 10Filip: [C: 031] "Looks good" [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:14:47] (03CR) 10Reedy: [V: 032 C: 032] Removed deprecated hook usage [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/328643 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:15:13] (03PS1) 10BryanDavis: phab: clone libphutil and arcanist from WMF repos [vagrant] - 10https://gerrit.wikimedia.org/r/328731 [21:15:27] (03CR) 10Reedy: [C: 032] Replaced deprecated hook usage [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:16:27] (03CR) 10Reedy: [C: 032] Removed deprecated hook usage [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:16:34] (03Merged) 10jenkins-bot: Replaced deprecated hook usage [extensions/PageInCat] - 10https://gerrit.wikimedia.org/r/328646 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:16:36] (03Merged) 10jenkins-bot: Removed deprecated hook usage [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/328647 (https://phabricator.wikimedia.org/T151973) (owner: 10Georggi199) [21:16:43] (03CR) 10BryanDavis: phab: clone libphutil and arcanist from WMF repos (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/328731 (owner: 10BryanDavis) [21:17:43] 06Community-Liaisons (Oct-Dec-2016), 07Documentation: Improve internal documentation on community consultations - https://phabricator.wikimedia.org/T153795#2897214 (10Whatamidoing-WMF) 05Open>03Resolved [21:19:14] (03PS10) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [21:19:28] (03PS2) 10EBernhardson: Provide id-filtering to runSearch.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 [21:19:35] (03CR) 10Filip: "Fixed it all, so why keep it in config.php" [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [21:19:58] Reedy: Seems like everything is working [21:20:58] rlot: We'll see if jenkins approves ;) [21:21:54] 06Developer-Relations (Oct-Dec-2016): Summarize the advice requested and provided by experts when drafting the Code of Conduct - https://phabricator.wikimedia.org/T141791#2897223 (10Qgil) 05Open>03Resolved [21:22:02] 06Community-Liaisons, 06Developer-Relations, 06Support-and-Safety, 05Goal: Goal: Binding code of conduct for all Wikimedia technical spaces with consequences for breaches - https://phabricator.wikimedia.org/T90908#2897225 (10Qgil) [21:22:09] 04(no projects): Category:Engineering disciplines, browser mobile view differs from Android view - https://phabricator.wikimedia.org/T153980#2897226 (10Lbertolotti) [21:22:34] (03CR) 10Pmiazga: [C: 04-1] "I'm afraid using User::newFromId() shouldn't be used in unit tests (there is lots of logic around managin users in MediaWikiTestCase and T" (034 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328500 (https://phabricator.wikimedia.org/T146889) (owner: 10Phuedx) [21:22:53] (03CR) 10Catrope: [C: 032] Use the right counter for the right badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328730 (https://phabricator.wikimedia.org/T142454) (owner: 10Sbisson) [21:24:06] 06Developer-Relations (Oct-Dec-2016): Summarize the advice requested and provided by experts when drafting the Code of Conduct - https://phabricator.wikimedia.org/T141791#2897238 (10Qgil) OK, I have added the summary in the task description. [21:24:19] rlot: phan has failed [21:24:47] Reedy: Eh, i'll look at zuul [21:25:04] https://integration.wikimedia.org/ci/job/mediawiki-core-php70-phan-jessie/725/console [21:25:31] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Consider using Phabricator Calendar events to schedule Wikimedia Developer Summit sessions - https://phabricator.wikimedia.org/T146749#2897241 (10Qgil) p:05Normal>03High [21:25:39] (03CR) 10Pmiazga: [C: 031] Make settings reducer control footer link [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/328674 (https://phabricator.wikimedia.org/T146889) (owner: 10Phuedx) [21:25:47] Reedy: Wierd, phan passes on my local setup [21:25:57] Different versions? :) [21:26:03] 04(no projects): Category:Engineering disciplines, browser mobile view differs from Android view - https://phabricator.wikimedia.org/T153980#2897243 (10Lbertolotti) [21:26:11] Reedy: Can you take a look at code? [21:26:28] Reedy: Maybe i should just suppress it [21:26:36] I think we said that before :) [21:26:40] You've fixed enough anyway [21:26:51] And possibly some this version of phan doesn't spot [21:27:01] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [21:27:33] Reedy: Its possible, i have new version from git, and it passes [21:27:43] Reedy: But keep these @var ? [21:27:55] I'd leave the changes you made, yeah [21:28:23] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2707386 (10Qgil) [21:28:58] 04(no projects): Category:Engineering disciplines, browser mobile view differs from Android view - https://phabricator.wikimedia.org/T153980#2897248 (10bearND) [21:29:13] rlot: 21:20:38 + composer require etsy/phan:0.7 --prefer-dist --dev --no-progress --ansi --profile -v [21:29:38] the release is upto 1.0.1 [21:29:54] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2897251 (10Wikitiki89) >>! In T132637#2896573, @TJones wrote: >>>! In T132637#2894519, @Wikitiki89 wrote: >> I can speak for Russian, that folding и/й would n... [21:30:10] Oh, missed it [21:30:13] um [21:30:15] ignore that [21:30:30] https://packagist.org/packages/etsy/phan [21:30:32] It's upto date [21:30:48] Must be some other issues [21:31:13] (03Merged) 10jenkins-bot: Use the right counter for the right badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328730 (https://phabricator.wikimedia.org/T142454) (owner: 10Sbisson) [21:32:36] 04(no projects): Query service prompting gui should not mess with the rest of the query - https://phabricator.wikimedia.org/T153982#2897273 (10Base) [21:34:13] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [21:34:29] (03PS11) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [21:34:41] Reedy: Commited, will wait for jenkins [21:35:41] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran phan static analysis and there were some errors: /srv/mediawiki-vagrant/mediawiki/extensions/CirrusSearch/includes/Elastica/LtrQuery" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [21:36:02] Reedy: Hmm, looks like its something with jenkins [21:36:05] (03PS10) 10Smalyshev: Move geosearch features to GeoData extension. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/326039 (https://phabricator.wikimedia.org/T152730) [21:36:08] I dont know [21:39:14] rlot: should note that phan doesn't read @var tags in the middle of code, only in class/method/function docblocks (a pain, i know) [21:39:37] orly? [21:39:43] it's a limitation of the php AST (they are thrown away, because the php runtime doesn't need them, as opposed to the class/method/function which are reported by reflection) [21:39:48] ebernhardson: Wow, this should fix it [21:40:03] ebernhardson: // why does it feel like my comments are ignored [21:40:24] 10MediaWiki-extensions-Newsletter: Subtitle should show "delete" option. - https://phabricator.wikimedia.org/T153879#2897294 (10Qgil) I had reported this problem myself, and @01tonythomas convinced me to give a shot to the current design, which follows the convention for deleting regular wiki pages. Deleting a n... [21:40:38] Reedy: i documented it :P https://www.mediawiki.org/wiki/Continuous_integration/Phan#Known_Problems [21:40:54] heh [21:40:55] annoyingly what they suggest is to use php 7 assertions, but we can't [21:40:59] Reedy: Omg, i have foreach suppressed in config.php [21:41:21] in php7 assertions can be pure expressions, and they can be turned off in prod, so you can assert(is_array($foo)) and phan will take it to be an array from then on [21:42:39] Ignoring MW min supported php version... [21:42:48] /** [21:42:48] * Usernames which fail to pass this function will be blocked [21:42:48] * from user login and new account registrations, but may be used [21:42:48] * internally by batch processes. [21:42:48] * [21:42:49] * If an account already exists in this form, login will be blocked [21:42:49] Does hhvm support it? [21:42:51] * by a failure to pass this function. [21:42:53] * [21:42:54] uh oh [21:42:55] * @param string $name Name to match [21:42:57] * @return bool [21:42:59] */ [21:43:01] /** @var $reservedUsernames string[] */ [21:43:05] Shound it be merged with this comment? [21:43:05] rlot: Do you know what a pastebin is? :) [21:44:03] Reedy: I must install some copy-paste bin tool in my system [21:44:10] 10MediaWiki-extensions-NavigationTiming, 06Performance-Team: Fix mediaWikiLoadComplete accuracy - https://phabricator.wikimedia.org/T153819#2897297 (10Krinkle) p:05Triage>03Normal a:03Krinkle [21:44:28] Reedy: But can it be just like @param etc? [21:44:51] Sounds like it. ebernhardson would be able to confirm [21:45:18] 10MediaWiki-History-or-Diffs, 10MediaWiki-extensions-Contributors, 07Community-Wishlist-Survey-2015: List of content contributors - https://phabricator.wikimedia.org/T120738#2897299 (10Quiddity) [21:45:18] rlot: it would be it the same block as the @param and @return, using @var i believe. best is to check the phan docs though sec [21:45:44] rlot: https://github.com/etsy/phan/wiki/Annotating-Your-Source-Code [21:45:54] rlot: says @var string $v, in the main docblock for a method [21:46:01] (or whatever your type/variable name is) [21:46:32] eberhardson: Name after type? [21:46:41] rlot: thats what the phan documentation shows [21:47:15] 07Design, 10MediaWiki-HTMLForm, 13Patch-For-Review: OOjs UI should allow `disabled` to contain an array - https://phabricator.wikimedia.org/T153927#2897306 (10Huji) An alternative approach was [[https://gerrit.wikimedia.org/r/#/c/328601 | proposed]] by @matmarex which would look like this: ``` new OOUI\Chec... [21:58:39] (03PS1) 10SamanthaNguyen: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 [22:01:42] wait, Reedy, are these hook tasks gone? [22:01:52] Georggi: Might need more publishing [22:02:08] or nvm, there is one [22:03:56] ebernhardson: Reedy: Made fixes in all files, still getting same errors [22:04:24] I'll just suppress it. [22:05:02] 04(no projects): Can't save edit in Wikipedia app for Android - https://phabricator.wikimedia.org/T153983#2897329 (10eranroz) [22:05:57] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2897341 (10Smalyshev) I am not a big fan of combining и and й because I think there's not a lot of benefit in it - й is in any Russian keyboard layout, and no... [22:14:08] Reedy: This system is really wierd [22:14:32] Reedy: Made these fixes, but suppressed it [22:14:58] (03CR) 10Smalyshev: "maybe makes sense to rebase this to master? not sure it uses LTR query" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [22:16:29] (03PS3) 10EBernhardson: Provide id-filtering to runSearch.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 [22:16:50] (03CR) 10EBernhardson: "right, this didn't need the ltr that's just where i happened to first need it and was testing it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [22:18:27] (03PS12) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [22:18:36] Reedy: Ok, suppressed [22:20:23] (03PS2) 10SamanthaNguyen: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (https://phabricator.wikimedia.org/T153551) [22:20:40] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Create config more intuitive aliases for filetype: search - https://phabricator.wikimedia.org/T150887#2897349 (10Smalyshev) Yes we still have T152728 for this which I think we can do somewhere in second... [22:22:28] (03CR) 10EBernhardson: "i was just thinking about this, and realized it might not even be necessary to use this patch. If i only want results for particular set o" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [22:22:34] (03PS1) 10Mholloway: Add page indicator view to description edit tutorial [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328840 (https://phabricator.wikimedia.org/T148205) [22:22:58] (03CR) 10Pmiazga: [C: 031] "Code looks good although I couldn't test it on dev side" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328721 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [22:23:32] (03PS3) 10SamanthaNguyen: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (https://phabricator.wikimedia.org/T153551) [22:24:50] (03PS2) 10Mholloway: Add page indicator view to description edit tutorial [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328840 (https://phabricator.wikimedia.org/T148205) [22:24:54] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897356 (10bmansurov) @Nirzar, compare https://en.m.wikipedia.org/wiki/Book vs https://en.m.wikipedia.org/wiki/Book?mobileaction=beta. [22:25:49] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [22:26:12] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897360 (10Nirzar) @bmansurov wait.. the recent changes we did to remove the flickr from auto suggest weren't deployed for everyone? [22:26:36] (03CR) 10Jack Phoenix: [C: 04-1] "Congratulations on making your first patch to gerrit! :)" (035 comments) [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (https://phabricator.wikimedia.org/T153551) (owner: 10SamanthaNguyen) [22:27:38] (03PS13) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [22:28:31] (03CR) 10Pmiazga: [C: 031] "Tested on Chromium55, looks better now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328723 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [22:29:22] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897364 (10bmansurov) Nope, beta only. [22:30:20] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897368 (10Nirzar) @bmansurov hmm i thought we deployed it to everyone. can we change this task to deploy it for everyone instead of featur... [22:30:22] 06Design-Research-Backlog: Wikimedia Commons curation workflow interviews - https://phabricator.wikimedia.org/T152248#2897369 (10Capt_Swing) Will start recruiting in early Q3. [22:30:28] 10Design Research participant recruiting, 06Design-Research: new participants from NR offline research into database - https://phabricator.wikimedia.org/T152755#2897371 (10ggellerman) a:03SBecker [22:30:29] (03PS3) 10Mholloway: Add page indicator view to description edit tutorial [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328840 (https://phabricator.wikimedia.org/T148205) [22:31:13] 06Design-Research: Wikum feedback - https://phabricator.wikimedia.org/T151946#2897375 (10Capt_Swing) [22:31:38] (03PS14) 10Filip: Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) [22:31:55] 06Design-Research: Participatory design in FLOSS case study - https://phabricator.wikimedia.org/T151944#2897376 (10Capt_Swing) [22:32:43] 06Design-Research: Participant recruiting training and documentation - https://phabricator.wikimedia.org/T145592#2897377 (10ggellerman) [22:33:24] 06Design-Research, 10Reading-UX-Research: Recruit users for iOS Longitudinal study pilot - https://phabricator.wikimedia.org/T136869#2897378 (10ggellerman) [22:34:17] 10Design Research participant recruiting, 06Design-Research: new participants from NR offline research into database - https://phabricator.wikimedia.org/T152755#2897382 (10ggellerman) p:05Triage>03Normal [22:35:14] (03CR) 10Krinkle: [C: 04-1] Fixed PHP issues found by phan (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [22:36:47] Reedy: Jenkins passed! https://integration.wikimedia.org/ci/job/mediawiki-core-php70-phan-jessie/729/ [22:37:17] Reedy: Can you look in the code? [22:37:20] (03CR) 10Krinkle: [C: 04-1] "We don't usually for it for local variables, and when we do it's inline or at least somewhere in the function body. E.g. "/** @var Excepti" [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [22:37:28] 06Design-Research: post all of the DR workshop recordings + deck on our mediawiki design research page - https://phabricator.wikimedia.org/T123752#2897386 (10SBecker) Discussed 12/22 Samantha has large video format only Add presenter names, presentation titles, and if time available, timestamps [22:38:33] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Feature flag the search overlay delay functionality - https://phabricator.wikimedia.org/T153973#2897388 (10bmansurov) Sounds good. Feel free to update the description as you see fit. [22:39:23] (03CR) 10MaxSem: [C: 04-1] "Instead of suppressing errors, why not annotate the types properly?" [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [22:39:35] 06Design-Research, 10Reading-UX-Research: Recruit users for iOS Longitudinal study pilot - https://phabricator.wikimedia.org/T136869#2350462 (10SBecker) p:05Triage>03Normal [22:40:11] (03CR) 10jerkins-bot: [V: 04-1] Fixed PHP issues found by phan [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [22:40:31] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader, 06Performance-Team: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2845290 (10aaron) I don't see this in production, but there are some oddities in querying the heartbe... [22:40:35] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [22:41:07] 10MediaWiki-Database, 10DBA, 07Tracking: Database replication lag issues (tracking) - https://phabricator.wikimedia.org/T3268#2897402 (10jcrespo) [22:41:10] 10MediaWiki-Database, 05MW-1.27-release-notes, 13Patch-For-Review: No user-visible lag reports when database slave server has stopped replication slave thread - https://phabricator.wikimedia.org/T19179#2897399 (10jcrespo) 05Open>03Resolved a:03aaron I would consider this resolved thanks to performance... [22:41:18] Reedy: Can you still reproduce and/or see in logs - https://phabricator.wikimedia.org/T152345 ? [22:41:23] 10Reading-UX-Research, 06Wikipedia-Android-App-Backlog (Kanban): Provide a prototype build of Description Editing to Design Research. - https://phabricator.wikimedia.org/T152521#2897403 (10Capt_Swing) [22:41:36] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Deploy flicker-free search for all users - https://phabricator.wikimedia.org/T153973#2897404 (10Nirzar) [22:41:40] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/328714 (owner: 10EBernhardson) [22:41:52] Reedy: It would be useful to know whether the majority of those 120s were spent at the point where it timed out, or somewhere earlier. [22:42:07] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Deploy flicker-free search for all users - https://phabricator.wikimedia.org/T153973#2897049 (10Nirzar) [22:42:10] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review: Improve user experience in search - https://phabricator.wikimedia.org/T137068#2897408 (10Nirzar) [22:42:24] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Deploy flicker-free search for all users - https://phabricator.wikimedia.org/T153973#2897049 (10Nirzar) @bmansurov description updated. [22:44:36] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader, 06Performance-Team: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2845290 (10Krinkle) @Reedy Can you still reproduce and/or see in logs? Also, the time column, is that... [22:44:54] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader, 06Performance-Team: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2897412 (10Krinkle) p:05Triage>03Low [22:45:04] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2845290 (10Krinkle) [22:46:13] 10MediaWiki-ResourceLoader, 06Front-end-Standards-Group: CSSMin should not convert urls for filters - https://phabricator.wikimedia.org/T151972#2897415 (10Krinkle) p:05Triage>03Low [22:47:37] (03PS1) 10MaxSem: Stop using deprecated stuff [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/328844 [22:47:54] 04(no projects): Lost session data on every save attempt - https://phabricator.wikimedia.org/T153984#2897418 (10Tacsipacsi) [22:50:05] 10MediaWiki-Authentication-and-authorization: It should be possible to remove local passwords - https://phabricator.wikimedia.org/T153985#2897433 (10Florian) [22:51:03] 10MediaWiki-ResourceLoader, 06Front-end-Standards-Group: CSSMin should not convert urls for filters - https://phabricator.wikimedia.org/T151972#2833787 (10Krinkle) It converts it to a relative url because CSSMin assumes all resources referenced in a stylesheet are stored on disk, and per CSS syntax rules, urls... [22:52:58] (03CR) 10Krinkle: [C: 04-1] Stop using deprecated stuff (031 comment) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/328844 (owner: 10MaxSem) [22:53:22] (03CR) 10Krinkle: [C: 04-1] Stop using deprecated stuff (031 comment) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/328844 (owner: 10MaxSem) [22:53:28] (03PS4) 10SamanthaNguyen: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 [22:54:19] (03CR) 10SamanthaNguyen: ">" (035 comments) [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (owner: 10SamanthaNguyen) [22:56:31] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2897449 (10srishakatux) [22:57:01] (03PS5) 10SamanthaNguyen: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 [23:00:05] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2897451 (10TJones) >>! In T132637#2897251, @Wikitiki89 wrote: > You seem to be conflating two different issues. One is about the actual orthographic rules, an... [23:00:36] (03CR) 10EBernhardson: Fixed PHP issues found by phan (031 comment) [core] - 10https://gerrit.wikimedia.org/r/328679 (https://phabricator.wikimedia.org/T153252) (owner: 10Filip) [23:01:04] (03PS1) 10Pppery: Add a `Special:Newsletter/id/subsrcibers` page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328845 [23:03:17] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: New subpage to list down subscribers for a newsletter - https://phabricator.wikimedia.org/T153639#2897455 (10Pppery) a:03Pppery [23:04:11] (03PS2) 10Pppery: Add a `Special:Newsletter/id/subsrcibers` page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328845 (https://phabricator.wikimedia.org/T15639) [23:04:55] (03PS3) 10Pppery: Add a `Special:Newsletter/id/subsrcibers` page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328845 (https://phabricator.wikimedia.org/T153639) [23:05:38] 10MediaWiki-Interface, 07Tracking: Things that could use the title rewrite (tracking) - https://phabricator.wikimedia.org/T15639#2897464 (10Pppery) [23:06:02] 10MediaWiki-Interface, 07Tracking: Things that could use the title rewrite (tracking) - https://phabricator.wikimedia.org/T15639#178994 (10Pppery) Oops, I made a typo in my bug number. [23:08:07] (03PS1) 10Seth: fix #T15619 [core] - 10https://gerrit.wikimedia.org/r/328847 [23:08:32] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Clicking the "History" or "Nearby" icon shows "Unfortunately, WIkipedia Alpha has stopped" message in 2.4.184-alpha-2016-12-23 - https://phabricator.wikimedia.org/T153968#2897472 (10Mholloway) [23:08:43] 07Design, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2897473 (10jmatazzoni) 05Open>03Resolved [23:21:39] 04(no projects): Document that https://github.com/WikiEducationFoundation/WikiEduDashboard also covers the Programs & Events dashboard - https://phabricator.wikimedia.org/T153986#2897479 (10kaldari) [23:24:59] Krinkle: I've been having some weird memcached issues since upgrading to 16.10 it seems... [23:25:06] I've filed a few weird ish bugs [23:26:16] Krinkle: Sessions were completely broken until I moved to redis [23:26:32] Dunno if that's a memcached bug, or a php to memcached bug in php 7 [23:32:37] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2897495 (10Reedy) Not exactly the same, but yeah, still there... I think it's seconds, so yeah, most of the 2 minutes doing... [23:32:46] (03CR) 10Blackspirit96: "> Blackspirit96: Please also check out https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews#Test_your_changes" [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [23:33:01] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2897498 (10srishakatux) @Rfarrand Thank you for putting up the page, I've made some excessive edits, so pardon me, and feel free to... [23:33:40] 06Research-and-Data-Archive, 10Research-management: Make sure each team member with published research outputs has an ORCID - https://phabricator.wikimedia.org/T144576#2897501 (10DarTar) SPARQL results: http://tinyurl.com/gqn8ytw [23:34:28] (03PS6) 10SamanthaNguyen: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (https://phabricator.wikimedia.org/T153551) [23:36:04] 06Community-Liaisons, 10Wikimedia-Hackathon-2017-Organization, 06Developer-Relations (Jan-Mar-2017): Create language stickers for international events - https://phabricator.wikimedia.org/T128722#2897508 (10Rfarrand) @intracer Oh cute! I like it! I am guessing we wont have stickers by the summit (6 working... [23:36:48] (03CR) 10Jack Phoenix: [C: 032] Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (https://phabricator.wikimedia.org/T153551) (owner: 10SamanthaNguyen) [23:37:08] 10MediaWiki-extensions-Nuke, 10UI-Standardization, 15User-Ladsgroup: Migrate Special:Nuke to OOUI - https://phabricator.wikimedia.org/T153988#2897526 (10Ladsgroup) [23:37:41] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2897541 (10srishakatux) Also, one last thing: now that we have a page on 'Remote Participation', I think that the social media post... [23:37:45] (03Merged) 10jenkins-bot: Lowercasing strings for consistency and readability [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/328811 (https://phabricator.wikimedia.org/T153551) (owner: 10SamanthaNguyen) [23:40:01] 10SiteMetrics, 10Social-Tools, 07Easy, 07I18n: Lowercase i18n strings for consistency with other extensions in SiteMetrics - https://phabricator.wikimedia.org/T153551#2884020 (10SamanthaNguyen) 05Open>03Resolved [23:40:30] 10MediaWiki-extensions-WikibaseRepository, 10DataValues, 10Wikidata: Wrong coordinate display in wikidata page - https://phabricator.wikimedia.org/T150085#2897550 (10Joutbis) I understand now. The value given is well within the precision, not even very far off. The problem then is that it is misleading. Some... [23:42:29] (03CR) 1001tonythomas: [C: 04-1] "on Special:Newsletter/48/subscribers" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328845 (https://phabricator.wikimedia.org/T153639) (owner: 10Pppery) [23:42:47] (03PS1) 10Ladsgroup: Convert Special:Nuke prompt form to OOUI [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/328850 (https://phabricator.wikimedia.org/T153988) [23:43:07] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2897554 (10Rfarrand) Alright, I agree regarding pointing to the etherpads. They will find them anyways if they want to. No, lets... [23:45:46] (03PS38) 10Mooeypoo: Adding new interface for review filters to RecentChanges [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) [23:47:41] (03PS1) 10Dzahn: fix HTML validation error [debs/wikistats] - 10https://gerrit.wikimedia.org/r/328851 [23:47:53] (03PS14) 10Mooeypoo: Gate enhanced RC filters on hidden user preference [core] - 10https://gerrit.wikimedia.org/r/323326 (owner: 10Mattflaschen) [23:48:01] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2897566 (10srishakatux) > No, lets not use #wikimedia-dev because that is already an existing channel that has other uses. #wikidev... [23:49:33] (03PS2) 10Dzahn: fix HTML validation error [debs/wikistats] - 10https://gerrit.wikimedia.org/r/328851 [23:50:49] (03CR) 10Dzahn: [C: 032] fix HTML validation error [debs/wikistats] - 10https://gerrit.wikimedia.org/r/328851 (owner: 10Dzahn) [23:50:56] (03CR) 10Dzahn: [V: 032 C: 032] fix HTML validation error [debs/wikistats] - 10https://gerrit.wikimedia.org/r/328851 (owner: 10Dzahn) [23:51:44] (03CR) 10Dzahn: "now it's "This document was successfully checked as XHTML 1.0 Strict!" again http://validator.w3.org/check?uri=http://wikistats.wmflabs.or" [debs/wikistats] - 10https://gerrit.wikimedia.org/r/328851 (owner: 10Dzahn) [23:56:37] (03PS1) 10TTO: Add text/plain as a trusted MIME type [core] - 10https://gerrit.wikimedia.org/r/328852 (https://phabricator.wikimedia.org/T153843) [23:58:16] (03PS1) 10Mholloway: Fix crash caused by vector drawable on pre-lollipop devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328853 [23:59:12] 10MediaWiki-extensions-ContributionTracking, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Spike: ContributionTracking sometimes fails to insert rows - https://phabricator.wikimedia.org/T153730#2897595 (10Ejegg) This may be a false alarm - I ju... [23:59:54] (03PS2) 10Mholloway: Fix crash caused by vector drawable on pre-lollipop devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/328853 (https://phabricator.wikimedia.org/T153968)