[00:07:59] (03CR) 10Divadsn: [] "Are we waiting until my other change has been merged to run a recheck?" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [00:16:59] (03CR) 10Legoktm: [] Move TempFileRepo to a separate file (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327909 (owner: 10Aaron Schulz) [00:22:40] (03PS1) 10Legoktm: Update changelog to indicate #848441 is also fixed [debian] - 10https://gerrit.wikimedia.org/r/328026 [00:31:59] (03CR) 10Legoktm: [V: 032 C: 032] Update changelog to indicate #848441 is also fixed [debian] - 10https://gerrit.wikimedia.org/r/328026 (owner: 10Legoktm) [00:33:49] (03CR) 10Divadsn: [] "Small notice from my side." (031 comment) [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [00:45:00] (03CR) 10Platonides: [C: 032] Fix for incategory prefix to work in 1.25: Needs to inherit from SearchDatabase for DB queries. [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/229725 (https://phabricator.wikimedia.org/T100007) (owner: 10Rglasnap) [00:45:07] (03Merged) 10jenkins-bot: Fix for incategory prefix to work in 1.25: Needs to inherit from SearchDatabase for DB queries. [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/229725 (https://phabricator.wikimedia.org/T100007) (owner: 10Rglasnap) [00:47:54] 10MediaWiki-File-management, 06Commons, 06Multimedia: File update operations are fragile, causing occasional data loss - https://phabricator.wikimedia.org/T153565#2884325 (10Tgr) [00:51:36] 10Social-Tools, 10VoteNY: Add returning community average for given Pageid - https://phabricator.wikimedia.org/T153566#2884347 (10Nodreams) [00:52:45] 10MediaWiki-extensions-SphinxSearch, 13Patch-For-Review: incategory: search prefix returning fatal error. - https://phabricator.wikimedia.org/T100007#2884367 (10Platonides) 05Open>03Resolved a:03Platonides I have merged @Rosencrantz patch. It //only// had to wait for 1 year and 4 months :( @jartes, plea... [01:04:57] 10MediaWiki-extensions-OATHAuth, 07Easy: OATHAuth token textbox must always be LTR - https://phabricator.wikimedia.org/T153556#2884374 (10Huji) a:05Huji>03None [01:07:51] (03CR) 10Huji: [C: 031] "Tested it; works as expected. Recommending merge." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326272 (owner: 10Matěj Suchánek) [01:08:26] 10MediaWiki-File-management, 06Commons, 06Multimedia: File update operations are fragile, causing occasional data loss - https://phabricator.wikimedia.org/T153565#2884376 (10Tgr) The typical way (or maybe not, but the one we understand) for files to get lost is that a storage operation fails but the correspo... [01:08:42] 10MediaWiki-File-management, 06Commons, 06Multimedia: MediaWiki file operations are fragile, causing occasional data loss - https://phabricator.wikimedia.org/T153565#2884380 (10Tgr) [01:09:42] (03CR) 10Huji: [] "Any interest in continuing to work on this?" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/7738 (https://bugzilla.wikimedia.org/13673) (owner: 10Eranroz) [01:11:47] 04(no projects): Redirect on pages that should be ending with a ")" - https://phabricator.wikimedia.org/T153568#2884395 (10Popey456963) [01:21:48] 10MediaWiki-File-management, 06Commons, 06Multimedia: MediaWiki file operations are fragile, causing occasional data loss - https://phabricator.wikimedia.org/T153565#2884325 (10Platonides) The filerepos do have support for using a lockmanager [01:23:25] 10MediaWiki-extensions-Babel: Babel language codes should be normalised to lower case when used in categories - https://phabricator.wikimedia.org/T63993#2884412 (10Liuxinyu970226) >>! In T63993#2884217, @Ningauble wrote: > I have blocked the bot account at en.wikiquote because this is //still// happening. Other... [01:26:35] (03PS5) 10Reedy: LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) (owner: 10Divadsn) [01:26:40] (03CR) 10Reedy: [C: 032] LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) (owner: 10Divadsn) [01:27:18] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method: Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [01:27:32] But, Reedy, it is 02:27 am /o\ [01:27:36] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current clients which use thumb URLs as an API - https://phabricator.wikimedia.org/T153498#2884430 (10Tgr) [01:27:46] divadsn: in CET maybe ;) [01:27:55] (03Merged) 10jenkins-bot: LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) (owner: 10Divadsn) [01:28:14] (03Merged) 10jenkins-bot: Removed usages of a deprecated method: Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [01:28:33] Wait, are you in UTC? [01:28:56] I am [01:29:05] Reedy: But it's still late, I will go off now, good night. [01:29:07] For 6 months of the year at least :P [01:29:12] I'm going to bed very shortly too [01:29:22] Just wanted to check in to see if anything was worth my attention :) [01:29:33] Nice to see that you had nothing to complain :P [01:29:59] divadsn: Well, you listened to CI, and fixed what it didn't like [01:30:12] divadsn: It also means with andre__'s help, we wrote sufficient instructions :) [01:30:22] (03PS5) 10Reedy: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [01:30:31] Which should mean we can now merge that too... [01:30:33] At least I found it, thanks to the example in the task ^^ [01:30:46] Yep :) [01:31:10] 10MediaWiki-File-management, 06Commons, 06Multimedia: MediaWiki file operations are fragile, causing occasional data loss - https://phabricator.wikimedia.org/T153565#2884435 (10Pokefan95) p:05Triage>03High We don't want our files to be permanently lost, if truly the file operations are fragile, then more... [01:31:10] divadsn: IIRC, there's another task the same too [01:32:42] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016, 07I18n, 13Patch-For-Review: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2884441 (10Reedy) 05Open>03Resolved [01:32:54] (03CR) 10Reedy: [C: 032] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [01:34:01] (03Merged) 10jenkins-bot: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [01:34:58] 10MediaWiki-General-or-Unknown: Redirect on pages that should be ending with a ")" - https://phabricator.wikimedia.org/T153568#2884444 (10Krenair) that's a problem with their URL detection. [01:37:40] 10MediaWiki-General-or-Unknown: Redirect on pages that should be ending with a ")" - https://phabricator.wikimedia.org/T153568#2884395 (10Platonides) This is a content issue, not something to be blindly applied. The bulk of the 1577 pages with an opening "(" but no ")" are missing-) redirects, with a few emotic... [01:38:23] (03PS3) 10Paladox: Remove grrrit-wm: force-restart [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/328025 [01:38:56] Reedy, good to know, I like these kind of tasks more than replace x with y ;) [01:39:22] Now I will leave my phone away also and go to sleep, bye! [01:39:28] Night! [01:49:09] (03CR) 10Victor Vasiliev: [C: 032] Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 (owner: 10Aaron Schulz) [01:51:34] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong message-key used in NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153530#2884470 (10divadsn) a:03divadsn Will work to solve this issue. [01:52:32] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 07I18n: Wrong message-key used in NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153530#2884472 (10divadsn) [01:57:01] (03Merged) 10jenkins-bot: Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 (owner: 10Aaron Schulz) [02:08:00] (03PS1) 10Cenarium: Pass undone revision id to PageContentSaveComplete hook [core] - 10https://gerrit.wikimedia.org/r/328027 [02:21:38] (03CR) 10Legoktm: [] "recheck" [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/326369 (owner: 10Legoktm) [02:22:19] (03PS1) 10Cenarium: Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) [02:22:37] (03CR) 10jenkins-bot: [V: 04-1] Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [02:29:20] (03CR) 10jenkins-bot: [V: 04-1] installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/326369 (owner: 10Legoktm) [02:32:01] (03CR) 10Legoktm: [C: 032] "For some reason on php5 and not hhvm, it's failing with mwe_player_1 vs mwe_player_2" [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [02:36:49] (03CR) 10Legoktm: [C: 032] "Also, given that Tim's parser test refactor only landed in REL1_28, why is this even failing on 1.27?" [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [02:39:27] (03CR) 10jenkins-bot: [V: 04-1] Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [02:43:17] (03CR) 10Legoktm: [C: 032] Add dotall modifier to EDITSECTION_REGEX [core] - 10https://gerrit.wikimedia.org/r/316617 (owner: 10Tim Starling) [02:44:14] 10MediaWiki-General-or-Unknown: Redirect on pages that should be ending with a ")" - https://phabricator.wikimedia.org/T153568#2884478 (10Popey456963) 05Open>03Resolved [02:44:41] 10MediaWiki-General-or-Unknown: Redirect on pages that should be ending with a ")" - https://phabricator.wikimedia.org/T153568#2884395 (10Popey456963) That was exactly what I meant! Didn't know it already existed. That is more than enough :) [02:46:19] (03PS2) 10Cenarium: Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) [02:53:50] (03Merged) 10jenkins-bot: Add dotall modifier to EDITSECTION_REGEX [core] - 10https://gerrit.wikimedia.org/r/316617 (owner: 10Tim Starling) [02:53:53] (03CR) 10jenkins-bot: [V: 04-1] Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [02:59:29] (03CR) 10Legoktm: [C: 031] "Were you planning to use this for something?" [core] - 10https://gerrit.wikimedia.org/r/319794 (owner: 10Gergő Tisza) [03:01:01] (03CR) 10Cenarium: [] "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [03:05:48] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current clients which use thumb URLs as an API - https://phabricator.wikimedia.org/T153498#2884488 (10Gaurav) [03:08:42] (03CR) 10jenkins-bot: [V: 04-1] Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [03:18:18] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current MediaWiki thumbnail URL format & processing logic - https://phabricator.wikimedia.org/T153497#2884492 (10Tgr) [03:18:36] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current MediaWiki thumbnail URL format & processing logic - https://phabricator.wikimedia.org/T153497#2882512 (10Tgr) [03:25:47] 04(no projects): Logging me out - https://phabricator.wikimedia.org/T153571#2884494 (10Bbb23) [03:41:27] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current MediaWiki thumbnail URL format & processing logic - https://phabricator.wikimedia.org/T153497#2884508 (10Tgr) [03:44:43] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2884509 (10Samwilson) Thanks @MusikAnimal! @Kudpung does it look okay to you? [04:00:41] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2884517 (10Kudpung) Sunday morning now. I'll check it out immediately after breakfast. [04:05:56] 10The-Wikipedia-Library: Email editors when their application is approved - https://phabricator.wikimedia.org/T147462#2884518 (10Nikkimaria) a:05Nikkimaria>03ThatAndromeda https://docs.google.com/document/d/1XYE3DA236Awqs8Rl9s2U543-C7O7_ahqjc40pDtWkM8/edit [04:18:07] 10MediaWiki-Parser: Sanitizer fails to include image tags if incorrectly written as closed/void tags - https://phabricator.wikimedia.org/T48443#529936 (10Dan.mulholland) It really would be nice to note in the RSS extension page that extracting //any// image information from the RSS feed is not possi... [04:30:08] (03CR) 10Gergő Tisza: [] "Yeah, the test in https://gerrit.wikimedia.org/r/#/c/320324/" [core] - 10https://gerrit.wikimedia.org/r/319794 (owner: 10Gergő Tisza) [04:36:51] 10UI-Standardization, 10Wikimedia-Blog, 13Patch-For-Review, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2884527 (10Tbayer) 05Open>03Resolved Merged and deployed - looks good now for me on both Firefox and Chrome, with white test on bl... [04:41:30] 10MediaWiki-User-login-and-signup: Logging me out - https://phabricator.wikimedia.org/T153571#2884529 (10Whatamidoing-WMF) [04:42:15] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current MediaWiki thumbnail URL format & processing logic - https://phabricator.wikimedia.org/T153497#2884530 (10Tgr) [04:58:51] 10MediaWiki-File-management, 10ArchCom-RfC, 06Commons, 06Multimedia, and 14 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214#2884546 (10Tgr) After thinking more about this and looking at the code I am getting more and more confused about what exactly we are trying to do. Medi... [05:13:33] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2884547 (10Kudpung) They seem to be working as expected but the order of the items on the list needs to be rearr... [05:52:55] (03PS2) 10Aaron Schulz: Move TempFileRepo to a separate file [core] - 10https://gerrit.wikimedia.org/r/327909 [06:04:22] (03PS2) 10Aaron Schulz: Remove the old abuse filter parser class [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 [06:08:48] (03CR) 10jenkins-bot: [V: 04-1] Remove the old abuse filter parser class [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 (owner: 10Aaron Schulz) [06:08:48] 06Wikipedia-Android-App-Backlog: Show the search icon in Explore view until the Search bar is completely visible - https://phabricator.wikimedia.org/T153573#2884556 (10Kaartic) [06:09:40] (03PS3) 10Aaron Schulz: Remove the old abuse filter parser class [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 [06:12:59] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2884569 (10Kudpung) Iwill shortly post the list of criteria in the order in which they should apear in the Creat... [06:25:35] 06Wikipedia-Android-App-Backlog: Add "Select link text" option to the menu that pops up when a wiki link is long pressed - https://phabricator.wikimedia.org/T153574#2884570 (10Kaartic) [06:32:39] (03CR) 10Legoktm: [] "Just to make sure, you do know that the caching parser is still broken right and has been disabled again?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 (owner: 10Aaron Schulz) [06:33:30] 06Wikipedia-Android-App-Backlog: Allow users to select text that appears in the snack bar when a reference is clicked - https://phabricator.wikimedia.org/T153575#2884585 (10Kaartic) [06:41:20] 06Wikipedia-Android-App-Backlog: Show contents of a section in link preview if the link is to a specific section of the article - https://phabricator.wikimedia.org/T153576#2884597 (10Kaartic) [07:04:45] 10MediaWiki-extensions-CentralAuth, 10Wikimedia-General-or-Unknown, 07Regression: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884622 (10MZMcBride) [08:33:34] 10MediaWiki-User-login-and-signup: Logging me out - https://phabricator.wikimedia.org/T153571#2884655 (10Aklapper) Hi @Bbb23. Have you already tried deleting the Wikimedia related cookies in your browser? Which browser and operating system is this about? Does the problem also happen with another browser? Has thi... [08:36:12] What [08:36:20] That filter did not work because it failed to parse [08:36:42] And apparently... nothing caught this?! [08:39:53] 10MediaWiki-extensions-BounceHandler, 10Wikimedia-General-or-Unknown: User:Ymblanter is continually having their email address unsubscribed - https://phabricator.wikimedia.org/T118648#2884657 (10Aklapper) >>! In T118648#1806713, @Ymblanter wrote: > Thanks, I will do it. @Ymblanter: What was the result? Is th... [08:40:43] 10MediaWiki-extensions-SphinxSearch: Search is not functional after upgrade to MW 1.24 - https://phabricator.wikimedia.org/T76566#2884659 (10Aklapper) 05stalled>03Resolved a:03Aklapper >>! In T76566#1801327, @Turnstep wrote: > Looks like this was fixed in acd40b8fa82c04e80d390f650ee368bbdd4628cd Thanks! C... [08:41:17] 10Blueprint: Use slide out/other animation when left panel is opened - https://phabricator.wikimedia.org/T104006#2884662 (10Aklapper) 05stalled>03Open I don't see anything stalled here. [08:42:49] 10MediaWiki-extension-requests: Make Share-a-fact available on desktop - https://phabricator.wikimedia.org/T94998#2884664 (10Aklapper) 05stalled>03Open p:05Triage>03Lowest I don't see any reason for "stalled" status here. [08:43:24] 10MediaWiki-extensions-UniversalLanguageSelector, 07I18n: wikipedia punjabi keyboard - https://phabricator.wikimedia.org/T103652#2884667 (10Aklapper) 05stalled>03declined >>! In T103652#1471073, @Amire80 wrote: > @Nachhattardhammu, it works for me. > - Do you have JavaScript enabled in your browser? > - Cl... [08:44:03] 10MediaWiki-History-or-Diffs: It would be useful if a click on a
  • element on the history page would check that li's radiobox - https://phabricator.wikimedia.org/T29412#2884670 (10Aklapper) 05stalled>03declined Unfortunately closing this report as no further information has been provided. Please reopen th... [08:46:52] 10MediaWiki-History-or-Diffs: Rich Diff framework - https://phabricator.wikimedia.org/T10981#2884675 (10Aklapper) 05stalled>03declined WikiDiff is available. If any //specific// functionality for //specific// situations is missing please [[ https://mediawiki.org/wiki/How_to_report_a_bug | file specific bug r... [08:48:00] 10Sentry, 13Patch-For-Review: Wrap jQuery AJAX callbacks in try..catch via mw.errorLogging - https://phabricator.wikimedia.org/T92247#2884677 (10Aklapper) p:05High>03Low [08:49:32] 10MediaWiki-extensions-DumpHTML: Memory Limit Failure - https://phabricator.wikimedia.org/T18831#2884679 (10Aklapper) 05stalled>03declined Unfortunately closing this report as no further information has been provided. Please reopen this report (by changing its status) after you have provided the information... [08:51:42] 10MediaWiki-General-or-Unknown: Redirect on pages that should be ending with a ")" - https://phabricator.wikimedia.org/T153568#2884681 (10Aklapper) 05Resolved>03Invalid [ Nothing got resolved via a code change after this task was created, hence setting task status to 'invalid'. ] [08:57:20] 10MediaWiki-File-management, 06Commons, 06Multimedia: MediaWiki file operations are fragile, causing occasional data loss - https://phabricator.wikimedia.org/T153565#2884684 (10Aklapper) p:05High>03Triage [08:58:18] 10MediaWiki-extensions-OATHAuth, 07Easy, 07I18n, 07RTL: OATHAuth token textbox must always be LTR - https://phabricator.wikimedia.org/T153556#2884685 (10Aklapper) [08:59:28] 10Social-Tools, 10VoteNY: Add returning community average for given Pageid - https://phabricator.wikimedia.org/T153566#2884687 (10Aklapper) @Nodreams: Please link to the existing documentation that you have been following. [09:01:15] (03CR) 1001tonythomas: [C: 04-1] "Minor Nits. The rest of it works. Thank you!" (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) (owner: 10Georggi199) [09:01:37] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: Minor followup to user-group "editor", add "autoreview " as implicit group - https://phabricator.wikimedia.org/T153548#2884689 (10Aklapper) Alright. So what's requested here, in a single sentence? Different API output? Because whatever it is,... [09:02:18] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Newsletter: Should newsletter be storing in data both in contenthandler and in the database - https://phabricator.wikimedia.org/T153532#2884690 (1001tonythomas) I see that atleast the description and main_page Id can be taken in by things like `$this->context... [09:02:27] 10MediaWiki-extensions-Other: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884691 (10Aklapper) [09:02:55] 10MediaWiki-extensions-Other: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884167 (10Aklapper) [09:02:57] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2884693 (10Aklapper) [09:03:53] 10Phabricator (Upstream), 07Upstream: Phabricator batch editor should support mass moving tasks to different sections of the workboard - https://phabricator.wikimedia.org/T153324#2884695 (10Aklapper) [09:04:48] 10Phabricator (Upstream), 07Upstream: Phabricator batch editor should support mass moving tasks to different sections of the workboard - https://phabricator.wikimedia.org/T153324#2876811 (10Aklapper) >>! In T153324#2884216, @MarcoAurelio wrote: > I propose that it be reported upstream See https://www.mediawik... [09:08:36] 10MediaWiki-Interface, 07Easy, 03Google-Code-In-2016: Add id attribute to error message "mw-error-cannotundelete" - https://phabricator.wikimedia.org/T20819#2884697 (10Aklapper) [09:09:36] 10AbuseFilter: AbuseFilterCachingParser never matches certain filters, which match with the old parser - https://phabricator.wikimedia.org/T153251#2884699 (10vvv) Okay, the answer is simple and somewhat disturbing: the new parser just failed to parse the filter in question with the syntax error, so it presumably... [09:11:13] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2884701 (10Aklapper) >>! In T152291#2884017, @Reedy wrote: > Copy pasta from another extension for 99% of it Yeah but I wasn't after teaching car... [09:11:50] 10grrrit-wm, 13Patch-For-Review: Add quit message when grrrit-wm receives a force-restart - https://phabricator.wikimedia.org/T151508#2884702 (10Aklapper) [09:13:12] 10MediaWiki-Watchlist: AJAX Watchlist does not completely work with expanded Watchlist: Ignores single changes from sequential ones - https://phabricator.wikimedia.org/T153536#2884703 (10Aklapper) [09:15:50] 10MediaWiki-User-login-and-signup: Logging me out - https://phabricator.wikimedia.org/T153571#2884704 (10Aklapper) Looks like this was already brought up in https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Logging_me_out (where I think that this belongs)... [09:22:57] tonythomas, doing the patch right now [09:25:24] (03CR) 10Reedy: [C: 032] Updated Cargo maintenance scripts to use $this->requireExtension() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [09:25:48] (03CR) 10Reedy: [C: 032] Updated maintenance scripts to use $this->requireExtension() [extensions/Math] - 10https://gerrit.wikimedia.org/r/327898 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [09:27:09] (03Merged) 10jenkins-bot: Updated Cargo maintenance scripts to use $this->requireExtension() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [09:30:50] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method Revision::getText (031 comment) [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [09:31:53] 10BiblioPlus, 07Easy, 03Google-Code-In-2016: Fix mixed whitespace in BiblioPlus - https://phabricator.wikimedia.org/T153581#2884720 (10Reedy) [09:33:03] 10BiblioPlus, 07Easy, 03Google-Code-In-2016: Fix mixed whitespace in BiblioPlus - https://phabricator.wikimedia.org/T153581#2884732 (10Reedy) [09:35:19] (03Merged) 10jenkins-bot: Updated maintenance scripts to use $this->requireExtension() [extensions/Math] - 10https://gerrit.wikimedia.org/r/327898 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [09:35:55] (03Merged) 10jenkins-bot: Removed usages of a deprecated method Revision::getText [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [09:36:52] (03PS2) 10Georggi199: Removed usage of old SpecialPage code for viewing the page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) [09:37:08] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2884735 (10Reedy) https://www.mediawiki.org/wiki/Continuous_integration/Entry_points I think is one of the few docs we actually have [09:38:14] (03CR) 10jenkins-bot: [V: 04-1] Removed usage of old SpecialPage code for viewing the page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) (owner: 10Georggi199) [09:39:17] 10BiblioPlus, 07Easy, 03Google-Code-In-2016: Fix mixed whitespace in BiblioPlus - https://phabricator.wikimedia.org/T153581#2884736 (10Reedy) [09:40:31] (03PS2) 10Fomafix: Fix language attributes for the embedded content [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/307914 [09:40:59] tonythomas, where are those i18n messages documented? [09:40:59] (03CR) 10Fomafix: [] Fix language attributes for the embedded content (032 comments) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/307914 (owner: 10Fomafix) [09:41:56] (03CR) 10Reedy: [C: 032] Add empty metadata block to i18n files for banana check [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/328015 (owner: 10Umherirrender) [09:42:03] (03CR) 10Reedy: [C: 032] Add empty metadata block to i18n files for banana check [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/328019 (owner: 10Umherirrender) [09:42:06] (03CR) 10Reedy: [C: 032] Add empty metadata block to i18n files for banana check [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/328020 (owner: 10Umherirrender) [09:42:10] (03CR) 10Reedy: [C: 032] Add empty metadata block to i18n files for banana check [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/328016 (owner: 10Umherirrender) [09:43:01] (03Merged) 10jenkins-bot: Add empty metadata block to i18n files for banana check [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/328015 (owner: 10Umherirrender) [09:43:24] (03CR) 10Reedy: [C: 032] Drop pre-1.29 backwards-compatibility [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/327781 (owner: 10Legoktm) [09:43:41] (03Merged) 10jenkins-bot: Add empty metadata block to i18n files for banana check [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/328019 (owner: 10Umherirrender) [09:43:43] (03Merged) 10jenkins-bot: Add empty metadata block to i18n files for banana check [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/328020 (owner: 10Umherirrender) [09:43:46] (03Merged) 10jenkins-bot: Add empty metadata block to i18n files for banana check [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/328016 (owner: 10Umherirrender) [09:43:48] (03CR) 10Reedy: [C: 032] extension.json: Add dependency upon Elastica [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/327782 (owner: 10Legoktm) [09:44:25] (03Merged) 10jenkins-bot: Drop pre-1.29 backwards-compatibility [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/327781 (owner: 10Legoktm) [09:45:05] (03CR) 10Reedy: [C: 032] Fix @metadata in i18n files [extensions/ParentPage] - 10https://gerrit.wikimedia.org/r/328017 (owner: 10Umherirrender) [09:45:07] (03Merged) 10jenkins-bot: extension.json: Add dependency upon Elastica [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/327782 (owner: 10Legoktm) [09:45:37] (03CR) 10Reedy: [V: 032 C: 032] Add empty @metadata to i18n file for banana check [extensions/QuickSearchLookup] - 10https://gerrit.wikimedia.org/r/328018 (owner: 10Umherirrender) [09:46:12] (03CR) 10Reedy: [C: 032] Fix invalid json in qqq.json [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/327910 (owner: 10Umherirrender) [09:46:27] (03Merged) 10jenkins-bot: Fix @metadata in i18n files [extensions/ParentPage] - 10https://gerrit.wikimedia.org/r/328017 (owner: 10Umherirrender) [09:46:34] (03CR) 10Reedy: [C: 032] Remove duplicate message key from en.json [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/327911 (owner: 10Umherirrender) [09:46:51] tonythomas: Are you there? [09:46:52] (03CR) 10Reedy: [C: 032] Remove duplicate message keys from core/en.json [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/327912 (owner: 10Umherirrender) [09:47:22] (03CR) 10Reedy: [C: 032] Add MessagesDirs to extension.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/327866 (owner: 10Umherirrender) [09:47:30] (03Merged) 10jenkins-bot: Fix invalid json in qqq.json [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/327910 (owner: 10Umherirrender) [09:47:46] (03Merged) 10jenkins-bot: Remove duplicate message key from en.json [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/327911 (owner: 10Umherirrender) [09:48:47] (03PS2) 10Reedy: Avoid duplicate @doc in extension.json [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/327876 (owner: 10Umherirrender) [09:48:49] (03CR) 10Reedy: [C: 032] Avoid duplicate @doc in extension.json [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/327876 (owner: 10Umherirrender) [09:48:55] (03CR) 10Reedy: [C: 032] Avoid duplicate @doc in extension.json [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/327876 (owner: 10Umherirrender) [09:49:29] (03CR) 10Reedy: [C: 032] Avoid duplicate @doc in extension.json [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/327875 (owner: 10Umherirrender) [09:53:06] 10AbuseFilter: AbuseFilterCachingParser never matches certain filters, which match with the old parser - https://phabricator.wikimedia.org/T153251#2884737 (10zhuyifei1999) ``` $ python -c 'import this' | grep implicit Explicit is better than implicit. ``` I'd suggest that a lone comma before the parenthesis shou... [09:53:13] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2884738 (10Kudpung) This is the list in the order it appears in Twinkle (less the ones that were deliberatel... [09:54:06] (03CR) 10Legoktm: [C: 032] "Right." [core] - 10https://gerrit.wikimedia.org/r/319794 (owner: 10Gergő Tisza) [09:56:53] (03Merged) 10jenkins-bot: Remove duplicate message keys from core/en.json [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/327912 (owner: 10Umherirrender) [09:56:55] (03Merged) 10jenkins-bot: Add MessagesDirs to extension.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/327866 (owner: 10Umherirrender) [09:58:19] 10AbuseFilter: AbuseFilterCachingParser never matches certain filters, which match with the old parser - https://phabricator.wikimedia.org/T153251#2884741 (10Legoktm) >>! In T153251#2884699, @vvv wrote: > `contains_any` is vararg, so `null` gets turned into `""`, which then gets treated as no-op (see T62203), un... [09:58:36] (03Merged) 10jenkins-bot: Avoid duplicate @doc in extension.json [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/327876 (owner: 10Umherirrender) [09:58:40] (03Merged) 10jenkins-bot: Avoid duplicate @doc in extension.json [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/327875 (owner: 10Umherirrender) [09:59:17] 10MediaWiki-extensions-Translate, 06Collaboration-Team-Triage, 10Notifications: Links added on translateable pages result in multiple notifications, for every language - https://phabricator.wikimedia.org/T153558#2884179 (10Nikerabbit) The notifications should ignore translation pages, it seems. Unless there... [10:03:02] (03Merged) 10jenkins-bot: Optionally collect context in TestLogger [core] - 10https://gerrit.wikimedia.org/r/319794 (owner: 10Gergő Tisza) [10:04:02] (03CR) 10LukBukkit: "Reedy thank you for your help!" [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:06:30] 10MediaWiki-extensions-Translate: Add dropdown on Special:PageTranslationDeletePage - https://phabricator.wikimedia.org/T153542#2884753 (10Nikerabbit) p:05Triage>03Low [10:14:42] (03CR) 10Reedy: [] "check experimental" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [10:14:44] 06Wikipedia-Android-App-Backlog: Greek letters are not shown correctly in search results - https://phabricator.wikimedia.org/T153582#2884764 (10Kaartic) [10:15:26] 10MediaWiki-extensions-CentralAuth, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884776 (10Legoktm) ``` 2016-12-18 07:03:22 [WFY0ugpAAEQAAEjNyusAAAAB] mw1273 metawiki 1.29.0-wmf.6 exception ERROR: [WFY0ugpAAEQAAEjN... [10:17:44] 06Wikipedia-Android-App-Backlog: Show a snack bar for redirected article - https://phabricator.wikimedia.org/T153583#2884778 (10Kaartic) [10:18:40] (03Draft2) 10Matěj Suchánek: Add Czech aliases for special pages [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/328033 [10:20:04] addshore: Can you finally merge it? https://gerrit.wikimedia.org/r/#/c/324528/ [10:23:43] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884791 (10MarcoAurelio) p:05Triage>03Unbreak! Confirm as user with access to the page: [WFZjMAp... [10:24:33] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884622 (10Reedy) CentralAuthGroupMembershipProxy ``` /** * @param $name * @return CentralAuthGro... [10:25:00] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884797 (10Legoktm) @MarcoAurelio, hold on a second. Does https://meta.wikimedia.org/wiki/Special:Globa... [10:25:03] 06Wikipedia-Android-App-Backlog: Improve the message shown initially when the user first uses the app - https://phabricator.wikimedia.org/T153584#2884798 (10Kaartic) [10:25:37] Reedy: SpecialUserRights was recently refactored but I guess CA wasn't updated for it [10:25:39] 10MediaWiki-extensions-Translate, 06translatewiki.net: Translate shows the English (not the localized) description of projects - https://phabricator.wikimedia.org/T153512#2882975 (10Nikerabbit) https://translatewiki.net/w/api.php?action=query&format=json&meta=messagegroups&mgformat=flat&mgprop=id%7Cpriority%7C... [10:26:00] 10MediaWiki-extensions-Translate, 06translatewiki.net, 13Patch-For-Review: Translate shows the English (not the localized) description of projects - https://phabricator.wikimedia.org/T153512#2884815 (10Nikerabbit) a:03Nikerabbit [10:26:06] 10MediaWiki-extensions-Translate, 06translatewiki.net, 13Patch-For-Review: Translate shows the English (not the localized) description of projects - https://phabricator.wikimedia.org/T153512#2882975 (10Nikerabbit) p:05Triage>03Normal [10:26:21] legoktm: yeah, the chain is icky [10:26:37] [02:25:56] MarcoAurelio changed global group membership for Legoktm from (none) to captcha-exempt with the following comment: for debug purposes, cfr. [[phab:T153578]] [10:26:37] [02:26:07] MarcoAurelio changed global group membership for Legoktm from captcha-exempt to (none) [10:26:38] T153578: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578 [10:27:10] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884820 (10MarcoAurelio) p:05Unbreak!>03Triage Yes, with username it doesn't fatal, and it does not... [10:27:45] (03CR) 10Urbanecm: [C: 031] "Looks good for me." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/328033 (owner: 10Matěj Suchánek) [10:37:35] 10MediaWiki-Parser: Sanitizer fails to include image tags if incorrectly written as closed/void tags - https://phabricator.wikimedia.org/T48443#2884822 (10Wikinaut) @Dan.mulholland RSS feeds are coming in a "zoo" of variants - please feel free to submit a pull request if you have a working fix for... [10:44:49] 10MediaWiki-extensions-Configure, 03Google-Code-In-2016: Confirgure missing API i18n messages - https://phabricator.wikimedia.org/T153585#2884823 (10Reedy) [10:44:58] 10MediaWiki-extensions-Configure, 03Google-Code-In-2016: Confirgure missing API i18n messages - https://phabricator.wikimedia.org/T153585#2884835 (10Reedy) [10:45:16] (03CR) 10Reedy: [V: 032 C: 032] "File https://phabricator.wikimedia.org/T153585 for missing i18n messages as a GCI task" [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [10:46:28] (03CR) 10jenkins-bot: [V: 04-1] Fix path in $wgMessagesDirs [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [10:46:38] (03PS2) 10Reedy: Fix path in $wgMessagesDirs [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [10:47:54] (03CR) 10jenkins-bot: [V: 04-1] Fix path in $wgMessagesDirs [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [10:50:16] 10MediaWiki-Configuration, 13Patch-For-Review: Don't put arbitrary extension attributes in the top level extension.json schema - https://phabricator.wikimedia.org/T133627#2884837 (10Legoktm) ``` (sid)km@km-tp:~/projects/gerrit/mediawiki/extensions$ git submodule foreach "../validate.sh" | grep v2 BlockAndNuke... [10:55:09] Reedy: Can i get login page link, with return from special page? [10:56:10] 10MediaWiki-extensions-Translate, 06Discovery, 06Discovery-Search, 10Elasticsearch: Implement update freeze and/or delays for TTMServerMessageUpdateJob - https://phabricator.wikimedia.org/T132315#2884853 (10Nikerabbit) @dcausse All that sounds good to me. [10:56:18] 10Phabricator: Create acl*otrs-admins - https://phabricator.wikimedia.org/T153586#2884854 (10MarcoAurelio) [10:57:15] 10MediaWiki-extensions-Translate, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WE doesn't allow accessing the Translate extension on Meta by clicking on Edit source - https://phabricator.wikimedia.org/T153445#2880632 (10Nikerabbit) > Btw, if I open **the source** of translatable message i... [10:59:04] (03CR) 10Nikerabbit: [C: 032] Make the code for grammar data processing common [core] - 10https://gerrit.wikimedia.org/r/241645 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [11:00:47] (03PS2) 10Legoktm: [WIP] registration: Move attributes out of the top level [core] - 10https://gerrit.wikimedia.org/r/327882 (https://phabricator.wikimedia.org/T133627) [11:01:54] How can i html parse text, with given argument? [11:03:37] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Newsletter: Should newsletter be storing in data both in contenthandler and in the database - https://phabricator.wikimedia.org/T153532#2884875 (10Legoktm) In general storing data from the page in the database is fine as long as the page is the primary source,... [11:06:42] (03Merged) 10jenkins-bot: Make the code for grammar data processing common [core] - 10https://gerrit.wikimedia.org/r/241645 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [11:08:56] (03CR) 10jenkins-bot: [V: 04-1] [WIP] registration: Move attributes out of the top level [core] - 10https://gerrit.wikimedia.org/r/327882 (https://phabricator.wikimedia.org/T133627) (owner: 10Legoktm) [11:10:18] (03PS8) 10Amire80: Move the Ukrainian grammar rules from PHP and JS to JSON [core] - 10https://gerrit.wikimedia.org/r/245184 (https://phabricator.wikimedia.org/T115217) [11:12:42] 10MediaWiki-extensions-Gadgets, 07User-notice: The CSS of each gadget is included two times - https://phabricator.wikimedia.org/T42284#2884889 (10Billinghurst) >>! In T42284#2883274, @Krinkle wrote: >>>! In T42284#2868044, @Billinghurst wrote: >> can we please also have a message to the wikitech-ambassadors wi... [11:13:23] (03PS2) 10Seb35: Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 [11:14:36] (03CR) 10jenkins-bot: [V: 04-1] Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 (owner: 10Seb35) [11:19:58] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2791764 (10FilipGCI) @01tonythomas SpecialNewsletter.php uses form instead of addHTML. How can i append html to... [11:23:28] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:23:36] (03PS2) 10LukBukkit: Removed usages of a deprecated method: Revision::getText [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) [11:24:54] 10MediaWiki-extensions-Translate, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WE doesn't allow accessing the Translate extension on Meta by clicking on Edit source - https://phabricator.wikimedia.org/T153445#2884899 (10IKhitron) >>! In T153445#2884866, @Nikerabbit wrote: >> Btw, if I ope... [11:34:24] (03PS3) 10Seb35: Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 [11:41:30] (03CR) 10LukBukkit: [] Removed usages of a deprecated method: Revision::getText (031 comment) [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:41:33] (03CR) 10Amire80: [] "This should be ready for merging, now that I5e75467121c3d791bb84f9e6fdfcf07c1840f81a is finally merged :)" [core] - 10https://gerrit.wikimedia.org/r/245184 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [11:43:39] 10MediaWiki-extensions-Translate, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WE doesn't allow accessing the Translate extension on Meta by clicking on Edit source - https://phabricator.wikimedia.org/T153445#2884910 (10Nikerabbit) Are we talking about the same thing? https://www.mediawik... [11:47:09] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2862787 (10Volker_E) [11:49:56] (03CR) 10Seb35: [C: 032] Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 (owner: 10Seb35) [11:51:14] (03Merged) 10jenkins-bot: Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 (owner: 10Seb35) [11:52:10] 10MediaWiki-Configuration, 10MediaWiki-JobQueue, 13Patch-For-Review: Turn $wgRunJobsAsync off by default - https://phabricator.wikimedia.org/T142751#2884915 (10Ciencia_Al_Poder) MediaWiki 1.28 .0, and 1660523 pending jobs: [[ https://www.mediawiki.org/wiki/Topic:The8wby7f7wmq1q1 | Topic:The8wby7f7wmq1q1 ]].... [11:56:05] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:56:19] (03PS2) 10LukBukkit: Removed usages of a deprecated method: Revision::getText [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) [11:58:06] 10Navigation-Popups: Hovering over citations show the preview shown by wikipedia and that of Navigation Pop-up - https://phabricator.wikimedia.org/T153587#2884919 (10Kaartic) [12:02:08] (03PS1) 10Filip: Added anonymous user warning message [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328041 (https://phabricator.wikimedia.org/T150637) [12:02:12] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:02:26] (03PS2) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) [12:04:41] (03PS3) 10Martineznovo: Turn $wgRunJobsAsync off by default [core] - 10https://gerrit.wikimedia.org/r/306667 (https://phabricator.wikimedia.org/T142751) [12:09:47] (03CR) 10Legoktm: [C: 032] Move TempFileRepo to a separate file [core] - 10https://gerrit.wikimedia.org/r/327909 (owner: 10Aaron Schulz) [12:15:45] (03CR) 10Filip: [C: 031] "Looks good" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:17:41] (03CR) 10Filip: [C: 04-1] "@LukBukkit - Always follow wikimedia guidelines. Lots of these extensions have really bad code." [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:18:38] (03Merged) 10jenkins-bot: Move TempFileRepo to a separate file [core] - 10https://gerrit.wikimedia.org/r/327909 (owner: 10Aaron Schulz) [12:18:58] (03CR) 10Filip: [C: 031] "Looks good" [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:29:28] (03Draft2) 10Matěj Suchánek: Improve interface for users who cannot modify filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327491 [12:34:28] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current clients which use thumb URLs as an API - https://phabricator.wikimedia.org/T153498#2882530 (10Nemo_bis) Special:Redirect/file is still kosher, right? A simple `ack-grep --js --php "/thumb"` in mediawiki/extensions already finds some int... [12:38:25] (03CR) 10Legoktm: [C: 032] "OK. We probably should have done this long ago, and a backport to REL1_27 seems reasonable to me." [core] - 10https://gerrit.wikimedia.org/r/306667 (https://phabricator.wikimedia.org/T142751) (owner: 10Martineznovo) [12:43:36] (03CR) 10Legoktm: [C: 032] mw.htmlform: Fields hidden with 'hide-if' should be disabled [core] - 10https://gerrit.wikimedia.org/r/311463 (https://phabricator.wikimedia.org/T145440) (owner: 10Bartosz Dziewoński) [12:46:48] (03PS2) 10Legoktm: Rewrite importImages.php to use Maintenance infrastructure [core] - 10https://gerrit.wikimedia.org/r/327860 (owner: 10MaxSem) [12:47:49] (03CR) 10Legoktm: [C: 032] "PS2: Add to autoload.php using the script, and fix the one space caught by PHPCS." [core] - 10https://gerrit.wikimedia.org/r/327860 (owner: 10MaxSem) [12:48:20] (03PS3) 10Legoktm: Remove unused Phan exception [core] - 10https://gerrit.wikimedia.org/r/327783 (owner: 10MaxSem) [12:49:21] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method: Revision::getText [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:49:35] (03Merged) 10jenkins-bot: Turn $wgRunJobsAsync off by default [core] - 10https://gerrit.wikimedia.org/r/306667 (https://phabricator.wikimedia.org/T142751) (owner: 10Martineznovo) [12:49:38] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:50:39] (03CR) 10Reedy: [] "It's a hard one, generally, writing new, you follow WMF guidelines" [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:50:55] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method: Revision::getText [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:56:14] (03Merged) 10jenkins-bot: mw.htmlform: Fields hidden with 'hide-if' should be disabled [core] - 10https://gerrit.wikimedia.org/r/311463 (https://phabricator.wikimedia.org/T145440) (owner: 10Bartosz Dziewoński) [12:56:31] (03CR) 10jenkins-bot: [V: 04-1] HTMLFormFieldCloner: Set 'formnovalidate' on add/remove field buttons [core] - 10https://gerrit.wikimedia.org/r/324950 (owner: 10Bartosz Dziewoński) [12:56:39] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Use 'mw-htmlform' CSS class [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [12:58:16] (03Merged) 10jenkins-bot: Rewrite importImages.php to use Maintenance infrastructure [core] - 10https://gerrit.wikimedia.org/r/327860 (owner: 10MaxSem) [12:58:20] (03Merged) 10jenkins-bot: Removed usages of a deprecated method: Revision::getText [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:58:22] (03Merged) 10jenkins-bot: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:58:24] (03Merged) 10jenkins-bot: Removed usages of a deprecated method: Revision::getText [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [12:58:28] (03PS2) 10Legoktm: HTMLFormFieldCloner: Set 'formnovalidate' on add/remove field buttons [core] - 10https://gerrit.wikimedia.org/r/324950 (owner: 10Bartosz Dziewoński) [12:58:40] (03CR) 10Legoktm: [C: 032] "Try again..." [core] - 10https://gerrit.wikimedia.org/r/324950 (owner: 10Bartosz Dziewoński) [12:59:08] (03PS2) 10Legoktm: HTMLForm: Use 'mw-htmlform' CSS class [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [12:59:13] (03CR) 10Legoktm: [C: 032] HTMLForm: Use 'mw-htmlform' CSS class [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [13:09:39] (03Merged) 10jenkins-bot: HTMLFormFieldCloner: Set 'formnovalidate' on add/remove field buttons [core] - 10https://gerrit.wikimedia.org/r/324950 (owner: 10Bartosz Dziewoński) [13:09:45] (03CR) 10jenkins-bot: [V: 04-1] HTMLForm: Use 'mw-htmlform' CSS class [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [13:12:42] tonythomas, are you here? [13:16:44] (03CR) 10MtDu: [C: 04-1] "You need to also remove the unused message from the qqq.json file. :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) (owner: 10Georggi199) [13:17:43] (03CR) 10Legoktm: [C: 032] "..." [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [13:18:06] (03CR) 10Legoktm: [C: 032] Remove unused Phan exception [core] - 10https://gerrit.wikimedia.org/r/327783 (owner: 10MaxSem) [13:21:57] (03CR) 10Legoktm: [] Pull rendering of single result out of SpecialSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [13:24:04] (03PS3) 10Georggi199: Removed usage of old SpecialPage code for viewing the page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) [13:25:10] 10MediaWiki-extensions-Translate, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017WE doesn't allow accessing the Translate extension on Meta by clicking on Edit source - https://phabricator.wikimedia.org/T153445#2884971 (10IKhitron) OK, here is the scenario: # Opt in NWE. # Open [[https://me... [13:27:58] (03Abandoned) 10Jack Phoenix: Add a hook to AbuseFilter::filterAction() to allow other extensions to tell AF to exit early [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/318786 (owner: 10Jack Phoenix) [13:32:03] (03Merged) 10jenkins-bot: HTMLForm: Use 'mw-htmlform' CSS class [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [13:32:06] (03CR) 10jenkins-bot: [V: 04-1] Remove unused Phan exception [core] - 10https://gerrit.wikimedia.org/r/327783 (owner: 10MaxSem) [13:38:25] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2884972 (10Reedy) Article::getContent() ```lines=10 Method get... [13:46:58] 10MediaWiki-API, 07Wikimedia-log-errors: Undefined index: spam in ApiEditPage:: execute() - https://phabricator.wikimedia.org/T153590#2884985 (10Dereckson) [13:53:54] 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: MapCacheLRU::has called with invalid key exception in CentralAuthUser::getInstanceByName - https://phabricator.wikimedia.org/T153591#2884999 (10Dereckson) [13:55:59] 10MediaWiki-extensions-Configure, 03Google-Code-In-2016: Configure missing API i18n messages - https://phabricator.wikimedia.org/T153585#2885012 (10Wargo) [13:56:37] tonythomas: Are yoy there? [13:56:54] rlot: Georggi : sorry for the delay, but right now I am! [13:56:57] (03PS2) 10Cenarium: Pass undone revision id to PageContentSaveComplete hook [core] - 10https://gerrit.wikimedia.org/r/328027 [13:57:19] tonythomas: Can you look at GCI site? [13:57:36] tonythomas, well, MtDu already helped with i18n message description, so you can just check the latest PS [13:57:50] rlot: right. Georggi: great [13:58:35] tonythomas: Georggi: Thanks for deleting this "doViewExecute", i lost 1hr, on trying to understand where is this view generating [13:59:02] 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: MapCacheLRU::has called with invalid key exception in CentralAuthUser::getInstanceByName - https://phabricator.wikimedia.org/T153591#2885013 (10Dereckson) [14:00:13] 10MediaWiki-Page-editing, 10ProofreadPage, 06Wikisource: Editing toolbar corrupt for Page namespace - https://phabricator.wikimedia.org/T151726#2885014 (10Pikne) p:05Triage>03Normal [14:00:26] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2885017 (10waldyrious) In case this helps, I am also using Firefox (50.1.0) and have the uBlock extension installed. [14:01:22] tonythomas: Code was made, for providing link via $1 argument. But if you wish to hard code link in en.json, i can edit the code [14:02:22] rlot: I will need a bit more time processing that one. Let me review https://gerrit.wikimedia.org/r/#/c/328023 in a minute [14:05:28] (03CR) 10jenkins-bot: [V: 04-1] Pass undone revision id to PageContentSaveComplete hook [core] - 10https://gerrit.wikimedia.org/r/328027 (owner: 10Cenarium) [14:14:30] (03CR) 1001tonythomas: [C: 032] "Works. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) (owner: 10Georggi199) [14:15:07] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2885048 (1001tonythomas) [14:15:09] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Remove default view (Special:Newsletter/id/) code from SpecialNewsletter.php - https://phabricator.wikimedia.org/T152678#2885046 (1001tonythomas) 05Open>03Resolved Works. Thank you for the patch! [14:15:33] (03Merged) 10jenkins-bot: Removed usage of old SpecialPage code for viewing the page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) (owner: 10Georggi199) [14:16:17] Georggi: ^^ ' [14:17:29] rlot: will check https://gerrit.wikimedia.org/r/#/c/328041/ [14:17:35] (03CR) 10Legoktm: "Hmmm, so Gratitude was being used in an extension, see T153555, and that's now fataling due to the missing icon." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264140 (owner: 10Catrope) [14:17:52] tonythomas: Ok! Thanks [14:23:46] tonythomas, thanks for that! [14:24:27] (03CR) 10Cenarium: [] "recheck" [core] - 10https://gerrit.wikimedia.org/r/328027 (owner: 10Cenarium) [14:40:12] (03CR) 10Prtksxna: [C: 04-1] "Hey pppery! Thanks for submitting the patch. The code looks great, but I noticed that some of it isn't following mediawiki coding conventi" [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [14:45:07] rlot: around ? [14:45:44] I think we need to stick with the existing warning message template, rather than creating in a new one [14:45:57] like - take a look at going to Special:Preferences on being logged out [14:46:24] or is there some other use case when this show up somewhere else in MW ? We could've copied the style [14:46:44] to know that one - you might want to ask it here (less chance due to Sunday) or even Mail to wikitech-l [14:47:06] (03PS3) 10Cenarium: Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) [14:47:31] 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: MapCacheLRU::has called with invalid key exception in CentralAuthUser::getInstanceByName - https://phabricator.wikimedia.org/T153591#2884999 (10MarcoAurelio) Related T153578 ? [14:49:32] tonythomas: But main code is made correctly? I used wikibase-like message [14:50:11] tonythomas: All warnings in wikibase is made like that [14:52:45] (03CR) 10jenkins-bot: [V: 04-1] Get undone revision id from hook param instead of request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [14:53:39] (03CR) 10Raimond Spekking: [C: 032] Add Czech aliases for special pages [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/328033 (owner: 10Matěj Suchánek) [14:54:32] tonythomas: So it should just show login prompt? [14:54:50] (03Merged) 10jenkins-bot: Add Czech aliases for special pages [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/328033 (owner: 10Matěj Suchánek) [14:56:01] rlot: I dont think you will haveto show up the login-prompt. No. I need somone else to look at the output. Reedy legoktm around ? [14:56:17] legoktm: Can you look at? [14:56:31] (03CR) 10Cenarium: [] "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/328028 (https://phabricator.wikimedia.org/T153567) (owner: 10Cenarium) [14:57:02] tonythomas: Can i just make message like in UserNotLoggedIn msg? [14:59:30] (03PS1) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:00:59] (03PS2) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:01:17] rlot: can you upload a screenshot (of the existing patch thing) and UserNotLoggedIn message to the task ? I can get others to take a look at it fast [15:01:39] tonythomas: I can make it in a box [15:02:22] (03PS3) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:03:09] tonythomas: Sended [15:03:14] sent [15:03:17] * [15:03:28] rlot: can you paste it to the phab task ? [15:03:32] Ok [15:04:10] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:04:13] 10MediaWiki-User-login-and-signup: Logging me out - https://phabricator.wikimedia.org/T153571#2885087 (10Bbb23) I use Windows 7 (64bit, home) and the latest version of Chrome. The link to the Pump is the latest link, but I brought this up first in October of this year at https://en.wikipedia.org/wiki/Wikipedia:... [15:04:30] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885088 (10FilipGCI) {F5093856} Sending how message look like. I can made it to use NoUserL... [15:04:42] tonythomas: I'll use no user logged exception. Give me sec [15:05:57] (03PS4) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:07:41] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2885090 (10PratyyaGhosh) [15:08:05] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:10:54] (03PS5) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:12:49] tonythomas: So what should I do? Should i replace this warning with some method? [15:13:38] rlot: can you past the other one too (like using UserNotLoggedIn thingy) ? [15:14:40] tonythomas: I don't have this done now, UserNotLoggedIn redirects to the login page, i'm trying to get how it shows this message, but i can find SpecialUserLogin, lots of them is deprecated [15:16:03] 10MediaWiki-extensions-FlaggedRevs, 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs: Unapproved article version shown in mobile apps - https://phabricator.wikimedia.org/T153595#2885093 (10Tacsipacsi) [15:16:38] rlot: there is a better way to fix this one though :D [15:16:46] tonythomas: ? [15:17:00] (03PS1) 10Urbanecm: Add Czech aliases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 [15:17:12] (03PS6) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:17:46] rlot: how about showing up that subscribe button on top in subtitles and the navbar even when the user is not logged in, and when the user clicks on it, he gets to UserLogin and shows that exception ('that login is necessary to subscribe to things'). Right now a non-logged in user might not even know that they can subscribe to a newsletter frankly [15:17:55] (03PS7) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:17:59] I think that would be more clean. [15:19:13] (03PS8) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:20:36] (03PS2) 10Pppery: Add `showThumbnails` option to slideshow galleries [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) [15:20:47] (03CR) 10Matěj Suchánek: [C: 04-1] Add Czech aliases (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [15:20:51] tonythomas: I think warning message is a bit more clean to do that, subscribe button is hidden to anon user, shouldnt show it again, and show prompt. I'll add that message [15:21:18] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:21:22] (03CR) 10Pppery: [] "Fixed the use of double-quotes in PHP and a missing space in JavaScript." [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [15:22:00] (03PS1) 10Urbanecm: Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 [15:22:00] rlot: I am not sure, as we will have to find in extra space on top for this one (when we already have a navbar there). [15:22:15] (03PS9) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:22:30] anyway. you can explore and uplod the screenshots. Someone who got mind in designs would check it out! [15:22:43] (03CR) 10jenkins-bot: [V: 04-1] Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [15:23:02] tonythomas: If we have navbar there, user will be logged in. So it shouldn't show [15:23:44] 10MediaWiki-extensions-FlaggedRevs, 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs: Unapproved article version shown in mobile apps - https://phabricator.wikimedia.org/T153595#2885106 (10Tacsipacsi) [15:23:59] (03PS2) 10Urbanecm: Add Czech aliases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 [15:24:09] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:24:16] rlot: navbar == navbar of our newsletter extension! we do not have that coming up currently for non-logged in users. Just have one button saying ('Subscribe') [15:24:18] and that would do [15:24:57] (03CR) 10Urbanecm: [] "Fixed in PS2." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [15:25:04] (03PS10) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:25:07] tonythomas: I'll upload this solution, can't find userlogin warning msg [15:26:13] (03PS2) 10Urbanecm: Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 [15:26:42] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:28:17] (03PS11) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:28:53] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885107 (10QuimGil) Just a minor thing: the dot at the end of the sentence is missing. :)... [15:30:16] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:30:41] 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: MapCacheLRU::has called with invalid key exception in CentralAuthUser::getInstanceByName - https://phabricator.wikimedia.org/T153591#2884999 (10Krenair) Yeah, at first glance it appears to be a dupe [15:31:34] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885110 (1001tonythomas) I had this in mind too: `tonythomas> rlot: how about showing up... [15:32:39] (03CR) 10Matěj Suchánek: [C: 04-1] Add Czech aliases (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [15:33:52] (03CR) 10Urbanecm: [] Add Czech aliases (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [15:34:16] (03PS12) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:34:53] tonythomas: Thats already implemented. Just removed the test statement [15:35:49] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885111 (10QuimGil) Mmmaybe, but I would agree the right approach with a designer before ad... [15:36:20] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:36:47] (03CR) 10Matěj Suchánek: [] Add Czech aliases (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [15:37:07] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885112 (10FilipGCI) >>! In T150637#2885110, @01tonythomas wrote: > I had this in mind too:... [15:38:36] (03PS13) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:39:40] (03CR) 10Matěj Suchánek: [C: 04-1] Add Czech aliases (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [15:40:12] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:41:09] rlot: I would stick to what Quim says anyway! Design feedback is always a mess. [15:41:40] tonythomas: Should i use this login prompt solution? [15:41:47] Its just removing if statement [15:42:00] But this message is design correct [15:42:05] Used in wikibase [15:42:13] rlot: can you just do that, and explain it with screenshot in the phab, so that people can take al ook / [15:42:47] (03PS3) 10Urbanecm: Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 [15:43:05] tonythomas: Do you know where warnings are also used? I cant find anything in code [15:43:13] Or where is loginprompt class [15:43:17] (03CR) 10Urbanecm: [] "Removed in PS3." (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [15:43:42] Reedy: Are you there? How should i propertly show warning message? [15:43:50] with these borders [15:43:52] (03PS14) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:44:20] rlot: I see this https://doc.wikimedia.org/mediawiki-core/master/php/classSpecialPage.html#ae39687061d16b5e6b550453003477703 [15:44:33] (03PS3) 10Urbanecm: Add Czech aliases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 [15:44:33] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2885115 (10QuimGil) [15:44:37] You can just put the message in there [15:44:47] tonythomas: Its already implemented [15:44:51] (03CR) 10Urbanecm: [] Add Czech aliases (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [15:45:10] tonythomas: If ill remove this if statement, it will show this prompt [15:45:17] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#1309329 (10QuimGil) @01tonythomas I wonder whether the implementation of this feature could be sliced in different GCi tasks? [15:45:21] rlot: okey - then what were you asking in "Do you know where warnings are also used? I cant find anything in code" ? [15:45:28] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:45:32] tonythomas: Its redirect [15:45:41] tonythomas: It doesnt show message in page [15:45:45] rlot: it woudl automatically redirect, as per the documetnation [15:46:11] tonythomas: but that is already in code. ] [15:46:22] rlot: it would redirect, and show the message in a box above the user login form. [15:46:46] rlot: If you are showing that in Newsletter page, better not have the box please. [15:47:02] Ok, i'll commit it in another patch. Thats just removing if [15:47:23] Alright. or maybe just paste a screenshot [15:47:29] (03PS15) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:48:00] Login prompt after subscribe button is already implemented. Its just not used becouse of if [15:48:03] tonythomas: [15:48:29] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885119 (10QuimGil) If it's implemented... let's try it out? [15:48:54] (03PS16) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:48:57] rlot: if you can be more specific (like which if, with a reference to the line in Github, I might be able to be more specific as well) :D [15:49:09] I'll make a patch [15:50:31] (03PS17) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:52:01] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:52:12] (03PS18) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:53:58] (03PS1) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [15:54:36] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [15:56:04] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2885121 (10FilipGCI) @QuimGil @01tonythomas Commited 2 solutions, choose one. Heres scree... [15:56:15] tonythomas: Made 2 solutions, choose one [15:56:34] (03PS19) 10Paladox: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 [15:59:48] tonythomas: So with solution do you prefer? [16:01:04] (03CR) 10Paladox: [C: 032] build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [16:01:54] (03Merged) 10jenkins-bot: build: Replace jshint and jscs with eslint [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/328045 (owner: 10Paladox) [16:01:55] (03CR) 10Filip: [] "Alternative solution: https://gerrit.wikimedia.org/r/#/c/328041/" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [16:02:01] (03PS8) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [16:02:10] (03CR) 10Filip: [] "Alternative solution: https://gerrit.wikimedia.org/r/#/c/328048/" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328041 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [16:05:20] (03CR) 10Filip: [C: 04-1] Add `showThumbnails` option to slideshow galleries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [16:08:58] (03CR) 10Pppery: [] "That doesn't seem to be the style used in other parts of the code for galleries" [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [16:12:28] (03CR) 10Filip: [C: 04-1] "Look at getModules( . But code looks good" [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [16:22:40] tonythomas: Can you merge of of them? [16:26:43] (03CR) 10Bartosz Dziewoński: "\o/" [core] - 10https://gerrit.wikimedia.org/r/311463 (https://phabricator.wikimedia.org/T145440) (owner: 10Bartosz Dziewoński) [16:27:20] (03PS4) 10Bartosz Dziewoński: HTMLForm: Suppress HTML5 form validation for non-JS users when needed [core] - 10https://gerrit.wikimedia.org/r/324951 [16:30:40] (03PS1) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 [16:33:09] (03CR) 10Pppery: [] "That's a completely different use of the [ character for defining an array rather than accessing an element of one." [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) (owner: 10Pppery) [16:33:54] (03PS2) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 [16:35:48] 10MediaWiki-General-or-Unknown, 10Wikimedia-General-or-Unknown, 07Browser-Support-Internet-Explorer: Drop Grade C support for IE8 - https://phabricator.wikimedia.org/T136203#2326583 (10matmarex) I think we shouldn't do this for at least a few more years. Wikimedia wikis aim to provide the "sum of human knowl... [16:36:43] 10Phabricator: Create acl*otrs-admins - https://phabricator.wikimedia.org/T153586#2885140 (10Aklapper) For the records, could someone link to a place where an "OTRS NDA on Legalpad" has been discussed / brought up? [16:37:15] 10MediaWiki-HTMLForm, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): An invalid form control with name='NAME' is not focusable. - https://phabricator.wikimedia.org/T145440#2885141 (10matmarex) 05Open>03Resolved [16:38:08] (03CR) 10Bartosz Dziewoński: [] "T145440 is fixed now. This should be safe to merge." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/205720 (https://phabricator.wikimedia.org/T96154) (owner: 10MarkTraceur) [16:40:28] (03CR) 10jenkins-bot: [V: 04-1] Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (owner: 10Paladox) [16:41:35] (03CR) 10Paladox: [] "recheck" [core] - 10https://gerrit.wikimedia.org/r/328049 (owner: 10Paladox) [16:43:51] (03PS6) 10Bartosz Dziewoński: Html: Unblacklist HTML5 form validation attributes [core] - 10https://gerrit.wikimedia.org/r/323408 [16:44:25] (03CR) 10Bartosz Dziewoński: [] "Rebased. All of the issues should be fixed by previous commits." [core] - 10https://gerrit.wikimedia.org/r/323408 (owner: 10Bartosz Dziewoński) [16:44:35] (03PS5) 10Bartosz Dziewoński: HTMLDateTimeField: Remove hacks for HTML5 form validation attributes [core] - 10https://gerrit.wikimedia.org/r/323409 [16:45:16] (03PS18) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [16:45:22] (03CR) 10jenkins-bot: [V: 04-1] Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [16:46:12] (03PS3) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 [16:46:19] (03CR) 10Huji: [C: 04-1] "Per Legoktm:" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [16:46:37] (03PS4) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) [16:46:49] (03CR) 10Bartosz Dziewoński: [] "Why do we need to do this? We already pin the version of grunt-eslint. And we did not do this for JSHint or JSCS in the past." [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [16:49:18] (03PS19) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [16:49:30] (03CR) 10Paladox: [] "@Bartosz Dziewoński hi, because jshint and jscs pined there versions but we did pin it as we did not specifify ^. grunt-eslint on the othe" [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [16:49:59] (03PS8) 10Bartosz Dziewoński: Use new OOUI display format in most forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/205720 (https://phabricator.wikimedia.org/T96154) (owner: 10MarkTraceur) [16:50:14] (03CR) 10Bartosz Dziewoński: [] "(Rebased.)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/205720 (https://phabricator.wikimedia.org/T96154) (owner: 10MarkTraceur) [16:50:23] (03CR) 10Paladox: [] "See https://github.com/sindresorhus/grunt-eslint/blob/master/package.json#L33" [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [16:51:52] (03CR) 10jenkins-bot: [V: 04-1] Html: Unblacklist HTML5 form validation attributes [core] - 10https://gerrit.wikimedia.org/r/323408 (owner: 10Bartosz Dziewoński) [16:51:58] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase, someone changed all the code to short array syntax :(" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/309924 (https://phabricator.wikimedia.org/T96154) (owner: 10Gergő Tisza) [16:52:03] 10Phabricator: Create acl*otrs-admins - https://phabricator.wikimedia.org/T153586#2885146 (10MarcoAurelio) What do you mean? OTRS agents have to sign an NDA in Phabricator since about a year or so prior to be given access, so this is not new. The agreement in English is L23 IIRC (there are several translations)... [16:52:55] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/311463 (https://phabricator.wikimedia.org/T145440) (owner: 10Bartosz Dziewoński) [16:53:40] (03PS20) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [16:53:57] (03CR) 10jenkins-bot: [V: 04-1] HTMLDateTimeField: Remove hacks for HTML5 form validation attributes [core] - 10https://gerrit.wikimedia.org/r/323409 (owner: 10Bartosz Dziewoński) [16:54:18] (03CR) 10jenkins-bot: [V: 04-1] Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [16:55:11] (03CR) 10Huji: [C: 04-1] "Per Legoktm:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [16:57:18] (03CR) 1001tonythomas: [C: 04-1] "Please also show in the Newsletter subtitles link too!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328041 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [16:58:17] 10MediaWiki-General-or-Unknown, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure: mediawiki-extensions-qunit-jessie tests are failing - https://phabricator.wikimedia.org/T153597#2885148 (10Paladox) [16:58:58] (03CR) 1001tonythomas: [] "^^ That was for your other patch. Sorry!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328041 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [16:59:04] 10MediaWiki-General-or-Unknown, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure: mediawiki-extensions-qunit-jessie tests are failing - https://phabricator.wikimedia.org/T153597#2885160 (10Paladox) p:05Triage>03Unbreak! Changing to unbreak as it is causing a patch I uploaded to fa... [17:00:08] (03CR) 1001tonythomas: [C: 04-1] "Can you check why its not showing up in the newsletter subtitles link ?" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [17:00:59] (03PS1) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/328050 [17:03:43] (03Abandoned) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/328050 (owner: 10Paladox) [17:04:09] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [17:08:11] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2885163 (10Dereckson) p:05Triage>03Normal [17:08:38] 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: MapCacheLRU::has called with invalid key exception in CentralAuthUser::getInstanceByName - https://phabricator.wikimedia.org/T153591#2885170 (10Dereckson) [17:08:40] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: Fatal exception at Special:GlobalUserRights on Meta-Wiki - https://phabricator.wikimedia.org/T153578#2884622 (10Dereckson) [17:09:00] (03CR) 10Paladox: [] "recheck" [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [17:09:09] 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Regression, 07Wikimedia-log-errors: 'MapCacheLRU::has called with invalid key' exception in CentralAuthUser::getInstanceByName at [[Special:GlobalUserRights]] - https://phabricator.wikimedia.org/T153578#2884622 (10Dereckson) [17:09:25] 10MediaWiki-extensions-CentralAuth, 07Wikimedia-log-errors: MapCacheLRU::has called with invalid key exception in CentralAuthUser::getInstanceByName - https://phabricator.wikimedia.org/T153591#2884999 (10Dereckson) Thanks to have noticed that. [17:12:32] 10Phabricator: Create acl*otrs-admins - https://phabricator.wikimedia.org/T153586#2884854 (10Krenair) Is this something that needs legal approval then? [17:14:53] 10MediaWiki-General-or-Unknown, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure: mediawiki-extensions-qunit-jessie tests are failing - https://phabricator.wikimedia.org/T153597#2885175 (10Paladox) [17:15:05] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/327947 (owner: 10L10n-bot) [17:16:46] (03CR) 10jenkins-bot: [V: 04-1] Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [17:28:08] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [17:28:14] (03PS2) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) [17:30:21] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [17:30:25] (03PS2) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) [17:33:17] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [17:33:23] (03PS2) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) [17:39:19] (03Restored) 10LukBukkit: Removed usages of the deprecated method Revision::getText [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [17:39:25] (03PS2) 10LukBukkit: Removed usages of the deprecated method Revision::getText [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) [17:48:14] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/327947 (owner: 10L10n-bot) [17:51:00] (03PS5) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) [17:53:39] (03PS2) 10Umherirrender: Add npm entry point and banana i18n linter [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [17:54:45] (03PS6) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) [17:56:08] (03CR) 10Paladox: [] "check experimental" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [17:56:12] (03CR) 10Paladox: [C: 031] Add npm entry point and banana i18n linter [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [17:56:19] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2885189 (10jcrespo) > Quite frankly I received very mixed messages when I was working on this change. First it was totally ok, then the cha... [17:56:38] (03CR) 10Umherirrender: [C: 032] Add npm entry point and banana i18n linter [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [17:57:48] (03Merged) 10jenkins-bot: Add npm entry point and banana i18n linter [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [17:58:36] tonythomas: Are you there? [17:58:48] What is "subtitles link"? [17:59:28] rlot: the one like "← List of newsletters | CustomOne (unsubscribe | announce | manage)" in http://newsletter-test.wmflabs.org/wiki/Newsletter:CustomOne [18:02:49] (03PS2) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [18:02:59] tonythomas: Got it [18:04:40] tonythomas: Will you merge this, or my prev. patch? [18:05:00] rlot: I am more to this one (personally) though [18:05:25] tonythomas: But both are made propertly? Can you submit it on GCI? [18:05:50] 10MediaWiki-Page-editing, 10ProofreadPage, 06Wikisource: Editing toolbar corrupt for Page namespace - https://phabricator.wikimedia.org/T151726#2885192 (10Aklapper) Hi @Pikne, thanks for taking the time to report this! Please provide a link that allows others to reproduce the problem. [18:06:31] rlot: I can approve it after it gets merged, yes [18:06:50] tonythomas: What patch will you merge? [18:07:22] tonythomas: I should abadon the other solution [18:07:42] rlot: I am more to this one (personally) though == https://gerrit.wikimedia.org/r/#/c/328048/ [18:08:16] 10MediaWiki-History-or-Diffs, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10UI-Standardization, and 2 others: Gray used in .autocomment in RC and watchlist is not accessible against background - https://phabricator.wikimedia.org/T125657#1993770 (10Ladsgroup) I think we should go `#54595d`. The contr... [18:08:48] tonythomas: Ok, i made commit [18:15:08] (03CR) 1001tonythomas: [C: 04-1] "Comments inline" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [18:15:43] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method Revision::getText [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:15:57] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method Revision::getText [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:16:25] (03CR) 10Reedy: [C: 032] Removed usages of a deprecated method Revision::getText [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:16:37] (03CR) 10Reedy: [C: 032] Removed usages of the deprecated method Revision::getText [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:17:24] (03Merged) 10jenkins-bot: Removed usages of a deprecated method Revision::getText [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:17:33] (03Merged) 10jenkins-bot: Removed usages of a deprecated method Revision::getText [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:17:45] (03Merged) 10jenkins-bot: Removed usages of a deprecated method Revision::getText [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:17:47] (03Merged) 10jenkins-bot: Removed usages of the deprecated method Revision::getText [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [18:18:04] 10MediaWiki-Page-editing, 10ProofreadPage, 06Wikisource: Editing toolbar corrupt for Page namespace - https://phabricator.wikimedia.org/T151726#2885201 (10Aklapper) (Oh well, ignore my last comment, I now saw that this is about https://et.wikisource.org ) [18:31:26] 10BetaFeatures, 10Hovercards: "MediaWiki:Popups-desc" should have a period - https://phabricator.wikimedia.org/T153599#2885220 (10Guycn2) [18:41:14] (03PS3) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [18:41:29] tonythomas: Made commit [18:43:00] (03CR) 10Bartosz Dziewoński: [C: 031] "I see, that sounds reasonable." [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [18:44:18] (03CR) 10Paladox: [] "Note: We have to specify it twice due to peerDependencies being deprecated in npm 3. This is a workaround to get it to install on npm3 and" [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [18:45:16] (03PS4) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [18:45:37] tonythomas: Fixed indent [18:46:43] (03PS5) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [18:50:13] tonythomas: Ok, I think its a final commit [19:01:56] 06Stewards-and-global-tools, 10Wikimedia-General-or-Unknown: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2879998 (10Ibrahim.ID) this error also in Arabic language users, they can't create a new account due Title blacklist ! [19:02:22] 06Stewards-and-global-tools, 10Wikimedia-General-or-Unknown: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2885235 (10Ibrahim.ID) p:05High>03Triage [19:05:20] tonythomas: Are you there? [19:07:58] 06Stewards-and-global-tools, 10Wikimedia-General-or-Unknown: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2879998 (10matmarex) This is because the namespace name for 'User' in Sindhi ('يوزر') matches the regexp. @ibrahim.id https://a... [19:14:27] 06Stewards-and-global-tools, 10Wikimedia-General-or-Unknown: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2885239 (10matmarex) This edit should resolve the problem: https://meta.wikimedia.org/w/index.php?title=Title_blacklist&diff=161... [19:18:15] 10Comments, 10Social-Tools, 10SocialProfile, 07Technical-Debt: SocialProfile UserBoard module's commenting system is very similar to the Comments extension - https://phabricator.wikimedia.org/T153520#2885240 (10SamanthaNguyen) p:05Triage>03Lowest Well, I'm a bit optimistic(perhaps idealistic?), so I'll... [19:34:37] 06Stewards-and-global-tools, 10Wikimedia-General-or-Unknown: Title blacklist entry on Meta blocks creating any account on Sindhi Wikipedia - https://phabricator.wikimedia.org/T153420#2885258 (10Aklapper) p:05Triage>03High @Ibrahim.ID: Why did you reset the Priority field? Setting back to High... [19:38:47] 10Phabricator (Upstream), 07Upstream: User "edited a custom field" - https://phabricator.wikimedia.org/T127584#2885270 (10Aklapper) 05Open>03Resolved a:03Aklapper No reply hence assuming this is obsolete. [19:39:10] 10Phabricator, 10Phabricator (Upstream), 07Upstream: Phabricator should only notify changes to the "Is Sprint" field if it is indeed changed - https://phabricator.wikimedia.org/T94155#2885273 (10Aklapper) 05Open>03Resolved a:03Aklapper No reply hence assuming this is obsolete. [19:39:27] tonythomas: Are you there [19:40:29] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2885276 (1001tonythomas) >>! In T100277#2885115, @QuimGil wrote: > @01tonythomas I wonder whether the implementation of this feature could be sliced in different GCi tasks? I need to get... [19:40:47] rlot: just came back! let me take a look [19:41:20] 06Developer-Relations, 07I18n: Offering internationalized programming facilities within WM enviroment - https://phabricator.wikimedia.org/T150933#2885280 (10Aklapper) >>! In T150933#2805747, @Aklapper wrote: > These all sound like very broad general questions to ask on a mailing list (like wikitech-l) or on IR... [19:41:39] (03PS85) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [19:41:47] (03PS86) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [19:42:33] (03CR) 10Umherirrender: [] "Can I get a forced merge over jenkins vote?" [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [19:42:38] (03PS87) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [19:43:05] (03CR) 10Paladox: [] "Yes, you need to remove jenkins." [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [19:44:06] 10Social-Tools, 10VoteNY: Add returning community average for given Pageid - https://phabricator.wikimedia.org/T153566#2885284 (10Nodreams) https://www.mediawiki.org/wiki/Extension:VoteNY [19:52:17] rlot: are you around. [19:52:25] 10Phabricator: Converting "See Also" Bugzilla links to Phabricator tasks - https://phabricator.wikimedia.org/T697#2885302 (10Quiddity) Is this a duplicate of {T687} ? (It seems to be, but perhaps I'm missing something?) [19:53:31] tonythomas: Yes? [19:53:36] I found a cheaper way to fix this without duplicating all that navigation link code (which I originally meant in my first comment too). [19:53:38] comeenting now [19:53:40] 10Phabricator: Create acl*otrs-admins - https://phabricator.wikimedia.org/T153586#2885304 (10MarcoAurelio) My adittion to the group only I suspect. I am not sure about how signatures on OTRS are being managed but judging from the absence of membership of all other OTRS admins from any dedicated acl* or group I g... [19:53:44] tonythomas: K [19:54:18] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: rename user TextworkerBot to VladiBot - https://phabricator.wikimedia.org/T153602#2885305 (10Rubin16) [19:54:39] (03CR) 10Huji: [C: 031] "Recommend merging." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327491 (owner: 10Matěj Suchánek) [19:55:28] (03PS7) 10Krinkle: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [19:55:30] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2885318 (10scfc) Without having gone down the rabbit holes mentioned in this task: For example, in PostgreSQL you could rename the old `rev... [19:56:43] rlot: check my comments, and in case you are stuck, I can paste [19:56:49] (03CR) 1001tonythomas: [C: 04-1] "Can be optimized more." (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) (owner: 10Filip) [19:56:56] (03CR) 10Krinkle: [] "peerDependencies is inappropriate here. The concept of a peer dependency only makes sense for production modules, not development modules." [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [19:57:36] (03CR) 10Paladox: [] "Oh thanks." [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [20:01:57] (03CR) 10jenkins-bot: [V: 04-1] Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [20:02:38] 10MediaWiki-extensions-Gadgets, 07User-notice: The CSS of each gadget is included two times - https://phabricator.wikimedia.org/T42284#2885326 (10Krinkle) @Billinghurst No, `type` can only have 1 value. Can you explain what you were trying to do? Please know that `type=general` modules can have styles //and//... [20:03:17] tonythomas: So in getNewsletterActionButton is should revert the if? [20:03:21] (03PS8) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) [20:04:04] rlot: in the function getNewsletterActionButtons () you might need to add a new if! [20:04:07] tonythomas: If user is not set, why test it using ->isLoggedIn()? Can it be just if ( $user ) {} [20:04:27] rlot: you can do that too, I guess. [20:04:56] (03CR) 10Krinkle: [] Remove the old abuse filter parser class (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 (owner: 10Aaron Schulz) [20:05:00] rlot: in getNewsletterActionButtons() you can just pull out the 'Subscribe' oout of the checks, so that it would show up no matter what. gotcha ? [20:05:19] tonythomas: What if user is already subscribed? [20:05:43] rlot: you would need checks for that, sure. [20:06:28] tonythomas: It should be in ( !$user->isLoggedIn || $user ){ add subscribe } else if($user){ orginal code } [20:06:40] not || but && [20:07:22] rlot: just try it with all the test cases (non-logged in user, logged in subscribed user, logged in not-subscribed user) , and push it, I can test! [20:08:34] tonythomas Just (userlogged){orginalcode}else{add subscribe} should be ok [20:09:11] rlot: the thing is that 'originalcode' already have this subscribe thingy in it [20:10:04] (03CR) 10jenkins-bot: [V: 04-1] Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [20:10:08] so if(logged in and subscribed) else if(logged in not subscribed) else (anon)? [20:10:11] tonythomas? [20:10:14] I would rather do something like -> add in code for the subscribe button (which would check if the user exists and is logged and show unsubscribe or subscribe correctly), add in the rest of the things only when the user is logged, and use one single making navigation function. [20:10:20] (03PS9) 10Paladox: Pin eslint version [core] - 10https://gerrit.wikimedia.org/r/328049 (https://phabricator.wikimedia.org/T118941) [20:10:24] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2885331 (10MZMcBride) >>! In T146843#2681748, @MZMcBride wrote: > At this point, I'm pretty close to scraping every task, dumping them in a directory as HTM... [20:12:06] tonythomas: So merge getNavigationLinks with fillParserOutput? [20:12:18] rlot: why would you want that ? [20:12:48] *getNavigationLinks With getNEwsletterActionBUttons [20:12:51] tonythomas: [20:13:01] rlot: why would you want that too ? [20:13:18] rlot: well, you can have both of them combined - but maybe in a later patch [20:13:28] " use one single making navigation function. " [20:13:45] Ok, i think i got it [20:13:47] rlot: aha - that was the foreach and the rest of the code [20:14:04] one is navigation, the other is subtitles (yeah, its a bit confusing) [20:14:18] rlot: okey. if you are clear. I will take a break now. Will be back in like 2 hours or so [20:15:02] tonythomas: Can you wait a while? I'm in UTC and i'll go sleep in 1hr. I'll make it in 10min [20:15:20] 10Phabricator: Wikimedia Phabricator search index missing Maniphest tasks - https://phabricator.wikimedia.org/T153603#2885335 (10MZMcBride) [20:15:42] rlot: hmm. I dont know. lets see what happens after 10 mins. take your time! [20:15:49] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2885347 (10Paladox) Hi, @20after4 has added experimental support for elasticsearch in phabricator. To try it out you type in the search bar click enter the... [20:15:59] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2885349 (10QuimGil) I don't think we need to complicate things so much. The Newsletter extension could simply offer somewhere a textarea where administrators could introduce usernames, on... [20:17:04] 10MediaWiki-Watchlist, 07TestMe: move page will make watchlist useless - https://phabricator.wikimedia.org/T42470#469257 (10IvanFon) Unable to reproduce on Mediawiki 1.29.0. [20:18:06] 10MediaWiki-Watchlist: move page will make watchlist useless - https://phabricator.wikimedia.org/T42470#2885354 (10IvanFon) [20:18:15] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2885355 (10Paladox) [20:19:07] 10MediaWiki-Watchlist: move page will make watchlist useless - https://phabricator.wikimedia.org/T42470#469257 (10IvanFon) 05Open>03Resolved a:03IvanFon [20:19:23] 10MediaWiki-Watchlist: move page will make watchlist useless - https://phabricator.wikimedia.org/T42470#469257 (10IvanFon) a:05IvanFon>03None [20:19:27] 10MediaWiki-extensions-Newsletter: Exporting existing newsletter to the Newsletter extension - https://phabricator.wikimedia.org/T104131#2885360 (10QuimGil) [20:19:29] 10MediaWiki-extensions-Newsletter: Feature to add Newsletter subscribers manually - https://phabricator.wikimedia.org/T100277#2885359 (10QuimGil) [20:19:32] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2885361 (10matmarex) @MZMcBride was complaining about search today on IRC. He noted that it seems that some tasks are simply not indexed at all, but performing any action on them causes them to... [20:20:17] (03PS4) 10Aaron Schulz: [DNM] Remove the old abuse filter parser class [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 [20:20:57] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2885362 (10Paladox) @mmodell hi elasticsearch seems to be getting better results probably want to add a little check box or add a setting in user preference... [20:22:25] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2885364 (10MZMcBride) The problem with finding test cases is that the search index is incomplete. When someone subscribes to, comments on, or even mentions a Maniphest task, that action to the... [20:22:51] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2885366 (10Paladox) [20:26:08] (03PS6) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [20:26:17] tonythomas: Ok! I got it [20:27:19] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2885369 (10Paladox) Well we should be doing a reindex soon as part of the phabricator upgrade since upstream have fixed support for innodb fulltext search + the upgrade requires a reindex anyways. [20:34:31] tonythomas: Made commit [20:44:23] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2885376 (10Yurik) @Deskana, what kind of searches are you making? Are there any other ways to search for the... [20:56:33] 10MobileFrontend, 07Mobile: Show Navboxes in mobile view - https://phabricator.wikimedia.org/T124168#2885381 (10Nemo_bis) [20:57:43] (03CR) 10Matěj Suchánek: [C: 031] Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [20:57:58] (03CR) 10Matěj Suchánek: [C: 031] Add Czech aliases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [20:59:23] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [21:00:31] (03CR) 10Raimond Spekking: [C: 032] Add Czech aliases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [21:02:42] (03Merged) 10jenkins-bot: Add Czech aliases [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/328046 (owner: 10Urbanecm) [21:07:10] (03PS4) 10Urbanecm: Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 [21:07:36] (03CR) 10Urbanecm: [] "Fixed in PS4." (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [21:09:55] (03CR) 10Raimond Spekking: [C: 032] Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [21:10:57] (03Merged) 10jenkins-bot: Add Czech aliases [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/328047 (owner: 10Urbanecm) [21:17:15] (03Draft2) 10Urbanecm: Add Czech aliases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 [21:19:11] 10Phabricator (2016-12-21): Wikimedia Phabricator search index missing Maniphest tasks - https://phabricator.wikimedia.org/T153603#2885395 (10Paladox) [21:19:50] 10Phabricator: Wikimedia Phabricator search index missing Maniphest tasks - https://phabricator.wikimedia.org/T153603#2885335 (10Paladox) [21:20:37] (03CR) 10jenkins-bot: [V: 04-1] Add Czech aliases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 (owner: 10Urbanecm) [21:26:57] (03PS7) 10Filip: Subscribe button now shows to Anonymous user [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328048 (https://phabricator.wikimedia.org/T150637) [21:27:03] (03PS3) 10Matěj Suchánek: Don't show red diff link [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326272 (https://phabricator.wikimedia.org/T47948) [21:27:36] 10AbuseFilter, 13Patch-For-Review: Weird broken diff link in mediawikiwiki AbuseLog - https://phabricator.wikimedia.org/T47948#2885406 (10matej_suchanek) a:03matej_suchanek [21:29:30] (03PS3) 10Urbanecm: Add Czech aliases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 [21:31:34] (03CR) 10Raimond Spekking: [C: 04-1] Add Czech aliases (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 (owner: 10Urbanecm) [21:37:04] 10MediaWiki-Internationalization, 06Community-Liaisons, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 2 others: Remove Russian fallback for Ukrainian language - https://phabricator.wikimedia.org/T39314#2885409 (10Piramidion) > Most likely the change was not deployed ther... [21:37:24] 10MediaWiki-Internationalization, 06Community-Liaisons, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 2 others: Remove Russian fallback for Ukrainian language - https://phabricator.wikimedia.org/T39314#2885410 (10Piramidion) 05Open>03Resolved [21:39:13] (03CR) 10jenkins-bot: [V: 04-1] Add Czech aliases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 (owner: 10Urbanecm) [21:39:58] (03PS4) 10Urbanecm: Add Czech aliases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 [21:40:59] (03CR) 10Urbanecm: [] "Sorry, terrible typo." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 (owner: 10Urbanecm) [21:42:03] (03CR) 10Yaron Koren: [C: 032] "My issue actually wasn't with the removal of backward compatibility, but with the specific change in this patch, which I thought was incor" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326550 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [21:43:07] (03Merged) 10jenkins-bot: Remove old ArticleAfterFetchContent hook subscriber [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326550 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [21:48:21] (03CR) 10jenkins-bot: [V: 04-1] Add Czech aliases [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 (owner: 10Urbanecm) [21:57:41] (03CR) 10Urbanecm: [] "Where I have mistake?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/328084 (owner: 10Urbanecm) [22:03:31] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Rename user TextworkerBot to VladiBot - https://phabricator.wikimedia.org/T153602#2885414 (10MarcoAurelio) [22:11:49] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2885421 (10greg) >>! In T146843#2885362, @Paladox wrote: > @mmodell hi elasticsearch seems to be getting better results probably want to add a little check... [22:21:30] 10AbuseFilter: AbuseFilter statistics - https://phabricator.wikimedia.org/T153604#2885425 (10MarcoAurelio) [22:22:50] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2885438 (10greg) >>! In T151500#2885361, @matmarex wrote: > @MZMcBride was complaining about search today on IRC. He noted that it seems that some tasks are simply not indexed at all, but perfo... [22:26:29] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 06Operations: Rename user TextworkerBot to VladiBot - https://phabricator.wikimedia.org/T153602#2885442 (10Peachey88) [22:29:58] 10AbuseFilter: AbuseFilter statistics - https://phabricator.wikimedia.org/T153604#2885425 (10Platonides) This could be a GCI candidate. [22:34:25] 10Phabricator: Wikimedia Phabricator search index missing Maniphest tasks - https://phabricator.wikimedia.org/T153603#2885335 (10epriestley) This command will rebuild the index (for tasks only) and fix the issue: ``` phabricator/ $ ./bin/search index --type task --background --force ``` I'd guess this will tak... [22:36:19] 10Phabricator: Wikimedia Phabricator search index missing Maniphest tasks - https://phabricator.wikimedia.org/T153603#2885458 (10epriestley) (That rebuild can also safely be run while Phabricator is online, and against any version of Phabricator.) [22:38:35] 10Phabricator: Wikimedia Phabricator search index missing Maniphest tasks - https://phabricator.wikimedia.org/T153603#2885335 (10Peachey88) @MZMcBride Do you have a list of example ones that aren't in the index? maybe we can see something in their history that explains why they weren't index. [22:43:22] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10SUL-Finalization: Implement some kind of double confirmation for global user merges - https://phabricator.wikimedia.org/T105893#2885471 (10MarcoAurelio) 05Open>03stalled p:05Triage>03Lowest Stalled due to {T49918}. GlobalUserMerge is not possible... [22:47:49] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 07I18n: Wrong message-key used in NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153530#2885476 (10divadsn) Is there actually a need to add message entries for 'newsletter-diff-publishersheader', because I saw that there is no entry for... [22:54:25] (03CR) 10Legoktm: [C: 032] Move the Ukrainian grammar rules from PHP and JS to JSON [core] - 10https://gerrit.wikimedia.org/r/245184 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [22:57:03] (03PS4) 10Legoktm: build: Update phpunit to 4.8.31 [core] - 10https://gerrit.wikimedia.org/r/291927 (owner: 10Paladox) [22:57:38] (03CR) 10Legoktm: [C: 032] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/291927 (owner: 10Paladox) [22:58:10] (03CR) 10Paladox: [] "Thanks and your welcome :)" [core] - 10https://gerrit.wikimedia.org/r/291927 (owner: 10Paladox) [23:01:44] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2853999 (10NDKilla) @Kghbln Any insight as to when REL1_28 backport might get merged? We automatically pull it... [23:03:16] (03CR) 10Reedy: [C: 032] Replace deprecated skin's commentBlock function with Linker::commentBlock [extensions/MassEditRegex] (REL1_28) - 10https://gerrit.wikimedia.org/r/325799 (https://phabricator.wikimedia.org/T152605) (owner: 10Kghbln) [23:03:18] (03CR) 10Reedy: [C: 032] Replace deprecated skin's commentBlock function with Linker::commentBlock [extensions/MassEditRegex] (REL1_27) - 10https://gerrit.wikimedia.org/r/325801 (https://phabricator.wikimedia.org/T152605) (owner: 10Kghbln) [23:03:20] (03CR) 10Legoktm: [] "What is different about this attempt?" [core] - 10https://gerrit.wikimedia.org/r/319528 (https://phabricator.wikimedia.org/T62604) (owner: 10Nikerabbit) [23:03:27] (03CR) 10jenkins-bot: [V: 04-1] build: Update phpunit to 4.8.31 [core] - 10https://gerrit.wikimedia.org/r/291927 (owner: 10Paladox) [23:04:49] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2885485 (10Kghbln) > Any insight as to when REL1_28 backport might get merged? By experience this can take every... [23:04:52] (03Merged) 10jenkins-bot: Move the Ukrainian grammar rules from PHP and JS to JSON [core] - 10https://gerrit.wikimedia.org/r/245184 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [23:04:56] (03CR) 10Paladox: [] "Test failing unrelated." [core] - 10https://gerrit.wikimedia.org/r/291927 (owner: 10Paladox) [23:07:06] (03Merged) 10jenkins-bot: build: Update phpunit to 4.8.31 [core] - 10https://gerrit.wikimedia.org/r/291927 (owner: 10Paladox) [23:07:09] (03Merged) 10jenkins-bot: Replace deprecated skin's commentBlock function with Linker::commentBlock [extensions/MassEditRegex] (REL1_28) - 10https://gerrit.wikimedia.org/r/325799 (https://phabricator.wikimedia.org/T152605) (owner: 10Kghbln) [23:07:11] (03Merged) 10jenkins-bot: Replace deprecated skin's commentBlock function with Linker::commentBlock [extensions/MassEditRegex] (REL1_27) - 10https://gerrit.wikimedia.org/r/325801 (https://phabricator.wikimedia.org/T152605) (owner: 10Kghbln) [23:07:13] (03PS4) 10Cenarium: Remove patrol links with JS when reviewing a revision [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/213582 (https://phabricator.wikimedia.org/T100323) [23:07:15] (03PS1) 10Cenarium: Make patrol of reviewed changes optional [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/328111 [23:08:18] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2885490 (10NDKilla) Speak of the devil :p Thanks guys [23:10:50] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2885491 (10Kghbln) >>! In T152605#2885490, @NDKilla wrote: > Speak of the devil :p > Thanks guys So three weeks... [23:11:25] 10MediaWiki-extensions-General-or-Unknown: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2885493 (10Kghbln) [23:13:07] 10MediaWiki-extensions-General-or-Unknown: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2885494 (10Reedy) >>! In T152605#2885491, @Kghbln wrote: >>>! In T152605#2885490, @NDKilla wrote: >> Speak of the devil :p >> Thanks gu... [23:13:41] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10SUL-Finalization, 13Patch-For-Review: Rename of global (attached) users to existing global usernames - https://phabricator.wikimedia.org/T49918#505207 (10Platonides) Not having a few indexes isn't really a "hard" problem. I don't think this extension wo... [23:25:29] (03PS1) 10Paladox: Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 [23:27:06] (03PS2) 10Paladox: Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 [23:28:13] (03PS4) 10Cenarium: Defer changes matching specified thresholds [WIP] [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (https://phabricator.wikimedia.org/T150593) [23:30:42] (03CR) 10jenkins-bot: [V: 04-1] Defer changes matching specified thresholds [WIP] [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (https://phabricator.wikimedia.org/T150593) (owner: 10Cenarium) [23:32:10] (03PS3) 10Paladox: Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 [23:38:26] (03CR) 10jenkins-bot: [V: 04-1] Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 (owner: 10Paladox) [23:42:19] (03PS4) 10Paladox: Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 [23:43:30] 10Phabricator: Converting "See Also" Bugzilla links to Phabricator tasks - https://phabricator.wikimedia.org/T697#2885522 (10scfc) The proposed format in T687 is slightly different ("See Also: http://bugzilla.wikimedia.org/show_bug.cgi?id=9123000 (T9125000)" instead of "See Also: T9125000" being suggested here).... [23:47:59] (03PS5) 10Paladox: Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 [23:51:31] 10MediaWiki-extensions-General-or-Unknown: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2885524 (10Paladox) Thanks. [23:54:49] (03CR) 10jenkins-bot: [V: 04-1] Update some packages [core] - 10https://gerrit.wikimedia.org/r/328113 (owner: 10Paladox)