[00:02:38] 10MediaWiki-Configuration: validateRegistrationFile.php: Check for duplicate key in json - https://phabricator.wikimedia.org/T153507#2882858 (10Legoktm) I think we can probably use https://github.com/Seldaek/jsonlint for this. [00:03:09] (03PS1) 10Chelsyx: Add sparklines for KPIs: - KPI Summary Page - Monthly Metrics Page [wikimedia/discovery/rainbow] - 10https://gerrit.wikimedia.org/r/327877 (https://phabricator.wikimedia.org/T150215) [00:03:22] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2882862 (10srishakatux) Shared a draft email with @Qgil and @rfarrand that I plan to send out on Monday to Wikitech-I, our Meetup g... [00:05:06] 06Research-and-Data, 10Research-management: Research Offsite Dec 2016: expense reports - https://phabricator.wikimedia.org/T153111#2882865 (10DarTar) [00:05:24] (03PS23) 10Bearloga: Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [00:06:58] 10MediaWiki-Configuration: Don't put arbitrary extension attributes in the top level extension.json schema - https://phabricator.wikimedia.org/T133627#2882879 (10Legoktm) a:03Legoktm [00:08:01] (03CR) 10Krinkle: [] Add EventBus RCFeed classes (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/325589 (https://phabricator.wikimedia.org/T152030) (owner: 10Ottomata) [00:08:44] 10Phabricator (Upstream), 07Upstream: Author cannot edit their Herald rule anymore if condition includes custom field which has been deactivated in the meantime - https://phabricator.wikimedia.org/T153455#2882880 (10Peachey88) [00:09:13] (03PS1) 10Legoktm: SearchInputWidget: Support searching a namespaces besides 0 [core] - 10https://gerrit.wikimedia.org/r/327878 [00:10:11] (03PS1) 10Legoktm: [WIP] Make extending SpecialPreferences easier [core] - 10https://gerrit.wikimedia.org/r/327880 [00:11:57] (03CR) 10Gergő Tisza: [] "It seems that WANObjectCache behaves erratically in unit tests so changes to the user do not always get picked up later. bdf21a964c7 is a(" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/321412 (owner: 10Anomie) [00:13:50] (03PS4) 10Paladox: Read messages from JSON file [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/266070 (https://phabricator.wikimedia.org/T70701) (owner: 10PranavK) [00:13:56] (03CR) 10Paladox: [C: 031] Read messages from JSON file [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/266070 (https://phabricator.wikimedia.org/T70701) (owner: 10PranavK) [00:14:26] (03PS5) 10Paladox: Read messages from JSON file [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/266070 (https://phabricator.wikimedia.org/T70701) (owner: 10PranavK) [00:15:04] (03CR) 10Paladox: [C: 031] Read messages from JSON file [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/266070 (https://phabricator.wikimedia.org/T70701) (owner: 10PranavK) [00:15:30] 10MediaWiki-Configuration: validateRegistrationFile.php: Check for duplicate key in json - https://phabricator.wikimedia.org/T153507#2882882 (10Umherirrender) It would be nice, if it is not entry point related, because there are also i18n json files with duplicate keys Or decline as the mention task (or set dup... [00:15:40] (03CR) 10Krinkle: [] Add EventBus RCFeed classes (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/325589 (https://phabricator.wikimedia.org/T152030) (owner: 10Ottomata) [00:16:21] (03CR) 10Krinkle: [C: 031] HTMLForm: Use 'mw-htmlform' CSS class [core] - 10https://gerrit.wikimedia.org/r/324959 (owner: 10Bartosz Dziewoński) [00:17:10] (03CR) 10jenkins-bot: [V: 04-1] SearchInputWidget: Support searching a namespaces besides 0 [core] - 10https://gerrit.wikimedia.org/r/327878 (owner: 10Legoktm) [00:18:13] (03CR) 10Paladox: [] "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/320987 (owner: 10TheDJ) [00:19:24] (03CR) 10Ppchelko: [C: 04-1] "This patch only handles the case of Docker, not Jenkins. I suggest setting this in the `npm test` script, possibly conditionally depending" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327747 (https://phabricator.wikimedia.org/T152614) (owner: 10BearND) [00:20:30] (03CR) 10jenkins-bot: [V: 04-1] Skip decorative images in Multimedia viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/320987 (owner: 10TheDJ) [00:21:03] Krinkle: do you want to +2 https://gerrit.wikimedia.org/r/#/c/311463/8 , so that the patch you just +1'd can actually be merged? :( [00:22:07] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2882886 (10srishakatux) @Qgil Thanks for making the changes :) Description for streamed videos will become something lik... [00:29:05] 06Research-and-Data, 10Research-outreach: Research showcase December 2016 - https://phabricator.wikimedia.org/T151782#2882890 (10DarTar) [00:29:09] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2882891 (10Rfarrand) Sounds good Srishti, the floor plans are here: http://www.presidio.gov/venues-internal/Shared%20Doc... [00:32:56] 10MediaWiki-extensions-Widgets: `git submodule update --init --recursive` in mediawiki/extensions fails - https://phabricator.wikimedia.org/T153503#2882641 (10Reedy) No. It was using some weird orphaned/forked remote Swapped it to the proper one that wasn't abandoned ``` git submodule sync git submodule update... [00:45:12] MatmaRex: Could you provide a minimal test plan to excercise this code? [00:45:26] I'm not very familiar with hide-if or how I should test it [00:46:28] (03CR) 10Jforrester: [C: 032] registration: Always specify version number in extension.schema.json file [core] - 10https://gerrit.wikimedia.org/r/327784 (owner: 10Legoktm) [00:48:26] (03CR) 10Jforrester: [C: 031] Drop pre-1.29 backwards-compatibility [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/327781 (owner: 10Legoktm) [00:48:44] (03CR) 10Jforrester: [C: 031] extension.json: Add dependency upon Elastica [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/327782 (owner: 10Legoktm) [00:51:00] Attention: Scheduled maintaince for grrrit-wm in 9 minutes !!! [00:52:44] (03CR) 10Jforrester: [C: 031] "Other than the minor issue of trying to make ES6 code run in an ES3 environment, this looks good to me. :-)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327878 (owner: 10Legoktm) [00:53:31] (03CR) 10Reedy: [C: 04-1] Replaced usage of deprecated hook "ArticleSave" (031 comment) [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [00:53:34] bleh [00:54:11] (03CR) 10Reedy: [C: 04-1] Replaced usage of deprecated hook "ArticleSave" (031 comment) [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/327771 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [00:54:57] (03Merged) 10jenkins-bot: registration: Always specify version number in extension.schema.json file [core] - 10https://gerrit.wikimedia.org/r/327784 (owner: 10Legoktm) [00:56:00] (03PS1) 10Krinkle: tests: Fix broken setup/teardown in mediawiki.language.test.js [core] - 10https://gerrit.wikimedia.org/r/327881 [00:56:07] (03PS1) 10Legoktm: [WIP] registration: Move attributes out of the top level [core] - 10https://gerrit.wikimedia.org/r/327882 (https://phabricator.wikimedia.org/T133627) [00:56:10] (03PS1) 10MaxSem: Fix type annotation [core] - 10https://gerrit.wikimedia.org/r/327883 [00:56:30] 10MediaWiki-Internationalization, 15User-Nikerabbit: mw.language unittest cleanup failing - https://phabricator.wikimedia.org/T152476#2882939 (10Krinkle) > The `mw.language` test cleanup uses `mw.Map.values` which has been deprecated Actually, it doesn't. `mw.language.data` is not a mw.Map instance and the se... [01:44:55] 10MediaWiki-extensions-Translate, 06translatewiki.net: Translate shows the English (not the localized) description of projects - https://phabricator.wikimedia.org/T153512#2882975 (10Huji) [01:53:53] (03CR) 10Legoktm: [] "test" [core] - 10https://gerrit.wikimedia.org/r/327880 (owner: 10Legoktm) [01:54:06] ffs there we go [01:58:20] (03Merged) 10jenkins-bot: mediawiki.api: Add test for api deferred rejection of errorformat!=bc [core] - 10https://gerrit.wikimedia.org/r/327702 (owner: 10Matthias Mullie) [01:59:15] (03PS38) 10Paladox: Update sql [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/190660 [02:15:17] (03CR) 10Legoktm: [C: 031] "Thanks...I didn't realize that was a ES6 thing." [core] - 10https://gerrit.wikimedia.org/r/327878 (owner: 10Legoktm) [02:15:50] (03CR) 10Jforrester: [C: 032] SearchInputWidget: Support searching a namespaces besides 0 [core] - 10https://gerrit.wikimedia.org/r/327878 (owner: 10Legoktm) [02:16:50] 10MediaWiki-extensions-Translate, 06translatewiki.net: The match percentage and use case count are not localized - https://phabricator.wikimedia.org/T153514#2883019 (10Huji) [02:17:16] 10MediaWiki-extensions-Translate, 06translatewiki.net, 07Easy, 07I18n: The match percentage and use case count are not localized - https://phabricator.wikimedia.org/T153514#2883031 (10Huji) p:05Triage>03Lowest a:03Huji [02:19:12] (03PS4) 10Bmansurov: WIP: Add reading depth [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) [02:21:59] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add reading depth [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [02:23:22] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2883035 (10bmansurov) I think I need to add one more set of test cases. For now, please... [02:25:07] (03Merged) 10jenkins-bot: SearchInputWidget: Support searching a namespaces besides 0 [core] - 10https://gerrit.wikimedia.org/r/327878 (owner: 10Legoktm) [02:34:00] 10MediaWiki-ResourceLoader, 06Performance-Team, 07JavaScript, 13Patch-For-Review: Upgrade to jQuery 3 - https://phabricator.wikimedia.org/T124742#2883040 (10Jdforrester-WMF) [02:34:04] 10MediaWiki-Interface, 07JavaScript, 07Tracking: jquery.tipsy (tracking) - https://phabricator.wikimedia.org/T69500#2883041 (10Jdforrester-WMF) [02:34:06] 10MediaWiki-General-or-Unknown, 07Developer-notice, 07JavaScript, 05MW-1.29-release-notes, and 4 others: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features - https://phabricator.wikimedia.org/T85048#2883038 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF [02:34:11] 10MediaWiki-General-or-Unknown, 07Developer-notice, 07JavaScript, 05MW-1.29-release-notes, and 4 others: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features - https://phabricator.wikimedia.org/T85048#937510 (10Jdforrester-WMF) a:05Jdforrester-WMF>03matmarex [02:34:38] (03CR) 10Bartosz Dziewoński: "The commit message no longer matches the code after changes in PS6 :(" [core] - 10https://gerrit.wikimedia.org/r/300854 (https://phabricator.wikimedia.org/T85048) (owner: 10Bartosz Dziewoński) [02:35:07] 10MediaWiki-General-or-Unknown, 07Developer-notice, 07JavaScript, 05MW-1.29-release-notes, and 4 others: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features - https://phabricator.wikimedia.org/T85048#2883044 (10matmarex) a:05matmarex>03None [02:51:24] (03CR) 10Gergő Tisza: [] "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/325177 (owner: 10Fomafix) [02:55:11] (03CR) 10Legoktm: [C: 04-1] "Something is wrong because not enough things are broken." [core] - 10https://gerrit.wikimedia.org/r/327882 (https://phabricator.wikimedia.org/T133627) (owner: 10Legoktm) [03:03:25] (03PS2) 10Jrchamp: Bug T110292 - Update Auth_remoteuser to use AuthManager [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/327891 [03:05:00] (03PS1) 10Yuvipanda: Remove Dockerfile [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327894 [03:05:03] (03PS1) 10Yuvipanda: Add kubernetes deployment yaml file [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327895 [03:05:06] (03PS1) 10Yuvipanda: Remove Stale info from README [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327896 [03:06:07] (03CR) 10Legoktm: [C: 032] Adjust phan script to run sub-projects [core] - 10https://gerrit.wikimedia.org/r/327884 (https://phabricator.wikimedia.org/T153040) (owner: 10EBernhardson) [03:06:12] (03CR) 10Legoktm: [C: 032] mediawiki.searchSuggest: Remove inline browser compat check [core] - 10https://gerrit.wikimedia.org/r/327885 (owner: 10Krinkle) [03:12:11] (03PS1) 10Pppery: Add `showThumbnails` option to slideshow galleries [core] - 10https://gerrit.wikimedia.org/r/327897 (https://phabricator.wikimedia.org/T147913) [03:17:08] (03Merged) 10jenkins-bot: Adjust phan script to run sub-projects [core] - 10https://gerrit.wikimedia.org/r/327884 (https://phabricator.wikimedia.org/T153040) (owner: 10EBernhardson) [03:17:12] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Remove inline browser compat check [core] - 10https://gerrit.wikimedia.org/r/327885 (owner: 10Krinkle) [03:20:53] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#90822 (10scfc) This task's description is out of date and blurry. https://phabricator.wikimedia.org/diffusion/MW/browse/master/maintenance... [03:23:27] (03PS1) 10IvanFon: Updated maintenance scripts to use $this->requireExtension() [extensions/Math] - 10https://gerrit.wikimedia.org/r/327898 (https://phabricator.wikimedia.org/T152139) [03:28:23] (03CR) 10Bartosz Dziewoński: [C: 032] Don't show link to testing interface when the user cannot test filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327790 (owner: 10Matěj Suchánek) [03:34:09] (03PS1) 10IvanFon: Updated maintenance scripts to use $this->requireExtension() [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/327899 (https://phabricator.wikimedia.org/T152139) [03:39:01] (03Merged) 10jenkins-bot: Don't show link to testing interface when the user cannot test filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327790 (owner: 10Matěj Suchánek) [03:41:37] (03Abandoned) 10IvanFon: Updated maintenance scripts to use $this->requireExtension() [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/327899 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [03:42:23] 10MediaWiki-API: API RevisionDelete forces old-style booleans - https://phabricator.wikimedia.org/T153518#2883118 (10RobinHood70) [03:52:12] If I have to swap two query string option values in execute() of a special page, how can I make it so that those values are also swapped in the page HTMLForm? [03:53:50] (03PS6) 10Sn1per: [WIP] Date range filtering in Special:NewFiles [core] - 10https://gerrit.wikimedia.org/r/326476 (https://phabricator.wikimedia.org/T13836) [03:54:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Date range filtering in Special:NewFiles [core] - 10https://gerrit.wikimedia.org/r/326476 (https://phabricator.wikimedia.org/T13836) (owner: 10Sn1per) [03:55:07] 10MediaWiki-Search, 06Discovery, 06Discovery-Search: Search suggestions should only highlight the first match in the title - https://phabricator.wikimedia.org/T27187#2883130 (10matmarex) a:03matmarex [03:55:56] (03PS1) 10Bartosz Dziewoński: jquery.suggestions: Only highlight prefix matches [core] - 10https://gerrit.wikimedia.org/r/327900 (https://phabricator.wikimedia.org/T27187) [03:56:44] 10MediaWiki-extensions-Widgets: `git submodule update --init --recursive` in mediawiki/extensions fails - https://phabricator.wikimedia.org/T153503#2883134 (10matmarex) 05Open>03Invalid Oh, huh, okay. `git submodule sync --recursive` in mediawiki/extensions did it for me. Thanks. [03:58:16] (03CR) 10Sn1per: [] [WIP] Date range filtering in Special:NewFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326476 (https://phabricator.wikimedia.org/T13836) (owner: 10Sn1per) [04:02:14] (03CR) 10jenkins-bot: [V: 04-1] jquery.suggestions: Only highlight prefix matches [core] - 10https://gerrit.wikimedia.org/r/327900 (https://phabricator.wikimedia.org/T27187) (owner: 10Bartosz Dziewoński) [04:05:35] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 3 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2883138 (10IvanFon) [04:11:02] (03PS2) 10Bartosz Dziewoński: jquery.suggestions: Only highlight prefix matches [core] - 10https://gerrit.wikimedia.org/r/327900 (https://phabricator.wikimedia.org/T27187) [04:12:52] 10Social-Tools, 10SocialProfile: SocialProfile Special:GiveGift should use autocompletion - https://phabricator.wikimedia.org/T153519#2883141 (10SamanthaNguyen) [04:14:32] (03PS9) 10Sn1per: Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) [04:20:01] (03PS1) 10IvanFon: Updated Cargo maintenance scripts to use $this->requireExtension() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) [04:28:18] 10MediaWiki-Watchlist, 07Regression: Watchlist toast no longer processing markup - https://phabricator.wikimedia.org/T153403#2879501 (10matmarex) It looks like the same kind of problem that VisualEditor suffered from a while ago. https://de.wikipedia.org/wiki/MediaWiki_Diskussion:Editing#Parse_issue https://d... [04:29:03] 10Comments, 10Social-Tools, 10SocialProfile, 07Technical-Debt: SocialProfile UserBoard module's commenting system is very similar to the Comments extension - https://phabricator.wikimedia.org/T153520#2883158 (10SamanthaNguyen) [04:30:50] 10Comments, 10Social-Tools, 10SocialProfile, 07Technical-Debt: SocialProfile UserBoard module's commenting system is very similar to the Comments extension - https://phabricator.wikimedia.org/T153520#2883158 (10SamanthaNguyen) [04:31:25] 10Comments, 10Social-Tools, 10SocialProfile, 07Technical-Debt: SocialProfile UserBoard module's commenting system is very similar to the Comments extension - https://phabricator.wikimedia.org/T153520#2883174 (10SamanthaNguyen) [04:35:39] 10RandomUsersWithAvatars, 10Social-Tools: RandomUsersWithAvatars should provide the username in an alt attribute for each avatar image - https://phabricator.wikimedia.org/T153521#2883175 (10SamanthaNguyen) [04:35:48] (03CR) 10Legoktm: [C: 032] Remove Dockerfile [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327894 (owner: 10Yuvipanda) [04:36:04] (03CR) 10Legoktm: [C: 032] Add kubernetes deployment yaml file [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327895 (owner: 10Yuvipanda) [04:36:15] (03CR) 10Legoktm: [C: 032] Remove Stale info from README [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327896 (owner: 10Yuvipanda) [04:36:18] (03Merged) 10jenkins-bot: Remove Dockerfile [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327894 (owner: 10Yuvipanda) [04:36:37] (03Merged) 10jenkins-bot: Add kubernetes deployment yaml file [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327895 (owner: 10Yuvipanda) [04:36:50] (03Merged) 10jenkins-bot: Remove Stale info from README [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327896 (owner: 10Yuvipanda) [04:41:57] 10BlogPage, 10Social-Tools: The "Don't miss" module of BlogPage is ironically easy to miss since it's positioned under the categories component - https://phabricator.wikimedia.org/T153522#2883188 (10SamanthaNguyen) [04:49:26] (03CR) 10Gergő Tisza: [C: 032] Use [] instead of array() syntax for PHP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/325177 (owner: 10Fomafix) [04:50:26] (03CR) 10Gergő Tisza: [] "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/326146 (https://phabricator.wikimedia.org/T58471) (owner: 10Sn1per) [04:51:41] 10NewUsersList, 10Social-Tools: NewUsersList should provide the username in an alt attribute for each avatar image - https://phabricator.wikimedia.org/T153523#2883201 (10SamanthaNguyen) [04:51:53] (03Merged) 10jenkins-bot: Use [] instead of array() syntax for PHP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/325177 (owner: 10Fomafix) [04:57:34] 10RandomGameUnit, 10Social-Tools: Reduce the amount of dependencies required for RandomGameUnit to function properly - https://phabricator.wikimedia.org/T153524#2883215 (10SamanthaNguyen) [04:59:56] (03CR) 10Gergő Tisza: [C: 032] Add alt text attributes to all of the lightbox buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/326146 (https://phabricator.wikimedia.org/T58471) (owner: 10Sn1per) [05:01:53] (03Merged) 10jenkins-bot: Add alt text attributes to all of the lightbox buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/326146 (https://phabricator.wikimedia.org/T58471) (owner: 10Sn1per) [05:04:06] (03CR) 10Legoktm: [C: 032] Change linking Special:PageLanguage on action=info [core] - 10https://gerrit.wikimedia.org/r/327788 (owner: 10Umherirrender) [05:10:31] 10NewSignupPage, 10Social-Tools: NewSignupPage should provide a separate configuration to let you customize the link to the policy - https://phabricator.wikimedia.org/T153525#2883232 (10SamanthaNguyen) [05:11:11] 10MediaWiki-Internationalization, 15User-Nikerabbit: mw.language unittest cleanup failing - https://phabricator.wikimedia.org/T152476#2883245 (10Tgr) 05Open>03Resolved a:03Krinkle Seems like that fixed the issue. Thanks! [05:14:21] (03Merged) 10jenkins-bot: Change linking Special:PageLanguage on action=info [core] - 10https://gerrit.wikimedia.org/r/327788 (owner: 10Umherirrender) [05:23:21] 10NewSignupPage, 10Social-Tools: NewSignupPage shouldn't provide a custom response for password mismatching - https://phabricator.wikimedia.org/T153526#2883248 (10SamanthaNguyen) [05:31:19] 10NewSignupPage, 10Social-Tools: NewSignupPage shouldn't provide a custom response for password mismatching - https://phabricator.wikimedia.org/T153526#2883262 (10SamanthaNguyen) Also, apparently from an old comment there isn't a password checker in core, but I believe there already is - For example, you can t... [05:46:57] (03CR) 10Smalyshev: [C: 04-1] Cleanup execution flow through SpecialSearch::execute() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) (owner: 10EBernhardson) [05:47:52] (03CR) 10Smalyshev: [C: 04-1] Pull rendering of single result out of SpecialSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [05:52:03] (03PS1) 10Krinkle: mediawiki.special.watchlist: Fix render stampede after "Mark all pages visited" [core] - 10https://gerrit.wikimedia.org/r/327903 [05:52:11] (03CR) 10Krinkle: "Just two other points:" [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [05:55:01] (03CR) 10Krinkle: [] "Screenshots of performance timeline:" [core] - 10https://gerrit.wikimedia.org/r/327903 (owner: 10Krinkle) [06:11:54] (03PS1) 10Krinkle: user: Minor clean up of User::isLocallyBlockedProxy() [core] - 10https://gerrit.wikimedia.org/r/327904 [06:13:11] (03PS11) 10Krinkle: [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) [06:13:51] (03CR) 10Smalyshev: [] [WIP] [DNM] Produce RDF dump of all categories and subcategories in a wiki. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327862 (owner: 10Smalyshev) [06:14:00] (03PS2) 10Krinkle: [WIP] Implement 'peers' feature for loading extra styles-type gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/322234 [06:14:17] (03PS3) 10Krinkle: Implement 'peers' feature for loading extra styles-type gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/322234 [06:15:51] 10MediaWiki-General-or-Unknown, 07Easy, 03Google-Code-In-2016, 07NewPHP, 13Patch-For-Review: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#2883273 (10mwjames) > We should of course make sure that this doesn't break hook subscribers that are expecting it t... [06:19:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [06:21:16] 10MediaWiki-extensions-Gadgets, 07User-notice: The CSS of each gadget is included two times - https://phabricator.wikimedia.org/T42284#2883274 (10Krinkle) >>! In T42284#2868044, @Billinghurst wrote: > can we please also have a message to the wikitech-ambassadors with some text around the solution. the consol... [06:22:33] (03CR) 10Krinkle: [] "Once merged, I'll expand documentation at https://www.mediawiki.org/wiki/RL/MGU#Gadget_type to consider the case where it is desired for t" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/322234 (owner: 10Krinkle) [06:29:14] 10MediaWiki-Unit-tests, 10MediaWiki-User-blocking, 07Regression: Flaky unit test "UserTest::testAutoblockCookieInfiniteExpiry" - https://phabricator.wikimedia.org/T153527#2883276 (10Krinkle) [06:29:24] (03CR) 10Krinkle: "fixme: Unit test is flaky - T153527" [core] - 10https://gerrit.wikimedia.org/r/48029 (https://phabricator.wikimedia.org/T5233) (owner: 10Parent5446) [06:33:19] (03CR) 10Krinkle: [C: 031] "T153527" [core] - 10https://gerrit.wikimedia.org/r/327698 (owner: 10Aaron Schulz) [06:33:23] (03CR) 10Krinkle: [C: 032] Fix various minor IDEA warnings in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/327698 (owner: 10Aaron Schulz) [06:34:06] (03CR) 10Aaron Schulz: [C: 032] user: Minor clean up of User::isLocallyBlockedProxy() [core] - 10https://gerrit.wikimedia.org/r/327904 (owner: 10Krinkle) [06:38:48] (03CR) 10Krinkle: Add ILocalizedException interface (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325984 (owner: 10Anomie) [06:41:36] (03Merged) 10jenkins-bot: Fix various minor IDEA warnings in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/327698 (owner: 10Aaron Schulz) [06:42:12] (03Merged) 10jenkins-bot: user: Minor clean up of User::isLocallyBlockedProxy() [core] - 10https://gerrit.wikimedia.org/r/327904 (owner: 10Krinkle) [06:46:48] (03CR) 10Krinkle: [C: 031] "Callers:" [core] - 10https://gerrit.wikimedia.org/r/266251 (owner: 10Gerrit Patch Uploader) [06:46:59] (03CR) 10Krinkle: [C: 032] mediawiki.api.watch: Use formatversion=2 for API requests [core] - 10https://gerrit.wikimedia.org/r/266251 (owner: 10Gerrit Patch Uploader) [06:56:01] (03Merged) 10jenkins-bot: mediawiki.api.watch: Use formatversion=2 for API requests [core] - 10https://gerrit.wikimedia.org/r/266251 (owner: 10Gerrit Patch Uploader) [07:12:03] 10MediaWiki-Internationalization, 06Operations: Norwegian messages inContentLanguage look for on-wiki overrides at the /nb subpage, not the root page - https://phabricator.wikimedia.org/T126146#2883330 (10Krinkle) >>! In T126146#2880170, @thiemowmde wrote: > "Sites" is not a first-class Wikibase concept. It wa... [07:23:05] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General-or-Unknown, 06Front-end-Standards-Group, 13Patch-For-Review, 07RfC: Switch to eslint for our linting and our code styling - https://phabricator.wikimedia.org/T118941#2883334 (10Krinkle) >>! In T118941#2880706, @Paladox wrote: > We should fork... [07:26:00] 10MediaWiki-extensions-Translate, 07Easy, 07I18n: The match percentage and use case count are not localized - https://phabricator.wikimedia.org/T153514#2883338 (10Nemo_bis) [07:33:33] 10MediaWiki-extensions-CodeMirror: Sometimes Enable/Disable button is broken - https://phabricator.wikimedia.org/T153528#2883340 (10Pastakhov) [07:41:37] 10MediaWiki-Internationalization, 06Language-Team, 07I18n, 07Regression: Message overrides not working on no.wikibooks.org - https://phabricator.wikimedia.org/T151247#2883353 (10Krinkle) I'd say, yes. * Various wikis have effectively lost all their interface overrides overnight, as well as high level conf... [07:46:10] (03PS2) 10Filip: Replaced usage of deprecated hook "ArticleSave" [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/327771 (https://phabricator.wikimedia.org/T151973) [07:50:32] 10MediaWiki-ResourceLoader: Shut up filemtime() warnings in ResourceLoader (and possibly other warnings related to nonexistent files as well) - https://phabricator.wikimedia.org/T28486#2883354 (10Krinkle) 05Open>03Resolved @Xcollector838 Despite ResourceLoader showing in the stack trace, the exception you ca... [07:51:27] (03PS3) 10Filip: Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) [07:52:19] (03CR) 10jenkins-bot: [V: 04-1] Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [07:55:16] (03PS4) 10Filip: Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) [07:56:17] (03CR) 10jenkins-bot: [V: 04-1] Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [08:00:11] (03CR) 10Niharika29: [] "> 07:56:14 Notice: Undefined property: WikiPage::$getTitle in /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/Aw" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [08:03:58] (03PS5) 10Filip: Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) [08:04:54] (03CR) 10Niharika29: [] Replaced usage of deprecated hook "ArticleSave" (031 comment) [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/327771 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [08:05:32] (03CR) 10jenkins-bot: [V: 04-1] Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [08:08:23] (03CR) 10Gergő Tisza: [] "There is a very similar older patch (with very similar problems): https://gerrit.wikimedia.org/r/#/c/308683" (038 comments) [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/327891 (owner: 10Jrchamp) [08:09:17] (03PS3) 10Filip: Replaced usage of deprecated hook "ArticleSave" [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/327771 (https://phabricator.wikimedia.org/T151973) [08:10:59] (03PS6) 10Filip: Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) [08:24:39] (03CR) 10Aaron Schulz: [C: 031] "@Cenarium: are you ok with these changes?" [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [08:31:23] 10MediaWiki-Internationalization, 06Operations: Norwegian messages inContentLanguage look for on-wiki overrides at the /nb subpage, not the root page - https://phabricator.wikimedia.org/T126146#2883359 (10Nemo_bis) [08:41:20] 10UI-Standardization, 03Google-Code-In-2016, 13Patch-For-Review, 13Patch-Needs-Improvement: Convert Special:Tags to OOUI - https://phabricator.wikimedia.org/T117742#2883362 (1001tonythomas) I'm adding in the GCI tag and moving this to 'missing-mentors' there. [08:47:02] 10MediaWiki-Special-pages, 10MediaWiki-extension-requests, 06Community-Tech, 06Stewards-and-global-tools: Setting a temporary usergroup (allow expiry of user rights via Special:UserRights form) - https://phabricator.wikimedia.org/T12493#2883368 (10matej_suchanek) [08:48:23] (03PS1) 10Urbanecm: Add Protect-level-autopatrol in et.json [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) [08:48:55] (03PS2) 10Urbanecm: Add Protect-level-autopatrol and relevant messages in et.json [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) [08:49:17] (03CR) 10Urbanecm: [C: 04-1] "Incomplete patch." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [08:49:18] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Fix Special:MovePage ends up in a fatal for Newsletters:Foo - https://phabricator.wikimedia.org/T153529#2883370 (1001tonythomas) [08:50:27] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Fix Special:MovePage ends up in a fatal for Newsletters:Foo - https://phabricator.wikimedia.org/T153529#2883382 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5433605692063744/ - waiting for @Aklapper to publish it. [08:51:13] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2883383 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5973046538010624/ - waiting f... [08:51:44] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Special:Newsletters and Newsletter details page could provide an explanation to anonymous users - https://phabricator.wikimedia.org/T150637#2791764 (1001tonythomas) [08:56:56] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong message-key used in NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153530#2883386 (1001tonythomas) [08:57:31] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong message-key used in NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153530#2883398 (1001tonythomas) [08:58:07] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong message-key used in NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153530#2883386 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5389180899164160/, waiting for @Aklapper to publish it. [09:01:20] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong id used for 'colspan' in content/NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153531#2883400 (1001tonythomas) [09:02:07] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong id used for 'colspan' in content/NewsletterDiffEngine.php - https://phabricator.wikimedia.org/T153531#2883412 (1001tonythomas) Imported as https://codein.withgoogle.com/dashboard/tasks/5730923393843200/ Waiting for @Aklapper to publish. [09:03:38] legoktm: are you around ? [09:07:08] Reedy: Are you there? [09:07:23] (everyone wants the same thing, isnt it) :P [09:09:08] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Newsletter: Should newsletter be storing in data both in contenthandler and in the database - https://phabricator.wikimedia.org/T153532#2883414 (1001tonythomas) [09:09:18] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-Newsletter: Should newsletter be storing in data both in contenthandler and in the database - https://phabricator.wikimedia.org/T153532#2883426 (1001tonythomas) [09:12:56] (03PS1) 10Aaron Schulz: Move TempFileRepo to a separate file [core] - 10https://gerrit.wikimedia.org/r/327909 [09:24:26] (03PS1) 10Umherirrender: Fix invalid json in qqq.json [extensions/WikipediaExtracts] - 10https://gerrit.wikimedia.org/r/327910 [09:28:32] (03PS1) 10Umherirrender: Remove duplicate message key from en.json [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/327911 [09:33:39] (03PS1) 10Umherirrender: Remove duplicate message keys in en.json [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/327912 [09:42:28] (03PS3) 10Gerrit Patch Uploader: Add protect-level-autopatrol and restriction-level-autopatrol [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [09:42:30] (03CR) 10Gerrit Patch Uploader: [] "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [09:43:06] (03PS2) 10Umherirrender: Remove duplicate message keys from core/en.json [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/327912 [09:46:56] (03CR) 10Urbanecm: [C: 04-1] "DNM - there is nothing for the language we're interested in. Going to fix." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [09:47:50] (03PS4) 10Urbanecm: Add protect-level-autopatrol and restriction-level-autopatrol [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) [09:50:36] (03PS5) 10Urbanecm: Add protect-level-autopatrol and restriction-level-autopatrol [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) [09:51:27] (03CR) 10Urbanecm: [C: 04-1] "Incomplete patch." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [09:57:28] 10MediaWiki-Watchlist: AJAX Watchlist does not refresh - https://phabricator.wikimedia.org/T153533#2883430 (10Nenntmichruhigip) [10:10:29] 10MediaWiki-Watchlist: AJAX Watchlist does not completly work with expanded Watchlist - https://phabricator.wikimedia.org/T153536#2883470 (10Nenntmichruhigip) [10:10:58] 10MediaWiki-Watchlist: AJAX Watchlist: Loading bar layout - https://phabricator.wikimedia.org/T153537#2883484 (10Nenntmichruhigip) [10:22:29] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2883515 (10jcrespo) >>! In T6715#2883093, @scfc wrote: > So the task description should be rephrased to clarify what is requested here. Th... [10:26:17] (03PS1) 10Seb35: Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 [10:27:31] (03CR) 10jenkins-bot: [V: 04-1] Bug monoversion installation, maintenance [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/327915 (owner: 10Seb35) [10:28:58] (03PS6) 10Urbanecm: Add protect-level-autopatrol and restriction-level-autopatrol [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) [10:29:58] (03CR) 10Urbanecm: [C: 04-1] "Till review from [[:mw:User:Pikne]] at linked phab task." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [10:34:34] (03CR) 10Reedy: [C: 04-1] "Minor code style issue" (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [10:34:51] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) [10:35:20] (03CR) 10Reedy: [C: 04-1] "Missing spaces here too" [extensions/Math] - 10https://gerrit.wikimedia.org/r/327898 (https://phabricator.wikimedia.org/T152139) (owner: 10IvanFon) [10:36:00] (03PS1) 10LukBukkit: Removed usages of the deprecated method Revision::getText [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) [10:36:50] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) [10:37:11] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) [10:37:59] (03CR) 10Reedy: [C: 032] Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:38:36] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) [10:38:50] (03CR) 10Reedy: [C: 032] Replaced usage of deprecated hook "ArticleSave" [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/327771 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:39:01] (03Merged) 10jenkins-bot: Replaced usage of deprecated hook "ArticleSave" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/327770 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:39:42] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327921 (https://phabricator.wikimedia.org/T151973) [10:39:44] (03Merged) 10jenkins-bot: Replaced usage of deprecated hook "ArticleSave" [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/327771 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:40:02] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) [10:40:29] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) [10:40:56] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) [10:41:20] (03PS1) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) [10:41:35] (03CR) 10Reedy: [C: 04-1] Removed usages of a deprecated method Revision::getText (032 comments) [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:43:25] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:43:52] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:44:06] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:44:24] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:44:36] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327921 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:44:46] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:44:57] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:45:06] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:45:16] (03CR) 10Reedy: [C: 04-1] "Same as https://gerrit.wikimedia.org/r/#/c/327916/" [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:48:28] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:48:35] (03Abandoned) 10LukBukkit: Removed usages of the deprecated method Revision::getText [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/327917 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:48:43] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/327920 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:48:50] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/327918 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:48:59] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/327919 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:49:10] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327921 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:49:16] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/327922 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:49:24] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327923 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:49:29] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/327924 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:49:31] (03Abandoned) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:50:22] Seriously? [10:51:11] 10NewSignupPage, 10Social-Tools: NewSignupPage should provide a separate configuration to let you customize the link to the policy - https://phabricator.wikimedia.org/T153525#2883544 (10ashley) p:05Triage>03Lowest It's not an ideal default, sure, but it's assumed that any non-ShoutWiki reuser of the extens... [10:52:07] (03CR) 10Reedy: "Why did you abandon all the commits? You can just amend them. There's not a lot to change" [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [10:53:35] (03CR) 10Urbanecm: [] "Review was done." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/327908 (https://phabricator.wikimedia.org/T153465) (owner: 10Urbanecm) [10:54:57] (03PS1) 10Jack Phoenix: Version 0.6.2 from ShoutWiki: HHVM compatibility fix, i18n loading fix [extensions/EnhanceContactForm] - 10https://gerrit.wikimedia.org/r/327926 [10:57:36] (03CR) 10Jack Phoenix: [C: 032] Version 0.6.2 from ShoutWiki: HHVM compatibility fix, i18n loading fix [extensions/EnhanceContactForm] - 10https://gerrit.wikimedia.org/r/327926 (owner: 10Jack Phoenix) [10:58:33] (03Merged) 10jenkins-bot: Version 0.6.2 from ShoutWiki: HHVM compatibility fix, i18n loading fix [extensions/EnhanceContactForm] - 10https://gerrit.wikimedia.org/r/327926 (owner: 10Jack Phoenix) [11:01:17] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2883554 (10BurritoBazooka) I'll put all my addons and Wikipedia gadgets here so that people can see whether there is any correlation, although... [11:02:51] (03CR) 10LukBukkit: "I was a litte bit confused and I have to take a look a each of these changes to prevent things from breaking, like you said. That's very I" [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:11:52] (03PS1) 10Jack Phoenix: Allow callers to override the default alt attribute in wAvatar::getAvatarURL() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327927 (https://phabricator.wikimedia.org/T153521) [11:12:14] (03CR) 10Jack Phoenix: [V: 032 C: 032] Allow callers to override the default alt attribute in wAvatar::getAvatarURL() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327927 (https://phabricator.wikimedia.org/T153521) (owner: 10Jack Phoenix) [11:17:53] (03PS1) 10Jack Phoenix: NewUsersList should provide the username in an alt attribute for each avatar image [extensions/NewUsersList] - 10https://gerrit.wikimedia.org/r/327928 (https://phabricator.wikimedia.org/T153523) [11:18:52] (03PS1) 10Jack Phoenix: RandomUsersWithAvatars should provide the username in an alt attribute for each avatar image [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/327929 (https://phabricator.wikimedia.org/T153521) [11:19:08] (03CR) 10Jack Phoenix: [C: 032] NewUsersList should provide the username in an alt attribute for each avatar image [extensions/NewUsersList] - 10https://gerrit.wikimedia.org/r/327928 (https://phabricator.wikimedia.org/T153523) (owner: 10Jack Phoenix) [11:20:17] (03Merged) 10jenkins-bot: NewUsersList should provide the username in an alt attribute for each avatar image [extensions/NewUsersList] - 10https://gerrit.wikimedia.org/r/327928 (https://phabricator.wikimedia.org/T153523) (owner: 10Jack Phoenix) [11:20:51] (03CR) 10Jack Phoenix: [C: 032] RandomUsersWithAvatars should provide the username in an alt attribute for each avatar image [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/327929 (https://phabricator.wikimedia.org/T153521) (owner: 10Jack Phoenix) [11:21:19] 10NewUsersList, 10Social-Tools: NewUsersList should provide the username in an alt attribute for each avatar image - https://phabricator.wikimedia.org/T153523#2883582 (10ashley) 05Open>03Resolved a:03ashley [11:21:43] (03Merged) 10jenkins-bot: RandomUsersWithAvatars should provide the username in an alt attribute for each avatar image [extensions/RandomUsersWithAvatars] - 10https://gerrit.wikimedia.org/r/327929 (https://phabricator.wikimedia.org/T153521) (owner: 10Jack Phoenix) [11:22:22] 10RandomUsersWithAvatars, 10Social-Tools: RandomUsersWithAvatars should provide the username in an alt attribute for each avatar image - https://phabricator.wikimedia.org/T153521#2883586 (10ashley) 05Open>03Resolved a:03ashley [11:29:50] tonythomas: Are you there? [11:30:25] tonythomas: Where can i enable warnings? [11:34:28] What warnings? [11:35:27] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:36:39] (03Restored) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:36:44] (03PS2) 10LukBukkit: Removed usages of a deprecated method: Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) [11:38:19] (03PS3) 10LukBukkit: Removed usages of a deprecated method: Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) [11:38:43] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Fix the warning after removing subscription to newsletter - https://phabricator.wikimedia.org/T149647#2758806 (10FilipGCI) @01tonythomas Wierd, this problem no longer occur in my setup( I have turned all debug options ). Can someone recreate this? [11:39:19] Reedy: Got it, these setting should be fine? $wgShowExceptionDetails = true; [11:39:19] $wgDebugToolbar = true; [11:39:19] $wgShowDebug = true; [11:39:20] $wgDevelopmentWarnings = true; [11:39:29] Should do most of it [11:39:40] You might want [11:39:40] error_reporting( E_ALL | E_STRICT ); [11:39:40] ini_set( "display_errors", 1 ); [11:39:41] too [11:40:01] Yep, i have this too [11:44:40] 10Comments, 10Social-Tools, 10SocialProfile, 07Technical-Debt: SocialProfile UserBoard module's commenting system is very similar to the Comments extension - https://phabricator.wikimedia.org/T153520#2883624 (10ashley) > From my understanding, the UserBoard module (Special:UserBoard and its AJAX functions)... [11:47:14] 10BlogPage, 10Social-Tools: The "Don't miss" module of BlogPage is ironically easy to miss since it's positioned under the categories component - https://phabricator.wikimedia.org/T153522#2883625 (10ashley) Yeah, the BlogPage layout is messed up on most skins. It was originally designed for skins like [[http:/... [11:47:15] (03CR) 10Reedy: [C: 04-1] Removed usages of a deprecated method: Revision::getText (033 comments) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [11:48:52] (03PS2) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) [11:57:41] 10MediaWiki-General-or-Unknown, 07Tracking: Make MediaWiki more AJAXy (tracking) - https://phabricator.wikimedia.org/T16123#2883631 (10matej_suchanek) [11:58:14] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2883635 (10matej_suchanek) [11:58:17] 10MediaWiki-General-or-Unknown, 07Tracking: Make MediaWiki more AJAXy (tracking) - https://phabricator.wikimedia.org/T16123#184727 (10matej_suchanek) [12:01:20] Hi! Can anyone retest this? https://phabricator.wikimedia.org/T138462 [12:08:50] 10RandomGameUnit, 10Social-Tools: Reduce the amount of dependencies required for RandomGameUnit to function properly - https://phabricator.wikimedia.org/T153524#2883638 (10ashley) This is actually already done as far as the PHP code is considered, it's just a documentation/setup issue mostly at this point. The... [12:13:06] (03PS2) 10Umherirrender: Fix deprecation message - use correct method name (defaultPrefixSearch) [core] - 10https://gerrit.wikimedia.org/r/327864 (owner: 10Smalyshev) [12:13:13] (03CR) 10Umherirrender: [C: 032] Fix deprecation message - use correct method name (defaultPrefixSearch) [core] - 10https://gerrit.wikimedia.org/r/327864 (owner: 10Smalyshev) [12:15:24] rlot: hey there. Whats up ? [12:15:38] Look at PW [12:15:45] pw ? :o [12:16:16] tonythomas: Look at chat, i wrote everything [12:16:32] rlot: sorry my client removed them all. can you tell again / [12:18:11] 10MediaWiki-extensions-Translate: Add dropdown on Special:PageTranslationDeletePage - https://phabricator.wikimedia.org/T153542#2883653 (10MarcoAurelio) [12:18:21] tonythomas: Can you take a look? https://phabricator.wikimedia.org/T149647 [12:19:07] oh heh. its the missing bug thing again :D Loads of fixes these days, and not-strangely fix one or the other. Let me try it [12:22:12] tonythomas: I have strange luck to these task [12:23:14] (03Merged) 10jenkins-bot: Fix deprecation message - use correct method name (defaultPrefixSearch) [core] - 10https://gerrit.wikimedia.org/r/327864 (owner: 10Smalyshev) [12:24:34] rlot: agreed. Newsletter extension do not throw that :) [12:25:08] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2883669 (1001tonythomas) [12:25:11] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Fix the warning after removing subscription to newsletter - https://phabricator.wikimedia.org/T149647#2883667 (1001tonythomas) 05Open>03Invalid Probably fixed in one of the earlier ContentHandler patchsets. The problem do not occur ATM. [12:27:58] 10MediaWiki-extensions-Newsletter, 10Security-Reviews, 06Security-Team: Security review of Newsletter extension - https://phabricator.wikimedia.org/T115095#2883672 (1001tonythomas) [12:28:02] 10MediaWiki-extensions-Newsletter: Newsletter extension: Technical review - https://phabricator.wikimedia.org/T110366#2883673 (1001tonythomas) [12:28:04] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Special:Newsletter fatals if the newsletter main page is deleted - https://phabricator.wikimedia.org/T119058#2883670 (1001tonythomas) 05Open>03Resolved Do not occur as of now, as we are storing things more 'wiki' way with Content-Handler = yay! [12:28:08] (03PS1) 10Jack Phoenix: Version 0.9.1: use the core-provided error message and error message CSS class instead of rolling out our own solution [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/327931 (https://phabricator.wikimedia.org/T147255) [12:29:18] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2883682 (1001tonythomas) [12:29:20] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remove default view (Special:Newsletter/id/) code from SpecialNewsletter.php - https://phabricator.wikimedia.org/T152678#2883681 (1001tonythomas) [12:31:10] (03CR) 10Jack Phoenix: [C: 032] Version 0.9.1: use the core-provided error message and error message CSS class instead of rolling out our own solution [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/327931 (https://phabricator.wikimedia.org/T147255) (owner: 10Jack Phoenix) [12:32:57] (03Merged) 10jenkins-bot: Version 0.9.1: use the core-provided error message and error message CSS class instead of rolling out our own solution [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/327931 (https://phabricator.wikimedia.org/T147255) (owner: 10Jack Phoenix) [12:33:49] 10BlogPage, 10Comments, 10FanBoxes, 10NewSignupPage, and 7 others: [EPIC] Remove inline styling from Social Tools extensions - https://phabricator.wikimedia.org/T87148#2883702 (10ashley) [12:33:51] 10NewSignupPage, 10Social-Tools: Remove inline styling from NewSignupPage - https://phabricator.wikimedia.org/T147255#2883699 (10ashley) 05Open>03Resolved a:03ashley [12:34:59] 10NewSignupPage, 10Social-Tools: NewSignupPage shouldn't provide a custom response for password mismatching - https://phabricator.wikimedia.org/T153526#2883703 (10ashley) 05Open>03Resolved a:03ashley To quote NewSignupPage.js on the purpose of that file/feature: "`JavaScript file for performing some inte... [12:41:00] (03PS1) 10Jack Phoenix: Special:GiveGift should use autocompletion to make finding users easier [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327932 (https://phabricator.wikimedia.org/T153519) [12:42:41] (03CR) 10jenkins-bot: [V: 04-1] Special:GiveGift should use autocompletion to make finding users easier [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327932 (https://phabricator.wikimedia.org/T153519) (owner: 10Jack Phoenix) [12:43:21] (03PS2) 10Jack Phoenix: Special:GiveGift should use autocompletion to make finding users easier [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327932 (https://phabricator.wikimedia.org/T153519) [12:44:09] (03CR) 10Jack Phoenix: [V: 032 C: 032] Special:GiveGift should use autocompletion to make finding users easier [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327932 (https://phabricator.wikimedia.org/T153519) (owner: 10Jack Phoenix) [12:48:38] 10Social-Tools, 10SocialProfile: SocialProfile Special:GiveGift should use autocompletion - https://phabricator.wikimedia.org/T153519#2883712 (10ashley) 05Open>03Resolved a:03ashley More autocompletion stuff coming eventually in [[https://gerrit.wikimedia.org/r/#/c/326071/|this patchset]], but this bug i... [12:56:32] (03CR) 10Paladox: "recheck" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/324030 (https://phabricator.wikimedia.org/T151842) (owner: 10Paladox) [12:56:49] (03PS11) 10Cenarium: Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 [12:59:05] (03CR) 10Cenarium: [] "I'm ok with the changes. I've also made an edit to use static in singleton so it no longer needs to be overridden." [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [13:10:00] 10Wikimedia-Site-requests: vd: interwiki overwrites VD: shortcuts on ca.wikiquote - https://phabricator.wikimedia.org/T153545#2883733 (10Unapersona) [13:13:09] 10Wikimedia-Site-requests: vd: interwiki overwrites VD: shortcuts on ca.wikiquote - https://phabricator.wikimedia.org/T153545#2883733 (10Urbanecm) I don't think this will be processed. I think much better will be to rename the shortcuts to WQ prefix and this WQ will be set as an alias for Wikiquote namespace. [13:13:30] 10Wikimedia-Site-requests: vd: interwiki overwrites VD: shortcuts on ca.wikiquote - https://phabricator.wikimedia.org/T153545#2883747 (10Urbanecm) p:05Triage>03Low Any change won't be needed in 14 days or so. [13:17:25] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General-or-Unknown, 06Front-end-Standards-Group, 13Patch-For-Review, 07RfC: Switch to eslint for our linting and our code styling - https://phabricator.wikimedia.org/T118941#2883753 (10Paladox) Are we sure that will work because I thougt a dep will n... [13:23:52] (03PS1) 10Paladox: Update to match vector changes [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327933 [13:27:31] (03PS2) 10Paladox: Update to match vector changes [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327933 [13:28:34] (03CR) 10Paladox: [C: 032] Update to match vector changes [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327933 (owner: 10Paladox) [13:29:26] (03Merged) 10jenkins-bot: Update to match vector changes [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327933 (owner: 10Paladox) [13:34:59] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2883761 (10Ladsgroup) [13:35:20] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2862861 (10Ladsgroup) @Volker_E Added [13:37:15] (03PS12) 10Cenarium: Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 [13:44:13] (03CR) 10jenkins-bot: [V: 04-1] Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [13:53:24] 10MediaWiki-Internationalization, 07I18n, 07Tracking: Unicode (UTF-8, utf8) compatibility (tracking) - https://phabricator.wikimedia.org/T5969#2883795 (10Liuxinyu970226) [13:53:37] 10MediaWiki-Internationalization, 07I18n, 07Tracking: Unicode (UTF-8, utf8) compatibility (tracking) - https://phabricator.wikimedia.org/T5969#81386 (10Liuxinyu970226) [13:53:53] 10MediaWiki-Internationalization, 07I18n, 07Tracking: Unicode (UTF-8, utf8) compatibility (tracking) - https://phabricator.wikimedia.org/T5969#81386 (10Liuxinyu970226) Transition failed, afaik [13:56:45] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 3 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2883802 (10Pppery) [14:01:03] 10Wikimedia-Site-requests, 07Tracking: robots.txt (tracking) - https://phabricator.wikimedia.org/T16720#2883821 (10Liuxinyu970226) [14:06:13] (03CR) 10LukBukkit: [] Removed usages of a deprecated method: Revision::getText (033 comments) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [14:07:25] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2883834 (10Ladsgroup) [14:08:12] (03PS4) 10Ladsgroup: Modernize MassMassage design (a little) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) [14:09:41] (03CR) 10jenkins-bot: [V: 04-1] Modernize MassMassage design (a little) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) (owner: 10Ladsgroup) [14:09:49] (03CR) 10Ladsgroup: [] "@legoktm: Done." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) (owner: 10Ladsgroup) [14:15:06] (03PS5) 10Ladsgroup: Modernize MassMassage design (a little) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) [14:24:02] (03PS13) 10Cenarium: Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 [14:31:24] (03PS1) 10Jack Phoenix: Fix the displaying of permanent blocks' expiries in the list of currently active blocks [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/327934 [14:33:30] (03CR) 10Jack Phoenix: [C: 032] Fix the displaying of permanent blocks' expiries in the list of currently active blocks [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/327934 (owner: 10Jack Phoenix) [14:33:55] (03CR) 10Aaron Schulz: [C: 032] Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [14:34:46] (03Merged) 10jenkins-bot: Fix the displaying of permanent blocks' expiries in the list of currently active blocks [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/327934 (owner: 10Jack Phoenix) [14:36:59] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2883858 (10Ibrahim.ID) we have experienced users in css and MediaWiki codes, so don't worry about the appearance, of course we will test it all OS and platform... [14:37:08] (03CR) 10Cenarium: [] "Hm... I had some doubts as to whether a static variable inside a static function inherited by a subclass was specific to the subclass or s" [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [14:44:14] (03PS1) 10Umherirrender: Fix path in $wgMessagesDirs [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 [14:45:44] (03CR) 10jenkins-bot: [V: 04-1] Fix path in $wgMessagesDirs [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [14:55:08] 06Wikipedia-Android-App-Backlog: Identify the namespaces of articles and use it to avoid certain unwanted processing on a few namespaces - https://phabricator.wikimedia.org/T153460#2883865 (10Kaartic) I guess this could even help in preventing the user from adding the descriptions to Wikidata for User pages, Cat... [14:55:12] (03CR) 10Paladox: [C: 031] Fix path in $wgMessagesDirs [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [14:57:08] (03CR) 10Reedy: [] "Well, unless you need to support MW < 1.21, you should be removing this old hook" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326550 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [14:58:48] (03CR) 10Reedy: [C: 04-1] Removed usages of a deprecated method Revision::getText (031 comment) [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [15:01:22] (03CR) 10Sn1per: [C: 031] mediawiki.special.watchlist: Fix render stampede after "Mark all pages visited" [core] - 10https://gerrit.wikimedia.org/r/327903 (owner: 10Krinkle) [15:09:07] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of JavaScript - https://phabricator.wikimedia.org/T148911#2883868 (10Sophivorus) @srishakatux Hi, thanks but even though I'd love to, I won't be able to attend the Summit (read comments above). Some weeks ago I... [15:09:26] (03PS6) 10Cenarium: Set stable revision as cached revision for stable parser cache [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/277945 [15:20:39] (03CR) 10Umherirrender: [] "Test failure seems unrelated" [extensions/Configure] - 10https://gerrit.wikimedia.org/r/327935 (owner: 10Umherirrender) [15:22:56] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: Minor followup to user-group "editor", add "autoreview " as implicit group - https://phabricator.wikimedia.org/T153548#2883869 (10Perhelion) [15:24:16] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: Minor followup to user-group "editor", add "autoreview " as implicit group - https://phabricator.wikimedia.org/T153548#2883884 (10Perhelion) [15:28:16] 10MediaWiki-General-or-Unknown, 07Easy, 03Google-Code-In-2016, 07NewPHP, 13Patch-For-Review: Use of &$this in hooks triggers warnings in PHP 7.1 - https://phabricator.wikimedia.org/T153505#2883893 (10Aklapper) >>! In T153505#2882758, @Legoktm wrote: > I guess this could be a GCI task? Who would like to... [15:28:20] 10MediaWiki-extensions-TemplateSandbox, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T149009#2883895 (10Amire80) [15:30:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fixing mediawiki's য় problem [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) (owner: 10Aftab) [15:32:53] 10MediaWiki-extensions-Translate, 06translatewiki.net, 07Easy, 03Google-Code-In-2016: Refactor Translate $1 Insertable classes - https://phabricator.wikimedia.org/T152837#2883899 (10Aklapper) [15:34:32] 10MediaWiki-extensions-Translate, 06translatewiki.net, 07Easy, 03Google-Code-In-2016: Refactor Translate $1 Insertable classes - https://phabricator.wikimedia.org/T152837#2861632 (10Aklapper) Thanks! Imported as https://codein.withgoogle.com/tasks/4740566749282304/ [15:40:13] (03Merged) 10jenkins-bot: Fixing mediawiki's য় problem [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) (owner: 10Aftab) [15:42:01] tonythomas: Around? [15:44:27] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#2883907 (10Aklapper) [15:45:51] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#1642839 (10Aklapper) Thanks! Imported as https://codein.withgoogle.com/tasks/5558853045321728/ [15:48:05] (03PS4) 10Tjones: Move ambiguity detection into main TextCat module. [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) [15:50:04] (03CR) 10Tjones: [] "Thanks for the tip on the constants. Reformatting the README was easy, so I did it since I needed to upload another patch anyway." [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) (owner: 10Tjones) [15:59:34] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2883925 (10Aklapper) Is there some more information available for contributors, like where to look about "composer.json" and what linting is and h... [16:01:35] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2883929 (10Bawolff) >The general problem is that in certain cases, the requester want a feature on a WMF wiki (Wikipedia or any other proje... [16:07:01] 10Phabricator: Converting "See Also" Bugzilla links to Phabricator tasks - https://phabricator.wikimedia.org/T697#11795 (10Liuxinyu970226) >>! In T697#832567, @Quiddity wrote: > Works for me. :) From T46667#520663: `I94056ca2` works for you? [16:12:45] (03CR) 10LukBukkit: [] "@Reedy Should I keep this null check or not?" [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [16:30:20] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: Minor followup to user-group "editor", add "autoreview " as implicit group - https://phabricator.wikimedia.org/T153548#2883946 (10Aklapper) This task does not really explain what the problem or suggestion is? Or is it the "add 'autoreview' as... [16:35:48] 10MediaWiki-extensions-CodeMirror: Sometimes Enable/Disable button is broken - https://phabricator.wikimedia.org/T153528#2883947 (10Aklapper) Are there any errors in the Developer Tools' console of your web browser when this happens? [16:43:22] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2883950 (10Anomie) Do we still use these covering indexes? I don't see the index described in T6715#90818 on `enwiki.revision` on any of db... [16:47:59] 10grrrit-wm, 13Patch-For-Review: Add quit message when grrrit-wm receieves a force-restart - https://phabricator.wikimedia.org/T151508#2883953 (10Aklapper) @Zppix: In that case you should explicitly ask a question and use a question mark. :) [16:50:01] 10NewSignupPage, 10Social-Tools: NewSignupPage should provide a separate configuration to let you customize the link to the policy - https://phabricator.wikimedia.org/T153525#2883954 (10SamanthaNguyen) Alright, that makes sense. [16:50:37] 10Recommendation-API, 10Security-Reviews: Security review for Recommendation API - https://phabricator.wikimedia.org/T148133#2883955 (10Bawolff) Sorry that this took so long. I lack experience with python and riot which caused me to take more time than I normally would. Overall, this looks good. By and large... [16:51:20] 10MediaWiki-Interface, 07Easy, 03Google-Code-In-2016: Add id attribute to error messages - https://phabricator.wikimedia.org/T20819#2883957 (10Aklapper) To better understand the scope here, this is only about wrapping `mw-error-cannotundelete`? Or are patch contributors expected to find more such cases them... [16:54:35] 07Design, 10MediaWiki-HTMLForm, 10MediaWiki-Special-pages, 07Easy, 13Patch-For-Review: Checkboxes on Special:BotPasswords should be shown on the left the label - https://phabricator.wikimedia.org/T150079#2883974 (10Volker_E) @Huji I was thinking the same in the beginning. But then there are two outcomes,... [16:54:58] 10The-Wikipedia-Library: Have a Testing server - https://phabricator.wikimedia.org/T147471#2883977 (10ThatAndromeda) I've requested this at T153549 ; once that resolves I can start installing & configuring things. [16:59:03] 10RandomGameUnit, 10Social-Tools: Reduce the amount of dependencies required for RandomGameUnit to function properly - https://phabricator.wikimedia.org/T153524#2883980 (10SamanthaNguyen) 05Open>03Resolved a:03SamanthaNguyen Ah alright, I was confused because there wasn't any note under the Requirements... [16:59:16] (03CR) 10Anomie: Add ILocalizedException interface (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325984 (owner: 10Anomie) [17:02:55] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2883985 (10ThatAndromeda) [17:02:58] 10The-Wikipedia-Library: Policy on handling gender in language - https://phabricator.wikimedia.org/T147464#2883983 (10ThatAndromeda) 05Open>03Resolved OK, I've updated the translator instructions (in `locale/README.md`). [17:05:04] 10MediaWiki-API, 07Easy: API RevisionDelete forces old-style booleans - https://phabricator.wikimedia.org/T153518#2883987 (10Anomie) This should be fixed, even though it's a breaking change for `formatversion=2` users. [17:06:11] 10Challenge, 10Social-Tools: Replace Challenge's userPageIcon.jpg to a WikiFont svg - https://phabricator.wikimedia.org/T153550#2883991 (10SamanthaNguyen) [17:06:26] 10Challenge, 10Social-Tools: Replace Challenge's userPageIcon.jpg with a WikiFont svg - https://phabricator.wikimedia.org/T153550#2883991 (10SamanthaNguyen) [17:16:08] 07Design, 10MediaWiki-HTMLForm, 10MediaWiki-Special-pages, 07Easy, 13Patch-For-Review: Checkboxes on Special:BotPasswords should be shown on the left the label - https://phabricator.wikimedia.org/T150079#2884006 (10Huji) To unmark T152532 as duplicate is not a big deal. In fact, perhaps that is exactly w... [17:16:35] 10The-Wikipedia-Library: Improve behaviour of description and collections fields - https://phabricator.wikimedia.org/T149997#2884008 (10ThatAndromeda) [17:16:39] 10The-Wikipedia-Library: Allow addition of hyperlinks to description and collections fields - https://phabricator.wikimedia.org/T150000#2884007 (10ThatAndromeda) 05Open>03Resolved [17:17:05] 10MediaWiki-HTMLForm, 10UI-Standardization, 10OOjs-UI: HTMLCheckMatrix checkboxes and labels are not clearly visually associated - https://phabricator.wikimedia.org/T152532#2884009 (10Huji) 05duplicate>03Open [17:18:25] (03PS1) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [17:19:18] (03PS2) 10Huji: Improve visual association of elements in OOjs UI HTMLForm matrix [core] - 10https://gerrit.wikimedia.org/r/327849 (https://phabricator.wikimedia.org/T152532) (owner: 10VolkerE) [17:19:46] 10MediaWiki-HTMLForm, 10UI-Standardization, 10OOjs-UI, 13Patch-For-Review: HTMLCheckMatrix checkboxes and labels are not clearly visually associated - https://phabricator.wikimedia.org/T152532#2851864 (10Huji) I reopened this bug. It was initially described using Special:BotPasswords as an example; that wa... [17:20:06] 10MediaWiki-Vagrant, 06Analytics-Kanban: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2884016 (10mschwarzer) @Physikerwelt @Ottomata I was able to run Flink jobs on YARN (see https://wikitech.wikimedia.org/wiki/Flink ). However, I could not enable Oovie / Hive usi... [17:20:54] (03PS1) 10Jack Phoenix: SQL injections, DOS vectors, XSS and oh my! [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/327937 (https://phabricator.wikimedia.org/T152884) [17:20:57] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2884017 (10Reedy) Copy pasta from another extension for 99% of it [17:24:15] (03PS2) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [17:29:13] 10SiteMetrics, 10Social-Tools: Lowercase i18n strings for consistency with other extensions in Challenge - https://phabricator.wikimedia.org/T153551#2884020 (10SamanthaNguyen) [17:29:33] 10SiteMetrics, 10Social-Tools: Lowercase i18n strings for consistency with other extensions in SiteMetrics - https://phabricator.wikimedia.org/T153551#2884020 (10SamanthaNguyen) [17:35:47] (03CR) 10Brian Wolff: [C: 032] SQL injections, DOS vectors, XSS and oh my! [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/327937 (https://phabricator.wikimedia.org/T152884) (owner: 10Jack Phoenix) [17:38:17] (03Merged) 10jenkins-bot: SQL injections, DOS vectors, XSS and oh my! [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/327937 (https://phabricator.wikimedia.org/T152884) (owner: 10Jack Phoenix) [18:03:20] (03CR) 10Fomafix: [C: 031] mediawiki.special.watchlist: Fix render stampede after "Mark all pages visited" [core] - 10https://gerrit.wikimedia.org/r/327903 (owner: 10Krinkle) [18:09:39] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2884038 (10Bawolff) So, as far as I understand, the issues with just expanding the *_comment fields: * Makes indexes/table storage potenti... [18:43:20] (03PS3) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [18:44:54] (03PS4) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [18:51:23] (03Draft1) 10Paladox: Bump version to 6.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327938 [18:52:19] (03PS2) 10Paladox: Bump version to 6.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327938 [18:52:24] (03CR) 10Paladox: [C: 032] Bump version to 6.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327938 (owner: 10Paladox) [18:52:32] (03PS1) 10Paladox: Bump version to 6.0 [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327939 [18:52:38] (03CR) 10Paladox: [C: 032] Bump version to 6.0 [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327939 (owner: 10Paladox) [18:53:17] (03Draft1) 10Paladox: MW 1.27: Bump version to 5.0 [skins/Metrolook] (REL1_27) - 10https://gerrit.wikimedia.org/r/327940 [18:53:28] (03PS2) 10Paladox: MW 1.27: Bump version to 5.0 [skins/Metrolook] (REL1_27) - 10https://gerrit.wikimedia.org/r/327940 [18:53:37] (03Merged) 10jenkins-bot: Bump version to 6.0 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327938 (owner: 10Paladox) [18:54:42] (03Merged) 10jenkins-bot: Bump version to 6.0 [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327939 (owner: 10Paladox) [18:56:04] (03PS3) 10Paladox: MW 1.27: Bump version to 5.0 [skins/Metrolook] (REL1_27) - 10https://gerrit.wikimedia.org/r/327940 [18:56:10] (03CR) 10Paladox: [C: 032] MW 1.27: Bump version to 5.0 [skins/Metrolook] (REL1_27) - 10https://gerrit.wikimedia.org/r/327940 (owner: 10Paladox) [18:57:37] (03Draft2) 10Paladox: Update README [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327941 [18:57:51] (03Draft1) 10Paladox: Update README [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327941 [18:57:55] (03CR) 10Paladox: [C: 032] Update README [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327941 (owner: 10Paladox) [18:57:57] (03Merged) 10jenkins-bot: MW 1.27: Bump version to 5.0 [skins/Metrolook] (REL1_27) - 10https://gerrit.wikimedia.org/r/327940 (owner: 10Paladox) [19:00:07] (03Merged) 10jenkins-bot: Update README [skins/Metrolook] (REL1_28) - 10https://gerrit.wikimedia.org/r/327941 (owner: 10Paladox) [19:00:40] (03Draft1) 10Paladox: Bump version to 7.0 alpha 1 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327942 [19:00:42] (03Draft2) 10Paladox: Bump version to 7.0 alpha 1 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327942 [19:00:47] (03CR) 10Paladox: [C: 032] Bump version to 7.0 alpha 1 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327942 (owner: 10Paladox) [19:01:00] (03PS5) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [19:01:42] (03Merged) 10jenkins-bot: Bump version to 7.0 alpha 1 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327942 (owner: 10Paladox) [19:02:01] (03PS6) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [19:02:30] (03PS7) 10Paladox: Re organise Metrolook skin [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/327936 [19:13:16] (03PS1) 10Aaron Schulz: Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 [19:13:18] (03PS1) 10Aaron Schulz: Remove the old abuse filter parser class [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 [19:14:32] (03CR) 10jenkins-bot: [V: 04-1] Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 (owner: 10Aaron Schulz) [19:17:06] (03PS2) 10Aaron Schulz: Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 [19:17:58] (03CR) 10jenkins-bot: [V: 04-1] Remove the old abuse filter parser class [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327945 (owner: 10Aaron Schulz) [19:21:01] (03CR) 10jenkins-bot: [V: 04-1] Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 (owner: 10Aaron Schulz) [19:22:03] 10MediaWiki-Interface, 07Easy, 03Google-Code-In-2016: Add id attribute to error messages - https://phabricator.wikimedia.org/T20819#2884095 (10Florian) No, let's do just the one for now! :) [19:24:51] 06Wikipedia-Android-App-Backlog, 07Easy, 07WorkType-NewFunctionality: Improve error handling in Featured Article widget. - https://phabricator.wikimedia.org/T121410#2884098 (10FleetAdmiral) Hey! I'd like to start contributing to the project and think this is a good place to start. Could i take up this issue? [19:25:39] legoktm: please read my pm [19:26:00] 07Community-Wishlist-Survey-2015: A powerful, handy TemplateTiger - https://phabricator.wikimedia.org/T120767#2884099 (10Kolossos) I take I look in my old php-code of templatetiger and must say that it's horrible. There are wild string-construction to generate sql-queries. It's simply not to modify anymore. I th... [19:27:45] (03PS3) 10Aaron Schulz: Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 [19:31:27] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog, 07WorkType-Maintenance, 07WorkType-NewFunctionality: Make login link in edit confirmation screen more prominent - https://phabricator.wikimedia.org/T118997#1815121 (10FleetAdmiral) Hey! I'd like to begin contributing to the project and would l... [19:31:43] (03CR) 10jenkins-bot: [V: 04-1] Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 (owner: 10Aaron Schulz) [19:40:20] (03PS4) 10Aaron Schulz: Move various classes to their own files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/327944 [19:46:00] (03PS3) 10LukBukkit: Removed usages of a deprecated method Revision::getText [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/327916 (https://phabricator.wikimedia.org/T151973) [19:58:48] (03PS1) 10Karima Rafes: Fix for Fuseki [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/327946 [20:00:42] Georggi: yeah! now I am. Go on! [20:00:45] (03PS4) 10LukBukkit: Removed usages of a deprecated method: Revision::getText [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) [20:02:59] (03CR) 10Karima Rafes: [V: 032 C: 032] Fix for Fuseki [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/327946 (owner: 10Karima Rafes) [20:06:57] (03CR) 10LukBukkit: [] "I decided to remove the null check, because the Revision::getText() method doesn't include it also." [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327925 (https://phabricator.wikimedia.org/T151973) (owner: 10LukBukkit) [20:09:15] 10MediaWiki-Internationalization, 07Bengali-Sites, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): $magicWords translation in Bengali - https://phabricator.wikimedia.org/T151134#2884117 (10Aftabuzzaman) [20:09:18] 10MediaWiki-Internationalization, 07Bengali-Sites, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): $magicWords with য় (U+09DF) does not seem to be working - https://phabricator.wikimedia.org/T153132#2884115 (10Aftabuzzaman) 05Open>03Resolved a:03Aftabuzzaman [20:10:56] 10MediaWiki-extensions-ContentTranslation, 07Bengali-Sites, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: Special:CX does not seem to be working on Bangla Wikipedia - https://phabricator.wikimedia.org/T152956#2884118 (10Aftabuzzaman) 05Open>03Resolved [20:18:25] tonythomas, what is supposed to happen when you go to to Special:Newsletter/id for the task to be accepted? [20:19:06] Georggi: simply, the user should not land up there. If the user lands up there, redirect to Newsletter:Foo (Foo is the corresponding newsletter to id) [20:19:59] 10MediaWiki-extensions-OATHAuth, 07Easy: 2FA textbox for the 6 digit code must always be LTR - https://phabricator.wikimedia.org/T153556#2884121 (10Huji) [20:20:07] 10MediaWiki-extensions-OATHAuth, 07Easy: 2FA textbox for the 6 digit code must always be LTR - https://phabricator.wikimedia.org/T153556#2884134 (10Huji) p:05Triage>03Lowest [20:20:46] Is it possible for a mailing list to be created for a tool out of curiousity [20:20:58] Ive not done any looking im just curious [20:22:56] (03PS2) 10IvanFon: Updated Cargo maintenance scripts to use $this->requireExtension() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327901 (https://phabricator.wikimedia.org/T152139) [20:24:13] (03PS2) 10IvanFon: Updated maintenance scripts to use $this->requireExtension() [extensions/Math] - 10https://gerrit.wikimedia.org/r/327898 (https://phabricator.wikimedia.org/T152139) [20:43:10] Addshore: Can you finally review/merge it? https://gerrit.wikimedia.org/r/#/c/324528 [20:43:13] addshore: [20:47:47] tonythomas: Around? [20:55:12] MtDu: Yup! tell me [20:56:58] tonythomas: I want to work on the new newsletter stuff you put up. But I'm currently working on something, so don't know if I should abandon it and then go back to it. :p How long will you be around? [20:56:59] 10MediaWiki-File-management, 06Commons, 06Multimedia: Document current clients which use thumb URLs as an API - https://phabricator.wikimedia.org/T153498#2884141 (10matmarex) [20:57:17] MtDu: heh. I would be here and there. dont worry :) [20:57:27] but I think we have like 4 new tasks up, so dont worry! [20:57:59] tonythomas: Ok. Well, three of them have been claimed i guess. :p :( [20:59:44] MtDu: oops. I didnt notice that :D [21:02:30] tonythomas: Well, I hope I can claim the last one. I can't right now though. :p [21:02:59] MtDu: alrught. no worries, more would be coming up soon! [21:10:06] 10MediaWiki-extensions-Page_Forms: Googlemaps input - (1) use other inputs for geocoding, (2) hide "set marker" button - https://phabricator.wikimedia.org/T153032#2884160 (10Jonathan3) Thanks. I'd be happy to have a go at this, though if I try to spend time on it before Christmas I might not survive to tell the... [21:21:45] (03PS1) 10Dereckson: Avoid to hardcode /srv/mediawiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/327980 [21:24:26] (03CR) 10Florianschmidtwelzow: [C: 04-1] "The message recentchanges-fieldset-filter is visible when the pageis loaded and the filter options box is uncollapsed, which results in tw" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [21:25:01] 10MediaWiki-extensions-Other: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884167 (10labster) [21:25:03] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2884166 (10Volker_E) What was the intention of the rounded corners (half circle) – indicating to be connec... [21:26:59] 10MediaWiki-extensions-Translate, 06Collaboration-Team-Triage, 10Notifications: Links added on translateable pages result in multiple notifications, for every language - https://phabricator.wikimedia.org/T153558#2884179 (10matmarex) [21:29:08] 10MediaWiki-extensions-Other: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884167 (10Paladox) See https://gerrit.wikimedia.org/r/#/c/325799/ please. Already fixed in master branch. [21:29:31] 10MediaWiki-extensions-General-or-Unknown: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884206 (10Paladox) [21:29:45] 10MediaWiki-extensions-General-or-Unknown: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884167 (10Paladox) [21:29:49] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock() - https://phabricator.wikimedia.org/T152605#2884209 (10Paladox) [21:38:56] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/327965 (owner: 10L10n-bot) [21:39:57] 10Phabricator (Upstream), 07Upstream: Phabricator batch edittor should support mass moving tasks to different sections of the workboard - https://phabricator.wikimedia.org/T153324#2884216 (10MarcoAurelio) Hmm. It seems that the Upstream task is set to work with Herald rules only. The best description of what I... [21:43:05] 10MediaWiki-extensions-Babel: Babel language codes should be normalised to lower case when used in categories - https://phabricator.wikimedia.org/T63993#2884217 (10Ningauble) I have blocked the bot account at en.wikiquote because this is //still// happening. Other wikis will have to fend for themselves. Please... [21:58:11] (03CR) 10Umherirrender: [] "check experimental" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [22:22:18] (03CR) 10Alex Monk: "bump random commit to test bot" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/283944 (owner: 10Luke081515) [22:27:08] (03CR) 10Florianschmidtwelzow: [C: 032] mediawiki.special.watchlist: Fix render stampede after "Mark all pages visited" [core] - 10https://gerrit.wikimedia.org/r/327903 (owner: 10Krinkle) [22:27:29] (03PS1) 10Umherirrender: Add empty metadata block to i18n files for banana check [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/328015 [22:28:17] (03CR) 10Umherirrender: [] "Last fixes in Iec3fef22db48c33ade87d95c1d2b7549034a376f" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/320596 (https://phabricator.wikimedia.org/T150332) (owner: 10Hashar) [22:35:09] (03Merged) 10jenkins-bot: mediawiki.special.watchlist: Fix render stampede after "Mark all pages visited" [core] - 10https://gerrit.wikimedia.org/r/327903 (owner: 10Krinkle) [22:36:25] (03PS1) 10Umherirrender: Add empty metadata block to i18n files for banana check [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/328016 [22:43:45] 10MediaWiki-extensions-General-or-Unknown: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884253 (10labster) 05duplicate>03declined If you're not going to fix the problem, don't just close the ticket resolved. I'm taking this to mean that you... [22:45:04] (03PS1) 10Umherirrender: Fix @metadata in i18n files [extensions/ParentPage] - 10https://gerrit.wikimedia.org/r/328017 [22:46:04] (03PS1) 10Umherirrender: Add empty @metadata to i18n file for banana check [extensions/QuickSearchLookup] - 10https://gerrit.wikimedia.org/r/328018 [22:46:25] 10MediaWiki-extensions-General-or-Unknown: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884256 (10Paladox) It is fixed, if you look at the link and the task this is merged into. Just no one has merged the fix on the REL1_28 branch. If you carn't... [22:46:54] (03CR) 10jenkins-bot: [V: 04-1] Add empty @metadata to i18n file for banana check [extensions/QuickSearchLookup] - 10https://gerrit.wikimedia.org/r/328018 (owner: 10Umherirrender) [22:48:50] (03CR) 10Umherirrender: [] "Test failure unrelated" [extensions/QuickSearchLookup] - 10https://gerrit.wikimedia.org/r/328018 (owner: 10Umherirrender) [22:49:17] (03PS1) 10Umherirrender: Add empty metadata block to i18n files for banana check [extensions/MadLib] - 10https://gerrit.wikimedia.org/r/328019 [22:49:48] 10MediaWiki-extensions-General-or-Unknown: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28 - https://phabricator.wikimedia.org/T153557#2884270 (10labster) Ah, OK. You just said "already fixed in master" and assigned a duplicate task, but didn't say that there was a fix for this branch. I as... [22:50:20] (03PS1) 10Umherirrender: Add empty metadata block to i18n files for banana check [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/328020 [23:01:46] (03PS1) 10Mglaser: Tests: Added to BlueSpice group [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/328022 [23:07:06] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-FlaggedRevs: Minor followup to user-group "editor", add "autoreview " as implicit group - https://phabricator.wikimedia.org/T153548#2884271 (10Perhelion) @Aklapper: For example (the API give us): ``` { "userid": 45468,... [23:17:18] (03CR) 10Mglaser: [C: 032] "Just a comment / annotation update, which I desperately need for a test run. So +2 myself here." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/328022 (owner: 10Mglaser) [23:18:42] (03Merged) 10jenkins-bot: Tests: Added to BlueSpice group [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/328022 (owner: 10Mglaser) [23:25:38] (03PS1) 10Georggi199: Removed usage of old SpecialPage code for viewing the page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/328023 (https://phabricator.wikimedia.org/T152678) [23:29:09] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2884276 (10Ladsgroup) I say let's go even further and use `errorbox` in mediawiki instead, so in that case... [23:35:47] (03PS1) 10Divadsn: LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) [23:36:08] Yay, finally got it up \o/ [23:37:17] (03CR) 10jenkins-bot: [V: 04-1] LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) (owner: 10Divadsn) [23:39:11] jenkins is funny, Failed asserting that 'api.php?action=linkfilter&id=37&status=2' starts not with "api.php?", am I blind or is it wrong? [23:40:23] (03PS2) 10Divadsn: LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) [23:40:55] (03CR) 10Divadsn: [] "Still did not manage to fix the file permission issue with Samba, time to do it right now :D" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) (owner: 10Divadsn) [23:41:15] (03CR) 10jenkins-bot: [V: 04-1] LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) (owner: 10Divadsn) [23:42:55] (03PS6) 10Ladsgroup: Modernize MassMassage design (a little) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) [23:48:23] (03PS3) 10Divadsn: LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) [23:48:45] (03Draft1) 10Paladox: Remove grrrit-wm: force-restart [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/328025 [23:48:48] (03Draft2) 10Paladox: Remove grrrit-wm: force-restart [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/328025 [23:49:31] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016, 07I18n, 13Patch-For-Review: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2884287 (10divadsn) Patch is on Gerrit, thanks to jenkins-bot I found the mistake that I had forgotten to remove. [23:50:32] (03PS4) 10Divadsn: LinkFilter missing api i18n messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/328024 (https://phabricator.wikimedia.org/T153238) [23:57:54] 10The-Wikipedia-Library: Allow addition of hyperlinks to description and collections fields - https://phabricator.wikimedia.org/T150000#2884288 (10Samwalton9) @ThatAndromeda How do the hyperlinks work? Can we link text, or is it just that entered URLs turn into links? Thanks!