[00:00:45] (03Abandoned) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/317374 (owner: 10Paladox) [00:01:45] (03PS14) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [00:03:39] (03Merged) 10jenkins-bot: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327393 (https://phabricator.wikimedia.org/T153261) (owner: 1020after4) [00:03:46] (03Merged) 10jenkins-bot: Record totals in categories in statsd [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325892 (https://phabricator.wikimedia.org/T152664) (owner: 10Legoktm) [00:05:02] (03PS5) 10Pmiazga: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) [00:08:25] (03CR) 10Ppchelko: [] "In Docker you have the env variable `IN_DOCKER`, CI should have something similar, so you could bump the timeout conditionally on those va" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND) [00:08:32] (03Merged) 10jenkins-bot: Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [00:09:44] (03PS1) 10Kaldari: Adding IGNORE in case 2 records for the same project are added at once [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327399 (https://phabricator.wikimedia.org/T152080) [00:10:28] (03CR) 10BearND: [C: 04-1] Add additional information to file and user pages for rendering (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [00:11:01] (03CR) 10BearND: [C: 04-1] Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [00:11:45] (03PS2) 10Ppchelko: Temporarily switch to non-flowing mode. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327378 (https://phabricator.wikimedia.org/T153122) [00:13:18] (03CR) 10jenkins-bot: [V: 04-1] Also show announcements on beta cluster [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327394 (owner: 10BearND) [00:14:34] 06Editing-Analysis: Add new wikitext editor column to editor month table - https://phabricator.wikimedia.org/T153274#2874934 (10Neil_P._Quinn_WMF) [00:14:46] 10MediaWiki-extensions-PageAssessments, 06Community-Tech, 13Patch-For-Review, 07Wikimedia-log-errors: Frequent duplicate key errors by page assessments - https://phabricator.wikimedia.org/T152080#2874946 (10kaldari) The existing code was only checking for the case where an assessment record was being added... [00:18:28] (03PS2) 10Kaldari: Adding IGNORE in case 2 records for the same project are added at once [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327399 (https://phabricator.wikimedia.org/T152080) [00:18:42] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), 07Wikimedia-log-errors: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappMan... - https://phabricator.wikimedia.org/T153250#2874085 [00:19:05] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review, 07Wikimedia-log-errors: Frequent duplicate key errors by page assessments - https://phabricator.wikimedia.org/T152080#2874952 (10kaldari) p:05Triage>03High [00:19:32] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review, 07Wikimedia-log-errors: Frequent duplicate key errors by page assessments - https://phabricator.wikimedia.org/T152080#2837553 (10kaldari) a:03kaldari [00:19:49] (03CR) 10Smalyshev: [C: 031] Cleanup execution flow through SpecialSearch::execute() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) (owner: 10EBernhardson) [00:20:32] (03PS6) 10Jdlrobson: Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) [00:21:04] (03CR) 10Jdlrobson: [] "Ive descoped. We can continue discussion around metadata later (wrapping up existing work in prep for vacation!)" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [00:22:20] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia/Wikimedia apps availability test: analyze results - https://phabricator.wikimedia.org/T146807#2874962 (10mpopov) @JKatzWMF Hi Jon! Sure here's the query I used: ```lang=sql SEL... [00:23:24] (03PS3) 10Kaldari: Adding IGNORE in case 2 records for the same project are added at once [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327399 (https://phabricator.wikimedia.org/T152080) [00:26:02] (03PS3) 10Chelsyx: Add geo breakdowns [wikimedia/discovery/prince] - 10https://gerrit.wikimedia.org/r/327139 (https://phabricator.wikimedia.org/T138107) [00:27:01] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), 07Wikimedia-log-errors: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappMan... - https://phabricator.wikimedia.org/T153250#2874967 [00:27:54] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove extracts.js [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327396 (owner: 10BearND) [00:28:07] (03CR) 10BearND: [C: 04-1] Add class to IPA container, do not use inline style (035 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [00:29:12] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 4 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874969 (10Jdlrobson) 05Open>03Resolved I have verified the icons are fixed on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?... [00:29:41] (03PS3) 10Bmansurov: Feature flag FontChanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) [00:30:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: remove extracts.js [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327396 (owner: 10BearND) [00:32:01] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work, and 2 others: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappManifest.php on line 31 - https://phabricator.wikimedia.org/T153250#2874972 (10bm... [00:32:27] 07Design, 10Hovercards (2016-17-Q2-Goal), 06Reading-Web-Backlog (Design): Make it more discoverable for users to turn hovercards on after disabling - https://phabricator.wikimedia.org/T128915#2874973 (10ovasileva) 05Open>03stalled Based on the current results from our [[ https://www.mediawiki.org/wiki/Be... [00:34:59] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy wikidata descriptions to mobile English Wikipedia stable - https://phabricator.wikimedia.org/T152743#2874980 (10ovasileva) [00:35:35] (03PS3) 10Cenarium: Defer changes matching specified thresholds [WIP] [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 [00:35:40] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy wikidata descriptions to Russian wikipedia - https://phabricator.wikimedia.org/T151342#2874985 (10ovasileva) 05Open>03stalled stalled based on community response [00:36:45] (03CR) 10Cenarium: [] Defer changes matching specified thresholds [WIP] (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (owner: 10Cenarium) [00:36:50] (03CR) 10jenkins-bot: [V: 04-1] Defer changes matching specified thresholds [WIP] [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (owner: 10Cenarium) [00:37:06] (03CR) 10Pmiazga: [] "Fixes after CR" (0312 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [00:37:18] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work, and 2 others: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappManifest.php on line 31 - https://phabricator.wikimedia.org/T153250#2874990 (10Ru... [00:37:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "No, I don't see one either. I guess we'll have to implement one? This is actually a bit hairy though, since you'd have to add such an opti" [core] - 10https://gerrit.wikimedia.org/r/325778 (https://phabricator.wikimedia.org/T150079) (owner: 10Huji) [00:38:06] (03PS1) 10Mattflaschen: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) [00:38:28] (03CR) 10jenkins-bot: [V: 04-1] Feature flag FontChanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) (owner: 10Bmansurov) [00:40:37] (03CR) 10Catrope: [C: 04-1] Allow to retrieve key in get (031 comment) [core] - 10https://gerrit.wikimedia.org/r/278608 (owner: 10Cenarium) [00:40:47] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 4 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874993 (10MtDu) @Jdlrobson For future reference, what is the login I can use to play around with things? I usually just use vagrant to... [00:42:34] (03CR) 10Smalyshev: [] "lgtm, except for some docs nitpicks. Not super-familiar with this code though, so review from somebody who is would help." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [00:42:46] (03CR) 10Smalyshev: [C: 031] Extract search form from SpecialSearch into widget [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [00:43:41] (03CR) 10Pmiazga: [C: 04-1] "-1 as I get Race condition and it fails with" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [00:44:27] (03CR) 10Catrope: [C: 031] "LGTM but I'd like someone with more parser / parser cache knowledge to look at this" [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [00:44:30] (03PS15) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [00:44:35] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 4 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874994 (10Jdlrobson) I'm not sure I understand. You can create an account on https://en.m.wikipedia.beta.wmflabs.org if you need to te... [00:45:00] (03CR) 10Catrope: [C: 031] "LGTM but I'd like someone with more parser knowledge to look at this" [core] - 10https://gerrit.wikimedia.org/r/279893 (owner: 10Cenarium) [00:45:21] (03PS1) 10Alex Monk: Update VisualEditor for I0dc6be0d, I0b43fd65, Ida6ffffa [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327403 [00:45:45] (03CR) 10Alex Monk: [C: 032] Update VisualEditor for I0dc6be0d, I0b43fd65, Ida6ffffa [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327403 (owner: 10Alex Monk) [00:49:14] (03PS2) 10Jack Phoenix: Avatars in page diff views [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/326074 [00:50:09] (03CR) 10jenkins-bot: [V: 04-1] Avatars in page diff views [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/326074 (owner: 10Jack Phoenix) [00:52:02] (03Draft1) 10Paladox: Fix submodules [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327406 [00:52:06] (03Draft2) 10Paladox: Fix submodules [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327406 [00:52:32] (03CR) 10Legoktm: [] "What is the purpose of this?" [core] - 10https://gerrit.wikimedia.org/r/279893 (owner: 10Cenarium) [00:54:01] 10Social-Tools, 10SocialProfile, 03Google-Code-In-2016, 07I18n: SocialProfile missing api i18n messages - https://phabricator.wikimedia.org/T153264#2874570 (10SamanthaNguyen) [00:54:30] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016, 07I18n: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2875002 (10SamanthaNguyen) [00:55:24] (03PS16) 10Jdlrobson: Make mobile-friendly version of the Notifications page left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [00:55:40] (03PS17) 10Jdlrobson: Make mobile-friendly version of the Notifications page left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [00:58:23] (03CR) 10Paladox: [] "recheck" [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326947 (https://phabricator.wikimedia.org/T152663) (owner: 10Hashar) [00:59:34] (03Merged) 10jenkins-bot: Update VisualEditor for I0dc6be0d, I0b43fd65, Ida6ffffa [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327403 (owner: 10Alex Monk) [01:00:36] (03PS9) 10Jdlrobson: Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) [01:00:43] (03CR) 1020after4: [C: 031] Fix submodules [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327406 (owner: 10Paladox) [01:01:13] (03CR) 1020after4: [C: 032] Fix submodules [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327406 (owner: 10Paladox) [01:01:35] (03CR) 1020after4: [V: 032 C: 032] Fix submodules [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327406 (owner: 10Paladox) [01:01:58] (03CR) 10Paladox: "@20after4 thanks :)" [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327406 (owner: 10Paladox) [01:02:30] (03CR) 10jenkins-bot: [V: 04-1] Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [01:02:40] 07Design, 10MobileFrontend, 06Reading-Web-Backlog (Design): "Back to top" button for pages that are long - https://phabricator.wikimedia.org/T151115#2875017 (10SamanthaNguyen) Hey, so sorry for not seeing this earlier! I shall add my comment on the other task you pointed out :) [01:04:02] (03CR) 10Fito: [C: 031] "Thanks!" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/327255 (https://phabricator.wikimedia.org/T153037) (owner: 10Florianschmidtwelzow) [01:04:05] (03Draft1) 10Paladox: Fix submodules for skins [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327408 [01:04:08] (03Draft2) 10Paladox: Fix submodules for skins [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327408 [01:04:11] (03CR) 10Smalyshev: [C: 04-1] "some small buglets" (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [01:04:15] (03CR) 10Bartosz Dziewoński: [] Pager class for filtering by date range (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) (owner: 10Sn1per) [01:04:22] (03CR) 10Bartosz Dziewoński: [C: 031] Date range filtering in Special:NewFiles [core] - 10https://gerrit.wikimedia.org/r/326476 (https://phabricator.wikimedia.org/T13836) (owner: 10Sn1per) [01:05:07] (03CR) 10Paladox: [] "Needs v+2 and remove jenkins vote." [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326947 (https://phabricator.wikimedia.org/T152663) (owner: 10Hashar) [01:05:12] 07Design, 10MobileFrontend, 06Reading-Web-Backlog (Design): "Back to top" button for pages that are long - https://phabricator.wikimedia.org/T151115#2875018 (10Nirzar) @SamanthaNguyen no worries. also it's very difficult to have feedback on the mocks itself so we are working on a quick prototype which can us... [01:05:55] (03PS10) 10Jdlrobson: Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) [01:06:02] (03CR) 10jenkins-bot: [V: 04-1] Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [01:06:47] (03CR) 10Jdlrobson: [] "That was painfull... hopefully worth it." (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [01:07:47] (03PS1) 10Legoktm: Add severity for error categories [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327410 (https://phabricator.wikimedia.org/T152822) [01:07:49] (03PS11) 10Jdlrobson: Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) [01:07:56] (03CR) 10Jdlrobson: [] "and rebase..." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [01:08:24] 10RW-Prototype, 06Reading-Web-Backlog (Design): Rethink in-article navigation on mobile web [Prototype] - https://phabricator.wikimedia.org/T149690#2759808 (10SamanthaNguyen) I would like to say I very much would appreciate such a function :) It's quite hard for scrolling even with just a back-to-top, because... [01:09:14] (03CR) 10Smalyshev: [C: 031] Extract 'did you mean' widget out of SpecialSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [01:09:51] 10MediaWiki-extensions-Linter, 13Patch-For-Review: Linter: introduce severity level for error categories - https://phabricator.wikimedia.org/T152822#2875027 (10Legoktm) a:03Legoktm [01:15:16] 10MediaWiki-General-or-Unknown: URL to pagenames with special characters fail - https://phabricator.wikimedia.org/T153275#2875030 (10Writ_Keeper) [01:19:15] (03CR) 10Smalyshev: [] Allow extensions to hook features (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [01:21:09] (03PS4) 10Smalyshev: Allow extensions to hook features [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) [01:21:42] 10MediaWiki-General-or-Unknown: URL to pagenames with special characters fail - https://phabricator.wikimedia.org/T153275#2875042 (10matmarex) [01:25:28] (03CR) 10Smalyshev: [] [WIP] Expose language classification of text via api (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326139 (owner: 10EBernhardson) [01:26:05] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2875047 (10Reedy) [01:26:39] 10GoogleLogin, 07I18n, 13Patch-For-Review: [[MediaWiki:Googlelogin-manage-notlinked/es]] i18n issue - https://phabricator.wikimedia.org/T153037#2875048 (10Fito) LGTM :) [01:26:46] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work): [Epic] Allow extensions to register simple keyword features - https://phabricator.wikimedia.org/T152517#2875049 (10Smalyshev) p:05Triage>03Normal [01:28:44] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2875051 (10Reedy) Article::getContent() ```lines=10 Method get... [01:30:25] (03CR) 10Chad: [C: 032] Fix submodules URL for Gerrit syncronisation [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326947 (https://phabricator.wikimedia.org/T152663) (owner: 10Hashar) [01:30:32] (03PS9) 10Aaron Schulz: Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [01:30:52] (03CR) 10Chad: [V: 032 C: 032] Fix submodules for skins [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327408 (owner: 10Paladox) [01:31:21] (03CR) 10Smalyshev: [C: 032] Do not return the current wikis when detecting query languages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/327031 (https://phabricator.wikimedia.org/T153051) (owner: 10DCausse) [01:31:47] (03CR) 10Chad: [] "No point, this extension doesn't work anyway." [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/315112 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:32:23] (03CR) 10Reedy: [C: 04-1] Replace ArticleSaveComplete hook usage (031 comment) [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/315110 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:33:37] (03CR) 10Reedy: [C: 04-1] Replace ArticleSaveComplete hook usage (031 comment) [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/315112 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:35:36] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/boost_template_api.feature:3:7:11:15:19:23 features/boolean_operators_api." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [01:35:41] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [01:35:49] (03PS1) 10Chad: Empty out dead extension [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/327415 [01:36:02] (03CR) 10Chad: [] "https://gerrit.wikimedia.org/r/#/c/327415/ instead" [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/315112 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [01:37:14] (03PS10) 10Aaron Schulz: Allow parser cache to expect another revision than the latest [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [01:37:22] (03Draft2) 10Ghybu: Bug T153233 [core] - 10https://gerrit.wikimedia.org/r/327412 [01:37:29] (03CR) 10Aaron Schulz: [C: 031] "LGTM with above changes" [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [01:37:51] (03CR) 10jenkins-bot: [V: 04-1] Empty out dead extension [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/327415 (owner: 10Chad) [01:39:00] (03CR) 10Chad: [] "Shut up Jenkins." [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/327415 (owner: 10Chad) [01:47:02] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Slideshow image width is hardcoded to 120px when inserting it but can be changed when trying to re-edit. - https://phabricator.wikimedia.org/T151512#2875098 (10Tanveer07) 05Open>03Resolved [01:47:31] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 07Verified, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Slideshow image width is hardcoded to 120px when inserting it but can be changed when trying to re-edit. - https://phabricator.wikimedia.org/T151512#2819852 (10Tanveer07) [01:50:16] 10MediaWiki-Internationalization: Diacritical letters (Çç, Êê, Îî, Şş, Ûû) on Kurdish pages do not become part of the internal link - https://phabricator.wikimedia.org/T153233#2875102 (10Ghybu) @Aklapper: [[https://gerrit.wikimedia.org/r/#/c/327412/2/languages/messages/MessagesKu_latn.php | Done]]. I also added... [01:52:55] (03PS1) 10Mattflaschen: FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) [01:54:04] (03CR) 10Legoktm: [C: 032] Use CentralIdLookup instead of hardcoding CentralAuth [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/317014 (owner: 10Legoktm) [01:55:20] (03Merged) 10jenkins-bot: Do not return the current wikis when detecting query languages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/327031 (https://phabricator.wikimedia.org/T153051) (owner: 10DCausse) [01:55:22] (03Merged) 10jenkins-bot: Use CentralIdLookup instead of hardcoding CentralAuth [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/317014 (owner: 10Legoktm) [01:55:25] (03CR) 10Catrope: [C: 031] Add echo notification when deferred (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316957 (owner: 10Cenarium) [01:56:54] (03CR) 10Legoktm: [] "Ping?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/313773 (owner: 10Legoktm) [01:57:15] (03CR) 10Catrope: [] Notify users of reviews (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [02:01:50] (03CR) 10Catrope: [C: 032] Make 'flow-skip-summary' clearer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/313773 (owner: 10Legoktm) [02:02:18] (03PS1) 10Mooeypoo: [wip] Create active/inactive behavior for complementary filters [core] - 10https://gerrit.wikimedia.org/r/327419 (https://phabricator.wikimedia.org/T149452) [02:04:52] (03PS1) 10Rudloff: Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327420 (https://phabricator.wikimedia.org/T153250) [02:08:34] 10MediaWiki-Installer, 07TestMe: cli php should check db modules - https://phabricator.wikimedia.org/T28492#2875127 (10fsgmhoward) I tested this bug once again. ``` # Current environment root@US1:~# php -r 'mysql_connect();' PHP Fatal error: Call to undefined function mysql_connect() in Command line code on l... [02:09:26] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create active/inactive behavior for complementary filters [core] - 10https://gerrit.wikimedia.org/r/327419 (https://phabricator.wikimedia.org/T149452) (owner: 10Mooeypoo) [02:10:17] (03Merged) 10jenkins-bot: Make 'flow-skip-summary' clearer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/313773 (owner: 10Legoktm) [02:14:48] 10MediaWiki-Interface, 10MediaWiki-User-blocking: Bring the CIDR calculator to MediaWiki core - https://phabricator.wikimedia.org/T152850#2875131 (10Huji) I am not sure. My intention is not to make CheckUser part of core. Instead, I want just the particular JavaScript module to be part of core.. [02:34:29] (03CR) 10Mattflaschen: [C: 04-1] FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [02:38:25] (03PS2) 10Mattflaschen: FlowFixInconsistentBoards: Run in update.php, fix updatelog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327417 (https://phabricator.wikimedia.org/T148057) [02:56:29] (03CR) 10Krinkle: [] Don't serialize useless StripStates and LinkHolders (031 comment) [core] - 10https://gerrit.wikimedia.org/r/279893 (owner: 10Cenarium) [02:59:38] 10MediaWiki-Installer, 07Tracking: CLI setup script (tracking) - https://phabricator.wikimedia.org/T12542#2875180 (10Krinkle) [02:59:40] 10MediaWiki-Installer, 07TestMe: cli php should check db modules - https://phabricator.wikimedia.org/T28492#2875178 (10Krinkle) 05Open>03Resolved a:03Krinkle [03:02:10] 10MediaWiki-Installer, 07TestMe: cli php should check db modules - https://phabricator.wikimedia.org/T28492#2875183 (10Krinkle) @fsgmhoward Thanks! I assume that means this issue can be closed. If you like, could you test your environment again with a more current version of the software? E.g. MediaWiki 1.27 o... [03:04:39] SMalyshev: hi, I got some problem with the last Updater in wikidata-query-distr [03:10:27] (03CR) 10Samwilson: [C: 032] Adding IGNORE in case 2 records for the same project are added at once [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327399 (https://phabricator.wikimedia.org/T152080) (owner: 10Kaldari) [03:10:51] (03CR) 10Krinkle: [] "The only calls to (un)serializeHalfParsedText are in Cite::referencesFormat() of the Cite extension." [core] - 10https://gerrit.wikimedia.org/r/279893 (owner: 10Cenarium) [03:11:35] (03Merged) 10jenkins-bot: Adding IGNORE in case 2 records for the same project are added at once [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327399 (https://phabricator.wikimedia.org/T152080) (owner: 10Kaldari) [03:21:04] (03CR) 10Pmiazga: [C: 04-1] "I found the race condition - WANObjectCache prepopulates User options before calling ExtensionFunctions. Because of our new `popups-enable" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [03:21:07] (03CR) 10Catrope: [C: 032] Autopromote: Remove superflous condition in APCOND_EDITCOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/264232 (owner: 10Cenarium) [03:32:10] (03Merged) 10jenkins-bot: Autopromote: Remove superflous condition in APCOND_EDITCOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/264232 (owner: 10Cenarium) [03:34:47] (03CR) 10Catrope: [] Don't always display review notice if autoreviewed, specify if autoreviewed (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255811 (https://phabricator.wikimedia.org/T60057) (owner: 10Cenarium) [03:40:01] (03CR) 10Catrope: [C: 04-1] Defer changes matching specified thresholds [WIP] (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (owner: 10Cenarium) [03:40:10] (03PS2) 10Samwilson: Re-index the array of excluded namespace IDs [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327141 (https://phabricator.wikimedia.org/T153165) [03:40:23] (03CR) 10Samwilson: [] Re-index the array of excluded namespace IDs (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327141 (https://phabricator.wikimedia.org/T153165) (owner: 10Samwilson) [03:41:58] (03CR) 10BearND: [C: 032] "Great. I think this is much simpler to follow now. Thank you!" (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [03:43:57] (03Merged) 10jenkins-bot: Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [03:51:36] 10MediaWiki-Page-deletion, 07TestMe: Unable to delete page containing "http://" in the title - https://phabricator.wikimedia.org/T24362#2875242 (10fsgmhoward) Bug retested. Steps ---- ``` # Get a clean source of latest 1.15.5 release of Mediawiki root@US1:~/dev# wget https://releases.wikimedia.org/mediawiki/1... [03:53:00] (03PS9) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [03:53:22] (03CR) 10Samwilson: [] "All fixed. Thanks!" (033 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [03:54:21] (03CR) 10Majr: Set $wgUserEmailUseReplyTo = true by default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326044 (https://phabricator.wikimedia.org/T66795) (owner: 10Legoktm) [04:07:59] (03PS1) 10Niedzielski: Hygiene: add AppTextViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327427 (https://phabricator.wikimedia.org/T152213) [04:09:04] 10Android-app-feature-Description-Editing, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Long Wikidata descriptions get clipped - https://phabricator.wikimedia.org/T152213#2875250 (10Niedzielski) @RHo, thank you for your super attention to detail!! I think this points to a bug in one of our b... [04:13:05] (03CR) 10Catrope: [C: 04-1] Defer changes matching specified thresholds [WIP] (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (owner: 10Cenarium) [04:14:02] (03CR) 10Krinkle: [] "Agreed. I'm thinking also about the use case of a developer in language A debugging something on a wiki with a content language B. (E.g. E" [core] - 10https://gerrit.wikimedia.org/r/323057 (https://phabricator.wikimedia.org/T127233) (owner: 10Gergő Tisza) [04:15:21] 10Wikimedia-Site-requests: Local upload on Kannada Wikipedia - https://phabricator.wikimedia.org/T133137#2875251 (10Ananthsubray) @Aklapper the policy page has been prepared, you can see in the following link https://kn.wikipedia.org/s/1mdf. [04:17:07] (03CR) 10Catrope: [C: 04-1] Notify users of reviews (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [04:17:57] (03CR) 10Catrope: [C: 04-1] Notify users of reviews (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [04:21:18] 10MediaWiki-extensions-FlaggedRevs, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled - https://phabricator.wikimedia.org/T54510#2875256 (10Catrope) This is what the notificati... [04:32:42] 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875305 (10Catrope) [04:33:33] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2875320 (10AndyRussG) Just checking the impression data in Hive... I... [04:39:43] 10MediaWiki-Categories, 06Discovery, 06Maps (Kartographer): Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2875392 (10Yurik) [04:40:20] 10MediaWiki-Configuration, 10MediaWiki-ContentHandler, 10Analytics-EventLogging, 10ArchCom-RfC, and 9 others: RFC: Use YAML instead of JSON for structured on-wiki content - https://phabricator.wikimedia.org/T147158#2875408 (10Yurik) [04:40:24] 07Design, 06Discovery, 06Maps (Kartographer): Show as a popup with darkened background - https://phabricator.wikimedia.org/T145480#2875414 (10Yurik) [04:40:49] 07Design, 06Discovery, 10VisualEditor, 06Maps (Kartographer): VE Map to support frame / frameless - https://phabricator.wikimedia.org/T143418#2875421 (10Yurik) [04:41:09] 10MediaWiki-extensions-Listings, 06Discovery, 10Wikidata, 06Maps (Kartographer): Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2875429 (10Yurik) [04:41:34] 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875447 (10Catrope) [04:41:38] 07Design, 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Define guidelines for positioning map controls - https://phabricator.wikimedia.org/T136982#2875453 (10Yurik) [04:41:46] 07Design, 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Design - Send a feedback / Report an error / Contribute to OSM - https://phabricator.wikimedia.org/T136986#2875452 (10Yurik) [04:42:10] 10MediaWiki-Uploading, 06Multimedia: Unexpected error "This SVG file contains an illegal namespace" for xmlns:rdfs attribute value - https://phabricator.wikimedia.org/T153285#2875470 (10Krinkle) [04:42:37] 10MediaWiki-extension-requests, 06Commons, 06Discovery, 06Maps (Kartographer): Generate location maps dynamically, producing actual images - https://phabricator.wikimedia.org/T120809#2875495 (10Yurik) [04:45:49] 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875498 (10Catrope) [04:50:31] 10MediaWiki-extensions-FlaggedRevs: Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875499 (10Catrope) The generic "info" icon in the screenshots above is temporary until we come up with something better. @Pginer-WMF: any ideas for an icon for this notification? @Ce... [04:51:42] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875501 (10Catrope) [04:56:29] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875503 (10Catrope) [04:56:31] 10MediaWiki-extensions-FlaggedRevs, 13Patch-For-Review: Allow to defer 'suspicious' edits for review on any page in a reviewable namespace ("Deferred changes") - https://phabricator.wikimedia.org/T118696#2875505 (10Catrope) [04:59:35] (03PS1) 10Legoktm: Drop pre-1.24 compat [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327430 [04:59:37] (03PS1) 10Legoktm: Add GPL file headers [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327431 [04:59:39] (03PS1) 10Legoktm: Add extension.json, deprecate PHP entry point [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327432 [04:59:41] (03PS1) 10Legoktm: Move tests in to tests/phpunit/ directory [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327433 [04:59:43] (03PS1) 10Legoktm: Improve extension description [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327434 [04:59:45] (03PS1) 10Legoktm: Add __METHOD__ to MWCallableUpdate [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327435 [04:59:47] (03PS1) 10Legoktm: Add Linter categories to action=query&meta=siteinfo [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327436 (https://phabricator.wikimedia.org/T153056) [04:59:49] (03PS1) 10Legoktm: Display count of lint errors on ?action=info [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327437 [05:00:20] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2875510 (10AndyRussG) >>! In T152602#2875320, @AndyRussG wrote: > It... [05:02:04] (03CR) 10jenkins-bot: [V: 04-1] Add Linter categories to action=query&meta=siteinfo [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327436 (https://phabricator.wikimedia.org/T153056) (owner: 10Legoktm) [05:02:43] (03CR) 10jenkins-bot: [V: 04-1] Display count of lint errors on ?action=info [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327437 (owner: 10Legoktm) [05:13:15] (03PS6) 10Sn1per: Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) [05:21:40] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: parenthesis_closer in SpaceBeforeControlStructureBraceSniff.php - https://phabricator.wikimedia.org/T146439#2875569 (10Legoktm) 05Open>03Resolved [05:48:58] (03PS1) 10Legoktm: Run phplint and phpcs with "composer test", and fix errors [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327443 [05:50:50] (03CR) 10Legoktm: [C: 032] Always show exceptions of type 'error' in LTR [core] - 10https://gerrit.wikimedia.org/r/326873 (https://phabricator.wikimedia.org/T153027) (owner: 10Huji) [05:53:43] (03CR) 10Legoktm: [C: 04-1] "The commit message needs to be improved to clearly state what is being changed here. "invisible" seems wrong because some colors are chang" [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [05:55:10] 10MediaWiki-API, 10MediaWiki-Database, 10DBA, 05MW-1.29-release-notes, and 4 others: ApiQueryExtLinksUsage::run query has crazy limit - https://phabricator.wikimedia.org/T59176#2875574 (10Krinkle) [05:55:19] (03CR) 10Legoktm: [C: 032] A full word instead of an acronym for the revid message [core] - 10https://gerrit.wikimedia.org/r/325675 (owner: 10Amire80) [05:55:59] (03CR) 10Legoktm: [C: 032] Escape return path extra params to php mail() [core] - 10https://gerrit.wikimedia.org/r/326260 (https://phabricator.wikimedia.org/T152717) (owner: 10Brian Wolff) [05:56:46] (03CR) 10Legoktm: [C: 032] Back off from job types longer for DB read-only errors [core] - 10https://gerrit.wikimedia.org/r/326244 (owner: 10Aaron Schulz) [05:59:25] (03CR) 10Krinkle: "fixme: Use PHP's own string escape. Why would it need to be decode from HTML or JSON? I agree the lilteral is a maintenance hazard, but do" [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [06:02:21] (03Merged) 10jenkins-bot: Always show exceptions of type 'error' in LTR [core] - 10https://gerrit.wikimedia.org/r/326873 (https://phabricator.wikimedia.org/T153027) (owner: 10Huji) [06:04:54] (03Merged) 10jenkins-bot: A full word instead of an acronym for the revid message [core] - 10https://gerrit.wikimedia.org/r/325675 (owner: 10Amire80) [06:05:59] (03Merged) 10jenkins-bot: Escape return path extra params to php mail() [core] - 10https://gerrit.wikimedia.org/r/326260 (https://phabricator.wikimedia.org/T152717) (owner: 10Brian Wolff) [06:11:04] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) [06:11:24] (03Merged) 10jenkins-bot: Back off from job types longer for DB read-only errors [core] - 10https://gerrit.wikimedia.org/r/326244 (owner: 10Aaron Schulz) [06:12:16] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [06:12:48] 10Mail, 13Patch-For-Review, 05Security: Fifth argument to php mail() function should be better escaped. - https://phabricator.wikimedia.org/T152717#2857917 (10Legoktm) Did you want to backport this? [06:14:32] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/327303 (https://phabricator.wikimedia.org/T151973) [06:17:04] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327289 (https://phabricator.wikimedia.org/T151973) [06:17:13] (03PS1) 10Krinkle: RELEASE-NOTES: Fixup for dfb50ab9f3 [core] - 10https://gerrit.wikimedia.org/r/327444 [06:17:16] (03CR) 10Krinkle: "Fixed in Ibe2efcd11c3f97ca343f43168bde278e44537be9." [core] - 10https://gerrit.wikimedia.org/r/326044 (https://phabricator.wikimedia.org/T66795) (owner: 10Legoktm) [06:17:48] (03CR) 10Legoktm: [C: 032] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/327444 (owner: 10Krinkle) [06:19:35] legoktm: btw, what's the status on require_once not being like a non-function? Just noticed it in the StopForumSpam patch again [06:19:42] Has it been released? Is there something I can merge? [06:19:55] x/like a function/ [06:20:56] it's fixed in master [06:21:03] (03CR) 10Krinkle: [C: 032] Drop pre-1.24 compat [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327430 (owner: 10Legoktm) [06:21:07] 26 | WARNING | [x] require_once keyword must not be used as a [06:21:07] | | function. [06:21:07] | | (MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords) [06:21:20] but there are still a few bugs in the newly added sniffs before we release a new version [06:21:32] (03CR) 10Krinkle: [C: 032] Add GPL file headers [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327431 (owner: 10Legoktm) [06:22:05] Krinkle: https://gerrit.wikimedia.org/r/#/projects/mediawiki/tools/codesniffer,dashboards/default if you want to review/merge those three patches, then I'll do another round of testing tomorrow probably, and hopefully it's ready to release [06:24:07] (03PS4) 10Legoktm: SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [06:25:03] (03CR) 10Legoktm: [C: 032] SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [06:27:18] (03Merged) 10jenkins-bot: RELEASE-NOTES: Fixup for dfb50ab9f3 [core] - 10https://gerrit.wikimedia.org/r/327444 (owner: 10Krinkle) [06:27:21] (03Merged) 10jenkins-bot: Drop pre-1.24 compat [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327430 (owner: 10Legoktm) [06:27:23] (03Merged) 10jenkins-bot: Add GPL file headers [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/327431 (owner: 10Legoktm) [06:27:52] bah [06:27:59] I added the test case and...the code didn't work :< [06:32:13] (03CR) 10jenkins-bot: [V: 04-1] SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [06:34:20] (03CR) 10jenkins-bot: [V: 04-1] SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [06:35:31] (03PS5) 10Legoktm: SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [06:41:30] (03CR) 10Legoktm: [C: 032] Add maintenance/view.php for viewing page contents [core] - 10https://gerrit.wikimedia.org/r/323142 (owner: 10Bartosz Dziewoński) [06:43:40] (03CR) 10Legoktm: [C: 04-1] Improve logging of exceptions which are not thrown but attached to context (031 comment) [core] - 10https://gerrit.wikimedia.org/r/323446 (https://phabricator.wikimedia.org/T151290) (owner: 10Gergő Tisza) [06:46:08] (03CR) 10Aaron Schulz: [C: 031] "I'll +2 assuming the amendments are fine" [core] - 10https://gerrit.wikimedia.org/r/277944 (owner: 10Cenarium) [06:46:32] 10MediaWiki-Page-editing, 07Easy, 13Patch-For-Review: New configuration settings $wgMergeHistoryRevisionsLimit - https://phabricator.wikimedia.org/T89551#1039064 (10Legoktm) Is there an actual reason you don't want the limit to be hardcoded? [06:49:02] (03CR) 10Legoktm: [C: 032] SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [06:54:16] (03Merged) 10jenkins-bot: Add maintenance/view.php for viewing page contents [core] - 10https://gerrit.wikimedia.org/r/323142 (owner: 10Bartosz Dziewoński) [06:58:30] (03Merged) 10jenkins-bot: SpecialRunJobs: Use wfHttpError to generate error messages [core] - 10https://gerrit.wikimedia.org/r/312650 (https://phabricator.wikimedia.org/T146546) (owner: 10Fomafix) [07:09:47] (03CR) 10Kaldari: [C: 032] Re-index the array of excluded namespace IDs [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327141 (https://phabricator.wikimedia.org/T153165) (owner: 10Samwilson) [07:11:05] (03Merged) 10jenkins-bot: Re-index the array of excluded namespace IDs [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327141 (https://phabricator.wikimedia.org/T153165) (owner: 10Samwilson) [07:15:02] (03CR) 10Nikerabbit: [C: 04-1] "This patch is missing a description." [core] - 10https://gerrit.wikimedia.org/r/327412 (owner: 10Ghybu) [07:15:44] (03PS1) 10Niharika29: Add README [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/327457 [07:16:26] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2875607 (10Marostegui) No worries - I have extended the downtime for the lag checks until Monday. However if it finishes before th... [07:20:25] (03CR) 10Krinkle: "fixme: This constructs 'new OO.ui.ProgressBarWidget' and appends it on page load. Ideally this should be deferred to when the button is cl" [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [07:22:28] 10MediaWiki-Special-pages, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Content of a 400 Bad Request response does not fit to the Content-Type - https://phabricator.wikimedia.org/T146546#2875609 (10Krinkle) 05Open>03Resolved [07:24:55] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review: TypeError: exclude.indexOf is not a function - https://phabricator.wikimedia.org/T153165#2875610 (10Samwilson) 05Open>03Resolved [07:25:27] (03CR) 1020after4: [C: 031] Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327420 (https://phabricator.wikimedia.org/T153250) (owner: 10Rudloff) [07:27:49] (03CR) 10Robert Vogel: [V: 032 C: 032] Updated scrollToTop with new icon class [skins/BlueSpiceSkin] (REL1_27) - 10https://gerrit.wikimedia.org/r/327215 (owner: 10Robert Vogel) [07:29:31] (03CR) 10jenkins-bot: [V: 04-1] Updated scrollToTop with new icon class [skins/BlueSpiceSkin] (REL1_27) - 10https://gerrit.wikimedia.org/r/327215 (owner: 10Robert Vogel) [07:34:38] (03CR) 10Kaldari: [C: 04-1] Add autocompletion to search fields (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [07:35:15] (03CR) 10Legoktm: [C: 04-1] Suppression: Don't tell non-suppressor users to view a log if they can't (031 comment) [core] - 10https://gerrit.wikimedia.org/r/40283 (https://phabricator.wikimedia.org/T39120) (owner: 10Alex Monk) [07:35:18] (03CR) 10Legoktm: [C: 032] Fix linking Special:ChangeContentModel from action=info [core] - 10https://gerrit.wikimedia.org/r/318695 (owner: 10Umherirrender) [07:35:24] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-CXserver, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 4 others: Enable Scap3 config deploys for CXServer - https://phabricator.wikimedia.org/T147634#2875616 (10KartikMistry) Scheduled on 15th December: htt... [07:40:23] (03PS2) 10Niharika29: Add README [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/327457 [07:45:05] (03CR) 10Mglaser: [C: 032] BSAvatars: Fixed blank profile image issue [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327201 (owner: 10Robert Vogel) [07:45:19] (03PS1) 10Mglaser: BSAvatars: Fixed blank profile image issue [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327458 [07:46:37] (03Merged) 10jenkins-bot: Fix linking Special:ChangeContentModel from action=info [core] - 10https://gerrit.wikimedia.org/r/318695 (owner: 10Umherirrender) [07:46:40] (03Merged) 10jenkins-bot: BSAvatars: Fixed blank profile image issue [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327201 (owner: 10Robert Vogel) [07:48:57] 10Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#2875627 (10hashar) [07:49:50] (03CR) 10BearND: [C: 04-1] "Needs a manual rebase" (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [07:50:35] 10Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#1677260 (10hashar) Will be fixed when the Jenkins jobs `mw-testextension*` are moved to Nodepool instance. There will be no more any leftover from previous build. [07:55:48] (03PS4) 10Ladsgroup: Adjustments to Wikimedia color palette. [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) [07:57:16] (03CR) 10BearND: [] "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327394 (owner: 10BearND) [07:59:42] 07Design, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2875633 (10Pginer-WMF) @jmatazzoni, @Catrope, @SBisson, In case it was lost in the comments above, I'll mention it again: I'd prefer to fix th... [08:01:40] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-CXserver, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 3 others: Replace jshint, jscs, jsbeautify by eslint - https://phabricator.wikimedia.org/T151741#2875635 (10Arrbee) 05Open>03Resolved [08:01:53] (03CR) 10Samwilson: [C: 031] "This works great for me." [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327300 (https://phabricator.wikimedia.org/T153164) (owner: 10Kaldari) [08:05:32] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2772468 (10BethNaught) How can I opt out of this? It's really a... [08:07:57] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Clarify the access to editing mode when translating templates - https://phabricator.wikimedia.org/T150952#2875639 (10Pginer-WMF) a:05Pginer-WMF>03Amire80 [08:11:05] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 13Patch-For-Review, 07Unplanned-Sprint-Work: Use new article recommendation api - https://phabricator.wikimedia.org/T153187#2875641 (10Arrbee) [08:15:23] 10MediaWiki-Internationalization, 06Language-Team: mw.language unittest cleanup failing - https://phabricator.wikimedia.org/T152476#2849621 (10WMDE-leszek) This looks pretty similar to what we have found as a cause of RevisionSlider tests failures started around last weekend (T153121). We've managed to track t... [08:16:18] (03PS10) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [08:17:43] (03CR) 10Samwilson: [] Add autocompletion to search fields (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [08:20:51] 07Design, 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Better communicate that changes when editing a template won't be lost on closing - https://phabricator.wikimedia.org/T150953#2875654 (10Arrbee) [08:22:17] 07Design, 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Better communicate that changes when editing a template won't be lost on closing - https://phabricator.wikimedia.org/T150953#2875656 (10Amire80)... [08:28:56] (03CR) 10Fomafix: [C: 04-1] Add autocompletion to search fields (032 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [08:30:46] 07Design, 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2875662 (10Prtksxna) [08:35:47] (03CR) 10Krinkle: [] "Perhaps use ESLint instead of JSHint?" [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/280777 (owner: 10Paladox) [08:45:36] (03CR) 10Paladox: [] "Yeh but I'm not sure how to use eslint." [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/280777 (owner: 10Paladox) [08:52:00] (03CR) 10Robert Vogel: [C: 032] BSAvatars: Fixed blank profile image issue [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/327458 (owner: 10Mglaser) [08:52:45] (03CR) 10Krinkle: "$ git lg --no-merges remotes/origin/wmf/1.29.0-wmf.5..remotes/origin/wmf/1.29.0-wmf.6" [extensions/examples] - 10https://gerrit.wikimedia.org/r/182760 (owner: 10Krinkle) [08:58:09] (03CR) 10Paladox: "check experimental" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327201 (owner: 10Robert Vogel) [08:59:10] 10Metrolook: Stylesheets should not both specify "media" and contain @media - https://phabricator.wikimedia.org/T113839#2875693 (10Paladox) @hashar but this fails on the skins tests for example the Metrolook one. Probably want to skip this one on the skins test. [09:00:29] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Align MediaWiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2835852 (10Fomafix) Is it possible to centralize the color palette into a single LESS file? [09:09:37] (03CR) 10Samwilson: [] "Thanks Fomafix, have fixed those." (032 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [09:10:00] (03PS11) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [09:10:22] (03CR) 10Krinkle: [] "MediaWiki core, Vector, BetaFeatures, unicodejs and 25 other repositories already use ESLint. Look at those for how to set it up." [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/280777 (owner: 10Paladox) [09:18:31] (03CR) 10Ladsgroup: [] Add CollationFa (033 comments) [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [09:20:01] 06Repository-Ownership-Requests: +2 for Fomafix in mediawiki/* - https://phabricator.wikimedia.org/T153177#2875712 (10Krinkle) [09:20:25] (03PS7) 10Ladsgroup: Add CollationFa [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) [09:26:31] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2875732 (10Samwilson) a:03Samwilson @kaldari Okay, that makes sense. The deletion reasons that are currently... [09:27:15] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Disable Page Previews for anons - https://phabricator.wikimedia.org/T152687#2875735 (10phuedx) a:03phuedx [09:28:46] 04(no projects): Sharing sessions don't work and breaks sessions if you change sub-domain - https://phabricator.wikimedia.org/T153295#2875736 (10Toma.luca95) [09:29:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 15User-Daniel: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#2875748 (10hoo) >>! In T151717#2871509, @Hall1467 wrote: > I think a good way to go about this tracking would be by overriding the Lua direct acce... [09:32:18] 10MediaWiki-Authentication-and-authorization: Sharing sessions don't work and breaks sessions if you change sub-domain - https://phabricator.wikimedia.org/T153295#2875759 (10Aklapper) Hi @Toma.luca95, thanks for taking the time to report this! Which exact MediaWiki version is this about? [09:38:05] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2875776 (10Aklapper) @BethNaught: As far as I know you cannot,... [09:38:57] 07Design, 06Design-Research-Backlog, 10FileAnnotations, 06Multimedia: Moderated usability testing for FileAnnotations prototypes - https://phabricator.wikimedia.org/T153296#2875777 (10Prtksxna) [09:39:35] 10MediaWiki-Authentication-and-authorization: Sharing sessions don't work and breaks sessions if you change sub-domain - https://phabricator.wikimedia.org/T153295#2875791 (10Toma.luca95) Hi, the production is with 1.27.1 and we are testing also the 1.28.0 with the same behavior [09:39:59] (03CR) 10Krinkle: "fixme: Original e8dd1f43fb169 also has unit tests. Can we add a regression test for the problem case here?" [core] - 10https://gerrit.wikimedia.org/r/326175 (https://phabricator.wikimedia.org/T152800) (owner: 10Catrope) [09:40:08] 07Design, 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2814426 (10Prtksxna) [09:42:52] (03PS1) 10DCausse: Do not return the current wikis when detecting query languages [extensions/CirrusSearch] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327467 (https://phabricator.wikimedia.org/T153051) [09:45:26] 10MediaWiki-extensions-Translate, 10VisualEditor, 07Browser-Support-Internet-Explorer: Can't edit translatable pages in IE11 using VE - https://phabricator.wikimedia.org/T117389#2875798 (10TTO) 05Open>03Resolved a:03TTO Works now. [09:47:48] 10Wikimedia-Site-requests, 13Patch-For-Review: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2872869 (10TTO) Sorry about the noise... I had forgotten that this has been available on testwiki for a few months. As far as the Translate extension is concer... [09:49:24] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n: Strip combining diacritical marks and convert precomposed characters when searching - https://phabricator.wikimedia.org/T3836#2875806 (10dcausse) Currently we only enabled ICU folding for en, fr and greek wikis, ASCII folding has no effect on heb... [09:50:19] 10MediaWiki-Internationalization, 15User-Nikerabbit: mw.language unittest cleanup failing - https://phabricator.wikimedia.org/T152476#2875807 (10Nikerabbit) There are arguments for both ways: tests should define their dependencies and avoid global state; tests should clean up after themselves (if the framework... [09:50:52] 07Design, 06Design-Research-Backlog, 10FileAnnotations, 06Multimedia: Moderated usability testing for FileAnnotations prototypes - https://phabricator.wikimedia.org/T153296#2875809 (10Prtksxna) [09:51:59] (03CR) 10Hashar: [] "recheck" [core] - 10https://gerrit.wikimedia.org/r/327412 (owner: 10Ghybu) [09:59:37] 07Design, 06Design-Research-Backlog, 10FileAnnotations, 06Multimedia: Moderated usability testing for FileAnnotations prototypes - https://phabricator.wikimedia.org/T153296#2875824 (10Prtksxna) [10:00:49] (03PS1) 10Robert Vogel: [WiP] Adding default filebackend for BlueSpice extensions [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/327469 [10:00:49] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Activate BM25 on all but wikis with spaceless languages - https://phabricator.wikimedia.org/T152092#2875827 (10dcausse) [10:02:33] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2875829 (10BurritoBazooka) >>! In T151770#2874646, @Anomie wrote: >>>! In T151770#2873767, @Legoktm wrote: >> If browsers are corrupting cookie... [10:02:49] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2875844 (10Kghbln) [10:03:39] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2875857 (10Kghbln) [10:04:07] (03PS1) 10Robert Vogel: [WiP] BSAvatars: ensure compatiblity with img_auth.php [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327471 [10:06:33] (03CR) 10Legoktm: [C: 04-1] "Messing with $wgParser like this shouldn't be acceptable for new code" [core] - 10https://gerrit.wikimedia.org/r/140975 (owner: 10Brian Wolff) [10:06:38] (03CR) 10Legoktm: [C: 032] SpecialUserrights: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [10:06:41] (03CR) 10Legoktm: [] "Could we mangle the response in JS to have the old output format for backwards compatibility? I guess there's no much advantage to this pa" [core] - 10https://gerrit.wikimedia.org/r/266251 (owner: 10Gerrit Patch Uploader) [10:06:41] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Provide better education and guidance for template editing - https://phabricator.wikimedia.org/T151030#2875858 (10Pginer-WMF) [10:06:44] (03CR) 10Legoktm: [C: 04-1] Remove doubled title on Special:MIMESearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/290493 (owner: 10Florianschmidtwelzow) [10:08:02] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Provide better education and guidance for template editing - https://phabricator.wikimedia.org/T151030#2805158 (10Pginer-WMF) a:05Pginer-WMF>03Amire80 I... [10:11:14] (03PS3) 10Sebastian Berlin (WMSE): Skip back word [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) [10:16:04] (03Merged) 10jenkins-bot: SpecialUserrights: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [10:16:24] (03CR) 10Filip: [] "Jenkins also unrelated" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:23:28] 07Design, 06Design-Research-Backlog, 10FileAnnotations, 06Multimedia: Moderated usability testing for FileAnnotations prototypes - https://phabricator.wikimedia.org/T153296#2875868 (10Prtksxna) [10:29:24] 07Design, 06Design-Research-Backlog, 10FileAnnotations, 06Multimedia: Moderated usability testing for FileAnnotations prototypes - https://phabricator.wikimedia.org/T153296#2875875 (10Prtksxna) Would love to get guidance on the process. I've tried to add relevant information, but please let me know where I... [10:44:37] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2875844 (10Nikerabbit) Please see `[Wikitech-l] [BREAKING CHANGE] Legacy wikibits will no longer loaded by default on Wikimedia wikis and MediaWiki 1.27` To me it seems Translate is just taking col... [10:46:41] (03CR) 10Fomafix: [] "> Could we mangle the response in JS to have the old output format" [core] - 10https://gerrit.wikimedia.org/r/266251 (owner: 10Gerrit Patch Uploader) [10:53:59] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2875909 (10Qgil) Two ideas that I have floated in a conversation with Rachel and Srishti: * Let's embrace the Unconference concept. Even... [10:55:57] 10Connected-Open-Heritage-New-data: Australia for COH - https://phabricator.wikimedia.org/T153221#2875915 (10Lokal_Profil) [10:59:24] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2875918 (10Qgil) 05Resolved>03Open But wait, right now it is impossible to tell which sessions are concurrent. Would... [11:05:53] (03PS1) 10Mobrovac: Update change-propagation to f3eab4f [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/327476 [11:07:04] (03CR) 10Mobrovac: [V: 032 C: 032] Update change-propagation to f3eab4f [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/327476 (owner: 10Mobrovac) [11:13:39] 10MediaWiki-extensions-SimpleSecurity, 03Google-Code-In-2016: Move SimpleSecurity classes to separate files - https://phabricator.wikimedia.org/T153266#2875968 (10Aklapper) Looking at https://www.mediawiki.org/wiki/Extension:SimpleSecurity I'm wondering a little bit if that's the best use of time (though I agr... [11:17:23] 10Social-Tools, 10SocialProfile, 03Google-Code-In-2016, 07I18n: SocialProfile missing api i18n messages - https://phabricator.wikimedia.org/T153264#2875976 (10Aklapper) This is a [[ https://www.mediawiki.org/wiki/Google_Code-in_2016 | GCI ]] task now: https://codein.withgoogle.com/tasks/5203015877263360/ (... [11:34:07] (03CR) 10Lokal Profil: [C: 04-1] "A few misses in docstrings and two questions" (035 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [11:36:23] 10MediaWiki-Internationalization: Diacritical letters (Çç, Êê, Îî, Şş, Ûû) on Kurdish pages do not become part of the internal link - https://phabricator.wikimedia.org/T153233#2876019 (10Ghybu) Can we make the code more complex? Inside a Kurdish word, when the letters "î" and "y" are written side by side (i.e... [11:40:52] (03PS3) 10MarcoAurelio: Set $linktrail for MessagesKu_latn.php [core] - 10https://gerrit.wikimedia.org/r/327412 (https://phabricator.wikimedia.org/T153233) (owner: 10Ghybu) [11:41:12] (03CR) 10Mobrovac: [V: 032 C: 032] "I somehow have my doubts around memory consumption, but let's give it a spin and modify later if needed." [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327378 (https://phabricator.wikimedia.org/T153122) (owner: 10Ppchelko) [11:41:19] (03CR) 10MarcoAurelio: [] "Commit message and topic amended as per commit message guidelines." [core] - 10https://gerrit.wikimedia.org/r/327412 (https://phabricator.wikimedia.org/T153233) (owner: 10Ghybu) [11:42:33] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:45:17] (03PS2) 10Mobrovac: Minor: use msg.meta.topic instead of parsing it out from kafkaMessage [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327217 [11:47:35] 10Phabricator, 15User-Addshore: Herald rule for adding project "User-Addshore" when Addshore is assigned to a task - https://phabricator.wikimedia.org/T153113#2870163 (10Addshore) Thanks @Aklapper ! [11:48:17] 10MediaWiki-General-or-Unknown, 07I18n, 05MW-1.29-release-notes, 07RTL, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): If error messages are in English, they should not be displayed in RTL even in RTL context - https://phabricator.wikimedia.org/T153027#2876061 (10Huji) 05Open>03Resolved [11:48:29] 10MediaWiki-Vagrant, 06Analytics-Kanban: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2876063 (10Physikerwelt) @mschwarzer Did you already manage to setup Flink. I recommend to document your setup here https://wikitech.wikimedia.org/wiki/Flink [11:49:20] 10MediaWiki-Vagrant, 10RESTBase-API, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876064 (10Mvolz) [11:50:34] 10MediaWiki-Vagrant, 10Citoid, 10RESTBase-API, 10VisualEditor: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214#2876081 (10Mvolz) p:05Triage>03Normal [11:50:44] (03CR) 10Mobrovac: [V: 032 C: 032] "@Jon, just a minor face lift to avoid parsing the topic since it's readily available in the message itself." [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327217 (owner: 10Mobrovac) [11:51:08] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:51:51] 10MediaWiki-Vagrant, 10RESTBase-API, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876084 (10Mvolz) [11:52:03] 10MediaWiki-Vagrant, 10RESTBase-API, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876064 (10Mvolz) p:05Triage>03Normal [11:52:28] (03PS1) 10Mobrovac: Update trending-edits to f98f002 [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327480 [12:02:16] (03PS24) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:02:59] (03CR) 10Mobrovac: [V: 032 C: 032] Update trending-edits to f98f002 [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327480 (owner: 10Mobrovac) [12:04:59] (03CR) 10Zfilipin: [] "Elena, looks like you have forgot to commit tests/rspec/README.md." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:06:05] 10MediaWiki-extensions-FlaggedRevs, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled - https://phabricator.wikimedia.org/T54510#2876091 (10Pginer-WMF) >>! In T54510#2875256, @... [12:08:41] (03PS25) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:13:32] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Map infobox/photograph template for Medelhavsmuseet - Cypern - https://phabricator.wikimedia.org/T144485#2876107 (10Mattias_Ostmar-WMSE) 05Open>03Resolved a:05Mattias_Ostmar-WMSE>03None [12:17:42] (03CR) 10Jhernandez: [] "Replied to some comments. I don't think the changes are necessary, I think cosmetic changes/refactors can come later in followup patches." (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [12:18:26] 10MediaWiki-extensions-SphinxSearch, 13Patch-For-Review: incategory: search prefix returning fatal error. - https://phabricator.wikimedia.org/T100007#1303446 (10jartes) Any update about this? I'm having the same issue. @Aklapper [12:29:51] (03PS1) 10Nschaaf: Fix rank of related articles to fix sorting [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327482 (https://phabricator.wikimedia.org/T153192) [12:31:19] (03CR) 10Nschaaf: [C: 032] Fix rank of related articles to fix sorting [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327482 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [12:31:22] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876130 (10Pginer-WMF) >>! In T153284#2875499, @Catrope wrote: > The generic "info" icon in the screens... [12:32:40] (03Merged) 10jenkins-bot: Fix rank of related articles to fix sorting [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327482 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [12:37:15] 10Increasing-content-coverage: Use related_articles as default in GapFinder - https://phabricator.wikimedia.org/T153192#2876136 (10schana) [12:37:55] (03CR) 10Phuedx: [] Sync enabled preview state to storage on change (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 (owner: 10Jhernandez) [12:40:03] (03PS5) 10Jhernandez: Sync enabled preview state to storage on change [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 [12:42:25] (03CR) 10Jhernandez: [] Sync enabled preview state to storage on change (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 (owner: 10Jhernandez) [12:42:33] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-General-or-Unknown: Fresh 1.27.0 install: ParameterAssertionException: Bad value for parameter maxKeys: must be above zero - https://phabricator.wikimedia.org/T139559#2436116 (10STRATO_AG) Dear Group Members, the discussed error was fixed. Thus, MediaW... [12:43:20] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2876153 (10Sn1per) Adding ``` $(function() { $watchlistRes... [12:45:03] (03PS5) 10Addshore: Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [12:47:11] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876159 (10Pginer-WMF) >>! In T153284#2875499, @Catrope wrote: > The first secondary link icon for auto... [12:47:33] (03CR) 10Addshore: [C: 032] Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [12:47:52] (03PS1) 10Jdrewniak: Stats update [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/327484 [12:50:23] (03PS4) 10Addshore: Added functions to access mime type and subtype separately [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/47438 (owner: 10Olenz) [12:50:24] 07Design, 10MediaWiki-Categories, 10MediaWiki-Installer, 03Community-Tech-Sprint, 07I18n: Make the "uca-xx" category collations the default during installation (with fallbacks) - https://phabricator.wikimedia.org/T47611#2876179 (10Niharika) a:03Niharika [12:50:28] (03CR) 10Addshore: [C: 031] Added functions to access mime type and subtype separately [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/47438 (owner: 10Olenz) [12:53:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "All this patch does is updating (or removing) deprecated JSHint options. No objection for a long, long time now. Let's move." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/269320 (owner: 10Paladox) [12:53:55] (03CR) 10jenkins-bot: [V: 04-1] Added functions to access mime type and subtype separately [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/47438 (owner: 10Olenz) [12:57:24] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876195 (10Pginer-WMF) >>! In T153284#2875499, @Catrope wrote: > Finally, I worry the wording might be... [12:59:01] (03PS1) 10Ljonka: Add config option to hide specific usernames [extensions/Contributors] (REL1_27) - 10https://gerrit.wikimedia.org/r/327488 [12:59:10] (03CR) 10Hashar: [C: 031] "Already included in .6 ( wmf/1.29.0-wmf.6 )." [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [13:01:05] (03PS3) 10Addshore: Make properties/methods in Cite private [extensions/Cite] - 10https://gerrit.wikimedia.org/r/311963 (owner: 10Thiemo Mättig (WMDE)) [13:01:08] (03CR) 10jenkins-bot: [V: 04-1] Add populateInterwiki maintenance script [core] - 10https://gerrit.wikimedia.org/r/286037 (https://phabricator.wikimedia.org/T114577) (owner: 10Aude) [13:01:12] (03CR) 10Addshore: [C: 032] Make properties/methods in Cite private [extensions/Cite] - 10https://gerrit.wikimedia.org/r/311963 (owner: 10Thiemo Mättig (WMDE)) [13:03:26] (03CR) 10Jdrewniak: [C: 032] Stats update [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/327484 (owner: 10Jdrewniak) [13:05:02] (03Merged) 10jenkins-bot: Changing jshint configuation [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/269320 (owner: 10Paladox) [13:06:04] (03PS4) 10Sebastian Berlin (WMSE): Skip back word [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) [13:08:43] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2876217 (10Tbayer) So yes, it's unlikely that not pausing the timer will cause an unmana... [13:09:05] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Always great to see documentation added. Poke me if you want this merged and it is not within the next days." [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/327457 (owner: 10Niharika29) [13:11:15] (03Merged) 10jenkins-bot: Make properties/methods in Cite private [extensions/Cite] - 10https://gerrit.wikimedia.org/r/311963 (owner: 10Thiemo Mättig (WMDE)) [13:14:27] (03Merged) 10jenkins-bot: Stats update [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/327484 (owner: 10Jdrewniak) [13:14:29] (03CR) 10Sebastian Berlin (WMSE): [] Skip back word (0314 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [13:16:36] (03CR) 10Sebastian Berlin (WMSE): [] "Forgot to post the replies on the previous patch set. They are included previous comment." [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [13:17:29] (03CR) 10Sebastian Berlin (WMSE): [] "recheck" [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [13:18:10] (03PS26) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:20:56] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:20:59] (03CR) 10Zppix: [C: 032] Remove hacks, fix logging [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/323712 (owner: 10MarkTraceur) [13:24:39] (03PS27) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:25:06] (03Merged) 10jenkins-bot: Remove hacks, fix logging [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/323712 (owner: 10MarkTraceur) [13:25:25] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:25:33] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "The HTML for a tab looks like this:
  • …
    • . The
  • contains a background image for the gradient. The contains a " [skins/Vector] - 10https://gerrit.wikimedia.org/r/327288 (https://phabricator.wikimedia.org/T104767) (owner: 10Pppery) [13:25:47] (03CR) 10Bartosz Dziewoński: [] Add CollationFa (032 comments) [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [13:25:47] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Search page duplicates result - https://phabricator.wikimedia.org/T153051#2876252 (10Raymond) [13:25:49] 06Discovery, 06Discovery-Search: TextCat shows search results from the same wiki - https://phabricator.wikimedia.org/T152988#2876254 (10Raymond) [13:26:03] (03PS8) 10Bartosz Dziewoński: Add CollationFa [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [13:27:12] (03CR) 10Bartosz Dziewoński: [C: 032] "I tested this and on my local wiki (unaffected by T139110) it works and gives the same results as 'uca-fa'. At the very least this shouldn" [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [13:28:38] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Search page duplicates result - https://phabricator.wikimedia.org/T153051#2876260 (10Deskana) 05Open>03Resolved [13:30:15] (03PS1) 10Phuedx: POC: Add missing test case for I36c231c1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327498 [13:30:16] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: [Epic] Allow extensions to register simple keyword features - https://phabricator.wikimedia.org/T152517#2876270 (10Aklapper) [13:33:12] Reedy: Are you there? I fixed my task [13:34:22] I'll have a look, trying to juggle a few things at once atm [13:35:49] (03CR) 10Phuedx: [C: 04-1] "Behaviour-wise this LGTM. I've tested this locally with Jdlrobson's minimal test case and with a couple of complex articles test articles " (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [13:37:59] (03Merged) 10jenkins-bot: Add CollationFa [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [13:38:49] (03CR) 10Hashar: [C: 032] "In preparation of SWAT in 20 minutes." [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [13:41:46] (03CR) 10Lokal Profil: [C: 032] Skip back word [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [13:42:17] (03CR) 10Nikerabbit: [C: 04-1] "It seems that you did not take into account the change in behavior with regards of escaping. Each usage should be checked for correct esca" (033 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/318274 (owner: 10Paladox) [13:42:21] (03PS1) 10Matthias Mullie: Do not lose message parameters in UploadFromChunks::verifyChunk() [core] - 10https://gerrit.wikimedia.org/r/327500 (https://phabricator.wikimedia.org/T32095) [13:43:00] (03CR) 10Nikerabbit: [C: 032] Fixing mediawiki's য় problem [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) (owner: 10Aftab) [13:43:25] (03CR) 10Phuedx: [C: 04-1] "I didn't migrate the last scenario from the "popups_settings" feature either." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 (owner: 10Phuedx) [13:44:16] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 05MW-1.28-release-notes, 13Patch-For-Review: uca-fa collation shows pages starting with ا incorrectly under ء - https://phabricator.wikimedia.org/T139110#2876293 (10matmarex) @kaldari Will you take CommTech be taking care of deploying the collation... [13:45:36] (03CR) 10Nikerabbit: [C: 04-1] "-1 for alerting for the comment" [core] - 10https://gerrit.wikimedia.org/r/326093 (https://phabricator.wikimedia.org/T125047) (owner: 10MarcoAurelio) [13:49:14] (03CR) 10Nikerabbit: [C: 032] Set $linktrail for MessagesKu_latn.php [core] - 10https://gerrit.wikimedia.org/r/327412 (https://phabricator.wikimedia.org/T153233) (owner: 10Ghybu) [13:49:16] 10MediaWiki-Internationalization, 13Patch-For-Review: Diacritical letters (Çç, Êê, Îî, Şş, Ûû) on Kurdish pages do not become part of the internal link - https://phabricator.wikimedia.org/T153233#2873591 (10Nikerabbit) > Can we make do that, for example "[[Amedî]]ye" appear "Amediye" (i.e "[[Amedî]]ye" -->"Ame... [13:51:08] (03CR) 10Nikerabbit: [C: 032] GENDER should be used for "triggered" in AbuseFilter log messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326371 (https://phabricator.wikimedia.org/T152872) (owner: 10Huji) [13:51:53] 10AbuseFilter, 07I18n, 13Patch-For-Review: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2862321 (10Nikerabbit) >>! In T152872#2862809, @Huji wrote: > Additionally, `Logentry-abusefilter-hit` does not use GENDER at all and should be fixed too.... [13:54:21] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: CX inline template editor must appear under the template - https://phabricator.wikimedia.org/T152629#2876307 (10Pginer-WMF) [13:55:36] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-CXserver, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 3 others: Enable Scap3 config deploys for CXServer - https://phabricator.wikimedia.org/T147634#2876309 (10mobrovac) 05Open>03Resolved [13:56:47] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/327303 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:57:13] (03Merged) 10jenkins-bot: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327402 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [13:57:19] (03Merged) 10jenkins-bot: Skip back word [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/315218 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [13:57:23] (03CR) 10jenkins-bot: [V: 04-1] Fixing mediawiki's য় problem [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) (owner: 10Aftab) [13:57:26] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327289 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:58:25] (03CR) 10Reedy: [C: 031] "Change is good, blocked by unrelated test failure." [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:58:53] (03Merged) 10jenkins-bot: Set $linktrail for MessagesKu_latn.php [core] - 10https://gerrit.wikimedia.org/r/327412 (https://phabricator.wikimedia.org/T153233) (owner: 10Ghybu) [13:58:56] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/327303 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:58:59] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327289 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:02:18] 10Wikispeech-Player, 06Wikispeech-WMSE, 07Story, 10Wikispeech (Phase 2): [Story] Support re-listening (Wikispeech) - https://phabricator.wikimedia.org/T122132#2876332 (10Sebastian_Berlin-WMSE) [14:02:35] 10Wikispeech-Player, 06Wikispeech-WMSE, 13Patch-For-Review, 10Wikispeech (Sprint 2016-12-14): Skip back in recitation (was: Re-listening to recitation) - https://phabricator.wikimedia.org/T133687#2876330 (10Sebastian_Berlin-WMSE) 05Open>03Resolved [14:02:55] 10Wikispeech-Player, 06Wikispeech-WMSE, 07Story, 10Wikispeech (Phase 2): [Story] Support re-listening (Wikispeech) - https://phabricator.wikimedia.org/T122132#1897499 (10Sebastian_Berlin-WMSE) 05Open>03Resolved a:03Sebastian_Berlin-WMSE [14:04:31] (03CR) 10jenkins-bot: [V: 04-1] GENDER should be used for "triggered" in AbuseFilter log messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326371 (https://phabricator.wikimedia.org/T152872) (owner: 10Huji) [14:04:48] (03CR) 10Nikerabbit: [C: 04-1] Make the code for grammar data processing common (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241645 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [14:08:14] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Upload a minor selection of images (~10 files) for SMVK-Mexiko - https://phabricator.wikimedia.org/T144358#2876339 (10Mattias_Ostmar-WMSE) [14:08:52] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Upload a minor selection of images (~10 files) for SMVK-Mexiko - https://phabricator.wikimedia.org/T144358#2597143 (10Mattias_Ostmar-WMSE) [14:11:03] (03CR) 10jenkins-bot: [V: 04-1] POC: Add missing test case for I36c231c1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327498 (owner: 10Phuedx) [14:11:39] (03CR) 10Nikerabbit: [C: 031] "Seems sensible." [core] - 10https://gerrit.wikimedia.org/r/325984 (owner: 10Anomie) [14:15:48] 10MediaWiki-Database, 10MediaWiki-Special-pages: Add a special page that creates subpage with given sql query - https://phabricator.wikimedia.org/T153313#2876348 (10IKhitron) [14:16:23] 10MediaWiki-General-or-Unknown: Make user-created userscripts (from enwiki and such) a "plugin" - https://phabricator.wikimedia.org/T153263#2876360 (10Zppix) This isnt an issue, merely a suggestion [14:17:33] (03PS4) 10Milimetric: Implement basic Dashiki extension [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) [14:18:05] (03CR) 10Milimetric: [] "thanks! cleaned up." (032 comments) [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) (owner: 10Milimetric) [14:18:24] (03PS1) 10Bartosz Dziewoński: IcuCollation: Add the current class name to 'first-letters' cache key [core] - 10https://gerrit.wikimedia.org/r/327502 [14:20:09] Reedy: Can you submit this task on GCI? [14:20:39] (03PS1) 10ItSpiderman: Added checks that prevent buildIndex from crashing on invalid page [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327503 [14:21:31] (03CR) 10Ladsgroup: [C: 031] IcuCollation: Add the current class name to 'first-letters' cache key [core] - 10https://gerrit.wikimedia.org/r/327502 (owner: 10Bartosz Dziewoński) [14:23:04] (03PS2) 10ItSpiderman: Added checks that prevent buildIndex from crashing on invalid page [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327503 [14:25:34] (03CR) 10Dbrant: [C: 04-1] "Unfortunately this introduces another regression: certain combinations of nested syntax symbols are no longer highlighted correctly. For e" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) (owner: 10Kaartic) [14:27:38] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2876392 (10Aklapper) [14:30:02] (03CR) 10Hashar: [C: 032] "SWAT" [extensions/CirrusSearch] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327467 (https://phabricator.wikimedia.org/T153051) (owner: 10DCausse) [14:30:16] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2876407 (10Aklapper) [14:33:27] (03CR) 10Dbrant: [C: 04-1] "I'm not sure I see what issue this is supposed to fix. Would you mind explaining? When I try this on my device, I see a regression where t" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 (owner: 10XinyueZ) [14:35:46] 10MediaWiki-Vagrant, 10Citoid, 10RESTBase, 10RESTBase-API, and 3 others: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214#2876414 (10mobrovac) a:03mobrovac I'll take this one. The config needs to be updated most likely. [14:38:17] (03CR) 10Ladsgroup: [] "This is too big to let us review it properly, I think it should be split to several (backward compatible) patches." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [14:38:28] (03CR) 10Ladsgroup: [] Log accessing private information in abuse filter logs (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [14:39:04] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2876423 (10Kghbln) 05Open>03Invalid >>! In T153299#2875879, @Nikerabbit wrote: > Please see [[ https://lists.wikimedia.org/pipermail/wikitech-l/2016-March/085113.html | `[Wikitech-l] [BREAKING C... [14:40:13] (03PS28) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [14:40:37] Reedy: Caan you submit this task on GCI site? [14:41:18] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [14:41:18] 10MediaWiki-extensions-Translate, 07Easy, 07I18n, 07RTL: Supporting RTL direction in the Special:PageMigration - https://phabricator.wikimedia.org/T139463#2876426 (10Aklapper) @Nidhinmahesh1: Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anyth... [14:42:30] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2876440 (10Nikerabbit) With debug=true I see: ``` Error loading translation aids http Objectexception: SyntaxError: Unexpected token E in JSON at position 0 at JSON.parse () at j... [14:43:23] 10MediaWiki-Vagrant, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876449 (10mobrovac) Doing the proposed change would (i) break RESTBase (as only the `dev.wiki.local.wmftest.net` domain is configured f... [14:44:07] 10Wikimedia-General-or-Unknown: Contact us URL behavior needs tweak on the English Wikipedia - https://phabricator.wikimedia.org/T54505#2876451 (10Aklapper) [14:44:13] (03Merged) 10jenkins-bot: Do not return the current wikis when detecting query languages [extensions/CirrusSearch] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327467 (https://phabricator.wikimedia.org/T153051) (owner: 10DCausse) [14:47:12] 10MediaWiki-Vagrant, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876473 (10Mvolz) >>! In T153307#2876449, @mobrovac wrote: > Doing the proposed change would (i) break RESTBase (as only the `dev.wiki.l... [14:47:55] 10MediaWiki-Vagrant, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876474 (10mobrovac) 05Open>03declined Agreed. Til then, closing as declined. [14:51:37] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2876489 (10Kghbln) >>! In T153299#2876440, @Nikerabbit wrote: > With debug=true I see: > ``` > Error loading translation aids http Objectexception: SyntaxError: Unexpected token E in JSON at positi... [14:53:07] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2876492 (10Nikerabbit) Command line curl package does not imply that the php curl module is available. [14:58:51] 10MediaWiki-Vagrant, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876495 (10Mvolz) Done: https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant&diff=prev&oldid=2313955 [15:01:35] 10MediaWiki-Vagrant, 10VisualEditor: Config issues using VE with Restbase on vagrant - points to working url but blocked by chrome - https://phabricator.wikimedia.org/T153307#2876503 (10mobrovac) <3 [15:02:25] (03PS29) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:03:03] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:03:17] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Is this fixing an actual bug? Is there a Phabricator ticket?" [core] - 10https://gerrit.wikimedia.org/r/327502 (owner: 10Bartosz Dziewoński) [15:05:38] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2876524 (10Kghbln) >>! In T153299#2876492, @Nikerabbit wrote: > Command line curl package does not imply that the php curl module is available. Omg, php curl. Yeah, did not think of this one and wo... [15:08:03] (03CR) 10Addshore: [C: 031] Add LoadBalancer::getMaintenanceConnectionRef() method [core] - 10https://gerrit.wikimedia.org/r/323883 (owner: 10Aaron Schulz) [15:09:45] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Activate BM25 on all but wikis with spaceless languages - https://phabricator.wikimedia.org/T152092#2876545 (10dcausse) [15:10:43] 10CirrusSearch, 06Discovery, 06Discovery-Search: Reindex all wikis with the new BM25 settings - https://phabricator.wikimedia.org/T139585#2876552 (10dcausse) [15:10:45] 10CirrusSearch, 06Discovery-Search: Activate BM25 on all but wikis with spaceless languages - https://phabricator.wikimedia.org/T152092#2838009 (10dcausse) 05Open>03Resolved done, all traffic's back to eqiad with BM25 enabled. [15:12:03] (03CR) 10Addshore: [C: 032] Fix tons of incomplete PHPDoc blocks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/326395 (owner: 10Thiemo Mättig (WMDE)) [15:12:59] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2876554 (10Stryn) Needing a extra click is not good :/ I used t... [15:14:43] (03CR) 10Mobrovac: [V: 032 C: 032] Use 1.4.0 of wikipedia-edits-scorer (031 comment) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327385 (owner: 10Jdlrobson) [15:14:48] 06Research-and-Data, 10Research-management: Research Offsite Dec 2016: expense reports - https://phabricator.wikimedia.org/T153111#2876561 (10schana) [15:15:39] (03PS30) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:16:03] 06ArchCom, 07Technical-Debt, 10Wikimedia-Developer-Summit (2017): Platforms are Products too! - https://phabricator.wikimedia.org/T149533#2876564 (10daniel) @Tgr my intention is mainly to start considering //ourselves// (payed WMF and WM* staff) users of the mediawiki plattform. 3rd party developers should a... [15:16:06] 10MediaWiki-extensions-Translate, 06Language-Team, 07Easy: Add confirmation message after accepting/rejecting translator applications - https://phabricator.wikimedia.org/T60706#638717 (10Aklapper) @Ashutosh1206: This issue has been assigned to you two months ago. Could you please share a status update? Are... [15:16:09] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:16:33] 10MediaWiki-extensions-Translate: Translation suggestions fail to load - https://phabricator.wikimedia.org/T153299#2876568 (10Kghbln) I am going to transform more and more pages to use the Translate extension so I'd like to note at this point that this one is another great one in the MediaWikiverse. [15:16:42] 10MediaWiki-API, 10MediaWiki-extensions-ZeroBanner, 10MediaWiki-extensions-ZeroPortal, 06Reading-Web-Backlog, and 3 others: Document justification for ApiZeroConfigPrinter and mark modules using it as internal - https://phabricator.wikimedia.org/T91456#2876569 (10Aklapper) @Yurik: This issue has been assig... [15:17:40] 10MediaWiki-API, 07Documentation, 07Easy: Improve documentation of API's "dir" parameter - https://phabricator.wikimedia.org/T58860#2876570 (10Aklapper) a:05D_konto>03None @D_konto: I am resetting the assignee of this task because there have been no signs of progress lately (please correct me if I'm wron... [15:17:50] 10MediaWiki-extensions-BookManager, 07Easy, 07I18n: BookManager shoun't use coll-collections and coll-community_book_prefix directly - https://phabricator.wikimedia.org/T32995#2876573 (10Aklapper) a:05raylton.sousa>03None [15:18:21] 10MediaWiki-extensions-CentralAuth, 07Easy: User:Username@global should be linked to CentralAuth - https://phabricator.wikimedia.org/T91868#2876577 (10Aklapper) @Glaisher: This issue has been assigned to you a while ago. Could you please share a status update? Are you still working (or still plan to work) on... [15:19:01] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Easy: BUG: Campaign date fields cannot be edited as text - https://phabricator.wikimedia.org/T97159#2876581 (10Aklapper) @awight: Can you please answer @amritsreekumar's question? [15:19:28] 10MediaWiki-extensions-ContentTranslation, 07Easy, 07I18n, 07RTL, 07WorkType-Maintenance: Correct direction must be applied to the ContentTranslation language selector in the dashboard after selection - https://phabricator.wikimedia.org/T116357#2876582 (10Aklapper) @Amire80: This issue has been assigned... [15:19:31] 06ArchCom, 07Technical-Debt, 10Wikimedia-Developer-Summit (2017): Platforms are Products too! - https://phabricator.wikimedia.org/T149533#2876583 (10daniel) [15:19:35] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal): Hovercards must display useful text for the majority of articles - https://phabricator.wikimedia.org/T152414#2876586 (10phuedx) [15:19:43] 10MediaWiki-extensions-ContentTranslation, 07Easy, 07I18n, 07RTL, 07WorkType-Maintenance: In RTL UI, language filter ULS is not aligned correctly on the ContentTranslation dashboard - https://phabricator.wikimedia.org/T114097#2876588 (10Aklapper) @Amire80: This issue has been assigned to you 14 months ag... [15:20:02] 10MediaWiki-extensions-FlaggedRevs, 07Easy: Use ResourceLoader/mw.config for jsReviewNeedsChange - https://phabricator.wikimedia.org/T36716#2876589 (10Aklapper) a:05matthiasmullie>03None [15:20:18] 10MediaWiki-extensions-UniversalLanguageSelector, 07Easy: Help pages for all the input methods in Universal Language Selector need to have content - https://phabricator.wikimedia.org/T59601#2876591 (10Aklapper) a:05Arrbee>03None [15:20:25] (03CR) 10Dbrant: [C: 032] Hygiene: replace Button with TextView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/317461 (owner: 10Niedzielski) [15:21:01] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with Wikimedia color palette - https://phabricator.wikimedia.org/T153049#2876593 (10Volker_E) No, the last approach doesn't make sense and the accent blue should only be used for interactiv... [15:21:31] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal): Hovercards must display useful text for the majority of articles - https://phabricator.wikimedia.org/T152414#2847202 (10phuedx) [15:22:02] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal): Previews must display useful text for the majority of articles - https://phabricator.wikimedia.org/T152414#2876595 (10phuedx) [15:22:05] (03CR) 10Bartosz Dziewoński: [] "Given that currently only one collation can be used on a wiki at a time, this doesn't cause issues in practice (except possibly for a brie" [core] - 10https://gerrit.wikimedia.org/r/327502 (owner: 10Bartosz Dziewoński) [15:24:09] 10MediaWiki-extensions-CentralAuth, 07Easy: User:Username@global should be linked to CentralAuth - https://phabricator.wikimedia.org/T91868#2876607 (10Glaisher) a:05Glaisher>03None The above now-abandoned patch actually does implement this but we do not want to do it without migrating to the current log fo... [15:24:37] (03PS1) 10Fjalapeno: Re-add p tags for iOS - needed for proper spacing [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327517 (https://phabricator.wikimedia.org/T152572) [15:25:49] 10UI-Standardization, 13Patch-For-Review, 13Patch-Needs-Improvement: Convert Special:Tags to OOUI - https://phabricator.wikimedia.org/T117742#2876614 (1001tonythomas) Possible #google-code-in-2016 task ? To complete those changes ? @matmarex -- thinking of mentoring ? :D [15:30:37] (03PS1) 10Mobrovac: RESTBase: Add the Citoid config [vagrant] - 10https://gerrit.wikimedia.org/r/327518 (https://phabricator.wikimedia.org/T153214) [15:32:22] (03PS6) 10Pmiazga: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) [15:33:26] (03CR) 10Addshore: [C: 04-1] "Is there a reason this is only being done on REL1_27?" (034 comments) [extensions/Contributors] (REL1_27) - 10https://gerrit.wikimedia.org/r/327488 (owner: 10Ljonka) [15:38:01] (03Merged) 10jenkins-bot: Fix tons of incomplete PHPDoc blocks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/326395 (owner: 10Thiemo Mättig (WMDE)) [15:39:12] (03PS7) 10Pmiazga: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) [15:40:01] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with Wikimedia color palette - https://phabricator.wikimedia.org/T153049#2876656 (10Ladsgroup) You're right, What about `#00af89`? {F5061315} [15:42:05] (03PS8) 10Pmiazga: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) [15:42:15] (03CR) 10Hashar: [V: 032 C: 032] ParserHooks has gone to GitHub [extensions/ParserHooks] - 10https://gerrit.wikimedia.org/r/326884 (owner: 10Reedy) [15:43:01] 06Research-and-Data, 10Research-management: Research Offsite Dec 2016: expense reports - https://phabricator.wikimedia.org/T153111#2876663 (10DarTar) [15:44:03] 10MediaWiki-Uploading, 06Multimedia: Unexpected error "This SVG file contains an illegal namespace" for xmlns:rdfs attribute value - https://phabricator.wikimedia.org/T153285#2876665 (10matmarex) I suppose we need to whitelist it (UploadBase::checkSvgScriptCallback). [15:44:59] (03Merged) 10jenkins-bot: Hygiene: replace Button with TextView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/317461 (owner: 10Niedzielski) [15:49:19] (03PS2) 10Ljonka: Add config option to hide specific usernames [extensions/Contributors] (REL1_27) - 10https://gerrit.wikimedia.org/r/327488 [15:49:28] 07Design, 06Collaboration-Team-Triage, 10Flow: Wikitext editing toolbar for Flow - https://phabricator.wikimedia.org/T78346#2876678 (10Pginer-WMF) a:05Pginer-WMF>03None [15:50:04] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: Support a responsive grid system - https://phabricator.wikimedia.org/T90687#2876679 (10Pginer-WMF) a:05Pginer-WMF>03None [15:50:09] (03CR) 10Yurik: [] "Dbkey might not be good either-- I think it contains special charts that bash won't be happy about, such as quotes" [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) (owner: 10Milimetric) [15:53:09] (03CR) 10Ljonka: [] "> Is there a reason this is only being done on REL1_27" [extensions/Contributors] (REL1_27) - 10https://gerrit.wikimedia.org/r/327488 (owner: 10Ljonka) [15:54:54] 10MediaWiki-Internationalization: Norwegian messages inContentLanguage look for on-wiki overrides at the /nb subpage, not the root page - https://phabricator.wikimedia.org/T126146#2876690 (10thiemowmde) p:05Unbreak!>03Low I don't see how this is Wikidata related. Jan was reviewing this when he was a WMDE emp... [15:57:35] 10MediaWiki-extensions-Translate, 07Easy, 07I18n, 07RTL: Supporting RTL direction in the Special:PageMigration - https://phabricator.wikimedia.org/T139463#2876694 (10Nidhinmahesh1) sorry for the inconvenience. please remove me * best regards,* Nidhin Mahesh Member at FOSS@Amrita (03CR) 10XinyueZ: [] "> I'm not sure I see what issue this is supposed to fix. Would you" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 (owner: 10XinyueZ) [16:00:11] (03CR) 10XinyueZ: [] "> > I'm not sure I see what issue this is supposed to fix. Would you" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 (owner: 10XinyueZ) [16:05:36] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2876714 (10bmansurov) @ovasileva given T147314#2876217, would you please update the task... [16:06:00] 10MediaWiki-Logging, 10MediaWiki-extensions-CentralAuth: Migrate CentralAuth to the current log formatter system - https://phabricator.wikimedia.org/T153322#2876715 (10MarcoAurelio) [16:06:09] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2205167 (10Wikitiki89) @Deskana What does the recently resolved subtask mean for this issue as a whole? [16:09:08] 06Research-and-Data, 10Research-management: Research Offsite Dec 2016: expense reports - https://phabricator.wikimedia.org/T153111#2876756 (10DarTar) [16:10:10] 10MediaWiki-extensions-CentralAuth, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review, 07Wikimedia-log-errors: Centralauth last deployment creating database contention on CentralAuthUser::saveSettings (Lock wait timeout exceeded; try restar... - https://phabricator.wikimedia.org/T139970#2876773 [16:10:42] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with Wikimedia color palette - https://phabricator.wikimedia.org/T153049#2876787 (10Volker_E) [16:10:55] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with WikimediaUI color palette - https://phabricator.wikimedia.org/T153049#2867522 (10Volker_E) [16:14:09] 10Phabricator: Phabricator batch edittor should support mass moving tasks to different sections of the workboard - https://phabricator.wikimedia.org/T153324#2876811 (10MarcoAurelio) [16:15:20] (03PS3) 10Jhernandez: Update the settings enabled radio with the enabled state [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 [16:15:28] (03CR) 10Dbrant: "This seems to have broken EditSectionActivity..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [16:15:46] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 07Performance, and 2 others: FOUC in section "Recently featured" on mobile Main Page - https://phabricator.wikimedia.org/T131423#2876840 (10Jdlrobson) a:03Jdlrobson [16:16:05] (03PS2) 10BearND: Fix a few formatting issues [services/trending-edits] - 10https://gerrit.wikimedia.org/r/325437 [16:17:50] (03PS3) 10BearND: Hygiene: Fix typo [services/trending-edits] - 10https://gerrit.wikimedia.org/r/325437 [16:18:35] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix typo [services/trending-edits] - 10https://gerrit.wikimedia.org/r/325437 (owner: 10BearND) [16:18:57] 10Phabricator (Upstream), 07Upstream: Phabricator batch edittor should support mass moving tasks to different sections of the workboard - https://phabricator.wikimedia.org/T153324#2876884 (10Aklapper) Nothing we'll implement, hence #phabricator-upstream [16:20:44] (03PS1) 10Hashar: Fix Metrolook URL in .gitmodules [skins] - 10https://gerrit.wikimedia.org/r/327532 [16:21:13] (03CR) 10Jhernandez: [] Update the settings enabled radio with the enabled state (033 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [16:21:30] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2205167 (10dcausse) @Wikitiki89 it means that we added all the necessary to enable ICU folding (required for all non-latin alphabets) At first we thought we... [16:21:35] (03PS4) 10Jhernandez: Update the settings enabled radio with the enabled state [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 [16:23:36] (03CR) 10Dbrant: [C: 04-1] "Oh I see! This seems to be a serious regression introduced in a very recent patch: a4feb3b1723a915e8fb4bcc45a0e9a78f8fd5298" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 (owner: 10XinyueZ) [16:25:07] (03CR) 10Jhernandez: [] "I'm not sure if it is important but the last patch of settings functionality is https://gerrit.wikimedia.org/r/#/c/327185/ in case you wan" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 (owner: 10Phuedx) [16:29:02] (03PS1) 10Hashar: Add SynagonismTemplate class to the autoloader [skins/Synagonism] - 10https://gerrit.wikimedia.org/r/327535 [16:29:22] (03Merged) 10jenkins-bot: Hygiene: Fix typo [services/trending-edits] - 10https://gerrit.wikimedia.org/r/325437 (owner: 10BearND) [16:29:36] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2876964 (10jmatazzoni) i see a number of issues here: - First, we need to follow our own guidelines... [16:29:58] (03PS2) 10Hashar: Add SynagonismTemplate class to the autoloader [skins/Synagonism] - 10https://gerrit.wikimedia.org/r/327535 (https://phabricator.wikimedia.org/T113860) [16:30:51] (03PS2) 10Jdlrobson: Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) [16:31:10] (03CR) 10Jdlrobson: [] Test and correct behaviour of getSectionId (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [16:31:25] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2876969 (10Aklapper) Tasks for hooks imported into GCI. [16:33:45] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2876981 (10Elitre) @Stryn says, "Maybe https://fi.wikivoyage.org/wiki/Malline:Listing It's completely without templatedata yet. Templatedata sho... [16:33:49] (03CR) 10XinyueZ: [] "> Oh I see! This seems to be a serious regression introduced in a" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 (owner: 10XinyueZ) [16:34:16] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2876983 (10Elitre) (For other languages: queries like https://quarry.wmflabs.org/query/4322 could be run in case.) [16:35:05] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2876984 (10Wikitiki89) > ICU folding will be enabled on the next reindex batch for english/french and greek wikis. To clarify, does you mean all Wikimedia wi... [16:35:08] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2876985 (10Nirzar) Can we look at an example. it's difficult to understand the impact without that. another question: is this task supposed to enable only for... [16:35:23] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2876986 (10Aklapper) [16:36:11] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Align MediaWiki core UI elements with WikimediaUI color palette - https://phabricator.wikimedia.org/T152025#2877004 (10Volker_E) [16:36:17] 10Phabricator, 06Project-Admins: Make #GlobalRename and #SUL-finalization subprojects of #CentralAuth? - https://phabricator.wikimedia.org/T153327#2877006 (10MarcoAurelio) [16:36:38] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2877021 (10dcausse) >>! In T132637#2876984, @Wikitiki89 wrote: > To clarify, do you mean all Wikimedia wikis in those languages (i.e. including Wiktionary, W... [16:37:49] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2877024 (10Aklapper) [16:41:25] (03CR) 10BearND: [C: 04-1] Add additional information to file and user pages for rendering (034 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [16:42:13] (03CR) 10jenkins-bot: [V: 04-1] Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [16:42:28] (03CR) 10BearND: [C: 032] Re-add p tags for iOS - needed for proper spacing [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327517 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [16:43:04] (03CR) 10Dbrant: "...and it also seems to cause most other activities not to have any toolbar, including Login, CreateAccount, LangLinks, and Settings. Do o" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [16:43:05] 10Phabricator, 06Project-Admins: Make #GlobalRename and #SUL-finalization subprojects of #CentralAuth? - https://phabricator.wikimedia.org/T153327#2877049 (10Aklapper) Which problem would this solve? (And any MW extension also depends on MediaWiki core, however that does not make it a subproject?) [16:45:50] (03CR) 10Pmiazga: [C: 031] "Looks good, not tested" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327129 (owner: 10Jdlrobson) [16:46:44] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Does not allow renaming own accounts with Special:GlobalRenameQueue/open - https://phabricator.wikimedia.org/T111789#1616498 (10MarcoAurelio) You shouldn't be really allowed to rename yourself. During the rename process your account is "locked" and being migr... [16:47:47] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2877062 (10jmatazzoni) [16:51:10] (03CR) 10Bmansurov: [C: 032] "Looks good. Tested on various desktop browsers. Thanks for working on it, pppery." [skins/Vector] - 10https://gerrit.wikimedia.org/r/327288 (https://phabricator.wikimedia.org/T104767) (owner: 10Pppery) [16:51:14] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2877068 (10MarcoAurelio) Can {H29} be amended so when any of the projects are #GlobalRename or #SUL-Finalization the project #CentralAuth be added? Thanks. [16:51:50] 04(no projects): owner of WMFProduct List - https://phabricator.wikimedia.org/T153329#2877070 (10eliza) [16:52:01] 10RW-Prototype, 06Reading-Web-Backlog (Design): Rethink in-article navigation on mobile web [Prototype] - https://phabricator.wikimedia.org/T149690#2877081 (10Nirzar) @SamanthaNguyen sounds good! i will share the updates here. [16:52:11] 04(no projects): owner of WMFProduct List - https://phabricator.wikimedia.org/T153329#2877082 (10eliza) [16:52:22] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Prevent users blocked (or editing from hard-blocked IPs) at meta from asking for global rename - https://phabricator.wikimedia.org/T149895#2768091 (10JEumerus) Besides, requesting a global rename and editing on meta wiki are distinctly different things. [16:58:02] tonythomas: Are you there? [16:58:12] rlot: I think yes :D [16:58:25] So task "Fix undeleting/restoring a Newsletter from the Special:Undelete page (by completing the work in an existing patch)" [16:58:42] Looks intresting, but this patch is little chaotic [16:59:25] rlot: feel free to edit it any way you need! [16:59:27] And how i can complete work in excisting patch [16:59:46] rlot: that is the beauty of Gerrit (and open source in general) [16:59:57] rlot: did you read the description of the task ? We have instructions on how to amend a change [17:00:19] tonythomas: Ok, i didn't scrolled down [17:00:41] rlot: you find the best at the bottom! [17:01:08] tonythomas: So functionality is made, i need to fix it up? [17:01:12] 10Phabricator, 06Project-Admins: Make #GlobalRename and #SUL-finalization subprojects of #CentralAuth? - https://phabricator.wikimedia.org/T153327#2877109 (10MarcoAurelio) MW extensions are suficiently unique IMHO to have a project for its own, even if it is true that it needs MediaWiki core to work. GlobalRe... [17:01:29] rlot: I dont think the functionality is completely made (check my reviews on the patch) ? [17:01:52] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2877111 (10Elitre) For it.wp, I found https://it.wikipedia.org/wiki/Template:Cita_tweet . [17:01:59] tonythomas: But code is made correctly? [17:02:16] tonythomas: I think, i do not need to refactor it? [17:02:29] rlot: I dont think so. If the code was correct, then it should work great! [17:02:40] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2877112 (10Nirzar) @bmansurov good catch. we should hide the bar in the footer which gives our information that is not relevant (not appropriate) here. [17:02:43] rlot: I think you need to check out whats happening with my review, and thast it [17:03:26] and Reedy 's comment as well [17:04:09] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2877118 (10bmansurov) @jhobs, since you're in charge of the chore wheel today, please update the description of the task per T153125#2877112 and move to the appropriate column. Thanks. [17:04:28] tonythomas: I need to take closer look, but i'm claiming it! [17:04:48] tonythomas: This will be intesting [17:04:55] it should be, yes! [17:06:05] (03Merged) 10jenkins-bot: Re-add p tags for iOS - needed for proper spacing [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327517 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [17:06:08] (03Merged) 10jenkins-bot: Specify height of tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/327288 (https://phabricator.wikimedia.org/T104767) (owner: 10Pppery) [17:06:10] 10Phabricator, 06Project-Admins: Make #GlobalRename and #SUL-finalization subprojects of #CentralAuth? - https://phabricator.wikimedia.org/T153327#2877142 (10Aklapper) I'm neutral, I'd just like to understand the motivation better, hence I asked. :) I'd say this needs input from affected maintainers. [17:08:21] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2877149 (10Anomie) >>! In T151770#2875829, @BurritoBazooka wrote: > This is an HAR file from Firefox 50.0.2, attempting to submit an edit and t... [17:08:37] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2877151 (10Aklapper) Are [[ https://phabricator.wikimedia.org/maniphest/query/QDtmnZKEAdlk/#R | these open SUL-Finalization tasks ]] automatically also t... [17:10:35] tonythomas: Ok, if undelete was made succesfully, it should return true? Why there's no else with false? [17:11:57] 10MediaWiki-extensions-Gadgets, 07Epic: Implement global gadgets (WMF-wide) - https://phabricator.wikimedia.org/T22153#2877173 (10DannyH) [17:12:52] (03PS5) 10VolkerE: Minor adjustments to align with WikimediaUI color palette, all but one of them affecting border-colors and in one case a :hover background-color. [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [17:13:03] rlot: I am not sure about that one either :-( You have to take a look at how Mediawiki hooks work, or maybe ping Reedy here! [17:13:14] (well, I got some idea, but I dont think that is what you want here) [17:13:20] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2877174 (10MarcoAurelio) >>! In T141703#2877151, @Aklapper wrote: > Are [[ https://phabricator.wikimedia.org/maniphest/query/QDtmnZKEAdlk/#R | these open... [17:13:23] Reedy: Can you take a look? [17:13:30] At what? [17:13:33] There's a lot of backscroll [17:13:44] I'm trying to end this [17:13:44] https://gerrit.wikimedia.org/r/#/c/320370/ [17:13:57] Ok, if undelete was made succesfully, it should return true? Why there's no else with false? [17:14:10] Well, it depends on the hook caller [17:14:34] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2877177 (10BethNaught) >>! In T150045#2876153, @Sn1per wrote: >... [17:14:55] It would be useful to look at where the hook is run in WM [17:14:56] *MW [17:14:58] Also, see https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L197-L204 [17:14:59] Reedy: And do you think, this skeleton of code is done correctly [17:15:05] ? [17:16:07] It looks vaguely correct, yes [17:16:13] At one point, MW always had to have areturn value from hooks [17:16:20] It's not been the case for a few years [17:16:34] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2877180 (10ovasileva) [17:16:43] 10MediaWiki-extensions-MultimediaViewer, 10Hovercards, 06Reading-Web-Backlog: WANObjectCache breaks extending $wgDefaultUserOptions via ExtensionFunctions in extensions. - https://phabricator.wikimedia.org/T153280#2877182 (10jhobs) p:05Triage>03Normal [17:16:49] I was questioning tonythomas' comment, as the MW code says, if you return false, it'll stop processsing [17:16:54] Which means any other hook subscribers won't run [17:17:13] Reedy: So it should return true [17:17:14] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2688614 (10ovasileva) @bmansurov - updated description to allow for pausing timer based... [17:17:17] (03PS1) 10Mglaser: ExtensionManager: Added deprecation code hints and method documentation [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/327547 [17:17:28] Reedy: But this code is really close to end it [17:17:32] Reedy: once we find out that the user was trying to undelete something from the Newsletter namespace, do we need anything else to run / [17:17:49] tonythomas: What if another extension was building ontop? [17:17:55] Or, changing some other tracking/stats etc [17:18:04] Generally, you wouldn't want to stop other hooks running [17:18:07] Reedy: oh. I never thought about all this [17:18:13] I mean, sure [17:18:21] yeah. that makes sense [17:18:24] If the shit hit the fan, and everything is broken, you'll want to throw an error [17:18:29] Which makes sense [17:18:40] But if things were fine... It generally wouldn't make much sense to stop [17:18:40] Reedy: true :D I can update my comments there! [17:18:53] But, if $newsletter is null, it should stop hooks? [17:19:20] Why would it? [17:19:29] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2877190 (10bmansurov) @ovasileva if we pause, we don't have to log the page visibility i... [17:19:45] 10MediaWiki-Watchlist, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2877191 (10Sn1per) Since the original form-submission-based res... [17:19:48] yeah - no stopping of hooks, and if $newsletter is null - then there is some serious thing happening too [17:20:10] like the thing belonged to the Newsletter namespace, but surprisingly is missing from the db [17:20:18] Yeah [17:20:28] Sounds like a race condition or similar [17:20:32] https://gerrit.wikimedia.org/r/#/c/320370/3/includes/NewsletterStore.php [17:20:34] Not generally expected behaviour [17:20:53] yeah. but we should make our code ready to accept them in. [17:21:00] so no stopping the hooks. [17:21:02] 10MediaWiki-Database: Improve MediaWiki:Dberrortext to link to a config-defined status page - https://phabricator.wikimedia.org/T2398#2877195 (10Aklapper) Looking at the task description, what is the reason for having "a config-defined status page"? Also, it looks like https://translatewiki.net/wiki/MediaWiki:Db... [17:21:07] $newsletter = getNewsletterFromName [17:21:12] It should be like that [17:22:45] 10MediaWiki-Database, 13Patch-For-Review, 07Performance, 07Schema-change, 07User-notice: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#90771 (10DannyH) [17:22:47] That would mean getNewsletterFromName is a global function [17:22:51] Which it's not [17:23:17] 10PageImages, 06Reading-Web-Backlog: Page images API doesn't return an image when the image is an imagemap - https://phabricator.wikimedia.org/T152798#2877215 (10bmansurov) Looks like we need to analyze articles from https://en.wikipedia.org/wiki/Category:Articles_containing_image_maps. However, if an image m... [17:23:47] So i'll include it? [17:24:07] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 15User-Daniel: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#2877216 (10Hall1467) I'd be happy to take the lead on the implementation of this task. Would that be okay? [17:26:03] (03CR) 10Thiemo Mättig (WMDE): [] "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327158 (owner: 10Thiemo Mättig (WMDE)) [17:26:27] 10MediaWiki-Revision-deletion, 10MediaWiki-extensions-CentralAuth, 06Stewards-and-global-tools, 07Vuln-Infoleak: Global suppression does not work properly when the target has already been locally blocked - https://phabricator.wikimedia.org/T25310#2877217 (10MarcoAurelio) [17:27:12] 07Design, 10UI-Standardization, 03UI-Standardization-Kanban: Provide a color palette and design for buttons that are purely highlighted links, to distinguish them from actual UI buttons - https://phabricator.wikimedia.org/T116549#2877224 (10Volker_E) p:05Triage>03Low [17:27:23] 10Wikimedia-General-or-Unknown, 07Tracking: Steward, global sysop and SWMT tasks bugs (tracking) - https://phabricator.wikimedia.org/T43492#2877227 (10MarcoAurelio) Blocking task still need removal, but I'll wait until I can do this w/o noise. [17:27:37] rlot: I think you should just use the existing Newsletter::newFromName( $title->getText() ); [17:27:59] 10MediaWiki-Parser, 07I18n: Anchors to section names for non-ASCII letters are encoded in the URL - https://phabricator.wikimedia.org/T75092#765515 (10DannyH) [17:28:20] 10MediaWiki-Special-pages, 07Easy: Special:WantedPages should order pages alphabetically when these pages have the same count - https://phabricator.wikimedia.org/T4335#2877246 (10Aklapper) p:05Low>03Lowest [17:28:23] 10UI-Standardization, 07Accessibility, 07Tracking, 03UI-Standardization-Kanban: Replace abandoned colors in current WMF/Wikimedia products - https://phabricator.wikimedia.org/T148708#2877251 (10Volker_E) p:05Triage>03High [17:28:46] (03CR) 10jenkins-bot: [V: 04-1] Remove non-helpful @param documentation from CentralAuthPlugin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327158 (owner: 10Thiemo Mättig (WMDE)) [17:29:26] 06Stewards-and-global-tools, 07Tracking: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools] - https://phabricator.wikimedia.org/T43492#2877256 (10MarcoAurelio) 05declined>03Invalid p:05Normal>03Lowest a:05Legoktm>03None [17:29:52] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2877264 (10Jarekt) By the way, for me the errors were consistently associated with use of [[ https://en.wikipedia.org/wiki/Wikipedia:MTC! | MTC... [17:31:46] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2877266 (10Jdlrobson) @nirzar we have a legal obligation to link to the history... but even if we hide it, this also doesn't help guide us with what to do in the mobileview api - we s... [17:31:54] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2877267 (10jhobs) p:05Triage>03Normal [17:32:44] 10MediaWiki-Special-pages, 07Easy: Option to hide rows from Special:Contributions where the edit is the most recent to a page - https://phabricator.wikimedia.org/T5753#2877274 (10Aklapper) [17:33:45] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2877284 (10Nirzar) @Jdlrobson we can include that in the top banner. it already next rev, prev rev, and it can have overall history link. let me put up a mock. [17:34:30] 10PageImages, 06Reading-Web-Backlog: Page images API doesn't return an image when the image is an imagemap - https://phabricator.wikimedia.org/T152798#2877286 (10Jdlrobson) That sounds like a good first step. My concern is we shouldn't introduce code if it's not useful due to the time it takes to implement thi... [17:35:08] 10MediaWiki-extensions-Translate, 13Patch-For-Review, 07User-notice: Translation pages: display outdated translations as such, without removing them - https://phabricator.wikimedia.org/T60429#2877287 (10Nemo_bis) [17:36:53] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2877305 (10YMS) I have never used the MTC! tool, so this correlation does not apply for me. Attached is a HAR file from my Firefox 50.1.0. Tha... [17:37:02] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 07User-notice: Send notification to account owner on multiple unsuccessful login attempts - https://phabricator.wikimedia.org/T11838#137154 (10DannyH) [17:38:19] 10MediaWiki-Database, 13Patch-For-Review, 07Performance, 07Schema-change, 07User-notice: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2877312 (10Domas) some newer mysql branches have a patch that allows efficient mostly covering index on large columns - then this can be... [17:39:06] 07Design, 10Living-Style-Guide, 10UI-Standardization, 03UI-Standardization-Kanban: Possible issues with applied `line-height` on buttons - https://phabricator.wikimedia.org/T137596#2877313 (10Volker_E) p:05Triage>03Lowest [17:39:24] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: CapsuleMultiSelectWidget: Label doesn't function as label - https://phabricator.wikimedia.org/T148946#2877317 (10Volker_E) p:05Triage>03Normal [17:40:06] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox - https://phabricator.wikimedia.org/T149654#2877321 (10Volker_E) p:05Triage>03Normal [17:40:28] 10UI-Standardization, 07Documentation, 03UI-Standardization-Kanban: Document "Basic styles implemented with base CSS & accompanying HTML" on MediaWiki on how to use - https://phabricator.wikimedia.org/T118920#2877323 (10Volker_E) p:05Triage>03Normal [17:41:16] 07Design, 10UI-Standardization, 06WMF-Design, 07Tracking, 03UI-Standardization-Kanban: Design shortcomings of current M101 widget overview (tracking) - https://phabricator.wikimedia.org/T136371#2877326 (10Volker_E) p:05High>03Normal [17:43:10] (03CR) 10EBernhardson: [] Cleanup execution flow through SpecialSearch::execute() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) (owner: 10EBernhardson) [17:43:14] 10MediaWiki-ResourceLoader, 10MobileFrontend, 06Reading-Web-Backlog, 07Performance: ResourceLoaderImage: Add option to generate only certain variants (not all) - https://phabricator.wikimedia.org/T149406#2877329 (10Jdlrobson) 05Open>03declined The problem has gone away since we redesigned the main menu... [17:43:22] (03CR) 10EBernhardson: [] Pull rendering of single result out of SpecialSearch (0317 comments) [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [17:44:22] tonythomas: $newsletter = Newsletter::newFromName( $title->getText() ); [17:44:22] [17:44:22] if ( $title->inNamespace( NS_NEWSLETTER ) ) { [17:44:22] $store = NewsletterStore::getDefaultInstance(); [17:44:22] $store->restoreNewsletter( $title->getText() ); [17:44:22] } [17:44:56] tonythomas: Here, why i cant just change param of restoreNewsletter to $newsletter, and get its name by ->getTitle? [17:45:30] tonythomas: Or, i see theres getName( [17:46:59] (03CR) 10Mobrovac: [C: 04-1] "I would be more comfortable with going live with this only after mobileview starts accepting the revision parameter. I am aware that you t" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [17:47:57] (03PS7) 10Kaartic: Make SyntaxHighlighter correctly highlight the last word [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) [17:49:15] (03CR) 10BearND: [C: 031] "Mobrovac Is my understanding correct that this would only go live once the respective change in RESTBase is deployed?" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [17:50:29] (03CR) 10Ppchelko: [] "@bearND Yes, but there's quite a lot of work to support this in RESTBase, so that won't happen until after the all hands. See https://phab" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [17:50:49] (03PS1) 10Dbrant: Revert "Hygiene: Separate Activity classes into themed and unthemed variants" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327552 [17:52:27] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Does not allow renaming own accounts with Special:GlobalRenameQueue/open - https://phabricator.wikimedia.org/T111789#2877368 (10Steinsplitter) >>! In T111789#2877059, @MarcoAurelio wrote: > You shouldn't be really allowed to rename yourself. During the rename... [17:52:30] (03CR) 10Mobrovac: [C: 04-1] "Regardless of the RESTBase part, in order to keep coherent (and keep our sanity), if mobileview does not support something MCS would like/" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [17:53:12] 07Design, 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2877369 (10Nirzar) [17:53:50] (03CR) 10EBernhardson: [] Extract search form from SpecialSearch into widget (034 comments) [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [17:54:05] (03PS8) 10Kaartic: Make SyntaxHighlighter correctly highlight the last word and prevent it from highlighting unmatched symbols [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) [17:54:46] (03PS3) 10Jdlrobson: Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) [17:55:20] (03CR) 10Mobrovac: [V: 032 C: 032] Update preq dependency [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND) [17:55:26] 10MediaWiki-Templates, 07Easy: Don't mark external links to the current wiki as external - https://phabricator.wikimedia.org/T13477#2877377 (10Aklapper) Where would the check for the siteurl being part of a link (and then not setting the 'external' icon) have to happen? `makeExternalLink()` in `/includes/Linke... [17:56:34] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2877382 (10Catrope) >>! In T153284#2876195, @Pginer-WMF wrote: >>>! In T153284#2875499, @Catrope wrote:... [17:57:46] 10MobileFrontend, 06Reading-Web-Backlog: List items are not displaying correctly on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T153199#2877384 (10jhobs) p:05Triage>03Normal Marking Normal, but please escalate to High if this turns out to be a regression. [18:00:54] (03CR) 10Jdlrobson: [] "> I would be more comfortable with going live with this only after mobileview starts accepting the revision parameter. I am aware that you" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326868 (https://phabricator.wikimedia.org/T146836) (owner: 10Jdlrobson) [18:01:09] 06Community-Liaisons (Oct-Dec-2016), 06Developer-Relations (Oct-Dec-2016): Technical Collaboration quarterly check in for January – March 2017 - https://phabricator.wikimedia.org/T150658#2877389 (10Elitre) [18:01:14] (03PS7) 10Jdlrobson: Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) [18:02:56] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Does not allow renaming own accounts with Special:GlobalRenameQueue/open - https://phabricator.wikimedia.org/T111789#2877391 (10MarcoAurelio) I obviously did, sorry. [18:04:34] tonythomas: tonythomas: $newsletter = Newsletter::newFromName( $title->getText() ); [18:04:34] [18:04:34] if ( $title->inNamespace( NS_NEWSLETTER ) ) { [18:04:34] $store = NewsletterStore::getDefaultInstance(); [18:04:35] $store->restoreNewsletter( $title->getText() ); [18:04:37] } [18:04:38] tonythomas: Here, why i cant just change param of restoreNewsletter to $newsletter, and get its name by ->getTitle? [18:04:41] tonythomas: Or, i see theres getName( [18:04:51] (03CR) 10C. Scott Ananian: [] LanguageConverter fixes to eliminate parser test failures (031 comment) [core] - 10https://gerrit.wikimedia.org/r/76341 (https://phabricator.wikimedia.org/T54190) (owner: 10Liangent) [18:05:40] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: MediaWiki theme: SelectFileWidget: Re-evaluate “File selection is not supported” message - https://phabricator.wikimedia.org/T149657#2877400 (10Volker_E) p:05Triage>03Low [18:07:05] (03CR) 10jenkins-bot: [V: 04-1] Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [18:07:27] (03PS1) 10Mholloway: Revert "Hygiene: Separate Activity classes into themed and unthemed variants" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327557 [18:07:30] rlot_: getName(), is it some Newsletter extension specific function ? [18:07:49] (03CR) 10Niedzielski: [C: 032] Revert "Hygiene: Separate Activity classes into themed and unthemed variants" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327552 (owner: 10Dbrant) [18:07:58] (03CR) 10Niedzielski: "Michael, we're temporarily reverting this guy due to an unspotted regression. I'd love to have this change in so please take another stab " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [18:08:13] 10MediaWiki-API, 07Easy: API's list=recentchanges should have rcrelated parameter (provide Special:RelatedChanges/Special:RecentChangesLinked functionality via API) - https://phabricator.wikimedia.org/T17552#2877401 (10Aklapper) >>! In T17552#196744, @MZMcBride wrote: > Marking this bug as "easy" as I don't th... [18:08:31] (03CR) 10C. Scott Ananian: [] Don't parse language converter markup as a cell parameter in tables. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) (owner: 10C. Scott Ananian) [18:08:57] tonythomas: Its Newsletter::getName() [18:09:13] Is it equivalent to $title constructor? [18:09:34] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: OOjs UI Demo shouldn't prevent text scaling and zooming - https://phabricator.wikimedia.org/T149652#2877406 (10Volker_E) p:05Triage>03Normal [18:09:37] 10MediaWiki-extensions-CentralAuth, 06Community-Tech: Add indices for local_user_id and global_user_id in production - https://phabricator.wikimedia.org/T148243#2877411 (10kaldari) [18:09:40] tonythomas see public function restoreNewsletter( $newsletter, $reason ) { [18:09:40] $success = $this->db->restoreNewsletter( $newsletter->getName() ); [18:09:40] if ( $success ) { [18:09:40] $this->logger->logNewsletterRestored( $newsletter, $reason ); [18:09:41] } [18:09:41] return $success; [18:09:41] 10MediaWiki-extensions-CentralAuth, 03Community-Tech-Sprint, 13Patch-For-Review, 07User-notice: Fully populate local_user_id and global_user_id fields in production - https://phabricator.wikimedia.org/T148242#2877409 (10kaldari) 05Open>03Resolved Done. [18:09:43] } [18:10:00] I made $newsletter to be newsletter, not name [18:10:13] (03CR) 10Kaartic: [] "> Unfortunately this introduces another regression: certain" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) (owner: 10Kaartic) [18:10:14] 07Design, 10UI-Standardization, 03UI-Standardization-Kanban: Redesign the "UnTrash" icon to better represent its meaning - https://phabricator.wikimedia.org/T149398#2877413 (10Volker_E) p:05Triage>03Low [18:10:31] 07Design, 10UI-Standardization, 03UI-Standardization-Kanban: Redesign the "UnTrash" icon to better represent its meaning - https://phabricator.wikimedia.org/T149398#2751011 (10Volker_E) p:05Low>03Lowest [18:11:02] rlot_: and on the side note, people do not always paste the entire code like this in IRC channels! [18:11:02] (03PS4) 10Jdlrobson: Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) [18:11:04] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2877415 (10kaldari) 05Open>03Resolved a:03kaldari @Marostegui: The script is finished. Feel free to reinstate the lag checks. [18:11:20] rlot_: so its a newsletter specific function [18:11:28] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: NumberInputWidget doesn't have explicit label - https://phabricator.wikimedia.org/T149644#2877420 (10Volker_E) p:05Triage>03Normal [18:11:46] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: ComboBoxInput- & CapsuleMultiSelectWidget's MenuSelectWidget required `aria-expanded` attribute is missing - https://phabricator.wikimedia.org/T149653#2877421 (10Volker_E) p:05Triage>03Normal [18:11:51] 10UI-Standardization, 03UI-Standardization-Kanban: Automation support to prevent close (indistinguishable) colors from being added to CSS/Less - https://phabricator.wikimedia.org/T147533#2877422 (10Volker_E) p:05Triage>03Normal [18:11:58] 10UI-Standardization, 03UI-Standardization-Kanban: Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component - https://phabricator.wikimedia.org/T127405#2877423 (10Volker_E) p:05Triage>03High [18:12:09] 10UI-Standardization, 03UI-Standardization-Kanban: Put current use of SVG (icon) build task and integration on trial - https://phabricator.wikimedia.org/T127744#2877424 (10Volker_E) p:05Triage>03Low [18:12:15] (03CR) 10Mholloway: "I actually pushed the revert button from here in the sick day void ;D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [18:12:18] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: DraggableGroupWidget's OptionWidgets feature `role=option`, but not necessary `role=listbox` on widget itself - https://phabricator.wikimedia.org/T149650#2877425 (10Volker_E) p:05Triage>03Normal [18:12:35] Yes, but i need to access $newsletter in Store->restoreNewsletter. So i changed params of restoreNewsletter to use Newsletter, insead of newsletter title [18:12:44] (03Merged) 10jenkins-bot: Revert "Hygiene: Separate Activity classes into themed and unthemed variants" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327552 (owner: 10Dbrant) [18:12:56] tonythomas: I think i fixed some mistakes, i'll test it locallty [18:13:07] rlot_: alright. do test it, and amend [18:14:04] (03PS20) 10C. Scott Ananian: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [18:14:25] (03CR) 10C. Scott Ananian: [] "Rebased." [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [18:14:41] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [18:15:25] (03Abandoned) 10Dbrant: Revert "Hygiene: Separate Activity classes into themed and unthemed variants" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327557 (owner: 10Mholloway) [18:15:45] tonythomas: Where can i undelete newsletter? [18:15:52] tonythomas: I cant see any logs [18:16:02] tonythomas: What should i search for? [18:16:13] rlot_: you should follow the instructions in the task topdown [18:16:13] (03CR) 10Mholloway: "I sort of lurk ;)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327557 (owner: 10Mholloway) [18:16:26] in case you do not find something, you can comment there on phab [18:18:10] (03Abandoned) 10Dbrant: Fixed to re-get toolbar(actionbar) in EditSectionActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 (owner: 10XinyueZ) [18:19:26] 10MediaWiki-Internationalization, 06Language-Team, 07I18n, 07Regression: Message overrides not working on no.wikibooks.org - https://phabricator.wikimedia.org/T151247#2812167 (10greg) Still UBN!? [18:19:29] 10MediaWiki-Internationalization: Norwegian messages inContentLanguage look for on-wiki overrides at the /nb subpage, not the root page - https://phabricator.wikimedia.org/T126146#2877452 (10greg) >>! In T126146#2876690, @thiemowmde wrote: > I also don't see how a months old patch can become "unbreak now". What... [18:21:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 15User-Daniel: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#2877463 (10daniel) @Hall1467 If you want to work on it, sure, go ahead! However, note that we may choose to not track this information if it turn... [18:21:58] 10Recommendation-API: Keep order from related_articles intact - https://phabricator.wikimedia.org/T153338#2877465 (10schana) [18:23:22] (03PS2) 10Niedzielski: Hygiene: add AppTextViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327427 (https://phabricator.wikimedia.org/T152213) [18:23:24] (03PS1) 10Niedzielski: Hygiene: add ArticleHeaderViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327558 (https://phabricator.wikimedia.org/T152213) [18:24:23] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2877499 (10jhobs) >>! In T147314#2877190, @bmansurov wrote: > @ovasileva if we pause, we... [18:25:03] (03CR) 10EBernhardson: [] Extract main search result rendering from SpecialSearch (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [18:25:14] tonythomas: Ok, i can see, deletion log is not showing as "deletion log" [18:25:33] 10Android-app-Bugs, 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Pronunciation icon should scale with user font size - https://phabricator.wikimedia.org/T153340#2877508 (10Niedzielski) [18:25:47] tonythomas: I think its something with NewsletterLogger logNewsletter Deleted [18:26:16] 10MediaWiki-Parser, 07Easy, 07I18n: MediaWiki:Cascadeprotected and MediaWiki:Cascadedprotectedwarning should take the same parameters - https://phabricator.wikimedia.org/T18111#2877522 (10Aklapper) [18:26:19] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2877524 (10ovasileva) [18:26:34] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2877526 (10cscott) [18:26:44] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2862861 (10Volker_E) @Ladsgroup I'm missing the validation screens above as they undergo slight (color) ch... [18:26:48] (03CR) 10EBernhardson: [] Extract 'did you mean' widget out of SpecialSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [18:26:51] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2877541 (10cscott) [18:27:03] (03PS11) 10EBernhardson: Pull rendering of single result out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) [18:27:06] (03PS16) 10EBernhardson: Cleanup execution flow through SpecialSearch::execute() [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) [18:27:09] (03PS18) 10EBernhardson: Extract search form from SpecialSearch into widget [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) [18:27:12] (03PS25) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) [18:27:15] (03PS21) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) [18:27:18] (03CR) 10Phuedx: [] Test and correct behaviour of getSectionId (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [18:28:23] 06Reading-Web-Backlog, 07Epic, 10Hovercards (2016-17-Q2-Goal): [EPIC] Hovercards technical debt and quality enhancements - https://phabricator.wikimedia.org/T144522#2877549 (10jhobs) [18:28:50] (03PS2) 10Dbrant: Fixed null-ptr crash if support actionbar retuns null [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327368 (owner: 10XinyueZ) [18:29:14] (03CR) 10Phuedx: [C: 04-1] "See inline :'( Do you want me to fix it up?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [18:29:26] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-12-14): Select logo for Wikispeech - https://phabricator.wikimedia.org/T142564#2877550 (10Jopparn) [18:30:08] 10Reading Epics: Central Notice for Apps - https://phabricator.wikimedia.org/T153342#2877553 (10Fjalapeno) [18:30:10] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2877552 (10cscott) Alternatively, we could dump the table of "languages with variants defined" as part of the per-wiki siteinfo. [18:30:31] tonythomas: Found bug in Newsletter, i added "$log->setDeleted();" to NewsletterLogger.php and its working [18:30:53] (03PS5) 10Jdlrobson: Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) [18:30:58] (03Abandoned) 10Jdlrobson: POC: Add missing test case for I36c231c1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327498 (owner: 10Phuedx) [18:31:00] 10Reading Epics: On This Day - https://phabricator.wikimedia.org/T153343#2877568 (10Fjalapeno) [18:31:12] 10Reading Epics: On This Day Language Expansion - https://phabricator.wikimedia.org/T153344#2877581 (10Fjalapeno) [18:32:22] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-12-14): Select logo for Wikispeech - https://phabricator.wikimedia.org/T142564#2877598 (10Jopparn) The new official logotype for Wikispeech! https://commons.wikimedia.org/wiki/File:Wikispeech_Logo_Proposals_v1_logo_3.svg [18:33:31] (03CR) 10jenkins-bot: [V: 04-1] Pull rendering of single result out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [18:33:34] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2877602 (10cscott) Another wrinkle: the PHP parser doesn't take into account "disabled variants" when determining whether to parse `-{...}-` c... [18:35:02] (03CR) 10jenkins-bot: [V: 04-1] Extract search form from SpecialSearch into widget [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [18:35:06] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Review external Agile trainings for Admin - https://phabricator.wikimedia.org/T152555#2877605 (10ggellerman) 05Open>03Resolved [18:35:38] kaldari: still got sysadmin/staff access? I wonder if you could have a look at a very consuming abusefilter and suggest or do improvements on it? [18:37:00] How to set log type to Deleted? [18:37:06] 10TPG-Essential-Functions, 10TPG-FY2016-17-Q2-Embedded-Support, 10TPG-Epics (Administer and process Team Practices Customer Satisfaction survey for FY 2016-17 Q2 (Oct-Dec 2016)), 06Team-Practices (This-Week): Update CSAT wiki to include instructions for fut... - https://phabricator.wikimedia.org/T152112#2877613 [18:37:19] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Disallow renaming own accounts with Special:GlobalRenameQueue - https://phabricator.wikimedia.org/T111789#2877614 (10MarcoAurelio) [18:37:29] (03CR) 10Dbrant: [C: 032] Make SyntaxHighlighter correctly highlight the last word and prevent it from highlighting unmatched symbols [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) (owner: 10Kaartic) [18:37:41] (03CR) 10jenkins-bot: [V: 04-1] Cleanup execution flow through SpecialSearch::execute() [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) (owner: 10EBernhardson) [18:37:53] 10Android-app-Bugs, 07Easy, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Syntax highlighter fails to highlight last character of text. - https://phabricator.wikimedia.org/T148191#2877616 (10Dbrant) [18:37:56] 06Research-and-Data: ORES in Q3 - https://phabricator.wikimedia.org/T152994#2877618 (10DarTar) [18:38:47] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-12-14): Write blog post for WMF about Wikispeech - https://phabricator.wikimedia.org/T137528#2877623 (10Jopparn) The new logotype has been added to the draft: https://commons.wikimedia.org/wiki/File:Wikispeech_Logo_Proposals_v1_logo_3.svg [18:39:02] (03CR) 10jenkins-bot: [V: 04-1] Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [18:39:18] (03CR) 10Dbrant: [C: 032] Fixed null-ptr crash if support actionbar retuns null [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327368 (owner: 10XinyueZ) [18:39:27] Reedy: Are you there? [18:40:48] (03Merged) 10jenkins-bot: Make SyntaxHighlighter correctly highlight the last word and prevent it from highlighting unmatched symbols [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) (owner: 10Kaartic) [18:41:58] (03CR) 10Dbrant: [C: 04-1] "I would really prefer if the zoom effect was animated, instead of jumping in and out of zoom. However, I would be fine with merging this, " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326286 (owner: 10XinyueZ) [18:42:05] 10TPG-Essential-Functions, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Working agreements for Coaches - https://phabricator.wikimedia.org/T151251#2877638 (10KLans_WMF) 05Open>03Resolved [18:42:15] 10TPG-Essential-Functions, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Working agreements for Coaches - https://phabricator.wikimedia.org/T151251#2812293 (10KLans_WMF) [18:42:22] (03CR) 10jenkins-bot: [V: 04-1] Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [18:42:34] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2877641 (10kaldari) This seems to make sense. We should double-check that autoblocks don't spawn their own cookies, otherwise it'll be spawni... [18:43:05] (03Merged) 10jenkins-bot: Fixed null-ptr crash if support actionbar retuns null [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327368 (owner: 10XinyueZ) [18:43:20] 10Dumps-Generation: wikidata page dumps very slow this month - https://phabricator.wikimedia.org/T153345#2877642 (10ArielGlenn) [18:43:58] (03PS12) 10EBernhardson: Pull rendering of single result out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) [18:44:51] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Incorporate Editing offsite planning retro actions into Offsite planning guide - https://phabricator.wikimedia.org/T152057#2836782 (10ksmith) [18:46:06] (03CR) 10Dbrant: [C: 032] Hygiene: add script for testing translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326463 (owner: 10Niedzielski) [18:46:25] (03PS9) 10Pmiazga: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) [18:46:35] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2877661 (10kaldari) [18:46:52] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Conduct LE survey for annual planning retrospective work - https://phabricator.wikimedia.org/T152124#2877662 (10ksmith) [18:47:03] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2864536 (10kaldari) p:05Triage>03Normal [18:47:41] 10TPG-Essential-Functions, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Publicizing the Coaching Clinic - https://phabricator.wikimedia.org/T151254#2877664 (10KLans_WMF) [18:48:04] 10TPG-Essential-Functions, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Publicizing the Coaching Clinic - https://phabricator.wikimedia.org/T151254#2812348 (10KLans_WMF) a:05KLans_WMF>03NHarateh_WMF [18:48:33] 06Discovery, 10Wikimedia-Portals, 06Discovery-Analysis (Current work), 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia/Wikimedia apps availability test: analyze results - https://phabricator.wikimedia.org/T146807#2877681 (10JKatzWMF) @mpopov Thanks! [18:48:40] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2877683 (10kaldari) [18:48:43] (03CR) 10Phuedx: [C: 032] Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [18:49:15] 10TPG-Essential-Functions, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Publicizing the Coaching Clinic - https://phabricator.wikimedia.org/T151254#2812348 (10KLans_WMF) @NHarateh_WMF I think you're not eh hook to make a flyer, which could help this effort along. @ggeller... [18:49:40] (03Merged) 10jenkins-bot: Hygiene: add script for testing translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326463 (owner: 10Niedzielski) [18:49:49] (03CR) 10Phuedx: [C: 032] "^ Per my review of PS1. PS2, 3, and 4 were fixing the minor-if-not-trivial parts of the review and squashing I70462fe9." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [18:50:01] 10TPG-Essential-Functions, 10TPG-Epics (Team Practices Group Coaching Clinic), 06Team-Practices (This-Week): Dry run/practice sessions with Coach volunteers - https://phabricator.wikimedia.org/T151250#2877688 (10KLans_WMF) 05Open>03Resolved [18:50:07] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2877690 (10Marostegui) Thanks for the heads up - I have now removed the downtimes. [18:50:51] (03PS17) 10EBernhardson: Cleanup execution flow through SpecialSearch::execute() [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) [18:50:54] (03PS19) 10EBernhardson: Extract search form from SpecialSearch into widget [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) [18:50:56] 10MediaWiki-extensions-CentralNotice, 07Easy, 07I18n: All messages in CentralNotice are defaulted to English regardless of content language - https://phabricator.wikimedia.org/T18321#2877705 (10Aklapper) [18:50:57] (03PS26) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) [18:51:00] (03PS22) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) [18:51:46] 10MediaWiki-extensions-CentralNotice, 07I18n: All messages in CentralNotice are defaulted to English regardless of content language - https://phabricator.wikimedia.org/T18321#212311 (10Aklapper) > See SpecialNoticeTemplate::showView() That function got removed in https://phabricator.wikimedia.org/rECNO4ea6241... [18:51:49] (03CR) 10Paladox: [C: 031] Add SynagonismTemplate class to the autoloader [skins/Synagonism] - 10https://gerrit.wikimedia.org/r/327535 (https://phabricator.wikimedia.org/T113860) (owner: 10Hashar) [18:52:33] 10Dumps-Generation: wikidata page dumps very slow this month - https://phabricator.wikimedia.org/T153345#2877715 (10ArielGlenn) I had a few theories to check: 1. Are there more revisions this month all of a sudden? Possible, but a check of revision count in stubs-meta-history-1 for Nov and Dec shows an increase... [18:52:50] 10MediaWiki-extensions-CentralNotice: Make "Hide" Cookies notice independent - https://phabricator.wikimedia.org/T19108#2877716 (10Aklapper) Removing #easy as per last comments - feel free to re-add once the task description has been updated and clarified. [18:54:32] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2877718 (10Catrope) >>! In T153284#2876130, @Pginer-WMF wrote: > Regarding the icon, I think the centra... [18:55:15] (03CR) 10DCausse: [C: 031] "only one nitpick that I'm not sure is worth fixing in this patch." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [18:56:24] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2877725 (10kaldari) [18:58:06] 10MediaWiki-Maintenance-scripts, 07Easy: Allow specifying what namespaces to generate sitemaps for, from the php command line - https://phabricator.wikimedia.org/T19748#2877730 (10Aklapper) p:05Low>03Lowest >>! In T19748#220041, @Jidanni wrote: > I have to put the specifications for in in LocalSettings.php... [18:58:32] 10MediaWiki-Maintenance-scripts, 07Easy: Allow specifying what namespaces to generate sitemaps for, from the php command line - https://phabricator.wikimedia.org/T19748#2877734 (10Aklapper) [18:59:38] (03PS1) 10BearND: Update mobileapps to ad0eda5 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327563 [18:59:58] (03CR) 10BearND: [V: 032 C: 032] Update mobileapps to ad0eda5 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327563 (owner: 10BearND) [19:00:46] (03CR) 10Jdlrobson: [C: 04-1] "Some minor feedback" (0311 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [19:01:28] 10MediaWiki-User-blocking, 06Community-Tech: CookieSetOnAutoblock for an infinite block would block the computer forever, this seems excessive - https://phabricator.wikimedia.org/T152952#2864511 (10kaldari) p:05Triage>03Normal [19:02:12] (03CR) 10Smalyshev: [] Report all syntax in stats, also add syntax to the log (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [19:02:22] (03Merged) 10jenkins-bot: Update mobileapps to ad0eda5 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327563 (owner: 10BearND) [19:04:49] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Implement Undeleting a newsletter from the Logs - https://phabricator.wikimedia.org/T150125#2774747 (10FilipGCI) I'll finish it [19:05:01] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy: Some buttons in mobile interface don't indicate clickable target with pointer - https://phabricator.wikimedia.org/T145493#2632026 (10Jdlrobson) @McIntireEvan any updates on this task? [19:05:27] (03CR) 10jenkins-bot: [V: 04-1] Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [19:05:37] (03Merged) 10jenkins-bot: Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [19:05:42] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#2877747 (10Jdlrobson) [19:05:52] (03CR) 10jenkins-bot: [V: 04-1] Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [19:06:42] 07Design, 10MediaWiki-Recent-changes, 10MobileFrontend, 06Reading-Web-Backlog, and 2 others: mw-changeslist-legend should not be present on RecentChanges in Minerva skin - https://phabricator.wikimedia.org/T112693#1642839 (10Jdlrobson) [19:07:08] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 07Technical-Debt (RW-Tech-Debt): [EPIC] Statically analyse codebase with Etsy's Phan - https://phabricator.wikimedia.org/T133664#2877755 (10Jdlrobson) [19:07:52] 07Design, 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2877757 (10JGirault) [19:08:25] (03CR) 10DCausse: [C: 031] Report all syntax in stats, also add syntax to the log (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [19:09:10] 10MediaWiki-Internationalization, 15User-Nikerabbit: mw.language unittest cleanup failing - https://phabricator.wikimedia.org/T152476#2877759 (10Jdlrobson) [19:09:14] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07Accessibility, 07Easy, and 2 others: Close and zoom buttons have no tooltips or speakable title (title attribute) - https://phabricator.wikimedia.org/T58471#2877758 (10Jdlrobson) [19:10:13] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment create database downtime - https://phabricator.wikimedia.org/T153348#2877761 (10jcrespo) [19:10:24] (03PS27) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) [19:10:27] (03PS23) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) [19:10:44] (03PS1) 10Mobrovac: Scap: Add BetaCluster deployment configuration [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327566 (https://phabricator.wikimedia.org/T149671) [19:11:03] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877778 (10jcrespo) [19:11:18] (03CR) 10Mobrovac: [V: 032 C: 032] Scap: Add BetaCluster deployment configuration [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327566 (https://phabricator.wikimedia.org/T149671) (owner: 10Mobrovac) [19:12:46] (03CR) 10EBernhardson: [C: 032] Enable supplying inline interwiki results [core] - 10https://gerrit.wikimedia.org/r/324652 (https://phabricator.wikimedia.org/T142795) (owner: 10Smalyshev) [19:13:14] (03PS1) 10Niedzielski: Hygiene: don't constrain article header title height [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327567 (https://phabricator.wikimedia.org/T152213) [19:13:41] (03Abandoned) 10EBernhardson: Do not output interwiki search results box when there's no result [core] - 10https://gerrit.wikimedia.org/r/239037 (https://phabricator.wikimedia.org/T96881) (owner: 10Nemo bis) [19:13:44] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877813 (10jcrespo) https://grafana-admin.wikimedia.org/dashboard/db/api-summary?panelId=2&fullscreen&from=1481825577820&to=1481826285856&var-percentile=p95&var-dc=eqiad [19:17:09] (03CR) 10BearND: "Would you add a comment about why this revert was necessary?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327552 (owner: 10Dbrant) [19:18:33] 10Mail, 05MW-1.29-release-notes, 13Patch-For-Review, 05Security, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Fifth argument to php mail() function should be better escaped. - https://phabricator.wikimedia.org/T152717#2877825 (10Bawolff) Yeah, we probably should. I can do the backports [19:22:17] (03CR) 10Dbrant: [C: 04-1] "There is actually a non-obvious use case for caching pages on their non-canonical title: offline forward navigation." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326033 (https://phabricator.wikimedia.org/T152720) (owner: 10Mholloway) [19:22:34] 10MediaWiki-Interface, 07Easy: Add id attribute to error messages - https://phabricator.wikimedia.org/T20819#2877853 (10Aklapper) So this task is basically about wrapping an error message into a class, similar to `$outputPage->wrapWikiMsg( "
    \n$1\n
    "` in [[ https:... [19:22:42] (03Merged) 10jenkins-bot: Enable supplying inline interwiki results [core] - 10https://gerrit.wikimedia.org/r/324652 (https://phabricator.wikimedia.org/T142795) (owner: 10Smalyshev) [19:22:53] (03PS1) 10EBernhardson: Correct DatabaseSqlite::unionQueries annotation [core] - 10https://gerrit.wikimedia.org/r/327569 [19:26:04] (03CR) 10Dbrant: "Sorry, I left comments on the original patch instead. The original patch was causing a crash in EditSectionActivity, and was causing some" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327552 (owner: 10Dbrant) [19:27:59] (03CR) 10Jdlrobson: [C: 032] "Fixes issues for me. No longer see warnings in my error log" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327420 (https://phabricator.wikimedia.org/T153250) (owner: 10Rudloff) [19:28:29] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877870 (10cscott) OCG fetches contributors, but if it were OCG, then (1) why would it be correlated with Parsoid restart, and (2) those requests should have been coming direct... [19:31:02] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2877526 (10Anomie) Looking at the code, it looks like the real deal here is whether the Language object's `->getConverter()` returns a `Langua... [19:32:37] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877897 (10cscott) PageID 9228 is https://en.wikipedia.org/w/index.php?curid=9228 (Earth) fwiw. Were image pages affected, too? If it was OCG, I'd expect to see requests for... [19:33:13] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877761 (10Arlolra) See T75412 as possibly related. [19:34:01] (03CR) 10Jdlrobson: [C: 031] Hygiene: Make mw.popups#isEnabled return boolean [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327196 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [19:35:20] (03Merged) 10jenkins-bot: Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327420 (https://phabricator.wikimedia.org/T153250) (owner: 10Rudloff) [19:35:28] (03PS1) 10EBernhardson: Fix two instances of calling function with too few args [core] - 10https://gerrit.wikimedia.org/r/327571 [19:37:08] (03CR) 10MaxSem: [C: 032] Correct DatabaseSqlite::unionQueries annotation [core] - 10https://gerrit.wikimedia.org/r/327569 (owner: 10EBernhardson) [19:37:18] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2877914 (10cscott) @Anomie My inclination right now is to (1) fix `->getConverter()` to return a FakeConverter if all the variants for a given... [19:37:22] (03CR) 10Jdlrobson: [] Introduce Opt-In option on user preferences page (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [19:39:23] (03CR) 10Jhobs: [] "Would be +1 if using MediaWikiTestCase in the tests." (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [19:40:01] (03CR) 10MarkAHershberger: "See https://www.mediawiki.org/w/index.php?diff=2314098 -- please remember to document changes to hooks properly." [core] - 10https://gerrit.wikimedia.org/r/64620 (owner: 10Matthias Mullie) [19:41:17] 07Design, 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2877918 (10JGirault) [19:41:24] (03CR) 10MaxSem: [C: 032] Fix two instances of calling function with too few args [core] - 10https://gerrit.wikimedia.org/r/327571 (owner: 10EBernhardson) [19:42:21] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Request OIT/admin to include more details in gcal room descriptions - https://phabricator.wikimedia.org/T150979#2877919 (10ksmith) @Awjrichards : This doesn't appear to have been done yet. Is it worth re-opening this ticket to reflect that? [19:43:58] (03CR) 10Jhobs: [C: 04-1] Update the settings enabled radio with the enabled state (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [19:44:07] (03CR) 10Jhobs: [C: 031] Update the settings enabled radio with the enabled state [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [19:44:46] (03CR) 10Dbrant: [C: 032] Hygiene: add AppTextViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327427 (https://phabricator.wikimedia.org/T152213) (owner: 10Niedzielski) [19:44:57] (03CR) 10Jhobs: [C: 032] "Actually, +2." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [19:45:11] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877922 (10cscott) @Arlolra Not sure it's actually related. {T75412} causes the Parser/Parsoid to work hard expanding a large template, but (1) it doesn't involve any database... [19:46:36] (03Merged) 10jenkins-bot: Correct DatabaseSqlite::unionQueries annotation [core] - 10https://gerrit.wikimedia.org/r/327569 (owner: 10EBernhardson) [19:46:41] (03CR) 10jenkins-bot: [V: 04-1] Fix two instances of calling function with too few args [core] - 10https://gerrit.wikimedia.org/r/327571 (owner: 10EBernhardson) [19:47:47] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877761 (10Anomie) At first glance at the data in logstash, I think the ApiQueryContributors hits are background noise here. The peak at 18:19:00 reports 132 hits in the 30-sec... [19:48:22] (03CR) 10Jhobs: [C: 031] "Not quite a +2 because I think Phuedx's comment about moving the `get` function to the outer scope is valid, but I'm also ok if the code g" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 (owner: 10Jhernandez) [19:48:49] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877761 (10ssastry) So far, it seems like this is coincidence and unrelated to the Parsoid deploy, since Parsoid doesn't trigger that contributors query. [19:48:54] (03PS1) 10Fomafix: mediawiki.special.watchlist: Optimize JavaScript code [core] - 10https://gerrit.wikimedia.org/r/327574 [19:49:04] (03Merged) 10jenkins-bot: Hygiene: add AppTextViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327427 (https://phabricator.wikimedia.org/T152213) (owner: 10Niedzielski) [19:50:54] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877962 (10Arlolra) > Not sure it's actually related. Yeah, doesn't seem to be, sorry. From OCG's contributorsQuery, ``` var request = { action: 'query', prop: 'contri... [19:50:56] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Implement Undeleting a newsletter from the Logs - https://phabricator.wikimedia.org/T150125#2877963 (10FilipGCI) Newsletter log messages are not showing as Deletion Logs. I cant just change type from "newsletter" "newsletter-removed" to "delete" "delete".... [19:52:06] (03CR) 10Jdlrobson: [] Hygiene: breakup mega-function in MobileView API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327129 (owner: 10Jdlrobson) [19:52:21] (03CR) 10Jhobs: [C: 032] "Joaquin's right, my suggested changes can just happen in a future patch." (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [19:55:36] (03Merged) 10jenkins-bot: Wire up saving enabled/disabled in settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [19:59:09] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2877987 (10cscott) The SQL query seems to match https://github.com/wikimedia/mediawiki/blob/master/includes/api/ApiQueryContributors.php#L108 . OCG uses this at https://github... [19:59:27] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2877989 (10BurritoBazooka) Thanks for interpreting that, @Anomie. I tried reproducing the problem using scripts like [[http://browsercookielimi... [19:59:59] (03CR) 10Jhobs: [] "Gonna hold off on review until the next PS since the scope of the patch has changed." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [20:01:25] (03PS2) 10Mooeypoo: [wip] Create active/inactive behavior for complementary filters [core] - 10https://gerrit.wikimedia.org/r/327419 (https://phabricator.wikimedia.org/T149452) [20:01:52] 10MediaWiki-extensions-Gadgets, 06Community-Tech, 07Epic: Implement global gadgets (WMF-wide) - https://phabricator.wikimedia.org/T22153#2877995 (10DannyH) [20:02:22] 10MediaWiki-Database, 06Community-Tech, 13Patch-For-Review, 07Performance, and 2 others: Allow comments longer than 255 bytes - https://phabricator.wikimedia.org/T6715#2877996 (10DannyH) [20:02:37] 10MediaWiki-extension-requests, 10ArchCom-RfC, 06Community-Tech, 10GlobalPreferences, and 2 others: Support global preferences - https://phabricator.wikimedia.org/T16950#2877998 (10DannyH) [20:03:05] 10MediaWiki-Special-pages, 10MediaWiki-extension-requests, 06Community-Tech, 06Stewards-and-global-tools: Setting a temporary usergroup (allow expiry of user rights via Special:UserRights form) - https://phabricator.wikimedia.org/T12493#2878001 (10DannyH) [20:04:01] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2878003 (10cscott) It looks like @Anomie is saying that the contributors requests weren't actually anomalous, and we should be looking at the other 91 requests in that 30-secon... [20:05:01] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Implement Undeleting a newsletter from the Logs - https://phabricator.wikimedia.org/T150125#2878005 (10MtDu) @FilipGCI I haven't finished it. I've had exams, so I haven't had time to. I have a working patch, just haven't pushed it. Please let me finish. :... [20:06:28] Hey folks. Anyone know if there are graphite metrics for api.php and if I could find out how often someone queries using a specific parameter -- e.g. "rvprop=oresscores"? [20:06:43] maybe anomie would know ^ [20:06:44] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Implement Undeleting a newsletter from the Logs - https://phabricator.wikimedia.org/T150125#2878006 (10MtDu) Note: [WIP] tag means the code is not finished. @FilipGCI [20:06:50] Maybe qgil ^ [20:07:05] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Implement Undeleting a newsletter from the Logs - https://phabricator.wikimedia.org/T150125#2878022 (10MtDu) Thanks for reminding me that it needs to be done though! :) @FilipGCI [20:07:08] legoktm: I wonder why TMH is failing all 1.27 backports [20:07:19] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 06Community-Tech, 07User-notice: Send notification to account owner on multiple unsuccessful login attempts - https://phabricator.wikimedia.org/T11838#2878023 (10DannyH) [20:07:49] halfak: There's data in kafka (etc), bd808 or tgr|away can probably tell you more about it. [20:08:00] Cool. Thanks anomie [20:08:29] If kafka, that means it's in the request logs then, right? [20:08:42] That would mean I can get at it with a hive query on stat1002 [20:08:49] I suppose that makes sense. [20:09:59] halfak: Example query: https://phabricator.wikimedia.org/P4581 [20:10:26] anomie, cool. That is really helpful [20:11:09] halfak: https://wikitech.wikimedia.org/wiki/Analytics/Data/ApiAction [20:11:32] tonythomas: sorry. Been quite busy. I'll work on some newsletter stuff soon. :) [20:11:41] Done with exams, finally. :) [20:13:51] thanks tgr [20:14:03] (03PS1) 10Aaron Schulz: Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 [20:19:15] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Implement Undeleting a newsletter from the Logs - https://phabricator.wikimedia.org/T150125#2878052 (10FilipGCI) @MtDu - Its GCI task, but i can abandon it for you, contact with me on IRC [20:22:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 13Patch-For-Review: [Task] Make Wikibase Repo work with a custom File collection, not only Wikimedia Commons - https://phabricator.wikimedia.org/T90492#2878054 (10Reedy) I note https://github.com/wikimedia/data-values-value-view/pull/159 was not merged e... [20:22:54] 10MediaWiki-Internationalization: Norwegian messages inContentLanguage look for on-wiki overrides at the /nb subpage, not the root page - https://phabricator.wikimedia.org/T126146#2878055 (10jhsoby) I can confirm that this is also a bug for [[ https://no.wikimedia.org/ | Wikimedia Norge's wiki ]]. For example, t... [20:24:24] (03CR) 10jenkins-bot: [V: 04-1] Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [20:29:54] 10MediaWiki-ResourceLoader, 10MobileFrontend, 06Performance-Team, 06Reading-Web-Backlog, 07Performance: ResourceLoaderImage: Add option to generate only certain variants (not all) - https://phabricator.wikimedia.org/T149406#2878061 (10Krinkle) [20:30:33] (03PS2) 10Aaron Schulz: Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 [20:31:04] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2878064 (10cscott) [20:31:14] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878065 (10AndyRussG) Hmmm, the numbers are down substantially (abou... [20:32:32] (03PS16) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [20:35:40] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2878080 (10Legoktm) @BurritoBazooka and @YMS , do you have any Firefox add-ons installed? I'm wondering if there's some kind of privacy add-on... [20:37:55] (03CR) 10jenkins-bot: [V: 04-1] Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [20:38:34] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 06Performance-Team: Display a password strength bar - https://phabricator.wikimedia.org/T32574#356180 (10Krinkle) >>! In T32574#2836570, @Anomie wrote: > Would it blow up ResourceLoader somehow (e.g. cache in LocalStorage) to be pulling down 77... [20:40:37] 10Mobile-Content-Service, 13Patch-For-Review: IPA content should not be hidden in response - https://phabricator.wikimedia.org/T141835#2878088 (10bearND) 05Open>03Resolved a:03bearND deploy/2016-12-15/c9b7386 [20:41:12] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2878092 (10YMS) Indeed I use Ghostery, as well as HTTPS Everywhere. No other major add-ons. Sadly I cannot try deactivating them now, as I won'... [20:41:16] 10MediaWiki-API, 10Monitoring, 06Operations, 10Parsoid, and 3 others: API action=parsoid-batch not available on Graphite - https://phabricator.wikimedia.org/T152776#2878093 (10Krinkle) [20:52:59] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2828393 (10Pcoombe) I guess it needs similar styles to T149249. Screenshots for reference. Adyen: {F5062850} Ingenico: {F5062852} [20:54:01] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2878146 (10Quiddity) I strongly urge 1. Everything on one page (instead of split into 3) ** This enables (A) easier wat... [20:54:18] (03PS3) 10Aaron Schulz: Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 [20:55:29] (03CR) 10Cenarium: [] "This was for showing references defined elsewhere in section preview and for MobileFrontend's lazy loading of references. But it seems the" [core] - 10https://gerrit.wikimedia.org/r/279893 (owner: 10Cenarium) [20:59:01] (03PS17) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [21:00:12] 06Discovery, 06Discovery-Analysis (Current work), 13Patch-For-Review: [Dashboard] Migrate golden to Reportupdater infrastructure - https://phabricator.wikimedia.org/T150915#2801092 (10mpopov) Running the test utility right now to check that everything is working OK before I officially ask Chelsy for CR. [21:03:05] (03PS1) 10Filip: Replaced deprecated hook "$wgHooks['ArticleInsertComplete'][]" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) [21:05:04] (03CR) 1020after4: [C: 031] "This looks good to me but I don't have time to test it right now." [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/324722 (https://phabricator.wikimedia.org/T106075) (owner: 10FreedomFighterSparrow) [21:05:55] 10MediaWiki-API, 06Parsing-Team, 10Parsoid: Parsoid deployment creates database downtime - https://phabricator.wikimedia.org/T153348#2878159 (10Anomie) While there was an uptick in queries to `prop=contributors` at 18:19 (363/minute) and 18:20 (322/minute) compared to the minutes just before and after (each... [21:06:03] (03PS1) 1020after4: Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) [21:06:23] (03CR) 10jenkins-bot: [V: 04-1] Add a page prop and a tracking category for errors [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/324722 (https://phabricator.wikimedia.org/T106075) (owner: 10FreedomFighterSparrow) [21:06:33] (03CR) 1020after4: [C: 032] Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:10:36] (03CR) 10Legoktm: [C: 032] Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [21:11:03] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878164 (10AndyRussG) BTW, I'm not seeing any banners on pages I vis... [21:13:35] (03CR) 1020after4: [C: 031] "errors from jenkins:" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/324722 (https://phabricator.wikimedia.org/T106075) (owner: 10FreedomFighterSparrow) [21:14:06] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878166 (10jmatazzoni) [21:14:09] (03CR) 10Paladox: [C: 032] Adding ##zppix-wikipedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327121 (owner: 10Zppix) [21:15:13] (03PS2) 10Filip: Replaced deprecated hook "$wgHooks['ArticleInsertComplete'][]" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) [21:15:18] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875305 (10jmatazzoni) [21:15:20] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2878173 (10debt) Hey @TJones, @mpopov and @dcausse - would you have time to take a quick run though of this new report? Thanks! [21:16:17] (03CR) 10jenkins-bot: [V: 04-1] Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:16:41] 06Discovery, 06Discovery-Analysis (Current work): [Dashboard][Search] Sparklines for KPIs - https://phabricator.wikimedia.org/T150215#2878176 (10mpopov) Notes from meeting: * When "KPI data range" == "All available data", the value boxes are currently "N/A" (by design) but would be better if it showed the spa... [21:17:40] (03PS1) 10Filip: Replaced deprecated hook "$wgHooks['ArticleInsertComplete'][]" [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) [21:18:30] (03CR) 10jenkins-bot: [V: 04-1] Allow parser tests to be run in any order [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [21:18:42] 06Discovery, 06Discovery-Analysis (Current work): Wikipedia portal: update eventlogging for sister project clickthroughs - https://phabricator.wikimedia.org/T152617#2878179 (10debt) a:03chelsyx [21:18:55] (03Merged) 10jenkins-bot: Adding ##zppix-wikipedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327121 (owner: 10Zppix) [21:19:09] (03CR) 10jenkins-bot: [V: 04-1] Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:19:18] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Unplanned-Sprint-Work: Update Adyen iframe css to match ingenico - https://phabricator.wikimedia.org/T151795#2878180 (10DStrine) a:03cwdent [21:19:47] (03PS2) 10Filip: Replaced deprecated hook "$wgHooks['ArticleInsertComplete'][]" [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) [21:21:45] (03PS1) 10Jdrewniak: Downgrading uglifyJS version which broke IE8 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/327584 [21:21:53] (03PS12) 10Cdentinger: add dash to crm role [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) [21:22:26] (03CR) 1020after4: [C: 032] "recheck" [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:22:59] (03CR) 1020after4: [C: 032] "wtf those failures are b.s." [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:23:10] 06Discovery, 06Discovery-Analysis (Current work): Wikipedia portal: update eventlogging for sister project clickthroughs - https://phabricator.wikimedia.org/T152617#2878184 (10mpopov) This will be a good one for Chelsy to do because adding a new metric module ('report") will give her a chance to get better acq... [21:23:13] (03PS1) 10Filip: Replaced deprecated hook "$wgHooks['ArticleSaveComplete'][]" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) [21:23:14] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878185 (10jmatazzoni) [21:24:57] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hook "$wgHooks['ArticleInsertComplete'][]" (031 comment) [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:25:01] (03CR) 10jenkins-bot: [V: 04-1] Replaced deprecated hook "$wgHooks['ArticleSaveComplete'][]" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:25:05] (03PS2) 10Smalyshev: Fix two instances of calling function with too few args [core] - 10https://gerrit.wikimedia.org/r/327571 (owner: 10EBernhardson) [21:25:12] grrrit-wm: restart [21:25:13] Ended SSH connection to Gerrit. [21:25:15] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878187 (10jmatazzoni) [21:25:28] 06Discovery, 06Discovery-Analysis (Current work): [Dashboard][Search] Sparklines for KPIs - https://phabricator.wikimedia.org/T150215#2878188 (10chelsyx) [21:25:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Replace use of deprecated methods (mainly in ApiErrorReporter) - https://phabricator.wikimedia.org/T153359#2878189 (10Anomie) [21:25:47] Great... [21:25:51] (03PS4) 10Bmansurov: Feature flag FontChanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) [21:25:53] (03Draft1) 10Paladox: Fix a missing : in zppix code [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327586 [21:26:15] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2875305 (10jmatazzoni) [21:26:23] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hook "$wgHooks['ArticleInsertComplete'][]" (031 comment) [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:26:41] (03CR) 10Zppix: [V: 032 C: 032] Fix a missing : in zppix code [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327586 (owner: 10Paladox) [21:26:57] (03CR) 10MaxSem: [C: 032] Fix two instances of calling function with too few args [core] - 10https://gerrit.wikimedia.org/r/327571 (owner: 10EBernhardson) [21:27:09] (03PS1) 10Paladox: Revert "Fix a missing : in zppix code" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327587 [21:27:29] (03CR) 10Reedy: [] "Test failure is related :)" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:28:43] MtDu_: hey. sorry for the late reply. I'm online, but into one of my assignments. will be back in 15 [21:28:54] (03PS2) 10Paladox: Fix a missing : in zppix code [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327587 [21:29:46] (03CR) 10Jdrewniak: [C: 032] Downgrading uglifyJS version which broke IE8 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/327584 (owner: 10Jdrewniak) [21:30:02] (03PS9) 10Anomie: API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 [21:30:23] tonythomas: no problem. Good luck! :( [21:30:27] :)* [21:30:38] (03CR) 10Zppix: [V: 032 C: 032] Fix a missing : in zppix code [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327587 (owner: 10Paladox) [21:30:43] (03CR) 10Pmiazga: [] Introduce Opt-In option on user preferences page (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [21:30:54] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878224 (10Ejegg) The JS blacklist is working! Till this morning, r... [21:31:02] Reedy: Are you there? [21:31:03] (03CR) 10jenkins-bot: [V: 04-1] Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:31:12] Yes [21:32:32] Reedy: So i need to change commit message? [21:32:37] Yup [21:32:51] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2878225 (10bmansurov) The schema has been updated: https://meta.wikimedia.org/w/index.ph... [21:33:35] (03CR) 10Anomie: [C: 031] "Yes, this needs doing." [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327300 (https://phabricator.wikimedia.org/T153164) (owner: 10Kaldari) [21:33:42] (03PS2) 10FreedomFighterSparrow: Add a page prop and a tracking category for errors [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/324722 (https://phabricator.wikimedia.org/T106075) [21:34:19] (03CR) 10jenkins-bot: [V: 04-1] Use getimagesizefromstring() instead of getimagesize() [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:35:04] (03CR) 10Aaron Schulz: [] "recheck" [extensions/TimedMediaHandler] (REL1_27) - 10https://gerrit.wikimedia.org/r/327577 (owner: 10Aaron Schulz) [21:37:13] (03PS1) 10Paladox: Fix linting issues due to upgrade on eslint-config-wikimedia [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327588 [21:37:59] Reedy: So "Replaced deprecated hook usage" should be fine? [21:38:15] rlot_: Include the name of the hook [21:38:26] Replace deprecated usage of hook XYZ [21:38:36] Thanks, i'll commit in minuted [21:39:31] (03PS2) 10Filip: Replaced deprecated usage of hook "$wgHooks['ArticleSaveComplete']" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) [21:40:04] (03CR) 10Subramanya Sastry: [C: 031] "It is odd that gallery and langconverter have this relation .. but that is not related to this patch. LGTM as far as I can tell." [core] - 10https://gerrit.wikimedia.org/r/76341 (https://phabricator.wikimedia.org/T54190) (owner: 10Liangent) [21:40:26] 10MediaWiki-ResourceLoader, 06Performance-Team: Grafana alerts for ResourceLoader - https://phabricator.wikimedia.org/T153171#2878249 (10Krinkle) p:05Triage>03Normal a:03Krinkle [21:40:38] (03Merged) 10jenkins-bot: Fix two instances of calling function with too few args [core] - 10https://gerrit.wikimedia.org/r/327571 (owner: 10EBernhardson) [21:40:48] (03CR) 1020after4: [C: 032] Fix linting issues due to upgrade on eslint-config-wikimedia [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327588 (owner: 10Paladox) [21:41:14] (03CR) 10jenkins-bot: [V: 04-1] API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 (owner: 10Anomie) [21:41:31] (03Merged) 10jenkins-bot: Downgrading uglifyJS version which broke IE8 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/327584 (owner: 10Jdrewniak) [21:41:46] 07Design, 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2865912 (10Yurik) Something else to consider: There may be a number of unusual usage cases that we should also consider for the design. For example, the table may be... [21:41:51] (03PS3) 10Filip: Replaced deprecated usage of hook "$wgHooks['ArticleInsertComplete']" [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) [21:42:43] 06Discovery, 06Discovery-Analysis (Current work): Wikipedia portal: update eventlogging for sister project clickthroughs - https://phabricator.wikimedia.org/T152617#2878274 (10mpopov) a:05chelsyx>03mpopov Whoops :/ I had a brain toot and FORGOT THE THING I LITERALLY JUST WROTE and added this to the big mig... [21:43:27] MtDu_: yeah! go on [21:43:51] (03PS4) 10Filip: Replaced deprecated usage of hook "$wgHooks['ArticleInsertComplete']" [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) [21:44:03] (03CR) 10Kaldari: [C: 032] Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [21:44:32] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878281 (10Cenarium) >>! In T153284#2876964, @jmatazzoni wrote: > - Secondly, while a notification is... [21:45:08] (03PS3) 10Filip: Replaced deprecated usage of hook "$wgHooks['ArticleInsertComplete'][]" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) [21:45:17] Reedy: Fixed it [21:45:55] (03CR) 10Paladox: [] "Thanks." [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327588 (owner: 10Paladox) [21:46:26] (03CR) 10Dbrant: [C: 032] Hygiene: add ArticleHeaderViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327558 (https://phabricator.wikimedia.org/T152213) (owner: 10Niedzielski) [21:47:10] tonythomas: so the hook were using ArticleUndelete doesn't have a status object. But if we need to throw an error like on ArticleDelete, then how do we do that? [21:47:27] (03PS18) 10Bearloga: Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [21:48:47] MtDu_: maybe return Status::newFatal( 'the-message-here' ); ? [21:49:09] 10CirrusSearch, 06Discovery-Search: Activate BM25 on all but wikis with spaceless languages - https://phabricator.wikimedia.org/T152092#2838009 (10Deskana) \o/ [21:49:18] 10MediaWiki-API: drvstartid/drvendid missing from prop=deletedrevisions - https://phabricator.wikimedia.org/T153236#2873669 (10Anomie) The difficulty here is that there's no appropriate index. You'd need to add an index on `(ar_namespace, ar_title, ar_timestamp, ar_rev_id)` to make it workable, or `(ar_namespace... [21:50:53] (03Merged) 10jenkins-bot: Fix linting issues due to upgrade on eslint-config-wikimedia [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327588 (owner: 10Paladox) [21:50:57] (03Merged) 10jenkins-bot: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [21:50:59] (03Merged) 10jenkins-bot: Hygiene: add ArticleHeaderViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327558 (https://phabricator.wikimedia.org/T152213) (owner: 10Niedzielski) [21:51:17] (03CR) 10Paladox: [] "recheck" [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:51:40] tonythomas: alright. I'm not home right now. I don't want to rush and push a patch. I will take a deep look when I get home, but you will probably be asleep. There should be a patch waiting for you in the morning. :( [21:51:43] :)* [21:51:55] MtDu_: alright :) Thank you! [21:51:58] Keep sending sad faces inadvertently... :( [21:52:11] (: [21:53:07] "Are you sure you want to reset unseen watchlist changes by marking all pages as visited?" is getting really annoying. And I've only seen it twice. [21:53:50] guillom: There's a script to disable that somewhere... [21:53:54] (03PS3) 10Reedy: Replaced deprecated usage of hook "ArticleSaveComplete" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:53:57] (03CR) 10Reedy: [C: 032] Replaced deprecated usage of hook "ArticleSaveComplete" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:54:04] * Deskana tries to find it [21:54:13] (03PS10) 10Pmiazga: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) [21:54:14] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Improve remote participation at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T146613#2878350 (10srishakatux) From the metrics meeting today I learned that there is a live chat feature for Youtube Live https://www.you... [21:54:21] guillom: https://phabricator.wikimedia.org/T150045#2876153 [21:54:34] (03CR) 1020after4: [C: 032] "recheck" [extensions/MobileFrontend] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327582 (https://phabricator.wikimedia.org/T153250) (owner: 1020after4) [21:55:22] (03Merged) 10jenkins-bot: Replaced deprecated usage of hook "ArticleSaveComplete" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327585 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:56:08] Deskana: My question is… whyyyyy. [21:56:13] * guillom eyes legoktm. [21:58:24] (03PS5) 10Reedy: Replaced usage of deprecated hooks [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:58:29] (03CR) 10Reedy: [C: 032] Replaced usage of deprecated hooks [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:59:20] guillom: Conventional logic would suggest it's an action that can't be undone, so a confirmation is required. [21:59:28] guillom: But... meh. Does seem a bit like overkill. [21:59:30] * Deskana shrugs [21:59:30] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878366 (10Cenarium) [21:59:41] (03PS1) 10MaxSem: Fix type annotations [core] - 10https://gerrit.wikimedia.org/r/327593 [22:00:35] I'm probably just having a Type xkcd-1172 reaction. [22:00:44] (03PS4) 10Reedy: Replaced usage of deprecated hook "ArticleInsertComplete" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:01:12] guillom: Did anyone ask Pine? [22:01:26] Reedy: Did anyone ask me???!!!111 [22:01:33] 06Research-and-Data, 10Research-management: Research Offsite Dec 2016: expense reports - https://phabricator.wikimedia.org/T153111#2878371 (10DarTar) [22:01:36] guillom: TO THE MAILING LISTS [22:02:03] * guillom jumps onto the pole straight to the listcave. [22:02:09] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878375 (10Cenarium) >>! In T153284#2877718, @Catrope wrote: >>>! In T153284#2876130, @Pginer-WMF wrote... [22:02:18] (03CR) 10Reedy: [C: 032] Replaced usage of deprecated hook "ArticleInsertComplete" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:02:26] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader, 06Performance-Team: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2878391 (10Krinkle) [22:04:15] (03CR) 10Dbrant: [C: 032] Hygiene: don't constrain article header title height [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327567 (https://phabricator.wikimedia.org/T152213) (owner: 10Niedzielski) [22:06:27] 10MediaWiki-extensions-TemplateSandbox, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support "Preview page with this template" in the new wikitext editor - https://phabricator.wikimedia.org/T153367#2878418 (10Amire80) [22:07:23] (03Merged) 10jenkins-bot: Replaced usage of deprecated hooks [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/327583 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:07:26] (03Merged) 10jenkins-bot: Replaced usage of deprecated hook "ArticleInsertComplete" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/327581 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:07:28] (03PS6) 10Ladsgroup: Minor adjustments to align with WikimediaUI color palette [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) [22:07:51] (03CR) 10Krinkle: [C: 032] MessageCache invalidation improvements [core] - 10https://gerrit.wikimedia.org/r/324023 (owner: 10Aaron Schulz) [22:08:12] (03CR) 10Ladsgroup: [] "First line of gerrit commit message should be less than 70 characters then a blank line and than more description which should stay less t" [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [22:08:34] (03CR) 10BearND: [C: 032] Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [22:10:01] (03Merged) 10jenkins-bot: Hygiene: don't constrain article header title height [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327567 (https://phabricator.wikimedia.org/T152213) (owner: 10Niedzielski) [22:12:05] (03CR) 10Cenarium: [] Don't always display review notice if autoreviewed, specify if autoreviewed (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255811 (https://phabricator.wikimedia.org/T60057) (owner: 10Cenarium) [22:12:17] guillom: They forgot to notify you in triplicate. Whoops. [22:13:03] MY OPINION WAS IGNORED. I WAS NOT CONSULTED. THIS WILL NOT STAND. [22:14:31] 10MediaWiki-extensions-FlaggedRevs, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notify users when their edit is actively deferred - https://phabricator.wikimedia.org/T153284#2878452 (10jmatazzoni) Thanks for filling in the form @Cenarium! Very helpful. @Catrope, do you need mo... [22:18:33] (03Merged) 10jenkins-bot: MessageCache invalidation improvements [core] - 10https://gerrit.wikimedia.org/r/324023 (owner: 10Aaron Schulz) [22:18:36] (03CR) 10jenkins-bot: [V: 04-1] Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [22:18:50] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 05MW-1.28-release-notes, 05MW-1.29-release-notes, and 2 others: uca-fa collation shows pages starting with ا incorrectly under ء - https://phabricator.wikimedia.org/T139110#2878494 (10kaldari) 05Open>03Resolved a:03kaldari @matmarex: Looks lik... [22:19:11] 10MediaWiki-Internationalization, 15User-Nikerabbit: mw.language unittest cleanup failing - https://phabricator.wikimedia.org/T152476#2878499 (10Tgr) It does reset them though: the teardown callback resets `mw.language.data.values` to what was saved in the setup. As far as I can see this includes `separatorTra... [22:19:26] (03CR) 10BearND: [C: 032] "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [22:19:50] 10MediaWiki-General-or-Unknown, 06Operations, 06Performance-Team, 10Traffic, and 4 others: Mediawiki thumbnail requests for 0px should result in http 400 not 500 - https://phabricator.wikimedia.org/T147784#2878516 (10Gilles) 05Open>03Resolved [22:20:04] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 05MW-1.28-release-notes, 05MW-1.29-release-notes, and 2 others: uca-fa collation shows pages starting with ا incorrectly under ء - https://phabricator.wikimedia.org/T139110#2878520 (10kaldari) 05Resolved>03Open Nevermind, that was only on Beta C... [22:21:43] (03Merged) 10jenkins-bot: Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [22:24:00] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Add auto-suggest to Special:PageAssessments form fields - https://phabricator.wikimedia.org/T152758#2878552 (10kaldari) 05Open>03Resolved [22:26:27] 10MediaWiki-extensions-PageAssessments, 06Community-Tech, 06Community-Tech-fixes, 13Patch-For-Review, 07Tracking: PageAssessments deployment to WMF wikis - https://phabricator.wikimedia.org/T120219#2878562 (10kaldari) [22:26:31] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7), 07Wikimedia-log-errors: Frequent duplicate key errors by page assessments - https://phabricator.wikimedia.org/T152080#2878561 (10kaldari) 05Open>03Resolved [22:27:32] (03PS11) 10Krinkle: resourceloader: Don't let module exception break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) [22:32:38] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 05MW-1.28-release-notes, 05MW-1.29-release-notes, and 2 others: uca-fa collation shows pages starting with ا incorrectly under ء - https://phabricator.wikimedia.org/T139110#2878583 (10Ladsgroup) I can't confirm that it's fixed in beta [[https://fa.w... [22:33:18] (03CR) 10Chad: [V: 032 C: 032] Fix Metrolook URL in .gitmodules [skins] - 10https://gerrit.wikimedia.org/r/327532 (owner: 10Hashar) [22:33:36] 10Mobile-Content-Service: MCS endpoints should be consistent with other endpoints - https://phabricator.wikimedia.org/T152825#2878598 (10Jdlrobson) Agreed. To make this migration.. how can we make it in a nice backwards compatible way? [22:34:45] (03CR) 10Reedy: "It seems passing the output of Message::listParam() to params() on WMF wikis, causes breakages:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/321404 (owner: 10Anomie) [22:34:54] (03PS1) 10Reedy: Revert "Add Message::listParam()" [core] - 10https://gerrit.wikimedia.org/r/327651 [22:35:01] (03PS1) 10Reedy: Revert "Add Message::listParam()" [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327652 [22:35:08] (03CR) 10Paladox: "Woops didn't notice this patch. Heres my +1." [skins] - 10https://gerrit.wikimedia.org/r/327532 (owner: 10Hashar) [22:35:12] (03CR) 10Paladox: "thanks." [skins] - 10https://gerrit.wikimedia.org/r/327532 (owner: 10Hashar) [22:35:21] (03PS1) 10Paladox: Fix Metrolook URL in .gitmodules [skins] (REL1_28) - 10https://gerrit.wikimedia.org/r/327653 [22:36:23] (03CR) 1020after4: [C: 032] Revert "Add Message::listParam()" [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327652 (owner: 10Reedy) [22:37:01] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 15User-Daniel: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#2878607 (10Halfak) @jcrespo, what would you need to know about a change like this in order to bless it from a DBA perspective? I'm imagining th... [22:38:11] (03PS1) 10Niedzielski: Fix: ArticleHeaderView leading and add LeadingSpanTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327655 (https://phabricator.wikimedia.org/T152213) [22:38:20] (03PS1) 10Reedy: Revert "API: i18n for warnings and errors" [core] - 10https://gerrit.wikimedia.org/r/327656 [22:38:37] (03CR) 10jenkins-bot: [V: 04-1] Revert "API: i18n for warnings and errors" [core] - 10https://gerrit.wikimedia.org/r/327656 (owner: 10Reedy) [22:38:54] 10Android-app-feature-Description-Editing, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Long Wikidata descriptions get clipped - https://phabricator.wikimedia.org/T152213#2878624 (10Niedzielski) This ended up being kind of a crazy bug that would either cause a terrible user experience at 5+... [22:39:11] (03CR) 10Reedy: [C: 04-2] "Hang on.." [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327652 (owner: 10Reedy) [22:39:55] (03CR) 10jenkins-bot: [V: 04-1] Revert "Add Message::listParam()" [core] - 10https://gerrit.wikimedia.org/r/327651 (owner: 10Reedy) [22:40:06] (03Abandoned) 10Reedy: Revert "Add Message::listParam()" [core] - 10https://gerrit.wikimedia.org/r/327651 (owner: 10Reedy) [22:40:13] (03PS1) 10Reedy: Message: Fix buggy parameter handling in Message::params() [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327658 (https://phabricator.wikimedia.org/T152603) [22:40:18] (03CR) 10Reedy: [C: 032] Message: Fix buggy parameter handling in Message::params() [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327658 (https://phabricator.wikimedia.org/T152603) (owner: 10Reedy) [22:41:10] (03CR) 10Reedy: "Looks like https://gerrit.wikimedia.org/r/#/c/325790/ may fix the issue... But $param is still undefined :)" [core] - 10https://gerrit.wikimedia.org/r/321404 (owner: 10Anomie) [22:41:22] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 15User-Daniel: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#2878632 (10Halfak) I forgot that we could also use EventLogging or some other high-capacity endpoint for this. For a good reference (IMO) on do... [22:41:32] (03CR) 10jenkins-bot: [V: 04-1] Revert "Add Message::listParam()" [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327652 (owner: 10Reedy) [22:41:49] (03Abandoned) 10Reedy: Revert "Add Message::listParam()" [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327652 (owner: 10Reedy) [22:41:53] (03Abandoned) 10Reedy: Revert "API: i18n for warnings and errors" [core] - 10https://gerrit.wikimedia.org/r/327656 (owner: 10Reedy) [22:42:20] 10Android-app-feature-Description-Editing, 10Android-app-goals-2016-Oct-Dec-Q2, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Add error handling to description editing interface. - https://phabricator.wikimedia.org/T148203#2878637 (10Niedzielski) o/ @Nicholas.tsg # Go to the Wikipedia:Wiki... [22:42:23] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2878638 (10Qgil) Today I have shared our ideas about the Unconference with Cscott and Greg, and both thought that they made sense. Yay! O... [22:43:20] (03PS1) 10Reedy: Fix undefined $param [core] - 10https://gerrit.wikimedia.org/r/327659 [22:43:51] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 06Reading-Web-Backlog, 07Regression: [Regression] "Log in" button on log in page not in tabindex order - https://phabricator.wikimedia.org/T153374#2878639 (10Krinkle) [22:43:56] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 06Reading-Web-Backlog, 07Regression: [Regression] "Log in" button on log in page not in tabindex order - https://phabricator.wikimedia.org/T153374#2878651 (10Krinkle) p:05Triage>03Unbreak! [22:44:07] (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/327659 fixes undefined $param" [core] - 10https://gerrit.wikimedia.org/r/321404 (owner: 10Anomie) [22:47:17] (03CR) 10Paladox: [C: 031] Fix undefined $param [core] - 10https://gerrit.wikimedia.org/r/327659 (owner: 10Reedy) [22:47:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Browser-Support-Apple-Safari: "TypeError: undefined is not an object (evaluating 'mw.util.addPortletLink')" while opening item in new tab (on background) in Safari - https://phabricator.wikimedia.org/T146069#2878690 (10Sjoerddebruin) Seems like https:/... [22:51:29] 10MediaWiki-ContentHandler, 10MediaWiki-Page-editing, 10Wikidata, 10Wikimedia-Developer-Summit (2017): Why Multi-Content-Revisions? Use cases and requirements. - https://phabricator.wikimedia.org/T149532#2755281 (10srishakatux) @daniel Hey! As developer summit is less than four weeks from now, we are worki... [22:53:36] (03CR) 10BearND: [] "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327396 (owner: 10BearND) [22:55:53] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 10Wikimedia-Developer-Summit (2017): MediaWiki Documentation - https://phabricator.wikimedia.org/T149372#2750298 (10srishakatux) @kaldari Hey! As developer summit is less than four weeks from now, we are working on a plan to incorporate the ‘unconference... [22:56:27] (03PS19) 10Bearloga: Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [22:56:32] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 06Reading-Web-Backlog, 07Regression: [Regression] "Log in" button on log in page not in tabindex order - https://phabricator.wikimedia.org/T153374#2878735 (10Krinkle) [22:57:33] (03Merged) 10jenkins-bot: Message: Fix buggy parameter handling in Message::params() [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327658 (https://phabricator.wikimedia.org/T152603) (owner: 10Reedy) [22:59:22] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2707386 (10srishakatux) @Mglaser @MarkAHershberger Hey! As developer summit is less than four weeks from now, we are working on a pla... [23:00:03] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 06Reading-Web-Backlog, 07Regression: [Regression] "Log in" button on log in page not in tabindex order - https://phabricator.wikimedia.org/T153374#2878639 (10Tgr) The markup seems sane: ``` for (i=0; i<16; i++) console.log($('... [23:00:20] 10Video, 10Wikimedia-Video, 10Wikimedia-Developer-Summit (2017): Cross-functional support for rich media - https://phabricator.wikimedia.org/T147604#2697960 (10srishakatux) @brion Hey! As developer summit is less than four weeks from now, we are working on a plan to incorporate the ‘unconference sessions’ th... [23:00:33] (03CR) 10Niedzielski: [] "(add folks manually to this patch and the following)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327005 (https://phabricator.wikimedia.org/T152980) (owner: 10Mholloway) [23:01:41] (03CR) 10Ejegg: [] "I think I see what's up with the forwarding" (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) (owner: 10Cdentinger) [23:01:54] 06Parsing-Team, 10Wikimedia-Developer-Summit (2017): Improved editability, tooling, reasoning, and performance by adopting DOM-based semantics for wikitext - https://phabricator.wikimedia.org/T149282#2747517 (10srishakatux) @ssastry Hey! As developer summit is less than four weeks from now, we are working on a... [23:02:11] 10MediaWiki-Parser, 06Parsing-Team, 10Wikimedia-Developer-Summit (2017): Grunge, or "zoom" - https://phabricator.wikimedia.org/T149659#2759078 (10srishakatux) @cscott Hey! As developer summit is less than four weeks from now, we are working on a plan to incorporate the ‘unconference sessions’ that have been... [23:03:15] 10MediaWiki-Search: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#2878772 (10Deskana) [23:03:21] (03PS1) 10Ppchelko: Update change-propagation to ca54ef0 [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/327662 [23:03:50] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 5 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2878773 (10Pcoombe) Thanks for all the help everyone! The random con... [23:03:54] (03CR) 10Ppchelko: [V: 032 C: 032] Update change-propagation to ca54ef0 [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/327662 (owner: 10Ppchelko) [23:05:10] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n: Strip combining diacritical marks and convert precomposed characters when searching - https://phabricator.wikimedia.org/T3836#60013 (10Deskana) If it's as simple as setting a flag to turn ICU folding on and doing a reindex, then we can do this soon. [23:05:30] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n: Enable ICU folding on Hebrew wikis - https://phabricator.wikimedia.org/T3836#2878776 (10Deskana) [23:05:53] (03PS20) 10Bearloga: Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [23:07:25] 10Discussion-modeling: Switch from keras to tflearn for deeplearning - https://phabricator.wikimedia.org/T143701#2576293 (10ellery) 05Open>03Invalid [23:07:58] 10Discussion-modeling, 07Epic: Detox Dashboard - https://phabricator.wikimedia.org/T143710#2878796 (10ellery) 05Open>03declined [23:08:07] 10MediaWiki-Search, 06Discovery, 06Discovery-Search: Allow option for omitting results from a repository when searching for files - https://phabricator.wikimedia.org/T67459#2878799 (10Deskana) [23:08:11] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search: A more intuitive option to search for local files only - https://phabricator.wikimedia.org/T153025#2878801 (10Deskana) [23:08:16] 10Discussion-modeling: Put EDP models on Demo - https://phabricator.wikimedia.org/T144065#2878803 (10ellery) 05Open>03declined [23:08:58] 10MediaWiki-Internationalization, 06Discovery, 06Discovery-Search: Wikimedia Interwiki Search Results messages shouldn't link to pages named "Main Page" - https://phabricator.wikimedia.org/T151649#2878806 (10Deskana) p:05Triage>03Normal [23:10:15] 10Discussion-modeling: Newcomer Good Faith Model - https://phabricator.wikimedia.org/T153379#2878814 (10ellery) [23:10:33] 10MediaWiki-Parser, 10CirrusSearch, 06Discovery, 06Discovery-Search: Wikilink can't have special characters used in cirrus search - https://phabricator.wikimedia.org/T150869#2878828 (10Deskana) p:05Triage>03Low [23:10:55] 10MediaWiki-Parser, 10CirrusSearch, 06Discovery, 06Discovery-Search: Wikilink can't have special characters used in cirrus search - https://phabricator.wikimedia.org/T150869#2799616 (10Deskana) Given that this does have a workaround, fixing this more thoroughly is not a high priority. [23:11:45] (03CR) 10Niedzielski: [C: 04-1] Description editing tutorial (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325424 (https://phabricator.wikimedia.org/T148205) (owner: 10Mholloway) [23:12:59] 10MediaWiki-Search, 06Discovery, 06Discovery-Search: Search suggest shouldn't offer unlisted special pages - https://phabricator.wikimedia.org/T27399#2878842 (10Deskana) p:05Normal>03Lowest This seems like a lot of work for not such a large gain, and as mentioned above I'm not even convinced the behaviou... [23:13:06] 10MediaWiki-Search: Search suggest shouldn't offer unlisted special pages - https://phabricator.wikimedia.org/T27399#2878844 (10Deskana) [23:13:45] 10CirrusSearch, 06Discovery, 06Discovery-Search: Add support for interleaved results in 2-way A/B test - https://phabricator.wikimedia.org/T150032#2878845 (10Deskana) p:05Triage>03Normal [23:14:21] (03CR) 10Gergő Tisza: "\x works but is less readable (you'd have to use UTF-8 bytes instead of a Unicode code point). I guess with the comment there it's not muc" [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [23:14:32] 10CirrusSearch, 06Discovery, 06Discovery-Search: Quotation marks do not help to avoid finding similar terms or derived words in ru.wikipedia.org - https://phabricator.wikimedia.org/T149694#2878848 (10Deskana) 05Open>03declined I don't think there's much for us to do here, so closing as declined. [23:16:12] 10MediaWiki-extensions-WikibaseRepository, 06Performance-Team, 10Wikidata: Wikibase repo UI is sometimes not properly starting up (on Firefox) - https://phabricator.wikimedia.org/T147798#2878851 (10Krinkle) >>! At T147798, @hoo wrote: > Once I encountered such a case, I tried to manually run our init code in... [23:18:39] 10MediaWiki-API: drvstartid/drvendid missing from prop=deletedrevisions - https://phabricator.wikimedia.org/T153236#2878854 (10Halfak) Yeah! So I use `prop=revisions` to look for reverted edits. In order to do that, I need to look at the edits before and after a specific rev_id. Edits before: `prop=revision&... [23:18:42] (03PS21) 10C. Scott Ananian: New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [23:19:15] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07I18n: Lack of diacritic folding in e.g. Ancient Greek - https://phabricator.wikimedia.org/T132637#2878855 (10Deskana) @dcausse When do we expect the reindex to be done for these wikis? I thought we'd just reindexed them to launch BM25 everywhere. [23:19:17] (03CR) 10jenkins-bot: [V: 04-1] New language variant 'en-x-piglatin' for easier variant testing [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [23:19:20] (03CR) 10Krinkle: [C: 031] jquery.tipsy: Remove support for 'live' option [core] - 10https://gerrit.wikimedia.org/r/300854 (https://phabricator.wikimedia.org/T85048) (owner: 10Bartosz Dziewoński) [23:19:23] (03PS5) 10Krinkle: jquery.tipsy: Remove support for 'live' option [core] - 10https://gerrit.wikimedia.org/r/300854 (https://phabricator.wikimedia.org/T85048) (owner: 10Bartosz Dziewoński) [23:19:52] (03CR) 10C. Scott Ananian: [] "Updated the way $wgUsePigLatinVariant works -- now prevents LanguageEn from creating a converter instance unless $wgUsePigLatinVariant is " [core] - 10https://gerrit.wikimedia.org/r/72053 (https://phabricator.wikimedia.org/T45547) (owner: 10Liangent) [23:20:11] (03PS2) 10MaxSem: Fix type annotations [core] - 10https://gerrit.wikimedia.org/r/327593 [23:20:14] (03PS1) 10MaxSem: Decrease the number of 'function says it should return something' errors [core] - 10https://gerrit.wikimedia.org/r/327666 [23:20:57] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07Epic: EPIC: Test if a reverse field can help to display more and better suggestions - https://phabricator.wikimedia.org/T107427#2878859 (10Deskana) @dcausse Did we do this? If not, do you think it's still worth doing at some point? I'm not sure how to prio... [23:21:23] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2878861 (10ksmith) @debt : For now, the focus is on the maps feature, thus excluding graphs and tabular data.... [23:21:50] 10CirrusSearch, 06Discovery, 06Discovery-Search: Disable all intermittently failing browser tests - https://phabricator.wikimedia.org/T132470#2878864 (10Deskana) 05Open>03Resolved a:03EBernhardson We made the test runner run each test four times... which is kind of a workaround, but it does work. [23:22:17] 10CirrusSearch, 06Discovery, 06Discovery-Search: Fix browser tests flagged with @expect_failure - https://phabricator.wikimedia.org/T132469#2878868 (10Deskana) 05Open>03Resolved a:03EBernhardson We made the test runner run each test four times... which is kind of a workaround, but it does work. [23:23:06] 10MediaWiki-extensions-Translate, 06Discovery, 06Discovery-Search, 10Elasticsearch: Implement update freeze and/or delays for TTMServerMessageUpdateJob - https://phabricator.wikimedia.org/T132315#2194227 (10Deskana) This ticket is old. Is this still causing a problem? [23:23:12] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2878873 (10Yurik) @ksmith, I think we should also remove the auto-appending of the #discovery tag - I think i... [23:23:20] 07Design, 06Discovery, 07Accessibility, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2878874 (10Volker_E) [23:24:48] 10CirrusSearch, 06Discovery, 06Discovery-Search: CirrusSearch\Elastica\PooledHttp class more robust - https://phabricator.wikimedia.org/T132075#2878878 (10Deskana) 05Open>03declined @EBernhardson thinks the current solution is good enough. [23:25:32] 06Discovery-Search: Section heading suggestions in search results can point to wrong heading - https://phabricator.wikimedia.org/T131950#2878894 (10Deskana) p:05Triage>03Low A legitimate issue, but it's an edge case since it's incredibly unlikely to occur in content namespaces, it can't really be prioritised. [23:25:40] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2878896 (10ksmith) @Deskana : You're the main stakeholder for the #Discovery tag. Do you find value in having... [23:25:43] 06Discovery, 06Discovery-Search: Section heading suggestions in search results can point to wrong heading - https://phabricator.wikimedia.org/T131950#2878898 (10Deskana) [23:25:59] (03PS12) 10Aaron Schulz: resourceloader: Don't let module exception break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) (owner: 10Krinkle) [23:26:57] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 07WorkType-NewFunctionality: Use Extension:JsonConfig for storing the template param mapping between languages - https://phabricator.wikimedia.org/T143857#2878905 (10Yurik) Tabular data has launched, and could be easily... [23:27:22] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2878906 (10Deskana) >>! In T137816#2878896, @ksmith wrote: > @Deskana : You're the main stakeholder for the #... [23:27:48] (03CR) 10jenkins-bot: [V: 04-1] Decrease the number of 'function says it should return something' errors [core] - 10https://gerrit.wikimedia.org/r/327666 (owner: 10MaxSem) [23:28:17] 10MediaWiki-API, 10MediaWiki-Language-converter, 10Parsoid: Export LanguageConverter enabled status in page info from core - https://phabricator.wikimedia.org/T153341#2878907 (10cscott) Hm. Preventing conversion when all variants are disabled is a little tricky. I believe $wgDisableLangConversion is meant... [23:30:55] MaxSem: You're doing stuff we were going to add to GCI :P [23:30:56] https://phabricator.wikimedia.org/T153252 [23:38:19] 10New-Readers, 06Reading-analysis: % of content read by % of people - https://phabricator.wikimedia.org/T152437#2878911 (10atgo) Hey @tbayer thinking about this more - could we do this per language for at least some languages? that will be way more useful than the overall #s. [23:39:14] 10MediaWiki-File-management, 10CirrusSearch, 06Commons, 06Discovery, and 2 others: Ogg Opus-File should be classified as audio not multimedia-Files. - https://phabricator.wikimedia.org/T151352#2878912 (10Smalyshev) Search is using already existing file data, which is generated by MimeAnalyzer::getMediaType... [23:40:11] 10MediaWiki-extensions-TemplateSandbox, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor - https://phabricator.wikimedia.org/T153367#2878914 (10AlexMonk-WMF) [23:40:36] (03PS3) 10Mooeypoo: [wip] Create active/inactive behavior for complementary filters [core] - 10https://gerrit.wikimedia.org/r/327419 (https://phabricator.wikimedia.org/T149452) [23:42:18] (03PS3) 10Niedzielski: Update: add news headline topic property [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323087 (https://phabricator.wikimedia.org/T148444) [23:44:01] (03CR) 10Niedzielski: [C: 04-1] "Rebased. Need to respond to feedback" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323087 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [23:44:17] 07Design, 06Discovery, 07Accessibility, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2878920 (10Volker_E) I'd like to emphasize that – when speaking about guidelines – we not only need to look at the presentational layer, but also t... [23:45:02] 10MediaWiki-extensions-DonationInterface, 10FR-PayPal-ExpressCheckout, 10FR-Paypal, 10Fundraising-Backlog, and 2 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2878922 (10awight) We're never reaching the `CreateRecurringPaymentsProfile` call, so the... [23:47:33] (03Abandoned) 10Jdlrobson: Hovering over links in menu should change link/icon to blue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T152418) (owner: 10Jdlrobson) [23:50:47] (03PS7) 10Tim Starling: Protect language converter markup in the preprocessor. [core] - 10https://gerrit.wikimedia.org/r/311849 (https://phabricator.wikimedia.org/T146304) (owner: 10C. Scott Ananian) [23:53:07] (03PS11) 10Jdlrobson: Introduce Opt-In option on user preferences page [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [23:54:04] (03CR) 10Tim Starling: [C: 032] "Looks fine. I think the $this->rules thing has overstayed its welcome, it would be nice to clean that up at some point since it has never " [core] - 10https://gerrit.wikimedia.org/r/311849 (https://phabricator.wikimedia.org/T146304) (owner: 10C. Scott Ananian)