[00:01:20] (03CR) 10jenkins-bot: [V: 04-1] Protect -{...}- variant constructs in definition lists. [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) (owner: 10C. Scott Ananian) [00:01:42] 10MediaWiki-extensions-GlobalBlocking, 07Wikimedia-log-errors: Warning: method_exists() expects exactly 2 parameters, 1 given in GlobalBlocking.class.php - https://phabricator.wikimedia.org/T153153#2871300 (10mmodell) [00:01:56] 10MediaWiki-extensions-GlobalBlocking, 07Wikimedia-log-errors: Warning: method_exists() expects exactly 2 parameters, 1 given in GlobalBlocking.class.php - https://phabricator.wikimedia.org/T153153#2871314 (10mmodell) [00:06:44] (03CR) 10jenkins-bot: [V: 04-1] Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) (owner: 10C. Scott Ananian) [00:07:13] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: breakup mega-function in MobileView API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327129 (owner: 10Jdlrobson) [00:08:27] 10MediaWiki-extensions-GlobalBlocking, 07Wikimedia-log-errors: Warning: method_exists() expects exactly 2 parameters, 1 given in GlobalBlocking.class.php - https://phabricator.wikimedia.org/T153153#2871322 (10mmodell) a:03mmodell [00:10:10] (03PS1) 1020after4: Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/327133 (https://phabricator.wikimedia.org/T153153) [00:11:06] (03PS10) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [00:12:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Epic: [Epic] Wikidata changes in article history - https://phabricator.wikimedia.org/T42358#455536 (10JKatzWMF) Just noting that this will be an extra helpful precaution against potential vandalism arising from wikidata description editing in Android app f... [00:13:08] (03PS1) 1020after4: Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327134 (https://phabricator.wikimedia.org/T153153) [00:13:24] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Epic: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]) - https://phabricator.wikimedia.org/T46874#490794 (10JKatzWMF) Just noting that fixing this will be an extra precau... [00:13:33] (03CR) 1020after4: [C: 032] Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327134 (https://phabricator.wikimedia.org/T153153) (owner: 1020after4) [00:13:38] (03CR) 10jenkins-bot: [] Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327134 (https://phabricator.wikimedia.org/T153153) (owner: 1020after4) [00:15:10] (03Merged) 10jenkins-bot: Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327134 (https://phabricator.wikimedia.org/T153153) (owner: 1020after4) [00:16:29] 10MobileFrontend, 06Reading-Web-Backlog: Bug: Lazy loaded references do not load on certain pages - https://phabricator.wikimedia.org/T146394#2871362 (10Jdlrobson) I got sucked into refactoring the API to make sense of what's happening here: * Kicked off with https://gerrit.wikimedia.org/r/327129 After a litt... [00:21:14] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Unplanned-Sprint-Work: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2871395 (10Ejegg) Confirmed that the userAgent seen by JS is the same as that sent... [00:24:50] (03CR) 10Ejegg: [] "OK, Alex Monk, the phab task is now public. Bmansurov, I added the observed userAgent to the qunit startup blacklist test." [core] - 10https://gerrit.wikimedia.org/r/327043 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [00:26:10] 10MediaWiki-extensions-GlobalBlocking, 13Patch-For-Review, 07Wikimedia-log-errors: Warning: method_exists() expects exactly 2 parameters, 1 given in GlobalBlocking.class.php - https://phabricator.wikimedia.org/T153153#2871425 (10mmodell) 05Open>03Resolved p:05Triage>03High [00:26:20] (03CR) 1020after4: [C: 032] Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/327133 (https://phabricator.wikimedia.org/T153153) (owner: 1020after4) [00:26:26] (03CR) 10jenkins-bot: [] Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/327133 (https://phabricator.wikimedia.org/T153153) (owner: 1020after4) [00:27:08] 10MediaWiki-extensions-GlobalBlocking, 13Patch-For-Review, 07Wikimedia-log-errors: Warning: method_exists() expects exactly 2 parameters, 1 given in GlobalBlocking.class.php - https://phabricator.wikimedia.org/T153153#2871300 (10mmodell) [00:27:21] (03Merged) 10jenkins-bot: Fix T153153 - method_exists takes to args, not an array. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/327133 (https://phabricator.wikimedia.org/T153153) (owner: 1020after4) [00:30:41] 10LDAP-Access-Requests: Add Carolyn Li-Madeo to wmf staff with Piwik login access - https://phabricator.wikimedia.org/T153102#2871430 (10demon) 05Open>03Resolved a:03demon Done. [00:31:58] 07Wikimedia-log-errors: pl proc line: 2959: warning: points must have either 4 or 2 values per line - https://phabricator.wikimedia.org/T153159#2871433 (10mmodell) [00:32:19] 07Wikimedia-log-errors: pl proc line: 2959: warning: points must have either 4 or 2 values per line - https://phabricator.wikimedia.org/T153159#2871445 (10mmodell) p:05Triage>03Normal [00:37:30] (03CR) 10Smalyshev: [] "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325622 (https://phabricator.wikimedia.org/T152543) (owner: 10Smalyshev) [00:37:56] (03PS2) 10Jdlrobson: Hygiene: breakup mega-function in MobileView API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327129 [00:39:08] (03CR) 10Gergő Tisza: [] "I copied it (and the other dependencies) from import::text where you added it in I127007af. Beyond that, I have no idea :)" [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [00:43:21] (03PS4) 10EBernhardson: [WIP] Calculate click data for top queries [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/317019 (https://phabricator.wikimedia.org/T149047) [00:43:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Calculate click data for top queries [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/317019 (https://phabricator.wikimedia.org/T149047) (owner: 10EBernhardson) [00:48:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: breakup mega-function in MobileView API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327129 (owner: 10Jdlrobson) [00:49:30] (03CR) 10Jdlrobson: [C: 032] Use global variable for tablet media query in responsive.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/326385 (https://phabricator.wikimedia.org/T124994) (owner: 10Jo12bar) [00:49:35] (03CR) 10jenkins-bot: [] Use global variable for tablet media query in responsive.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/326385 (https://phabricator.wikimedia.org/T124994) (owner: 10Jo12bar) [00:49:48] (03Abandoned) 10Jdlrobson: Fix media query bug & change skin.json structure [skins/Vector] - 10https://gerrit.wikimedia.org/r/326874 (https://phabricator.wikimedia.org/T124994) (owner: 10Jo12bar) [00:51:29] (03Merged) 10jenkins-bot: Use global variable for tablet media query in responsive.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/326385 (https://phabricator.wikimedia.org/T124994) (owner: 10Jo12bar) [00:53:23] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 06Collaboration-Team-Triage, 10Flow, and 5 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#2871484 (10Jdlrobson) [00:57:07] (03PS3) 10Jdlrobson: Hygiene: breakup mega-function in MobileView API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327129 [01:05:53] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 15User-Daniel: Usage tracking: record which statement group is used - https://phabricator.wikimedia.org/T151717#2871509 (10Hall1467) I think a good way to go about this tracking would be by overriding the Lua direct access method for the table that represent... [01:08:44] (03CR) 10Ppchelko: [] "Also will need to set up the probability for logging in the config" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327045 (owner: 10Ppchelko) [01:10:18] (03CR) 10Kaldari: [C: 04-1] Add autocompletion to search fields (033 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [01:11:21] (03CR) 10Kaldari: [C: 04-1] Add autocompletion to search fields (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [01:17:50] (03CR) 10Kaldari: [C: 04-1] "Also, you'll need to add:" [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [01:18:01] Krenair: Googleweblight is also deleting all images below the fold (while leaving their captions) [01:18:19] with the CN code? [01:18:22] or just in general? [01:18:32] in general - it's due to that mobile optimization where we don't load the images till you scroll down [01:18:47] https://googleweblight.com/?lite_url=https://es.wikipedia.org/wiki/Barack_Obama [01:18:55] ^^^ no banners on eswiki right now [01:19:28] it /would/ show the images if it was in no-js mode [01:20:13] this proxy seems broken enough that we probably shouldn't be trying to run JS on it [01:20:21] yeah [01:20:41] I updated the commit message to point out the non-CN brokenness [01:21:05] and added a UA to the qunit blacklist test [01:21:25] (03PS1) 10Jdlrobson: Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) [01:21:42] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Bug: Lazy loaded references do not load on certain pages - https://phabricator.wikimedia.org/T146394#2871528 (10Jdlrobson) [01:23:38] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Bug: Lazy loaded references do not load on certain pages - https://phabricator.wikimedia.org/T146394#2659687 (10Jdlrobson) a:03Jdlrobson Bingo. [01:24:07] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Bug: Lazy loaded references do not load on certain pages - https://phabricator.wikimedia.org/T146394#2871533 (10Jdlrobson) To test behaviour please try https://en.m.wikipedia.beta.wmflabs.or... [01:24:50] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Bug: Lazy loaded references do not load on certain pages - https://phabricator.wikimedia.org/T146394#2871534 (10Jdlrobson) [01:25:14] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Bug: Lazy loaded references do not load on certain pages - https://phabricator.wikimedia.org/T146394#2659687 (10Jdlrobson) [01:25:46] (03PS11) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [01:26:38] (03CR) 10Jdlrobson: [C: 031] "Sam can you merge? I don't want to mess up your flow." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [01:27:31] (03CR) 10Reedy: [] "Are we going to merge this?" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [01:29:14] (03PS5) 10C. Scott Ananian: Protect -{...}- variant constructs in definition lists. [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) [01:29:17] (03PS4) 10C. Scott Ananian: Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) [01:30:48] (03CR) 10jenkins-bot: [V: 04-1] Test and correct behaviour of getSectionId [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [01:33:06] (03PS8) 10Smalyshev: Report all syntax in stats, also add syntax to the log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) [01:34:03] (03CR) 10Smalyshev: [] Report all syntax in stats, also add syntax to the log (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [01:41:29] (03CR) 10Alex Monk: [] "okay. roan/timo?" [core] - 10https://gerrit.wikimedia.org/r/327043 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [01:43:24] 10CirrusSearch, 06Discovery, 06Discovery-Search: Convert CirrusSearch to use extension registration - https://phabricator.wikimedia.org/T87892#2871549 (10Smalyshev) [01:43:26] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Find a way to keep CirrusSearch settings comments - https://phabricator.wikimedia.org/T142811#2871548 (10Smalyshev) 05Open>03Resolved [01:45:02] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [01:45:10] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [01:51:24] (03CR) 10BearND: [C: 04-1] "Minor stuff/questions inline." (034 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [01:56:18] (03PS1) 10Chelsyx: add geo breakdown [wikimedia/discovery/prince] - 10https://gerrit.wikimedia.org/r/327139 [02:00:03] 10MediaWiki-extensions-PageAssessments, 06Community-Tech: Convert PageAssessments projects API from a property query to a list query - https://phabricator.wikimedia.org/T153164#2871572 (10kaldari) [02:03:57] (03CR) 10Catrope: [C: 032] "I think that the fact that we can't execute JS for the user, only on the Google server, is reason enough to blacklist this UA, especially " [core] - 10https://gerrit.wikimedia.org/r/327043 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [02:04:03] (03CR) 10jenkins-bot: [] Add googleweblight to JS blacklist [core] - 10https://gerrit.wikimedia.org/r/327043 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [02:04:29] (03PS1) 10MtDu: Replace Linker::link*() usage with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/327140 (https://phabricator.wikimedia.org/T149346) [02:04:33] grrrit-wm has issues with zero scores again :/ [02:04:51] (03PS2) 10Chelsyx: Add geo breakdowns [wikimedia/discovery/prince] - 10https://gerrit.wikimedia.org/r/327139 (https://phabricator.wikimedia.org/T138107) [02:06:23] (03CR) 10Ejegg: [] "Thanks Catrope! We have a potential workaround (blocking by UA on Special:BannerLoader), but expediting this may be preferable." [core] - 10https://gerrit.wikimedia.org/r/327043 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [02:06:43] (03PS2) 10MtDu: Replace Linker::link*() usage with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/327140 (https://phabricator.wikimedia.org/T149346) [02:07:23] (03PS3) 10MtDu: Replace Linker::link*() usage with LinkRenderer [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/327140 (https://phabricator.wikimedia.org/T149346) [02:17:28] (03Merged) 10jenkins-bot: Add googleweblight to JS blacklist [core] - 10https://gerrit.wikimedia.org/r/327043 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [02:21:50] (03PS4) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [02:23:37] (03CR) 10jenkins-bot: [V: 04-1] Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [02:24:42] (03CR) 10Samwilson: [] "@kaldari: thanks for reviewing. I've updated those points." (033 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [02:26:17] (03PS5) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [02:27:58] (03CR) 10jenkins-bot: [V: 04-1] Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [02:28:22] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint: TypeError: exclude.indexOf is not a function - https://phabricator.wikimedia.org/T153165#2871605 (10Samwilson) [02:32:02] (03PS6) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [02:33:26] (03CR) 10jenkins-bot: [V: 04-1] Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [02:37:45] (03PS1) 10Samwilson: Re-index the array of excluded namespace IDs [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327141 (https://phabricator.wikimedia.org/T153165) [02:38:37] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review: TypeError: exclude.indexOf is not a function - https://phabricator.wikimedia.org/T153165#2871605 (10Samwilson) p:05Triage>03Normal [02:41:42] (03PS7) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [02:43:19] (03CR) 10jenkins-bot: [V: 04-1] Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [02:45:12] (03PS8) 10Samwilson: Add autocompletion to search fields [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) [02:47:15] (03CR) 10Samwilson: [] "Right, sorry about all that noise. This is now ready to be reviewed again! :-)" [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [03:32:40] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2871630 (10srishakatux) I've created a page about the Hack Day https://www.mediawiki.org/wiki/Wikimedia_Developer_Summit/2017/Hack_Day and the Pre-summit Meetup h... [04:21:39] 10MediaWiki-extensions-UrlShortener: Add basic abuse prevention to UrlShortener - https://phabricator.wikimedia.org/T133109#2220431 (10Jalexander) yeah, I think a rate limit could prevent the biggest amount of this. That makes it a lot harder to try and force a problematic, specific, url to use. 10 per 2 is prob... [04:25:01] 10MediaWiki-extensions-UrlShortener: Add basic abuse prevention to UrlShortener - https://phabricator.wikimedia.org/T133109#2871635 (10Jalexander) Also: How hard is it to deactivate a url if worst comes to worst? Is it just a db row being dropped (or changed) or is it something more massively pita? [04:36:23] 06Wikipedia-Android-App-Backlog, 07Easy, 07WorkType-NewFunctionality: require confirmation for deleting one item from history - https://phabricator.wikimedia.org/T103685#2871638 (10Probz360) a:03Probz360 [05:35:00] 10MediaWiki-ResourceLoader, 06Performance-Team: Grafana alerts for ResourceLoader - https://phabricator.wikimedia.org/T153171#2871715 (10Peter) [05:37:43] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2871729 (10srishakatux) @Qgil @Rfarrand I've updated the schedule page that we previously created: https://www.mediawiki... [05:38:51] (03PS1) 10BearND: mobile-sections: remove unnecessary TextExtract request [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327142 [05:41:25] (03CR) 10jenkins-bot: [V: 04-1] mobile-sections: remove unnecessary TextExtract request [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327142 (owner: 10BearND) [05:52:31] 10MiniInvite, 10Social-Tools, 07Easy: Lowercase content of i18n messages for consistency with other messages - https://phabricator.wikimedia.org/T152879#2871731 (10MtDu) a:03MtDu I can fix this within a week or two. :) [06:14:45] (03CR) 10BearND: [C: 04-1] Add additional information to file and user pages for rendering (033 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [06:15:08] 10MediaWiki-extensions-Linter, 10Parsoid, 13Patch-For-Review, 07Verified: Crasher when linting a gallery - https://phabricator.wikimedia.org/T152785#2871736 (10Ryasmeen) [06:15:16] (03CR) 10BearND: [] "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327142 (owner: 10BearND) [06:17:33] 10MediaWiki-extensions-UrlShortener: Add basic abuse prevention to UrlShortener - https://phabricator.wikimedia.org/T133109#2871738 (10Legoktm) >>! In T133109#2871635, @Jalexander wrote: > Also: How hard is it to deactivate a url if worst comes to worst? Is it just a db row being dropped (or changed) or is it so... [06:21:27] (03PS1) 10Fomafix: Apply color palette change also to wikitable cell border [core] - 10https://gerrit.wikimedia.org/r/327144 [06:22:42] (03PS5) 10BearND: Update: pick localized pic descriptions uniformly [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322049 (owner: 10Niedzielski) [06:24:33] (03CR) 10BearND: [C: 032] Update: pick localized pic descriptions uniformly [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322049 (owner: 10Niedzielski) [06:24:38] (03CR) 10jenkins-bot: [] Update: pick localized pic descriptions uniformly [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322049 (owner: 10Niedzielski) [06:26:25] (03Merged) 10jenkins-bot: Update: pick localized pic descriptions uniformly [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322049 (owner: 10Niedzielski) [06:30:18] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Exit the template editing mode when the user moves to a different paragraph - https://phabricator.wikimedia.org/T151630#2823186 (10Nikerabbit) a:03Nikerabbit [06:44:32] 10MediaWiki-Vagrant, 07HHVM: Xdebug does not work with HHVM in CLI mode - https://phabricator.wikimedia.org/T153172#2871756 (10Tgr) [06:55:57] 10MediaWiki-Vagrant, 07HHVM: Xdebug does not work with HHVM in CLI mode - https://phabricator.wikimedia.org/T153172#2871773 (10Tgr) When used on a real file with `-d xdebug.remote_autostart=1` it works as expected and does not hang, so that's a good workaround. It would be nice to have a simple way to turn it... [07:02:45] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5), 07WorkType-Maintenance: Some translations can't be published after deploying the new CX templa... - https://phabricator.wikimedia.org/T152144#2871775 [07:03:01] 10MediaWiki-Vagrant, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-CXserver, 10ContentTranslation-Deployments, and 3 others: Update contenttranslation role in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T149284#2871777 (10Arrbee) [07:03:03] 10MediaWiki-Vagrant, 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07Unplanned-Sprint-Work: Add Echo dependency to contenttranslation role - https://phabricator.wikimedia.org/T152372#2871776 (10Arrbee) 05Open>03Resolved [07:05:25] 10MediaWiki-Vagrant, 07HHVM: Xdebug does not work with HHVM in CLI mode - https://phabricator.wikimedia.org/T153172#2871778 (10Tgr) ``` alias php='/usr/bin/php -d xdebug.remote_enable="${HHVM_XDEBUG_ENABLED:0}"' ``` sort of works but fails if the variable is set on the same line. Alternatively, the already exi... [07:07:39] 10MediaWiki-Vagrant, 07HHVM: Xdebug does not work with HHVM in CLI mode - https://phabricator.wikimedia.org/T153172#2871780 (10Tgr) Or define alternative commands like `hhvm-debug` / `php-debug` I guess. [07:15:08] 10UI-Standardization, 10MassMessage, 13Patch-For-Review, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2871784 (10Ladsgroup) [07:15:16] (03PS1) 10Phuedx: Make API requests after 50 ms [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327147 [07:15:28] (03CR) 10Nikerabbit: [C: 032] Fixing mediawiki's য় problem [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/327047 (owner: 10Aftab) [07:15:34] (03CR) 10jenkins-bot: [] Fixing mediawiki's য় problem [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/327047 (owner: 10Aftab) [07:15:49] (03CR) 10Ladsgroup: [] "Added in the phab card" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) (owner: 10Ladsgroup) [07:15:53] (03CR) 10Nikerabbit: [C: 032] Fixing mediawiki's য় problem [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327033 (owner: 10Aftab) [07:16:00] (03CR) 10jenkins-bot: [] Fixing mediawiki's য় problem [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327033 (owner: 10Aftab) [07:18:02] (03CR) 10jenkins-bot: [V: 04-1] Make API requests after 50 ms [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327147 (owner: 10Phuedx) [07:18:30] 10MediaWiki-API, 10MediaWiki-Uploading, 06Multimedia, 05MW-1.29-release-notes, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Non transcluded variable in stashfailed error message - https://phabricator.wikimedia.org/T147720#2871785 (10matmarex) 05Open>03Resolved a:03matmarex This should fix the error mess... [07:23:19] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2871789 (10Marostegui) >>! In T152761#2869535, @kaldari wrote: > @Marostegui: Apparently, it's taking a long time to complete the... [07:24:59] (03CR) 10Ladsgroup: [] "Already covered in I233e42ac399202791dd44e48dc58487be0f9d8ac" [core] - 10https://gerrit.wikimedia.org/r/327144 (owner: 10Fomafix) [07:26:28] (03Merged) 10jenkins-bot: Fixing mediawiki's য় problem [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/327047 (owner: 10Aftab) [07:26:30] (03CR) 10jenkins-bot: [V: 04-1] Fixing mediawiki's য় problem [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327033 (owner: 10Aftab) [07:26:42] (03CR) 10Bartosz Dziewoński: [] "I think https://gerrit.wikimedia.org/r/326370 in OOjs UI fixes most of this?" [core] - 10https://gerrit.wikimedia.org/r/327039 (owner: 10VolkerE) [07:27:49] (03CR) 10Gergő Tisza: [] "recheck" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/303345 (https://phabricator.wikimedia.org/T142134) (owner: 1001tonythomas) [07:28:43] (03CR) 10BearND: [C: 04-1] Hygiene: improve ESLint configuration (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/325709 (owner: 10Niedzielski) [07:29:02] (03CR) 10BearND: [C: 04-1] "Let's try a manual rebase first." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/325709 (owner: 10Niedzielski) [07:29:04] (03CR) 10jenkins-bot: [V: 04-1] Check if the user is subscribed initially, before unsubscribing [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/303345 (https://phabricator.wikimedia.org/T142134) (owner: 1001tonythomas) [07:29:53] 10Wikimedia-Extension-setup, 07Tracking: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T33235#2871794 (10Legoktm) [07:29:55] 10MediaWiki-extensions-StopForumSpam, 10Security-Reviews, 06Support-and-Safety, 06WMF-Legal: Security and compliance with the Privacy Policy review of Extension:StopForumSpam to consider deployment on WMF wikis - https://phabricator.wikimedia.org/T125338#2871791 (10Legoktm) 05Open>03Resolved a:03Legok... [07:33:57] 10MediaWiki-File-management, 06Commons, 06Multimedia: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2871796 (10Osnard) Status update: The "hacky way" was not a good one. I've now decided to create a new entry point (based on `img_... [07:36:47] (03PS5) 10EBernhardson: Calculate click data for top queries [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/317019 (https://phabricator.wikimedia.org/T149047) [07:36:54] (03CR) 10jenkins-bot: [V: 04-1] Calculate click data for top queries [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/317019 (https://phabricator.wikimedia.org/T149047) (owner: 10EBernhardson) [07:37:08] (03CR) 10Bartosz Dziewoński: [C: 032] Apply color palette change also to wikitable cell border [core] - 10https://gerrit.wikimedia.org/r/327144 (owner: 10Fomafix) [07:37:14] (03CR) 10jenkins-bot: [] Apply color palette change also to wikitable cell border [core] - 10https://gerrit.wikimedia.org/r/327144 (owner: 10Fomafix) [07:37:52] (03CR) 10Bartosz Dziewoński: [] Some more invisible adjustments to Wikimedia color palette. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [07:37:55] (03CR) 10Nikerabbit: [C: 032] "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327033 (owner: 10Aftab) [07:38:00] (03CR) 10jenkins-bot: [] Fixing mediawiki's য় problem [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327033 (owner: 10Aftab) [07:38:18] (03CR) 10Bartosz Dziewoński: [] Some more invisible adjustments to Wikimedia color palette. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [07:42:59] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2791502 (10Samwilson) I've attempted to write some documentation for the structure of the on-wiki configuration... [07:43:56] (03CR) 10Legoktm: [C: 04-1] "All of the JavaScript in ext.MassMessage.create.js needs to be updated too." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) (owner: 10Ladsgroup) [07:45:30] (03CR) 10Ladsgroup: [] Some more invisible adjustments to Wikimedia color palette. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [07:45:53] (03PS2) 10Ladsgroup: Some more invisible adjustments to Wikimedia color palette. [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) [07:49:19] (03Merged) 10jenkins-bot: Apply color palette change also to wikitable cell border [core] - 10https://gerrit.wikimedia.org/r/327144 (owner: 10Fomafix) [07:49:22] (03Merged) 10jenkins-bot: Fixing mediawiki's য় problem [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327033 (owner: 10Aftab) [07:56:18] (03PS6) 10Gergő Tisza: Fix tests [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/325883 (https://phabricator.wikimedia.org/T142134) [07:56:19] 04(no projects): img_auth.php: Improve extendability - https://phabricator.wikimedia.org/T153174#2871813 (10Osnard) [07:56:28] (03PS2) 10Gergő Tisza: Check if the user is subscribed initially, before unsubscribing [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/303345 (https://phabricator.wikimedia.org/T142134) (owner: 1001tonythomas) [07:57:02] (03PS3) 10Gergő Tisza: Check if the user is subscribed initially, before unsubscribing [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/303345 (https://phabricator.wikimedia.org/T142134) (owner: 1001tonythomas) [07:57:18] (03PS7) 10Gergő Tisza: Fix tests [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/325883 (https://phabricator.wikimedia.org/T142134) [07:57:45] 10MediaWiki-File-management, 06Commons, 06Multimedia: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2871825 (10Osnard) [07:57:47] 04(no projects): img_auth.php: Improve extendability - https://phabricator.wikimedia.org/T153174#2871824 (10Osnard) [07:57:53] (03CR) 10jenkins-bot: [V: 04-1] Check if the user is subscribed initially, before unsubscribing [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/303345 (https://phabricator.wikimedia.org/T142134) (owner: 1001tonythomas) [07:58:21] (03CR) 10jenkins-bot: [V: 04-1] Fix tests [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/325883 (https://phabricator.wikimedia.org/T142134) (owner: 10Gergő Tisza) [07:58:28] (03PS8) 10Gergő Tisza: Fix tests [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/325883 (https://phabricator.wikimedia.org/T142134) [08:04:42] (03CR) 10Gergő Tisza: [] "Not sure what's going on here. It's definitely related to caching (the original error also goes away when loading users with READ_LATEST)." [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/325883 (https://phabricator.wikimedia.org/T142134) (owner: 10Gergő Tisza) [08:09:28] 10MediaWiki-extensions-ContentTranslation: Horizontal scrollbar in translation view columns and JS errors in OOjs UI - https://phabricator.wikimedia.org/T153175#2871831 (10Nikerabbit) [08:10:02] (03PS7) 10Sebastian Berlin (WMSE): Skip back sentence [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/314664 (https://phabricator.wikimedia.org/T133687) [08:14:57] 10MediaWiki-General-or-Unknown: img_auth.php: Improve extendability - https://phabricator.wikimedia.org/T153174#2871845 (10Paladox) [08:21:56] 10MediaWiki-extensions-ContentTranslation: Horizontal scrollbar in translation view columns and JS errors in OOjs UI - https://phabricator.wikimedia.org/T153175#2871848 (10Nikerabbit) ``` 2c71e9181acf0469125f4804320d53a604f75a6b is the first bad commit commit 2c71e9181acf0469125f4804320d53a604f75a6b Author: Sant... [08:25:42] (03PS4) 10Legoktm: API: Expose wfIsBadImage() in prop=imageinfo [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) [08:29:41] (03PS5) 10Legoktm: API: Expose wfIsBadImage() in prop=imageinfo [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) [08:30:19] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy wikidata descriptions to English Wikipedia - https://phabricator.wikimedia.org/T152743#2871865 (10JEumerus) Not sure if this is the right place, but is it clearly marked somewhere that such descriptions are not part of enWiki? [08:35:13] (03CR) 10Ladsgroup: [] "ping" [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [08:36:53] 06Repository-Ownership-Requests: +2 for Fomafix in mediawiki/* - https://phabricator.wikimedia.org/T153177#2871869 (10Legoktm) [08:37:11] (03PS1) 10Robert Vogel: Fixed file name calcuation for special case [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/327149 [08:38:19] (03CR) 10Robert Vogel: [C: 032] Fixed file name calcuation for special case [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/327149 (owner: 10Robert Vogel) [08:38:24] (03CR) 10jenkins-bot: [] Fixed file name calcuation for special case [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/327149 (owner: 10Robert Vogel) [08:38:26] (03PS1) 10Robert Vogel: Fixed file name calcuation for special case [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/327150 [08:38:38] (03CR) 10Robert Vogel: [C: 032] Fixed file name calcuation for special case [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/327150 (owner: 10Robert Vogel) [08:38:44] (03CR) 10jenkins-bot: [] Fixed file name calcuation for special case [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/327150 (owner: 10Robert Vogel) [08:39:19] (03Merged) 10jenkins-bot: Fixed file name calcuation for special case [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/327149 (owner: 10Robert Vogel) [08:39:38] (03Merged) 10jenkins-bot: Fixed file name calcuation for special case [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/327150 (owner: 10Robert Vogel) [08:41:27] (03CR) 10Legoktm: [C: 032] "We should also file an upstream ticket for this functionality if there isn't already one..." [core] - 10https://gerrit.wikimedia.org/r/325963 (owner: 10EBernhardson) [08:41:27] 04(no projects): Restoration might fail in ContentTranslationLoader.prototype.restoreSection - https://phabricator.wikimedia.org/T153178#2871882 (10Nikerabbit) [08:41:33] (03CR) 10jenkins-bot: [] Add script to support per-line @suppress annotations in Phan [core] - 10https://gerrit.wikimedia.org/r/325963 (owner: 10EBernhardson) [08:42:25] 10MediaWiki-Categories, 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor makes redlinked category index pages inacessible - https://phabricator.wikimedia.org/T139191#2871896 (10Schnark) [08:43:46] (03CR) 10Legoktm: [C: 032] Convert legacy bugs ID to Phabricator tasks ID for Parser class [core] - 10https://gerrit.wikimedia.org/r/326372 (owner: 10Dereckson) [08:43:51] (03CR) 10jenkins-bot: [] Convert legacy bugs ID to Phabricator tasks ID for Parser class [core] - 10https://gerrit.wikimedia.org/r/326372 (owner: 10Dereckson) [08:46:00] (03CR) 10Legoktm: [C: 032] "Image size limit" text should always read left-to-right [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [08:46:06] (03CR) 10jenkins-bot: [] "Image size limit" text should always read left-to-right [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [08:46:23] (03CR) 10Legoktm: [C: 032] The automatic test in MediaWikiTestCase was marked as risky [core] - 10https://gerrit.wikimedia.org/r/326363 (https://phabricator.wikimedia.org/T152923) (owner: 10Seb35) [08:46:30] (03CR) 10jenkins-bot: [] The automatic test in MediaWikiTestCase was marked as risky [core] - 10https://gerrit.wikimedia.org/r/326363 (https://phabricator.wikimedia.org/T152923) (owner: 10Seb35) [08:47:29] (03CR) 10Legoktm: [C: 032] Message: Fix buggy parameter handling in Message::params() [core] - 10https://gerrit.wikimedia.org/r/325790 (https://phabricator.wikimedia.org/T152603) (owner: 10Anomie) [08:47:35] (03CR) 10jenkins-bot: [] Message: Fix buggy parameter handling in Message::params() [core] - 10https://gerrit.wikimedia.org/r/325790 (https://phabricator.wikimedia.org/T152603) (owner: 10Anomie) [08:49:22] (03CR) 10Legoktm: [C: 04-1] "the idn_ functions can't be depended upon, we don't require the intl extension. Either it should be optional, or we need to polyfill them." [core] - 10https://gerrit.wikimedia.org/r/322729 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [08:49:35] (03PS2) 10Aaron Schulz: CIDR finder should allow spaces around the minus character [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/325615 (https://phabricator.wikimedia.org/T152519) (owner: 10Huji) [08:50:05] (03CR) 10Aaron Schulz: [C: 032] CIDR finder should allow spaces around the minus character [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/325615 (https://phabricator.wikimedia.org/T152519) (owner: 10Huji) [08:50:10] (03CR) 10jenkins-bot: [] CIDR finder should allow spaces around the minus character [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/325615 (https://phabricator.wikimedia.org/T152519) (owner: 10Huji) [08:50:47] (03CR) 10Legoktm: [C: 031] "From a MW perspective I think this is good to go...are we still waiting on DBA approval?" [core] - 10https://gerrit.wikimedia.org/r/322727 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [08:51:29] (03Merged) 10jenkins-bot: Add script to support per-line @suppress annotations in Phan [core] - 10https://gerrit.wikimedia.org/r/325963 (owner: 10EBernhardson) [08:51:32] (03Draft1) 10Paladox: Make bot ignore jenkins-bot v+2 again [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 [08:51:37] (03Draft2) 10Paladox: Make bot ignore jenkins-bot v+2 again [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 [08:52:22] (03Merged) 10jenkins-bot: Convert legacy bugs ID to Phabricator tasks ID for Parser class [core] - 10https://gerrit.wikimedia.org/r/326372 (owner: 10Dereckson) [08:53:54] 10MediaWiki-Categories: Long words page titles display poorly in categories - https://phabricator.wikimedia.org/T153179#2871902 (10Schnark) [08:55:31] (03CR) 10Bartosz Dziewoński: [] Some more invisible adjustments to Wikimedia color palette. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [08:55:59] (03PS3) 10Bartosz Dziewoński: Some more invisible adjustments to Wikimedia color palette. [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [08:56:45] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-ParserFunctions: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2871915 (10Legoktm) 05Open>03declined I don't think we're going to extend
syntax to diverge from the HTML standard, that would just be asking for trou... [08:57:51] 10MediaWiki-extensions-ContentTranslation, 10Continuous-Integration-Config, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2871920 (10hashar) RevisionSlider filled in {... [09:02:29] (03PS1) 10Legoktm: Add missing semicolon to &mdash [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327153 [09:03:17] (03Merged) 10jenkins-bot: "Image size limit" text should always read left-to-right [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [09:03:21] (03Merged) 10jenkins-bot: The automatic test in MediaWikiTestCase was marked as risky [core] - 10https://gerrit.wikimedia.org/r/326363 (https://phabricator.wikimedia.org/T152923) (owner: 10Seb35) [09:03:25] (03Merged) 10jenkins-bot: Message: Fix buggy parameter handling in Message::params() [core] - 10https://gerrit.wikimedia.org/r/325790 (https://phabricator.wikimedia.org/T152603) (owner: 10Anomie) [09:03:46] (03Merged) 10jenkins-bot: CIDR finder should allow spaces around the minus character [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/325615 (https://phabricator.wikimedia.org/T152519) (owner: 10Huji) [09:03:57] (03PS1) 10Ladsgroup: Fix small typos in includes/lib/lockManager/LockManager.php [core] - 10https://gerrit.wikimedia.org/r/327154 [09:05:10] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2871926 (10Qgil) The problem I see with "Creative Coding Day" is that it kind of drives away those who don't code or won't be in coding mood. > Get Stuff Done Da... [09:07:13] (03CR) 10ArielGlenn: [C: 031] "Added LegoKtm (somewhat randomly) as a reviewer, we need a MW dev that can +2 and merge this." [core] - 10https://gerrit.wikimedia.org/r/251804 (owner: 10Gerrit Patch Uploader) [09:07:49] apergos: ok, I can take a look :P [09:08:12] legoktm: sorry about that! [09:08:17] (and thanks) [09:08:17] no worries [09:08:35] 10MediaWiki-extensions-ContentTranslation: Unguarded eternal link in translation column that will navigate away when clicked - https://phabricator.wikimedia.org/T153180#2871929 (10Nikerabbit) [09:08:54] apergos: what actually uses xml:lang? I don't think MW imports do right..? [09:09:13] what a good question. I was only looking at the export piece of course [09:10:17] legoktm: a cursory grep shows that it's not used by imports [09:11:22] yeah, I couldn't find any uses either [09:11:32] reading https://www.w3.org/International/questions/qa-when-xmllang.en it just looks like "an XML thing" [09:11:56] (03CR) 10Legoktm: [C: 032] "According to the bottom of these should be BCP 47." [core] - 10https://gerrit.wikimedia.org/r/251804 (owner: 10Gerrit Patch Uploader) [09:12:02] (03CR) 10jenkins-bot: [] Export: Use BCP 47 language code for attribute xml:lang [core] - 10https://gerrit.wikimedia.org/r/251804 (owner: 10Gerrit Patch Uploader) [09:15:13] apergos: that won't get deployed until January though, is that okay? [09:15:18] that's fine by me [09:15:27] I just didn't want it to sit and rot [09:21:38] (03Merged) 10jenkins-bot: Export: Use BCP 47 language code for attribute xml:lang [core] - 10https://gerrit.wikimedia.org/r/251804 (owner: 10Gerrit Patch Uploader) [09:22:57] \o/ [09:34:13] (03CR) 10Jcrespo: [] "I am ok with this change." [core] - 10https://gerrit.wikimedia.org/r/322727 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [09:38:03] 10MediaWiki-extensions-Linter: Linter: introduce severity level for error categories - https://phabricator.wikimedia.org/T152822#2871959 (10Legoktm) For now I think just 'error' and 'warning' should be good enough? We can add more levels as needed. [09:38:30] 10MediaWiki-extensions-Linter: Linter: Support API query for getting the list of categories - https://phabricator.wikimedia.org/T153056#2871960 (10Legoktm) [09:38:39] 10MediaWiki-extensions-Linter: Linter: introduce severity level for error categories - https://phabricator.wikimedia.org/T152822#2871962 (10Legoktm) [09:38:42] 10MediaWiki-extensions-Linter: Linter: Support API query for getting the list of categories - https://phabricator.wikimedia.org/T153056#2868089 (10Legoktm) [09:39:54] (03CR) 10Legoktm: [C: 032] Add externallinks.el_index_60 column and indexes [core] - 10https://gerrit.wikimedia.org/r/322727 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [09:40:01] (03CR) 10jenkins-bot: [] Add externallinks.el_index_60 column and indexes [core] - 10https://gerrit.wikimedia.org/r/322727 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [09:42:13] 06Repository-Ownership-Requests: +2 for Fomafix in mediawiki/* - https://phabricator.wikimedia.org/T153177#2871963 (10Fomafix) You can filter this with https://gerrit.wikimedia.org/r/#/q/author:%22fomafix%2540googlemail.com%22 [09:44:44] (03CR) 10Legoktm: [C: 032] "Filed T153182 for schema change" [core] - 10https://gerrit.wikimedia.org/r/322727 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [09:47:11] (03Merged) 10jenkins-bot: Add externallinks.el_index_60 column and indexes [core] - 10https://gerrit.wikimedia.org/r/322727 (https://phabricator.wikimedia.org/T59176) (owner: 10Anomie) [09:52:53] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-ParserFunctions: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2871979 (10VictorPorton) "but tag syntax doesn't expand templates inside of it," - I don't understand this phrase. Lua is not a solution of my problem at all,... [09:55:07] (03PS1) 10Thiemo Mättig (WMDE): Remove non-helpful @param documentation from CentralAuthPlugin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327158 [09:57:34] (03CR) 10jenkins-bot: [V: 04-1] Remove non-helpful @param documentation from CentralAuthPlugin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/327158 (owner: 10Thiemo Mättig (WMDE)) [09:59:38] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2871982 (10Qgil) The design looks very good to me, thank you! [10:02:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Story: [Story] consistent order of statements in an item - https://phabricator.wikimedia.org/T99243#2871991 (10thiemowmde) [10:02:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-11-15: [Task] Apply property ordering in EntityView - https://phabricator.wikimedia.org/T150788#2871988 (10thiemowmde) 05Open>03Resolved [10:03:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Story, 03Wikidata-Sprint-2016-11-15: [Story] consistent order of statements in an item - https://phabricator.wikimedia.org/T99243#1287858 (10thiemowmde) [10:03:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Sort statement: Up arrow and question mark nearly melted into each other - https://phabricator.wikimedia.org/T61951#2872000 (10thiemowmde) [10:03:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Story, 07TestMe: [Story] show diffs for ordering changes - https://phabricator.wikimedia.org/T59918#2872001 (10thiemowmde) [10:03:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Story, 03Wikidata-Sprint-2016-11-15: [Story] consistent order of statements in an item - https://phabricator.wikimedia.org/T99243#1287858 (10thiemowmde) 05Open>03Resolved a:03thiemowmde [10:04:03] 10MediaWiki-General-or-Unknown: img_auth.php: Improve extendability - https://phabricator.wikimedia.org/T153174#2872003 (10Aklapper) Have you considered bringing this up on [[ https://lists.wikimedia.org/mailman/listinfo/wikitech-l | wikitech-l@ ]] with some more info? Latest changes: https://phabricator.wikime... [10:05:18] 10MediaWiki-extensions-FlaggedRevs, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Hide reviewbox (from extension FlaggedRevisions) while in source mode - https://phabricator.wikimedia.org/T151615#2872004 (10Schnark) Well, let's see what happens when NWE is enabled as beta feature and more... [10:05:35] 10MediaWiki-API, 10MediaWiki-Database, 10DBA, 05MW-1.29-release-notes, and 4 others: ApiQueryExtLinksUsage::run query has crazy limit - https://phabricator.wikimedia.org/T59176#2872005 (10jcrespo) [10:07:25] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2860935 (10Trizek-WMF) A challenge day: one day to have things done. [10:08:23] (03PS1) 10WMDE-leszek: Fix assigning void return value to a variable [core] - 10https://gerrit.wikimedia.org/r/327163 [10:12:58] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2872056 (10Mvolz) [10:13:41] (03CR) 10Phuedx: [] "Recheck." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327147 (owner: 10Phuedx) [10:21:03] (03CR) 10Jack Phoenix: [C: 032] Kill inline CSS [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326310 (https://phabricator.wikimedia.org/T147259) (owner: 10Jack Phoenix) [10:21:10] (03CR) 10jenkins-bot: [] Kill inline CSS [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326310 (https://phabricator.wikimedia.org/T147259) (owner: 10Jack Phoenix) [10:21:36] 10MediaWiki-extensions-Scribunto, 10Tabular-Data, 03Interactive-Sprint, 13Patch-For-Review: mw.ext.data.get() returns 0-indexed tables - https://phabricator.wikimedia.org/T152809#2860780 (10hashar) So from a quick discussion with Yurik. We should SWAT https://gerrit.wikimedia.org/r/#/c/326906/ , it has ba... [10:22:10] (03Merged) 10jenkins-bot: Kill inline CSS [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326310 (https://phabricator.wikimedia.org/T147259) (owner: 10Jack Phoenix) [10:23:03] (03PS1) 10Jack Phoenix: Make the animation faster so that it's less annoying [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/327165 [10:23:20] (03CR) 10Jack Phoenix: [C: 032] Make the animation faster so that it's less annoying [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/327165 (owner: 10Jack Phoenix) [10:23:24] (03CR) 10jenkins-bot: [] Make the animation faster so that it's less annoying [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/327165 (owner: 10Jack Phoenix) [10:24:15] (03Merged) 10jenkins-bot: Make the animation faster so that it's less annoying [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/327165 (owner: 10Jack Phoenix) [10:24:44] 10MediaWiki-extensions-Scribunto, 10Tabular-Data, 03Interactive-Sprint, 13Patch-For-Review: mw.ext.data.get() returns 0-indexed tables - https://phabricator.wikimedia.org/T152809#2872077 (10Yurik) don't worry if the table gets broken after the deployment - the module https://en.wikipedia.org/wiki/Module:Sa... [10:26:04] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Epic, 07Tracking: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230#2872080 (10Lydia_Pintscher) [10:26:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Verified: Sort statements within a statement group - https://phabricator.wikimedia.org/T54392#2872081 (10Lydia_Pintscher) [10:26:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Story, 07TestMe: [Story] show diffs for ordering changes - https://phabricator.wikimedia.org/T59918#2872078 (10Lydia_Pintscher) 05Open>03Invalid We are sticking to a global sort order so I think this is no longer relevant. [10:26:52] 10MiniInvite, 10Social-Tools: Remove inline styling from MiniInvite - https://phabricator.wikimedia.org/T147259#2872086 (10ashley) 05Open>03Resolved a:03ashley [10:26:54] 10BlogPage, 10Comments, 10FanBoxes, 10NewSignupPage, and 7 others: [EPIC] Remove inline styling from Social Tools extensions - https://phabricator.wikimedia.org/T87148#2872089 (10ashley) [10:27:07] 06Repository-Ownership-Requests: +2 for Fomafix in mediawiki/* - https://phabricator.wikimedia.org/T153177#2871869 (10Florian) I thought he already has +2 rights. Of course, he is a trusted developer and I always appreciate his reviews. Having him with +w rights would, in my opinion, be a benefit for all of us! :) [10:27:56] (03CR) 10Lokal Profil: [C: 032] Skip back sentence [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/314664 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [10:28:01] (03CR) 10jenkins-bot: [] Skip back sentence [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/314664 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [10:29:57] (03Merged) 10jenkins-bot: Skip back sentence [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/314664 (https://phabricator.wikimedia.org/T133687) (owner: 10Sebastian Berlin (WMSE)) [10:30:08] Niharika: Hey [10:30:17] Niharika: I'm doing this task https://codein.withgoogle.com/dashboard/task-instances/5900623927050240/ [10:30:36] Does the task apply only to extensions or can I change in medawiki core ? [10:31:06] 10MediaWiki-extensions-ContentTranslation: Restoration might fail in ContentTranslationLoader.prototype.restoreSection - https://phabricator.wikimedia.org/T153178#2872104 (10Aklapper) [10:32:28] Oops ! Stupid question. MediaWiki core has ->doEdit() functions replaced [10:33:21] (03CR) 10Mobrovac: [V: 032 C: 032] Added trace loggin to be able to do sampled logging (031 comment) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327045 (owner: 10Ppchelko) [10:33:26] (03CR) 10jenkins-bot: [] Added trace loggin to be able to do sampled logging [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327045 (owner: 10Ppchelko) [10:33:53] 10Wikispeech-Player, 06Wikispeech-WMSE, 07Story, 10Wikispeech (Phase 2): [Story] Support re-listening (Wikispeech) - https://phabricator.wikimedia.org/T122132#2872107 (10Sebastian_Berlin-WMSE) [10:33:56] 10Wikispeech-Player, 06Wikispeech-WMSE, 13Patch-For-Review, 10Wikispeech (Sprint 2016-11-30): Skip back in recitation (was: Re-listening to recitation) - https://phabricator.wikimedia.org/T133687#2872105 (10Sebastian_Berlin-WMSE) 05Open>03Resolved [10:35:28] 10Wikispeech-Player, 06Wikispeech-WMSE, 07Story, 10Wikispeech (Phase 2): [Story] Support re-listening (Wikispeech) - https://phabricator.wikimedia.org/T122132#1897499 (10Sebastian_Berlin-WMSE) [10:35:31] 10Wikispeech-Player, 06Wikispeech-WMSE, 13Patch-For-Review, 10Wikispeech (Sprint 2016-12-14): Skip back in recitation (was: Re-listening to recitation) - https://phabricator.wikimedia.org/T133687#2239395 (10Sebastian_Berlin-WMSE) 05Resolved>03Open Forgot that there were two patches for this one. [10:37:51] (03PS19) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:38:28] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:39:37] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Technical-Debt (RW-Tech-Debt): Finish rewriting instrumentation - https://phabricator.wikimedia.org/T152225#2842182 (10phuedx) [10:40:51] (03PS4) 10Jhernandez: Wire up saving enabled/disabled in settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 [10:42:39] (03CR) 10Jhernandez: [] "Should be complete now." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [10:42:59] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5: Use new article recommendation api - https://phabricator.wikimedia.org/T153187#2872122 (10santhosh) [10:43:31] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:44:27] 10MediaWiki-extensions-StopForumSpam, 10Security-Reviews, 06Support-and-Safety, 06WMF-Legal: Security and compliance with the Privacy Policy review of Extension:StopForumSpam to consider deployment on WMF wikis - https://phabricator.wikimedia.org/T125338#2872152 (10MarcoAurelio) Hi @Legoktm. Yes, I think i... [10:45:58] (03CR) 10Phuedx: [C: 04-1] "I few minor comments inline." (038 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [10:46:18] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5: Use new article recommendation api - https://phabricator.wikimedia.org/T153187#2872154 (10santhosh) p:05Triage>03Normal [10:50:15] (03PS1) 10Mobrovac: Update trending-edits to a0ccc3f [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327168 [10:51:26] (03PS2) 10Mobrovac: Update trending-edits to a0ccc3f [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327168 [10:52:40] (03PS3) 10Mobrovac: Update trending-edits to a0ccc3f [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327168 (https://phabricator.wikimedia.org/T153122) [10:53:07] (03CR) 10Mobrovac: [V: 032 C: 032] Update trending-edits to a0ccc3f [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327168 (https://phabricator.wikimedia.org/T153122) (owner: 10Mobrovac) [10:53:12] (03CR) 10jenkins-bot: [] Update trending-edits to a0ccc3f [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327168 (https://phabricator.wikimedia.org/T153122) (owner: 10Mobrovac) [10:56:02] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [10:56:44] 06Repository-Ownership-Requests: +2 for Fomafix in mediawiki/* - https://phabricator.wikimedia.org/T153177#2872166 (10Paladox) +1 [11:04:32] Hello my name is Muhammed Nagy [11:05:40] 07Design, 10Wikimedia-Etherpad, 07Easy: Fix up ep_mediawiki and deploy it to etherpad.wikimedia.org - https://phabricator.wikimedia.org/T49754#2872190 (10Lluis_tgn) OK, thanks for all guys. [11:07:33] 10MediaWiki-General-or-Unknown: img_auth.php: Improve extendability - https://phabricator.wikimedia.org/T153174#2872198 (10Osnard) Thank you for the hint. I probably will do so. But I wrote to mailinglists (`mediawiki-l`, `wikitech-l`) in the past and never got much reaction from there. [11:07:38] How do I replace new Article( $title, 0 ) with WikiPage::factory() ? WikiPage::factory doesn't have a 2nd parameter :O [11:13:06] (03PS1) 10Jhernandez: WIP: Sync enabled preview state to storage on change [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 [11:18:01] 10MediaWiki-extensions-MultiBoilerplate, 07Easy: Add MediaWiki:Multiboilerplate to the Admin Links page - https://phabricator.wikimedia.org/T35435#2872214 (10FreedomFighterSparrow) 05Open>03declined This is very old and I see no current interest, so I'm declining this. Anybody can reopen if interested. [11:18:07] 10MediaWiki-Interface, 07I18n, 07Tracking: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#2872216 (10FreedomFighterSparrow) [11:19:15] (03PS1) 10Jack Phoenix: New UserProfileGetProfileTop hook in UserProfilePage::getProfileTop() so that extensions like Challenge can add their own hooks to the social profile header [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327175 (https://phabricator.wikimedia.org/T152930) [11:20:27] (03CR) 10jenkins-bot: [V: 04-1] New UserProfileGetProfileTop hook in UserProfilePage::getProfileTop() so that extensions like Challenge can add their own hooks to the social profile header [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327175 (https://phabricator.wikimedia.org/T152930) (owner: 10Jack Phoenix) [11:23:45] (03PS20) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:24:03] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:27:50] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: in the CX template editor, link cards are not shown and links are not adapted - https://phabricator.wikimedia.org/T153189#2872230 (10Amire80) [11:29:02] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: in the CX template editor, link cards are not shown and links are not adapted - https://phabricator.wikimedia.org/T153189#2872242 (10Amire80) [11:29:19] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: in the CX template editor, link cards are not shown and links are not adapted - https://phabricator.wikimedia.org/T153189#2872230 (10Amire80) [11:29:35] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:29:56] subins2000: Hi, the task is for extensions only and it specifies which extensions need to be covered for that task to be complete. [11:30:29] Niharika: Okay, thanks :) [11:30:37] You're welcome. :) [11:34:25] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [11:44:23] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 2 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2872247 (10Pcoombe) Good news, I'm no longer seeing a banner at http... [11:49:54] (03CR) 10Jhernandez: [C: 032] Hygiene: Tidy up "core" acceptance tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326955 (owner: 10Phuedx) [11:50:00] (03CR) 10jenkins-bot: [] Hygiene: Tidy up "core" acceptance tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326955 (owner: 10Phuedx) [11:50:50] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove "I am on the ... page" step [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326956 (owner: 10Phuedx) [11:50:56] (03CR) 10jenkins-bot: [] Hygiene: Remove "I am on the ... page" step [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326956 (owner: 10Phuedx) [11:51:47] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove RL-related step (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326957 (owner: 10Phuedx) [11:51:53] (03CR) 10jenkins-bot: [] Hygiene: Remove RL-related step [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326957 (owner: 10Phuedx) [11:52:11] (03CR) 10Jhernandez: [C: 032] Tag previews acceptance tests with @integration [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326958 (owner: 10Phuedx) [11:52:14] (03Merged) 10jenkins-bot: Hygiene: Tidy up "core" acceptance tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326955 (owner: 10Phuedx) [11:52:17] (03Merged) 10jenkins-bot: Hygiene: Remove "I am on the ... page" step [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326956 (owner: 10Phuedx) [11:52:20] (03CR) 10jenkins-bot: [] Tag previews acceptance tests with @integration [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326958 (owner: 10Phuedx) [11:52:28] (03CR) 10Phuedx: [C: 04-1] "-1 for documenting your design choice, which AFAICT is a short-hand for storing the value in the settings part of the state tree." (033 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [11:52:44] (03CR) 10Jhernandez: [] "Should we add @integration on this ones here? Or as a follow up?" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 (owner: 10Phuedx) [11:53:14] (03Merged) 10jenkins-bot: Hygiene: Remove RL-related step [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326957 (owner: 10Phuedx) [11:54:13] (03Merged) 10jenkins-bot: Tag previews acceptance tests with @integration [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326958 (owner: 10Phuedx) [11:58:20] (03PS3) 10Paladox: Make bot ignore jenkins-bot v+2 again [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 [11:59:56] (03CR) 10Paladox: [] Make bot ignore jenkins-bot v+2 again (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 (owner: 10Paladox) [12:03:52] (03CR) 10Jack Phoenix: [V: 032 C: 032] SQL optimization [extensions/Comments] - 10https://gerrit.wikimedia.org/r/326404 (https://phabricator.wikimedia.org/T135367) (owner: 10Jack Phoenix) [12:04:31] 10Comments, 10Social-Tools, 07Performance: Potential query optimization on getComments - https://phabricator.wikimedia.org/T135367#2872256 (10ashley) 05Open>03Resolved a:03ashley [12:07:53] 10Wikispeech, 10Wikispeech-Lexicon, 06Wikispeech-STTS: More validation rules for Swedish - https://phabricator.wikimedia.org/T153190#2872260 (10HannaLindgren) [12:09:07] (03CR) 10Phuedx: [] "I'll tag 'em with @integration here." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 (owner: 10Phuedx) [12:10:29] (03CR) 10Paladox: [] "@MarkTraceur hi, I know you doint like me doing self merges but I would like to self merge this as it fixes jenkins keeps commenting on ir" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 (owner: 10Paladox) [12:10:48] (03CR) 10Paladox: [] "I can clear up the code later if you doint like it and think there's a better way." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 (owner: 10Paladox) [12:11:27] (03CR) 10Paladox: [C: 032] Make bot ignore jenkins-bot v+2 again [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 (owner: 10Paladox) [12:11:32] (03CR) 10jenkins-bot: [] Make bot ignore jenkins-bot v+2 again [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 (owner: 10Paladox) [12:12:03] (03Merged) 10jenkins-bot: Make bot ignore jenkins-bot v+2 again [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327152 (owner: 10Paladox) [12:14:07] 10Social-Tools, 10Video: Video should use HTML5 instead of Flash for YouTube videos - https://phabricator.wikimedia.org/T128996#2872273 (10ashley) 05Open>03Resolved a:03ashley [[https://gerrit.wikimedia.org/r/#/c/275271/|Gerrit changeset #275271]] was fixed and merged, thus this bug is resolved. [12:14:25] 10Social-Tools, 10Video: Video should accept modern-day YouTube embed code and be able to pull the video ID from there - https://phabricator.wikimedia.org/T128997#2872276 (10ashley) 05Open>03Resolved a:03ashley [[https://gerrit.wikimedia.org/r/#/c/275271/|Gerrit changeset #275271]] was fixed and merged,... [12:15:16] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2872279 (10Aklapper) If the connotation of the word "hack" is too codey, it's going to be workshops. Though "workshops" might imply commitment to //stay// at some... [12:17:16] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Clarify the access to editing mode when translating templates - https://phabricator.wikimedia.org/T150952#2872280 (10Pginer-WMF) Removing the "Design" tag. L... [12:26:16] 10Phabricator-Bot-Requests: Requesting a bot account for @MarcoAurelio - https://phabricator.wikimedia.org/T153191#2872284 (10MarcoAurelio) [12:39:38] 10Increasing-content-coverage: Use related_articles as default in GapFinder - https://phabricator.wikimedia.org/T153192#2872315 (10schana) [12:45:55] 10MediaWiki-extensions-General-or-Unknown, 06Community-Liaisons, 07Documentation, 07I18n, 15User-Johan: Create a searchable and shared glossary - https://phabricator.wikimedia.org/T150263#2872333 (10Psychoslave) Sure, but would such an approach be adopted this is not the form most users would consult the... [12:46:57] (03PS5) 10Jhernandez: Wire up saving enabled/disabled in settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 [12:47:00] (03PS2) 10Jhernandez: WIP: Sync enabled preview state to storage on change [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 [12:50:25] 06WMF-Internal-Tech: Automate or Simplify calculating Per-Diems - https://phabricator.wikimedia.org/T140819#2872336 (10Milimetric) A good update from @Abit: https://docs.google.com/a/wikimedia.org/spreadsheets/d/1HjLXIJ1CYyt_Wq5sH0VgT7wt3OMJnodutJoS9-JLWDY/edit?usp=sharing. [12:51:07] (03PS21) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:51:25] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [12:51:36] (03PS6) 10Jhernandez: Wire up saving enabled/disabled in settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 [12:51:39] (03PS3) 10Jhernandez: WIP: Sync enabled preview state to storage on change [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 [12:53:31] (03CR) 10Jhernandez: [] "Concerns addressed." (033 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [12:58:18] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:01:35] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [13:04:05] (03PS4) 10Jhernandez: Sync enabled preview state to storage on change [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 [13:17:35] 10Connected-Open-Heritage-Batch-uploads, 10Connected-Open-Heritage-Communication: Gather information from GLAMs - https://phabricator.wikimedia.org/T153095#2872360 (10Mattias_Ostmar-WMSE) @Jopparn Yes, I assume that we will start with an internal meeting where the people that actually has been involved in init... [13:18:12] (03PS1) 10Bartosz Dziewoński: mediawiki.page.watch: Avoid lego messages [core] - 10https://gerrit.wikimedia.org/r/327179 [13:18:21] ugh [13:19:03] wait [13:19:06] that's not a lego message [13:19:26] lego message name maybe [13:19:55] uh [13:19:59] that's true actually [13:20:09] i got my terms confused [13:20:20] Lego! [13:20:29] (03PS2) 10Bartosz Dziewoński: mediawiki.page.watch: Avoid dynamic message keys [core] - 10https://gerrit.wikimedia.org/r/327179 [13:20:51] (03CR) 10Legoktm: [C: 032] mediawiki.page.watch: Avoid dynamic message keys [core] - 10https://gerrit.wikimedia.org/r/327179 (owner: 10Bartosz Dziewoński) [13:33:07] (03Merged) 10jenkins-bot: mediawiki.page.watch: Avoid dynamic message keys [core] - 10https://gerrit.wikimedia.org/r/327179 (owner: 10Bartosz Dziewoński) [13:34:02] (03PS1) 10Bartosz Dziewoński: mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers [core] - 10https://gerrit.wikimedia.org/r/327183 [13:34:33] 06Wikispeech-STTS, 10Wikispeech-Synthesis, 10Wikispeech (Sprint 2016-11-30): Multiple requests to TTS server should not cause delay - https://phabricator.wikimedia.org/T143644#2872384 (10Sebastian_Berlin-WMSE) @HaraldBerthelsen: I would like to try running in threaded mode. How do you do that? [13:35:02] qchris, phabricator doesn't allow to create projects? [13:35:45] (03PS1) 10Esanders: build: Replace jshint/jscs with eslint [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/327184 [13:36:43] Krenair: At least for me, it does not allow it. When I go to: https://phabricator.wikimedia.org/diffusion/edit/form/default/?vcs=git [13:36:49] Phabricator fails with: [13:36:53] Unhandled Exception ("Exception") [13:36:56] This install is configured in cluster mode, but all available repository cluster services are closed to new allocations. At least one service must be open to allow new allocations to take place. [13:37:03] * Krenair sighs [13:37:11] qchris, got a ticket for this? [13:37:22] (03CR) 10Phuedx: [C: 031] "Thanks for writing those docs Jhernandez. I'll test this locally now." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [13:37:30] Nope. But I've got a sent email for this. [13:37:36] to who? [13:38:07] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-12-14): Simple gui for workflow cycle - https://phabricator.wikimedia.org/T143860#2872387 (10HannaLindgren) [13:38:21] mmodell. [13:38:21] (03PS1) 10Jhernandez: Update the settings enabled radio with the enabled state [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 [13:38:54] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-12-14): Enable installation of TTS-server for development - https://phabricator.wikimedia.org/T141462#2872389 (10HannaLindgren) [13:39:04] qchris, okay... I would prefer tasks be created for this stuff [13:39:24] adding him as a subscriber would ensure it ends up in his inbox [13:39:31] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-12-14): dbapi: clean up variable names on initialization after db search - https://phabricator.wikimedia.org/T153078#2872406 (10HannaLindgren) [13:39:40] 10Wikispeech-NLP, 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-12-14): Admin GUI for lexicon database - https://phabricator.wikimedia.org/T134754#2872407 (10HannaLindgren) [13:39:49] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-12-14): Caching on TTS server - https://phabricator.wikimedia.org/T151880#2872408 (10HannaLindgren) [13:40:24] (03PS2) 10Jhernandez: Update the settings enabled radio with the enabled state [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 [13:40:53] (03CR) 10Jhernandez: [] "PS2 fixes a jscs space error..." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [13:41:47] 10Phabricator-Bot-Requests: Requesting a bot account for @MarcoAurelio - https://phabricator.wikimedia.org/T153191#2872284 (10Krenair) (please excuse my phone, I think this is fine) [13:42:21] (03CR) 10Jhernandez: [] "Just to note I've locally QAd the change." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [13:43:18] 06Wikispeech-STTS, 10Wikispeech-Synthesis, 10Wikispeech (Sprint 2016-12-14): TTS server should handle special expressions - https://phabricator.wikimedia.org/T148635#2872433 (10HannaLindgren) [13:44:13] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/327184 (owner: 10Esanders) [13:45:08] 10MobileFrontend, 06Reading-Web-Backlog: list items are not displaying correctly - https://phabricator.wikimedia.org/T153199#2872463 (10bmansurov) [13:45:16] 10MediaWiki-Database, 05MW-1.28-release-notes, 13Patch-For-Review, 07Schema-change: change_tag doesn't have a primary key - https://phabricator.wikimedia.org/T123225#2872475 (10TTO) 05Open>03Resolved [13:45:19] 10MediaWiki-Database, 10DBA, 13Patch-For-Review, 07PostgreSQL, 07Schema-change: Some tables lack unique or primary keys, may allow confusing duplicate data - https://phabricator.wikimedia.org/T17441#2872476 (10TTO) [13:45:26] 10Wikispeech-Lexicon, 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-12-14): More validation rules for Swedish - https://phabricator.wikimedia.org/T153190#2872477 (10HannaLindgren) [13:46:19] 10MobileFrontend, 06Reading-Web-Backlog: list items are not displaying correctly on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T153199#2872479 (10bmansurov) [13:46:49] 10MobileFrontend, 06Reading-Web-Backlog: list items are not displaying correctly on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T153199#2872463 (10bmansurov) [13:53:02] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, and 3 others: Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2872487 (10bmansurov) [13:54:03] (03CR) 10Jhernandez: [C: 04-1] "I've posted a question about the defaults and when the preference shows up and it's default state." (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [13:54:30] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, and 2 others: Feature flag font-changer - https://phabricator.wikimedia.org/T148193#2872488 (10bmansurov) [13:54:59] (03CR) 10Jhernandez: [C: 04-1] "Should the option be used somewhere to actually enable or disable popups?" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [13:55:46] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2872489 (10Mvolz) [13:56:28] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 07Performance, and 2 others: FOUC in section "Recently featured" on mobile Main Page - https://phabricator.wikimedia.org/T131423#2872492 (10bmansurov) [13:56:55] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 13Patch-For-Review, and 3 others: 3rd parties shouldn't be subjected to hacks.less - https://phabricator.wikimedia.org/T94102#2872493 (10bmansurov) [13:59:35] 10MobileFrontend, 06Reading-Web-Backlog: List items are not displaying correctly on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T153199#2872463 (10bmansurov) [14:02:08] 06Wikispeech-STTS, 10Wikispeech-Synthesis, 10Wikispeech (Sprint 2016-12-14): Multiple requests to TTS server should not cause delay - https://phabricator.wikimedia.org/T143644#2872505 (10HaraldBerthelsen) Oh, I should have said: the latest version in git (and the demo server) uses threaded mode. If you want... [14:03:22] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2872507 (10bmansurov) @Nirzar, what do you think? Should the last modified bar in the footer display information about the page or the current revision that's being viewed? [14:04:44] (03PS4) 10Mholloway: Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) [14:05:00] (03PS5) 10Mholloway: Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) [14:05:35] (03CR) 10Mholloway: [] Reinstate manual blacklist (033 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [14:07:08] (03CR) 10Mholloway: [] Reinstate manual blacklist (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [14:07:46] 10PageImages, 06Reading-Web-Backlog: Page images API doesn't return an image when the image is an imagemap - https://phabricator.wikimedia.org/T152798#2872515 (10bmansurov) @Jdlrobson, what needs clarification? [14:09:22] 10MobileFrontend, 06Reading-Web-Backlog: Mobile edit page shows different content than desktop edit/visual editor - https://phabricator.wikimedia.org/T152058#2872516 (10bmansurov) @Nirzar, what do you say? [14:12:51] 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2872526 (10PratyyaGhosh) [14:13:54] 10MediaWiki-API, 10MediaWiki-Database, 10DBA, 05MW-1.29-release-notes, and 4 others: ApiQueryExtLinksUsage::run query has crazy limit - https://phabricator.wikimedia.org/T59176#2872527 (10Anomie) [14:16:31] (03CR) 10Seb35: "Thanks to you!" [core] - 10https://gerrit.wikimedia.org/r/326363 (https://phabricator.wikimedia.org/T152923) (owner: 10Seb35) [14:16:44] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327191 [14:17:57] 10MediaWiki-extensions-RelatedSites, 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 07Community-consensus-needed, 07Technical-Debt: De-deploy the RelatedSites extension - https://phabricator.wikimedia.org/T128326#2872528 (10bmansurov) cc @Moushira [14:19:56] 10MobileFrontend, 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 07Easy, 07Technical-Debt (RW-Tech-Debt): Hygiene: Clean up configuration variables (mobile) - https://phabricator.wikimedia.org/T147092#2872530 (10bmansurov) 05Open>03Resolved a:03bmansurov Given the conversation above about the sa... [14:20:37] 10MobileFrontend, 06Reading-Web-Backlog: Mobile edit page shows different content than desktop edit/visual editor - https://phabricator.wikimedia.org/T152058#2872533 (10pmiazga) [14:21:09] 10MobileFrontend, 06Reading-Web-Backlog: Mobile edit page shows different content than desktop edit/visual editor - https://phabricator.wikimedia.org/T152058#2836809 (10pmiazga) [14:23:48] 10MobileFrontend, 06Reading-Web-Backlog: Oversized fonts on Lumia 950 - https://phabricator.wikimedia.org/T148552#2726033 (10bmansurov) @Vituzzu ping ^? [14:23:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 15User-Daniel, 03Wikidata-Sprint-2016-11-15: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2872538 (10Ladsgroup) [14:24:14] 10MediaWiki-General-or-Unknown, 07Tracking: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking) - https://phabricator.wikimedia.org/T41480#2872543 (10Anomie) [14:24:17] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Invalid parameter for message "api-help-permissions-granted-to" - https://phabricator.wikimedia.org/T152603#2872542 (10Anomie) 05Open>03Resolved [14:24:47] 10MediaWiki-extensions-ZeroBanner, 06Reading-Web-Backlog, 06Zero: Add Zero banners to non Wikipedia mobile project pages - https://phabricator.wikimedia.org/T122625#1909185 (10bmansurov) @DFoy, ping ^? [14:25:22] (03Draft2) 10Aftab: Fixing mediawiki's য় problem [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) [14:27:46] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327191 (owner: 10Dbrant) [14:29:42] (03PS1) 10Phuedx: Redefine when Page Previews are enabled [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327194 (https://phabricator.wikimedia.org/T152687) [14:29:45] (03PS1) 10Phuedx: Hygiene: Remove experiment-related code [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327195 (https://phabricator.wikimedia.org/T152687) [14:29:48] (03PS1) 10Phuedx: Hygiene: Make mw.popups#isEnabled return boolean [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327196 (https://phabricator.wikimedia.org/T152687) [14:30:50] 10MobileFrontend, 06Reading-Web-Backlog: Make toasts tappable links - https://phabricator.wikimedia.org/T150189#2872561 (10bmansurov) Don't toast messages, by definition, not require an input from the user? @Nirzar what do you think? [14:31:48] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, and 2 others: insource (regex) search on en.wp's Special:Search does not work - https://phabricator.wikimedia.org/T152895#2872562 (10dcausse) The fix https://gerrit.wikimedia.org/r/#/c/326464/ does not seem to solve the iss... [14:31:51] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327191 (owner: 10Dbrant) [14:32:40] 10Hovercards, 06Reading-Web-Backlog: Intermittent schema exception in reading-web-staging in Chrome - https://phabricator.wikimedia.org/T146031#2872564 (10bmansurov) 05stalled>03declined Haven't heard anything about these failures in over a month. [14:34:54] 10Increasing-content-coverage: Use related_articles as default in GapFinder - https://phabricator.wikimedia.org/T153192#2872315 (10schana) a:03schana [14:35:23] (03PS1) 10Nschaaf: Use related_articles search in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327197 (https://phabricator.wikimedia.org/T153192) [14:37:27] (03PS3) 10Aftab: Fixing mediawiki's য় problem [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) [14:38:38] (03PS10) 10Sbisson: Special:RC filter: userExpLevel [core] - 10https://gerrit.wikimedia.org/r/321744 (https://phabricator.wikimedia.org/T149637) [14:38:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 15User-Daniel, 03Wikidata-Sprint-2016-11-15: Allow the EditEntity API module to work with all types of entities - https://phabricator.wikimedia.org/T152491#2872574 (10Ladsgroup) Okay, I checked a little, It seems we have two options: - Register a hook:... [14:41:20] (03CR) 10Mholloway: Demo: refactor description edit tutorial page views (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [14:41:37] (03PS2) 10Nschaaf: Use related_articles search in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327197 (https://phabricator.wikimedia.org/T153192) [14:44:13] (03CR) 10Nschaaf: [C: 032] Use related_articles search in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327197 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [14:45:44] 10Increasing-content-coverage: Use related_articles as default in GapFinder - https://phabricator.wikimedia.org/T153192#2872315 (10schana) [14:46:01] (03CR) 10Esanders: [] "Unit test failures due to wrong number locale setting..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/327184 (owner: 10Esanders) [14:46:06] (03CR) 10Esanders: [] "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/327184 (owner: 10Esanders) [14:46:32] (03Merged) 10jenkins-bot: Use related_articles search in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327197 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [14:49:23] (03PS1) 10Nschaaf: Increment version to 0.1.1 [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327200 (https://phabricator.wikimedia.org/T153192) [14:49:40] (03PS1) 10Robert Vogel: BSAvatars: Fixed blank profile image issue [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/327201 [14:50:04] (03CR) 10Nschaaf: [C: 032] Increment version to 0.1.1 [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327200 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [14:51:07] (03Merged) 10jenkins-bot: Increment version to 0.1.1 [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327200 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [14:54:46] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/327184 (owner: 10Esanders) [14:59:08] 10Phabricator: Phabricator workboard layout breaks with too many sidebar links - https://phabricator.wikimedia.org/T152143#2872603 (10jhobs) My thinking was that from a design perspective, making the sidebar scrollable is far preferential to being able to scroll past the bottom of the workboard. [15:01:47] (03CR) 10Jhobs: [C: 031] Update Reading Web roles [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [15:02:17] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2872606 (10ThatAndromeda) [15:02:19] 10The-Wikipedia-Library: Add next parameters to ToURequired mixin - https://phabricator.wikimedia.org/T147470#2872605 (10ThatAndromeda) 05Open>03Resolved [15:02:29] (03PS3) 10Zppix: Adding ##zppix-wikipedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327121 [15:05:23] (03PS1) 10Nschaaf: Fix valid search test in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327203 (https://phabricator.wikimedia.org/T153192) [15:05:34] (03CR) 10Nschaaf: [C: 032] Fix valid search test in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327203 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [15:06:34] (03Merged) 10jenkins-bot: Fix valid search test in GapFinder [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/327203 (https://phabricator.wikimedia.org/T153192) (owner: 10Nschaaf) [15:07:40] 06Wikipedia-Android-App-Backlog, 05Release: Build, test, and publish 2.1.184-2016-12-14 beta - https://phabricator.wikimedia.org/T153201#2872609 (10Dbrant) [15:07:51] 05Release, 06Wikipedia-Android-App-Backlog (Kanban): Build, test, and publish 2.1.184-2016-12-14 beta - https://phabricator.wikimedia.org/T153201#2872623 (10Dbrant) [15:09:03] (03CR) 10Jhobs: Hygiene: Organize reducers (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326919 (owner: 10Phuedx) [15:10:04] (03PS1) 10ItSpiderman: added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/327205 [15:10:10] (03PS1) 10WMDE-leszek: Document type of LogEntry::isPatrollable property [core] - 10https://gerrit.wikimedia.org/r/327206 [15:12:34] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, and 3 others: Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2872638 (10ovasileva) @bmansurov - I agree, let's enable it. Could we do this here or under a separate card? [15:13:20] (03PS2) 10ItSpiderman: added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/327205 [15:14:06] (03PS6) 10Mholloway: Hygiene: Separate Activity classes into themed and unthemed variants [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 [15:14:14] (03CR) 10Mholloway: [] Hygiene: Separate Activity classes into themed and unthemed variants (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [15:15:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Separate Activity classes into themed and unthemed variants [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [15:15:33] (03PS1) 10Robert Vogel: [WiP] Initial commit [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/327207 [15:16:21] (03CR) 10Anomie: [C: 032] API: Expose wfIsBadImage() in prop=imageinfo [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) (owner: 10Legoktm) [15:17:40] (03PS1) 10ItSpiderman: Updated scrollToTop with new icon class [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/327208 [15:19:35] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, and 3 others: Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2872655 (10bmansurov) [15:19:47] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, and 3 others: Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2709563 (10bmansurov) @ovasileva we can do it here. [15:22:34] 10Connected-Open-Heritage-Batch-uploads, 10Connected-Open-Heritage-Communication: Gather information from GLAMs - https://phabricator.wikimedia.org/T153095#2872661 (10Mattias_Ostmar-WMSE) Note to self: I'll start here https://outreach.wikimedia.org/wiki/GLAM [15:23:02] (03PS1) 10Mobrovac: Use the message's original TS for commit calculation. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327212 (https://phabricator.wikimedia.org/T153122) [15:23:02] 10Wikispeech, 10Wikispeech-Lexicon, 06Wikispeech-STTS: Extend validation rule sets - https://phabricator.wikimedia.org/T146453#2872665 (10HannaLindgren) p:05Triage>03Low [15:23:26] 10Wikispeech, 10Wikispeech-Lexicon, 06Wikispeech-STTS: Stress placement, syllables and syllabification - https://phabricator.wikimedia.org/T143983#2872668 (10HannaLindgren) p:05Triage>03Low [15:26:00] (03CR) 10DCausse: [] Calculate click data for top queries (033 comments) [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/317019 (https://phabricator.wikimedia.org/T149047) (owner: 10EBernhardson) [15:26:28] 10Connected-Open-Heritage-Batch-uploads, 10Connected-Open-Heritage-Communication: Gather information from GLAMs - https://phabricator.wikimedia.org/T153095#2872687 (10Jopparn) Start with some preparations around this if you get stuck with the Cyprus batch-upload, and then we can look at it together when I am b... [15:26:47] (03PS2) 10Mobrovac: Use the message's original TS for commit calculation [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327212 (https://phabricator.wikimedia.org/T153122) [15:27:15] (03CR) 10Mobrovac: [V: 032 C: 032] "Merging to see in action right away" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327212 (https://phabricator.wikimedia.org/T153122) (owner: 10Mobrovac) [15:29:09] (03PS1) 10Mobrovac: Update trending-edits to b15b8ce [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327213 [15:29:28] (03CR) 10Mobrovac: [V: 032 C: 032] Update trending-edits to b15b8ce [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/327213 (owner: 10Mobrovac) [15:30:34] (03CR) 10Robert Vogel: [C: 032] added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/327205 (owner: 10ItSpiderman) [15:30:41] (03PS1) 10Robert Vogel: added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 [15:30:52] (03CR) 10Robert Vogel: [C: 032] added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/327214 (owner: 10Robert Vogel) [15:31:06] (03CR) 10Robert Vogel: [C: 032] Updated scrollToTop with new icon class [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/327208 (owner: 10ItSpiderman) [15:31:11] (03CR) 10jenkins-bot: [V: 04-1] API: Expose wfIsBadImage() in prop=imageinfo [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) (owner: 10Legoktm) [15:31:19] (03PS1) 10Robert Vogel: Updated scrollToTop with new icon class [skins/BlueSpiceSkin] (REL1_27) - 10https://gerrit.wikimedia.org/r/327215 [15:31:24] (03CR) 10Hashar: "check experimental" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/327094 (owner: 10L10n-bot) [15:31:29] (03CR) 10Robert Vogel: [C: 032] Updated scrollToTop with new icon class [skins/BlueSpiceSkin] (REL1_27) - 10https://gerrit.wikimedia.org/r/327215 (owner: 10Robert Vogel) [15:32:03] (03CR) 10Hashar: "check experimental" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326919 (owner: 10Phuedx) [15:32:12] (03CR) 10Pmiazga: [C: 04-1] "I like the idea of nice registration, an HookManager that registers all hooks only when necessary." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317135 (owner: 10Phuedx) [15:34:32] (03Merged) 10jenkins-bot: added bs-arrow-o-up (used in go-to-top button) to bs icon set [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/327205 (owner: 10ItSpiderman) [15:36:43] (03CR) 10jenkins-bot: [V: 04-1] Updated scrollToTop with new icon class [skins/BlueSpiceSkin] (REL1_27) - 10https://gerrit.wikimedia.org/r/327215 (owner: 10Robert Vogel) [15:39:34] (03Merged) 10jenkins-bot: Updated scrollToTop with new icon class [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/327208 (owner: 10ItSpiderman) [15:41:33] (03CR) 10jenkins-bot: [V: 04-1] Updated scrollToTop with new icon class [skins/BlueSpiceSkin] (REL1_27) - 10https://gerrit.wikimedia.org/r/327215 (owner: 10Robert Vogel) [15:42:12] 10Wikispeech, 10Wikispeech-Lexicon, 06Wikispeech-STTS: validation.Rule should have accept/reject examples - https://phabricator.wikimedia.org/T138487#2872711 (10HannaLindgren) [15:43:17] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: Investigate Improvements and Confidence Measures for TextCat Language Detection - https://phabricator.wikimedia.org/T140289#2872713 (10TJones) [15:43:22] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:44:22] (03PS1) 10Mobrovac: Minor: use msg.meta.topic instead of parsing it out from kafkaMessage [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327217 [15:44:39] 10PageImages, 06Reading-Web-Backlog: Page images API doesn't return an image when the image is an imagemap - https://phabricator.wikimedia.org/T152798#2872717 (10Jdlrobson) Should it? If an image map is used in an article is it not used to make certain areas clickable? Would that translate well to a page image... [15:45:09] (03CR) 10Jhobs: [C: 04-1] "Couple minors in settingsDialog.js. The -1 only pertains to the comment about `getSelectedSetting`." (033 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [15:46:43] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327087 (owner: 10L10n-bot) [15:49:12] 10Connected-Open-Heritage-Events: Organize an internal event at Världskulturmuseerna to prepare for batch-upload - https://phabricator.wikimedia.org/T151618#2872722 (10Mattias_Ostmar-WMSE) [15:49:14] 10Connected-Open-Heritage-Events: Follow-up on possible new collections from Världskulturmuseer - https://phabricator.wikimedia.org/T151619#2872719 (10Mattias_Ostmar-WMSE) 05Open>03Resolved a:05Mattias_Ostmar-WMSE>03None [15:50:05] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:51:39] Hello [15:52:11] (03CR) 10DCausse: [] Calculate click data for top queries (031 comment) [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/317019 (https://phabricator.wikimedia.org/T149047) (owner: 10EBernhardson) [15:53:01] i am a junior software developer [15:53:15] i am 16 year old [15:53:30] 10MediaWiki-Uploading, 06Multimedia: Update mediawiki.Upload.BookletLayout.js for recent API error message changes - https://phabricator.wikimedia.org/T153200#2872726 (10matmarex) [15:53:39] hello [15:55:26] (03PS7) 10Mholloway: Hygiene: Separate Activity classes into themed and unthemed variants [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 [15:56:25] (03PS22) 10Zfilipin: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:57:07] (03CR) 10Zfilipin: [] "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [15:57:11] (03CR) 10Anomie: [] "Stupid flaky qunit test..." [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) (owner: 10Legoktm) [15:57:19] (03CR) 10Anomie: [C: 032] API: Expose wfIsBadImage() in prop=imageinfo [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) (owner: 10Legoktm) [16:01:48] 10MediaWiki-Internationalization, 07I18n: On multilinguage instances like beta.wikiversity, one should be able to define the main language for the content of the current page - https://phabricator.wikimedia.org/T149595#2872762 (10jcrespo) [16:01:54] 10MediaWiki-Internationalization, 07I18n, 07Schema-change: Specify default language on a per-page basis - https://phabricator.wikimedia.org/T11360#2872764 (10jcrespo) [16:01:59] 04(no projects): Add user_agent_map field to EventCapsule - https://phabricator.wikimedia.org/T153207#2872765 (10Tbayer) [16:02:59] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Create landing page for SMVK on Wikimedia Commons - https://phabricator.wikimedia.org/T144349#2872780 (10Mattias_Ostmar-WMSE) a:03Mattias_Ostmar-WMSE [16:03:28] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [16:04:26] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Upload a minor selection of images (~10 files) for SMVK-Mexiko - https://phabricator.wikimedia.org/T144358#2872781 (10Mattias_Ostmar-WMSE) [16:05:05] (03PS1) 10WMDE-leszek: Fix parameter type docs [core] - 10https://gerrit.wikimedia.org/r/327221 [16:07:56] (03Merged) 10jenkins-bot: API: Expose wfIsBadImage() in prop=imageinfo [core] - 10https://gerrit.wikimedia.org/r/316249 (https://phabricator.wikimedia.org/T148343) (owner: 10Legoktm) [16:12:07] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Disable Page Previews for anons - https://phabricator.wikimedia.org/T152687#2872794 (10ovasileva) [16:12:42] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Disable Page Previews for anons - https://phabricator.wikimedia.org/T152687#2872797 (10bmansurov) [16:12:45] 10MobileFrontend, 06Reading-Web-Backlog: Make toasts tappable links - https://phabricator.wikimedia.org/T150189#2872798 (10Nirzar) @bmansurov not necessarily https://material.google.com/components/snackbars-toasts.html#snackbars-toasts-usage section 0-1 actions, not dismiss or cancel [16:13:57] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [16:17:32] (03PS1) 10Fjalapeno: Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) [16:18:01] 10MobileFrontend, 06Reading-Web-Backlog: 4 hours: Warning: Invalid state error in MobileFormatter - https://phabricator.wikimedia.org/T151838#2872817 (10bmansurov) [16:18:15] 10MobileFrontend, 06Reading-Web-Backlog: 4 hours: Warning: Invalid state error in MobileFormatter - https://phabricator.wikimedia.org/T151838#2872820 (10ovasileva) p:05High>03Normal [16:18:57] (03CR) 10Hashar: "Was causing Qunit tests to fail on RevisionSlider: T153121" [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [16:18:59] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 07Easy, 07Need-volunteer: Deleting a Wikipedia link with Backspace key causes deleting another links - https://phabricator.wikimedia.org/T153204#2872823 (10thiemowmde) p:05Triage>03Normal [16:19:33] 06Wikipedia-Android-App-Backlog, 07Technical-Debt: Always request an edit token before page edit - https://phabricator.wikimedia.org/T153104#2872843 (10Dbrant) [16:19:42] (03CR) 10Fjalapeno: [] "Dmitri - please double check the content of the the android announcement!" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [16:19:56] (03CR) 10jenkins-bot: [V: 04-1] Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [16:21:09] (03CR) 10Fjalapeno: [] "bearnD: how do I get rid of this issue? This is just how long the string is" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [16:24:21] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2688614 (10jhobs) @bmansurov When you updated the schema, I noticed you added `pageVisib... [16:26:21] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2872859 (10bmansurov) @Jhobs I think that's an overkill personally. I'd like to keep it... [16:26:43] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Upload a minor selection of images (~10 files) for SMVK-Mexiko - https://phabricator.wikimedia.org/T144358#2872860 (10Mattias_Ostmar-WMSE) Created new [Category:Ola_Apenes](https://commons.wikimedia.org/wiki/Category:Ola_Apenes) [16:27:49] 10Android-app-Bugs, 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: In the news card item text is truncated on the side - https://phabricator.wikimedia.org/T152975#2872863 (10Niedzielski) [16:29:10] (03CR) 10Jhobs: [C: 04-1] "A reducer will also need to be created within the EventLogging reducers." (035 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [16:29:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I also don't have ICU 52 locally to test, but I thought about this for a bit more and I think it's actually wrong. (It's also definitely w" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/302096 (https://phabricator.wikimedia.org/T139110) (owner: 10Ladsgroup) [16:30:04] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2872869 (10Nemo_bis) [16:30:11] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2872885 (10Nemo_bis) p:05Triage>03Normal [16:30:19] 06Wikipedia-Android-App-Backlog: Get properly localized error messages from the MediaWiki API - https://phabricator.wikimedia.org/T152689#2872889 (10Dbrant) [16:30:40] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2872869 (10Nemo_bis) [16:31:47] 10Android-app-feature-Feeds, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Today’s Featured Article and In the News is not shown in Hungarian mobile app - https://phabricator.wikimedia.org/T152284#2872895 (10bearND) [16:31:54] (03PS2) 10Fjalapeno: Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) [16:33:55] 10MediaWiki-Unit-tests, 05MW-1.29-release-notes, 13Patch-For-Review, 07Technical-Debt, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): testMediaWikiTestCaseParentSetupCalled does not have @covers annotations - https://phabricator.wikimedia.org/T152923#2872903 (10Seb35) 05Open>03Resolved Reviewed and merged b... [16:34:31] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2872905 (10Marostegui) I have extended this just in case and in order to avoid bothering our US folks with a page. [16:35:34] (03CR) 10Fomafix: [C: 031] mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers [core] - 10https://gerrit.wikimedia.org/r/327183 (owner: 10Bartosz Dziewoński) [16:37:33] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Upload a minor selection of images (~10 files) for SMVK-Mexiko - https://phabricator.wikimedia.org/T144358#2872906 (10Mattias_Ostmar-WMSE) @lokal_profil I can't figure out 'remove double space before
in depicted place'. There is no
ther... [16:41:30] 10Android-app-feature-Feeds, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Today’s Featured Article and In the News is not shown in Hungarian mobile app - https://phabricator.wikimedia.org/T152284#2872929 (10Fjalapeno) @Tacsipacsi You are correct, we will need templates / main pages updated acro... [16:41:37] (03CR) 10Jhobs: [C: 031] "Still needs @integration obviously, as mentioned in comments, but +1 because there doesn't seem to be anything wrong with these tests. Nic" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 (owner: 10Phuedx) [16:41:58] 04(no projects): Coordinate links should remember user preference for the mapping service and not ask to choose every time - https://phabricator.wikimedia.org/T153211#2872930 (10Yurivict) [16:43:07] 04(no projects): Coordinate links should remember user preference for the mapping service and not ask to choose every time - https://phabricator.wikimedia.org/T153211#2872942 (10Yurivict) [16:45:16] 04(no projects): Coordinate links should remember user preference for the mapping service and not ask to choose every time - https://phabricator.wikimedia.org/T153211#2872947 (10Aklapper) Please provide steps to reproduce where to "click on the coordinate". You're requesting some Wikipedia (or such?) site to p... [16:47:24] (03CR) 10Bmansurov: [] WIP: Add reading depth (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [16:47:47] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2872954 (10ThatAndromeda) [16:47:50] 10The-Wikipedia-Library: Make the 'Apply for access' button larger - https://phabricator.wikimedia.org/T150002#2872953 (10ThatAndromeda) 05Open>03Resolved [16:47:57] 10The-Wikipedia-Library: Include partner's logo image on the signup page - https://phabricator.wikimedia.org/T150001#2872955 (10ThatAndromeda) 05Open>03Resolved [16:47:59] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2692820 (10ThatAndromeda) [16:50:14] (03PS3) 10Fjalapeno: Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) [16:52:11] 10MobileFrontend, 06Reading-Web-Backlog: Make toasts tappable links - https://phabricator.wikimedia.org/T150189#2872965 (10ovasileva) @Nirzar - should we style the article name as a link then? [16:53:15] (03CR) 10Mholloway: [] "@bearND, following up on standup, PS5 contains all intended changes." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [16:54:19] (03CR) 10Dbrant: [C: 04-1] Add EN Donation Announcements (033 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [16:57:17] (03CR) 10Jhobs: [C: 04-1] "I believe we're overthinking it." (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327174 (owner: 10Jhernandez) [16:57:32] (03CR) 10Dbrant: [C: 04-1] "lol Shoot, all of my comments are meant for the Android announcement, not iOS ;)" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [16:57:39] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2872968 (10Nemo_bis) [16:58:18] (03CR) 10Arlolra: [C: 032] Add missing semicolon to &mdash [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327153 (owner: 10Legoktm) [16:59:27] (03Merged) 10jenkins-bot: Add missing semicolon to &mdash [extensions/Linter] - 10https://gerrit.wikimedia.org/r/327153 (owner: 10Legoktm) [17:01:04] (03PS23) 10Etonkovidova: WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [17:01:10] (03CR) 10EBernhardson: [C: 032] Fix assigning void return value to a variable [core] - 10https://gerrit.wikimedia.org/r/327163 (owner: 10WMDE-leszek) [17:02:12] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2872869 (10MarcoAurelio) What is that setting suposed to do? [17:03:15] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2873011 (10bmansurov) @ovasileva logging happens at these seconds: 1, 2, 3, 5, 8, 13, 21... [17:05:55] 06Community-Liaisons (Oct-Dec-2016), 06Developer-Relations (Oct-Dec-2016): Technical Collaboration quarterly check in for January - March 2017 - https://phabricator.wikimedia.org/T150658#2873013 (10Johan) [17:06:29] 06Community-Liaisons (Oct-Dec-2016), 06Developer-Relations (Oct-Dec-2016): Technical Collaboration quarterly check in for January – March 2017 - https://phabricator.wikimedia.org/T150658#2792447 (10Johan) [17:07:03] 06Editing-Analysis: Define guidelines for helping teams with metrics - https://phabricator.wikimedia.org/T151912#2873022 (10Neil_P._Quinn_WMF) 05Open>03Resolved Just checked with Trevor, and he doesn't need anything more from us on this. [17:07:16] 10Phabricator (Upstream), 07Upstream: Phabricator workboard layout can be scrolled to bottom (exposing empty area) with many sidebar links - https://phabricator.wikimedia.org/T152143#2873025 (10Aklapper) 05stalled>03Open [17:07:28] 10Phabricator (Upstream), 07Upstream: Phabricator workboard layout can be scrolled to bottom (exposing empty area) with many sidebar links - https://phabricator.wikimedia.org/T152143#2873029 (10Aklapper) p:05Triage>03Lowest [17:08:15] 10Phabricator-Bot-Requests: Requesting a bot account for @MarcoAurelio - https://phabricator.wikimedia.org/T153191#2873030 (10MarcoAurelio) In order not to break anything, please let me know if the account should either be created by the admins, or via LDAP myself or via OAuth myself. [17:09:26] (03Merged) 10jenkins-bot: Fix assigning void return value to a variable [core] - 10https://gerrit.wikimedia.org/r/327163 (owner: 10WMDE-leszek) [17:10:27] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [17:14:18] (03CR) 10Mholloway: [C: 04-1] "Same as before on my machine, even with preq 0.5.1." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND) [17:14:43] 10MediaWiki-History-or-Diffs, 06Performance-Team, 07Availability, 07Notice, and 2 others: Make rollback use POST instead of GET (use AJAX in GUI) - https://phabricator.wikimedia.org/T88044#1683845 (10Tnegrin) I will set up a meeting with designers and move this forward. [17:15:46] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search: Allow searching by file license on Commons - https://phabricator.wikimedia.org/T152855#2873042 (10Aklapper) Ah.... sorry, true that. I'm wondering how to make people like me click the "Help" link and realize "Help" also means "Advanced op... [17:16:07] (03CR) 10Jhobs: [C: 04-1] "The first comment doesn't necessarily contribute to the -1, but I think it's the better way of handling the change." (033 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327185 (owner: 10Jhernandez) [17:16:15] 10MediaWiki-Vagrant, 10Citoid, 06Services, 10VisualEditor: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214#2873043 (10Mvolz) [17:17:55] (03CR) 10Mholloway: [C: 04-1] "Ah, reading over the commit message, I see this is expecting an environment variable to be set. It would have to be set here[1] to pass t" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND) [17:19:52] 10MediaWiki-extensions-Linter, 10Parsoid, 10VisualEditor: Improve detection of missing quotes in HTML tag attributes - https://phabricator.wikimedia.org/T153203#2873074 (10Arlolra) [17:20:56] 10MediaWiki-Interface, 10MediaWiki-User-blocking: Bring the CIDR calculator to MediaWiki core - https://phabricator.wikimedia.org/T152850#2873076 (10Aklapper) Should T28751 be a parent task? [17:22:11] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2860935 (10Whatamidoing-WMF) "Hack Mode Day" (http://www.catb.org/jargon/html/H/hack-mode.html – it implies focusing on what you're doing, whether that's code or... [17:23:41] (03CR) 10Mholloway: [C: 04-1] "That being said... does it make sense to increase the timeout just for Docker runs, given that our reason for using Docker is to simulate " [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND) [17:24:34] 04(no projects): watroles is misleading and should be disabled - https://phabricator.wikimedia.org/T153216#2873080 (10Andrew) [17:25:37] 10MediaWiki-extensions-General-or-Unknown, 07WorkType-NewFunctionality: Way to bring back user preferences that were removed from core - https://phabricator.wikimedia.org/T42346#2873091 (10Aklapper) Are there //any// examples of what's being requested in this task actually? The summary talks about "user prefe... [17:26:43] (03PS1) 10Ljonka: Add exception groups variable and handler [extensions/Contributors] (REL1_27) - 10https://gerrit.wikimedia.org/r/327236 [17:27:08] 10BlueSpice, 07Easy, 07I18n: [[MediaWiki:Notification-bs-pageassignments-page-delete-body/pt]] cannot be used for GENDER - https://phabricator.wikimedia.org/T151595#2873092 (10Aklapper) @Harjotsingh: Any. :) test.wikipedia.org for example. Please [[ https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_ha... [17:27:44] 10MediaWiki-Vagrant, 10Citoid, 06Services, 10VisualEditor: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214#2873095 (10Mvolz) [17:28:19] (03Abandoned) 10Mholloway: WIP: Log missing @Required fields remotely when unmarshalling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/319899 (https://phabricator.wikimedia.org/T145075) (owner: 10Mholloway) [17:28:42] 04(no projects): watroles is misleading and should be disabled - https://phabricator.wikimedia.org/T153216#2873097 (10Aklapper) Hi @Andrew. Please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task to allow others to find this task when searchin... [17:29:06] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Extract search result rendering from SpecialSearch - https://phabricator.wikimedia.org/T150390#2873102 (10Deskana) @lindseyanne @dr0ptp4kt Is there anyone in Editing or Reading that's suitably versed in core t... [17:31:35] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Cleanup execution flow through Special:Search - https://phabricator.wikimedia.org/T150393#2873110 (10Deskana) @lindseyanne @dr0ptp4kt Is there anyone in Editing or Reading that's suitably versed in core that c... [17:32:08] (03CR) 10Jhobs: [C: 04-1] "Few things on top of what's been said." (036 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [17:32:25] (03CR) 10Aaron Schulz: [C: 032] Fix small typos in includes/lib/lockManager/LockManager.php [core] - 10https://gerrit.wikimedia.org/r/327154 (owner: 10Ladsgroup) [17:32:52] 10The-Wikipedia-Library: Require users to have an email address linked to their account - https://phabricator.wikimedia.org/T151118#2873112 (10Samwalton9) I think they should be able to create accounts, but require email before being allowed to submit an application. [17:33:19] (03PS4) 10Fjalapeno: Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) [17:36:38] 10The-Wikipedia-Library: Non-terrible email address handling - https://phabricator.wikimedia.org/T147466#2873114 (10Samwalton9) I think it would make sense that users' emails follow their Wikimedia account email unless they explicitly change it in the platform, perhaps with a box that allows them to reset back t... [17:38:06] 10Wikimedia-Developer-Summit: Facilitate Wikidev'17 main topic "Artificial Intelligence to build and navigate content" - https://phabricator.wikimedia.org/T147708#2873116 (10Capt_Swing) [17:40:16] (03CR) 10Jhobs: [] Redefine when Page Previews are enabled (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327194 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [17:41:57] (03Merged) 10jenkins-bot: Fix small typos in includes/lib/lockManager/LockManager.php [core] - 10https://gerrit.wikimedia.org/r/327154 (owner: 10Ladsgroup) [17:43:04] (03CR) 10Dbrant: [C: 031] "looks good!" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [17:45:27] (03PS5) 10Fjalapeno: Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) [17:45:32] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Extract search result rendering from SpecialSearch - https://phabricator.wikimedia.org/T150390#2873137 (10dr0ptp4kt) I believe a number of Reading Web engineers have interfaced with search-related things at on... [17:46:19] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Cleanup execution flow through Special:Search - https://phabricator.wikimedia.org/T150393#2873139 (10dr0ptp4kt) I believe a number of Reading Web engineers have interfaced with search-related things at one poi... [17:46:41] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 05MW-1.29-release-notes, and 2 others: Spurious Amazon clicks / Banners on googleweblight.com - https://phabricator.wikimedia.org/T152602#2873141 (10Ejegg) Thanks! We're rolling out the patch to treat webli... [17:47:56] (03CR) 10Jhobs: [C: 032] "Woooooo! I love patches that remove things!" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327195 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [17:48:02] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Cleanup execution flow through Special:Search - https://phabricator.wikimedia.org/T150393#2873142 (10Deskana) >>! In T150393#2873139, @dr0ptp4kt wrote: > @deskana, with the freeze coming, is the urgency for re... [17:48:26] (03CR) 10Fjalapeno: [] "Dbrant - had to make an iOS specific change, but we are good now" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [17:48:41] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Extract search result rendering from SpecialSearch - https://phabricator.wikimedia.org/T150390#2873143 (10Deskana) >>! In T150390#2873137, @dr0ptp4kt wrote: > @deskana, with the freeze coming, is the urgency f... [17:48:44] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with Wikimedia color palette - https://phabricator.wikimedia.org/T153049#2867522 (10Volker_E) @Ladsgroup I'm not convinced by this change, as it lowers the focus on the 'yes' tabular data c... [17:49:13] (03CR) 10Dbrant: [C: 031] Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [17:50:49] (03CR) 10Jhobs: [] "Everything was done in this patch AFAICT except for actually making mw.popups#isEnabled return a boolean." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327196 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [17:51:11] (03CR) 10Jhobs: [] "Nevermind, I just saw the followup change." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327194 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [17:52:53] 10TPG-FY2016-17-Q2-Design-Collaboration, 06Community-Liaisons (Oct-Dec-2016): Seeking community liaison support for engaging WMF/broader community for validation of statement of purpose of design - https://phabricator.wikimedia.org/T144991#2873149 (10Awjrichards) @Qgil we are done! The CLs helped coordinate an... [17:53:07] 10TPG-FY2016-17-Q2-Design-Collaboration, 10TPG-Epics (Design Statement of Purpose (Phase 2 & 3)), 06Team-Practices (This-Week): Publish 'statement of purpose of design at the WMF' publicly - https://phabricator.wikimedia.org/T139999#2873151 (10Awjrichards) [17:53:25] (03CR) 10Jhobs: [] "Actually, there are still some usage instances that need to be updated too. I'm gonna go ahead and assume this was actually uploaded as a " [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327196 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [17:53:40] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2873154 (10kaldari) @Samwilson: Unlike Twinkle, PageTriage is only designed to facilitate new page patrolling, w... [17:57:06] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2873168 (10ovasileva) @bmansurov - I think we're good as is then. [17:57:47] (03CR) 10Mholloway: [C: 032] Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [17:59:46] (03Merged) 10jenkins-bot: Add EN Donation Announcements [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [18:03:15] 10Connected-Open-Heritage-New-data: Importing data from China for COH - https://phabricator.wikimedia.org/T153218#2873177 (10Lokal_Profil) [18:06:27] (03CR) 10Subramanya Sastry: [] "No, not to be abandoned. We had an RFC hearing around this, and the block figure image usage had approval, but inline image markup was sti" [core] - 10https://gerrit.wikimedia.org/r/196532 (https://phabricator.wikimedia.org/T51097) (owner: 10Prtksxna) [18:06:30] 10Connected-Open-Heritage-New-data: Importing data from China for COH - https://phabricator.wikimedia.org/T153218#2873189 (10Lokal_Profil) I believe Wikidata should support Chinese but maybe @Lea_Lacroix_WMDE knows or can point us to someone who knows? [18:07:11] (03CR) 10Mvolz: [] "We are, but I can't properly review it until T152398 is fixed. I am waiting to +2 it until then." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [18:08:04] 10Android-app-feature-Feeds, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Today’s Featured Article and In the News is not shown in Hungarian mobile app - https://phabricator.wikimedia.org/T152284#2843908 (10bearND) We have a task for adding Featured Article to other languages besides English I... [18:09:11] (03CR) 10Jhobs: [C: 04-1] WIP: Add reading depth (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [18:09:35] Hello [18:11:11] (03Restored) 10Niedzielski: Demo: refactor description edit tutorial page views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [18:11:17] (03Draft1) 10Paladox: Fix a no-op [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327248 [18:11:20] (03Draft2) 10Paladox: Fix a no-op [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327248 [18:11:25] (03PS3) 10Niedzielski: Demo: refactor description edit tutorial page views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) [18:11:46] (03CR) 10jenkins-bot: [V: 04-1] Demo: refactor description edit tutorial page views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [18:12:36] (03CR) 10Pmiazga: [C: 04-1] "Missing unit tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) (owner: 10Bmansurov) [18:15:00] 10Hovercards, 06Reading-Web-Backlog, 07Easy, 07Technical-Debt: SchemaPopupsSamplingRate config variable is badly named - https://phabricator.wikimedia.org/T146434#2873216 (10Aklapper) @McIntireEvan: Tell us if we should make this a #Google-Code-in-2016 task! :) [18:15:03] (03CR) 10Niedzielski: [] Demo: refactor description edit tutorial page views (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [18:15:11] (03Abandoned) 10Niedzielski: Demo: refactor description edit tutorial page views [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [18:15:31] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, and 3 others: Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2873218 (10Jdlrobson) [18:15:58] (03PS1) 10Mholloway: Update announcement schema and add validation check [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327249 [18:18:24] (03PS5) 10Florianschmidtwelzow: registration: Generalize CoreVersionChecker to VersionChecker [core] - 10https://gerrit.wikimedia.org/r/325118 (https://phabricator.wikimedia.org/T117277) [18:18:27] (03PS33) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [18:18:41] (03CR) 10Florianschmidtwelzow: [] "PS33 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [18:18:44] (03PS1) 10Ejegg: Add googleweblight to JS blacklist [core] - 10https://gerrit.wikimedia.org/r/327250 (https://phabricator.wikimedia.org/T152602) [18:19:28] (03Abandoned) 10Ejegg: Add googleweblight to JS blacklist [core] - 10https://gerrit.wikimedia.org/r/327250 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [18:20:07] 07Design, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-non-beta-2016, 07WorkType-Maintenance: There is no comfortable way to move to the next paragraph in Special:ContentTranslation using the keyboard, e.g. Enter - https://phabricator.wikimedia.org/T109056#2873247 (10Amire80) [18:21:22] 10MediaWiki-extensions-HitCounters, 07Regression: $wgHitcounterUpdateFreq prevents statistics from being recorded - https://phabricator.wikimedia.org/T135816#2873254 (10Aklapper) [18:21:32] 10MediaWiki-API, 10MediaWiki-Page-editing, 07Documentation: Document ApiStashEdit - https://phabricator.wikimedia.org/T113189#2873255 (10Aklapper) [18:21:45] (03PS1) 10Ejegg: Add googleweblight to JS blacklist [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327251 (https://phabricator.wikimedia.org/T152602) [18:22:56] 10TPG-FY2016-17-Q2-Design-Collaboration, 10TPG-Epics (Design Statement of Purpose (Phase 2 & 3)), 06Team-Practices (This-Week): Publish 'statement of purpose of design at the WMF' publicly - https://phabricator.wikimedia.org/T139999#2873257 (10Awjrichards) The finished statement has been [[ https://www.media... [18:22:58] (03CR) 10Niedzielski: [C: 032] Hygiene: Separate Activity classes into themed and unthemed variants (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [18:23:22] (03PS1) 10Ejegg: Add googleweblight to JS blacklist [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327252 (https://phabricator.wikimedia.org/T152602) [18:24:01] (03CR) 10Zppix: [C: 032] Fix a no-op [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327248 (owner: 10Paladox) [18:24:13] 06Discovery-Portal-Backlog, 06WMF-Communications: Wikimedia Foundation logo colour on Wikipedia.org is the wrong colour - https://phabricator.wikimedia.org/T153220#2873262 (10jrbs) [18:26:35] (03Merged) 10jenkins-bot: Hygiene: Separate Activity classes into themed and unthemed variants [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323177 (owner: 10Mholloway) [18:26:39] (03Merged) 10jenkins-bot: Fix a no-op [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327248 (owner: 10Paladox) [18:27:32] (03Abandoned) 10Mholloway: API: Add thumbwidth property parameter to restrict size by width only [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325066 (https://phabricator.wikimedia.org/T152254) (owner: 10Mholloway) [18:28:31] (03PS4) 10Zppix: Adding ##zppix-wikipedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/327121 [18:28:50] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with Wikimedia color palette - https://phabricator.wikimedia.org/T153049#2873285 (10Ladsgroup) From [[https://www.mediawiki.org/wiki/Extension:Interwiki#Setting_up_interlanguage_links | the... [18:29:05] (03PS1) 10Jack Phoenix: Change extension type to the more precise antispam from specialpage [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/327254 [18:29:50] 10Wikimedia-Extension-setup, 07Tracking: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T33235#2873292 (10Aklapper) [18:29:54] 10MediaWiki-extensions-Other: Review PDBHandler extension - https://phabricator.wikimedia.org/T46660#2873289 (10Aklapper) 05stalled>03declined Nobody knows where its codebase is; https://www.mediawiki.org/wiki/Special:ExtensionDistributor/PDBHandler says "No such extension "PDBHandler""; https://www.mediawik... [18:30:36] 10Connected-Open-Heritage-New-data: Australia for COH - https://phabricator.wikimedia.org/T153221#2873296 (10Lokal_Profil) [18:31:24] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, and 3 others: Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2873308 (10bmansurov) a:03bmansurov [18:31:30] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, and 2 others: Feature flag font-changer - https://phabricator.wikimedia.org/T148193#2873309 (10bmansurov) a:03bmansurov [18:31:43] 10MediaWiki-extensions-Interwiki, 10UI-Standardization, 13Patch-For-Review, 15User-Ladsgroup: Align Special:Interwiki with Wikimedia color palette - https://phabricator.wikimedia.org/T153049#2873310 (10Ladsgroup) This one looks more OOUIy: {F5055444} [18:32:00] (03PS1) 10Florianschmidtwelzow: i18n: Actually -> currently [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/327255 (https://phabricator.wikimedia.org/T153037) [18:32:21] (03CR) 10Jack Phoenix: [C: 032] Change extension type to the more precise antispam from specialpage [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/327254 (owner: 10Jack Phoenix) [18:32:26] 10GoogleLogin, 07I18n, 13Patch-For-Review: [[MediaWiki:Googlelogin-manage-notlinked/es]] i18n issue - https://phabricator.wikimedia.org/T153037#2867205 (10Florian) Oha, it should be currently, as the account is currently not linked to a Google account. [18:32:51] 10Phabricator, 10Diffusion, 10grrrit-wm: Merge R1982 INTO rTGRT in phab - https://phabricator.wikimedia.org/T153222#2873320 (10Zppix) [18:33:34] (03Merged) 10jenkins-bot: Change extension type to the more precise antispam from specialpage [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/327254 (owner: 10Jack Phoenix) [18:35:14] 10Phabricator, 10Diffusion, 10grrrit-wm: Merge R1982 INTO rTGRT in phab - https://phabricator.wikimedia.org/T153222#2873335 (10Paladox) 05Open>03Resolved a:03Paladox [18:35:33] 10Connected-Open-Heritage-New-data: Australia for COH - https://phabricator.wikimedia.org/T153221#2873337 (10Lokal_Profil) Question 1: * What is the license of the data itself? * We would possibly want to filter the data on one or more of the `Type` / `Register` / `Type of register` fields but otherwise I think... [18:35:59] (03PS1) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327257 (https://phabricator.wikimedia.org/T151973) [18:37:48] (03PS3) 10Milimetric: Implement basic Dashiki extension [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) [18:37:50] 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2873341 (10Urbanecm) [18:38:24] 10MediaWiki-General-or-Unknown, 06Operations, 06Release-Engineering-Team, 10Traffic, and 4 others: Make sure we're not relying on HTTP_PROXY headers - https://phabricator.wikimedia.org/T140658#2873344 (10Aklapper) [18:38:33] 10MediaWiki-Cache, 05MW-1.27-release-notes, 05MW-1.28-release-notes, 05MW-1.29-release-notes, 13Patch-For-Review: wincache_ucache_cas() expects parameter 2 to be long, string given - https://phabricator.wikimedia.org/T120896#2873348 (10Aklapper) [18:38:34] 10MediaWiki-Search, 07Easy, 05MW-1.27-release: "Page title matches" and "Page text matches" search results are weirdly floated next to each other - https://phabricator.wikimedia.org/T122499#2873346 (10Aklapper) [18:38:36] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07Easy: Reindexer.php error: Call to a member function indexToIndexTypes() on a non-object - https://phabricator.wikimedia.org/T121621#2873347 (10Aklapper) [18:38:38] 10MediaWiki-Internationalization, 06Language-Team, 07I18n: Main page tab is not translated in 1.26 - https://phabricator.wikimedia.org/T119938#2873350 (10Aklapper) [18:38:39] 10MediaWiki-Search, 06Discovery-Search: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#2873351 (10Aklapper) [18:38:42] 10MediaWiki-Debug-Logger, 06Reading-Infrastructure-Team, 10Wikimedia-Logstash, 07HHVM, and 2 others: Log php fatals with full backtraces again (fatal.log on fluorine) - https://phabricator.wikimedia.org/T89169#2873352 (10Aklapper) [18:39:03] (03CR) 10Milimetric: [] "addressed all review notes, thanks to all three of you, I really appreciate it!" (038 comments) [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) (owner: 10Milimetric) [18:39:28] (03CR) 10Phuedx: [] Redefine when Page Previews are enabled (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327194 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [18:39:31] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 06Performance-Team: Display a password strength bar - https://phabricator.wikimedia.org/T32574#2873354 (10Gilles) [18:39:35] (03PS1) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/327259 (https://phabricator.wikimedia.org/T151973) [18:40:45] (03PS7) 10Phuedx: Wire up saving enabled/disabled in settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327018 (owner: 10Jhernandez) [18:40:48] (03PS2) 10Phuedx: Hygiene: Tidy up "settings" feature [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 [18:41:35] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Reading-Web-Backlog, and 3 others: Cleanup execution flow through Special:Search - https://phabricator.wikimedia.org/T150393#2873370 (10ovasileva) That works, tagging it with the reading-web backlog for review and will discuss with team about lining it ear... [18:41:44] (03CR) 10Kaldari: [C: 04-1] Re-index the array of excluded namespace IDs (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327141 (https://phabricator.wikimedia.org/T153165) (owner: 10Samwilson) [18:41:48] 10MediaWiki-extensions-ContentTranslation: Unguarded external link in translation column that will navigate away when clicked - https://phabricator.wikimedia.org/T153180#2873372 (10Amire80) [18:42:14] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Reading-Web-Backlog, and 3 others: Extract search result rendering from SpecialSearch - https://phabricator.wikimedia.org/T150390#2873373 (10ovasileva) [18:42:46] 10MediaWiki-extensions-UniversalLanguageSelector, 06Performance-Team, 07Regression: "jquery.uls.data" syntax error in IE11 - https://phabricator.wikimedia.org/T152180#2873374 (10Gilles) [18:43:59] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Tidy up "settings" feature [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327016 (owner: 10Phuedx) [18:44:16] (03PS1) 10Jack Phoenix: Fix typo [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/327262 [18:46:02] (03CR) 10Jforrester: [C: 032] mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers [core] - 10https://gerrit.wikimedia.org/r/327183 (owner: 10Bartosz Dziewoński) [18:46:42] (03CR) 10Jack Phoenix: [V: 032 C: 032] Fix typo [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/327262 (owner: 10Jack Phoenix) [18:48:13] (03PS1) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/327264 (https://phabricator.wikimedia.org/T151973) [18:49:43] (03PS2) 10Phuedx: Hygiene: Make mw.popups#isEnabled return boolean [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327196 (https://phabricator.wikimedia.org/T152687) [18:50:44] (03CR) 10Phuedx: [] ":D" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327196 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [18:53:08] (03PS1) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/327265 (https://phabricator.wikimedia.org/T151973) [18:56:09] (03CR) 10Kaldari: [C: 04-1] Add autocompletion to search fields (033 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326894 (https://phabricator.wikimedia.org/T152758) (owner: 10Samwilson) [18:56:21] (03Merged) 10jenkins-bot: mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers [core] - 10https://gerrit.wikimedia.org/r/327183 (owner: 10Bartosz Dziewoński) [18:56:24] (03Merged) 10jenkins-bot: Fix typo [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/327262 (owner: 10Jack Phoenix) [18:56:50] (03PS1) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) [18:57:53] (03CR) 10jenkins-bot: [V: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [18:59:54] (03CR) 10Divadsn: [] "Aha, jenkins-bot says a lot about the failure, hrmpf..." [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:01:28] (03PS1) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327268 (https://phabricator.wikimedia.org/T151973) [19:04:48] (03CR) 10Thcipriani: [C: 032] "SWAT" [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327251 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [19:04:54] (03CR) 10Thcipriani: [C: 032] "SWAT" [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327252 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [19:05:14] 10Mobile-Content-Service, 07Technical-Debt: Convert one test to use mocked data - https://phabricator.wikimedia.org/T151091#2807331 (10bearND) An interesting idea I heard mentioned by Stephen at our retrospective meeting a while ago is to try a similar approach some Android unit tests are done by having a Mock... [19:06:04] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2873420 (10Jdlrobson) FYI these were purposely disabled by default due to seriously impacting reader experience. Note a site notice will consume most of a mobi... [19:06:34] (03PS2) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) [19:08:50] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2873431 (10Urbanecm) >>! In T152826#2861710, @Ibrahim.ID wrote: > https://ar.wikipedia.org/wiki/%D9%88%D9%8A%D9%83%D9%8A%D8%A8%D9%8A%D8%AF%D9%8A%D8%A7:%D8%A7%D... [19:08:53] 10MediaWiki-extensions-PageAssessments, 06Community-Tech, 07Wikimedia-log-errors: Frequent duplicate key errors by page assessments - https://phabricator.wikimedia.org/T152080#2873432 (10kaldari) It does have code to check for this. There must be a bug. [19:10:28] (03CR) 10Jdlrobson: [] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327137 (https://phabricator.wikimedia.org/T146394) (owner: 10Jdlrobson) [19:11:28] 10MediaWiki-extensions-CentralNotice: Selector logic link in Special:CentralNoticeBanners links to a 404 page - https://phabricator.wikimedia.org/T153225#2873433 (10MarcoAurelio) [19:11:33] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2873445 (10Jdlrobson) My apologies I missed the comment. [19:12:23] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2873447 (10Urbanecm) [19:12:55] 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 13Patch-For-Review: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2873449 (10Jdlrobson) Can you point me to the SIteNotice you are hoping to run? I would like to show a screenshot of how this would look in mobile if enabled. [19:14:07] (03CR) 10Jdlrobson: [C: 031] "Any reason?" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327217 (owner: 10Mobrovac) [19:14:25] 10Mobile-Content-Service, 07Technical-Debt: Convert one test to use mocked data - https://phabricator.wikimedia.org/T151091#2873451 (10Niedzielski) [19:14:27] 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog, 07Spike, 07Technical-Debt: Investigate best practice for mocking network data - https://phabricator.wikimedia.org/T152454#2873452 (10Niedzielski) [19:15:53] (03PS12) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [19:17:13] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2873462 (10Nemo_bis) Enable Special:PageLanguage [19:19:04] 10Phabricator, 15User-Addshore: Herald rule for adding project "User-Addshore" when Addshore is assigned to a task - https://phabricator.wikimedia.org/T153113#2873481 (10Aklapper) 05Open>03Resolved a:03Aklapper Created {H212}. [19:19:26] (03CR) 10jenkins-bot: [V: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:20:30] 10MediaWiki-extensions-CentralNotice: Special:RecordImpression shouldn't be a blank page - https://phabricator.wikimedia.org/T153228#2873497 (10MarcoAurelio) [19:20:33] (03Merged) 10jenkins-bot: Add googleweblight to JS blacklist [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327251 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [19:20:36] (03Merged) 10jenkins-bot: Add googleweblight to JS blacklist [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327252 (https://phabricator.wikimedia.org/T152602) (owner: 10Ejegg) [19:20:47] 10MediaWiki-extensions-AntiSpoof, 05Security: Add some more characters to AntiSpoof mappings for usage in TitleBlacklists - https://phabricator.wikimedia.org/T153021#2873511 (10Legoktm) [19:21:32] (03Abandoned) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:22:10] (03CR) 10EBernhardson: [C: 032] Document type of LogEntry::isPatrollable property [core] - 10https://gerrit.wikimedia.org/r/327206 (owner: 10WMDE-leszek) [19:22:50] (03CR) 10Reedy: Replace "Article::getContent()" deprecated in MediaWiki 1.21 (033 comments) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:23:19] 04(no projects): Dash not rendering for Megan or I - probably date format related - https://phabricator.wikimedia.org/T153229#2873516 (10Eileenmcnaughton) [19:23:49] (03CR) 10Reedy: "There's no need to abandon; there are unrelated test failures that need fixing, but you don't necessarily have to do it -- but you could. " [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:23:53] (03CR) 10Divadsn: "Seems like a bigger problem, the class acutally extends Article I see, whoops." [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:24:02] (03CR) 10Reedy: Replace "Article::getContent()" deprecated in MediaWiki 1.21 (031 comment) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:24:14] 10MediaWiki-extensions-CentralNotice: Avoid the increasing lenght of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2873532 (10MarcoAurelio) [19:25:30] 10MobileFrontend, 06Reading-Web-Backlog: Mobile page always shows the last modifier - https://phabricator.wikimedia.org/T153125#2873545 (10Jdlrobson) I'm also concerned that this might be a legal problem... [19:26:07] 10Phabricator, 06Operations, 06Release-Engineering-Team, 13Patch-For-Review: Setup test domain for phab2001 - https://phabricator.wikimedia.org/T152132#2873547 (10Dzahn) a:03Dzahn [19:26:44] (03PS1) 10Jack Phoenix: Delete old PHP entry point, remove Brickimedia's custom global CSS solution from the DeepSea skin class + also rm some other old cruft [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/327270 [19:27:03] 10Phabricator, 06Operations, 06Release-Engineering-Team, 13Patch-For-Review: Setup test domain for phab2001 - https://phabricator.wikimedia.org/T152132#2839539 (10Dzahn) we are waiting for https://gerrit.wikimedia.org/r/#/c/324797/ here, traffic team asked to wait a couple days because they were in the mi... [19:27:04] 10Phabricator-Bot-Requests: Requesting a bot account for @MarcoAurelio - https://phabricator.wikimedia.org/T153191#2873550 (10Aklapper) Wondering about the "email address" item on https://www.mediawiki.org/wiki/Phabricator/Bots#Acquiring_a_bot ... [19:27:43] 10MediaWiki-API, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Add wfIsBadImage() status to prop=imageinfo API - https://phabricator.wikimedia.org/T148343#2873551 (10Legoktm) 05Open>03Resolved [19:27:45] 10Wikimedia-Site-requests: Actually enable Special:PageLanguage on all Translate wikis - https://phabricator.wikimedia.org/T153209#2873552 (10MarcoAurelio) What is Special:PageLanguage suposed to do? Any link or explanation would be helpful, even if it seems obvious to all of you. Thank you :-) [19:28:07] (03PS8) 10GWicke: WIP: Add serviceworker build process [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/321565 [19:28:11] (03CR) 10Jack Phoenix: [V: 032 C: 032] Delete old PHP entry point, remove Brickimedia's custom global CSS solution from the DeepSea skin class + also rm some other old cruft [skins/DeepSea] - 10https://gerrit.wikimedia.org/r/327270 (owner: 10Jack Phoenix) [19:28:16] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add serviceworker build process [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/321565 (owner: 10GWicke) [19:29:08] 10Android-app-feature-Feeds, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Today’s Featured Article and In the News is not shown in Hungarian mobile app - https://phabricator.wikimedia.org/T152284#2873555 (10Tacsipacsi) Thank you for taking care of it. I’m sure it should use some CSS class(es) (... [19:29:39] (03CR) 10Reedy: [C: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327257 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:29:42] (03CR) 10EBernhardson: [C: 032] Fix parameter type docs [core] - 10https://gerrit.wikimedia.org/r/327221 (owner: 10WMDE-leszek) [19:30:13] (03Merged) 10jenkins-bot: Document type of LogEntry::isPatrollable property [core] - 10https://gerrit.wikimedia.org/r/327206 (owner: 10WMDE-leszek) [19:30:26] (03CR) 10Reedy: [C: 04-1] "Use ContentHandler::getContentText() as per Cargo" [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/327259 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:30:58] Reedy, the same for other extensions too? :D [19:31:00] (03PS9) 10GWicke: Add serviceworker build process [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/321565 [19:31:04] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Special:RecordImpression shouldn't be a blank page - https://phabricator.wikimedia.org/T153228#2873557 (10DStrine) [19:31:07] (03CR) 10jenkins-bot: [V: 04-1] Add serviceworker build process [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/321565 (owner: 10GWicke) [19:31:20] divadsn: if you wouldn't mind... I've got a dog sat on my knee atm, who's making it very hard for me to use my laptop :P [19:31:42] divadsn: Fixup LinkFilter and we'll see about unbreaking the tests too :) [19:31:52] Could make it into a GCI task too [19:31:58] Reedy, oh, my dog is waiting outside to go with him for a walk :P [19:32:27] So instead of $page-getContent()->getNativeData() I should use ContentHandler::getContentText( $page->getContent() ) right? [19:32:33] This one is being needy [19:32:35] Yus please [19:33:43] (03PS3) 10Jdlrobson: Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) [19:33:48] (03CR) 10Jdlrobson: [] Add additional information to file and user pages for rendering (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [19:34:09] 10Tools-Global-user-contributions: The subdomain of a Wikipedia URL is truncated inappropriately to two characters - https://phabricator.wikimedia.org/T153232#2873579 (10Suzukaze-c) [19:34:11] 04(no projects): Kurdish projects: Internal links - https://phabricator.wikimedia.org/T153233#2873591 (10Ghybu) [19:34:15] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2873577 (10Jdforrester-WMF) [19:34:18] 10Tools-Global-user-contributions: The subdomain of a Wikipedia URL is truncated inappropriately to two characters - https://phabricator.wikimedia.org/T153232#2873606 (10Suzukaze-c) [19:35:22] (03PS2) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327257 (https://phabricator.wikimedia.org/T151973) [19:35:56] (03CR) 10jenkins-bot: [V: 04-1] Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [19:36:03] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Special:NewPagesFeed incorrectly states "No Categories" when categories exist - https://phabricator.wikimedia.org/T147721#2873612 (10jmatazzoni) 05Open>03Resolved a:03j... [19:36:10] (03CR) 10Jdlrobson: [] Hygiene: improve ESLint configuration (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/325709 (owner: 10Niedzielski) [19:36:29] (03PS2) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/327259 (https://phabricator.wikimedia.org/T151973) [19:36:55] (03Restored) 10Reedy: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:37:23] (03PS4) 10Jdlrobson: Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) [19:37:39] (03PS2) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/327264 (https://phabricator.wikimedia.org/T151973) [19:37:52] 10Phabricator-Bot-Requests: Requesting a bot account for @MarcoAurelio - https://phabricator.wikimedia.org/T153191#2873659 (10MarcoAurelio) You can check [[ https://gerrit.wikimedia.org/r/#/q/owner:MarcoAurelio | my gerrit patches ]] for it if you wish. I wonder how an email address is relevant for this though,... [19:39:12] 10Phabricator (Upstream), 07Upstream: Phabricator workboard layout can be scrolled to bottom (exposing empty area) with many sidebar links - https://phabricator.wikimedia.org/T152143#2839858 (10mmodell) If you expand the sidebar then it takes up less vertical space. [19:39:28] (03CR) 10Bartosz Dziewoński: "(caused T153231)" [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [19:39:38] 10MediaWiki-API: drvstartid/drvendid missing from prop=deletedrevisions - https://phabricator.wikimedia.org/T153236#2873669 (10Halfak) [19:39:50] Reedy, when you are a bit tired and merging two commands into one: http://i.rly.li/7x1j/2e34kk.png :D [19:40:10] anomie, if you have a minute, could you look at https://phabricator.wikimedia.org/T153236 [19:40:14] divadsn: git can do everything else ;) [19:40:28] I want to address issues with the task description while it is still fresh in my thoughts :) [19:40:47] (03PS2) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/327265 (https://phabricator.wikimedia.org/T151973) [19:40:50] 10Phabricator, 06Project-Admins: Rename #WMF FR - https://phabricator.wikimedia.org/T153237#2873687 (10MarcoAurelio) [19:40:59] * halfak starts on a work-around [19:41:07] (03CR) 10BearND: "dbrant: question for you inline." (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [19:41:21] (03Merged) 10jenkins-bot: Fix parameter type docs [core] - 10https://gerrit.wikimedia.org/r/327221 (owner: 10WMDE-leszek) [19:42:26] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2873702 (10Reedy) [19:42:29] (03PS2) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327268 (https://phabricator.wikimedia.org/T151973) [19:43:24] (03PS3) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) [19:43:38] (03PS1) 10Thcipriani: Bump JsonConfig submodule [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327276 [19:43:42] (03CR) 10Dbrant: Add EN Donation Announcements (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [19:43:57] (03CR) 10jenkins-bot: [V: 04-1] Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) (owner: 10Jdlrobson) [19:44:35] andre__: I'll import T153238 into GCI in half an hour or so [19:44:35] T153238: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238 [19:44:41] (03CR) 10Yurik: [C: 032] Bump JsonConfig submodule [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327276 (owner: 10Thcipriani) [19:45:01] Reedy, the commit spam train has arrived at the destination, now I am on a walk with my dog, see you later! :) [19:45:59] 10Phabricator, 06Project-Admins: Rename #WMF FR - https://phabricator.wikimedia.org/T153237#2873721 (10MarcoAurelio) For the join settings, I'd say this is being used sort of a acl* for Wikimedia Fundraising folks. It should then be adjusted to {icon lock, color=red} `acl*wikimedia-fundraising`. Join settings,... [19:46:22] 10Phabricator, 06Project-Admins, 06WMF FR: Rename #WMF FR - https://phabricator.wikimedia.org/T153237#2873722 (10MarcoAurelio) So they're aware of this. [19:46:29] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data - https://phabricator.wikimedia.org/T151770#2873724 (10Amire80) I confirm that it happened to my own edits in Wikipedia in several languages. More interestingly: I regularly measure the number of failed saving ev... [19:47:47] (03CR) 10jenkins-bot: [V: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [19:48:06] (03CR) 10BearND: Add EN Donation Announcements (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327224 (https://phabricator.wikimedia.org/T152572) (owner: 10Fjalapeno) [19:48:09] (03CR) 10Bmansurov: [] WIP: Add reading depth (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [19:50:23] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I can't review this in-depth, but I am willing to merge this. Please poke me if it's not merged within the next few days." [core] - 10https://gerrit.wikimedia.org/r/327192 (https://phabricator.wikimedia.org/T153132) (owner: 10Aftab) [19:52:05] 04(no projects): Kurdish projects: Internal links - https://phabricator.wikimedia.org/T153233#2873751 (10Ghybu) [19:52:14] 07Design, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review: Allow unwatching a Flow topic/board from a notification about that topic/board - https://phabricator.wikimedia.org/T132975#2873752 (10jmatazzoni) 05Open>03Resolved [19:53:04] 10EasyTimeline, 07Wikimedia-log-errors: proc line: 2959: warning: points must have either 4 or 2 values per line - https://phabricator.wikimedia.org/T138036#2873758 (10Legoktm) [19:53:07] 07Wikimedia-log-errors: pl proc line: 2959: warning: points must have either 4 or 2 values per line - https://phabricator.wikimedia.org/T153159#2873760 (10Legoktm) [19:54:43] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data - https://phabricator.wikimedia.org/T151770#2827529 (10Legoktm) If browsers are corrupting cookies this often, we should work around it somehow and/or file upstream bugs. [19:56:25] 10MediaWiki-extensions-UniversalLanguageSelector, 06Performance-Team, 07Regression: "jquery.uls.data" syntax error in IE11 - https://phabricator.wikimedia.org/T152180#2873771 (10Krinkle) I'm still able to reproduce this on the first attempt: 1. Open BrowserStack (Windows 8.1; IE 11 Latest) 2. https://www.me... [19:57:11] (03Merged) 10jenkins-bot: Bump JsonConfig submodule [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/327276 (owner: 10Thcipriani) [20:00:28] 10MediaWiki-extensions-VectorBeta: VectorBeta requires ext.eventLogging to run - https://phabricator.wikimedia.org/T71490#2873777 (10Aklapper) p:05Triage>03Lowest [20:00:56] (03PS1) 10C. Scott Ananian: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/327278 [20:07:05] (03CR) 10Jack Phoenix: [C: 032] "Thanks for the patch and apologies for the delay in review! For whatever reason I wasn't subscribed to this changeset so I only accidental" [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/321385 (owner: 10Southparkfan) [20:07:48] (03CR) 10Divadsn: [] "So the test failures have nothing to do with my changes, right? :)" (031 comment) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:08:03] (03CR) 10Legoktm: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/327278 (owner: 10C. Scott Ananian) [20:08:06] (03Merged) 10jenkins-bot: Optimize amount of SQL queries for Special:TopRatings [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/321385 (owner: 10Southparkfan) [20:09:06] (03CR) 10BearND: [C: 032] Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [20:10:30] 10Wiki-Loves-Monuments-Database, 13Patch-For-Review: ErfgoedBot categorisation task fails with TypeError - https://phabricator.wikimedia.org/T149258#2873804 (10Lokal_Profil) 05Open>03Resolved [20:12:26] 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2738271 (10Pppery) @PratyyaGhosh Why did you re-subscribe me? [20:13:25] (03CR) 10BearND: [C: 04-1] "Mobrovac or Pchelolo are you planning to add eslint to the test folder in the template soon? We're running into issues when we try doing t" (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/325709 (owner: 10Niedzielski) [20:14:00] 10Connected-Open-Heritage-New-data: Add Moldova through COH - https://phabricator.wikimedia.org/T153242#2873824 (10Lokal_Profil) User @Gikü has previously looked ato importing these to Wikipedia [20:16:02] 10MediaWiki-Uploading, 10AbuseFilter, 06Multimedia, 05Security: Upload abuse filters can be occasionally bypassed somehow - https://phabricator.wikimedia.org/T153217#2873849 (10matmarex) 05Open>03Resolved p:05Triage>03High [20:16:44] andre__afk: https://codein.withgoogle.com/dashboard/tasks/5692704023379968/ [20:16:51] (03PS1) 10Jkroll: debug output stuff [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/327283 [20:17:26] (03CR) 10jenkins-bot: [V: 04-1] debug output stuff [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/327283 (owner: 10Jkroll) [20:17:32] 10MediaWiki-Uploading, 10AbuseFilter, 06Multimedia, 10Wikimedia-General-or-Unknown, 05Security: Upload abuse filters can be occasionally bypassed somehow - https://phabricator.wikimedia.org/T153217#2873156 (10matmarex) [20:18:14] (03CR) 10Phe: [C: 031] Makes sure that "Proofread tools" toolbar is always loaded after Page: pages edit interface setup [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/327027 (https://phabricator.wikimedia.org/T152945) (owner: 10Tpt) [20:18:55] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2873858 (10Reedy) https://codein.withgoogle.com/dashboard/tasks/5692704023379968/ on GCI, but not published yet... [20:19:00] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/327278 (owner: 10C. Scott Ananian) [20:19:03] (03Merged) 10jenkins-bot: Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [20:21:08] (03CR) 10Reedy: [C: 032] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327257 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:21:21] 04(no projects): Diacritical letters (Çç, Êê, Îî, Şş, Ûû) on Kurdish pages do not become part of the internal link - https://phabricator.wikimedia.org/T153233#2873863 (10Aklapper) [20:21:45] (03CR) 10Reedy: [C: 032] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/327259 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:22:11] (03Merged) 10jenkins-bot: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/327257 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:22:30] (03CR) 10BearND: [C: 032] Update announcement schema and add validation check [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327249 (owner: 10Mholloway) [20:22:54] (03Merged) 10jenkins-bot: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/327259 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:23:41] 10MediaWiki-ContentHandler, 07Easy, 03Google-Code-In-2016: Move exception classes out of ContentHandler.php - https://phabricator.wikimedia.org/T153243#2873876 (10Reedy) [20:24:30] 10MediaWiki-Internationalization: Diacritical letters (Çç, Êê, Îî, Şş, Ûû) on Kurdish pages do not become part of the internal link - https://phabricator.wikimedia.org/T153233#2873891 (10Aklapper) p:05Triage>03Low See T64998#659226 - you need to define `$linkTrail` in [[ https://phabricator.wikimedia.org/dif... [20:24:44] (03Merged) 10jenkins-bot: Update announcement schema and add validation check [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327249 (owner: 10Mholloway) [20:25:21] (03CR) 10Reedy: [C: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 (031 comment) [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/327265 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:28:01] (03CR) 10Reedy: [C: 032] "Bonus points for the doEdit() :D" (031 comment) [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/327264 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:29:00] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2873916 (10Aklapper) [20:29:04] (03CR) 10Reedy: [C: 032] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327268 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:29:13] (03Merged) 10jenkins-bot: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/327264 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:29:43] 10MediaWiki-Uploading, 10AbuseFilter, 06Multimedia, 10Wikimedia-General-or-Unknown, 05Security: Upload abuse filters can be occasionally bypassed somehow - https://phabricator.wikimedia.org/T153217#2873156 (10Legoktm) Can you file a separate task about the bug in AbuseFilterCachingParser? [20:30:02] (03Merged) 10jenkins-bot: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/327268 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:30:04] (03CR) 10Reedy: [] Replace "Article::getContent()" deprecated in MediaWiki 1.21 (031 comment) [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:30:26] (03CR) 10Reedy: [] "But yeah, test failures aren't your fault, just you touched the extension" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [20:31:00] 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2873923 (10Mvolz) @Peppry; I think it's automated because of the tag. If you don't want to get resubscribed every time someone edits the description, we should edit the @ out of the... [20:31:27] 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2873925 (10Mvolz) [20:32:38] 07Documentation, 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2873926 (10Reedy) [20:33:59] (03PS2) 10BearND: Update preq dependency [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 [20:38:36] (03CR) 10BearND: [] "> does it make sense to increase the timeout just for Docker runs, given that our reason for using Docker is to simulate production as clo" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND) [20:43:04] 10MediaWiki-extensions-CentralNotice, 10Wikimedia-Fundraising: Banner close button throws javascript error - https://phabricator.wikimedia.org/T153240#2873940 (10AndyRussG) [20:43:06] 10MediaWiki-ContentHandler, 07Easy, 03Google-Code-In-2016: Move exception classes out of ContentHandler.php - https://phabricator.wikimedia.org/T153243#2873941 (10Aklapper) https://codein.withgoogle.com/tasks/5664973030162432/ [20:45:41] (03PS1) 10Pppery: Specify height of tabs [skins/Vector] - 10https://gerrit.wikimedia.org/r/327288 (https://phabricator.wikimedia.org/T104767) [20:47:57] 07Design, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2873962 (10jmatazzoni) Based on @Etonkovidova's screenshots above, it looks like changes were made but this issue... [20:48:10] 07Design, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2873964 (10jmatazzoni) [20:50:42] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327289 (https://phabricator.wikimedia.org/T151973) [20:51:49] 10MobileFrontend, 06Reading-Web-Backlog: Menu icons misaligned in Firefox 50 (light navigation drawer) - https://phabricator.wikimedia.org/T152391#2846684 (10Nicholas.tsg) BrowserStack settings OS: El Capitan Browser: Firefox 50 (latest) Steps I reproduced: 1) With Browserstack open on credentials above, go... [20:52:00] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 3 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2873988 (10ovasileva) [20:52:02] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2873987 (10ovasileva) 05Open>03Resolved [20:52:05] (03CR) 10Jdlrobson: [C: 031] Introduce Popups Opt-In option on user preferences page (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327041 (https://phabricator.wikimedia.org/T146889) (owner: 10Pmiazga) [20:54:17] 10MediaWiki-API: Tracking: API/backend issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#2873994 (10ovasileva) [20:54:47] 10Hovercards, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭: Stop Hovercards A/B tests - https://phabricator.wikimedia.org/T144490#2873995 (10ovasileva) 05Open>03Resolved [20:55:08] 10MediaWiki-Uploading, 10AbuseFilter, 06Multimedia, 10Wikimedia-General-or-Unknown, 05Security: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2873996 (10matmarex) [20:55:23] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2874012 (10Reedy) Andre: Can we just do 1 task per extension? gre... [20:55:51] 10MediaWiki-Special-pages, 07Beta-Cluster-reproducible: HTTP 503 error for "Special:Contributions" results on de.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T152672#2874017 (10Aklapper) User wrote that they cannot reproduce the problem anymore. [20:57:12] Reedy: Are you there? $article->getContent( true ) is used in code, but getContent( doesnt take any bool, can i remove it? [20:57:42] rlot: Yes... Plus the getContent needs replacing on an article object anyway [20:57:59] I'll convert it to WikiPage [20:58:57] 10Wikimedia-Site-requests, 05Goal: Tidy up wmf-config CommonSettings.php and InitialiseSettings.php - https://phabricator.wikimedia.org/T31902#2874043 (10Reedy) [20:59:23] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint: Convert PageAssessments projects API from a property query to a list query - https://phabricator.wikimedia.org/T153164#2874047 (10kaldari) a:03kaldari [20:59:57] 10MediaWiki-extensions-CentralNotice, 10Wikimedia-Fundraising: Banner close button throws javascript error - https://phabricator.wikimedia.org/T153240#2874050 (10Pcoombe) 05Open>03Resolved Thanks, yeah that was copy-pasted from the wrong banner. Fixed now in the live banners and our template. [20:59:59] (03CR) 10Reedy: [C: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [21:00:34] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/327295 (https://phabricator.wikimedia.org/T151973) [21:01:40] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Avoid the increasing lenght of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2874060 (10DStrine) [21:01:48] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Avoid the increasing lenght of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2873532 (10DStrine) p:05Triage>03Normal [21:02:34] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Avoid the increasing length of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#2874063 (10Reedy) [21:02:46] 10MediaWiki-Uploading, 10AbuseFilter, 06Multimedia, 10Wikimedia-General-or-Unknown, and 2 others: Some abuse filters can be bypassed (never match any actions) - https://phabricator.wikimedia.org/T153217#2874064 (10matmarex) All production wikis were affected by this issue, in the following periods. But oth... [21:04:56] (03CR) 10Catrope: [C: 032] Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [21:04:59] (03CR) 10Catrope: [C: 032] Fix check for content text [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311880 (owner: 10Mattflaschen) [21:05:02] (03CR) 10Catrope: [C: 032] speedy deletion-previously deleted takes a page name, not a URL [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/312108 (https://phabricator.wikimedia.org/T118264) (owner: 10Mattflaschen) [21:05:05] (03CR) 10Catrope: [C: 04-1] "Looks good, minor comments inline. As for WANCache, FlaggedRevs should probably be converted to that, yes; or at least it should use somet" (034 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/194988 (https://phabricator.wikimedia.org/T51787) (owner: 10Cenarium) [21:05:07] (03CR) 10Catrope: [C: 031] Add echo notification when deferred [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316957 (owner: 10Cenarium) [21:05:09] (03CR) 10Catrope: [] Don't always display review notice if autoreviewed, specify if autoreviewed (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255811 (https://phabricator.wikimedia.org/T60057) (owner: 10Cenarium) [21:05:11] (03CR) 10Catrope: [C: 032] Autopromote: Remove superflous condition in APCOND_EDITCOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/264232 (owner: 10Cenarium) [21:05:16] 10MobileFrontend, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), 07Wikimedia-log-errors: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappManifest.php on line 31 - https://phabricator.wikimedia.org/T153250#2874085 (10mmodell) [21:05:31] 10MobileFrontend, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), 07Wikimedia-log-errors: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappManifest.php on line 31 - https://phabricator.wikimedia.org/T153250#2874099 (10mmodell) [21:05:54] 10AbuseFilter: AbuseFilterCachingParser never matches certain filters, which match with the old parser - https://phabricator.wikimedia.org/T153251#2874101 (10matmarex) [21:05:56] (03PS6) 10C. Scott Ananian: Protect language converter markup in the preprocessor. [core] - 10https://gerrit.wikimedia.org/r/311849 (https://phabricator.wikimedia.org/T146304) [21:05:59] (03PS4) 10C. Scott Ananian: Protect -{...}- variant constructs in images. [core] - 10https://gerrit.wikimedia.org/r/327042 (https://phabricator.wikimedia.org/T146305) [21:06:02] (03PS17) 10C. Scott Ananian: LanguageConverter fixes to eliminate parser test failures [core] - 10https://gerrit.wikimedia.org/r/76341 (https://phabricator.wikimedia.org/T54190) (owner: 10Liangent) [21:06:05] (03PS6) 10C. Scott Ananian: Protect -{...}- variant constructs in definition lists. [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) [21:06:08] (03PS5) 10C. Scott Ananian: Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) [21:06:31] (03Merged) 10jenkins-bot: Add MessagePoster/Flow support to PageTriage, fix related issues [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [21:06:33] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint: Convert PageAssessments projects API from a property query to a list query - https://phabricator.wikimedia.org/T153164#2874118 (10kaldari) [21:06:40] (03PS1) 10Filip: "Article::getContent()" is deprecated in MediaWiki 1.21 [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327298 (https://phabricator.wikimedia.org/T151973) [21:07:28] (03Merged) 10jenkins-bot: Fix check for content text [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311880 (owner: 10Mattflaschen) [21:07:34] (03PS1) 10Mholloway: Update mobileapps to f5d9d86 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327299 [21:07:45] (03PS1) 10Kaldari: Switch projects API from property query to list query [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327300 (https://phabricator.wikimedia.org/T153164) [21:08:05] (03CR) 10Mholloway: [V: 032 C: 032] Update mobileapps to f5d9d86 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/327299 (owner: 10Mholloway) [21:08:14] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016: Fixup Phan issues - https://phabricator.wikimedia.org/T153252#2874130 (10Reedy) [21:08:24] (03PS1) 10Catrope: ApiFlow: Clean up submodule handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327301 [21:08:27] (03PS1) 10Catrope: ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) [21:08:30] (03CR) 10jenkins-bot: [V: 04-1] "Article::getContent()" is deprecated in MediaWiki 1.21 [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327298 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:08:49] (03Merged) 10jenkins-bot: speedy deletion-previously deleted takes a page name, not a URL [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/312108 (https://phabricator.wikimedia.org/T118264) (owner: 10Mattflaschen) [21:08:52] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/327303 (https://phabricator.wikimedia.org/T151973) [21:08:54] (03CR) 10jenkins-bot: [V: 04-1] Autopromote: Remove superflous condition in APCOND_EDITCOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/264232 (owner: 10Cenarium) [21:09:15] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review: Convert PageAssessments projects API from a property query to a list query - https://phabricator.wikimedia.org/T153164#2874151 (10kaldari) [21:09:57] Reedy: $rtitle = ContentHandler::makeContent( $article->getContent(), null, CONTENT_MODEL_WIKITEXT ) [21:09:57] ->getRedirectTarget() [21:10:09] Reedy: Why just do not use getContentObject? [21:10:11] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review: Convert PageAssessments projects API from a property query to a list query - https://phabricator.wikimedia.org/T153164#2871572 (10kaldari) p:05Triage>03Low [21:10:25] rlot: Seems sensible [21:10:46] Reedy: But this ->getRedirectTarget() [21:11:04] Does content object support it? [21:11:10] Have a look? [21:11:25] Its WikiArticleFeeds_body.php [21:12:23] # Setup, handle redirects [21:12:23] if ( $article->isRedirect() ) { [21:12:23] $rtitle = ContentHandler::makeContent( $article->getContent(), null, CONTENT_MODEL_WIKITEXT ) [21:12:23] ->getRedirectTarget(); [21:12:23] if ( $rtitle ) { [21:12:24] $article = new Article( $rtitle ); [21:12:26] } [21:12:28] } [21:12:31] Reedy: [21:13:47] to [21:13:48] if ( $article->isRedirect() ) { [21:13:48] $rtitle = $article->getContentObject()->getRedirectTarget(); [21:13:48] if ( $rtitle ) { [21:13:48] $article = new Article( $rtitle ); [21:13:48] } [21:13:50] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016: Fixup Phan issues - https://phabricator.wikimedia.org/T153252#2874179 (10Reedy) [21:13:52] [21:14:00] (03PS18) 10C. Scott Ananian: LanguageConverter fixes to eliminate parser test failures [core] - 10https://gerrit.wikimedia.org/r/76341 (https://phabricator.wikimedia.org/T54190) (owner: 10Liangent) [21:14:03] (03PS7) 10C. Scott Ananian: Protect -{...}- variant constructs in definition lists. [core] - 10https://gerrit.wikimedia.org/r/327112 (https://phabricator.wikimedia.org/T153135) [21:14:06] (03PS6) 10C. Scott Ananian: Don't parse language converter markup as a cell parameter in tables. [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) [21:14:41] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2874180 (10jhobs) @bmansurov @ovasileva The problem with this approach though is that if... [21:15:52] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) [21:17:36] (03CR) 10Jhobs: [] Redefine when Page Previews are enabled (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327194 (https://phabricator.wikimedia.org/T152687) (owner: 10Phuedx) [21:18:54] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/327308 (https://phabricator.wikimedia.org/T151973) [21:19:01] (03PS3) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/327265 (https://phabricator.wikimedia.org/T151973) [21:19:48] (03PS1) 10Florianschmidtwelzow: PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [21:19:51] (03PS1) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [21:19:54] (03PS1) 10Florianschmidtwelzow: [DO NOT MERGE] Example usage of ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327314 [21:19:56] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016: Fixup Phan issues - https://phabricator.wikimedia.org/T153252#2874221 (10Aklapper) [21:20:01] 10Mobile-Content-Service, 13Patch-For-Review: MCS should quote the ETag - https://phabricator.wikimedia.org/T150886#2874222 (10Mholloway) 05Open>03Resolved [21:20:19] Reedy: Ok, i did it [21:20:28] Reedy: Submited it on GCI [21:22:24] (03PS2) 10Florianschmidtwelzow: PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 [21:24:01] (03CR) 10Filip: [] "Jenkins unrelated" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327298 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:24:41] (03PS4) 10Divadsn: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) [21:24:45] 06Reading-analysis: Investigate frequency of section titles in Wikipedia articles - https://phabricator.wikimedia.org/T148260#2874233 (10Zareenf) 05Open>03Resolved [21:24:52] (03CR) 10Filip: [] "I don't know, is this valid solution, but Article extends ->getContentObject" [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/327308 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:25:18] 10MediaWiki-General-or-Unknown: Unable to overwrite services using MediaWikiServices hook - https://phabricator.wikimedia.org/T153256#2874237 (10Nikerabbit) [21:25:44] Hopefully I did understand the code and did the right thing, Reedy ^^ [21:26:40] (03PS2) 10Florianschmidtwelzow: PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [21:27:03] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:27:51] 06Reading-analysis: Readership metrics report - https://phabricator.wikimedia.org/T148261#2874278 (10Zareenf) [21:28:44] 10MediaWiki-General-or-Unknown, 15User-Nikerabbit: Unable to overwrite services using MediaWikiServices hook - https://phabricator.wikimedia.org/T153256#2874282 (10Nikerabbit) [21:29:26] (03CR) 10Florianschmidtwelzow: [] "Hi @legoktm! :) I've uploaded this change and three otehr ones that build on top of it as something I wrote down. The basic idea is to hav" [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [21:29:45] 07Design, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2874284 (10SBisson) >>! In T142454#2873962, @jmatazzoni wrote: > Based on @Etonkovidova's screenshots above, it looks like changes were made bu... [21:30:54] (03CR) 10Filip: [] "Also, looks unrelated" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [21:31:08] (03PS3) 10Reedy: A few more hooks in DifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/322039 (owner: 10Jack Phoenix) [21:31:14] (03CR) 10Reedy: [C: 032] A few more hooks in DifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/322039 (owner: 10Jack Phoenix) [21:31:18] (03PS3) 10Reedy: Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [21:33:05] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Example usage of ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327314 (owner: 10Florianschmidtwelzow) [21:33:15] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016: Fixup Phan issues - https://phabricator.wikimedia.org/T153252#2874291 (10Reedy) [21:33:41] (03PS1) 10Chad: Tidy up ACLs for wmf related branches. Use BLOCK instead of DENY everywhere, also drop refs/tags/* stuff since we don't use tags for wmf branches. [mediawiki] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327360 [21:34:21] (03PS1) 10MtDu: Show the user icon on watchlist page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) [21:34:54] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Tabular-Data, and 3 others: Audio/Video/Media/Viz/Layout Session at Wikidev'17 - https://phabricator.wikimedia.org/T151952#2833116 (10Qgil) Should these subtasks be merged? [21:36:20] (03CR) 10Tpt: [C: 032] Makes sure that "Proofread tools" toolbar is always loaded after Page: pages edit interface setup [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/327027 (https://phabricator.wikimedia.org/T152945) (owner: 10Tpt) [21:36:36] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 2 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874300 (10MtDu) a:03MtDu Please take a look at the patch when you get a chance. Thanks! [21:36:41] (03CR) 10jenkins-bot: [V: 04-1] PoC: Add new ConfigRepository and ConfigItem architecture [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [21:36:42] 10TPG-FY2016-17-Q2-Design-Collaboration, 06Community-Liaisons (Oct-Dec-2016): Seeking community liaison support for engaging WMF/broader community for validation of statement of purpose of design - https://phabricator.wikimedia.org/T144991#2874302 (10Qgil) 05Open>03Resolved OK, thank you! [21:36:48] (03CR) 10jenkins-bot: [V: 04-1] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [21:37:08] (03CR) 10MarkAHershberger: [] "Could you look at the jenkins-bot failures? You may not have caused them, but if you can fix them, I'll +2." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/326047 (owner: 10Cicalese) [21:37:37] jenkins-bot is just... (ノ°▽°)ノ︵┻━┻ [21:38:14] (03CR) 10Florianschmidtwelzow: [C: 04-1] "The "Expand filter options" is a step in the right direction, but still: I think this isn't visible enough for the user. The first thing h" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [21:38:31] (03PS11) 10Mholloway: Description editing tutorial [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325424 (https://phabricator.wikimedia.org/T148205) [21:38:43] (03CR) 10Mholloway: Demo: refactor description edit tutorial page views (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326172 (https://phabricator.wikimedia.org/T148205) (owner: 10Niedzielski) [21:39:07] 07Design, 10MediaWiki-Categories, 10MediaWiki-Installer, 03Community-Tech-Sprint, 07I18n: Make the "uca-xx" category collations the default and selectable in the installer - https://phabricator.wikimedia.org/T47611#2874310 (10kaldari) [21:39:09] 10MediaWiki-Categories, 10MediaWiki-Installer, 06Community-Tech: Add ability to set category collation from the installer - https://phabricator.wikimedia.org/T146225#2874308 (10kaldari) 05Open>03declined Declining per Legoktm. Will look at just changing the default instead. [21:39:50] (03CR) 10Chad: [V: 032 C: 032] Tidy up ACLs for wmf related branches. Use BLOCK instead of DENY everywhere, also drop refs/tags/* stuff since we don't use tags for wmf bra [mediawiki] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/327360 (owner: 10Chad) [21:40:22] 10MediaWiki-Categories, 10MediaWiki-Installer, 06Community-Tech: Add ability to set category collation from the installer - https://phabricator.wikimedia.org/T146225#2874320 (10Legoktm) Er, we still need to modify the installer to *set* that default right? Like in LocalSettingsGenerator.php [21:41:16] (03CR) 10Reedy: [C: 031] "LGTM for purposes of GCI, merging blocked on unrelated test failure. Won't block GCI task" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [21:41:24] 10Reading-Web-Trending-Service, 10Security-Reviews: Security Review of Trending Edits Endpoint - https://phabricator.wikimedia.org/T153087#2874322 (10bearND) [21:41:45] (03CR) 10Reedy: [C: 032] Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/327265 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [21:42:05] divadsn: Is that all your patches dealt with for that task now? [21:43:16] (03PS1) 10Reedy: Push SemanticForms back to 3.7 branch [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327362 [21:43:27] 07Design, 10MediaWiki-Categories, 10MediaWiki-Installer, 03Community-Tech-Sprint, 07I18n: Make the "uca-xx" category collations the default and selectable in the installer - https://phabricator.wikimedia.org/T47611#2874335 (10kaldari) Legoktm has recommended against adding an interface for setting the co... [21:44:12] (03CR) 10jenkins-bot: [V: 04-1] PoC: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 (owner: 10Florianschmidtwelzow) [21:44:20] 10Mobile-Content-Service, 10Security-Reviews: Security Review of On This Day Endpoint - https://phabricator.wikimedia.org/T153088#2869298 (10bearND) This is not written yet. Will add more info when we start working on the 'On this Day' endpoint, see parent task. [21:44:38] (03CR) 1020after4: [C: 032] Push SemanticForms back to 3.7 branch [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327362 (owner: 10Reedy) [21:45:13] (03PS2) 10Bmansurov: WIP: Add reading depth [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) [21:45:21] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add reading depth [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/327122 (https://phabricator.wikimedia.org/T147314) (owner: 10Bmansurov) [21:46:18] (03Merged) 10jenkins-bot: A few more hooks in DifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/322039 (owner: 10Jack Phoenix) [21:46:21] (03Merged) 10jenkins-bot: Makes sure that "Proofread tools" toolbar is always loaded after Page: pages edit interface setup [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/327027 (https://phabricator.wikimedia.org/T152945) (owner: 10Tpt) [21:46:23] (03Merged) 10jenkins-bot: Replace "Article::getContent()" deprecated in MediaWiki 1.21 [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/327265 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [21:47:00] (03PS1) 10BearND: Add .eslintcache to gitignore [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327363 [21:47:09] 07Design, 10MediaWiki-Categories, 10MediaWiki-Installer, 03Community-Tech-Sprint, 07I18n: Make the "uca-xx" category collations the default during installation (with fallbacks) - https://phabricator.wikimedia.org/T47611#2874354 (10kaldari) [21:47:25] 10MediaWiki-Categories, 10MediaWiki-Installer, 06Community-Tech: Add ability to set category collation from the installer - https://phabricator.wikimedia.org/T146225#2874356 (10kaldari) @Legoktm: That's T47611. [21:47:46] 10MediaWiki-Categories, 10MediaWiki-Installer, 06Community-Tech: Add ability to set category collation from the installer - https://phabricator.wikimedia.org/T146225#2874362 (10Legoktm) Ah, right. [21:47:59] (03CR) 10D3r1ck01: [C: 031] "I will like @Robson to have a look at the user Icon you used. But if its ok, then this PS is ready for +2 and merge. I don't have the powe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [21:48:24] (03CR) 10D3r1ck01: [C: 031] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [21:48:50] 10Mobile-Content-Service, 13Patch-For-Review: MCS should quote the ETag - https://phabricator.wikimedia.org/T150886#2800243 (10bearND) deploy/2016-12-14/ae1d3c23 [21:49:32] (03PS1) 10Tjones: Move ambiguity detection into main TextCat module. [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) [21:50:21] 10Mobile-Content-Service, 13Patch-For-Review: AMGTV and Lali Esposito are back - https://phabricator.wikimedia.org/T153001#2866011 (10bearND) 05Open>03Resolved a:03bearND deploy/2016-12-14/ae1d3c23 [21:51:18] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭: Add reading depth to hovercards schema (defined as time spent on page) - https://phabricator.wikimedia.org/T147314#2874379 (10bmansurov) @jhobs, we always have misleading data, even when we pause the tim... [21:51:32] (03CR) 10Tjones: [] Move ambiguity detection into main TextCat module. (031 comment) [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) (owner: 10Tjones) [21:51:47] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016: Fixup Phan issues - https://phabricator.wikimedia.org/T153252#2874380 (10Legoktm) [21:51:50] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 2 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874381 (10D3r1ck01) Please @MtDu, do well to submit your work for review on the GCI site. Its not yet submitted for approval :) [21:52:20] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 2 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874382 (10D3r1ck01) >>! In T146834#2874300, @MtDu wrote: > Please take a look at the patch when you get a chance. > Thanks! The PS is... [21:52:56] (03PS1) 10Kaldari: Updating version and authors for PageAssessments extension [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327365 [21:54:28] 06Discovery-Search (Current work), 13Patch-For-Review: Refactor TextCat for ambiguity detection and add additional params - https://phabricator.wikimedia.org/T153105#2874387 (10TJones) [21:55:22] (03CR) 10jenkins-bot: [V: 04-1] Move ambiguity detection into main TextCat module. [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) (owner: 10Tjones) [21:56:35] 10MediaWiki-extensions-CentralAuth, 03Community-Tech-Sprint, 13Patch-For-Review, 07User-notice: Fully populate local_user_id and global_user_id fields in production - https://phabricator.wikimedia.org/T148242#2874389 (10kaldari) Script is still running. It's up to specieswiki now (going in alphabetical ord... [21:56:42] 06Discovery-Portal-Backlog, 06WMF-Communications: Wikimedia Foundation logo colour on Wikipedia.org is the wrong colour - https://phabricator.wikimedia.org/T153220#2874391 (10jrbs) [21:56:46] 07Design, 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint, 13Patch-For-Review: Wikipedia.org Portal: update logo for new branding guidelines - https://phabricator.wikimedia.org/T144834#2874394 (10jrbs) [21:57:44] (03Merged) 10jenkins-bot: Push SemanticForms back to 3.7 branch [core] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327362 (owner: 10Reedy) [21:58:33] (03PS1) 10XinyueZ: Fixed null-ptr crash if support actionbar retuns null [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327368 [21:58:53] (03CR) 10jenkins-bot: [V: 04-1] Show the user icon on watchlist page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:00:02] (03CR) 10D3r1ck01: [C: 04-1] "Ohhh, I see Jenkins is not happy with your PS, checkout the error and fix :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:00:58] 07Design, 06Collaboration-Team-Triage, 10Notifications, 13Patch-For-Review: Notices tray icon with 99+ needs more space - https://phabricator.wikimedia.org/T142454#2874400 (10Catrope) I wrote down what this would look like (it's a few simple CSS changes but I don't remember what they are), but not in a ver... [22:01:21] (03CR) 10D3r1ck01: [C: 04-1] "Check your indentation, thats what the npm console error says. Check here: https://integration.wikimedia.org/ci/job/npm-node-4/19969/conso" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:03:09] 10MediaWiki-Interface, 10MediaWiki-Page-editing, 06Collaboration-Team-Triage, 06Editing-Department, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2848049 (10Halfak) See also http://pythonhosted.org/mwreverts/ This is how I do it for #revision-... [22:03:12] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12): Upload a minor selection of images (~10 files) for SMVK-Mexiko - https://phabricator.wikimedia.org/T144358#2874404 (10Lokal_Profil) >>! In T144358#2872906, @Mattias_Ostmar-WMSE wrote: > @lokal_profil > I can't figure out 'remove double space before <... [22:03:37] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n: Strip combining diacritical marks and convert precomposed characters when searching - https://phabricator.wikimedia.org/T3836#60013 (10eranroz) Note that the search is almost non functional in he.wikisource (this affects mainly wikisource because... [22:05:17] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07WorkType-NewFunctionality: Write CX template editor illustrated translatable help page - https://phabricator.wikimedia.org/T152590#2874421 (10Amire80) I added the screenshots. I consi... [22:05:20] 10MediaWiki-Interface, 10MediaWiki-Page-editing, 06Collaboration-Team-Triage, 06Editing-Department, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2874422 (10Jdlrobson) This is what I mean.. I see lots of evidence of working around this problem... [22:11:29] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Epic: EPIC: Plan to enable BM25 on fulltext search - https://phabricator.wikimedia.org/T139575#2874445 (10eranroz) [22:11:32] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n: Strip combining diacritical marks and convert precomposed characters when searching - https://phabricator.wikimedia.org/T3836#2874446 (10eranroz) [22:11:47] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 07I18n: Strip combining diacritical marks and convert precomposed characters when searching - https://phabricator.wikimedia.org/T3836#60013 (10eranroz) Trey did some interesting analysis of the affects of stripping diacritics in the search: https://www.... [22:15:08] (03CR) 10JGirault: [C: 032] "Alright, let's make it finally happen! Good job Jan, there is quite some work there :)" (032 comments) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/319563 (https://phabricator.wikimedia.org/T136446) (owner: 10Jdrewniak) [22:17:02] d3r1ck, jdlrobson: Are you around? [22:17:17] 10UI-Standardization, 07Accessibility, 10OOjs-UI (OOjs-UI-0.18.3), 13Patch-For-Review, 03UI-Standardization-Kanban: Invalid text input `border`/`box-shadow` and dialog error border color should be set to `@destructive` - https://phabricator.wikimedia.org/T123812#2874467 (10Jdforrester-WMF) [22:17:21] 10UI-Standardization, 07Accessibility, 10OOjs-UI (OOjs-UI-0.18.3), 13Patch-For-Review, 03UI-Standardization-Kanban: Invalid text input `border`/`box-shadow` and dialog error border color should be set to `@destructive` - https://phabricator.wikimedia.org/T123812#1938556 (10Jdforrester-WMF) 05Open>03Re... [22:17:26] 10UI-Standardization, 07Accessibility, 05MW-1.28-release-notes, 10OOjs-UI (OOjs-UI-0.17.9), and 2 others: Improve color palette to comply with WCAG 2.0 min level AA and color-deficiency-friendly. - https://phabricator.wikimedia.org/T109915#2874470 (10Jdforrester-WMF) [22:19:38] (03CR) 10Divadsn: [] "@Reedy, ok, I submitted my task for review :)" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/327267 (https://phabricator.wikimedia.org/T151973) (owner: 10Divadsn) [22:19:50] (03CR) 10Reedy: [] "Looks like Jenkins is behaving now" [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [22:19:55] (03PS4) 10Reedy: Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [22:19:58] (03CR) 10Reedy: [C: 032] Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [22:20:11] (03PS2) 10Tjones: Move ambiguity detection into main TextCat module. [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) [22:21:20] (03PS2) 10Cicalese: Added nsall option. Fixed namespace and dry run handling. [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/326047 [22:21:50] (03CR) 10MtDu: [] "I'm not sure what is wrong with my indentation. I will check more in depth when I get home." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:22:59] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 07Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2874499 (10awight) [22:23:02] (03CR) 10Reedy: [] "Probably related to the ( and the [" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:24:04] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 07Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2127476 (10awight) [22:24:22] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 07Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2127476 (10awight) [22:25:36] (03Merged) 10jenkins-bot: Adding client-side translations for footer text. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/319563 (https://phabricator.wikimedia.org/T136446) (owner: 10Jdrewniak) [22:26:55] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2874525 (10Rfarrand) @srishakatux & @Qgil & I have meet. We are going with "Get Stuff Done Day" [22:27:05] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2874526 (10Rfarrand) Thanks to everyone for ideas! :) [22:27:12] 10MediaWiki-extensions-DonationInterface, 10FR-PayPal-ExpressCheckout, 10FR-Paypal, 10Fundraising-Backlog, and 2 others: [Epic] Support Express Checkout recurring donations - https://phabricator.wikimedia.org/T134446#2874527 (10awight) We still need to feed a real recurring charge (first and second!) throu... [22:27:39] (03Merged) 10jenkins-bot: Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [22:27:44] (03PS3) 10Tjones: Move ambiguity detection into main TextCat module. [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/327364 (https://phabricator.wikimedia.org/T153105) [22:27:51] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search: Allow searching by file license on Commons - https://phabricator.wikimedia.org/T152855#2874533 (10Deskana) >>! In T152855#2873042, @Aklapper wrote: > Ah.... sorry, true that. Nothing to apologise for. It's always better to report somethi... [22:29:24] (03CR) 10Smalyshev: [C: 04-1] "lgtm in general, but some code nitpicks" (0317 comments) [core] - 10https://gerrit.wikimedia.org/r/322012 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [22:31:39] (03PS1) 10XinyueZ: Fixed to re-get toolbar(actionbar) in EditSectionActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/327376 [22:31:40] 04(no projects): Make user-created userscripts (from enwiki and such) a "plugin - https://phabricator.wikimedia.org/T153262#2874539 (10Zppix) [22:32:03] 04(no projects): Make user-created userscripts (from enwiki and such) a "plugin - https://phabricator.wikimedia.org/T153262#2874552 (10Zppix) 05Open>03Invalid posted before completed task info [22:32:16] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (031 comment) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/327289 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:33:15] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/327295 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:33:26] (03CR) 10Reedy: [C: 04-1] "Use ContentHandler::getContentText()" [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/327303 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:34:13] (03CR) 10Reedy: [C: 032] "WFM" [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/327308 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:34:22] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/327295 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:34:25] 10MediaWiki-General-or-Unknown: Make user-created userscripts (from enwiki and such) a "plugin" - https://phabricator.wikimedia.org/T153263#2874556 (10Zppix) [22:34:42] (03CR) 10Reedy: [C: 04-1] "Use ContentHandler::getContentText()" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:35:25] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/327308 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:35:43] (03CR) 10Jdlrobson: [C: 032] "eslint is failing that's JS and unrelated. I'm looking into that separately." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:36:37] (03PS2) 10Jdlrobson: Feature flag FontChanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) (owner: 10Bmansurov) [22:36:46] (03PS2) 10Jdlrobson: Feature flag disabling of CentralNotice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [22:37:14] 10Social-Tools, 10SocialProfile, 03Google-Code-In-2016: SocialProfile missing api i18n messages - https://phabricator.wikimedia.org/T153264#2874570 (10Reedy) [22:37:46] (03CR) 10Arlolra: [] Don't parse language converter markup as a cell parameter in tables. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/327127 (https://phabricator.wikimedia.org/T153140) (owner: 10C. Scott Ananian) [22:38:04] (03CR) 10Reedy: [C: 04-1] "(Yes, test failure is unrelated)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/327305 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:38:15] (03Abandoned) 10C. Scott Ananian: Other language converter bugs (test case tweaks) [core] - 10https://gerrit.wikimedia.org/r/312066 (https://phabricator.wikimedia.org/T54661) (owner: 10C. Scott Ananian) [22:40:03] (03PS1) 10Ppchelko: Temporarily switch to non-flowing mode. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327378 (https://phabricator.wikimedia.org/T153122) [22:43:03] 10MobileFrontend, 06Reading-Web-Backlog: Make toasts tappable links - https://phabricator.wikimedia.org/T150189#2874594 (10Nirzar) {F5056380} we can simply treat link as underline. first i tried a separate action on the toast that says "view" or go to that page but we want to have the functionality to go to re... [22:44:02] (03CR) 10jenkins-bot: [V: 04-1] Feature flag FontChanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) (owner: 10Bmansurov) [22:45:13] (03PS1) 10Reedy: Fix CI errors [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327379 [22:45:26] (03CR) 10jenkins-bot: [V: 04-1] Show the user icon on watchlist page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:45:51] (03PS1) 10Jdlrobson: Fix linting issues due to upgrade on eslint-config-wikimedia [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327380 [22:46:28] (03PS2) 10Jdlrobson: Show the user icon on watchlist page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [22:46:55] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 3 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874599 (10Jdlrobson) [22:47:08] 10MediaWiki-Language-converter, 10MediaWiki-Parser: Language converter source text and language names cannot use escaping. - https://phabricator.wikimedia.org/T153265#2874600 (10cscott) [22:47:11] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 3 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2672399 (10Jdlrobson) The patch is blocked from merging on https://gerrit.wikimedia.org/r/327380 [22:47:42] (03CR) 10jenkins-bot: [V: 04-1] Feature flag disabling of CentralNotice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [22:47:57] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 4 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874620 (10Jdlrobson) [22:48:00] 10MediaWiki-extensions-SimpleSecurity, 03Google-Code-In-2016: Move SimpleSecurity classes to seperate files - https://phabricator.wikimedia.org/T153266#2874621 (10Reedy) [22:48:11] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2874634 (10divadsn) a:03divadsn I will work to fix this to get the other patch merged as soon as possible :) [22:48:14] (03CR) 10Reedy: [C: 032] Fix CI errors [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327379 (owner: 10Reedy) [22:48:49] 10MediaWiki-extensions-SimpleSecurity, 03Google-Code-In-2016: Move SimpleSecurity classes to separate files - https://phabricator.wikimedia.org/T153266#2874637 (10Reedy) [22:48:59] (03PS2) 10Cenarium: Autopromote: Remove superflous condition in APCOND_EDITCOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/264232 [22:49:04] (03CR) 10Cicalese: [] "Well, that was easy :-) It was indeed my fault: a line that was too long. It is now fixed." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/326047 (owner: 10Cicalese) [22:49:13] (03Merged) 10jenkins-bot: Fix CI errors [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327379 (owner: 10Reedy) [22:49:17] (03PS13) 10Bearloga: [WIP] Migrate to Reportupdater framework [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/325870 [22:50:01] (03CR) 10Reedy: [] "recheck" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327298 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:50:07] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data (since around 2016-11-28) - https://phabricator.wikimedia.org/T151770#2874646 (10Anomie) >>! In T151770#2873767, @Legoktm wrote: > If browsers are corrupting cookies this often, we should work around it somehow an... [22:51:33] (03CR) 10Reedy: [C: 032] "Article::getContent()" is deprecated in MediaWiki 1.21 [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327298 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:52:25] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2874648 (10Rfarrand) MONDAY: Unconference organizers need to be at venue at 8:50 to register. There will be one early bus leaving CQ 10 mi... [22:52:33] (03Merged) 10jenkins-bot: "Article::getContent()" is deprecated in MediaWiki 1.21 [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/327298 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [22:53:32] 10MediaWiki-Page-editing, 06Community-Tech, 07Persona-New-Editor: Steer new editors to WikiVoyage to contribute subjective info - https://phabricator.wikimedia.org/T153267#2874650 (10Ejegg) [22:55:02] (03PS1) 10Jdlrobson: Use 0.4.0 of wikipedia-edits-scorer [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327385 [22:55:21] (03PS2) 10Jdlrobson: Use 1.4.0 of wikipedia-edits-scorer [services/trending-edits] - 10https://gerrit.wikimedia.org/r/327385 [22:56:06] (03CR) 10Aaron Schulz: [] "I see a lot of duplication and complexity here." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/194988 (https://phabricator.wikimedia.org/T51787) (owner: 10Cenarium) [22:56:52] (03PS6) 10Cenarium: Don't always display review notice if autoreviewed, specify if autoreviewed [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255811 (https://phabricator.wikimedia.org/T60057) [22:57:11] (03CR) 10Aaron Schulz: [] "For style consistency, yes, WANCache is better than $wgMemc. That should probably be updated at some point." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/194988 (https://phabricator.wikimedia.org/T51787) (owner: 10Cenarium) [22:59:32] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2874723 (10kaldari) @Marostegui: It's taking much longer than I expected. One thing that I've learned is that I'm terrible at esti... [22:59:50] 10LinkFilter, 10Social-Tools, 03Google-Code-In-2016: LinkFilter missing api i18n messages - https://phabricator.wikimedia.org/T153238#2874724 (10Reedy) You might need a bit of back and forth with CI to make the tests to pass, but shouldn't be anything excessive [23:00:47] 10MediaWiki-Interface, 10MediaWiki-Page-editing, 06Collaboration-Team-Triage, 06Editing-Department, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2874725 (10Halfak) Agreed. I'd like to have a log item that captures what my `Revert` objects do.... [23:02:29] (03PS5) 10Jdlrobson: Add additional information to file and user pages for rendering [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326178 (https://phabricator.wikimedia.org/T148118) [23:03:38] 10MobileFrontend, 06Reading-Web-Backlog, 07Regression: IEMobile/9.0 on Windows Phone 7.x: RTL mobile WP Main Pages layouts broken - https://phabricator.wikimedia.org/T140651#2874738 (10Nicholas.tsg) Credentials OS: Windows Phone 8.1 (Nokia Lumia 520) Browser: Internet Explorer mobile version According to th... [23:04:35] 10MediaWiki-General-or-Unknown, 05Release: Release MediaWiki 1.29 - https://phabricator.wikimedia.org/T153271#2874741 (10greg) [23:04:46] 10MediaWiki-General-or-Unknown, 05MW-1.29-release, 05Release: Release MediaWiki 1.29 - https://phabricator.wikimedia.org/T153271#2874753 (10greg) [23:05:17] 10MobileFrontend, 06Reading-Web-Backlog: Make toasts tappable links - https://phabricator.wikimedia.org/T150189#2874754 (10ovasileva) @Nirzar - looks good! [23:05:42] (03CR) 10Jdlrobson: [C: 04-1] "It was my understanding in standup you said we were going to remove this flag altogether as there doesn't seem to be a need for a feature " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:06:29] 10MediaWiki-General-or-Unknown, 05MW-1.29-release, 05Release, 03releng-201617-q4: Release MediaWiki 1.29 - https://phabricator.wikimedia.org/T153271#2874741 (10greg) [23:07:01] (03CR) 10Subramanya Sastry: [] "I am also confused by the additional of gallery tests in this patch .. and they don't seem to have any language converter markup necessari" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/76341 (https://phabricator.wikimedia.org/T54190) (owner: 10Liangent) [23:07:17] (03CR) 10Jdlrobson: [C: 031] "I'm fine with this, but I have a feeling Piotr will want a unit test of some sort :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326841 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:10:11] 10MediaWiki-Internationalization, 10Wikidata: Norwegian messages inContentLanguage look for on-wiki overrides at the /nb subpage, not the root page - https://phabricator.wikimedia.org/T126146#2874779 (10greg) p:05Triage>03Unbreak! This is blocking an UBN! task, so setting this appropriately. Please re-tria... [23:10:58] (03PS1) 10Catrope: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) [23:11:33] (03CR) 10Aaron Schulz: [C: 032] ApiFlow: Determine write mode on a per-submodule basis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/327302 (https://phabricator.wikimedia.org/T120543) (owner: 10Catrope) [23:12:28] 10MediaWiki-Interface, 10MediaWiki-Page-editing, 06Collaboration-Team-Triage, 06Editing-Department, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2874797 (10Tgr) Except for rollback, the user can arbitrarily edit the text. Should pressing undo... [23:12:52] (03CR) 10Jdlrobson: [C: 04-1] Remove SkinMinervaBeta.php (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326850 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:13:00] 10MediaWiki-General-or-Unknown, 15User-Daniel, 15User-Nikerabbit: Unable to overwrite services using MediaWikiServices hook - https://phabricator.wikimedia.org/T153256#2874800 (10daniel) p:05Triage>03High if you are right, that would be bad :) I need to check and think, though. There is a misunderstandin... [23:13:12] (03CR) 10Kaldari: [C: 032] Updating version and authors for PageAssessments extension [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327365 (owner: 10Kaldari) [23:15:29] AaronSchulz: Thanks! [23:15:42] 10MobileFrontend, 06Reading-Web-Backlog: Make toasts tappable links - https://phabricator.wikimedia.org/T150189#2874804 (10Nirzar) [23:16:01] (03Merged) 10jenkins-bot: Updating version and authors for PageAssessments extension [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/327365 (owner: 10Kaldari) [23:16:27] Reedy: How long will you be around? I might replace some getContent functions if you are. [23:17:39] (03CR) 10Jforrester: [C: 032] Fix linting issues due to upgrade on eslint-config-wikimedia [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327380 (owner: 10Jdlrobson) [23:18:18] (03PS15) 10Jdlrobson: Make mobile-friendly version of the Notifications page left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [23:18:35] MtDu: Probably another hour or so. But I would review any other stuff in the morning [23:18:45] (03CR) 10Jdlrobson: [C: 032] Add .eslintcache to gitignore [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327363 (owner: 10BearND) [23:19:58] Reedy: Alright. I'll just wait then. I have three more exams tomorrow. there's plenty left right? :) [23:20:13] MtDu: I'm not sure... but we've got various tasks getting lined up to go up :) [23:20:22] Some ContentHandler hooks.. [23:20:27] And some other completely unrelated stuff [23:20:46] Reedy, Ah yes. Can you review my hook one from a few days ago? I'm not sure why jenkins wasn't happy. [23:20:56] (03CR) 10Mattflaschen: [C: 032] Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) (owner: 10Catrope) [23:21:18] Neither was I when I looked before... [23:21:41] Reedy, https://gerrit.wikimedia.org/r/#/c/325735/. Ok. Hm.... [23:21:59] MtDu: Oh, yeah I am [23:22:04] MtDu: BTW did you ever get around to the Thanks/Echo icon thing? [23:22:06] MtDu: You killed the [] [23:22:40] (03PS11) 10Paladox: Move function to seperate file [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/225710 [23:22:42] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hooks (032 comments) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [23:23:09] (03CR) 10Paladox: "recheck" [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/324030 (https://phabricator.wikimedia.org/T151842) (owner: 10Paladox) [23:23:32] (03PS4) 10MtDu: Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) [23:23:46] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2874823 (10srishakatux) 05Open>03Resolved [23:23:52] Reedy, Ah. Ok. My bad. :p [23:24:01] MtDu: There's gonna be a GCI task for that... [23:24:20] Reedy, Oh. I guess I'll have to do another one then. [23:24:46] (03CR) 10jenkins-bot: [V: 04-1] Move function to seperate file [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/225710 (owner: 10Paladox) [23:25:00] (03CR) 10Jdlrobson: [C: 032] mobile-sections: remove unnecessary TextExtract request [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327142 (owner: 10BearND) [23:25:09] MtDu: I'd like to give you credit for it [23:25:15] Considering it was always going to be a GCI task [23:25:32] I can't even publish tasks, otherwise I'd create a simple one for your credit [23:26:06] Maybe we can deal with it when we get it filed [23:26:23] (03PS5) 10Paladox: Move functions to own file [extensions/SharedCssJs] - 10https://gerrit.wikimedia.org/r/239407 (https://phabricator.wikimedia.org/T100178) [23:26:46] Reedy, Ok. Can you talk to Andre about it? Because I ran into a similar situation for https://gerrit.wikimedia.org/r/#/c/326179/, https://gerrit.wikimedia.org/r/#/c/326186/, and https://gerrit.wikimedia.org/r/#/c/326197/, where I pushed patches, but they removed from GCi because of some rule. [23:26:49] MtDu: we can hold off merging it if you want :P [23:26:49] (03PS7) 10Paladox: Fix sql [extensions/SacredText] - 10https://gerrit.wikimedia.org/r/239173 (https://phabricator.wikimedia.org/T112400) [23:27:02] Reedy: Yeah, let's do that I guess. [23:27:12] (03CR) 1020after4: [C: 031] Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) (owner: 10Catrope) [23:27:16] Wasn't it commits made before GCI? [23:27:28] Technically, this was made after etc [23:27:31] (03PS19) 10Paladox: Add grunt-jsonlint, Update packages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/264970 [23:27:36] (03CR) 10Cenarium: [] Don't always display review notice if autoreviewed, specify if autoreviewed (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255811 (https://phabricator.wikimedia.org/T60057) (owner: 10Cenarium) [23:28:05] Reedy, I made them during GCI. Like I had done a bunch of other ones like it, so I went ahead and did them all. They ahd already had the GCI project added. But whatevers. [23:28:15] Reedy, Yeah. We'll figure it out. :) [23:28:24] (03Merged) 10jenkins-bot: Fix linting issues due to upgrade on eslint-config-wikimedia [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327380 (owner: 10Jdlrobson) [23:28:27] (03Merged) 10jenkins-bot: Show the user icon on watchlist page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/327361 (https://phabricator.wikimedia.org/T146834) (owner: 10MtDu) [23:28:29] (03Merged) 10jenkins-bot: Add .eslintcache to gitignore [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327363 (owner: 10BearND) [23:28:48] @RoanKattouw: I'd love to work on it. I have 3 more exams in my way. I can probably get to it this weekend. Sorry for pushing it off for so long. :p [23:28:49] (03PS20) 10Paladox: Add grunt-jsonlint, Update packages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/264970 [23:29:32] @RoanKattouw: Is that ok? Also, I'd probably need your guidance. I rembember taking a look, and it seems more complicated than the ones I've done. [23:29:41] (03PS8) 10Paladox: Changing jshint configuation [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/269320 [23:30:49] MtDu: Yeah, no worries, just wondering / reminding [23:31:06] @RoanKattouw, Yeah thanks! Hope you're doing well. :) [23:31:09] No rush [23:31:59] MtDu: Yup, doing good. Heading home for the holidays, currently working from airplane wifi over Tennessee somewhere [23:32:22] @RoanKattouw: Ah. I'm in Tennessee. :) Are you from the US or going overseas? [23:32:27] 10MediaWiki-Interface, 10MediaWiki-Page-editing, 06Collaboration-Team-Triage, 06Editing-Department, and 3 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#2848049 (10Mattflaschen-WMF) >>! In T152434#2874797, @Tgr wrote: > Should pressing undo + editing... [23:32:49] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 3 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2672399 (10Jdlrobson) [23:32:51] MtDu: No, he just sounds like an American when speaking :P [23:32:55] (03PS12) 10Paladox: Add composer.json [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/276968 (https://phabricator.wikimedia.org/T129744) [23:33:10] Reedy, Haha. I'm thinking about doing this, https://phabricator.wikimedia.org/T153243, but it's listed as beginner. [23:33:33] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), 07Wikimedia-log-errors: Warning: No such file or directory in /srv/mediawiki/php-1.29.0-wmf.6/extensions/MobileFrontend/includes/api/ApiWebappMan... - https://phabricator.wikimedia.org/T153250#2874847 [23:33:47] Reedy, It seems MWContentSerializationException is empty? [23:33:47] (03Merged) 10jenkins-bot: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/327387 (https://phabricator.wikimedia.org/T153261) (owner: 10Catrope) [23:33:51] (03Merged) 10jenkins-bot: mobile-sections: remove unnecessary TextExtract request [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327142 (owner: 10BearND) [23:35:07] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, and 2 others: MobileFrontend should adopt an app manifest - https://phabricator.wikimedia.org/T108878#2874855 (10Jdlrobson) A follow up will be required - T153250 - @Rudloff not sure if you have time to look before me? [23:35:40] (03PS1) 1020after4: Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327393 (https://phabricator.wikimedia.org/T153261) [23:35:44] (03PS6) 10Paladox: Add npm entry point [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/280777 [23:35:47] MtDu: The typing/names for exceptions is useful enough for catching specific types [23:35:54] (03CR) 1020after4: [C: 032] Follow-up d66771523c2: unbreak ext.echo.emailicons module [extensions/Echo] (wmf/1.29.0-wmf.6) - 10https://gerrit.wikimedia.org/r/327393 (https://phabricator.wikimedia.org/T153261) (owner: 1020after4) [23:35:57] Reedy: Ah ok. [23:35:59] (03CR) 10jenkins-bot: [V: 04-1] Make mobile-friendly version of the Notifications page left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [23:37:42] (03Abandoned) 10Paladox: Update jQuery to 3.0.0 [core] - 10https://gerrit.wikimedia.org/r/293522 (https://phabricator.wikimedia.org/T124742) (owner: 10Paladox) [23:38:12] (03Abandoned) 10Paladox: Update grunt-jsonlint to 1.1.0 [core] - 10https://gerrit.wikimedia.org/r/293903 (https://phabricator.wikimedia.org/T137631) (owner: 10Paladox) [23:39:40] (03PS1) 10BearND: Also show announcements on beta cluster [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327394 [23:39:47] (03PS2) 10Paladox: Update phpunit to 4.8.31 [core] - 10https://gerrit.wikimedia.org/r/291927 [23:40:37] (03PS3) 10Paladox: Update phpunit to 4.8.31 [core] - 10https://gerrit.wikimedia.org/r/291927 [23:41:28] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 03Google-Code-In-2016, and 3 others: User icon does not show on watchlist page - https://phabricator.wikimedia.org/T146834#2874866 (10MtDu) Should we close as resolved or do we need to wait? @Jdlrobson [23:41:34] 10MediaWiki-API, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Can't edit transcluded sections - https://phabricator.wikimedia.org/T153176#2874868 (10Esanders) [23:42:28] Reedy, Let me know when the hooks one is in the site, and I'll claim it. :) [23:43:00] (03PS1) 10BearND: Hygiene: remove extracts.js [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327396 [23:43:03] (03CR) 10Yurik: [C: 04-1] Implement basic Dashiki extension (032 comments) [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) (owner: 10Milimetric) [23:43:49] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Special:RecordImpression shouldn't be a blank page - https://phabricator.wikimedia.org/T153228#2873497 (10AndyRussG) @MarcoAurelio Thanks for flagging this! Special:RecordImpression used to be the endpoint that CentralNotice called to record banner i... [23:43:58] (03CR) 10Yurik: [C: 04-1] "oh, and btw, while you could add ro translations from the start, I would advise to only add en & qqq. Everything else is much better to ma" [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/323178 (https://phabricator.wikimedia.org/T125403) (owner: 10Milimetric) [23:44:06] (03PS5) 10Paladox: Move all functions into hooks file in preparation for extension.json [extensions/Collection] - 10https://gerrit.wikimedia.org/r/304206 (https://phabricator.wikimedia.org/T87899) [23:44:11] (03CR) 10Arlolra: [C: 032] Record totals in categories in statsd [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325892 (https://phabricator.wikimedia.org/T152664) (owner: 10Legoktm) [23:44:20] (03Abandoned) 10Paladox: Switch to eslint from jscs and jshint for our linting [core] - 10https://gerrit.wikimedia.org/r/307286 (https://phabricator.wikimedia.org/T118941) (owner: 10Paladox) [23:44:34] MtDu: I'm hoping to get that one up in the morning [23:44:55] Reedy: Alright. But there will be plenty of instances right, so I don't need to be worried about claiming it later? [23:45:16] (03Abandoned) 10Paladox: Support changing tags even if you merged the change all ready [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/310982 (https://phabricator.wikimedia.org/T37534) (owner: 10Paladox) [23:46:03] (03PS2) 10Paladox: Replace DB begin()/commit() with startAtomic()/endAtomic() as needed [extensions/LiveTranslate] (REL1_27) - 10https://gerrit.wikimedia.org/r/312802 (https://phabricator.wikimedia.org/T120791) [23:46:41] MtDu: I think there's about 20 extensions to fix, so yeah [23:46:44] (03PS2) 10Paladox: Remove begin()/commit() calls that can break outer transactions [extensions/Survey] (REL1_27) - 10https://gerrit.wikimedia.org/r/312801 (https://phabricator.wikimedia.org/T120791) [23:46:46] Probably 1 task per extension [23:46:47] 10MediaWiki-API, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Can't edit transcluded sections - https://phabricator.wikimedia.org/T153176#2874881 (10Esanders) Ignore that - I've misread the URL - we're going to have to do a redirect... [23:46:58] (03Abandoned) 10Paladox: Allow reset of global services (redux). [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/314572 (https://phabricator.wikimedia.org/T147511) (owner: 10Paladox) [23:47:00] Reedy, Oh, so I can do more. :) [23:47:15] Reedy, Yeah, I wish I could be online more. Just exponentially busier than last year. :p [23:47:16] (03PS4) 10Paladox: Replace ArticleSaveComplete hook usage [extensions/DidYouMean] - 10https://gerrit.wikimedia.org/r/315110 (https://phabricator.wikimedia.org/T147390) [23:47:23] MtDu: Seems it's nogo on that patch [23:47:26] So we can get that merged [23:47:36] nogo for GCI [23:47:36] Reedy, Alright. :( [23:47:41] 07Documentation, 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2874884 (10Pppery) [23:47:43] Keep your patches to yourself [23:47:45] *cough* [23:47:46] (03PS4) 10Paladox: Replace ArticleSaveComplete hook usage [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/315112 (https://phabricator.wikimedia.org/T147390) [23:51:01] (03PS5) 10Paladox: Replace deprecated Linker::link() with MediaWiki\Linker\LinkRenderer [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/318274 [23:52:17] 10MediaWiki-General-or-Unknown: Make user-created userscripts (from enwiki and such) a "plugin" - https://phabricator.wikimedia.org/T153263#2874891 (10Aklapper) Hi @Zppix, thanks for taking the time to report this! Unfortunately this report lacks some information: A description of an actual problem to solve. If... [23:52:36] (03Abandoned) 10Paladox: Test: Do not submit [core] - 10https://gerrit.wikimedia.org/r/318787 (owner: 10Paladox) [23:54:17] (03Abandoned) 10Paladox: Fix $wgShowExceptionDetails to work without having to set $wgShowDBErrorBacktrace [core] - 10https://gerrit.wikimedia.org/r/322739 (https://phabricator.wikimedia.org/T148957) (owner: 10Paladox) [23:54:51] Reedy, Alright. I'll see you around. [23:55:08] (03Abandoned) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/325129 (owner: 10Paladox) [23:55:15] (03CR) 10Reedy: [C: 032] Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [23:58:26] (03PS7) 10Paladox: [examples] Update tests [extensions/examples] - 10https://gerrit.wikimedia.org/r/244750 [23:59:25] (03CR) 10BearND: [] "I think in CI we'd want this, too. I see lots of timeouts (504s) lately." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/327023 (owner: 10BearND)