[00:03:21] 10Wikimedia-Site-requests: hewiki asks to change default image sizes for thumb and gallery - https://phabricator.wikimedia.org/T43712#2863948 (10Dereckson) @Gilles Would you have an opinion on this task, so we can have a coherent response for T113877 and this one? [00:04:38] legoktm, Around? Hope studying for exams has been productive and fun. :) [00:27:33] 10Wikimedia-Site-requests: Give `abusefilter-private` permission to checkusers at FA WP - https://phabricator.wikimedia.org/T152934#2863957 (10Huji) [00:32:23] (03CR) 10BryanDavis: [C: 032] Add a question about scholarship in past year, remove previous attendance qns [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326103 (https://phabricator.wikimedia.org/T151366) (owner: 10Niharika29) [00:33:31] (03Merged) 10jenkins-bot: Add a question about scholarship in past year, remove previous attendance qns [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326103 (https://phabricator.wikimedia.org/T151366) (owner: 10Niharika29) [00:35:24] 10MediaWiki-General-or-Unknown, 07Documentation: new HtmlPageLinkRenderer[Begin|End] hooks not documented - https://phabricator.wikimedia.org/T152935#2863973 (10stronk7) [00:38:12] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Convert Special:DeletedContributions to OOUI - https://phabricator.wikimedia.org/T134525#2863987 (10Volker_E) [00:42:44] 10Wikimedia-Site-requests: Give `abusefilter-private` permission to checkusers at FA WP - https://phabricator.wikimedia.org/T152934#2863957 (10MarcoAurelio) No, that must not happen. The abusefilter-private right is globally disabled at WMF because it gives unlogged access to user's private data and that is unna... [00:45:22] 10Wikimedia-Site-requests: Give `abusefilter-private` permission to checkusers at FA WP - https://phabricator.wikimedia.org/T152934#2864007 (10Huji) Hmm. You are right, I didn't think about the fact that it is not logged. This information would be tremendously helpful though. Is there any desire to perhaps modi... [00:51:12] 10Wikimedia-Site-requests: Give `abusefilter-private` permission to checkusers at FA WP - https://phabricator.wikimedia.org/T152934#2863957 (10Platonides) That would need to be the first step before this could be granted. [00:54:25] Is there any mediawiki tool for populating a development wiki with lots of dummy data (pages and users and what not)? [00:57:03] (03PS1) 10BryanDavis: Change goals question to be about past reports instead [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326378 (https://phabricator.wikimedia.org/T151366) [01:10:13] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2864017 (10Reedy) Article::getContent() ```lines=10 Method... [01:10:32] (03PS1) 10Reedy: WikiPage::prepareTextForEdit() was removed [core] - 10https://gerrit.wikimedia.org/r/326382 [01:12:20] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Convert Special:DeletedContributions to OOUI - https://phabricator.wikimedia.org/T134525#2864018 (10Volker_E) @Quiddity Thanks for providing the pointer. It's ~260px high box currently. No, we don't h... [01:12:56] (03PS2) 10Reedy: WikiPage::prepareTextForEdit() was removed [core] - 10https://gerrit.wikimedia.org/r/326382 (https://phabricator.wikimedia.org/T145728) [01:21:01] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.3), 03UI-Standardization-Kanban: Improve form layouts in OOUI MW core forms for better user experience - https://phabricator.wikimedia.org/T136790#2864020 (10Volker_E) @BethNaught Not necessarily as general rule, but in specific cases, like in the form above prov... [01:50:43] (03CR) 10Jforrester: [C: 032] Call setHeaders() in SpecialNewPagesFeed::execute() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/325611 (https://phabricator.wikimedia.org/T152319) (owner: 10Catrope) [01:51:05] (03CR) 10Isarra: "Thank you for this! This has now been redone as part of the skin rewrite, however." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/265212 (https://phabricator.wikimedia.org/T87875) (owner: 10MtDu) [01:51:35] (03Abandoned) 10Isarra: Deprecate and empty PHP entry point [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/265212 (https://phabricator.wikimedia.org/T87875) (owner: 10MtDu) [01:51:46] (03Merged) 10jenkins-bot: Call setHeaders() in SpecialNewPagesFeed::execute() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/325611 (https://phabricator.wikimedia.org/T152319) (owner: 10Catrope) [02:07:10] 04(no projects): Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864030 (10Huji) p:05Triage>03Normal [02:07:22] 10MediaWiki-extensions-Babel: Babel Extension - Issue with ASE language code - https://phabricator.wikimedia.org/T152925#2863705 (10StevenJ81) We have substantially the same problem with "jam" (Jamaican patois). If I hard-code "jam-0" the userbox reads (in //jam,// to be sure) "This user has no knowledge of Engl... [02:16:54] 10MediaWiki-extensions-Babel, 07I18n: Babel Extension - Issue with ASE language code - https://phabricator.wikimedia.org/T152925#2864037 (10Reedy) [02:22:38] 04(no projects): Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864038 (10Huji) Here is my proposed solution. Let me know if anything needs to be changed. If not, I will start working on it. Instead of showing private information on... [02:23:22] 10AbuseFilter: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864039 (10Reedy) [02:39:15] 10Social-Tools, 07Documentation: Organize release notes of social tools extensions - https://phabricator.wikimedia.org/T152928#2864041 (10SamanthaNguyen) [02:52:59] 10UI-Standardization, 03UI-Standardization-Kanban: MediaWiki theme: Set `line-height` explicitely on form legends and labels - https://phabricator.wikimedia.org/T152937#2864042 (10Volker_E) [02:53:04] 10UI-Standardization, 03UI-Standardization-Kanban: MediaWiki theme: Set `line-height` explicitely on form legends and labels - https://phabricator.wikimedia.org/T152937#2864042 (10Volker_E) [02:56:56] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2864057 (10Tgr) @Theklan if you can reproduce, could you upload in a private paste the exact request network details? (On Chrome or Firefox, press F12 to bring up the Developer Toolbar, then select Net... [03:22:32] 10Refreshed: Refreshed: Header floats above content with wikitable in site notice - https://phabricator.wikimedia.org/T152939#2864074 (10labster) [03:24:05] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2864085 (10Tbayer) Here is a screenshot from "Inspect Element" on Firefox - let me know in case a different view is needed. {F5039502} [03:42:34] 06Brickimedia, 10Refreshed: Refreshed is zoomable on mobile, which allows the user interface to break - https://phabricator.wikimedia.org/T146114#2651116 (10labster) As of iOS 10, all pages are zoomable. There is no API to prevent zooming on a page. http://stackoverflow.com/questions/4389932/how-do-you-disab... [03:45:04] 10AbuseFilter, 06Security-Team: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864088 (10Peachey88) [03:55:53] 10Wikimedia-General-or-Unknown, 07I18n: [[Wikimedia:Wsa-form-rights2/ast]] i18n issue - https://phabricator.wikimedia.org/T152940#2864091 (10Oriciu) [03:58:44] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2864103 (10Ghouston) Thanks, that fixes it for me. I guess the load order was changing between the working and non-working versions, maybe depending on whether the files were... [03:59:45] legoktm, if something extends querypage which extends specialpage, can I just use $this->getLinkRenderer() or do I need to get Context? [04:03:47] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2864104 (10Ghouston) Correction, that's javascript.options.strict. [04:20:06] (03PS1) 10MtDu: Replace Linker::link*() usage with LinkRenderer and conver to use [] array syntax [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326384 [04:20:43] (03CR) 10MtDu: "Just thought that this would be useful. Let me know if this shouldn't be done. :)" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326384 (owner: 10MtDu) [04:21:04] (03CR) 10jenkins-bot: [V: 04-1] Replace Linker::link*() usage with LinkRenderer and conver to use [] array syntax [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326384 (owner: 10MtDu) [04:22:24] (03PS2) 10MtDu: Replace Linker::link*() usage with LinkRenderer and conver to use [] array syntax [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326384 [04:25:30] (03PS3) 10MtDu: Replace Linker::link*() usage with LinkRenderer and convert to use [] array syntax [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326384 [04:40:41] (03PS20) 10Sn1per: [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) [04:48:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) (owner: 10Sn1per) [04:49:34] (03PS1) 10Jo12bar: Use global variable for tablet media query in responsive.less [skins/Vector] - 10https://gerrit.wikimedia.org/r/326385 (https://phabricator.wikimedia.org/T124994) [05:10:04] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint: Database error when paginating through results at Special:PageAssessments - https://phabricator.wikimedia.org/T152756#2864149 (10Samwilson) [06:04:00] (03CR) 10Fomafix: [C: 031] "The server generated hidden progress bar is surely a very clean way but is has the disadvantage that it generates an additional space that" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [06:08:02] (03CR) 10Fomafix: [C: 031] Convert legacy bugs ID to Phabricator tasks ID for Parser class [core] - 10https://gerrit.wikimedia.org/r/326372 (owner: 10Dereckson) [06:33:32] 10MediaWiki-extensions-PageAssessments, 06Community-Tech: Add auto-suggest to Special:PageAssessments form fields - https://phabricator.wikimedia.org/T152758#2864151 (10Samwilson) [06:35:28] tonythomas, are you here? [06:43:28] (03CR) 10McIntireEvan: [C: 031] "LGTM. Would be great if someone else took a look at the unit test - it should be fine, but it never hurts to have another set of eyes." [core] - 10https://gerrit.wikimedia.org/r/325802 (https://phabricator.wikimedia.org/T34496) (owner: 10Subins2000) [06:51:55] McIntireEvan: Thanks :) [07:02:09] (03PS1) 10Jhobs: Make implicit dependency on mw.Uri explicit [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326387 [07:09:00] 10MediaWiki-API, 06Operations, 10Parsoid, 10RESTBase, and 6 others: HHVM request timeouts not working; support lowering the API request timeout per request - https://phabricator.wikimedia.org/T97192#2864158 (10Joe) >>! In T97192#2860191, @Anomie wrote: > Tried my code from T97192#1237258 with `hhvm.server.... [07:23:18] (03CR) 10Raimond Spekking: "As far as I can see this patch set is a no-op. Only the comments were removed. Or do I misread the patch?" [core] - 10https://gerrit.wikimedia.org/r/326138 (https://phabricator.wikimedia.org/T151633) (owner: 10Dereckson) [07:25:51] (03CR) 10Thiemo Mättig (WMDE): "recheck" [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [07:26:03] (03PS1) 10Samwilson: Switch special page to be a QueryPage rather than using an IndexPager [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) [07:26:31] (03CR) 10Robert Vogel: [C: 032] BSInsertCategory: Added integration for UploadPanel [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/324697 (owner: 10Robert Vogel) [07:27:11] (03CR) 10Robert Vogel: [C: 032] CategoryBoxSelect: Added "tree-trigger" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/324735 (owner: 10Robert Vogel) [07:27:23] (03CR) 10jenkins-bot: [V: 04-1] Switch special page to be a QueryPage rather than using an IndexPager [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) (owner: 10Samwilson) [07:27:48] (03Merged) 10jenkins-bot: BSInsertCategory: Added integration for UploadPanel [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/324697 (owner: 10Robert Vogel) [07:28:56] (03Merged) 10jenkins-bot: CategoryBoxSelect: Added "tree-trigger" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/324735 (owner: 10Robert Vogel) [07:30:09] (03PS2) 10Samwilson: Switch special page to be a QueryPage rather than using an IndexPager [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) [07:32:33] (03CR) 10jenkins-bot: [V: 04-1] Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [07:33:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Expand .gitignore for more editors [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/326096 (owner: 10Umherirrender) [07:33:29] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Expand .gitignore for more editors [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/326094 (owner: 10Umherirrender) [07:34:30] (03Merged) 10jenkins-bot: Expand .gitignore for more editors [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/326096 (owner: 10Umherirrender) [07:35:13] (03Merged) 10jenkins-bot: Fix MessagesDirs in extension.json [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/326097 (owner: 10Umherirrender) [07:35:16] (03Merged) 10jenkins-bot: Expand .gitignore for more editors [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/326094 (owner: 10Umherirrender) [07:35:18] (03Merged) 10jenkins-bot: Fix MessagesDirs in extension.json [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/326095 (owner: 10Umherirrender) [07:36:00] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam - Replace "wfMessage(" with "$this->msg" in SpecialPages - https://phabricator.wikimedia.org/T152852#2864174 (10Florian) 05Open>03Resolved a:05FilipGCI>03MtDu Already done in: https://gerrit.wikimedia.org/r/#/c/326243/ [07:38:16] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks good so far. Looking forward to merge this." (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/326156 (owner: 10Cenarium) [07:41:55] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2861692 (10zhuyifei1999) >>! In T152839#2863786, @matmarex wrote: > The issue was caused by this edit to the gadget: https://commons.wikimedia.org/w/index.php?title=MediaWiki... [07:42:03] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2864181 (10Mvolz) [07:42:06] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam - Replace "wfMessage(" with "$this->msg" in SpecialPages - https://phabricator.wikimedia.org/T152852#2864183 (10Mvolz) [07:42:30] 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Other, and 4 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#2864186 (10Mvolz) [07:42:33] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2861456 (10Mvolz) 05Open>03Resolved a:03MtDu [07:43:56] (03CR) 10Fomafix: [C: 04-1] Mark pages on watchlist as visited using JS without reload (032 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [07:50:31] 10Tabular-Data, 03Interactive-Sprint: Support `null` to indicate a missing value - https://phabricator.wikimedia.org/T152753#2864187 (10Yurik) From extensive conv at https://gitter.im/frictionlessdata/chat - seems by the standard, `null` is always implicitly allowed, and to prevent that, the schema supports `c... [08:00:25] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2864195 (10Theklan) {F5039980} [08:05:27] 06Brickimedia, 10Refreshed: Integrate closable/openable content sections in Refreshed skin - https://phabricator.wikimedia.org/T143511#2570163 (10labster) Nope. The sectioning is done here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L541 That loo... [08:07:54] McIntireEvan: Should I mark my GCI task for review ? [08:07:59] @seen McIntireEvan [08:07:59] subins2000: McIntireEvan is in here, right now [08:15:11] (03CR) 1001tonythomas: "@Georggi: Thinking of it earlier today, I too agree that we can remove parts of it (since we do not want to show too much of info to users" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [08:17:30] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Align mediawiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2864198 (10Qgil) [08:18:02] (03CR) 10Georggi199: "Well, basically what I suggested in the first place." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [08:39:32] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864215 (10mmodell) @paladox: I always test before deploying to prod. Thanks for catching this though. [08:39:36] Hi, I'm new and would like to contribute. Can someone get me started? Thanks. [08:40:19] 10Tabular-Data, 03Interactive-Sprint: Create a demo for tabular data introduction - https://phabricator.wikimedia.org/T152765#2864220 (10Yurik) * Auto-generated HTML (text) table, similar to original: [[ https://en.wikipedia.org/wiki/User:Yurik/WeatherDemo | User:Yurik/WeatherDemo ]] * Heat map experiment - [[... [08:42:11] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864221 (10Paladox) Oh, your welcome. [08:43:08] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864222 (10mmodell) 05Open>03Resolved a:03mmodell [08:45:54] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2864226 (10Tgr) Got it, thanks! I asked an admin to delete it since it contains private data and was uploaded as public (I can send it to anyone else who wants to do some debugging). I'll look into it... [08:48:37] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864227 (10Paladox) @mmodell hi why close this as resolved? [08:48:50] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Technical-Debt (RW-Tech-Debt): Finish refactoring instrumentation - https://phabricator.wikimedia.org/T152225#2864229 (10phuedx) Over to @Jhernandez for initial review. There are two events missing –... [08:49:58] (03CR) 10Foxtrott: [V: 032 C: 032] Consistently use tabs for indentation in composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/325529 (owner: 10Legoktm) [08:50:36] (03Merged) 10jenkins-bot: Consistently use tabs for indentation in composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/325529 (owner: 10Legoktm) [08:51:01] (03PS1) 10Gergő Tisza: [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) [08:52:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [08:52:32] (03CR) 10Foxtrott: [C: 032] Unbreak noglossary tag hook [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/325526 (owner: 10Legoktm) [08:53:08] (03Merged) 10jenkins-bot: Unbreak noglossary tag hook [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/325526 (owner: 10Legoktm) [08:53:25] (03PS1) 10Thiemo Mättig (WMDE): Fix tons of incomplete PHPDoc blocks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/326395 [08:58:45] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864236 (10mmodell) I pushed the fix to wmf/stable. [09:00:34] (03CR) 10Hashar: [V: 032 C: 032] Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_28) - 10https://gerrit.wikimedia.org/r/326301 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [09:00:45] (03CR) 10Hashar: [V: 032 C: 032] Mass migrate extensions to fix submodules (1.27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326302 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [09:00:56] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864239 (10mmodell) [09:00:59] (03CR) 10Hashar: [V: 032 C: 032] Mass migrate extensions to fix submodules (1.23) [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326303 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [09:01:28] 10Phabricator (2016-12-14): Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2863059 (10mmodell) [09:14:52] 10Phabricator, 06Labs, 06Operations, 10Tool-Labs, and 2 others: Install Arcanist in toollabs::dev_environ - https://phabricator.wikimedia.org/T139738#2864252 (10hashar) Puppet patch https://gerrit.wikimedia.org/r/#/c/297975/ will add arcanist on tools development environment for Trust and Jessie. Precise... [09:15:20] (03PS1) 10Paladox: Mass migrate skins to fix submodules [skins] (REL1_28) - 10https://gerrit.wikimedia.org/r/326399 (https://phabricator.wikimedia.org/T152663) [09:16:14] (03PS2) 10Paladox: Mass migrate skins to fix submodules [skins] (REL1_28) - 10https://gerrit.wikimedia.org/r/326399 (https://phabricator.wikimedia.org/T152663) [09:18:26] (03CR) 10Hashar: [V: 032 C: 032] Mass migrate skins to fix submodules [skins] (REL1_28) - 10https://gerrit.wikimedia.org/r/326399 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [09:22:16] (03CR) 10DCausse: [C: 031] "For reference: I1a79969 (a patch to prevent unexpected deb update in the repo)." [vagrant] - 10https://gerrit.wikimedia.org/r/325908 (https://phabricator.wikimedia.org/T138608) (owner: 10Gergő Tisza) [09:23:23] (03Draft1) 10Paladox: Mass migrate skins to fix submodules [skins] (REL1_27) - 10https://gerrit.wikimedia.org/r/326400 (https://phabricator.wikimedia.org/T152663) [09:23:25] (03Draft2) 10Paladox: Mass migrate skins to fix submodules [skins] (REL1_27) - 10https://gerrit.wikimedia.org/r/326400 (https://phabricator.wikimedia.org/T152663) [09:39:45] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Activate BM25 on all but wikis with spaceless languages - https://phabricator.wikimedia.org/T152092#2864283 (10dcausse) [09:47:30] (03CR) 10Hashar: [V: 032 C: 032] Mass migrate skins to fix submodules [skins] (REL1_27) - 10https://gerrit.wikimedia.org/r/326400 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [09:56:10] (03PS1) 10Jhobs: Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326402 (https://phabricator.wikimedia.org/T152223) [09:57:00] (03CR) 10Jhobs: [C: 032] Make implicit dependency on mw.Uri explicit [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326387 (owner: 10Jhobs) [09:59:20] (03Merged) 10jenkins-bot: Make implicit dependency on mw.Uri explicit [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326387 (owner: 10Jhobs) [09:59:42] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Technical-Debt (RW-Tech-Debt): Finish refactoring/implementing tweaked settings workflow - https://phabricator.wikimedia.org/T152223#2864295 (10jhobs) >>! In T152223#2858633, @bmansurov wrote: > Any... [10:00:09] 10MediaWiki-Internationalization, 13Patch-For-Review: Translate digits into devanagari in Nepali Wikipedia - https://phabricator.wikimedia.org/T151633#2864298 (10Dereckson) @biplabanand This digits array has already been in the file since 2007, introduced by r20904 / 7a4289397, per T11297. [10:02:30] (03CR) 10Dereckson: [C: 04-1] "This digits table has already been in the file since 2007, introduced by r20904 / 7a4289397, per T11297. @Raimond You were the committer b" [core] - 10https://gerrit.wikimedia.org/r/326138 (https://phabricator.wikimedia.org/T151633) (owner: 10Dereckson) [10:03:49] (03CR) 10DCausse: Report all syntax in stats, also add syntax to the log (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325821 (https://phabricator.wikimedia.org/T147045) (owner: 10Smalyshev) [10:09:48] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Generate all description files and look at category statistics for SMVK-Mexico - https://phabricator.wikimedia.org/T144357#2864315 (10Mattias_Ostmar-WMSE) [10:09:58] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Upload media files from Medelhavsmuseet to Wikimedia Commons - https://phabricator.wikimedia.org/T144356#2864318 (10Mattias_Ostmar-WMSE) [10:10:00] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Generate all description files and look at category statistics for SMVK-Mexico - https://phabricator.wikimedia.org/T144357#2597127 (10Mattias_Ostmar-WMSE) 05Open>03Resolved a:03Mattias_Ostmar-WMSE [10:15:09] 10MediaWiki-extensions-General-or-Unknown, 06Community-Liaisons, 07Documentation, 07I18n, 15User-Johan: Create a searchable and shared glossary - https://phabricator.wikimedia.org/T150263#2864335 (10Trizek-WMF) I'm not a developer, but I see that glossary as something separate where translators can find... [10:18:28] (03CR) 10Jack Phoenix: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:19:54] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:24:46] (03CR) 10Jhobs: [C: 032] Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326402 (https://phabricator.wikimedia.org/T152223) (owner: 10Jhobs) [10:26:31] (03Merged) 10jenkins-bot: Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326402 (https://phabricator.wikimedia.org/T152223) (owner: 10Jhobs) [10:44:13] (03CR) 10DCausse: "looks great, only one nitpick so far" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [10:44:26] (03CR) 10DCausse: [WIP] Move geosearch features to GeoData extension. (034 comments) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/326039 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [10:48:03] (03CR) 10DCausse: Refactor search context - get rid of search type (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325622 (https://phabricator.wikimedia.org/T152543) (owner: 10Smalyshev) [10:48:46] (03PS1) 10Jack Phoenix: SQL optimization [extensions/Comments] - 10https://gerrit.wikimedia.org/r/326404 (https://phabricator.wikimedia.org/T135367) [10:49:39] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2864416 (10Pginer-WMF) [10:49:45] 10Phabricator (2016-12-14): Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864417 (10Paladox) Thankyou. [10:50:04] (03CR) 10jenkins-bot: [V: 04-1] SQL optimization [extensions/Comments] - 10https://gerrit.wikimedia.org/r/326404 (https://phabricator.wikimedia.org/T135367) (owner: 10Jack Phoenix) [10:54:41] (03PS1) 10Jack Phoenix: Remove unnecessary eval() + fix typo [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/326405 (https://phabricator.wikimedia.org/T150082) [11:03:24] 10AbuseFilter, 07Easy, 07I18n, 13Patch-For-Review: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2864423 (10Aklapper) (Heh. I was wondering if this could be a Google Code-in task but I see you already created a patch.) [11:03:31] (03CR) 10Jack Phoenix: [C: 032] Remove unnecessary eval() + fix typo [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/326405 (https://phabricator.wikimedia.org/T150082) (owner: 10Jack Phoenix) [11:03:55] tonythomas, Uhh, fina [11:04:10] finally got power in the school back:) [11:05:04] (03Merged) 10jenkins-bot: Remove unnecessary eval() + fix typo [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/326405 (https://phabricator.wikimedia.org/T150082) (owner: 10Jack Phoenix) [11:05:45] 10Wikimedia-Wikimania-Scholarships, 07I18n: [[Wikimedia:Wsa-form-rights2/ast]] i18n issue - https://phabricator.wikimedia.org/T152940#2864445 (10Aklapper) "Wikimania Scholarships App" -> #wikimedia-wikimania-scholarships (Please feel free to change the project tags in Phabricator!) [11:05:56] 10Social-Tools: Extension:SiteScout needless use of eval in JS - https://phabricator.wikimedia.org/T150082#2864448 (10ashley) 05Open>03Resolved a:03ashley Fixed, thanks! [11:06:10] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Upload a minor selection of images (~10 files) for Medelhavsmuseet - https://phabricator.wikimedia.org/T144358#2864452 (10Mattias_Ostmar-WMSE) Uploading the same images as displayued as examples on https://commons.wikimedia.org/wiki/User:Mattias_... [11:07:26] (03PS7) 10Jack Phoenix: Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 [11:07:35] (03CR) 10Jack Phoenix: [C: 032] Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 (owner: 10Jack Phoenix) [11:08:45] (03Merged) 10jenkins-bot: Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 (owner: 10Jack Phoenix) [11:12:01] (03PS2) 10Jack Phoenix: ArticleSaveComplete (deprecated in MW 1.21) -> PageContentSaveComplete [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/326348 [11:12:52] (03CR) 10Jack Phoenix: "recheck" [core] - 10https://gerrit.wikimedia.org/r/322039 (owner: 10Jack Phoenix) [11:15:08] 10MediaWiki-Parser, 07I18n, 07Tracking: GENDER (tracking) - https://phabricator.wikimedia.org/T32443#2864463 (10Aklapper) [11:15:11] 10AbuseFilter, 07I18n, 13Patch-For-Review: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2864462 (10Aklapper) [11:16:30] 10Tools-Global-user-contributions: Global user contributions - tool not working - https://phabricator.wikimedia.org/T152922#2864464 (10Aklapper) Hi @BrillLyle, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce the problem, please... [11:17:22] (03PS6) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) [11:17:28] tonythomas, ^^^ [11:18:06] 10MediaWiki-General-or-Unknown, 13Patch-For-Review, 07Technical-Debt: testMediaWikiTestCaseParentSetupCalled does not have @covers annotations - https://phabricator.wikimedia.org/T152923#2864465 (10Aklapper) [11:20:00] 10MediaWiki-Logging: Make the log also include the prior page name when moving a page - https://phabricator.wikimedia.org/T152829#2864466 (10Aklapper) [11:26:47] (03CR) 10Jhernandez: [C: 031] "I have a question on boot.js, besides that looks great to me. Seems to have merge conflicts though" (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325283 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [11:29:24] (03PS7) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) [11:32:05] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-blocking, 06Community-Tech, 05MW-1.29-release-notes, 13Patch-For-Review: Add feature flag for block cookie behavior - https://phabricator.wikimedia.org/T147610#2698368 (10Bawolff) I have some concerns about this, please don't enable cookie bl... [11:35:34] (03CR) 10Jhernandez: "recheck" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325284 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [11:35:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Extract shared stub user object [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325284 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [11:35:57] git-review -R [11:36:00] (03CR) 10Jhernandez: [C: 032] "LGTM. There's a problem in the Qunit tests with the Schema class though." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325284 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [11:36:07] Oups, lol, wrong window)) [11:36:14] :) [11:36:23] (03PS8) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) [11:37:19] (03CR) 10Georggi199: "Php will only check syntax in foreach loop but nothing else if there are 0 publishers." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [11:41:42] (03CR) 10Mglaser: [C: 032] Replaced long deprecated DB_READ constant by DB_SLAVE [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/326130 (owner: 10Robert Vogel) [11:42:05] (03CR) 10Mglaser: [C: 032] Replaced long deprecated DB_READ constant by DB_SLAVE [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326131 (owner: 10Robert Vogel) [11:43:25] (03Merged) 10jenkins-bot: Replaced long deprecated DB_READ constant by DB_SLAVE [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/326130 (owner: 10Robert Vogel) [11:43:27] (03Merged) 10jenkins-bot: Replaced long deprecated DB_READ constant by DB_SLAVE [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326131 (owner: 10Robert Vogel) [11:43:33] (03CR) 10Jhernandez: [C: 032] "LGTM." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325285 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [11:49:18] 10Electron-PDFs, 10Reading-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Begin conversation with community on move from OCG to Electron - https://phabricator.wikimedia.org/T146757#2670293 (10Nemo_bis) In the conversation, it would be useful to know whether after OCG is eliminated we can be given... [11:51:16] (03CR) 10Jhernandez: [C: 032] "I see storing the preview count is in the next commit, so LGTM, gg" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325286 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [11:54:39] (03PS1) 10Jdrewniak: Portal Stats update [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/326407 (https://phabricator.wikimedia.org/T128546) [12:01:17] 10CirrusSearch, 06Discovery, 06Discovery-Search: Specific search on en.wp's Special:Search does not work - https://phabricator.wikimedia.org/T152895#2864481 (10Aklapper) [12:03:48] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-ParserFunctions: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2864483 (10Aklapper) p:05Triage>03Lowest @VictorPorton: Please edit the task summary to describe a problem instead of a solution - thank you! [12:04:11] 10CirrusSearch, 06Discovery, 06Discovery-Search: Specific search on en.wp's Special:Search does not work - https://phabricator.wikimedia.org/T152895#2864485 (10Aklapper) Query takes more than 40s here, then displays "An error has occurred while searching: We could not complete your search due to a temporary... [12:04:36] (03CR) 10Jhernandez: "Very nice." (033 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [12:08:43] (03CR) 10Jhernandez: [C: 032] Hygiene: Organise change listeners (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325336 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [12:09:25] (03CR) 10Jdrewniak: [C: 032] Portal Stats update [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/326407 (https://phabricator.wikimedia.org/T128546) (owner: 10Jdrewniak) [12:14:53] (03CR) 10Jhernandez: [C: 032] LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [12:16:22] (03CR) 10Jhernandez: [C: 032] LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [12:17:36] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864502 (10MarcoAurelio) I think it'd be better to keep this in CheckUser and make the CU tool be able to check filter... [12:18:19] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864504 (10MarcoAurelio) [12:19:40] (03Merged) 10jenkins-bot: Portal Stats update [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/326407 (https://phabricator.wikimedia.org/T128546) (owner: 10Jdrewniak) [12:19:42] 10MediaWiki-extensions-WikimediaMessages, 06Community-Liaisons, 07Easy, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Create MediaWiki messages to say {{int:Hello}} and {{int:Thank-you}} - https://phabricator.wikimedia.org/T137127#2358277 (10MarcoAurelio) [12:23:31] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864510 (10MarcoAurelio) >>! In T152934#2864038, @Huji wrote: > `* Date, Time: $1 acces... [12:23:46] 10MediaWiki-User-blocking, 06Community-Tech: CookieSetOnAutoblock for an infinite block would block the computer forever, this seems excessive - https://phabricator.wikimedia.org/T152952#2864511 (10Bawolff) [12:28:39] 10MediaWiki-extensions-StopForumSpam, 10Security-Reviews, 06Support-and-Safety, 06WMF-Legal: Security and compliance with the Privacy Policy review of Extension:StopForumSpam to consider deployment on WMF wikis - https://phabricator.wikimedia.org/T125338#2864528 (10MarcoAurelio) Hello. Any progress on this... [12:31:58] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Convert Special:DeletedContributions to OOUI - https://phabricator.wikimedia.org/T134525#2864529 (10TheDJ) @Volker_E > we have to provide them with slightly bigger form widgets for touch interfaces.... [12:41:19] (03CR) 10Jhernandez: [C: 032] {LINK,PREVIEW}_ABANDON_END logs an event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325928 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [12:43:36] (03PS1) 10Pwirth: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326410 [12:44:20] (03PS13) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [12:45:18] 10MediaWiki-User-blocking, 06Community-Tech: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches - https://phabricator.wikimedia.org/T152953#2864536 (10Bawolff) [12:45:49] 10Datasets-General-or-Unknown: Filter dump files and dirs for rsyncers of last N good dumps - https://phabricator.wikimedia.org/T152954#2864550 (10ArielGlenn) [12:48:33] (03PS14) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [12:51:22] (03CR) 10Phuedx: [C: 04-1] "Per Jhernandez's review." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [12:52:27] (03PS1) 10Nschaaf: Update wheels for related articles [research/recommendation-api/wheels] - 10https://gerrit.wikimedia.org/r/326411 (https://phabricator.wikimedia.org/T151793) [12:52:34] 10Datasets-General-or-Unknown: Filter dump files and dirs for rsyncers of last N good dumps - https://phabricator.wikimedia.org/T152954#2864575 (10ArielGlenn) I've done some pylint cleanup and added an option to the script to write the following to files especially for the rsync inclusion list: - dir names of... [12:53:27] 10CirrusSearch, 06Discovery, 06Discovery-Search: Specific search on en.wp's Special:Search does not work - https://phabricator.wikimedia.org/T152895#2862825 (10dcausse) Probably related to T134157, I wonder if the curl timeout is reached before shard timeout and resulting in an error rather than a warning. [12:53:43] (03CR) 10Nschaaf: [V: 032 C: 032] Update wheels for related articles [research/recommendation-api/wheels] - 10https://gerrit.wikimedia.org/r/326411 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [12:54:35] (03PS1) 10Jhernandez: Revert "Settings dialog" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326414 [12:57:03] (03PS15) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [12:57:18] (03CR) 10Jhernandez: [C: 032] Revert "Settings dialog" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326414 (owner: 10Jhernandez) [13:00:18] (03Merged) 10jenkins-bot: Revert "Settings dialog" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326414 (owner: 10Jhernandez) [13:02:16] (03CR) 10Fomafix: "A got again the error" [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [13:02:25] (03PS4) 10Phuedx: Initial Popups logging implementation [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325283 (https://phabricator.wikimedia.org/T152225) [13:02:28] (03PS4) 10Phuedx: Hygiene: Extract shared stub user object [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325284 (https://phabricator.wikimedia.org/T152225) [13:02:31] (03PS4) 10Phuedx: Include user's edit count in BOOT action [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325285 (https://phabricator.wikimedia.org/T152225) [13:02:34] (03PS5) 10Phuedx: Include user's preview count in BOOT action [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325286 (https://phabricator.wikimedia.org/T152225) [13:02:37] (03PS6) 10Phuedx: Store/update user's preview count [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) [13:02:40] (03PS5) 10Phuedx: Hygiene: Organise change listeners [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325336 (https://phabricator.wikimedia.org/T152225) [13:02:43] (03PS2) 10Phuedx: LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) [13:02:46] (03PS2) 10Phuedx: LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) [13:02:49] (03PS2) 10Phuedx: {LINK,PREVIEW}_ABANDON_END logs an event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325928 (https://phabricator.wikimedia.org/T152225) [13:03:04] (03PS1) 10Jhernandez: Re-introduce Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) [13:03:51] (03CR) 10Jhernandez: [C: 04-2] "Let's rebase once the other patches are merged and resolve merge conflicts, and do some review." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) (owner: 10Jhernandez) [13:04:53] 10Wikispeech, 06Wikispeech-STTS: Rearrange pronlex/lexserver and other pronlex directories - https://phabricator.wikimedia.org/T152955#2864597 (10NikolajLindberg) [13:05:02] 10Wikispeech, 06Wikispeech-STTS: Rearrange pronlex/lexserver and other pronlex directories - https://phabricator.wikimedia.org/T152955#2864597 (10NikolajLindberg) p:05Triage>03Low [13:07:35] Reedy: Are you there? [13:08:14] 06Wikispeech-STTS, 10Wikispeech-Synthesis, 10Wikispeech (Sprint 2016-11-30): Multiple requests to TTS server should not cause delay - https://phabricator.wikimedia.org/T143644#2574660 (10HaraldBerthelsen) 1) The wikispeech server (python flask) can be run in threaded mode. That is not recommended for deploym... [13:08:25] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864613 (10mschwarzer) Not rebooting is not really a suitable solution when using the VM for development, since I also need to enable other roles or change port-forwarding. For instanc... [13:10:11] (03CR) 10Jhernandez: [C: 032] Initial Popups logging implementation [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325283 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:10:14] (03PS7) 10Phuedx: Store/update user's preview count [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) [13:10:17] (03PS6) 10Phuedx: Hygiene: Organise change listeners [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325336 (https://phabricator.wikimedia.org/T152225) [13:10:20] (03PS3) 10Phuedx: LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) [13:10:23] (03PS3) 10Phuedx: LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) [13:11:45] (03CR) 10Mglaser: [C: 032] Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] (REL1_23) - 10https://gerrit.wikimedia.org/r/319801 (owner: 10Robert Vogel) [13:11:49] (03CR) 10Phuedx: [C: 04-1] Store/update user's preview count (032 comments) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:12:14] (03CR) 10Sn1per: "I don't get a reference error. I didn't include 'oojs-ui-core' in the dependencies because I thought it would be included in the dependenc" [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [13:12:46] (03PS16) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [13:12:49] (03CR) 10Jhernandez: [C: 032] Store/update user's preview count [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:13:04] (03Merged) 10jenkins-bot: Initial Popups logging implementation [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325283 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:13:37] (03Merged) 10jenkins-bot: Hygiene: Extract shared stub user object [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325284 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:14:19] 10MediaWiki-Unit-tests, 13Patch-For-Review, 07Technical-Debt: testMediaWikiTestCaseParentSetupCalled does not have @covers annotations - https://phabricator.wikimedia.org/T152923#2864619 (10Seb35) Changed the tag to a specialised tag [13:14:31] (03Merged) 10jenkins-bot: Include user's edit count in BOOT action [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325285 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:14:34] Reedy: Can you yake a look at gerrit patches [13:14:58] (03Merged) 10jenkins-bot: Include user's preview count in BOOT action [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325286 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:14:58] 10Tools-Global-user-contributions: Global user contributions - tool not working - https://phabricator.wikimedia.org/T152922#2864625 (10BrillLyle) So if I click on Global user contributions in the footer of a Wikipedia User's User Contributions, the GUC interface is not pulling current information. Like for some... [13:15:01] (03Merged) 10jenkins-bot: Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] (REL1_23) - 10https://gerrit.wikimedia.org/r/319801 (owner: 10Robert Vogel) [13:15:26] (03Merged) 10jenkins-bot: Store/update user's preview count [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325287 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:16:32] (03CR) 10Fomafix: "Maybe this was just a caching problem on my side. After a reload the error didn't occur anymore." [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [13:17:04] (03Merged) 10jenkins-bot: Hygiene: Organise change listeners [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325336 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:19:29] (03CR) 10jenkins-bot: [V: 04-1] LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:19:32] (03CR) 10jenkins-bot: [V: 04-1] LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:23:04] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Technical-Debt (RW-Tech-Debt): Finish refactoring instrumentation - https://phabricator.wikimedia.org/T152225#2864631 (10phuedx) a:05Jhernandez>03phuedx Pending adding the `type` property to `dis... [13:24:31] (03CR) 10jenkins-bot: [V: 04-1] LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:26:06] (03CR) 10jenkins-bot: [V: 04-1] LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [13:27:44] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-11-30): Caching on TTS server - https://phabricator.wikimedia.org/T151880#2830758 (10HaraldBerthelsen) Caching currently works as expected in the browser: If the page isn't reloaded the audio elements are still there and play without resynthesising. Fair enough. But... [13:29:39] 10MediaWiki-extensions-ContentTranslation: Special:CX does not seem to be working on Bangla Wikipedia - https://phabricator.wikimedia.org/T152956#2864640 (10Arrbee) [13:32:32] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864652 (10Physikerwelt) I think it might be a good idea to play with https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/role/manifests/hadoop.pp#L7 Maybe puttin... [13:33:01] (03CR) 10Niharika29: [C: 032] Change goals question to be about past reports instead [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326378 (https://phabricator.wikimedia.org/T151366) (owner: 10BryanDavis) [13:33:19] Niharika: Are you there? [13:33:53] (03CR) 10Mglaser: [C: 032] Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/326108 (owner: 10Robert Vogel) [13:34:05] (03Merged) 10jenkins-bot: Change goals question to be about past reports instead [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326378 (https://phabricator.wikimedia.org/T151366) (owner: 10BryanDavis) [13:34:07] (03Merged) 10jenkins-bot: Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/326108 (owner: 10Robert Vogel) [13:34:18] rlot: Yep. Did your patches get reviewed yet? I checked them and they looked fine but I wanted to wait on Ree-dy to look at them. [13:34:44] (03PS1) 10Mglaser: Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] (REL1_27) - 10https://gerrit.wikimedia.org/r/326423 [13:34:46] Niharika: Yeah, they was checked 2 days ago. Now i'm making another task [13:34:53] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864654 (10Huji) >>! In T152934#2864502, @MarcoAurelio wrote: > I think it'd be better... [13:34:57] Awesome. [13:35:06] 10MediaWiki-extensions-ContentTranslation: Special:CX does not seem to be working on Bangla Wikipedia - https://phabricator.wikimedia.org/T152956#2864655 (10Arrbee) {F5040806 size=full} Both pages are listed under 'Other Special pages', but do not resolve to anything but the page that says that there are no suc... [13:35:27] (03CR) 10Mglaser: [C: 032] BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326410 (owner: 10Pwirth) [13:35:31] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2864656 (10Huji) >>! In T152934#2864510, @MarcoAurelio wrote: >>>! In T152934#2864038,... [13:35:39] Niharika: Its also about Article, and Reedy checked it, i fixed little mistakes, so can you review this? [13:35:43] Look at GCI site [13:35:45] (03PS1) 10Mglaser: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326424 [13:35:48] i provided links [13:35:58] Most of them are merged [13:36:01] (03PS1) 10Mglaser: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326425 [13:36:04] rlot: Okay, gimme a few minutes, I'll take a look. [13:37:17] (03CR) 10Mglaser: [C: 032] Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] (REL1_27) - 10https://gerrit.wikimedia.org/r/326423 (owner: 10Mglaser) [13:37:43] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864657 (10Physikerwelt) However, I still don't really understand that particular error message. If you `export VAGRANT_LOG=DEBUG` you'll see that ``` INFO subprocess: Starting process... [13:37:50] 10AbuseFilter, 07Easy, 07I18n, 13Patch-For-Review: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2864658 (10Huji) @Aklapper I think we should create a Google Code-in task which is "Go through MediaWiki core and all major extensions (at least those used by WMF... [13:38:10] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864659 (10mschwarzer) Due to the error with --provision the Hadoop ports weren't set up correctly: ``` $ vagrant forward-port -l Local port => VM's port ----------------------- ``` T... [13:38:39] (03CR) 10Mglaser: [C: 032] BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326425 (owner: 10Mglaser) [13:39:14] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Upload a minor selection of images (~10 files) for Medelhavsmuseet - https://phabricator.wikimedia.org/T144358#2864660 (10Mattias_Ostmar-WMSE) The photograph field generates an Error e.g. [[ https://commons.wikimedia.org/wiki/File:Museet_i_Teotih... [13:40:20] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Create client functionality for getting human readable wikitext from Wikibase statements - https://phabricator.wikimedia.org/T142940#2864664 (10aude) [13:41:00] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864667 (10mschwarzer) Vagrant seems to call the lxc-attach help function: ``` INFO subprocess: Starting process: ["/usr/bin/sudo", "/usr/bin/env", "lxc-attach", "-h"] ``` I don't see... [13:41:36] (03CR) 10DCausse: [C: 04-1] "should not be merged until all wikis are reindexed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320788 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [13:43:44] (03CR) 10Niharika29: Cleaned "Article::getContent" deprecated in MediaWiki 1.21 (031 comment) [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:45:40] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864669 (10Physikerwelt) I have no idea what you could try next. Probably run vagrant destroy and adjust the config. Are you trying the analytics role or just the hadoop role? I wonder... [13:46:12] (03Merged) 10jenkins-bot: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326410 (owner: 10Pwirth) [13:46:13] (03Merged) 10jenkins-bot: Improve BlueSpiceVisualEditor integration [extensions/BlueSpiceSMWConnector] (REL1_27) - 10https://gerrit.wikimedia.org/r/326423 (owner: 10Mglaser) [13:46:15] (03Merged) 10jenkins-bot: BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326425 (owner: 10Mglaser) [13:46:49] (03PS3) 10Filip: Cleaned "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) [13:47:08] Niharika: Fixed it [13:48:35] (03PS2) 10Jhernandez: Re-introduce Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) [13:49:12] (03CR) 10Jhernandez: [C: 04-2] "> Uploaded patch set 2." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) (owner: 10Jhernandez) [13:49:36] (03CR) 10Niharika29: Replaced "Article::getContent" deprecated in MediaWiki 1.21 (033 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:50:57] (03CR) 10jenkins-bot: [V: 04-1] Re-introduce Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) (owner: 10Jhernandez) [13:53:08] (03CR) 10Reedy: [C: 032] Cleaned "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:53:35] (03PS4) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) [13:54:04] (03Merged) 10jenkins-bot: Cleaned "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:56:16] 10Wikimedia-Site-requests, 07Verified: Change namespaces configuration - ku.wikipedia - https://phabricator.wikimedia.org/T39521#422559 (10hashar) A new namespace alias is being requested via T152815 and I found out we had two pages conflicting due to this portal addition. I got them fixed: ``` $ mwscript name... [13:56:44] 10video2commons: Disk space went not cool again on the video encoding instances - https://phabricator.wikimedia.org/T152899#2864683 (10zhuyifei1999) I made [[https://github.com/toollabs/video2commons/commit/e68e15fe71cd6abd9b271d0d82ceb1758b6efaf4|a commit]] to set to task to retry every 5 mins (up to an hour) w... [13:57:54] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/323981 (https://phabricator.wikimedia.org/T142811) (owner: 10Smalyshev) [13:58:03] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (0312 comments) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:58:05] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/323981 (https://phabricator.wikimedia.org/T142811) (owner: 10Smalyshev) [14:00:13] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:01:53] (03PS3) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) [14:08:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: getLabelWithLang returns wrong lang - https://phabricator.wikimedia.org/T152241#2864727 (10matej_suchanek) Can anyone look into this? I can confirm that this is bug which influences client wikis. [14:09:04] (03PS1) 10Robert Vogel: Removed invalid hook callbacks [extensions/BlueSpiceSMWConnector] (REL1_23) - 10https://gerrit.wikimedia.org/r/326428 [14:09:07] Reedy: So it should be "Hook handler for BlueSpice hook BSRSSFeederGetRegisteredFeeds" [14:09:19] And param a feed [14:09:22] rlot: Sounds good to me, yup [14:09:23] return? [14:09:26] Ok [14:09:27] bool [14:09:34] Looks like they just copy pasted it from elsewhere [14:10:00] 10Phabricator: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864731 (10faidon) [14:11:29] Reedy: $aFeeds its not used anywhre [14:12:09] rlot: that's a different issue though. The hook does pass it [14:12:20] What time is it? [14:12:48] *Type [14:13:25] I dont know what to write in @params [14:13:34] it's an array [14:14:01] (03CR) 10Mglaser: [C: 032] Removed invalid hook callbacks [extensions/BlueSpiceSMWConnector] (REL1_23) - 10https://gerrit.wikimedia.org/r/326428 (owner: 10Robert Vogel) [14:14:09] (03Merged) 10jenkins-bot: Removed invalid hook callbacks [extensions/BlueSpiceSMWConnector] (REL1_23) - 10https://gerrit.wikimedia.org/r/326428 (owner: 10Robert Vogel) [14:16:36] (03PS5) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) [14:16:39] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 07Easy: Feed: News stories are partially obscured by system status bar when no thumbnail is found - https://phabricator.wikimedia.org/T141991#2864749 (10Mholloway) a:03Mayank.jindal5 @Mayank.jindal5 Great! Have you seen our wiki page for contributors j... [14:16:43] Reedy: Ok, i commited it [14:17:29] rlot: there's still the spaces need around the . when used for string concat [14:17:56] (03Draft2) 10Matěj Suchánek: Don't show hit count field if it's always empty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326253 [14:17:58] (03PS1) 10Niharika29: Change Feb 16 -> Feb 20 per task edit [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326432 [14:19:04] (03PS3) 10Matěj Suchánek: Don't show hit count field if it's always empty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326253 [14:20:08] (03CR) 10Niharika29: [C: 032] "Trivial edit. Self-merging." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326432 (owner: 10Niharika29) [14:20:38] (03Draft2) 10Matěj Suchánek: Make more fields sortable and one conditionally [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326258 [14:21:06] (03PS3) 10Matěj Suchánek: Make more fields sortable and one conditionally [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326258 [14:21:10] (03Merged) 10jenkins-bot: Change Feb 16 -> Feb 20 per task edit [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326432 (owner: 10Niharika29) [14:22:34] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864758 (10mschwarzer) Same problem when only enabling the hadoop role :/ [14:27:09] (03PS6) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) [14:27:18] Reedy: Done [14:28:24] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Content Translation should adapt the namespace when no target title is provided - https://phabricator.wikimedia.org/T152960#2864763 (10Amire80) [14:29:08] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Content Translation should adapt the namespace when no target title is provided - https://phabricator.wikimedia.org/T152960#2864775 (10Amire80) [14:29:11] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:29:13] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864777 (10Krenair) See also T142516 [14:29:30] (03CR) 10Anomie: "Code seems sane, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/326355 (https://phabricator.wikimedia.org/T109909) (owner: 10Brian Wolff) [14:29:42] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:31:34] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:32:05] (03Abandoned) 10Reedy: Update pear/net_smtp from v1.7.1 to v1.7.2 [vendor] - 10https://gerrit.wikimedia.org/r/313661 (owner: 10Reedy) [14:32:16] (03Abandoned) 10Reedy: symfony/process 3.0.4 -> 3.1.4 [vendor] - 10https://gerrit.wikimedia.org/r/298233 (owner: 10Reedy) [14:32:39] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:32:54] rlot: Is that all the commits for the GCI task? [14:33:09] Reedy: Yeah [14:33:23] Reedy: Look at GCI [14:33:45] It doesn't make the URLs clickable [14:33:52] So it makes it harder to check [14:33:55] (03CR) 10Daniel Kinzler: [C: 032] WikiPage::prepareTextForEdit() was removed [core] - 10https://gerrit.wikimedia.org/r/326382 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [14:34:59] (03CR) 10Reedy: [C: 032] Remove < MW 1.14 support [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323657 (owner: 10Reedy) [14:35:14] (03CR) 10Reedy: [C: 032] Some code cleanup [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323658 (owner: 10Reedy) [14:35:31] (03CR) 10Reedy: [C: 032] Move functions to class [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323660 (owner: 10Reedy) [14:36:09] andre__: [14:36:14] Are you around? [14:36:31] andre__: So should i reclaim this task? MtDu [14:37:06] rlot: You are free to, if you were not aware that a patch existed already outside of GCI and if you provided a patch. [14:37:22] andre__: Nevermind, MtDu claimed it [14:37:35] errrm. [14:38:00] Oh, its here! [14:38:06]  [14:38:07] [Do not claim] Convert messages to use $this->msg() instead of wfMessage in SmiteSpam [14:38:36] andre__: Can you submit it? I provided a patch link [14:39:48] rlot: Let me check the situation. [14:40:14] (03CR) 10Dbrant: [C: 04-1] Fixed null-ptr for some codes (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326285 (owner: 10XinyueZ) [14:42:46] (03CR) 10Mholloway: [C: 04-1] "I still have to run this for manual testing when homebrew is done upgrading, but the code looks good to me." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [14:43:03] 10MediaWiki-Vagrant, 10Analytics: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2864815 (10Physikerwelt) @mschwarzer Maybe you find someone using the analytics vagrant role on [IRC](https://webchat.freenode.net/?channels=#wikimedia-analytics). [14:45:18] (03CR) 10Mholloway: [C: 04-1] "(Actually two, one each for experimental and non-)?" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [14:45:38] 10MediaWiki-API, 06Operations, 10Parsoid, 10RESTBase, and 6 others: HHVM request timeouts not working; support lowering the API request timeout per request - https://phabricator.wikimedia.org/T97192#2864816 (10GWicke) >>! In T97192#2861483, @Joe wrote: > Just for the record, the reason requests piled up in... [14:45:47] (03Abandoned) 10Reedy: [WIP] Bring in video.js from composer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/320094 (https://phabricator.wikimedia.org/T150128) (owner: 10Reedy) [14:45:51] (03Abandoned) 10Reedy: Add videojs/video.js for TimedMediaHandler [vendor] - 10https://gerrit.wikimedia.org/r/320095 (https://phabricator.wikimedia.org/T150128) (owner: 10Reedy) [14:45:54] (03Merged) 10jenkins-bot: WikiPage::prepareTextForEdit() was removed [core] - 10https://gerrit.wikimedia.org/r/326382 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [14:45:58] (03Merged) 10jenkins-bot: Remove < MW 1.14 support [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323657 (owner: 10Reedy) [14:46:00] (03Merged) 10jenkins-bot: Some code cleanup [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323658 (owner: 10Reedy) [14:46:02] (03Merged) 10jenkins-bot: Move functions to class [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323660 (owner: 10Reedy) [14:46:25] (03CR) 10Reedy: [C: 032] Convert DiscussionThreading to extension registration [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323661 (owner: 10Reedy) [14:46:31] (03CR) 10Reedy: [C: 032] Fix Undefined property: EditPage::$replyadded [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323663 (https://phabricator.wikimedia.org/T70742) (owner: 10Reedy) [14:47:01] 10TimedMediaHandler, 13Patch-For-Review: Bring video.js in via composer - https://phabricator.wikimedia.org/T150128#2864823 (10Reedy) [14:47:05] 10ArchCom-RfC, 06Front-end-Standards-Group, 10Librarization, 07RfC: MediaWiki support for Composer equivalent for JavaScript packages - https://phabricator.wikimedia.org/T107561#2864826 (10Reedy) [14:47:25] rlot: could you hand in for review? [14:47:33] 10TimedMediaHandler, 13Patch-For-Review: Bring video.js in via composer - https://phabricator.wikimedia.org/T150128#2774799 (10Reedy) [14:47:35] 10MediaWiki-General-or-Unknown, 07Composer: Find location of Composer files - https://phabricator.wikimedia.org/T150129#2864827 (10Reedy) 05Open>03declined [14:47:47] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Activate BM25 on all but wikis with spaceless languages - https://phabricator.wikimedia.org/T152092#2864830 (10dcausse) [14:48:03] andre__: Ok, here [14:48:41] (03PS1) 10Reedy: Sync video.js version in package.json to what's in the repo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/326434 [14:49:29] 10Wikimedia-Site-requests: domain addded to $wgCopyUploadsDomains in production? - https://phabricator.wikimedia.org/T152962#2864832 (10Ebastia1) [14:49:49] (03PS5) 10Sbisson: [WIP] Fix contradictory RC filters [core] - 10https://gerrit.wikimedia.org/r/325567 (https://phabricator.wikimedia.org/T151873) [14:50:06] 10Wikimedia-Site-requests: domain added to $wgCopyUploadsDomains in production? - https://phabricator.wikimedia.org/T152962#2864844 (10Reedy) [14:51:06] 10Wikimedia-Site-requests: domain added to $wgCopyUploadsDomains in production? - https://phabricator.wikimedia.org/T152962#2864832 (10Dereckson) 'The domain whitelist was requested at T150167. [14:52:31] andre__: Thanks! [14:53:16] (03PS3) 10Reedy: Convert DiscussionThreading to extension registration [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323661 [14:53:29] (03CR) 10Fomafix: [C: 04-1] "The problem with the missing OO in the first load must be some where else on my installation. A missing dependency seams not to be the rea" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [14:53:57] (03PS2) 10Reedy: Fix Undefined property: EditPage::$replyadded [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323663 (https://phabricator.wikimedia.org/T70742) [14:54:36] rlot, thanks for you patience and sorry that things got a bit confusing :) [14:54:52] (03PS3) 10Reedy: Fix Undefined property: EditPage::$replyadded [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323663 (https://phabricator.wikimedia.org/T70742) [14:54:56] (03CR) 10Reedy: [C: 032] Fix Undefined property: EditPage::$replyadded [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323663 (https://phabricator.wikimedia.org/T70742) (owner: 10Reedy) [14:57:16] (03Merged) 10jenkins-bot: Fix Undefined property: EditPage::$replyadded [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323663 (https://phabricator.wikimedia.org/T70742) (owner: 10Reedy) [14:57:35] 10MediaWiki-extensions-DiscussionThreading, 13Patch-For-Review: Notice: Undefined property: EditPage::$replyadded in DiscussionThreading.php on line 172 - https://phabricator.wikimedia.org/T70742#2864851 (10Reedy) 05Open>03Resolved [14:57:55] (03PS4) 10Reedy: Convert DiscussionThreading to extension registration [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323661 [14:57:59] (03CR) 10Reedy: [C: 032] Convert DiscussionThreading to extension registration [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323661 (owner: 10Reedy) [14:59:38] (03CR) 10Dbrant: [C: 04-1] "Thanks for the patch! This is an interesting effect, but I'm not sure it conforms with Material Design guidelines:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326367 (owner: 10XinyueZ) [15:01:28] (03Merged) 10jenkins-bot: Convert DiscussionThreading to extension registration [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323661 (owner: 10Reedy) [15:07:36] (03CR) 1001tonythomas: [C: 04-1] "See comments." (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [15:10:03] 10MediaWiki-Logging: Make the log also include the prior page name when moving a page - https://phabricator.wikimedia.org/T152829#2864857 (10Spinningspark) > Aklapper changed the title from "Feature Request: Move log enhancement" to "Make the log also include the prior page name when moving a page" If that resu... [15:10:26] (03CR) 10Dbrant: [C: 032] Update bundled CSS (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326065 (owner: 10Mholloway) [15:15:31] (03Merged) 10jenkins-bot: Update bundled CSS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326065 (owner: 10Mholloway) [15:17:47] (03CR) 10Mholloway: [C: 04-1] "Actually, it looks like something is turned around. The inline style is being applied for the /formatted endpoint and not /mobile-section" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [15:19:45] (03PS1) 10Dbrant: Fix possible crash when visiting external link. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326438 [15:21:18] (03CR) 10Florianschmidtwelzow: [C: 04-1] Convert Special:RecentChanges to OOUI (035 comments) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [15:22:07] (03CR) 10Florianschmidtwelzow: [C: 04-1] "See the comments from PS11 :)" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [15:24:00] 10MediaWiki-extensions-ThrottleOverride: overridethrottle message is mileading - https://phabricator.wikimedia.org/T152964#2864875 (10Reedy) [15:24:05] 10MediaWiki-Vagrant, 10Wikidata, 13Patch-For-Review, 15User-Tobi_WMDE_SW: Create simple wikibase_repo vagrant role - https://phabricator.wikimedia.org/T151845#2864887 (10Tobi_WMDE_SW) 05Open>03Resolved a:03Tobi_WMDE_SW [15:24:31] 10Phabricator (2016-12-14): Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2864890 (10Paladox) @mmodell Hi, I just tried to git pull on phab-03 and it found no new up... [15:24:33] 10MediaWiki-extensions-ThrottleOverride: overridethrottle message is mileading - https://phabricator.wikimedia.org/T152964#2864891 (10Reedy) [15:25:39] (03PS14) 10Reedy: Make OverrideThrottle handle modifications of existing throttles [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:27:39] (03CR) 10Reedy: [C: 04-1] "[42cebccc9c65c39a1b5868d9] /wiki/Special:OverrideThrottle Error from line 166 of /var/www/wiki/mediawiki/extensions/ThrottleOverride/Speci" [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:29:02] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog (Kanban): Gallery should offer article previews - https://phabricator.wikimedia.org/T142024#2864917 (10Dbrant) [15:29:15] (03CR) 10Reedy: [C: 04-1] Make OverrideThrottle handle modifications of existing throttles (031 comment) [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:29:19] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) [15:29:47] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog (Kanban): Recommend UI enhancement: TOC drawer should appear in front of both the app bar and screen contents - https://phabricator.wikimedia.org/T108726#2864922 (10Dbrant) [15:32:57] (03PS2) 10Thiemo Mättig (WMDE): Fix CSS embedding of SVG files with wrong "text/plain" MIME type [core] - 10https://gerrit.wikimedia.org/r/284427 [15:35:01] (03PS15) 10Reedy: Make OverrideThrottle handle modifications of existing throttles [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:36:06] (03CR) 10Reedy: [C: 04-1] "Fixed up that fatal..." [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:36:22] (03CR) 10DCausse: "corresponding patch in cirrus was merged" [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/325995 (owner: 10DCausse) [15:37:56] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/326447 (https://phabricator.wikimedia.org/T151973) [15:39:37] 10MediaWiki-extensions-ContentTranslation, 13Patch-For-Review: Special:CX does not seem to be working on Bangla Wikipedia - https://phabricator.wikimedia.org/T152956#2864640 (10Nikerabbit) //Copying from chat to permament storage.// Basically [UtfNormal\Validator::cleanUp] normalization call forces everything... [15:40:58] (03PS1) 10Mobrovac: Revert "Config: Lower concurrency" [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/326449 [15:41:33] (03CR) 10Mobrovac: [V: 032 C: 032] Revert "Config: Lower concurrency" [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/326449 (owner: 10Mobrovac) [15:42:23] FlorianSW|away, [15:44:33] (03CR) 10Reedy: [C: 04-1] "I was going to claim that it didn't modify throttles, but just create more. It seems any created before the thr_target just causes few lit" [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:45:00] (03PS16) 10Reedy: Make OverrideThrottle handle modifications of existing throttles [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/198687 (https://phabricator.wikimedia.org/T62423) (owner: 10Glaisher) [15:45:24] (03PS1) 10Mobrovac: Update change-propagation to b2bf30d [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/326450 [15:46:05] (03CR) 10Mobrovac: [V: 032 C: 032] Update change-propagation to b2bf30d [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/326450 (owner: 10Mobrovac) [15:46:32] victorbarbu, [15:46:39] hi! [15:46:43] hi! :) [15:46:56] does mw js have any utility for string2boolean conversion? [15:47:01] or should I implement my own? [15:47:15] (03CR) 10Anomie: Block API - Allow blocking/unblocking using userid (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325802 (https://phabricator.wikimedia.org/T34496) (owner: 10Subins2000) [15:47:47] victorbarbu: for what do you need that? [15:48:14] because query variables are retrieved in query format [15:48:21] and I need to get the boolean out of it [15:48:32] for the makeCollapsible [15:49:02] https://gerrit.wikimedia.org/r/#/c/325049/12/resources/src/mediawiki.special/mediawiki.special.recentchanges.js #69 [15:49:02] just check for a specific value? [15:49:06] yes [15:49:34] that looks ok so :) [15:49:45] it doesn't work... I tested it [15:49:53] and Boolean("0") returns true [15:49:59] and Boolean("false") as well [15:50:13] 10Wikimedia-Site-requests: hewiki asks to change default image sizes for thumb and gallery - https://phabricator.wikimedia.org/T43712#2864961 (10Gilles) Since 250px is much more common than 220px (as per Swift figures recently compiled in P4577, CountPerSize section)? 200 is even more common. This change should... [15:51:19] victorbarbu: what context are you in? WebRequest::getBool() for web, or PARAM_TYPE => 'boolean' for api are the prefered ways [15:51:40] I am working on client-side now [15:51:58] ahh [15:52:02] i dunno anything about that :P [15:52:44] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Technical-Debt (RW-Tech-Debt): Finish refactoring/implementing tweaked settings workflow - https://phabricator.wikimedia.org/T152223#2864962 (10bmansurov) Thanks for the update, @jhobs! [15:52:49] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) [15:54:00] 10MediaWiki-extensions-ThrottleOverride, 13Patch-For-Review: Make ThrottleOverride handle modifications - https://phabricator.wikimedia.org/T62423#668516 (10Reedy) Just needs a useable edit link on the List and should be all good [15:54:08] victorbarbu: the value of panel-collapsed should be set by the form only, so couldn't you safely check for a specific non-boolean value? "true" === "true"? [15:54:31] 10MediaWiki-extensions-ThrottleOverride: ThrottleOverride should allow setting starting time and ending time - https://phabricator.wikimedia.org/T93468#2864971 (10Reedy) [15:54:42] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864973 (10mmodell) a:03mmodell [15:54:51] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 07Easy: Feed: News stories are partially obscured by system status bar when no thumbnail is found - https://phabricator.wikimedia.org/T141991#2864974 (10Mayank.jindal5) @Mholloway yes, I had seen wiki page and set up gerrit and all. [15:55:28] 06Operations-Software-Development, 13Patch-For-Review: Add support for physical disks to get-raid-status-megacli.py - https://phabricator.wikimedia.org/T151043#2864975 (10Volans) 05Open>03Resolved [15:55:40] @seen anomie [15:55:41] subins2000: anomie is in here, right now [15:55:48] 06Reading-Web-Backlog, 07Epic, 07Tracking: [EPIC + TRACKING] Adopting recent developments in web standards - https://phabricator.wikimedia.org/T108877#2864980 (10bmansurov) [15:55:50] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, and 2 others: MobileFrontend should adopt an app manifest - https://phabricator.wikimedia.org/T108878#2864977 (10bmansurov) 05Open>03Resolved a:03bmansurov Looks good to me. Tested on https://en.m.wikipedia.beta... [15:56:44] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864982 (10mmodell) the "security field" no longer has any affect. It's only remaining for historical reasons - to not lose the bit of information on old tasks which had a value set.... [15:56:48] 10MediaWiki-extensions-ContentTranslation, 13Patch-For-Review: Special:CX does not seem to be working on Bangla Wikipedia - https://phabricator.wikimedia.org/T152956#2864640 (10thiemowmde) I totally support idea 2.A. Let's have a unit test for this. [15:57:17] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2864986 (10bmansurov) @jdlrobson, according to T148108#2847463, you moved the task to Ready for Signoff skipping QA. [15:58:32] (03PS5) 10Subins2000: Block API - Allow blocking/unblocking using userid [core] - 10https://gerrit.wikimedia.org/r/325802 (https://phabricator.wikimedia.org/T34496) [15:58:37] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864989 (10Aklapper) ( https://www.mediawiki.org/wiki/Phabricator/Security might also welcome an overhaul) [15:59:45] 10MediaWiki-extensions-ThrottleOverride: overridethrottle message is misleading - https://phabricator.wikimedia.org/T152964#2864990 (10Aklapper) [16:00:06] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2864991 (10mmodell) The task that @krenair linked above is about making a form specifically for 'other confidential issues' ... It's not currently linked from anywhere prominent, but... [16:00:37] 10MediaWiki-extensions-ThrottleOverride: Purge expired throttles - https://phabricator.wikimedia.org/T147363#2864992 (10Reedy) Current implementation just deletes that override IF it's no longer valid ``` $conds = [ "thr_range_start <= $quotedIp", "thr_range_end >= $quotedIp", 'thr_type' . $dbr->bui... [16:00:56] 10Monitoring: Investigate usage of service dependencies in icinga - https://phabricator.wikimedia.org/T152967#2864993 (10akosiaris) [16:01:55] FlorianSW, I am already returning the "nearest" possible value for urls, so no url is broken [16:02:04] I solved the problem with preferences [16:04:02] 10Monitoring: Investigate usage of parents in icinga for host definitions - https://phabricator.wikimedia.org/T152968#2865007 (10akosiaris) [16:05:01] (03PS13) 10Victorbarbu: Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [16:05:26] FlorianSW, check this out [16:05:31] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865019 (10Aklapper) Also see https://phabricator.wikimedia.org/T152395#2863188 for potentially related confusion [16:07:34] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865036 (10mmodell) I've hidden the security field from the 'advanced' task form. In other places the field is visible but locked. [16:07:34] tonythomas, are you here? [16:08:09] 10Phabricator: Custom task form for #WMF-NDA - https://phabricator.wikimedia.org/T142516#2865038 (10mmodell) I think this task should be marked as complete? the primary purpose has been fulfilled. [16:08:15] (03PS1) 10Reedy: Purge all expired Throttles when running pingLimiter [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/326454 (https://phabricator.wikimedia.org/T147363) [16:08:58] 10MediaWiki-General-or-Unknown: Article title containing space-colon-space can become inaccessible after a namespace is created - https://phabricator.wikimedia.org/T152970#2865043 (10maiden_taiwan) [16:09:17] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865055 (10mmodell) 05Open>03Resolved [16:09:40] (03PS1) 10Niedzielski: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326455 [16:10:17] (03Abandoned) 10Reedy: Purge all expired Throttles when running pingLimiter [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/326454 (https://phabricator.wikimedia.org/T147363) (owner: 10Reedy) [16:10:40] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326455 (owner: 10Niedzielski) [16:11:08] 10MediaWiki-extensions-ThrottleOverride, 13Patch-For-Review: Purge expired throttles - https://phabricator.wikimedia.org/T147363#2865059 (10Reedy) 05Open>03declined I just noticed in the List too... ``` if ( !wfReadOnly() && !mt_rand( 0, 10 ) ) { // Purge expired entries on one in every 10 queries... [16:11:10] 10MediaWiki-extensions-ThrottleOverride, 10Security-Reviews, 10Wikimedia-Extension-setup, 10Wikimedia-Developer-Summit (2017): Review and deploy ThrottleOverride extension to Wikimedia wikis - https://phabricator.wikimedia.org/T27000#2865061 (10Reedy) [16:11:55] (03CR) 10Jdlrobson: "Minor improvement suggested. I will test this within the next 3 hours!" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/326385 (https://phabricator.wikimedia.org/T124994) (owner: 10Jo12bar) [16:11:58] 10MediaWiki-extensions-ThrottleOverride: Special page actions should have API equivalents - https://phabricator.wikimedia.org/T147367#2690616 (10Reedy) Worth adding a "query" module too to list all throttles? [16:13:04] (03PS1) 10Dbrant: Fix possible crash when resuming activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326457 [16:13:11] (03PS14) 10Victorbarbu: Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [16:13:29] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, and 2 others: MobileFrontend should adopt an app manifest - https://phabricator.wikimedia.org/T108878#2865065 (10Jdlrobson) Thanks @Rudloff ! I hope to see some more patches from you. Thanks for the positive and produ... [16:14:07] (03PS2) 10Nschaaf: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) [16:14:39] 10MediaWiki-extensions-ThrottleOverride: Special page actions should have API equivalents - https://phabricator.wikimedia.org/T147367#2865066 (10bd808) [16:15:04] 10MediaWiki-extensions-ThrottleOverride: Special page actions should have API equivalents - https://phabricator.wikimedia.org/T147367#2690616 (10bd808) >>! In T147367#2865062, @Reedy wrote: > Worth adding a "query" module too to list all throttles? Yup. I added "view" to the needed actions. [16:15:14] (03PS6) 10Subins2000: Block API - Allow blocking/unblocking using userid [core] - 10https://gerrit.wikimedia.org/r/325802 (https://phabricator.wikimedia.org/T34496) [16:15:44] 10MediaWiki-extensions-ThrottleOverride, 10Security-Reviews, 10Wikimedia-Extension-setup, 10Wikimedia-Developer-Summit (2017): Review and deploy ThrottleOverride extension to Wikimedia wikis - https://phabricator.wikimedia.org/T27000#2865069 (10Reedy) [16:15:47] 10MediaWiki-extensions-ThrottleOverride: The Event Organiser's Userright - https://phabricator.wikimedia.org/T91928#2865068 (10Reedy) [16:15:49] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2865070 (10Aklapper) [For the records; sorted out the GCI aspects of this task.] [16:16:33] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2865071 (10mmodell) @paladox: There was no need to ping epriestley about this, it's not his problem. [16:16:36] (03CR) 10jenkins-bot: [V: 04-1] Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [16:17:03] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2865072 (10Paladox) ok sorry. [16:17:29] 10MediaWiki-Email, 10Mail, 06Operations, 10Wikimedia-General-or-Unknown, and 3 others: Email server's DMARC config prevents users from sending emails via Special:EmailUser - https://phabricator.wikimedia.org/T66795#2865073 (10Aklapper) @AnnaMariaKoshka: Feel free to create a separate task with more informa... [16:18:18] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:19:05] (03PS2) 10Niedzielski: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326455 [16:19:14] (03PS21) 10Sn1per: [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) [16:19:17] (03PS1) 10Sn1per: Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) [16:19:37] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/326460 (https://phabricator.wikimedia.org/T151973) [16:19:49] (03CR) 10Nikerabbit: [C: 04-1] GENDER should be used for "triggered" in AbuseFilter log messages (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326371 (https://phabricator.wikimedia.org/T152872) (owner: 10Huji) [16:23:05] (03CR) 10Niedzielski: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326455 (owner: 10Niedzielski) [16:24:41] (03CR) 10jenkins-bot: [V: 04-1] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [16:25:08] paladox: Hi! Did you receive my email about https://phabricator.wikimedia.org/H107 ? [16:25:57] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/326462 (https://phabricator.wikimedia.org/T151973) [16:26:02] andre__ Hi, probaly but as i get alot of emails + my email provider keeps crashing my brower i tend to not read emails. [16:26:09] But i can have a look now [16:26:14] (03PS3) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) [16:26:23] 10CirrusSearch, 06Discovery, 06Discovery-Search: insource (regex) search on en.wp's Special:Search does not work - https://phabricator.wikimedia.org/T152895#2865080 (10dcausse) [16:26:28] (03PS1) 10Niedzielski: Hygiene: add script for testing translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326463 [16:26:54] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326455 (owner: 10Niedzielski) [16:27:06] (03PS1) 10DCausse: Use CirrusSearchClientSideSearchTimeout for connection timeout [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326464 (https://phabricator.wikimedia.org/T152895) [16:27:18] (03PS3) 10Reedy: Fix smarty submodule to point at better upstream [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/302930 (https://phabricator.wikimedia.org/T142091) [16:27:50] (03CR) 10jenkins-bot: [V: 04-1] Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) (owner: 10Sn1per) [16:27:54] Reedy: Are you there? [16:28:13] Reedy: I found wierd usage of ->getContent [16:28:18] ? [16:28:23] $article->getContent(); [16:28:23] $text = $article->mContent; [16:29:01] Why not $text = $article->getContent(); ? [16:29:26] Because people write bad code [16:29:46] Btw, lots of that extensions don't follow guidelines [16:29:49] like whitespaces [16:29:51] We know [16:30:01] It's not enforced [16:30:08] So can i just use $text = (depracation) [16:30:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) (owner: 10Sn1per) [16:30:23] That doesn't make sense [16:30:27] (03PS1) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 [16:30:42] Artciel::getContent() is still deprecated [16:30:56] I know, [16:31:27] (03PS2) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [16:31:34] I don't see anyone using ->mcontent directly [16:31:47] (03PS3) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [16:31:59] $content = $article->getContentObject(); [16:32:00] $text = ContentHandler::getContentText( $content ); [16:32:01] So its ok [16:32:23] 06Maps (Kartographer): Allow per-wiki customization of the map detail list - https://phabricator.wikimedia.org/T152971#2865090 (10Yurik) [16:32:30] (03PS1) 10BryanDavis: Fix missing Special:MyLanguage references [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326466 (https://phabricator.wikimedia.org/T152940) [16:32:32] (03PS17) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [16:33:00] (03CR) 10Huji: [C: 04-1] "So far, only the user interface has been created. Access control, form submission, etc has not been coded yet." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [16:33:50] anomie: Updated my patch as per your comments : https://gerrit.wikimedia.org/r/325802 [16:34:08] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/News] - 10https://gerrit.wikimedia.org/r/326467 (https://phabricator.wikimedia.org/T151973) [16:34:26] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools, 13Patch-For-Review: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2865115 (10Huji) I created the user interface in the linked patch... [16:35:58] andre__ hi, which email, it seems i have one from you about phabricator weekly project changes [16:36:19] but carnt seem to find any email with https://phabricator.wikimedia.org/H107 [16:36:24] 10Wikimedia-Wikimania-Scholarships, 07I18n: [[Wikimedia:Wsa-form-intro-faq/en]] i18n issue - https://phabricator.wikimedia.org/T119760#1835134 (10bd808) We don't have a good method to separate the URLs from the messages in the current application. Is there some magic way to markup the message that indicates th... [16:37:16] 10Wikimedia-Wikimania-Scholarships, 07I18n: [[Wikimedia:Wsa-form-contrib-explain/uk]] i18n issue - https://phabricator.wikimedia.org/T122775#2865129 (10bd808) [16:38:29] paladox: Thu, 08 Dec 2016 22:01:03UTC [16:39:05] Oh [16:39:30] (03CR) 10VolkerE: [C: 04-1] Use global variable for tablet media query in responsive.less (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/326385 (https://phabricator.wikimedia.org/T124994) (owner: 10Jo12bar) [16:39:34] Reedy: Look at GCI site, heres all of that patches [16:39:35] http://linkbun.ch/04jo2 [16:39:50] 10MediaWiki-Special-pages: Easy date selection for Special:NewFiles - https://phabricator.wikimedia.org/T13836#2865152 (10Sn1per) [16:40:27] (03PS6) 10Cdentinger: add dash to crm role [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) [16:40:30] (03PS7) 10Cdentinger: WIP add dash to crm role [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) [16:41:00] 10Android-app-feature-Description-Editing, 10Android-app-goals-2016-Oct-Dec-Q2, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Add error handling to description editing interface. - https://phabricator.wikimedia.org/T148203#2865160 (10RHo) LGTM {F5041489} [16:41:39] (03PS1) 10Cdentinger: Allow force reinstall of node_modules directory [vagrant] - 10https://gerrit.wikimedia.org/r/326472 [16:43:00] (03CR) 10Niedzielski: [C: 04-1] "I'm not sure what the state of this patch is but please note that Grrrit dropped the reviewers" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325979 (owner: 10Mholloway) [16:43:07] 10AbuseFilter, 07Easy: AbuseLog should show a warning when log ID does not exist - https://phabricator.wikimedia.org/T152973#2865164 (10Huji) [16:43:25] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/News] - 10https://gerrit.wikimedia.org/r/326467 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:43:27] (03PS1) 10Huji: AbuseLog should show a warning when log ID does not exist [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326473 (https://phabricator.wikimedia.org/T152973) [16:43:41] 10AbuseFilter, 07Easy, 13Patch-For-Review: AbuseLog should show a warning when log ID does not exist - https://phabricator.wikimedia.org/T152973#2865179 (10Huji) p:05Triage>03Lowest a:03Huji [16:44:05] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/326462 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:44:35] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/News] - 10https://gerrit.wikimedia.org/r/326467 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:45:53] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326464 (https://phabricator.wikimedia.org/T152895) (owner: 10DCausse) [16:46:01] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326464 (https://phabricator.wikimedia.org/T152895) (owner: 10DCausse) [16:46:03] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (031 comment) [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:46:55] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/326462 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:46:59] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) [16:47:13] Reedy: Updated PollNY [16:47:26] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/326447 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:48:24] (03PS2) 10Huji: AbuseLog should show a warning when log ID does not exist [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326473 (https://phabricator.wikimedia.org/T152973) [16:48:31] (03PS5) 10Thiemo Mättig (WMDE): Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [16:48:38] (03CR) 10jenkins-bot: [V: 04-1] Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [16:48:55] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/326447 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:48:57] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/326460 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:49:31] (03CR) 10Nikerabbit: "It does not seem to be disabled in https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php" [core] - 10https://gerrit.wikimedia.org/r/326138 (https://phabricator.wikimedia.org/T151633) (owner: 10Dereckson) [16:49:32] andre__ found it [16:49:47] (03PS2) 10Huji: GENDER should be used for "triggered" in AbuseFilter log messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326371 (https://phabricator.wikimedia.org/T152872) [16:50:13] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/326460 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:51:04] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (032 comments) [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:51:54] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (031 comment) [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:53:21] (03PS3) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) [16:56:07] (03CR) 10Mholloway: "@Niedzielski Well, shoot. Thanks for the heads-up. I'm not sure either but might as well add everyone else at any rate." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325979 (owner: 10Mholloway) [16:56:10] (03PS4) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) [16:56:18] Reedy: Fixed [16:57:13] (03PS3) 10Jhernandez: Re-introduce Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) [16:57:57] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2865196 (10Volker_E) @Tbayer We're getting closer in identifying the issue. The applied style on other browsers rely on a CSS file that comes from a MailChi... [16:58:04] 10Wikimedia-Wikimania-Scholarships: Create a means to separate links and other non-translated content from messages - https://phabricator.wikimedia.org/T152974#2865197 (10bd808) [16:58:08] 10MediaWiki-Vagrant, 06Analytics-Kanban: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2865209 (10Nuria) [16:58:37] 10Wikimedia-Wikimania-Scholarships: Create a means to separate links and other non-translated content from messages - https://phabricator.wikimedia.org/T152974#2865212 (10bd808) [16:58:39] 10Wikimedia-Wikimania-Scholarships, 07I18n: [[Wikimedia:Wsa-form-contrib-explain/en]] i18n issue - https://phabricator.wikimedia.org/T119761#2865215 (10bd808) [16:58:41] 10Wikimedia-Wikimania-Scholarships, 07I18n: [[Wikimedia:Wsa-form-intro-faq/en]] i18n issue - https://phabricator.wikimedia.org/T119760#2865216 (10bd808) [16:58:55] 10Wikimedia-Wikimania-Scholarships: Create a means to separate links and other non-translated content from messages - https://phabricator.wikimedia.org/T152974#2865197 (10bd808) p:05Triage>03Normal [16:59:09] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [16:59:17] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326442 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:01:13] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:01:14] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Align MediaWiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2865228 (10Volker_E) [17:02:21] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/326451 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:03:58] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Maps Attribution: link to terms of use on dynamic maps - https://phabricator.wikimedia.org/T151900#2865233 (10debt) [17:06:39] McIntireEvan: https://codein.withgoogle.com/dashboard/task-instances/5318682349666304/ [17:07:43] (03CR) 10Fomafix: [C: 031] Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [17:07:50] (03CR) 10Niedzielski: [C: 032] Update design of "add description" CTA in article header. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326187 (owner: 10Dbrant) [17:08:35] (03PS2) 10Sn1per: Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) [17:08:45] (03CR) 10Niedzielski: TEMP: Update page subtitle view on description edit success [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325979 (owner: 10Mholloway) [17:12:05] (03PS3) 10Sn1per: Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) [17:13:26] 10MediaWiki-Special-pages, 03Community-Tech-Sprint, 07Community-Wishlist-Survey, 05MW-1.28-release-notes, and 2 others: Improve date range searches on Special:Contributions - https://phabricator.wikimedia.org/T120733#2865251 (10Volker_E) I still think, writing full month names as default is an improvement... [17:13:53] 10Android-app-Bugs, 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: In the news card items are truncated on the side - https://phabricator.wikimedia.org/T152975#2865252 (10Niedzielski) [17:14:01] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Maps Attribution: link to terms of use on dynamic maps - https://phabricator.wikimedia.org/T151900#2865266 (10debt) [17:14:34] (03Merged) 10jenkins-bot: Update design of "add description" CTA in article header. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326187 (owner: 10Dbrant) [17:15:58] addshore: Are you there? [17:15:59] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Maps Attribution: static map display - https://phabricator.wikimedia.org/T151906#2865273 (10debt) [17:16:01] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Align MediaWiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2865275 (10Volker_E) @Ladsgroup Again, providing screenshots with before/after are useful! [17:16:03] Yes! [17:16:05] rlot: ^^ [17:16:32] addshore: To huggle task "make localizable", i need to make pull request? [17:16:44] Yes you will have to! :) [17:16:50] Ok, great [17:17:35] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2865281 (10Jdlrobson) In the past we've written qa tests inside the sign off column but that's not the point... Let me rephrase... [17:18:29] addshore: How many strings do i need to make translatable? [17:18:36] *checks the task* [17:18:40] (03CR) 10VolkerE: [C: 04-1] "Same as on the other patch. Please provide a task with a before/after screenshot!" [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 (owner: 10Ladsgroup) [17:18:44] (03CR) 10Niedzielski: "Thanks for the patch! This isn't a feature I personally would use but it seems to work well. @dbrant, I think we'll need sign off from pro" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326286 (owner: 10XinyueZ) [17:19:57] (03PS4) 10Sn1per: Pager class for filtering by date range [core] - 10https://gerrit.wikimedia.org/r/326459 (https://phabricator.wikimedia.org/T120733) [17:20:36] (03PS1) 10Sn1per: Date range filtering in Special:NewFiles [core] - 10https://gerrit.wikimedia.org/r/326476 (https://phabricator.wikimedia.org/T13836) [17:21:50] so rlot the task doesnt specify a number ;) [17:22:09] but it provides an example >> https://github.com/huggle/huggle3-qt-lx/commit/ea52e2607a36d7a5bf94317c3ff178183c9bc16f [17:22:24] 10 sounds like a good target! [17:22:26] addshore: I see, thanks! [17:23:04] 06Wikipedia-Android-App-Backlog, 07Technical-Debt: Periodic CI tests often fail to start the emulator - https://phabricator.wikimedia.org/T152976#2865292 (10Niedzielski) [17:24:33] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2865307 (10Jdlrobson) [17:24:36] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 03UI-Standardization-Kanban: When hovering over a menu item icon and text should change colour - https://phabricator.wikimedia.org/T152418#2865304 (10Jdlrobson) 05Open>03stalled The team decided that this will be stalled until there is a ge... [17:28:55] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Map attribution needs to be visible at all times, including when Map Details is displayed - https://phabricator.wikimedia.org/T152978#2865322 (10debt) [17:31:51] 04(no projects): Allow "application/json" content-type in response to action=raw, for JSON content-model pages - https://phabricator.wikimedia.org/T152979#2865339 (10Nihiltres) [17:33:10] (03CR) 10Fomafix: [C: 04-1] "The CSS file must renamed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [17:35:37] (03CR) 10VolkerE: "Please provide a before/after screenshot on the task!" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/325364 (https://phabricator.wikimedia.org/T152447) (owner: 10Ladsgroup) [17:36:19] (03CR) 10VolkerE: "Please provide a before/after screenshot on the task!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) (owner: 10Ladsgroup) [17:37:09] (03CR) 10VolkerE: [C: 032] Align colors with Wikimedia color palette [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/326314 (owner: 10Ladsgroup) [17:38:21] (03PS8) 10Cdentinger: WIP add dash to crm role [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) [17:38:51] (03CR) 10EBernhardson: [C: 032] Send options as Base64 to runSearch [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/325995 (owner: 10DCausse) [17:39:22] (03Merged) 10jenkins-bot: Align colors with Wikimedia color palette [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/326314 (owner: 10Ladsgroup) [17:39:25] (03Merged) 10jenkins-bot: Send options as Base64 to runSearch [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/325995 (owner: 10DCausse) [17:40:24] (03PS1) 10Dbrant: Update survey end time. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326478 [17:40:28] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2865356 (10Volker_E) The `input`'s width is also giving us a hint, that exactly what I've described above is happening. https://cdn-images.mailchimp.com/emb... [17:41:28] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] IllegalArgumentException due to illegal URL: null://null/api/rest_v1/ - https://phabricator.wikimedia.org/T152980#2865363 (10Dbrant) [17:41:46] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog: Add BBcode to MV export options - https://phabricator.wikimedia.org/T152838#2865377 (10pmiazga) [17:42:35] 06Reading-Web-Backlog, 10RelatedArticles: RelatedArticles should not depend on EventLogging - https://phabricator.wikimedia.org/T152828#2865378 (10pmiazga) [17:46:11] (03CR) 10Anomie: "Looked at the API changes, didn't review the rest." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/325881 (owner: 10EBernhardson) [17:46:14] (03CR) 10Mholloway: [C: 032] Update survey end time. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326478 (owner: 10Dbrant) [17:46:16] (03CR) 10Niedzielski: [C: 031] "The survey was meant to be rhetorical!" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326478 (owner: 10Dbrant) [17:49:31] (03Merged) 10jenkins-bot: Update survey end time. [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326478 (owner: 10Dbrant) [17:50:39] (03PS2) 10Reedy: Remove unused message from AbuseFilter i18n files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [17:51:16] addshore: Ok, i made it [17:51:20] https://github.com/huggle/huggle3-qt-lx/pull/188 [17:51:38] (03PS1) 10Mayank.jindal5: fragment_news.xml: Fix news stories obscuring by system status bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326479 (https://phabricator.wikimedia.org/T141991) [17:53:12] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] NPE at org.wikipedia.edit.preview.Wikitext$Query.wikitext() - https://phabricator.wikimedia.org/T152982#2865406 (10Dbrant) [17:55:03] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Map attribution needs to be visible at all times, including when Map Details is displayed - https://phabricator.wikimedia.org/T152978#2865420 (10Yurik) [17:56:19] 10The-Wikipedia-Library: Filtering is not working - https://phabricator.wikimedia.org/T152983#2865423 (10Stryn) [17:57:07] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] RemoteServiceException: Bad notification posted from package org.wikipedia: Couldn't create icon: StatusBarIcon - https://phabricator.wikimedia.org/T152984#2865437 (10Dbrant) [17:58:30] 10Phabricator: Custom task form for #WMF-NDA - https://phabricator.wikimedia.org/T142516#2865453 (10AlexMonk-WMF) I think it's close, it just needs the tag field to always include #WMF-NDA and I think the only way to do that right now is to lock it. [17:59:14] (03PS4) 10Reedy: Fix completely broken UserMerge support [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/313917 [17:59:23] (03CR) 10Reedy: [C: 032] Fix completely broken UserMerge support [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/313917 (owner: 10Reedy) [18:00:32] (03Merged) 10jenkins-bot: Fix completely broken UserMerge support [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/313917 (owner: 10Reedy) [18:00:43] (03PS3) 10Reedy: Add a version; set to 1.1 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/313920 [18:00:47] (03CR) 10Reedy: [C: 032] Add a version; set to 1.1 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/313920 (owner: 10Reedy) [18:01:09] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] RemoteServiceException: Bad notification posted from package org.wikipedia: Couldn't create icon: StatusBarIcon - https://phabricator.wikimedia.org/T152984#2865472 (10Dbrant) This is currently the topmost crash, despite being deceptively sca... [18:01:44] rlot: it looks like travis says the build fails [18:01:51] did you try buling it locally before submitting the PR? [18:02:03] (03Merged) 10jenkins-bot: Add a version; set to 1.1 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/313920 (owner: 10Reedy) [18:04:16] (03CR) 10Mglaser: [C: 032] BSReview: Fixed bug where only a review on the mainpage could be edited [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326424 (owner: 10Mglaser) [18:04:53] addshore: Give me a sec [18:06:20] (03Draft2) 10Reedy: Remove WikiPage::getText() call [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/326480 (https://phabricator.wikimedia.org/T151973) [18:07:25] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2865486 (10Volker_E) @Tbayer @EdErhart-WMF After looking closer into the plugin administration, removing style dependency looks like a case for customer sup... [18:07:55] 06Discovery, 06Maps (Map-Styles): Deploy borders table on prod cluster - https://phabricator.wikimedia.org/T152986#2865489 (10Yurik) [18:09:15] addshore: Got it [18:10:14] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: CapsuleMultiSelectWidget: Label doesn't function as label - https://phabricator.wikimedia.org/T148946#2737304 (10Volker_E) p:05Low>03Triage [18:10:53] (03CR) 10Gehel: [C: 031] "lgtm (not entirely nice, but better than what we have now)" [vagrant] - 10https://gerrit.wikimedia.org/r/325908 (https://phabricator.wikimedia.org/T138608) (owner: 10Gergő Tisza) [18:10:55] (03PS3) 10Nschaaf: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) [18:11:16] 10MobileFrontend, 06Reading-Web-Backlog: Menu icons misaligned in Firefox 50 (light navigation drawer) - https://phabricator.wikimedia.org/T152391#2865515 (10Jhernandez) I'm still seeing the same thing but if others aren't, lets just close it. [18:11:37] (03CR) 10DCausse: [C: 032] Update elasticsearch version to match Wikimedia apt repo [vagrant] - 10https://gerrit.wikimedia.org/r/325908 (https://phabricator.wikimedia.org/T138608) (owner: 10Gergő Tisza) [18:12:16] (03CR) 10jenkins-bot: [V: 04-1] Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [18:13:26] (03Merged) 10jenkins-bot: Update elasticsearch version to match Wikimedia apt repo [vagrant] - 10https://gerrit.wikimedia.org/r/325908 (https://phabricator.wikimedia.org/T138608) (owner: 10Gergő Tisza) [18:13:54] 10Phabricator (Upstream), 07Upstream: Burnup Rate diagrams for several projects? - https://phabricator.wikimedia.org/T152987#2865520 (10Volker_E) [18:14:23] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2865534 (10Jdlrobson) [18:14:43] 10Phabricator, 05Security: Security: "Other confidential issue" does not do anything - https://phabricator.wikimedia.org/T152959#2865536 (10faidon) Thanks, that was fast :) When was this changed? Shouldn't we audit all the tasks opened using that functionality since it was deprecated to make sure we don't have... [18:15:12] (03PS2) 10EBernhardson: Cleanup some incorrect return annotations [core] - 10https://gerrit.wikimedia.org/r/325881 [18:15:14] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2858423 (10Jdlrobson) [18:15:18] (03PS1) 10BryanDavis: Wording tweak from review meeting [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326483 [18:15:38] (03CR) 10EBernhardson: "updated preg_match changes to cast (bool) instead of === 1" [core] - 10https://gerrit.wikimedia.org/r/325881 (owner: 10EBernhardson) [18:17:18] addshore: Ok, text passes [18:17:29] addshore: *tests [18:18:01] 10MobileFrontend, 06Reading-Web-Backlog: Menu icons misaligned in Firefox 50 (light navigation drawer) - https://phabricator.wikimedia.org/T152391#2846684 (10MBinder_WMF) p:05Triage>03Normal [18:18:12] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2865552 (10MBinder_WMF) p:05Triage>03High [18:18:22] looks good! [18:18:55] approved [18:18:58] (03PS4) 10Nschaaf: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) [18:20:02] (03CR) 10MarkTraceur: "I still don't see the category on the redirect file page...did you confirm that was working locally?" [core] - 10https://gerrit.wikimedia.org/r/266582 (https://phabricator.wikimedia.org/T29857) (owner: 10TheDJ) [18:20:43] (03CR) 10jenkins-bot: [V: 04-1] Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [18:23:39] (03PS5) 10Nschaaf: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) [18:24:56] (03CR) 10jenkins-bot: [V: 04-1] Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [18:24:58] (03CR) 10Kaldari: [C: 04-1] Switch special page to be a QueryPage rather than using an IndexPager (032 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) (owner: 10Samwilson) [18:26:05] (03PS6) 10Nschaaf: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) [18:28:25] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865578 (10Yurik) Bummer, now we no longer get any of the Phabricator notifications in the wikimedia-interact... [18:28:28] (03PS1) 10Cicalese: Updated extensions/lua. [tools/ansible-wikifarm] - 10https://gerrit.wikimedia.org/r/326488 [18:28:50] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 3 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2865580 (10Krenair) [18:29:52] (03PS3) 10Smalyshev: Allow extensions to hook features [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) [18:30:19] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865584 (10Aklapper) @Yurik: https://phabricator.wikimedia.org/diffusion/TWBT/browse/master/channels.yaml [18:31:22] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865590 (10Yurik) @aklapper but it was there -- https://phabricator.wikimedia.org/diffusion/TWBT/browse/maste... [18:31:38] 06Discovery, 06Discovery-Search: TextCat shows search results from the same wiki - https://phabricator.wikimedia.org/T152988#2865591 (10Raymond) [18:33:53] 10Android-app-Bugs, 07Easy, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Sharing picture of the day to email has a poor subject line - https://phabricator.wikimedia.org/T151023#2865618 (10RHo) LGTM, nice one. {F5042718} [18:34:25] (03CR) 10Smalyshev: Allow extensions to hook features (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [18:34:56] (03CR) 10Jforrester: [C: 032] ImageHistoryPseudoPager: Don't ignore limit from URL [core] - 10https://gerrit.wikimedia.org/r/326361 (https://phabricator.wikimedia.org/T152813) (owner: 10Bartosz Dziewoński) [18:35:24] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2865622 (10bmansurov) a:03bmansurov [18:38:09] 06Discovery, 06Maps (Map-Styles): Deploy borders table on prod cluster - https://phabricator.wikimedia.org/T152986#2865628 (10Pnorman) For this we're after a short term solution until meddo+brighmed is done. We want the maps server to download the data from somewhere and load it into PostgreSQL. The questions... [18:38:37] (03CR) 10Niharika29: [C: 032] Fix missing Special:MyLanguage references [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326466 (https://phabricator.wikimedia.org/T152940) (owner: 10BryanDavis) [18:38:59] 06Offline Working Group, 03Discovery-Portal-Sprint, 13Patch-For-Review: Add node 6 compatibility to Portal build tasks - https://phabricator.wikimedia.org/T150190#2865630 (10Fjalapeno) [18:39:27] (03CR) 10Niharika29: [C: 032] Wording tweak from review meeting [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326483 (owner: 10BryanDavis) [18:40:37] (03CR) 10Cicalese: [V: 032 C: 032] Updated extensions/lua. [tools/ansible-wikifarm] - 10https://gerrit.wikimedia.org/r/326488 (owner: 10Cicalese) [18:41:44] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865635 (10Aklapper) @Yurik: https://phabricator.wikimedia.org/T148650 might provide some insights on milesto... [18:43:07] (03Merged) 10jenkins-bot: ImageHistoryPseudoPager: Don't ignore limit from URL [core] - 10https://gerrit.wikimedia.org/r/326361 (https://phabricator.wikimedia.org/T152813) (owner: 10Bartosz Dziewoński) [18:43:10] (03PS7) 10Nschaaf: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) [18:43:12] (03Merged) 10jenkins-bot: Fix missing Special:MyLanguage references [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326466 (https://phabricator.wikimedia.org/T152940) (owner: 10BryanDavis) [18:43:13] (03Merged) 10jenkins-bot: Wording tweak from review meeting [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/326483 (owner: 10BryanDavis) [18:45:12] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I don't think logentry-abusefilter-hit is unused. Messages like logentry-A-B are generated in LogFormatter::getMessageKey(), and there's a" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [18:46:03] 10AbuseFilter, 07Easy, 07I18n, 13Patch-For-Review: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2863901 (10matmarex) That sounds like a very boring GCI task, and also error-prone because the message name construction by concatenation is more common that you... [18:46:30] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/boost_template_api.feature:3:7:11:15:19:23 features/did_you_mean_api.featu" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [18:46:41] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326037 (https://phabricator.wikimedia.org/T152730) (owner: 10Smalyshev) [18:47:01] (03CR) 10Nschaaf: [C: 032] Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [18:48:12] (03Merged) 10jenkins-bot: Add related articles recommendation type [research/recommendation-api] - 10https://gerrit.wikimedia.org/r/326058 (https://phabricator.wikimedia.org/T151793) (owner: 10Nschaaf) [18:48:22] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2865653 (10cscott) @Rfarrand Hmm, I had the idea that we were doing 2 days of prescheduled (with unconference on the side) followed by one... [18:48:32] (03CR) 10Jdlrobson: [C: 032] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [18:48:46] (03PS1) 10Bartosz Dziewoński: ImageHistoryPseudoPager: Don't ignore limit from URL [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326497 (https://phabricator.wikimedia.org/T152813) [18:48:53] (03CR) 10Jdlrobson: [C: 04-1] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [18:50:07] 10Phabricator, 06Discovery, 06Maps, 06Project-Admins: Rearrange the discovery interactive and maps phab projects, including converting some to milestones - https://phabricator.wikimedia.org/T137816#2865657 (10Yurik) @Aklapper uploaded https://gerrit.wikimedia.org/r/#/c/326496/ - please +2, thx! [18:51:01] (03CR) 10Jdlrobson: [C: 04-1] Large gap left in footer on pages with no related articles (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [18:52:11] (03CR) 10Bartosz Dziewoński: [C: 032] Don't show hit count field if it's always empty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326253 (owner: 10Matěj Suchánek) [18:52:16] 10Wikimedia-Site-requests, 13Patch-For-Review: On wikis where uploads are fully disabled remove upload rights on any group - https://phabricator.wikimedia.org/T143789#2579006 (10Nemo_bis) I'm ok with this proposal. It would be even nicer if MediaWiki handled this, by "unregistering" the upload-related permissi... [18:52:59] (03PS1) 10Reedy: WikiPage::getText() was removed [core] - 10https://gerrit.wikimedia.org/r/326498 (https://phabricator.wikimedia.org/T145728) [18:55:12] 10MediaWiki-extensions-Babel, 07I18n: Babel Extension - Issue with ASE language code - https://phabricator.wikimedia.org/T152925#2863705 (10Quiddity) I've replied (hopefully with correct details) at https://meta.wikimedia.org/wiki/Talk:User_language#Issue_with_ase - If that's the only thing that needs to be do... [18:55:57] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2865687 (10Rfarrand) @cscott: Day 3 is a self organized day or "Hacking Day" with no meeting spaces available to be scheduled. People can... [18:56:03] 10MediaWiki-ContentHandler: Allow "application/json" content-type in response to action=raw, for JSON content-model pages - https://phabricator.wikimedia.org/T152979#2865688 (10Krenair) [18:57:25] 10MediaWiki-extensions-GuidedTour, 10Wikimedia Resource Center, 10Wikimedia-Site-requests, 13Patch-For-Review: Install GuidedTour extension on Meta - https://phabricator.wikimedia.org/T152656#2856233 (10MarcoAurelio) Sorry for being a bit nitpick, but the Meta-Wiki has not been consulted about this and Met... [18:57:42] (03PS1) 10Jdlrobson: Surface number of editors in trending responses [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326499 [18:58:16] (03CR) 10Daniel Kinzler: [C: 032] WikiPage::getText() was removed [core] - 10https://gerrit.wikimedia.org/r/326498 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [18:58:28] Reedy: \o/ [18:58:36] Getting there! [18:58:40] :D [18:58:51] (03PS10) 10Mholloway: Description editing tutorial [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325424 (https://phabricator.wikimedia.org/T148205) [18:58:56] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/326480/ [18:58:58] Reedy: thanks for taking care of this. [18:59:03] Related, but won't break anything not being merged [18:59:04] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] RemoteServiceException: Bad notification posted from package org.wikipedia: Couldn't create icon: StatusBarIcon - https://phabricator.wikimedia.org/T152984#2865704 (10Dbrant) a:03Dbrant [18:59:07] As they already had compat for the new way [18:59:51] Reedy: merging this will break compat with mw < 1.21 [19:00:01] probably fine, but... [19:00:03] DanielK_WMDE: Does anyone care? [19:00:06] Probably not [19:00:14] who knows! [19:00:17] Even the SMW guys aren't caring about that old anymore [19:00:55] (03CR) 10Daniel Kinzler: [C: 031] "This breaks compat with mw < 1.21. Does anyone care?" [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/326480 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [19:01:19] 10MediaWiki-Categories, 07Documentation: Document how to decide if adding a new category collation is OK to do quickly and when we need to do other prep - https://phabricator.wikimedia.org/T447#2865722 (10greg) >>! In T447#2863700, @matmarex wrote: > @greg: What remains to be done here? We've been routinely ch... [19:01:24] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: insource (regex) search on en.wp's Special:Search does not work - https://phabricator.wikimedia.org/T152895#2865723 (10dcausse) [19:01:42] 10Android-app-feature-Description-Editing, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Long Wikidata descriptions get clipped - https://phabricator.wikimedia.org/T152213#2841861 (10RHo) hi @Niedzielski – I tested on the article "Quantum field theory" and the wikidata description is no long... [19:01:48] (03PS4) 10Phuedx: LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) [19:01:51] (03PS4) 10Phuedx: LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) [19:01:55] (03PS4) 10Phuedx: {LINK,PREVIEW}_ABANDON_END logs an event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325928 (https://phabricator.wikimedia.org/T152225) [19:05:03] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2865731 (10cscott) @Rfarrand Yup. We should probably keep this task focused on this year, not next, though. My apologies. Perhaps we ha... [19:06:18] 10MediaWiki-General-or-Unknown, 10ArchCom-RfC, 07ArchCom-Has-shepherd: [RfC] Deprecation policy for PHP code in MediaWiki - https://phabricator.wikimedia.org/T146965#2676292 (10daniel) Scheduled to be discussed during the ArchCom RFC office hour at #wikimedia-office on Wednesday December 14, at 21:00 UTC (2p... [19:07:26] DanielK_WMDE: yeah, SMW are >= 1.23 [19:07:48] (03CR) 10Fjalapeno: [C: 031] Surface number of editors in trending responses [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326499 (owner: 10Jdlrobson) [19:07:53] 10MediaWiki-extensions-GuidedTour, 10Wikimedia Resource Center, 10Wikimedia-Site-requests, 13Patch-For-Review: Install GuidedTour extension on Meta - https://phabricator.wikimedia.org/T152656#2865737 (10Mattflaschen-WMF) I don't think this requires community consensus. It doesn't impact the default user ex... [19:09:15] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work): Search engine does not find "ai dû" on the French Wiktionary. - https://phabricator.wikimedia.org/T151173#2865738 (10dcausse) 05stalled>03Resolved fr.wiktionary.org is now reindexed with the new settings, this is still not perfect but //Anne... [19:09:31] (03PS1) 10Dbrant: Fix crash when posting W0 notification on API <21. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326502 (https://phabricator.wikimedia.org/T152984) [19:09:48] 10MediaWiki-Email, 10Mail, 06Operations, 10Wikimedia-General-or-Unknown, and 3 others: Email server's DMARC config prevents users from sending emails via Special:EmailUser - https://phabricator.wikimedia.org/T66795#1044685 (10Johan) I changed the email address on one of my accounts (one I use when I give p... [19:10:04] (03Merged) 10jenkins-bot: Don't show hit count field if it's always empty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326253 (owner: 10Matěj Suchánek) [19:10:06] (03Merged) 10jenkins-bot: WikiPage::getText() was removed [core] - 10https://gerrit.wikimedia.org/r/326498 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [19:11:01] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2865751 (10Rfarrand) > Do we need to schedule some time for the "20 second pitch" sessions to kick off the unconference? Maybe the presche... [19:11:52] 10MediaWiki-Special-pages, 03Community-Tech-Sprint, 07Community-Wishlist-Survey, 05MW-1.28-release-notes, and 2 others: Improve date range searches on Special:Contributions - https://phabricator.wikimedia.org/T120733#2865752 (10kaldari) @Volker_E: I agree, especially because month abbreviations may not be... [19:13:40] (03CR) 10Jforrester: "> Blocking this on #2 being finished on WMF wikis. #1 can be done later on an opt-in bases via the feature flag." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/229852 (https://phabricator.wikimedia.org/T33597) (owner: 10Krinkle) [19:14:34] (03PS1) 10Mobrovac: Update change-propagation to 0018164 [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/326503 [19:14:43] (03CR) 10Phuedx: "PS4 fixes the failing test case." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [19:15:28] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326504 (https://phabricator.wikimedia.org/T151973) [19:15:35] (03CR) 10Mobrovac: [V: 032 C: 032] Update change-propagation to 0018164 [services/change-propagation/deploy] - 10https://gerrit.wikimedia.org/r/326503 (owner: 10Mobrovac) [19:16:18] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326504 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:17:41] (03PS1) 10Mholloway: Description edit tutorial: replace vector drawables with PNGs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326505 (https://phabricator.wikimedia.org/T148205) [19:18:14] (03CR) 10Phuedx: [C: 032] "Per Jhernandez's review of PS 3." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [19:18:55] (03CR) 10Mobrovac: [C: 032] Surface number of editors in trending responses [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326499 (owner: 10Jdlrobson) [19:19:22] (03CR) 10Thcipriani: [C: 032] "SWAT" [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326497 (https://phabricator.wikimedia.org/T152813) (owner: 10Bartosz Dziewoński) [19:19:35] (03PS1) 10Reedy: Replace Article::fetcContent() [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/326506 (https://phabricator.wikimedia.org/T151973) [19:20:25] (03CR) 10Phuedx: [C: 032] "Per Jhernandez's review of PS1 – N.B. that PS2 and PS3 were rebases." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325928 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [19:20:57] (03Merged) 10jenkins-bot: LINK_DWELL starts an interaction [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325926 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [19:21:11] 10MediaWiki-Gallery, 06Multimedia, 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Change the default mode of tags to mode=packed on English Wikipedia - https://phabricator.wikimedia.org/T141349#2865778 (10Whatamidoing-WMF) [19:21:14] (03PS1) 10Reedy: Article::fetchContent() was removed [core] - 10https://gerrit.wikimedia.org/r/326507 (https://phabricator.wikimedia.org/T145728) [19:21:55] (03Merged) 10jenkins-bot: LINK_CLICK logs an "opened" event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325927 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [19:22:42] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/326508 (https://phabricator.wikimedia.org/T151973) [19:22:51] (03CR) 10Ppchelko: "Updated the public API PR" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326499 (owner: 10Jdlrobson) [19:23:11] (03CR) 10Daniel Kinzler: [C: 031] "Looks good to me, but is it really no longer used anywhere?" [core] - 10https://gerrit.wikimedia.org/r/326507 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [19:23:46] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2865784 (10Reedy) Article::getContent() ``` Method getC... [19:24:12] (03PS2) 10Reedy: Replace Article::fetchContent() [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/326506 (https://phabricator.wikimedia.org/T151973) [19:24:28] (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/#/c/326506/ is the last usage" [core] - 10https://gerrit.wikimedia.org/r/326507 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [19:26:09] (03CR) 10Jdlrobson: Implement mw-references list with responsive columns (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/229852 (https://phabricator.wikimedia.org/T33597) (owner: 10Krinkle) [19:26:10] 10MediaWiki-Gallery, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Media: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2865786 (10Jdforrester-WMF) p:05Normal>03High [19:26:31] 06Research-and-Data, 10Research-outreach: Wiki Workshop 2017 planning - https://phabricator.wikimedia.org/T151923#2865798 (10DarTar) [19:27:12] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/326509 (https://phabricator.wikimedia.org/T151973) [19:27:39] 06Research-and-Data, 10Research-outreach: Research showcase December 2016 - https://phabricator.wikimedia.org/T151782#2865803 (10DarTar) @Tbayer I'd like to decide early this week who to invite as a potential second speaker, do you have a moment to check in? [19:28:05] 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint, 13Patch-For-Review: Recursive URLs, available in the Wikipedia.org portal - https://phabricator.wikimedia.org/T151685#2865804 (10MaxSem) Sigh, as far as I remember there was a need for this to work both in production (with mediawiki-config's docr... [19:28:46] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2865806 (10Reedy) [19:29:21] 07Easy, 03Google-Code-In-2016: Create a LUA module that contains commonly-used image functions - https://phabricator.wikimedia.org/T148618#2865820 (10Strainu) 05Open>03Resolved a:03Strainu @borisfba implemented this at https://www.mediawiki.org/wiki/Module:ImageUtils [19:29:25] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/326511 (https://phabricator.wikimedia.org/T151973) [19:31:01] (03PS1) 10Jhernandez: Move settings images and styles to ext.popups/ [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326512 [19:31:02] 06Research-and-Data: ORES in Q3 - https://phabricator.wikimedia.org/T152994#2865840 (10DarTar) [19:31:04] (03PS1) 10Jhernandez: Hygiene: Use constant instead of string 'LINK_CLICK' [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326513 [19:31:07] (03PS1) 10Jhernandez: Hygiene: Rename action constants for consistency [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326514 [19:31:10] (03PS1) 10Jhernandez: Create the settings reducer [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326515 [19:31:13] (03PS1) 10Jhernandez: Introduce the settings change listener [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326516 [19:31:16] (03PS1) 10Jhernandez: Wire up showing settings via footer link or cog icon [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326517 [19:31:19] (03PS1) 10Jhernandez: Move settings template to ext.popups [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326518 [19:31:22] (03PS1) 10Jhernandez: Introduce the settings dialog UI [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326519 [19:31:32] (03PS1) 10Thcipriani: Bump ElectronPdfService submodule [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326520 [19:31:35] (03CR) 10Daniel Kinzler: Replace Article::fetchContent() (031 comment) [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/326506 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [19:32:00] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326521 (https://phabricator.wikimedia.org/T151973) [19:32:04] Reedy: please avoid getNativeData. I really want to kill it. [19:32:08] 06Research-and-Data: ORES in Q3 - https://phabricator.wikimedia.org/T152994#2865873 (10DarTar) p:05Triage>03Normal [19:32:13] 10Wikimedia Resource Center: Guided Tours extension for WRC - https://phabricator.wikimedia.org/T147899#2865874 (10mcruzWMF) @Ocaasi_WMF I Updated Guided Tours script. You can find it here: https://docs.google.com/document/d/1Q-7zMrffLFgYXDHkuRbQh2PJUnTEKtmJRQjj8BDLlik/edit#heading=h.a8xwx3dyj7nz [19:32:35] it gives absolutely no guarantee as to what it returns. So it's really not possibel to use it without making bad assumptions [19:32:37] (03CR) 10Awight: "Note that Puppet lint is going to require we align all the "=>" in each block. Boo." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) (owner: 10Cdentinger) [19:32:43] Reedy: --^^ [19:32:52] (03Abandoned) 10Jhernandez: Re-introduce Settings dialog [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326419 (https://phabricator.wikimedia.org/T152223) (owner: 10Jhernandez) [19:33:00] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2865891 (10Krenair) https://wikitech.wikimedia.org/w/index.php?title=Add_a_wiki&diff=1126855&oldid=1069881 godog/Filippo has offered to look at the RB patch probably this week [19:33:08] Reedy: instead, TextContent should have a getText method [19:33:25] (03CR) 10Addshore: [C: 031] Bump ElectronPdfService submodule [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326520 (owner: 10Thcipriani) [19:33:32] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Maps Attribution: static map display - https://phabricator.wikimedia.org/T151906#2865894 (10JGirault) a:03JGirault [19:33:50] 06Discovery, 03Interactive-Sprint, 06Maps (Kartotherian): Snapshot service does not handle auto-positioning - https://phabricator.wikimedia.org/T149147#2865895 (10JGirault) a:03JGirault [19:34:06] (03CR) 10Thcipriani: [C: 032] "SWAT" [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326520 (owner: 10Thcipriani) [19:34:17] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326521 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:34:46] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2865912 (10JGirault) [19:35:00] (03CR) 10jenkins-bot: [V: 04-1] Move settings images and styles to ext.popups/ [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326512 (owner: 10Jhernandez) [19:35:09] 10Wikimedia Resource Center: Guided Tours extension for WRC - https://phabricator.wikimedia.org/T147899#2865925 (10mcruzWMF) [19:35:20] 10Tools-Global-user-contributions: Global user contributions - tool not working - https://phabricator.wikimedia.org/T152922#2865927 (10scfc) If I go to https://tools.wmflabs.org/guc/?user=BrillLyle, after some "|" are displayed, it says: "736 wikis searched. 38085 edits found in 16 projects." and your contributi... [19:36:03] 10Data-release, 06Research-and-Data, 10Wikilabels: Licensing of labeled data - https://phabricator.wikimedia.org/T145024#2865929 (10DarTar) @halfak bumping this thread today [19:36:16] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326522 (https://phabricator.wikimedia.org/T151973) [19:36:27] 10Wikimedia Resource Center: Guided Tours extension for WRC - https://phabricator.wikimedia.org/T147899#2707611 (10mcruzWMF) [19:36:38] (03Merged) 10jenkins-bot: Surface number of editors in trending responses [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326499 (owner: 10Jdlrobson) [19:37:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename action constants for consistency [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326514 (owner: 10Jhernandez) [19:37:23] (03CR) 10Filip: "Jenkins fail unrelated." [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326521 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:37:29] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326522 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:37:57] 10MediaWiki-ContentHandler, 10ArchCom-RfC, 06Collaboration-Team-Triage, 07ArchCom-Has-shepherd, and 2 others: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2865934 (10daniel) a:05daniel>03None unassigning myself, since we now track shephers via #ArchCom-Has-shepherd [19:38:06] (03Merged) 10jenkins-bot: ImageHistoryPseudoPager: Don't ignore limit from URL [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326497 (https://phabricator.wikimedia.org/T152813) (owner: 10Bartosz Dziewoński) [19:38:09] (03Merged) 10jenkins-bot: {LINK,PREVIEW}_ABANDON_END logs an event [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/325928 (https://phabricator.wikimedia.org/T152225) (owner: 10Phuedx) [19:38:12] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use constant instead of string 'LINK_CLICK' [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326513 (owner: 10Jhernandez) [19:38:40] (03CR) 10Filip: "Jenkins unrelated" [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326522 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:38:51] (03CR) 10jenkins-bot: [V: 04-1] Create the settings reducer [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326515 (owner: 10Jhernandez) [19:38:54] (03CR) 10Filip: "Jenkins unrelated" [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326504 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:38:57] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Enable GuidedTour on all wikis - https://phabricator.wikimedia.org/T152827#2865939 (10Mattflaschen-WMF) >>! In T152827#2863468, @Dereckson wrote: > I concur this is a good idea: when not configured, it doesn't create a... [19:39:43] 06Discovery, 03Interactive-Sprint, 06Maps (Kartographer): Improve tabular data styling - https://phabricator.wikimedia.org/T152998#2865953 (10JGirault) [19:39:45] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2865954 (10Tbayer) @Volker_E No ad blocker add-on was active. But it turns out this Mailchimp CSS is blocked by the inbuilt [[https://developer.mozilla.org/... [19:39:49] (03CR) 10jenkins-bot: [V: 04-1] Introduce the settings change listener [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326516 (owner: 10Jhernandez) [19:39:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikimedia-Site-requests, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Please enable abe or Western Abenaki - https://phabricator.wikimedia.org/T150633#2791594 (10Nikki) There are currently 4 items with labels for this language code. Does this... [19:40:13] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Skip 'descriptionpage' step of test tour (test.js) if there is no description page - https://phabricator.wikimedia.org/T153000#2865959 (10Mattflaschen-WMF) [19:41:16] 10Recommendation-API: Create README for packaging wheels - https://phabricator.wikimedia.org/T147004#2865972 (10schana) 05Open>03Resolved [19:41:28] Reedy: Are you there? I'm making another task, and: [19:41:43] 10Recommendation-API: Design schema for general Recommendation API - https://phabricator.wikimedia.org/T144421#2865975 (10schana) [19:41:44] Reedy: 2 extensions failed, jenkins unrelated [19:41:58] 10Recommendation-API: Design schema for general Recommendation API - https://phabricator.wikimedia.org/T144421#2599279 (10schana) a:05ori>03schana [19:42:02] Reedy: Patroller dont use ->getText in Revision [19:42:12] (03CR) 10jenkins-bot: [V: 04-1] Wire up showing settings via footer link or cog icon [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326517 (owner: 10Jhernandez) [19:42:17] 10Recommendation-API: Design schema for general Recommendation API - https://phabricator.wikimedia.org/T144421#2599279 (10schana) 05Open>03Resolved [19:42:34] 06Reading-Admin, 10Security-Reviews, 10TemplateStyles: Security review of TemplateStyles - https://phabricator.wikimedia.org/T133408#2230994 (10dr0ptp4kt) Note: remediation slated for Q3 FY 2016-2017 (January - March 2017) by Reading Infrastructure. Heads up @dpatrick, in case re-reviews need slotting the sa... [19:43:09] (03CR) 10jenkins-bot: [V: 04-1] Move settings template to ext.popups [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326518 (owner: 10Jhernandez) [19:44:39] (03CR) 10jenkins-bot: [V: 04-1] Introduce the settings dialog UI [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/326519 (owner: 10Jhernandez) [19:44:45] (03Merged) 10jenkins-bot: Bump ElectronPdfService submodule [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326520 (owner: 10Thcipriani) [19:48:11] (03CR) 10Jdlrobson: [C: 04-1] "Our PHP less implementation does not support unfortunately. At least I can see this isnt working which leads me to believe that." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326192 (https://phabricator.wikimedia.org/T94102) (owner: 10Niedzielski) [19:48:17] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/326524 (https://phabricator.wikimedia.org/T151973) [19:48:27] (03CR) 10Jdlrobson: [C: 04-1] "Our PHP less implementation does not support when unfortunately. At least I can see this isnt working which leads me to believe that." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326192 (https://phabricator.wikimedia.org/T94102) (owner: 10Niedzielski) [19:48:34] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Skip 'descriptionpage' step of test tour (test.js) if there is no description page, and launchtour step if it's not editable and main namespace - https://phabricator.wikimedia.org/T153000#2865988 (10Mattflaschen-WMF) a... [19:48:41] 10MediaWiki-extensions-Babel, 07I18n: Babel Extension - Issue with ASE language code - https://phabricator.wikimedia.org/T152925#2865990 (10AnotherPoint) As I noted earlier, multiple languages seem to have issues with Babel userboxes in Wikimedia. It would help if the settings in Wikipedia, where these issues... [19:48:45] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Skip 'descriptionpage' step of test tour (test.js) if there is no description page, and 'launchtour' step if it's not editable and main namespace - https://phabricator.wikimedia.org/T153000#2865959 (10Mattflaschen-WMF) [19:48:50] (03CR) 10Jdlrobson: [C: 04-1] "Volker ^" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326192 (https://phabricator.wikimedia.org/T94102) (owner: 10Niedzielski) [19:48:50] DanielK_WMDE: lol [19:50:08] (03PS1) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/326525 (https://phabricator.wikimedia.org/T151973) [19:51:05] (03CR) 10Bartosz Dziewoński: [C: 032] Make more fields sortable and one conditionally [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326258 (owner: 10Matěj Suchánek) [19:51:40] 10Phabricator, 06Developer-Relations (Oct-Dec-2016), 07Performance: Review and consolidate current Herald rules - https://phabricator.wikimedia.org/T141703#2865999 (10Aklapper) [19:52:15] (03PS1) 10Bmansurov: Remove redundant "prefix" from ResourceLoaderImageModule modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (https://phabricator.wikimedia.org/T152732) [19:54:17] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/combined_filters_api.feature:8:9:10 features/boolean_operators_api.feature" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/304111 (https://phabricator.wikimedia.org/T87892) (owner: 10Reedy) [19:55:17] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran phan static analysis and there were some errors: /extensions/CirrusSearch/includes/CirrusSearch.php:705 PhanSignatureMismatch Declar" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/304111 (https://phabricator.wikimedia.org/T87892) (owner: 10Reedy) [19:55:25] Oh sod off [19:55:27] 10Mobile-Content-Service: AMGTV and Lali Esposito are back - https://phabricator.wikimedia.org/T153001#2866011 (10Mholloway) [19:57:10] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2866030 (10ZhouZ) Thanks for flagging @Volker_E and helping fix this issue! @Tbayer is right - we should avoid loading third-party resources and if we do,... [19:57:28] 10MediaWiki-File-management, 06Commons, 06Multimedia, 05MW-1.29-release-notes, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): File histories won't display more than 10 files on a page - https://phabricator.wikimedia.org/T152813#2866031 (10matmarex) 05Open>03Resolved Fixed and deployed. [19:57:59] (03PS3) 10Reedy: Replace Article::fetchContent() [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/326506 (https://phabricator.wikimedia.org/T151973) [19:58:13] (03CR) 10Jforrester: [C: 032] Article::fetchContent() was removed [core] - 10https://gerrit.wikimedia.org/r/326507 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [19:59:37] (03CR) 10Jforrester: [C: 032] Remove WikiPage::getText() call [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/326480 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [19:59:51] (03PS18) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [20:00:10] (03PS19) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [20:01:10] (03CR) 10Sn1per: "Restored original client side functionality from PS9 since we don't need the progress bar without JS anyways and we can add the progress b" [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [20:01:34] 06Reading-Web-Backlog, 06Research-and-Data, 10Wikimedia-Site-requests: QuickSurvey for reader segmentation research - run multiple choice survey in more languages - https://phabricator.wikimedia.org/T151835#2866100 (10atgo) @leila here's a doc with all the Hindi translations: https://docs.google.com/spreadsh... [20:01:55] 10Mobile-Content-Service: AMGTV and Lali Esposito are back - https://phabricator.wikimedia.org/T153001#2866101 (10Mholloway) [20:02:58] (03PS1) 10Reedy: Remove unreferenced background image [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326530 [20:03:03] (03CR) 10Jforrester: [C: 032] Replace Article::fetchContent() [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/326506 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [20:03:46] (03Merged) 10jenkins-bot: Make more fields sortable and one conditionally [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326258 (owner: 10Matěj Suchánek) [20:03:55] (03CR) 10Jforrester: [C: 032] "> This breaks compat with mw < 1.21. Does anyone care?" [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/326480 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [20:06:16] (03CR) 10Cdentinger: "Yeah I slapped WIP back on here cause I broke it, needs this change which I separated because it's out of dash scope: https://gerrit.wikim" [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) (owner: 10Cdentinger) [20:06:28] (03CR) 10Bartosz Dziewoński: [C: 032] AbuseLog should show a warning when log ID does not exist [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326473 (https://phabricator.wikimedia.org/T152973) (owner: 10Huji) [20:07:52] (03PS1) 10Reedy: PHP 5.4 removed Call-time pass-by-reference [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326531 [20:08:03] (03CR) 10Reedy: [C: 032] PHP 5.4 removed Call-time pass-by-reference [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326531 (owner: 10Reedy) [20:08:16] (03CR) 10Reedy: [C: 032] Remove unreferenced background image [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326530 (owner: 10Reedy) [20:08:53] (03CR) 10jenkins-bot: [V: 04-1] PHP 5.4 removed Call-time pass-by-reference [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326531 (owner: 10Reedy) [20:09:26] (03PS1) 10EBernhardson: Record searchToken in referer for mobile as well [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326532 [20:11:03] (03CR) 10Reedy: [C: 04-2] Remove unreferenced background image [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326530 (owner: 10Reedy) [20:11:30] 10MediaWiki-Special-pages, 13Patch-For-Review: Easy date selection for Special:NewFiles - https://phabricator.wikimedia.org/T13836#2866133 (10Sn1per) {F5043626} https://gerrit.wikimedia.org/r/#/c/326459 implements a `RangeChronologicalParser` that makes it relatively easy to add date range filtering to other... [20:11:46] (03PS2) 10Reedy: Remove unreferenced background image [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326530 [20:12:17] (03CR) 10Bartosz Dziewoński: [C: 032] Remove unreferenced background image [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326530 (owner: 10Reedy) [20:12:32] (03CR) 10Bmansurov: "Thanks, Gergo. Pining JHobs who was mainly interested in these features. I'll also try and test." [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [20:13:18] Reedy: Can you take a look at: http://linkbun.ch/04job [20:13:19] (03CR) 10Reedy: [V: 032 C: 032] PHP 5.4 removed Call-time pass-by-reference [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326531 (owner: 10Reedy) [20:13:28] (03CR) 10Fomafix: [C: 031] Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [20:13:39] (03PS1) 10BearND: Cache announcement responses [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) [20:13:40] rlot: I'm currently trying to deal with the other test failures you've found [20:13:50] Reedy: Thanks! [20:14:47] (03Merged) 10jenkins-bot: Article::fetchContent() was removed [core] - 10https://gerrit.wikimedia.org/r/326507 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [20:14:50] (03Merged) 10jenkins-bot: Remove WikiPage::getText() call [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/326480 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [20:14:52] (03Merged) 10jenkins-bot: Replace Article::fetchContent() [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/326506 (https://phabricator.wikimedia.org/T151973) (owner: 10Reedy) [20:15:26] (03Merged) 10jenkins-bot: AbuseLog should show a warning when log ID does not exist [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326473 (https://phabricator.wikimedia.org/T152973) (owner: 10Huji) [20:16:16] 10AbuseFilter, 07Easy: AbuseLog should show a warning when log ID does not exist - https://phabricator.wikimedia.org/T152973#2866164 (10Huji) 05Open>03Resolved [20:16:25] (03PS1) 10Ppchelko: Added simple metrics reporting. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326535 [20:17:07] (03PS2) 10Ppchelko: Added simple metrics reporting. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326535 [20:18:23] (03CR) 10jenkins-bot: [V: 04-1] Cache announcement responses [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:19:04] (03CR) 10Ppchelko: "Getting this data from the trending service is pretty cheap and we don't know yet how fast the results would change (how fast does an arti" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:19:36] 10AbuseFilter, 07Easy, 07I18n, 13Patch-For-Review: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2866168 (10Huji) @matmarex in that case, we need someone to review the code and add comments wherever such concatenations occur (the comment containing full messa... [20:20:45] (03CR) 10jenkins-bot: [V: 04-1] Added simple metrics reporting. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326535 (owner: 10Ppchelko) [20:21:02] (03CR) 10BearND: "Ppchelko this is just for the announcements endpoint. It has no relationship with trending at all." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:21:04] (03CR) 10Niedzielski: [C: 032] Fix crash when posting W0 notification on API <21. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326502 (https://phabricator.wikimedia.org/T152984) (owner: 10Dbrant) [20:21:42] (03PS3) 10Ppchelko: Added simple metrics reporting. [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326535 [20:22:00] (03CR) 10BearND: "It's a static json response. The only time it changes is when we decide to make changes to it through a deploy." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:23:02] (03CR) 10Niedzielski: [C: 032] Fix possible crash when resuming activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326457 (owner: 10Dbrant) [20:23:13] 10Mobile-Content-Service: AMGTV and Lali Esposito are back - https://phabricator.wikimedia.org/T153001#2866174 (10JMinor) Yeah, I really wish we understood what is driving this traffic and why the profile might have shifted. Is this an SEO trick (either effective or not)? Are they embedding these pages in a weir... [20:23:36] (03PS1) 10Mobrovac: Update trending-edits to f3166a5 [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/326536 [20:23:52] (03Merged) 10jenkins-bot: Remove unreferenced background image [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326530 (owner: 10Reedy) [20:24:03] 06Community-Liaisons (Jan-Mar 2017), 06Developer-Relations (Jan-Mar-2017): Technical Collaboration annual plan FY2017-18 - https://phabricator.wikimedia.org/T153007#2866176 (10Qgil) [20:24:04] (03CR) 10Ppchelko: [C: 031] "@bearND Oh I have no idea why did I think it's trending. Probably because I'm working on it right now.. Sure makes sense." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:24:28] (03CR) 10Reedy: "recheck" [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326522 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:24:35] (03CR) 10Reedy: "recheck" [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326521 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:25:23] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326521 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:25:33] (03CR) 10Reedy: [C: 04-1] Replaced "Revision::getText()" depracated in MediaWiki 1.21 (031 comment) [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/326524 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:25:55] (03Merged) 10jenkins-bot: Fix crash when posting W0 notification on API <21. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326502 (https://phabricator.wikimedia.org/T152984) (owner: 10Dbrant) [20:26:05] (03CR) 10Reedy: [C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/326525 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:26:22] (03CR) 10Niedzielski: [C: 032] Fix possible crash when visiting external link. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326438 (owner: 10Dbrant) [20:26:25] (03CR) 10BearND: [C: 04-1] "Ppchelko could use some guidance on how to make this work properly, though. It currently returns a 500. :(" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:26:30] (03PS2) 10Filip: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/326524 (https://phabricator.wikimedia.org/T151973) [20:26:36] Reedy: Fixed it [20:27:06] (03CR) 10Reedy: [C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/326508 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:27:18] (03PS33) 10Mooeypoo: Adding new interface for review filters to RecentChanges [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) [20:27:29] (03CR) 10Ppchelko: [C: 031] "Perhaps the `res.headers === undefined` at that point? Try adding `res.headers = res.headers || {}`" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:27:50] (03CR) 10Reedy: [C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/326509 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:28:11] (03Merged) 10jenkins-bot: Fix possible crash when resuming activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326457 (owner: 10Dbrant) [20:28:14] (03CR) 10BearND: [C: 04-1] "Yes, that's the case. I'll try your suggestion. Thanks!" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:28:42] (03CR) 10Reedy: [C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326522 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:28:54] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/suggest_api.feature:87" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326532 (owner: 10EBernhardson) [20:29:04] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326532 (owner: 10EBernhardson) [20:29:14] (03CR) 10Reedy: [C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/326511 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:30:22] (03CR) 10Ppchelko: [C: 031] "Oh, it's express.. it's `res.set('cache-control', 'blablabla')`" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:31:29] (03PS1) 10Reedy: PHP 5.4 removed Call-time pass-by-reference [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326538 [20:32:41] (03CR) 10jenkins-bot: [V: 04-1] PHP 5.4 removed Call-time pass-by-reference [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326538 (owner: 10Reedy) [20:33:27] andre__: phab search for "english wikipedia collation" (https://phabricator.wikimedia.org/search/query/Lcdmm9jP357z/#R) does not find T136150. should i file a task about this? [20:33:27] T136150: Switch English Wikipedia to uca-default collation - https://phabricator.wikimedia.org/T136150 [20:34:27] MatmaRex: see https://phabricator.wikimedia.org/T151500 [20:34:28] yeah [20:34:46] (03CR) 10Mobrovac: [V: 032 C: 032] Update trending-edits to f3166a5 [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/326536 (owner: 10Mobrovac) [20:35:09] andre__: ok, i'll comment [20:35:10] (03CR) 10Reedy: [V: 032 C: 032] PHP 5.4 removed Call-time pass-by-reference [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326538 (owner: 10Reedy) [20:35:15] (03Merged) 10jenkins-bot: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/326525 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:35:29] (03PS1) 10Niedzielski: Fix: update screenshots for DescriptionEditViewTest & AnnouncementCardViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326539 [20:35:38] (03CR) 10Reedy: [V: 032 C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326504 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:35:57] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2819387 (10matmarex) Search for "english wikipedia collation" (https://phabricator.wikimedia.org/search/query/Lcdmm9jP357z/#R) currently does not find T136150. {F5043709} [20:36:32] (03CR) 10Reedy: [C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/326524 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:38:10] (03CR) 10jenkins-bot: [V: 04-1] Adding new interface for review filters to RecentChanges [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) (owner: 10Mooeypoo) [20:39:01] (03Merged) 10jenkins-bot: Fix possible crash when visiting external link. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326438 (owner: 10Dbrant) [20:39:02] (03Merged) 10jenkins-bot: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/326508 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:39:04] (03Merged) 10jenkins-bot: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/326509 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:39:06] (03Merged) 10jenkins-bot: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/PopupPages] - 10https://gerrit.wikimedia.org/r/326522 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:39:09] (03Merged) 10jenkins-bot: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/326511 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:40:40] (03PS34) 10Mooeypoo: Adding new interface for review filters to RecentChanges [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) [20:40:52] (03CR) 10Reedy: [V: 032 C: 032] Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/326521 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:41:03] (03Merged) 10jenkins-bot: Replaced "Revision::getText()" depracated in MediaWiki 1.21 [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/326524 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:41:29] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Update gallery dialog to work with Parsoid's native implementation - https://phabricator.wikimedia.org/T150621#2866242 (10Esanders) [20:43:09] (03PS1) 10XenoRyet: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/326542 [20:43:26] (03CR) 10XenoRyet: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/326542 (owner: 10XenoRyet) [20:49:21] 10MediaWiki-ContentHandler, 10Wikidata: EditFilterMerged hook still used in Wikidata - https://phabricator.wikimedia.org/T153009#2866247 (10Reedy) [20:49:53] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/326542 (owner: 10XenoRyet) [20:51:27] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326532 (owner: 10EBernhardson) [20:51:37] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326532 (owner: 10EBernhardson) [20:52:07] (03PS2) 10BearND: Cache announcement responses [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) [20:54:03] (03CR) 10Niedzielski: [C: 04-1] "Feedback in I0458a687e097421351aff51b79509b9b15b4d42d" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325424 (https://phabricator.wikimedia.org/T148205) (owner: 10Mholloway) [20:54:17] (03CR) 10Ppchelko: [C: 031] Cache announcement responses [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:54:36] 10MediaWiki-extensions-Widgets: Update smarty to newer version - https://phabricator.wikimedia.org/T142092#2866272 (10Jdforrester-WMF) [20:54:38] 10MediaWiki-extensions-Widgets: Stop using abandoned fork for smarty - https://phabricator.wikimedia.org/T142091#2866270 (10Jdforrester-WMF) 05Open>03Resolved a:03Reedy [20:55:02] (03PS3) 10Jforrester: Track smarty v3.1.29 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/302931 (https://phabricator.wikimedia.org/T142092) (owner: 10Reedy) [20:55:25] (03CR) 10Mholloway: [C: 032] Cache announcement responses [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:56:25] (03PS1) 10Mholloway: Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) [20:57:14] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog (Kanban): [Crash] NPE at org.wikipedia.edit.preview.Wikitext$Query.wikitext() - https://phabricator.wikimedia.org/T152982#2866282 (10Dbrant) a:03Dbrant [20:57:29] (03Merged) 10jenkins-bot: Cache announcement responses [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326534 (https://phabricator.wikimedia.org/T151246) (owner: 10BearND) [20:58:17] 10MediaWiki-Categories, 07Documentation: Document how to decide if adding a new category collation is OK to do quickly and when we need to do other prep - https://phabricator.wikimedia.org/T447#2866287 (10matmarex) 05Open>03Resolved We all know that no one reads documentation, but I added a couple words on... [20:58:22] (03PS1) 10Dbrant: Fix possible NPE when fetching edit preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326546 (https://phabricator.wikimedia.org/T152982) [21:00:01] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 3 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2866303 (10Pppery) [21:02:03] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 07Easy, 13Patch-For-Review: Feed: News stories are partially obscured by system status bar when no thumbnail is found - https://phabricator.wikimedia.org/T141991#2519053 (10Niedzielski) @Mayank.jindal5, thanks for the patch! This approach works well for... [21:02:18] (03CR) 10Niedzielski: [C: 04-1] "Thanks for the patch!! Please see my feedback on the Phabricator ticket :]" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326479 (https://phabricator.wikimedia.org/T141991) (owner: 10Mayank.jindal5) [21:03:50] (03PS1) 10Reedy: Remove old ArticleAfterFetchContent hook subscriber [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326550 (https://phabricator.wikimedia.org/T151973) [21:05:14] 10MediaWiki-Vagrant, 06Analytics-Kanban: Cannot enable 'analytics' role on Labs instance - https://phabricator.wikimedia.org/T151861#2830159 (10Ottomata) I don't know what is up at all with lxc-attach, but if fuse is causing you problems, try commenting it out and re-provisioning: https://github.com/wikimedia... [21:06:24] (03PS1) 10Reedy: Replace ArticleAfterFetchContent hook subscriber [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/326551 (https://phabricator.wikimedia.org/T151973) [21:07:02] Reedy: Can you submit it on GCI? thanks! [21:07:12] (03CR) 10Mholloway: [C: 04-2] "needs updating to work with the $merge nodes" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [21:11:35] (03CR) 10Niedzielski: [C: 04-1] Fix possible NPE when fetching edit preview. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326546 (https://phabricator.wikimedia.org/T152982) (owner: 10Dbrant) [21:13:12] 10AbuseFilter, 07Easy, 07I18n, 13Patch-For-Review: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2866349 (10matmarex) In cases like this one, where the concatenated strings can come from various extensions, that is impossible. I'm sure we can use 1 hour of e... [21:15:19] 10MediaWiki-Gallery, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Media: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2866351 (10Esanders) Appears to be working fine on fr.wiki: {F5043918} Maybe the is a config issue w... [21:16:38] 10Phabricator (Upstream), 07Upstream: Burnup Rate diagrams for several projects? - https://phabricator.wikimedia.org/T152987#2866353 (10Aklapper) Why? (And why is opening several tabs not sufficient?) Use cases welcome. [21:20:12] 10MediaWiki-Email: Special:EmailUser emails sometimes not delivered due to bounce - https://phabricator.wikimedia.org/T134886#2866355 (10Aklapper) @Kaganer: See https://phabricator.wikimedia.org/T66795#2858497 - this task is closed as a duplicate. [21:21:17] 10MediaWiki-Categories: pages are not displayed in categories - https://phabricator.wikimedia.org/T151859#2866356 (10Aklapper) Hi @ChMuheim! This sounds like a JobQueue question - have you brought this up on https://www.mediawiki.org/wiki/Project:Support_desk already? Link welcome. [21:21:37] (03CR) 10Niedzielski: Hygiene: improve ESLint configuration (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/325709 (owner: 10Niedzielski) [21:23:14] 10Wikimedia-Etherpad: Install Mediawiki plugin for Wikimedia Etherpads to allow exporting content to wiki markup - https://phabricator.wikimedia.org/T151674#2866373 (10Aklapper) p:05Triage>03Lowest a:05akosiaris>03None >>! In T151674#2829338, @akosiaris wrote: > we are not using ANY etherpad plugin and c... [21:24:53] (03PS1) 10Mholloway: Update mobileapps to 2a8ad26 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/326620 [21:25:33] (03PS1) 10Yurik: Bumped JsonConfig ext [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326627 [21:26:05] 10Wikimedia-General-or-Unknown: Community Portal tasks Category preference selection, to enhance participation of all Wikipedia users - https://phabricator.wikimedia.org/T151986#2866378 (10Aklapper) Thanks, however I still have problems to understand what exactly is requested in this task. It's very welcome to e... [21:26:23] 10MediaWiki-Gallery, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Media: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2866380 (10Tchanders) @ssastry The version that relies on HTML-based serialization hasn't been deploy... [21:27:10] 10Phabricator: Phabricator workboard layout breaks with too many sidebar links - https://phabricator.wikimedia.org/T152143#2866382 (10Aklapper) 05Open>03stalled @jhobs: ping? [21:27:46] (03CR) 10Mholloway: [C: 032] Update mobileapps to 2a8ad26 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/326620 (owner: 10Mholloway) [21:28:22] 10MediaWiki-Debian: AutoLoader.php can't require when upgrading 1.19->1.27 - https://phabricator.wikimedia.org/T151785#2866387 (10Aklapper) Is this still a problem? [21:28:56] (03PS7) 10Jdlrobson: Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) [21:29:15] (03CR) 10Jdlrobson: "done!" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [21:29:57] (03Merged) 10jenkins-bot: Update mobileapps to 2a8ad26 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/326620 (owner: 10Mholloway) [21:30:05] (03CR) 10Jdlrobson: [C: 032] Fix typo: page_ids -> pageIds [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/326227 (owner: 10EBernhardson) [21:30:16] (03CR) 10jenkins-bot: [V: 04-1] Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) (owner: 10Jdlrobson) [21:30:34] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-ParserFunctions: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2866388 (10VictorPorton) [21:30:38] (03CR) 10Yurik: [C: 032] Bumped JsonConfig ext [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326627 (owner: 10Yurik) [21:30:40] (03CR) 10MaxSem: Log whether the event is the first interaction with the map (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/325599 (https://phabricator.wikimedia.org/T152513) (owner: 10JGirault) [21:31:29] (03CR) 10Jdlrobson: [C: 031] "have not tested yet" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325044 (https://phabricator.wikimedia.org/T152163) (owner: 10Mholloway) [21:31:31] (03Merged) 10jenkins-bot: Fix typo: page_ids -> pageIds [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/326227 (owner: 10EBernhardson) [21:32:51] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2866392 (10Aklapper) >>! In T152159#2844121, @Mvolz wrote: > Can you publish this one @Aklapper ? Thanks! @Mvolz: Ahem. Yes, done now. Sorry, m... [21:34:45] jdloft: page images might finish in the next day or two, most clusters are done but s2 and s3 are still running. [21:35:09] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326588 (owner: 10L10n-bot) [21:35:23] (03PS8) 10Jdlrobson: Add class to IPA container, do not use inline style [services/mobileapps] - 10https://gerrit.wikimedia.org/r/309170 (https://phabricator.wikimedia.org/T141835) [21:35:26] 10MediaWiki-Debian: AutoLoader.php can't require when upgrading 1.19->1.27 - https://phabricator.wikimedia.org/T151785#2866398 (10emoshikon) 05Open>03Resolved That solution worked for me, and sounds like next version won't have this problem - https://gerrit.wikimedia.org/r/#/c/310288/ [21:35:27] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/326588 (owner: 10L10n-bot) [21:35:44] (03PS1) 10Pppery: Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) [21:35:59] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: [BUG] Snackbars should be confined to the originating screen - https://phabricator.wikimedia.org/T145906#2866401 (10Niedzielski) @Karadkar o/ I think I would just call Snackbar.setDuration(LENGTH_SHORT) when the user changes tabs. If the snackbar dismisses d... [21:36:23] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-11-30): Caching on TTS server - https://phabricator.wikimedia.org/T151880#2866402 (10Lokal_Profil) A note from our previous discussions: One solution is that the cache could either be time limited in such a way that resynthesis would happen regularly enough anyway.... [21:36:38] jdlrobson: page images might finish in the next day or two for most wikis, s1 and s4-s7 are done. s2 has 4 wiki's to go, s3 is only about half way through but maybe thats ok... [21:39:01] 10Reading-Community-Engagement, 06Community-Liaisons (Oct-Dec-2016): Inform community on changes/updates on hovercards functionality based on A/B test results - https://phabricator.wikimedia.org/T146755#2866408 (10CKoerner_WMF) [21:39:04] 06Reading-Web-Backlog, 06Community-Liaisons (Oct-Dec-2016), 10Hovercards (2016-17-Q2-Goal): Share results of Hovercard A/B Test on Hungarian Wikipedia - https://phabricator.wikimedia.org/T139370#2866406 (10CKoerner_WMF) 05Open>03Resolved I asked the Hungarian Wikipedia if they would [[ https://hu.wikiped... [21:40:11] (03CR) 10Reedy: [C: 04-1] "One minor issue :)" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [21:41:49] (03PS5) 10Mobrovac: Quote the ETag being set and fix it up in some endpoints [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322084 (https://phabricator.wikimedia.org/T150886) [21:41:56] (03CR) 10jenkins-bot: [V: 04-1] Quote the ETag being set and fix it up in some endpoints [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322084 (https://phabricator.wikimedia.org/T150886) (owner: 10Mobrovac) [21:42:09] 10Comments, 10Social-Tools: Rename Comments database table to be in line with convention - https://phabricator.wikimedia.org/T153012#2866410 (10lcawte) [21:42:18] 10Comments, 10Social-Tools: Rename Comments database table to be in line with convention - https://phabricator.wikimedia.org/T153012#2866424 (10lcawte) p:05Triage>03Lowest [21:43:02] (03Merged) 10jenkins-bot: Bumped JsonConfig ext [core] (wmf/1.29.0-wmf.5) - 10https://gerrit.wikimedia.org/r/326627 (owner: 10Yurik) [21:43:12] (03PS2) 10Pppery: Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) [21:43:17] 10MediaWiki-Gallery, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Media: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2866425 (10Arlolra) https://it.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces... [21:44:18] (03PS6) 10Mobrovac: Quote the ETag being set and fix it up in some endpoints [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322084 (https://phabricator.wikimedia.org/T150886) [21:44:28] ebernhardson: our usernames are unfortunate, aren't they? [21:44:33] (03CR) 10Reedy: [C: 032] Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [21:45:19] jdloft: indeed :P [21:47:26] (03CR) 10Gergő Tisza: "recheck" [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [21:47:28] (03CR) 10Huji: "As for your test WP, I am afraid you are wrong. The message you see in https://test.wikipedia.org/wiki/Special:AbuseLog?wpSearchUser=Matma" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [21:48:56] (03CR) 10Huji: "Basically, this way of thinking will result in unused messages just piling up." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [21:49:51] (03CR) 10Jdlrobson: [C: 031] "This is fine but I dont see how this relates to the bug it links to. Why do you think this is the reason for the icons not being visible?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (https://phabricator.wikimedia.org/T152732) (owner: 10Bmansurov) [21:50:26] (03CR) 10Mobrovac: "Rebased and addressed your concerns and commentes, Bernd && Petr" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/322084 (https://phabricator.wikimedia.org/T150886) (owner: 10Mobrovac) [21:50:35] 10MediaWiki-extensions-Babel, 07I18n: Babel Extension - Issue with ASE language code - https://phabricator.wikimedia.org/T152925#2866429 (10Quiddity) >>! In T152925#2865990, @AnotherPoint wrote: > As I noted earlier, multiple languages seem to have issues with Babel userboxes in Wikimedia. It would help if the... [21:50:51] 10MediaWiki-Gallery, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Media: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2865379 (10Jdforrester-WMF) Yup, Italian (for whatever reason) has "File" and "Discussioni_file" as t... [21:53:08] (03CR) 10jenkins-bot: [V: 04-1] Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [21:53:53] (03PS2) 10Gergő Tisza: [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) [21:54:00] 06Community-Liaisons (Oct-Dec-2016): Planning for Community Engagement Off-site - https://phabricator.wikimedia.org/T149846#2866432 (10CKoerner_WMF) We had a third meeting on 8 December. We fleshed out the schedule for the day, discussing the concerns from the feedback survey and planned to share the rough sched... [21:55:05] (03CR) 10Gergő Tisza: "Somehow this patch is passing and the child patch is failing due to code in this patch..." [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [21:55:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [21:58:16] 10MediaWiki-extensions-SecurePoll, 06Security-Team, 06Stewards-and-global-tools: Accessing private information through SecurePoll should be logged - https://phabricator.wikimedia.org/T152972#2866440 (10Huji) p:05Triage>03High a:03Huji [21:58:29] (03PS3) 10Gergő Tisza: [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) [21:58:55] 10MediaWiki-extensions-CheckUser, 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools, 13Patch-For-Review: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2866443 (10Huji) a:03Huji [21:59:04] (03PS3) 10Fomafix: Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323677 (https://phabricator.wikimedia.org/T117845) [21:59:07] 10AbuseFilter, 06Security-Team, 06Stewards-and-global-tools, 13Patch-For-Review: Log accessing private information by those with `abusefilter-private` permission - https://phabricator.wikimedia.org/T152934#2863957 (10Huji) [21:59:31] (03CR) 10jenkins-bot: [V: 04-1] Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Echo] - 10https://gerrit.wikimedia.org/r/323677 (https://phabricator.wikimedia.org/T117845) (owner: 10Fomafix) [21:59:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [22:01:37] (03CR) 10Gergő Tisza: "Filed as T153013." [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) (owner: 10Gergő Tisza) [22:03:31] (03PS3) 10Gergő Tisza: Update Reading Web roles [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) [22:03:33] (03PS4) 10Gergő Tisza: [WIP] Add mediawiki::import::url [vagrant] - 10https://gerrit.wikimedia.org/r/326394 (https://phabricator.wikimedia.org/T152036) [22:03:56] (03PS1) 10Pppery: Make maintainance scripts use `$this->requireExtension()` [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/326822 (https://phabricator.wikimedia.org/T152139) [22:04:15] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize unconference at the Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T147955#2866467 (10srishakatux) >>! In T147955#2860889, @Rfarrand wrote: > I would say if we are going to have "unconference sessions" that are no... [22:09:10] (03PS4) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [22:09:37] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 3 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2866469 (10Pppery) [22:14:25] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I don't mean the message on Special:AbuseLog, which is indeed a different one, but the message sent to IRC when you hit a filter (and whic" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [22:14:33] (03PS2) 10Mholloway: Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) [22:14:47] (03CR) 10Mholloway: Reinstate manual blacklist [services/mobileapps] - 10https://gerrit.wikimedia.org/r/326544 (https://phabricator.wikimedia.org/T153001) (owner: 10Mholloway) [22:15:44] (03CR) 10jenkins-bot: [V: 04-1] Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [22:16:20] (03CR) 10Bartosz Dziewoński: [C: 04-2] "I did the historical investigation and the message was added in https://gerrit.wikimedia.org/r/#/c/4954/ ." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [22:18:36] (03PS6) 10Divadsn: Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) [22:19:10] jdlrobson, I think I did the right thing :) [22:21:19] (03CR) 10Jdlrobson: [C: 032] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [22:22:04] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, and 4 others: Large gap left in footer on pages with no related articles - https://phabricator.wikimedia.org/T147217#2866482 (10Jdlrobson) [22:22:41] (03PS2) 10JGirault: Log whether the event is the first interaction with the map [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/325599 (https://phabricator.wikimedia.org/T152513) [22:22:44] looks good divadsn :D [22:22:48] thanks for your contribution! [22:23:27] jdlrobson, thanks for your final review :D [22:23:53] Now I can go to sleep, good night everyone :) [22:27:17] (03CR) 10Awight: WIP add dash to crm role (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) (owner: 10Cdentinger) [22:27:59] (03CR) 10Awight: WIP add dash to crm role (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/325515 (https://phabricator.wikimedia.org/T99869) (owner: 10Cdentinger) [22:28:30] (03Merged) 10jenkins-bot: Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [22:34:33] (03PS5) 10Dbrant: Finalize design of description editing view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325819 [22:36:14] (03PS1) 10Chelsyx: Fixed bugs in poultry [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/326830 [22:36:38] (03CR) 10Chelsyx: [V: 032 C: 032] Fixed bugs in poultry [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/326830 (owner: 10Chelsyx) [22:36:40] (03CR) 10Bmansurov: "Since the bug is only happening in production, we don't know whether this patch fixes the issue or not. This is the only thing that I coul" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (https://phabricator.wikimedia.org/T152732) (owner: 10Bmansurov) [22:39:20] jdlrobson, before I forget, could you also please approve my task on GCI? :) [22:39:37] divadsn: yep just verifying it fixes on our test cluster [22:40:01] (03CR) 10Reedy: [C: 032] Make maintainance scripts use `$this->requireExtension()` [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/326822 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:40:07] jdlrobson: Ok, thanks! [22:40:19] (03CR) 10Jdlrobson: [C: 031] "Baha see the task - I identified the culprit! It wasn't this so feel free to merge without the task number." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (https://phabricator.wikimedia.org/T152732) (owner: 10Bmansurov) [22:40:50] (03PS5) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [22:40:59] (03Merged) 10jenkins-bot: Make maintainance scripts use `$this->requireExtension()` [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/326822 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:42:04] (03CR) 10Huji: [C: 04-1] "Still doesn't log access to private info. But the interface is almost complete (correctly shows warnings if input is invalid, user doesn't" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [22:42:07] (03PS3) 10Reedy: Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:42:14] (03CR) 10Reedy: [C: 032] Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:42:30] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, and 4 others: Large gap left in footer on pages with no related articles - https://phabricator.wikimedia.org/T147217#2866531 (10Jdlrobson) 05Open>03Resolved Approved https://codein.withgoogle.com/dashboard/task-instances/6552767919292416/ and s... [22:42:35] (03PS2) 10Bmansurov: Remove redundant "prefix" from ResourceLoaderImageModule modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 [22:43:20] (03CR) 10Bmansurov: [C: 032] "self-merging per above comment" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (owner: 10Bmansurov) [22:43:26] (03PS13) 10Dbrant: Add detailed "help" activity for editing descriptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323354 (https://phabricator.wikimedia.org/T151467) [22:43:31] (03CR) 10Bmansurov: [C: 04-2] Remove redundant "prefix" from ResourceLoaderImageModule modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (owner: 10Bmansurov) [22:43:50] (03PS3) 10Bmansurov: Remove redundant "prefix" from ResourceLoaderImageModule modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 [22:44:09] (03PS4) 10Bmansurov: Remove redundant "prefix" from ResourceLoaderImageModule modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 [22:44:38] (03PS1) 10Pppery: Make maintainance scripts use `$this->requireExtension()` [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) [22:44:47] (03CR) 10Bmansurov: [C: 032] "ok, now self-merging after fixing the url in the commit message" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (owner: 10Bmansurov) [22:45:12] 10Mobile-Content-Service: MCS endpoints should be consistent with other endpoints - https://phabricator.wikimedia.org/T152825#2861325 (10bearND) I cannot comment much on the related endpoint since I just learned about that. In hindsight I think we should have used `pages` in the the most-read endpoint instead of... [22:46:17] (03CR) 10Reedy: [C: 032] Track smarty v3.1.29 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/302931 (https://phabricator.wikimedia.org/T142092) (owner: 10Reedy) [22:46:20] (03PS1) 10Edward Chernenko: Special:ArticleLists: Allow to add custom text under

(this is supported by all other special pages). [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326836 [22:46:49] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 4 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2866544 (10bmansurov) @TameeshB need any help with the task? [22:48:59] (03CR) 10jenkins-bot: [V: 04-1] Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [22:50:08] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2866548 (10greg) [22:51:42] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 4 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2866550 (10TameeshB) @Physikerwelt Yes, i'm able to access the url form my browser. @bmansurov Yes, I had written the patch but i... [22:52:49] 10Comments, 10Social-Tools, 13Patch-For-Review, 07Performance: Potential query optimization on getComments - https://phabricator.wikimedia.org/T135367#2866551 (10labster) Your guide seems pretty good, I'll give it a shot the next time I think of a patch. Actually, BlogPageClass.php is taunting me with: `... [22:53:43] (03PS6) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [22:53:44] (03CR) 10Reedy: [C: 04-1] Make maintainance scripts use `$this->requireExtension()` (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:54:34] (03CR) 10Pppery: "Why do I always leave out whitespace?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:54:40] heh [22:55:56] (03Merged) 10jenkins-bot: Make maintenance scripts use $this->requireExtension() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326723 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:56:03] (03PS2) 10Pppery: Make maintainance scripts use `$this->requireExtension()` [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) [22:57:19] (03PS11) 10Mooeypoo: Gate enhanced RC filters on hidden user preference [core] - 10https://gerrit.wikimedia.org/r/323326 (owner: 10Mattflaschen) [22:57:31] (03CR) 10Reedy: [C: 032] Make maintainance scripts use `$this->requireExtension()` [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [22:57:33] (03PS1) 10Bmansurov: Feature flag FontChanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) [22:58:53] (03PS7) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [23:01:08] (03PS1) 10Bmansurov: Feature flag disabling of CentralNotice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) [23:01:46] 10AbuseFilter, 07Easy, 07I18n: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2866561 (10Huji) 05Open>03declined [23:02:10] 10AbuseFilter, 07Easy, 07I18n: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2863901 (10Huji) @matmarex showed that the log is actually in use (for IRC purposes). [23:03:33] (03PS3) 10Samwilson: Switch special page to be a QueryPage rather than using an IndexPager [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) [23:04:03] (03PS11) 10Mooeypoo: Add userExpLevel filter in the RCFilters UI [core] - 10https://gerrit.wikimedia.org/r/325851 (https://phabricator.wikimedia.org/T149435) [23:04:38] (03PS5) 10Mooeypoo: [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) [23:04:50] (03PS3) 10Mooeypoo: RCFilters UI: Add 'remove' and 'restore defaults' to filter list [core] - 10https://gerrit.wikimedia.org/r/326208 (https://phabricator.wikimedia.org/T144448) [23:06:02] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#2866575 (10Jdforrester-WMF) [23:07:03] 10MediaWiki-Vagrant: Git on vagrant guest sees host repo path - https://phabricator.wikimedia.org/T153016#2866578 (10Tgr) [23:07:39] 04(no projects): iAl@@1-800-790-9186@HP Printer Technical Support Number customer service phone number customer support phone number - https://phabricator.wikimedia.org/T153017#2866590 (10Dulla4444) [23:08:19] (03CR) 10Jdlrobson: Feature flag disabling of CentralNotice (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:08:30] (03Merged) 10jenkins-bot: Remove redundant "prefix" from ResourceLoaderImageModule modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326526 (owner: 10Bmansurov) [23:08:32] (03Merged) 10jenkins-bot: Track smarty v3.1.29 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/302931 (https://phabricator.wikimedia.org/T142092) (owner: 10Reedy) [23:08:34] (03CR) 10Samwilson: "Fixed." (032 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) (owner: 10Samwilson) [23:10:09] (03CR) 10Jdlrobson: [C: 031] "haven't tested but code looks fine" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326839 (https://phabricator.wikimedia.org/T148193) (owner: 10Bmansurov) [23:10:51] (03CR) 10jenkins-bot: [V: 04-1] Make maintainance scripts use `$this->requireExtension()` [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [23:10:58] (03CR) 10Bmansurov: Feature flag disabling of CentralNotice (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:11:02] (03CR) 10jenkins-bot: [V: 04-1] Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) (owner: 10Huji) [23:13:31] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2833814 (10divadsn) @Reedy could you maybe give an update please h... [23:13:41] (03PS3) 10Pppery: Make maintainance scripts use `$this->requireExtension()` [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) [23:13:51] (03CR) 10jenkins-bot: [V: 04-1] Add userExpLevel filter in the RCFilters UI [core] - 10https://gerrit.wikimedia.org/r/325851 (https://phabricator.wikimedia.org/T149435) (owner: 10Mooeypoo) [23:14:04] (03PS1) 10Bmansurov: Feature flag "BackToTop" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326841 (https://phabricator.wikimedia.org/T147944) [23:14:27] (03CR) 10Pppery: "I accidentally put the space inside the quotation marks rather than outside them in populateCheckUserTable.php" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/326834 (https://phabricator.wikimedia.org/T152139) (owner: 10Pppery) [23:15:46] 10AbuseFilter, 06Stewards-and-global-tools: Please add a dropdown with reasons (and mantain the free text field too) for when hidding individual abuselog entries - https://phabricator.wikimedia.org/T153018#2866615 (10MarcoAurelio) [23:15:49] 10MobileFrontend, 06Reading-Web-Backlog, 07Epic, 13Patch-For-Review, 07Technical-Debt (RW-Tech-Debt): Remove SkinMinervaBeta class - https://phabricator.wikimedia.org/T147944#2866627 (10bmansurov) [23:16:38] (03CR) 10Jdlrobson: Feature flag "BackToTop" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326841 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:16:50] (03CR) 10Jdlrobson: Feature flag disabling of CentralNotice (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326840 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:17:26] (03CR) 10jenkins-bot: [V: 04-1] [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) (owner: 10Mooeypoo) [23:17:59] 10MediaWiki-extensions-Widgets: Update smarty to newer version - https://phabricator.wikimedia.org/T142092#2866645 (10Reedy) 05Open>03Resolved a:03Reedy [23:18:18] (03PS4) 10Samwilson: Switch special page to be a QueryPage rather than using an IndexPager [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/326389 (https://phabricator.wikimedia.org/T152756) [23:18:45] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 13Patch-For-Review, and 2 others: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2866647 (10Reedy) >>! In T151973#2866611, @divadsn wrote: > @Reedy... [23:18:59] 10MediaWiki-Vagrant: Git on vagrant guest sees host repo path - https://phabricator.wikimedia.org/T153016#2866648 (10Tgr) One-line fix is ``` sed -i 's/^gitdir: .*\(\.git\/modules\/puppet\/.*\)$/gitdir: ..\/..\/..\/\1/' /vagrant/puppet/modules/*/.git ``` (no idea if that's the best way to fix it but it works) [23:19:58] 10MediaWiki-Vagrant: MediaWiki-Vagrant submodules are set up with absolute paths - https://phabricator.wikimedia.org/T153016#2866650 (10Tgr) [23:20:15] (03CR) 10Bmansurov: Feature flag "BackToTop" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326841 (https://phabricator.wikimedia.org/T147944) (owner: 10Bmansurov) [23:21:09] (03CR) 10Bartosz Dziewoński: "While this might not be the most elegant solution, I think it's acceptable and shouldn't cause maintenance problems. I would appreciate an" [core] - 10https://gerrit.wikimedia.org/r/311463 (https://phabricator.wikimedia.org/T145440) (owner: 10Bartosz Dziewoński) [23:22:08] (03CR) 10jenkins-bot: [V: 04-1] RCFilters UI: Add 'remove' and 'restore defaults' to filter list [core] - 10https://gerrit.wikimedia.org/r/326208 (https://phabricator.wikimedia.org/T144448) (owner: 10Mooeypoo) [23:23:46] (03PS5) 10Gergő Tisza: Make sure all PHP files are available from the host machine [vagrant] - 10https://gerrit.wikimedia.org/r/187874 (https://phabricator.wikimedia.org/T88149) [23:31:52] 04(no projects): iAl@@1-800-790-9186@HP Printer Technical Support Number customer service phone number customer support phone number - https://phabricator.wikimedia.org/T153017#2866699 (10tomasz) 05Open>03Invalid [23:32:02] 06ArchCom, 07Technical-Debt, 10Wikimedia-Developer-Summit (2017): First Tech Debt Bash - https://phabricator.wikimedia.org/T153022#2866700 (10Qgil) [23:32:04] 04(no projects): iAl@@1-800-790-9186@HP Printer Technical Support Number customer service phone number customer support phone number - https://phabricator.wikimedia.org/T153017#2866590 (10tomasz) [23:34:05] 06Research-and-Data, 10Research-outreach, 10WikiCite: Dates/locations/hosts for WikiCite 2017 - https://phabricator.wikimedia.org/T141640#2866718 (10DarTar) [23:35:35] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot: Spike: Impressions abnormally low for Ireland - https://phabricator.wikimedia.org/T152650#2866729 (10AndyRussG) I pulled the data for Dec. 7, and indeed, Ireland is abnormally way down... just above 50%. The... [23:36:15] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Wikimedia Developer Summit 2017 - https://phabricator.wikimedia.org/T141926#2866732 (10Rfarrand) [23:36:17] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Shuttle Transportation: Wikimedia Developer Summit - https://phabricator.wikimedia.org/T141933#2866730 (10Rfarrand) 05Open>03Resolved This is contracted! Closing the task [23:37:10] 10Wikimedia-Site-requests, 13Patch-For-Review: Allow bureaucrats instead of sysops to add/remove users to/from interface editor group on ur.wikipedia - https://phabricator.wikimedia.org/T133564#2866734 (10Dereckson) 05Open>03Resolved [23:37:16] 10Wikimedia-Site-requests, 13Patch-For-Review: Add prioritized languages to compact language links for nowiki - https://phabricator.wikimedia.org/T148021#2866735 (10Dereckson) 05Open>03Resolved [23:37:25] 10Wikimedia-Site-requests, 13Patch-For-Review: Enable the Translate extension on Wikimedia Norge's wiki - https://phabricator.wikimedia.org/T152490#2866736 (10Dereckson) 05Open>03Resolved [23:42:35] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Spike: Spike: Investigate huge spike in StaleCampaignException messages since Dec 8 - https://phabricator.wikimedia.org/T152741#2866741 (10awight) a:03awight [23:45:39] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Particpant info up on Dev Summit event wiki - https://phabricator.wikimedia.org/T153023#2866743 (10Rfarrand) [23:46:54] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Particpant info up on Dev Summit event wiki - https://phabricator.wikimedia.org/T153023#2866756 (10Rfarrand) @srishakatux: If you are able to help create and event table for this, it should be on a seperate page "/particpants" And should have the coll... [23:49:37] (03CR) 10MaxSem: [C: 032] Log whether the event is the first interaction with the map [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/325599 (https://phabricator.wikimedia.org/T152513) (owner: 10JGirault) [23:50:56] (03Merged) 10jenkins-bot: Log whether the event is the first interaction with the map [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/325599 (https://phabricator.wikimedia.org/T152513) (owner: 10JGirault) [23:50:58] (03PS1) 10Dbrant: Fix possible crash when edit preview times out. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326849 [23:51:32] 10Wikimedia-Developer-Summit (2017): WikiDev'17 Keynote by Ward Cunningham: Has our success made it hard to see your own contribution? - https://phabricator.wikimedia.org/T153024#2866767 (10Qgil) [23:51:36] (03PS1) 10Bmansurov: Remove SkinMinervaBeta.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326850 (https://phabricator.wikimedia.org/T147944) [23:51:38] (03PS1) 10Bmansurov: Get rid of the `mode` property of SkinMinerva.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326851 (https://phabricator.wikimedia.org/T147944) [23:52:27] (03CR) 10jenkins-bot: [V: 04-1] Fix possible crash when edit preview times out. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326849 (owner: 10Dbrant) [23:53:15] (03PS2) 10Dbrant: Fix possible crash when edit preview times out. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326849 [23:53:40] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2866785 (10bmansurov) a:05bmansurov>03ovasileva