[00:15:06] (03PS2) 10Mooeypoo: RCFilters UI: Add 'remove' and 'restore defaults' to filter list [core] - 10https://gerrit.wikimedia.org/r/326208 (https://phabricator.wikimedia.org/T144448) [00:17:45] (03CR) 10Chad: [V: 032 C: 032] Fix the Example submodule [skins] - 10https://gerrit.wikimedia.org/r/326276 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [00:18:38] (03PS1) 10Paladox: Revert "Testing submodules" [skins/Example] - 10https://gerrit.wikimedia.org/r/326292 [00:19:44] 10WikiHiero: RTL in WikiHiero - https://phabricator.wikimedia.org/T152875#2862384 (10ahmad) [00:19:57] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage: Convert PageTriage to use extension registration - https://phabricator.wikimedia.org/T87954#2862396 (10Reedy) a:05Reedy>03None [00:20:30] 10MediaWiki-Categories, 07Documentation: Document how to decide if adding a new category collation is OK to do quickly and when we need to do other prep - https://phabricator.wikimedia.org/T447#2862397 (10Reedy) a:05Reedy>03None [00:20:56] (03CR) 10Paladox: "This is to see if the submodule will update." [skins/Example] - 10https://gerrit.wikimedia.org/r/326292 (owner: 10Paladox) [00:20:59] (03CR) 10Paladox: [C: 031] Revert "Testing submodules" [skins/Example] - 10https://gerrit.wikimedia.org/r/326292 (owner: 10Paladox) [00:21:46] (03PS2) 10Reedy: Remove WikiPage::doEdit() call [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/312090 (https://phabricator.wikimedia.org/T145736) [00:22:08] (03CR) 10jenkins-bot: [V: 04-1] Remove WikiPage::doEdit() call [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/312090 (https://phabricator.wikimedia.org/T145736) (owner: 10Reedy) [00:22:46] (03PS3) 10Reedy: Remove WikiPage::doEdit() call [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/312090 (https://phabricator.wikimedia.org/T145736) [00:23:05] (03CR) 10jenkins-bot: [V: 04-1] RCFilters UI: Add 'remove' and 'restore defaults' to filter list [core] - 10https://gerrit.wikimedia.org/r/326208 (https://phabricator.wikimedia.org/T144448) (owner: 10Mooeypoo) [00:23:13] (03CR) 10jenkins-bot: [V: 04-1] Remove WikiPage::doEdit() call [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/312090 (https://phabricator.wikimedia.org/T145736) (owner: 10Reedy) [00:23:18] (03CR) 10Chad: [C: 032] Revert "Testing submodules" [skins/Example] - 10https://gerrit.wikimedia.org/r/326292 (owner: 10Paladox) [00:24:20] 10Social-Tools: [TRACKING] Discuss how to develop a bigger open-source community for the social tools umbrella of extensions - https://phabricator.wikimedia.org/T152876#2862400 (10SamanthaNguyen) [00:25:21] (03Merged) 10jenkins-bot: Revert "Testing submodules" [skins/Example] - 10https://gerrit.wikimedia.org/r/326292 (owner: 10Paladox) [00:27:06] (03PS4) 10Mooeypoo: [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) [00:27:31] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons - https://phabricator.wikimedia.org/T152839#2861692 (10Ghouston) {F5030405} - console output from Firefox when viewing a file when the problem occurred: https://commons.wikimedia.org/wiki/File:Pillang%C3%B3s_-_panoramio.jpg One thing that sta... [00:30:18] 10MediaWiki-extensions-SubPageList: SubPageList testextension fails - https://phabricator.wikimedia.org/T147393#2862418 (10Reedy) a:05Reedy>03JeroenDeDauw Even if you move that... it's still pretty broken, as it seems to be basing it on a PSR-4 autoloader? Which, I guess CI doesn't know how to load it... ``... [00:30:21] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons - https://phabricator.wikimedia.org/T152839#2862420 (10Ghouston) Disabling the CropTool gadget in preferences seems to help. [00:30:52] 10Wikimedia-Extension-setup: Enable Extension:GoogleNewsSitemap on elwikinews - https://phabricator.wikimedia.org/T39608#2862421 (10Reedy) [00:32:46] (03Draft1) 10Paladox: Mass migrate skins to fix submodules [skins] - 10https://gerrit.wikimedia.org/r/326294 [00:32:55] (03Draft2) 10Paladox: Mass migrate skins to fix submodules [skins] - 10https://gerrit.wikimedia.org/r/326294 [00:33:09] (03PS3) 10Paladox: Mass migrate skins to fix submodules [skins] - 10https://gerrit.wikimedia.org/r/326294 (https://phabricator.wikimedia.org/T152663) [00:33:57] (03CR) 10Chad: [V: 032 C: 032] Mass migrate skins to fix submodules [skins] - 10https://gerrit.wikimedia.org/r/326294 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [00:34:17] (03CR) 10jenkins-bot: [V: 04-1] [wip] RCFilters UI: Read preferences as base state [core] - 10https://gerrit.wikimedia.org/r/326064 (https://phabricator.wikimedia.org/T149391) (owner: 10Mooeypoo) [00:36:05] (03Draft1) 10Paladox: Mass migrate extensions to fix submodules [extensions] - 10https://gerrit.wikimedia.org/r/326295 (https://phabricator.wikimedia.org/T152663) [00:36:07] (03Draft2) 10Paladox: Mass migrate extensions to fix submodules [extensions] - 10https://gerrit.wikimedia.org/r/326295 (https://phabricator.wikimedia.org/T152663) [00:36:32] (03PS3) 10Paladox: Mass migrate extensions to fix submodules [extensions] - 10https://gerrit.wikimedia.org/r/326295 (https://phabricator.wikimedia.org/T152663) [00:37:10] (03CR) 10Reedy: [V: 032 C: 032] Remove WikiPage::doEdit() call [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/312090 (https://phabricator.wikimedia.org/T145736) (owner: 10Reedy) [00:37:42] (03CR) 10Reedy: [V: 032 C: 032] Replace WikiPage::doEdit() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/312092 (https://phabricator.wikimedia.org/T145736) (owner: 10Reedy) [00:39:28] 10WikiHiero, 07I18n, 07RTL: RTL in WikiHiero - https://phabricator.wikimedia.org/T152875#2862428 (10Reedy) [00:42:09] 10BlogPage, 06Brickimedia, 10Social-Tools: Remove redundant "User" prefix from "User blog" namespace in BlogPage - https://phabricator.wikimedia.org/T151517#2862429 (10ashley) 05Open>03Resolved a:03ashley NS_BLOG is back to `Blog` again in `/var/www/core/LocalSettings_ext.php`. I've also tweaked Bricki... [00:46:18] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2862434 (10Reedy) SemanticForms can be disabled in CI/limited to 3.7 now -- https://gerrit.wikimedia.org/r/#/c/326218/ is merged `... [01:02:37] 10MediaWiki-extensions-Linter, 10Wikimedia-Extension-setup: Review and deploy Linter extension to Wikimedia wikis - https://phabricator.wikimedia.org/T148609#2862448 (10Legoktm) [01:02:40] 10MediaWiki-extensions-Linter, 10Beta-Cluster-Infrastructure, 13Patch-For-Review: Deploy Linter extension to Beta cluster - https://phabricator.wikimedia.org/T152620#2862446 (10Legoktm) 05Open>03Resolved a:03Legoktm [01:03:49] 10MediaWiki-extensions-ThrottleOverride, 10Security-Reviews, 10Wikimedia-Extension-setup, 10Wikimedia-Developer-Summit (2017): Review and deploy ThrottleOverride extension to Wikimedia wikis - https://phabricator.wikimedia.org/T27000#289033 (10Reedy) [01:04:48] 10Wikimedia-Site-requests, 13Patch-For-Review: Private wiki for Project Grants Committee - https://phabricator.wikimedia.org/T143138#2862453 (10Krenair) @Mjohnson_WMF, how's that going? A couple of important people went to the (quite large) trouble of creating this wiki, so if you don't have time to finish set... [01:04:58] (03CR) 10Chad: [V: 032 C: 032] Mass migrate extensions to fix submodules [extensions] - 10https://gerrit.wikimedia.org/r/326295 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [01:06:27] (03Draft1) 10Paladox: Insert the description of the change. [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326296 [01:07:00] (03PS2) 10Paladox: Insert the description of the change. [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326296 [01:07:05] (03CR) 10Paladox: [C: 032] Insert the description of the change. [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326296 (owner: 10Paladox) [01:07:31] (03CR) 10Paladox: [C: 032] "Testing submodules update :)" [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326296 (owner: 10Paladox) [01:08:29] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Livvi-Karelian Wikipedia at olo.wikipedia.org - https://phabricator.wikimedia.org/T146612#2862456 (10Krenair) Thanks to Chase on T151570 meta_p is now handled. Input from anyone who knows about collation would be appreciated in T147064. [01:08:31] 10MediaWiki-extensions-ThrottleOverride, 10Wikimedia-Developer-Summit (2017): Hackathon Project: Get ThrottleOverride ready for WMF deployment - https://phabricator.wikimedia.org/T152877#2862459 (10Reedy) [01:08:47] (03Merged) 10jenkins-bot: Insert the description of the change. [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326296 (owner: 10Paladox) [01:10:47] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2862476 (10Krenair) Thanks Chase. That leaves RB (which I will be having words with certain people about) and collation (which @Dereckson might know about?) [01:20:36] 10Wikimedia-Site-requests, 13Patch-For-Review: Internal Wiki for Wikimedians of Ecuador - https://phabricator.wikimedia.org/T135521#2862487 (10Krenair) We need to figure out who the initial bureaucrat will be still. Given that this information has been waiting for over a month it may have been a mistake to acc... [01:20:39] 10MiniInvite, 10Social-Tools: MiniInvite ext: Make title message of Special:EmailNewArticle consistent with other messages - https://phabricator.wikimedia.org/T152878#2862488 (10SamanthaNguyen) [01:22:00] 10MiniInvite: Lowercase content of i18n messages for consistency with other messages - https://phabricator.wikimedia.org/T152879#2862500 (10SamanthaNguyen) [01:22:37] 10MiniInvite, 10Social-Tools: Lowercase content of i18n messages for consistency with other messages - https://phabricator.wikimedia.org/T152879#2862513 (10SamanthaNguyen) [01:23:31] 10MiniInvite, 10Social-Tools: Remove inline styling from MiniInvite - https://phabricator.wikimedia.org/T147259#2862516 (10SamanthaNguyen) [01:28:55] (03PS1) 10Paladox: Revert "Insert the description of the change." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326297 [01:29:02] (03CR) 10Paladox: [C: 032] Revert "Insert the description of the change." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326297 (owner: 10Paladox) [01:29:50] 10Wikimedia-Site-requests, 13Patch-For-Review: OTRS-Wiki link to mobile website - https://phabricator.wikimedia.org/T152870#2862291 (10Krenair) I went through the rest of the wikis lacking mobile DNS entries: ```auditcom.m.wikimedia.org boardgovcom.m.wikimedia.org board.m.wikimedia.org chair.m.wikimedia.org af... [01:30:47] (03Merged) 10jenkins-bot: Revert "Insert the description of the change." [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/326297 (owner: 10Paladox) [01:31:26] 10MiniInvite: Remove deprecated entry point for MiniInvite - https://phabricator.wikimedia.org/T152881#2862533 (10SamanthaNguyen) [01:36:59] 10BlogPage, 06Brickimedia, 10Social-Tools: Remove redundant "User" prefix from "User blog" namespace in BlogPage - https://phabricator.wikimedia.org/T151517#2819990 (10georgebarnick) The reason we had this the way it was was to keep consistency with Wikia. Not sure if we're worried on doing that anymore alth... [01:43:57] 10Challenge, 10Social-Tools: Add check mark icon for Challenge's special page, ChallengeHistory - https://phabricator.wikimedia.org/T152883#2862574 (10SamanthaNguyen) [01:58:28] (03CR) 10Catrope: [C: 032] Defer secondary page metadata backfill DB writes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/326279 (https://phabricator.wikimedia.org/T152847) (owner: 10Aaron Schulz) [01:58:42] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 13Patch-For-Review: Frequent DB writes on HTTP GET from PageTriage - https://phabricator.wikimedia.org/T152847#2862609 (10Catrope) 05Open>03Resolved a:03Catrope [01:59:27] 10Challenge, 10Social-Tools: Challenge ext - Special:ChallengeUser should use autocompletion to make it easier - https://phabricator.wikimedia.org/T152885#2862611 (10SamanthaNguyen) [01:59:42] (03Merged) 10jenkins-bot: Defer secondary page metadata backfill DB writes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/326279 (https://phabricator.wikimedia.org/T152847) (owner: 10Aaron Schulz) [02:06:02] 10Challenge, 10Social-Tools: Challenging a user through Special:ChallengeUser redirects to Special:Search - https://phabricator.wikimedia.org/T152886#2862627 (10SamanthaNguyen) [02:18:12] (03PS1) 10Jack Phoenix: Fix RandomGameUnit integration [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326299 [02:20:21] (03CR) 10Jack Phoenix: [C: 032] Fix RandomGameUnit integration [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326299 (owner: 10Jack Phoenix) [02:21:25] (03Merged) 10jenkins-bot: Fix RandomGameUnit integration [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326299 (owner: 10Jack Phoenix) [02:24:48] (03PS1) 10Jack Phoenix: Special:ChallengeUser should use autocompletion [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326300 (https://phabricator.wikimedia.org/T152885) [02:26:05] (03CR) 10Jack Phoenix: [C: 032] Special:ChallengeUser should use autocompletion [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326300 (https://phabricator.wikimedia.org/T152885) (owner: 10Jack Phoenix) [02:26:56] (03Merged) 10jenkins-bot: Special:ChallengeUser should use autocompletion [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326300 (https://phabricator.wikimedia.org/T152885) (owner: 10Jack Phoenix) [02:27:56] 10Challenge, 10Social-Tools: Challenge ext - Special:ChallengeUser should use autocompletion to make it easier - https://phabricator.wikimedia.org/T152885#2862657 (10ashley) 05Open>03Resolved a:03ashley [02:28:06] 10Challenge: Add Echo support for Challenge - https://phabricator.wikimedia.org/T152887#2862660 (10SamanthaNguyen) [02:28:21] 10Challenge: Add Echo support for Challenge - https://phabricator.wikimedia.org/T152887#2862673 (10SamanthaNguyen) [02:29:46] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2862674 (10lcf119) These database errors aren't limited to editing pages only. I've been experiencing a myriad of errors related to this. Like Nova said, the search bar w... [02:29:58] (03Draft1) 10Paladox: Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_28) - 10https://gerrit.wikimedia.org/r/326301 [02:30:01] (03Draft2) 10Paladox: Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_28) - 10https://gerrit.wikimedia.org/r/326301 [02:30:56] (03Draft1) 10Paladox: Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326302 [02:31:00] (03Draft2) 10Paladox: Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326302 [02:31:07] 10Challenge, 10Social-Tools: Add Echo support for Challenge - https://phabricator.wikimedia.org/T152887#2862675 (10SamanthaNguyen) [02:31:44] (03PS3) 10Paladox: Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_28) - 10https://gerrit.wikimedia.org/r/326301 [02:32:15] (03PS3) 10Paladox: Mass migrate extensions to fix submodules (1.27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326302 [02:33:21] (03Draft1) 10Paladox: Mass migrate extensions to fix submodules (1.23) [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326303 [02:33:25] (03Draft2) 10Paladox: Mass migrate extensions to fix submodules (1.23) [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326303 [02:33:50] 10Challenge, 10Social-Tools: Add Echo support for Challenge - https://phabricator.wikimedia.org/T152887#2862677 (10SamanthaNguyen) [02:34:18] (03PS4) 10Paladox: Mass migrate extensions to fix submodules (1.28) [extensions] (REL1_28) - 10https://gerrit.wikimedia.org/r/326301 (https://phabricator.wikimedia.org/T152663) [02:34:36] (03PS4) 10Paladox: Mass migrate extensions to fix submodules (1.27) [extensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/326302 (https://phabricator.wikimedia.org/T152663) [02:35:10] (03PS3) 10Paladox: Mass migrate extensions to fix submodules (1.23) [extensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/326303 (https://phabricator.wikimedia.org/T152663) [02:45:17] 10Challenge, 10Social-Tools, 07Epic: Convert forms in Challenge to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152888#2862681 (10SamanthaNguyen) [02:45:50] 10Challenge, 10Social-Tools, 07Epic: Convert Challenge Special:ChallengeUser to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152889#2862694 (10SamanthaNguyen) [02:51:01] (03PS1) 10Jack Phoenix: Sucks to be using an unsupported version of MediaWiki [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326304 (https://phabricator.wikimedia.org/T152881) [02:51:30] (03CR) 10Jack Phoenix: [V: 032 C: 032] Sucks to be using an unsupported version of MediaWiki [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326304 (https://phabricator.wikimedia.org/T152881) (owner: 10Jack Phoenix) [02:52:22] 10MiniInvite: Remove deprecated entry point for MiniInvite - https://phabricator.wikimedia.org/T152881#2862713 (10ashley) 05Open>03Resolved a:03ashley [02:55:00] (03PS1) 10Jack Phoenix: i18n improvements [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326305 (https://phabricator.wikimedia.org/T152878) [02:55:26] (03CR) 10Jack Phoenix: [V: 032 C: 032] i18n improvements [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326305 (https://phabricator.wikimedia.org/T152878) (owner: 10Jack Phoenix) [02:55:58] 10MiniInvite, 10Social-Tools: MiniInvite ext: Make title message of Special:EmailNewArticle consistent with other messages - https://phabricator.wikimedia.org/T152878#2862721 (10ashley) 05Open>03Resolved a:03ashley [02:56:21] 10Challenge, 10Social-Tools: Accessing Special:ChallengeAction directly results in a blank page - https://phabricator.wikimedia.org/T152890#2862724 (10SamanthaNguyen) [03:00:50] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2862737 (10SamanthaNguyen) I'm tempted to raise the priority of this ticket since that's concerning, I've also been receiving errors too. Not sure necessarily about "Unbr... [03:03:23] (03PS1) 10Jack Phoenix: Show a message if someone accesses Special:ChallengeAction directly [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326307 (https://phabricator.wikimedia.org/T152890) [03:04:24] (03CR) 10Jack Phoenix: [C: 032] Show a message if someone accesses Special:ChallengeAction directly [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326307 (https://phabricator.wikimedia.org/T152890) (owner: 10Jack Phoenix) [03:05:28] (03Merged) 10jenkins-bot: Show a message if someone accesses Special:ChallengeAction directly [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326307 (https://phabricator.wikimedia.org/T152890) (owner: 10Jack Phoenix) [03:06:35] 10Challenge, 10Social-Tools: Accessing Special:ChallengeAction directly results in a blank page - https://phabricator.wikimedia.org/T152890#2862746 (10ashley) 05Open>03Resolved a:03ashley [03:06:57] 10Challenge, 10Social-Tools, 07Epic: Convert Challenge special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152888#2862681 (10SamanthaNguyen) [03:07:09] (03PS1) 10Jack Phoenix: Fix dumb URL construction [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326309 (https://phabricator.wikimedia.org/T152886) [03:17:34] (03PS2) 10Jack Phoenix: Fix dumb URL construction [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326309 (https://phabricator.wikimedia.org/T152886) [03:18:40] (03CR) 10Jack Phoenix: [C: 032] Fix dumb URL construction [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326309 (https://phabricator.wikimedia.org/T152886) (owner: 10Jack Phoenix) [03:19:35] (03Merged) 10jenkins-bot: Fix dumb URL construction [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/326309 (https://phabricator.wikimedia.org/T152886) (owner: 10Jack Phoenix) [03:20:30] 10Challenge, 10Social-Tools: Challenging a user through Special:ChallengeUser redirects to Special:Search - https://phabricator.wikimedia.org/T152886#2862755 (10ashley) 05Open>03Resolved a:03ashley [04:06:08] (03PS6) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [04:14:55] (03CR) 10jenkins-bot: [V: 04-1] Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [04:17:38] 10Wikimedia-Blog: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2862787 (10Tbayer) [04:23:26] (03PS7) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [04:32:28] (03PS1) 10Jack Phoenix: Kill inline CSS [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/326310 (https://phabricator.wikimedia.org/T147259) [04:37:10] (03CR) 10Legoktm: [C: 04-1] "Looks good. I think a progress indicator is a good idea too, maybe a OO.ui.ProgressBarWidget underneath the button? There's also a pending" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [04:37:46] hi OH- :) [04:41:08] hi legoktm [04:49:29] legoktm, if I put an indeterminate progress bar under the button, should the button itself also be OOUI styled so it fits betteR? [04:49:42] nah, let's just leave that part the same [04:50:36] legoktm: what does the format version = 2 in that patch do? [04:51:02] https://www.mediawiki.org/wiki/API:JSON_version_2 [04:59:30] 10Wikimedia-Site-requests, 13Patch-For-Review: Private wiki for Project Grants Committee - https://phabricator.wikimedia.org/T143138#2862808 (10Mjohnson_WMF) Hi there, I still haven't been able to log in. I tried to follow the instructions, but still haven't been able to get it to work. I am under tremendou... [05:15:29] 10AbuseFilter, 07I18n: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2862809 (10Huji) Additionally, `Logentry-abusefilter-hit` does not use GENDER at all and should be fixed too. [05:22:30] (03PS8) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [05:31:44] 10MediaWiki-Special-pages: Special:Search Issue - https://phabricator.wikimedia.org/T152895#2862825 (10JustBerry) [05:42:45] 10MediaWiki-Search, 06Discovery, 06Discovery-Search: Special:Search Issue - https://phabricator.wikimedia.org/T152895#2862839 (10Krenair) more likely an issue with the backend than the special page itself [06:03:32] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Frequent DB writes on HTTP GET from PageTriage - https://phabricator.wikimedia.org/T152847#2862851 (10Catrope) a:05Catrope>03aaron [06:05:14] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Frequent DB writes on HTTP GET from PageTriage - https://phabricator.wikimedia.org/T152847#2862853 (10aaron) According to a comment, this should be rare. I wonder if there is anothe... [06:13:58] @husun [06:14:15] @seen husun [06:14:15] dargasea: Last time I saw Husun they were quitting the network with reason: Ping timeout: 260 seconds N/A at 12/7/2016 2:31:51 PM (3d15h42m24s ago) [07:03:33] l [07:16:29] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: [BUG] Snackbars should be confined to the originating screen - https://phabricator.wikimedia.org/T145906#2862860 (10Karadkar) @Niedzielski I am thinking about following approach In `ReadingListsFragment` Save `Snackbar` instance from method `showDeletePa... [07:18:04] (03PS1) 10Ladsgroup: Align colors with Wikimedia color palette [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/326314 [07:22:43] (03PS1) 10Ladsgroup: Align colors with Wikimedia color palette. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/326315 [07:58:06] 10UI-Standardization, 10MassMessage, 15User-Ladsgroup: Convert Special:EditMassMessageList and Special:CreateMassMessageList to use OOUI - https://phabricator.wikimedia.org/T152896#2862861 (10Ladsgroup) [08:00:33] (03PS1) 10Ladsgroup: Modernize MassMassage design [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 [08:00:59] (03PS2) 10Ladsgroup: Modernize MassMassage design [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) [08:04:44] (03PS3) 10Ladsgroup: Modernize MassMassage design (a little) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/326317 (https://phabricator.wikimedia.org/T152896) [08:14:30] (03CR) 10Polybuildr: "Can you also document in the commit message the ->text() vs ->escaped() changes you've made?" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [08:15:50] (03CR) 10Polybuildr: "More importantly, someone else already submitted a change to do this: https://gerrit.wikimedia.org/r/#/c/326243/" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [08:17:36] (03CR) 10Polybuildr: [C: 032] Escape raw HTML messages in SmiteSpam SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326243 (https://phabricator.wikimedia.org/T152831) (owner: 10MtDu) [08:18:59] (03Merged) 10jenkins-bot: Escape raw HTML messages in SmiteSpam SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326243 (https://phabricator.wikimedia.org/T152831) (owner: 10MtDu) [09:03:34] Has anyone seen legoktm ? [09:06:28] @seen Polybuildr [09:06:28] rlot: Last time I saw polybuildr they were changing the nickname to , but is no longer in channel #wikimedia-labs at 8/29/2016 3:42:50 PM (103d17h23m37s ago) [09:10:19] (03CR) 10Filip: "Polybuildr: This task was claimed to me on GCI site" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [09:10:50] If someone merged task patch, without claiming it on GCI site [09:11:03] And i claimed it, but its merged now [09:12:37] andre__: [09:13:38] @seen polybuildr [09:13:38] rlot: Last time I saw polybuildr they were changing the nickname to , but is no longer in channel #wikimedia-labs at 8/29/2016 3:42:50 PM (103d17h30m48s ago) [09:14:29] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2862881 (10polybuildr) @Legoktm, @Aklapper: Could you please resolve the conflict between this task and T152852? @FilipGCI says that the GCI task was claimed by them (https://ge... [09:15:15] (03CR) 10Polybuildr: "Sorry about that, I didn't know. I've asked others to resolve this at https://phabricator.wikimedia.org/T152831." [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [09:16:34] (03CR) 10Filip: "Btw, there should'nt be "->escaped" becouse you'll see text like "Hello%20World"" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [09:19:55] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2862885 (10FilipGCI) I don't know, maybe i should abandon it. Btw, i think there should'nt be "->escaped" becouse code will look like that "Hello%20World", and it should'nt be i... [09:23:36] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2862886 (10polybuildr) @FilipGCI, I don't think that's what happens. The `%20` kind of escaping is for use in URLs (such as php's `urlencode`), but this is escaping for HTML (`<... [09:23:49] tonythomas, Uhh, I believe when you added $this->decode you partially fixed my task:\(Although error still shows when you remove all publishers) [09:28:54] (03PS5) 10Filip: Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) [09:29:00] (03CR) 10jenkins-bot: [V: 04-1] Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [09:33:57] Is there any GCI mentor> [09:33:57] ? [09:36:35] 04(no projects): Problems to save changes in eu:wp - https://phabricator.wikimedia.org/T152897#2862887 (10Theklan) [09:51:04] rlot: it looks like in the text of that task, legoktm says it was reserved for MtDu? I'm not sure if this is kosher or not [09:51:32] rlot: if it's okay with you, I'll unassign you for the time being, so you can move on to another task? [09:51:52] mvolz: Ok [09:52:02] and then maybe this is something that we should address with project admins [09:52:26] rlot: ok, you're unassigned [09:52:32] 10MediaWiki-extensions-SubPageList: SubPageList testextension fails - https://phabricator.wikimedia.org/T147393#2862898 (10JeroenDeDauw) This extension is maintained at https://github.com/JeroenDeDauw/SubPageList. Issues should be filed at https://github.com/JeroenDeDauw/SubPageList/issues [09:52:33] Thanks! [09:52:43] sorry about the extra work [09:53:01] 10MediaWiki-extensions-SubPageList: SubPageList testextension fails - https://phabricator.wikimedia.org/T147393#2862899 (10JeroenDeDauw) a:05JeroenDeDauw>03None [09:53:55] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2862901 (10FilipGCI) Ok, i abadoned it. [09:56:12] mvolz: It's a bit not OK, to claim task without GCI site [09:56:26] mvolz: I lost time with doing this task [09:56:56] rlot: I agree, this was not done well. I'll bring it up with the project admins :(. [09:56:58] rlot, it is OK, since devlopment happens over at Phabricator, regardless of GCI. [09:57:02] mvolz: But contacting admins would take a lot more time [09:57:14] Yes, but it was assigned as gci task [09:57:57] I don't want to sound mean, but if it's an open task, any volunteer should be able to claim it, regardless if they participate in GCI. [09:58:04] I think we probably shouldn't argue about this here :) [09:58:08] and dargasea, that's correct [09:58:55] but in this case the task was created specfically for another gci contestant and this *may* be against contest rules, so I will ask higher up the chain ^-^ [09:59:29] but in general someone can always swoop down and fix something before you, that's true, and the nature of open source :D [09:59:38] Btw, is there any chance to get this task done? [10:00:21] If Google would hold this contest all year long ;) [10:00:35] Just think about how many backlogs that will be cleaned.. [10:10:03] 10AbuseFilter, 07I18n: Allow translation of action names for AbuseFilter logs - https://phabricator.wikimedia.org/T152869#2862903 (10matej_suchanek) [10:10:06] 10AbuseFilter, 07I18n: Incomplete i18n for log entries - https://phabricator.wikimedia.org/T40753#2862906 (10matej_suchanek) [10:11:00] 10AbuseFilter, 07I18n: Incomplete i18n for log entries - https://phabricator.wikimedia.org/T40753#465536 (10matej_suchanek) [10:15:19] 04(no projects): Problems to save changes in eu:wp - https://phabricator.wikimedia.org/T152897#2862887 (10Framawiki) Hello, have you a link to discussions about this on the wiki ? Can you give example of concerned pages ? [10:23:34] How to commit to another gerrit patch? [10:23:40] when i do another edit [10:26:46] rlot, do you have separte branches for each task? [10:27:11] or do you mean you are uploading an improved patch for a Gerrit entry? [10:27:57] (03PS1) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326321 (https://phabricator.wikimedia.org/T151973) [10:32:28] Hey, anybody there who can help me with Status::newFatal()? Why does it have to be returned, even though it works without doing that? [10:34:57] 10MediaWiki-Email, 10Mail, 06Operations, 10Wikimedia-General-or-Unknown, and 3 others: Email server's DMARC config prevents users from sending emails via Special:EmailUser - https://phabricator.wikimedia.org/T66795#2862931 (10AnnaMariaKoshka) @Legoktm - I have sent 3 emails with copy to me. Two of these em... [10:37:54] (03PS1) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326322 (https://phabricator.wikimedia.org/T151973) [10:38:51] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326322 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:42:49] 10MediaWiki-Email, 10Mail, 06Operations, 10Wikimedia-General-or-Unknown, and 3 others: Email server's DMARC config prevents users from sending emails via Special:EmailUser - https://phabricator.wikimedia.org/T66795#2862943 (10AnnaMariaKoshka) Sorry - it was only a time delay! [10:43:25] (03PS1) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Video] - 10https://gerrit.wikimedia.org/r/326323 (https://phabricator.wikimedia.org/T151973) [10:44:24] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Video] - 10https://gerrit.wikimedia.org/r/326323 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:45:39] (03CR) 10Filip: "I think its jenkins fault" [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326322 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:46:07] Hi! Can anyone check is this jenkins error? I cant find any eroors there [10:46:22] https://gerrit.wikimedia.org/r/326322 [10:47:29] (03PS2) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Video] - 10https://gerrit.wikimedia.org/r/326323 (https://phabricator.wikimedia.org/T151973) [10:48:00] rlot, check this PHP Fatal error: Call-time pass-by-reference has been removed in includes/apis/WOM_OutputProcessor.php on line 107 [10:48:13] Maybe I am wrong, but just in case [10:48:19] WOM_OutputProcessor was not edited [10:49:24] Its totally unreleted [10:52:37] 10Wikimedia-Planet, 07Technical-Debt: Add UTF-8 support to Venus - https://phabricator.wikimedia.org/T133663#2862946 (10Dereckson) p:05High>03Normal Decreasing [10:54:00] rlot: hi and thank you for the patch to the Video extension! functionality-wise it looks good to me and I'd be happy to merge it, but can I ask you to make one tiny coding style change, as per MediaWiki's coding conventions? :-) right now you have ContentHandler::makeContent($categoryWikiText, $page->getTitle()) but it needs just a bit more spacing so that it'll look like this: ContentHandler::mak [10:54:02] eContent( $categoryWikiText, $page->getTitle() ) (and yes, I'm aware that this is horrible nitpicking!) [10:54:13] (03CR) 10Fomafix: [C: 04-1] Mark pages on watchlist as visited using JS without reload (033 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [10:54:45] ashley: Sure! I'll make commit in secound [10:55:02] SMWQueryProcessor::processFunctionParams( $rawparams, &$querystring, &$params, &$printouts ); [10:55:14] rlot, ^ this is deprecated in 5.4, tests run in 5.5 apparently [10:55:16] (03CR) 10Fomafix: [C: 04-1] Mark pages on watchlist as visited using JS without reload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [10:55:18] so I wouldn't say you are to blame [10:55:24] (03PS1) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152168) [10:56:04] ^^ Yeah, its unrelated [10:56:27] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2862952 (10Dereckson) Ideal collation candidate is `uca-fi`, already used by other Finnish projects. [10:57:35] ashley: I did a commit, take a look [10:58:56] (03PS2) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152168) [10:59:08] (03PS3) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Video] - 10https://gerrit.wikimedia.org/r/326323 (https://phabricator.wikimedia.org/T151973) [10:59:30] 10video2commons: Disk space went not cool again on the video encoding instances - https://phabricator.wikimedia.org/T152899#2862953 (10zhuyifei1999) [10:59:47] (03CR) 10Jack Phoenix: [C: 032] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Video] - 10https://gerrit.wikimedia.org/r/326323 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [10:59:58] rlot: splendid, thank you! :) [11:01:04] (03Merged) 10jenkins-bot: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Video] - 10https://gerrit.wikimedia.org/r/326323 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:05:19] Can someone take a look at: https://gerrit.wikimedia.org/r/#/c/326326/1/classes/RDFIO_SMWPageWriter.php [11:05:36] Do i need to indent it all? [11:07:51] dargasea: Do i need to use new function?? [11:08:48] rlot: I'm not familiar with that particular extension, but your change looks good to me; more than your change, the real issue was the presence of that unwanted end-of-line whitespace in the first place; I'm not sure if the coding conventions pages on MW.org say anything about this, but it's commonly accepted that such EOL whitespace shouldn't be there (but since all software is written by... [11:08:50] ...humans instead of our robotic overlords, we make mistakes every now and then) [11:10:00] Actually, its problem with text editors - i use atom, with dont use EOL whitespace at blank lines [11:10:46] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2862968 (10MarcoAurelio) Where is it configured? [11:11:29] I'm not actually a PHP dev ;( just observing. [11:11:34] yeah, it generates a slightly "messy" diff and I know for a fact that some people don't like it when you mix functional changes and whitespace/coding style changes, but I can't complain 'cause I do it myself, too :P [11:12:20] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2862969 (10Dereckson) >>! In T151570#2862968, @MarcoAurelio wrote: > Where is it configured? $wgCategoryCollation in IS, around line 14200. [11:14:07] (03PS1) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/326327 (https://phabricator.wikimedia.org/T151973) [11:14:25] 10video2commons: Disk space went not cool again on the video encoding instances - https://phabricator.wikimedia.org/T152899#2862986 (10Dereckson) We seriously need these two weeks to handle server-side upload. Could you shelf perhaps the candidates for server side upload so they are preserved? [11:17:10] (03PS4) 10Jack Phoenix: [WIP/EXPERIMENTAL] Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 [11:17:40] (03CR) 10Jack Phoenix: [C: 032] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/326327 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:18:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP/EXPERIMENTAL] Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 (owner: 10Jack Phoenix) [11:19:27] (03PS5) 10Jack Phoenix: [WIP/EXPERIMENTAL] Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 [11:20:01] (03Merged) 10jenkins-bot: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/326327 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:21:41] 10Wikimedia-Site-requests, 13Patch-For-Review: Request to Change title or sitename and logo for localisation and update namespaces on gujarati wikiquote (gu.wikiquote) - https://phabricator.wikimedia.org/T121853#2862992 (10Dereckson) Yes, both logo and configuration in Odder change at 323236, and the other par... [11:33:20] (03PS1) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326328 (https://phabricator.wikimedia.org/T151973) [11:33:39] 10Wikimedia-Site-requests, 13Patch-For-Review: Internal Wiki for Wikimedians of Ecuador - https://phabricator.wikimedia.org/T135521#2863001 (10Dereckson) Meanwhile, I left a mesage on https://meta.wikimedia.org/wiki/Talk:Wikimedistas_de_Ecuador#Wiki_Interna_2 I'm going to recontact Edjoerv, it was apparently... [11:35:19] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326328 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:36:27] (03PS2) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326328 (https://phabricator.wikimedia.org/T151973) [11:37:53] (03PS1) 10Reedy: SubPageList is now hosted over at GitHub [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/326329 (https://phabricator.wikimedia.org/T147393) [11:38:14] (03CR) 10jenkins-bot: [V: 04-1] SubPageList is now hosted over at GitHub [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/326329 (https://phabricator.wikimedia.org/T147393) (owner: 10Reedy) [11:38:27] 10MediaWiki-extensions-SubPageList, 10Continuous-Integration-Config, 13Patch-For-Review: SubPageList testextension fails - https://phabricator.wikimedia.org/T147393#2863006 (10Reedy) [11:39:40] 10MediaWiki-extensions-SubPageList, 10Continuous-Integration-Config, 13Patch-For-Review: SubPageList testextension fails - https://phabricator.wikimedia.org/T147393#2691506 (10Reedy) @hashar Want to add this to things to remove from WMF CI please? :) [11:39:57] (03PS1) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) [11:40:53] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:41:10] (03PS6) 10Jack Phoenix: [WIP] Version 1.5.4 -- use HTML5 instead of Flash for YouTube videos [extensions/Video] - 10https://gerrit.wikimedia.org/r/275271 [11:43:35] (03PS1) 10Jack Phoenix: Fix the "block user with regular expression" link on Special:Contributions/ [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/326331 [11:43:45] (03PS2) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) [11:43:47] (03CR) 10Jack Phoenix: [V: 032 C: 032] Fix the "block user with regular expression" link on Special:Contributions/ [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/326331 (owner: 10Jack Phoenix) [11:45:03] (03CR) 10jenkins-bot: [V: 04-1] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:46:08] (03CR) 10Jack Phoenix: [C: 032] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326328 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:46:15] (03Merged) 10jenkins-bot: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326328 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:46:50] (03PS3) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) [11:47:21] (03PS4) 10Reedy: Create OATHAuth tables when adding a wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321815 (owner: 10Dereckson) [11:47:25] (03PS5) 10Reedy: Create OATHAuth tables when adding a wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321815 (owner: 10Dereckson) [11:47:30] (03CR) 10Reedy: [C: 032] Create OATHAuth tables when adding a wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321815 (owner: 10Dereckson) [11:48:53] (03Merged) 10jenkins-bot: Create OATHAuth tables when adding a wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321815 (owner: 10Dereckson) [11:49:31] (03Abandoned) 10Reedy: Move all configuration into ConfirmAccount.php [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/209051 (owner: 10Paladox) [11:52:10] (03Abandoned) 10Filip: Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [11:52:25] (03PS1) 10Jack Phoenix: Follow-up to the previous commit, fix a fatal typo [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326332 [11:52:42] (03CR) 10Jack Phoenix: [C: 032] Follow-up to the previous commit, fix a fatal typo [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326332 (owner: 10Jack Phoenix) [11:52:49] (03Merged) 10jenkins-bot: Follow-up to the previous commit, fix a fatal typo [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/326332 (owner: 10Jack Phoenix) [11:53:44] (03CR) 10Reedy: [C: 04-1] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 (031 comment) [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [11:55:22] (03PS4) 10Filip: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) [11:56:55] (03CR) 10Reedy: [V: 032 C: 032] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/326322 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:04:52] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2863033 (10Reedy) Add RDFIO to the list [12:05:20] (03CR) 1001tonythomas: [C: 04-1] "Comments inline." (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152168) (owner: 10Georggi199) [12:06:48] tonythomas, if you just make > 0 part, it will give an exception [12:07:29] Georggi: hmm. I havent seen it! [12:07:32] And I tested it, it does ask if you are sure that you want to remove all publishers before accepting [12:07:38] what is the exception, can you paste it ? [12:07:46] sec, need to restart vagrant [12:08:00] (03CR) 10Reedy: [C: 032] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:09:28] tonythomas, beforehands, it had thrown an Fatal status when you add publishers too, but it was because wrong decoding I guess, because I didn't see it after your patch [12:09:33] (03Merged) 10jenkins-bot: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/326330 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:10:28] tonythomas, https://gerrit.wikimedia.org/r/#/c/325816/ check it in this PS, where I tried to do that, but you indeed commented that it fatals with this one [12:10:30] Georggi: yeah. I fixed that with that decode thingy [12:10:48] (03CR) 10Reedy: [C: 032] Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326321 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:10:50] tonythomas, but it still showed up when you tried to remove publishers [12:11:02] Georggi: is it happening now (in master) ? [12:11:15] When you remove all publishers - yes [12:11:29] (and if it is set to check > 0 [12:12:06] (03Merged) 10jenkins-bot: Replaced "Article::doEdit()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326321 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [12:13:47] tonythomas, I will paste a few things on phabricator page [12:15:08] Georggi: okey! [12:18:00] Oh, just found out that I've listed wrong bug in it, oups? Can I just change Bug:***? [12:23:09] tonythomas, and yeah, sorry in advance, but is it fine if I just don't edit an image and put it in imgur? Gonna paste 7 of them there, so I don't what to put all of them on phabricator:). [12:23:36] Georggi: you can just drag and drop those things to phabricator. In the worst case, go for imgur [12:23:36] (03PS11) 10Florianschmidtwelzow: Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [12:23:52] (03CR) 10Florianschmidtwelzow: "PS11 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [12:24:07] I mean, I am doing screenshots of a whole page, so 7 1366*768 screenshots won't be good I guess? [12:24:10] 10Phabricator: Recent update to wmf/stable has broke phabricator (test installs) - https://phabricator.wikimedia.org/T152902#2863059 (10Paladox) [12:24:53] (03CR) 10Victorbarbu: "Florian, what do you think?" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [12:26:03] FlorianSW, hi! [12:26:27] victorbarbu: hi! :) Currently reviweing your change, sorry for tha huge delay :( [12:26:37] So much for German efficiency [12:26:52] FlorianSW, it's ok, I just hope it will be fine and I will get my task accepted... [12:28:40] (03PS2) 10Addshore: Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [12:28:41] Reedy: :P You don't know what I did instead of reviewing changes :P :D [12:29:09] 10Phabricator: Recent update to wmf/stable has broke phabricator (test installs) - https://phabricator.wikimedia.org/T152902#2863072 (10Paladox) I did this on phab-03 as someone reported T152891 and I tried to recover my account which when I tried to login gave a 500 error and I looked in the logs and got [Sun... [12:29:31] * Reedy takes all of FlorianSW's lebkuchen [12:30:11] eyyy [12:30:43] Which reminds me. I need to go source some [12:30:46] (03CR) 10jenkins-bot: [V: 04-1] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [12:32:22] !class BaseTemplate [12:32:22] See https://doc.wikimedia.org/mediawiki-core/master/php/classBaseTemplate.html [12:33:51] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Lone publisher is not listed in Newsletter:NewsletterName - https://phabricator.wikimedia.org/T152668#2863074 (10Georggi199) a:03Georggi199 Base newsletter: http://imgur.com/a/mD0NV Editing to no publishers: http://imgur.com/a/PvLC3 Case 1( count(*) >... [12:34:40] tonythomas, check it ^^^^ [12:35:03] (03PS3) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) [12:35:29] Georggi: sorry. I am bit busy with my assignment right now. Will check it in like ~3 hours [12:35:36] sure [12:36:06] (03PS1) 10Jack Phoenix: Attach the JS listeners to body so that they'll always work [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/326335 [12:37:03] (03CR) 10jenkins-bot: [V: 04-1] Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [12:37:38] (03CR) 10Jack Phoenix: [V: 032 C: 032] Attach the JS listeners to body so that they'll always work [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/326335 (owner: 10Jack Phoenix) [12:38:40] (03Merged) 10jenkins-bot: Attach the JS listeners to body so that they'll always work [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/326335 (owner: 10Jack Phoenix) [12:39:11] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Namespace is repeated in notification link - https://phabricator.wikimedia.org/T140402#2463560 (10FilipGCI) @01tonythomas @Rudloff @Aklapper I cant recreate this. When i make new announce to "Foo:bar" it links correctly to "Foo:bar". I'm using master... [12:43:54] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [12:44:40] 04(no projects): Settings tab SIL/X-SAMPA is confusing and links to unhelpful page - https://phabricator.wikimedia.org/T152903#2863081 (10Effeietsanders) [12:45:51] 04(no projects): Settings tab SIL/X-SAMPA is confusing and links to unhelpful page - https://phabricator.wikimedia.org/T152903#2863092 (10Effeietsanders) [12:46:07] 10MediaWiki-extensions-UniversalLanguageSelector: Settings tab SIL/X-SAMPA is confusing and links to unhelpful page - https://phabricator.wikimedia.org/T152903#2863093 (10Reedy) [12:47:30] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Ok, the code side:" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [12:47:44] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Namespace is repeated in notification link - https://phabricator.wikimedia.org/T140402#2863095 (10Rudloff) I can't reproduce anymore with 1.28+88234fa. [12:47:57] victorbarbu: added a comment and review :) [12:48:21] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Namespace is repeated in notification link - https://phabricator.wikimedia.org/T140402#2863096 (10FilipGCI) So i think this is not valid GCI task [12:49:06] 10MediaWiki-extensions-ContentTranslation: Attempting to translate list containing a MathWorld template causes 'TypeError: mwData.parts[0].template is undefined' - https://phabricator.wikimedia.org/T152904#2863097 (10He7d3r) [12:49:55] (03CR) 10jenkins-bot: [V: 04-1] Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that hooked functions can use them where needed [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [12:51:19] FlorianSW, I see you rebased the change. do I have to run git pull --rebase origin master in my local git? [12:51:27] or will it rebase from something else? [12:51:47] victorbarbu: you just need to download the change again, and it should be something near master :) [12:51:49] 10UI-Standardization, 13Patch-For-Review, 13Patch-Needs-Improvement: Convert Special:EditWatchlist to OOUI - https://phabricator.wikimedia.org/T117790#2863109 (10BethNaught) For my taste and I suspect for many other users' the new normal edit mode is far too big. For users with long watchlists, the fact you... [12:52:46] (03CR) 10Reedy: "Curious, still complaining about the same thing" [core] - 10https://gerrit.wikimedia.org/r/326075 (owner: 10Jack Phoenix) [12:52:52] damn it [12:53:09] "merge conflict in ...SpecialRecentChanges.php" [12:53:11] ... [12:53:26] 10MediaWiki-extensions-ContentTranslation: ContentTranslation does not translate accented words correctly - https://phabricator.wikimedia.org/T152905#2863110 (10He7d3r) [12:54:21] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Namespace is repeated in notification link - https://phabricator.wikimedia.org/T140402#2863122 (1001tonythomas) FlipGCI, can you attach two screenshots (one with your announce form, and the other with the Echo notificaiton) ? [12:55:57] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/326337 [12:56:06] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/326338 [12:56:16] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/326339 [12:57:23] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/326337 (owner: 10Hashar) [12:57:32] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/326338 (owner: 10Hashar) [12:57:42] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/326339 (owner: 10Hashar) [13:00:12] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Namespace is repeated in notification link - https://phabricator.wikimedia.org/T140402#2863123 (10FilipGCI) @01tonythomas {F5036257} {F5036261} [13:02:03] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.18.3), 03UI-Standardization-Kanban: Improve form layouts in OOUI MW core forms for better user experience - https://phabricator.wikimedia.org/T136790#2863125 (10BethNaught) Simply with the large number of options and checkboxes on for example the watchlist panel, an... [13:03:43] (03CR) 10Victorbarbu: "I will continue to work on this until it's merged even if my GCI task is accepted, yeah!" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [13:04:48] FlorianSW, the change regarding those urls, the one with "days" [13:05:29] because even if I convert that to seconds, what if it's not one of the options I provide? [13:05:42] I mean, what if it's 13 days? I don't have such an option? [13:09:29] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Namespace is repeated in notification link - https://phabricator.wikimedia.org/T140402#2863128 (1001tonythomas) 05Open>03Resolved a:0301tonythomas Nice. Happy that it got fixed. Would've been fixed during the contenthandler migration [13:16:15] 04(no projects): Problems to save changes in eu:wp - https://phabricator.wikimedia.org/T152897#2863143 (10Theklan) We don't even have a discussion on it, as it's difficult to make changes. We have been discussing it with others via Whatsapp and yes, many people is experiencing this issue. You can try changing a... [13:16:42] 10MediaWiki-Redirects: #REDIRECT - https://phabricator.wikimedia.org/T152807#2863144 (10Zoranzoki21) 05stalled>03Resolved a:03Zoranzoki21 I close task. MediaWiki we discussed what to do. Thanks anyway. [13:18:41] 04(no projects): Problems to save changes in eu:wp - https://phabricator.wikimedia.org/T152897#2862887 (10Reedy) Works fine for me https://eu.wikipedia.org/w/index.php?title=Antunes_da_Silva&action=history [13:18:57] Heyy, any GCI mentors online? [13:21:21] ISBetrayal0520: hi, I'm not a GCI mentor, but if you've a general question, I can perhaps answer [13:25:41] (03CR) 10Fomafix: [C: 04-1] [WIP] Unwatch link for pages in Special:Watchlist (033 comments) [core] - 10https://gerrit.wikimedia.org/r/293892 (https://phabricator.wikimedia.org/T2424) (owner: 10Sn1per) [13:25:44] it would be nice if gerrit had gpg signing [13:25:46] FlorianSW, [13:25:51] are you still arround? [13:25:53] around* [13:27:16] victorbarbu: you send your patch to Gerrit through SSH, from a ssh key linked to your account [13:27:22] 10MediaWiki-Email, 10Mail, 06Operations, 10Wikimedia-General-or-Unknown, and 3 others: Email server's DMARC config prevents users from sending emails via Special:EmailUser - https://phabricator.wikimedia.org/T66795#2863149 (10AnnaMariaKoshka) @Legoktm - after some time of tesing - it doesnt work. If I se... [13:27:32] Dereckson, yes [13:27:40] victorbarbu: that allows to be fairly sure *committer* is genuine [13:28:03] oh, correct, then why did github add a gpg signing flag for ssh commits as well? [13:29:28] 04(no projects): Problems to save changes in eu:wp - https://phabricator.wikimedia.org/T152897#2863151 (10Theklan) It saved after 10 attempts. [13:31:47] (03CR) 10Hashar: [V: 032 C: 032] SubPageList is now hosted over at GitHub [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/326329 (https://phabricator.wikimedia.org/T147393) (owner: 10Reedy) [13:33:31] Dereckson, could you please help me amending a change? [13:33:39] I have a situation that i've never met [13:33:46] 10MediaWiki-extensions-SubPageList, 10Continuous-Integration-Config, 13Patch-For-Review: SubPageList testextension fails - https://phabricator.wikimedia.org/T147393#2863155 (10Reedy) 05Open>03declined [13:34:06] yes, I can [13:34:25] http://pastebin.com/mnMCG96m [13:34:30] check this out [13:34:51] missing a git fetch? [13:34:51] okay, try to fetch the last master branch and to rebase: [13:34:53] git fetch [13:34:56] git rebase origin/master [13:35:40] (03PS12) 10Victorbarbu: Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [13:35:43] the first will fetch new changes from the server, the second will replay your commit history on the top of master, not your current master, but directly the remote one [13:35:48] Dereckson, you're a genius [13:36:07] don't worry, you'll get use to Git fetch/rebase dance after some months [13:37:08] (03CR) 10Fomafix: [C: 04-1] [WIP] Unwatch link for pages in Special:Watchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/293892 (https://phabricator.wikimedia.org/T2424) (owner: 10Sn1per) [13:37:11] I use rebase frequently [13:37:13] but not fetch [13:37:31] I have to read the manual for that and gain some experience with it [13:40:08] and there's still people saying "git is easy" ;) [13:40:11] this git fetch ; git rebase origin/master is easier than git checkout master ; git pull ; git checkout your-branch ; git rebase master [13:40:20] well shorter [13:40:27] no, Git isn't easy [13:41:06] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) [13:41:10] The fact everyoone uses a same VCS software is. The fact the workflows are smilar everywhere is too. But Git itself isn't easy. [13:52:04] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [14:00:01] 10Phabricator: Recent update to wmf/stable has broke phabricator (test installs) - https://phabricator.wikimedia.org/T152902#2863163 (10Paladox) I think that error was just cached, I now get this error after restarting apache [Sun Dec 11 13:59:12.216475 2016] [:error] [pid 22512] [client 10.68.21.68:35968] >>>... [14:05:25] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Convert Special:DeletedContributions to OOUI - https://phabricator.wikimedia.org/T134525#2268115 (10TheDJ) BTW, we get the same response every single time we do one of these switches and for good reas... [14:07:08] (03CR) 10Jack Phoenix: [C: 04-2] "Fatals on http://social-tools.wmflabs.org/ :" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:07:25] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2863180 (10hashar) I have removed SemanticForms. SemanticFormsInput is still around, though it depends on SemanticForms, might want... [14:08:50] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 [14:11:02] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config, 13Patch-For-Review: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2863186 (10Reedy) TODO: RDFIO SemanticBreadcrumbLinks SemanticCite SemanticExternalQueryLookup SemanticExtra... [14:11:45] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2863187 (10Aklapper) [14:14:06] 10Phabricator: Recent update to wmf/stable on Phabricator test installs: Call to undefined method PhabricatorEnv::getRemoteAddress() / PhutilIPAddress::getAddress() - https://phabricator.wikimedia.org/T152902#2863190 (10Paladox) p:05Triage>03High I managed to workaround this by using some of the old code sho... [14:14:15] 10TimedMediaHandler, 10TimedMediaHandler-Player: Support 360 videos - https://phabricator.wikimedia.org/T150624#2863192 (10TheDJ) [14:14:45] 10TimedMediaHandler: Support WebM spatial metadata file annotations - https://phabricator.wikimedia.org/T150640#2863195 (10TheDJ) [14:14:49] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2863198 (10GabrielLeeDHS) [14:15:11] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [14:15:45] ashley: I made a commit [14:16:36] cheers, I'll deploy it to the test site soon to try it out :) [14:18:04] (03PS1) 10Jack Phoenix: ArticleSaveComplete (deprecated in MW 1.21) -> PageContentSaveComplete [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/326348 [14:18:47] ashley: lol aft [14:19:18] Reedy: what can I say, Brickipedia's rather fond of it (and people are actually *using* it!) [14:20:17] lol [14:20:55] rlot: yay, now it doesn't explode :) if you could tweak the commit message a bit, specifically remove the part about "Replaced "Article" class with "WikiPage"", I'll merge it [14:21:26] Reedy: you can't make up this shit: http://en.brickimedia.org/wiki/Special:Log/articlefeedbackv5 [14:21:45] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) [14:24:24] (03PS3) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [14:24:33] ashley: Doen [14:25:31] (03PS1) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/326349 (https://phabricator.wikimedia.org/T151973) [14:26:31] 10MediaWiki-Internationalization, 10MediaWiki-extensions-WikimediaIncubator, 06translatewiki.net, 07I18n, 07RTL: Wikimedia Incubator and translatewiki cannot set the rtl direction for N'Ko (nqo) language, probably because there's no MessagesNqo.php - https://phabricator.wikimedia.org/T152908#2863206 (10Am... [14:28:41] rlot: hm, it would appear that BlogPage::getBlurb() is now broken -- look for the comment "Run text through parser" in that method; the following line of code attempts to use the now-nonexistent $article variable [14:28:41] (03PS1) 10Filip: Cleaned "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) [14:29:14] ashley: I'll take a look [14:29:19] 10MediaWiki-Internationalization, 10MediaWiki-extensions-WikimediaIncubator, 06translatewiki.net, 07I18n, 07RTL: Wikimedia Incubator and translatewiki cannot set the rtl direction for N'Ko (nqo) language, probably because there's no MessagesNqo.php - https://phabricator.wikimedia.org/T152908#2863206 (10Ni... [14:29:24] thanks [14:29:59] 10Dumps-Generation, 13Patch-For-Review, 05Security: Omit private data from being generated during dump runs - https://phabricator.wikimedia.org/T152021#2863222 (10Bawolff) >>! In T152021#2838148, @jcrespo wrote: >> I don't think so. We have db backups for that. @jcrespo can say more about those. > > I trust... [14:31:44] (03PS3) 10Paladox: Remove uneeded subscribe [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326216 [14:31:51] 10MediaWiki-Internationalization, 10MediaWiki-extensions-WikimediaIncubator, 06translatewiki.net, 07I18n, 07RTL: Wikimedia Incubator and translatewiki cannot set the rtl direction for N'Ko (nqo) language, probably because there's no MessagesNqo.php - https://phabricator.wikimedia.org/T152908#2863223 (10Am... [14:32:01] (03Abandoned) 10Paladox: Enable submodule in this skin [skins/Example] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326237 (owner: 10Paladox) [14:32:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Allows to retrieve a Wikibase entity from a page name in Lua - https://phabricator.wikimedia.org/T152909#2863224 (10Tpt) [14:35:02] (03PS4) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [14:35:10] ashley: Commited it [14:35:31] (03PS9) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [14:37:46] (03PS53) 10Paladox: Add extension.json, empty PHP entry point [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/208523 (https://phabricator.wikimedia.org/T100425) [14:38:52] (03CR) 10Paladox: [C: 031] "Haven't tested and not sure if this will work but +1." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324352 (owner: 10Reedy) [14:41:12] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config, 13Patch-For-Review: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2863241 (10hashar) I have marked them all as read-only in Gerrit and updated the description to point at the... [14:42:54] To ssh://rlot@gerrit.wikimedia.org:29418/mediawiki/extensions/WYSIWYG.git [14:42:54] ! [remote rejected] HEAD -> refs/publish/master/T151973 (project is read only) [14:42:54] error: failed to push some refs to 'ssh://rlot@gerrit.wikimedia.org:29418/mediawiki/extensions/WYSIWYG.git' [14:42:58] Whats wrong? [14:43:48] It's readonly [14:44:21] So how i can make gerrit patch? [14:45:02] You can't [14:45:25] So how i can complete GCI task? [14:45:52] Just ignore that extension, leaving a comment to that extent [14:46:35] (03PS5) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [14:49:00] (03PS1) 10Reedy: WYSIWYG has gone to GitHub [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/326353 [14:49:13] (03CR) 10Reedy: [V: 032 C: 032] WYSIWYG has gone to GitHub [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/326353 (owner: 10Reedy) [14:50:00] rlot: This is one of the problems. A lot of these extensions are abandoned, in bad states, or moved elsewhere. And we're hosting old copies of them on gerrit [14:50:08] You wouldn't be penalised on GCI for this [14:50:27] Reedy: Ok, i submited it [14:50:43] Heres pastebin code [14:50:51] or i must make pull request? [14:51:10] for WYSIWYG? I wouldn't bother [14:51:13] Just ignore it [14:52:40] Ok, i submited it on GCI site [14:52:55] rlot: looks good, but sadly: PHP Fatal error: Call to undefined method WikiPage::getContext() in /vagrant/mediawiki/extensions/BlogPage/BlogPageClass.php on line 1129 [14:54:23] apparently dear ol' WikiPage doesn't extend RequestContext and thus isn't aware of the context...like, at all [14:56:33] 10Wikimedia-Site-requests, 13Patch-For-Review: Private wiki for Project Grants Committee - https://phabricator.wikimedia.org/T143138#2863245 (10Krenair) Okay, let's try to debug after the 18th [15:03:04] 10BlueSpice: RSSStandards.class.php has raw built SQL - https://phabricator.wikimedia.org/T152910#2863251 (10Reedy) [15:03:42] (03CR) 10Reedy: [C: 04-1] "Why all the style changes?" (031 comment) [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:06:07] (03CR) 10Reedy: [C: 04-1] Replaced "Article::getContent" deprecated in MediaWiki 1.21 (032 comments) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:06:38] (03CR) 10Reedy: [C: 04-1] Cleaned "Article::getContent" deprecated in MediaWiki 1.21 (031 comment) [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:07:39] (03CR) 10Reedy: [C: 032] Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/326349 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:08:02] WYSIWYG is the extension with those huge JavaScript blobs imported from who knows where which spam your terminal whenever you try to grep all extensions, rght? [15:08:07] (03Merged) 10jenkins-bot: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/326349 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:08:51] Nemo_bis: Not any more. It's been emptied :D [15:12:32] Hello everyone, I am a software dev, new to the wikimedia. I wish to contribute to your codebase. [15:12:56] It would be great id you could guide me through [15:13:06] 10Wikimedia-Site-requests: Problems to save changes in eu:wp - https://phabricator.wikimedia.org/T152897#2863267 (10MarcoAurelio) @Anomie @Tgr Could you please dig in Logstash if this is something related to AuthManager / CentralAuth ? Thanks. [15:13:10] !start | raghav [15:13:10] raghav: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [15:14:01] 10Wikimedia-Site-requests, 13Patch-For-Review: Migrate 'technician' trwiki usergroup name to 'interface-editor' - https://phabricator.wikimedia.org/T144638#2863270 (10MarcoAurelio) [15:15:43] Reedy: good, I don't like zombie repositories mnuch [15:15:58] Nemo_bis: Indeed. Same for rotting and moved ones [15:16:05] Which is why I've nuked a load of Semantic ones too this weekend [15:16:43] Reedy: speaking of which, it would be nice to revisit the reasons they moved to GitHub [15:17:08] I'm not sure the reasons have ever been written down/shared on wikitech-l and whether they're still current [15:17:23] It's kinda funny [15:17:30] And I seem to perceive a growing discomfort with the situation [15:17:36] 10Wikimedia-Site-requests: Remove 'technican' usergroup from tr.wikiquote - https://phabricator.wikimedia.org/T152911#2863271 (10MarcoAurelio) [15:18:04] Nemo_bis: https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/2080#issuecomment-266170558 [15:18:18] "What do you mean we can't host our extensions elsewhere and expect them to be maintained?" [15:19:46] Of course, the commit to gerrit and abandon is annoying generally [15:19:55] :P [15:26:17] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2863291 (10GabrielLeeDHS) [15:27:30] 10Wikimedia-Site-requests, 13Patch-For-Review: Remove 'technican' usergroup from tr.wikiquote - https://phabricator.wikimedia.org/T152911#2863292 (10MarcoAurelio) [15:28:04] (03PS4) 10Reedy: Remove FSRepo [core] - 10https://gerrit.wikimedia.org/r/324350 [15:28:10] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2544589 (10GabrielLeeDHS) [15:30:03] (03CR) 10Fomafix: [C: 04-1] "The progress bar generates a flickering because the whole page scrolls down. Maybe an absolute position is a solution for this problem." [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [15:30:49] (03PS1) 10Brian Wolff: Allow password resets from anon-only range blocks [core] - 10https://gerrit.wikimedia.org/r/326355 (https://phabricator.wikimedia.org/T109909) [15:33:44] 10Wikimedia-Blog: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2863314 (10Volker_E) a:03Volker_E [15:33:57] 05Security: Password recovery blocked from the WMF office - https://phabricator.wikimedia.org/T151966#2833615 (10Bawolff) For reference https://gerrit.wikimedia.org/r/326355 I think this should be marked as a dupe of T109909 [15:38:45] (03CR) 10jenkins-bot: [V: 04-1] Allow password resets from anon-only range blocks [core] - 10https://gerrit.wikimedia.org/r/326355 (https://phabricator.wikimedia.org/T109909) (owner: 10Brian Wolff) [15:39:56] 04(no projects): RevisionSlider lazy loading causes arrow on bar to load on wrong side in RTL - https://phabricator.wikimedia.org/T152913#2863322 (10Addshore) [15:42:03] 10MediaWiki-User-blocking, 13Patch-For-Review: Anon-only range block doesn't allow password resets - https://phabricator.wikimedia.org/T109909#1562360 (10Nemo_bis) So how will one prevent such users from trying bulk password resets for many accounts? By switching the range block to also affect registered users... [15:45:32] (03CR) 10Reedy: "Why the file permission changes on both files? Even more so, on one you've not made any change in" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [15:45:46] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2863341 (10GabrielLeeDHS) [15:47:46] 10Wikimedia-Site-requests, 13Patch-For-Review: Remove 'technican' usergroup from tr.wikiquote - https://phabricator.wikimedia.org/T152911#2863343 (10MarcoAurelio) p:05Triage>03Low [15:47:56] 06Stewards-and-global-tools, 10Wikimedia-Site-requests, 13Patch-For-Review: Allow private.dblist wikis to manage more permissions internally - https://phabricator.wikimedia.org/T152489#2863345 (10MarcoAurelio) p:05Triage>03Low [15:48:25] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863347 (10MarcoAurelio) [15:49:34] 10MediaWiki-User-blocking, 13Patch-For-Review: Anon-only range block doesn't allow password resets - https://phabricator.wikimedia.org/T109909#1562360 (10Ciencia_Al_Poder) >>! In T109909#2863336, @Nemo_bis wrote: > So how will one prevent such users from trying bulk password resets for many accounts? By switch... [15:50:11] (03CR) 10Divadsn: "@Reedy, see previous changes, I did revert them in the latest patch set." [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [15:52:14] (03CR) 10Reedy: "https://stackoverflow.com/questions/20958888/preserving-file-permissions-for-samba-shares-when-file-is-edited" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [15:52:31] (03PS5) 10Divadsn: Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) [15:53:20] (03CR) 10Divadsn: "I fixed them on the go via SSH access on my test machine from remote, should be ok now :)" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [16:06:31] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2863369 (10Nemo_bis) p:05Triage>03Normal [16:07:10] 10MediaWiki-extensions-SmiteSpam, 13Patch-For-Review: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2861456 (10Nemo_bis) [16:07:15] 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Other, and 4 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#2863370 (10Nemo_bis) [16:08:38] (03PS2) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/326342 (https://phabricator.wikimedia.org/T151973) [16:10:07] (03PS2) 10Filip: Cleaned "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/326351 (https://phabricator.wikimedia.org/T151973) [16:10:53] (03PS3) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) [16:11:28] Reedy: I made all of these style changes, to fit 100 char limit [16:13:42] 10MiniInvite, 10Social-Tools, 07Easy: Lowercase content of i18n messages for consistency with other messages - https://phabricator.wikimedia.org/T152879#2863374 (10Aklapper) [16:13:44] Reedy: Can you take a look at https://gerrit.wikimedia.org/r/#/c/326344/ [16:13:59] ashley: Should i use ParserOutput? [16:14:39] 10Wikimedia-Site-requests, 13Patch-For-Review: Request to Change title or sitename and logo for localisation and update namespaces on gujarati wikiquote (gu.wikiquote) - https://phabricator.wikimedia.org/T121853#2863377 (10Dereckson) a:03tomasz Tomasz has scheduled the change for deployment at 00:00 UTC on T... [16:16:30] rlot: I don't think so, but I'm not sure to be honest; maybe Reedy has some good suggestions on how to best handle this [16:19:14] andre__: Are you around? [16:21:03] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons - https://phabricator.wikimedia.org/T152839#2863385 (10Aklapper) Thanks! After enabling [[ https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CropTool.js | CropTool ]] on https://commons.wikimedia.org/wiki/Special:Preferences#mw-prefsection-g... [16:21:23] 10AbuseFilter, 07Easy, 07I18n: GENDER parameter for AbuseFilter log should use the user, not the username - https://phabricator.wikimedia.org/T152873#2863386 (10Aklapper) [16:22:25] 10CirrusSearch, 06Discovery, 06Discovery-Search: Special:Search Issue - https://phabricator.wikimedia.org/T152895#2863388 (10Aklapper) (Wikimedia sites don't use #MediaWiki-Search hence setting #CirrusSearch ) [16:22:45] rlot: kind of [16:23:02] but don't ask to ask, please :) [16:23:33] andre__: I asked on private chat [16:26:56] 10MediaWiki-Redirects: #REDIRECT - https://phabricator.wikimedia.org/T152807#2863390 (10Aklapper) 05Resolved>03Invalid [16:27:44] andre__ [16:31:31] Krenair: yeah? :) [16:31:44] andre__, you've got mail [16:32:00] That's basically every minute the case. :P [16:32:27] heh [16:32:34] you've got a direct one from me [16:32:43] I might read that soon! :) [16:32:48] (03PS6) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [16:33:03] ashley: I work arounded it [16:36:26] @seen Reedy [16:36:26] rlot: Reedy is in here, right now [16:41:10] 10MediaWiki-General-or-Unknown: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2863402 (10VictorPorton) [16:41:58] 10MediaWiki-General-or-Unknown: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2863414 (10VictorPorton) [16:44:23] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863415 (10Aklapper) `mw.Api error: http Object { xhr: Object, textStatus: "error", exception: "" } load.php:13281:4` is what I get after opening the web browser's developer tools and their 'console... [16:44:33] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863416 (10Aklapper) p:05Triage>03High [16:46:54] ashley: Can you check https://gerrit.wikimedia.org/r/#/c/326344/ [16:49:23] andre__, if you could read it sooner rather than later, that'd be appreciated [16:50:11] 10SpamRegex: Implement a text field for providing a reason in Special:SpamRegex form - https://phabricator.wikimedia.org/T152168#2863419 (10SamanthaNguyen) Hey @georggi199, looks like you made a typo and meant to ticket T152668 instead (but looks like you already updated it!), so I'm going to remove the #patch-f... [16:57:45] Reedy, I fixed the file permissions with latest patch set, could you please look over my task? https://gerrit.wikimedia.org/r/#/c/326252/ :) [16:58:02] rlot: when calling BlogPage::getBlurb() manually (from /maintenance/eval.php): PHP Fatal error: Call to a member function getContent() on a non-object in /vagrant/mediawiki/extensions/BlogPage/BlogPageClass.php on line 1095 (because $page is undefined there) [16:58:25] ashley: Ok, give me a secound [16:59:09] ashley: Typo [16:59:14] (03PS7) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [16:59:19] ashley: Fixed it [17:00:06] PHP Catchable fatal error: Argument 1 passed to ContentHandler::getContentText() must implement interface Content, string given, called in /vagrant/mediawiki/extensions/BlogPage/BlogPageClass.php on line 1096 and defined in /vagrant/mediawiki/includes/content/ContentHandler.php on line 114 [17:05:46] (03PS8) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [17:06:03] ashley: Ok, my fault. Its ok now [17:10:27] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2863443 (10Volker_E) [17:12:36] (03CR) 10D3r1ck01: [C: 031] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [17:12:54] (03CR) 10D3r1ck01: [C: 031] "recheck" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [17:14:01] (03CR) 10Paladox: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/190660 (owner: 10Paladox) [17:14:57] rlot: aye, seems to be good now (manually calling BlogPage::getBlurb() still throws out a fatal, but I've confirmed that that's "expected", though I gotta admit it's strange, but that's not your fault, that's mine) [17:17:16] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 13Patch-For-Review: Clicking New tab icon should make the created tab the currently active tab - https://phabricator.wikimedia.org/T150019#2863449 (10Kaartic) 05Open>03Resolved [17:19:39] ashley: Can you +2 it? Thanks for your work! [17:20:52] rlot: hm, actually not quite, I'm afraid -- it seems to break down when dealing with a(n interwiki) redirect. simplest possible test case: create a page in the blog NS, either manually or via Special:CreateBlogPost, that contains an interwiki redirect (#REDIRECT [[wikipedia:Main Page]] or #REDIRECT [[shoutwiki:Main Page]] or whatever) and instead of something sane, you get this: [17:20:54] [64344383079270f1e141d8c4] /w/index.php?title=Blog:Redirect_test&action=edit BadMethodCallException from line 46 of /vagrant/mediawiki/extensions/BlogPage/BlogPageClass.php: Call to a member function getNativeData() on a non-object (NULL) [17:22:38] ashley: Thats wierd [17:22:57] ashley $rpage->getContent() is an object of Content [17:24:26] 10UI-Standardization, 10Wikimedia-Blog, 03UI-Standardization-Kanban: "Subscribe" button has wrong text color - https://phabricator.wikimedia.org/T152893#2863455 (10Volker_E) @Tbayer Could you provide an insight into the applied styles by inspecting the button via Developer Tools? The button should have `-moz... [17:29:17] (03PS9) 10Filip: Replaced "Article::getContent" deprecated in MediaWiki 1.21 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) [17:29:26] ashley: I think i finally got it [17:30:06] Georggi: around ? [17:30:11] testing your patch now! [17:32:41] Reedy: Are you there? [17:34:49] 10MediaWiki-Vagrant, 10Gerrit: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2863456 (10bd808) Another report at https://www.mediawiki.org/wiki/Talk:MediaWiki-Vagrant#Cloning_MediaWiki_fails_during_first_setup @demon is there a good procedure for deb... [17:42:14] (03CR) 1001tonythomas: [C: 04-1] "Comments inline" (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [17:42:20] Georggi: done. [17:45:19] tonythomas, yeah, I am here [17:45:22] mvolz: I talked to andre__: [17:46:01] (03PS1) 10Brian Wolff: Use long array syntax on mw-config/index.php for better error msg [core] - 10https://gerrit.wikimedia.org/r/326357 [17:46:15] And i can reclaim it, when i'll finish my task [17:47:51] tonythomas, why do you need to return it anyways? [17:48:05] Georggi: we need functions to return something, please! [17:48:09] I haven't seen anything break, nor anything used status returned [17:48:38] But when status is returned, it is not being used anywhere. [17:48:54] And it always returns an array [17:50:00] Did you look at screenshots I put in phabricator? [17:50:44] ashley: I made commit [17:51:15] And anyways, if you tested it, what was wrong when it didn't return Status and only returned an array? [17:52:25] (03CR) 10Filip: "@Reedy: I made style changes to fit 100 char line limit. And its a bit cleaner to read" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/326346 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [17:53:42] 10MediaWiki-Vagrant, 10Gerrit: "index-pack failed" when installing new MediaWiki-Vagrant box - https://phabricator.wikimedia.org/T152801#2860585 (10Mainframe98) >>! In T152801#2863456, @bd808 wrote: > Another report at https://www.mediawiki.org/wiki/Talk:MediaWiki-Vagrant#Cloning_MediaWiki_fails_during_first_s... [17:53:49] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863463 (10Dereckson) Can't repro on Chrome 56 or Firefox 52 (but I can confirm issues with gadgets). [17:56:36] 04(no projects): Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863464 (10Framawiki) Same, I haven't this message error in FF. [17:56:53] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863466 (10Framawiki) [17:59:04] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-ParserFunctions: A new syntax for #if sections idea - https://phabricator.wikimedia.org/T152914#2863467 (10Framawiki) [17:59:06] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Enable GuidedTour on all wikis - https://phabricator.wikimedia.org/T152827#2861371 (10Dereckson) I concur this is a good idea: when not configured, it doesn't create anything, but once enabled, any admin / interface ed... [18:00:23] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863472 (10MarcoAurelio) @Krinkle is good with updating Gadgets. If he's avalaible he might be able to have a look at them (and delete duplicate messages in the meanwhile). [18:06:16] Krenair: I've read it; I won't reply today [18:07:29] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2863492 (10Aklapper) [18:19:08] 10Wikimedia-Site-requests: Add prioritized languages to compact language links for nowiki - https://phabricator.wikimedia.org/T148021#2863500 (10Dereckson) a:03Dereckson [18:33:18] tonythomas, are you still here? [18:38:22] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 06ELiSo, 10Wikimedia-Site-requests, 07I18n: Enable translation tools on beta.wikiversity.org - https://phabricator.wikimedia.org/T148947#2737354 (10Dereckson) 05Open>03stalled p:05Triage>03Low [18:45:39] 10MediaWiki-extensions-ContentTranslation: ContentTranslation adds two copies of the same paragraph to the translation - https://phabricator.wikimedia.org/T152918#2863533 (10He7d3r) [18:49:37] @seen Reedy [18:49:37] rlot: Reedy is in here, right now [18:54:45] 10Challenge, 10Social-Tools: Challenge ext should use a lighter font weight in its forms for readability - https://phabricator.wikimedia.org/T152919#2863545 (10SamanthaNguyen) [18:56:13] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2863557 (10Steinsplitter) >>! In T152839#2863385, @Aklapper wrote: > Thanks! After enabling [[ https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CropTool.js | CropTool ]] o... [18:57:54] 10Social-Tools, 10SocialProfile, 07Documentation, 07Tracking: Add documentation for SocialProfile's support for Echo - https://phabricator.wikimedia.org/T152867#2863560 (10SamanthaNguyen) [19:02:46] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2681748 (10scfc) I've re-read the timeline and I can't see if and how the errors are debugged. For example, in T146843#2684248, @epriestley wrote: > […] >... [19:02:57] 10MediaWiki-User-login-and-signup: The returnto request after UserLogin converts POST parameter to GET parameter - https://phabricator.wikimedia.org/T152920#2863567 (10Fomafix) [19:10:41] 10MediaWiki-extensions-OATHAuth, 10UI-Standardization, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Special:OATH doesn't use the OOUI inputform style - https://phabricator.wikimedia.org/T150863#2863579 (10Volker_E) 05Open>03Resolved a:03TheDJ [19:12:06] Reedy: Are you there? [19:16:13] 07Design, 10MediaWiki-extensions-WikibaseRepository, 10UI-Standardization, 06WMDE-Design, and 2 others: Apply WikimediaUI color palette to Wikibase - https://phabricator.wikimedia.org/T151194#2863591 (10Volker_E) [19:18:44] (03PS10) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [19:23:28] 04(no projects): Diff highlights some changes in bold, but not all - https://phabricator.wikimedia.org/T152921#2863603 (10scfc) [19:24:25] 10MediaWiki-History-or-Diffs: Diff highlights some changes in bold, but not all - https://phabricator.wikimedia.org/T152921#2863614 (10scfc) [19:28:39] (03PS11) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [19:29:49] (03PS3) 10Sn1per: Move Special:Watchlist auto-reload check from PHP to JS [core] - 10https://gerrit.wikimedia.org/r/326233 (https://phabricator.wikimedia.org/T150045) [19:30:39] (03PS1) 10Bartosz Dziewoński: ImageHistoryPseudoPager: Don't ignore limit from URL [core] - 10https://gerrit.wikimedia.org/r/326361 (https://phabricator.wikimedia.org/T152813) [19:31:25] (03PS12) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [19:33:56] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2863621 (10epriestley) > Does the dataset for task 91231 include the word "databases"? Here's how to answer this question: - Find the task PHID for the... [19:35:09] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2863622 (10epriestley) (Note that mentioning the PHID of the task may also trigger mentions and reindexing, so no one should mention either `T...` or `PHID-... [19:35:20] 10Tools-Global-user-contributions: Global user contributions - tool not working - https://phabricator.wikimedia.org/T152922#2863623 (10BrillLyle) [19:36:05] 10Tools-Global-user-contributions: Global user contributions - tool not working - https://phabricator.wikimedia.org/T152922#2863635 (10BrillLyle) [19:40:59] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2863636 (10epriestley) On the `mysql.ft_boolean_syntax` issue, the resolution was: - InnoDB does not support `mysql.ft_boolean_syntax`, nor does it have... [19:50:22] 10MediaWiki-Logging: Feature Request: Move log enhancement - https://phabricator.wikimedia.org/T152829#2861414 (10Spinningspark) Just knowing that the page has been moved at all would be a good start. One does not always even know to go trawling through the history for the information. The log for the article... [19:53:23] 10MediaWiki-extensions-Linter: Linter: Display lint errors for a single page - https://phabricator.wikimedia.org/T151362#2863641 (10Legoktm) We also need to expose this via the API, probably as a prop module so it can be combined with prop=revisions, so you can get the article content and lint errors in the same... [19:55:51] 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review: Namespaces in slovak Wikibooks - https://phabricator.wikimedia.org/T138779#2863644 (10Dereckson) [19:56:06] 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review: Namespaces in slovak Wikibooks - https://phabricator.wikimedia.org/T138779#2409901 (10Dereckson) [19:57:26] 07Technical-Debt: testMediaWikiTestCaseParentSetupCalled does not have @covers annotations - https://phabricator.wikimedia.org/T152923#2863646 (10Seb35) [19:57:42] 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review: Namespaces in slovak Wikibooks - https://phabricator.wikimedia.org/T138779#2409901 (10Dereckson) 05stalled>03declined Original requester didn't pursue effort to get more consensus on wiki and doesn't seem to actively participate... [19:57:44] 10Social-Tools, 07Documentation, 07Tracking: Improve MediaWiki.org documentation for how social tools currently or could support Echo notifications - https://phabricator.wikimedia.org/T152924#2863661 (10SamanthaNguyen) [19:58:17] 07Technical-Debt: testMediaWikiTestCaseParentSetupCalled does not have @covers annotations - https://phabricator.wikimedia.org/T152923#2863646 (10Seb35) p:05Triage>03Lowest [19:58:31] 10Social-Tools, 07Documentation, 07Tracking: Improve documentation for how social tools currently or could support Echo notifications - https://phabricator.wikimedia.org/T152924#2863661 (10SamanthaNguyen) [19:58:38] 10Social-Tools, 07Documentation, 07Tracking: Improve documentation for how social tools currently or could support Echo notifications - https://phabricator.wikimedia.org/T152924#2863661 (10SamanthaNguyen) [19:58:41] 10Social-Tools, 07Documentation, 07Tracking: [TRACKING] Improve MediaWiki.org documentation for social tool extensions - https://phabricator.wikimedia.org/T152862#2862163 (10SamanthaNguyen) [19:58:43] 10Social-Tools, 10SocialProfile, 07Documentation, 07Tracking: Add documentation for SocialProfile's support for Echo - https://phabricator.wikimedia.org/T152867#2863677 (10SamanthaNguyen) [20:00:05] 10Social-Tools, 07Documentation: Improve documentation for how social tools currently or could support Echo notifications - https://phabricator.wikimedia.org/T152924#2863680 (10Aklapper) [20:00:09] 10Social-Tools, 07Documentation: [TRACKING] Improve MediaWiki.org documentation for social tool extensions - https://phabricator.wikimedia.org/T152862#2863681 (10Aklapper) [20:01:05] 10Phabricator, 10Elasticsearch, 13Patch-For-Review: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2863683 (10Paladox) @epriestley @mmodell pulled in the recent update you did and I applied it to the test instance phab-03 and these are the error's I got T... [20:04:16] 07Technical-Debt: testMediaWikiTestCaseParentSetupCalled does not have @covers annotations - https://phabricator.wikimedia.org/T152923#2863686 (10Seb35) [20:08:21] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2863691 (10lcf119) I just received a different database error while using Special:Search, which included the backtrace log below. ``` #0 /var/www/core/includes/db/Databas... [20:13:50] (03CR) 10Bartosz Dziewoński: [C: 032] Check whether user is allowed to see the hit count [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/321370 (https://phabricator.wikimedia.org/T120562) (owner: 10Matěj Suchánek) [20:16:12] 10AbuseFilter, 05Security, 07Vuln-Infoleak: AbuseFilter reveals hit count even without appropriate rights - https://phabricator.wikimedia.org/T120562#2863693 (10matmarex) 05Open>03Resolved This probably should've been a security bug (even if the issue is minor), but it's been public for a year, so… [20:16:44] (03PS1) 10Seb35: The automatic test in MediaWikiTestCase was marked as risky [core] - 10https://gerrit.wikimedia.org/r/326363 (https://phabricator.wikimedia.org/T152923) [20:20:42] 10MediaWiki-Categories, 07Documentation: Document how to decide if adding a new category collation is OK to do quickly and when we need to do other prep - https://phabricator.wikimedia.org/T447#2863700 (10matmarex) @greg: What remains to be done here? We've been routinely changing category collations on variou... [20:25:09] (03Merged) 10jenkins-bot: Check whether user is allowed to see the hit count [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/321370 (https://phabricator.wikimedia.org/T120562) (owner: 10Matěj Suchánek) [20:26:57] (03PS1) 10Bartosz Dziewoński: installer: Restore PHP 5.3 compatibility in index.php [core] - 10https://gerrit.wikimedia.org/r/326364 [20:29:57] (03PS2) 10Bartosz Dziewoński: installer: Restore PHP 5.3 compatibility in index.php [core] - 10https://gerrit.wikimedia.org/r/326364 [20:30:39] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863702 (10Tgr) >>! In T152897#2863267, @MarcoAurelio wrote: > @Anomie @Tgr Could you please dig in Logstash if this is something related to AuthManager / CentralAuth ? Thanks. It's hard to find usefu... [20:39:28] (03CR) 10Filip: "I think its ok now" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/326344 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [20:40:15] 10MediaWiki-extensions-Babel: Babel Extension - Issue with ASE language code - https://phabricator.wikimedia.org/T152925#2863705 (10AnotherPoint) [20:49:23] 10MediaWiki-File-management, 06Commons, 06Multimedia, 13Patch-For-Review: File histories won't display more than 10 files on a page - https://phabricator.wikimedia.org/T152813#2863718 (10matmarex) https://commons.wikimedia.org/w/index.php?title=Commons:Help_desk&oldid=225902593#Only_showing_10_file_revisions [20:52:27] (03PS1) 10Pppery: Make #lsth ignore blank line at end of section [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/326365 (https://phabricator.wikimedia.org/T144762) [20:58:00] (03PS1) 10XinyueZ: Added elevation animation when long tap on 'Today on Wikipedia' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326367 [21:07:04] (03CR) 10Fomafix: "Duplicate to https://gerrit.wikimedia.org/r/326357" [core] - 10https://gerrit.wikimedia.org/r/326364 (owner: 10Bartosz Dziewoński) [21:12:58] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2863742 (10Ghouston) I have more luck reproducing it with "fresh" files. Refreshing the page will fix it, and then it stays fixed when refreshed several more times. There's n... [21:15:06] Georggi: now I am! [21:15:47] So, can you answer why Status has to be returned, I tested what you suggested and it works too, but still. [21:20:11] Georggi: I think its nice to have all functions returning something. [21:20:39] tonythomas, but it is still returning array of publishers:\ [21:20:45] (03CR) 10Bartosz Dziewoński: "The "short arrays" rule should probably be ignored in the entire file. My accidental duplicate patch does that: https://gerrit.wikimedia.o" [core] - 10https://gerrit.wikimedia.org/r/326357 (owner: 10Brian Wolff) [21:21:07] Georggi: when ? if ( count( $publishersList ) === 0 ) { } ? [21:21:27] Georggi: when things are wrong, it should NOT return an array of publishers. are we clear on that ? [21:21:44] But it doesn't [21:22:18] It still did the same thing without returning a Status. [21:22:28] 10Tools-Global-user-contributions: Global user contributions - tool not working - https://phabricator.wikimedia.org/T152922#2863623 (10scfc) What do you mean by "basic user contributions correctly"? [21:22:41] Still asked for confirmation if I want to remove all publishers. [21:22:45] Georggi: there might be some test cases when things might not go as expected, and we do not want it to not to return anything [21:23:50] these things happen post deployment, and its a good enough practise to make functions return something [21:24:09] Georggi: if you cannot make the change. I can do that, and get it merged. [21:24:22] What do you mean by not return anything... It always returns an array, and if an array is empty it simply shows it No publishers instead of making userList [21:24:26] I can [21:25:12] I just don't understand why you say that it doesn't return anything then. [21:25:12] Georggi: when things are wrong, like when count( $publishersList ) === 0 , we do NOT want the code to even execute the next steps, just return! [21:25:45] ok, let me test something about if it does next code [21:25:50] wait 5 min [21:26:04] Georggi: think about it like this. as soon as count( $publishersList ) === 0 is met, we know things are wwrong - and we just want to STOP executing the funciton (saving some load) [21:26:09] Georggi: you got full day :) [21:26:33] No, I just don't want you to go too far [21:26:59] Georggi: heh. I will be around! [21:27:07] 10MediaWiki-Internationalization, 10MediaWiki-extensions-WikimediaIncubator, 06translatewiki.net, 07I18n, 07RTL: Wikimedia Incubator and translatewiki cannot set the rtl direction for N'Ko (nqo) language, probably because there's no MessagesNqo.php - https://phabricator.wikimedia.org/T152908#2863762 (10Ni... [21:35:48] (03CR) 10Legoktm: [C: 032] installer: Restore PHP 5.3 compatibility in index.php [core] - 10https://gerrit.wikimedia.org/r/326364 (owner: 10Bartosz Dziewoński) [21:36:37] 10Social-Tools, 07Documentation: Organize release notes of social tools extensions - https://phabricator.wikimedia.org/T152928#2863771 (10SamanthaNguyen) [21:39:19] (03Abandoned) 10Reedy: Use long array syntax on mw-config/index.php for better error msg [core] - 10https://gerrit.wikimedia.org/r/326357 (owner: 10Brian Wolff) [21:39:26] (03PS1) 10Reedy: installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/326368 [21:39:48] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons (CropTool gadget issue?) - https://phabricator.wikimedia.org/T152839#2863786 (10matmarex) 05Open>03Resolved a:03matmarex The CropTool gadget was definitely missing a dependency. Fixed: https://commons.wikimedia.org/w/index.php?title=Medi... [21:43:40] (03CR) 10Legoktm: [C: 032] installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/326368 (owner: 10Reedy) [21:43:51] (03PS1) 10Legoktm: installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/326369 [21:44:26] (03CR) 10Legoktm: [C: 032] installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/326369 (owner: 10Legoktm) [21:44:45] (03Merged) 10jenkins-bot: installer: Restore PHP 5.3 compatibility in index.php [core] - 10https://gerrit.wikimedia.org/r/326364 (owner: 10Bartosz Dziewoński) [21:53:04] tonythomas, Now that I looked into that, do Fatal Statuses in getPublishersFromJSONData are actually not shown to the screen? Thought that checking was done there, but it is done in NewsletterEditPage? [21:54:51] (03CR) 10jenkins-bot: [V: 04-1] installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/326369 (owner: 10Legoktm) [21:55:33] tonythomas, then, why there is that code in it at all, if EditPage handles checking that there are 0 publishers\publisher with a wrong name [21:57:00] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2863790 (10NovaHawk) Article feedback also seems unusable to me, with "[05d76a40] Database query error" coming up every time I try to mark something (although Vasko seems... [21:57:01] I would guess that it can only break if user was removed from database by hand. [21:58:20] (03Merged) 10jenkins-bot: installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/326368 (owner: 10Reedy) [21:58:23] (03CR) 10jenkins-bot: [V: 04-1] installer: Restore PHP 5.3 compatibility in index.php [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/326369 (owner: 10Legoktm) [21:58:28] And even then, checking if there are 0 publishers when SHOWING the page is for sure not needed there. [22:03:43] 04(no projects): WikiForum overwrites $wgCaptchaTriggers when adding a new permission - https://phabricator.wikimedia.org/T152929#2863797 (10labster) [22:04:08] 10Social-Tools, 10WikiForum: WikiForum overwrites $wgCaptchaTriggers when adding a new permission - https://phabricator.wikimedia.org/T152929#2863808 (10labster) [22:07:02] Hi [22:07:31] I'm doing the Google code-in challenge to create a gadget that shows the wikidata id of a page on the Romanian wikipedia [22:08:03] How exactly do I create a gadget? [22:10:26] Have you tried searching for mediawiki gadgets? [22:10:27] I read the wikimedia-dev documentation, but i'm still kind of lost [22:10:50] yes [22:12:52] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2863817 (10lcf119) I've been experiencing those errors with article feedback as well, but I didn't report them as I didn't see "database error" and as such didn't repor... [22:13:28] 06Discovery, 06Discovery-Search: Track progress of Ukrainian Analyzer in Lucene/Elastic - https://phabricator.wikimedia.org/T148051#2713412 (10Dchaplinsky) ElasticSearch 5.1.1 is out! Now with proper Ukrainian analyzer: https://www.elastic.co/guide/en/elasticsearch/reference/5.1/release-notes-5.1.1.html#featu... [22:20:04] 10AbuseFilter, 07I18n: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2863829 (10Huji) [22:20:06] 10AbuseFilter, 07Easy, 07I18n: GENDER parameter for AbuseFilter log should use the user, not the username - https://phabricator.wikimedia.org/T152873#2863827 (10Huji) 05Open>03declined p:05Triage>03Lowest [22:21:56] (03PS4) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) [22:23:44] Georggi: even that happens :) [22:23:58] when you are writing software, you have to think about every single thing! [22:24:02] tonythomas, yeah, writing a comment about one thing too [22:24:28] Don't approve\reject change just yet [22:25:44] (03CR) 10Georggi199: "Check that comment please." (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [22:25:57] tonythomas, ok, you can check a comment there^ [22:26:34] About removing part with checking if there is 0 publishers, it is not needed there for sure. [22:26:57] 06Brickimedia: Database error and/or MediaWiki exception occurs upon trying to edit on Brickipedia - https://phabricator.wikimedia.org/T152737#2863841 (10SamanthaNguyen) I believe we can all agree that we could consider (again) for looking at other options to improve our sever, aye? I believe @UltrasonicNXT (al... [22:27:04] That part with wrong publisher is kinda 1 in 10000 case I guess [22:27:06] Georggi: that might be exactly for " if user was added before and then removed somehow from database" ? [22:27:23] Georggi: where are you coming up with this numbers from ? [22:27:24] Well yeah, but then it has to be treated differently [22:27:32] it should just return at that point [22:27:37] please revert :-( [22:27:42] Wait [22:27:46] Just wait [22:28:03] Part with 0 publishers is not needed, is that clear? [22:28:21] It is checking when page is shown up, not edited, right? [22:28:24] Georggi: it is needed. Please do NOT remove it [22:29:02] When newsletter has 0 publishers, it just has to say that there are none, that's all [22:29:31] It's when it is edited that has to be thrown up, which it is in NewsletterEditPage.php... [22:31:21] About other part with wrong publisher name, again, this is only executed when page is shown up, not when editing it. So there it may stay, but then when this happens, it will show that there are 0 publishers. [22:32:39] Georggi: When the count( $publishersList ) == 0, if you remove that check, it would unnecessarily execute the rest of the function, right ? [22:32:41] So what I suggest, is either not add wrong user to an array of output of a function, or remove that publisher from publisher list of a page, or leave Status::newFatal, but you have to treat it differently [22:32:46] No [22:32:54] Or better to say [22:32:55] yes [22:32:58] And it has to [22:33:05] Georggi: it do not have to! [22:33:09] why should it ? [22:33:37] if its 0, just show the message 'newsletter-view-no-publishers', which its showing up perfectly now! [22:33:43] (happening in the else {} ) [22:33:53] Because it does it when it shows the page, when you like load it! And that message jsut asks if you are sure that you want to remove all publishers. But that has to be shown when editing, not when jsut showing the page! [22:34:46] NewsletterContent is unrelated to editing page, which is completely different class. [22:35:06] Is that clear? [22:36:24] Georggi: that function getPublishersFromJSONData() is called, when you are viewing a newsletter which has 0 publishers in there, you dont want to execute the rest of the function [22:36:45] Uhm, ok [22:36:48] Listen, please [22:37:10] Georggi: you can type. Lets see how this works out :D [22:38:48] When there are 0 publishers, that function just sends an empty array. After that an if statement with (count()) just checks if it has more than 0 publishers. [22:38:56] (03PS1) 10Huji: GENDER should be used for "triggered" in AbuseFilter log messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326371 (https://phabricator.wikimedia.org/T152872) [22:39:13] 10AbuseFilter, 07I18n, 13Patch-For-Review: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2863853 (10Huji) p:05Triage>03Low a:03Huji [22:39:34] That part of a code in getPublishersFromJSONData() which handles 0 publishers case is just unnecessary. [22:39:44] Georggi: "When there are 0 publishers, that function just sends an empty array." does that involve executing lines $publishers = []; and the rest ? [22:40:06] atlest PHP will have to go through it, creating a new $publishers = [] variable ? [22:40:34] Well, if publishers list is empty, then it won't go through foreach loop [22:40:53] will it create the variable $publishers = [], and execute an if condition check ? [22:41:05] and you are creating additional check for Status + additional conditinal check. [22:41:07] foreach actually executes an if condition [22:41:39] but if there are 0 publishers in argument, foreach won't be executed... [22:42:11] so it will jsut initialise an empty array and then immidiately return it [22:42:15] Georggi: only after PHP runs through 'foreach ( $publishersList as $publisherName ) {' will it know that that valuie of $publisherList was 0, and stop, right ? [22:42:42] How can it run through foreach loop, if $publishersList is empty? [22:43:18] Georggi: its like PHP reads that line of code, tries executing it - and finds out that bah - $publisherList is not an array ? [22:43:45] (not the actual running through the foreach loop, which cannot happen as in this case) [22:44:14] but it has to do that additional check. Just avoid that, and put that simple if condition on top, save the extra variable array and return [22:45:44] So you wanna say that it firstly runs through all foreach loop and only then thinks if it has anything in an array $publishersList(which is input array and in our case it has nothing in it) [22:47:18] runs through all foreach loop >> NO. It checks at the first line (which is the foreach declaration), and tries to check the variable which needs to be iterated, and finds it uniteratable - so quites [22:47:36] (03PS1) 10Dereckson: Convert legacy bugs ID to Phabricator tasks ID for Parser class [core] - 10https://gerrit.wikimedia.org/r/326372 [22:47:53] Even if so, ok then, but there is no need to return Status, and just make a check if( count ($publisherList) === 0) after initialising empty $publishers array and returning it inside if statement [22:48:25] But what is wrong for sure, is returning Status there. [22:48:40] >> after initialising empty $publishers array --> why would we even need that ? Save some variable space, man. [22:49:13] Ok, will $publisherList work then?(return an input argument?) [22:49:26] that will work too [22:49:38] Georggi: returning $publishersList ? [22:49:42] Yes [22:51:06] yeah. that might also work. [22:51:33] And like that you don't need a check for status(not counting that you don't have to create it) [22:51:54] But now about part with wrong publisher name [22:53:06] Georggi: so. please do that check well above, and return something (either the status with a check below, or return $publisherList) [22:53:07] If you return a Status there, it will just break that if(count(...)) statement in fillParserOutput(if to use your suggestion) and show the page like there are 0 publishers [22:54:00] Georggi: can you explain "it will just break " ?? [22:54:29] In your suggestion, you check if output is instance of Status. [22:54:39] So it will output Status [22:54:50] and think that there are 0 publishers and give out that message [22:56:04] In fact, the whole thing I see is copy-pasted from EditNewsletterPage, where it is used correctly. [22:56:07] 10Challenge, 10Social-Tools, 10SocialProfile: If SocialProfile is installed, then add a "challenge this user" link to the user profile - https://phabricator.wikimedia.org/T152930#2863856 (10SamanthaNguyen) [22:56:35] Georggi: >> "So it will output Status" -- what woudl ouput here status ? :o if its instance of status, the if( ) fails and it woudl go to the else {} [22:56:46] Yes [22:56:50] That's what I mean [22:57:30] Basically what I say that it has to be handled differently, or removed at all. [22:57:57] Georggi: can you explain "it will just break " ?? [22:57:57] One thing I suggest is to not include that publisher, it is not found. [22:58:03] Uhm? [22:58:23] like, is something going wrong (which I overlooked) ? [23:00:17] Yes, you said if statement will fail if Status is given and it will go to else {} [23:00:50] But message there is that there are 0 publishers, which at the very least is missleading, if Status was for wrong publisher name [23:01:22] Georggi: that makes sense. [23:03:11] So do you fine, if wrong publisher is just being ignored(at the end, it is jsut when page is shown up, so that message in newFatal() is also missleading) [23:04:23] That 'newsletter-manage-invalid-publisher' says that publisher is not a valid user and asks to enter valid input, when there are no input actually [23:04:29] 10Comments, 10Social-Tools, 07Performance: Potential query optimization on getComments - https://phabricator.wikimedia.org/T135367#2863872 (10ashley) Hi there and thanks for the patch! Please accept my apologies for not getting back to you sooner -- this is by no means a trivial patch and finding people who... [23:05:52] Georggi: lets fatal it there to show that something serious has happened inside ? [23:06:08] like someone forcefully edited the page content (since we are taking it from contenthandler) [23:06:41] You want to still use newFatal or what? [23:07:29] Georggi: yes please. You can just keep it there. There might be a test case when the newslettercontent gets changed, and we want to show up a fatal [23:08:14] Georggi: but even returning an empty list, like you proposed for getPublishersFromJSONData() makes sense too [23:08:47] Wait, but we are talking about the same function, it is all inside getPublishersFromJSONData() [23:08:57] 10AbuseFilter: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2863901 (10Huji) [23:09:14] 10AbuseFilter, 07I18n: Remove unused message from AbuseFilter i18n files - https://phabricator.wikimedia.org/T152933#2863913 (10Huji) p:05Triage>03Lowest a:03Huji [23:09:27] 04(no projects): Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152315#2863917 (10Dereckson) [23:09:29] 10MediaWiki-extensions-Scribunto, 15User-Dereckson: Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2863919 (10Dereckson) [23:10:03] Then if you remove checking that output of it is instanceof Status, then it will break and show that instance of countable was expected, Status given. [23:10:32] 10Wikimedia-Site-requests, 13Patch-For-Review: Enable the Translate extension on Wikimedia Norge's wiki - https://phabricator.wikimedia.org/T152490#2863920 (10Dereckson) p:05Triage>03Normal [23:10:37] 10Wikimedia-Site-requests, 13Patch-For-Review: Add prioritized languages to compact language links for nowiki - https://phabricator.wikimedia.org/T148021#2863921 (10Dereckson) p:05Triage>03Normal [23:10:44] Is it the best thing? I am not quite sure, the thing is there may be ok users in that list and there may be wrong ones [23:10:50] Georggi: so, pleaes cehck for instance of Status! :D [23:11:05] But then it will say no-publishers:) [23:11:20] heh. I see that :D [23:11:50] but I guess this status::newFatal gets logged somewhere (I dont know for sure), and later an admin might be able to find out that something is going wrong somewhere [23:11:53] Again, why not to just not add wrong username to output array? [23:12:16] But it doesn't need to be returned for that? [23:12:46] Georggi: that returning is to immediately stop execution! [23:13:15] and please update that comment '// Ask for confirmation before removing all the publishers' [23:15:08] Yes, but if you don't return, as you say, just create newFatal for that, and not return it and keep going through an array, which will result in: 1. Only proper publishers are shown; 2. If input contains wrong names, it will log new Fatal for each username, without breaking anything. [23:15:45] And then as you said, admin can go take in a log, and figure it out [23:16:12] But the message will have to be added too(this one is wrong anyways) [23:16:46] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863923 (10Theklan) Right now (from 00:05 to 00:15, trying to save new article [https://eu.wikipedia.org/w/index.php?title=Jos%C3%A9_Manuel_Otxotorena&action=submit])... just impossible. [23:17:03] Georggi: " you don't return, as you say, just create newFatal for that" >> Please return at that instant :D [23:17:34] But then it will show no-publishers, or just break the page? [23:17:53] Georggi: it would show no-publishers (considering the check we have downstairs :D) [23:17:58] anyway, I would allow you to explore. Its too late for me here. [23:17:59] (depending on what is if statement in fillParserOutput [23:18:27] Yeah, but the fact that there is wrong publisher doesn't mean there are none. [23:18:54] I mean, it doesn't mean there are no proper publishers. [23:19:56] Georggi: I would think about getting the correct message from the Status object, and maybe displaying [23:20:10] but it depends on what complicated message we want to show to the user, afterall [23:20:41] anyway. zzz. Maybe tomorrow I would wake up and see what all trash I had been speaking. Perks of Sunday night. [23:20:58] And show an error message instead of userList, that may work too [23:21:59] Georggi: true. feel free to take it forward [23:30:11] 10Phabricator, 06Labs, 06Operations, 10Tool-Labs, and 2 others: Install Arcanist in toollabs::dev_environ - https://phabricator.wikimedia.org/T139738#2863925 (10Dereckson) As there is a consensus to merge this right now and take care of Precise later if needed, this change has been scheduled to [[ https:/... [23:30:14] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863926 (10Theklan) After logging out, I could save the article as an anonymous IP. But after logging in again, the problem continues. [23:31:20] 10Wikimedia-Site-requests: Problems to save changes in eu.wikipedia - https://phabricator.wikimedia.org/T152897#2863927 (10Dereckson) Could you try disabling all gadgets? [23:32:46] (03PS1) 10Huji: Remove unused message from AbuseFilter i18n files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) [23:35:29] (03PS5) 10Huji: "Image size limit" text should always read left-to-right [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) [23:37:47] (03CR) 10Foxtrott: [C: 032] Consistently use tabs for indentation in composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/325529 (owner: 10Legoktm) [23:38:06] (03PS3) 10Foxtrott: Consistently use tabs for indentation in composer.json [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/325529 (owner: 10Legoktm) [23:42:11] (03PS5) 10Georggi199: Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) [23:43:21] 10Wikimedia-Site-requests, 13Patch-For-Review: Allow bureaucrats instead of sysops to add/remove users to/from interface editor group on ur.wikipedia - https://phabricator.wikimedia.org/T133564#2863935 (10Dereckson) p:05Low>03Normal [23:43:25] (03CR) 10jenkins-bot: [V: 04-1] Made sure publisher is listed, if there is only one [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [23:43:30] (03CR) 10Georggi199: "Haven't tested if it works(besides the fact that for it I have to manually edit the page somehow)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326325 (https://phabricator.wikimedia.org/T152668) (owner: 10Georggi199) [23:43:32] (03CR) 10jenkins-bot: [V: 04-1] Remove unused message from AbuseFilter i18n files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326375 (https://phabricator.wikimedia.org/T152933) (owner: 10Huji) [23:45:35] 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review: Change Marathi Wikiquote site title - https://phabricator.wikimedia.org/T136514#2863936 (10Dereckson) 05Open>03stalled [23:49:55] 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review: Change Marathi Wikiquote site title - https://phabricator.wikimedia.org/T136514#2337381 (10Dereckson) @Mahitgar I see you contributed on this wiki: would you have an opinion on this task? [23:59:31] 10Phabricator, 06Labs, 06Operations, 10Tool-Labs, and 2 others: Install Arcanist in toollabs::dev_environ - https://phabricator.wikimedia.org/T139738#2863940 (10Dereckson) p:05Triage>03Normal [23:59:46] 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review: Change Marathi Wikiquote site title - https://phabricator.wikimedia.org/T136514#2863942 (10Dereckson) p:05Triage>03Normal