[00:00:04] 10MobileFrontend, 06Reading-Web-Backlog: Varying layouts for commons mobile main page - https://phabricator.wikimedia.org/T151170#2861045 (10Tgr) [00:00:08] 10JA Backlog, 10Phlogiston: Phlogiston velocity charts should include quarterly summaries - https://phabricator.wikimedia.org/T152812#2861047 (10JAufrecht) [00:00:09] 10JA Backlog, 10Phlogiston: Phlogiston burnup for Collaboration is inflated - https://phabricator.wikimedia.org/T152811#2861048 (10JAufrecht) [00:00:18] 10JA Backlog: Clarify and refresh Joel's VE/Editing engagement goals - https://phabricator.wikimedia.org/T150698#2861052 (10JAufrecht) [00:00:22] 10JA Backlog, 10TPG-Essential-Functions, 06Team-Practices (This-Week): Lessons from 2016 Editing Offsite incorporated into TPG Offsites guide - https://phabricator.wikimedia.org/T149705#2861055 (10JAufrecht) [00:00:26] 10MobileFrontend, 06Reading-Web-Backlog: Varying layouts for commons mobile main page - https://phabricator.wikimedia.org/T151170#2809542 (10Tgr) [00:00:32] 06Reading-Infrastructure-Team, 06Reading-Web-Backlog, 10TemplateStyles, 10Wikimedia-Extension-setup: Deploy TemplateStyles to WMF production - https://phabricator.wikimedia.org/T133410#2231032 (10Tgr) [00:00:43] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2861065 (10srishakatux) Here are a few immediate action points for this task that I can start working on: - Create a wiki page that includes a brief overview of what th... [00:01:54] 10Phlogiston (Burnup-Support): Don't include Archived projects in reports - https://phabricator.wikimedia.org/T148800#2861070 (10JAufrecht) [00:01:56] 10Phlogiston (Burnup-Support): Recategorization configuration accepts inline wildcards - https://phabricator.wikimedia.org/T139812#2861071 (10JAufrecht) [00:01:58] 10Phlogiston (Burnup-Support): Create a Phlogiston Burnup chart that rolls up all the sub-categories on a board - https://phabricator.wikimedia.org/T133246#2861072 (10JAufrecht) [00:04:47] (03Draft1) 10Paladox: Fix submodules not auto updating [extensions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326201 (https://phabricator.wikimedia.org/T152663) [00:04:51] (03Draft2) 10Paladox: Fix submodules not auto updating [extensions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326201 (https://phabricator.wikimedia.org/T152663) [00:04:55] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2861081 (10Rfarrand) In addition to being a "hacking day" I think its fine to allow people just to chat, hang out, have meetings, or figure out what they are going to do... [00:05:03] 10TemplateStyles: Wrapping templatestyle tag in a noinclude was not intuitive. - https://phabricator.wikimedia.org/T135789#2311238 (10Tgr) The alternative would be that styles are transcluded to every page and processed there, which is more flexible (e.g. styles can depend on template parameters) but also more e... [00:06:06] (03PS3) 10Paladox: Remove superproject from All-Project [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326200 [00:06:33] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize an online event before dev summit to help participants form project teams for hackathon day: On Tuesday January 3rd, 2017 10am - 11:30am PST - https://phabricator.wikimedia.org/T150152#2861098 (10srishakatux) >>! In T150152#2859435, @... [00:07:42] (03CR) 10Chad: [V: 032 C: 032] Fix submodules not auto updating [extensions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326201 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [00:08:04] 10MediaWiki-extensions-Linter, 10Parsoid: Have Parsoid fix broken wikitext in tables - https://phabricator.wikimedia.org/T110694#2861110 (10Arlolra) [00:08:09] (03CR) 10Gergő Tisza: "I think apt-cache policy uses the local apt cache so the race condition is between the repo getting updated and apt-get update being run l" [vagrant] - 10https://gerrit.wikimedia.org/r/325908 (https://phabricator.wikimedia.org/T138608) (owner: 10Gergő Tisza) [00:09:13] 10MediaWiki-Internationalization, 06Language-Team, 05MW-1.29-release-notes, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5), 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Notices and Alerts on Wikipedia Arabic cannot be opened (TypeError: transformTable is undefined) - https://phabricator.wikimedia.org/T152800#2861112 (... [00:09:39] (03PS1) 10Chad: Updating config to drop obsolete rules [skins/webplatform] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326202 [00:10:13] (03CR) 10Chad: [V: 032 C: 032] Remove superproject from All-Project [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326200 (owner: 10Paladox) [00:12:02] (03CR) 10Chad: [V: 032 C: 032] Updating config to drop obsolete rules [skins/webplatform] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326202 (owner: 10Chad) [00:13:09] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2861123 (10kaldari) @jcrespo: OK, I've [[ https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20161212T1830 | scheduled... [00:13:40] 10JA Backlog, 10Phlogiston: Automate start and cutoff dates in Phlogiston configuration - https://phabricator.wikimedia.org/T152816#2861124 (10JAufrecht) [00:15:18] (03Abandoned) 10Reedy: Apply Ori's bandaid for API cluster fails [core] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324895 (https://phabricator.wikimedia.org/T151702) (owner: 10Reedy) [00:15:22] (03Draft1) 10Paladox: Testing submodules [skins/Example] - 10https://gerrit.wikimedia.org/r/326206 [00:15:26] (03Draft2) 10Paladox: Testing submodules [skins/Example] - 10https://gerrit.wikimedia.org/r/326206 [00:18:15] (03Draft1) 10Paladox: Fix submodules not auto updating [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326207 (https://phabricator.wikimedia.org/T152663) [00:18:21] (03Draft2) 10Paladox: Fix submodules not auto updating [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326207 (https://phabricator.wikimedia.org/T152663) [00:19:17] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize an online event before dev summit to help participants form project teams for hackathon day: On Tuesday January 3rd, 2017 10am - 11:30am PST - https://phabricator.wikimedia.org/T150152#2861143 (10srishakatux) @Rfarrand Sounds good! I... [00:19:21] (03CR) 10Chad: [V: 032 C: 032] Fix submodules not auto updating [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326207 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [00:19:27] (03PS1) 10Mooeypoo: RCFilters UI: Add 'remove' and 'restore defaults' to filter list [core] - 10https://gerrit.wikimedia.org/r/326208 (https://phabricator.wikimedia.org/T144448) [00:19:59] (03CR) 10Mooeypoo: [C: 032] Follow-up eed48aa7: remove unnecessary z-index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326196 (owner: 10Catrope) [00:20:07] (03CR) 10Chad: [C: 032] Testing submodules [skins/Example] - 10https://gerrit.wikimedia.org/r/326206 (owner: 10Paladox) [00:24:04] (03CR) 10MtDu: "recheck" [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326066 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [00:25:44] (03CR) 10Reedy: [C: 04-2] "So, I tried to do this in https://gerrit.wikimedia.org/r/#/c/324703/ but I changed the patch... (see the discussion there)" [core] - 10https://gerrit.wikimedia.org/r/326193 (owner: 10MtDu) [00:26:02] 10MediaWiki-ContentHandler, 05MW-1.28-release-notes, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Clean up ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T145728#2861147 (10Reedy) [00:26:05] 10MediaWiki-ContentHandler, 10MediaWiki-Export-or-Import: WikiRevision::getText() needs fixing up - https://phabricator.wikimedia.org/T152282#2861146 (10Reedy) [00:26:09] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize an online event before dev summit to help participants form project teams for hackathon day: On Tuesday January 3rd, 2017 10am - 11:30am PST - https://phabricator.wikimedia.org/T150152#2861148 (10Rfarrand) Would it be possible to hold... [00:26:50] (03PS3) 10Reedy: Update for API error i18n [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321438 (owner: 10Anomie) [00:27:01] (03CR) 10Reedy: [C: 032] Update for API error i18n [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321438 (owner: 10Anomie) [00:27:33] (03PS2) 10VolkerE: Remove superfluos mixins that are available in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/325506 [00:27:54] (03CR) 10jenkins-bot: [V: 04-1] RCFilters UI: Add 'remove' and 'restore defaults' to filter list [core] - 10https://gerrit.wikimedia.org/r/326208 (https://phabricator.wikimedia.org/T144448) (owner: 10Mooeypoo) [00:28:04] (03CR) 10VolkerE: Remove superfluos mixins that are available in core (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/325506 (owner: 10VolkerE) [00:29:18] (03Merged) 10jenkins-bot: Follow-up eed48aa7: remove unnecessary z-index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/326196 (owner: 10Catrope) [00:29:21] (03Merged) 10jenkins-bot: Testing submodules [skins/Example] - 10https://gerrit.wikimedia.org/r/326206 (owner: 10Paladox) [00:29:23] (03Merged) 10jenkins-bot: Update for API error i18n [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321438 (owner: 10Anomie) [00:30:00] (03CR) 10Reedy: [C: 04-1] "Code LGTM otherwise, just a bit of related cleanup that'd be nice to do whilst we're changing this code in this area :)" (032 comments) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [00:30:25] (03PS1) 10Catrope: Fix animation of notifications overlay drawer in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326209 [00:30:44] jdlrobson: Fun RTL bug with a one-character fix ---^^ [00:31:06] (03PS1) 10Chad: Touching .gitmodules [skins] - 10https://gerrit.wikimedia.org/r/326211 [00:31:17] (03CR) 10Chad: [V: 032 C: 032] Touching .gitmodules [skins] - 10https://gerrit.wikimedia.org/r/326211 (owner: 10Chad) [00:31:35] (03PS5) 10Reedy: Check whether IP is valid in ip_in_range() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/266595 (https://phabricator.wikimedia.org/T124117) (owner: 10MtDu) [00:34:37] (03Draft2) 10Chad: Edit Project Config [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326212 [00:35:31] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2861151 (10srishakatux) @Rfarrand Sounds good :) I will add your suggestions in the overview section of the wiki I plan to create! [00:36:09] 10MediaWiki-extensions-Linter, 10Parsoid: Implement WP:CHECKWIKI errors in Linter (tracking) - https://phabricator.wikimedia.org/T152817#2861152 (10Legoktm) [00:36:57] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Organize hackathon at the dev summit - https://phabricator.wikimedia.org/T152814#2861164 (10bd808) I have two different projects that I know I want to try and make time for at this hackathon, but this is a pretty radical departure from my "plans" for... [00:37:22] 10MediaWiki-extensions-Linter, 10Parsoid: Linter: Check for external link with no protocol (checkwiki #62) - https://phabricator.wikimedia.org/T152818#2861165 (10Legoktm) [00:38:31] (03Abandoned) 10Reedy: Replaced deprecated function Article::fetchContent() [extensions/OracleTextSearch] - 10https://gerrit.wikimedia.org/r/313401 (https://phabricator.wikimedia.org/T146199) (owner: 10Enigmaeth) [00:38:51] 10MediaWiki-ContentHandler, 05MW-1.28-release-notes, 13Patch-For-Review, 07Technical-Debt: Article::fetchContent() is deprecated - https://phabricator.wikimedia.org/T145734#2861183 (10Reedy) [00:38:54] 10MediaWiki-ContentHandler, 13Patch-For-Review, 07Technical-Debt: OracleTextSearch should not use Article::fetchContent() anymore - https://phabricator.wikimedia.org/T146199#2861180 (10Reedy) 05Open>03Resolved a:03FilipGCI https://gerrit.wikimedia.org/r/#/c/326167/ [00:39:36] (03Abandoned) 10Chad: Edit Project Config [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326212 (owner: 10Chad) [00:39:42] 10MediaWiki-extensions-Linter, 10Parsoid: Linter: Double pipe in a link (checkwiki #32) - https://phabricator.wikimedia.org/T152819#2861184 (10Legoktm) [00:40:43] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Blog post concluding the dev summit - https://phabricator.wikimedia.org/T152820#2861198 (10srishakatux) [00:40:57] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Blog post concluding the dev summit - https://phabricator.wikimedia.org/T152820#2861198 (10srishakatux) p:05Triage>03Low [00:41:19] anomie: I just realized that the new PageAssessments API that I made for retrieving a list of all the WikiProjects should probably be a siteinfo prop query rather than a regular prop query, since it's returning info about the wiki, not about pages. It doesn't looks like there are any hooks for adding siteinfo parameters though. Do you have any opinion on [00:41:19] what the best implementation would be? Context: https://www.mediawiki.org/wiki/Extension:PageAssessments#Projects and https://gerrit.wikimedia.org/r/#/c/322489/ . [00:41:34] 10TemplateStyles: TemplateStyles puts css in page_props table, which might be subject to race conditions, etc - https://phabricator.wikimedia.org/T136054#2321595 (10Tgr) On FlaggedRevs wikis the CSS from the stable version of the template needs to be shown on stable articles, which complicates the page_props app... [00:41:50] 10TemplateStyles: Wrapping templatestyle tag in a noinclude was not intuitive. - https://phabricator.wikimedia.org/T135789#2861214 (10Tgr) See also {T136054}. [00:42:34] 10MediaWiki-extensions-Linter, 10Parsoid: Linter: check for tags (checkwiki #4) - https://phabricator.wikimedia.org/T152821#2861216 (10Legoktm) [00:43:14] 06Reading-Infrastructure-Team, 06Reading-Web-Backlog, 10TemplateStyles, 10Wikimedia-Extension-setup: Deploy TemplateStyles to WMF production - https://phabricator.wikimedia.org/T133410#2861230 (10Tgr) [00:43:17] 10TemplateStyles: TemplateStyles puts css in page_props table, which might be subject to race conditions, etc - https://phabricator.wikimedia.org/T136054#2321595 (10Tgr) [00:49:25] (03CR) 10Gergő Tisza: [V: 032] "Thanks, Geoff! Feel free to submit the GCI task, I'll merge this when the CI issues are sorted out." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/326146 (https://phabricator.wikimedia.org/T58471) (owner: 10Sn1per) [00:49:37] 10MediaWiki-extensions-Linter, 10Parsoid: Crasher when linting a gallery - https://phabricator.wikimedia.org/T152785#2861231 (10Arlolra) p:05Triage>03High a:03Arlolra [00:51:21] 10MediaWiki-extensions-Linter: Linter: introduce severity level for error categories - https://phabricator.wikimedia.org/T152822#2861233 (10Legoktm) [00:54:42] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Post-Developer Summit communication plan - https://phabricator.wikimedia.org/T152823#2861247 (10srishakatux) [00:55:25] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Post-Developer Summit communication plan - https://phabricator.wikimedia.org/T152823#2861247 (10srishakatux) p:05Triage>03Low [00:56:16] 06Developer-Relations, 10Wikimedia-Developer-Summit (2017): Post-Developer Summit communication plan - https://phabricator.wikimedia.org/T152823#2861247 (10srishakatux) [00:56:22] 10MediaWiki-extensions-Linter: Linter: Include some information about the error and how to fix it when editing - https://phabricator.wikimedia.org/T152824#2861269 (10Legoktm) [00:57:14] 06Reading-Infrastructure-Team, 06Reading-Web-Backlog, 10TemplateStyles, 10Wikimedia-Extension-setup: Deploy TemplateStyles to WMF production - https://phabricator.wikimedia.org/T133410#2861283 (10Tgr) [00:57:16] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 13Patch-For-Review, 07Technical-Debt (RW-Tech-Debt): 3rd parties shouldn't be subjected to hacks.less - https://phabricator.wikimedia.org/T94102#2861282 (10Tgr) [00:57:42] 10MobileFrontend, 06Reading-Web-Backlog, 07Easy, 13Patch-For-Review, 07Technical-Debt (RW-Tech-Debt): 3rd parties shouldn't be subjected to hacks.less - https://phabricator.wikimedia.org/T94102#1155229 (10Tgr) This does not seem to be a blocker for deploying TemplateStyles, maybe the relationship was int... [00:58:38] (03Draft2) 10Paladox: Use all [skins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326216 [00:59:43] 10MediaWiki-Watchlist, 03Google-Code-In-2016: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2861286 (10Sn1per) a:03Sn1per [01:01:31] (03PS3) 10Mattflaschen: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) [01:01:47] (03CR) 10Mattflaschen: FlowFixInconsistentBoards: Don't output non-critical error info (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [01:01:58] OH-: oh sweet. :) [01:02:43] \o/ [01:03:02] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize an online event before dev summit to help participants form project teams for hackathon day: On Tuesday January 3rd, 2017 10am - 11:30am PST - https://phabricator.wikimedia.org/T150152#2861289 (10srishakatux) I think that 20 minutes w... [01:03:07] 10MediaWiki-Watchlist: Add confirmation to rollback button from watchlist page - https://phabricator.wikimedia.org/T149514#2754890 (10Legoktm) I'm fairly sure this is a duplicate... [01:03:55] 10MediaWiki-Watchlist: Add confirmation to rollback button from watchlist page - https://phabricator.wikimedia.org/T149514#2861294 (10Legoktm) Dupe of {T126798} which is probably a dupe of {T49782}. [01:04:44] OH-: ideally I'd like to get it merged before tuesday so it can go out next week before the freeze if you think that's reasonable [01:05:08] (03CR) 10Mattflaschen: "Also now reporting on both fixable and non-fixable." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [01:05:32] I'll try my best [01:07:28] (03PS1) 10Legoktm: Update Linter to master [extensions] - 10https://gerrit.wikimedia.org/r/326224 [01:07:41] (03CR) 10Legoktm: [V: 032 C: 032] Update Linter to master [extensions] - 10https://gerrit.wikimedia.org/r/326224 (owner: 10Legoktm) [01:08:24] (03PS1) 10Mattflaschen: Role for flagged revisions. You can use 'Reviewer' user to review [vagrant] - 10https://gerrit.wikimedia.org/r/326226 (https://phabricator.wikimedia.org/T152584) [01:08:38] (03PS1) 10EBernhardson: Fix typo: page_ids -> pageIds [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/326227 [01:09:26] (03PS2) 10Mattflaschen: Role for flagged revisions. You can use 'Reviewer' user to review [vagrant] - 10https://gerrit.wikimedia.org/r/326226 (https://phabricator.wikimedia.org/T152584) [01:09:51] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-87-♨️😭, 07Unplanned-Sprint-Work: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2861303 (10Jdlrobson) [01:10:06] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2861305 (10Jdlrobson) Any reason this didn't go through the QA column? We've already found 2 serious regressions which is disapp... [01:10:41] (03CR) 10Jdlrobson: [C: 032] Fix animation of notifications overlay drawer in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326209 (owner: 10Catrope) [01:11:36] (03CR) 10Jdlrobson: [C: 032] Remove superfluos mixins that are available in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/325506 (owner: 10VolkerE) [01:12:24] (03PS2) 10MtDu: Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) [01:14:11] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Organize an online event before dev summit to help participants form project teams for hackathon day: On Tuesday January 3rd, 2017 10am - 11:30am PST - https://phabricator.wikimedia.org/T150152#2861309 (10srishakatux) I missed one of your poin... [01:14:53] (03CR) 10jenkins-bot: [V: 04-1] Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [01:18:49] (03Merged) 10jenkins-bot: Fix animation of notifications overlay drawer in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/326209 (owner: 10Catrope) [01:20:55] Reedy: I changed from mTitle to getTitle and now tests are failing. There's a spacing error, but I can fix that after you take a lok. https://gerrit.wikimedia.org/r/#/c/325735/2 [01:22:02] MtDu: LGTM otherwise [01:22:22] So the space is all? [01:22:51] (03Merged) 10jenkins-bot: Remove superfluos mixins that are available in core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/325506 (owner: 10VolkerE) [01:23:16] MtDu: Nope.... Look at the other unit tests [01:23:22] 01:13:00 PHP Notice: Undefined property: WikiPage::$getTitle in /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/AdvancedMeta/AdvancedMeta.class.php on line 211 [01:23:34] getTitle is a function, not a member variable [01:23:41] then.. [01:23:42] 01:13:00 PHP Fatal error: Call to a member function getArticleID() on a non-object in /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/AdvancedMeta/AdvancedMeta.class.php on line 211 [01:23:45] Rip rekt [01:23:46] Sorry. [01:23:59] I forgot the parentheses. I'll fix that and the spacing. :p [01:24:20] (03CR) 10Reedy: [C: 04-1] Replaced deprecated hooks (031 comment) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [01:24:22] Yeah, haha [01:24:33] loooks like those missing () cause all the other errors [01:24:58] (03PS3) 10MtDu: Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) [01:25:09] Reedy, Yeah. Just realized. My bad. [01:25:53] (03CR) 10jenkins-bot: [V: 04-1] Replaced deprecated hooks [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/325735 (https://phabricator.wikimedia.org/T151973) (owner: 10MtDu) [01:31:01] legoktm, could I submit a little patch to move watchlist auto-reload config check from PHP to JS? [01:31:17] which check? [01:31:28] it's something I would need for both the watchlist "X" patch I had as well as this task [01:32:10] (03PS14) 10Kmuthu: Make mobile-friendly version of the Notifications page left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) [01:32:24] legoktm, https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialWatchlist.php#L427 [01:32:27] (03CR) 10jenkins-bot: [V: 04-1] Make mobile-friendly version of the Notifications page left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [01:32:57] presumably non-controversial and would make messing with the watchlist js module easier for everything [01:33:29] (03CR) 10EBernhardson: [C: 032] "thanks for fixing this!" [core] - 10https://gerrit.wikimedia.org/r/326176 (owner: 10Phantom42) [01:36:26] 01:25:31 [fdba201ac6d5cb132841835b] [no req] MWException from line 176 of /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/includes/Hooks.php: Invalid callback onPageContentSave in hooks for PageContentSave [01:38:33] wtf is up with it [01:39:27] 10MediaWiki-Watchlist, 03Google-Code-In-2016: Add a confirmation button to "Mark all pages as visited" on the Watchlist, and update via ajax - https://phabricator.wikimedia.org/T150045#2772468 (10MtDu) I would like to learn how this is done anyways, so I'll just keep up with this. :) [01:41:41] OH-: hmm, I think that should stay server-side so there's less processing client side? it'll be a little faster that way. [01:41:57] OH-: oh but if you're going to load the watchlist module unconditionally, *then* that makes sense. [01:42:01] I understand you now [01:42:09] (03PS3) 10Mattflaschen: Role for flagged revisions. You can use 'Reviewer' user to review [vagrant] - 10https://gerrit.wikimedia.org/r/326226 (https://phabricator.wikimedia.org/T152584) [01:44:11] (03Merged) 10jenkins-bot: Fix links problem on Special:Search [core] - 10https://gerrit.wikimedia.org/r/326176 (owner: 10Phantom42) [02:02:26] Phantom42: oops, I missed that when testing. Nice work on fixing :) [02:02:53] (03PS1) 10Sn1per: Move Special:Watchlist auto-reload check from PHP to JS [core] - 10https://gerrit.wikimedia.org/r/326233 (https://phabricator.wikimedia.org/T150045) [02:05:25] (03CR) 10Legoktm: [C: 04-1] "You'll need a dependency upon 'user.options' now." [core] - 10https://gerrit.wikimedia.org/r/326233 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [02:05:53] derp [02:09:45] (03PS2) 10Sn1per: Move Special:Watchlist auto-reload check from PHP to JS [core] - 10https://gerrit.wikimedia.org/r/326233 (https://phabricator.wikimedia.org/T150045) [02:11:15] 10Mobile-Content-Service: MCS endpoints should be consistent with other endpoints - https://phabricator.wikimedia.org/T152825#2861325 (10Jdlrobson) [02:13:37] 10MediaWiki-extensions-GuidedTour, 10Wikimedia Resource Center, 10Wikimedia-Site-requests: Install GuidedTour extension on Meta - https://phabricator.wikimedia.org/T152656#2861337 (10Mattflaschen-WMF) [02:15:10] 10MediaWiki-extensions-GuidedTour, 10Wikimedia Resource Center, 10Wikimedia-Site-requests: Install GuidedTour extension on Meta - https://phabricator.wikimedia.org/T152656#2856233 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [02:20:24] 10MobileFrontend-Feature-requests, 10Wikimedia-Site-requests: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2861342 (10Ibrahim.ID) [02:21:03] (03Draft1) 10Paladox: Enable submodule in this skin [skins/Example] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326237 [02:21:05] (03Draft2) 10Paladox: Enable submodule in this skin [skins/Example] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/326237 [02:22:21] (03PS1) 10Gergő Tisza: Do not disable footer feature when BetaFeatures is not installed [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326238 [02:35:18] (03PS1) 10Jforrester: Manually update submodules to master [extensions] - 10https://gerrit.wikimedia.org/r/326239 [02:36:17] (03CR) 10Legoktm: [V: 032 C: 032] Manually update submodules to master [extensions] - 10https://gerrit.wikimedia.org/r/326239 (owner: 10Jforrester) [02:36:33] Thanks legoktm. [02:36:35] James_F: did you automate that? [02:36:45] There's already scripts to do it? [02:37:00] None of them seemed to work, so I just `git submodule foreach git pull origin master && git add -p`ed. [02:37:28] sync-with-gerrit.py WFM before [02:37:28] Which script is the one you're meant to use? [02:37:44] that just adds new submodules right...? [02:37:48] Yeah. [02:38:02] Or is that update-extensions.sh? [02:38:09] there's too many scripts in that dir [02:38:22] With different names. [02:38:36] And no README. [02:39:58] I ran `sort-gitmodules.py` and got an awful mess, for instance, had to totally reset the clone. [02:44:31] legoktm: I ran a recheck after the other patch to remove the unused message was merged. https://gerrit.wikimedia.org/r/326066 [02:46:29] 06Editing-Analysis: Update editor month table and metrics reports for November 2016 - https://phabricator.wikimedia.org/T152431#2861360 (10Neil_P._Quinn_WMF) 05Open>03Resolved a:03Neil_P._Quinn_WMF In addition to the code changes and recalculations, I also added second-month active editors as a key metric.... [03:01:00] 10MediaWiki-API, 10VisualEditor, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): [Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together." - https://phabricator.wikimedia.org/T152547#2861363 (10Jdforrester-WMF) 05Open>03Resolved p:0... [03:03:20] 10MediaWiki-extensions-GuidedTour: Enable GuidedTour on all wikis - https://phabricator.wikimedia.org/T152827#2861371 (10Mattflaschen-WMF) [03:08:42] 10MediaWiki-Vagrant, 06Reading-Infrastructure-Team, 06Reading-Web-Backlog: Add vagrant roles for extensions maintained by WMF Reading - https://phabricator.wikimedia.org/T152036#2861383 (10Tgr) Some of these extensions could use a documentation refresh. The QuickSurvey docs on how to actually a survey are to... [03:08:54] (03PS1) 10Gergő Tisza: Update Reading Web roles [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) [03:12:24] (03PS1) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [03:12:27] (03PS2) 10Gergő Tisza: Update Reading Web roles [vagrant] - 10https://gerrit.wikimedia.org/r/326241 (https://phabricator.wikimedia.org/T152036) [03:14:11] 10RelatedArticles: RelatedArticles should not depend on EventLogging - https://phabricator.wikimedia.org/T152828#2861388 (10Tgr) [03:35:25] OH-: In order to test that, what would I need to do? [03:35:45] You have mediawiki-vagrant set up, yes? [03:36:02] OH-: How big is the dialog, because if it's small, the 'watchlist-mark-all-visited' message seems a bit long. But it is a dialog, so it's probably ok. Do you have a screenshot I could see? [03:36:18] OH-: Yes, but I'm not on a machine that has it. I can look when I get home. [03:37:51] MtDu, https://i.imgur.com/RbkWUfs.png on a 1080p monitor [03:38:21] So what I did was I created User:Admin while logged in as Admin, so User:Admin should be on your watchlist [03:38:38] then using an incognito window I edited user:Admin as an IP editor so that those edits would go onto the watchlist [03:39:02] if you refresh the watchlist as the Admin user you will see new entries in bold (indicating they are edits since you last visited the page) [03:39:13] OH-: Gotcha. I'll definitely ask more questions about the code as I read it. :) [03:39:24] clicking the button and the dialog etc. should cause the entries to turn un-bold (and when you refresh they shouldn't be marked as new anymore) [03:43:17] OH-: Does this line $watchlistReset = $( '#mw-watchlist-resetbutton' ); automatically create a button? Or is it just selecting the elemtn with that id? [03:43:51] It selects the existing button that resets the watchlist [03:44:01] so we can override its functionality with the dialog etc. [03:44:48] OH-: Ok, yeah that makes sense. And it has id mw-watchlist-resetbutton? [03:45:40] Yep. it's added in the PHP source here if you're interested https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialWatchlist.php#L611 [03:46:38] OH-: Yeah, I saw that earlier, but I got confused because it said form. How do you know it's a button? [03:48:00] Nevermind. I see submitbutton after. [03:48:53] yeah, to override existing functionality we override the submission of the form element, not the button by itself [03:49:59] OH-: Yeah, and then you call the JQuery method preventDefault. [03:50:10] Nice job. I'm still reading through. :) [04:00:51] legoktm, just wondering, what does infusable mean? [04:02:15] (03CR) 10Catrope: [C: 032] FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [04:02:54] legoktm, Also, I'm reading through https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/OO.ui.WindowManager. How do I know what paraemters I can pass through openWindow()? For example, title, message, etc.? [04:04:42] OH-: Why do you have action 'reject' and action 'reset'? Those don't seem usual actions. I don't quite understand that. [04:09:23] MtDu, those action names are just IDs for the later code to know which option was chosen [04:09:48] I just reused the same ones from the original user script: 'reject' means the user rejected the window and canceled, 'reset' means the user wanted to reset their watchlist [04:11:24] OH-: Why don't we use 'safe' and 'destructive' flags for 'reject' and 'primary' and 'constructive' flags for 'reset'? If a user wants to reset the watchlist and they click on it, shouldn't we mark the reset as progressive and the reject as destructive? [04:11:41] Since if they click on it, they probably want to reset? [04:13:12] (03CR) 10MtDu: Mark pages on watchlist as visited using JS without reload (032 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [04:13:26] OH-: Thanks for explaining it. I'll see you later. [04:13:32] legoktm: Please take a look when you get a chance. :) [04:13:44] don't quote me on this but I thought the 'destructive' flag meant the option destroyed data ..... nevermind [04:14:27] (03Merged) 10jenkins-bot: FlowFixInconsistentBoards: Don't output non-critical error info [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325730 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [04:14:49] OH-: can you post an updated screenshot on gerrit when you get a chance trying the flags I recommended? I just want to see. [04:15:15] oh, you're still here [04:15:22] I referred to https://www.mediawiki.org/wiki/OOjs_UI/Widgets/Buttons_and_Switches [04:15:25] OH-: also, how do you know what you can pass into window.open? You pass in title and message etc. But when I look on the docs I don't see any. [04:16:38] OH-: I see your point on the data destruction now. Hm. I guess legoktm will give his opinion. [04:16:49] OH-: phones about to die. [04:16:53] MtDu_, the options passed into window.open [04:16:54] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/OO.ui.MessageDialog [04:17:01] Look under "instance properties" [04:17:08] the open method just passes the 'data" there [04:17:54] the data object given to the openWindow method defines the properties that are used to create the dialog [04:18:12] So you would look into what props you can use for your desired dialog [04:45:24] 10MediaWiki-Logging: Feature Request: Move log - https://phabricator.wikimedia.org/T152829#2861414 (10Xaosflux) [04:45:44] 10MediaWiki-Logging: Feature Request: Move log enhancement - https://phabricator.wikimedia.org/T152829#2861426 (10Xaosflux) [04:46:32] 10MediaWiki-Logging: Feature Request: Move log enhancement - https://phabricator.wikimedia.org/T152829#2861414 (10Xaosflux) [04:49:47] 10MediaWiki-Logging: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861428 (10Xaosflux) [04:50:00] 10MediaWiki-Logging: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861441 (10Xaosflux) Possibly related to T152829 [04:50:32] 10MediaWiki-Logging: Feature Request: Move log enhancement - https://phabricator.wikimedia.org/T152829#2861414 (10Xaosflux) Possibly related to T152830 [04:50:46] 10MediaWiki-Logging: Feature Request: Move log enhancement - https://phabricator.wikimedia.org/T152829#2861447 (10Xaosflux) Possibly related to T40123 [04:53:22] 10MediaWiki-Logging: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861449 (10Xaosflux) See some discussion here: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=753982438#Easy_way_to_spot_user_renames.3F [04:55:28] 10MediaWiki-Database: DatabaseSqlite / Error in BEGIN query: There is already an active transaction - https://phabricator.wikimedia.org/T88312#1009052 (10DBeidle) I have a wiki, based on mediawiki-1.26.2, that I use as a personal knowledge base for the various projects I have worked on. Access is limited to the... [04:58:53] (03CR) 10Legoktm: [C: 04-1] Mark pages on watchlist as visited using JS without reload (032 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [05:00:00] legoktm, Could you explain the use of a token in general, and how it applies to the patch above? ^ [05:07:21] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861454 (10Legoktm) So...basically the "previous name" field on https://meta.wikimedia.org/wiki/Special:Log/gblrename but for local rename logs? [05:07:51] MtDu: yeah, one sec [05:08:15] MtDu: https://www.mediawiki.org/wiki/Cross-site_request_forgery [05:09:17] legoktm, gotcha. So just a security precaution that's super important. [05:09:49] well, necessity, not precaution :) [05:10:06] legoktm, Are you busy atm? [05:10:27] I'm busy reviewing your patch :P [05:11:50] legoktm, Oh. Thanks. :) [05:13:46] 10MediaWiki-extensions-SmiteSpam: SmiteSpam has lots of HTML messages - https://phabricator.wikimedia.org/T152831#2861456 (10Legoktm) [05:14:42] (03CR) 10Legoktm: [C: 032] Replace Linker::link*() usage with LinkRenderer [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326066 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [05:15:00] legoktm, now, I guess I can fix that above. :) [05:15:16] legoktm, Could you explain the difference between wfMessage and $this->msg? [05:15:52] (03Merged) 10jenkins-bot: Replace Linker::link*() usage with LinkRenderer [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326066 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [05:16:27] uh, did you not submit it in GCI? [05:16:42] legoktm, Sorry, will do now. [05:16:53] well I just can't approve it until you do :P [05:17:23] legoktm, yeah. My bad. [05:18:27] legoktm, Done. [05:18:27] wfMessage is a global function, so to figure out the title and language used to parse, it has to use the global objects $wgLang and $wgTitle. While $this->msg will use the language from $this->getLanguage() and $this->getTitle() [05:18:57] So $this->msg is better when you can use it. [05:19:18] We don't like using global objects because you can't modify them if you have a legit use case, and you have to resort to ugly hacks [05:19:20] yes [05:19:46] legoktm, So pretty much everything in the special pages for SmiteSpam should be switched to $this->msg? [05:20:01] https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/includes/job/MassMessageJob.php#L280 <-- super ugly [05:20:05] legoktm, And what did you mean by the task you created for HTML messages? [05:20:07] yep [05:20:28] legoktm, Should I go ahead and do that? [05:21:50] well so there are different message output formats right? ->text() just does GENDER/PLURAL expansions, but doesn't process wikitext. ->escaped() will just apply htmlspecialchars() to ->text(), and ->parse() process the wikitext. So if a message is going to be treated as HTML, it should either be escaped or parse. text is for when whatever is going to be escaped by something else, OR going into wikitext [05:22:34] legoktm, So that also needs to be fixed. Gotcha. So essentially, whenever you're message goes inside html tags, you want to escape it first? [05:22:37] MtDu: yeah, let me create a GCI task for you [05:22:48] (03PS2) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [05:24:05] legoktm, Oh thanks. Are you an org admin this year? [05:25:26] nope, just a mentor [05:25:41] andre__: around? could you publish https://codein.withgoogle.com/dashboard/tasks/5146004766588928/ for me and MtDu? [05:28:24] legoktm: Is the phabricator task for it the one above? Or did you create another one? I can go ahead and get started right? [05:28:40] I didn't create a phab task for wfMessage->$this->msg [05:28:45] but that's what the GCI task is for [05:28:49] feel free to start on it [05:28:59] (just don't claim any other tasks in the meantime) [05:30:26] legoktm: Ok. Could you explain what difference between parse and escaped is? The messages API Documentation says parse sanitizes it in addition. What does that mean? [05:34:55] MtDu, parse runs it thru the wikitext parser [05:35:11] so you can put in things like [[wikitext|links]] and it will convert them into HTML [05:37:57] (03PS1) 10MtDu: Escape raw HTML messages in SmiteSpam SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326243 (https://phabricator.wikimedia.org/T152831) [05:48:52] (03PS4) 10Subins2000: Block API - Allow blocking/unblocking using userid [core] - 10https://gerrit.wikimedia.org/r/325802 (https://phabricator.wikimedia.org/T34496) [05:57:18] I have been in this task for the past 3 days. Can someone please review this (hopefully) last patch and review it : https://gerrit.wikimedia.org/r/325802 [05:59:46] 10Wikimedia-Site-requests: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2861476 (10Urbanecm) Please provide a link to that discussion. [06:06:42] (03CR) 10Niedzielski: "Looks Jenkins missed some folks. Ima add" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325819 (owner: 10Dbrant) [06:10:02] Hey andre__ : Can you please review this task ? :) [06:10:04] https://codein.withgoogle.com/dashboard/task-instances/5318682349666304/ [06:21:02] 10MediaWiki-Database, 10DBA, 06Operations: db1028 increased lag after extensions/CentralAuth/maintenance/populateLocalAndGlobalIds.php - https://phabricator.wikimedia.org/T152761#2861482 (10Marostegui) ok - I have downtimed db1028 from Monday 12th Dec starting at 18:30:00 UTC until Tuesday 13th finishing at... [06:47:40] Hey, I'm a GCI student [06:48:17] can someone please review this ? : https://gerrit.wikimedia.org/r/#/c/325802/ https://codein.withgoogle.com/dashboard/task-instances/5318682349666304/ [06:48:28] ^ I've been waiting for 3 days :( [06:48:43] I'm free today and would like to work on another exciting new task [06:51:51] subins2000: Please be patient. Mentors live in different time zones and also have lives. Just post a comment on the gerrit patch and leave your mentor a comment. :) [06:52:39] It's just a minor change and wouldn't take 5 minutes to review it. [06:52:51] I guess I have to wait :( [06:53:34] subins2000: I understand and definitely know how it feels. But it'll be ok. :) [07:03:50] MtDu: :) [07:26:54] (03PS1) 10Aaron Schulz: Back off from job types longer for DB read-only errors [core] - 10https://gerrit.wikimedia.org/r/326244 [07:41:22] 10MediaWiki-API, 06Operations, 10Parsoid, 10RESTBase, and 6 others: HHVM request timeouts not working; support lowering the API request timeout per request - https://phabricator.wikimedia.org/T97192#2861483 (10Joe) Just for the record, the reason requests piled up in T151702 is because of a low-level deadl... [07:48:52] hi [07:49:56] hi [07:51:40] hi [07:53:22] matthiasmullie : hi [07:54:12] i am from gci [07:55:56] anyone there [07:57:10] its a bit boring staying 1 hour on irc [07:58:44] raghav1, hi. [07:58:52] hi [07:59:19] dargasia : are you a mentor [08:02:30] hi [08:04:32] hi [08:06:04] halfak, it's late, go home ;) [08:07:31] dargasia : where you from [08:08:23] :P Am traveling [08:08:23] Late becomes relative ^_^ [08:12:04] @seen jayvdb [08:12:04] dargasia: Last time I saw jayvdb they were quitting the network with reason: Remote host closed the connection N/A at 12/10/2016 12:08:32 AM (8h3m32s ago) [08:12:36] 10MediaWiki-extensions-Lingo: Lingo and VisualEditor compatibility: HTTP 401 errors - https://phabricator.wikimedia.org/T135551#2861489 (10Dan.mulholland) 05Open>03Resolved Closing to be nice and tidy. [08:12:38] Ugh, time difference sucks [08:13:09] are you a mentor [08:13:23] Nope. [08:13:40] where you from [08:14:31] That's not the best pickup line ^. [08:14:50] i know [08:15:11] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Site-requests: Enable GuidedTour on all wikis - https://phabricator.wikimedia.org/T152827#2861491 (10Peachey88) [08:16:33] 10MediaWiki-extensions-GuidedTour, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Enable GuidedTour on all wikis - https://phabricator.wikimedia.org/T152827#2861493 (10Urbanecm) [08:16:50] @seen dargasia [08:16:50] raghav1: dargasia is in here, right now [08:17:48] @seen andre__ [08:17:48] raghav1: andre__ is in here, right now [08:20:10] @seen wm-bot [08:20:10] raghav1: I am right here [08:23:50] @seen wikibugs [08:23:50] raghav1: wikibugs is in here, right now [08:24:18] @seen dstrine [08:24:19] raghav1: dstrine is in here, right now [08:26:01] hi [08:26:21] raghav1, you can't just look up everyone when you're actually not looking for them, just sayin [08:26:57] ok [08:30:17] hi [08:34:50] hi [08:35:11] where you from [08:39:13] @seen victorbarbu [08:39:13] raghav1: victorbarbu is in here, right now [08:42:23] hi [08:48:01] hi [08:48:37] (03PS2) 10Filip: Removed deprecated "Article::fetchContent()" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/326160 (https://phabricator.wikimedia.org/T151973) [08:51:09] 10MediaWiki-General-or-Unknown: Allow template editors (or interface editors) use LESS instead of CSS - https://phabricator.wikimedia.org/T152832#2861505 (10Tgr) [08:54:54] (03PS3) 10Filip: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) [08:58:37] (03PS4) 10Filip: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) [09:04:25] 10Wikimedia-Site-requests: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2861521 (10Urbanecm) There is another problem. The wmgMFEnableSiteNotice property isn't in the file now... I can't find something similar. [09:10:05] hi everyone [09:16:10] i am not able to solve the problem of extension in my PC [09:16:26] should i redownload it [09:19:08] Guneet, what problem? [09:20:28] (03CR) 10Esanders: "@fomafix: the no-alert is only enabled in the next version of eslint-config-wikimedia, so the globals are currently not required." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/326121 (owner: 10Esanders) [09:22:33] i am doing a task of GCI [09:22:57] in wich i have install vagrant [09:23:08] (03CR) 10Fomafix: [C: 04-1] Mark pages on watchlist as visited using JS without reload (031 comment) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [09:23:37] and take screen shot of the extension and ypload on wikimedia commons [09:24:02] now i installed vagrant succesfully [09:24:23] but i am not able to view the extension [09:24:31] in my browser [09:24:41] what to do [09:24:57] should i redownload the extesion [09:25:06] extension [09:26:12] in the link-"https://www.mediawiki.org/wiki/Extension:ParserFunctions" [09:27:07] it says "Download and place the file(s) in a directory called ParserFunctions in your extensions/ folder." [09:27:43] which file or which extension [09:28:02] extesions/folder [09:29:49] dargasia [09:29:54] you there [09:38:21] Guneet: So you should extract the tarball that you download into the extensions folder so you have a subfolder (eg: extensions/ParserFunctions) [09:38:50] but just fyi, ParserFunctions doesn't really have any interfaces that you can take a snapshot of [09:39:15] where is extension folder [09:39:43] then which one should i choose [09:40:08] Guneet: if you have installed vagrant, you can enable extensions using the "enable roles" command [09:40:18] the actual code should already be in there [09:40:43] in /vagrant/mediawiki/extensions/ParserFunctions I think [09:43:40] the command "enable roles" didn't work [09:44:38] Guneet: what output did it give you? [09:45:49] -bash: enable: roles: not a shell builtin [09:45:57] this is what it said [09:49:02] should i reinsntall vagrant [09:50:10] (03Abandoned) 1001tonythomas: Newsletter name removed from NewsletterContent.php [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326147 (owner: 10Borisfba) [09:54:32] p858snake|L2 you there [09:55:55] gunet: I don't use vagrant myself (as I don't code), but providing copies of error messages is always helpful for when someone is around that does [09:59:31] 10MediaWiki-extensions-Newsletter: Fatal error on Newsletter creation, possibly after Linker change - https://phabricator.wikimedia.org/T152833#2861527 (1001tonythomas) [10:00:06] (03CR) 1001tonythomas: [C: 04-1] "I cant test this right now due to https://phabricator.wikimedia.org/T152833" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326142 (owner: 10Borisfba) [10:27:46] legoktm, MtDu: published [10:29:19] subins2000: I cannot, as it's out of my skill set. [10:30:32] (03PS1) 1001tonythomas: Decode values correctly on Newsletter content fixing fatal [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326249 (https://phabricator.wikimedia.org/T152833) [10:31:05] (03CR) 1001tonythomas: [C: 032] "Fix everythign :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326249 (https://phabricator.wikimedia.org/T152833) (owner: 1001tonythomas) [10:32:37] (03Merged) 10jenkins-bot: Decode values correctly on Newsletter content fixing fatal [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326249 (https://phabricator.wikimedia.org/T152833) (owner: 1001tonythomas) [10:32:48] tada! [10:33:56] (03PS1) 10Ladsgroup: Some more invisible adjustments to Wikimedia color palette. [core] - 10https://gerrit.wikimedia.org/r/326250 (https://phabricator.wikimedia.org/T152025) [10:34:14] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Fatal error on Newsletter creation, possibly after Linker change - https://phabricator.wikimedia.org/T152833#2861544 (1001tonythomas) a:0301tonythomas Fixed! [10:34:22] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Fatal error on Newsletter creation, possibly after Linker change - https://phabricator.wikimedia.org/T152833#2861546 (1001tonythomas) 05Open>03Resolved [10:35:08] (03PS4) 1001tonythomas: 'newsletter-view-name' removed [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326142 (owner: 10Borisfba) [10:35:19] andre [10:35:40] i am still not able to view the extension [10:36:00] andre__ have a look [10:36:10] at the problem [10:36:44] (03CR) 1001tonythomas: [C: 032] "Works! LGTM" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326142 (owner: 10Borisfba) [10:37:05] guneet: are you in vagrant shell ? [10:37:37] what vagrant shell [10:37:56] guneet: Guneet> the command "enable roles" didn't work [10:38:11] (03Merged) 10jenkins-bot: 'newsletter-view-name' removed [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/326142 (owner: 10Borisfba) [10:38:20] no it didn't [10:38:42] guneet: where are you executing that command ? [10:38:53] in vagrant [10:39:14] guneet: so are you in the vagrant command shell ? (like after vagrant ssh) ? [10:39:33] yes i think so [10:40:59] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Improve Newsletter detail page - https://phabricator.wikimedia.org/T152666#2861547 (1001tonythomas) 05Open>03Resolved Fixed in https://gerrit.wikimedia.org/r/#/c/326142 [10:41:02] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Design feedback on the Newsletter extension - https://phabricator.wikimedia.org/T116353#2861549 (1001tonythomas) [10:41:22] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Improve Newsletter detail page - https://phabricator.wikimedia.org/T152666#2861550 (1001tonythomas) I couldnt find the right owner here in phab, though! [10:41:26] guneet: and what is the error message you get ? [10:42:28] -bash enabel: roles: not shell buitin [10:43:15] ebabel ? :o [10:43:36] enable [10:44:30] can you run ./setup.sh [10:44:39] wait [10:45:23] should i run it in git bash [10:45:31] or vagrant [10:45:37] guneet: inside vagrant [10:45:46] to be clear, please run $ vagrant roles list [10:45:46] first [10:46:34] -bash ./setup.sh: No such file directory exists [10:46:58] there is no exists [10:47:10] its just till directory [10:47:28] guneet: tonythomas> to be clear, please run $ vagrant roles list [10:49:29] * tonythomas is sorry, I got to go. You can find the rest of things here https://www.mediawiki.org/wiki/MediaWiki-Vagrant or ask in #mediawiki-labs [10:49:58] the program 'vagrant' is currently not installed. to run 'vagrant' please ask administrator to install the package 'vagrant' [10:50:35] (03CR) 10Mobrovac: [C: 04-1] "LGTM but needs Jenkins support" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/326169 (owner: 10Ppchelko) [10:53:01] this is the comment [10:53:26] so is there any problem in installation [11:12:02] guneet: it's hard to follow what you did or not. Feel free to post the complete output of your terminal session to pastebin.com or such [11:16:17] (03PS1) 10Mobrovac: Config: Lower min_edits in BetaCluster to 2 [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/326251 [11:16:33] (03CR) 10Mobrovac: [V: 032 C: 032] Config: Lower min_edits in BetaCluster to 2 [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/326251 (owner: 10Mobrovac) [11:24:22] i opened my virtual machine and started vagrant [11:24:34] entered the login and password [11:25:14] and then went to the link http://127.0.0.1:8080/ [11:25:40] and it said 503 service unavialable [11:26:03] also [11:26:04] The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later. [11:26:06] this [11:26:43] then i downloaded the extension again and extracted it [11:26:59] the problem is where do i keep it [11:27:23] and later refreshed the page [11:27:44] but there was no change [11:27:52] thats it [11:28:01] till now [11:28:21] and i tried the commands suggested to me [11:28:38] which din't come to be handy [11:31:03] guneet: Please post the complete output of your terminal session to pastebin.com or such [11:31:10] and then tell us where to look at them. Thanks! [11:31:31] also, please check the log file of your webserver software. [11:34:36] wheree is thelog file [11:36:06] Reedy: Are you there? [11:37:15] what are the new ideas for GsOc 2017 ? [11:37:40] *any one ? [11:37:52] Niharika: Are you around? [11:37:59] yes [11:38:17] i wish to work for wikimedia [11:38:41] sdsa: see https://www.mediawiki.org/wiki/Google_Summer_of_Code_2017 [11:38:50] guneet: I guess you run Apache HTTPD as webserver software? [11:38:55] thanks [11:39:08] guneet: If so, see https://httpd.apache.org/docs/1.3/logs.html [11:39:28] guneet: uh wait, make that https://httpd.apache.org/docs/2.4/logs.html instead [11:40:07] what all should i be knowing to work fine with projects ? [11:40:12] andre__: If vagrant is not working for him, He may try install LAMP + mediawiki? [11:40:13] @andre [11:40:45] rlot2_: I've lost overview whether guneet uses Vagrant or not [11:40:57] guneet, that link above is the first result when entering ""apache httpd" "error log" "access log"" in an internet search engine. Anyone can do that too. [11:41:25] Oh, ok [11:41:44] sdsa: did you click any of the links on that page? [11:41:53] sdsa: because they might cover that. [11:42:18] yeah [11:42:49] sdsa: plus http://write.flossmanuals.net/gsocstudentguide/what-is-google-summer-of-code/ in general. [11:42:56] @seen Niharika [11:42:56] rlot2_: Niharika is in here, right now [11:43:02] thanks andre [11:43:22] or ist andrew [11:44:23] My nick is andre__ :) [11:44:42] @seen Reedy [11:44:42] rlot2_: Reedy is in here, right now [11:47:23] 10MediaWiki-Redirects: #REDIRECT - https://phabricator.wikimedia.org/T152807#2861554 (10Aklapper) Please provide an exact example of the problem, and please see https://mediawiki.org/wiki/How_to_report_a_bug for how to structure your bug report. Thanks! [11:55:24] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861555 (10Paladox) [11:58:50] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861569 (10Paladox) [11:59:25] (03CR) 10Legoktm: [C: 04-1] Mark pages on watchlist as visited using JS without reload (032 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [12:04:17] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861570 (10Aklapper) Works for me - 4th item is Phabricator. If it's not for you, please provide a screenshot of that area. [12:06:44] (03PS4) 10Matěj Suchánek: Check whether user is allowed to see the hit count [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/321370 (https://phabricator.wikimedia.org/T120562) [12:09:26] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861573 (10Paladox) Hi heres a screenshot {F5023986} [12:10:47] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861574 (10Paladox) I've been having this problem for a while so nothing to do with last night hotfix. [12:11:04] (03PS1) 10Divadsn: Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) [12:12:26] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861579 (10Paladox) Heres a screenshot with the workaround {F5024058} [12:17:19] (03CR) 10jenkins-bot: [V: 04-1] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [12:19:42] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: [BUG] App doesn't handle *.m.wikipedia.org links - https://phabricator.wikimedia.org/T146704#2668919 (10Hlakhara) I believe this is something that depends on browser. I am unable to produce the exact same behavior on other browser. Following are the result... [12:20:53] 10Phabricator: Searching for the phabricator project does not work correctly - https://phabricator.wikimedia.org/T152834#2861582 (10Aklapper) {F5024093} is how it looks here. [12:21:36] Jenkins-bot is doing it's annoying code style check, while I just followed the same code style in the code as it was before xD [12:23:22] And random errors, totally unrelated with my code [12:23:22] yeah the bots push humans to get better ^^ [12:23:37] (03CR) 10Divadsn: "jenkins-bot is checking wrong things I think, I will revert my changes to see if his builds will still fail." [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [12:24:58] divadsn: I think your editor changed int. level [12:25:05] indentation [12:25:23] divadsn: Btw, what editor do you use [12:25:49] rlot2_, not really, the diff in Gerrit shows the tabs the same as before my change [12:26:00] I am using Atom for Windoofs [12:26:42] tab indentation level shouldn't matter [12:26:53] you can use whatever level you want, provided you use tabs [12:27:26] e.g. I use 8 characters, I know other people who use 4, etc [12:27:45] bawolff - Some editors replace tabs by spaces, its really annoying when you code in python [12:28:04] But i also use atom [12:28:06] yes. They are stupid and wrong ;) [12:28:20] and there's not such problems [12:28:52] bawolff, but npm-node-4 is bothering about it xD [12:28:59] See, https://integration.wikimedia.org/ci/job/npm-node-4/19168/console [12:29:06] I think the error message is just misleading [12:29:17] But then why giving the code review -1 -.- [12:29:26] It wants you to use one less level of tabs [12:29:45] But I use the same level as before, that's why I am confused. [12:29:51] https://gerrit.wikimedia.org/r/#/c/326252/1/resources/ext.relatedArticles.readMore.bootstrap/index.js [12:30:09] I see the same tabs used ">>" [12:30:13] no, previously it was using 4, in your new commit there is 5 indents [12:30:30] Where can I see this? [12:30:43] https://gerrit.wikimedia.org/r/#/c/326252/1/resources/ext.relatedArticles.readMore.bootstrap/index.js [12:31:09] On line 33 [12:31:28] On left hand side there are 4 >>, on right hand side there are 5 >> [12:31:37] (assuming your gerrit prefs are set to side by side diff) [12:32:12] Theres double indent [12:32:29] .done( function ( _, pages ) { [12:32:32] after this [12:41:31] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2861593 (10Reedy) [12:53:32] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2861609 (10Reedy) Similarly, for SemanticForms (maybe only master?) this should be done so we can empty the extension after the ren... [12:54:20] 10AbuseFilter: warning message on article deletion / article moving is not parsed - https://phabricator.wikimedia.org/T65768#2861611 (10matej_suchanek) [12:54:39] 10AbuseFilter, 07TestMe: warning message on article deletion / article moving is not parsed - https://phabricator.wikimedia.org/T65768#2861613 (10matej_suchanek) [12:57:10] (03CR) 10jenkins-bot: [V: 04-1] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [13:03:49] 10MediaWiki-extensions-Translate, 06translatewiki.net, 07Easy, 03Google-Code-In-2016: Refactor Translate $1 Insertable classes - https://phabricator.wikimedia.org/T152837#2861632 (10Amire80) [13:05:58] 05Security: Fifth argument to php mail() function should be better escaped. - https://phabricator.wikimedia.org/T152717#2861646 (10Bawolff) [13:06:33] 10Mail, 05Security: Fifth argument to php mail() function should be better escaped. - https://phabricator.wikimedia.org/T152717#2857917 (10Bawolff) Making this public since its not exploitable and this is only a hardening measure. [13:08:49] 10Mail, 05Security: Fifth argument to php mail() function should be better escaped. - https://phabricator.wikimedia.org/T152717#2861650 (10Ciencia_Al_Poder) [13:08:56] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861651 (10Xaosflux) @Legoktm no more of the opposite - entering only the "current" name should be able to find the rename log that made the current name come in to existe... [13:11:08] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861652 (10Legoktm) I don't understand...if you use the new name in the title field, it works just fine...? https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type... [13:16:36] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 03Google-Code-In-2016: Add documentation to CREDIT videos - https://phabricator.wikimedia.org/T142728#2861653 (10husn_shujaat) Thats great. Thanks @srishakatux :) [13:18:35] 10AbuseFilter: Some interface messages are broken if filter name contains template syntax - https://phabricator.wikimedia.org/T26309#2861655 (10matej_suchanek) [13:18:39] 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Other, and 4 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#2861654 (10matej_suchanek) [13:20:55] (03PS1) 10Brian Wolff: Escape return path extra params to php mail() [core] - 10https://gerrit.wikimedia.org/r/326260 (https://phabricator.wikimedia.org/T152717) [13:24:02] (03CR) 10Reedy: [C: 032] Removed deprecated "Article::fetchContent()" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/326160 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:25:24] (03Merged) 10jenkins-bot: Removed deprecated "Article::fetchContent()" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/326160 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:27:39] 10MediaWiki-Redirects: #REDIRECT - https://phabricator.wikimedia.org/T152807#2861662 (10Zoranzoki21) @Aklapper I am report on support desk. My report is [[https://www.mediawiki.org/w/index.php?title=Topic:Tgxf28xa29ha8h08&topic_showPostId=tgxqh57aij8tlsia&fromnotif=1#flow-post-tgxqh57aij8tlsia| here ]] [13:34:32] 04(no projects): Add BBcode to MV export options - https://phabricator.wikimedia.org/T152838#2861664 (10Strainu) [13:34:49] 10Recommendation-API, 10Security-Reviews: Security review for Recommendation API - https://phabricator.wikimedia.org/T148133#2861675 (10Bawolff) I haven't finished looking at this yet, but some preliminary concerns: * In web/templates/index.html - The escaping done for the values inserted into javascript s,t a... [13:35:10] 10MediaWiki-extensions-MultimediaViewer: Add BBcode to MV export options - https://phabricator.wikimedia.org/T152838#2861676 (10Reedy) [13:53:48] (03CR) 10Reedy: [C: 04-1] Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 (031 comment) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [13:55:06] (03PS3) 10Divadsn: Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) [14:01:26] (03PS5) 10Filip: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) [14:03:32] (03CR) 10jenkins-bot: [V: 04-1] Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [14:07:24] (03CR) 10D3r1ck01: [C: 04-1] "Jenkins is not happy. Check the codes again :)" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) (owner: 10Divadsn) [14:36:55] (03CR) 10Reedy: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 (033 comments) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [14:45:37] andre__ how to use pastebin.com [14:45:38] (03PS4) 10Divadsn: Large gap left in footer on pages with no related articles [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/326252 (https://phabricator.wikimedia.org/T147217) [14:45:54] i don't know how to use it [14:46:03] dpaste.de is probably better [15:08:10] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2861707 (10Kghbln) 05Open>03Resolved a:03Kghbln Thanks! All extensions were covered. [15:13:00] legoktm, Did you see my SmiteSpam patch? [15:14:28] https://gerrit.wikimedia.org/r/#/c/326243/ [15:15:34] andre__ do i have to do something like setting up mediawiki [15:16:58] Guneet: to do what? [15:17:57] setup mediawiki [15:19:37] so vuplix [15:19:55] do i have to reinstall vagrant [15:21:14] Guneet: for what? [15:21:14] usually not, do you have any problem? [15:21:37] for the extension [15:21:50] as i saw vedio on youtube [15:21:53] Guneet, if we don't know what the problem is that you like to solve, throwing in random solutions into the chat does not allow anybody to say whether you idea is good or bad [15:21:56] it said so [15:22:17] ok [15:22:24] Guneet: We don't know what problem you try to solve. And if some random Youtube video is right or wrong. [15:22:49] So you ask the questions and i will answer [15:23:19] Guneet: no, you explain the problem first and we can suggest solutions :) [15:23:32] my problem is how to install wikimedia on vagrant [15:23:43] wikimedia extension [15:23:46] *mediawiki [15:23:51] yes [15:24:09] :D [15:24:23] what extension? is MediaWiki already installed and working? [15:24:36] no its not [15:24:58] the task description says-"In your development environment, install a MediaWiki extension of your choice that is also installed on Wikimedia sites and which also does not yet have a screenshot on the extension's home page on https://www.mediawiki.org" [15:25:18] Guneet, that's not a problem description. It only explains what you want to do, but not why you cannot do it. [15:25:33] The answer to "how to install wikimedia on vagrant" is https://www.mediawiki.org/wiki/MediaWiki-Vagrant . [15:26:11] (The software is called "MediaWiki'. The entire organization and movement behind is "Wikimedia".) [15:26:26] I wonder why the task asks to install an extension already installed on WMF wikis, if the screenshot can usually be taken visiting Wikipedia or similar... [15:26:27] ok [15:28:44] 10Wikimedia-Site-requests: enable sitenotice mobile for Arwiki - https://phabricator.wikimedia.org/T152826#2861710 (10Ibrahim.ID) https://ar.wikipedia.org/wiki/%D9%88%D9%8A%D9%83%D9%8A%D8%A8%D9%8A%D8%AF%D9%8A%D8%A7:%D8%A7%D9%84%D9%85%D9%8A%D8%AF%D8%A7%D9%86/%D8%AA%D9%82%D9%86%D9%8A%D8%A9/08/2016#.D9.85.D9.82.D8.... [15:29:00] Vulpix: well, it looked like an wasy way to let the student 'proof' that they installed Vagrant. I'm open for better ideas. :P [15:30:01] Vulpix: the thing with competitions on the internet is: If I created a task "make a handstand" and don't ask the student for a photo of it, it's hard for a mentor to check if the student mentioned the task. :D [15:30:07] s/mentioned/managed/ [15:31:13] ah, if it is a competition that's fine, it makes sense [15:31:30] Vulpix: see https://www.mediawiki.org/wiki/Google_Code-in_2016 [15:31:45] Vulpix: if you have ideas for tasks you'd like to mentor, please consider it. :) [15:33:33] @seen FlorianSW [15:33:33] rlot: Last time I saw FlorianSW they were changing the nickname to FlorianSW|away and FlorianSW|away is still in the channel #wikimedia-mobile at 12/8/2016 9:23:34 PM (1d18h9m58s ago) [15:35:32] (03PS3) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [15:39:07] (03PS18) 10Amire80: Make the code for grammar data processing common [core] - 10https://gerrit.wikimedia.org/r/241645 (https://phabricator.wikimedia.org/T115217) [15:39:52] (03PS6) 10Filip: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) [15:42:22] (03CR) 10Filip: "This whole parser cloning is pointless. Why do not remove it, and replace function calls with simple $page = ..." [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [15:43:52] 04(no projects): Noto Naksh Arabic fonts installation on Sindhi Wikipedia - https://phabricator.wikimedia.org/T152840#2861714 (10mehtab.ahmed) [15:44:15] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Linter, 07Browser-Support-Google-Chrome: jquery.textSelection does not scroll textbox in Chromium, works in Firefox - https://phabricator.wikimedia.org/T152760#2861725 (10Harjotsingh) Thanks for the suggestion, after running maintenance/update.php the DB... [15:44:49] Can anyone take a look at https://gerrit.wikimedia.org/r/326171 ? I think this whole parser cloning is useless, becouse we use now WikiPage with has getParserOutput [15:45:15] 10MediaWiki-extensions-UniversalLanguageSelector, 06Operations, 07I18n: Noto Naksh Arabic fonts installation on Sindhi Wikipedia - https://phabricator.wikimedia.org/T152840#2861726 (10Aklapper) [15:47:38] (03CR) 10Fomafix: [C: 04-1] "A progress indicator would be nice. Also the button should be blocked while progressing to avoid parallel requests." [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [15:51:16] (03PS7) 10Amire80: Move the Ukrainian grammar rules from PHP and JS to JSON [core] - 10https://gerrit.wikimedia.org/r/245184 (https://phabricator.wikimedia.org/T115217) [15:56:10] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861732 (10Xaosflux) @Legoktm thank you! Looks like we just need to update the prompt at MediaWiki:Speciallogtitlelabel to reference that syntax. Will this work for mult... [16:03:33] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861737 (10Xaosflux) For global renames: would be handy to have a "name history" - perhaps a seperate log request - e.g. given a current name, what were all prior names.... [16:06:45] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861739 (10Xaosflux) Related discussion with some examples: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=754050483#Easy_way_to_spot... [16:07:10] 10MediaWiki-Logging, 10MediaWiki-extensions-Renameuser: Feature Request: Rename log enhancement - https://phabricator.wikimedia.org/T152830#2861740 (10Xaosflux) p:05Triage>03Lowest [16:07:44] (03PS4) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [16:08:29] (03CR) 10Sn1per: "Would a suitable indicator be changing the button text while disabled to something like "Marking all pages visited..."?" [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [16:09:49] @seen Reedy [16:09:49] rlot: Reedy is in here, right now [16:10:02] gasp [16:14:59] (03CR) 10jenkins-bot: [V: 04-1] Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [16:18:28] 07Mobile: Nowrap template not working on mobile site - https://phabricator.wikimedia.org/T152841#2861756 (10Tvx1) [16:18:44] 10Wikimedia-Site-requests, 13Patch-For-Review: Request to Change title or sitename and logo for localisation and update namespaces on gujarati wikiquote (gu.wikiquote) - https://phabricator.wikimedia.org/T121853#2861768 (10Krenair) @Dereckson do we have everything needed to schedule this? [16:22:00] (03PS5) 10Sn1per: Mark pages on watchlist as visited using JS without reload [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) [16:34:21] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog, 07Easy: Feed: News stories are partially obscured by system status bar when no thumbnail is found - https://phabricator.wikimedia.org/T141991#2519053 (10Mayank.jindal5) I would like to work on this issue. I am new to wikimedia but I am doing android app de... [16:43:55] 10Phabricator (Upstream), 07Upstream: Simple way to start a Conpherence with another Phabricator user - https://phabricator.wikimedia.org/T152652#2856125 (10Krenair) Yes, let's not re-add that [16:51:15] @seen McIntireEvan [16:51:16] subins2000: McIntireEvan is in here, right now [16:52:19] McIntireEvan: Hey ! Can you please review this task https://codein.withgoogle.com/dashboard/task-instances/5318682349666304/ [17:05:31] (03PS9) 10Sn1per: [WIP] Unwatch link for pages in Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/293892 (https://phabricator.wikimedia.org/T2424) [17:06:21] (03PS18) 10Sn1per: [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) [17:11:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Unwatch link for pages in Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/293892 (https://phabricator.wikimedia.org/T2424) (owner: 10Sn1per) [17:13:19] (03Draft1) 10Paladox: Insert the description of the change. [skins] - 10https://gerrit.wikimedia.org/r/326276 [17:13:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) (owner: 10Sn1per) [17:15:15] (03PS2) 10Paladox: Fix the Example submodule [skins] - 10https://gerrit.wikimedia.org/r/326276 (https://phabricator.wikimedia.org/T152663) [17:16:53] (03CR) 10Paladox: "We will then after this is merged submit a patch to the example repo and see if submodules start updating for the example submodule :)" [skins] - 10https://gerrit.wikimedia.org/r/326276 (https://phabricator.wikimedia.org/T152663) (owner: 10Paladox) [17:19:27] (03PS1) 10Karima Rafes: Merge remote-tracking branch 'refs/remotes/origin/master' [extensions/LinkedWiki] (REL1_27) - 10https://gerrit.wikimedia.org/r/326277 [17:24:46] Reedy: Are you around? [17:28:30] (03PS19) 10Sn1per: [WIP] Use PHP DateInputWidget in Contribs and use for range filtering [core] - 10https://gerrit.wikimedia.org/r/316574 (https://phabricator.wikimedia.org/T120733) [17:31:27] 10MediaWiki-extensions-Scribunto: Expose site collation to Lua - https://phabricator.wikimedia.org/T152845#2861822 (10matej_suchanek) [17:31:41] 10MediaWiki-extensions-Scribunto: Expose site collation to Lua - https://phabricator.wikimedia.org/T152845#2861834 (10matej_suchanek) [17:31:43] 10MediaWiki-extensions-Scribunto, 07Tracking: Requested Scribunto/Lua built-in methods/functions (tracking) - https://phabricator.wikimedia.org/T50176#2861835 (10matej_suchanek) [17:42:49] Hellp [17:43:00] ? [17:43:28] I try to merge the branch 1_27 with my master but I cannot find the good command with gerrit [17:44:00] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/LinkedWiki,n,z [17:45:19] What are you trying to make? [17:45:28] Git review say me all [17:45:34] sorry... [17:45:35] why would you want to merge REL1_27 with master? o_O [17:45:48] the branch 1_27 is a old version [17:46:05] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2861593 (10hashar) For Wikimedia deployment we need to keep in Gerrit the extensions that are deployed for Wikitech on silver: ```... [17:46:07] I try to push the master in this branch [17:46:27] But why your trying to make it on code review? [17:46:34] Make it locally [17:46:56] maybe Karima is the project maintainer [17:47:27] when the users download the version 1_27 of my extension... the code is obsolete [17:48:01] yes I am the maintainer of my extension [17:48:50] I use Gerrit one time all six month... I am not a expert... [17:50:09] I don't know how to do that, either, let's wait an expert here... [17:50:15] Had anyone seen Reedy or Nikiharika [17:50:17] ? [17:50:22] Niharika [17:50:36] maybe only the administrator can update the branch 1_27 of my extension ? [17:55:35] I think you should be able to do that [17:57:40] I try to do a merge... but I can t push the old commits [18:00:59] message is : remote: To push into this reference you need 'Push' rights. ! [remote rejected] REL1_27 -> REL1_27 (prohibited by Gerrit) [18:01:52] ...so you want to bypass Gerrit? [18:02:09] (or more like: code review in Gerrit) [18:02:28] andre__: I think he might have a local commit that's ahead of the branch. [18:02:37] no I want update the branch REL1_27 with the last version of my code (already review via gerrit in the master) [18:03:03] Karima wants to change REL1_27 of an extension to point to current master [18:03:25] yes [18:04:11] that can be done "backporting" all changes to master since REL1_27 to REL1_27, but I guess there's a more straightforward way like just dropping REL1_27 and recreating it at a given commit [18:05:53] Karima: do you see delete buttons or a way to change existing branches from here? https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/LinkedWiki,branches [18:07:23] (03Abandoned) 10Karima Rafes: Merge remote-tracking branch 'refs/remotes/origin/master' [extensions/LinkedWiki] (REL1_27) - 10https://gerrit.wikimedia.org/r/326277 (owner: 10Karima Rafes) [18:12:09] Karima: branch versions are maintained by releases team #wikimedia-releng, but generally the branches are cut off automatically as part as a mediawiki release [18:12:19] if people download master they will get the most recent version [18:13:46] I delete the branch 1_27 I try to create a new branch with the same name [18:14:21] sometimes the automatic cut off is not correct (see T66157), wondering if project owners can have control to change at which commit the branch points to [18:14:21] T66157: Update branches in mediawiki/extensions/* for REL1_23 - https://phabricator.wikimedia.org/T66157 [18:24:23] I deleted all the branch [18:24:43] The good version is only in the master [18:25:08] I will search a good solution the next time ;) [18:26:04] Vulpix Thanks for the link in gerrit. Bye [18:27:00] that would break Extension Distribution for those branches... from that same link you can create new branches, specifying the commit at which they should point [18:28:52] yes... it's simple... thanks [18:30:15] I created the branch for 1_27. it's good [18:39:11] 10MediaWiki-extensions-SemanticResultFormats, 07I18n: [[MediaWiki:Srf-ui-datatables-label-sInfoThousands/pt]] i18n query - https://phabricator.wikimedia.org/T152107#2861860 (10Aklapper) 05Open>03declined Bugs for this extension are tracked at https://github.com/SemanticMediaWiki/SemanticResultFormats/issue... [18:40:05] 10MediaWiki-extensions-LocalisationUpdate, 10MediaWiki-extensions-SemanticResultFormats, 10MediaWiki-extensions-Validator, 07Wikimedia-log-errors: Couple of weird warnings coming up during LocalisationUpdate runs - https://phabricator.wikimedia.org/T107546#2861862 (10Aklapper) Both patches got merged ages... [18:43:23] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-General-or-Unknown, 06Reading-Infrastructure-Team, 05Goal: Update all extensions to use AuthManager - https://phabricator.wikimedia.org/T110291#2861865 (10Aklapper) [18:43:25] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-SemanticSignup, 06Reading-Infrastructure-Team: Update SemanticSignup to use AuthManager - https://phabricator.wikimedia.org/T110300#2861863 (10Aklapper) 05Open>03declined Tasks for the SemanticSingup extension are tracked at https://git... [18:44:37] 10MediaWiki-extensions-SemanticSignup: ConfirmEdit (Captcha) not supported - https://phabricator.wikimedia.org/T32629#2861867 (10Aklapper) 05Open>03declined Tasks for the SemanticSingup extension are tracked at https://github.com/SemanticMediaWiki/SemanticSignup/issues hence closing this task. See https://gi... [18:44:52] 10MediaWiki-extensions-General-or-Unknown, 10Continuous-Integration-Config: Disable CI for Semantic Extensions that have gone to github - https://phabricator.wikimedia.org/T152835#2861869 (10Reedy) >>! In T152835#2861837, @hashar wrote: > For Wikimedia deployment we need to keep in Gerrit the extensions that a... [18:45:10] 10MediaWiki-extensions-SemanticSignup: SemanticSignup: Location for {{#signupfields:}}; Incompatibility with WikiEditor. - https://phabricator.wikimedia.org/T36864#2861870 (10Aklapper) 05Open>03declined Tasks for the SemanticSingup extension are tracked at https://github.com/SemanticMediaWiki/SemanticSignup/... [18:46:28] 10MediaWiki-extensions-UniversalLanguageSelector, 07I18n: Noto Naksh Arabic fonts installation on Sindhi Wikipedia - https://phabricator.wikimedia.org/T152840#2861872 (10Reedy) [18:51:20] 10MediaWiki-extensions-Semantic-Glossary: Loading both Lingo and SemanticGlossary with wfLoadExtension throws an exception - https://phabricator.wikimedia.org/T135286#2861874 (10Aklapper) 05Open>03declined SemanticGlossary issues are tracked at https://github.com/SemanticMediaWiki/SemanticGlossary/issues hen... [18:56:39] (03CR) 10Reedy: [C: 04-1] Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 (035 comments) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:10:44] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage: Frequent DB writes on HTTP GET from PageTriage - https://phabricator.wikimedia.org/T152847#2861877 (10aaron) [19:12:16] 10MediaWiki-General-or-Unknown, 10ScopedCallback: Install version 1.28 via git gives the error Class 'Wikimedia\\ScopedCallback' not found - https://phabricator.wikimedia.org/T152848#2861890 (10Karima) [19:13:16] 10MediaWiki-General-or-Unknown, 10ScopedCallback: Install version 1.28 via git gives the error Class 'Wikimedia\\ScopedCallback' not found - https://phabricator.wikimedia.org/T152848#2861890 (10Reedy) Have you run composer update?, I'm guessing not? https://github.com/wikimedia/mediawiki/blob/REL1_28/RELEASE-... [19:17:34] (03PS7) 10Filip: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) [19:20:52] (03CR) 10Reedy: [C: 032] Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:21:59] (03Merged) 10jenkins-bot: Replaced "Article::fetchContent()" deprecated in MediaWiki 1.21 [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/326171 (https://phabricator.wikimedia.org/T151973) (owner: 10Filip) [19:22:37] 10MediaWiki-Interface, 10MediaWiki-User-blocking: Bring the CIDR calculator to MediaWiki core - https://phabricator.wikimedia.org/T152850#2861920 (10Huji) [19:28:48] (03PS1) 10Aaron Schulz: Defer secondary page metadata backfill DB writes [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/326279 (https://phabricator.wikimedia.org/T152847) [19:29:04] legotkm: Are you around? [19:32:34] legoktm: [19:32:42] @seen legoktm [19:32:43] rlot: legoktm is in here, right now [19:33:37] 10MediaWiki-General-or-Unknown, 10ScopedCallback: Install version 1.28 via git gives the error Class 'Wikimedia\\ScopedCallback' not found - https://phabricator.wikimedia.org/T152848#2861936 (10Karima) I did : composer install But not composer update It works now. Thanks [19:33:54] 10MediaWiki-General-or-Unknown, 10ScopedCallback: Install version 1.28 via git gives the error Class 'Wikimedia\\ScopedCallback' not found - https://phabricator.wikimedia.org/T152848#2861937 (10Karima) 05Open>03Resolved [19:34:37] rlot: if you want to know if someone is idle, type /whois NICK NICK (yes, NICK 2 times, where NICK is the nick of the user you're requesting) [19:34:49] Thanks! [19:35:09] Whats diffrence between ->parse and -> text [19:35:09] ? [19:35:19] (I think Lego is pretty busy this weekend, if I remember correctly) [19:36:49] Oh, fortunately i claimed small task [19:37:03] Btw, should i use ->parse() in ->msg( ? [19:37:19] (when converting from global messages) [19:39:24] ? [19:40:44] (03CR) 10VolkerE: "Sure, it's just generally useful to have the UI challenges and evolution documented by a current and post-patch state. It would also help " [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/326121 (owner: 10Esanders) [19:41:32] 10Phabricator, 10Elasticsearch: Collect test cases for phabricator search - https://phabricator.wikimedia.org/T151500#2819387 (10scfc) Test case: Searching for "databases", "Open and Closed", "Task", "Author: @scfc" (https://phabricator.wikimedia.org/search/query/dxp3d.8.DDWY/#R) lists nine tasks, but not 9123... [19:46:58] In addHTML( [19:47:01] I should use [19:47:05] ->parsed [19:47:08] or ->text [19:47:09] ? [19:51:55] (03PS1) 10Aaron Schulz: Fix a few minor IDEA warnings [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/326280 [19:56:25] if my task is not at phabricator, what branch name should i use? [19:56:28] andre__ [19:59:08] rlot: How do you mean? [19:59:30] Task does not have Phabricator task [19:59:34] "branch" = part of a code repository. "task" = something in an issue tracking system [19:59:39] Or I'll create one [19:59:53] rlot: You refer to the git commit message? Or where? [19:59:56] Yeah, i know, but its wierd [20:00:03] GCI task "Special pages in SmiteSpam should use $this->msg() instead of the global function wfMessage. [20:00:03] " [20:00:09] Ah! Now I get it! [20:00:16] You can use any random branch name, actually [20:00:16] Does not have phabricator task [20:00:26] Can i create one? [20:00:30] Of course! :D [20:00:31] On phabricator [20:00:36] Ok, Thanks! [20:00:49] 10MediaWiki-extensions-LiquidThreads: LQT on-the-fly DB corrections causing writes on HTTP GET - https://phabricator.wikimedia.org/T152851#2861944 (10aaron) [20:00:52] You don't have to ask for permission to report bugs or feature requests in Phab, anyone can do that :) [20:01:43] 10MediaWiki-extensions-SmiteSpam: SmiteSpam - Replace "wfMessage(" with "$this->msg" in SpecialPages - https://phabricator.wikimedia.org/T152852#2861956 (10FilipGCI) [20:01:53] Is it ok? [20:04:25] rlot: yes, looks very good! [20:04:39] (03PS1) 10Filip: Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) [20:06:32] (03CR) 10jenkins-bot: [V: 04-1] Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) (owner: 10Filip) [20:09:31] (03PS2) 10Filip: Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) [20:13:27] How to log error? [20:14:13] How do you mean? Like https://www.mediawiki.org/wiki/Manual:How_to_debug ? [20:14:23] add log to system [20:14:27] i know [20:14:31] error_log( [20:14:39] but i don't know i can use it [20:15:07] (I try to add orginal error message to log, and show user translatable) [20:19:42] Is there any command line tool to submit tasks on GCI site? [20:20:27] It would be much easier when you work without X server [20:22:16] don't think so [20:22:20] there is a command line for phabricator [20:23:35] Google have log-in api, so it could be easily done i python [20:27:14] andre__: Can you take a look at "Convert messages to use $this->msg() instead of wfMessage in SmiteSpam (Wikimedia)" [20:27:30] Theres note "[note: This task is intended for MtDu since we talked about it on IRC after he updated the extension in another task and noticed it, not sure if I can reserve it for him somehow...]" [20:28:14] So should i abadon it or something [20:31:27] rlot: Students are very welcome to propose GCI tasks themselves. But you cannot really "reserve" a task. [20:32:46] rlot: You are welcome to work on it I'd say. Or you could also leave it to MtDu if you see another task you're interested in. [20:33:00] Hmm. Hmm, hmm. [20:33:41] Ok, i'll wait for legoktm [20:40:05] 10MediaWiki-General-or-Unknown, 10ScopedCallback: Install version 1.28 via git gives the error Class 'Wikimedia\\ScopedCallback' not found - https://phabricator.wikimedia.org/T152848#2861989 (10Aklapper) 05Resolved>03Invalid Changing status to 'invalid' as no code change was committed. [20:43:11] 10RegexBlock: IPv6 ranges fail the RegexBlockData::isValidRegex() test in RegexBlockForm::validateTargetField() - https://phabricator.wikimedia.org/T152853#2861991 (10SamanthaNguyen) [20:44:19] 10RegexBlock: RegexBlock::check() doesn't handle IP ranges - https://phabricator.wikimedia.org/T152854#2862005 (10SamanthaNguyen) [20:46:14] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search: Allow searching by file license on Commons - https://phabricator.wikimedia.org/T152855#2862019 (10Aklapper) [21:03:54] (03CR) 10Addshore: [C: 032] Fix a few minor IDEA warnings [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/326280 (owner: 10Aaron Schulz) [21:05:12] (03Merged) 10jenkins-bot: Fix a few minor IDEA warnings [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/326280 (owner: 10Aaron Schulz) [21:05:48] 10FanBoxes, 10Social-Tools: FanBoxes extension: Add documentation for and parser hooks - https://phabricator.wikimedia.org/T152856#2862040 (10SamanthaNguyen) [21:09:04] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search: Allow searching by file license on Commons - https://phabricator.wikimedia.org/T152855#2862068 (10Deskana) 05Open>03Resolved a:03Deskana [[https://commons.wikimedia.org/wiki/Special:Search/incategory:cc-zero|incategory:cc-zero]] wil... [21:09:35] 10MediaWiki-extensions-Linter: Linter: introduce severity level for error categories - https://phabricator.wikimedia.org/T152822#2862071 (10MZMcBride) Python's flake8 has a pretty neat categorization system using W, E, and F with positive integers. It might be too technical to emulate directly, but perhaps it'll... [21:10:07] (03CR) 10VolkerE: [C: 031] Switch OATH to OOUI [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322100 (https://phabricator.wikimedia.org/T150863) (owner: 10TheDJ) [21:17:38] 10MediaWiki-extension-requests: A Mediawiki extension to preview MAFF files - https://phabricator.wikimedia.org/T152783#2862073 (10ahmad) [21:17:45] 10MediaWiki-extension-requests: A Mediawiki extension to preview MAFF files - https://phabricator.wikimedia.org/T152783#2859923 (10ahmad) A bounty is put on the implementation of this: https://www.bountysource.com/issues/39907864-a-mediawiki-extension-to-preview-maff-files [21:19:34] (03PS1) 10XinyueZ: Fixed null-ptr for some codes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326285 [21:22:54] 10FanBoxes, 10Social-Tools: Replace YUI color picker in Special:FanBoxes with a jQuery color picker - https://phabricator.wikimedia.org/T152858#2862076 (10SamanthaNguyen) [21:25:22] 10Social-Tools, 07PostgreSQL: Social Tools Postgres support - https://phabricator.wikimedia.org/T87542#2862095 (10SamanthaNguyen) [21:25:46] 10Comments, 10Social-Tools, 07PostgreSQL: Postgres support for Comments - https://phabricator.wikimedia.org/T59761#2862098 (10SamanthaNguyen) [21:27:18] (03PS1) 10XinyueZ: Added 'double tap' to zoom-in gallery [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/326286 [21:42:00] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Convert Special:DeletedContributions to OOUI - https://phabricator.wikimedia.org/T134525#2862102 (10Quiddity) Note: Some frustration was expressed regarding this change, at https://en.wikipedia.org/wi... [21:55:16] To addHTML( is should use -> parsed or -> text? [21:57:44] 10Wikimedia-General-or-Unknown: Sometimes no js is loading on commons - https://phabricator.wikimedia.org/T152839#2862108 (10Aklapper) [ - #Operations; + #Wikimedia-General-or-Unknown ] When this happens, can you please check in your web browser's developer tools ('console' and/or 'network') if there are any re... [21:59:04] In addHTML code should be escaped or text? [22:00:12] 10Social-Tools, 10SocialProfile, 07Documentation: Improve MediaWiki.org documentation for SocialProfile - https://phabricator.wikimedia.org/T152859#2862112 (10SamanthaNguyen) [22:01:36] (03PS3) 10Filip: Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) [22:03:24] Anyone? [22:05:17] How i can delete patch set to back? [22:06:09] 06Brickimedia, 10Refreshed, 07Documentation: Improve MediaWiki.org documentation for Refreshed skin - https://phabricator.wikimedia.org/T152860#2862132 (10SamanthaNguyen) [22:09:17] (03PS4) 10Filip: Replace "wfMessage(" with "$this->msg" in SmiteSpam's SpecialPages [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/326282 (https://phabricator.wikimedia.org/T152852) [22:17:54] 10Social-Tools: Project request: Create project for MiniInvite extension - https://phabricator.wikimedia.org/T152861#2862148 (10SamanthaNguyen) [22:27:33] 10Social-Tools, 07Tracking: [TRACKING] Improve MediaWiki.org documentation for social tool extensions - https://phabricator.wikimedia.org/T152862#2862163 (10SamanthaNguyen) [22:28:37] 10Social-Tools, 10SocialProfile, 07Documentation: Improve MediaWiki.org documentation for SocialProfile - https://phabricator.wikimedia.org/T152859#2862175 (10SamanthaNguyen) [22:28:39] 10Social-Tools, 07Tracking: [TRACKING] Improve MediaWiki.org documentation for social tool extensions - https://phabricator.wikimedia.org/T152862#2862163 (10SamanthaNguyen) [22:31:12] (03CR) 10Fomafix: Mark pages on watchlist as visited using JS without reload (033 comments) [core] - 10https://gerrit.wikimedia.org/r/326242 (https://phabricator.wikimedia.org/T150045) (owner: 10Sn1per) [22:33:02] 10Social-Tools, 07Tracking: Review and/or update the current screenshots of social tool extensions - https://phabricator.wikimedia.org/T152863#2862176 (10SamanthaNguyen) [22:33:53] 10Social-Tools, 07Documentation, 07Tracking: [TRACKING] Improve MediaWiki.org documentation for social tool extensions - https://phabricator.wikimedia.org/T152862#2862163 (10SamanthaNguyen) [22:34:18] 10Social-Tools, 07Documentation, 07Tracking: Review and/or update the current screenshots of social tool extensions - https://phabricator.wikimedia.org/T152863#2862176 (10SamanthaNguyen) [22:38:00] 10Social-Tools, 07Documentation, 07Tracking: Review and/or update the current screenshots of social tool extensions - https://phabricator.wikimedia.org/T152863#2862193 (10SamanthaNguyen) [22:39:06] 10Social-Tools, 07Documentation, 07Tracking: Review and/or update the current screenshots of social tool extensions - https://phabricator.wikimedia.org/T152863#2862176 (10SamanthaNguyen) * https://www.mediawiki.org/wiki/Extension:QuizGame#/media/File:QuizGame_MediaWiki_extension.png * https://www.mediawiki.o... [23:02:03] 10Social-Tools, 10SocialProfile: Update SocialProfile to newer extension registration method - https://phabricator.wikimedia.org/T152865#2862216 (10SamanthaNguyen) [23:15:06] 10Social-Tools, 07Documentation, 07Tracking: Add documentation for SocialProfile's support for Echo - https://phabricator.wikimedia.org/T152867#2862249 (10SamanthaNguyen) [23:21:29] (03PS4) 10Aaron Schulz: Add LoadBalancer::getMaintenanceConnectionRef() method [core] - 10https://gerrit.wikimedia.org/r/323883 [23:23:14] 10Social-Tools, 10VoteNY: VoteNY should state if and when the user doesn't have the "voteny" user right permission or if the database is locked - https://phabricator.wikimedia.org/T152868#2862265 (10SamanthaNguyen) [23:28:24] (03PS5) 10Aaron Schulz: Add LoadBalancer::getMaintenanceConnectionRef() method [core] - 10https://gerrit.wikimedia.org/r/323883 [23:35:40] 10AbuseFilter, 07I18n: Allow translation of action names for AbuseFilter logs - https://phabricator.wikimedia.org/T152869#2862279 (10Huji) [23:35:49] (03PS6) 10Aaron Schulz: Add LoadBalancer::getMaintenanceConnectionRef() method [core] - 10https://gerrit.wikimedia.org/r/323883 [23:46:34] 04(no projects): OTRS-Wiki link to mobile website - https://phabricator.wikimedia.org/T152870#2862291 (10Framawiki) [23:47:47] (03PS3) 10Reedy: Switch OATH to OOUI [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322100 (https://phabricator.wikimedia.org/T150863) (owner: 10TheDJ) [23:47:55] (03CR) 10Reedy: [C: 032] "Prettyful" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322100 (https://phabricator.wikimedia.org/T150863) (owner: 10TheDJ) [23:49:50] (03Merged) 10jenkins-bot: Switch OATH to OOUI [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322100 (https://phabricator.wikimedia.org/T150863) (owner: 10TheDJ) [23:49:50] 10Wikimedia-Site-requests: OTRS-Wiki link to mobile website - https://phabricator.wikimedia.org/T152870#2862302 (10Reedy) [23:51:06] 10Social-Tools, 07Documentation, 07Tracking: Make the sections consistent with the social tools extensions - https://phabricator.wikimedia.org/T152871#2862305 (10SamanthaNguyen) [23:51:15] 10Wikimedia-Site-requests: OTRS-Wiki link to mobile website - https://phabricator.wikimedia.org/T152870#2862291 (10Reedy) Or do you want mobile enabling properly? The problem is no otrs-wiki.m.wikimedia.org DNS entry; so we can easily fix that if you prefer [23:51:33] 10AbuseFilter: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2862321 (10Huji) [23:52:51] 10AbuseFilter, 07I18n: GENDER parameter for AbuseFilter log should use the user, not the username - https://phabricator.wikimedia.org/T152873#2862336 (10Huji) [23:53:00] 10AbuseFilter, 07I18n: GENDER should be used for "triggered" in AbuseFilter log messages - https://phabricator.wikimedia.org/T152872#2862321 (10Huji) [23:55:24] (03PS4) 10Reedy: Remove SpecialOATHLogin.php as more AuthManager related cleanup [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321091