[00:00:16] I know what it is, I just haven't participated [00:00:24] oh, alright [00:00:31] ayden: it's pretty silent in this channel currently, probably because it's weekend. Just saying :) [00:00:46] People have asked me to participate before (as both a student and a mentor IIRC), but I never really had the time [00:01:08] It does take up a lot of time to do well in it [00:01:45] ...on both the mentors' and students' sides :P [00:02:39] the benefit of GCI is that it needs less attention [00:02:45] on the other hand I might be confusing it with GSoC [00:02:45] (as mentor) [00:02:51] as they are many small tasks [00:03:16] From the few days ive been on it, i've spent upwards of 8 hours on it [00:03:18] (OTOH you are expected to commit to reply in less than X time) [00:03:38] ayden: as a mentor or as a student? [00:03:43] a student [00:04:17] i turned 13 recently, and a google employee told me about it [00:04:18] hmm, it's quite normal [00:04:47] you are doing advanced stuff [00:05:17] it would take less time to someone with more experience doing X? sure [00:05:31] but how much do you think it took THEM the first time? :) [00:06:11] what were you working on, ayden ? [00:07:16] Last, I was working on a basic task, in which you have to run a linux distro called haiku in a vm [00:07:50] I had to get to know some of the features like stacking and blocking tabs [00:07:51] (03PS1) 10Lewis Cawte: Call echo related hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325141 [00:07:55] ah, nice [00:08:21] to be fair, altough I've heard about Haiku, and I think I tried it some time ago [00:08:25] (03CR) 10Lewis Cawte: [C: 032 V: 032] Call echo related hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325141 (owner: 10Lewis Cawte) [00:08:35] I have no idea what are those stacking and blocking tabs features [00:08:43] so you already passed me on that :) [00:10:06] I also tried to use the android ndk to build a sample app with copyleft games [00:10:39] I couldn't do that in time though lol [00:11:30] and what are you planning to do now? [00:11:38] something related to Wikimedia? [00:13:37] I plan to do another task with wikimedia soon, but this task was to connect to their developer irc [00:13:49] And stay for an hour [00:14:49] ok [00:15:10] you may want to try one of the more advanced ones after this [00:15:22] you can only do a couple of basic tasks, after all [00:15:26] That's what I was planning on [00:15:55] This isnt even a basic task, I dont think [00:16:02] the last one was, though [00:16:04] so, what do you know about wikimedia? [00:16:04] really? [00:16:13] Yea, it surprised me too [00:16:19] maybe an oversight [00:16:30] it looks like a basic task to me [00:16:33] andre__? [00:17:27] and krenair, from what I understand, wikimedia runs wikipedia, which is a site that many people pool what they know into a bunch of webpages [00:17:40] yep [00:17:51] among other things [00:18:02] that's a good explanation [00:18:14] got any questions about the technical side? [00:18:16] 10MediaWiki-extensions-SimpleSAMLphp: Mediawiki 1.27 and simplesamlphp - https://phabricator.wikimedia.org/T152153#2845011 (10Peteolsen) It gives back the error "The Supplied Credentials could not be authenticated". [00:18:18] now a tricky question: what is mediawiki, and how does it relate to the others? ;) [00:20:35] (I googled it) Its an open source php package used to make wiki pages for individual websites [00:21:18] was that correct? I only checked the preview of the site on google [00:21:21] its base is php, yes. [00:21:51] hte answer is not wrong, but I don't think you really understood the concept :P [00:21:52] I really want to learn php, but I have had some trouble with setting up a test server [00:22:02] how does mediawiki relate to wikimedia and wikipedia? [00:22:29] Platonides, you asked two questions and he got the first [00:23:57] idk if I got the correct answer ¯\_ツ_/¯ [00:24:09] Platonides: yeah, that was an oversight that I couldn't fix anymore [00:24:43] why so? looks like you could create a new basic task and deprecate the old one [00:25:13] ayden, it is open source, it is primarily PHP (though we use other things like JS to make the user interface more interactive), and it allows reading, creating, editing etc. of wiki pages [00:25:16] so that part is right [00:25:20] ayden: wikimedia is what runs the projects, which (mainly) use the mediawiki software [00:25:31] alright, cool [00:25:48] so the website in Wikipedia is using MediaWiki [00:25:52] and andre, I just realized you are one of the mentors, lol [00:25:58] just like many blogs use WordPress [00:26:15] andre__ is the Chief Mentor ;) [00:26:20] heh [00:27:26] So how does the mentor gui work, can you choose who to check on, or do you go through a queue? [00:27:48] (03CR) 10Legoktm: "> So, from my perspective: To fulfil, that the manifest_version check is performed outside of the version check, would revert the change, " [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [00:28:19] there is a list of pending tasks that you can check [00:28:27] cool [00:28:58] but also, some mentors are helping with certain tasks [00:29:28] not all of us knwo about every aspect of wikimedia or what could have been asked to a student [00:29:42] (03CR) 10Legoktm: [C: 04-1] "Minor doc issues, looks good otherwise" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [00:29:55] at least, it works this way if they didn't change the interface too much [00:30:04] I was a gci mentor last year [00:30:16] but I'm not signed up as one this one [00:30:48] 04(no projects): Ease creating collapsible lists - https://phabricator.wikimedia.org/T152301#2845012 (10Aklapper) Why / which actual problem would this solve? And which project is this task about? Is this about MediaWiki core, or some extension? [00:30:55] Nice, I've never been on irc before, but it seems somewhat similar to teamspeak, if you are familiar with that program [00:31:11] * Platonides looks that up [00:31:30] teamspeak is voice-based [00:31:35] irc is text-only [00:32:03] yea, but other than that, the atmosphere is pretty similar [00:32:17] 04(no projects): User setting for collapsible elements - https://phabricator.wikimedia.org/T152314#2845013 (10Aklapper) Currently this task does not explain well //why// this task was created. It proposes a solution to an underlying problem that still needs to get defined. Knowing the background of the request... [00:32:28] most people seem to be doing something other than what the chat is meant for, and just kind of chatting [00:33:40] ? [00:34:03] (03CR) 10Jack Phoenix: [C: 032] Replace ArticleSaveComplete hook usage [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/315124 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [00:34:03] idk, it's been a while since I was on ts [00:34:08] irc is very suited for multitasking [00:34:47] 04(no projects): Expand/collapse scrolling view - https://phabricator.wikimedia.org/T152326#2845014 (10Aklapper) Currently this task does not explain well //why// this task was created. It describes a solution to an underlying problem that still needs to get defined. Knowing the background of the request in thi... [00:35:28] (03Merged) 10jenkins-bot: Replace ArticleSaveComplete hook usage [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/315124 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [00:35:36] 04(no projects): Ease creating collapsible lists - https://phabricator.wikimedia.org/T152301#2844312 (10Platonides) This is probably a duplicate of a years-old task about
    . This would solve styling long lists by changing just the beginning, instead of having to change every item, and keeping the... [00:35:44] 04(no projects): Print collapsible elements expanded - https://phabricator.wikimedia.org/T152330#2845018 (10Aklapper) Can you please provide an example what a "collapsible element" is, or some link to a page where this problem can be reproduced? Also, which project is this about? Is this about MediaWiki core, o... [00:35:49] (03CR) 10Paladox: "Thank you." [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/315124 (https://phabricator.wikimedia.org/T147390) (owner: 10Paladox) [00:36:06] why has wikibugs split into two again [00:37:04] 10MediaWiki-Parser: Easier syntax for ul tags with attributes (Ease creating collapsible lists) - https://phabricator.wikimedia.org/T152301#2845019 (10Platonides) [00:37:04] Most likly a bug in wikibugs, is there a task on this? [00:37:25] Should probaly make that task high priority to fix duplicate wikibugs in irc. [00:38:03] I don't think it's high priority, it so happens that the way it's structured means it can handle multiple IRC jobs running [00:38:15] I just don't know why it ends up with multiple running [00:38:34] * ayden figures out how to use /me [00:38:45] * Platonides congratulates ayden [00:38:55] as you see, I was talking to you [00:39:10] then writing to https://phabricator.wikimedia.org/T152301 [00:39:15] but keeping an eye on this window [00:39:44] and also changing to other channels [00:39:56] it's also very common that people is doing something [00:40:03] and only occasionally looking at the channel [00:40:26] a common mistake by new users is expecting that people will answer immediately [00:40:35] and then leaving [00:40:36] with 190 people in here I'm guessing most people are not looking that often [00:40:42] hehe [00:40:50] and in many different timezones, too! [00:40:53] plenty of idling [00:41:11] alright [00:41:12] while with some waiting, they may have had an anser [00:41:16] that, too [00:41:23] I'll leave shortly, too :P [00:41:29] while keeping the client connected [00:41:37] it's coming up on 2AM there isn't it? [00:41:42] yep [00:41:52] for me, its like 8pm [00:41:55] and it has been a long day [00:42:02] me too [00:42:11] to be fair, I don't review what everyone said on every channel when I reconnect [00:42:31] although I do look what people wanted of me when I was mentioned [00:43:36] I wouldn't hold it against you if you didnt see something that I said, it seems rather difficult to check everything [00:44:20] (03PS1) 10Legoktm: Use Timeout.timeout instead of deprecated Object#timeout [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/325142 (https://phabricator.wikimedia.org/T152231) [00:45:39] Krenair: it should kill the duplicate one when it restarts, but this gives us better flood protection so I'm not inclined to fix it very much... [00:45:57] (03CR) 10jenkins-bot: [V: 04-1] Use Timeout.timeout instead of deprecated Object#timeout [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/325142 (https://phabricator.wikimedia.org/T152231) (owner: 10Legoktm) [00:46:06] yeah [00:46:38] 10MediaWiki-General-or-Unknown: Print collapsible elements expanded - https://phabricator.wikimedia.org/T152330#2845026 (10Legoktm) Probably referring to jquery.collapsible. [00:52:50] good night [00:54:27] night [00:55:41] (03CR) 10Legoktm: "recheck" [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/325142 (https://phabricator.wikimedia.org/T152231) (owner: 10Legoktm) [01:16:58] (03CR) 10Raimond Spekking: [C: 032] Add $magicWords translation for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/322614 (https://phabricator.wikimedia.org/T151134) (owner: 10Pmlineditor) [01:22:40] 10MediaWiki-extensions-SimpleSAMLphp: Mediawiki 1.27 and simplesamlphp - https://phabricator.wikimedia.org/T152153#2845038 (10Peteolsen) Cindy, Once I do get this working, :) How do I assign users into groups based on their attrs? Thanks, Pete. [01:26:24] 10MediaWiki-extensions-PoolCounter, 10Continuous-Integration-Config: PoolCounter daemon CI tests should use dependencies from debian, not bundler - https://phabricator.wikimedia.org/T152338#2845039 (10Legoktm) [01:27:20] (03Merged) 10jenkins-bot: Add $magicWords translation for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/322614 (https://phabricator.wikimedia.org/T151134) (owner: 10Pmlineditor) [01:35:05] 10MediaWiki-Vagrant: Warning: could not look up qualified variable 'restbase::port'; class restbase has not been evaluated - https://phabricator.wikimedia.org/T152183#2845057 (10bd808) It looks like there are missing require/include statements to ensure that `::restbase` has been processed by Puppet before `serv... [01:35:25] (03CR) 10Legoktm: "I *think* the test failure is due to T152338 but my ruby-fu isn't that strong." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/325142 (https://phabricator.wikimedia.org/T152231) (owner: 10Legoktm) [01:36:11] 10MediaWiki-Vagrant, 06Reading-Web-Backlog: Add vagrant roles for reading services - https://phabricator.wikimedia.org/T152036#2836160 (10bd808) >>! In T152036#2839850, @jhobs wrote: > @Jdlrobson do we have to ping anyone specifically to get this going, or is the fact that you added #mediawiki-vagrant enough?... [01:42:37] 10MediaWiki-General-or-Unknown: Print collapsible elements expanded - https://phabricator.wikimedia.org/T152330#2845062 (10VictorPorton) I refer to [[https://www.mediawiki.org/wiki/Manual:Collapsible_elements|collapsible elements]]. Print "[Collapse]" button in the first example and then do Print or Print Previ... [01:47:15] 10Wikimedia-General-or-Unknown, 07Tracking: Bengali Wiki projects (tracking) - https://phabricator.wikimedia.org/T42760#2845066 (10MarcoAurelio) [01:47:17] 10MediaWiki-Internationalization, 13Patch-For-Review: $magicWords translation in Bengali - https://phabricator.wikimedia.org/T151134#2845063 (10MarcoAurelio) 05Open>03Resolved p:05Triage>03Normal a:03Pmlineditor [01:47:38] 04(no projects): Expand/collapse scrolling view - https://phabricator.wikimedia.org/T152326#2845067 (10VictorPorton) The "underlying problem" is to reduce long text (or images) fragments into small (scrollable) space but with the possibility to expand to show the full text (without scrolling) when required or d... [01:48:28] 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth: Problems provisioning the centralauth vagrant role - https://phabricator.wikimedia.org/T146443#2845069 (10bd808) 05Open>03declined I'm going to close this as declined because there is no way to debug what went wrong with the given information. I hav... [01:48:45] Hello everyone :) [01:49:08] 10MediaWiki-Vagrant: Make it easy to point Vagrant to an existing MediaWiki checkout - https://phabricator.wikimedia.org/T51319#2845071 (10bd808) p:05Normal>03Low [02:03:14] (03PS1) 10BryanDavis: Link to 2017 wiki for FAQ [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325147 [02:11:01] (03PS2) 10Legoktm: Link to 2017 wiki for FAQ [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325147 (owner: 10BryanDavis) [02:11:06] (03CR) 10Legoktm: [C: 032] Link to 2017 wiki for FAQ [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325147 (owner: 10BryanDavis) [02:13:22] (03Merged) 10jenkins-bot: Link to 2017 wiki for FAQ [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325147 (owner: 10BryanDavis) [02:13:43] (03CR) 10Legoktm: [C: 032] Add integration test for MWHttpRequest user/pass options [core] - 10https://gerrit.wikimedia.org/r/325136 (owner: 10Gergő Tisza) [02:15:07] (03PS2) 10Legoktm: registration: Provide credits information to callbacks [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) [02:16:10] (03PS1) 10BryanDavis: Use Special::MyLanguage when linking to wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) [02:16:47] (03CR) 10Legoktm: registration: Provide credits information to callbacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:17:14] (03CR) 10jenkins-bot: [V: 04-1] registration: Provide credits information to callbacks [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:17:52] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:18:09] (03CR) 10jenkins-bot: [V: 04-1] Use Special::MyLanguage when linking to wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) (owner: 10BryanDavis) [02:19:07] (03CR) 10BryanDavis: "CI failure is an unrelated DNS barf ("scandium.eqiad.wmnet: Name or service not known")" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) (owner: 10BryanDavis) [02:19:33] I think labs DNS just fell over [02:19:47] yep [02:19:48] [18:16:59] PROBLEM - Host labservices1001 is DOWN: CRITICAL - Host Unreachable (208.80.155.117) [02:19:48] [18:17:00] PROBLEM - Host labs-ns0.wikimedia.org is DOWN: CRITICAL - Host Unreachable (208.80.155.117) [02:19:48] [18:17:39] PROBLEM - Host 208.80.155.118 is DOWN: CRITICAL - Host Unreachable (208.80.155.118) [02:20:17] (03PS1) 10VolkerE: Add Webkit hack to `transition` mixin [core] - 10https://gerrit.wikimedia.org/r/325149 [02:21:11] (03CR) 10jenkins-bot: [V: 04-1] Add integration test for MWHttpRequest user/pass options [core] - 10https://gerrit.wikimedia.org/r/325136 (owner: 10Gergő Tisza) [02:22:20] (03PS2) 10VolkerE: Add Webkit hack to `transition` mixin [core] - 10https://gerrit.wikimedia.org/r/325149 [02:24:53] (03CR) 10jenkins-bot: [V: 04-1] Add Webkit hack to `transition` mixin [core] - 10https://gerrit.wikimedia.org/r/325149 (owner: 10VolkerE) [02:42:44] (03CR) 10BryanDavis: "recheck" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) (owner: 10BryanDavis) [02:44:26] 10UI-Standardization, 13Patch-For-Review, 13Patch-Needs-Improvement, 15User-Ladsgroup: Convert Special:UserRights to OOUI - https://phabricator.wikimedia.org/T117884#2845097 (10Volker_E) [02:57:03] 04(no projects): labservices1001 down - https://phabricator.wikimedia.org/T152340#2845101 (10fgiunchedi) [02:59:26] 10Phabricator, 10Security-Reviews, 10Striker, 13Patch-For-Review: Unable to mirror repository from git.legoktm.com into diffusion - https://phabricator.wikimedia.org/T143969#2845116 (10mmodell) T146055 improves the situation slightly by isolating the db credentials which are readable by the phd user from t... [03:31:44] (03CR) 10VolkerE: "Layout-wise there are still a few things that need some love:" [core] - 10https://gerrit.wikimedia.org/r/225536 (https://phabricator.wikimedia.org/T117884) (owner: 10Florianschmidtwelzow) [03:31:47] (03PS1) 10Legoktm: profiler: Support tideways for PHP7 profiling [core] - 10https://gerrit.wikimedia.org/r/325150 (https://phabricator.wikimedia.org/T152186) [03:31:52] (03CR) 10VolkerE: [C: 04-1] Use OOUI for Special:UserRights [core] - 10https://gerrit.wikimedia.org/r/225536 (https://phabricator.wikimedia.org/T117884) (owner: 10Florianschmidtwelzow) [03:34:12] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages: Deleted diffs result in blank page (HTTP 200 OK) when one revision is suppressed - https://phabricator.wikimedia.org/T150617#2845125 (10Krenair) @legoktm ran the request (he has a local admin flag, I prefer not to mess with that kind of thing to test bu... [03:34:14] (03CR) 10VolkerE: [C: 04-1] "As I said above, 192x192 is the safe bet currently." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) (owner: 10Rudloff) [03:37:00] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages: Deleted diffs result in blank page (HTTP 200 OK) when one revision is suppressed - https://phabricator.wikimedia.org/T150617#2845127 (10Krenair) The relevant caller is this from SpecialUndelete::showDiff: ```$formattedDiff = $diffEngine->generateContent... [03:48:23] (03PS1) 10Jack Phoenix: [WIP] Version 1.4: Special:RegexBlock is now more of a Special:Block copy [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325151 (https://phabricator.wikimedia.org/T152260) [04:06:10] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2845146 (10Catrope) >>! In T152122#2844144, @Ejegg wrote: > A watched pot nev... [04:10:46] (03PS2) 10Catrope: Add help icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325104 (owner: 10Cenarium) [04:12:27] (03CR) 10Catrope: [C: 032] Add help icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325104 (owner: 10Cenarium) [04:23:59] (03Merged) 10jenkins-bot: Add help icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325104 (owner: 10Cenarium) [04:43:54] (03PS1) 10BryanDavis: Bump wikimedia/slimapp to v0.8.0 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325153 [04:43:56] (03PS1) 10BryanDavis: Update 3rd-party js and css [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325154 [04:43:58] (03PS1) 10BryanDavis: Move custom js to file and tighten CSP rules [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325155 [04:46:03] (03CR) 10jenkins-bot: [V: 04-1] Update 3rd-party js and css [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325154 (owner: 10BryanDavis) [04:46:08] (03CR) 10jenkins-bot: [V: 04-1] Move custom js to file and tighten CSP rules [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325155 (owner: 10BryanDavis) [04:50:28] 10MediaWiki-extensions-CLDR, 06Language-Team, 10Wikidata, 07I18n: Add English names for languages which don't yet have one - https://phabricator.wikimedia.org/T151269#2845148 (10Liuxinyu970226) Thanks for adding zh-mo, since there's some differences between Hong Kong and Macau words pointed on zhwiki. I d... [05:00:07] (03CR) 10BryanDavis: [C: 031] "Changes here look good. I haven't tested with Tideways installed to see if the profiling actually works." [core] - 10https://gerrit.wikimedia.org/r/325150 (https://phabricator.wikimedia.org/T152186) (owner: 10Legoktm) [05:19:32] legoktm: ping! [05:19:40] hi subins2000 [05:20:06] (03CR) 10Legoktm: "I think php-tideways can be installed from https://deb.sury.org/ and it's also in debian unstable. I put:" [core] - 10https://gerrit.wikimedia.org/r/325150 (https://phabricator.wikimedia.org/T152186) (owner: 10Legoktm) [05:20:11] I have a question about this : https://gerrit.wikimedia.org/r/#/c/325090/ [05:20:56] If there are so many calls to $this->getLinkRenderer() should I set a class private variable as $this->getLinkRenderer() and use that variable [05:20:56] what's your question? [05:21:03] oh [05:21:23] well, it's already set as a private class variable, but it's lazy loaded [05:21:49] so it's best to just do something like $linkRenderer = $this->getLinkRenderer(); for each function that uses it multiple times [05:21:50] Should I set it in __construct() ? [05:22:08] Ok :) [05:22:14] Thanks :) [05:33:59] (03PS6) 10Subins2000: Replaced Linker::link() and Linker::linkKnown() usage with LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) [05:35:41] legoktm: Did it ^ [05:59:02] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:00:01] subins2000: looks good, it's running the full tests now, if those pass I'll approve it [06:03:25] Great ! :D [06:09:07] (03PS7) 10Legoktm: Replaced Linker::link() usage with LinkRenderer in some special pages [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:09:13] (03CR) 10Legoktm: [C: 032] "Nice work!" [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:09:49] subins2000: can you submit the task on the GCI website so I can approve it? [06:09:58] (03PS3) 10EBernhardson: [WIP] Port learn to rank from solr cloud [search/extra] - 10https://gerrit.wikimedia.org/r/324852 [06:10:47] legoktm: I marked it https://codein.withgoogle.com/dashboard/task-instances/5010170084065280/ [06:11:19] approved :) [06:11:22] legoktm: Thanks :) [06:11:42] there's another task for doing the same conversion in an extension if you're interested [06:19:40] (03Merged) 10jenkins-bot: Replaced Linker::link() usage with LinkRenderer in some special pages [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:19:57] legoktm: I'm interested [06:20:05] legoktm: Let me look it up [06:20:41] legoktm: Claimed that task ! [06:20:44] :)) [06:24:03] (03CR) 10Legoktm: [C: 032] Add integration test for MWHttpRequest user/pass options [core] - 10https://gerrit.wikimedia.org/r/325136 (owner: 10Gergő Tisza) [06:24:22] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [06:31:51] (03Merged) 10jenkins-bot: Add integration test for MWHttpRequest user/pass options [core] - 10https://gerrit.wikimedia.org/r/325136 (owner: 10Gergő Tisza) [06:34:21] 10MediaWiki-extensions-ORES, 10Wikimedia-Extension-setup, 15User-Ladsgroup, 15User-Urbanecm: Enable ORES on Czech wikipedia - https://phabricator.wikimedia.org/T151611#2845154 (10Wesalius) @Ladsgroup The target of 250000 at tools.wmflabs.org/dexbot/tools/wikilabels_stats.php doesnt seem appropriate :-) [06:50:55] 06Developer-Relations (Oct-Dec-2016), 10Phabricator (Upstream), 07Upstream: Complete the round of Phabricator improvements funded by Wikimedia - https://phabricator.wikimedia.org/T136213#2845159 (10mmodell) [06:50:58] 10Phabricator (Upstream), 07Upstream: Projects dropdown should offer project descriptions - https://phabricator.wikimedia.org/T234#2845156 (10mmodell) 05Open>03stalled a:05mmodell>03None See upstream discussion: https://secure.phabricator.com/T11034#201013 [06:52:21] 10Phabricator, 06Labs, 07Puppet: Phabricator labs puppet role configures phabricator wrong - https://phabricator.wikimedia.org/T131899#2845162 (10mmodell) @paladox: is this now working on phab-01? [06:53:04] 10Phabricator, 06Labs, 07Puppet: Phabricator labs puppet role configures phabricator wrong - https://phabricator.wikimedia.org/T131899#2845163 (10mmodell) a:05mmodell>03None rather, the main role now works on labs, correct? [07:06:32] 10Phabricator: List acl* projects at the bottom of project lists - https://phabricator.wikimedia.org/T95950#2845170 (10mmodell) 05Open>03declined [07:11:02] 10MediaWiki-extensions-ORES, 10Wikimedia-Extension-setup, 15User-Ladsgroup, 15User-Urbanecm: Enable ORES on Czech wikipedia - https://phabricator.wikimedia.org/T151611#2845171 (10Ladsgroup) It should be only 5000, there is something wrong. I check [07:18:09] 10Phabricator: List acl* projects at the bottom of project lists - https://phabricator.wikimedia.org/T95950#2845172 (10mmodell) fwiw I filtered acl projects from the list of 5 on users' profile pages, this may partially address the problem described here. [07:34:43] 10Phabricator: Custom task form for #WMF-NDA - https://phabricator.wikimedia.org/T142516#2845174 (10mmodell) >>! In T142516#2547454, @Danny_B wrote: > That of course makes sense, I was confused by the name and icon. Therefore for the sake of consistency it should be {icon lock color=red} acl*NDA-all. I don't th... [07:35:31] 10Phabricator: List acl* projects at the bottom of project lists - https://phabricator.wikimedia.org/T95950#2845176 (10mmodell) [07:35:33] 10Phabricator, 06Project-Admins: Create policy projects and convert people projects to open - https://phabricator.wikimedia.org/T90491#2845175 (10mmodell) [07:36:48] (03PS1) 10Legoktm: Get rid of $wgFlowGroupPermissions hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325156 [07:37:41] (03PS1) 10Legoktm: Remove duplicate $wgAvailableRights additions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325157 [07:39:40] 10Phabricator: Custom task form for #WMF-NDA - https://phabricator.wikimedia.org/T142516#2537654 (10Legoktm) > Per discussion in -staff and -devtools just now Could you please summarize those discussions on this task? [07:45:47] (03CR) 10jenkins-bot: [V: 04-1] Get rid of $wgFlowGroupPermissions hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325156 (owner: 10Legoktm) [07:46:00] (03CR) 10jenkins-bot: [V: 04-1] Remove duplicate $wgAvailableRights additions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325157 (owner: 10Legoktm) [07:47:43] (03PS2) 10Legoktm: Remove duplicate $wgAvailableRights additions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325157 [07:47:46] (03PS2) 10Legoktm: Get rid of $wgFlowGroupPermissions hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325156 [07:48:08] hello guys [07:52:05] hello [07:53:03] hi victorbarbu [07:53:12] what's up legoktm? [07:53:21] it's late :P [07:53:32] you are in US right? [07:53:46] yes [07:53:55] oh [07:53:56] 11:53pm here [07:53:57] nice [07:54:03] I am on GMT+2.00 [07:54:08] romania [08:08:24] Is anybody here? [08:09:24] hi harpreet [08:11:14] hi leogoktm [08:12:19] can you review my task? [08:14:20] can you reply/. [08:14:35] harpreet, who's your mentor? [08:14:45] harpreet: link? [08:18:04] legoktm: @return string name: "Certainly the variable name means absolutely nothing at this point" -> "@return string name of thing" Nice solution! :D [08:18:20] (03CR) 10Florianschmidtwelzow: [C: 032] registration: Provide credits information to callbacks [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [08:18:36] i am giving it. [08:19:31] (03CR) 10Florianschmidtwelzow: registration: Don't let extensions load lately (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [08:19:33] "Get onto Internet Relay Chat (IRC) and stay for a while (Wikimedia)" is my task [08:20:49] https://storage.googleapis.com/codein-prod.appspot.com/gci-2016/core_taskupdate/doc/6310880052510720_1480826191_Untitled.png?Expires=1480925954&GoogleAccessId=codein-prod%40appspot.gserviceaccount.com&Signature=eJ82hzF%2B9rrOT6Chg42H030luw6bMEQR6yTcGSCBeS4deqViOw%2F52N8kjEJik1gmOY%2BxAEcptNT%2BEICdj%2FvwGydxme0hPgeP3UepNqsFMutcgje%2FtS622hAGEH6dTJ%2BDYCIi5WWN1tCw3cQyngQytwCAw2E%2B%2F9rfM%2F3vleF%2FTi5uE%2FACt%2Bh%2Fg7uIXcGIIH1n%2FWlcadxy5tPZR9nk [08:20:51] mFUPUwciyZO4w6FT7X%2FZpa7fK10p%2B9dH%2F2s6hnfl0zjlI71Hor8Jyo5PXHLvufmtGgqYoHESZhy3bkFKn0Yf7DRRoC8Rl6mYw2RP%2By8Hk46Mau1QiNG2OjToS7Mz%2BEtFQcfAGg%3D%3D [08:21:00] it is link [08:21:19] (03PS4) 10Florianschmidtwelzow: registration: Don't let extensions load lately [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) [08:21:46] FlorianSW, hello! [08:22:00] victorbarbu: hi! :) [08:22:08] what's up? [08:22:21] reply please [08:23:30] victorbarbu: anything is fine, and on your side? :P :) [08:23:47] FlorianSW, working on that conversion [08:23:53] have seen what I did? [08:24:36] the "collapse" thing? [08:24:41] Not now, as I'm just looking at some stuff in the morning, sorry :) Bigger things (and your task is really a big thing) isn't my focus now :( (Just because of no time) [08:24:54] harpreet: IRC means patience ;) [08:25:12] (If anyone now says "I thought IRC means internet relay chat", I will be a bit angry :P) [08:25:31] ha ha [08:25:49] :) [08:29:06] (03CR) 10jenkins-bot: [V: 04-1] registration: Don't let extensions load lately [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [09:11:53] 04(no projects): InternetArchiveBot reversing manual corrections - https://phabricator.wikimedia.org/T152343#2845207 (10Patrug) [09:13:18] 04(no projects): InternetArchiveBot reversing manual corrections - https://phabricator.wikimedia.org/T152343#2845218 (10Patrug) [09:49:09] (03PS4) 10Samwilson: Add new special page for searching assessments [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/324657 (https://phabricator.wikimedia.org/T120407) [09:49:46] (03CR) 10Samwilson: "Thanks for reviewing. See what you think now." (033 comments) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/324657 (https://phabricator.wikimedia.org/T120407) (owner: 10Samwilson) [09:55:03] Can someone suggest me is this image-https://upload.wikimedia.org/wikipedia/commons/4/49/Screenshot_from_2016-12-04_12-50-28.png good enough for this extension-https://www.mediawiki.org/wiki/Extension:InputBox? [10:06:46] hi FlorianSW [10:14:49] I missed him :( [10:16:07] (03PS5) 10Legoktm: registration: Don't let extensions load late [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [10:17:08] (03CR) 10Legoktm: [C: 031] "Fixed spaces -> tabs, used array_keys() in exception so we get the path names and not timestamps, and edited the commit message a bit." [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [10:22:13] 10MediaWiki-Internationalization, 07I18n, 13Patch-For-Review: Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl - https://phabricator.wikimedia.org/T117845#2845237 (10Nemo_bis) > When these patches can generated automatically then this is fine. I don't know what you m... [10:24:33] Hi there, I'm lecafard and I'm doing Google Code-in. [10:25:47] (03CR) 10Nikerabbit: mediawiki.language: fix convertNumber( ..., true ) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [10:54:41] 10MediaWiki-File-management, 06Commons, 06Multimedia, 07Easy, and 2 others: Greyscale pngs without gAMA chunk rendered with incorrect contrast [or setting the gamma in GIMP exports to PNG] - https://phabricator.wikimedia.org/T106516#2845238 (10Billinghurst) [11:06:39] (03CR) 10Legoktm: [C: 032] Properly escape abusefilter-log-linkoncontribs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/324434 (owner: 10Nikerabbit) [11:14:37] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, and 2 others: Modify email footer to clarify that by responding one reveals their address - https://phabricator.wikimedia.org/T152242#2845239 (10AnnaMariaKoshka) @Legoktm why have you marked it as closed? I will be released 3 days aftes you marke... [11:17:35] (03Merged) 10jenkins-bot: Properly escape abusefilter-log-linkoncontribs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/324434 (owner: 10Nikerabbit) [11:17:44] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, and 2 others: Modify email footer to clarify that by responding one reveals their address - https://phabricator.wikimedia.org/T152242#2845242 (10Legoktm) >>! In T152242#2845239, @AnnaMariaKoshka wrote: > @Legoktm why have you marked it as closed?... [11:18:08] (03PS1) 10Filip: Fix "Warnings thrown up on creating a new newsletter via Special:CreateNewsletter" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325158 (https://phabricator.wikimedia.org/T150090) [11:22:49] 10Phabricator, 06Labs, 07Puppet: Phabricator labs puppet role configures phabricator wrong - https://phabricator.wikimedia.org/T131899#2845248 (10Paladox) @mmodell I haven't applied this role to phab-01 yet but I have applied it to the phabricator role so looks like it is working on labs (no failures) [11:23:20] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, and 2 others: Modify email footer to clarify that by responding one reveals their address - https://phabricator.wikimedia.org/T152242#2845249 (10AnnaMariaKoshka) @Legoktm - ok thanks. Thats mean we can be sure its work after "Verified" tag being a... [11:25:29] Hello, I'm Greymtr and I'm participating in Google Code-In. [11:27:11] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, and 2 others: Modify email footer to clarify that by responding one reveals their address - https://phabricator.wikimedia.org/T152242#2845251 (10Legoktm) >>! In T152242#2845249, @AnnaMariaKoshka wrote: > @Legoktm - ok thanks. Thats mean we can be... [11:30:26] welcome greymtr [11:30:52] irssi, great ;) [11:31:29] 10MediaWiki-extensions-CategoryTree: PHP Notice: Use of undefined constant CT_MODE_PAGES - assumed 'CT_MODE_PAGES' under MW 1.28 - https://phabricator.wikimedia.org/T152294#2845254 (10Pspviwki) [11:35:10] (03CR) 10Raimond Spekking: [C: 04-1] "Please sort 'bn' before 'br'" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) (owner: 10Aftab) [11:36:40] (03CR) 10Mobrovac: [C: 032] Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) (owner: 10Jdlrobson) [11:39:38] (03Merged) 10jenkins-bot: Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) (owner: 10Jdlrobson) [11:41:28] 10MediaWiki-extensions-Score, 06Community-Liaisons, 10VisualEditor, 07Documentation, 03Google-Code-In-2016: Make a new section for musical scores in the user guide for VisualEditor - https://phabricator.wikimedia.org/T117437#2845256 (10Aklapper) 05Open>03Resolved a:05Whatamidoing-WMF>03None Thank... [11:49:04] (03CR) 10Mobrovac: [C: 04-1] Edit stream should replay edits up to the maximum age (031 comment) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323490 (owner: 10Jdlrobson) [11:49:09] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, and 2 others: Modify email footer to clarify that by responding one reveals their address - https://phabricator.wikimedia.org/T152242#2845260 (10AnnaMariaKoshka) @Legoktm - ok - after you leave the comment here - I will test it on ru wiki. Cause I... [11:53:28] (03CR) 10Mobrovac: [C: 04-1] Use datacenter1 in development config for compatibility with Vagrant (031 comment) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323238 (owner: 10Jdlrobson) [12:00:28] How to use the same IRC nick on 2 PCs? I can't use mt nick here (rlot_) [12:00:47] Guest5322, that is intentional. [12:01:06] It's not supported [12:01:22] (Interesting idea though, especially as nowadays many services do allow this.) [12:01:51] The usual way is to run irssi on a machine and ssh into it from the others [12:02:29] Its good idea! i'll run it on my RPI [12:09:36] (03CR) 10Mvolz: [C: 04-1] "So close!" (035 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [12:17:04] (03PS6) 10Rudloff: Add a webapp manifest [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) [12:18:19] (03CR) 10Rudloff: "I just noticed that getimagesize() is available even without the GD extension so I updated my patch to detect the icon size and type autom" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) (owner: 10Rudloff) [12:20:12] (03CR) 10Reedy: Improve code readability in Quiz extension by reformatting code (035 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [12:22:18] (03PS1) 10Mobrovac: Update trending-edits to 29a9e6a [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/325159 [12:23:09] (03CR) 10Mobrovac: [C: 032 V: 032] Update trending-edits to 29a9e6a [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/325159 (owner: 10Mobrovac) [12:27:10] (03CR) 1001tonythomas: [C: 032] "Works. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325158 (https://phabricator.wikimedia.org/T150090) (owner: 10Filip) [12:28:19] (03Merged) 10jenkins-bot: Fix "Warnings thrown up on creating a new newsletter via Special:CreateNewsletter" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325158 (https://phabricator.wikimedia.org/T150090) (owner: 10Filip) [12:28:19] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2845262 (10Phantom42) [12:32:32] Hi [12:44:48] (03PS6) 10Aftab: adding CategoryTree.i18n.magic $magicWords translations for bengali [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) [12:45:56] Hello everybody! Can you tell me please: in case I have questions about GCI task where is it better to ask: on related Phab page or on the GCI task page? [12:46:12] Hey There Everyone. My name is Jai. I am an GCI contestant. [12:46:29] Looking for some help on coding for terasology. [12:50:33] Phantom42, better to ask on the Phabricator task, as many of MW mentors does not have access to your conversation on the GCI task [12:51:13] Jai: This is mediawiki organization channel. You need to join terasology chat: #terasology [12:51:27] ok thanks [12:51:39] divadsn: thank you [12:55:11] Phantom42, no problem :) [12:59:11] 10MediaWiki-Vagrant, 15User-mobrovac: Warning: could not look up qualified variable 'restbase::port'; class restbase has not been evaluated - https://phabricator.wikimedia.org/T152183#2845265 (10mobrovac) p:05Triage>03Normal a:03mobrovac [12:59:26] (03PS1) 10Mobrovac: service::node: Set a default for ::restbase::port [vagrant] - 10https://gerrit.wikimedia.org/r/325160 (https://phabricator.wikimedia.org/T152183) [12:59:52] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2845271 (10Phantom42) It looks like some maintenance scripts do not... [13:03:33] (03CR) 10KartikMistry: [C: 031] "Not tested. Code LGTM." [vagrant] - 10https://gerrit.wikimedia.org/r/325160 (https://phabricator.wikimedia.org/T152183) (owner: 10Mobrovac) [13:20:42] (03PS2) 10Reedy: OAuth -> OATH for used tokens memcache [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/323381 (https://phabricator.wikimedia.org/T151536) (owner: 10TheDJ) [13:20:46] (03CR) 10Reedy: [C: 032] OAuth -> OATH for used tokens memcache [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/323381 (https://phabricator.wikimedia.org/T151536) (owner: 10TheDJ) [13:21:07] mvolz, I am the entire day outside my house without my laptop, can I submit changes to Gerrit from the PC of my grandparents? [13:22:00] It is running Linux Mint, so I could also clone the repo and switch to my change using git review -d :) [13:22:09] divadsn: yup, you can add multiple ssh keys to gerrit [13:22:43] Good, I will try my best :D [13:22:59] (03Merged) 10jenkins-bot: OAuth -> OATH for used tokens memcache [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/323381 (https://phabricator.wikimedia.org/T151536) (owner: 10TheDJ) [13:23:35] mvolz: But there is a newer comment on the change by Reedy, did you have seen that? [13:26:39] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2845279 (10Reedy) >>! In T152139#2845271, @Phantom42 wrote: > It loo... [13:31:23] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-CXserver, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 4 others: Enable Scap3 config deploys for CXServer - https://phabricator.wikimedia.org/T147634#2845280 (10mobrovac) Tuesday 2016-12-06? [13:32:45] addshore: did you get my message on GCI? [13:36:47] (03PS5) 10Reedy: Don't allow scratch tokens when enrolling for 2 auth. [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) (owner: 10TheDJ) [13:39:45] Hi [13:39:47] ca [13:40:00] How ca i add translatable message to wikimedia? [13:40:24] rlot2_: Generally, you shouldn't be adding untranslateable ones at all [13:40:44] rlot2_: And I presume you mean MediaWiki (the software) [13:42:11] Yes, how can i add message to be translatable? I need to add something to translate window, but i don't have anything to translate [13:42:16] (I mean messages) [13:42:35] https://upload.wikimedia.org/wikipedia/commons/c/cb/Translate_manual_-_Translate_example_-_07._Editor_assistant.png [13:42:37] You need to add them to the en.json file [13:43:05] In languages/i18n/ [13:43:06] ? [13:43:34] hi [13:43:34] I added but it don't shows in system [13:44:10] (03PS1) 10Mobrovac: Config: Add purging parameters [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/325161 [13:44:23] rlot2_: Well, if it's for Translate, you add it to the transalte extension [13:44:37] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-CXserver, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 4 others: Enable Scap3 config deploys for CXServer - https://phabricator.wikimedia.org/T147634#2845284 (10KartikMistry) Perfect. Thanks. @mobrovac @ako... [13:44:42] (03CR) 10Mobrovac: [C: 032 V: 032] Config: Add purging parameters [services/trending-edits/deploy] - 10https://gerrit.wikimedia.org/r/325161 (owner: 10Mobrovac) [13:46:36] (03CR) 10Reedy: "So, if I play dumb, and enter a recovery code twice in a row, it seems 2FA becomes enabled anyway, and throws me to a Disable window..." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) (owner: 10TheDJ) [13:55:00] 10MediaWiki-Internationalization, 06Community-Tech, 05MW-1.29-release-notes, 07Need-volunteer, and 2 others: Add support for Bengali to IcuCollation class - https://phabricator.wikimedia.org/T148885#2845288 (10Bodhisattwa) The issue with ড, ঢ, ব, য and ড়, ঢ়, র, য় has been discussed in T7948. [13:56:21] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader: Maximum execution time exceeded via ResourceLoaderWikiModule::preloadTitleInfo( ) into Memcached - https://phabricator.wikimedia.org/T152345#2845290 (10Reedy) [14:00:38] is amire80 around? [14:07:36] (03CR) 10Reedy: [C: 04-1] "Struggling to test it on my dev wiki atm.. As getting weird timeout issues, unrelated to this" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/322009 (https://phabricator.wikimedia.org/T150824) (owner: 10TheDJ) [14:07:37] 10InternetArchiveBot: InternetArchiveBot reversing manual corrections - https://phabricator.wikimedia.org/T152343#2845304 (10Aklapper) a:03Cyberpower678 [14:13:18] (03PS1) 10Phantom42: Update maintenance script to use $this->requireExtension [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325162 (https://phabricator.wikimedia.org/T152139) [14:15:51] andre__: I'm making task "Find and remove MediaWiki code marked for removal in a past release" [14:16:11] How much code do i need to remove? [14:19:20] It can be a function [14:19:28] Or it can just be a block of code inside a function [14:19:37] Though, you can't just remove it from core if it's still used in an extension [14:19:41] You need to fix those up too [14:25:12] Its in core? I can't find anything [14:25:15] Reedy: [14:25:26] There's a lot of things in core [14:25:41] Look for anything that says @deprecated since... [14:25:48] And a version less than the current release, which is 1.28 [14:25:57] Ok, thanks! [14:26:48] 10Dumps-Generation, 06Wiktionary: Broken SQL dump of Russian Wiktionary - https://phabricator.wikimedia.org/T151133#2845308 (10Alex.dorokhov) Thank you guys! There is no issue, seems. The only thing, I had to do, is to use "raw" mysql command to import the dump, instead of relying on third-party utilities. E... [14:34:07] (03PS1) 10Filip: Removed MediaWiki code marked for removal in a past release [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) [14:34:18] 10MediaWiki-Gallery, 06Multimedia: 360 Photo support - https://phabricator.wikimedia.org/T151749#2845313 (10Ahm_masum) into production, T138933 [14:35:06] (03PS2) 10Filip: Removed MediaWiki code marked for removal in a past release [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) [14:36:06] Reddy: Is that correct? https://gerrit.wikimedia.org/r/#/c/325163/ [14:36:16] Reedy: [14:39:07] (03CR) 10Reedy: [C: 04-1] "+1 for finding something eligible for removal. -1 for commit summary and lack of RELEASE-NOTES" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:39:18] (03Abandoned) 10Filip: Removed MediaWiki code marked for removal in a past release [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:39:28] rlot2_: Why did you abandon it? [14:39:53] (03Restored) 10Filip: Removed MediaWiki code marked for removal in a past release [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:40:12] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:40:46] Why, when i removed some files from commit, it got commited? [14:41:05] Reedy: [14:41:18] 10MediaWiki-General-or-Unknown, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review, 07Technical-Debt: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113#2845317 (10Reedy) [14:41:29] Presumably you didn't amend your commit [14:41:57] rlot2_: Sometimes git commit -a isn't the best [14:42:06] it's better to do git add on the changed files, then git commit [14:42:07] (03PS1) 10Phantom42: Update maintenance scripts to use $this->requireExtension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 [14:42:28] But i used git add [14:42:30] Wierd [14:42:33] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (owner: 10Phantom42) [14:42:45] (03CR) 10Reedy: [C: 032] Update maintenance script to use $this->requireExtension [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325162 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [14:43:57] (03CR) 10Reedy: [C: 04-1] Update maintenance scripts to use $this->requireExtension (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (owner: 10Phantom42) [14:44:15] rlot2_: Had you already git add-ed the other changes? [14:45:25] (03Merged) 10jenkins-bot: Update maintenance script to use $this->requireExtension [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325162 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [14:47:17] (03PS3) 10Filip: Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) [14:47:31] (03CR) 10jenkins-bot: [V: 04-1] Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:47:44] (03PS2) 10Phantom42: Update maintenance scripts to use $this->requireExtension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) [14:48:09] (03PS4) 10Filip: Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) [14:48:22] (03CR) 10jenkins-bot: [V: 04-1] Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:48:49] Reedy: Whats wrong with jenkins? [14:48:56] rlot2_: He's a dick [14:48:58] Let me look [14:49:21] rlot2_: needs rebasing it seems [14:49:44] your clone of MW core isn't up to date [14:50:40] Ok, let me fix it [14:51:00] It's most likly RELEASE notes causing the merge failures. [14:51:06] Probably [14:51:15] but it's generally good practice to keep your clone upto date [14:51:22] Yeh. [14:51:45] You can remove the change from the file through the web interface and then do a rebase and then re add it back [14:52:12] (03PS14) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [14:52:42] Should i reclone whole repo? [14:52:51] haha, no [14:53:14] mvolz, I was able to make these changes on my grandma's PC, new patchset should be up :) [14:53:27] I guess you haven't been using branches... So you probably have 2 commits ontop of master? [14:53:28] git pull [14:53:33] git rebase origin/master [14:53:47] Thanks! [14:54:31] There will be merge conflicts [14:54:42] so you will need to add the file shown on screen [14:54:48] by doing git add [14:54:53] then git rebase --continue [14:55:03] then you have to edit the file and remove the merge conflicts it had [14:55:31] (03PS5) 10Filip: Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) [14:55:59] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [14:58:05] (03CR) 10Divadsn: Improve code readability in Quiz extension by reformatting code (032 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [14:58:07] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [14:59:18] (03CR) 10Paladox: Update maintenance scripts to use $this->requireExtension (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [14:59:21] rlot2_, also if you did already commit a change and got stuck, you can always revert back to your change using git review -d [15:06:23] There is also a way how to revert back to a specific patchset, look here: http://stackoverflow.com/a/28514846 [15:06:48] (03PS1) 10Filip: Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) [15:07:19] (03PS2) 10Filip: Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) [15:08:04] I commited it, and it made new Change? [15:08:22] https://gerrit.wikimedia.org/r/#/c/325167/ [15:08:31] Here it comes, but i need to delete old one [15:08:55] Reedy: [15:08:58] Did you create a new commit? [15:09:23] You need to amend your last commit instead of creating a new one [15:09:46] Yes, becouse when i used --amend it shows some strange commit [15:09:52] made by jenkins (?) [15:09:58] 10MediaWiki-extensions-Lockdown: Lockdown blocks extensions relying on API interaction - https://phabricator.wikimedia.org/T148582#2845328 (10FreedomFighterSparrow) Well, according to my testing just now, backporting Daniel's [change 303369](https://gerrit.wikimedia.org/r/#/c/303369/) to REL1_27 is enough to fix... [15:10:03] You can also squash your 2 comits into one [15:10:23] ? [15:10:26] rlot2_, see here: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Squash_several_commits_into_one_single_commit_via_rebase [15:11:03] But whats about gerrit [15:11:13] it will remove old ones? [15:11:24] After that you can update your changes to a existing one. Don't forget to leave the Instance-ID of your first change! [15:11:35] rlot2_, no, but you can abandon the new change [15:12:47] I did the same mistake 2 times, look here: https://gerrit.wikimedia.org/r/#/c/324837/ [15:13:03] (03CR) 10Filip: "https://gerrit.wikimedia.org/r/#/c/325167/" [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [15:13:07] (03Abandoned) 10Filip: Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325163 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [15:13:14] (03PS1) 10Phantom42: Update maintenance scripts to use $this->requireExtension [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/325168 (https://phabricator.wikimedia.org/T152139) [15:15:00] Oh, he is using a normal IRC connection, well... :/ [15:15:31] (03CR) 10Sbisson: [C: 032] Add script to fix inconsistent state for board name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [15:15:44] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2845331 (10Phantom42) @Reedy Thank you for an explanation. I updated... [15:17:00] Maybe it would be good to leave a note about IRC that you will miss every message when you disconnect from it.. [15:18:53] (03PS3) 10Phantom42: Update maintenance scripts to use $this->requireExtension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) [15:19:50] Reedy: Heres valid gerrit patch https://gerrit.wikimedia.org/r/#/c/325167/ [15:23:50] rlot, you should maybe consider renting a IRC bouncer or installing one on a Raspberry Pi or server to never miss a messsage here :) [15:24:28] I'll do it in free time [15:24:31] Or you can use irccloud.com instead, or just install The Lounge on a server ^^ [15:24:59] rlot, I recommend you to do it in the meanwhile where your change is being reviewed ;) [15:26:03] (03Merged) 10jenkins-bot: Add script to fix inconsistent state for board name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/322223 (https://phabricator.wikimedia.org/T148057) (owner: 10Mattflaschen) [15:37:02] Hey all [15:37:22] FlorianSW: I'm having trouble uploading my patch [15:37:44] When I run git review -R and after entering my credentials, it says "fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/AbuseFilter/' [15:41:10] subins2000: it's because you've cloned via HTTPS [15:41:23] rlot: Why the new patchset? [15:42:11] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages: Deleted diffs result in blank page (HTTP 200 OK) when one revision is suppressed - https://phabricator.wikimedia.org/T150617#2845335 (10Krenair) DifferenceEngine has code to handle this sort of thing, but it wants revision IDs rather than revision objec... [15:43:06] Reedy: Yup, I used https. Does changing the URL in .git/config help ? [15:43:19] subins2000: If you need to use HTTPS, there's a different password to use [15:43:33] How can I find the SSH URL ? [15:43:35] https://gerrit.wikimedia.org/r/#/settings/http-password [15:44:21] (03PS1) 10Subins2000: Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/325169 (https://phabricator.wikimedia.org/T149346) [15:44:36] Reedy: Thanks. I got it ^ [15:45:37] yay [15:59:21] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Separate log action for moves suppressing redirects - https://phabricator.wikimedia.org/T152346#2845337 (10GeoffreyT2000) [16:03:48] (03CR) 10D3r1ck01: [C: 031] Removed deprecated class RevisiondeleteAction() [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [16:04:08] 10Wikimedia-Site-requests, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2845352 (10Krenair) So, updated list of stuff to do: * Interwiki map update - deploy https://gerrit.wikimedia.org/r/#/c/324918/ * RB patch and restart -... [16:04:30] greg-g, ^ these constant issues with wiki creations are really beginning to piss me off [16:04:53] the only set of people who can do everything needed don't [16:06:03] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Separate log action for moves suppressing redirects - https://phabricator.wikimedia.org/T152346#2845337 (10MarcoAurelio) Do you mean be able to winnow page moves in Special:Log/move using the new dropdown that allows you to filter actions? Page moves overwritting... [16:07:03] divadsn: ugh, I see that Platonides and I have been giving you completely opposite advise and have just been going back and forth on those spaces :( sorry. In retrospect we probably should have just stuck to shortening lines only and not done any other changes so that patchset wasn't so big :). Ah well. Also, most recent patchset seems to be broken, all the quizzes are showing up for me as taken . Probably one of tho [16:08:57] (03CR) 10Mvolz: [C: 04-1] "The quizzes all now show up scored, whether or not they've been taken." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [16:09:02] (03CR) 10Aude: Use Special::MyLanguage when linking to wikis (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) (owner: 10BryanDavis) [16:10:50] 06Research-and-Data: Request access to data/cluster for understanding WDQS - https://phabricator.wikimedia.org/T152023#2835737 (10Adrian_Bielefeldt) username for Adrian Bielefeldt: arnad Public ssh key for this phabricator task: {F4978176} preferred login name: Adrian_Bielefeldt [16:11:36] 10MediaWiki-extensions-Page_Forms: Special:CreateClass creates empty form and category page - https://phabricator.wikimedia.org/T152347#2845357 (10Nikerabbit) [16:11:43] mvolz, could you give me a example quiz so I can reproduce it? [16:12:04] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Modify email footer to clarify that by responding one reveals their address to the original sender - https://phabricator.wikimedia.org/T152242#2845370 (10Huji) [16:12:16] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Modify email footer to clarify that by responding one reveals their address to the original sender - https://phabricator.wikimedia.org/T152242#2842741 (10Huji) [16:12:26] any of em. :) But you can export the help:quiz page on wikiversity and then import it locally for a nice page for testing [16:12:50] 06Research-and-Data: Request access to data/cluster for understanding WDQS - https://phabricator.wikimedia.org/T152023#2835737 (10Krenair) bastiononly does not exist. [16:12:52] https://en.wikiversity.org/wiki/Special:Export [16:13:37] https://en.wikiversity.org/wiki/Help:Quiz [16:13:50] import link on your dev wiki will be under "special pages" link on the left [16:23:18] (03PS1) 10Reedy: Remove Notifications, deleted from gerrit [extensions] - 10https://gerrit.wikimedia.org/r/325171 [16:23:32] (03CR) 10Reedy: [C: 032 V: 032] Remove Notifications, deleted from gerrit [extensions] - 10https://gerrit.wikimedia.org/r/325171 (owner: 10Reedy) [16:25:51] (03PS2) 10Subins2000: Replaced Linker::link() & Linker::linkKnown() with LinkRenderer [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/325169 (https://phabricator.wikimedia.org/T149346) [16:28:45] Reedy: I made commit from another computer, and new gerrit made new pachset [16:29:00] (03CR) 10Divadsn: "That's strange, will see it on my test machine home." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [16:29:07] Reedy: It is alright now? Is task done? [16:37:16] rlot: If you change to another computer, you can just do git review -d 12345 [16:37:23] where 12345 is to get the patch onto that computer [16:40:45] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 [16:46:46] (03PS3) 10Reedy: Removed deprecated class RevisiondeleteAction [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [16:46:51] (03PS4) 10Reedy: Removed deprecated class RevisiondeleteAction [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [16:46:55] (03CR) 10Reedy: [C: 032] Removed deprecated class RevisiondeleteAction [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [16:49:03] rlot: When gerrit has merged it, I'll approve it on gci [16:59:36] (03Merged) 10jenkins-bot: Removed deprecated class RevisiondeleteAction [core] - 10https://gerrit.wikimedia.org/r/325167 (https://phabricator.wikimedia.org/T61113) (owner: 10Filip) [17:01:05] (03PS1) 10Reedy: Remove PipVideoJs as deleted [extensions] - 10https://gerrit.wikimedia.org/r/325172 [17:01:23] (03CR) 10Reedy: [C: 032 V: 032] Remove PipVideoJs as deleted [extensions] - 10https://gerrit.wikimedia.org/r/325172 (owner: 10Reedy) [17:03:53] 10MediaWiki-General-or-Unknown, 07Easy, 03Google-Code-In-2016, 05MW-1.29-release-notes, and 2 others: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113#2845402 (10Reedy) [17:08:21] 10Phabricator: Allow workboard columns to have a description that is displayed as a hover box - https://phabricator.wikimedia.org/T152349#2845404 (10scfc) [17:09:23] 10Wikimedia-Site-requests, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2845417 (10Acer) Also, Finnish needs to be added to the Wikivoyage portal. (https://www.wikivoyage.org) Both the direct link and as a language option fo... [17:17:53] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Separate log action for moves suppressing redirects - https://phabricator.wikimedia.org/T152346#2845428 (10GeoffreyT2000) >>! In T152346#2845353, @MarcoAurelio wrote: > Do you mean be able to winnow page moves in Special:Log/move using the new dropdown that allow... [17:26:00] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Upon deleting a newsletter, the message shows Newsletter ID - https://phabricator.wikimedia.org/T149648#2845434 (10FilipGCI) a:03FilipGCI I'll do it for GCI. [17:31:06] 10Wikimedia-Site-requests, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2845441 (10MarcoAurelio) >>! In T151570#2845417, @Acer wrote: > Also, Finnish needs to be added to the Wikivoyage portal. (https://www.wikivoyage.org) >... [17:39:26] (03CR) 10Hashar: "Looks great :] I have added a few suggestions, feel free to ignore them though." (033 comments) [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/324693 (https://phabricator.wikimedia.org/T151879) (owner: 10Seb35) [17:39:35] (03CR) 10Hashar: "recheck" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/324693 (https://phabricator.wikimedia.org/T151879) (owner: 10Seb35) [17:42:40] 10Wikimedia-Site-requests, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2845442 (10MarcoAurelio) [[ https://meta.wikimedia.org/w/index.php?title=Www.wikivoyage.org_template&diff=16126547&oldid=15788589 | Added ]] and I'll tr... [17:47:32] 10Wikimedia-Site-requests, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Create Wikivoyage Finnish - https://phabricator.wikimedia.org/T151570#2845443 (10Acer) >>! In T151570#2845442, @MarcoAurelio wrote: > [[ https://meta.wikimedia.org/w/index.php?title=Www.wikivoyage.org_template&diff=1612654... [17:55:26] (03PS1) 10Filip: Fix "Upon deleting a newsletter, the message shows Newsletter ID" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325175 (https://phabricator.wikimedia.org/T149648) [17:57:39] 10MediaWiki-extensions-ORES, 10Wikimedia-Extension-setup, 15User-Ladsgroup, 15User-Urbanecm: Enable ORES on Czech wikipedia - https://phabricator.wikimedia.org/T151611#2845459 (10Ladsgroup) labels_per_task was set 50 mistakenly instead of 1. It's fixed now. You only need to label 5000 edits now. [17:59:06] Hi, my name is Ekesh. I am participating in Google Code-In 2016. I'm a high school student from the United States and my favorite subjects are Math and Computer Science. In my free time, I like to play the piano and play chess. [18:03:22] ekesh: Welcome! Hope that you find good moments. See andre__ if you have questions with regards to tasks, etc. He's the pro :) [18:03:46] thank you =) [18:06:37] hi ekesh and welcome! [18:15:22] (03PS1) 10Fomafix: Use [] instead of array() syntax for PHP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/325177 [18:21:51] 10MediaWiki-extensions-Scribunto, 15User-Dereckson: Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2844376 (10Anomie) Regarding the pcntl functions, there's also https://gerrit.wikimedia.org/r/#/c/273173/ that looks to be adding a fallback using the common implementati... [18:25:54] (03CR) 10jenkins-bot: [V: 04-1] Use [] instead of array() syntax for PHP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/325177 (owner: 10Fomafix) [18:32:47] (03PS1) 10MarcoAurelio: Updated stats and added fi.wikivoyage to the www.wikivoyage.org portal [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/325178 (https://phabricator.wikimedia.org/T151570) [18:36:58] 11 minutes for a jenkins-test... [18:39:59] [18:40:54] When i change somethink in already translated message(just a char # to "), do i need to change it in all locales? [18:43:29] rlot: Yes, I believe that you need to. [18:45:13] But there's lots of files here. I think i18n should take care of it [18:45:48] actually you should avoid touching the non-English (en) localizations, most extensions as well as MediaWiki core are handled via translatewiki.net so they'll get updated there and any updates you'd make to a non-English i18n file on gerrit would simply be lost [18:46:56] ashley: For example i'm changing "Some file #$1" to "Some file \"$1\"" [18:47:21] So it's good to change only en.json like in adding some messages? [18:48:09] yeah, you're free to do whatever you need to with en.json (remember to follow the best i18n practises, they're documented _somewhere_ on MediaWiki.org...), feel free to ignore the other i18n files [18:48:59] ashley: Thanks! It's clear for me now [18:49:42] yw :) [18:56:49] (03CR) 10Raimond Spekking: [C: 032] adding CategoryTree.i18n.magic $magicWords translations for bengali [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) (owner: 10Aftab) [18:58:02] (03Merged) 10jenkins-bot: adding CategoryTree.i18n.magic $magicWords translations for bengali [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) (owner: 10Aftab) [18:58:53] (03CR) 10Legoktm: [C: 04-1] "Looks good, one minor thing" (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/325168 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [18:59:26] (03CR) 10MtDu: "@01tonythomas, Do you think we should show Newsletter:$1 to show that it is a namespace? Maybe 'Newsletter:$1' or even 'Newsletter Newslet" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325175 (https://phabricator.wikimedia.org/T149648) (owner: 10Filip) [19:00:08] (03Abandoned) 10MarcoAurelio: Create a "centralnotice-shared-help-translate' temporary [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) (owner: 10MarcoAurelio) [19:01:56] (03CR) 10Legoktm: [C: 04-1] "Minor spacing issue, looks good otherwise!" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [19:02:19] 10MediaWiki-extensions-WikimediaMessages: MediaWiki:Centralnotice-shared-help-translate: adding to WikimediaMessages temporary to fix broken massmessage - https://phabricator.wikimedia.org/T150750#2845518 (10MarcoAurelio) 05Open>03declined p:05Triage>03Lowest Self-decline since the message was fixed late... [19:08:30] (03PS4) 10Phantom42: Update maintenance scripts to use $this->requireExtension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) [19:09:16] (03CR) 10Phantom42: "Spacing issue fixed" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [19:11:50] (03PS2) 10Phantom42: Update maintenance scripts to use $this->requireExtension [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/325168 (https://phabricator.wikimedia.org/T152139) [19:13:38] (03CR) 10Phantom42: "Fixed" (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/325168 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [19:16:53] 07Design, 10UI-Standardization, 06WMDE-Design: Create OOUI mockup shapes for use in Open Source diagramming application - https://phabricator.wikimedia.org/T152099#2845524 (10Jan_Dittrich) Some implementation directions: - [[ https://github.com/jgraph/mxgraph/blob/master/javascript/examples/grapheditor/www/... [19:24:05] What does "$this->addWhereFld" mean in Api code? [19:24:17] 10MediaWiki-Vagrant: error on doing vagrant up "mount.nfs: access denied by server while mounting" in ubuntu 14.04 - https://phabricator.wikimedia.org/T78153#2845525 (10Sn1per) >>! In T78153#846323, @Sn1per wrote: > 'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.... [19:27:43] rlot, what class is this from? [19:28:17] rlot, https://github.com/wikimedia/mediawiki/blob/bddb40db1c34d4b4fd31f3227923b5bc3929f395/includes/api/ApiQueryBase.php#L258 [19:30:34] Krenair: ApiQueryUsers exacally\ [19:31:02] okay, the query modules are special [19:31:25] but here's how to answer this question in general [19:31:45] the top of that class says "class ApiQueryUsers extends ApiQueryBase {" [19:32:18] which does define the function you're looking for [19:32:24] (ApiQueryBase.php) [19:32:53] Ok, but i got it. Its for adding value to field [19:32:58] Thanks! [19:34:05] (03PS2) 10BryanDavis: Use Special::MyLanguage when linking to wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) [19:34:41] (03CR) 10BryanDavis: Use Special::MyLanguage when linking to wikis (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325148 (https://phabricator.wikimedia.org/T85533) (owner: 10BryanDavis) [19:37:35] hi [19:51:40] (03CR) 10Divadsn: "Patch set 13 works fine, so the bug is probably in the newer changes." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [20:06:38] (03PS15) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [20:11:08] mvolz, the bug was in line 36 with the string comparison, I missed it somehow. Here is why: http://stackoverflow.com/a/80649 [20:20:23] 10MediaWiki-extensions-Page_Forms: Special:CreateClass creates empty form and category page - https://phabricator.wikimedia.org/T152347#2845568 (10Kghbln) I would try switching to the Page Forms extension and see if the issue can be replicated with that one. I do not think that @Yaron_Koren will put more effort... [20:23:02] 1234 [20:23:35] 5678 [20:23:49] 910112 [20:24:11] okay [20:27:02] Why in ApiQuery theres "ususers" but in code its "users" [20:27:07] what "us" mean [20:27:09] ? [20:27:53] rlot: it's a prefix so it doesn't clash with other api modules using the same parameter name [20:28:10] every module has it's own prefix [20:30:45] How to register new parameter? [20:31:32] I can't just add detection to Query php, becouse it doesnt reconize it [20:33:01] each module has a method where all recognized parameters are defined [20:33:35] I added it, but it still returns "Unrecognized parameter: 'usids'" [20:34:54] where's the us perfix from? [[API:Listusers]]? [20:34:57] @link [20:34:57] https://www.mediawiki.org/wiki/API:Listusers [20:35:14] Its ApiQueryUsers [20:35:16] * https://www.mediawiki.org/wiki/API:Users [20:35:22] I want to add ids [20:35:59] !class ApiQueryUsers [20:35:59] See https://doc.wikimedia.org/mediawiki-core/master/php/classApiQueryUsers.html [20:36:37] ApiQueryUsers::getAllowedParams is the method where it should be defined, *without* the "us" prefix [20:37:16] Thanks you! [20:43:41] Where i need to add documentation for my api changes? [20:46:57] Depends what you're changing [20:48:06] api parameters etc are documented now in i18n messages [20:52:55] Just normal message? [20:53:17] Oh, i see [20:53:18] thanks! [21:03:33] 10MediaWiki-extensions-CodeReview: Update extension to also support git - https://phabricator.wikimedia.org/T152355#2845649 (10Paladox) [21:04:30] 10MediaWiki-extensions-CodeReview: Update extension to also support git - https://phabricator.wikimedia.org/T152355#2845662 (10Reedy) p:05Triage>03Lowest [21:04:56] 10MediaWiki-JavaScript, 13Patch-For-Review, 07Technical-Debt: [jquery.tipsy] Uses deprecated $.fn.live when using live option - https://phabricator.wikimedia.org/T69989#2845663 (10Tacsipacsi) [21:17:59] 10Wikimedia-General-or-Unknown, 07Tracking: Bengali Wiki projects (tracking) - https://phabricator.wikimedia.org/T42760#2845666 (10Aftabuzzaman) [21:18:01] 10MediaWiki-extensions-CategoryTree, 07I18n, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): adding $magicWords for bengali (CategoryTree.i18n.magic.php) - https://phabricator.wikimedia.org/T151690#2845665 (10Aftabuzzaman) 05Open>03Resolved [21:21:21] 07Design, 10MediaWiki-Watchlist, 13Patch-For-Review: Add a direct unwatch link to entries on Special:Watchlist - https://phabricator.wikimedia.org/T2424#2845671 (10MZMcBride) >>! In T2424#2469220, @Isarra wrote: > The line changing after and having the undo link there also seems like a bit much - is it reall... [21:27:55] (03CR) 1001tonythomas: [C: 032] "Works! Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325175 (https://phabricator.wikimedia.org/T149648) (owner: 10Filip) [21:29:15] (03Merged) 10jenkins-bot: Fix "Upon deleting a newsletter, the message shows Newsletter ID" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325175 (https://phabricator.wikimedia.org/T149648) (owner: 10Filip) [21:29:35] (03CR) 1001tonythomas: "@MtDu: I think that might be an overkill for that message :-(, but you got a point!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/325175 (https://phabricator.wikimedia.org/T149648) (owner: 10Filip) [21:35:34] 10MediaWiki-extensions-CodeReview, 10Wikimedia-Site-requests, 07Technical-Debt: Undeploy CodeReview - https://phabricator.wikimedia.org/T116948#2845678 (10Reedy) [21:51:07] (03CR) 10Cindy-the-browser-test-bot: "I ran tests for your patch and there were some errors: features/commons.feature:3" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325191 (owner: 10L10n-bot) [21:51:15] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/325191 (owner: 10L10n-bot) [21:51:20] (03PS2) 10Jack Phoenix: Version 1.4: Special:RegexBlock is now more of a Special:Block copy [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325151 (https://phabricator.wikimedia.org/T152260) [21:51:27] (03CR) 10Jack Phoenix: [C: 032 V: 032] Version 1.4: Special:RegexBlock is now more of a Special:Block copy [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325151 (https://phabricator.wikimedia.org/T152260) (owner: 10Jack Phoenix) [21:54:51] 10RegexBlock, 10SpamRegex: Expressions on the special pages of RegexBlock and SpamRegex should be wrapped in a element so they're rendered in a monospaced font for scanning easier - https://phabricator.wikimedia.org/T152260#2845712 (10ashley) 05Open>03Resolved [21:55:00] 10RegexBlock: List items on Special:RegexBlock should be normal font size, not 11px / 12px - https://phabricator.wikimedia.org/T152262#2845714 (10ashley) 05Open>03Resolved [21:55:16] 10RegexBlock: Form button UI that says "Block this user" should be consistent with other forms on Special:RegexBlock - https://phabricator.wikimedia.org/T152166#2845716 (10ashley) 05Open>03Resolved a:03ashley [21:55:29] 10RegexBlock: RegexBlock should allow custom expiry time input in Special:RegexBlock form - https://phabricator.wikimedia.org/T152177#2845719 (10ashley) 05Open>03Resolved [21:56:19] 07Design, 10MediaWiki-Watchlist, 13Patch-For-Review: Add a direct unwatch link to entries on Special:Watchlist - https://phabricator.wikimedia.org/T2424#2845721 (10Stevietheman) Note that this is appearing as a proposal in the 2016 Community Wishlist Survey [[ https://meta.wikimedia.org/wiki/2016_Community_W... [21:56:21] 10RegexBlock, 10SpamRegex: Consider adding an interface message containing a default list of reasons for RegexBlock and/or SpamRegex forms - https://phabricator.wikimedia.org/T152179#2845722 (10ashley) RegexBlock now^ has a default list, although currently it uses the same message as core Special:Block does, w... [21:58:13] 07Design, 10UI-Standardization, 10RegexBlock: RegexBlock should use HTMLForm and be displayed in OOJS-UI - https://phabricator.wikimedia.org/T152175#2845724 (10ashley) As of [[https://gerrit.wikimedia.org/r/325151|gerrit changeset #325151]] (RegexBlock version 1.4) RegexBlock uses HTMLForm. OOJS-UI stuff is... [22:07:39] 10SyntaxHighlight, 07HHVM: Unexpected output from Pygments encountered - https://phabricator.wikimedia.org/T151523#2845729 (10Nikerabbit) After downgrading the error went away: `dpkg: warning: downgrading hhvm from 3.15.3~trusty to 3.12.7+dfsg-1+wmf1~trusty1` @greg It seems this could affect WMF sites as well... [22:08:25] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2845731 (10Aklapper) Reedy: So, how to proceed for GCI? Could you order the grep r... [22:16:16] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Fatal error in WikibaseClient when editing a page - https://phabricator.wikimedia.org/T152357#2845736 (10Nikerabbit) [22:16:43] 10RegexBlock: RegexBlock should force users to add a reason for adding a blocked username/ip address - https://phabricator.wikimedia.org/T152259#2845750 (10ashley) So as we discussed on chat, "generic reason" in RegexBlock actually means one of the following MW: messages: * regexblock-reason-ip * regexblock-reas... [22:21:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Fatal error in WikibaseClient when editing a page - https://phabricator.wikimedia.org/T152357#2845736 (10Paladox) Caused by https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/ceb7502741b9b93cdf5d84f3c7b9ea3a31d8af45#diff-dddc331aefd35f9b98a7cc37... [22:26:28] 10Phabricator (Upstream), 07Upstream: Allow workboard columns to have a description that is displayed as a hover box - https://phabricator.wikimedia.org/T152349#2845760 (10Aklapper) p:05Triage>03Lowest > For example, the description of the column "In progress" in Tool-Labs would say "Tasks must have an ass... [22:32:11] 10MediaWiki-Categories: Natural number sorting in categories causes problem with timestamps - https://phabricator.wikimedia.org/T151319#2845773 (10Aklapper) @JAnD: Can you please clarify? [22:35:40] (03CR) 10Legoktm: [C: 032] Update maintenance scripts to use $this->requireExtension [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/325168 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [22:36:20] (03CR) 10Legoktm: [C: 032] Update maintenance scripts to use $this->requireExtension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [22:40:53] 10MediaWiki-Parser: Floating image on left covers bullet points of a list - https://phabricator.wikimedia.org/T55991#580912 (10Aklapper) >>! In T55991#1059017, @Edokter wrote: > The reported issues may seem different, but the root cause is the same, and known. ...hence merging this task into T13782 (again). [22:41:03] 10MediaWiki-Parser: Floating image on left covers bullet points of a list - https://phabricator.wikimedia.org/T55991#2845778 (10Aklapper) [22:41:05] 10MediaWiki-Parser: List indicators overlap with left floating images/blocks - https://phabricator.wikimedia.org/T13782#2845781 (10Aklapper) [22:42:15] 10MediaWiki-Parser: Date Format not always consistent - https://phabricator.wikimedia.org/T18210#2845782 (10Aklapper) [22:44:10] (03Merged) 10jenkins-bot: Update maintenance scripts to use $this->requireExtension [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/325168 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [22:44:22] 10MediaWiki-Parser: Need a way to use e.g. 01, 02... or i, ii... for numbered lists - https://phabricator.wikimedia.org/T55620#2845786 (10Aklapper) 05Open>03declined >>! In T55620#585571, brion wrote: > I don't think we'd add new syntax for this, as it's doable through existing HTML and CSS. Closing as decl... [22:44:56] (03PS4) 10EBernhardson: [WIP] Port learn to rank from solr cloud [search/extra] - 10https://gerrit.wikimedia.org/r/324852 [22:45:13] (03Merged) 10jenkins-bot: Update maintenance scripts to use $this->requireExtension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325165 (https://phabricator.wikimedia.org/T152139) (owner: 10Phantom42) [22:47:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Port learn to rank from solr cloud [search/extra] - 10https://gerrit.wikimedia.org/r/324852 (owner: 10EBernhardson) [22:51:07] 10MediaWiki-Parser: Easier syntax for ul tags with attributes (Ease creating collapsible lists) - https://phabricator.wikimedia.org/T152301#2845796 (10Aklapper) p:05Triage>03Low [22:53:13] 10MediaWiki-General-or-Unknown: Create widget that provide small scrollbox with "preview" content when collapsed and full text (without scrolling) when expanded - https://phabricator.wikimedia.org/T152326#2845797 (10Aklapper) p:05Triage>03Lowest [22:55:56] (03CR) 10Legoktm: [C: 04-1] "See inline comments. Of the three message output formats (text, escaped, parse), text and escaped are the same, except escaped also does h" (0311 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/325169 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [23:09:44] (03CR) 10Cenarium: "Forgot to mention that I also used the diff as primary link rather than the help page, mostly to be consistent with the review notificatio" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316957 (owner: 10Cenarium) [23:28:09] teleport me to T152075 [23:28:10] T152075: Automatic use of fake user agent for bot-unfriendly sites - https://phabricator.wikimedia.org/T152075 [23:36:00] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2845811 (1001tonythomas) [23:36:02] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Upon deleting a newsletter, the message shows Newsletter ID - https://phabricator.wikimedia.org/T149648#2845809 (1001tonythomas) 05Open>03Resolved Thank you! [23:36:37] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2401078 (1001tonythomas) [23:36:41] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Warnings thrown up on creating a new newsletter via Special:CreateNewsletter - https://phabricator.wikimedia.org/T150090#2845824 (1001tonythomas) 05Open>03Resolved a:03FilipGCI Thank you! [23:37:48] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Wrong Return-To URL in Special:Newsletter/xx/unsubscribe - https://phabricator.wikimedia.org/T150097#2845828 (1001tonythomas) 05Open>03Resolved a:03Phantom42 Thank you! [23:38:45] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Upon deleting a newsletter, do not show the subtitle navigation on top - https://phabricator.wikimedia.org/T149649#2845831 (1001tonythomas) @Aklapper : was this improted ? If not, it would be a great task there and @Devirk has agreed to mentor. I too ca... [23:42:12] 10MediaWiki-extensions-Newsletter: Remove Special:Newsletter/id/delete forms completely form Newsletter interface - https://phabricator.wikimedia.org/T152359#2845832 (1001tonythomas) [23:43:06] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remove 'delete' option from Special:Newsletter/id/actions subtitles - https://phabricator.wikimedia.org/T152360#2845844 (1001tonythomas) [23:44:56] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remoe 'delete' forms and other code from Newsletter codebase - https://phabricator.wikimedia.org/T152361#2845857 (1001tonythomas) [23:45:01] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Remove 'delete' forms and other code from Newsletter codebase - https://phabricator.wikimedia.org/T152361#2845857 (1001tonythomas) [23:45:57] 10MediaWiki-extensions-Newsletter: Adding a Publisher to a newsletter should subscribed them automatically - https://phabricator.wikimedia.org/T150614#2845874 (1001tonythomas) 05Open>03Invalid >>! In T150614#2791163, @QuimGil wrote: > Ooops, now I realized that Miraheze admins installed 1.2.0 (e0ad10a) 23:40... [23:46:43] 07Design, 10MediaWiki-extensions-Newsletter: Newsletter notifications should have a specific icon - https://phabricator.wikimedia.org/T119059#2845876 (1001tonythomas) @Akashkrishnan is there any go on this one ? If not, please un-assign so that we can make this a possible GCI task. If you are stuck at some p... [23:49:52] (03PS10) 10Cenarium: Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) [23:50:53] (03CR) 10Cenarium: "I've avoided notification of duplicate reviews." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium)