[00:01:54] 10PageImages, 06Reading-Web-Backlog, 07Wikimedia-Incident: Return free images by default - https://phabricator.wikimedia.org/T152216#2843154 (10bmansurov) [00:02:00] (03CR) 10Pmiazga: [C: 031] Edit stream should replay edits up to the maximum age [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323490 (owner: 10Jdlrobson) [00:02:41] 10SpamRegex: Create a log for SpamRegex at Special:Log/regexspam - https://phabricator.wikimedia.org/T152164#2843155 (10SamanthaNguyen) Another thing, when a person triggers the SpamRegex filter, that should be logged too (similar with AbuseFilter). Should they be separate logs? On a high-traffic wiki, and espec... [00:03:27] (03CR) 10Pmiazga: [C: 031] Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) (owner: 10Jdlrobson) [00:04:22] (03CR) 10jenkins-bot: [V: 04-1] WIP: replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 (owner: 10MaxSem) [00:05:23] (03CR) 10Smalyshev: Refactor interwiki support (035 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320625 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [00:07:06] 06Reading-Web-Backlog, 06Research-and-Data, 03Reading-Web-Sprint-87-: QuickSurvey for reader segmentation research - run multiple choice survey in more langugaes - https://phabricator.wikimedia.org/T151835#2843156 (10atgo) Hey @leila do you have an English version of the google survey you're using? That one... [00:07:09] (03CR) 10Pmiazga: [C: 031] Use Map for storing trending information [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323489 (owner: 10Jdlrobson) [00:07:16] 10MediaWiki-User-blocking, 06Community-Tech, 06Support-and-Safety, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable and test cookie blocking on English Wikipedia - https://phabricator.wikimedia.org/T152076#2843158 (10Peachey88) Have you notified the en.wikipedia community anywhere? [00:09:07] 10PageImages: Maintenance script should be more flexible - https://phabricator.wikimedia.org/T152252#2843162 (10Jdlrobson) [00:10:18] 10MediaWiki-User-blocking, 06Community-Tech, 06Support-and-Safety, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable and test cookie blocking on English Wikipedia - https://phabricator.wikimedia.org/T152076#2843174 (10MusikAnimal) >>! In T152076#2843158, @Peachey88 wrote: > Have you notified the en.w... [00:10:21] (03CR) 10Jdlrobson: Restrict page images to lead section (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [00:11:12] (03PS4) 10Smalyshev: Enable supplying inline interwiki results [core] - 10https://gerrit.wikimedia.org/r/324652 (https://phabricator.wikimedia.org/T142795) [00:13:59] 04(no projects): SpamRegex should provide a reason in the edit form when someone submits an edit but triggers the filter (in action=submit) - https://phabricator.wikimedia.org/T152253#2843175 (10SamanthaNguyen) [00:14:34] 10SpamRegex: SpamRegex should provide a reason in the edit form when someone submits an edit but triggers the filter (in action=submit) - https://phabricator.wikimedia.org/T152253#2843188 (10SamanthaNguyen) a:03ashley [00:15:20] (03PS7) 10MaxSem: WIP: replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 [00:15:23] (03PS1) 10MaxSem: WIP: return stderr [core] - 10https://gerrit.wikimedia.org/r/325063 [00:15:48] (03PS1) 10Legoktm: Include location in LintError::id() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325065 [00:16:23] (03PS1) 10Mholloway: API: Add thumbwidth property parameter to restrict size by width only [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325066 (https://phabricator.wikimedia.org/T152254) [00:17:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow time values more precise than day - https://phabricator.wikimedia.org/T57755#638782 (10sladen) I saw the following diff on my Watchlist: https://www.wikidata.org/w/index.php?title=Q21980653&curid=24012630&diff=413314375&oldid=413187600 So I thoug... [00:17:40] (03CR) 10jenkins-bot: [V: 04-1] API: Add thumbwidth property parameter to restrict size by width only [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325066 (https://phabricator.wikimedia.org/T152254) (owner: 10Mholloway) [00:17:46] 10SpamRegex: SpamRegex should provide a reason in the edit form when someone submits an edit but triggers the filter (in action=submit) - https://phabricator.wikimedia.org/T152253#2843213 (10SamanthaNguyen) [00:20:35] (03PS2) 10Mholloway: API: Add thumbwidth property parameter to restrict size by width only [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325066 (https://phabricator.wikimedia.org/T152254) [00:20:37] (03CR) 10Arlolra: [C: 032] Add integration tests for Database class [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324654 (owner: 10Legoktm) [00:21:54] (03Merged) 10jenkins-bot: Add integration tests for Database class [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324654 (owner: 10Legoktm) [00:22:06] . [00:22:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 (owner: 10MaxSem) [00:23:41] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create "Session Request Template" for Dev Summit - https://phabricator.wikimedia.org/T151485#2843215 (10srishakatux) More and more I think about this topic, I feel tempted to think about communication tools which are good open source slack alt... [00:23:54] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2843217 (10Ejegg) PhantomJS script: P4559 [00:24:02] (03Merged) 10jenkins-bot: Add alias file [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324932 (owner: 10Legoktm) [00:25:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: return stderr [core] - 10https://gerrit.wikimedia.org/r/325063 (owner: 10MaxSem) [00:28:15] (03CR) 10Arlolra: [C: 032] Add basic integration tests for Special:LintErrors [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324933 (owner: 10Legoktm) [00:28:32] (03PS1) 10Legoktm: Add unit tests for LintError [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325068 [00:29:27] (03Merged) 10jenkins-bot: Add basic integration tests for Special:LintErrors [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324933 (owner: 10Legoktm) [00:29:47] 10Mobile-Content-Service: Fix caching of external responses in npm test runs - https://phabricator.wikimedia.org/T152255#2843221 (10bearND) [00:30:09] (03CR) 10Arlolra: [C: 032] Remove unused LintError::equals() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324934 (owner: 10Legoktm) [00:31:09] (03Merged) 10jenkins-bot: Remove unused LintError::equals() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324934 (owner: 10Legoktm) [00:34:37] (03CR) 10Arlolra: [C: 032] Add basic integration tests for RecordLintJob [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324935 (owner: 10Legoktm) [00:34:41] (03CR) 10Arlolra: [C: 032] Use INSERT IGNORE when putting new lint errors in the database [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325061 (owner: 10Legoktm) [00:35:51] (03Merged) 10jenkins-bot: Add basic integration tests for RecordLintJob [extensions/Linter] - 10https://gerrit.wikimedia.org/r/324935 (owner: 10Legoktm) [00:36:43] (03Merged) 10jenkins-bot: Use INSERT IGNORE when putting new lint errors in the database [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325061 (owner: 10Legoktm) [00:36:45] (03CR) 10Arlolra: [C: 032] Include location in LintError::id() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325065 (owner: 10Legoktm) [00:37:29] 10PageImages, 06Reading-Web-Backlog: Maintenance script should be more flexible - https://phabricator.wikimedia.org/T152252#2843240 (10bmansurov) [00:37:48] (03Merged) 10jenkins-bot: Include location in LintError::id() [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325065 (owner: 10Legoktm) [00:47:33] (03CR) 10Arlolra: [C: 032] Add unit tests for LintError [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325068 (owner: 10Legoktm) [00:48:08] (03PS1) 10Krinkle: phpunit: Make getResourceLoaderContext() more extendable [core] - 10https://gerrit.wikimedia.org/r/325070 [00:48:43] (03Merged) 10jenkins-bot: Add unit tests for LintError [extensions/Linter] - 10https://gerrit.wikimedia.org/r/325068 (owner: 10Legoktm) [00:53:54] (03CR) 10jenkins-bot: [V: 04-1] phpunit: Make getResourceLoaderContext() more extendable [core] - 10https://gerrit.wikimedia.org/r/325070 (owner: 10Krinkle) [00:55:12] (03PS2) 10EBernhardson: [WIP] Port learn to rank from solr cloud [search/extra] - 10https://gerrit.wikimedia.org/r/324852 [00:55:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Port learn to rank from solr cloud [search/extra] - 10https://gerrit.wikimedia.org/r/324852 (owner: 10EBernhardson) [01:00:59] (03PS2) 10Krinkle: phpunit: Make getResourceLoaderContext() more extendable [core] - 10https://gerrit.wikimedia.org/r/325070 [01:01:02] (03PS1) 10Krinkle: [WIP] resourceloader: Don't fail startup if getScript is broken [core] - 10https://gerrit.wikimedia.org/r/325071 [01:02:08] 10SpamRegex: SpamRegex should provide a reason in the edit form when someone submits an edit but triggers the filter (in action=submit) - https://phabricator.wikimedia.org/T152253#2843267 (10SamanthaNguyen) At the very least, it should say if this was an accident, please discuss with a wiki staff member" (or som... [01:08:14] (03CR) 10Jack Phoenix: [C: 032 V: 032] Booleans are *hard* [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/324872 (https://phabricator.wikimedia.org/T152178) (owner: 10Jack Phoenix) [01:09:09] (03PS1) 10Mholloway: Refresh page on description edit success [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/325072 (https://phabricator.wikimedia.org/T152207) [01:10:00] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Organize/ prepare content for an informational google hangout session for new Google Code-In mentors on Thu 2016-12-01 17:00UTC - https://phabricator.wikimedia.org/T150636#2843280 (10srishakatux) @01tonythomas thank you for bringing this up! :) I jus... [01:10:07] 07Design, 10New-Readers, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃: Finish print styles for flashcard - https://phabricator.wikimedia.org/T148378#2843281 (10atgo) Thanks @jhernandez. iOS is still doing iOS (no surprised there). The Android that I'm on is now downloading, but when it's loading it's... [01:10:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Don't fail startup if getScript is broken [core] - 10https://gerrit.wikimedia.org/r/325071 (owner: 10Krinkle) [01:11:21] RoanKattouw bmansurov hey - can we chat here about the swat? [01:11:31] ok [01:12:03] RoanKattouw: do you have access to a prod db? Can you query a page prop? [01:12:12] I need to check something before submitting a fix [01:12:45] Sure [01:12:48] Tell me what you need [01:14:27] 10MediaWiki-Special-pages, 06Community-Tech, 07IPv6: Create new Special:RangeContributions page to support viewing contributions across an IP range - https://phabricator.wikimedia.org/T145912#2843284 (10DannyH) [01:14:59] ( bmansurov ) [01:17:59] (03PS1) 10Jack Phoenix: trim() the phrase we're about to block before trying to enter it into the DB [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/325074 [01:19:17] RoanKattouw: can you check what is the value of pp_value if pp_propname = 'page_image', and also separately, if pp_propname = 'pag_image_free' for Donald Trump in the page_props table? [01:20:20] https://en.wikipedia.org/w/api.php?action=query&prop=pageprops&titles=Donald%20Trump [01:20:30] hah thanks legoktm [01:20:53] 10MediaWiki-Special-pages, 06Community-Tech, 07IPv6: Create new Special:RangeContributions page to support viewing contributions across an IP range - https://phabricator.wikimedia.org/T145912#2644851 (10DannyH) @MusikAnimal @kaldari : I added a wireframe, which is just a mash-up of #1) the range calculator o... [01:21:02] cool thanks [01:21:25] RoanKattouw: ok, looks like my theory is correct, i'll be submitting a patch soon [01:22:46] 06Reading-Web-Backlog, 06Research-and-Data, 03Reading-Web-Sprint-87-: QuickSurvey for reader segmentation research - run multiple choice survey in more langugaes - https://phabricator.wikimedia.org/T151835#2843292 (10leila) @atgo. sorry, that was my mistake. Please share [[ https://docs.google.com/a/wikimedi... [01:23:19] 10SpamRegex, 13Patch-For-Review: Page creation bypasses filter of SpamRegex - https://phabricator.wikimedia.org/T152178#2843293 (10SamanthaNguyen) 05Open>03Resolved [01:24:14] (03Abandoned) 10Bearloga: Easier backfilling [WIP] [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/322051 (https://phabricator.wikimedia.org/T150915) (owner: 10Bearloga) [01:25:31] 10MediaWiki-extensions-FlaggedRevs: Aligning FlaggedRevision to WikimediaUI color palette received negative feedback - https://phabricator.wikimedia.org/T152258#2843297 (10Volker_E) [01:29:36] (03PS1) 10Bmansurov: Return any image, not just the non-free image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325075 [01:29:46] RoanKattouw: ^ for swat [01:31:24] MaxSem: can you review ^ [01:31:26] (03CR) 10Catrope: [C: 032] Return any image, not just the non-free image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325075 (owner: 10Bmansurov) [01:31:36] Too late :P [01:31:55] (j/k, he should still review) [01:32:06] But I'll set the wheels in motion, it takes a bit of time [01:32:30] great, thanks [01:32:33] Jenkins needs to do its thing and merge this patch, and then I need to cherry-pick it and +2 the cherry-pick, then Jenkins needs to do its thing again, and then once that's done I can deploy it to a test box [01:32:40] (03Merged) 10jenkins-bot: Return any image, not just the non-free image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325075 (owner: 10Bmansurov) [01:32:44] bmansurov: Are you able to test this using a desktop browser? [01:32:52] yes, on my local instance [01:32:58] OK cool [01:33:09] Do you have the WikimediaDebug browser extension? [01:33:22] yes [01:33:28] Cool [01:33:37] Once Jenkins has Jenkinsed (twice), I'll put your patch on mwdebug1001 [01:33:40] bmansurov, so getPageImage() returns a random property out of two? [01:33:59] RoanKattouw: ok, I"ll test there [01:34:08] MaxSem: yeah [01:34:12] [0] seems a bit weird, that would just return whichever row is in mysql first...? [01:34:15] unless the results are ordered [01:34:17] errrrrrrrrrr? [01:34:28] same as any in the api, no? [01:34:52] Hmm [01:35:03] So because of MySQL implementation details you will probably get them in alphabetical order by property name [01:35:10] any means "best", not "random", right? [01:35:29] But yeah you probably wanna have explicit logic preferring free over non-free or whatever else it is your preferences are [01:36:09] makes sense, but currently the data shows only one image for Donald Trump for example [01:36:18] maybe not ideal for edge cases [01:36:22] just random is gonna give you another bug report next week [01:36:33] understand [01:37:27] (03CR) 10MaxSem: Return any image, not just the non-free image (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325075 (owner: 10Bmansurov) [01:37:54] ok, so can we stop deploying? [01:38:11] wait, we're deploying on friday evening? [01:38:46] yeah, apps are missing lead images [01:38:58] this should fix it [01:39:01] what are they requesting? [01:39:17] 07Design, 10New-Readers, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃: Finish print styles for flashcard - https://phabricator.wikimedia.org/T148378#2843318 (10Catrope) >>! In T148378#2843281, @atgo wrote: > Thanks @jhernandez. iOS is still doing iOS (no surprised there). > > The Android that I'm on... [01:39:32] MaxSem: their images back [01:39:42] MaxSem: https://en.wikipedia.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Donald%20Trump&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage%7Crevision§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidth=640 for example isn't returning any images [01:40:22] i suggest we don't stop the deployment, and i'll submit a better fix [01:40:38] ffs, mobileview is a mutant mastodon that needs to die [01:41:03] we're working on it, microservices for the rescue [01:41:12] I know cuz I created it :} [01:41:35] (03PS1) 10Catrope: Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 [01:41:40] (03CR) 10Catrope: [C: 032] Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 (owner: 10Catrope) [01:41:52] wait, why are we still deploying that? [01:41:58] it's going to take 5 minutes to fix properly [01:42:05] Sure, we can wait [01:42:17] Sorry, I got distracted and missed some of the discussion [01:42:23] 17:37:55 ok, so can we stop deploying? [01:42:25] I see [01:42:28] * RoanKattouw revokes +2 [01:42:32] ok [01:42:35] (03CR) 10Catrope: [C: 04-2] Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 (owner: 10Catrope) [01:42:38] (03Abandoned) 10Catrope: Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 (owner: 10Catrope) [01:42:44] (03Restored) 10Catrope: Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 (owner: 10Catrope) [01:43:32] I'm going to submit a follow up [01:44:01] RoanKattouw, as long as we commit a followup quickly, that change still needs to be merged :) [01:44:07] Hmm right [01:44:10] (03PS2) 10Krinkle: [WIP] resourceloader: Don't fail startup if getScript is broken [core] - 10https://gerrit.wikimedia.org/r/325071 [01:44:17] I just need to hold off on actually deploying I suppose [01:44:24] (03CR) 10Catrope: [C: 032] Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 (owner: 10Catrope) [01:44:49] friday evening is a tough time :) [01:45:42] (03Merged) 10jenkins-bot: Return any image, not just the non-free image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325076 (owner: 10Catrope) [01:46:25] Whoa how does the PageImages gate-and-submit pipeline run so fast [01:46:46] I guess some extensions don't need to run VE+Echo+Flow+Thanks+Scribunto+etc unit tests :) [01:47:13] it's not included in that all-shit-bundled-and-takes-forever job? [01:47:39] on the other hand, that means MW doesn't get tested [01:48:02] Yeah it seemed weird to me that the MW core unit tests aren't run [01:48:03] (03CR) 10Jack Phoenix: [C: 032 V: 032] trim() the phrase we're about to block before trying to enter it into the DB [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/325074 (owner: 10Jack Phoenix) [01:49:27] RoanKattouw: MaxSem: basic extensions test does still run the extensions's own phpunit tests with mw core installed, and it also runs the Structure tests mw core provides [01:50:20] what do you mean by mw core unit tests aren't run? No extension (including the extension group job with VE etc.) runs core unit tests other than structure tests [01:51:23] isn't everything possible included in gate tests? [01:51:43] (03PS3) 10BryanDavis: Change link from external cross-wiki contribs tool to centralauth [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324529 (https://phabricator.wikimedia.org/T151380) (owner: 10Niharika29) [01:51:52] (03CR) 10BryanDavis: [C: 032] Change link from external cross-wiki contribs tool to centralauth [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324529 (https://phabricator.wikimedia.org/T151380) (owner: 10Niharika29) [01:52:08] why can't i use an array of field names [01:52:18] we need to document functions [01:52:20] :( [01:54:05] (03Merged) 10jenkins-bot: Change link from external cross-wiki contribs tool to centralauth [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324529 (https://phabricator.wikimedia.org/T151380) (owner: 10Niharika29) [01:55:37] bmansurov, need help? [01:55:54] yeah, i'll upload my patch, can you take a look? [01:56:00] sure [01:56:49] bmansurov: You may need to use select() instead of selectField() then? [01:56:51] Or selectRow()? [01:57:52] (03PS1) 10Bmansurov: blah [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 [01:57:57] i see [01:58:01] blah:) [01:58:03] max ^ [01:58:48] !is_null shouldn't have ! ;( [01:58:51] (03CR) 10jenkins-bot: [V: 04-1] blah [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:00:27] bmansurov, just order them by pp_propname [02:01:06] yes, and that would put 'page_image' first right? [02:01:36] Yeah alphanumeric [02:01:42] 10ProveIt-Gadget: Phase out the website - https://phabricator.wikimedia.org/T148228#2843351 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Mattflaschen-Personal [02:03:16] 10RegexBlock: RegexBlock should force users to add a reason for adding a blocked username/ip address - https://phabricator.wikimedia.org/T152259#2843352 (10SamanthaNguyen) [02:08:42] 10RegexBlock, 10SpamRegex: Expressions in RegexBlock and SpamRegex should be wrapped in a element so they're rendered in a monospaced font for scanning easier - https://phabricator.wikimedia.org/T152260#2843367 (10SamanthaNguyen) [02:10:18] 10RegexBlock, 10SpamRegex: Expressions on the special pages of RegexBlock and SpamRegex should be wrapped in a element so they're rendered in a monospaced font for scanning easier - https://phabricator.wikimedia.org/T152260#2843367 (10SamanthaNguyen) [02:12:09] MaxSem: not sure what's wrong, but adding order by to the options is giving an error [02:12:22] what kind of? [02:13:39] http://pastebin.com/G1UQwwqa [02:14:08] 10MediaWiki-Authentication-and-authorization, 07I18n: Raw HTML shown in Authmanager-authn-autocreate-failed - https://phabricator.wikimedia.org/T147735#2843386 (10Mattflaschen-WMF) [02:14:09] 10MediaWiki-User-login-and-signup: Login errors show as raw HTML (on Beta) - https://phabricator.wikimedia.org/T148247#2843388 (10Mattflaschen-WMF) [02:14:12] 10MediaWiki-General-or-Unknown: nuke.php and nukeNS.php delete content without extension being notified - https://phabricator.wikimedia.org/T152261#2843389 (10mwjames) [02:14:15] bmansurov, "SELECT 1 FROM `updatelog` WHERE ul_key = 'Pingback-1.29.0-alpha' LIMIT 1" [02:14:19] i know [02:14:29] wtf [02:14:31] just outputting the $sql [02:14:38] but that's totally unrelated [02:14:53] bmansurov: What does your code look like? [02:15:12] added 'ORDER BY' => 'pp_propname' to the $options [02:16:12] (03CR) 10Mwjames: [C: 031] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:17:01] That seems like it should work [02:17:09] without full exception information hard to tell [02:17:28] how can I output it? [02:17:40] if you're trying to dump the SQL query, it won't work because API [02:18:01] well, it will if you die() immediately afterwards [02:18:30] (03CR) 10Mwjames: "@paladox If possible having this backported to 1.27 would be nice to avoid having to wait on the next LTS." [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:19:25] (03PS1) 10Paladox: registration: Provide credits information to callbacks [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/325080 (https://phabricator.wikimedia.org/T151136) [02:19:33] 10RegexBlock: List items on Special:RegexBlock should be normal font size, not 11px / 12px - https://phabricator.wikimedia.org/T152262#2843405 (10SamanthaNguyen) [02:19:36] (03PS1) 10Paladox: registration: Provide credits information to callbacks [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/325081 (https://phabricator.wikimedia.org/T151136) [02:19:43] same error even after dying [02:24:42] (03CR) 10Paladox: [C: 031] registration: Provide credits information to callbacks [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:25:04] (03PS2) 10Bmansurov: Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 [02:25:25] RoanKattouw: ^ seems to fix the issue [02:25:54] bmansurov: You should use tabs instead of spaces for indentation [02:25:58] Jenkins will be unhappy otherwise [02:26:10] ok [02:26:21] So to be clear, this prefers non-free over free? [02:27:18] (03CR) 10Legoktm: "Let's wait for this to be merged into master first, and then backport it...?" [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [02:28:58] (03PS3) 10Bmansurov: Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 [02:29:11] RoanKattouw: no, free over non-free [02:29:14] oops [02:29:16] you're right [02:29:42] (03CR) 10jenkins-bot: [V: 04-1] registration: Provide credits information to callbacks [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/325081 (https://phabricator.wikimedia.org/T151136) (owner: 10Paladox) [02:29:42] making more and more mistakes as the week ends [02:30:11] (03PS1) 10Jack Phoenix: Wrap expressions in [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/325082 (https://phabricator.wikimedia.org/T152260) [02:31:01] (03CR) 10Jack Phoenix: [C: 032 V: 032] Wrap expressions in [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/325082 (https://phabricator.wikimedia.org/T152260) (owner: 10Jack Phoenix) [02:33:23] (03CR) 10Catrope: Implementation of deferred changes (036 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/218104 (https://phabricator.wikimedia.org/T118696) (owner: 10Cenarium) [02:35:12] eh, forgot how to test it [02:36:01] (03PS3) 10Krinkle: [WIP] resourceloader: Don't fail startup if getScript is broken [core] - 10https://gerrit.wikimedia.org/r/325071 [02:36:10] (03CR) 10Bmansurov: [C: 04-1] "testing" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:36:26] 10MediaWiki-Configuration: Loading dependency from within another extension - https://phabricator.wikimedia.org/T152263#2843428 (10mwjames) [02:36:42] (03CR) 10Krinkle: "PS3 shows that first case works, and second case fails ($response is empty string, error contains "startup" as Problematic module, no JS o" [core] - 10https://gerrit.wikimedia.org/r/325071 (owner: 10Krinkle) [02:37:44] 10MediaWiki-Configuration: Loading dependency from within another extension - https://phabricator.wikimedia.org/T152263#2843440 (10mwjames) [02:38:29] (03CR) 10Bmansurov: "tested various scenarios, works fine." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:38:45] MaxSem: can you take a look ^ [02:40:31] RoanKattouw: anything else you want me to do before SWATting? [02:41:36] (03PS4) 10Catrope: Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:41:40] (whitespace fix) [02:41:46] bmansurov: Doesn't this still prefer the non-free image? [02:41:57] yes [02:42:09] Is that intended? (It's OK if it is, just checking) [02:42:11] if the free image is the best one then it's only saved once [02:42:14] yes [02:42:20] if the non-free is best then it's also saved [02:42:23] (03PS5) 10MaxSem: Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:42:29] so best one is the non-free if exists [02:42:36] 10RegexBlock: RegexBlock should force users to add a reason for adding a blocked username/ip address - https://phabricator.wikimedia.org/T152259#2843441 (10SamanthaNguyen) [02:42:36] that looks simpler ^^^ [02:42:40] (03PS3) 10BryanDavis: Change location, dates and links on application form for 2017 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324519 (https://phabricator.wikimedia.org/T151401) (owner: 10Niharika29) [02:42:47] (03CR) 10BryanDavis: [C: 032] Change location, dates and links on application form for 2017 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324519 (https://phabricator.wikimedia.org/T151401) (owner: 10Niharika29) [02:43:01] MaxSem: cool, thanks [02:43:19] two change ids? [02:44:14] (03PS6) 10Catrope: Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:44:18] (03CR) 10Catrope: [C: 032] Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:44:55] (03Merged) 10jenkins-bot: Change location, dates and links on application form for 2017 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324519 (https://phabricator.wikimedia.org/T151401) (owner: 10Niharika29) [02:45:01] (03CR) 10BryanDavis: [C: 032] Remove Final:Full report from app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324715 (https://phabricator.wikimedia.org/T151377) (owner: 10Niharika29) [02:45:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Don't fail startup if getScript is broken [core] - 10https://gerrit.wikimedia.org/r/325071 (owner: 10Krinkle) [02:45:24] (03Merged) 10jenkins-bot: Choose the best image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/325078 (owner: 10Bmansurov) [02:45:36] (03CR) 10BryanDavis: [C: 032] Add a missing error message key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324721 (owner: 10Niharika29) [02:46:34] (03PS1) 10Catrope: Choose the best image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325083 [02:46:38] (03CR) 10Catrope: [C: 032] Choose the best image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325083 (owner: 10Catrope) [02:47:29] (03CR) 10jenkins-bot: [V: 04-1] Add a missing error message key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324721 (owner: 10Niharika29) [02:48:28] (03Merged) 10jenkins-bot: Choose the best image [extensions/PageImages] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/325083 (owner: 10Catrope) [02:49:01] Alright. deployment time [02:49:19] WHAT WILL WE BREAK? [02:49:29] ... this time [02:51:52] (03CR) 10BryanDavis: [C: 04-1] Show a prominent flag on review screen if applicant is a minor (034 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324736 (https://phabricator.wikimedia.org/T151375) (owner: 10Niharika29) [02:51:56] Wow scap pull is super slow on mwdebug1001 [02:52:02] Much slower than I remember it being on mw1017 [02:52:28] RoanKattouw, someone's downloading a torrent? [02:52:30] Hmm it's doing a CDB rebuild for some reason [02:52:40] bmansurov: Try if testing mwdebug1001 works already [02:52:47] It finished fetching so it should [02:52:50] ok [02:54:40] don't see "image" in the response of https://en.wikipedia.org/w/api.php?action=mobileview&format=json&noheadings=true&page=Donald%20Trump&prop=sections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Cid%7Cprotection%7Ceditable%7Cdisplaytitle%7Cthumb%7Cdescription%7Cimage%7Crevision§ionprop=toclevel%7Cline%7Canchor%7Clevel%7Cnumber%7Cfromtitle%7Cindex§ions=all&thumbwidth=640 yet [02:57:07] 10Social-Tools: [EPIC] Convert forms in socials tools extensions to HTMLForm and display in OOJS-UI - https://phabricator.wikimedia.org/T152265#2843462 (10SamanthaNguyen) [02:58:04] works for me [02:58:13] you're not hitting the debug host [02:58:39] the toolbar is on and mwdebug1001 is selected [02:58:41] anything else? [02:59:01] well, when I do that I get the image [02:59:46] more intuitive link: https://en.wikipedia.org/w/index.php?title=2016_Ohio_State_University_attack&action=info [03:01:59] ok i see the image in your link too [03:02:15] mobileview must have been caching too [03:02:29] though I got the image in API too [03:03:23] "image":{"file":"Donald Trump August 19, 2015 (cropped).jpg","width":1500,"height":2000} [03:03:38] also, should we continue debugging on Obama? :] [03:05:15] ok, so should we push to other servers now? [03:05:35] RoanKattouw, ^ [03:05:48] Is everything working the way it's supposed to? [03:05:54] yep [03:05:58] Cool, then I'll push now [03:11:38] i see trump's image too now, MaxSem [03:14:25] cool [03:14:30] signing off [03:14:58] thanks MaxSem [03:15:06] have a good weekend [03:15:10] :) [03:15:14] you too! [03:15:18] thanks [03:16:48] 10MediaWiki-Configuration: Loading dependency from within another extension - https://phabricator.wikimedia.org/T152263#2843428 (10Legoktm) At the very least, this is going to be blocked on Florian's work towards {T117277} so extensions can specify dependencies in their extension.json. This should be doable as a... [03:17:00] 10MediaWiki-Configuration: Loading dependency from within another extension - https://phabricator.wikimedia.org/T152263#2843488 (10Legoktm) [03:17:03] 10MediaWiki-Configuration, 13Patch-For-Review: Extend 'requires' section of extension.json to include extensions - https://phabricator.wikimedia.org/T117277#1770180 (10Legoktm) [03:17:07] RoanKattouw: looks like the changes have propagated already? [03:17:20] i see the image on mw2017 too [03:18:40] (03Abandoned) 10Legoktm: registration: Provide credits information to callbacks [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/325080 (https://phabricator.wikimedia.org/T151136) (owner: 10Paladox) [03:18:43] (03Abandoned) 10Legoktm: registration: Provide credits information to callbacks [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/325081 (https://phabricator.wikimedia.org/T151136) (owner: 10Paladox) [03:25:45] 10Phabricator, 06Operations, 06Release-Engineering-Team, 13Patch-For-Review: Setup test domain for phab2001 - https://phabricator.wikimedia.org/T152132#2843493 (10Dzahn) p:05Triage>03Normal [03:29:47] RoanKattouw: Monte confirmed that some images started showing again. Thanks for your help and have a good weekend. I'll call it a day. [03:33:37] 10MediaWiki-ResourceLoader, 06Performance-Team: Better guard against exceptions from module classes - https://phabricator.wikimedia.org/T152266#2843494 (10Krinkle) [03:50:05] 10Phabricator, 07Availability, 13Patch-For-Review, 07WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#2843507 (10Dzahn) We can now rsync from iridium to phab2001. I have deleted the old contents of /srv/repos on phab2001, and started a new s... [03:56:57] (03PS4) 10Krinkle: [WIP] resourceloader: Don't let exception from module break startup [core] - 10https://gerrit.wikimedia.org/r/325071 [03:57:07] (03PS5) 10Krinkle: [WIP] resourceloader: Don't let exception from module break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) [03:59:09] (03PS1) 10Krinkle: resourceloader: Include backtrace in formatted errors (if enabled) [core] - 10https://gerrit.wikimedia.org/r/325084 [04:05:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Don't let exception from module break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) (owner: 10Krinkle) [04:08:38] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Include backtrace in formatted errors (if enabled) [core] - 10https://gerrit.wikimedia.org/r/325084 (owner: 10Krinkle) [04:09:13] (03PS2) 10Krinkle: resourceloader: Include backtrace in formatted errors (if enabled) [core] - 10https://gerrit.wikimedia.org/r/325084 [04:09:16] (03PS6) 10Krinkle: [WIP] resourceloader: Don't let exception from module break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) [04:15:05] (03PS3) 10Krinkle: resourceloader: Include backtrace in formatted errors (if enabled) [core] - 10https://gerrit.wikimedia.org/r/325084 [04:17:49] 10BlogPage, 10Social-Tools: Convert Special:CreateBlogPost to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152267#2843522 (10SamanthaNguyen) [04:19:55] 10BlogPage, 10Social-Tools: Convert BlogPage Special:CreateBlogPost to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152267#2843533 (10SamanthaNguyen) [04:22:26] 10FanBoxes, 10Social-Tools: Convert FanBoxes Special:Userboxes to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152268#2843534 (10SamanthaNguyen) [04:22:42] 10FanBoxes, 10Social-Tools: Convert FanBoxes Special:Userboxes to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152268#2843534 (10SamanthaNguyen) [04:24:54] (03PS3) 10Krinkle: phpunit: Make getResourceLoaderContext() more extendable [core] - 10https://gerrit.wikimedia.org/r/325070 [04:26:13] 10LinkFilter, 10Social-Tools: Convert LinkFilter special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152269#2843546 (10SamanthaNguyen) [04:26:41] 10LinkFilter, 10Social-Tools: Convert LinkFilter Special:LinkSubmit to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152270#2843557 (10SamanthaNguyen) [04:27:09] 10LinkFilter, 10Social-Tools: Convert LinkFilter Special:LinkEdit to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152271#2843568 (10SamanthaNguyen) [04:27:37] 10LinkFilter, 10Social-Tools: Convert LinkFilter special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152269#2843546 (10SamanthaNguyen) [04:27:38] 10LinkFilter, 10Social-Tools: Convert LinkFilter Special:LinkSubmit to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152270#2843557 (10SamanthaNguyen) [04:27:52] 10LinkFilter, 10Social-Tools: Convert LinkFilter Special:LinkEdit to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152271#2843568 (10SamanthaNguyen) [04:27:54] 10LinkFilter, 10Social-Tools: Convert LinkFilter special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152269#2843546 (10SamanthaNguyen) [04:28:51] (03CR) 10Krinkle: [WIP] resourceloader: Don't let exception from module break startup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) (owner: 10Krinkle) [04:32:26] 10LinkFilter, 10Social-Tools: Convert LinkFilter special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152269#2843585 (10SamanthaNguyen) [04:32:28] 10Social-Tools: [EPIC] Convert forms in socials tools extensions to HTMLForm and display in OOJS-UI - https://phabricator.wikimedia.org/T152265#2843584 (10SamanthaNguyen) [04:32:30] 10BlogPage, 10Social-Tools: Convert BlogPage Special:CreateBlogPost to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152267#2843587 (10SamanthaNguyen) [04:32:32] 10FanBoxes, 10Social-Tools: Convert FanBoxes Special:Userboxes to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152268#2843586 (10SamanthaNguyen) [04:36:19] (03PS7) 10Krinkle: [WIP] resourceloader: Don't let exception from module break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) [04:36:23] (03PS4) 10Krinkle: resourceloader: Include backtrace in formatted errors (if enabled) [core] - 10https://gerrit.wikimedia.org/r/325084 [04:36:54] (03PS8) 10Krinkle: [WIP] resourceloader: Don't let exception from module break startup [core] - 10https://gerrit.wikimedia.org/r/325071 (https://phabricator.wikimedia.org/T152266) [04:36:59] (03PS5) 10Krinkle: resourceloader: Include backtrace in formatted errors (if enabled) [core] - 10https://gerrit.wikimedia.org/r/325084 [04:37:11] 10Social-Tools: Convert WikiForum special pages to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152272#2843588 (10SamanthaNguyen) [04:37:39] 10Social-Tools, 10WikiForum: Convert WikiForum Special:WikiForum&wfaction=addforum to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152273#2843601 (10SamanthaNguyen) [04:37:52] 10Social-Tools, 10WikiForum: Convert WikiForum special pages to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152272#2843588 (10SamanthaNguyen) [04:38:15] 10Social-Tools, 10WikiForum: Convert WikiForum Special:WikiForum&wfaction=addthread to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152274#2843615 (10SamanthaNguyen) [04:38:39] 10Social-Tools, 10WikiForum: Convert WikiForum Special:WikiForum&wfaction=editcategory to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152275#2843628 (10SamanthaNguyen) [04:39:08] 10Social-Tools, 10WikiForum: Convert WikiFOrum Special:WikiForum&wfaction=editforum to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152276#2843641 (10SamanthaNguyen) [04:42:48] 10Social-Tools, 10WikiForum: Convert WikiForum Special:WikiForum&wfaction=editforum to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152276#2843641 (10SamanthaNguyen) [05:00:04] 10Social-Tools, 10SocialProfile: Convert SocialProfile special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152277#2843681 (10SamanthaNguyen) [05:17:23] 10MediaWiki-Debian: AutoLoader.php can't require when upgrading 1.19->1.27 - https://phabricator.wikimedia.org/T151785#2843698 (10emoshikon) Sorry, I meant upgrading :) I fixed that part in my comment. Thanks for the clarifications. So it's completely safe to 
apt-get remove mediawiki-extensions-*
? [05:25:31] 10MediaWiki-ResourceLoader, 06Performance-Team: Make mw.loader.store asynchronous - https://phabricator.wikimedia.org/T130855#2843700 (10Krinkle) p:05Normal>03Low [05:25:57] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Gadgets, 07JavaScript: Remove gadget modules from mw.loader.store when the user disables them - https://phabricator.wikimedia.org/T58778#2843703 (10Krinkle) p:05Normal>03Low [05:32:34] I just found a simple bug in Flow extension : https://phabricator.wikimedia.org/T152278 [05:37:35] (03CR) 10Krinkle: "Code would probably need to be similar to what we do for Last-Modified of page views that are a redirect - https://github.com/wikimedia/me" [core] - 10https://gerrit.wikimedia.org/r/269901 (https://phabricator.wikimedia.org/T108653) (owner: 10Kaldari) [05:38:06] (03CR) 10Krinkle: "Actually, maybe we can make MediaWiki update page_touched of incoming redirects when pages are edited. Similar to how we do that already f" [core] - 10https://gerrit.wikimedia.org/r/269901 (https://phabricator.wikimedia.org/T108653) (owner: 10Kaldari) [05:40:22] Hey, I'm a Google Code In participant [05:40:52] I'm trying to do a commit. I entered my Gerrit username and password but it says : fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Flow/' [05:48:20] Git remote says : [05:48:21] remote: You are not allowed to perform this operation. [05:48:21] remote: To push into this reference you need 'Push' rights. [05:48:21] remote: User: subins2000 [05:48:22] remote: Please read the documentation and contact an administrator [05:48:22] remote: if you feel the configuration is incorrect [05:52:17] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Stop Hovercards A/B tests - https://phabricator.wikimedia.org/T144490#2843740 (10Tbayer) 05Resolved>03Open This was deployed on November 28, right? Strangely, the event rate on ruwiki and itwiki did not drop to 0 on th... [05:52:28] 10MediaWiki-extensions-CentralAuth, 06Collaboration-Team-Triage, 10DBA, 10Notifications, and 2 others: CentralAuthCreateLocalAccountJob failing on meta due to Echo deadlocks - https://phabricator.wikimedia.org/T121161#2843742 (10Krinkle) [06:04:04] 10MediaWiki-extensions-CentralNotice, 10Analytics, 10Fundraising-Backlog, 06Performance-Team, 07Spike: Spike: CentralNotice: Investigate new ways to implement cross-domain banner close-button functionality, to end the Special:HideBanners cookie storm - https://phabricator.wikimedia.org/T117433#1774073 (10... [06:16:09] (03PS1) 10Subins2000: Replaced Linker::link() usage with LinkRenderer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325087 (https://phabricator.wikimedia.org/T149346) [06:16:57] ^ I finally committed one successfully [06:25:13] (03CR) 10MtDu: [C: 04-1] "I don't think you can simply use $this->linkrenderer. In addition, I posted some other things I saw. :)" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325087 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:28:26] (03Abandoned) 10Subins2000: Replaced Linker::link() usage with LinkRenderer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/325087 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [06:33:16] 10Social-Tools, 07Epic: [EPIC] Convert forms in socials tools extensions to HTMLForm and display in OOJS-UI - https://phabricator.wikimedia.org/T152265#2843750 (10Peachey88) [06:38:27] 10MediaWiki-extensions-CentralNotice, 10Analytics, 10Fundraising-Backlog, 06Performance-Team, 07Spike: Spike: CentralNotice: Investigate new ways to implement cross-domain banner close-button functionality, to end the Special:HideBanners cookie storm - https://phabricator.wikimedia.org/T117433#1774073 (10... [06:42:30] legoktm: ping! [06:42:46] I'm on the GCI task https://codein.withgoogle.com/dashboard/task-instances/5010170084065280/ [06:43:17] Are all functions of Linker class deprecated ? [06:43:43] 10MediaWiki-Page-editing, 06Editing-Department, 06Performance-Team, 10VisualEditor: Investigate bad_token statsd spikes - https://phabricator.wikimedia.org/T109797#2843753 (10Krinkle) 05Open>03declined 10MediaWiki-Special-pages, 06Community-Tech, 07IPv6: Create new Special:RangeContributions page to support viewing contributions across an IP range - https://phabricator.wikimedia.org/T145912#2843755 (10kaldari) @DannyH: In the range metadata section, the "range" is the same thing as the start and end IPs. H... [06:49:38] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Page-editing, 07Regression: edit.failures.session_loss regressed on Wikimedia cluster - https://phabricator.wikimedia.org/T141557#2843756 (10Krinkle) 05Open>03declined Seems to have recovered and is now lost in the noise. {F4953360} [06:49:49] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Page-editing, 06Performance-Team, 07Regression: edit.failures.session_loss regressed on Wikimedia cluster - https://phabricator.wikimedia.org/T141557#2843758 (10Krinkle) [06:50:36] 10MediaWiki-extensions-ZeroBanner, 06Performance-Team, 06Reading-Web-Backlog, 06Zero: Instrument Wikipedia Zero with Web Page Test - https://phabricator.wikimedia.org/T120251#2843759 (10Krinkle) 05Open>03declined Per @Jdlrobson. [06:53:48] 10MediaWiki-extensions-CentralNotice, 10Analytics, 10Fundraising-Backlog, 06Performance-Team, 07Spike: Spike: Investigate alternatives to Special:HideBanners cookie storm for cross-domain banner close-button - https://phabricator.wikimedia.org/T117433#2843761 (10Krinkle) [07:23:03] (03PS1) 10Subins2000: Replaced Linker::link() usage with LinkRenderer in Special Pages [core] - 10https://gerrit.wikimedia.org/r/325088 (https://phabricator.wikimedia.org/T149346) [07:29:41] 10MediaWiki-extensions-Translate: Translation review fails for some messages - https://phabricator.wikimedia.org/T152187#2840999 (10Nemo_bis) You forgot to include in the task description the steps to reproduce which were included in the thread. If you follow the link to https://translatewiki.net/w/i.php?title=... [07:33:47] hey [07:34:16] (03CR) 10MtDu: [C: 04-1] "Some things. :)" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/325088 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [07:35:12] hey, I want to contribute [07:35:22] Can anyone help? [07:39:48] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2843774 (10Liuxinyu970226) [07:50:15] If there's a problem reported a review, should I close it and create a new review request ? Or is there a follow up feature ? [07:51:38] (03Abandoned) 10Subins2000: Replaced Linker::link() usage with LinkRenderer in Special Pages [core] - 10https://gerrit.wikimedia.org/r/325088 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [07:52:33] 10MediaWiki-extensions-LabeledSectionTransclusion: lstx deletes content when substituted - https://phabricator.wikimedia.org/T152279#2843776 (10Cpiral) [07:53:38] 10MediaWiki-extensions-LabeledSectionTransclusion: lstx deletes content when substituted - https://phabricator.wikimedia.org/T152279#2843788 (10Cpiral) [08:03:30] (03PS1) 10Subins2000: Replaced Linker::link() usage with LinkRenderer in Special Pages [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) [08:20:45] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2843790 (10srishakatux) I've incorporated UX feedback given by @cmadeo here: https://www.mediawiki.org/wiki/Wikimedia_De... [08:22:48] 04(no projects): MediaWiki message delivery - Bot - https://phabricator.wikimedia.org/T152280#2843791 (10Doror) [08:28:52] hello! [08:32:04] 10MassMessage: MediaWiki message delivery - Bot - https://phabricator.wikimedia.org/T152280#2843803 (10eranroz) 1. Who is they? 2. Do bot messages can trigger talk-page notification (I think yes)? Do bot messages mentioning other users can trigger echo notification? (I think yes if signed, but not sure) [08:34:07] (03CR) 10Gergő Tisza: API: i18n for warnings and errors (0329 comments) [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [08:34:13] 10MassMessage: MediaWiki message delivery - Bot - https://phabricator.wikimedia.org/T152280#2843805 (10Doror) [08:43:58] 10UI-Standardization, 03Google-Code-In-2016, 13Patch-For-Review: Convert Special:RecentChanges to OOUI - https://phabricator.wikimedia.org/T117740#2843806 (10Victorbarbu) @Haritha28 I cannot reach you on IRC. Can we talk there, please? [09:19:00] MatmaRex, is there any module for adding namespaceinputwidget to js? [09:20:57] legoktm, are you around? [09:26:19] Is pranavk there? [09:40:06] 10MassMessage: MediaWiki message delivery - Bot - https://phabricator.wikimedia.org/T152280#2843816 (10Legoktm) 05Open>03Invalid > because the users wont get a message if the bot writing in their talk page This only happens if the edit has a bot flag *and* is marked as a minor edit. MassMessage does not mar... [09:45:09] Does wikimedia support get_browser() ? [09:45:26] I returns nothing [09:45:43] Hello rlot [09:45:56] hi [09:46:21] get_browser is a PHP function, not a MediaWiki core one, to return capabilities from the browscap database, https://browscap.org/ [09:46:54] So i can't use it in wikimedia? [09:47:18] As documented at http://php.net/manual/en/function.get-browser.php that would require to deploy a browscap.ini file [09:47:53] Ok, so how i can get browser version? [09:48:06] from JS or PHP code? [09:48:10] PHP [09:48:29] I can parse USER AGENT [09:48:41] yes, you can parse the user agent, but I'm a little puzzled, what are you trying to achieve? [09:49:13] Detect is the browser IE9, and view message on Special page [09:49:33] https://phabricator.wikimedia.org/T139590 [09:49:50] oh [09:49:55] you should use jquery.client [09:50:12] ? But its PHP code [09:50:37] does it have to be done in PHP? [09:50:50] 10MediaWiki-extensions-UniversalLanguageSelector, 07Regression: "jquery.uls.data" syntax error in IE11 - https://phabricator.wikimedia.org/T152180#2843822 (10Nikerabbit) Any idea what is the cause? jshint only gives:` 6 This character may get silently deleted by one or more browsers.` There has been only few... [09:51:06] because of how our caching system works, anything that depends on the user's user agent is typically done in javascript [09:51:15] It's special page, so i think i should put it in PHP of Special:CX [09:51:30] According amire80, "we already have a browser support matrix in the code" [09:51:54] I stronly suspect it was intended to be done client-side [09:51:57] strongly* [09:52:01] "the code" doesn't disambig if it's ContentTranslation or the core [09:52:34] the browser support matrix he's referring to is ContentTranslation [09:53:06] https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/master/extension.json#L145 [09:53:39] rlot: the error message "Could not connect to the server" is fired by JS, not PHP [09:53:44] modules/source/ext.cx.source.js [09:53:45] 100: mw.hook( 'mw.cx.error' ).fire( mw.msg( 'cx-error-server-connection' ) ); [09:53:50] also, see https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/master/modules/campaigns/ext.cx.campaigns.newarticle.js#L63 [09:53:58] Thanks so much! [09:54:10] so yes, it makes sense to do it in JS [09:54:20] also in modules/source/ext.cx.source.selector.js around line 140 [10:01:34] Can i use this function?: "this property was removed in jQuery 1.9 and is available only through the jQuery.migrate plugin. Please try to use feature detection instead." [10:03:17] 10MediaWiki-extensions-Translate: Translation review fails for some messages - https://phabricator.wikimedia.org/T152187#2840999 (10Nikerabbit) Error given is `{error: {code: "unknownmessage", info: "Unknown message",…}}`. Did you try whether editing these messages work? There might be something funny with the... [10:04:33] (03PS5) 10Rudloff: Add a webapp manifest [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) [10:07:46] 10MassMessage: MediaWiki message delivery - Bot - https://phabricator.wikimedia.org/T152280#2843825 (10eranroz) @Legoktm BTW, is there a documentation for it? where? [10:10:45] 10MassMessage: MediaWiki message delivery - Bot - https://phabricator.wikimedia.org/T152280#2843826 (10Legoktm) See "nominornewtalk" on https://www.mediawiki.org/wiki/Manual:User_rights [10:28:36] Why jenkins failed? I think it's not about my changes [10:28:37] https://gerrit.wikimedia.org/r/#/c/325092/ [10:32:38] rlot: don't worry about it, let me whitelist you [10:34:54] 10AbuseFilter: If statements containing several statements don't work anymore in edit filters - https://phabricator.wikimedia.org/T152281#2843830 (10Nirmos) [10:35:44] 10Technical-Tool-Request: Host LanguageTool WikiCheck on on Tool Labs - https://phabricator.wikimedia.org/T152049#2843842 (10Aklapper) p:05Triage>03Lowest [10:43:34] (03CR) 10Legoktm: [C: 032] Allow subpages to show up in search suggestions [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/324868 (owner: 10Jack Phoenix) [10:44:57] (03Merged) 10jenkins-bot: Allow subpages to show up in search suggestions [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/324868 (owner: 10Jack Phoenix) [10:49:11] rlot: can you upload a new version of the patch? maybe just change the commit message a bit so I can make sure you're all set with jenkins? [10:54:53] Ok, i commited new version [10:55:04] (03PS1) 10Jack Phoenix: Removed unused class member variable $mPosted [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325095 [10:55:26] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed unused class member variable $mPosted [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325095 (owner: 10Jack Phoenix) [10:55:58] 06Wikimedia-DC: Wikimedia DC virtual server hits 100% usage and stops working - https://phabricator.wikimedia.org/T151410#2843844 (10Legoktm) Console locked up too. linode's status dashboards showed a huge increase in network traffic at the same time, and access logs point to the same xmlrpc.php spammers. I simp... [11:19:15] 10MediaWiki-extensions-Translate: Translation review fails for some messages - https://phabricator.wikimedia.org/T152187#2843845 (10Kghbln) > Did you try whether editing these messages work? Indeed editing works and gets recorded in the version history. The change as such gets however ignored by the interface. [11:20:20] 10MediaWiki-extensions-Translate: Translation review fails for some messages - https://phabricator.wikimedia.org/T152187#2843846 (10Kghbln) [11:23:03] 10MediaWiki-extensions-Translate: Translation review fails for some messages - https://phabricator.wikimedia.org/T152187#2843847 (10Kghbln) 05Open>03Invalid > You forgot to include in the task description the steps to reproduce which were included in the thread. This was what the quick test link was meant f... [11:23:54] (03PS1) 10Jack Phoenix: Split the RegexBlockData class into its own file [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325096 [11:26:10] (03CR) 10Jack Phoenix: [C: 032 V: 032] Split the RegexBlockData class into its own file [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/325096 (owner: 10Jack Phoenix) [11:31:17] 10MediaWiki-extensions-Translate: Translation review fails for some messages - https://phabricator.wikimedia.org/T152187#2843850 (10Kghbln) > The change as such gets however ignored by the interface. I am sorry but this info is incorrect. After editing these messages also vanish from the translation interface. [11:48:11] 10MediaWiki-General-or-Unknown, 07Need-volunteer: Add a new MediaWiki system message as a content header inside #mw-content-text - https://phabricator.wikimedia.org/T151682#2843853 (10Aklapper) [11:52:20] 10MediaWiki-General-or-Unknown, 07Need-volunteer: Add a new MediaWiki system message as a content header inside #mw-content-text - https://phabricator.wikimedia.org/T151682#2843856 (10Aklapper) **[offtopic]** @JakeTheDeveloper: For your info, the #Developer-notice tag is not meant for "contacting a developer"... [11:52:27] (03CR) 10Reedy: registration: Provide credits information to callbacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [11:58:58] 10PageImages, 07Documentation: PageImages code should have documentation warning developers about caching implications - https://phabricator.wikimedia.org/T152239#2843858 (10Aklapper) [11:59:28] 10AbuseFilter: If statements containing several statements don't work anymore in edit filters - https://phabricator.wikimedia.org/T152281#2843859 (10Reedy) p:05Triage>03High [12:01:36] 07Design, 10MediaWiki-extensions-FlaggedRevs: Aligning FlaggedRevision to WikimediaUI color palette received negative feedback - https://phabricator.wikimedia.org/T152258#2843861 (10Aklapper) [12:01:40] (03CR) 10Raimond Spekking: [C: 032] Add $magicWords translation for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/322614 (https://phabricator.wikimedia.org/T151134) (owner: 10Pmlineditor) [12:01:49] (03CR) 10jenkins-bot: [V: 04-1] Add $magicWords translation for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/322614 (https://phabricator.wikimedia.org/T151134) (owner: 10Pmlineditor) [12:02:07] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 4 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2843862 (10Physikerwelt) I'm not sure if wrapping inline math elements in a div would be a good idea. And texvc_cgi is not used in... [12:04:56] FlorianSW|away, are you around? [12:05:10] tto, hello! [12:05:17] victorbarbu, hello :) [12:05:17] (03CR) 10Reedy: Modify the populateLocalAndGlobalIds maintenance script to: * Exclude renames while populating records to avoid conflicts * Run per wiki (us (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/324793 (owner: 10Niharika29) [12:05:22] how's it going? [12:05:50] do you remember I had a mentor, Ankita something, last year who did not respond for 3 days? [12:05:57] and you helped me [12:06:21] (03Abandoned) 10Reedy: Update extensions with sync-with-gerrit.py [extensions] - 10https://gerrit.wikimedia.org/r/306237 (owner: 10Nemo bis) [12:07:56] (03Abandoned) 10Reedy: Revert "Remove old remapping hacks from Database::indexName()" [core] - 10https://gerrit.wikimedia.org/r/324809 (owner: 10Reedy) [12:07:59] (03Abandoned) 10Reedy: Revert "Remove old remapping hacks from Database::indexName()" [core] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324810 (owner: 10Reedy) [12:09:24] 07Design, 10Math, 10MobileFrontend, 06Reading-Web-Backlog, and 4 others: Page becomes horizontally scrollable with certain formulae - https://phabricator.wikimedia.org/T134281#2843863 (10TameeshB) >>! In T134281#2843862, @Physikerwelt wrote: > I'm not sure if wrapping inline math elements in a div would be... [12:11:55] (03PS2) 10Reedy: Remove ContentHandler functions with no usages at all [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) [12:12:08] (03CR) 10jenkins-bot: [V: 04-1] Remove ContentHandler functions with no usages at all [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:12:43] (03CR) 10Reedy: "PS2 removes the WikiRevision changes, brings in the RELEASE-NOTES to the correct patch" [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:13:34] (03PS3) 10Reedy: Remove ContentHandler functions with no usages at all [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) [12:16:30] (03CR) 10TTO: [C: 031] "Fine by me. I have a feeling Daniel will be quick to +2 this :)" [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:16:58] (03PS2) 10Reedy: Article::getAutosummary() and WikiPage::getAutosummary() were removed [core] - 10https://gerrit.wikimedia.org/r/324705 (https://phabricator.wikimedia.org/T145728) [12:17:52] (03CR) 10Reedy: "Seemed easier to do the WikiRevision stuff in another change rather than complicating this one further for no real benefit" [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:21:38] 10MediaWiki-ContentHandler, 10MediaWiki-Export-or-Import: WikiRevision::getText() needs fixing up - https://phabricator.wikimedia.org/T152282#2843864 (10Reedy) [12:23:13] 07Design, 10MediaWiki-extensions-FlaggedRevs: Aligning FlaggedRevision to WikimediaUI color palette received negative feedback - https://phabricator.wikimedia.org/T152258#2843879 (10Ladsgroup) Okay, I think I might know what's going on here. {F4956881} And {F4956909} These are RED90 and YELLOW90. IMO They sh... [12:24:30] (03CR) 10Reedy: "Want to remove your CR -1 too? ;)" [core] - 10https://gerrit.wikimedia.org/r/324710 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:27:21] (03PS2) 10Reedy: ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed [core] - 10https://gerrit.wikimedia.org/r/324710 (https://phabricator.wikimedia.org/T145728) [12:29:02] 10MediaWiki-Vagrant: Unexpected failure during download from download of "Mediawiki-Vagrant" - https://phabricator.wikimedia.org/T152283#2843881 (10jeblad) [12:29:46] (03CR) 10Reedy: ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324710 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:30:54] 10MediaWiki-extensions-Lingo: User::loadFromSession called before the end of Setup.php - https://phabricator.wikimedia.org/T152243#2842767 (10mwjames) > #7 /WIKIFARM/MEDIAWIKI/mediawiki-REL1_28/extensions/Lingo/src/Lingo.php(74): Message->text() Caused by `wfMessage( 'lingo-desc', $lingoPageName )->text();` may... [12:32:09] (03PS1) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [12:34:50] 10MediaWiki-extensions-WikimediaMessages, 10Wikimedia-Site-requests, 13Patch-For-Review: Change a link for Privacy policy for Russian Wikiprojects - https://phabricator.wikimedia.org/T150070#2843898 (10Iniquity) @Dereckson, yep, I know it. But I think that people care about vandals` edits which can be shown... [12:44:46] (03CR) 10Daniel Kinzler: [C: 032] "+2 for this, and +1 for doing the WikiRevision stuff in another patch :)" [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:49:04] (03CR) 10Divadsn: "I tried my best to reformat the code, I left probably some code lines." (031 comment) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [12:49:19] (03CR) 10Daniel Kinzler: [C: 032] ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324710 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:50:41] (03CR) 10Daniel Kinzler: [C: 032] Article::getAutosummary() and WikiPage::getAutosummary() were removed [core] - 10https://gerrit.wikimedia.org/r/324705 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:57:09] (03Merged) 10jenkins-bot: Remove ContentHandler functions with no usages at all [core] - 10https://gerrit.wikimedia.org/r/324703 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [12:59:01] (03Merged) 10jenkins-bot: Article::getAutosummary() and WikiPage::getAutosummary() were removed [core] - 10https://gerrit.wikimedia.org/r/324705 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [13:01:31] (03Merged) 10jenkins-bot: ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed [core] - 10https://gerrit.wikimedia.org/r/324710 (https://phabricator.wikimedia.org/T145728) (owner: 10Reedy) [13:02:30] 10MediaWiki-Vagrant: Unexpected failure during download from download of "Mediawiki-Vagrant" - https://phabricator.wikimedia.org/T152283#2843903 (10jeblad) Seems to be a failure due to TLS, aka to large download attempted as HTTPS. [13:27:51] (03PS2) 10Victorbarbu: [WIP] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [13:29:00] 10Android-app-feature-Feeds, 06Wikipedia-Android-App-Backlog: Today’s Featured Article and In the News is not shown in Hungarian mobile app - https://phabricator.wikimedia.org/T152284#2843908 (10Tacsipacsi) [13:31:22] (03CR) 10Fomafix: Replaced Linker::link() usage with LinkRenderer in Special Pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [13:34:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [13:38:50] 10Montage: Montage parallel service during Tools maintenance time - https://phabricator.wikimedia.org/T149974#2843921 (10yuvipanda) 05Open>03Resolved Was done :) [13:51:58] 10MediaWiki-Maintenance-scripts: GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835240 (10Liuxinyu970226) Just tell you @Baskice that, you could just use T108443 and T65098 as well as using Magic Words in MW, no need to make such unne... [13:55:42] Hey, I'm a GCI participant [13:55:51] I have a question [13:56:39] If there was a mistake in a code review request I made, is there a follow up review option to do ? Or should I abandon the review and submit a new review with fixed changes ? [13:59:25] (03CR) 10Ladsgroup: "It would be nice if someone reviews this." [core] - 10https://gerrit.wikimedia.org/r/225536 (https://phabricator.wikimedia.org/T117884) (owner: 10Florianschmidtwelzow) [14:01:12] subins2000: hey [14:01:46] MatmaRex: hi [14:01:53] subins2000: yes, you can update your patch. https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 [14:02:16] or do you mean something else than a Gerrit patch? [14:03:09] No, it's a Gerrit patch : https://gerrit.wikimedia.org/r/#/c/325090/ [14:03:43] Someone reviewed the code and said some suggestions. I was wondering I would have to start over by abandoning the review and submit a new one [14:05:31] 10MediaWiki-extensions-ContentTranslation, 07Regression, 07WorkType-Maintenance: Content Tranlsation adapts English Wikipedia's {{Reflist}} to {{Reflist}} in the Polish Wikipedia even though it is linked to {{Przypisy}} - https://phabricator.wikimedia.org/T152285#2843936 (10Amire80) [14:08:25] legoktm: Hey [14:08:32] legoktm: I'm working on the task https://codein.withgoogle.com/dashboard/task-instances/5010170084065280/ [14:09:49] legoktm: Should I only replace Linker::link() functions ? Is there a list of deprecated functions in Linker class that needs to be replaced ? [14:12:37] 10Graphs, 07TestMe: some pic of graph can't loading? - https://phabricator.wikimedia.org/T134462#2266353 (10ISBetrayal) >>! In T134462#2711953, @TerraCodes wrote: > I was going to ask if this was fixed, but the Largest cities graph isn't showing for me so I'm guessing it isn't fixed. I loaded the webpage, the... [14:13:38] 10Phabricator: Import projects and tasks into phab-01 - https://phabricator.wikimedia.org/T151527#2844001 (10Aklapper) p:05Triage>03Lowest [14:14:49] 10Phabricator: "Pre-scheduled session" - https://phabricator.wikimedia.org/T147144#2844003 (10Aklapper) 05stalled>03Invalid Unfortunately closing this report as no further information has been provided. @Ss22ever: Please reopen this report (by changing its status) after you have provided the information aske... [14:15:05] 10MediaWiki-extensions-WikimediaMessages, 10Wikimedia-Site-requests, 13Patch-For-Review: Change a link for Privacy policy for Russian Wikiprojects - https://phabricator.wikimedia.org/T150070#2844005 (10Dereckson) So I suggest to deploy it and to ask ru.wikipedia community to locally override the MediaWiki me... [14:16:54] 10Graphs: some pic of graph can't loading? - https://phabricator.wikimedia.org/T134462#2844006 (10ISBetrayal) [14:18:21] (03PS2) 10Subins2000: Replaced Linker::link() usage with LinkRenderer in Special Pages [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) [14:18:40] 10Phlogiston (Technical Debt): Phabricator dump used by Phlogiston should be updated when Phabricator is upgraded - https://phabricator.wikimedia.org/T125698#2844007 (10Aklapper) Removing #Phabricator as there's nothing to do there. [14:19:24] MatmaRex: Thank you so much ! I have successfully updated my patch [14:19:51] yay [14:20:05] 10MediaWiki-Authentication-and-authorization, 10Phabricator, 07Security-General: Phabricator (on iPhone) gives login error and incorrectly says that I have disabled cookies - https://phabricator.wikimedia.org/T132268#2844009 (10Aklapper) p:05Triage>03Low [14:20:13] Hey, can someone please look into this code review? https://gerrit.wikimedia.org/r/#/c/325097/ [14:21:21] (03CR) 10Mvolz: [C: 04-1] "Lots of good work, a few minor comments inline." (033 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [14:23:43] (03PS2) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [14:29:03] (03PS3) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [14:35:17] 10Graphs: some pic of graph can't loading? - https://phabricator.wikimedia.org/T134462#2844026 (10Aklapper) 05Open>03Resolved >>! In T134462#2843999, @ISBetrayal wrote: > I loaded the webpage, the graphs were fine, even the largest cities graph. Indeed, this looks fixed. Thanks for retesting (and providing... [14:40:35] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2844039 (10Liuxinyu970226) [14:40:37] 10MediaWiki-extensions-ContentTranslation, 07TestMe, 07WorkType-Maintenance: ContentTranslation inserts HTML source when adapting {{Cite journal}} from English to Czech, Chinese - https://phabricator.wikimedia.org/T109174#2844038 (10Liuxinyu970226) [14:41:42] 10Collection, 10Internet-Archive, 07TestMe: Incorrect rendering of chess board to pdf - https://phabricator.wikimedia.org/T36562#2844040 (10ISBetrayal) >>! In T36562#396552, @brion wrote: > Looks like source page is https://en.wikibooks.org/wiki/Chess/Tactics > > Seems that the PDF renderer is not handling... [14:41:53] 10Collection, 10Internet-Archive: Incorrect rendering of chess board to pdf - https://phabricator.wikimedia.org/T36562#2844044 (10ISBetrayal) [14:44:11] (03PS5) 10Cenarium: Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) [14:44:20] (03CR) 10jenkins-bot: [V: 04-1] Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [14:45:38] Is Mvolz here? [14:45:46] MVolz [14:47:18] rlot: which task are you working on? [14:48:04] Add "Add reading in of html "lang" property to html-metadata's parseGeneral method " [14:48:09] Ah, ok. [14:48:11] (03PS6) 10Cenarium: Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) [14:48:14] I added support [14:48:14] 10MediaWiki-extensions-ContentTranslation: Allow wikis to add customized tips with links to local helppages - https://phabricator.wikimedia.org/T152290#2844045 (10tarlocesilion) [14:48:27] but i don't know what does "live test" mean [14:48:40] rlot: a "live test" means a test that scrapes a live website [14:48:57] just bare NodeJS? [14:49:03] or mocha test? [14:49:08] so just like the tests in here: https://github.com/wikimedia/html-metadata/blob/master/test/scraping.js [14:49:34] So its mocha test [14:49:45] 'npm test' runs the mocha tests [14:50:09] yes [14:51:39] npm test static.js [14:51:45] Throws Test failed [14:54:01] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2844058 (10Mvolz) [14:54:26] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2844073 (10Mvolz) [14:54:33] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: Wrap long lines in Quiz extension - https://phabricator.wikimedia.org/T150103#2774076 (10Mvolz) [14:55:01] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016: Add a composer.json and lint the php in the Quiz extension - https://phabricator.wikimedia.org/T152291#2844058 (10Mvolz) [14:55:08] 10MediaWiki-extensions-Quiz, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: Wrap long lines in Quiz extension - https://phabricator.wikimedia.org/T150103#2774076 (10Mvolz) [14:55:14] Can i just add lang test to scraping.js? [14:58:05] yup [14:58:12] and you'll need to fix the static tests [14:58:19] as they test everything all at once [14:58:42] hey there can any body help me? [14:58:46] so if you've added new functionality without changing them, they'll fail [14:59:57] (03PS6) 10Paladox: Update sql support for web updater [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/238006 [15:00:28] reply please. [15:01:25] (03CR) 10Mvolz: [C: 04-1] "Whoops, I think my comments on the previous patch weren't very clear, I meant that there was a tab in there that should be removed!" (034 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [15:02:10] Oh, didn't saw that, Atom is showing me as a proper tab [15:02:55] 10MediaWiki-extensions-Quiz: Use TemplateParser instead of raw HTML tags in code - https://phabricator.wikimedia.org/T152293#2844094 (10divadsn) [15:03:39] 10Collection, 10Internet-Archive: Incorrect rendering of chess board to pdf - https://phabricator.wikimedia.org/T36562#2844107 (10Aklapper) 05Open>03Resolved a:03Aklapper Thank you IsBetrayal for the good retesting (and providing your exact steps, that's really great work)! It looks like the bug in this... [15:05:27] (03PS4) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [15:06:11] (03PS5) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [15:08:30] (03CR) 10Divadsn: Improve code readability in Quiz extension by reformatting code (032 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [15:13:30] 10MediaWiki-Page-editing, 07Easy, 07User-notice: Allow posting new sections to top of page on a per-page basis - https://phabricator.wikimedia.org/T33919#2844115 (10matej_suchanek) [15:26:11] 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2840322 (10Mvolz) Can you publish this one @Aklapper ? Thanks! [15:26:37] 07Easy, 03Google-Code-In-2016: Add templateData to a template on a non-English wikipedia that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T152159#2844123 (10Mvolz) [15:29:35] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Change all relevant dates and links on application form to reflect new 2017 information - https://phabricator.wikimedia.org/T151401#2844125 (10Niharika) 05Open>03Resolved a:03Niharika [15:29:38] (03PS4) 10Paladox: Update videojs to 5.14.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314731 [15:31:51] mvolz: I submited it on GCI site [15:35:49] Hello everyone! [15:35:55] Hi [15:36:09] Hi rlot! [15:36:14] 10MediaWiki-Vagrant: Unexpected failure during download from download of "Mediawiki-Vagrant" - https://phabricator.wikimedia.org/T152283#2844128 (10jeblad) This is a bug in TLS. A quickfix is to use SSH. [15:36:29] Are you participating in GCI 2016 rlot? [15:36:49] Yes [15:37:06] Cool! [15:37:09] 10MediaWiki-Vagrant: Unexpected failure during download from download of "Mediawiki-Vagrant" - https://phabricator.wikimedia.org/T152283#2844129 (10jeblad) 05Open>03Invalid Must be fexed upstream. [15:37:26] @rlot, How many tasks have you claimed till now? [15:45:22] (03CR) 10Paladox: "The version number should be bumped to 0.6.0 or 1.0 since this is a big change." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [15:45:30] (03CR) 10Paladox: [C: 031] Convert to extension registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/322609 (https://phabricator.wikimedia.org/T87981) (owner: 10Reedy) [15:47:03] (03Draft2) 10Matěj Suchánek: Don't pass unsupported parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/324949 [15:50:46] (03PS2) 10Niharika29: Add a missing error message key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324721 [15:50:48] (03PS2) 10Niharika29: Show a prominent flag on review screen if applicant is a minor [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324736 (https://phabricator.wikimedia.org/T151375) [15:50:50] (03PS2) 10Niharika29: Remove Final:Full report from app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324715 (https://phabricator.wikimedia.org/T151377) [15:50:58] Uh oh. [15:54:32] 10Wikimedia-Wikimania-Scholarships, 13Patch-For-Review: Change all relevant dates and links on application form to reflect new 2017 information - https://phabricator.wikimedia.org/T151401#2844139 (10Niharika) 05Resolved>03Open Keeping this (and other tasks) open for @Shouston_WMF and @eyoung to review. [15:56:59] mvolz, I created a new task on Phabricator, this could be also a possible GCI task :) https://phabricator.wikimedia.org/T152293 [15:57:34] divadsn: great, thanks! [15:59:02] Could you also please look on my latest patch set on Gerrit? [15:59:38] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Unplanned-Sprint-Work: Central Notice: possible CN issue early on December 1st UTC - https://phabricator.wikimedia.org/T152122#2844144 (10Ejegg) A watched pot never boils. No banner dip observed December... [16:04:01] (03PS1) 10Cenarium: Add help icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/325104 [16:06:56] (03PS7) 10Cenarium: Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) [16:06:56] 10MediaWiki-extensions-CategoryTree: PHP Notice: Use of undefined constant CT_MODE_PAGES - assumed 'CT_MODE_PAGES' under MW 1.28 - https://phabricator.wikimedia.org/T152294#2844149 (10Pspviwki) [16:08:16] (03CR) 10Cenarium: "I've added a help link, this now depends on I31665932b69c52e2a3eb2f0e1d9b5d88c562bca2 for the icon." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [16:08:19] (03PS2) 10Paladox: Move JS to RL module [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323664 (owner: 10Reedy) [16:09:25] (03CR) 10Paladox: "Added support for php variable to js. Since $replaceMeText is defined in php so we need to get it's value and import it into js." [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323664 (owner: 10Reedy) [16:09:43] (03CR) 10Cenarium: Notify users of reviews (033 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [16:11:31] (03CR) 10jenkins-bot: [V: 04-1] Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [16:11:47] (03CR) 10Paladox: "recheck" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:12:02] (03CR) 10Paladox: [C: 031] Provide an alternative to the pcntl_* functions [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:14:17] (03CR) 10Fomafix: [C: 04-1] Replaced Linker::link() usage with LinkRenderer in Special Pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [16:15:56] (03CR) 10jenkins-bot: [V: 04-1] Provide an alternative to the pcntl_* functions [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:17:25] Good day! I'm Ivan Sucgang and I am a part of this year's Google Code In [16:17:41] Hope someone is online. [16:20:02] Yes [16:20:38] I am a high school senior participating in this year's Google Code In too [16:20:48] Hi and welcome [16:20:49] How are you @ISBetrayal10520? [16:20:58] Hey Dereckson [16:21:13] So I'm kinda new to the whole wikimedia thingy, and I'm a bit bombarded with info [16:21:38] there's a lot of jargon that i can't quite understand yet but, i really wanna learn [16:23:00] @The_Codeguy i'm also a high school senior [16:23:09] not really a senior [16:23:27] ISBetrayal0520: if you've questions about jargon, you can ask them here [16:23:39] Ohh, so this is basically like, [16:23:45] a place where you can ask stuff [16:23:51] yes [16:24:04] and coordinate with other developers, and be spammed by bot notifications [16:24:17] i also read that i can connect to a channel with my native language [16:24:20] (03PS1) 10Cenarium: echo 1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/325106 [16:24:21] (03PS1) 10Cenarium: echo 2 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/325107 [16:24:22] how do i know which channel [16:24:30] what's your language? [16:24:40] Filipino. I'm from the Philippines [16:24:47] good question [16:25:01] (03Abandoned) 10Cenarium: echo 1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/325106 (owner: 10Cenarium) [16:25:12] (03Abandoned) 10Cenarium: echo 2 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/325107 (owner: 10Cenarium) [16:25:13] what do those messages mean [16:26:29] I guess id.wikipedia has probably an IRC channel, perhaps #wikipedia-id, but that will be for Wikipedia related discussions [16:26:48] ISBetrayal0520: grrrit-wm is a bot, and means someone have just reviewed a patch [16:26:55] these are notifiations from different services, here Gerrit, the software we use for code review [16:27:49] code review is the process to check if the code offered is valid, suggest improvements, and when all is good, merge/integrate it to the main/official code [16:28:01] the main/official code is generally called the "master branch" [16:28:07] (03PS5) 10Paladox: Provide an alternative to the pcntl_* functions [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:28:23] (03CR) 10Paladox: "Rebased." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:28:55] ohhhh. Thank you sir. So I code at Gerrit, then I upload it back to the master branch? [16:29:53] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Gallery dialog's search results aspect ratio is different to the media dialog's search results - https://phabricator.wikimedia.org/T151509#2819688 (10Tchanders) I think this is because the space in the gallery dialog is narrower. After play... [16:29:56] 10MediaWiki-Vagrant, 10Wikidata: Mediawiki-Vagrant role "Wikidata" fails after timeout - https://phabricator.wikimedia.org/T150581#2844182 (10Sn1per) I get this issue with the LXC provider, but not with virtualbox. [16:30:52] Can you guys like, suggest a basic task that I can do to pass the time? [16:31:29] Preferably something code related, so I can improve my skills and such [16:32:06] (03PS6) 10Paladox: Provide an alternative to the pcntl_* functions [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:32:13] (03CR) 10Paladox: "Fix phpcs error." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:32:25] (03PS8) 10Cenarium: Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) [16:33:13] !easy | ISBetrayal0520 [16:33:13] ISBetrayal0520: We keep a list of bugs that are easy to solve, in case new developers want a simple step to start out with. Check out https://phabricator.wikimedia.org/tag/easy/ and let us know if you need any help fixing your first bug! [16:33:47] Is Git different from gerrit? [16:36:18] yes [16:36:32] (03CR) 10jenkins-bot: [V: 04-1] Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) (owner: 10Cenarium) [16:36:33] gerrit is the code review system we use [16:36:44] it's based on the git version control system [16:37:49] (03CR) 10Mvolz: [C: 04-1] "So it looks like you got rid of a lot of a lot of the quote escaping, which is great, but if we do that we should make sure we very consis" (0312 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [16:38:01] (03PS9) 10Cenarium: Notify users of reviews [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316410 (https://phabricator.wikimedia.org/T54510) [16:38:28] Wait, so there is a different program for gerrit? [16:39:38] 10Wikimedia-Site-requests, 13Patch-For-Review: Internal Wiki for Wikimedians of Ecuador - https://phabricator.wikimedia.org/T135521#2844187 (10Krenair) @Dereckson, we should try to finish this ticket off. [16:40:50] ISBetrayal0520, what? [16:40:51] 10Wikimedia-Site-requests, 13Patch-For-Review: Private wiki for Project Grants Committee - https://phabricator.wikimedia.org/T143138#2844188 (10Krenair) a:05Dereckson>03Mjohnson_WMF [16:40:55] 04(no projects): delete me - https://phabricator.wikimedia.org/T152279#2844189 (10Cpiral) 05Open>03Resolved [16:40:55] you use git to upload to gerrit [16:41:09] Ohh so i have to download git first [16:41:12] sorry [16:41:19] I'll search for answers online first [16:41:32] then I'll ask here if I have a roadblock [16:41:49] (03CR) 10Paladox: [C: 031] Provide an alternative to the pcntl_* functions [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/273173 (https://phabricator.wikimedia.org/T128048) (owner: 10MarkAHershberger) [16:41:51] you don't need to download gerrit, it's a service that wikimedia hosts [16:43:09] ISBetrayal0520: https://www.mediawiki.org/wiki/Gerrit/Getting_started [16:43:21] thank you very much [16:43:25] 10Wikimedia-Interwiki-links, 13Patch-For-Review: Update interwikimap of Finnish Wikivoyage - https://phabricator.wikimedia.org/T152201#2841408 (10hoo) >>! In T152201#2841891, @Koavf wrote: > Oh wow. The interwiki links *provided by Wikidata* are pointing to language editions of Wikipedia. See, e.g. https://fi.... [16:43:33] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Livvi-Karelian Wikipedia at olo.wikipedia.org - https://phabricator.wikimedia.org/T146612#2844196 (10Krenair) Let's create a list of things left to do here. [16:43:44] (03CR) 10Paladox: [C: 031] Remove < MW 1.14 support [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323657 (owner: 10Reedy) [16:43:58] (03PS3) 10Subins2000: Replaced Linker::link() usage with LinkRenderer in Special Pages [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) [16:44:13] (03CR) 10Paladox: [C: 031] Some code cleanup [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323658 (owner: 10Reedy) [16:44:23] 10Wikimedia-Site-requests, 13Patch-For-Review: Private wiki for Project Grants Committee - https://phabricator.wikimedia.org/T143138#2844199 (10Dereckson) So, to give a little status update, @Mjohnson_WMF sent me 3 days ago a mail explaining there are some login issue, and I sent instructions by mail how to so... [16:44:26] (03CR) 10Paladox: [C: 031] Move functions to class [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323660 (owner: 10Reedy) [16:44:42] (03CR) 10Paladox: [C: 031] Convert DiscussionThreading to extension registration [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323661 (owner: 10Reedy) [16:45:02] (03CR) 10Paladox: [C: 031] Fix Undefined property: EditPage::$replyadded [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323663 (https://phabricator.wikimedia.org/T70742) (owner: 10Reedy) [16:45:23] (03CR) 10Paladox: [C: 031] Move JS to RL module [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323664 (owner: 10Reedy) [16:47:25] (03CR) 10Mvolz: "That should be only use double quotes *inside* strings, not instead. :)" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [16:47:54] 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2844200 (10Paladox) SemanticForms was discontinued and renamed to PageForms as it doesn't need SemanticMediaWiki any... [16:50:01] FlorianSW: Hey, I'm a GCI student [16:50:19] heyyy [16:50:24] im also GCI [16:50:29] ISBetrayal0520: Hey ! [16:50:35] is this a task of yours? [16:50:54] ISBetrayal0520: Yes, I'm on this : https://codein.withgoogle.com/dashboard/task-instances/5010170084065280/ [16:50:56] subins2000: hi! :) [16:51:06] subins2000: do you have like, background on stuff like this [16:51:17] ISBetrayal0520: I know PHP [16:51:35] FlorianSW: Does this task require to replace all deprecated Linker functions ? https://codein.withgoogle.com/dashboard/task-instances/5010170084065280/ [16:51:44] subins2000: have you joined GCI before? [16:51:46] FlorianSW: Or just Linker::link() [16:51:57] ISBetrayal0520: Yes, this is my 4th year [16:52:17] subins2000: woah. veteran. I'm just a beginner [16:52:27] ISBetrayal0520: How old are u ? [16:52:30] subins2000: no, just Linker::link() :) [16:52:49] subins2000: 17, so yeah, i barely made the cut to join GCI, you? [16:53:04] FlorianSW: I made a patch, but a reviewer commented abo [16:53:16] *commented about the Linker::linkKnown() [16:53:19] https://gerrit.wikimedia.org/r/325090 [16:53:44] ISBetrayal0520: 16 :) [16:54:08] subins2000: ah, sorry, yes, and Linker::linkKnown() :) So, Linker functions that are marked as deprecated :) [16:54:16] subins2000: that's cool so yeah [16:54:46] FlorianSW: Should I replace on all the Special pages ? Or just on the pages that I made the patch on ? [16:54:57] FlorianSW: I made the path on 10 Special pages [16:54:57] subins2000: Is this IRC good for like, asking questions about stuff, [16:55:07] ISBetrayal0520: Very good for asking questions [16:55:30] ISBetrayal0520: But you need to have great patience [16:55:30] subins2000: Okay then, thank you. [16:55:40] subins2000: why? [16:56:02] ISBetrayal0520: Most people aren't really online and most reply after a long time [16:56:08] 10Wikimedia-Site-requests: Review the 'botadmin' group at mlwiktionary and mlwikisource - https://phabricator.wikimedia.org/T152296#2844203 (10MarcoAurelio) [16:56:29] ISBetrayal0520: The question I just asked was asked by me earlier this day (about 7 hours ago) and no one replied [16:56:35] 10Wikimedia-Site-requests: Review the 'botadmin' group at mlwiktionary and mlwikisource - https://phabricator.wikimedia.org/T152296#2844218 (10MarcoAurelio) p:05Triage>03Low [16:56:44] ISBetrayal0520: You have to keep trying to get an answer [16:56:47] subins2000: Woah. That's long. [16:56:56] subins2000: Which org are you doing tasks for [16:57:10] ISBetrayal0520: Obviously MediaWiki ;) [16:57:30] subins2000: but, you do tasks for other orgs? or just media wiki [16:57:48] ISBetrayal0520: I know PHP the most, so just MediaWiki. Last year I was on Ubuntu [16:58:01] ISBetrayal0520: and the year before that Drupal [16:58:08] 10MediaWiki-extensions-CentralNotice, 07Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#2844220 (10Dispenser) [16:58:11] subins2000: I have background on HTML and CSS, [16:58:37] ISBetrayal0520: Learn a server side language. PHP is really easy to learn [16:58:42] subins2000: How many tasks have you completed so far? [16:58:44] ISBetrayal0520: Node.js is good too [16:58:49] ISBetrayal0520: This is my 2nd task :) [16:59:04] subins2000: this is also my second task. Which of the two would you recommend? [16:59:08] ^ hi all, wondering if you guys could take chatter into a PM? [16:59:13] mvolz: I made commit to github, can you check it? [16:59:20] ISBetrayal0520: PHP is the easiest [16:59:26] dargasia: Okay, sorry [16:59:54] (03CR) 10Fomafix: [C: 04-1] Replaced Linker::link() usage with LinkRenderer in Special Pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [17:00:17] ^ Damn [17:00:56] o/ [17:02:24] (03PS4) 10Subins2000: Replaced Linker::link() usage with LinkRenderer in Special Pages [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) [17:03:50] 10The-Wikipedia-Library: Version 3.0: Discovery - https://phabricator.wikimedia.org/T151803#2844240 (10Samwalton9) [17:03:51] 10The-Wikipedia-Library: Integrate EZProxy authentication (or other institutional proxy tool) into library card platform - https://phabricator.wikimedia.org/T102055#2844241 (10Samwalton9) [17:03:57] FlorianSW: Where can I get a list of Linker functions that are marked as deprecated [17:04:44] 10The-Wikipedia-Library: Version 2.0: Proxy - https://phabricator.wikimedia.org/T151802#2844243 (10Samwalton9) [17:04:45] 10The-Wikipedia-Library: Integrate EZProxy authentication (or other institutional proxy tool) into library card platform - https://phabricator.wikimedia.org/T102055#1354638 (10Samwalton9) [17:04:48] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#2844244 (10Samwalton9) [17:05:00] subins2000: you can search the source code of Linker or use the deprecated list here: https://doc.wikimedia.org/mediawiki-core/master/php/deprecated.html [17:05:10] However, you should focus on link() and linkKnown :) [17:05:34] FlorianSW: Should I replace on all the Special pages ? Or just on the pages that I made the patch on ? I made the path on 10 Special pages [17:05:51] *patch [17:06:06] 5 at least [17:06:27] subins2000: you can do as most as you want. However, try to keep a single change as small as possible, 10 special pages are already a lot of things, so you shouldn't do more things in it :) [17:06:38] rlot is right, too, iirc the task requests at least 5 changes :) [17:06:47] Take a look there: https://gerrit.wikimedia.org/r/#/c/324925/ [17:07:45] Hey ISBetrayal0520, how was Philippine Model Congress? :) [17:07:47] subins2000: and remember, replace ->escape() with ->text() in msg [17:08:08] The_Codeguy: Hey, how did you find out? [17:08:12] The_Codeguy: PM [17:08:26] rlot: I'm gonna update the review with 5 more Linker::linkKnown() replacements : https://gerrit.wikimedia.org/r/#/c/325090/ [17:08:27] ISBetrayal0520: ;) [17:09:35] 10AbuseFilter, 07Regression: If statements containing several statements don't work anymore in edit filters - https://phabricator.wikimedia.org/T152281#2844245 (10BethNaught) [17:09:43] rlot: Thanks [17:11:35] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2844259 (10Samwalton9) [17:11:37] 10The-Wikipedia-Library: Internationalization - https://phabricator.wikimedia.org/T118254#2844260 (10Samwalton9) [17:11:39] mvolz: Can you look at github? [17:11:39] 10The-Wikipedia-Library: Allow different languages for the partner's description field - https://phabricator.wikimedia.org/T151364#2844258 (10Samwalton9) [17:11:50] FlorianSW: "Don't do more things". So I guess stick on this patch https://gerrit.wikimedia.org/r/#/c/325090/ or update the patch with linkKnown replacements() ? [17:13:07] (03PS8) 10Cenarium: [WIP] Deferred changes blocks [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/317324 [17:13:09] (03PS30) 10Cenarium: Implementation of deferred changes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/218104 (https://phabricator.wikimedia.org/T118696) [17:13:11] (03PS8) 10Cenarium: Add echo notification when deferred [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316957 [17:13:13] (03PS9) 10Cenarium: [WIP] Allow to automatically defer from software change tags [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/315344 [17:13:20] subins2000: update the linkKnown replacements in this change, but only for special pages, which are already modified by this change :) [17:13:35] FlorianSW: Ok :) [17:14:34] (03PS2) 10MarcoAurelio: Add $magicWords translation for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/322614 (https://phabricator.wikimedia.org/T151134) (owner: 10Pmlineditor) [17:15:21] Ayo , sup? [17:15:50] (03CR) 10MarcoAurelio: "I've manually rebased the change." [core] - 10https://gerrit.wikimedia.org/r/322614 (https://phabricator.wikimedia.org/T151134) (owner: 10Pmlineditor) [17:16:07] 10The-Wikipedia-Library: Collect interface translations for all relevant languages - https://phabricator.wikimedia.org/T152299#2844261 (10Samwalton9) [17:16:55] 10The-Wikipedia-Library: Collect interface translations for all relevant languages - https://phabricator.wikimedia.org/T152299#2844261 (10Samwalton9) [17:17:09] (03CR) 10Cenarium: Implementation of deferred changes (0311 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/218104 (https://phabricator.wikimedia.org/T118696) (owner: 10Cenarium) [17:17:24] 10The-Wikipedia-Library: Collect interface translations for all relevant languages - https://phabricator.wikimedia.org/T152299#2844261 (10Samwalton9) Though this should probably be one of the last things we do for v1.5 since the interface is liable to change between now and then. [17:18:12] 10The-Wikipedia-Library: Internationalization - https://phabricator.wikimedia.org/T118254#2844277 (10Samwalton9) [17:18:14] 10The-Wikipedia-Library: Collect interface translations for all relevant languages - https://phabricator.wikimedia.org/T152299#2844279 (10Samwalton9) [17:20:44] (03PS1) 10Niharika29: Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) [17:21:18] (03CR) 10Cenarium: Add echo notification when deferred (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316957 (owner: 10Cenarium) [17:22:07] Hi this is Humblefool, a part of Google Code-in [17:22:14] Hi! [17:22:22] (03PS5) 10Subins2000: Replaced Linker::link() and Linker::linkKnown() usage with LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) [17:23:06] 10Wikimedia-Wikimania-Scholarships: Add new questions regarding staff/board status - https://phabricator.wikimedia.org/T151371#2844282 (10Niharika) {F4961183} {F4961182} [17:25:10] 10MediaWiki-extensions-CentralNotice, 07Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#2844285 (10Jseddon) p:05Triage>03Lowest [17:27:28] (03PS2) 10MarcoAurelio: Typo fix [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/324871 [17:28:30] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2844287 (10Samwalton9) [17:28:33] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#2844288 (10Samwalton9) [17:28:34] 10The-Wikipedia-Library: Create database backup strategy - https://phabricator.wikimedia.org/T149433#2844286 (10Samwalton9) [17:29:14] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2692820 (10Samwalton9) [17:29:16] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) [17:29:18] 10The-Wikipedia-Library: Add async email-sending strategy - https://phabricator.wikimedia.org/T149436#2844289 (10Samwalton9) [17:29:52] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) [17:29:54] 10The-Wikipedia-Library: Conduct a general survey of users who have applied through the Library Card Platform - https://phabricator.wikimedia.org/T150494#2844292 (10Samwalton9) [17:30:15] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2692820 (10Samwalton9) [17:30:17] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) [17:30:19] 10The-Wikipedia-Library: Make gunicorn start automatically on boot - https://phabricator.wikimedia.org/T149738#2844294 (10Samwalton9) [17:30:29] has anyone gotten the wikidata role to work with vagrant? [17:32:56] why there are 2 wikibugs? [17:39:54] lol [17:40:08] bye [17:44:46] bye! [17:44:51] 10Wikimedia-Site-requests, 13Patch-For-Review: Create Livvi-Karelian Wikipedia at olo.wikipedia.org - https://phabricator.wikimedia.org/T146612#2844297 (10MarcoAurelio) * category collation, on a subtask * add to meta_p? (and check if all new wikis are there as well?) [17:45:45] 10MobileFrontend, 06Reading-Web-Backlog, 07Mobile: In mobile version, hidden edit summary is always shown to users who have permission to view it (no indication that it's hidden for everyone else) - https://phabricator.wikimedia.org/T118864#2844299 (101339861mzb) i will provide two pictures for the same page... [17:46:42] (03CR) 10Jforrester: [C: 032] Minor fixes: comments, obsolete stuff [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/324814 (owner: 10MaxSem) [17:47:46] (03CR) 10Jforrester: [C: 032] generateTables cleanup [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/324815 (owner: 10MaxSem) [17:48:26] (03CR) 10Jforrester: [C: 032] Convert to new array syntax [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/324816 (owner: 10MaxSem) [17:56:22] (03Merged) 10jenkins-bot: Minor fixes: comments, obsolete stuff [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/324814 (owner: 10MaxSem) [17:56:24] (03Merged) 10jenkins-bot: generateTables cleanup [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/324815 (owner: 10MaxSem) [17:56:26] (03Merged) 10jenkins-bot: Convert to new array syntax [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/324816 (owner: 10MaxSem) [17:57:24] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T152300#2844300 (10Samwalton9) [17:58:18] 04(no projects): Ease creating collapsible lists - https://phabricator.wikimedia.org/T152301#2844312 (10VictorPorton) [17:58:48] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T102064#2844323 (10Samwalton9) [17:59:16] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T152300#2844325 (10Samwalton9) 05Open>03Invalid I was going to move tasks over to this one but reworded the above into 102064 instead; ignore this. [18:02:40] legoktm: are you around? :) [18:05:19] 10The-Wikipedia-Library: Create interface for general filtering of ExternalLinksChange data - https://phabricator.wikimedia.org/T152302#2844330 (10Samwalton9) [18:05:46] 10The-Wikipedia-Library: Create interface for general filtering of ExternalLinksChange data - https://phabricator.wikimedia.org/T152302#2844342 (10Samwalton9) [18:05:47] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T102064#2844343 (10Samwalton9) [18:10:39] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) [18:10:55] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T102064#2844359 (10Samwalton9) [18:10:57] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844358 (10Samwalton9) [18:11:24] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#2844361 (10Samwalton9) [18:11:26] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T102064#1354780 (10Samwalton9) [18:11:58] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) [18:12:00] 10The-Wikipedia-Library: Integrate link addition metrics through API pull into Library card platform - https://phabricator.wikimedia.org/T102059#2844364 (10Samwalton9) 05Open>03declined Going with a different approach, see T102064. [18:13:06] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) [18:13:09] 10The-Wikipedia-Library: Version 1.5: Beta fixes - https://phabricator.wikimedia.org/T147434#2844372 (10Samwalton9) [18:14:02] 04(no projects): Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2844376 (10Dereckson) a:03Dereckson [18:14:15] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) This has now been split out into T147434, T151802, T151803, T151804, and T102064. [18:14:32] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#2844387 (10Samwalton9) [18:14:58] 10The-Wikipedia-Library: Library Card Platform - https://phabricator.wikimedia.org/T102048#1354542 (10Samwalton9) [18:18:15] 10The-Wikipedia-Library: Filtering of data by URL pattern - https://phabricator.wikimedia.org/T152305#2844389 (10Samwalton9) [18:18:58] 10The-Wikipedia-Library: Filtering of data by URL pattern - https://phabricator.wikimedia.org/T152305#2844401 (10Samwalton9) [18:19:00] 10The-Wikipedia-Library: Create interface for general filtering of ExternalLinksChange data - https://phabricator.wikimedia.org/T152302#2844402 (10Samwalton9) [18:20:20] 10The-Wikipedia-Library: Filtering of data within a given time frame - https://phabricator.wikimedia.org/T152306#2844403 (10Samwalton9) [18:20:31] 10The-Wikipedia-Library: Create interface for general filtering of ExternalLinksChange data - https://phabricator.wikimedia.org/T152302#2844330 (10Samwalton9) p:05Triage>03Normal [18:20:38] 10The-Wikipedia-Library: Filtering of data by URL pattern - https://phabricator.wikimedia.org/T152305#2844389 (10Samwalton9) p:05Triage>03Normal [18:21:56] 10The-Wikipedia-Library: Create interface for general filtering of ExternalLinksChange data - https://phabricator.wikimedia.org/T152302#2844418 (10Samwalton9) [18:23:18] 10The-Wikipedia-Library: Filtering of data by username - https://phabricator.wikimedia.org/T152307#2844419 (10Samwalton9) [18:23:20] 10The-Wikipedia-Library: Filtering of data by username - https://phabricator.wikimedia.org/T152307#2844419 (10Samwalton9) [18:23:22] 10The-Wikipedia-Library: Filtering of data by page name - https://phabricator.wikimedia.org/T152308#2844433 (10Samwalton9) [18:23:30] 10The-Wikipedia-Library: Filtering of data by page name - https://phabricator.wikimedia.org/T152308#2844433 (10Samwalton9) p:05Normal>03Low [18:27:28] (03CR) 10Florianschmidtwelzow: "> 1) I don't think manifest_version should be handled by this - it should stay very simple and quick in ExtensionRegistry IMO." [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [18:27:55] (03PS29) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [18:27:58] addshore: https://github.com/Wikidata-lib/PropertySuggester/pull/184 is merged. :) Can I submit? [18:27:58] (03PS1) 10Florianschmidtwelzow: Don't let extensions load other extensions lately [core] - 10https://gerrit.wikimedia.org/r/325117 [18:28:01] (03PS1) 10Florianschmidtwelzow: registration: Generalize CoreVersionChecker to VersionChecker [core] - 10https://gerrit.wikimedia.org/r/325118 [18:28:32] (03PS2) 10Florianschmidtwelzow: registration: Don't let extensions load lately [core] - 10https://gerrit.wikimedia.org/r/325117 [18:28:43] (03PS4) 10Aftab: adding $magicWords translations for bengali [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) [18:30:20] Hello everyone. I'm taking part in GCI 2016. I hope to learn a lot while having fun! [18:31:28] (03PS5) 10Aftab: adding CategoryTree.i18n.magic $magicWords translations for bengali [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) [18:31:45] GodofDragons: hello! Welcome. :) [18:32:37] MtDu_: Hey! Thanks. Can I help in any way? [18:33:02] (03CR) 10Florianschmidtwelzow: [C: 031] "waiting for feedback from legoktm for the comment of Reedy :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324666 (https://phabricator.wikimedia.org/T151136) (owner: 10Legoktm) [18:33:23] 10Montage: Montage parallel service during Tools maintenance time - https://phabricator.wikimedia.org/T149974#2844450 (10mahmoud) @yuvipanda Thanks man :) [18:33:47] (03PS3) 10Florianschmidtwelzow: registration: Don't let extensions load lately [core] - 10https://gerrit.wikimedia.org/r/325117 (https://phabricator.wikimedia.org/T117277) [18:34:01] (03PS2) 10Florianschmidtwelzow: registration: Generalize CoreVersionChecker to VersionChecker [core] - 10https://gerrit.wikimedia.org/r/325118 (https://phabricator.wikimedia.org/T117277) [18:34:16] (03PS3) 10Florianschmidtwelzow: registration: Generalize CoreVersionChecker to VersionChecker [core] - 10https://gerrit.wikimedia.org/r/325118 (https://phabricator.wikimedia.org/T117277) [18:34:24] (03PS30) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [18:34:43] (03CR) 10Divadsn: "This could be solved using PHP_EOL instead of "\n", but it would make the code lines longer." (031 comment) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [18:38:50] (03CR) 10Harjotsingh: "@Jdlrobson Thanks for the information." [core] - 10https://gerrit.wikimedia.org/r/320612 (https://phabricator.wikimedia.org/T114883) (owner: 10Harjotsingh) [18:41:18] (03CR) 10Alex Monk: "Id62d8d77 for deployment-prep compatibility, you'll want a CommonSettings.php change too before this goes out in the train" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [18:43:29] (03CR) 10jenkins-bot: [V: 04-1] registration: Generalize CoreVersionChecker to VersionChecker [core] - 10https://gerrit.wikimedia.org/r/325118 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [18:44:55] 10Social-Tools, 10SocialProfile: ConvertSocialProfile SystemGifts special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152309#2844453 (10SamanthaNguyen) [18:45:05] (03CR) 10jenkins-bot: [V: 04-1] registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [18:45:15] 10Social-Tools, 10SocialProfile: Convert SocialProfile SystemGifts special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152309#2844453 (10SamanthaNguyen) [18:46:01] (03PS3) 10Aftab: Gadgets.alias.php translation for bengali [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323888 [18:46:28] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserGifts special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152310#2844467 (10SamanthaNguyen) [18:48:37] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserBoard special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152311#2844480 (10SamanthaNguyen) [18:51:14] addshore: Submitted. [18:52:18] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserProfile special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152312#2844493 (10SamanthaNguyen) [18:53:30] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserRelationship special page forms to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152313#2844506 (10SamanthaNguyen) [18:54:25] 04(no projects): User setting for collapsible elements - https://phabricator.wikimedia.org/T152314#2844519 (10VictorPorton) [19:03:34] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2844531 (10FilipGCI) [19:07:33] 04(no projects): Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152315#2844534 (10Dereckson) a:03Dereckson [19:07:59] 07Design, 10MediaWiki-extensions-FlaggedRevs: Aligning FlaggedRevision to WikimediaUI color palette received negative feedback - https://phabricator.wikimedia.org/T152258#2844536 (10Volker_E) @Ladsgroup Are there any before (the patch) screenshots available to have a direct comparison of the change? [19:08:14] 10MediaWiki-extensions-UniversalLanguageSelector, 07Regression: "jquery.uls.data" syntax error in IE11 - https://phabricator.wikimedia.org/T152180#2844537 (10Amire80) I tried reproducing this and didn't succeed. I tried with IE 11 on Windows 7, logged-in and logged-out, with Compact Language Links on and off.... [19:08:39] 10MediaWiki-extensions-Scribunto, 15User-Dereckson: Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2844538 (10Dereckson) [19:09:20] (03PS6) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [19:09:28] (03CR) 10jenkins-bot: [V: 04-1] Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [19:10:08] 10The-Wikipedia-Library: Display filtered data in different categories - https://phabricator.wikimedia.org/T152316#2844539 (10Samwalton9) [19:10:30] 10The-Wikipedia-Library: Display filtered data in different categories - https://phabricator.wikimedia.org/T152316#2844539 (10Samwalton9) [19:10:41] 10MediaWiki-extensions-Scribunto, 15User-Dereckson: Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2844554 (10Dereckson) p:05Triage>03Low [19:13:14] (03PS7) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [19:13:21] (03CR) 10jenkins-bot: [V: 04-1] Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [19:14:11] I give up, this is going insane, spend the entire day on searching double quotes, now it fails to build.. [19:14:25] 10The-Wikipedia-Library: Display filtered data in different categories - https://phabricator.wikimedia.org/T152316#2844557 (10Samwalton9) @MER-C Do you think this would be sufficient? I took your comments from T118042 into consideration here. [19:15:00] (03PS8) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [19:16:23] (03CR) 10Divadsn: "I have replaced every "\n" with PHP_EOL and reformatted everything I could see, I hope that this was the last patchset for today :)" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [19:19:25] divadsn: it's ok. I feel you. Sometimes, it takes a while. Make sure you rest! Wouldn't want you to go insane. :) [19:20:11] mvolz, it seems like the build succeed, lets hope that this mess is done for now ^^ [19:20:50] MtDu_, well if you would see the code I have to reformat, such a huge mess, double quotes mixed with single quotes, tabs here and here, this was hard to sort out. [19:21:17] I will go offline for now, see ya! [19:21:28] (03PS1) 10Florianschmidtwelzow: WIP: registration: Add possibility to set CONTENT_MODEL_ and CONTENT_FORMAT_ constants [core] - 10https://gerrit.wikimedia.org/r/325120 (https://phabricator.wikimedia.org/T108285) [19:21:32] (Maybe I play a game in the meanwhile :D) [19:21:41] (03CR) 10Florianschmidtwelzow: [C: 04-2] WIP: registration: Add possibility to set CONTENT_MODEL_ and CONTENT_FORMAT_ constants [core] - 10https://gerrit.wikimedia.org/r/325120 (https://phabricator.wikimedia.org/T108285) (owner: 10Florianschmidtwelzow) [19:22:10] 10The-Wikipedia-Library: Allow tracking of TWL partner references through strings - https://phabricator.wikimedia.org/T152317#2844563 (10Samwalton9) [19:23:21] 10The-Wikipedia-Library: Report where links have been added for Wikipedia Library partners - https://phabricator.wikimedia.org/T130988#2844577 (10Samwalton9) [19:23:24] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) [19:23:28] FlorianSW: I am too slow to claim your tasks. :P [19:23:42] 10The-Wikipedia-Library: Report link number changes for Wikipedia Library partners - https://phabricator.wikimedia.org/T131035#2844582 (10Samwalton9) [19:23:44] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) [19:23:45] (03CR) 10Florianschmidtwelzow: "This is just an idea and a very early implementation. I'm open for opinions about better approaches here, as I think I don't have that dee" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325120 (https://phabricator.wikimedia.org/T108285) (owner: 10Florianschmidtwelzow) [19:23:54] 10The-Wikipedia-Library: Report overall link numbers for Wikipedia Library partners - https://phabricator.wikimedia.org/T130987#2844586 (10Samwalton9) [19:23:57] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) [19:24:03] MtDu_: hmm? :D [19:25:04] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T102064#2844594 (10Samwalton9) [19:25:08] 10Possible-Tech-Projects, 10The-Wikipedia-Library: Map different types of measurement for T115119 's schema - https://phabricator.wikimedia.org/T118042#2844589 (10Samwalton9) 05Open>03Resolved a:03Samwalton9 The above information has been taken into account and merged into T152302 and its more granular s... [19:25:47] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844595 (10Samwalton9) p:05Triage>03Normal [19:26:39] 10MediaWiki-extensions-Scribunto, 15User-Dereckson: Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2844608 (10Dereckson) For pcntl, it seems pcntl_* functions are disabled by default on Ubuntu 16.10. ```name=Dockerfile FROM ubuntu:16.10 # On Ubuntu, the php package w... [19:26:45] https://gerrit.wikimedia.org/r/#/c/325090/ [19:26:49] (03PS4) 10Florianschmidtwelzow: registration: Generalize CoreVersionChecker to VersionChecker [core] - 10https://gerrit.wikimedia.org/r/325118 (https://phabricator.wikimedia.org/T117277) [19:27:19] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) [19:27:21] divadsn: if you want to put it back to review on the GCI site we'll see if we can't get this merged :) [19:27:41] (03PS31) 10Florianschmidtwelzow: registration: Allow specifying extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [19:28:03] 10MediaWiki-Special-pages, 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage: "What links here" and "Page information" should not appear on Special:NewPagesFeed - https://phabricator.wikimedia.org/T152319#2844610 (10GeoffreyT2000) [19:30:28] 10The-Wikipedia-Library: Ability to crate pages per Wikipedia Library partner - https://phabricator.wikimedia.org/T152320#2844623 (10Samwalton9) [19:31:09] mvolz, submitted for review on GCI ;) [19:32:07] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) [19:32:21] 10The-Wikipedia-Library: Ability to create pages per Wikipedia Library partner - https://phabricator.wikimedia.org/T152320#2844623 (10Samwalton9) [19:32:37] hmm, divadsn it looks like you undid some changes you had previously made in the latest patchset? https://gerrit.wikimedia.org/r/#/c/325097/5..8/Question.php :( [19:33:00] for instance the comments were #, then //, then # again... is it possible you edit the wrong version? [19:33:05] edited* [19:33:26] Ooops wth?! o_O [19:33:45] and line lengths too :( [19:33:53] Well, I think the samba share got broken, shi... [19:33:55] (03CR) 10Fomafix: Move JS to RL module (037 comments) [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/323664 (owner: 10Reedy) [19:34:02] here, have this: t [19:34:04] :D [19:34:18] * divadsn bumps his head against a wall [19:34:39] I bet you wish you never claimed this task [19:34:57] (code reformatting... yay....) [19:35:02] * subins2000 :O [19:35:46] But I believe that somehow my work will be counted as good, it's not all about the amount of tasks done C: [19:36:34] divadsn: indeed :D. for the good of the people that edit it next ^-^ [19:36:35] And my target is to do one task a day, maybe 2 or 3 when the christmas break will come ^^ [19:36:52] 10The-Wikipedia-Library: Track and display overall link numbers for TWL partner URL pattern(s) - https://phabricator.wikimedia.org/T152322#2844652 (10Samwalton9) [19:36:59] Is there a way to revert git to the 5th patchset? [19:37:07] yes [19:37:36] but the other file looks okay, so we don't want to undo that [19:37:46] I would just pick a diff between the 5th and latest patchset and copy over the new changes [19:39:05] If only Google sponsors GCI all year long.. [19:39:47] dargasia, there is Google Code of Summer if I am not wrong ^^ [19:39:49] FlorianSW: Familiar with Phabricator? I accidentally changed my profile picture and now when I upload I get this. No configured storage engine can store this file. See "Configuring File Storage" in the documentation for information on configuring storage engines. [19:40:11] ha yeah; just amazing how quick backlogs clear once there's competition [19:41:00] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844665 (10Samwalton9) [19:41:22] mvolz, so it is only that one file which seems to be "broken" due to this: https://img.rly.li/frj5/2g05l1.png ? [19:41:51] divadsn: you can checkout older patchsets from here: Patch Sets (8/8) in the upper right hand corner [19:42:09] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 07Browser-Support-Internet-Explorer, 13Patch-For-Review: Minimized PageCuration Toolbar rotates text 180 degrees instead of 90 degrees under IE11 - https://phabricator.wikimedia.org/T105846#2844667 (10GeoffreyT2000) 05Open>03Resolved a:... [19:42:53] MtDu: ähm... I would say yes to the question "Familiar with Phabrciator?". However, just as a user :( iirc andre__ and twentyafterfour are administrators in phabricator and at least twentyafterfour is the person who did maintenance task in the past. Probably one of these two can help you better :) [19:43:04] another way would be to open a task in phabricator :P [19:43:59] 10The-Wikipedia-Library: Create administrator interface for adding new partners - https://phabricator.wikimedia.org/T152323#2844670 (10Samwalton9) [19:44:16] mvolz, Hm, so yes, only Question.php is broken, well I fix this asap and go off ^^" [19:44:20] 10MediaWiki-extensions-Scribunto, 15User-Dereckson: Do an Ubuntu + PHP 7 + Luasandbox/pcntl test - https://phabricator.wikimedia.org/T152304#2844683 (10Dereckson) 05Open>03Resolved For luasandbox, it works, but explicit extension load is required. ```name=Dockerfile FROM ubuntu:16.10 RUN apt update && ap... [19:44:29] MtDu, I'm having trouble reproducing your error. [19:44:38] I changed profile pics back and forth just fine [19:45:09] 10Reading-Community-Engagement, 06Reading-Web-Backlog: Improve site branding on Mobile website - https://phabricator.wikimedia.org/T148514#2844685 (10Nirzar) [19:46:48] MtDu, I can also confirm what dargasia said, it works for me :/ [19:46:53] 10The-Wikipedia-Library: Integration with the Library Card Platform for user data - https://phabricator.wikimedia.org/T152324#2844686 (10Samwalton9) [19:46:56] Maybe your image is too large [19:47:23] 10Reading-Community-Engagement, 06Reading-Web-Backlog: Improve site branding on Mobile website - https://phabricator.wikimedia.org/T148514#2844699 (10Nirzar) >I suppose the nearby page change is outside the scope of the task not really, this is the way current nearby works. it replaces the bell icon with relo... [19:48:12] MtDu, just adding that if you keep expericing troubles, you can also talk to #wikipedia-operations [19:48:26] 10The-Wikipedia-Library: Partner pages should only show link changes for users with access to that partner - https://phabricator.wikimedia.org/T152325#2844700 (10Samwalton9) [19:48:26] #wikimedia-operations * ^ [19:50:08] 10Reading-Community-Engagement, 06Reading-Web-Backlog: Improve site branding on Mobile website - https://phabricator.wikimedia.org/T148514#2844717 (10Nirzar) [19:52:00] 10The-Wikipedia-Library: Partner pages should only show link changes for users with access to that partner - https://phabricator.wikimedia.org/T152325#2844719 (10Samwalton9) p:05Normal>03Triage [19:52:14] 10The-Wikipedia-Library: Partner pages should only show link changes for users with access to that partner - https://phabricator.wikimedia.org/T152325#2844700 (10Samwalton9) p:05Normal>03Triage [19:52:17] 10The-Wikipedia-Library: Partner pages should only show link changes for users with access to that partner - https://phabricator.wikimedia.org/T152325#2844700 (10Samwalton9) p:05Triage>03Normal [19:53:08] 10Reading-Community-Engagement, 06Reading-Web-Backlog: Improve site branding on Mobile website - https://phabricator.wikimedia.org/T148514#2844734 (10Nirzar) >I'm not seeing any mocks for how the footer should look, so we can assume it's not impacted in any way? If so can you mention that in the task descripti... [19:53:16] 10The-Wikipedia-Library: Create interface for TWL tracking & reporting of ExternalLinksChange data - https://phabricator.wikimedia.org/T152303#2844346 (10Samwalton9) p:05Normal>03High [19:53:55] 10The-Wikipedia-Library: Create a tool to display and filter data from Schema:ExternalLinksChange - https://phabricator.wikimedia.org/T102064#1354780 (10Samwalton9) p:05Normal>03High [19:54:13] 10The-Wikipedia-Library: Collect interface translations for all relevant languages - https://phabricator.wikimedia.org/T152299#2844739 (10Samwalton9) p:05Normal>03Lowest [19:54:36] (03PS9) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [19:54:51] 10Reading-Community-Engagement, 06Reading-Web-Backlog: Improve site branding on Mobile website - https://phabricator.wikimedia.org/T148514#2844745 (10Nirzar) [19:55:47] 10The-Wikipedia-Library: Include capability for metrics of strings - https://phabricator.wikimedia.org/T102620#1369481 (10Samwalton9) [19:55:48] 10The-Wikipedia-Library: Allow tracking of TWL partner references through strings - https://phabricator.wikimedia.org/T152317#2844750 (10Samwalton9) [19:55:51] (03CR) 10Florianschmidtwelzow: [C: 04-1] "two little things. And: Can we do some css magic, so that the checkboxes doesn't have soo much space between each other? At least the marg" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/225536 (https://phabricator.wikimedia.org/T117884) (owner: 10Florianschmidtwelzow) [19:56:04] mvolz, I managed to revert these changes back :) [19:56:36] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2844751 (10FilipGCI) [19:56:41] Now it should be 100% MediaWikiCodeConvention-proof :D [20:01:06] 10Technical-Tool-Request: Wish: Host LanguageTool WikiCheck on Tool Labs - https://phabricator.wikimedia.org/T152049#2844756 (10WTM) [20:08:37] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2844760 (10FilipGCI) [20:09:15] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General-or-Unknown, 07Easy, 03Google-Code-In-2016, and 2 others: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139#2839668 (10FilipGCI) [20:28:23] Why i'm getting "Could not connect to gerrit." in git [20:28:35] Guest92096, how are you doing this? [20:29:19] (Btw, i'm rlot_ some nick problems), i'm trying to commit a patch [20:29:49] From cloned repo via username [20:31:14] (03PS1) 10Filip: Update Maintenance script to use $this->requireExtension() [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/325124 (https://phabricator.wikimedia.org/T152139) [20:31:25] Are you going this on your host machine or on vagrant using 'vagrant ssh'? [20:31:32] *doing [20:32:37] And if you have connection problems with IRC, then I can recommend you to get a IRC bouncer or to use a web client like Shout-IRC or The Lounge (if you have a server where you can host this) [20:32:44] (03PS2) 10Filip: Update Maintenance script to use $this->requireExtension() [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/325124 (https://phabricator.wikimedia.org/T152139) [20:33:07] (03CR) 10Gergő Tisza: [C: 031] Update for API error i18n (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/321439 (owner: 10Anomie) [20:36:56] Ok, i re-cloned it [20:36:59] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: CapsuleMultiSelectWidget: Label doesn't function as label - https://phabricator.wikimedia.org/T148946#2844772 (10Volker_E) p:05Triage>03Low [20:37:00] and its working [20:37:05] Thanks! [20:38:54] 10UI-Standardization, 10OOjs-UI, 03UI-Standardization-Kanban: Should OOjs UI Widgets apply `box-sizing: border-box` as general rule? - https://phabricator.wikimedia.org/T147692#2844774 (10Volker_E) p:05High>03Lowest [20:42:05] (03PS1) 10Filip: Update Maintenance script to use $this->requireExtension() [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/325125 (https://phabricator.wikimedia.org/T152139) [20:46:37] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 10Wikimedia-Developer-Summit (2017): MediaWiki Documentation - https://phabricator.wikimedia.org/T149372#2844777 (10Xephyr826) This is a topic I'm very interested in as a technical writer and new MediaWiki contributor. One idea I'd like to propose is an... [20:49:11] (03PS1) 10Filip: Update Maintenance script to use $this->requireExtension() [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/325126 (https://phabricator.wikimedia.org/T152139) [20:53:08] (03CR) 10Divadsn: "After patch set 5 Question.php seemed to be reverted for some reasons, now I reverted this back and added my changes." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [21:05:43] 04(no projects): Expand/collapse scrolling view - https://phabricator.wikimedia.org/T152326#2844781 (10VictorPorton) [21:06:09] (03CR) 10MaxSem: [C: 032] "Thanks! =)" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/325126 (https://phabricator.wikimedia.org/T152139) (owner: 10Filip) [21:07:23] (03CR) 10Florianschmidtwelzow: [C: 04-1] "some little comments, otherwise looks good. I'll give legoktm give some time to look at this change, too :)" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [21:10:16] FlorianSW, hi! [21:10:28] victorbarbu: hi :) [21:10:35] you're very hard to reach :)) [21:10:56] so I'm working on that recentchanges-to-ooui conversion [21:11:03] I found this ins the code [21:11:03] if ( $this->getConfig()->get( 'AllowCategorizedRecentChanges' ) ) { [21:11:03] $extraOpts['category'] = $this->categoryFilterForm( $opts ); [21:11:03] } [21:11:06] victorbarbu: unfortunately, yes, sorry for that :( If you've requests, you can also send me an e-mail :P [21:11:40] ok, what is with that? :) [21:11:45] However that categoryFilterForm is not displayed in my wiki nor on wikipedia [21:11:51] what should I configure to see it? [21:12:44] victorbarbu: you need to enable the configuration option AllowCategorizedRecentChanges :) [21:12:56] I am not sure where to do that [21:12:59] That's what §this->getConifg()->get() does, it returns the value of a configuration option :) [21:13:03] in the LocalSettings? [21:13:10] You simply add $wgAllowCategorizedRecentChanges = true to your LocalSettings.php :) [21:13:15] * $wgAllowCategorizedRecentChanges = true; [21:13:17] you're a god [21:13:41] :P [21:13:45] no, not really :D [21:14:07] could you please take a look at my patch? [21:14:15] it's currently WIP however [21:14:47] if you've a link, sure :P [21:15:16] ok, found it: https://gerrit.wikimedia.org/r/#/c/325049/ [21:17:49] (03Merged) 10jenkins-bot: Update Maintenance script to use $this->requireExtension() [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/325126 (https://phabricator.wikimedia.org/T152139) (owner: 10Filip) [21:24:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Haven't looked at the complete implementation, however, for a WIP it looks good." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [21:24:18] victorbarbu: ^ :) [21:24:33] FlorianSW, sorry for that [21:24:38] I didn't see the message [21:24:45] 07Design, 10New-Readers, 06Reading-Web-Backlog (Design): Saved screen if there are no saved pages - https://phabricator.wikimedia.org/T149603#2844793 (10Nirzar) [21:24:51] no worries, anything is ok :) [21:24:54] what do you think? [21:24:59] 07Design, 10New-Readers, 06Reading-Web-Backlog (Design): Saved screen if there are no saved pages - https://phabricator.wikimedia.org/T149603#2757573 (10Nirzar) a:05Nirzar>03Jhernandez [21:25:09] 07Design, 10New-Readers, 06Reading-Web-Backlog (Design): Saved screen if there are no saved pages - https://phabricator.wikimedia.org/T149603#2757573 (10Nirzar) @atgo done from design [21:25:11] victorbarbu: I added a comment, see the message from grrrit-wm :) [21:25:21] That's what I meant with my "^" :D [21:25:26] sorry for the confusion :P [21:28:31] (03CR) 10Victorbarbu: [WIP] Convert Special:RecentChanges to OOUI (032 comments) [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [21:30:52] Thiemo_WMDE, I am sorry that I "disturbed" your patch, I will follow up my patch after yours will be merged. [21:31:45] 10MediaWiki-Database, 10MediaWiki-Unit-tests, 07PostgreSQL, 07Regression: 1.28-alpha / Error: 42P01 ERROR: table "unittest_user_groups" does not exist - https://phabricator.wikimedia.org/T149454#2844805 (10Paladox) @mwjames and @aaron the reason why https://travis-ci.org/paladox/SemanticMediaWiki/builds/1... [21:32:18] FlorianSW, http://imgur.com/a/olLXr [21:32:27] (03CR) 10Legoktm: [C: 032] Update Maintenance script to use $this->requireExtension() [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/325125 (https://phabricator.wikimedia.org/T152139) (owner: 10Filip) [21:32:44] stashbot: teleport me to T149771 [21:32:44] See https://wikitech.wikimedia.org/wiki/Tool:Stashbot for help. [21:32:44] T149771: TimedMediaHandler does not support Japanese/Chinese file name - https://phabricator.wikimedia.org/T149771 [21:33:04] (03CR) 10Legoktm: [C: 032] Update Maintenance script to use $this->requireExtension() [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/325124 (https://phabricator.wikimedia.org/T152139) (owner: 10Filip) [21:33:51] (03CR) 10Gergő Tisza: [C: 031] Update for API error i18n [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/321457 (owner: 10Anomie) [21:33:53] (03Merged) 10jenkins-bot: Update Maintenance script to use $this->requireExtension() [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/325125 (https://phabricator.wikimedia.org/T152139) (owner: 10Filip) [21:34:00] (03Merged) 10jenkins-bot: Update Maintenance script to use $this->requireExtension() [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/325124 (https://phabricator.wikimedia.org/T152139) (owner: 10Filip) [21:34:34] victorbarbu: looks better, but still, the form is too big :( [21:34:46] I will align the labels to the left [21:34:49] instead of top [21:34:55] oh [21:34:58] I also have it zoomed [21:35:18] 10Social-Tools, 10SocialProfile: SocialProfile: Accessing Special:RemoveRelationship on social-tools.wmflabs directly returns a fatal error - https://phabricator.wikimedia.org/T152327#2844808 (10SamanthaNguyen) [21:35:38] You have zoom enabled ^^ http://rly.li/c6r7/585e9r [21:36:07] Whops, my ZNC was too slow, nevermind ;) [21:37:55] divadsn: usually I manually specify a freenode server [21:38:15] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserRelationship Special:AddRelationship to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152328#2844822 (10SamanthaNguyen) [21:38:38] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserRelationship Special:RemoveRelationship to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152329#2844835 (10SamanthaNguyen) [21:39:05] dargasia, well, my setup is a bit strange, I will make a mspaint drawing ;) [21:39:12] FlorianSW|away, is it ok if I remove the fieldset legends? [21:39:14] I like them [21:39:17] but if needed... [21:41:21] 04(no projects): Print collapsible elements expanded - https://phabricator.wikimedia.org/T152330#2844849 (10VictorPorton) [21:42:30] (03CR) 10Legoktm: [C: 04-1] "Looking good!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/325090 (https://phabricator.wikimedia.org/T149346) (owner: 10Subins2000) [21:42:47] (03CR) 10BryanDavis: [C: 032] Show a prominent flag on review screen if applicant is a minor [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324736 (https://phabricator.wikimedia.org/T151375) (owner: 10Niharika29) [21:43:16] (03PS2) 10BryanDavis: Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:43:34] (03PS2) 10Huji: Email footer should state that by responding one reveals their address [core] - 10https://gerrit.wikimedia.org/r/325040 (https://phabricator.wikimedia.org/T152242) [21:43:58] (03Merged) 10jenkins-bot: Remove Final:Full report from app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324715 (https://phabricator.wikimedia.org/T151377) (owner: 10Niharika29) [21:44:31] (03PS3) 10Victorbarbu: [WIP] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [21:44:46] (03Merged) 10jenkins-bot: Add a missing error message key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324721 (owner: 10Niharika29) [21:44:48] (03Merged) 10jenkins-bot: Show a prominent flag on review screen if applicant is a minor [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324736 (https://phabricator.wikimedia.org/T151375) (owner: 10Niharika29) [21:46:25] (03CR) 10Florianschmidtwelzow: "For the Form size One idea: Would it be able to Focus on the Elements that are Form Elements already and keeping the other ones (the hide/" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [21:46:34] 10Social-Tools, 07Epic: [EPIC] Convert forms in socials tools extensions to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152265#2844866 (10SamanthaNguyen) [21:47:32] (03PS3) 10BryanDavis: Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:47:40] (03CR) 10jenkins-bot: [V: 04-1] Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:47:46] FlorianSW|away, check this out http://imgur.com/a/s2QEy [21:47:50] it fits in the screen now [21:47:50] (03CR) 10BryanDavis: [C: 032] Add two questions for 2017 iteration (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:47:54] my screen at least [21:48:05] (03PS4) 10BryanDavis: Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:48:35] (03PS1) 10Seb35: Special config case [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/325127 [21:49:26] (03PS1) 10Jack Phoenix: Fix fatal when accessing Special:RemoveRelationship directly [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325128 (https://phabricator.wikimedia.org/T152327) [21:50:08] (03CR) 10Seb35: [C: 032 V: 032] Special config case [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/325127 (owner: 10Seb35) [21:50:13] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix fatal when accessing Special:RemoveRelationship directly [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325128 (https://phabricator.wikimedia.org/T152327) (owner: 10Jack Phoenix) [21:50:55] victorbarbu, looks good, did you tried to see how it looks with other screen resolutions? [21:51:02] 04(no projects): In SocialProfile Special:UpdateProfile, textareas can be expanded further than they should be able to - https://phabricator.wikimedia.org/T152331#2844873 (10SamanthaNguyen) [21:51:21] 10Social-Tools, 10SocialProfile: In SocialProfile Special:UpdateProfile, textareas can be expanded further than they should be able to - https://phabricator.wikimedia.org/T152331#2844885 (10SamanthaNguyen) [21:51:24] victorbarbu: is it this big by default? [21:51:32] (03CR) 10BryanDavis: Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:51:32] yeah [21:51:35] (03CR) 10BryanDavis: [C: 032] Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:51:46] that's the ooui style [21:52:03] FlorianSW|away, pointed something on gerrit [21:52:16] that I should keep the show|hide links as links here [21:52:18] not checkboxes [21:52:22] which is a good idea [21:52:29] but won't decrease the size very much [21:52:37] Can this be collapsed? [21:52:40] nope [21:52:47] that's what I was writing, I swear [21:52:49] :)) [21:53:01] Because I'd want to go in recent pages and see the recent changes, not the filter [21:53:19] 10Social-Tools, 10SocialProfile: SocialProfile: Accessing Special:RemoveRelationship on social-tools.wmflabs directly returns a fatal error - https://phabricator.wikimedia.org/T152327#2844890 (10SamanthaNguyen) 05Open>03Resolved a:03ashley [21:53:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [21:53:44] yeah [21:53:48] this is the current problem [21:53:49] usability [21:54:04] that's what Florian was telling me, to make the form smaller [21:54:13] but it cannot be made smaller than this [21:54:19] collapse would work fine [21:54:36] but dargasia, there is another problem you should consider [21:54:54] (03Merged) 10jenkins-bot: Add two questions for 2017 iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/325112 (https://phabricator.wikimedia.org/T151371) (owner: 10Niharika29) [21:55:03] once you've filtered the changes, you scroll down [21:55:05] and that's it [21:55:18] you don't care whether the form is collapsed or not, because you've already scrolled down [21:55:41] and collapse would be a nice feature however, but only available with js enabled [21:55:56] I feel like I shouldn't need to scroll down. [21:56:06] If the page is about recent pages, I would want it to be mainly about it [21:56:52] It would be better if it would collapse, so that people can expand it when they actually need it [21:57:31] (03CR) 10Gergő Tisza: [C: 032] Update for API error i18n [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/321419 (owner: 10Anomie) [21:59:01] 06Brickimedia, 10MediaWikiChat, 10Social-Tools: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2844897 (10SamanthaNguyen) [21:59:43] 06Brickimedia, 10MediaWikiChat: MediaWikiChat parses the input element when it shouldn't - https://phabricator.wikimedia.org/T152332#2844897 (10SamanthaNguyen) [22:00:36] Helloo yall [22:00:37] (03PS1) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/325129 [22:00:38] victorbarbu: ^ [22:01:14] Hi jellysnake ;) [22:01:29] dargasia, so you're saying that it should be collapsed by default [22:01:45] I agree [22:02:32] Yeah, if this can happen that would be great, victorbarbu. [22:04:24] (03PS1) 10Seb35: Cleaning [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/325130 [22:04:29] I will see what I can do [22:04:41] however, oojs-ui does not have accordions AFAIK [22:06:42] (03Merged) 10jenkins-bot: Update for API error i18n [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/321419 (owner: 10Anomie) [22:07:02] (03PS2) 10Paladox: Test: Do not merge [core] - 10https://gerrit.wikimedia.org/r/325129 [22:07:19] (03PS2) 10Seb35: Cleaning [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/325130 [22:07:32] 10Social-Tools, 10SocialProfile: Redesign accessing Special:AddRelationship and Special:RemoveRelationship in SocialProfile so they're more user-friendly - https://phabricator.wikimedia.org/T152333#2844911 (10SamanthaNguyen) [22:07:52] (03CR) 10Victorbarbu: "What if I give the panel a "max-height" in CSS and make it scrollable?" [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [22:08:39] (03CR) 10Seb35: [C: 032 V: 032] Cleaning [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/325130 (owner: 10Seb35) [22:18:23] dargasia, your wish was fulfilled! [22:19:37] (03CR) 10Mvolz: [C: 04-1] "Unfortunately the latest patchset is broken. If you want to test it, you can add a simple quiz to your dev wiki: https://en.wikiversity.or" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [22:20:12] (03PS4) 10Victorbarbu: [WIP] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) [22:22:12] mvolz, I see it on my test machine, ehh [22:22:47] The extraneous comma was introduced in the first patchset, fyi, didn't catch it until now! [22:23:50] (03CR) 10Umherirrender: [C: 04-1] "I am missing the class HTMLTagFilter where the context is on $this->mParent->getContext(), the rest looks good" [core] - 10https://gerrit.wikimedia.org/r/316836 (https://phabricator.wikimedia.org/T105649) (owner: 10Matěj Suchánek) [22:25:02] 10Phabricator, 06Brickimedia, 10Social-Tools: Create Herald rules for managing extensions under the Brickimedia and Social-Tools tags - https://phabricator.wikimedia.org/T147271#2844939 (10SamanthaNguyen) 05Open>03Resolved a:03SamanthaNguyen Seems like they've already been created, so whoever did it: T... [22:26:42] (03CR) 10Divadsn: "It generates the HTML code correctly, but it does not display on the page anymore, weird..." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [22:27:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert Special:RecentChanges to OOUI [core] - 10https://gerrit.wikimedia.org/r/325049 (https://phabricator.wikimedia.org/T117740) (owner: 10Victorbarbu) [22:28:24] (03CR) 10Umherirrender: [C: 032] Don't pass unsupported parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/324949 (owner: 10Matěj Suchánek) [22:31:11] 10Social-Tools, 10SocialProfile: Reformat the actions of some SocialProfile logs (Avatar upload log and User profile edit log) for consistency with other logs - https://phabricator.wikimedia.org/T146606#2844942 (10SamanthaNguyen) 1. Makes sense. I'm fine with what you suggested: "User Foo uploaded a new avatar... [22:31:38] 10MediaWiki-extensions-LiquidThreads, 06Collaboration-Team-Triage, 10Flow, 06translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#2844943 (10Nemo_bis) [22:36:20] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserProfile Special:EditProfile to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152334#2844945 (10SamanthaNguyen) [22:37:41] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserProfile Special:RemoveAvatar to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152335#2844958 (10SamanthaNguyen) [22:38:14] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserProfile Special:UpdateProfile to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152336#2844971 (10SamanthaNguyen) [22:38:21] I broke my mouse again while struggling where the bug could be... oh dear, what's wrong with me [22:38:43] 10Social-Tools, 10SocialProfile: Convert SocialProfile UserProfile Special:UploadAvatar to OOJS-UI HTMLForm - https://phabricator.wikimedia.org/T152337#2844984 (10SamanthaNguyen) [22:41:22] (03Merged) 10jenkins-bot: Don't pass unsupported parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/324949 (owner: 10Matěj Suchánek) [22:42:29] (03CR) 10Gergő Tisza: [C: 031] API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 (owner: 10Anomie) [22:44:18] (03CR) 10Divadsn: "That is impossible, as when I compare patchset 5 with the latest, there are no changes in the functionwise of the code." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [22:44:43] Summon anyone to help :( [22:45:23] (03PS3) 10Legoktm: Clarify in emailuserfooter that by responding one reveals their email address [core] - 10https://gerrit.wikimedia.org/r/325040 (https://phabricator.wikimedia.org/T152242) (owner: 10Huji) [22:45:39] (03CR) 10Legoktm: [C: 032] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/325040 (https://phabricator.wikimedia.org/T152242) (owner: 10Huji) [22:45:47] hi divadsn [22:45:51] what's up? [22:46:20] (03CR) 10Gergő Tisza: "> That seems trivial to fix, just add the array it is complaining" [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/313019 (owner: 10Vimja) [22:46:27] I am struggling to find why the heck this code won't work anymore with the latest patchset, https://gerrit.wikimedia.org/r/#/c/325097/ [22:47:41] (03CR) 10Paladox: "recheck" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [22:47:58] When I compare the latest patchset with patchset 5 (as mvolz confirmed that this was the recent working one), I can not see any difference where the code has been changed that it is not working now [22:50:23] https://gerrit.wikimedia.org/r/#/c/325097/5..9/Question.php [22:50:27] https://gerrit.wikimedia.org/r/#/c/325097/5..9/Quiz.class.php [22:51:19] fwiw I think using double quotes for "\n" is totally fine [22:52:57] 419 -» » » » » » $value = "<_{$possibility}_ >"; [22:52:57] 423 +» » » » » » $value = '<_{' . $possibility . '}_ >'; [22:53:20] divadsn: so the { } around a variable in double quotes are there to signal to PHP that it's a variable, you wouldn't keep them there if you're using single quotes [22:53:57] legoktm: Aaaaah, I thought they were for wikitext... that explains everything [22:56:06] (03Merged) 10jenkins-bot: Clarify in emailuserfooter that by responding one reveals their email address [core] - 10https://gerrit.wikimedia.org/r/325040 (https://phabricator.wikimedia.org/T152242) (owner: 10Huji) [22:56:39] divadsn: see https://secure.php.net/manual/en/language.types.string.php#language.types.string.parsing [22:57:33] legoktm: I never used this in my life in PHP, something learned :) [22:58:14] this is how I learned PHP too ;) [22:58:35] (03CR) 10Paladox: "Hi @Divadsn where it says Diff against in small words on the toolbar above the files to diff, select that and scroll to patchset 8. it wil" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [23:01:17] (03CR) 10Divadsn: "@Paladox yes, because Atom did something wrong and reverted the base in patchset 7 and 8, but in patchset 9 I reverted back to patchset 5 " [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [23:01:24] (03PS27) 10Lewis Cawte: [WIP] Initial Echo integration and replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:01:26] (03PS1) 10Lewis Cawte: [WIP] Replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325133 [23:02:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Initial Echo integration and replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:03:08] (03PS10) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [23:03:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325133 (owner: 10Lewis Cawte) [23:06:04] (03PS11) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [23:07:05] I hope that this will finish my task for this day, now I go back to my bed ^^ [23:07:39] good night, divadsn [23:07:45] Thank you very much for pointing out the difference, legoktm :) [23:08:20] did you test the extension after your changes? [23:08:45] you're welcome :) [23:08:58] Platonides, yes I did, it shows now the answers correctly :) Good night [23:09:39] 10MediaWiki-Email, 10Mail, 07Easy, 05MW-1.29-release-notes, and 2 others: Modify email footer to clarify that by responding one reveals their address - https://phabricator.wikimedia.org/T152242#2845004 (10Legoktm) 05Open>03Resolved [23:10:07] (03Abandoned) 10Gergő Tisza: Add error file/line information to exceptions caught by the API [core] - 10https://gerrit.wikimedia.org/r/317460 (owner: 10Gergő Tisza) [23:15:47] (03CR) 10Umherirrender: "I did not like unreadable characters in the source repo, it is possible that different char sets will destroy the character. In my opinion" [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [23:20:09] Why am I getting 404s when trying to download from Gerrit? [23:21:08] Lcawte hi, would you be able to report that in -operations please? [23:21:20] #wikimedia-operations, so they can see if they have the porblem too [23:22:04] works for me [23:24:32] (03CR) 10Gergő Tisza: "You could use html_entity_decode( '‎' ) or json_decode( '"\u200e"' ) or something similar." [core] - 10https://gerrit.wikimedia.org/r/323675 (https://phabricator.wikimedia.org/T144386) (owner: 10Huji) [23:27:16] (03CR) 10Platonides: [C: 04-1] Improve code readability in Quiz extension by reformatting code (035 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [23:32:03] (03PS2) 10Lewis Cawte: Replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325133 [23:33:01] (03CR) 10Divadsn: "Next patch is coming up..." (033 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [23:33:06] (03CR) 10jenkins-bot: [V: 04-1] Replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325133 (owner: 10Lewis Cawte) [23:33:50] (03PS12) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [23:35:13] (03PS13) 10Divadsn: Improve code readability in Quiz extension by reformatting code [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) [23:35:47] (03CR) 10Divadsn: "Forgot to remove one ternary operator, now this should be enough." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/325097 (https://phabricator.wikimedia.org/T150103) (owner: 10Divadsn) [23:36:37] This task should really be splitted into two or three subtasks, I mean I should only wrap the code lines, nothing more :/ [23:38:03] And regarding to the comment with Html::input(), I already created a (simillar) task on Phabricator; https://phabricator.wikimedia.org/T152293 [23:38:22] (03PS1) 10Gergő Tisza: Add integration test for MWHttpRequest user/pass options [core] - 10https://gerrit.wikimedia.org/r/325136 [23:39:52] (03CR) 10Gergő Tisza: "Added a test in I5bcb263." [core] - 10https://gerrit.wikimedia.org/r/320388 (owner: 10Chrisludt) [23:40:09] * divadsn can't go to sleep without waking up every 10 minutes and checking if there is a change on Gerrit xD [23:40:28] (03PS28) 10Lewis Cawte: Initial Echo integration, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:40:43] (03PS2) 10Umherirrender: Move count of revisions/files out of undelete log comment [core] - 10https://gerrit.wikimedia.org/r/318683 [23:41:32] (03CR) 10Umherirrender: "Patch Set 2: Rebased" [core] - 10https://gerrit.wikimedia.org/r/318683 (owner: 10Umherirrender) [23:41:35] (03CR) 10Lewis Cawte: [C: 032 V: 032] Replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325133 (owner: 10Lewis Cawte) [23:42:52] (03CR) 10jenkins-bot: [V: 04-1] Replacement of old AJAX stuff with API modules, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/325133 (owner: 10Lewis Cawte) [23:49:53] Hey, I'm new here [23:51:00] hi ayden [23:51:23] I'm participating in the google code in program [23:52:32] How are you doing Krenair? [23:54:28] (03CR) 10Jack Phoenix: Initial Echo integration, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:54:53] (03PS29) 10Lewis Cawte: Initial Echo integration, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:55:18] I'm okay. I'm doing non-wikimedia stuff right now but still checking IRC every now and again [23:55:35] have fun with GCI [23:55:47] thanks, are you familiar with it> [23:55:50] *? [23:55:51] (03CR) 10jenkins-bot: [V: 04-1] Initial Echo integration, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:55:52] 10Wikimedia-General-or-Unknown, 07JavaScript: mw.user.isAnon is not a function @ th.wikipedia - https://phabricator.wikimedia.org/T152172#2845009 (10Aklapper) @Octahedron80: Please tell us if this is still a problem. [23:56:51] no [23:57:28] (03CR) 10Lewis Cawte: [C: 032 V: 032] Initial Echo integration, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix) [23:57:47] It's a program where pre-uni students can participate in to learn about open source development [23:57:49] Hi ayden and welcome to IRC! [23:58:03] Hello andre! [23:58:24] (03CR) 10jenkins-bot: [V: 04-1] Initial Echo integration, based on ikasty's code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/278868 (https://phabricator.wikimedia.org/T64520) (owner: 10Jack Phoenix)