[00:00:04] (03CR) 10Niedzielski: [C: 031] Hygiene: Remove .travis.yml [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324341 (owner: 10Mholloway) [00:01:14] (03CR) 10Reedy: "If $wgFileStore disappeared in 1.24... I think we might aswell clean these up then!" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324352 (owner: 10Reedy) [00:01:36] (03CR) 10Gergő Tisza: refreshLinks.php: allow refreshing by categories, tracking or not (033 comments) [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) (owner: 10MaxSem) [00:02:06] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: After login, user not logged in when "prefershttps" set to false and "wgSecureLogin" set to true - https://phabricator.wikimedia.org/T149977#2833670 (10fgiunchedi) [00:02:24] (03CR) 10Mholloway: "recheck" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324005 (owner: 10Mholloway) [00:02:42] (03PS4) 10Reedy: Replace FSRepo with FileRepo [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324352 [00:02:44] (03CR) 10Paladox: Replace FSRepo with FileRepo (032 comments) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324352 (owner: 10Reedy) [00:03:09] (03CR) 10Paladox: "Ignore my comment I just saw you add the function, but the config comment remains." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324352 (owner: 10Reedy) [00:04:17] (03CR) 10Reedy: [C: 04-1] "2 extensions make use of this, those patches should be merged first before this can be removed" [core] - 10https://gerrit.wikimedia.org/r/324350 (owner: 10Reedy) [00:04:47] legoktm: There. something more worthwhile :P [00:05:07] (03Merged) 10jenkins-bot: Make protect.php maintenance script not ignore --user and --reason parameters [core] - 10https://gerrit.wikimedia.org/r/324179 (https://phabricator.wikimedia.org/T89713) (owner: 10Filip) [00:05:14] (03CR) 10Krinkle: [C: 032] Replace FSRepo with FileRepo [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/324348 (owner: 10Reedy) [00:05:52] xD [00:06:47] 10MediaWiki-extensions-Newsletter: Creating a newsletter in the latest mediawiki-core master fails with a fatal - https://phabricator.wikimedia.org/T151967#2833672 (1001tonythomas) [00:06:50] (03CR) 10Mholloway: "I was just in a middle of writing a patch to fix this flaky test. I'll rebase over it." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324005 (owner: 10Mholloway) [00:06:51] legoktm: if you are around -- https://phabricator.wikimedia.org/T151967 [00:07:00] (03Merged) 10jenkins-bot: Replace FSRepo with FileRepo [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/324348 (owner: 10Reedy) [00:07:12] something to do with contenthandler. Dont know why that is happening all of a sudden :-( [00:07:13] (03CR) 10MaxSem: refreshLinks.php: allow refreshing by categories, tracking or not (036 comments) [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) (owner: 10MaxSem) [00:07:33] (03PS1) 10Reedy: Remove $wgSessionsInMemcached [core] - 10https://gerrit.wikimedia.org/r/324353 [00:08:40] (03CR) 10Jdlrobson: [C: 031] "Thiemo Mättig (WMDE) I took a look at this code and I don't think it's reasonable to expect a new developer to be able to write a unit tes" [core] - 10https://gerrit.wikimedia.org/r/320612 (https://phabricator.wikimedia.org/T114883) (owner: 10Harjotsingh) [00:09:14] (03PS1) 10Mholloway: Fix flaky most-read spec test [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324354 [00:09:37] tonythomas: Parental consent approved. I'll fix some Newsletter stuff. Sticking around? [00:09:56] (03PS1) 10MtDu: Replace Linker::link() usage with LinkRenderer in the following special pages: - SpecialAllPages - SpecialAncientpage - SpecialBlock - SpecialBrokenRedirects - SpecialDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) [00:10:06] MtDu: its kinda dark here (1:00 am), but I would be here for around 15 more mins [00:10:19] tonythomas: Ok. I'll fix the redirect bugs I found [00:10:40] MtDu update your mediawiki-core to master and see if the extension still works :-( [00:11:11] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2833690 (10Piramidion) > Unless, of course, you're ok with removing Russian ones completely, in that case the probl... [00:11:23] tonythomas: It still works. [00:11:24] (03PS1) 10Reedy: Replace Job::batchInsert() call with JobQueueGroup::singleton()->push() [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/324356 [00:11:38] tonythomas: I have the most reent core. [00:11:49] MtDu: core = latest from master, and extension = latest from master, update database done ? [00:11:55] and a composer upate too (:D) [00:12:13] (03CR) 10Krinkle: [C: 031] Remove $wgSessionsInMemcached [core] - 10https://gerrit.wikimedia.org/r/324353 (owner: 10Reedy) [00:12:19] 10MediaWiki-General-or-Unknown, 10MediaWiki-Recent-changes, 05Security: Separate bot right for normal pages and interface (MediaWiki:) pages - https://phabricator.wikimedia.org/T151408#2833691 (10Tgr) >>! In T151408#2832640, @Krinkle wrote: > If a bot is granted rights like `editinterface`, `edituserjs`, `ed... [00:12:28] (03PS8) 10Mholloway: Fix eslint errors [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324005 [00:12:30] (03PS1) 10Jforrester: Update OOjs UI to v0.18.1 [core] - 10https://gerrit.wikimedia.org/r/324357 [00:12:44] and try creating a newsletter via Special:CreateNewsletter [00:12:54] MtDu: I hit across https://phabricator.wikimedia.org/T151967 :-( [00:13:01] (03PS1) 10Reedy: Remove Job::batchInsert() back compat [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/324358 [00:13:52] (03CR) 10Krinkle: "Still not tests for this repo? not even lint?" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/324356 (owner: 10Reedy) [00:14:25] Krinkle: They're running :P [00:14:28] Seems it's taking a while [00:14:47] Reedy: Hm.. wasnt' there in october (last commit) [00:14:48] but okay [00:14:50] ay [00:14:51] Yay [00:14:58] (03CR) 10Krinkle: [C: 032] Replace Job::batchInsert() call with JobQueueGroup::singleton()->push() [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/324356 (owner: 10Reedy) [00:15:18] I was scared too when you said it :P [00:15:35] (03PS1) 10Jforrester: Update OOjs UI to v0.18.1 [vendor] - 10https://gerrit.wikimedia.org/r/324359 [00:15:46] tonythomas: Testing now. [00:16:05] (03CR) 10Krinkle: [C: 032] Remove Job::batchInsert() back compat [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/324358 (owner: 10Reedy) [00:16:23] (03PS2) 10Mholloway: Hygiene: Remove .travis.yml [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324341 [00:17:18] (03CR) 10jenkins-bot: [V: 04-1] Replace Linker::link() usage with LinkRenderer in the following special pages: - SpecialAllPages - SpecialAncientpage - SpecialBlock - SpecialBrokenRedirects - SpecialDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [00:17:57] hey im here for google code in [00:18:02] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.18.1 [core] - 10https://gerrit.wikimedia.org/r/324357 (owner: 10Jforrester) [00:18:03] 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2833695 (10Reedy) [00:18:34] codeincs: Hello! Welcome. :) [00:18:59] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833511 (10DStrine) I cannot reproduce on regular chrome, firefox or safari. [00:19:11] 10MediaWiki-General-or-Unknown, 10MediaWiki-Recent-changes, 05Security: Separate bot right for normal pages and interface (MediaWiki:) pages - https://phabricator.wikimedia.org/T151408#2833709 (10Anomie) >>! In T151408#2833691, @Tgr wrote: > Right now the bot right is bundled in the high-volume grant, but we... [00:19:25] 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2833695 (10MaxSem) Nuke the code, leave GONE_TO_GITHUB.txt with instructions? [00:20:29] tonythomas: After I clone into the most recent, I have to run the update.php? [00:20:36] And just composer update for compsoer? [00:20:40] MtDu: yeah. [00:20:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove .travis.yml [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324341 (owner: 10Mholloway) [00:21:00] (03PS1) 10MtDu: Change Return-To URL in Special:Newsletter/xx/announce to 'Return to Newsletter:Foo' instead of 'Return to Special:Newsletter/1' - Part of migration to ContentHandler [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324361 (https://phabricator.wikimedia.org/T150096) [00:21:12] tonythomas: I went ahead and fixed the announce returnto. :) [00:21:26] MtDu: nice. are things working, btw ? [00:21:40] going into ssh atm [00:21:44] (03PS3) 10Mholloway: Hygiene: Remove .travis.yml [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324341 [00:21:57] (03PS6) 10Mholloway: Add basic 2FA support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322366 (https://phabricator.wikimedia.org/T150900) [00:23:00] tonythomas: Updating composer. One moment. [00:23:43] tonythomas: Do I need to do anything for DB update? [00:24:03] I just ran mwscript update.php and composer update and everything seems to be working. Let me try creating anew newsletter [00:24:08] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833718 (10DStrine) p:05High>03Normal [00:24:18] MtDu: alright! [00:24:24] (03CR) 10Jdlrobson: "Copying from IRC:" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [00:24:38] tonythomas: Can you review that patch really fast? I just claimed it. :) [00:24:56] (03Merged) 10jenkins-bot: Replace Job::batchInsert() call with JobQueueGroup::singleton()->push() [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/324356 (owner: 10Reedy) [00:24:58] (03Merged) 10jenkins-bot: Remove Job::batchInsert() back compat [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/324358 (owner: 10Reedy) [00:25:09] tonythomas: Also, are my previous newsletters supposed to be there? [00:25:43] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 07Verified, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): In Gallery, the order of images in search result section changes randomly while trying to re-edit it - https://phabricator.wikimedia.org/T151659#2833720 (10Ryasmeen) [00:26:32] 06Research-and-Data: Request access to data/cluster for article expansion research - https://phabricator.wikimedia.org/T151969#2833724 (10leila) [00:26:54] 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2833738 (10Reedy) >>! In T151968#2833710, @MaxSem wrote: > Nuke the code, leave GONE_TO_GITHUB.txt with instructions... [00:27:36] (03PS1) 10Reedy: Replace job->insert() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/324363 [00:27:37] 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2833739 (10MaxSem) Get rid of everything semantic in production? [00:29:00] tonythomas: I think I ran into a bug. [00:29:06] Not sure if it's what we're looking for though. [00:29:11] (03PS1) 10Reedy: Replace $job->insert() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/324364 [00:29:42] Reedy: Any other deprecated things that you could let me do? ;) [00:29:49] MtDu: There's load [00:29:52] Go look for some :P [00:30:03] Reedy: Did you just create some? [00:30:10] (03CR) 10jenkins-bot: [V: 04-1] Replace $job->insert() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/324364 (owner: 10Reedy) [00:30:12] Some tasks? Nah [00:30:37] Reedy, How do I look for any, just look for @deprecated? [00:31:26] (03PS2) 10Reedy: Replace $job->insert() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/324364 [00:32:02] (03CR) 1001tonythomas: [C: 04-1] en.json: display newsletter title on confimation page (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324257 (https://phabricator.wikimedia.org/T149645) (owner: 10Phantom42) [00:32:22] tonythomas: Let me send you a link to the screenshot. [00:32:33] It's when I create a newsletter and add the description. [00:32:33] MtDu: okey. I am half sleepy zzz [00:32:58] (03CR) 10jenkins-bot: [V: 04-1] Replace job->insert() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/324363 (owner: 10Reedy) [00:33:20] 10TPG-FY2016-17-Q2-LE-Metrics, 06Team-Practices (This-Week): Clarify guidelines for when to use LE Survey - https://phabricator.wikimedia.org/T150469#2833741 (10JAufrecht) Looks good. I added some example survey questions that JMo reviewed. [00:33:53] (03CR) 10Gergő Tisza: refreshLinks.php: allow refreshing by categories, tracking or not (034 comments) [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) (owner: 10MaxSem) [00:33:54] tonythomas: https://postimg.org/image/9cautf53n/ [00:34:26] tonythomas: Also, did you see the return to link patch I fixed? [00:34:26] (03CR) 1001tonythomas: [C: 032] "Works. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324361 (https://phabricator.wikimedia.org/T150096) (owner: 10MtDu) [00:34:37] tonythomas: Nvm. Can I submit on GCI? [00:34:53] (03PS2) 10Reedy: Replace job->insert() calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/324363 [00:34:55] MtDu: that one seem different. You can maybe file a separate patch. [00:35:21] tonythomas: What do you mean? For the screenshot? [00:35:29] MtDu: yup! [00:35:37] (03Merged) 10jenkins-bot: Change Return-To URL in Special:Newsletter/xx/announce to 'Return to Newsletter:Foo' instead of 'Return to Special:Newsletter/1' - Part of migration to ContentHandler [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324361 (https://phabricator.wikimedia.org/T150096) (owner: 10MtDu) [00:36:01] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Page Forms and Cargo - https://phabricator.wikimedia.org/T149612#2833761 (10Tgr) I'm not trying to shut down the discussion, and sure, it would be nice to have a showcase of those extensions, but IMO there is no decision paralysis at al... [00:36:20] tonythomas: I submitted on GCI. Do you think this is a bug or just a glitch of sorts? [00:36:29] tonythomas: Is newsletter still not working for you? [00:36:53] MtDu: I can create it using the action=edit way, so I could test it! [00:37:06] I am trying to close the thing in GCI, but its not working :-( [00:37:11] tonythomas: :( [00:37:26] tonythomas: Also, for the bug, could you reproduce it? [00:38:16] (03PS1) 10Reedy: Removed Xml::escapeJsString() [core] - 10https://gerrit.wikimedia.org/r/324365 [00:38:26] MtDu: approved. [00:38:33] MtDu: I couldnt, but it might be a bug. [00:38:40] definetly sleepy. Good nigt/day. [00:38:51] tonythomas: Ok. Good night. [00:38:57] (03CR) 10MaxSem: refreshLinks.php: allow refreshing by categories, tracking or not (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) (owner: 10MaxSem) [00:39:16] (03CR) 10Legoktm: [C: 04-1] "Looks good, one issue inline" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [00:39:22] btw, I approved your task on GCI - hope you can hunt down more tonight! [00:39:24] tonythomas: Do you want me to go ahead and fix the other two return tos? [00:39:30] MtDu: yeah! [00:39:37] MtDu: did you claim the linkrenderer task on GCI? [00:39:42] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [00:39:46] * tonythomas quits [00:39:48] legoktm: Not yet. :) WIll do that soon [00:39:53] ok [00:40:00] legoktm: I can do now if you want. [00:40:06] yes please [00:40:09] It's the core one? [00:40:36] yep [00:40:43] Claimed. [00:41:00] (03PS1) 10Reedy: Replace User::edits() call [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/324366 [00:41:04] legoktm: Oops is right haha. :p [00:41:13] Thought I double checked them too. [00:41:31] What a 8 hour school day will do to you haha, legoktm. [00:42:00] (03PS1) 10Reedy: User::edits() was removed [core] - 10https://gerrit.wikimedia.org/r/324367 [00:43:12] legoktm, Do you know what this error is? I'm trying to download the patch https://dpaste.de/XfLo [00:43:38] --download? [00:43:44] Yeah. [00:43:51] meh, same thing [00:43:51] uh for some reason it is missing the /r/ in the URL [00:43:51] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2824008 (10EBernhardson) >>! In T151660#2833690, @Piramidion wrote: >> Unless, of course, you're ok with removing R... [00:44:03] git review -d is less to type ;) [00:44:17] MtDu: git fetch https://gerrit.wikimedia.org/r/mediawiki/core refs/changes/55/324355/1 && git checkout FETCH_HEAD [00:44:25] (via the download menu in the top right) [00:44:29] legoktm: I guess I should carry on with the blitz against CH stuff :/ [00:44:38] loads of 1.21 function usages left [00:44:43] :( [00:44:53] In lots of stupid extensions no one cares about [00:44:54] Reedy: If you have a lot, just let me know the extension. :) [00:45:00] Reedy: GCI tasks! [00:45:08] Yeah, true [00:45:11] Reedy: That works too. :) [00:45:14] We must have a phab task about it [00:45:18] (03CR) 10Legoktm: [C: 032] Replace User::edits() call [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/324366 (owner: 10Reedy) [00:45:22] I can create it if you want. [00:45:30] I'm 99% sure we have one [00:45:31] Actually, you probably should. :) [00:45:41] Anyways, trying it now, legoktm. [00:45:45] I'm sure you/we were fixing this a year ago [00:46:05] ffs, 1 minute left of laptop battery life [00:46:10] Reedy: Haha probs. I remember wfMsg and User::sentmail [00:46:18] (03Merged) 10jenkins-bot: Replace User::edits() call [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/324366 (owner: 10Reedy) [00:46:22] (03CR) 10Legoktm: [C: 032] Remove $wgSessionsInMemcached [core] - 10https://gerrit.wikimedia.org/r/324353 (owner: 10Reedy) [00:46:24] I'll have a look for the task [00:46:33] (03CR) 10Legoktm: [C: 032] Replace $job->insert() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/324364 (owner: 10Reedy) [00:47:03] (03CR) 10Legoktm: [C: 04-1] "Unrelated change slipped in?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324367 (owner: 10Reedy) [00:47:07] (03CR) 10Unicornisaurous: [C: 04-1] "Just a minor style issue." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/323896 (https://phabricator.wikimedia.org/T122280) (owner: 10Georggi199) [00:49:27] (03PS2) 10Reedy: User::edits() was removed [core] - 10https://gerrit.wikimedia.org/r/324367 [00:49:39] (03CR) 10Reedy: "Absolutely no idea where that change came from" [core] - 10https://gerrit.wikimedia.org/r/324367 (owner: 10Reedy) [00:50:54] MtDu: https://phabricator.wikimedia.org/T145728 is the task [00:51:11] Hey there I'm Nicholas, calling in from Google CodeIn B) [00:51:19] NicholasBates: Hello! Welcome. :) [00:51:25] I wonder if I should create a seperate subtask for GCI for that one... [00:51:51] (03CR) 10Legoktm: [C: 04-1] Replace job->insert() calls (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/324363 (owner: 10Reedy) [00:52:09] im from google codein to [00:52:10] o [00:52:18] hi codeincs [00:52:42] codeincs: Hello! Welcome. :) [00:53:13] 10MediaWiki-Vagrant, 13Patch-For-Review, 15User-bd808: Vagrant 1.9.0 unable to install local mediawiki-vagrant plugin - https://phabricator.wikimedia.org/T151928#2833782 (10bd808) a:03bd808 [00:54:19] 10MediaWiki-ContentHandler, 05MW-1.28-release-notes, 13Patch-For-Review, 07Technical-Debt: Clean up ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T145728#2833784 (10Reedy) [00:54:28] 10MediaWiki-ContentHandler, 05MW-1.28-release-notes, 07Technical-Debt: Clean up ContentHandler deprecated functions and hooks - https://phabricator.wikimedia.org/T145728#2652588 (10Reedy) [00:55:18] (03Merged) 10jenkins-bot: Remove $wgSessionsInMemcached [core] - 10https://gerrit.wikimedia.org/r/324353 (owner: 10Reedy) [00:55:22] (03Merged) 10jenkins-bot: Replace $job->insert() call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/324364 (owner: 10Reedy) [00:56:36] legoktm: I get this when trying to git review httpsL//dpaste.de/hRYC [00:56:46] Reedy, if you can take a look. :) ^ [00:57:00] https://dpaste.de/hRYC you mean [00:57:06] MtDu: what version of git review are you using? [00:57:27] legoktm: 2.10.1 [00:57:38] legoktm: I pushed a patch like 15 minutes ago. Don't know what happened. [00:58:01] errr [00:58:06] run $ git-review --version [00:58:10] I think that's your git version [00:58:15] 1.25.0 [00:58:26] Yeah you're right. [00:58:27] okay that's fine [00:58:40] oh right [00:58:48] are you checked out to a branch? [00:58:56] 10MediaWiki-ResourceLoader, 06Front-end-Standards-Group: CssJanus should not convert urls for filters - https://phabricator.wikimedia.org/T151972#2833787 (10Jdlrobson) [00:58:58] or detached head still? [00:59:14] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2833799 (10Reedy) [00:59:25] (03CR) 10Gergő Tisza: refreshLinks.php: allow refreshing by categories, tracking or not (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) (owner: 10MaxSem) [00:59:28] How do we tag stuff for GCI? [00:59:40] I think you add a project. [00:59:42] add the GCI project and then we can import it into their website [00:59:55] The calendar one? [01:00:00] 10MediaWiki-Configuration, 06Operations, 06Performance-Team, 06Services (watching), and 5 others: Integrating MediaWiki (and other services) with dynamic configuration - https://phabricator.wikimedia.org/T149617#2833815 (10Krinkle) >>! In T149617#2832982, @aaron wrote: > The background process would write... [01:00:05] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2833816 (10Reedy) [01:00:14] Yup, looks like it [01:00:24] MINIONS: GO FORTH AND WORK [01:00:30] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2833817 (10Smalyshev) These are Ukrainian titles, not Russian: Блокування Блокування_IP-адресу Права_груп_користу... [01:01:18] MtDu: If you are able, I'd recommend using mediawiki-vagrant (we even have a GCI task for "setting up your development environment"). I've never had a problem with git or git review when using vagrant. Make sure you are checked out on a branch too. [01:01:20] legoktm: I am on master [01:01:41] unicornisaurous: I am using vagrant as a test environment. [01:02:05] Hm. Well, there's a first for everything. :) [01:02:05] (03CR) 10BryanDavis: Add Vagrant role for Wikibase Repo (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/323841 (https://phabricator.wikimedia.org/T151845) (owner: 10Tobias Gritschacher) [01:02:22] 10MediaWiki-extensions-General-or-Unknown, 07Technical-Debt: Removing deprecated code from Semantic* extensions where gerrit is not the canonical repo - https://phabricator.wikimedia.org/T151968#2833826 (10Reedy) >>! In T151968#2833739, @MaxSem wrote: > Get rid of everything semantic in production? That's T53642 [01:02:24] Is there any reason you can't submit code from inside vagrant? MtDu [01:02:39] (03CR) 10BryanDavis: [C: 032] Properly add stil/gd-text for ZeroBanner [vendor] - 10https://gerrit.wikimedia.org/r/319765 (owner: 10Reedy) [01:03:13] (03CR) 10BryanDavis: [C: 032] Move stil/gd-text to vendor repo properly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/319766 (owner: 10Reedy) [01:04:45] unicornisaurous: I have no idea. I just submitted some patches inside vagrant like 20 minutes ago. [01:05:09] unicornisaurous: But I had to reset HEAD and then git pull because of some differences. [01:05:17] Maybe I did it wrong and an issue arose.. [01:06:30] MtDu I only mentioned it because I noticed your command prompt said mac not vagrant@mediawiki-vagrant [01:06:39] (03PS4) 10Jdlrobson: Overhaul navigation drawer to better focus on navigation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [01:06:41] (03PS1) 10Jdlrobson: Hovering over links in menu should change icons to blue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) [01:06:46] (03CR) 10Legoktm: [C: 032] User::edits() was removed [core] - 10https://gerrit.wikimedia.org/r/324367 (owner: 10Reedy) [01:06:48] MtDu: git symbolic-ref -q HEAD failing means that you don't have an upstream branch [01:06:59] or "detached head" [01:07:31] (03CR) 10Jdlrobson: [C: 031] Overhaul navigation drawer to better focus on navigation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [01:08:02] you can probably fix this with `git rebase origin/master` to place your current work on top of the master branch of the origin repo [01:08:30] (03PS2) 10Haikalizz: GCI16: core: Use LinkRenderer instead of Linker:link() [core] - 10https://gerrit.wikimedia.org/r/324221 [01:08:40] (03CR) 10jenkins-bot: [V: 04-1] GCI16: core: Use LinkRenderer instead of Linker:link() [core] - 10https://gerrit.wikimedia.org/r/324221 (owner: 10Haikalizz) [01:09:53] is it okay to check code against the master of mediawiki-codesniffer? Everything seems to just use 0.7.2 for some reason [01:09:55] (03Abandoned) 10Jdlrobson: Improve documentation/parameter names of openPopup method [extensions/Popups] - 10https://gerrit.wikimedia.org/r/312431 (owner: 10Jdlrobson) [01:10:10] unicornisaurous: Hm. I thought that shows only in ssh. [01:10:25] samwilson: look at the differences? :P [01:11:10] samwilson: https://github.com/wikimedia/mediawiki-tools-codesniffer/compare/v0.7.2...master [01:11:23] Reedy: I am, and there's lots more errors, because there's lots more tests! :) [01:11:32] legoktm: Are we due a proper 0.8.0 release? :) [01:11:33] (03CR) 10MtDu: GCI16: core: Use LinkRenderer instead of Linker:link() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324221 (owner: 10Haikalizz) [01:11:59] what about a proper *stable* release? i.e. 1.0.0? [01:12:19] Does < 1 really mean it's not stable? :) [01:12:24] (03Merged) 10jenkins-bot: Properly add stil/gd-text for ZeroBanner [vendor] - 10https://gerrit.wikimedia.org/r/319765 (owner: 10Reedy) [01:12:31] http://semver.org/ [01:12:37] Reedy: yep, in semver world it does [01:12:47] "If your software is being used in production, it should probably already be 1.0.0." [01:13:00] hehe yeah :) [01:13:03] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Organize/ prepare content for an informational google hangout session for new Google Code-In mentors on Thu 2016-12-01 17:00UTC - https://phabricator.wikimedia.org/T150636#2833837 (10srishakatux) Invite sent for info session via Google Calendar to al... [01:13:05] samwilson: Should a dev tool be classed as being in production? [01:13:09] Feels like trolling asking that [01:13:29] (03Merged) 10jenkins-bot: Move stil/gd-text to vendor repo properly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/319766 (owner: 10Reedy) [01:13:31] ooh, yeah, that's deep philosophical stuff... [01:13:31] (03CR) 10jenkins-bot: [V: 04-1] User::edits() was removed [core] - 10https://gerrit.wikimedia.org/r/324367 (owner: 10Reedy) [01:13:49] (03CR) 10Gergő Tisza: "You could include the value of $wgPageImagesLeadSectionOnly in the page_props key name, and write a maintenance script to delete props ent" (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [01:13:55] and nothing that's on labs is in production then, either? ;) [01:13:55] Certainly does look like we're overdue a release though, yeah [01:14:00] and BUMP ALL THE THINGS [01:14:02] Reedy: we are definitely due, but iirc there were still some bugs [01:14:09] legoktm: I am disappoint, son. [01:14:11] What are they? [01:14:26] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Bringing "Enterprise MediaWiki" to the Wikimedia Foundation - https://phabricator.wikimedia.org/T149612#2833842 (10Yaron_Koren) [01:14:27] Maybe samwilson can fix them ;) [01:14:27] samwilson: don't use master, because it we add a new rule to the set, your repo will randomly start railing [01:14:35] samwilson: you can use the0.8.0 alpha tag though [01:14:35] (03CR) 10TTO: GCI16: core: Use LinkRenderer instead of Linker:link() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324221 (owner: 10Haikalizz) [01:15:02] legoktm: good point. I'm thinking of just testing locally against master, but still only having 0.7.2 in composer.json [01:15:19] to start cleaning things up with a view to the future [01:15:22] (03PS20) 10Jdlrobson: mediawiki.util: Port to requires module [core] - 10https://gerrit.wikimedia.org/r/260883 (https://phabricator.wikimedia.org/T140384) [01:15:35] https://phabricator.wikimedia.org/project/view/1087/ [01:15:49] (03CR) 10Jdlrobson: "Fyi MobileFrontend is not using modules.exports in a nonstandard way. We decided to wait until file support was added." [core] - 10https://gerrit.wikimedia.org/r/260883 (https://phabricator.wikimedia.org/T140384) (owner: 10Jdlrobson) [01:16:11] https://phabricator.wikimedia.org/T146439 needs fixing [01:16:20] and https://phabricator.wikimedia.org/T146388 [01:16:25] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/tools/codesniffer+status:open [01:16:54] samwilson: ^ go nuts ;D [01:17:13] Reedy: :) sounds like fun [01:18:09] what's the 'pass codesniffer' project column for? [01:19:24] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Wrong Return-To URL in Special:Newsletter/xx/announce - https://phabricator.wikimedia.org/T150096#2833861 (10MtDu) 05Open>03Resolved a:03MtDu [01:19:45] "Make foobar extension pass codesniffer" type tasks [01:20:12] (03PS3) 10Haikalizz: GCI16: core: Use LinkRenderer instead of Linker:link() [core] - 10https://gerrit.wikimedia.org/r/324221 [01:20:23] (03CR) 10jenkins-bot: [V: 04-1] GCI16: core: Use LinkRenderer instead of Linker:link() [core] - 10https://gerrit.wikimedia.org/r/324221 (owner: 10Haikalizz) [01:20:33] (03CR) 10Jdlrobson: "> You could include the value of $wgPageImagesLeadSectionOnly in the page_props key name, and write a maintenance script to delete props e" (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [01:20:42] (03CR) 10Haikalizz: "> (1 comment)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324221 (owner: 10Haikalizz) [01:21:08] (03CR) 10Catrope: [C: 04-1] goodfaith filter (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) (owner: 10Sbisson) [01:21:28] legoktm: https://dpaste.de/AJOO Does that look right? [01:21:51] well that means your patch isn't on master [01:22:13] Before this, I had done a git reset HEAD~2 --hard and then a git pull. [01:22:31] (03CR) 10Catrope: [C: 032] Rename language codes sr-ec and sr-el to sr-cyrl and sr-latn [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/323684 (https://phabricator.wikimedia.org/T117845) (owner: 10Fomafix) [01:23:18] legoktm, So do I need to run that git fetch command now? [01:24:01] halfak, so, for the scoring system I put local_celery to activate the celery queue. Then checking `celery worker` and found it complaning about Received unregistered task of type 'ores.scoring_systems.celery_queue._process_score_map'. [01:24:25] git review --download still gives me that error. (Where the /r isn't in the URL) [01:24:25] 10Phabricator, 07Availability, 13Patch-For-Review, 07WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#2833863 (10Dzahn) I re-enabled puppet on phab2001 today, i checked that it got the right secondary IP on the interface now (see subtask abou... [01:25:19] (03CR) 10Samwilson: [C: 031] "All works well for me." [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/322489 (owner: 10Kaldari) [01:25:34] samwilson: Thanks! [01:26:22] kaldari: no worries :) I updated the mw.org doco too a bit [01:26:41] 10Phabricator, 07Availability, 13Patch-For-Review, 07WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#2833878 (10Dzahn) @volans puppet runs again on phab2001, it got a bunch of pending upgrades, it also started reporting in icinga again. (tho... [01:27:06] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Bringing "Enterprise MediaWiki" to the Wikimedia Foundation - https://phabricator.wikimedia.org/T149612#2833879 (10Yaron_Koren) @cscott - alright, cool; I just changed the title back. I think this is the better title because (a) I think... [01:27:26] Hi, I came here from GCI and wanted to look around [01:27:33] 10Phabricator, 07Availability, 13Patch-For-Review, 07WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#2833880 (10Dzahn) [01:27:39] TehTotalPwnage: Hello! Welcome. :) [01:28:23] Thanks, looking forward to learning more about WikiMedia and maybe contributing to it :) [01:29:36] TehTotalPwnage: Awesome. You'll learn a lot. Here's a generic tutorial for GCI students for Wikimedia. https://www.mediawiki.org/wiki/Google_Code-in_2016#Instructions_for_GCI_students Ask if you have any questions. :) [01:29:47] general* [01:30:50] Cool, thanks again [01:30:52] Reedy, how can I tell which patchset/change I'm on? I just reset HEAD and pulled up to date and now I want to edit my patch, but I get this error. https://dpaste.de/YOQF [01:32:14] legoktm, is git review --download not supported anymore? If so, then we need to update the docs. [01:32:17] (03CR) 10Gergő Tisza: "I don't think the API ever triggers parsing. (It doesn't have any way to do it: no props can just mean the page had no suitable images. Pl" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [01:32:23] no it is [01:32:36] I'm just not sure why it's not working for you [01:32:56] broken git-review? [01:33:01] legoktm, Ok. I did a git fetch for my patch. I'm in detached head state [01:33:05] (03PS5) 10Kaldari: Adding API for retrieving list of all WikiProjects on a wiki [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/322489 [01:33:10] git checkout -b whatever [01:33:11] Some distros ship old gitreview versions [01:33:17] hoo: checked that already :/ [01:33:23] Reedy, I'm not sure. I'm able to push patches, but I can't download them... :p [01:33:46] legoktm, how do I remove a branch? [01:33:55] git branch -D name [01:36:52] legoktm, thanks. Is there a way to locally compare differences between two patchsets using git? [01:37:33] MtDu, MtDu_: I suppose you've claimed T124005 for GCI? [01:37:34] T124005: Create tests for fake user agent - https://phabricator.wikimedia.org/T124005 [01:38:05] dargasia: Oh, no. I actually removed myself from the task in light of GCI. Feel free to claim it. :) [01:38:20] dargasia: I'm Justin by the way. Nice to meet you. [01:39:00] Lovely metting you MtDu :) . [01:39:04] meeting *. [01:39:39] (03PS2) 10MtDu: Replace Linker::link() usage with LinkRenderer in the following special pages: - SpecialAllPages - SpecialAncientpage - SpecialBlock - SpecialBrokenRedirects - SpecialDoubleRedirects [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) [01:39:48] legoktm, there it goes. :) [01:40:03] woot [01:40:14] MtDu: FYI, if you're fixing little issues, sometimes it's easier to just do it via the gerrit web interface [01:40:35] Reedy, Yeah, via the publish edit? [01:40:39] yeah, exactly [01:40:47] Reedy, had to do that for the @since ha. ;) [01:40:48] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2833883 (10kaldari) [01:41:44] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 03Community-Tech-Sprint: Update PageTriage speedy deletion tag list to match Twinkle's - https://phabricator.wikimedia.org/T150628#2791502 (10kaldari) @Kudpung, @TTO: I've restored the entire list on this ticket per Kudpung. Feel free to discu... [01:43:22] Reedy, when was that feature added? I've only been noticing it recently. [01:43:28] hi :) [01:43:36] (03CR) 10MaxSem: [C: 04-1] Restrict page images to lead section (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [01:43:39] It's been a little while, not sure exactly [01:44:21] defund: Hello! Is it your first time here? Welcome. :) [01:44:28] 10MediaWiki-Codesniffer: Should we require documentation for constructors? - https://phabricator.wikimedia.org/T146388#2659448 (10Samwilson) You can just document the constructor parameters, and it'll pass. I think it's worth documenting parameters for every method, including constructors. But no need, as you s... [01:44:30] yeah, I saw this task on google code in [01:44:32] lol [01:44:56] defund, Well, it's nice to have you. [01:45:42] well, I go on irc normally [01:45:46] so like why not [01:46:04] (03CR) 10Samwilson: [C: 031] Adding API for retrieving list of all WikiProjects on a wiki [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/322489 (owner: 10Kaldari) [01:50:27] Hey dargasia [01:50:41] Can you give me the full errors. I'm not sure what you are talking about :S [01:51:13] (03CR) 10Krinkle: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/260883 (https://phabricator.wikimedia.org/T140384) (owner: 10Jdlrobson) [01:51:27] MatmaRex: https://gerrit.wikimedia.org/r/#/c/323240/ [01:52:02] halfak, yep, this is from celery https://paste.kde.org/pdowtz2ne [01:52:14] after modifying this line in config: [01:52:16] scoring_system: local_celery [01:53:34] "celery worker" ? [01:53:38] What command are you running? [01:54:10] Oh! [01:54:12] I see. [01:54:21] run "./utility applications.celery" [01:54:47] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.api: Fix getToken() incompat with jQuery 3.0 [core] - 10https://gerrit.wikimedia.org/r/323240 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [01:55:10] oh this makes much more sense! so you acutally don't want me to run my own worker from command line. [01:56:08] legoktm, Reedy: I'm going to head out for today. Thanks for helping. :) [01:56:37] 10Tools-Global-user-contributions: Limit list to contributions made within a stated date range - https://phabricator.wikimedia.org/T139702#2833918 (10Krinkle) 05Resolved>03declined [01:57:08] legoktm, When you get a chance, take a look at the patch. :) [01:57:49] Oh I do. That command will start up the worker process [01:57:54] dargasia, ^ [01:58:51] yeah, halfak :) just didn't realize today that the functions will not be registered unless I run them with ./utility [01:59:22] 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2833921 (10DarTar) [02:00:03] 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2723524 (10DarTar) [02:00:08] So, when you run the uwsgi service (what starts with `dev_server` you are running a client for celery. [02:00:36] When you run the celery service `applications.celery`, you're running the server for celery [02:00:50] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Bringing "Enterprise MediaWiki" to the Wikimedia Foundation - https://phabricator.wikimedia.org/T149612#2833923 (10Yaron_Koren) @Tgr - alright. For mediawiki.org infobox data, I do think Page Forms and Cargo is the much better solution... [02:00:58] It turns out that "dev_server" is on its way to being deprecated. [02:01:13] 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2723524 (10DarTar) [02:01:19] In the future (and currently) you'll want to run "applications.wsgi" for the wsgi celery client [02:01:34] wsgi is responsible for responding to http [02:01:46] celery is responsible for doing the actual scoring :) [02:02:38] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2833926 (10Krinkle) @cicalese If you are passing `ext.C... [02:02:40] Ah, understood. [02:02:50] halfak, got something slightly more interesting: https://paste.kde.org/pksyiu6l8/e0haj1 [02:03:03] That's expected. :) [02:03:12] (03PS2) 10Sleepinglion: new file: RelatedLinks.alias.php new file: RelatedLinks.hooks.php new file: RelatedLinks.php new file: SpecialRelatedLinks.php new file: ext.related_links.css new file: ext.related_links.js new file: extension.json new file: i18n/e [extensions/RelatedLinks] - 10https://gerrit.wikimedia.org/r/324036 [02:03:16] (03Merged) 10jenkins-bot: mediawiki.api: Fix getToken() incompat with jQuery 3.0 [core] - 10https://gerrit.wikimedia.org/r/323240 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [02:03:34] It turns out that celery doesn't solve some of the types of dependencies we need to solve with tasks, so we had to do something that is hazardous. [02:04:02] Oh wait! That's a new version of celery and it's actually throwing and error. [02:04:24] Yup, ORES's ui gives me a "We're sorry" now. [02:04:35] "celery >= 3.1.22, < 3.1.999" [02:04:41] That's our requirement for celery [02:04:52] We need to make some fixes to celery upstream before we can upgrade. [02:06:34] 10MediaWiki-ResourceLoader, 07Browser-Support-Google-Chrome: Flaky loading Userscripts with Google Chrome - https://phabricator.wikimedia.org/T149449#2833933 (10Krinkle) p:05Triage>03Normal [02:06:50] halfak, my celery seems to meet this requirement [02:06:57] >>> celery.__version__ (\n) 3.1.25 [02:07:34] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2833935 (10fgiunchedi) p:05Triage>03Normal `/tmp` keeps getting full with temporary directories that are never cleaned up. Interestingly all files in there are either one byte or 4194304 bytes so some... [02:09:10] I don't get that error with 3.1.25 [02:09:19] The blocking problem is only supposed to be there in 3.2 [02:10:17] 10MediaWiki-ResourceLoader: Allow modularization of site stylesheets (MediaWiki:Common.css etc.) - https://phabricator.wikimedia.org/T146733#2669644 (10Krinkle) We may not need `@import` support. I'm not 100% sure, but I believe this can already be done by using a custom gadget instead of the built-in site modul... [02:11:08] dargasia, can you give me a past of the celery startup stuff when you run "./utility applications.celery" [02:11:12] *paste [02:14:18] halfak, very sorry about the false alarm - just found out that I ran the program in the wrong virtualenv [02:14:30] All is well. So sorry. [02:14:45] (03PS3) 10Reedy: User::edits() was removed [core] - 10https://gerrit.wikimedia.org/r/324367 [02:14:54] \o/ [02:15:11] I've got to step away from the computer shortly. It's getting pretty late. [02:15:23] Feel free to drop me an email if you run into more trouble. I'll PM shortly. [02:15:27] * Reedy looks at the time being 02:15 [02:21:40] Reedy lol [02:23:33] (03PS6) 10Bartosz Dziewoński: qunit: Don't assume synchronous Deferred.resolve [core] - 10https://gerrit.wikimedia.org/r/323241 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [02:32:45] (03PS4) 10Haikalizz: Replace Linker::link() usage with LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/324221 (https://phabricator.wikimedia.org/T149346) [02:32:57] (03CR) 10jenkins-bot: [V: 04-1] Replace Linker::link() usage with LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/324221 (https://phabricator.wikimedia.org/T149346) (owner: 10Haikalizz) [02:33:36] 10MediaWiki-extensions-InterwikiSorting, 10Wikidata: Add parser function to disable automatic interwiki sorting - https://phabricator.wikimedia.org/T151588#2822090 (10aude) [02:34:27] 10MediaWiki-extensions-InterwikiSorting, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Allow use of new InterwikiSorting configs instead of Wikibase configs - https://phabricator.wikimedia.org/T151652#2833961 (10aude) [02:36:32] (03PS2) 10Sleepinglion: new file: RelatedLinks.alias.php new file: RelatedLinks.hooks.php new file: RelatedLinks.php new file: SpecialRelatedLinks.php new file: ext.related_links.css new file: ext.related_links.js new file: extension.json new file: i18n/en [extensions/RelatedLinks] - 10https://gerrit.wikimedia.org/r/324034 [02:38:09] 10MediaWiki-extensions-InterwikiSorting, 10Wikidata: [RFC] Do we want a namespaces setting in the InterwikiSorting extension to enable sorting for only some namespaces? - https://phabricator.wikimedia.org/T151976#2833962 (10aude) [02:43:18] (03CR) 10Krinkle: [C: 032] "Per Bartosz" [core] - 10https://gerrit.wikimedia.org/r/323241 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [02:43:21] (03PS3) 10MaxSem: refreshLinks.php: allow refreshing by categories, tracking or not [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) [02:43:24] (03CR) 10Krinkle: qunit: Don't assume synchronous Deferred.resolve [core] - 10https://gerrit.wikimedia.org/r/323241 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [02:43:34] (03CR) 10jenkins-bot: [V: 04-1] refreshLinks.php: allow refreshing by categories, tracking or not [core] - 10https://gerrit.wikimedia.org/r/324347 (https://phabricator.wikimedia.org/T149723) (owner: 10MaxSem) [02:53:03] (03Merged) 10jenkins-bot: qunit: Don't assume synchronous Deferred.resolve [core] - 10https://gerrit.wikimedia.org/r/323241 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [02:54:26] just had a strange feeling that some tasks were specifically designed to get students to work on [02:55:05] just had a strange feeling that some tasks were specifically designed to get students to work on [02:57:59] 10MediaWiki-Codesniffer, 13Patch-For-Review: Undefined index: parenthesis_closer in SpaceBeforeControlStructureBraceSniff.php - https://phabricator.wikimedia.org/T146439#2833984 (10Samwilson) a:03Samwilson The above changes fix this and one other similar problem. phpcs runs fine on TextExtracts (well, there'... [03:00:43] (03CR) 10Yaron Koren: "Wow, I wasn't expecting that! This looks great. I plan to try this patch out at some point soon." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/145214 (owner: 10Jamesmontalvo3) [03:01:17] 10Comments, 10Social-Tools: Update REL1_27 branch to current master - https://phabricator.wikimedia.org/T149508#2833987 (10SamanthaNguyen) 05Open>03Invalid [03:04:19] 10MediaWiki-Special-pages, 10ProofreadPage, 06Wikisource, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Make Special:IndexPages transcludable and with parameters - https://phabricator.wikimedia.org/T114346#2833989 (10Samwilson) a:03Samwilson [03:04:36] 10Wikimedia-Extension-setup: Adapt "DPLforum" extension for watchlisting individual threads on a few selected Village Pumps and other main forums. - https://phabricator.wikimedia.org/T16087#2833991 (10MaxSem) 05Open>03declined Wikimedia now has Flow for structured discussions, no point in installing a compet... [03:04:39] 10Wikimedia-Extension-setup, 07Tracking: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T33235#2833993 (10MaxSem) [03:09:46] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834007 (10Shizhao) [03:12:16] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834009 (10Shizhao) [03:12:19] 10Android-app-Bugs, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog, 13Patch-For-Review: [BUG] Chinese news endpoint content garbled - https://phabricator.wikimedia.org/T147874#2834008 (10Shizhao) [03:13:11] 10Wikimedia-Extension-setup, 07Tracking: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T33235#2834013 (10MaxSem) [03:13:13] 10Wikimedia-Extension-setup: Enable NaturalLanguageList Extension on WMF wikis - https://phabricator.wikimedia.org/T24928#2834011 (10MaxSem) 05Open>03declined >>! In T24928#1163359, @Ricordisamoa wrote: >>>! In T24928#269474, @greg wrote: >> Is this extension still needed now that we have Lua available on al... [03:13:15] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#1981019 (10Shizhao) [03:13:17] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: [BUG] Error trying to edit page 中國新歌聲_(第一季) in Simplified Chinese on API 23 - https://phabricator.wikimedia.org/T148075#2834014 (10Shizhao) [03:16:35] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834022 (10Shizhao) [03:16:37] 06Wikipedia-Android-App-Backlog: Use RESTBase for zhwiki - https://phabricator.wikimedia.org/T148854#2834021 (10Shizhao) [03:35:45] 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2834025 (10DarTar) [03:35:55] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Enter app from website got wrong language - https://phabricator.wikimedia.org/T137039#2834026 (10Shizhao) [03:35:57] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834027 (10Shizhao) [03:36:51] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#1981321 (10Shizhao) [03:38:16] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834031 (10Shizhao) [03:39:57] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2006122 (10Shizhao) [03:40:00] 10UI-Standardization, 10Editing-UX-Research: Consider `text-emphasis` usage instead of `italics` in UI for languages like Japanese or Chinese - https://phabricator.wikimedia.org/T147541#2834032 (10Shizhao) [03:40:42] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834038 (10Shizhao) [03:41:44] 10MediaWiki-Extensions-Spec: Failed to update page props, no clear reason why - https://phabricator.wikimedia.org/T151978#2834039 (10jeblad) [03:42:20] 10MediaWiki-extensions-PageAssessments, 10WikiProject-tools, 03Community-Tech-Sprint: Create a report interface for PageAssessments - https://phabricator.wikimedia.org/T120407#2834051 (10Samwilson) a:03Samwilson [03:43:07] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, 13Patch-For-Review, 07WorkType-NewFunctionality: Template translation is broken if none of the parameters can be auto-mapped - https://phabricator.wikimedia.org/T151868#2830393 (10santh... [03:44:02] 10MediaWiki-Extensions-Spec: Failed to update page props, no clear reason why - https://phabricator.wikimedia.org/T151978#2834056 (10jeblad) p:05Triage>03Normal [03:45:45] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834058 (10Shizhao) [03:45:56] 10MediaWiki-ResourceLoader, 10ArchCom-RfC, 06Front-end-Standards-Group, 07ArchCom-Has-shepherd, 07RfC: Provide standard-compatible way to load multi-file packages (not plain concatenation) - https://phabricator.wikimedia.org/T133462#2834059 (10Catrope) On IRC @Krinkle told me his ideas for this task, whi... [03:46:03] 04(no projects): Scrolling with arrow keys on iPad hardware keyboard not supported - https://phabricator.wikimedia.org/T151979#2834060 (10Rconradharris) [03:52:23] 04(no projects): Scrolling with arrow keys on iPad hardware keyboard not supported - https://phabricator.wikimedia.org/T151979#2834074 (10Rconradharris) Update: The issue seems to be related to default focus. When an article is first clicked into, the page doesn't appear to get focus, so scrolling events are ig... [04:20:08] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, 13Patch-For-Review, 07WorkType-NewFunctionality: Template translation is broken if none of the parameters can be auto-mapped - https://phabricator.wikimedia.org/T151868#2834078 (10santh... [04:30:00] (03CR) 10Gergő Tisza: [C: 031] "Looks good. Not sure it is worth the complexity though - why not just use a real block (or even an AbuseFilter rule)? I'm pretty sure we h" [core] - 10https://gerrit.wikimedia.org/r/324214 (owner: 10Anomie) [04:43:35] 10Wikimedia-Language-setup, 07I18n: Use "ar-u-nu-latn" instead "ar" for whole Arabic Wikipedia or just for its - https://phabricator.wikimedia.org/T64725#2834133 (10Helmoony) [04:43:37] 10Wikimedia-Language-setup: Set Western Arabic numeral by default in Arabic projects - https://phabricator.wikimedia.org/T117215#2834135 (10Helmoony) [04:46:36] 10Wikimedia-Language-setup, 07I18n: Use "ar-u-nu-latn" instead "ar" for whole Arabic Wikipedia or just for its - https://phabricator.wikimedia.org/T64725#2834137 (10Helmoony) I merged this task with T117215, the description of that task is cited below: This task is a split in 3 tasks of a... [04:54:07] (03CR) 10Legoktm: "Sounds like a good idea. Do any of the other database updaters need to be updated to not drop this field?" [core] - 10https://gerrit.wikimedia.org/r/322495 (https://phabricator.wikimedia.org/T120216) (owner: 10Nemo bis) [04:55:16] (03CR) 10Legoktm: Don't drop the hitcounter table (and related DB fields) during update (031 comment) [core] - 10https://gerrit.wikimedia.org/r/322495 (https://phabricator.wikimedia.org/T120216) (owner: 10Nemo bis) [05:04:09] (03CR) 10BearND: [C: 04-1] "I'd like to see first how hard it would be to get code coverage reports going. I see RB is using coveralls.io. I believe this is using tra" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324341 (owner: 10Mholloway) [05:11:44] (03CR) 10BearND: [C: 032] Fix flaky most-read spec test [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324354 (owner: 10Mholloway) [05:13:38] (03Merged) 10jenkins-bot: Fix flaky most-read spec test [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324354 (owner: 10Mholloway) [05:24:48] Hello, I am pigeon, and i am proud :) [05:25:26] pigeon[1]: Hello. Interesting. :) [05:30:53] (03CR) 10Krinkle: [C: 04-1] "Good point. I'll do that." [core] - 10https://gerrit.wikimedia.org/r/323344 (https://phabricator.wikimedia.org/T121646) (owner: 10Krinkle) [05:35:56] 06Wikipedia-Android-App-Backlog, 07Technical-Debt: Provide full AuthManager support (or intentionally don't) - https://phabricator.wikimedia.org/T151227#2834175 (10Mholloway) [05:35:57] 06Wikipedia-Android-App-Backlog, 13Patch-For-Review, 07Technical-Debt: Add "remember me" support for AuthManager logins - https://phabricator.wikimedia.org/T151494#2834174 (10Mholloway) 05Open>03Resolved [05:36:56] 06Wikipedia-Android-App-Backlog, 13Patch-For-Review, 07Technical-Debt: Add "remember me" support for AuthManager logins - https://phabricator.wikimedia.org/T151494#2819166 (10Mholloway) a:03Mholloway [05:39:17] legoktm: pager classes don't have access to link renderer right? [05:39:36] You would have to use mediawiki services. [05:39:41] 10MediaWiki-File-management, 06Commons, 06Multimedia, 10Tabular-Data, and 3 others: Audio/Video/Media/Viz/Layout Session at Wikidev'17 - https://phabricator.wikimedia.org/T151952#2834177 (10Yurik) I'm all for it, sounds like an awesome idea. @cscott thanks for organizing! [05:40:05] (03PS7) 10Georggi199: Added warning for improper ending of a token [core] - 10https://gerrit.wikimedia.org/r/323896 (https://phabricator.wikimedia.org/T122280) [05:44:59] (03CR) 10BearND: "Question for Pchelolo about service-template-node inline" (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324007 (owner: 10Mholloway) [05:46:54] (03PS1) 10Jack Phoenix: Fix PHP Notice: Undefined property: Video::$historyLine in ..\extensions\Video\VideoClass.php on line 617 under MW 1.28 [extensions/Video] - 10https://gerrit.wikimedia.org/r/324381 [05:48:22] (03CR) 10Jack Phoenix: [C: 032] Fix PHP Notice: Undefined property: Video::$historyLine in ..\extensions\Video\VideoClass.php on line 617 under MW 1.28 [extensions/Video] - 10https://gerrit.wikimedia.org/r/324381 (owner: 10Jack Phoenix) [05:49:31] (03Merged) 10jenkins-bot: Fix PHP Notice: Undefined property: Video::$historyLine in ..\extensions\Video\VideoClass.php on line 617 under MW 1.28 [extensions/Video] - 10https://gerrit.wikimedia.org/r/324381 (owner: 10Jack Phoenix) [05:55:28] (03CR) 10BearND: [C: 04-1] "Question: Did you use the autofix feature of eslint? If so would you document the command line used in the commit message?" (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324005 (owner: 10Mholloway) [06:12:30] 10MediaWiki-extensions-ContentTranslation, 05ContentTranslation-Release10, 05Language-Engineering July-September 2016: Translation in ContentTranslation not match - https://phabricator.wikimedia.org/T151984#2834186 (10Johnstad) [06:17:22] 10MediaWiki-Special-pages, 07Easy: Special:UserRights "you must log in" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874#1811411 (10Gauravbackback) @Aklapper hey I want to work on this bug .I will add a log in link with text you must log in just... [06:29:38] 07Design, 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2834201 (10Prtksxna) [06:46:58] 07Design, 10FileAnnotations, 06Multimedia: Adding FileAnnotations (on images) - https://phabricator.wikimedia.org/T151846#2834208 (10Prtksxna) > That's really what I meant, if it hides the information, then finding that information and acting on it is at least one click removed, hence, slower. It might be... [06:53:01] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4: Use mw.widgets.TitleInputWidget for CX Source page selector - https://phabricator.wikimedia.org/T151985#2834209 (10santhosh) [06:58:05] 07Design, 10FileAnnotations, 06Multimedia: Adding FileAnnotations (on images) - https://phabricator.wikimedia.org/T151846#2834229 (10Prtksxna) > I particularly like 4 (or 3), 6, and 8 from technical and look/feel perspectives. Is 2 very hard to do? I think that sometimes the user won't know which tab will... [06:58:11] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, 07Unplanned-Sprint-Work: Use mw.widgets.TitleInputWidget for CX Source page selector - https://phabricator.wikimedia.org/T151985#2834230 (10Arrbee) [06:58:56] (03CR) 10BearND: [C: 04-1] "A few questions inline." (033 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323085 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [06:59:08] MtDu_: you can use the linkrenderer instance from the special page and pass it onto the pager class, you can look at an already converted special page for an example [06:59:46] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, 13Patch-For-Review, and 3 others: Template translation is broken if none of the parameters can be auto-mapped - https://phabricator.wikimedia.org/T151868#2834231 (10Arrbee) [07:04:14] (03CR) 10Robert Vogel: [C: 032] Checklist: Add PHPUnit Tests for API functions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/322246 (owner: 10Ljonka) [07:04:26] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, 13Patch-For-Review, 07Unplanned-Sprint-Work: Use mw.widgets.TitleInputWidget for CX Source page selector - https://phabricator.wikimedia.org/T151985#2834235 (10santhosh) p:05Triage>... [07:04:47] (03Merged) 10jenkins-bot: Checklist: Add PHPUnit Tests for API functions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/322246 (owner: 10Ljonka) [07:05:22] 07Design, 10MediaWiki-extensions-ContentTranslation, 10TemplateData, 10VisualEditor, and 5 others: reconsider terminology about template parameters in VisualEditor and ContentTranslation - https://phabricator.wikimedia.org/T151865#2834236 (10santhosh) a:03Amire80 [07:05:23] (03CR) 10BearND: [C: 04-1] "I think the comments should make this very clear that this is not testing against the local instance but prod. It could warrant a new cate" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323994 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [07:08:05] (03CR) 10BearND: "One more thought. Have you considered writing a unit test for this? Maybe we could copy the Parsoid output of each language and test again" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323994 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [07:08:05] 10MediaWiki-Vagrant, 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4: Update cxserver in contenttranslation Vagrant role for service-runner - https://phabricator.wikimedia.org/T151435#2817062 (10Karti... [07:10:05] (03CR) 10Niedzielski: "@bearND, I think Michael was talking about a similar idea on IRC earlier. I have something going locally but it's not quite ready to push." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323994 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [07:11:26] 07Design, 10MediaWiki-extensions-ContentTranslation, 10TemplateData, 10VisualEditor, and 4 others: reconsider terminology about template parameters in VisualEditor and ContentTranslation - https://phabricator.wikimedia.org/T151865#2834244 (10Arrbee) [07:13:04] (03PS1) 10Sleepinglion: modified: SpecialRelatedLinks.php [extensions/RelatedLinks] - 10https://gerrit.wikimedia.org/r/324385 [07:14:52] Hey everyone, I'm a GCI student.. I have one problem while setting up Vagrant ..While executing command 5 "vagrant up" of step 5 under Quick start section it gives an error - http://pastebin.com/hm54XvFC ..I have vargant version 1.8.7 [07:15:04] Actually I executed "vargant up" earlier but while execution/downloading in between my internet goes off and it displayed some error then I re-executed this command again but unfortunately it gives an error .In case if you want to see the error- http://pastebin.com/T4iZgRrd [07:18:16] 04(no projects): Community Portal tasks Category preference selection, to enhance participation of all Wikipedia users - https://phabricator.wikimedia.org/T151986#2834246 (10Bush6984) [07:20:45] Should I unistall vargant and retry the same process? [07:24:42] p_d, check line 30, it's probably your VirtualBox to blame [07:25:08] If you restart your computer and go into the BIOS [07:25:17] Turn on options about VT-x or virtualization [07:41:48] dargasia: Okay I'll try [07:55:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07TestMe: error messages have the wrong language - https://phabricator.wikimedia.org/T76723#2834276 (10Lucie) Can't reproduce the error anymore. [07:56:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07TestMe: error messages have the wrong language - https://phabricator.wikimedia.org/T76723#2834277 (10Lucie) 05Open>03Invalid [08:03:33] 10MediaWiki-Internationalization, 06Community-Liaisons, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 3 others: Remove Russian fallback for Ukrainian language - https://phabricator.wikimedia.org/T39314#2834279 (10thiemowmde) @Piramidion, Wikidata just uses the language f... [08:05:08] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "You can convince me. The -1 is mainly to get your attention." (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323888 (owner: 10Aftab) [08:06:16] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Map infobox/photograph template for SVMK - Mexiko - https://phabricator.wikimedia.org/T151040#2834281 (10Lokal_Profil) >>! In T151040#2829877, @Mattias_Ostmar-WMSE wrote: > Created [Category:Linné_expedition_at_Teotihuacan_Mexico_1932](http://com... [08:06:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Gadgets.namespaces.php translations for bengali [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323891 (owner: 10Aftab) [08:07:53] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Adding $specialPageAliases translations for bengali (bn) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323666 (owner: 10Aftab) [08:08:02] (03Merged) 10jenkins-bot: Gadgets.namespaces.php translations for bengali [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323891 (owner: 10Aftab) [08:08:50] (03Merged) 10jenkins-bot: Adding $specialPageAliases translations for bengali (bn) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323666 (owner: 10Aftab) [08:19:45] (03PS2) 10Aaron Schulz: MessageCache: some inline comments [core] - 10https://gerrit.wikimedia.org/r/316368 (owner: 10AndyRussG) [08:20:09] (03PS3) 10Aaron Schulz: MessageCache: some inline comments [core] - 10https://gerrit.wikimedia.org/r/316368 (owner: 10AndyRussG) [08:20:15] (03CR) 10Aaron Schulz: [C: 032] MessageCache: some inline comments [core] - 10https://gerrit.wikimedia.org/r/316368 (owner: 10AndyRussG) [08:21:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] ContributionScores.alias.php translations for bengali. [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/324276 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [08:21:44] (03CR) 10Aaron Schulz: [C: 04-1] "I'd rather just require Lua rather than proliferate this kind of words." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255719 (owner: 10Cenarium) [08:21:56] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Adding $specialPageAliases translations for bengali (bn) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/323783 (owner: 10Aftab) [08:31:24] (03Merged) 10jenkins-bot: MessageCache: some inline comments [core] - 10https://gerrit.wikimedia.org/r/316368 (owner: 10AndyRussG) [08:31:27] (03Merged) 10jenkins-bot: ContributionScores.alias.php translations for bengali. [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/324276 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [08:32:47] 10MediaWiki-extensions-ContentTranslation, 07Easy, 07I18n, 05Language-Engineering October-December 2016, and 3 others: Plural does not work on Special:CXstats for cx-stats-grouping-title - https://phabricator.wikimedia.org/T151198#2834288 (10Nikerabbit) It turns out the issue was not missing `mediawiki.jqu... [08:33:22] (03Merged) 10jenkins-bot: Adding $specialPageAliases translations for bengali (bn) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/323783 (owner: 10Aftab) [08:40:19] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 07WorkType-NewFunctionality: Save changes automatically as templates are translated - https://phabricator.wikimedia.org/T151920#2834289 (10Arrbee) [08:40:58] persistant chats in Phab = yay! [08:44:37] tonythomas: Hello! I am currently checking why the link is not working on your local. I think that's because I am using php of a newever version. Will notify you when I finish checking and fix the bug. [08:45:28] Phantom42: is the link showing up in your local ? Can you paste a screenshot in phab or somewhere ? [08:46:30] tonythomas: yes. it works. [08:46:46] Phantom42: please post a screenshot to the phab task, then! [08:47:12] but there are some warnings. And I think that is the reason [08:47:28] Anyone please look up -http://pastebin.com/UE7nE4SY I ran vargant up and I wanted to know does this command executed successfully> [08:47:32] ?* [08:47:41] My newer version of php just ignores them but older dont. [08:53:01] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Easy, and 2 others: Provide a special page to list all available badges - https://phabricator.wikimedia.org/T114473#2834298 (10Victorbarbu) Is there anyone that could review my patch, please? [08:53:56] hello people [08:57:49] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 07WorkType-NewFunctionality: A template transclusion with an HTML comment after the template name cannot be adapted by Content Translation - https://phabricator.wikimedia.org/T150468#2834299 (10Arrbee) [08:58:16] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-Quality, 10Wikidata: Migrate Wikibase to OOUI - https://phabricator.wikimedia.org/T151988#2834300 (10Victorbarbu) [09:01:37] 10MediaWiki-extensions-ContentTranslation, 07I18n, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 2 others: Plural does not work on Special:CXstats for cx-stats-grouping-title - https://phabricator.wikimedia.org/T151198#2834313 (10Nikerabbit) [09:02:25] (03PS1) 10Nikerabbit: mediawiki.language: fix convertNumber( ..., true ) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) [09:02:31] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Map infobox/photograph template for SVMK - Mexiko - https://phabricator.wikimedia.org/T151040#2834316 (10Lokal_Profil) 2nd review of the [[ https://commons.wikimedia.org/wiki/User:Mattias_%C3%96stmar_(WMSE)/sandbox/photographer_template_examples... [09:02:48] hi [09:03:33] ' [09:04:08] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, 13Patch-For-Review, 07Unplanned-Sprint-Work: Use mw.widgets.TitleInputWidget for CX Source page selector - https://phabricator.wikimedia.org/T151985#2834318 (10santhosh) Screenshot {F... [09:05:42] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Map infobox/photograph template for SVMK - Mexiko - https://phabricator.wikimedia.org/T151040#2834320 (10Lokal_Profil) Could you include 0307.b.0052 and 0307.a.0055 in the next demo (to illustrate how multiple depicted persons are handled)? [09:06:14] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Map infobox/photograph template for SVMK - Mexiko - https://phabricator.wikimedia.org/T151040#2834321 (10Lokal_Profil) >>! In T151040#2834316, @Lokal_Profil wrote: > [X] [[ https://commons.wikimedia.org/wiki/Creator:Sigvald_Linn%C3%A9 | Creator:S... [09:07:25] 07Design, 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Improve the New Translation dialog to easily find articles to translate - https://phabricator.wikimedia.org/T111094#2834322 (10santhosh) [09:09:55] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.language: fix convertNumber( ..., true ) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [09:15:50] Hello, I am a Google Code-In student! I really look forward to working with the people in wikimedia because I have only worked with the other organisation before. Cheers! [09:16:04] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2834326 (10phuedx) [09:17:15] guys, is there anything I have to do before using OOUI in an extension? I mean, do I have to install it in the extension's repo? [09:17:44] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2797589 (10phuedx) I've updated the task with @Nirzar's suggestions from T150814#2833030. --- >>! In T150814#2833030, @Nirz... [09:18:20] 06Developer-Relations, 06WMF-Engineering-Administration: Request for on-site Engineering internships - https://phabricator.wikimedia.org/T114348#2834328 (10Qgil) 05Open>03Resolved a:03Qgil On-site Engineering internships are happening, and they are being announced in the regular channels where WMF job po... [09:18:57] 06WMF-Engineering-Administration, 06Developer-Relations (Oct-Dec-2016): Request for on-site Engineering internships - https://phabricator.wikimedia.org/T114348#2834331 (10Qgil) [09:24:58] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 10Wikimedia-Developer-Summit (2017): MediaWiki Documentation - https://phabricator.wikimedia.org/T149372#2834338 (10Qgil) @samuwmde I would like to reply to your post, but this is a Summit proposal about "MediaWiki documentation", and I fear we would be... [09:26:16] 06Developer-Relations, 10Hovercards (2016-17-Q2-Goal): Create rollout plan for Hovercards - https://phabricator.wikimedia.org/T149195#2744940 (10Qgil) @ovasileva can you share the link to the plan, please? [09:27:07] tonythomas: I switched to older php version but the link works. Thats strange. I will post screenshot to phab [09:27:14] zehata: Welcome! [09:27:32] Phantom42: hmm. that sounds scary. I probably am using an older version (for sure :-() [09:31:23] 06ELiSo: Traduki paĝojn pri internaciigo kaj traduko - https://phabricator.wikimedia.org/T151989#2834345 (10Psychoslave) [09:33:20] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Better code review processes for reviewers - https://phabricator.wikimedia.org/T149639#2834357 (10Qgil) >>! In T149639#2831864, @ksmith wrote: > I have heard that not everyone agrees on the meaning of "+1". That some people view a patch... [09:34:22] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Upon creating newsletter, the confirmation message do not show link to new newsletter - https://phabricator.wikimedia.org/T149645#2758774 (10Phantom42) It looks like everything is working on my local. Link is clickable. Here is pro... [09:34:44] tonythomas: I left message on the Phab [09:37:30] (03PS1) 10DCausse: Use "docId" instead of "pageId" [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324389 [09:37:55] (03CR) 10jenkins-bot: [V: 04-1] Use "docId" instead of "pageId" [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324389 (owner: 10DCausse) [09:38:20] Phantom42: let me check now [09:40:38] 10MediaWiki-extensions-Newsletter: Creating a newsletter in the latest mediawiki-core master fails with a fatal - https://phabricator.wikimedia.org/T151967#2834364 (1001tonythomas) 05Open>03Invalid Aha. This was due to my php version (fresh debian 8.6, it seems). After installing `libmcrypt4 php5 php5-mcry... [09:42:58] (03PS2) 10DCausse: Use "docId" instead of "pageId" [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324389 [09:43:00] (03PS1) 10DCausse: Fix flake8 complaints [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324391 [09:43:01] 07Design, 10New-Readers, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃: Finish print styles for flashcard - https://phabricator.wikimedia.org/T148378#2834369 (10Jhernandez) I wrote about the only solution I know of, changing the header in the rendering service to specify `attachment` instead of `inline... [09:45:14] (03CR) 1001tonythomas: [C: 032] "Works in latest php. Thank you!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324257 (https://phabricator.wikimedia.org/T149645) (owner: 10Phantom42) [09:46:25] (03Merged) 10jenkins-bot: en.json: display newsletter title on confimation page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324257 (https://phabricator.wikimedia.org/T149645) (owner: 10Phantom42) [09:47:05] 10MediaWiki-extensions-Newsletter, 13Patch-For-Review: Convert Newsletter to use ContentHandler - https://phabricator.wikimedia.org/T138462#2834376 (1001tonythomas) [09:47:08] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Upon creating newsletter, the confirmation message do not show link to new newsletter - https://phabricator.wikimedia.org/T149645#2834373 (1001tonythomas) 05Open>03Resolved a:03Phantom42 Thank you! [09:50:16] 10Connected-Open-Heritage-Batch-uploads (Medelhavsmuseet_2016-08): Map infobox/photograph template for SVMK - Mexiko - https://phabricator.wikimedia.org/T151040#2834379 (10Mattias_Ostmar-WMSE) Fixes from the 2nd review of the [[ https://commons.wikimedia.org/wiki/User:Mattias_%C3%96stmar_(WMSE)/sandbox/photograp... [09:51:12] (03CR) 10Legoktm: [C: 04-1] "I don't think you've addressed all of the inline comments?" [core] - 10https://gerrit.wikimedia.org/r/324221 (https://phabricator.wikimedia.org/T149346) (owner: 10Haikalizz) [09:52:28] (03PS3) 10Legoktm: Replace Linker::link() with LinkRenderer in some special pages [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [09:52:48] (03CR) 10Legoktm: [C: 032] "Nice work!" [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [09:54:47] 10MediaWiki-General-or-Unknown: Stray wikitext markup prevented page from being edited (http:// 400 error) - https://phabricator.wikimedia.org/T151942#2834380 (10Qgil) At least @Trizek-WMF and I run into this problem. He took a screenshot of that dialog (that I also got). Maybe you can share it (only the dialog,... [09:55:35] 10MediaWiki-General-or-Unknown: Stray wikitext markup prevented page from being edited (http:// 400 error) - https://phabricator.wikimedia.org/T151942#2834381 (10Qgil) Also, the problem was with VisualEditor only, so maybe this task should be tagged accordingly? [09:59:42] (03CR) 10DCausse: [C: 032] Fix flake8 complaints [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324391 (owner: 10DCausse) [10:01:54] 06Developer-Relations, 06Parsing-Team, 10Wikimedia-Developer-Summit, 05Goal: Facilitate Wikidev'17 main topic "Handling wiki content beyond plaintext" - https://phabricator.wikimedia.org/T147602#2834382 (10Qgil) Thank you for all this work organizing your main topic, @cscott! Probably the next step is to k... [10:03:30] 05Security: Password recovery blocked from the WMF office - https://phabricator.wikimedia.org/T151966#2833615 (10Peachey88) Can you let us know what IP you were editing from, So we can look at unblocking it? [10:04:10] (03Merged) 10jenkins-bot: Replace Linker::link() with LinkRenderer in some special pages [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [10:04:13] (03Merged) 10jenkins-bot: Fix flake8 complaints [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324391 (owner: 10DCausse) [10:07:25] 07Design, 10UI-Standardization, 10Kartographer, 10OOjs-UI: Reduce the size of the hole in MapPin and MapPinAdd icons - https://phabricator.wikimedia.org/T151099#2834388 (10Pginer-WMF) This is interesting. Using stroke widths that align better with the text ones can help making the whole thing (icon + label... [10:08:34] guys [10:08:46] I am getting malformedtitleexception when I hit login on my local wiki [10:08:57] have any of you met this? [10:24:58] (03CR) 10Haikalizz: "> I don't think you've addressed all of the inline comments?" [core] - 10https://gerrit.wikimedia.org/r/324221 (https://phabricator.wikimedia.org/T149346) (owner: 10Haikalizz) [10:29:39] (03CR) 10Phuedx: [C: 032] previews: Tidy up styles [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324163 (https://phabricator.wikimedia.org/T151054) (owner: 10Phuedx) [10:29:42] (03CR) 10TTO: "The bottom of the test output will usually show the reason:" [core] - 10https://gerrit.wikimedia.org/r/324221 (https://phabricator.wikimedia.org/T149346) (owner: 10Haikalizz) [10:31:38] (03Merged) 10jenkins-bot: previews: Tidy up styles [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324163 (https://phabricator.wikimedia.org/T151054) (owner: 10Phuedx) [10:33:28] 06Developer-Relations (Oct-Dec-2016), 07Documentation, 10Wikimedia-Developer-Summit (2017): MediaWiki Documentation - https://phabricator.wikimedia.org/T149372#2834421 (10samuwmde) The reason why I was jumping in, was to bring up some ideas how to tackle it. A big finding of the develop interview was that i... [10:33:48] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834424 (10Liuxinyu970226) [10:34:08] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2068992 (10Liuxinyu970226) [10:34:28] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2074615 (10Liuxinyu970226) [10:34:52] (03PS1) 10Phuedx: previews: More visual design tweaks [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324399 (https://phabricator.wikimedia.org/T150814) [10:35:22] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2121297 (10Liuxinyu970226) [10:35:29] Hi [10:38:42] I want to work on bug T118874 how to get it assigned to me? [10:38:43] T118874: Special:UserRights "you must log in" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874 [10:39:40] yeah so would passing returnto would be enough? [10:40:14] how do i work on bug [10:40:46] gramatical mistake [10:42:08] emilyo11: Hi! See https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [10:42:36] thanks :) [10:43:26] saw .But the thing is one guy has already been asigned to that bug from feb .So should I wait ? [10:44:30] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2834441 (10phuedx) @Nirzar: You should be able to look at the results of those ^ tweaks here: http://reading-web-staging.wmfl... [10:45:28] 10Wikimedia-General-or-Unknown, 07Tracking: Malayalam Wiki Projects (tracking) - https://phabricator.wikimedia.org/T58295#2834444 (10Liuxinyu970226) [10:45:54] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Developer Summit 2017 Closing - https://phabricator.wikimedia.org/T151492#2834451 (10Qgil) What if we don't have a closing session at the end of Tuesday (since, well, it's not the end of the Summit) but at the end of Wednesday? [10:46:10] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 06Community-Tech: Possibility to include pages with only hidden categories in Special:UncategorizedPages - https://phabricator.wikimedia.org/T30145#319537 (10Niharika) > One problem is that the query is cached. It would need two sets of querycache rows, one... [10:47:31] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Allow generic hovercards to appear in special cases - https://phabricator.wikimedia.org/T151054#2834454 (10phuedx) @ovasileva, @Nirzar: If you preview the //Empty// or //Redirects to a page that doesn't e... [10:52:10] Reedy: ping [10:53:05] 10TimedMediaHandler: TimedMediaHandler does not support Japanese/Chinese file name - https://phabricator.wikimedia.org/T149771#2762329 (10Liuxinyu970226) >>! In T149771#2804700, @Baskice wrote: > This might be a bug related to the $wgForeignFileRepos ForeignDBRepo class incompatible, where MW randomly refuse to... [10:54:31] 10TimedMediaHandler, 07TestMe: TimedMediaHandler does not support Japanese/Chinese file name - https://phabricator.wikimedia.org/T149771#2834482 (10Liuxinyu970226) [10:54:38] 06Developer-Relations, 10Hovercards (2016-17-Q2-Goal): Create rollout plan for Hovercards - https://phabricator.wikimedia.org/T149195#2834485 (10Aklapper) Subtask T146756 links to https://www.mediawiki.org/wiki/Beta_Features/Hovercards#Rollout_Plan (among many other things) but I do not see any dates in that t... [10:56:08] 04(no projects): Scrolling with arrow keys on iPad hardware keyboard not supported - https://phabricator.wikimedia.org/T151979#2834490 (10Aklapper) Hi @Rconradharris, thanks for taking the time to report this! Which browser and browser version is this about? [10:56:49] 10MediaWiki-General-or-Unknown: To scroll via arrow keys on iPad hardware keyboard, need to tap into page content first to set focus - https://phabricator.wikimedia.org/T151979#2834491 (10Aklapper) [10:57:27] 07Design, 06WMDE-Design, 10Wikidata: [Research, Review] Assess the future use of OOUI.js Widgets in the Wikidata GUI - https://phabricator.wikimedia.org/T146738#2834496 (10Lydia_Pintscher) [10:57:28] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-Quality, 10Wikidata: Migrate Wikibase to OOUI - https://phabricator.wikimedia.org/T151988#2834498 (10Lydia_Pintscher) [10:58:14] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki: Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2834499 (10Schnark) [10:58:23] bd808: patch for fixing autopatrol is now on gerrit, added you as reviewer :) [10:59:20] 10MediaWiki-Special-pages, 07Easy: Special:UserRights "you must log in" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874#2834514 (10Aklapper) That would be my naïve understanding after reading the task summary line but we will only know if that... [11:02:41] Hy.. as mentioned here- https://www.mediawiki.org/wiki/MediaWiki-Vagrant in step 7 I'm not getting any form kind of thing to login Instead http://127.0.0.1:8080/ shows "index of- favicon.ico, html/ , info.php , robots.txt , w/ " [11:03:10] 10MediaWiki-extensions-General-or-Unknown, 07I18n: SpecialPageAliases translation in Bengali projects (2) - https://phabricator.wikimedia.org/T151927#2832287 (10MarcoAurelio) Is there any way to make all those changes and submit them together instead of doing git review 20 times? Thanks. [11:06:43] gauravlordofther, still around? Did you get an answer to your question? [11:07:56] yeah I got one of the devloper replied [11:08:03] excellent! [11:10:25] (03Draft2) 10MarcoAurelio: $specialPageAliases for Bengali (bn) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/324405 (https://phabricator.wikimedia.org/T151927) [11:10:31] (03Draft1) 10MarcoAurelio: $specialPageAliases for Bengali (bn) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/324405 (https://phabricator.wikimedia.org/T151927) [11:10:33] p_d: so you get a raw listing of the directory instead of the index page rendered? That sounds like a misconfiguration of your webserver software [11:11:50] gauravlordofther: no, I am *not* a developer, sorry. :) (*if* you referred to T118874) [11:11:50] T118874: Special:UserRights "you must log in" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874 [11:13:16] ohh sorry still I wanted to thank you . [11:15:40] andre__: yeah any fix? or anything I need to re-config/install? [11:16:41] p_d: (coming into this late and have only seen Andre's reply) what webserver are you running? [11:19:01] (03PS1) 10MarcoAurelio: CheckUser.alias for Bengali (bn) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/324407 (https://phabricator.wikimedia.org/T151927) [11:19:44] myrcx: Apache I guess ..Actually I have completed all the steps mentioned under Quick Start section of https://www.mediawiki.org/wiki/MediaWiki-Vagrant [11:20:12] 10UI-Standardization, 10OOjs-UI, 07Tracking, 03UI-Standardization-Kanban: Sub-pixel rendering layout issues with `em` or `%` relative units – General discussion and tracking - https://phabricator.wikimedia.org/T130691#2834534 (10Volker_E) [11:20:13] 10UI-Standardization, 07Browser-Support-Google-Chrome, 10OOjs-UI (OOjs-UI-0.18.0), 03UI-Standardization-Kanban: RadioInputWidget is not perfectly round - https://phabricator.wikimedia.org/T148941#2834533 (10Volker_E) 05Resolved>03Open [11:20:27] (03CR) 10Rudloff: Add a webapp manifest (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) (owner: 10Rudloff) [11:21:59] andre_:can you assign that bug to me ? [11:22:17] 10MediaWiki-extensions-InterwikiSorting, 10Wikidata: [RFC] Do we want a namespaces setting in the InterwikiSorting extension to enable sorting for only some namespaces? - https://phabricator.wikimedia.org/T151976#2833962 (10Lydia_Pintscher) No, as you said this setting is mostly to prevent the adding of langu... [11:22:20] (03CR) 10Nikerabbit: Gadgets.alias.php translation for bengali (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323888 (owner: 10Aftab) [11:23:37] 10UI-Standardization, 07Browser-Support-Google-Chrome, 10OOjs-UI (OOjs-UI-0.18.0), 03UI-Standardization-Kanban: RadioInputWidget is not perfectly round - https://phabricator.wikimedia.org/T148941#2834539 (10Volker_E) Remains open, the merged patches on adressing sizing issues differently haven't affected R... [11:25:02] Hello [11:26:13] gauravlordofther: I could, but you could also do that yourself [11:26:29] Hi AlexAJ again! :) [11:26:40] :-) [11:28:15] p_d: Entering "apache shows directory listing" in an internet search engine should show lots of results :) [11:28:38] andre__, shouldn't we need to run "vagrant provision" after "vagrant roles enable monobook" ? [11:28:47] (03CR) 10Tobias Gritschacher: Add Vagrant role for Wikibase Repo (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/323841 (https://phabricator.wikimedia.org/T151845) (owner: 10Tobias Gritschacher) [11:28:48] aokay [11:28:52] okay* [11:29:54] p_d: I really don't know as I've never set up Vagrant, to be honest :D [11:29:57] p_d: But if you think so (and can explain why), your comment on the talk/discussion page of our Vagrant installation wikipage would be very welcome [11:30:02] so we can improve our docs [11:30:25] andre__: Hey. Could you do me. A favor? :) [11:31:34] 10Outreachy, 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Actions to grow the diversity of our technical community - https://phabricator.wikimedia.org/T148598#2834561 (10Qgil) Workshop with questions, how would that work during the session? Also, maybe can we start this work bef... [11:31:40] legoktm_: are you still there? If so, I submitted. (You're probably asleep though, considering its 3am in your time zone.) Thanks [11:31:47] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2834562 (10Pginer-WMF) [11:31:54] MtDu_: maybe. Depends if it's covered by my skill set :D [11:32:17] andre__: Actually after entering vagrant roles enable monobook it says "Ok. Run `vagrant provision` to apply your changes" thats why I asked [11:32:32] andre__: well. I finished https://gerrit.wikimedia.org/r/#/c/324355/ and legoktm merged but I wasn't awake when he told me to submit. :P [11:32:33] 10MediaWiki-extensions-AntiSpoof, 13Patch-For-Review: Add more characters to ccnorm - https://phabricator.wikimedia.org/T27619#2834578 (10He7d3r) [11:32:57] 07Design, 10FileAnnotations, 06Multimedia: Explore designs for FileAnnotations - https://phabricator.wikimedia.org/T151327#2834579 (10Prtksxna) First prototype coming up! w00t! https://prtksxna.github.io/wikimedia-prototypes/fileannotations/discovery_wp/discovery_wp/discovery_wp.html (will organize into tas... [11:32:58] andre__: but it's ok. If you'd rather have Florian or Lego approve it, I'll just wait. :) [11:33:40] I'll take a look [11:34:23] xD [11:36:03] MtDu_ if you don't mind, I will work on Linker task in includes/ when my task is accepted. [11:36:23] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Better recommending of tasks suitable for new technical contributors - https://phabricator.wikimedia.org/T149564#2834597 (10Qgil) I am wondering whether this session is really a good fit for a pre-scheduled one (jn a bigger room with vi... [11:36:30] MtDu_: I don't mind at all. There are plenty of usages left. I'd be happy to review your code. :) [11:36:38] Or help yyou review it. [11:37:01] Sure [11:37:03] tonythomas: are you still having issues with Newsletter? Did Lego confirm the problem? [11:37:59] 10MediaWiki-JobRunner, 10Deployment-Systems, 10scap, 03Scap3 (Scap3-Adoption-Phase1): Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#2834598 (10hashar) [11:38:07] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2834601 (10Pcoombe) 05Open>03Resolved a:03Pcoombe Thanks for the detailed report! I've fixed thi... [11:41:05] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2834608 (10Qgil) @MarkAHershberger could you adress the questions or at least share your opinions, please? Especially if this session... [11:41:42] (03CR) 10Addshore: "The 2 final comment regarding namespaces seem to be inconsistent with the rest of core :/" [core] - 10https://gerrit.wikimedia.org/r/322644 (owner: 10Addshore) [11:42:50] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I have now seen the two different naming schemes in many other extensions. Thanks for the explanation." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323888 (owner: 10Aftab) [11:43:27] (03PS7) 10Addshore: Add DB ConnectionManagers [core] - 10https://gerrit.wikimedia.org/r/322644 [11:43:41] DanielK_WMDE: ^^ [11:45:24] 10Outreachy, 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Actions to grow the diversity of our technical community - https://phabricator.wikimedia.org/T148598#2834630 (10samuwmde) The workshop should be focussed on prototyping in my oppinion so that the people actually are able... [11:46:24] (03PS4) 10Rudloff: Add a webapp manifest [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) [11:51:06] (03CR) 10Addshore: [C: 032] Add license information to extension metadata [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/265171 (owner: 10Dereckson) [11:52:42] (03Merged) 10jenkins-bot: Add license information to extension metadata [extensions/Git2Pages] - 10https://gerrit.wikimedia.org/r/265171 (owner: 10Dereckson) [11:55:51] andre__: Take your time. Thanks! :) [11:57:15] (03CR) 10Unicornisaurous: [C: 031] Added warning for improper ending of a token [core] - 10https://gerrit.wikimedia.org/r/323896 (https://phabricator.wikimedia.org/T122280) (owner: 10Georggi199) [12:03:06] MtDu, so html is converted to text in Linker by using HtmlArmor on it? [12:03:28] Georggi: What do you mean? [12:04:28] Georggi: HrmlArmor is used when you don't want the html entities to be escaped. Ex. You don't want to become literally a '' [12:04:40] You actually want it to make whatever you want bold. [12:04:43] Does that make sense? [12:08:06] I believe so. [12:08:45] Georggi: Well, here's a link for your reference. https://www.mediawiki.org/wiki/Manual:HtmlArmor Ping if you have any more questions. :) [12:14:05] (03CR) 10Sbisson: goodfaith filter (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) (owner: 10Sbisson) [12:19:30] I have one question if I remove Vagrant from my system now.. Then whatever cloning or setup I performed basically all those things which are mentioned in step 5 at https://www.mediawiki.org/wiki/MediaWiki-Vagrant under Quick start will permanently remove from my system? [12:19:42] (03PS2) 10Nikerabbit: mediawiki.language: fix convertNumber( ..., true ) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) [12:19:52] Actually I want to setup vagrant fresh [12:19:57] again [12:21:11] p_d: if you are reinstalling vagrant, I recommend you uninstall everything (except git) and start again. [12:21:43] MtDu: okay thanks [12:23:55] MtDu_: Should I run "dpkg -r package" for removing NFS and ruby-dev too ..Using ubuntu [12:24:20] p_d: I don't think you need to, but you can ti be safe and start fresh. :) [12:24:43] hmm okay [12:24:55] 06WMF-Legal, 07Tracking: Copyright license and attribution issues (tracking) - https://phabricator.wikimedia.org/T87268#2834675 (10ovasileva) [12:24:58] 10PageImages, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Pageimages should return both free and non-free images with 'free-ness' denoted as a property - https://phabricator.wikimedia.org/T131105#2834672 (10ovasileva) 05Open>03Resolved just tested it as we... [12:27:14] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data - https://phabricator.wikimedia.org/T151770#2827529 (10YMS) To translate/summarize my report made there: I experience the same problem. Everything Jarekt says is valid for me, too. All Wikipedias seem to be affec... [12:27:42] (03PS3) 10Nikerabbit: mediawiki.language: fix convertNumber( ..., true ) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) [12:32:32] 07I18n: Hindi number formatting strips decimals in JavaScript implementation - https://phabricator.wikimedia.org/T151998#2834684 (10Nikerabbit) [12:34:55] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃, and 3 others: Regression: Empty watchlists are confusing - https://phabricator.wikimedia.org/T148599#2834696 (10ovasileva) 05Open>03Resolved looks good! [12:37:12] 10Wikimedia-General-or-Unknown: Community Portal tasks Category preference selection, to enhance participation of all Wikipedia users - https://phabricator.wikimedia.org/T151986#2834698 (10Aklapper) Hi @Bush6984, thanks for taking the time to report this! I assume this is about https://en.wikipedia.org/wiki/Wik... [12:37:45] (03CR) 10Nikerabbit: "See also T151998" [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [12:41:02] (03PS1) 10Esanders: Fix primary command name [extensions/Math] - 10https://gerrit.wikimedia.org/r/324424 [12:49:54] 06Developer-Relations, 10Hovercards (2016-17-Q2-Goal): Create rollout plan for Hovercards - https://phabricator.wikimedia.org/T149195#2834725 (10ovasileva) We'll be setting dates based on the initial response for stage 0 - I can throw in rough estimates for now [12:50:35] (03PS1) 10Jhernandez: Hygiene: Correct return value type on mw.popups.wait [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324425 [12:50:38] (03PS1) 10Jhernandez: Fix UserSettings#getIsEnabled docs [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324426 [12:50:41] (03PS1) 10Jhernandez: Hygiene: Do not refer to specific UI elements in comments [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324427 [12:50:44] (03PS1) 10Jhernandez: Hygiene: Fix docs reference to createUserSettings [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324428 [12:50:47] (03PS1) 10Jhernandez: Tests: Explain the second assert in the test [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324429 [12:50:50] (03PS1) 10Jhernandez: Hygiene: Only use that when necessary. Else use this [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 [12:50:53] (03PS1) 10Jhernandez: Hygiene: #processLinks Only use global variables at the edges [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324431 [12:50:56] (03PS1) 10Jhernandez: Hygiene: #processLinks Improve wording on tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324432 [12:50:59] (03PS1) 10Jhernandez: Hygiene: #nextState explain why we iterate keys to copy [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324433 [12:52:07] gauravlordofther: Hi [12:54:32] 04(no projects): RevisionSlider: Mark own edits for logged in users - https://phabricator.wikimedia.org/T152000#2834726 (10Bmueller) [12:56:15] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834743 (10Pginer-WMF) [12:57:12] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834756 (10Pginer-WMF) Here are some thoughts and a quick exploration. Thoughts: - Green and red bring intuitive associations with addition and substraction. they are used in oth... [12:58:36] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834759 (10Pginer-WMF) [12:58:56] (03PS1) 10Nikerabbit: Properly escape abusefilter-log-linkoncontribs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/324434 [13:00:20] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834743 (10Pginer-WMF) As a reference, here is another example: In Google docs suggestions a thicker semi-transparent green line is used for removals, and green text is used for... [13:01:39] (03PS1) 10Reedy: Skip all large wikis during the maintenance script run [extensions/CentralAuth] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324435 [13:01:46] (03PS1) 10Reedy: Skip all large wikis during the maintenance script run [extensions/CentralAuth] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/324436 [13:02:05] MtDu_: I think I fixed it. It was some problem with my php version! [13:02:36] (03CR) 10Reedy: [C: 032] Skip all large wikis during the maintenance script run [extensions/CentralAuth] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/324436 (owner: 10Reedy) [13:02:43] (03CR) 10Reedy: [C: 032] Skip all large wikis during the maintenance script run [extensions/CentralAuth] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324435 (owner: 10Reedy) [13:02:56] tonythomas: needsmoarphp [13:04:14] Reedy: heh. I reinstalled my debian stable yesterday to something light, and alas the default one as per https://wiki.debian.org/LaMp do not want to work with the Newsletter extension [13:04:16] strange. :-( [13:04:40] anyway, fixed it after upgrade to 5.6.27 [13:05:22] (03Merged) 10jenkins-bot: Skip all large wikis during the maintenance script run [extensions/CentralAuth] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/324436 (owner: 10Reedy) [13:05:27] 04(no projects): Show a timeline when RevisionSlider is expanded - https://phabricator.wikimedia.org/T152002#2834761 (10Bmueller) [13:06:14] (03Merged) 10jenkins-bot: Skip all large wikis during the maintenance script run [extensions/CentralAuth] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324435 (owner: 10Reedy) [13:08:09] tonythomas: great. :) [13:08:21] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834788 (10Pginer-WMF) [13:08:26] 10MobileFrontend, 06Reading-Web-Backlog, 07Regression: IEMobile/9.0 Windows Phone 7.5 ar.m.wikipedia.org Main Page, Other Article Layouts Broken - https://phabricator.wikimedia.org/T140651#2834790 (10ovasileva) @Nicholas.tsg - could you look at this one through various windows phone devices across 1-2 browse... [13:15:17] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 03Reading-Web-Sprint-87-: Add preview type to hovercards schema - https://phabricator.wikimedia.org/T152004#2834800 (10ovasileva) [13:15:31] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 03Reading-Web-Sprint-87-: Add preview type to hovercards schema - https://phabricator.wikimedia.org/T152004#2834812 (10ovasileva) p:05Triage>03Normal [13:17:31] (03CR) 10Abhinand: "> Abhinand whenever you send a change in Gerrit, Jenkins will run the" [extensions/EditNotify] - 10https://gerrit.wikimedia.org/r/324146 (owner: 10Hashar) [13:17:37] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834833 (10Pginer-WMF) In a [[ https://ca.wikipedia.org/wiki/Viquiprojecte:Viquitrobada_2016 | recent event]] with editors of the Catalan Wikipedia , [[ https://ca.wikipedia.org/... [13:17:46] (03PS1) 10Cicalese: Fixed vector URL; Fixed apache config; updated extensions [tools/ansible-wikifarm] - 10https://gerrit.wikimedia.org/r/324438 [13:18:45] (03CR) 10Cicalese: [C: 032 V: 032] Fixed vector URL; Fixed apache config; updated extensions [tools/ansible-wikifarm] - 10https://gerrit.wikimedia.org/r/324438 (owner: 10Cicalese) [13:19:51] 10MediaWiki-extensions-LiquidThreads: LQT sends duplicate enotif for past actions on updated thread - https://phabricator.wikimedia.org/T95837#2834835 (10Nemo_bis) This has just happened again to me as https://translatewiki.net/wiki/Thread:User_talk:Liuxinyu970226/Thread_moves was moved (how ironic). https://ger... [13:21:48] Hi, GCI anyone? [13:22:11] rlot: Hi! Welcome [13:22:17] me [13:22:19] Are you a GCI student? [13:22:23] Yeah [13:22:34] Great to have you around! [13:22:52] If you're completing the IRC task, don't forget to introduce yourself :) [13:23:03] Im on IRC from 2 days [13:23:13] 3 tasks done [13:23:29] You're a pro already then! [13:24:10] When i submit a task, i need to wait on phabricator for Path-for-Review? [13:24:22] No, that's just bot tagging [13:24:31] you need the code actually reviewing and submitting [13:25:11] So i need to wait, if someone review it on gerrit, then i can post it for review on GCI-site? [13:26:33] What you should do is to post it for review on GCI, then wait for someone to review on Gerrit. [13:28:04] But i there's any errors [13:28:15] I must fix it [13:28:31] but i don't know whats wrong, without gerrit review [13:30:10] 10MobileFrontend, 06Reading-Web-Backlog, 07Regression: IEMobile/9.0 on Windows Phone 7.x: RTL mobile WP Main Pages layouts broken - https://phabricator.wikimedia.org/T140651#2834838 (10Aklapper) [13:30:57] rlot: Oh, I see what you mean. You should *submit* the patch to Gerrit first, then post for review on GCI, then wait for another developer to post comments on Gerrit [13:31:18] What errors are you experiencing? [13:32:23] I was only wondering [13:32:46] For now, everything is going great [13:33:21] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-11-30): Caching on TTS server - https://phabricator.wikimedia.org/T151880#2834840 (10Sebastian_Berlin-WMSE) [13:33:32] 06Wikispeech-STTS, 10Wikispeech-Synthesis, 10Wikispeech (Sprint 2016-11-30): Multiple requests to TTS server should not cause delay - https://phabricator.wikimedia.org/T143644#2834842 (10Sebastian_Berlin-WMSE) [13:34:13] (03CR) 10Hashar: "recheck" [extensions/BookManager] - 10https://gerrit.wikimedia.org/r/321129 (owner: 10L10n-bot) [13:38:13] 10MediaWiki-extensions-General-or-Unknown, 10Revision-Slider, 06TCB-Team, 13Patch-For-Review, and 2 others: Revision slider disconnects wikEdDiff - https://phabricator.wikimedia.org/T143199#2834848 (10IKhitron) Well, @Addshore, It's OK now, I think. At least I tryed many times and it works. Thanks to @Kipo... [13:38:15] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-11-30): Enable installation of TTS-server for development - https://phabricator.wikimedia.org/T141462#2834850 (10Sebastian_Berlin-WMSE) [13:38:17] Hello [13:38:32] (03CR) 10Phuedx: [C: 032] Hygiene: Correct return value type on mw.popups.wait [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324425 (owner: 10Jhernandez) [13:38:49] (03CR) 10Phuedx: [C: 032] Fix UserSettings#getIsEnabled docs [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324426 (owner: 10Jhernandez) [13:39:03] (03CR) 10Phuedx: [C: 032] Hygiene: Do not refer to specific UI elements in comments [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324427 (owner: 10Jhernandez) [13:39:11] 10Wikimedia-Site-requests: Add IPv6 address for dashboard.wikiedu.org to the ratelimit exemptions - https://phabricator.wikimedia.org/T151823#2829066 (10Dereckson) [13:39:13] Hi Alexandru. [13:39:15] (03CR) 10Phuedx: [C: 032] Hygiene: Fix docs reference to createUserSettings [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324428 (owner: 10Jhernandez) [13:39:40] (03CR) 10Phuedx: [C: 04-1] Tests: Explain the second assert in the test (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324429 (owner: 10Jhernandez) [13:39:55] Husun Shujaat asked me for a screenshot [13:40:21] hey Alexandru! yeah I did [13:40:38] what should be the screenshot? [13:41:13] Alexandru: one of any extension you install. [13:41:28] well, I didn't see you here for an hour,myself so I thought I'd get a screenshot [13:41:56] 10Wikispeech, 10Wikispeech-Player, 06Wikispeech-WMSE: Segment by tags - https://phabricator.wikimedia.org/T149091#2834867 (10Lokal_Profil) Removing from sprint due to prioritisation in T151786 [13:42:09] (03Merged) 10jenkins-bot: Hygiene: Correct return value type on mw.popups.wait [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324425 (owner: 10Jhernandez) [13:42:17] Alexandru, do you remember the time when you spent an hour here? [13:42:48] 10TimedMediaHandler, 10Wikispeech, 10Wikispeech-Player, 06Wikispeech-WMSE: make use of TMH in Wikispeech - https://phabricator.wikimedia.org/T142562#2834871 (10Lokal_Profil) Removing from sprint due to prioritisation in T151786 [13:42:53] i disconnected myself 10 minutes ago [13:42:59] (03Merged) 10jenkins-bot: Fix UserSettings#getIsEnabled docs [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324426 (owner: 10Jhernandez) [13:43:48] 10Wikispeech, 10Wikispeech-Lexicon, 10Wikispeech-NewLanguages, 06Wikispeech-WMSE: [Task] Development of the lexicon through simple tools (Wikispeech) - https://phabricator.wikimedia.org/T133893#2834877 (10Sebastian_Berlin-WMSE) a:03Cyrta [13:43:56] (03Merged) 10jenkins-bot: Hygiene: Do not refer to specific UI elements in comments [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324427 (owner: 10Jhernandez) [13:44:38] Alexandru, I've been here for an hour now, didn't see you 10 minutes ago, which channel were you on? :) [13:44:51] (03Merged) 10jenkins-bot: Hygiene: Fix docs reference to createUserSettings [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324428 (owner: 10Jhernandez) [13:45:24] On this channel [13:45:32] 07Design, 10UI-Standardization, 10Kartographer, 10OOjs-UI: Reduce the size of the hole in MapPin and MapPinAdd icons - https://phabricator.wikimedia.org/T151099#2834881 (10RHo) I think the smaller hole in the pin works fine and is better in keeping with the ratio of pin-to-hole size in some other pin icons... [13:45:38] (03PS1) 10Nikerabbit: Properly escape dates in ThreadHistoryPager [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/324441 [13:46:23] And i changed my nickname, too [13:46:32] (03CR) 10DCausse: [C: 032] Accept 'OK' status results from search engine [core] - 10https://gerrit.wikimedia.org/r/320551 (https://phabricator.wikimedia.org/T134157) (owner: 10EBernhardson) [13:46:40] 10Wikispeech-NLP, 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-11-30): Admin GUI for lexicon database - https://phabricator.wikimedia.org/T134754#2834883 (10HannaLindgren) [13:46:54] 06Wikispeech-STTS, 10Wikispeech (Sprint 2016-11-30): Simple gui for workflow cycle - https://phabricator.wikimedia.org/T143860#2834884 (10HannaLindgren) [13:47:01] (03CR) 10Phuedx: [C: 032] Hygiene: #processLinks Improve wording on tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324432 (owner: 10Jhernandez) [13:47:45] Alexandru oohh, I just saw the line which says you disconnected [13:47:52] (03CR) 10Phuedx: [C: 032] Hygiene: #nextState explain why we iterate keys to copy [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324433 (owner: 10Jhernandez) [13:47:58] (03CR) 10Phuedx: [C: 032] Hygiene: Only use that when necessary. Else use this [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 (owner: 10Jhernandez) [13:48:06] approving your tasks in 10..9..8.. :D [13:48:27] Husun: Can i submit it? [13:48:30] Alexandru can submit the task for review [13:48:32] yes please [13:48:33] (03CR) 10Phuedx: [C: 032] Hygiene: #processLinks Only use global variables at the edges [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324431 (owner: 10Jhernandez) [13:48:37] Ok :D [13:48:44] Thank you! :-) [13:49:18] 10MobileFrontend, 06Reading-Web-Backlog, 07Regression: IEMobile/9.0 on Windows Phone 7.x: RTL mobile WP Main Pages layouts broken - https://phabricator.wikimedia.org/T140651#2834887 (10Aklapper) Comparison of 3 RTL and 2 LTR main pages in IE (position of search bar; context repetition on the right): {F490193... [13:49:23] No worries :) Hope you have a great time with IRC and GCI [13:50:07] (03PS1) 10Phantom42: Fix wrong Return-To URL [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) [13:51:28] Husun: Thanks for the help, I hope to do more of your tasks! [13:52:19] * andre__ thanks Husun [13:53:02] 10Wikimedia-Language-setup: Set Western Arabic numeral by default in Arabic projects - https://phabricator.wikimedia.org/T117215#2834891 (10Nemo_bis) 05duplicate>03Resolved This one was already fixed, as far as I can see from the current configuration: ``` 'wgTranslateNumerals' => [ 'default' => true, 'a... [13:53:03] yay :D [13:53:22] (03PS1) 10Nikerabbit: SpecialActiveUsers: escape group names [core] - 10https://gerrit.wikimedia.org/r/324443 [13:54:50] 10MediaWiki-Internationalization, 07I18n: Use "ar-u-nu-latn" instead "ar" for whole Arabic Wikipedia or just for its - https://phabricator.wikimedia.org/T64725#2834894 (10Nemo_bis) [13:56:21] 10MediaWiki-Internationalization, 07I18n: Use "ar-u-nu-latn" instead "ar" for whole Arabic Wikipedia or just for its - https://phabricator.wikimedia.org/T64725#657220 (10Nemo_bis) Moved to MediaWiki to verify whether there is support for such a language code, since the Wikimedia configura... [13:56:58] Could you tell me please if I have to leave a comment on related Phab page after I complete some GCI task? [13:57:17] 10MediaWiki-extensions-ContentTranslation, 07Easy, 03Google-Code-In-2016, 07I18n, 07WorkType-Maintenance: the header text at Special:ContentTranslation and Special:ContentTranslationStats is the same - https://phabricator.wikimedia.org/T117191#2834905 (10FilipGCI) a:03FilipGCI I'll do it for GCI [13:59:00] 10Wikispeech, 06Wikispeech-WMSE: Wikispeech.playOrStop() triggers twice if button is in focus - https://phabricator.wikimedia.org/T146459#2834907 (10Sebastian_Berlin-WMSE) [13:59:37] (03Merged) 10jenkins-bot: Accept 'OK' status results from search engine [core] - 10https://gerrit.wikimedia.org/r/320551 (https://phabricator.wikimedia.org/T134157) (owner: 10EBernhardson) [14:00:26] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2834921 (10Nemo_bis) >>! In T151660#2833504, @Smalyshev wrote: > There is, however, special meaning to the first al... [14:00:41] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2834925 (10Nemo_bis) p:05Triage>03Normal [14:01:31] 10Wikimedia-General-or-Unknown, 07Tracking: Chinese Wikimedia projects tracking - https://phabricator.wikimedia.org/T125033#2834928 (10Shizhao) [14:02:51] 06Wiktionary, 07Browser-Support-Firefox: Users getting "loss of session data" error while editing with Firefox - https://phabricator.wikimedia.org/T152008#2834929 (10TheDaveRoss) [14:04:02] Phantom42, it is definitely welcome, yes! [14:04:19] Phantom42, but only if your task has been really completed [14:04:54] andre__: okay. I understood. Thank you. [14:05:15] 06Wiktionary, 07Browser-Support-Firefox: Users getting "loss of session data" error while editing with Firefox - https://phabricator.wikimedia.org/T152008#2834942 (10Aklapper) [14:05:17] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data - https://phabricator.wikimedia.org/T151770#2834945 (10Aklapper) [14:05:21] 06Wiktionary, 07Browser-Support-Firefox: Users getting "loss of session data" error while editing with Firefox - https://phabricator.wikimedia.org/T152008#2834929 (10Aklapper) Hi @TheDaveRoss, thanks for taking the time to report this! This particular problem has already been reported into our bug tracking sys... [14:05:25] (03CR) 10Hashar: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/307043 (owner: 10Chad) [14:05:45] (03CR) 10Hashar: "recheck" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/318829 (owner: 10L10n-bot) [14:06:16] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data - https://phabricator.wikimedia.org/T151770#2827529 (10Aklapper) p:05Triage>03High Also mentioned here: https://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2016/November#Session_data_error_on_Mozilla_Firefox [14:08:43] (03CR) 10Hashar: "recheck" [extensions/OpenIDConnect] - 10https://gerrit.wikimedia.org/r/321150 (owner: 10L10n-bot) [14:09:52] andre__: I imagine you're super busy? [14:11:51] MtDu_, so far this week has been... exceptional, yes :D [14:12:07] 10Wikispeech, 10Wikispeech-Player, 06Wikispeech-WMSE: Make player buttons keep screen position during scroll - https://phabricator.wikimedia.org/T151887#2830974 (10Lokal_Profil) Know pitfalls: * Ensure buttons don't cover text when scrolled to the end. [14:16:37] (03CR) 10Hashar: "recheck" [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/316099 (owner: 10L10n-bot) [14:17:03] Hi, i'm doing task "Fix ContentTranslationStats .." [14:17:51] Mentor is Pranavmk98 [14:17:58] thank you :) [14:18:00] Do i need to hardcode it? [14:18:14] Or get it from function/variable [14:18:48] 10MediaWiki-Authentication-and-authorization, 06Editing-Department: Frequent loss of session data - https://phabricator.wikimedia.org/T151770#2834972 (10Anomie) The usual cause of this symptom is some sort of cookie corruption in your browser. Especially if it's fixed by switching browsers, that's probably the... [14:19:11] (03Abandoned) 10Cenarium: Add magic word for pending changes expiry [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255719 (owner: 10Cenarium) [14:21:02] rlot, Hi! [14:21:44] I believe the task requires you to change the heading at Special:ContentTranslationStats [14:22:16] 10Wikispeech, 10Wikispeech-Player, 06Wikispeech-WMSE: Cache processed text - https://phabricator.wikimedia.org/T151874#2830612 (10Lokal_Profil) First thought on test: * Two different browsers visiting one after another. Only the first should trigger the log message in cleaner/segmenter. * Second user updates... [14:22:31] 10Wikispeech, 10Wikispeech-Player, 06Wikispeech-WMSE: Investigate: Cache processed text - https://phabricator.wikimedia.org/T151874#2834985 (10Lokal_Profil) [14:22:50] So if by "hardcoding" you mean manually changing it, then yes, you need to "hardcode" it :) [14:23:33] Ok, i'm searching for this sring [14:23:39] *string [14:24:11] 10Wikimedia-Site-requests, 13Patch-For-Review: Add IPv6 address for dashboard.wikiedu.org to the ratelimit exemptions - https://phabricator.wikimedia.org/T151823#2834990 (10Dereckson) a:03Dereckson Deployed. @Rageross Could you confirm you aren't affected by this rate throttle anymore from the IPv6? [14:25:40] (03CR) 10Anomie: [C: 032] Added warning for improper ending of a token [core] - 10https://gerrit.wikimedia.org/r/323896 (https://phabricator.wikimedia.org/T122280) (owner: 10Georggi199) [14:25:44] (03PS1) 10Hashar: build: register $wgAuth on Wikimedia CI [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/324449 [14:25:59] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#2834994 (10matej_suchanek) [14:26:02] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Easy, and 2 others: Provide a special page to list all available badges - https://phabricator.wikimedia.org/T114473#2834993 (10matej_suchanek) [14:28:45] (03CR) 10Hashar: "recheck" [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/316632 (owner: 10L10n-bot) [14:28:56] rlot Any luck? [14:29:27] (03CR) 10Nemo bis: "I sent a local message too: https://roa-tara.wikipedia.org/w/index.php?title=Wikipedia%3APortale_d%27a_Comunitate&type=revision&diff=13410" [core] - 10https://gerrit.wikimedia.org/r/323886 (owner: 10Nemo bis) [14:29:34] (03CR) 10Hashar: "recheck" [extensions/Contest] - 10https://gerrit.wikimedia.org/r/312655 (https://phabricator.wikimedia.org/T146195) (owner: 10Rohitt-wikipedia) [14:30:31] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2834999 (10Pginer-WMF) [14:30:56] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2835001 (10Esanders) Copying my comment from the previous bug: >>! In T149702#2820166, @Pginer-WMF wrote: >>>! In T149702#2818990, @Esanders wrote: >> The problem with using stri... [14:31:01] But there's lang variable for it [14:31:16] (03CR) 10Hashar: "recheck" [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/317217 (owner: 10L10n-bot) [14:31:18] Do i need to add this in all languages? [14:31:40] rlot, the i18n will take care of that [14:31:48] I tried to add new var in en.js, but what about all of o [14:31:49] Ok [14:31:53] you'll just have to edit the en.json [14:32:00] not in en.js [14:32:06] Yes, i know [14:32:32] 10Wikispeech, 10Wikispeech-Player, 06Wikispeech-WMSE: Handle unsupported page language - https://phabricator.wikimedia.org/T151883#2835006 (10Lokal_Profil) [14:32:56] (03PS1) 10Reedy: Revert "Apply Ori's bandaid for API cluster fails" [core] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/324454 [14:33:12] (03PS2) 10Reedy: Revert "Apply Ori's bandaid for API cluster fails" [core] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/324454 [14:33:25] (03CR) 10Tjones: [C: 032] Use "docId" instead of "pageId" [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324389 (owner: 10DCausse) [14:33:57] 10Wikispeech-Player, 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Investigate: Cache processed text - https://phabricator.wikimedia.org/T151874#2835009 (10Lokal_Profil) [14:34:09] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Change text to glyphs - https://phabricator.wikimedia.org/T151884#2835011 (10Lokal_Profil) [14:34:27] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2835013 (10Pginer-WMF) [14:34:31] 10Wikispeech-Player, 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Handle unsupported page language - https://phabricator.wikimedia.org/T151883#2830843 (10Lokal_Profil) [14:35:06] (03CR) 10TheDJ: [C: 032] Fix primary command name [extensions/Math] - 10https://gerrit.wikimedia.org/r/324424 (owner: 10Esanders) [14:37:22] 10Wikispeech (Sprint 2016-11-30): Blogpost on Wikispeech – Arabic - https://phabricator.wikimedia.org/T151639#2835019 (10Lokal_Profil) [14:37:49] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Blogpost on Wikispeech – Arabic - https://phabricator.wikimedia.org/T151639#2823351 (10Lokal_Profil) [14:40:16] (03CR) 10Anomie: "A real block also checks all IPs in X-Forwarded-For (if $wgApplyIpBlocksToXff is set, at least, which it is on WMF wikis), which breaks wh" [core] - 10https://gerrit.wikimedia.org/r/324214 (owner: 10Anomie) [14:40:53] Hey! I am Parth Miglani. I am participating in Google Code In. [14:41:13] hi [14:41:18] 10MediaWiki-General-or-Unknown: To scroll via arrow keys on iPad hardware keyboard, need to tap into page content first to set focus - https://phabricator.wikimedia.org/T151979#2835029 (10Rconradharris) Hi @Aklapper, This affects the Wikipedia app for the iPad. I'm using an iPad Pro with a Logitech Create keyb... [14:41:42] I cant install virtualbox now "sudo apt-get install virtualbox" says http://paste.ubuntu.com/23558246/ ..anyone knows how to tackle this prob.? [14:42:03] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2835030 (10Aklapper) [14:42:41] why? [14:42:46] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2835032 (10dcausse) Thanks Stas, I agree with you this is the best we can do in a reasonable amount of time. @Piram... [14:43:06] (03Merged) 10jenkins-bot: Added warning for improper ending of a token [core] - 10https://gerrit.wikimedia.org/r/323896 (https://phabricator.wikimedia.org/T122280) (owner: 10Georggi199) [14:43:08] (03Merged) 10jenkins-bot: Use "docId" instead of "pageId" [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/324389 (owner: 10DCausse) [14:43:11] https://www.virtualbox.org/wiki/Downloads [14:45:06] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2835038 (10Trizek-WMF) Do you plan to investigate more, or can we just add that to t... [14:45:29] heyy parthmiglani, nice to see you here. Which irc client are you using? [14:45:43] (03CR) 10DCausse: [C: 031] "tested and works as expected, I'll +2 tomorrow in case someone wants to comment." [core] - 10https://gerrit.wikimedia.org/r/324332 (https://phabricator.wikimedia.org/T151660) (owner: 10Smalyshev) [14:47:02] emilyoll, I downloaded .deb file from there.. I tried using command "dpkg -i package_file*.deb" but it gives me an error "Running VMs found" [14:47:06] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2835044 (10Aklapper) [14:47:12] 10MediaWiki-API, 07Easy, 03Google-Code-In-2016, 13Patch-For-Review: Make action=checktoken give a warning if token ends in " \" (e.g. Url encoding mistake) - https://phabricator.wikimedia.org/T122280#2835045 (10Unicornisaurous) 05Open>03Resolved [14:47:25] Ok, i see theres variable named cx-stats-title, and its used in getDescription() [14:47:45] (03Merged) 10jenkins-bot: Fix primary command name [extensions/Math] - 10https://gerrit.wikimedia.org/r/324424 (owner: 10Esanders) [14:47:48] emilyoll, http://imgur.com/a/P25OQ [14:50:56] rlot, Do you have MediaWiki Vagrant installed? [14:51:15] If you don't, I'd highly recommend installing it [14:51:16] Well Husun_ I am using XChat [14:51:18] Yes, i have this locally [14:51:44] OK, i see the getDescription is for normal heading, not for this type [14:51:49] so i need to change this [14:51:53] So what is the heading at Special:ContentTranslationStats? [14:51:58] As of now [14:52:12] cx var [14:52:22] so Translate page [14:52:24] I mean, what is displayed? [14:52:35] parthmiglani, that's perfect! [14:53:07] 10TimedMediaHandler, 07TestMe: TimedMediaHandler does not support Japanese/Chinese file name - https://phabricator.wikimedia.org/T149771#2835052 (10Baskice) The file with name [[File:クローサー-ザ-ザ-チェインスモーカーズは-ハルシー.ogg]] was not loaded during test. It was wrote there just for an example. Most developer here, as a... [14:53:08] Thanks.. Husun_ [14:53:15] But function getDescription gets cx-stats-title - its "Translation statistics" [14:53:21] but its not displaying [14:53:22] :) [14:54:12] So shall I submit the task? [14:54:35] 10Android-app-feature-Description-Editing, 10Reading-UX-Research, 06Wikipedia-Android-App-Backlog (Kanban): Moderated Usability testing for Wikidata description editing flows - https://phabricator.wikimedia.org/T151828#2835057 (10RHo) [14:55:05] (03PS2) 10Phuedx: previews: More visual design tweaks [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324399 (https://phabricator.wikimedia.org/T150814) [14:55:07] parthmiglani: I'd say wait tilll your 1 hour is over :) [14:55:08] (03PS4) 10Phuedx: previews: Add generic fallback preview [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324164 (https://phabricator.wikimedia.org/T151054) [14:55:11] (03PS1) 10Phuedx: Fix linkTitleChangeListener [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324460 [14:55:26] Ok I would wait.. Husun_ [14:55:28] Tahanks [14:55:36] np ;) [14:55:36] Thanks! [14:57:49] (03CR) 10Hashar: [C: 032] build: register $wgAuth on Wikimedia CI [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/324449 (owner: 10Hashar) [14:59:31] (03PS14) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 [14:59:33] (03PS18) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 [14:59:43] (03Merged) 10jenkins-bot: build: register $wgAuth on Wikimedia CI [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/324449 (owner: 10Hashar) [15:00:21] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Technical-Debt: Cleanup execution flow through Special:Search - https://phabricator.wikimedia.org/T150393#2835063 (10EBernhardson) a:03EBernhardson [15:00:45] Yeah i got it! [15:01:26] rlot, Good job! [15:03:00] Hi! I'm Aditya Jayant Gupta, a teen front-end web developer who loves to code and keeps learning :) [15:05:19] adityagupta4213, hi and welcome! Are you taking part in Google Code-in? :) [15:05:40] Yes [15:06:20] I'm using XChat as the client [15:07:42] adityagupta4213: hello. Welcome. :) [15:08:25] Can i make comments in code, i see some of code is not needed now [15:08:36] But i'm not sure so i want to leave a comment [15:09:03] rlot, Sure, commenting is fine! [15:09:39] (03CR) 10TheDJ: "I assume this breaks backwards compatibility btw, i'm just not sure how severely... (as in, what is currently the lowest supported MediaWi" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321091 (owner: 10Reedy) [15:09:42] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/323896 (https://phabricator.wikimedia.org/T122280) (owner: 10Georggi199) [15:10:22] (03CR) 10jenkins-bot: [V: 04-1] Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (owner: 10EBernhardson) [15:10:28] 07Design, 10VisualEditor: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2835078 (10Pginer-WMF) >>! In T152001#2835001, @Esanders wrote: > As we aren't using a custom edit surface it won't be very easy to change the colour of the strikethrough, or hav... [15:12:33] 07I18n, 07SEO: Google doesn't honor canonical URLs of zh.wiki - https://phabricator.wikimedia.org/T108443#2835083 (10Baskice) This problem is not solved in MW 1.28.0. For what I know this is bug related to sitemap, which was not solved for at lest three years. Sitemap list all language varietals with same prio... [15:14:04] 10MediaWiki-extensions-General-or-Unknown, 07I18n, 13Patch-For-Review: SpecialPageAliases translation in Bengali projects (2) - https://phabricator.wikimedia.org/T151927#2835084 (10Aftabuzzaman) [15:15:34] (03CR) 10jenkins-bot: [V: 04-1] Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (owner: 10EBernhardson) [15:15:50] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 07Accessibility, 13Patch-For-Review, and 5 others: Visually report damaging confidence - https://phabricator.wikimedia.org/T144922#2835085 (10Trizek-WMF) [15:16:08] 07Design, 10Edit-Review-Improvements-RC-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2835087 (10Pginer-WMF) >>! In T151994#2835038, @Trizek-WMF wrote: > Do you plan to i... [15:17:54] (03CR) 10Addshore: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) (owner: 10Phantom42) [15:18:21] (03CR) 10Addshore: "Note: me saying "recheck" was just to trigger a bot to run the full test suite" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) (owner: 10Phantom42) [15:18:34] (03CR) 10Dbrant: [C: 032] Hygiene: remove convert-icons.py [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323501 (owner: 10Niedzielski) [15:22:22] (03Merged) 10jenkins-bot: Hygiene: remove convert-icons.py [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323501 (owner: 10Niedzielski) [15:24:34] (03CR) 10Dbrant: [C: 04-1] "With this patch, it looks like [[links]] aren't getting highlighted correctly. (the first "[" is not highlighted.)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322431 (https://phabricator.wikimedia.org/T148191) (owner: 10Kaartic) [15:25:07] 10MediaWiki-extensions-General-or-Unknown, 07I18n, 13Patch-For-Review: SpecialPageAliases translation in Bengali projects (2) - https://phabricator.wikimedia.org/T151927#2835097 (10Aftabuzzaman) [15:26:01] 10Wikimedia-Site-requests, 13Patch-For-Review: Proposal for changing Importer, Patroller, Rollbackers & Autopatrolled user right settings on Nepali Wikipedia - https://phabricator.wikimedia.org/T148171#2835101 (10Arseny1992) 05Open>03Resolved a:03Dereckson Assigning per patch uploader Closing per SAL ent... [15:29:40] parthmiglani, I think your 1 hour is up, submit your task [15:30:32] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Determine purpose and audience for Wikispeech demo - https://phabricator.wikimedia.org/T151882#2835117 (10Lokal_Profil) * For **Stage 1** the explicit goal is to ensure that the installation (extension + TTS server) works. * For **Stage 2** the explicit goal... [15:30:44] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Determine purpose and audience for Wikispeech demo (Player) - https://phabricator.wikimedia.org/T151882#2835118 (10Lokal_Profil) [15:31:54] 10Wikispeech, 06Wikispeech-WMSE, 05Goal: Publically accessible demo (player) - https://phabricator.wikimedia.org/T151786#2835124 (10Lokal_Profil) [15:31:57] 06Wikispeech-WMSE, 10Wikispeech (Sprint 2016-11-30): Determine purpose and audience for Wikispeech demo (Player) - https://phabricator.wikimedia.org/T151882#2830801 (10Lokal_Profil) 05Open>03Resolved a:03Lokal_Profil Planning for Stage 0-2 is done in T151786 later stages will need their own planning tasks. [15:32:21] okay Thanks Husun [15:32:41] ;) [15:34:17] 10Wikispeech, 06Wikispeech-WMSE, 05Goal: Publically accessible demo (player) [Stage 1+2] - https://phabricator.wikimedia.org/T151786#2835125 (10Lokal_Profil) [15:34:20] done Please review it Husun_: [15:34:38] done :) [15:38:22] Thanks Husun_! Great working with you!! [15:44:21] :) Hope to see you in future tasks again [15:45:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] CheckUser.alias for Bengali (bn) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/324407 (https://phabricator.wikimedia.org/T151927) (owner: 10MarcoAurelio) [15:45:33] (03PS14) 10Matěj Suchánek: Migrate abusefilter/modify log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/292784 [15:46:01] (03PS10) 10Sbisson: goodfaith filter [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) [15:48:43] 06Wikipedia-Android-App-Backlog: Move page title and description to WebView - https://phabricator.wikimedia.org/T150459#2835138 (10RHo) [15:50:06] (03CR) 10Anomie: [C: 04-1] "You're missing the i18n messages for the new parameter. See https://www.mediawiki.org/wiki/API:Localisation" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/324338 (https://phabricator.wikimedia.org/T114465) (owner: 10Blackspirit96) [15:53:19] 07Design, 10MobileFrontend, 06Reading-Web-Backlog (Design): Collapsible templates don't collapse in Mobile Frontend - https://phabricator.wikimedia.org/T111565#1610543 (10TheDJ) I think there is a different problem here, and that is that unlike infobox and navbox, these sidebars are badly maintained and not... [15:53:28] 10MobileFrontend, 06Reading-Web-Backlog: Temporary section collapsing code is leaking to other skins - https://phabricator.wikimedia.org/T152009#2835145 (10bmansurov) [15:54:19] (03PS5) 10Anomie: Add Message::listParam() [core] - 10https://gerrit.wikimedia.org/r/321404 [15:54:45] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2798744 (10Addshore) *poke* it is the end of November now :) [15:55:27] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [15:55:54] (03CR) 10Hashar: "check experimental" [core] (wmf/1.29.0-wmf.3) - 10https://gerrit.wikimedia.org/r/324182 (https://phabricator.wikimedia.org/T151702) (owner: 10Reedy) [15:55:58] (03Merged) 10jenkins-bot: CheckUser.alias for Bengali (bn) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/324407 (https://phabricator.wikimedia.org/T151927) (owner: 10MarcoAurelio) [15:56:00] (03CR) 10Hashar: "check experimental" [core] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324339 (https://phabricator.wikimedia.org/T145133) (owner: 10Chad) [15:56:21] (03PS10) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [15:56:24] (03PS4) 10Anomie: Fix MediaTransformError message handling [core] - 10https://gerrit.wikimedia.org/r/321405 [15:58:30] (03CR) 10Anomie: "PS4 is just a rebase." [core] - 10https://gerrit.wikimedia.org/r/321405 (owner: 10Anomie) [15:58:39] Hello! I'm Lukas, and I am from Slovakia, Europe. [15:59:50] Hi [16:00:00] GCI student? [16:00:24] Yes. My first task. [16:00:49] chaoss, Welcome! [16:00:51] (03PS11) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [16:01:00] So, good luck with it! I'm also on GCI, and its my first year [16:01:06] first time [16:01:14] So far I am loving it. Thank you! [16:02:22] chaoss, great to hear! [16:02:32] (and I can probably say "ahoj" too) [16:05:06] 10Android-app-Bugs, 10Android-app-feature-Description-Editing, 06Wikipedia-Android-App-Backlog (Kanban): [BUG] App errors appearing as inline input error validation when making title description edits - https://phabricator.wikimedia.org/T152010#2835168 (10RHo) [16:07:27] 10MediaWiki-Interface, 07CSS: Pages often have reflows due to jquery.makeCollapsible collapsible content - https://phabricator.wikimedia.org/T152011#2835184 (10TheDJ) [16:08:20] I am sorry, I used irssi terminal client, and it seems to be buggy. [16:08:40] Yes, nice! ahoj is indeed in slovak language [16:08:57] 10MediaWiki-Interface, 07CSS: Pages often have reflows due to jquery.makeCollapsible collapsible content - https://phabricator.wikimedia.org/T152011#2835199 (10TheDJ) [16:09:11] 10MediaWiki-General-or-Unknown, 06Commons, 06Multimedia: RenameLink gadget on Commons causes the page tabs to jump around after it loads - https://phabricator.wikimedia.org/T152013#2835213 (10matmarex) [16:09:25] 10MediaWiki-Interface, 07CSS: Pages often have reflows due to jquery.makeCollapsible collapsible content - https://phabricator.wikimedia.org/T152011#2835184 (10TheDJ) [16:10:27] chaoss, hah, I learned something today! Thanks :) [16:10:41] 10MediaWiki-Special-pages, 07Easy: Special:UserRights "you must log in" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874#2835227 (10Gauravbackback) @Legoktm How to recreate this bug i.e what must be my wiki settings ? [16:11:10] 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog: Save reading list on cloud - https://phabricator.wikimedia.org/T151924#2835229 (10NHarateh_WMF) @Dbrant to confirm if this is a duplicate. [16:12:17] andre__: have you had a chance to take a look for me? :) [16:12:38] You are welcome. So these logs are real-time wikimedia bugs? [16:12:44] 06Wikipedia-Android-App-Backlog: Android Studio cannot read properties from the checkstyle XML configuration file - https://phabricator.wikimedia.org/T151773#2835232 (10Mholloway) 05Open>03Invalid Not a bug in our stuff and nothing for us to do, at any rate. [16:13:14] MtDu_, no, too busy with other things, sorry... [16:13:18] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Sort feature in Saved Pages may not be functioning properly - https://phabricator.wikimedia.org/T151662#2835235 (10Dbrant) [16:13:25] chaoss: yes. There are bots that place updates when patches are uploaded, bugs are updated. [16:13:43] chaoss, this is a channel for chatting, but we also have some automated notifications in here, about bug reports and about code patches getting reviewed or merged. [16:13:48] andre__: no problem. Don't overwork yourself. :) [16:16:16] 04(no projects): GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835240 (10Baskice) [16:17:43] 04(no projects): GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835251 (10Baskice) [16:18:15] 04(no projects): GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835240 (10Baskice) [16:18:58] legoktm_: ping. [16:19:21] 10MediaWiki-Maintenance-scripts: GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835240 (10Baskice) [16:19:31] (03CR) 10Jforrester: [C: 032] Add Message::listParam() [core] - 10https://gerrit.wikimedia.org/r/321404 (owner: 10Anomie) [16:21:58] 10MediaWiki-Maintenance-scripts: GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835256 (10Aklapper) > This is a realllllllly old bug related to languages with variants (e.g. Chinese) which is still not solved!!!! If you'd like to see... [16:22:38] MtDu_: no need for contentless pings :) [16:24:24] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2835260 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03High a:03Esanders Ouch. Ha... [16:24:41] (03CR) 10Anomie: [C: 032] Prevent login-only local password provider from removing passwords [core] - 10https://gerrit.wikimedia.org/r/321602 (owner: 10Gergő Tisza) [16:25:03] MtDu_, approved [16:25:17] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2835270 (10Jdforrester-WMF) a:05Esanders>03Tchanders [16:29:06] (03CR) 10Aaron Schulz: "Probably, though I imagine it's in use atm." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/255719 (owner: 10Cenarium) [16:29:26] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 13Patch-For-Review, 15User-Ladsgroup, 03Wikidata-Sprint-2016-11-15: Usage tracking info should be shown on action=info in any namespace - https://phabricator.wikimedia.org/T151926#2832264 (10daniel) 05Open>03Resolved [16:29:30] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Epic, 07Notice, 07Tracking: [Epic] Track Wikidata entity usage on client pages - https://phabricator.wikimedia.org/T49288#2835277 (10daniel) [16:29:37] (03Draft2) 10Aftab: Collection.alias for Bengali (bn) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/324479 [16:30:01] (03Merged) 10jenkins-bot: Add Message::listParam() [core] - 10https://gerrit.wikimedia.org/r/321404 (owner: 10Anomie) [16:30:46] 10MediaWiki-Internationalization: MediaWiki:Post-expand-template-argument-category - https://phabricator.wikimedia.org/T42830#2835282 (10matmarex) 05Open>03Invalid Seems to be working as expected. [16:30:49] andre__: thanks! Sorry to bother you. :) [16:31:08] yw :) [16:31:10] 10MediaWiki-Categories: Customizing the number of pictures per page in certain categories - https://phabricator.wikimedia.org/T19458#2835284 (10matmarex) 05Open>03declined [16:31:39] MtDu_ congrats! :) [16:31:49] (03CR) 10Jforrester: [C: 031] mediawiki.language: fix convertNumber( ..., true ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [16:32:37] (03CR) 10Jforrester: [C: 032] Fix MediaTransformError message handling [core] - 10https://gerrit.wikimedia.org/r/321405 (owner: 10Anomie) [16:34:27] 06Wikipedia-Android-App-Backlog: Date for tomorrow appearing on some of the pages - https://phabricator.wikimedia.org/T151661#2835287 (10Dbrant) 05Open>03declined Yes, this is expected behavior. [16:34:41] 10MediaWiki-Special-pages: Special:Categories hides categories having 0 current members - https://phabricator.wikimedia.org/T12915#2835289 (10matmarex) [16:36:01] (03PS3) 10Aftab: Collection.alias for Bengali (bn) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/324479 (https://phabricator.wikimedia.org/T151927) [16:37:39] (03PS10) 10Etonkovidova: WIP RSpec test for Mention notificationon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [16:37:42] 10ArchCom-RfC, 07ArchCom-Has-shepherd, 07RfC: RFC: Per-language URLs for multilingual wiki pages - https://phabricator.wikimedia.org/T114662#2835296 (10daniel) >>! In T114662#2832408, @Nemo_bis wrote: > Most of the times, when someone shares a uselang URL with me (e.g. those which many Wikimedia wikis genera... [16:39:14] (03Merged) 10jenkins-bot: Prevent login-only local password provider from removing passwords [core] - 10https://gerrit.wikimedia.org/r/321602 (owner: 10Gergő Tisza) [16:40:24] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016: Wrong Return-To URL in Special:Newsletter/xx/delete - https://phabricator.wikimedia.org/T150123#2835297 (10MtDu) a:03MtDu I'll finish what I created. :) [16:40:39] 10Wikimedia-Language-setup, 07I18n, 10Wikimedia-Developer-Summit (2017): Interface language selection for unregistered users on Wikimedia projects - https://phabricator.wikimedia.org/T149419#2835299 (10daniel) >>! In T149419#2832342, @Nemo_bis wrote: >> When you change your user language, everything on the p... [16:40:49] 10MediaWiki-Special-pages: Special:Categories hides categories having 0 current members - https://phabricator.wikimedia.org/T12915#154004 (10matmarex) Now that a 'category' table exists (since MW 1.13, heh), and now that the definition of category existence has been changed to "has any members, or has a descript... [16:40:54] 10MediaWiki-Maintenance-scripts: GenerateSitemap.php should not generate all language variants with same priority - https://phabricator.wikimedia.org/T152014#2835304 (10Baskice) Hi Aklapper, We got a temporary fix for sitemap error here: [[ https://phabricator.wikimedia.org/T65098 | T65098 ]] to overcome the 5... [16:42:11] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 03Reading-Web-Sprint-86-🔪🦃, 07Spike: [Spike: 3 Hours] Investigate page_summary RESTBase API - https://phabricator.wikimedia.org/T151055#2835305 (10pmiazga) TextExtracts extensions strips those tags from HTML: ``` "table", "div", "ul.gallery", ".mw-... [16:43:04] (03PS1) 10Cicalese: Switched from jquery.ui.dialog to oojs-ui-windows to support mobile [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324485 (https://phabricator.wikimedia.org/T151863) [16:43:20] 10MediaWiki-Special-pages: Special:Categories hides categories having 0 current members - https://phabricator.wikimedia.org/T12915#2835309 (10matmarex) a:03matmarex [16:43:23] (03PS1) 10Bartosz Dziewoński: CategoryPager: Allow categories with no members to be shown [core] - 10https://gerrit.wikimedia.org/r/324486 (https://phabricator.wikimedia.org/T12915) [16:43:46] 10MediaWiki-Special-pages, 13Patch-For-Review: Special:Categories hides categories having 0 current members - https://phabricator.wikimedia.org/T12915#2835314 (10matmarex) [16:43:48] 10MediaWiki-Categories, 13Patch-For-Review: Entries for non-existent categories with no members should be deleted from the 'category' table - https://phabricator.wikimedia.org/T28411#2835315 (10matmarex) [16:44:17] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): How to unleash the power of 3rd party extension developers - https://phabricator.wikimedia.org/T147892#2835325 (10MarkAHershberger) Krenair writes: > I'm not sure what "a structure within MW.o where corporate MW devs can > go to and fi... [16:44:32] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2835327 (10Aklapper) List of extensions in Wikimedia Git from a quick `grep` (with... [16:45:51] (03PS1) 10MtDu: Change Return-To URL in Special:Newsletter/xx/delete to 'Return to Newsletter:Foo' instead of 'Return to Special:Newsletter/1' - Part of migration to ContentHandler [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324490 (https://phabricator.wikimedia.org/T150123) [16:46:01] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2835333 (10Charlie_WMDE) {F4905555} @Addshore any suggestions on improvement etc? [16:46:47] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2835334 (10Addshore) Looks good to me! [16:47:34] tonythomas: finished what I started. :) ^ [16:47:52] 10MediaWiki-Special-pages, 07Tracking: Query pages improvements (tracking) - https://phabricator.wikimedia.org/T41661#2835338 (10matmarex) [16:47:55] 10MediaWiki-Categories, 07Tracking: Things that could use a category table (tracking) - https://phabricator.wikimedia.org/T15326#2835339 (10matmarex) [16:47:56] 10MediaWiki-Special-pages: Optimize query in Special Unusedcategories & Special Mostlinkedcategories by using category table - https://phabricator.wikimedia.org/T15577#2835336 (10matmarex) 05Open>03Resolved Mostlinkedcategories has been updated; Unusedcategories doesn't really need any fixes (it's not any w... [16:48:08] (03PS2) 10Cicalese: Switched from jquery.ui.dialog to oojs-ui-windows to support mobile [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324485 (https://phabricator.wikimedia.org/T151863) [16:48:47] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2835341 (10Charlie_WMDE) okay. i'll go ahead and add a white background then and upload the svg file. commons or here? [16:49:45] (03CR) 10Kghbln: "This would be including a tagging request I added with my comment." [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/323376 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [16:50:07] (03CR) 10Cicalese: [C: 032 V: 032] Switched from jquery.ui.dialog to oojs-ui-windows to support mobile [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324485 (https://phabricator.wikimedia.org/T151863) (owner: 10Cicalese) [16:50:29] (03CR) 10Kghbln: "This is just a tiny tweak." [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/323375 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [16:50:51] (03CR) 10Cicalese: "recheck" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [16:50:56] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2835344 (10Addshore) @Charlie_WMDE uploading it here would be fine! Could we also have a RTL version? I think the boxes... [16:52:11] (03Draft2) 10Aftab: Echo.alias for Bengali (bn) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324491 [16:52:45] (03PS3) 10Aftab: Echo.alias for Bengali (bn) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324491 (https://phabricator.wikimedia.org/T151927) [16:52:57] 10MediaWiki-Categories, 07Tracking: Things that could use a category table (tracking) - https://phabricator.wikimedia.org/T15326#2835349 (10matmarex) 05Open>03Resolved As this 'category' table has existed for 8 years now, I don't think this tracking bug makes much sense. Most of the tracked tasks have actu... [16:53:04] 06Reading-Web-Backlog: Move first paragraph before infobox on stable - https://phabricator.wikimedia.org/T150325#2782128 (10ovasileva) [16:53:29] 10MobileFrontend, 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 07Easy, 07Technical-Debt (RW-Tech-Debt): Hygiene: Clean up configuration variables (mobile) - https://phabricator.wikimedia.org/T147092#2835354 (10jhobs) [16:55:00] 10MobileFrontend, 06Reading-Web-Backlog, 10Wikimedia-Site-requests, 07Easy, 07Technical-Debt (RW-Tech-Debt): Hygiene: Clean up configuration variables (mobile) - https://phabricator.wikimedia.org/T147092#2680725 (10jhobs) a:05jhobs>03None @Jdlrobson I updated the task to be clearer about my original... [16:55:06] (03Restored) 10Cicalese: Jenkins job validation (DO NOT SUBMIT) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [16:55:16] (03PS3) 10Cicalese: Jenkins job validation (DO NOT SUBMIT) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [16:55:48] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec test for Mention notificationon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [16:56:02] 04(no projects): Kafka Security Features - https://phabricator.wikimedia.org/T152015#2835361 (10Ottomata) [16:56:24] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [16:56:38] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835374 (10cicalese) Thank you @K... [16:57:54] (03PS11) 10Etonkovidova: WIP RSpec test for Mention notificationon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) [16:59:17] (03Draft3) 10Aftab: EducationProgram.i18n.alias for Bengali (bn) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/324493 (https://phabricator.wikimedia.org/T151927) [16:59:27] (03PS1) 10Cicalese: Removed deleted messages referenced in extension.json [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324494 [16:59:32] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2835383 (10Charlie_WMDE) {F4905886} {F4905918} {F4905885} {F4905917} [16:59:44] 04(no projects): mailing list - admin access - https://phabricator.wikimedia.org/T152016#2835384 (10Saqib) [16:59:58] (03CR) 10Cicalese: [C: 032 V: 032] Removed deleted messages referenced in extension.json [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324494 (owner: 10Cicalese) [17:00:13] (03PS4) 10Cicalese: Jenkins job validation (DO NOT SUBMIT) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [17:00:32] (03PS2) 10Jhernandez: Tests: Explain the second assert in the test [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324429 [17:00:54] (03Merged) 10jenkins-bot: Fix MediaTransformError message handling [core] - 10https://gerrit.wikimedia.org/r/321405 (owner: 10Anomie) [17:01:14] (03CR) 10Jhernandez: Tests: Explain the second assert in the test (031 comment) [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324429 (owner: 10Jhernandez) [17:01:24] Reedy: re: https://gerrit.wikimedia.org/r/#/c/322039/ , would this be fine to submit now? it's been a few days and I believe the gerrit maintenance is now done, judging by, well, commits like that^^ ;-) [17:01:36] (03PS2) 10Jhernandez: Hygiene: Only use that when necessary. Else use this [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 [17:01:39] (03CR) 10MarcoAurelio: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [17:01:50] (03PS2) 10Jhernandez: Hygiene: #processLinks Only use global variables at the edges [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324431 [17:01:55] (03PS2) 10Jhernandez: Hygiene: #processLinks Improve wording on tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324432 [17:02:01] (03PS2) 10Jhernandez: Hygiene: #nextState explain why we iterate keys to copy [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324433 [17:02:11] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Special-pages, 07Wikimedia-log-errors: SpecialUserrights: fetchUser() called with wrong parameters - https://phabricator.wikimedia.org/T151961#2835397 (10Krenair) https://gerrit.wikimedia.org/r/#/c/107009/9 [17:02:16] (03CR) 10Alex Monk: "https://phabricator.wikimedia.org/T151961" [core] - 10https://gerrit.wikimedia.org/r/107009 (https://phabricator.wikimedia.org/T27319) (owner: 10Jackmcbarn) [17:03:26] (03CR) 10jenkins-bot: [V: 04-1] WIP RSpec test for Mention notificationon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [17:03:35] (03CR) 10jenkins-bot: [V: 04-1] Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [17:04:03] 07Design, 06TCB-Team, 10Two-Column-Edit-Conflict-Merge, 06WMDE-Design, 03WMDE-QWERTY-Team-Board: Create logo for TwoColConflict beta feature - https://phabricator.wikimedia.org/T150847#2835400 (10Addshore) 05Open>03Resolved a:03Addshore [17:04:07] (03CR) 10MarcoAurelio: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [17:04:19] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist: Watchlist and recent changes edits in the same minute are sorted wrong. - https://phabricator.wikimedia.org/T149558#2835403 (10IKhitron) [17:04:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Only use that when necessary. Else use this [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 (owner: 10Jhernandez) [17:04:38] (03Abandoned) 10Cicalese: Jenkins job validation (DO NOT SUBMIT) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [17:04:54] (03CR) 10Hashar: "Magically fixed! well done :-}" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324053 (owner: 10Hashar) [17:04:56] 10MediaWiki-extensions-DynamicPageList2: Strict Standards: Only variables should be assigned by reference - https://phabricator.wikimedia.org/T76102#2835406 (10Seb35) 05Open>03Resolved a:03Seb35 The two occurences of =& were resolved in 700978b (11 September 2015, REL1_26+) and 72b0844 (11 January 2014, R... [17:05:06] (03CR) 10Hashar: "recheck" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/322867 (owner: 10Raimond Spekking) [17:05:12] (03CR) 10jenkins-bot: [V: 04-1] Consistency tweaks in preparation for translatewiki.net [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/322867 (owner: 10Raimond Spekking) [17:06:07] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835411 (10cicalese) OK, tests pa... [17:06:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: #processLinks Improve wording on tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324432 (owner: 10Jhernandez) [17:06:58] (03CR) 10Paladox: "recheck" [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324432 (owner: 10Jhernandez) [17:07:01] (03Draft3) 10Aftab: EducationProgram.i18n.ns for Bengali (bn) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/324496 (https://phabricator.wikimedia.org/T151927) [17:07:50] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: #nextState explain why we iterate keys to copy [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324433 (owner: 10Jhernandez) [17:09:29] 10Hovercards, 06Reading-Web-Backlog, 10Security-Reviews: Security Review of Popups extension library - https://phabricator.wikimedia.org/T151902#2835419 (10MBinder_WMF) [17:09:47] 10MediaWiki-extensions-DynamicPageList2: Strict Standards: Only variables should be assigned by reference - https://phabricator.wikimedia.org/T76102#2835422 (10Kghbln) @Seb35 Merci beaucoup! Indeed 700978b was still not done at the time of my report. [17:10:02] 10MediaWiki-extensions-DynamicPageList2, 07Technical-Debt: Strict standards not being upheld - line 53 DPLMain.php - https://phabricator.wikimedia.org/T107149#2835424 (10Seb35) [17:11:04] 06Reading-Admin, 06Wikipedia-Android-App-Backlog, 07Category, 07Epic: Synchronize user saved pages across devices. - https://phabricator.wikimedia.org/T120107#2835425 (10Dbrant) [17:11:17] 06Reading-Web-Backlog, 06Wikipedia-Android-App-Backlog: Save reading list on cloud - https://phabricator.wikimedia.org/T151924#2835432 (10Dbrant) [17:11:19] 06Reading-Admin, 06Wikipedia-Android-App-Backlog, 07Category, 07Epic: Synchronize user saved pages across devices. - https://phabricator.wikimedia.org/T120107#1845032 (10Dbrant) [17:12:35] 10MobileFrontend, 06Reading-Web-Backlog: Temporary section collapsing code is leaking to other skins - https://phabricator.wikimedia.org/T152009#2835438 (10bmansurov) p:05Triage>03Low [17:12:41] 10MediaWiki-extensions-DynamicPageList2, 07Technical-Debt: Strict standards not being upheld - line 53 DPLMain.php - https://phabricator.wikimedia.org/T107149#2835441 (10Seb35) 05Open>03Resolved a:03Seb35 The two occurences of =& were resolved in 700978b (11 September 2015, REL1_26+) and 72b0844 (11 Janu... [17:12:47] 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Clean up inappropriate usages of wmg prefix in Reading-web maintained extensions - https://phabricator.wikimedia.org/T151891#2835447 (10MBinder_WMF) [17:12:53] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835448 (10hashar) There is no ro... [17:13:27] (03CR) 10Pastakhov: [C: 032] "Hi, I'm sorry for delay. Thanks for contribution." [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/323376 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [17:13:47] (03Draft2) 10Aftab: FlaggedRevs.alias for Bengali (bn) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/324498 (https://phabricator.wikimedia.org/T151927) [17:14:33] (03Merged) 10jenkins-bot: Provide license information to show on "Special:Version" [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/323376 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [17:15:03] 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Clean up inappropriate usages of wmg prefix in Reading-web maintained extensions - https://phabricator.wikimedia.org/T151891#2835451 (10bmansurov) p:05Triage>03Low [17:15:13] (03PS3) 10Aftab: FlaggedRevs.alias for Bengali (bn) Bug: T151927 Change-Id: I727f75658663d64ca9d07361b39fd395cffdef53 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/324498 (https://phabricator.wikimedia.org/T151927) [17:16:01] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835453 (10cicalese) Great! I see... [17:16:08] (03CR) 10Yaron Koren: "Sorry, I think I missed this before!" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/323375 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [17:16:11] (03CR) 10Yaron Koren: [C: 032] Provide license label to show on "Special:Version" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/323375 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [17:16:24] (03CR) 10Niedzielski: [C: 031] "Nice! Ready for merge pending dependencies" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323256 (https://phabricator.wikimedia.org/T148202) (owner: 10Mholloway) [17:17:00] (03PS4) 10Aftab: FlaggedRevs.alias for Bengali (bn) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/324498 (https://phabricator.wikimedia.org/T151927) [17:17:56] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃, 07Unplanned-Sprint-Work, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Watchlist sticky state not working - https://phabricator.wikimedia.org/T150650#2835462 (10Jdlrobson) [17:18:08] (03CR) 10Kghbln: "No worries. That's why I pinged you. :)" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/323375 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [17:18:14] 10Android-app-feature-Description-Editing, 06Wikipedia-Android-App-Backlog: Add 'edit here' as a new text selection option for title descriptions - https://phabricator.wikimedia.org/T150433#2835463 (10Dbrant) [17:18:50] 10MediaWiki-General-or-Unknown, 10Wikidata-Page-Banner, 13Patch-For-Review, 06Reading-Web-Backlog (Design): Display banners on diff pages - https://phabricator.wikimedia.org/T147946#2835467 (10Jdlrobson) 05Open>03stalled We're not clear on the path forward right now :/ [17:20:12] 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 10TimedMediaHandler, 13Patch-For-Review: Show Videos in Media Viewer - https://phabricator.wikimedia.org/T77147#2835474 (10Jdlrobson) What's the current status of this task? Any hope of the patch no longer being a WIP? [17:20:37] (03Draft2) 10Aftab: GlobalBlocking.alias for Bengali (bn) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/324499 (https://phabricator.wikimedia.org/T151927) [17:20:43] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃, 07Unplanned-Sprint-Work: Warning: Invalid state error in MobileFormatter - https://phabricator.wikimedia.org/T151838#2835476 (10pmiazga) p:05Triage>03High [17:22:23] (03PS11) 10Sbisson: goodfaith filter [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) [17:23:47] (03Draft2) 10Aftab: GlobalUsage.alias for Bengali (bn) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/324500 [17:23:51] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835488 (10cicalese) One more que... [17:24:06] (03PS3) 10Aftab: GlobalUsage.alias for Bengali (bn) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/324500 (https://phabricator.wikimedia.org/T151927) [17:26:30] (03PS3) 10Aftab: adding $magicWords translations for bengali [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/323669 (https://phabricator.wikimedia.org/T151690) [17:26:33] 07Design, 10UI-Standardization, 06Reading-Web-Backlog, 03UI-Standardization-Kanban: mediawiki.UI: Bring Checkboxes and Radios on par with M101 and OOjs UI implementation - https://phabricator.wikimedia.org/T148265#2835499 (10ovasileva) p:05Triage>03Normal [17:26:38] 10CirrusSearch, 06Discovery, 06Discovery-Search, 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2835500 (10Smalyshev) a:03Smalyshev [17:26:42] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Nav bar should autohide on nearby pan - https://phabricator.wikimedia.org/T146817#2835502 (10Dbrant) [17:26:43] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Navigation toolbar should autohide on nearby map pan - https://phabricator.wikimedia.org/T147999#2835504 (10Dbrant) [17:27:24] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835507 (10hashar) Sure thing! Th... [17:27:38] 10MobileFrontend, 06Reading-Web-Backlog, 07Spike: [2hrs] Production warning: Undefined index: token in InlineDifferenceEngine - https://phabricator.wikimedia.org/T151837#2835509 (10MBinder_WMF) p:05Triage>03Low [17:28:56] (03CR) 10Cicalese: "I included two of the changes in If142b2b48ebd91810bbb823425d2b30c2e2f7f60. The changes relating to capitalization I did not include for t" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/322867 (owner: 10Raimond Spekking) [17:29:18] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt (RW-Tech-Debt): Explore creating an interface to check for emptiness of an object - https://phabricator.wikimedia.org/T151797#2835527 (10bmansurov) p:05Triage>03Low [17:29:41] (03Draft2) 10Aftab: Interwiki.alias for Bengali (bn) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/324502 [17:30:03] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 07Mobile, 13Patch-For-Review: CommentStreams: The module 'ext.CommentStreams' must not have target 'mobile' because its dependency 'jquery.ui.dialog' does not have it - https://phabricator.wikimedia.org/T151863#2835544 (10cicalese) Awesome! Tha... [17:30:04] (03PS3) 10Aftab: Interwiki.alias for Bengali (bn) [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/324502 (https://phabricator.wikimedia.org/T151927) [17:30:13] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2835546 (10Jdforrester-WMF) Sorry, wrong patch previously; it'll roll out tomorrow. [17:30:54] 10MediaWiki-Interface, 10UI-Standardization, 06Front-end-Standards-Group, 10MobileFrontend, and 2 others: Mobile should equip blockquote with language dependent quotation marks - https://phabricator.wikimedia.org/T114885#2835549 (10MBinder_WMF) [17:33:32] (03Draft2) 10Aftab: Nuke.alias for Bengali (bn) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/324503 [17:33:33] 10MediaWiki-Interface, 10UI-Standardization, 06Front-end-Standards-Group, 10MobileFrontend, and 2 others: Mobile should equip blockquote with language dependent quotation marks - https://phabricator.wikimedia.org/T114885#2835551 (10ovasileva) @Nirzar - any thought on this? [17:33:41] 10MediaWiki-Interface, 10UI-Standardization, 06Front-end-Standards-Group, 10MobileFrontend, and 2 others: Mobile should equip blockquote with language dependent quotation marks - https://phabricator.wikimedia.org/T114885#2835553 (10ovasileva) [17:33:45] (03CR) 10Smalyshev: Allow specification of minimum length for classification (031 comment) [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/323998 (https://phabricator.wikimedia.org/T149318) (owner: 10Tjones) [17:33:51] (03PS3) 10Aftab: Nuke.alias for Bengali (bn) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/324503 (https://phabricator.wikimedia.org/T151927) [17:33:59] (03CR) 10Smalyshev: [C: 031] Allow specification of minimum length for classification [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/323998 (https://phabricator.wikimedia.org/T149318) (owner: 10Tjones) [17:34:07] 10MediaWiki-Interface, 10UI-Standardization, 06Front-end-Standards-Group, 10MobileFrontend, and 2 others: Mobile should equip blockquote with language dependent quotation marks - https://phabricator.wikimedia.org/T114885#2835556 (10Jdlrobson) [17:34:39] 04(no projects): Decide whether a Lexeme's lemma can have multiple representations for the same language code. - https://phabricator.wikimedia.org/T152019#2835558 (10daniel) [17:35:21] 04(no projects): Decide whether a Lexeme's lemma can have multiple representations for the same language code. - https://phabricator.wikimedia.org/T152019#2835573 (10daniel) [17:37:01] (03Draft2) 10Aftab: Renameuser.alias for Bengali (bn) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/324504 [17:37:20] (03PS3) 10Aftab: Renameuser.alias for Bengali (bn) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/324504 (https://phabricator.wikimedia.org/T151927) [17:37:26] 06Design-Research, 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2835579 (10aripstra) [17:38:03] (03CR) 10MarcoAurelio: "Can we have this code-reviewed and merged if code is okay? This CGI patch is sitting here since January :) Thanks." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [17:40:44] 10MobileFrontend, 06Reading-Web-Backlog, 07Spike: [2hrs] Production warning: Undefined index: token in InlineDifferenceEngine - https://phabricator.wikimedia.org/T151837#2835585 (10Jdlrobson) This was broken by T130946 and I6be2c07824c17b165e068fc4ac36ab192e12bc9d which removed the token from this method whi... [17:41:16] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy related pages to Japanese and Spanish wikipedias - https://phabricator.wikimedia.org/T151346#2835589 (10ovasileva) [17:42:49] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy related pages to Japanese and Spanish wikipedias - https://phabricator.wikimedia.org/T151346#2814866 (10ovasileva) [17:42:51] 06Reading-Web-Backlog: Deploy related pages to Spanish wikipedia - https://phabricator.wikimedia.org/T151341#2835595 (10ovasileva) [17:43:45] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy related pages to Japanese and Spanish wikipedias - https://phabricator.wikimedia.org/T151346#2835604 (10bmansurov) [17:43:53] 06Reading-Web-Backlog, 10Wikimedia-Site-requests: Deploy wikidata descriptions to stable mobile French wikipedia - https://phabricator.wikimedia.org/T151345#2814853 (10ovasileva) [17:44:48] 06Design-Research, 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2835612 (10leila) [17:45:40] 06Design-Research, 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2835614 (10ellery) [17:46:32] 06Design-Research, 06Research-and-Data, 10Research-management: Research Offsite 16-17 planning - https://phabricator.wikimedia.org/T148453#2835615 (10Halfak) [17:47:59] (03PS1) 10Fjalapeno: Extend survey through December [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) [17:48:23] 10MediaWiki-extensions-ConfirmAccount, 07Easy, 07Technical-Debt: Only variables should be assigned by reference in backend/ConfirmAccount.class.php - https://phabricator.wikimedia.org/T152020#2835620 (10Seb35) [17:49:25] 10Wikimedia-General-or-Unknown: generator-wikimedia-php-library broken (throws error) - https://phabricator.wikimedia.org/T148300#2835634 (10MarcoAurelio) Feel free to change it if you find a better project. [17:51:41] (03CR) 10Mholloway: [C: 031] Extend survey through December [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [17:51:44] 10MediaWiki-Internationalization, 13Patch-For-Review: $magicWords translation in Bengali - https://phabricator.wikimedia.org/T151134#2835641 (10Aftabuzzaman) @Pmlineditor Please reupload the patch. It says "The change cannot be merged due to a path conflict". [17:52:11] 10Android-app-Bugs, 10Android-app-feature-UX-Debt, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): [BUG] [API 21+] App toolbar color is incorrect in system recents - https://phabricator.wikimedia.org/T146928#2835643 (10RHo) hey @Sniedzielski – normal light theme now shows the app bar as blue,... [17:54:33] 10MediaWiki-General-or-Unknown, 10Wikidata-Page-Banner, 13Patch-For-Review, 06Reading-Web-Backlog (Design): Display banners on diff pages - https://phabricator.wikimedia.org/T147946#2835645 (10Andyrom75) Maybe I'm wrong but since the banner it's just a normal picturre (nothing more, nothing less), I suppos... [17:56:08] (03PS1) 10Sbisson: [WIP] 'damaging' filter [extensions/ORES] - 10https://gerrit.wikimedia.org/r/324507 (https://phabricator.wikimedia.org/T149734) [17:56:52] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Special-pages, 07Wikimedia-log-errors: SpecialUserrights: fetchUser() called with wrong parameters - https://phabricator.wikimedia.org/T151961#2835650 (10matmarex) a:03matmarex Whoops. [17:58:20] (03Draft2) 10Aftab: SecurePoll.alias for Bengali (bn) [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/324508 [17:58:40] (03PS3) 10Aftab: SecurePoll.alias for Bengali (bn) [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/324508 (https://phabricator.wikimedia.org/T151927) [17:58:49] 10Wikimedia-Wikimania-Scholarships: Change all relevant dates and links on application form to reflect new 2017 information - https://phabricator.wikimedia.org/T151401#2816077 (10Niharika) [18:00:35] (03CR) 10BearND: "No problem with this in principle. We'll get this deployed today. Just waiting for dbrant to specify what time he needs for Android." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [18:00:46] (03Draft2) 10Aftab: SiteMatrix.alias for Bengali (bn) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/324509 [18:01:04] (03PS3) 10Aftab: SiteMatrix.alias for Bengali (bn) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/324509 (https://phabricator.wikimedia.org/T151927) [18:01:58] (03PS4) 10Aftab: SiteMatrix.alias for Bengali (bn) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/324509 (https://phabricator.wikimedia.org/T151927) [18:03:14] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Special-pages, 07Wikimedia-log-errors: SpecialUserrights: fetchUser() called with wrong parameters - https://phabricator.wikimedia.org/T151961#2835660 (10matmarex) For ApiQueryUsers it doesn't really matter, it looks like the code path which checks th... [18:03:19] 10MediaWiki-General-or-Unknown, 10Wikidata-Page-Banner, 13Patch-For-Review, 06Reading-Web-Backlog (Design): Display banners on diff pages - https://phabricator.wikimedia.org/T147946#2835661 (10Jdlrobson) It's trivial to show the banner again but I'm concerned that showing it at the top of the diff page wil... [18:03:24] (03Draft2) 10Aftab: TemplateSandbox.alias for Bengali (bn) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/324510 [18:03:44] (03PS3) 10Aftab: TemplateSandbox.alias for Bengali (bn) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/324510 (https://phabricator.wikimedia.org/T151927) [18:05:29] (03PS1) 10Bartosz Dziewoński: SpecialUserrights: Make new fetchUser() parameter optional [core] - 10https://gerrit.wikimedia.org/r/324511 (https://phabricator.wikimedia.org/T151961) [18:05:37] ostriches: ^ [18:05:52] (03CR) 10MarcoAurelio: [C: 04-1] "I feel the commit message needs improvement. Please see for guidance. Th" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) (owner: 10Sbisson) [18:06:00] 10MediaWiki-Special-pages, 13Patch-For-Review, 07Wikimedia-log-errors: SpecialUserrights: fetchUser() called with wrong parameters - https://phabricator.wikimedia.org/T151961#2835668 (10matmarex) [18:08:02] MatmaRex: tyvm. Will review & backport to wmf.4 [18:08:19] (was low volume on group0, but would probably 'splode on larger wikis) [18:08:26] ostriches: thanks [18:09:34] (03PS1) 10Seb35: Fix PHP notice 'Only variables should be assigned by reference' [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324515 (https://phabricator.wikimedia.org/T152020) [18:12:33] (03PS2) 10Seb35: Fix PHP notice 'Only variables should be assigned by reference' [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324515 (https://phabricator.wikimedia.org/T152020) [18:13:08] 10MediaWiki-extensions-PageAssessments, 10WikiProject-tools, 03Community-Tech-Sprint: Create a report interface for PageAssessments - https://phabricator.wikimedia.org/T120407#2835714 (10kaldari) [18:14:32] 04(no projects): Omit private data from being generated during dump runs - https://phabricator.wikimedia.org/T152021 (10ArielGlenn) [18:14:36] (03CR) 10Chad: [C: 032] SpecialUserrights: Make new fetchUser() parameter optional [core] - 10https://gerrit.wikimedia.org/r/324511 (https://phabricator.wikimedia.org/T151961) (owner: 10Bartosz Dziewoński) [18:14:42] (03PS1) 10Chad: SpecialUserrights: Make new fetchUser() parameter optional [core] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324516 (https://phabricator.wikimedia.org/T151961) [18:14:53] 04(no projects): Omit private data from being generated during dump runs - https://phabricator.wikimedia.org/T152021 (10ArielGlenn) [18:14:59] 10MediaWiki-extensions-PageAssessments, 10WikiProject-tools, 03Community-Tech-Sprint: Create a report interface for PageAssessments - https://phabricator.wikimedia.org/T120407#1853076 (10kaldari) [18:15:59] 04(no projects): Omit private data from being generated during dump runs - https://phabricator.wikimedia.org/T152021 (10ArielGlenn) I've added Analytics to see if they know of any users of these files on the stats* hosts (they would have to be rsynced specially from the dataset host). If they don't, I'll upda... [18:16:51] 10MediaWiki-extensions-ConfirmAccount, 07Easy, 13Patch-For-Review, 07Technical-Debt: Only variables should be assigned by reference in backend/ConfirmAccount.class.php - https://phabricator.wikimedia.org/T152020#2835724 (10Seb35) p:05Triage>03Lowest [18:17:00] 04(no projects): Omit private data from being generated during dump runs - https://phabricator.wikimedia.org/T152021 (10Aklapper) @ArielGlenn: Was your visibility change on this task intentional? If so, please set it to "Public" instead of "All users". [18:17:29] 10Wikimedia-Wikimania-Scholarships: Link to CentralAuth page for users in review interface - https://phabricator.wikimedia.org/T151380#2835727 (10Niharika) [18:18:41] 04(no projects): Omit private data from being generated during dump runs - https://phabricator.wikimedia.org/T152021 (10ArielGlenn) Yes it was, ok fixing. [18:18:43] (03CR) 10Daniel Kinzler: [C: 032] "@addshore Uhhh, you are right, core puts tests into the same namespace as production code! That seems so wrong! Now I'm torn between consi" [core] - 10https://gerrit.wikimedia.org/r/322644 (owner: 10Addshore) [18:19:38] (03CR) 10Phuedx: "Recheck." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324433 (owner: 10Jhernandez) [18:20:22] (03PS2) 10Jforrester: Update OOjs UI to v0.18.1 [vendor] - 10https://gerrit.wikimedia.org/r/324359 [18:20:54] (03CR) 10Phuedx: "Recheck." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 (owner: 10Jhernandez) [18:21:24] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.18.1 [vendor] - 10https://gerrit.wikimedia.org/r/324359 (owner: 10Jforrester) [18:21:30] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.18.1 [core] - 10https://gerrit.wikimedia.org/r/324357 (owner: 10Jforrester) [18:21:40] Hi everyone, I am Apratim a participant of Google Code-In [18:21:57] 10MediaWiki-extensions-ContentTranslation, 10Editing-UX-Research: Editing-Lang CX template translation test sessions - https://phabricator.wikimedia.org/T146419#2835736 (10Pginer-WMF) [18:22:04] 06Research-and-Data: Request access to data/cluster for understanding WDQS - https://phabricator.wikimedia.org/T152023#2835737 (10leila) [18:22:20] (03CR) 10Phuedx: "Recheck." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 (owner: 10Jhernandez) [18:22:40] Hi ARChak and welcome! [18:23:35] 06Discovery, 06Reading-Web-Backlog, 07Browser-Support-Apple-Safari: Safari search results add racist title to Wikipedia article - https://phabricator.wikimedia.org/T150541#2835753 (10Fjalapeno) This is an Apple Search result. I don't believe they use our APIs for returning results, beyond reporting to Apple... [18:23:41] (03CR) 10Chad: [C: 032] SpecialUserrights: Make new fetchUser() parameter optional [core] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324516 (https://phabricator.wikimedia.org/T151961) (owner: 10Chad) [18:23:45] 10MediaWiki-extensions-ContentTranslation, 10Editing-UX-Research: Editing-Lang CX template translation test sessions - https://phabricator.wikimedia.org/T146419#2660453 (10Pginer-WMF) [18:24:25] (03PS1) 10Jhernandez: Tests: Deeply extend prev state for test correctness [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324517 [18:26:00] 10Hovercards, 06Reading-Web-Backlog, 10TextExtracts, 07Epic, 07Tracking: [EPIC] Service for hovercards and link preview needs to provide useful text for the majority of articles - https://phabricator.wikimedia.org/T113094#2835760 (10phuedx) [18:26:33] 10Hovercards, 06Reading-Web-Backlog, 10TextExtracts: Reference lists appearing in extracts for some articles - https://phabricator.wikimedia.org/T74629#2835762 (10phuedx) [18:27:10] (03Merged) 10jenkins-bot: SpecialUserrights: Make new fetchUser() parameter optional [core] - 10https://gerrit.wikimedia.org/r/324511 (https://phabricator.wikimedia.org/T151961) (owner: 10Bartosz Dziewoński) [18:27:17] (03PS12) 10Sbisson: 'goodfaith' filter on Special:RC / Special:Watchlist [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) [18:27:54] (03CR) 10Phuedx: [C: 032] Tests: Explain the second assert in the test [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324429 (owner: 10Jhernandez) [18:29:19] 10MediaWiki-Internationalization, 07I18n: Hindi number formatting strips decimals in JavaScript implementation - https://phabricator.wikimedia.org/T151998#2835764 (10matmarex) [18:29:26] 10MediaWiki-Internationalization, 10MediaWiki-extensions-ContentTranslation, 07I18n, 05Language-Engineering October-December 2016, and 4 others: Plural does not work on Special:CXstats for cx-stats-grouping-title - https://phabricator.wikimedia.org/T151198#2835765 (10matmarex) [18:29:58] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835766 (10mmodell) hmm... I'm not sure what's up with that. Can we just mount it as tmpfs? [18:30:16] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2835767 (10Nirzar) signed off from design [18:31:44] (03PS1) 10Niharika29: Make i18n changes for new iteration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324519 [18:31:47] Is their any way to make sure that virtualbox is installed in the system properly..am running on ubuntu 16.04 lts [18:32:23] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.language: fix convertNumber( ..., true ) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [18:32:59] (03CR) 10Bartosz Dziewoński: mediawiki.language: fix convertNumber( ..., true ) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [18:33:23] 05Security: Password recovery blocked from the WMF office - https://phabricator.wikimedia.org/T151966#2833615 (10Jalexander) If IPs are blocked then blocking password resets from that IP makes sense given the history of abuse there. That said: The Office IP is blocked to anonymous editing on MW.org, personally... [18:35:23] 10MediaWiki-extensions-Other, 13Patch-For-Review: MediaWikiFarm Jenkins job failures - https://phabricator.wikimedia.org/T151879#2835770 (10Seb35) Thanks hashar for the setup. I will check in details how I can improve the various reports. Some first things: * I didn’t try with HHVM since I don’t have it inst... [18:36:13] 10MediaWiki-extensions-WikibaseRepository, 10Structured-Multimedia-Data, 10Wikidata, 13Patch-For-Review, 03Wikidata-Sprint-2016-11-15: Create a dispatching version of TermSearchInteractor - https://phabricator.wikimedia.org/T150848#2835772 (10daniel) Most of this is done now. I'm wondering whether we wan... [18:38:18] (03PS2) 10Sbisson: [WIP] 'damaging' filter [extensions/ORES] - 10https://gerrit.wikimedia.org/r/324507 (https://phabricator.wikimedia.org/T149734) [18:38:40] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 06Community-Tech: Possibility to include pages with only hidden categories in Special:UncategorizedPages - https://phabricator.wikimedia.org/T30145#2835775 (10kaldari) @Niharika: Hmm, good point. I guess that means it's not as simple as I was thinking. It wo... [18:38:56] 10MediaWiki-Categories, 10MediaWiki-Special-pages: Possibility to include pages with only hidden categories in Special:UncategorizedPages - https://phabricator.wikimedia.org/T30145#2835776 (10kaldari) [18:40:55] I have installed vagrant using dpkg command I need to completely remove it from the system all its files everything ..Want to install a fresh what command should I follow?any idea? [18:41:14] earlier^* [18:41:23] (03Draft2) 10Aftab: MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 [18:41:43] (03PS3) 10Aftab: MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) [18:41:56] (03PS3) 10Sbisson: 'damaging' filter on Special:RC / Special:Watchlist [extensions/ORES] - 10https://gerrit.wikimedia.org/r/324507 (https://phabricator.wikimedia.org/T149734) [18:41:59] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Create config more intuitive aliases for filetype: search - https://phabricator.wikimedia.org/T150887#2835779 (10Smalyshev) [18:42:25] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835781 (10Dzahn) Does Phabricator have a config option where to store the temp files? [18:43:03] 05Security: Password recovery blocked from the WMF office - https://phabricator.wikimedia.org/T151966#2835783 (10awight) Well, it all makes sense historically, and I'm not sure any new feature work is justified. In an ideal world however, it would be possible to prevent anonymous editing from an IP range but tr... [18:43:11] (03CR) 10Thiemo Mättig (WMDE): "I did not meant to block this patch. But as explained I will not merge it." [core] - 10https://gerrit.wikimedia.org/r/320612 (https://phabricator.wikimedia.org/T114883) (owner: 10Harjotsingh) [18:43:24] (03Merged) 10jenkins-bot: Add DB ConnectionManagers [core] - 10https://gerrit.wikimedia.org/r/322644 (owner: 10Addshore) [18:43:27] (03Merged) 10jenkins-bot: Update OOjs UI to v0.18.1 [vendor] - 10https://gerrit.wikimedia.org/r/324359 (owner: 10Jforrester) [18:43:29] (03Merged) 10jenkins-bot: Update OOjs UI to v0.18.1 [core] - 10https://gerrit.wikimedia.org/r/324357 (owner: 10Jforrester) [18:43:32] (03Merged) 10jenkins-bot: SpecialUserrights: Make new fetchUser() parameter optional [core] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324516 (https://phabricator.wikimedia.org/T151961) (owner: 10Chad) [18:43:58] 10MediaWiki-Categories, 10MediaWiki-Special-pages: Possibility to include pages with only hidden categories in Special:UncategorizedPages - https://phabricator.wikimedia.org/T30145#2835787 (10Tgr) The OATH extension has a ProxySpecialPage class which can be used to deal with such problems (in a rather hacky way). [18:44:02] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2835788 (10Smalyshev) [18:44:49] 10MediaWiki-General-or-Unknown, 06Commons, 06Multimedia: RenameLink gadget on Commons causes the page tabs to jump around after it loads - https://phabricator.wikimedia.org/T152013#2835790 (10MarkTraceur) p:05Triage>03Low [18:45:58] (03CR) 10Dpatrick: [C: 032] Throw an exception if password hash would be truncated by DB [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [18:46:35] p_d: just uninstall everything and delete the files it created. :) [18:47:26] legoktm: what were you saying about the accessing linkrenderer in a pager class? I don't think the message saved on my IRC client. [18:47:39] 07Design, 10FileAnnotations, 06Multimedia: Adding FileAnnotations (on images) - https://phabricator.wikimedia.org/T151846#2835799 (10MarkTraceur) 2 wouldn't be difficult to do, no, but the ultra-long div looks weird to me. Maybe in context it wouldn't look so bad. [18:48:06] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835806 (10Paladox) I think it is https://secure.phabricator.com/book/phabricator/article/configuring_file_storage/ "Engine: Local Disk" [18:48:26] MtDu_: I ran the dpkg -i command ..is their anything else needed to run? [18:48:38] 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata, 07Easy, and 2 others: Unhelpful error message on Special:MergeItems if items are already merged - https://phabricator.wikimedia.org/T130642#2835810 (10FilipGCI) a:03FilipGCI I'll make it for GCI [18:48:41] MtDu_* [18:48:51] (03Merged) 10jenkins-bot: Tests: Explain the second assert in the test [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324429 (owner: 10Jhernandez) [18:48:54] (03Merged) 10jenkins-bot: Hygiene: Only use that when necessary. Else use this [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324430 (owner: 10Jhernandez) [18:48:59] (03Merged) 10jenkins-bot: Hygiene: #processLinks Only use global variables at the edges [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324431 (owner: 10Jhernandez) [18:49:02] (03Merged) 10jenkins-bot: Hygiene: #processLinks Improve wording on tests [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324432 (owner: 10Jhernandez) [18:49:05] (03Merged) 10jenkins-bot: Hygiene: #nextState explain why we iterate keys to copy [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324433 (owner: 10Jhernandez) [18:49:21] I have one more question [18:49:53] MtDu_: here's an example https://github.com/wikimedia/mediawiki/commit/3c9b4b1eb13e072f2216facc424e400d3bfdde1b I passed the LinkRenderer from the specialpage into the pager class [18:50:11] (03PS1) 10Niharika29: Change link from external cross-wiki contribs tool to centralauth [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/324529 (https://phabricator.wikimedia.org/T151380) [18:50:25] Sorry to interrupt you, but i couldn't figure what you guys are talking about [18:50:29] 04(no projects): remove/fix "Check for gridmaster host resolution" Icinga check for "labtest" - https://phabricator.wikimedia.org/T152024#2835820 (10Dzahn) [18:51:53] ARChak: don't worry. This is just a platform to discuss issues each person is working on and to collaborate. Everyone is usually working on something different. :) [18:52:24] p_d: I'm not sure for Linux/Ubuntu. Refer to google would be what I'd do. [18:52:28] 10MediaWiki-Uploading, 10MediaWiki-extension-requests, 06Multimedia, 07Need-volunteer: Handle PSD format - https://phabricator.wikimedia.org/T145208#2835836 (10MarkTraceur) p:05Triage>03Low While I agree that "lowest" may not be indicated, while we are blocked on unanswered questions about the viabilit... [18:52:52] 06Discovery, 06Reading-Web-Backlog, 07Browser-Support-Apple-Safari: Safari search results add racist title to Wikipedia article - https://phabricator.wikimedia.org/T150541#2835841 (10JMinor) Yeah, this is purely Apple's issue, though an end user wouldn't know it :( Our best bet is to point as many people at... [18:52:54] @MtDu_ I got it :) [18:53:04] MtDu_ : hmm [18:54:21] (03CR) 10Niedzielski: [C: 04-1] "One last question about edit.png inline" (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321802 (https://phabricator.wikimedia.org/T148202) (owner: 10Mholloway) [18:54:28] 10MediaWiki-File-management, 06Commons, 06Multimedia: Cannot display image; no thumbnails generated: HTTP 500 with unknown-error - https://phabricator.wikimedia.org/T144680#2835844 (10MarkTraceur) Just so you know, the Multimedia team isn't currently well-equipped to handle problems with the thumbnailing sys... [18:58:31] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2835851 (10Nirzar) thanks @phuedx looking sharp! [18:59:22] 10UI-Standardization: Align mediawiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2835852 (10Ladsgroup) [18:59:30] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835865 (10Dzahn) Thanks, this sounds like it ``` storage.local-disk.path: Set to some writable directory on local disk. Make that directory. ``` We could simply use /srv/tmp because there we have h... [19:00:16] 10UI-Standardization: Align mediawiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2835870 (10Ladsgroup) [19:00:34] (03CR) 10jenkins-bot: [V: 04-1] 'goodfaith' filter on Special:RC / Special:Watchlist [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) (owner: 10Sbisson) [19:00:51] 06Reading-Web-Backlog, 06Research-and-Data, 03Reading-Web-Sprint-87-: QuickSurvey for reader segmentation research - run multiple choice survey in more langugaes - https://phabricator.wikimedia.org/T151835#2829433 (10Ravidreams) Hi @atgo If you would like to have a language from India because of the ongoin... [19:01:05] (03PS1) 10Cicalese: Fixed OOjs dependency to work with MW 1.26. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324533 [19:01:15] (03CR) 10jenkins-bot: [V: 04-1] 'damaging' filter on Special:RC / Special:Watchlist [extensions/ORES] - 10https://gerrit.wikimedia.org/r/324507 (https://phabricator.wikimedia.org/T149734) (owner: 10Sbisson) [19:01:52] (03PS1) 10Ladsgroup: Almost invisible change on UI colors to align with Wikimedia color palette [core] - 10https://gerrit.wikimedia.org/r/324534 (https://phabricator.wikimedia.org/T152025) [19:02:45] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835893 (10Dzahn) Of course there should be some cleanup but we also don't have to make it hard on us by limiting ourselves to this tiny 10G / where you are constantly fighting to keep the remaining 2G fr... [19:02:49] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Request OIT/admin to include more details in gcal room descriptions - https://phabricator.wikimedia.org/T150979#2835894 (10MBinder_WMF) p:05Triage>03Low [19:03:23] (03PS2) 10Fjalapeno: Extend survey through December and update Privacy Policy [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) [19:04:03] (03CR) 10Cicalese: [C: 032 V: 032] Fixed OOjs dependency to work with MW 1.26. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/324533 (owner: 10Cicalese) [19:04:39] (03CR) 10Fjalapeno: "Thanks Bernd - I also updated the Privacy policy for Josh" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [19:04:50] (03Merged) 10jenkins-bot: mediawiki.language: fix convertNumber( ..., true ) [core] - 10https://gerrit.wikimedia.org/r/324387 (https://phabricator.wikimedia.org/T151198) (owner: 10Nikerabbit) [19:04:58] 04(no projects): RecentChanges - https://phabricator.wikimedia.org/T152027#2835901 (10Tunglinwu) [19:05:45] 04(no projects): RecentChanges - https://phabricator.wikimedia.org/T152027#2835912 (10Aklapper) Hi @Tunglinwu, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce the problem, please [[ https://www.mediawiki.org/wiki/How_to_report... [19:06:00] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2835913 (10AlexMonk-WMF) I did some digging and found https://gerrit.wikimedia.org/r/#/c/323090/2 pr... [19:06:47] (03PS1) 10Esanders: Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/Cite] - 10https://gerrit.wikimedia.org/r/324536 [19:08:33] (03Abandoned) 10Raimond Spekking: Consistency tweaks in preparation for translatewiki.net [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/322867 (owner: 10Raimond Spekking) [19:09:29] (03CR) 10Phuedx: [C: 04-1] "There needs to be a guard against the previous state having an active link but the link has already had its title scrubbed." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324460 (owner: 10Phuedx) [19:10:49] (03Merged) 10jenkins-bot: Throw an exception if password hash would be truncated by DB [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [19:13:31] (03CR) 10Aaron Schulz: [C: 032] Fix PHP notice 'Only variables should be assigned by reference' [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324515 (https://phabricator.wikimedia.org/T152020) (owner: 10Seb35) [19:13:49] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2835919 (10Piramidion) I thank all of you for devoting your time and efforts to resolving this issue... [19:14:41] (03CR) 10jenkins-bot: [V: 04-1] Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/Cite] - 10https://gerrit.wikimedia.org/r/324536 (owner: 10Esanders) [19:14:43] (03Merged) 10jenkins-bot: Fix PHP notice 'Only variables should be assigned by reference' [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/324515 (https://phabricator.wikimedia.org/T152020) (owner: 10Seb35) [19:15:10] 04(no projects): Top days / top hours widget - https://phabricator.wikimedia.org/T152028#2835921 (10Ejegg) [19:15:57] 05Security: Password recovery blocked from the WMF office - https://phabricator.wikimedia.org/T151966#2833615 (10Krenair) The user account policy requires staff accounts to have various things, it's somewhat pointless if staff can just make paid edits while logged out (as a few people appeared to be doing) [19:16:15] 04(no projects): RecentChanges - https://phabricator.wikimedia.org/T152027#2835936 (10Tunglinwu) When I edit any page, the page's history will recode my edit, but Special:RecentChanges page not recode it. [19:17:21] (03CR) 10Jforrester: "Presumably this was added for a reason… Avoiding redirect categories, probably." [core] - 10https://gerrit.wikimedia.org/r/324486 (https://phabricator.wikimedia.org/T12915) (owner: 10Bartosz Dziewoński) [19:17:38] (03PS1) 10Mholloway: Add linting for /etc and non-template-provided /test directories [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324538 [19:18:15] 04(no projects): RecentChanges - https://phabricator.wikimedia.org/T152027#2835938 (10Aklapper) Which MediaWiki version is this about? Can this problem be seen on some public wiki site? Any link? :) [19:18:29] (03CR) 10Bartosz Dziewoński: "It was added because we used to never remove categories from the 'category' table, even when they got emptied of files and deleted. But we" [core] - 10https://gerrit.wikimedia.org/r/324486 (https://phabricator.wikimedia.org/T12915) (owner: 10Bartosz Dziewoński) [19:18:36] (03CR) 10Jforrester: [C: 032] ImageHistoryPseudoPager: Only display 10 revisions at once by default [core] - 10https://gerrit.wikimedia.org/r/323547 (owner: 10Bartosz Dziewoński) [19:19:55] legoktm, there is $options parameter in Linker::link, but there isn't in the makeLink() method, should it just be removed? [19:20:26] (03CR) 10Mholloway: "@Bernd, I'll update the commit message." (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324005 (owner: 10Mholloway) [19:21:21] (03CR) 10Aftab: [C: 031] $specialPageAliases for Bengali (bn) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/324405 (https://phabricator.wikimedia.org/T151927) (owner: 10MarcoAurelio) [19:22:20] (03CR) 10Jforrester: [C: 032] "You convinced me. :-)" [core] - 10https://gerrit.wikimedia.org/r/324486 (https://phabricator.wikimedia.org/T12915) (owner: 10Bartosz Dziewoński) [19:22:29] (03PS1) 10Ladsgroup: Use darker shade of yellow [extensions/ORES] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324541 [19:23:01] 10MediaWiki-Categories, 07Tracking: Things that could use a category table (tracking) - https://phabricator.wikimedia.org/T15326#2835958 (10Jdforrester-WMF) [19:23:04] 10MediaWiki-Special-pages, 07User-notice: Don't hide categories with 0 current members from Special:Categories - https://phabricator.wikimedia.org/T12915#2835955 (10Jdforrester-WMF) 05Open>03Resolved [19:23:26] 10MediaWiki-ContentHandler, 10MediaWiki-extensions-General-or-Unknown, 03Google-Code-In-2016, 07Technical-Debt: Cleanup ContentHandler deprecated function calls in other Extensions - https://phabricator.wikimedia.org/T151973#2835959 (10Aklapper) @Reedy: If you kill the false positives, I could create the G... [19:25:21] 04(no projects): RecentChanges - https://phabricator.wikimedia.org/T152027#2835962 (10Tunglinwu) MW version is 1.28.0. Site: http://wiki.llsif.moe/ RecentChanges can't record any information. [19:25:36] (03PS9) 10Mholloway: Fix eslint errors [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324005 [19:25:39] 10MediaWiki-extensions-CentralAuth, 03Community-Tech-Sprint, 13Patch-For-Review: Fully populate local_user_id and global_user_id fields in production - https://phabricator.wikimedia.org/T148242#2835963 (10Niharika) The script ran up until labswiki and errored out. It won't restart. Here's the last few lines:... [19:26:30] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835964 (10fgiunchedi) @mmodell tmpfs won't help because it doesn't clean up old files by itself. @dzahn @Paladox yeah that might help if it actually gets honoured. My thought on that was that if all phab... [19:26:42] (03PS2) 10Mholloway: Add linting for /etc and non-template-provided /test directories [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324538 [19:27:27] Oh, I guess if 'known' is passed in $options[] it should be done as makeKnownLink? legoktm [19:27:27] (03Merged) 10jenkins-bot: ImageHistoryPseudoPager: Only display 10 revisions at once by default [core] - 10https://gerrit.wikimedia.org/r/323547 (owner: 10Bartosz Dziewoński) [19:28:13] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2835971 (10Paladox) @fgiunchedi hi, looking at it more it says we should be using MySQL by default so we may have a bug in that since it should not have set a local disk path as I see no setting has been s... [19:29:13] halfak, saw PR 180 to revert. I can catch the celery exception in lookup maps (and others that use .get), normalize and log, if that's the way you'd like to implement this. [19:29:53] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/ORES] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324541 (owner: 10Ladsgroup) [19:30:46] (03CR) 10Phuedx: "See If0c16afd6ca1c44f0e7eed497f62f0190005a619." [extensions/Popups] (mpga) - 10https://gerrit.wikimedia.org/r/324517 (owner: 10Jhernandez) [19:31:21] (03CR) 10Gergő Tisza: Low severity security-ish issues in CentralAuth special pages (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/319055 (https://phabricator.wikimedia.org/T134931) (owner: 10Brian Wolff) [19:31:36] (03PS4) 10Nuria: Consolidate docs on README [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/324277 (https://phabricator.wikimedia.org/T145099) [19:32:10] +^ oh only one occurence other than _process_missing_scores() really. [19:32:24] (03Merged) 10jenkins-bot: CategoryPager: Allow categories with no members to be shown [core] - 10https://gerrit.wikimedia.org/r/324486 (https://phabricator.wikimedia.org/T12915) (owner: 10Bartosz Dziewoński) [19:32:29] (03Merged) 10jenkins-bot: Use darker shade of yellow [extensions/ORES] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324541 (owner: 10Ladsgroup) [19:32:59] (03Abandoned) 10Mholloway: Hygiene: Remove .travis.yml [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324341 (owner: 10Mholloway) [19:33:57] Bye fellas [19:38:31] Florian, what can $options[] inside Linker:link method contaion except 'known'(which I guess means that method should be converted into makeKnownLink?)? [19:38:47] (03CR) 10Tjones: [C: 04-1] "Also, I've noticed a new corner case with the min length, so I'm going to retest and upload a new patch soonish." (031 comment) [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/323998 (https://phabricator.wikimedia.org/T149318) (owner: 10Tjones) [19:41:25] Well, found what it can contain, but what about managing $options[] parameter in Linker.php and DummyLinker.php? [19:41:33] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 10Wikidata, and 2 others: WikidataPageBanner when using page images generated API renders badly cropped images - https://phabricator.wikimedia.org/T131424#2836042 (10divadsn) I will work to fix it in the next 2 days as a Google Code-in student. As far as I... [19:41:35] Should it just be removed? [19:42:17] FlorianSW, ^^^ [19:42:23] Hello Georggi ! [19:42:34] Hi Nemo_bis! Nice to see you. [19:43:22] Georggi: what exactly do you mean with "managing $options[] parameter in Linker.php"? :/ [19:44:11] in Link() method there is $options[] parameter but in makeLink or makeKnownLink there isn't [19:45:16] Georggi: the options it can take should have their own functions in Linker (e.g. the "known" option has makeKnownLink()) :) [19:45:37] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: limit min input length for TextCat - https://phabricator.wikimedia.org/T149318#2836058 (10TJones) I found another corner case I hadn't considered before: if the string is made up entirely of non-word characters (like a numb... [19:45:41] So the question is what to do with it in places where it occurs. [19:46:27] what do you mean with occur? :D Have you a specific example? :) [19:46:48] Reconnected I guess [19:47:27] (03CR) 10Jforrester: [C: 032] Almost invisible change on UI colors to align with Wikimedia color palette [core] - 10https://gerrit.wikimedia.org/r/324534 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [19:47:33] Georggi: what do you mean with occur? :D Have you a specific example? :) [19:47:44] (03PS2) 10Jforrester: Almost invisible change on UI colors to align with Wikimedia color palette [core] - 10https://gerrit.wikimedia.org/r/324534 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [19:48:06] (03CR) 10Jforrester: [C: 032] Almost invisible change on UI colors to align with Wikimedia color palette [core] - 10https://gerrit.wikimedia.org/r/324534 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [19:49:29] Here https://dpaste.de/GTU9 there is $options parameter(it's 5th), but in makeLink() it is not present [19:49:34] legoktm is too fast for me with merging patches and accepting work of GCI students :P [19:49:48] So just what I should convert it into. [19:50:10] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 10Wikidata, and 2 others: WikidataPageBanner when using page images generated API renders badly cropped images - https://phabricator.wikimedia.org/T131424#2836098 (10Jdlrobson) Hi @divadsn - to be more specific any images where the width of the image is le... [19:50:13] (03PS1) 10Bartosz Dziewoński: DatabaseUpdater: Stop inserting junk into 'updatelog' every time the updater runs [core] - 10https://gerrit.wikimedia.org/r/324544 [19:50:22] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2836099 (10Piramidion) I have checked several pages from the list P4542 and it seems that most of th... [19:51:02] Georggi: it depends on what the $options array conatins. If it's an empty array you can safely omit it. Otherwise you would need to find replacements in the LinkRenderer :) [19:51:16] (03CR) 10Jdlrobson: "@Harjotsingh please let me know if anything about my suggestion is unclear and needs further work. I'd be much happier merging this with t" [core] - 10https://gerrit.wikimedia.org/r/320612 (https://phabricator.wikimedia.org/T114883) (owner: 10Harjotsingh) [19:51:58] FlorianSW: it's ok. He did it when I was sleeping so andre had to accept the task. :) [19:53:21] FlorianSW: long day today? [19:53:35] Well, if I get it right, it should be makeKnownLink if known is in array, but [19:53:50] MtDu_: yes, and we'd a christmas party from my company today, that's why I'm online just now :) [19:54:05] Georggi: if known is the only option, yes :) [19:55:17] There are places where it's not set and it has an empty array by default, but I guess can pass something else too? This is what manages $options in link() https://dpaste.de/jVDN [19:55:30] I wouldn't like to put it everywhere, right?:) [19:55:55] 10Wikimedia-Interwiki-links: Links to other language Wikipedias not displaying - https://phabricator.wikimedia.org/T151892#2836102 (10Iadmc) Thanks for the explanation. That makes sense. Cheers [19:56:26] (03CR) 10Florianschmidtwelzow: [C: 032] "I think the user shouldn't be uninformed why he has to do something. So, a warning message with a imporveable UI is better as no informati" [core] - 10https://gerrit.wikimedia.org/r/323786 (https://phabricator.wikimedia.org/T141474) (owner: 10Gergő Tisza) [19:57:29] 10MediaWiki-Unit-tests: duplicate key in unittest_updatelog - https://phabricator.wikimedia.org/T73087#2836104 (10matmarex) 05Open>03Resolved (Fixed long ago.) [19:57:51] (03Merged) 10jenkins-bot: Almost invisible change on UI colors to align with Wikimedia color palette [core] - 10https://gerrit.wikimedia.org/r/324534 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [19:57:56] (03CR) 10jenkins-bot: [V: 04-1] DatabaseUpdater: Stop inserting junk into 'updatelog' every time the updater runs [core] - 10https://gerrit.wikimedia.org/r/324544 (owner: 10Bartosz Dziewoński) [19:58:17] Georggi: I'm not sure if I understand your question corectly :) Are you working on a specific task? Normally you should replace only things that are actually used. So, if the $options array contains a known, use makeKnownLink(), otherwise use makeLink(); if it contains broken, use makeBrokenLink() and so on :) [19:59:22] 06Discovery, 06Discovery-Search (Current work): Cross-wiki search results: making sure the results are relevant from sister projects - https://phabricator.wikimedia.org/T151935#2836126 (10TJones) I stumbled upon an interesting example of low value result today on Italian WP. Searching for //[[ https://it.wikip... [19:59:52] (03CR) 10Gergő Tisza: Fix MediaTransformError message handling (032 comments) [core] - 10https://gerrit.wikimedia.org/r/321405 (owner: 10Anomie) [20:00:11] Ok, actually there are options specified for most of them. I gonna change them and if anything unknown left say you. [20:00:45] (03PS2) 10Bartosz Dziewoński: DatabaseUpdater: Stop inserting junk into 'updatelog' every time the updater runs [core] - 10https://gerrit.wikimedia.org/r/324544 [20:01:02] FlorianSW: Does your country celebrate Christmas earlier? [20:01:25] Oh, by the way, if that array contains both known and noclasses, should I just use makeKnown? [20:01:49] MtDu_: nope, it's common to have a christmas party with the colleagues way more early as with the closer family :) So you've the opportunity to have a good time with your colleagues and a nice christmas time with your family :) [20:02:12] (03CR) 10Gergő Tisza: "Although they will still be uninformed if the reauthentication requires any interaction on the remote site. I don't think we can do much a" [core] - 10https://gerrit.wikimedia.org/r/323786 (https://phabricator.wikimedia.org/T141474) (owner: 10Gergő Tisza) [20:02:48] Hi :D [20:03:21] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 10Wikidata, and 2 others: WikidataPageBanner when using page images generated API renders badly cropped images - https://phabricator.wikimedia.org/T131424#2836147 (10divadsn) @Jdlrobson Thank you for the clarification, now I will setup my dev environment.... [20:03:41] addshore: did you see my comment about rollbackAtomicSection()? Even with 'flush' it still encourages the same problem. [20:03:44] Actually, noclasses there is not even ever used, as known is checked earlier in 'if' statement [20:04:31] I'm doing GCI, and know a little bit about MediaWiki and a bit more about PHP, but would like to help out in any way I can ^.^ [20:04:32] picapi_: hello! Is it your first time here? [20:04:41] addshore: also, what's wrong with just using $dbw = x->getWriteConnection(); $dbw->startAtomic( __METHOD__ )... ? [20:04:50] picapi_: Awesome! Welcome. :) [20:05:00] 10MediaWiki-Interface, 07CSS: Pages often have reflows due to jquery.makeCollapsible collapsible content - https://phabricator.wikimedia.org/T152011#2835184 (10matmarex) Duplicate of T42812? Or not? Please beware, because jquery.makeCollapsible is unreasonably flexible, and it would really suck if we accident... [20:05:07] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 10Wikidata, and 2 others: WikidataPageBanner when using page images generated API renders badly cropped images - https://phabricator.wikimedia.org/T131424#2836158 (10Sumit) >>! In T131424#2836147, @divadsn wrote: > @Jdlrobson Thank you for the clarificatio... [20:05:23] FlorianSW: that's pretty awesome. :) [20:06:04] Maybe I should turn finding and fixing message escaping errors into a gci task [20:06:11] Georggi: you should use makePreloadedLink and use LinkRenderer::getLinkClasses() to get the value for the classes parameter. This is a merged way of using makeKnownLink and noclasses. However, merging noclasses and known sounds a bit strange, you probably can use noclasses only :P [20:06:13] (03CR) 10Filippo Giunchedi: "Removing myself, no idea how to give relevant input on this :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/324405 (https://phabricator.wikimedia.org/T151927) (owner: 10MarcoAurelio) [20:06:22] (03CR) 10Filippo Giunchedi: "Removing myself, no idea how to give relevant input on this :)" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/323888 (owner: 10Aftab) [20:06:27] thats probably the right amount of scope [20:06:42] Whew, done with all my assignments for the week. Time to actually make some tasks [20:06:45] bawolff: sounds like a good idea, in this way, GCI students would learn about i18n, html escape and the MediaWiki infra :) [20:07:09] (03CR) 10Bmansurov: Hovering over links in menu should change icons to blue (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) (owner: 10Jdlrobson) [20:07:17] 10MediaWiki-Vagrant, 06Reading-Web-Backlog: Add vagrant roles for reading services - https://phabricator.wikimedia.org/T152036#2836160 (10Jdlrobson) [20:07:34] and also there's probably more than enough examples to go around [20:07:36] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 10Wikidata, and 2 others: WikidataPageBanner when using page images generated API renders badly cropped images - https://phabricator.wikimedia.org/T131424#2836174 (10Jdlrobson) [[ https://www.mediawiki.org/wiki/MediaWiki-Vagrant | Vagrant ]] should be fine... [20:07:46] (03CR) 10BearND: [C: 032] "Starting to get patches ready for deployment. If we need to extend the Android survey campaign we can do so later as well." [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [20:08:46] Ok, thanks FlorianSW, at last, how should I test if it works before commiting it? [20:08:55] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2836177 (10Tchanders) Yes indeed - thanks for pointing that out. It was a problem with any gallery w... [20:09:05] (03CR) 10Jdlrobson: [C: 04-1] MobileFrontend.alias for Bengali (bn) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [20:09:11] Georggi: make the change and see, if the link looks like it looked before :) [20:09:49] (03Merged) 10jenkins-bot: Extend survey through December and update Privacy Policy [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324506 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [20:10:05] 10MediaWiki-Special-pages, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4), and 2 others: SpecialUserrights: fetchUser() called with wrong parameters - https://phabricator.wikimedia.org/T151961#2836194 (10demon) 05Open>03Resolved [20:10:34] (03PS1) 10Aaron Schulz: Remove rollbackAtomicSection() method [core] - 10https://gerrit.wikimedia.org/r/324547 [20:10:49] tonythomas: did you see my comment? [20:10:55] (03CR) 10Ottomata: [C: 032] Consolidate docs on README [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/324277 (https://phabricator.wikimedia.org/T145099) (owner: 10Nuria) [20:11:06] MtDu_: nope. Can you share a link ? [20:11:41] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 03Fundraising Sprint Waiting for Godot, 07Unplanned-Sprint-Work: Determine impact of mobile CSS changes - https://phabricator.wikimedia.org/T151815#2828861 (10awight) **Desktop** | banner | donations / clicks | | B1617_1121_en6C_dsk_p1_lg_txt... [20:12:00] (03CR) 10Chad: [C: 031] "The self::$updateCounter logic can be removed as well." [core] - 10https://gerrit.wikimedia.org/r/324544 (owner: 10Bartosz Dziewoński) [20:12:41] (03CR) 10Chad: "Er, rather, the declaring of it." [core] - 10https://gerrit.wikimedia.org/r/324544 (owner: 10Bartosz Dziewoński) [20:12:45] (03CR) 10Niedzielski: [C: 04-1] "The diff script only works when it has something to diff and be mindful of T150272. I think you might be hitting T150271? The latter is th" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322776 (https://phabricator.wikimedia.org/T148202) (owner: 10Mholloway) [20:13:39] (03PS3) 10Bartosz Dziewoński: DatabaseUpdater: Stop inserting junk into 'updatelog' every time the updater runs [core] - 10https://gerrit.wikimedia.org/r/324544 [20:13:44] (03CR) 10Bartosz Dziewoński: "Thanks, done." [core] - 10https://gerrit.wikimedia.org/r/324544 (owner: 10Bartosz Dziewoński) [20:14:05] 10MediaWiki-extensions-CentralAuth, 03Community-Tech-Sprint, 13Patch-For-Review: Fully populate local_user_id and global_user_id fields in production - https://phabricator.wikimedia.org/T148242#2836203 (10bd808) >>! In T148242#2835963, @Niharika wrote: > The script ran up until labswiki and errored out. It w... [20:15:17] tonythomas: I fixed another return URL. https://gerrit.wikimedia.org/r/324490 also claimed it. :) [20:15:27] 10Phabricator, 06Operations: iridium / filesystem almost full - https://phabricator.wikimedia.org/T150396#2836208 (10Dzahn) Adding the cron with a "find" to delete older files won't be hard, but _how_ old is old enough to delete? [20:15:48] (03CR) 10Aaron Schulz: [C: 032] DatabaseUpdater: Stop inserting junk into 'updatelog' every time the updater runs [core] - 10https://gerrit.wikimedia.org/r/324544 (owner: 10Bartosz Dziewoński) [20:15:50] MtDu_: checking now [20:16:05] tonythomas: thanks. I'll submit once its merged. :) [20:16:38] (03CR) 10Niedzielski: [C: 032] Hygiene: Consolidate news classes in org.wikipedia.feed.news (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323266 (owner: 10Mholloway) [20:17:12] (03CR) 10Aaron Schulz: "Merge conflict" [core] - 10https://gerrit.wikimedia.org/r/318658 (owner: 10Gergő Tisza) [20:17:18] (03PS2) 10Jdlrobson: Hovering over links in menu should change icons to blue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) [20:17:23] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Developer Summit 2017 Closing - https://phabricator.wikimedia.org/T151492#2836217 (10Rfarrand) The room will not be set up in the same way (to fit everyone inside of it in a seat) because the main room will be turned into a hacking spac... [20:17:26] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Spike: CentralNotice: Evaluate supressing banners for logged-out users who previously logged in - https://phabricator.wikimedia.org/T152038#2836218 (10AndyRussG) [20:17:29] (03CR) 10Jdlrobson: Hovering over links in menu should change icons to blue (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) (owner: 10Jdlrobson) [20:17:31] (03CR) 10jenkins-bot: [V: 04-1] Remove rollbackAtomicSection() method [core] - 10https://gerrit.wikimedia.org/r/324547 (owner: 10Aaron Schulz) [20:17:45] (03CR) 10Bmansurov: [C: 031] Overhaul navigation drawer to better focus on navigation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [20:18:50] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Spike: CentralNotice: Evaluate supressing banners for logged-out users who previously logged in - https://phabricator.wikimedia.org/T152038#2836218 (10Ejegg) Never mind my suggestion about using the enwikiUserName cookie - it's http-only [20:18:53] (03CR) 1001tonythomas: [C: 032] Change Return-To URL in Special:Newsletter/xx/delete to 'Return to Newsletter:Foo' instead of 'Return to Special:Newsletter/1' - Part of mi [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324490 (https://phabricator.wikimedia.org/T150123) (owner: 10MtDu) [20:19:09] MtDu_: merged. but it do not have a GCI task associated with it ? [20:19:15] It dies [20:19:20] Does [20:19:23] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2836233 (10Deskana) >>! In T151660#2835919, @Piramidion wrote: > @EBernhardson can you please do the... [20:19:56] tonythomas: want me to submit? [20:20:00] I see that. [20:20:23] let me see the status of it [20:20:33] once it gets merged, please submit - yes [20:21:02] (03CR) 10Bmansurov: Hovering over links in menu should change icons to blue (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) (owner: 10Jdlrobson) [20:21:31] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: Selecting "More parameters" in the CX template editor adds a field called "More parameters" instead of showing more parameters - https://phabricator.wikimedia.org/T152039#2836238 (10Amire80) [20:21:33] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2836237 (10Nirzar) @Jdlrobson @Volker_E following points needs fixing - The icons look pure black by default. Can we use B20... [20:21:45] tonythomas: done. :) [20:21:52] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Create config more intuitive aliases for filetype: search - https://phabricator.wikimedia.org/T150887#2836250 (10Smalyshev) p:05Triage>03Normal [20:22:10] neat. let me close it down [20:23:06] god, the gci website is so slow right now :-( [20:23:44] tonythomas: will you be around? I can fix that French thing. [20:23:48] Uhh, MtDu_ are you sure that it's makeLink() there https://gerrit.wikimedia.org/r/#/c/324355/3/includes/specials/SpecialBrokenRedirects.php on line 139? [20:24:24] MtDu_: sorry. I got no idea aabout the french thing. Also, I got an assignment deadlien tomrrow :-( would be unavialable for another 12 hours or so! [20:24:31] maybe more :-( [20:24:34] 'broken' is passed in options, so I guess it should be makeBrokenLink, no? [20:24:51] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2836258 (10EBernhardson) I re-ran the query and added highlights this time, indeed Спеціальна:Журнал... [20:25:13] tonythomas: that's alright. Good luck in your assignment. I'll find something else to do. :) [20:25:32] In fact, as I said before, makeLink has only 4 parameters, so that ['broken'] is ignored. [20:26:50] (03Merged) 10jenkins-bot: DatabaseUpdater: Stop inserting junk into 'updatelog' every time the updater runs [core] - 10https://gerrit.wikimedia.org/r/324544 (owner: 10Bartosz Dziewoński) [20:26:53] (03Merged) 10jenkins-bot: Hygiene: Consolidate news classes in org.wikipedia.feed.news [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323266 (owner: 10Mholloway) [20:26:55] (03Merged) 10jenkins-bot: Change Return-To URL in Special:Newsletter/xx/delete to 'Return to Newsletter:Foo' instead of 'Return to Special:Newsletter/1' - Part of migration to ContentHandler [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324490 (https://phabricator.wikimedia.org/T150123) (owner: 10MtDu) [20:27:20] (03CR) 1001tonythomas: "Can you give that a try ?" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) (owner: 10Phantom42) [20:27:21] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2836261 (10EBernhardson) Also i could certainly come up with something similar for magic words, but... [20:28:01] (03CR) 10Sbisson: "recheck" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/323328 (https://phabricator.wikimedia.org/T149853) (owner: 10Sbisson) [20:28:17] 06Editing-Analysis: Refine definition of active editors metric - https://phabricator.wikimedia.org/T151507#2836262 (10Neil_P._Quinn_WMF) @leila, @ezachte, and I just met on this, and we agreed how to resolve most of the inconsistencies. **Action items**: * I will document our consensus on Meta. * I will change... [20:29:09] MtDu_: Thank you! [20:30:25] 04(no projects): Create a "query demo" tool in labs - https://phabricator.wikimedia.org/T152040#2836263 (10TJones) [20:31:05] (03CR) 10Phantom42: "Hm. You are right.That could be done simplier." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) (owner: 10Phantom42) [20:31:19] 06Editing-Analysis: Refine definition of active editors metric - https://phabricator.wikimedia.org/T151507#2836274 (10leila) @Neil_P._Quinn_WMF thanks for documenting it and your help. Just a note that we agreed to run the final proposal re the updated metric by Dario before sending it out. I'll take care of th... [20:31:58] (03PS1) 10Ladsgroup: Align search result CSS with Wikimedia UI color palette [core] - 10https://gerrit.wikimedia.org/r/324549 (https://phabricator.wikimedia.org/T152025) [20:32:11] 10UI-Standardization, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Align mediawiki core UI elements with Wikimedia color palette - https://phabricator.wikimedia.org/T152025#2836276 (10Ladsgroup) [20:32:17] 06Editing-Analysis: Refine definition of active editors metric - https://phabricator.wikimedia.org/T151507#2836278 (10leila) [20:32:19] MtDu_, check my previous message please [20:32:54] (03PS6) 10Dbrant: Announcement data client. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322712 (https://phabricator.wikimedia.org/T151085) [20:33:30] (03CR) 10Gergő Tisza: "AbuseFilter would not help in that case as it acts on the username and that also uses XFF." [core] - 10https://gerrit.wikimedia.org/r/324214 (owner: 10Anomie) [20:34:13] (03PS6) 10Jdlrobson: Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) [20:37:07] FlorianSW: Going to make a GCI task, but I want to clarify the wording of this: https://phabricator.wikimedia.org/T34494. I assume it means that you can specify user IDs instead of usernames. Would you (or anyone else) agree? [20:38:04] (03CR) 10Dbrant: Announcement data client. (0317 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322712 (https://phabricator.wikimedia.org/T151085) (owner: 10Dbrant) [20:38:18] McIntireEvan: yes, it requests that user ids and usernames are possible as input values for the api :) [20:38:38] (03CR) 10jenkins-bot: [V: 04-1] Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) (owner: 10Jdlrobson) [20:39:43] Georggi: I will check later. Currently not near my machine. :) [20:39:51] Hello! I have a small question about gerrit. I have posted some change and after code review I want to fix something in my code. How shall I do that? Just create and push one more commit in that branch? [20:39:51] Sure [20:40:14] You should amend you previous commit and push it again [20:40:35] Woo, thanks. I'm going to clarify the bug some and make a GCI task :) [20:40:52] FlorianSW: I claimed the clarify messages on specialistgrant since it was related to the one I did earlier. [20:41:01] (03CR) 10Sbisson: "recheck" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/324507 (https://phabricator.wikimedia.org/T149734) (owner: 10Sbisson) [20:41:07] Georggi: thank you [20:41:48] FlorianSW: it proposes Identity verification only, no ability to act on a user's behalf but I think no API access is fine. I propose something like "user identity verification only, no API access". What do you think? [20:42:01] Phantom42: to clarify not a new commit in branch [20:42:11] Phantom42: however, you shouldn't create a new commit, if you want to push a new patchset for the existing gerrit change. Instead please amend it, like Georggi said :) [20:42:13] but amending the previous one [20:42:35] I.e. git commit --amend [20:42:37] Okay. I understood. Thank you [20:43:00] (03CR) 10Jforrester: "Leaving for Discovery to decide upon." [core] - 10https://gerrit.wikimedia.org/r/324549 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [20:43:14] MtDu_: do you've the phab task link? :D It's a bit difficult to remember the exact task, I just know that there was one :P [20:43:31] FlorianSW: yep. https://phabricator.wikimedia.org/T145354 [20:44:22] 07Design, 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media: "Add new image" button in gallery is difficult to discover after adding 4/5 images, since the button floats down as the list grows - https://phabricator.wikimedia.org/T151506#2836297 (10Tchanders) a:03Tchanders [20:45:05] (03CR) 10Niedzielski: [C: 031] Announcement data client. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322712 (https://phabricator.wikimedia.org/T151085) (owner: 10Dbrant) [20:45:23] MtDu_: ah, right, thanks! :) The purpose of the task is to get rid of the "no API access" part of the message, as "API" is way to generic, while the MediaWiki web API is meant :) So you should at least really get rid of this part :) [20:45:41] 10MediaWiki-API, 07Easy, 03Google-Code-In-2016: API: Ability to search by user id - https://phabricator.wikimedia.org/T34494#2836304 (10McIntireEvan) [20:45:52] 10MediaWiki-API, 07Easy, 03Google-Code-In-2016: API: Ability to search by user id - https://phabricator.wikimedia.org/T34494#367043 (10McIntireEvan) I will mentor this in #google-code-in-2016 [20:48:13] (03PS2) 10Phantom42: Fix wrong Return-To URL [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) [20:49:08] (03CR) 10Phantom42: "Fixed that" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/324442 (https://phabricator.wikimedia.org/T150097) (owner: 10Phantom42) [20:49:22] (03PS7) 10Jdlrobson: Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) [20:49:59] (03CR) 10Kghbln: "That's great Pavel!! I was not sure if you were around or not. Cool that you also tagged!" [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/323376 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [20:51:37] (03PS4) 10Jdlrobson: Edit stream should replay edits up to the maximum age [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323490 [20:51:42] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: a
is added to most parameter values in an infobox that CX template editor outputs - https://phabricator.wikimedia.org/T152041#2836318 (10Amire80) [20:52:07] FlorianSW, what does Linker::makeExternalLink convert into? [20:52:52] 10MediaWiki-extensions-ContentTranslation, 07WorkType-Maintenance: CX template editor starts the first paragraph's text immediately after the infobox - https://phabricator.wikimedia.org/T152042#2836332 (10Amire80) [20:54:36] Oh, I guess it's not deprecated, oh well [20:56:32] (03CR) 10Jdlrobson: Edit stream should replay edits up to the maximum age (031 comment) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323490 (owner: 10Jdlrobson) [20:56:39] (03Abandoned) 10Hashar: Sync repos [extensions] - 10https://gerrit.wikimedia.org/r/324026 (owner: 10Hashar) [20:56:44] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/324048 (owner: 10Hashar) [20:56:44] 06Discovery, 06Community-Liaisons (Oct-Dec-2016): Support Discovery Q2 Goal: Enable the backend for cross-project indices on all Wikimedia projects - https://phabricator.wikimedia.org/T147312#2836346 (10CKoerner_WMF) The message has been marked for translation and the astounding community of translators have b... [20:57:05] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 07Unplanned-Sprint-Work: Ingenico: stop calling SET_PAYMENT when GET_ORDERSTATUS returns 25 - https://phabricator.wikimedia.org/T151788#2836349 (10DStrine) [20:57:47] (03PS1) 10Raimond Spekking: Revert "Localisation updates from https://translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/324561 [20:59:12] (03PS6) 10Dbrant: Announcement cards in the feed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322782 (https://phabricator.wikimedia.org/T140012) [20:59:22] (03CR) 10Florianschmidtwelzow: [C: 032] Add path to unfold extra magic (git hashes, license info) [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/323129 (owner: 10Kghbln) [20:59:50] (03CR) 10Catrope: [C: 032] Echo.alias for Bengali (bn) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324491 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [21:00:49] (03Merged) 10jenkins-bot: Add path to unfold extra magic (git hashes, license info) [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/323129 (owner: 10Kghbln) [21:03:40] (03CR) 10Dbrant: Announcement cards in the feed. (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/322782 (https://phabricator.wikimedia.org/T140012) (owner: 10Dbrant) [21:04:54] (03CR) 10Kghbln: "Thanks a lot for being my Allzweckwaffe again! :)" [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/323129 (owner: 10Kghbln) [21:05:41] 10UI-Standardization, 06Revision-Scoring-As-A-Service, 10Wikilabels, 07Easy, 15User-Ladsgroup: Apply ui standardization color palette to Wikilabels - https://phabricator.wikimedia.org/T151119#2836398 (10Halfak) 05Open>03Resolved [21:05:44] 10MediaWiki-extensions-ORES, 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service: Post about ORES review tool including ERI filters - https://phabricator.wikimedia.org/T150858#2836400 (10Halfak) 05Open>03Resolved [21:05:45] 06Design-Research, 06Research-and-Data, 10Research-management: Research Staff "VC" special edition - https://phabricator.wikimedia.org/T150488#2836402 (10Halfak) [21:05:53] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review, 15User-Ladsgroup, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Add "Lowest" ORES sensitivity for fpr=0.1 - https://phabricator.wikimedia.org/T150224#2836405 (10Halfak) 05Open>03Resolved [21:05:56] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 07Accessibility, 13Patch-For-Review, and 5 others: Visually report damaging confidence - https://phabricator.wikimedia.org/T144922#2836406 (10Halfak) 05Open>03Resolved [21:08:36] (03Merged) 10jenkins-bot: Echo.alias for Bengali (bn) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/324491 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [21:10:30] (03PS15) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) [21:10:32] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836421 (10scfc) [21:10:33] (03PS13) 10EBernhardson: Cleanup execution flow through SpecialSearch::execute() [core] - 10https://gerrit.wikimedia.org/r/322013 (https://phabricator.wikimedia.org/T150393) [21:10:38] (03PS15) 10EBernhardson: Extract search form from SpecialSearch into widget [core] - 10https://gerrit.wikimedia.org/r/322014 (https://phabricator.wikimedia.org/T150390) [21:10:41] (03PS19) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) [21:11:42] 10UI-Standardization, 10Wikidata, 15User-Ladsgroup, 03Wikidata-Sprint-2016-11-15: Make Special:EntityUsage and Special:PagesWithBadges use OOUI - https://phabricator.wikimedia.org/T152046#2836440 (10Ladsgroup) [21:12:07] (03PS2) 10Gergő Tisza: Clean up http classes a bit [core] - 10https://gerrit.wikimedia.org/r/318658 [21:12:14] AaronSchulz: ^ [21:14:34] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2836459 (10Piramidion) @EBernhardson Thanks for the adjustment. I've checked them all, found only 10... [21:14:41] (03PS1) 10Smalyshev: Add Trey to authors [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/324563 [21:15:17] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2836460 (10AlexMonk-WMF) 05Open>03Resolved [21:16:56] (03CR) 10jenkins-bot: [V: 04-1] Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [21:20:40] 10MediaWiki-Internationalization, 06Community-Liaisons, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 4, and 3 others: Remove Russian fallback for Ukrainian language - https://phabricator.wikimedia.org/T39314#2836465 (10Piramidion) @thiemowmde Thanks for the info. Hope you're r... [21:21:38] (03CR) 10jenkins-bot: [V: 04-1] Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [21:21:59] (03PS4) 10Aftab: MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) [21:24:36] (03CR) 10Smalyshev: Allow specification of minimum length for classification (031 comment) [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/323998 (https://phabricator.wikimedia.org/T149318) (owner: 10Tjones) [21:28:14] (03PS2) 10Dbrant: Make the first edit pencil serve a dual purpose. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323314 (https://phabricator.wikimedia.org/T151468) [21:28:32] (03CR) 10jenkins-bot: [V: 04-1] Make the first edit pencil serve a dual purpose. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323314 (https://phabricator.wikimedia.org/T151468) (owner: 10Dbrant) [21:28:38] (03CR) 10Fomafix: [C: 04-1] Replace Linker::link() usage with LinkRenderer (0321 comments) [core] - 10https://gerrit.wikimedia.org/r/324221 (https://phabricator.wikimedia.org/T149346) (owner: 10Haikalizz) [21:29:09] (03PS5) 10Niedzielski: Hygiene: add tests for news sites [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323994 (https://phabricator.wikimedia.org/T148444) [21:29:11] (03PS4) 10Niedzielski: Update: move full headline selector into news-sites [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323085 (https://phabricator.wikimedia.org/T148444) [21:30:24] (03PS3) 10Dbrant: Make the first edit pencil serve a dual purpose. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323314 (https://phabricator.wikimedia.org/T151468) [21:30:49] (03PS6) 10Niedzielski: Hygiene: add tests for news sites [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323994 (https://phabricator.wikimedia.org/T148444) [21:32:17] (03CR) 10Aaron Schulz: Clean up http classes a bit (031 comment) [core] - 10https://gerrit.wikimedia.org/r/318658 (owner: 10Gergő Tisza) [21:32:34] FlorianSW: do you think "User identity verification only, no ability to act on a user's behalf" makes it clear enough? [21:33:55] (03PS1) 10Georggi199: Replace Linker::link() with LinkRenderer in includes directory [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) [21:34:01] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 07Browser-Support-Internet-Explorer: Improve the search experience for IE8 - https://phabricator.wikimedia.org/T142525#2836498 (10bmansurov) p:05Low>03Lowest There is a long way before Minverva is ready for desktop, let alone IE8. [21:35:00] Maybe even leave the identity part out. [21:36:02] tgr: left a comment about the callback [21:37:30] Is it me, or is gerrit down? [21:38:02] I guess if the libcurl wrapper is just C code, it probably just calls the zend methods for the callback and skips visibility permissions, maybe? [21:38:47] Works now, oh well... [21:39:23] MtDu_, feel free to review this one https://gerrit.wikimedia.org/r/#/c/324600/ :) [21:39:44] 10AbuseFilter, 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt: Rewrite mobile.abusefilter in OOJS UI and upstream to AbuseFilter extension. - https://phabricator.wikimedia.org/T110741#1585611 (10bmansurov) The task needs more information about the bigger plan and the reasoning to use OOJS-UI. [21:40:31] 07Design, 06Front-end-Standards-Group: WikiDev 16 working area: User interface presentation - https://phabricator.wikimedia.org/T119162#2836512 (10daniel) [21:40:33] 06ArchCom, 10ArchCom-RfC, 07RfC: WikiDev 16 working area: Collaboration - https://phabricator.wikimedia.org/T119030#2836514 (10daniel) [21:40:38] 06Reading-Admin: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#2836516 (10daniel) [21:40:40] 06ArchCom: WikiDev 16 working area: Content access and APIs - https://phabricator.wikimedia.org/T119029#2836515 (10daniel) [21:40:42] 06ArchCom, 10ArchCom-RfC, 07RfC: Transition WikiDev '16 working areas into working groups - https://phabricator.wikimedia.org/T124504#2836510 (10daniel) 05Open>03declined Got stale, we should talk about working groups in a more general context. [21:41:25] 10MediaWiki-extensions-ConfirmAccount, 07Easy, 13Patch-For-Review, 07Technical-Debt: Only variables should be assigned by reference in backend/ConfirmAccount.class.php - https://phabricator.wikimedia.org/T152020#2836519 (10Seb35) 05Open>03Resolved a:03Seb35 [21:41:46] Oh, and yes, FlorianSW and legoktm, when checking my change, please check parts with options, especially where they are passed from somewhere else, I think I did that right(and I don't see any broken links on devwiki, although I have only main page), but still. [21:42:47] (03CR) 10Tjones: [C: 032] "Hey, cool! Thanks!" [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/324563 (owner: 10Smalyshev) [21:43:04] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836521 (10Aklapper) Well, I don't find anything similar either when searching by language or using Google... Do you maybe still have a Pxxxx number in your mail inbox? [21:43:17] Georggi: will do :) [21:44:01] (03PS5) 10Jdlrobson: Edit stream should replay edits up to the maximum age [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323490 [21:44:06] (03CR) 10Mooeypoo: [C: 04-1] [WIP]Make mobile-friendly version of the Notifications page left nav (0311 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323348 (https://phabricator.wikimedia.org/T139525) (owner: 10Kmuthu) [21:44:09] (03Merged) 10jenkins-bot: Add Trey to authors [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/324563 (owner: 10Smalyshev) [21:45:33] 06Reading-Web-Backlog, 10Hovercards (2016-17-Q2-Goal), 13Patch-For-Review, 03Reading-Web-Sprint-86-🔪🦃: Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2836535 (10Nirzar) a:05Nirzar>03None [21:45:41] (03CR) 10Niedzielski: "Ok this is ready for review! :]" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323994 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [21:46:19] (03CR) 10Dbrant: Make the first edit pencil serve a dual purpose. (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323314 (https://phabricator.wikimedia.org/T151468) (owner: 10Dbrant) [21:46:32] Is there a place, like last year, where I can add my username, in order to be able to do 'recheck'? [21:46:56] (03CR) 10Jdlrobson: [C: 032] MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [21:47:13] (03CR) 10jenkins-bot: [V: 04-1] Replace Linker::link() with LinkRenderer in includes directory [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) (owner: 10Georggi199) [21:47:59] legoktm, ^ [21:48:04] you might know that one [21:48:11] I assumed everyone could recheck [21:48:24] (03PS1) 10Jdlrobson: Hygiene: Remove references to Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324602 [21:48:41] (03PS1) 10BearND: Revert "Update to service-template-node v0.5.0 (minus eslint)" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324603 [21:48:57] Georggi: you're already whitelisted [21:49:11] Oh, was that from last year? [21:49:39] Gonna fix some jenkins errors right now [21:50:08] 10MediaWiki-General-or-Unknown, 10ArchCom-RfC, 07ArchCom-Has-shepherd: [RfC] Deprecation policy for PHP code in MediaWiki - https://phabricator.wikimedia.org/T146965#2836542 (10Krinkle) a:03tstarling [21:51:36] (03CR) 10Mholloway: [C: 032] Revert "Update to service-template-node v0.5.0 (minus eslint)" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324603 (owner: 10BearND) [21:51:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove references to Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324602 (owner: 10Jdlrobson) [21:52:50] (03Merged) 10jenkins-bot: Revert "Update to service-template-node v0.5.0 (minus eslint)" [services/mobileapps] - 10https://gerrit.wikimedia.org/r/324603 (owner: 10BearND) [21:53:46] (03CR) 10VolkerE: [C: 031] Align search result CSS with Wikimedia UI color palette [core] - 10https://gerrit.wikimedia.org/r/324549 (https://phabricator.wikimedia.org/T152025) (owner: 10Ladsgroup) [21:54:13] 04(no projects): Host LanguageTool WikiCheck on on Tool Labs - https://phabricator.wikimedia.org/T152049#2836550 (10WTM) [21:55:46] (03CR) 10Legoktm: [C: 04-1] "See inline comments. Also in general, you should add a "use MediaWiki\MediaWikiServices;" line at the top of the file (see others for exam" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) (owner: 10Georggi199) [21:55:55] (03PS16) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) [21:55:58] (03PS20) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) [21:57:53] 04(no projects): Host LanguageTool WikiCheck on on Tool Labs - https://phabricator.wikimedia.org/T152049#2836563 (10Aklapper) @WTM: Please feel free to set it up on Tool labs - see https://wikitech.wikimedia.org/wiki/Help:Tool_Labs how you can do this. :) I'm not sure what is requested exactly in this task and... [21:58:02] tgr: Do you think "User identity verification only, no ability to act on a user's behalf" makes the message in https://phabricator.wikimedia.org/T145354 clear enough? Maybe even leave the identity. Let me know what you think. [21:58:41] 04(no projects): Host LanguageTool WikiCheck on on Tool Labs - https://phabricator.wikimedia.org/T152049#2836564 (10WTM) [21:59:13] (03CR) 10Raimond Spekking: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/324605 (owner: 10L10n-bot) [21:59:44] (03CR) 10jenkins-bot: [V: 04-1] MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [22:00:13] RFC meeting starting now in #wikimedia-office: Per-language URLs for multilingual wiki pages [22:00:25] (03CR) 10Jdlrobson: [C: 04-1] "Code looks good but after testing I found a few issues with the icons." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) (owner: 10Rudloff) [22:00:29] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences: Display a password strength bar - https://phabricator.wikimedia.org/T32574#356180 (10Anomie) I did a little poking at this today. It turns out not to be too hard to put zxcvbn in an extension and inject a field into AuthManager's HTMLForms to dis... [22:00:53] (03PS1) 10Mholloway: Update service-mobileapp-node to 14deac7 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/324607 [22:01:06] (03CR) 10Mholloway: [C: 032 V: 032] Update service-mobileapp-node to 14deac7 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/324607 (owner: 10Mholloway) [22:01:26] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search, 07Technical-Debt: [Epic] De-Spaghettify SpecialSearch class - https://phabricator.wikimedia.org/T150217#2836574 (10EBernhardson) [22:01:28] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 07Technical-Debt: Consider removing usage of SearchEngine::searchTitle from Special:Search - https://phabricator.wikimedia.org/T150392#2836572 (10EBernhardson) 05Open>03declined After doing a variety of other cleanups... [22:01:46] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836575 (10scfc) Unfortunately not without going through external backups. I had added (IIRC) @tstarling, @Krinkle, @bd808 and @valhallasw as subscribers to that paste, so maybe one of them can search more easily for the... [22:02:17] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836577 (10Aklapper) p:05Triage>03Lowest [22:03:08] (03CR) 10jenkins-bot: [V: 04-1] Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [22:03:12] legoktm, Well, I guess I will do includes/actions as part of this task too then. [22:03:30] Georggi: uh, I think you're better off sticking to special pages [22:03:46] the infrastructure for special pages is better and well tested [22:04:07] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: Extract search result rendering from SpecialSearch - https://phabricator.wikimedia.org/T150390#2836581 (10EBernhardson) This code should be ready to go now. I've tested it locally with both inline interwiki (t... [22:04:16] Well, ok. [22:04:26] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836583 (10valhallasw) Apparently it was a file: {F4257254} [22:04:42] 04(no projects): Host LanguageTool WikiCheck on on Tool Labs - https://phabricator.wikimedia.org/T152049#2836586 (10WTM) Just throw the idea to people who have more technical knowledge than I do. I am an ordinary Wikipedia editor, who will be happy to take advantage of useful tools. [22:05:18] @seen halfak [22:05:18] dargasia: I have never seen halfak [22:05:31] wat [22:05:35] o/ wm-bot [22:05:37] I'm here [22:05:51] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836587 (10bd808) I'm not seeing any pastes by @scfc in a search for pastes that have me as a subscriber. [22:06:05] (03CR) 10jenkins-bot: [V: 04-1] Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) (owner: 10EBernhardson) [22:06:22] Ha. Just wondering if you saw my msg about the correct way to catch the celery exception earlier [22:06:32] Basically should I do the same thing as process_lookup..()? [22:06:41] 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: Don't show special page aliases in Russian in the search suggestions on ukwiki - https://phabricator.wikimedia.org/T151660#2836588 (10Piramidion) @EBernhardson This is the list of magic words in Russian to search for: (#... [22:06:47] dargasia, I guess I didn't see it. [22:07:04] Not sure which task you're referring to since the logging one is done [22:07:07] (03CR) 10Jdlrobson: Add a webapp manifest (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/323654 (https://phabricator.wikimedia.org/T108878) (owner: 10Rudloff) [22:07:19] That one. But you've considered a revert [22:07:32] So I do want to fix it. Don't want you to clean up my mess [22:07:53] 10MediaWiki-extensions-Newsletter, 03Google-Code-In-2016, 13Patch-For-Review: Wrong Return-To URL in Special:Newsletter/xx/delete - https://phabricator.wikimedia.org/T150123#2836590 (10MtDu) 05Open>03Resolved [22:07:56] 06Discovery, 06Discovery-Search (Current work): Cross-wiki search results: making sure the results are relevant from sister projects - https://phabricator.wikimedia.org/T151935#2836591 (10Deskana) >>! In T151935#2832678, @TJones wrote: > **Edit:** After talking to David, I learned that 90th percentile scores p... [22:09:21] (03PS5) 10Jdlrobson: MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [22:09:22] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836594 (10Aklapper) 05Open>03Invalid Hah! Thanks everybody! Closing as invalid. [22:09:28] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2836596 (10srishakatux) reached out to @cmadeo for help with UX review. [22:09:36] (03CR) 10Jdlrobson: [C: 032] MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [22:09:38] (03CR) 10Niedzielski: Update: move full headline selector into news-sites (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323085 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [22:09:43] Halfak ^ [22:09:45] (03PS2) 10Georggi199: Replace Linker::link() with LinkRenderer in includes directory [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) [22:09:48] (03PS2) 10Jdlrobson: Hygiene: Remove references to Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324602 [22:10:08] (03PS1) 10Catrope: Don't use constants in Flow config [vagrant] - 10https://gerrit.wikimedia.org/r/324611 [22:10:35] dargasia, see https://github.com/wiki-ai/ores/pull/181 [22:10:35] Posted that for now, should I create separate commit for special pages or keep amending current one legoktm? [22:10:52] (03PS54) 10Catrope: Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:11:00] I think your contrib with obviously good and I was just being nit-picky so I took it upon myself to do a follow-up. [22:11:13] Georggi: lets do a separate change? and 2 special pages so you have a total of 5 files for GCI sounds good [22:11:34] Meh, these are kinda fast, so I will do more:) [22:11:39] 10MediaWiki-General-or-Unknown, 03Google-Code-In-2016, 05MW-1.29-release-notes, 13Patch-For-Review, and 2 others: Replace Linker::link() usage with LinkRenderer in XX extension (clonable) - https://phabricator.wikimedia.org/T149346#2749436 (10MtDu) The following special pages are done. * SpecialAllPages *... [22:12:13] ah, thanks for the addition then! [22:12:22] brb dargasia. In meeting and have more to say :) [22:14:21] I mean, unless there are more then one instance of a task on GCI, I don't see a reason why I shouldn't do a bit more:). [22:14:39] (03PS1) 10Chad: Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 [22:15:04] (03CR) 10Legoktm: [C: 04-1] Replace Linker::link() with LinkRenderer in includes directory (034 comments) [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) (owner: 10Georggi199) [22:15:40] (03CR) 10Legoktm: [C: 032] Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:16:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove references to Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324602 (owner: 10Jdlrobson) [22:16:03] (03CR) 10jenkins-bot: [V: 04-1] Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:16:09] (03CR) 10Tjones: Allow specification of minimum length for classification (031 comment) [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/323998 (https://phabricator.wikimedia.org/T149318) (owner: 10Tjones) [22:16:30] (03PS2) 10Chad: Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 [22:17:09] legoktm: Subtle difference ;-) https://gerrit.wikimedia.org/r/#/c/324612/1..2/src/Reader.php [22:17:18] 10Phabricator: Cannot find paste authored by me - https://phabricator.wikimedia.org/T152045#2836604 (10scfc) *argl* The "I //uploaded// a paste" should have been a clue for me. Thanks. [22:17:32] uh....whoops. [22:17:36] (03CR) 10Legoktm: [C: 032] Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:17:42] (03PS1) 10Jdlrobson: Hygiene: Remove dead folder of images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324613 [22:17:47] (03CR) 10jenkins-bot: [V: 04-1] Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:17:51] heh, the tests caught it :) [22:17:51] Er, still wrong [22:17:56] Hmm [22:18:00] (03PS17) 10EBernhardson: Extract 'did you mean' widget out of SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/323976 (https://phabricator.wikimedia.org/T150390) [22:18:04] (03PS21) 10EBernhardson: Extract main search result rendering from SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/322015 (https://phabricator.wikimedia.org/T150390) [22:18:27] oh, you need to skip the dba_handlers call if the extension isn't installed [22:18:30] Yeah [22:18:39] Now I'm just making it more complicated, lol. [22:18:56] (03CR) 10Legoktm: [C: 04-1] Store result from repeated calls to Reader::haveExtension() (031 comment) [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:19:12] MtDu_: sounds good. don't forget to update the other "no API access" message as well [22:19:34] 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2836609 (10Pppery) [22:20:08] (03PS3) 10Georggi199: Replace Linker::link() with LinkRenderer in includes directory [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) [22:20:11] tgr: yep. So do you think leaving the identity is better or leave it out? "User identity verification" or just "User verification" [22:20:14] 10TPG-FY2016-17-Q2-Embedded-Support, 06Team-Practices (This-Week): Update Q1 List of CSAT recipients for Q2 - https://phabricator.wikimedia.org/T151807#2836610 (10ggellerman) I added some names/addresses to my list. [22:20:38] user identity is clearer [22:20:53] Ok. Great. I'll be sure to add you as a reviewer. Thanks! [22:21:21] (03PS3) 10Chad: Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 [22:21:30] 06Discovery, 06Discovery-Search (Current work): Cross-wiki search results: making sure the results are relevant from sister projects - https://phabricator.wikimedia.org/T151935#2836612 (10TJones) >>! In T151935#2836591, @Deskana wrote: > An arbitrary heuristic like this is probably fine to apply to inter-wiki... [22:21:37] legoktm: So I cheat with an anonymous function :p [22:22:15] MtDu_: that grant also gives no ability to read pages (that might be visible to that user but not to an anonymous user) [22:22:23] not sure how to phrase that in [22:22:30] ostriches: eh, is that actually going to be faster? hhvm doesn't optimize anonymous funcs as much iirc [22:22:45] Only on the first call :) [22:22:55] It'll be slower then [22:23:09] as opposed to the basic grant, which allows read access but still no ability to do anything [22:23:29] (well, anything nontrivial. It might allow purging pages and such.) [22:23:32] (03Abandoned) 10Chad: Store result from repeated calls to Reader::haveExtension() [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:23:39] legoktm: With summary: "Mostly wasting time I think." [22:24:30] I've probably wasted more cycles thinking about it than cpu cycles it'll save. [22:24:36] heh [22:24:56] Better use of cycles: just stop using cdb everywhere ;-) [22:26:26] 04(no projects): "de-formal" is no valid HTML language code - https://phabricator.wikimedia.org/T152050#2836616 (10Phispi) [22:26:28] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2836615 (10Jdlrobson) FYI devs the colors B20 /B50/B70 are documented on M101. I had to ask about that. >>! In T148108#2836237,... [22:26:58] (03PS2) 10Dbrant: Add detailed "help" activity for editing descriptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323354 (https://phabricator.wikimedia.org/T151467) [22:27:30] tgr: how about something like "User identity verification only, no ability to read pages or act on a user's behalf"? [22:27:39] 10MediaWiki-General-or-Unknown, 10MediaWiki-Internationalization: "de-formal" is no valid HTML language code - https://phabricator.wikimedia.org/T152050#2836629 (10Florian) [22:27:51] And that added phrase needs to be included in both grants right? [22:28:06] legoktm: Worst part was, that wasn't even what I set out to do. I was looking at something else and got distracted [22:28:09] Oooh, shiny [22:28:11] * ostriches runs off [22:28:33] have you seen Moana yet? [22:28:40] also, what were you actually going to do? :P [22:28:45] (03CR) 10Jforrester: [C: 032] Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:28:56] (03CR) 10Jforrester: [C: 032] Don't use constants in Flow config [vagrant] - 10https://gerrit.wikimedia.org/r/324611 (owner: 10Catrope) [22:29:28] (03CR) 10Paladox: "Thankyou." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:30:18] (03Merged) 10jenkins-bot: MobileFrontend.alias for Bengali (bn) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324523 (https://phabricator.wikimedia.org/T151927) (owner: 10Aftab) [22:30:22] (03Merged) 10jenkins-bot: Don't use constants in Flow config [vagrant] - 10https://gerrit.wikimedia.org/r/324611 (owner: 10Catrope) [22:30:56] (03CR) 10jenkins-bot: [V: 04-1] Replace Linker::link() with LinkRenderer in includes directory [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) (owner: 10Georggi199) [22:31:03] (03CR) 10Paladox: "@Jforrester and @Catrope should we use manifest version 1 instead of version 2?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:32:03] legoktm: No I haven't seen it yet. And I was originally poking at https://phabricator.wikimedia.org/T35409 [22:32:42] One of the songs is called Shiny ;) [22:36:19] MtDu_: yeah, that sounds reasonable [22:37:11] (03CR) 10Pmiazga: [C: 031] Edit stream should replay edits up to the maximum age [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323490 (owner: 10Jdlrobson) [22:38:20] 10PageImages: New images don't show up in popups - https://phabricator.wikimedia.org/T152052#2836645 (10Till_Kraemer) [22:38:22] 03Google-Code-In-2016: Add templateData to a template that doesn't have any (cloneable) - https://phabricator.wikimedia.org/T148977#2836658 (10Pppery) [22:38:28] (03PS2) 10Niedzielski: Hygiene: add model for news sites [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323086 (https://phabricator.wikimedia.org/T148444) [22:39:01] (03Merged) 10jenkins-bot: Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:39:24] (03CR) 10Pmiazga: [C: 031] Implement a configurable purge strategy [services/trending-edits] - 10https://gerrit.wikimedia.org/r/323239 (https://phabricator.wikimedia.org/T145554) (owner: 10Jdlrobson) [22:39:28] (03CR) 10Niedzielski: Hygiene: add model for news sites (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323086 (https://phabricator.wikimedia.org/T148444) (owner: 10Niedzielski) [22:40:07] tgr: ok. Updating both messages now. [22:40:25] 10Android-app-feature-UX-Debt, 06Wikipedia-Android-App-Backlog: Icons on the article toolbar are hard to discern when the article's lead image is a light color - https://phabricator.wikimedia.org/T150471#2786891 (10Dbrant) We can come back to this, but I seem to recall the Google Play folks advising us against... [22:40:38] 10UI-Standardization, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Update Navigation Drawer color scheme - https://phabricator.wikimedia.org/T148108#2836677 (10Nirzar) >We can but I'd recommend doing that in a follow up task as we'll need to do some extended testing on differe... [22:42:13] 10MobileFrontend, 06Reading-Web-Backlog, 07Spike: [2hrs] Production warning: Undefined index: token in InlineDifferenceEngine - https://phabricator.wikimedia.org/T151837#2836678 (10pmiazga) Good catch @Jdlrobson [22:46:01] 10Android-app-feature-Feeds, 06Wikipedia-Android-App-Backlog: Extend the MobileWikiAppFeed schema to measure basic engagement metrics - https://phabricator.wikimedia.org/T149125#2836697 (10Tbayer) [22:46:14] Welp, legoktm, hope you won't mind that I am curently done through like half of the special pages?:)) [22:46:16] (03CR) 10MtDu: "I think we missed something. :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/324355 (https://phabricator.wikimedia.org/T149346) (owner: 10MtDu) [22:46:22] legoktm: I think we missed something. ^ [22:46:57] MtDu: oh yeah, can you submit a follow up for that? [22:46:59] my bad [22:47:05] Georggi: uhhhh [22:47:13] legoktm: yeah. Want me to create a phabricator task for it? [22:47:28] MtDu: just a patch is fine [22:47:42] Georggi, I mean, it's been 2 days. Not sure if we should wait to let others have a hand at it. :p [22:47:54] I understand your excitement though. :) [22:48:01] (03PS3) 10Jdlrobson: Restrict page images to lead section [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) [22:48:08] gotta run, bbl [22:48:09] legoktm, Alright, will do. [22:48:14] (03CR) 10Jdlrobson: Restrict page images to lead section (032 comments) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/323989 (https://phabricator.wikimedia.org/T87336) (owner: 10Jdlrobson) [22:48:18] legoktm, Ok. See you. :) [22:48:32] (03CR) 10Krinkle: Store result from repeated calls to Reader::haveExtension() (031 comment) [cdb] - 10https://gerrit.wikimedia.org/r/324612 (owner: 10Chad) [22:48:42] I am just kinda bored, I understand that I am not gonna be able to claim a task till tomorrow(today morning) anyways:) [22:49:02] So just doing something meanwhile. [22:51:22] 07Design, 10MediaWiki-Interface, 10UI-Standardization, 07Easy: inconsistent close icon "X" in MediaWiki interfaces - https://phabricator.wikimedia.org/T50067#526612 (10McIntireEvan) Just to give an update https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_icon_set gives a list of places the... [22:53:41] Ok, stopped at SpecialMostLinkedTemplates, I mean, it's just 12 files modified, right?:) [22:54:42] (03PS1) 10MtDu: Replace makeLink() with makeBrokenLink() as [ 'broken' ] as a 5th parameter is no longer supported. [core] - 10https://gerrit.wikimedia.org/r/324620 [22:55:00] 10MobileFrontend, 06Reading-Web-Backlog, 07Spike: [2hrs] Production warning: Undefined index: token in InlineDifferenceEngine - https://phabricator.wikimedia.org/T151837#2836711 (10Jdlrobson) p:05Low>03Normal I'm bumping priority as I worry that this will drop of our radar and I suspect this prevents pat... [22:55:58] 06ArchCom, 10ArchCom-RfC, 07RfC: Transition WikiDev '16 working areas into working groups - https://phabricator.wikimedia.org/T124504#2836713 (10greg) >>! In T124504#2836510, @daniel wrote: > Got stale, we should talk about working groups in a more general context. should all of the proposed working groups... [22:56:50] (03PS1) 10Georggi199: Replace Linker::link() with LinkRenderer in some special pages [core] - 10https://gerrit.wikimedia.org/r/324621 (https://phabricator.wikimedia.org/T149346) [22:57:08] 10MediaWiki-extensions-PageAssessments, 10WikiProject-tools, 03Community-Tech-Sprint: Create a report interface for PageAssessments - https://phabricator.wikimedia.org/T120407#2836715 (10Samwilson) Should the namespace search field exclude/include non-talk namespaces based on `$wgPageAssessmentsOnTalkPages`?... [22:59:23] (03PS4) 10Georggi199: Replace Linker::link() with LinkRenderer in includes directory [core] - 10https://gerrit.wikimedia.org/r/324600 (https://phabricator.wikimedia.org/T149346) [22:59:33] 10MediaWiki-JobQueue, 10ChangeProp, 10EventBus, 06Operations, and 4 others: Asynchronous processing in production: one queue to rule them all - https://phabricator.wikimedia.org/T149408#2836718 (10greg) p:05Triage>03Normal [22:59:36] 10MobileFrontend, 06Reading-Web-Backlog, 07Spike: [2hrs] Production warning: Undefined index: token in InlineDifferenceEngine - https://phabricator.wikimedia.org/T151837#2836720 (10Jdlrobson) These errors also occur more than T151838 which is high so we may want to make this high as well. [22:59:38] 06ArchCom, 07Technical-Debt, 10Wikimedia-Developer-Summit (2017): Platforms are Products too! - https://phabricator.wikimedia.org/T149533#2836722 (10greg) p:05Triage>03Normal [22:59:47] 10MediaWiki-Interwiki, 10MediaWiki-Sites, 10Wikimedia-Developer-Summit (2017): Refactoring the Interwiki Map: status and outlook - https://phabricator.wikimedia.org/T149535#2836723 (10greg) p:05Triage>03Normal [23:08:01] Well, bye guys, have to go sleep. [23:08:27] Good night! [23:11:01] (03CR) 10MtDu: [C: 04-1] "Just some things I saw. Make sure you read the docs when converting." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/324621 (https://phabricator.wikimedia.org/T149346) (owner: 10Georggi199) [23:11:13] 10MediaWiki-Database, 07Performance, 10Wikimedia-Developer-Summit (2017): Scaling the MediaWiki database schema - https://phabricator.wikimedia.org/T149534#2836738 (10greg) p:05Triage>03Normal [23:11:37] (03CR) 10Jforrester: "> version 2 breaks mw 1.28 and 1.27 compat." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [23:11:59] (03CR) 10Paladox: "Ok." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [23:12:04] 10MediaWiki-Configuration, 05Goal: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#2836741 (10Jdforrester-WMF) [23:12:59] 10MediaWiki-Special-pages, 07Easy, 03Google-Code-In-2016: "Authentication only, no API access." text at Special:ListGrants is a bit confusing - https://phabricator.wikimedia.org/T145354#2836746 (10MtDu) a:03MtDu Will fix this. Patch coming soon. [23:15:34] (03PS3) 10Aftab: Hygiene: Remove references to Special:TopicTag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324602 (owner: 10Jdlrobson) [23:15:49] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media: GalleryDialog: Items should scroll into view when selected - https://phabricator.wikimedia.org/T152053#2836751 (10Jdforrester-WMF) p:05Triage>03Normal [23:16:59] 10Android-app-feature-Feeds, 06Wikipedia-Android-App-Backlog: Extend the MobileWikiAppFeed schema to measure basic engagement metrics - https://phabricator.wikimedia.org/T149125#2836755 (10Tbayer) There has been some deliberation with @dbrant about the precise definition of card impressions, i.e. the exact mom... [23:17:03] 10MobileFrontend: Cannot collapse/uncollapse headings inside infoboxes - https://phabricator.wikimedia.org/T152055#2836757 (10pmiazga) [23:17:58] 10MediaWiki-General-or-Unknown, 07Developer-notice, 07JavaScript, 07Notice, and 2 others: jquery.tipsy: Don't use deprecated/removed 'context' and 'selector' features - https://phabricator.wikimedia.org/T85048#2836769 (10Krinkle) [23:21:42] (03PS5) 10Jdlrobson: Overhaul navigation drawer to better focus on navigation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [23:21:52] 10Mobile-Content-Service, 13Patch-For-Review, 06Wikipedia-Android-App-Backlog (Kanban): Surface wikibase id in response - https://phabricator.wikimedia.org/T147578#2836797 (10bearND) 05Open>03Resolved Was actually deployed on Monday, 11/28. [23:23:58] (03PS3) 10Jdlrobson: Hovering over links in menu should change icons to blue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) [23:25:08] (03PS1) 10Ladsgroup: [WIP] Align diff colors with Wikimedia color palette [core] - 10https://gerrit.wikimedia.org/r/324626 (https://phabricator.wikimedia.org/T152025) [23:25:25] (03PS1) 10MtDu: Clarify grant-mwoath-authonly and grant-mwoath-authonlyprivate messages * Reword generic "API" * Notify user of inability to read pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/324627 (https://phabricator.wikimedia.org/T145354) [23:26:26] FlorianSW, tgr, d3r1ck: Added you guys as reviewers. :) [23:27:26] (03CR) 10Gergő Tisza: [C: 031] Clarify grant-mwoath-authonly and grant-mwoath-authonlyprivate messages * Reword generic "API" * Notify user of inability to read pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/324627 (https://phabricator.wikimedia.org/T145354) (owner: 10MtDu) [23:30:11] tgr: Is there anyone else I should add as a reviewer? I figured you were one of the main authors of the extension. :) [23:31:23] I'm not, but there is no need to ping the authors for a text change [23:31:25] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 10Wikidata, and 2 others: WikidataPageBanner when using page images generated API renders badly cropped images - https://phabricator.wikimedia.org/T131424#2836807 (10divadsn) a:03divadsn @Jdlrobson Thanks, everything is ready to go! I will reply back whe... [23:31:33] (03PS4) 10Krinkle: jquery.tipsy: Remove support for 'live' option [core] - 10https://gerrit.wikimedia.org/r/300854 (https://phabricator.wikimedia.org/T85048) (owner: 10Bartosz Dziewoński) [23:32:56] tgr: Ok. Thanks. I'll let the other mentors, Florian and d3r1ck take a look. [23:34:35] (03CR) 10Mholloway: Add description editing success activity (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321802 (https://phabricator.wikimedia.org/T148202) (owner: 10Mholloway) [23:35:48] (03PS9) 10Krinkle: [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) [23:36:00] (03CR) 10Krinkle: "Rebase - resolved conflict" [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [23:36:09] (03PS10) 10Krinkle: [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) [23:36:27] (03PS6) 10Jdlrobson: Overhaul navigation drawer to better focus on navigation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [23:37:16] 10MobileFrontend: Mobile edit page shows different content than desktop edit/visual editor - https://phabricator.wikimedia.org/T152058#2836809 (10pmiazga) [23:37:28] (03CR) 10Jdlrobson: [C: 031] "has nirzar stamp of approval (although follow up patch needs +2ing before this should be merged so they get merged together" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [23:38:07] 10PageImages, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃, 07Unplanned-Sprint-Work: Images inside infoboxes are not being used as page image - https://phabricator.wikimedia.org/T151276#2836821 (10bmansurov) Here is what I learned so far: 1. The template https://en.wikipedia.org/wiki/Template:Nation%2... [23:38:22] (03PS4) 10Jdlrobson: Hovering over links in menu should change icons to blue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) [23:43:25] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Upgrade to jQuery v3 [core] - 10https://gerrit.wikimedia.org/r/322812 (https://phabricator.wikimedia.org/T124742) (owner: 10Krinkle) [23:47:43] (03PS2) 10Niedzielski: Update: add news headline topic property [services/mobileapps] - 10https://gerrit.wikimedia.org/r/323087 (https://phabricator.wikimedia.org/T148444) [23:48:05] (03CR) 10jenkins-bot: [V: 04-1] Overhaul navigation drawer to better focus on navigation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/317746 (https://phabricator.wikimedia.org/T148108) (owner: 10VolkerE) [23:48:44] (03CR) 10jenkins-bot: [V: 04-1] Hovering over links in menu should change icons to blue [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/324370 (https://phabricator.wikimedia.org/T148108) (owner: 10Jdlrobson) [23:52:24] 10PageImages, 06Reading-Web-Backlog, 03Reading-Web-Sprint-86-🔪🦃, 07Unplanned-Sprint-Work: Images inside infoboxes are not being used as page image - https://phabricator.wikimedia.org/T151276#2836826 (10Jdlrobson) Nice detective work! So basically the image candidates are not returned in order they appear i... [23:55:00] Hey dargasia [23:55:06] (03PS1) 10Catrope: ExtensionRegistryTest: Illustrate priority in array_replace_recursive test case [core] - 10https://gerrit.wikimedia.org/r/324628 [23:55:09] Sorry for forgot to ping when I was done with my meeting. [23:55:18] SO yeah. Just one more thing that I wanted to say. [23:55:24] Thanks! :) [23:55:34] OK two more things. [23:55:55] I think it's really important to find a way to accept Pull Requests. If I choose to be nit picky, that's on me (wherever possible) [23:56:39] When I submitted the revert, really what I wanted to do was to go back in time and talk to you about your PR before it got merged. [23:56:43] 10CirrusSearch, 06Discovery, 06Discovery-Search: CirrusSearch: Replace double quotes with spaces in queries - https://phabricator.wikimedia.org/T149307#2748223 (10Smalyshev) Not sure what is the plan on this one - looks like FullTextQueryStringQueryBuilder has quite extensive handing for quotes with regard t... [23:56:52] Still, I think Amir1 made a good call to merge. [23:57:43] (03CR) 10Dbrant: Add detailed "help" activity for editing descriptions. (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/323354 (https://phabricator.wikimedia.org/T151467) (owner: 10Dbrant)