[00:02:17] (03PS1) 10Tim Starling: Accept salted password hashes with :A: prefixes [core] - 10https://gerrit.wikimedia.org/r/321570 [00:06:08] (03Merged) 10jenkins-bot: Extract namespace_text and wiki on all ResultsType [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320756 (owner: 10DCausse) [00:06:11] (03CR) 10Brian Wolff: [C: 032] Accept salted password hashes with :A: prefixes [core] - 10https://gerrit.wikimedia.org/r/321570 (owner: 10Tim Starling) [00:15:47] (03Merged) 10jenkins-bot: Accept salted password hashes with :A: prefixes [core] - 10https://gerrit.wikimedia.org/r/321570 (owner: 10Tim Starling) [00:24:05] (03CR) 10Alex Monk: [C: 032] Fix incorrectly indented block [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/321365 (owner: 10Niharika29) [00:24:20] (03CR) 10Kaldari: [C: 04-1] Add eventlogging for checking how often users are blocked from editing due to presence of BlockID cookie (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/320239 (https://phabricator.wikimedia.org/T146230) (owner: 10Niharika29) [00:26:16] (03Merged) 10jenkins-bot: Fix incorrectly indented block [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/321365 (owner: 10Niharika29) [01:13:39] (03PS5) 10Mooeypoo: [super-atomic-WIP] Adding filters to RecentChanges [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) [01:19:17] (03CR) 10jenkins-bot: [V: 04-1] [super-atomic-WIP] Adding filters to RecentChanges [core] - 10https://gerrit.wikimedia.org/r/320332 (https://phabricator.wikimedia.org/T149435) (owner: 10Mooeypoo) [01:29:09] (03CR) 10Alex Monk: Remove inline CodeEditor for (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/318913 (owner: 10TheDJ) [01:31:30] (03PS1) 10Alex Monk: Follow-up I83714188: Don't turn every MW page into an exception [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/321580 [01:31:56] (03PS32) 10Samwilson: Send a cookie with autoblocks to prevent vandalism. [core] - 10https://gerrit.wikimedia.org/r/48029 (https://phabricator.wikimedia.org/T5233) (owner: 10Parent5446) [01:32:10] (03CR) 10Alex Monk: "I2d6c6b8f" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/318913 (owner: 10TheDJ) [01:33:17] (03CR) 10Legoktm: [C: 032] Follow-up I83714188: Don't turn every MW page into an exception [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/321580 (owner: 10Alex Monk) [01:34:13] (03Merged) 10jenkins-bot: Follow-up I83714188: Don't turn every MW page into an exception [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/321580 (owner: 10Alex Monk) [01:38:56] (03CR) 10JGirault: [C: 04-1] Adding client-side translations for footer text. (0321 comments) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/319563 (owner: 10Jdrewniak) [02:24:30] (03CR) 10Gergő Tisza: [C: 032] Add better logging to password reset [core] - 10https://gerrit.wikimedia.org/r/321166 (owner: 10Brian Wolff) [02:24:34] (03PS3) 10Anomie: API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 [02:24:36] (03PS3) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [02:25:41] (03CR) 10EBernhardson: [C: 031] "looks great! love the tests (don't love the copied in config ... but what can you do.) One trivial thing to fix in the test case, but othe" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320757 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [02:26:24] (03PS1) 10Legoktm: Get rid of separate ext.oathauth module [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321586 [02:26:26] (03PS1) 10Legoktm: Hide empty square for QR code with CSS for no-JS users [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321587 [02:34:20] (03Merged) 10jenkins-bot: Add better logging to password reset [core] - 10https://gerrit.wikimedia.org/r/321166 (owner: 10Brian Wolff) [02:36:25] (03CR) 10Gergő Tisza: Add password policy to prevent password including User's Real Name (031 comment) [core] - 10https://gerrit.wikimedia.org/r/318956 (https://phabricator.wikimedia.org/T121181) (owner: 10Reedy) [02:38:15] (03PS1) 10Gergő Tisza: Fix SpecialPasswordResetOnSubmit parameter handling [core] - 10https://gerrit.wikimedia.org/r/321589 [02:38:59] (03CR) 10EBernhardson: "looks pretty good overall. I didn't have a chance to try this yet, but will soon." (035 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320625 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [02:40:34] (03PS1) 10Gergő Tisza: Followup to I5b47e5a [core] - 10https://gerrit.wikimedia.org/r/321590 [02:41:33] (03CR) 10jenkins-bot: [V: 04-1] API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 (owner: 10Anomie) [02:42:02] (03PS2) 10Gergő Tisza: Fix SpecialPasswordResetOnSubmit parameter handling [core] - 10https://gerrit.wikimedia.org/r/321589 [02:42:48] (03CR) 10jenkins-bot: [V: 04-1] API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [02:56:14] (03CR) 10Gergő Tisza: [C: 032] "Trivial comment-only change." [core] - 10https://gerrit.wikimedia.org/r/321590 (owner: 10Gergő Tisza) [02:58:42] (03PS1) 10Gergő Tisza: Reduce default cookie expiration time to 30 days [core] - 10https://gerrit.wikimedia.org/r/321592 [02:59:38] (03PS4) 10Anomie: Update for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 [02:59:41] (03PS1) 10Anomie: Prepare for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321593 [03:00:20] (03PS4) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [03:05:01] (03Merged) 10jenkins-bot: Followup to I5b47e5a [core] - 10https://gerrit.wikimedia.org/r/321590 (owner: 10Gergő Tisza) [03:08:50] (03CR) 10jenkins-bot: [V: 04-1] API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [03:13:57] (03CR) 10Parent5446: "So what you're saying is that unit tests should almost definitely be written for it. ;)" [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [03:15:28] (03CR) 10Anomie: "Ugh. Ieae527de doesn't make this pass because the tests run against "Wikidata" instead of "Wikibase". As far as I can tell, that means we " [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [03:21:07] (03PS2) 10Anomie: Prepare for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321593 [03:22:16] (03PS5) 10Anomie: Update for API error i18n [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 [03:30:07] (03CR) 10Parent5446: [C: 04-1] Add password policy to prevent password including User's Real Name (034 comments) [core] - 10https://gerrit.wikimedia.org/r/318956 (https://phabricator.wikimedia.org/T121181) (owner: 10Reedy) [03:38:08] (03CR) 10Brian Wolff: [C: 032] Fix SpecialPasswordResetOnSubmit parameter handling [core] - 10https://gerrit.wikimedia.org/r/321589 (owner: 10Gergő Tisza) [03:42:14] (03PS1) 10Brian Wolff: Fix message name for passwordreset-invalidemail [core] - 10https://gerrit.wikimedia.org/r/321596 [03:45:47] (03PS1) 10Brian Wolff: Use different varname for upgraded hash from origin hash [core] - 10https://gerrit.wikimedia.org/r/321597 [03:48:33] (03Merged) 10jenkins-bot: Fix SpecialPasswordResetOnSubmit parameter handling [core] - 10https://gerrit.wikimedia.org/r/321589 (owner: 10Gergő Tisza) [03:53:50] (03PS2) 10Brian Wolff: Use different varname for upgraded hash from original hash [core] - 10https://gerrit.wikimedia.org/r/321597 [03:55:24] anomie: Yeah, when I was writing that comment, both solutions sounded wrong [04:01:45] (03PS3) 10Krinkle: resourceloader: Remove top/bottom queue distinction [core] - 10https://gerrit.wikimedia.org/r/320315 (https://phabricator.wikimedia.org/T109837) [04:15:49] (03PS2) 10Tim Starling: Fix multiple bugs in EncryptedPassword [core] - 10https://gerrit.wikimedia.org/r/321359 [04:23:05] (03CR) 10Tim Starling: "All done now. Unit tests can be in a separate commit if you really want them." [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [04:29:30] (03CR) 10Krinkle: [C: 031] "Basic test coverage for this class and MwOldPassword would make sense I think." [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [04:30:20] (03PS1) 10Gergő Tisza: Prevent login-only local password provider from removing passwords [core] - 10https://gerrit.wikimedia.org/r/321602 [04:44:15] (03CR) 10jenkins-bot: [V: 04-1] Prevent login-only local password provider from removing passwords [core] - 10https://gerrit.wikimedia.org/r/321602 (owner: 10Gergő Tisza) [04:45:49] (03PS2) 10KartikMistry: WIP: Update Contenttranslation role [vagrant] - 10https://gerrit.wikimedia.org/r/320362 (https://phabricator.wikimedia.org/T149880) [04:46:33] (03CR) 10Krinkle: "Per T146510, the data looks okay. Let's update this implementation to match the one we ended up with there. After this this should be good" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/319902 (owner: 10Ori.livneh) [05:17:15] (03CR) 10Brian Wolff: [C: 032] Fix multiple bugs in EncryptedPassword [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [05:25:35] (03Merged) 10jenkins-bot: Fix multiple bugs in EncryptedPassword [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [05:28:58] (03CR) 10Parent5446: "You don't have to be so snarky about it. It was supposed to be marked as experimental, so I'm sorry if I missed that in what was a 1,600 l" [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [05:34:26] (03PS1) 10Tim Starling: Rewrite runBatchedQuery.php [core] - 10https://gerrit.wikimedia.org/r/321604 [05:40:32] (03CR) 10jenkins-bot: [V: 04-1] Rewrite runBatchedQuery.php [core] - 10https://gerrit.wikimedia.org/r/321604 (owner: 10Tim Starling) [05:42:16] (03PS2) 10Tim Starling: Rewrite runBatchedQuery.php [core] - 10https://gerrit.wikimedia.org/r/321604 [05:51:34] (03CR) 10Brian Wolff: "For reference, I intend to (sometime, probably not today) commit unit tests in a follow up patch." [core] - 10https://gerrit.wikimedia.org/r/321359 (owner: 10Tim Starling) [06:12:07] (03PS1) 10Brian Wolff: Throw an exception if password hash would be truncated by DB [core] - 10https://gerrit.wikimedia.org/r/321606 [06:18:22] (03CR) 10jenkins-bot: [V: 04-1] Throw an exception if password hash would be truncated by DB [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [06:20:18] (03CR) 10Parent5446: "Is this really something that belongs in the Password class? IMO DB-specific limits should be alongside the code that stores the data in t" [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [06:21:22] (03PS2) 10Brian Wolff: Throw an exception if password hash would be truncated by DB [core] - 10https://gerrit.wikimedia.org/r/321606 [06:25:10] (03CR) 10Brian Wolff: "I disagree somewhat (although i do see where you're coming from). Password hashes should be valid in all db backends imo. If you specify a" [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [06:27:46] (03CR) 10Parent5446: [C: 031] ":) I haven't been keeping up with the times." [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [06:33:35] (03CR) 10Dzahn: [C: 031] Revert "Add en.wiktionary.org to blacklist temporarily to prevent DoS." [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/314058 (https://phabricator.wikimedia.org/T147211) (owner: 10C. Scott Ananian) [06:36:08] (03CR) 10Fomafix: Linker: No need to encode single quotes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/264621 (owner: 10Gerrit Patch Uploader) [06:38:15] (03CR) 10Majr: mw.Message: Match behavior when key does not exist to PHP (031 comment) [core] - 10https://gerrit.wikimedia.org/r/321378 (owner: 10Bartosz Dziewoński) [06:56:37] (03CR) 10Aaron Schulz: [C: 031] Rewrite runBatchedQuery.php (033 comments) [core] - 10https://gerrit.wikimedia.org/r/321604 (owner: 10Tim Starling) [07:18:17] (03CR) 10Robert Vogel: [C: 032] "Thank you very much" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/321411 (owner: 10Anomie) [07:20:09] (03Merged) 10jenkins-bot: Update for API error i18n [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/321411 (owner: 10Anomie) [07:28:09] (03PS2) 10Gergő Tisza: Prevent login-only local password provider from removing passwords [core] - 10https://gerrit.wikimedia.org/r/321602 [08:16:22] (03PS5) 10Hashar: Add composer entry point with phplint [extensions/timeline] - 10https://gerrit.wikimedia.org/r/291668 (owner: 10Paladox) [08:23:14] (03CR) 10Marostegui: [C: 031] Revert "Add en.wiktionary.org to blacklist temporarily to prevent DoS." [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/314058 (https://phabricator.wikimedia.org/T147211) (owner: 10C. Scott Ananian) [08:29:42] (03CR) 10Hashar: "recheck" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/291668 (owner: 10Paladox) [08:33:16] (03CR) 10Hashar: [C: 032] Add composer entry point with phplint [extensions/timeline] - 10https://gerrit.wikimedia.org/r/291668 (owner: 10Paladox) [08:35:51] (03Merged) 10jenkins-bot: Add composer entry point with phplint [extensions/timeline] - 10https://gerrit.wikimedia.org/r/291668 (owner: 10Paladox) [08:46:42] (03CR) 10Kaldari: [C: 04-1] "Just some minor nit-picks." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/48029 (https://phabricator.wikimedia.org/T5233) (owner: 10Parent5446) [08:58:28] (03CR) 10Nikerabbit: "Added Raymond" [core] - 10https://gerrit.wikimedia.org/r/321596 (owner: 10Brian Wolff) [09:01:23] (03CR) 10Nikerabbit: "Shouldn't we just get strict mode enabled for all dbs?" [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [09:07:56] (03CR) 10Raimond Spekking: [C: 032] "@Brian: I will do a full export of core messages later today." [core] - 10https://gerrit.wikimedia.org/r/321596 (owner: 10Brian Wolff) [09:10:55] (03CR) 10Nikerabbit: build: Replace jscs+jshint with eslint (031 comment) [mapdata] - 10https://gerrit.wikimedia.org/r/320714 (owner: 10JGirault) [09:19:58] (03CR) 10Tim Starling: Rewrite runBatchedQuery.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/321604 (owner: 10Tim Starling) [09:34:53] (03Merged) 10jenkins-bot: Fix message name for passwordreset-invalidemail [core] - 10https://gerrit.wikimedia.org/r/321596 (owner: 10Brian Wolff) [09:35:46] (03CR) 10Prtksxna: [C: 032] Initialize gallery slideshow on wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/321500 (owner: 10TheDJ) [09:44:32] (03Merged) 10jenkins-bot: Initialize gallery slideshow on wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/321500 (owner: 10TheDJ) [09:47:28] (03CR) 10Jeroen De Dauw: "No tests for the new stuff?" [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [09:47:35] (03PS1) 10Hashar: Add mediawiki-codesniffer [extensions/timeline] - 10https://gerrit.wikimedia.org/r/321617 [10:15:13] (03CR) 10DCausse: Add and implement InterwikiResolver (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320757 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [10:16:19] (03PS1) 10Urbanecm: Add Czech alias of special page [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/321622 [10:17:26] (03PS18) 10DCausse: Refactor interwiki support [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320625 (https://phabricator.wikimedia.org/T141033) [10:17:28] (03PS17) 10DCausse: Remove BC code after interwiki refactoring [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320788 (https://phabricator.wikimedia.org/T141033) [10:17:30] (03PS8) 10DCausse: Add and implement InterwikiResolver [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320757 (https://phabricator.wikimedia.org/T141033) [10:25:13] (03PS1) 10Hashar: Refresh extensions [extensions] - 10https://gerrit.wikimedia.org/r/321623 [10:25:59] (03CR) 10Hashar: [C: 032 V: 032] Refresh extensions [extensions] - 10https://gerrit.wikimedia.org/r/321623 (owner: 10Hashar) [10:28:17] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320625 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [10:28:24] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320625 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [10:32:10] (03CR) 10Hashar: [C: 04-1] "You should keep the composer.json file which was previously introduced in https://gerrit.wikimedia.org/r/#/c/321212/" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/321220 (owner: 10Samwilson) [10:43:22] (03PS1) 10Phuedx: Remove underscores from redirect toast message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321626 (https://phabricator.wikimedia.org/T150639) [10:49:25] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320788 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [10:55:05] (03CR) 10Thiemo Mättig (WMDE): Add password policy to prevent password including User's Real Name (031 comment) [core] - 10https://gerrit.wikimedia.org/r/318956 (https://phabricator.wikimedia.org/T121181) (owner: 10Reedy) [10:58:02] (03PS1) 10Hashar: Delete WikimediaPageViewInfo directory [extensions] - 10https://gerrit.wikimedia.org/r/321630 [10:58:22] (03PS2) 10Hashar: Delete WikimediaPageViewInfo directory [extensions] - 10https://gerrit.wikimedia.org/r/321630 [10:58:27] (03CR) 10Hashar: [C: 032 V: 032] Delete WikimediaPageViewInfo directory [extensions] - 10https://gerrit.wikimedia.org/r/321630 (owner: 10Hashar) [11:00:37] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320757 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [11:00:46] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/320757 (https://phabricator.wikimedia.org/T141033) (owner: 10DCausse) [11:12:22] (03CR) 10Jdlrobson: [C: 032] Remove underscores from redirect toast message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321626 (https://phabricator.wikimedia.org/T150639) (owner: 10Phuedx) [11:24:11] (03Merged) 10jenkins-bot: Remove underscores from redirect toast message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321626 (https://phabricator.wikimedia.org/T150639) (owner: 10Phuedx) [11:27:25] (03PS2) 10MarcoAurelio: [WIP] Add $specialPageAliases for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/321392 (https://phabricator.wikimedia.org/T150586) [11:31:22] (03CR) 10Hashar: "recheck" [mapdata] - 10https://gerrit.wikimedia.org/r/320714 (owner: 10JGirault) [11:42:28] (03PS3) 10MarcoAurelio: Add $specialPageAliases for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/321392 (https://phabricator.wikimedia.org/T150586) [11:42:35] (03PS4) 10MarcoAurelio: Add $specialPageAliases for Bengali (bn) [core] - 10https://gerrit.wikimedia.org/r/321392 (https://phabricator.wikimedia.org/T150586) [12:17:33] (03PS7) 10Matthias Mullie: Embed TinyRGB color profile when JPG EXIF Color Space = sRGB but no profile embedded [core] - 10https://gerrit.wikimedia.org/r/307511 (https://phabricator.wikimedia.org/T134498) [12:25:51] (03PS1) 10MarcoAurelio: Create a "centralnotice-shared-help-translate' temporary [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) [12:26:34] (03CR) 10jenkins-bot: [V: 04-1] Create a "centralnotice-shared-help-translate' temporary [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) (owner: 10MarcoAurelio) [12:27:03] (03PS2) 10MarcoAurelio: Create a "centralnotice-shared-help-translate' temporary [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) [12:27:55] (03PS1) 10Samwilson: Re-add composer, and rename the Genealogy namespace to remove personal name. [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/321640 [12:45:45] (03PS1) 10Hashar: build: bump mw codesniffer 0.7.1..0.7.2 [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/321641 [12:47:57] (03CR) 10Esanders: [C: 032] eslint: Enable wrap-iife [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321004 (owner: 10Phuedx) [12:51:09] (03CR) 10jenkins-bot: [V: 04-1] build: bump mw codesniffer 0.7.1..0.7.2 [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/321641 (owner: 10Hashar) [12:54:59] (03PS2) 10Samwilson: Re-add composer, and rename the Genealogy namespace to remove personal name. [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/321640 [12:56:26] (03PS6) 10Esanders: build: Replace jshint+jscs with eslint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/320406 [12:56:28] (03PS4) 10Esanders: eslint: Enable valid-jsdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/320984 [12:56:57] (03PS7) 10Esanders: build: Replace jshint+jscs with eslint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/320406 [12:56:59] (03PS5) 10Esanders: eslint: Enable valid-jsdoc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/320984 [12:57:21] (03PS2) 10Esanders: eslint: Enable wrap-iife [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321004 (owner: 10Phuedx) [12:59:53] (03PS1) 10Esanders: eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/Cite] - 10https://gerrit.wikimedia.org/r/321643 [13:07:42] (03PS1) 10Jdlrobson: WIP: Fix swagger file [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 [13:08:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix swagger file [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 (owner: 10Jdlrobson) [13:10:09] (03PS2) 10Jdlrobson: WIP: Fix swagger spec routes [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 [13:11:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix swagger spec routes [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 (owner: 10Jdlrobson) [13:14:20] (03PS1) 10Esanders: eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/Math] - 10https://gerrit.wikimedia.org/r/321649 [13:16:01] (03CR) 10Jdlrobson: "minor issue" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/320984 (owner: 10Esanders) [13:55:50] (03CR) 10Jdlrobson: "I've separated the swagger spec fixes to here:" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/320628 (https://phabricator.wikimedia.org/T145553) (owner: 10Jdlrobson) [13:55:52] (03PS1) 10Anomie: API: Fix tbnooverride parameter type [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/321655 [14:03:06] (03CR) 10Hashar: "Looking at the open changes in Gerrit, you seem to have a single branch on your local machine and keep building on top of it. Each new com" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/321640 (owner: 10Samwilson) [14:08:12] (03CR) 10Jdlrobson: Fix Bug T134281 Math-page-overflow (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/320978 (https://phabricator.wikimedia.org/T134281) (owner: 10TameeshB) [14:08:34] (03CR) 10Jdlrobson: [C: 04-1] Fix Bug T134281 Math-page-overflow [extensions/Math] - 10https://gerrit.wikimedia.org/r/320978 (https://phabricator.wikimedia.org/T134281) (owner: 10TameeshB) [14:38:29] (03CR) 10MarcoAurelio: "Maybe should be tagged as optional too, to avoid having to delete a lot of stuff in the future." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) (owner: 10MarcoAurelio) [14:46:13] (03CR) 10Anomie: "I note this means that trying to switch over to something like GoogleLogin will never trigger the local password removal. I guess this is " [core] - 10https://gerrit.wikimedia.org/r/321602 (owner: 10Gergő Tisza) [14:47:35] (03CR) 10Dbrant: [C: 032] Add error feedback UI to description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320543 (https://phabricator.wikimedia.org/T148203) (owner: 10Niedzielski) [14:50:13] (03CR) 10Anomie: "recheck" [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [14:56:45] (03CR) 10Mholloway: [C: 031] Close DescriptionEditActivity on successful edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320620 (https://phabricator.wikimedia.org/T148204) (owner: 10Niedzielski) [15:02:44] (03PS1) 10Robert Vogel: Bugfix for "grouping feature" in gridpanel [extensions/BlueSpiceFoundation] (REL1_23) - 10https://gerrit.wikimedia.org/r/321664 [15:06:25] (03CR) 10Mholloway: Handle abusefilters in Wikidata description editing (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T146641) (owner: 10BearND) [15:12:00] (03Merged) 10jenkins-bot: Add error feedback UI to description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320543 (https://phabricator.wikimedia.org/T148203) (owner: 10Niedzielski) [15:13:50] (03CR) 10jenkins-bot: [V: 04-1] Bugfix for "grouping feature" in gridpanel [extensions/BlueSpiceFoundation] (REL1_23) - 10https://gerrit.wikimedia.org/r/321664 (owner: 10Robert Vogel) [15:15:12] (03CR) 10Pwirth: [C: 032 V: 032] Bugfix for "grouping feature" in gridpanel [extensions/BlueSpiceFoundation] (REL1_23) - 10https://gerrit.wikimedia.org/r/321664 (owner: 10Robert Vogel) [15:15:20] (03CR) 10Dbrant: [C: 032] Close DescriptionEditActivity on successful edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320620 (https://phabricator.wikimedia.org/T148204) (owner: 10Niedzielski) [15:15:29] (03PS1) 10Pwirth: Bugfix for "grouping feature" in gridpanel [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/321665 [15:15:41] (03PS1) 10Pwirth: Bugfix for "grouping feature" in gridpanel [extensions/BlueSpiceFoundation] (REL1_27) - 10https://gerrit.wikimedia.org/r/321667 [15:20:07] (03CR) 10Anomie: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/321421 (owner: 10Anomie) [15:27:20] (03Merged) 10jenkins-bot: Close DescriptionEditActivity on successful edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320620 (https://phabricator.wikimedia.org/T148204) (owner: 10Niedzielski) [15:37:14] (03CR) 10Tjones: [C: 031] Update for API error i18n [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321416 (owner: 10Anomie) [15:44:14] (03PS1) 10DCausse: [WIP] Split ClassicInterwikiLookup [core] - 10https://gerrit.wikimedia.org/r/321674 [15:45:56] (03CR) 10Tjones: [C: 031] "Looks good, but Cindy is really unhappy. Shall we wait for Cindy's blessing?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321393 (owner: 10DCausse) [15:49:41] (03CR) 10Anomie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/321426 (owner: 10Anomie) [15:49:51] (03CR) 10Anomie: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/321455 (owner: 10Anomie) [15:51:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Split ClassicInterwikiLookup [core] - 10https://gerrit.wikimedia.org/r/321674 (owner: 10DCausse) [15:55:00] (03PS1) 10Ottomata: Allow Kafka topic deletion [vagrant] - 10https://gerrit.wikimedia.org/r/321675 [15:56:57] (03PS2) 10DCausse: [WIP] Split ClassicInterwikiLookup [core] - 10https://gerrit.wikimedia.org/r/321674 [15:59:13] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321393 (owner: 10DCausse) [15:59:23] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321393 (owner: 10DCausse) [16:00:00] (03CR) 10Jforrester: [C: 032] eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/Cite] - 10https://gerrit.wikimedia.org/r/321643 (owner: 10Esanders) [16:00:11] (03CR) 10Jforrester: [C: 032] eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/Math] - 10https://gerrit.wikimedia.org/r/321649 (owner: 10Esanders) [16:01:13] (03CR) 10Tjones: [C: 032] icu_tokenzer: add a default set of language codes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321393 (owner: 10DCausse) [16:09:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Split ClassicInterwikiLookup [core] - 10https://gerrit.wikimedia.org/r/321674 (owner: 10DCausse) [16:10:24] (03Merged) 10jenkins-bot: eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/Cite] - 10https://gerrit.wikimedia.org/r/321643 (owner: 10Esanders) [16:12:16] (03PS3) 10DCausse: [WIP] Split ClassicInterwikiLookup [core] - 10https://gerrit.wikimedia.org/r/321674 [16:14:16] (03Merged) 10jenkins-bot: eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/Math] - 10https://gerrit.wikimedia.org/r/321649 (owner: 10Esanders) [16:15:34] Sorry for bothering you, but since days I have to sometimes click 10 times saving [16:15:51] before my edit really gets saved. The error is loss of session data [16:16:02] (03PS2) 10Anomie: Update for API error i18n [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/321408 [16:16:06] (03PS2) 10Anomie: Update for API error i18n [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/321425 [16:16:08] Logging out and in again doesn't help in any kind [16:16:08] (03PS2) 10Anomie: Update for API error i18n [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/321434 [16:16:46] (03PS5) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [16:21:44] (03PS4) 10DCausse: [WIP] Split ClassicInterwikiLookup [core] - 10https://gerrit.wikimedia.org/r/321674 [16:23:15] Other people had this problem too: https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia/Archiv/2016/Woche_45#Sitzungsdaten_gehen_st.C3.A4ndig_verloren [16:26:07] As IP I can save the same edit without problems [16:26:32] kopiersperre: Thanks for reporting this. Could you perhaps file a Phabricator ticket for it? I can do it if you don't know how. [16:27:02] (03CR) 10jenkins-bot: [V: 04-1] API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [16:28:36] (03PS1) 10Cicalese: Fixed avatar bug plus two new features. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/321682 [16:30:55] Niharika: I will try to reproduce it and then report [16:31:16] kopiersperre: Thank you, that will be helpful. [16:31:17] (03CR) 10Cicalese: [C: 032 V: 032] Fixed avatar bug plus two new features. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/321682 (owner: 10Cicalese) [16:43:11] (03CR) 10Brian Wolff: "Well yes... but strict mode is not in my power to make happen. Also third parties" [core] - 10https://gerrit.wikimedia.org/r/321606 (owner: 10Brian Wolff) [16:51:40] (03PS1) 10Cicalese: Bug fix. Incorrect if closure. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/321688 [16:54:21] (03CR) 10Cicalese: [C: 032 V: 032] Bug fix. Incorrect if closure. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/321688 (owner: 10Cicalese) [16:56:01] (03PS6) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [17:02:56] (03CR) 10Ottomata: [C: 031] Allow Kafka topic deletion [vagrant] - 10https://gerrit.wikimedia.org/r/321675 (owner: 10Ottomata) [17:03:09] (03CR) 10BryanDavis: [C: 032] Allow Kafka topic deletion [vagrant] - 10https://gerrit.wikimedia.org/r/321675 (owner: 10Ottomata) [17:07:47] (03CR) 10jenkins-bot: [V: 04-1] API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) (owner: 10Anomie) [17:08:10] (03Merged) 10jenkins-bot: Allow Kafka topic deletion [vagrant] - 10https://gerrit.wikimedia.org/r/321675 (owner: 10Ottomata) [17:15:00] (03PS7) 10Anomie: API: i18n for warnings and errors [core] - 10https://gerrit.wikimedia.org/r/321406 (https://phabricator.wikimedia.org/T37074) [17:15:19] (03PS2) 10Niedzielski: Use File page descriptions for picture of the day [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321084 (https://phabricator.wikimedia.org/T144109) [17:20:37] (03PS3) 10Ori.livneh: Don't report stats when page visibility changes during page load [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/319902 [17:23:05] (03CR) 10Jforrester: "Eran/Ed – is there a decision to make here?" [core] - 10https://gerrit.wikimedia.org/r/292041 (https://phabricator.wikimedia.org/T136641) (owner: 10Eranroz) [17:23:18] (03PS1) 10Esanders: VE: Fix combobox API and other issues [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/321691 (https://phabricator.wikimedia.org/T150555) [17:24:51] (03PS1) 10Jdlrobson: Don't show icon on talk button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321692 (https://phabricator.wikimedia.org/T142976) [17:28:19] (03PS1) 10Jforrester: Follow-up e681e5d: Correct typo in test comment [core] - 10https://gerrit.wikimedia.org/r/321693 [17:28:22] (03CR) 10Jforrester: mw.Message: Match behavior when key does not exist to PHP (031 comment) [core] - 10https://gerrit.wikimedia.org/r/321378 (owner: 10Bartosz Dziewoński) [17:28:48] (03CR) 10Jforrester: [C: 032] "Comment-only change." [core] - 10https://gerrit.wikimedia.org/r/321693 (owner: 10Jforrester) [17:29:15] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up e681e5d: Correct typo in test comment [core] - 10https://gerrit.wikimedia.org/r/321693 (owner: 10Jforrester) [17:29:24] (03PS1) 10Esanders: Update ComboBoxInputWidget API [extensions/Cite] - 10https://gerrit.wikimedia.org/r/321695 (https://phabricator.wikimedia.org/T150555) [17:29:50] (03PS1) 10Niedzielski: Remove Chinese wiki support from the news endpoint [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321696 (https://phabricator.wikimedia.org/T147874) [17:30:42] (03CR) 10Jforrester: [C: 032] "Whoops." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/321695 (https://phabricator.wikimedia.org/T150555) (owner: 10Esanders) [17:32:03] (03CR) 10Jforrester: [C: 032] VE: Fix combobox API and other issues [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/321691 (https://phabricator.wikimedia.org/T150555) (owner: 10Esanders) [17:32:38] (03PS4) 10WMDE-leszek: [WIP] Extend WikiDiff2 to show changes inside moved paragraphes [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/319866 (https://phabricator.wikimedia.org/T146781) (owner: 10WMDE-Fisch) [17:34:27] (03CR) 10jenkins-bot: [V: 04-1] Don't show icon on talk button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321692 (https://phabricator.wikimedia.org/T142976) (owner: 10Jdlrobson) [17:34:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Extend WikiDiff2 to show changes inside moved paragraphes [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/319866 (https://phabricator.wikimedia.org/T146781) (owner: 10WMDE-Fisch) [17:34:45] (03CR) 10Gergő Tisza: "> I note this means that trying to switch over to something like" [core] - 10https://gerrit.wikimedia.org/r/321602 (owner: 10Gergő Tisza) [17:36:20] (03PS2) 10Jdlrobson: Don't show icon on talk button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321692 (https://phabricator.wikimedia.org/T142976) [17:39:58] (03Merged) 10jenkins-bot: Follow-up e681e5d: Correct typo in test comment [core] - 10https://gerrit.wikimedia.org/r/321693 (owner: 10Jforrester) [17:42:40] (03Merged) 10jenkins-bot: Update ComboBoxInputWidget API [extensions/Cite] - 10https://gerrit.wikimedia.org/r/321695 (https://phabricator.wikimedia.org/T150555) (owner: 10Esanders) [17:42:42] (03Merged) 10jenkins-bot: VE: Fix combobox API and other issues [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/321691 (https://phabricator.wikimedia.org/T150555) (owner: 10Esanders) [17:43:39] (03CR) 10Kunalgrover05: "Yup, I mentioned in the CR description too." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321092 (https://phabricator.wikimedia.org/T150019) (owner: 10Kunalgrover05) [17:51:04] (03CR) 10Anomie: [C: 031] "Keep in mind that the whole point of loginOnly is that the wiki admin is wanting to stop using local passwords in favor of whatever other " [core] - 10https://gerrit.wikimedia.org/r/321602 (owner: 10Gergő Tisza) [17:51:10] (03CR) 10WMDE-leszek: "PS4 is a failed attempt of myself to make it build. Apparently code uses C++11 features, and that's why it fails. My hack added in PS4 doe" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/319866 (https://phabricator.wikimedia.org/T146781) (owner: 10WMDE-Fisch) [17:52:05] (03PS4) 10Anomie: API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 [17:53:59] (03CR) 10Jforrester: [C: 032] ApiSandbox: Don't use OO.ui.NumberInputWidget for limit fields [core] - 10https://gerrit.wikimedia.org/r/321395 (owner: 10Anomie) [17:56:36] (03PS1) 10Bartosz Dziewoński: mw.jqueryMsg: Match behavior when key does not exist to PHP [core] - 10https://gerrit.wikimedia.org/r/321697 [17:58:20] (03PS1) 10Niedzielski: Hygiene: remove EditTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321698 [18:02:35] (03Merged) 10jenkins-bot: ApiSandbox: Don't use OO.ui.NumberInputWidget for limit fields [core] - 10https://gerrit.wikimedia.org/r/321395 (owner: 10Anomie) [18:09:23] (03CR) 10jenkins-bot: [V: 04-1] mw.jqueryMsg: Match behavior when key does not exist to PHP [core] - 10https://gerrit.wikimedia.org/r/321697 (owner: 10Bartosz Dziewoński) [18:09:27] (03CR) 10jenkins-bot: [V: 04-1] API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 (owner: 10Anomie) [18:10:55] (03PS1) 10Niedzielski: Hygiene: remove unused show password icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321700 [18:12:38] (03PS4) 10BearND: Handle abusefilters in Wikidata description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T150704) [18:12:41] (03PS1) 10BearND: Hygiene: add base class for MW responses [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321701 [18:12:43] (03PS1) 10BearND: Add CentralAuthTokenClient [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321702 (https://phabricator.wikimedia.org/T150705) [18:12:45] (03PS1) 10BearND: Wikidata description editing flow for logged in users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321703 (https://phabricator.wikimedia.org/T150705) [18:12:55] Hello Devs, I am experiencing very serious issues with my Wikipedia accoun [18:12:58] *account [18:13:56] Someone else is using it to edit articles on Wikipedia and because of that, it has been blocked globally? I didn't do any of those edits to the US Presidents article but now I am punished for a crime I did not commit? [18:14:20] I don't understand the meaning of this, I have complained in #wikipedia but no one is replying [18:14:22] (03CR) 10Bartosz Dziewoński: "Hmm, '{{int:doesnt<>exist}}' is apparently a parse error… let's just remove this test. The output, being nothing, is clearly HTML-safe ;)" [core] - 10https://gerrit.wikimedia.org/r/321697 (owner: 10Bartosz Dziewoński) [18:14:43] I don't get it. How can someone be using my account? My account has been breached? [18:14:48] (03PS2) 10Bartosz Dziewoński: mw.jqueryMsg: Match behavior when key does not exist to PHP [core] - 10https://gerrit.wikimedia.org/r/321697 [18:15:02] d3r1ck: yes [18:16:51] MatmaRex: This is not good [18:17:21] d3r1ck: if you used the same password as for wikimedia sites anywhere else, most likely one of those services had leaked it. you should probably change your passwords to everything right now [18:17:25] How could this be? I am in the middle of serious use of my mediawiki account. [18:17:40] d3r1ck: you should contact wikimedia stewards about recovering your account [18:18:07] e.g. on #wikimedia-stewards on IRC [18:18:07] MatmaRex: how can I contact Wikimedia Stewards? How is that done? [18:18:16] https://meta.wikimedia.org/wiki/Stewards [18:18:40] d3r1ck: #wikimedia-stewards on IRC, or email stewards@wikimedia.org [18:18:43] (03PS2) 10GWicke: WIP: Add serviceworker build process [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/321565 [18:20:17] MatmaRex: Thans. Let me contact them right away. [18:20:26] MatmaRex: the account has been blocked globally [18:26:34] (03CR) 10jenkins-bot: [V: 04-1] mw.jqueryMsg: Match behavior when key does not exist to PHP [core] - 10https://gerrit.wikimedia.org/r/321697 (owner: 10Bartosz Dziewoński) [18:27:07] Hi d3r1ck [18:27:14] bawolff: Hi [18:27:31] Do you mind if I pm you? [18:28:14] (03PS9) 10Jdlrobson: Surface edits via kafka [services/trending-edits] - 10https://gerrit.wikimedia.org/r/320628 (https://phabricator.wikimedia.org/T145553) [18:30:27] (03PS3) 10Bartosz Dziewoński: mw.jqueryMsg: Match behavior when key does not exist to PHP [core] - 10https://gerrit.wikimedia.org/r/321697 [18:30:33] (03CR) 10jenkins-bot: [V: 04-1] Surface edits via kafka [services/trending-edits] - 10https://gerrit.wikimedia.org/r/320628 (https://phabricator.wikimedia.org/T145553) (owner: 10Jdlrobson) [18:32:03] (03CR) 10Brian Wolff: [C: 032] "looks good" [core] - 10https://gerrit.wikimedia.org/r/321697 (owner: 10Bartosz Dziewoński) [18:32:28] (03CR) 10Jdlrobson: "I can't work this out.. Any ideas services experts? :)" [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 (owner: 10Jdlrobson) [18:33:02] (03CR) 10Jforrester: [C: 032] ApiSandbox: Add text about limit's "max" value [core] - 10https://gerrit.wikimedia.org/r/321396 (owner: 10Anomie) [18:34:36] (03PS5) 10Anomie: API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 [18:40:09] (03Merged) 10jenkins-bot: mw.jqueryMsg: Match behavior when key does not exist to PHP [core] - 10https://gerrit.wikimedia.org/r/321697 (owner: 10Bartosz Dziewoński) [18:41:35] (03CR) 10Subramanya Sastry: "Sorry about the lengthy delay! this got lost in my review queue, but I'll test the Parsoid side of it and update the test." [core] - 10https://gerrit.wikimedia.org/r/296064 (owner: 10Umherirrender) [18:41:47] (03PS2) 10Subramanya Sastry: Add parser test for "Piped link with empty link text" [core] - 10https://gerrit.wikimedia.org/r/296064 (owner: 10Umherirrender) [18:43:03] (03PS3) 10GWicke: WIP: Add serviceworker build process [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/321565 [18:43:34] (03Merged) 10jenkins-bot: ApiSandbox: Add text about limit's "max" value [core] - 10https://gerrit.wikimedia.org/r/321396 (owner: 10Anomie) [18:47:42] (03PS1) 10Gergő Tisza: Add emailauth role [vagrant] - 10https://gerrit.wikimedia.org/r/321705 [18:51:57] (03PS3) 10Subramanya Sastry: Add parser test for "Piped link with empty link text" [core] - 10https://gerrit.wikimedia.org/r/296064 (owner: 10Umherirrender) [18:52:15] (03CR) 10jenkins-bot: [V: 04-1] API: Add deprecation warnings for Iae0e2ce3 [core] - 10https://gerrit.wikimedia.org/r/321407 (owner: 10Anomie) [18:57:47] 10Wikimedia-Blog: Overlaid captions obscure the content of images - https://phabricator.wikimedia.org/T131074#2796671 (10EdErhart-WMF) Fair point. [18:57:52] 10Wikimedia-Blog: Overlaid captions obscure the content of images - https://phabricator.wikimedia.org/T131074#2796672 (10EdErhart-WMF) 05stalled>03declined [18:59:23] (03PS2) 10BearND: Wikidata description editing flow for logged in users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321703 (https://phabricator.wikimedia.org/T150705) [18:59:25] (03PS2) 10BearND: Add CentralAuthTokenClient [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321702 (https://phabricator.wikimedia.org/T150705) [18:59:27] (03PS5) 10BearND: Handle abusefilters in Wikidata description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T150704) [18:59:55] 10Wikimedia-Blog: Automatic summary is truncated, duplicated, sometimes irrelevant - https://phabricator.wikimedia.org/T131076#2796676 (10EdErhart-WMF) We're working on getting the theme so we can tweak it in-house, so it's stalled for now, but we'll either be able to fix it or will have to decline as too diffic... [18:59:58] (03CR) 10BearND: [C: 032] Hygiene: remove EditTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321698 (owner: 10Niedzielski) [19:00:22] (03CR) 10BearND: [C: 032] Hygiene: remove unused show password icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321700 (owner: 10Niedzielski) [19:01:44] (03CR) 10BearND: Handle abusefilters in Wikidata description editing (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T150704) (owner: 10BearND) [19:03:31] (03CR) 10jenkins-bot: [V: 04-1] Wikidata description editing flow for logged in users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321703 (https://phabricator.wikimedia.org/T150705) (owner: 10BearND) [19:04:33] 10Phabricator, 07LDAP: "LDAP record query returned more than one result. The query must uniquely identify a record." when trying to log in via LDAP - https://phabricator.wikimedia.org/T138653#2796713 (10demon) [19:04:35] 10Phabricator, 07LDAP: Having difficulty logging into Phabricator via LDAP when multiple accounts returned for username - https://phabricator.wikimedia.org/T138672#2796716 (10demon) [19:04:52] (03Merged) 10jenkins-bot: Hygiene: remove EditTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321698 (owner: 10Niedzielski) [19:08:09] (03Merged) 10jenkins-bot: Hygiene: remove unused show password icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321700 (owner: 10Niedzielski) [19:09:07] 10ORES, 06Research-and-Data, 10Research-management: ORES (a 2-3 minute presentation) - https://phabricator.wikimedia.org/T150544#2789195 (10Halfak) Thanks @Capt_Swing. I'll make sure that gets highlighted. [19:09:28] (03CR) 10jenkins-bot: [V: 04-1] Add CentralAuthTokenClient [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321702 (https://phabricator.wikimedia.org/T150705) (owner: 10BearND) [19:09:30] 10CirrusSearch, 06Discovery, 06Discovery-Search: CirrusSearch does not index redirects, removing them from autosuggest in the search box - https://phabricator.wikimedia.org/T146678#2796735 (10maiden_taiwan) @dcausse - Thank you //so much// for that information! We'll try it out. [19:09:47] 10Wikimedia-Site-requests: Make __NOINDEX__ work on all namespaces on Meta-Wiki - https://phabricator.wikimedia.org/T150245#2796736 (10Dereckson) a:03Dereckson [19:13:01] (03CR) 10jenkins-bot: [V: 04-1] Handle abusefilters in Wikidata description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T150704) (owner: 10BearND) [19:14:33] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2796768 (10Quiddity) I recommend the basic table approach, as used by TheDJ [[https://www.mediawiki.org/w/index.php?titl... [19:16:34] (03CR) 10Mattflaschen: "Verify this also fixes T150552." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/311856 (https://phabricator.wikimedia.org/T85030) (owner: 10Mattflaschen) [19:20:26] (03PS1) 10TheDJ: Correct flex display for thumbnail contents on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321708 (https://phabricator.wikimedia.org/T150706) [19:20:55] 10MediaWiki-Special-pages, 06Collaboration-Team-Triage, 10Flow: Flow links are not parsed in special:whatlinkshere - https://phabricator.wikimedia.org/T150615#2791113 (10Mattflaschen-WMF) So it's only when you transclude Special:WhatLinksHere, not when you visit it? [19:22:07] (03PS2) 10TheDJ: Correct flex display for thumbnail contents on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321708 (https://phabricator.wikimedia.org/T150706) [19:30:28] (03CR) 10Niedzielski: [C: 04-1] "Nice refactor. Very minor feedback inline." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321701 (owner: 10BearND) [19:33:18] (03CR) 10Mholloway: [C: 031] Remove Chinese wiki support from the news endpoint [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321696 (https://phabricator.wikimedia.org/T147874) (owner: 10Niedzielski) [19:34:15] (03PS1) 10Legoktm: Update lint errors via the job queue [extensions/Linter] - 10https://gerrit.wikimedia.org/r/321709 [19:35:06] 10Phabricator (Upstream), 07Upstream: Distinguish "mentions" from "subscribers" - https://phabricator.wikimedia.org/T150766#2795792 (10Quiddity) Related upstream tasks: * https://secure.phabricator.com/T9031 "When I ignore subscription changes, I'm not notified of being cc'ed" * https://secure.phabricator.com/... [19:35:39] (03PS1) 10Legoktm: Allow blocked users to use Special:CiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/321710 (https://phabricator.wikimedia.org/T150791) [19:36:56] (03PS10) 10Ppchelko: Surface edits via kafka [services/trending-edits] - 10https://gerrit.wikimedia.org/r/320628 (https://phabricator.wikimedia.org/T145553) (owner: 10Jdlrobson) [19:40:08] 10MediaWiki-Special-pages, 06Collaboration-Team-Triage, 10Flow: Flow links are not parsed in special:whatlinkshere - https://phabricator.wikimedia.org/T150615#2796839 (10IKhitron) Even more, a transclusion to my draft looks well. I have no idea what happens there. [19:40:41] (03CR) 10jenkins-bot: [V: 04-1] Surface edits via kafka [services/trending-edits] - 10https://gerrit.wikimedia.org/r/320628 (https://phabricator.wikimedia.org/T145553) (owner: 10Jdlrobson) [19:41:54] 10Wikimedia-Site-requests, 13Patch-For-Review: Make __NOINDEX__ work on all namespaces on Meta-Wiki - https://phabricator.wikimedia.org/T150245#2796846 (10Dereckson) @MarcoAurelio Could you discuss the issue on https://meta.wikimedia.org/wiki/Meta:Babel? [19:47:59] (03CR) 10Esanders: [C: 032] Make /*jshint -W024*/ global to allow 'static' as property [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [19:48:45] (03CR) 10Legoktm: [C: 032] API: Fix tbnooverride parameter type [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/321655 (owner: 10Anomie) [19:52:34] 10MediaWiki-User-blocking: Global IP block not preventing the display of a FormSpecialPage even if requiresUnblock returns true - https://phabricator.wikimedia.org/T150796#2796877 (10Orlodrim) [19:53:03] ebernhardson: ping [19:56:02] (03PS1) 10Legoktm: Don't require write access for Special:CiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/321716 [19:56:13] (03PS3) 10BearND: Wikidata description editing flow for logged in users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321703 (https://phabricator.wikimedia.org/T150705) [19:56:15] (03PS3) 10BearND: Add CentralAuthTokenClient [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321702 (https://phabricator.wikimedia.org/T150705) [19:56:17] (03Merged) 10jenkins-bot: API: Fix tbnooverride parameter type [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/321655 (owner: 10Anomie) [19:56:19] (03PS6) 10BearND: Handle abusefilters in Wikidata description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T150704) [19:56:53] 06Discovery, 06Discovery-Analysis (Current work): Google-referred desktop traffic decline vs overall desktop traffic decline - https://phabricator.wikimedia.org/T149355#2796903 (10Tbayer) >>! In T149355#2793351, @mpopov wrote: ... > @Tbayer Thanks for pointing out the inflation! I'm not sure how to correct tha... [19:57:49] 10Wikimedia-Site-requests, 13Patch-For-Review: Make __NOINDEX__ work on all namespaces on Meta-Wiki - https://phabricator.wikimedia.org/T150245#2779089 (10Jdforrester-WMF) Alternatively we could just declare NS0 to not be content for meta, which would be more accurate perhaps? [19:58:51] gwicke: pong [19:59:35] ebernhardson: hey, the recent discussion around high volume search access reminds me about the idea of making those API entry points more cacheable at the Varnish level [20:00:42] gwicke: technically, as long as you are logged out, the opensearch is cached in varnish. The problem is generator usage is not [20:01:18] yeah [20:01:23] (03CR) 10jenkins-bot: [V: 04-1] Make /*jshint -W024*/ global to allow 'static' as property [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [20:01:47] (03CR) 10Bartosz Dziewoński: [C: 032] "derp" [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [20:02:22] we do have cached page summaries in varnish & RB as well, and a generic hydration mechanism that's fairly efficient [20:02:41] so if you are interested in exploring the options in that space a bit more, let us know [20:02:51] (03PS12) 10Nuria: node-rdkafka event.stats callback that reports stats to statsd [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/319671 (https://phabricator.wikimedia.org/T145099) [20:04:00] ebernhardson: this is the summary end point that's used by the apps & will be used by hovercards as well: https://en.wikipedia.org/api/rest_v1/#!/Page_content/get_page_summary_title [20:04:07] 06Developer-Relations, 10Outreachy: Provide a group chat system for mentoring - https://phabricator.wikimedia.org/T150732#2796914 (10jayvdb) I am not advocating that IRC should be replaced. It is great for many purposes (I said that in the opening sentence), especially when lots of custom IRC bots are created... [20:06:34] (03CR) 10BearND: [C: 032] Remove Chinese wiki support from the news endpoint [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321696 (https://phabricator.wikimedia.org/T147874) (owner: 10Niedzielski) [20:06:52] gwicke: i suppose my worry is things end up very special cased, for example would need a specific endpoint for whatever set of properties this particular user is trying to fetch [20:07:42] although i suppose if it's cached, they could just fan out instead with first the opensearch, then hitting restbase per-title [20:07:51] ebernhardson: yeah, that's definitely something we are trying to avoid by defining a single summary to cover the vast majority of cases [20:08:09] fan out sounds a little dangerous to me though, depends on hit rates :) [20:08:24] (03CR) 10Esanders: "Follow-up question about unused var "fileStr"" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247513 (https://phabricator.wikimedia.org/T115863) (owner: 10Prtksxna) [20:08:36] the hydration part handles the fan-out internally [20:09:32] oh, interesting [20:09:41] basically, a backend service can return `$merge: ["https://en.wikipedia.org/api/rest_v1/page/summary/Sometitle"]`, which the frontend will then replace (hydrate) with the target content(s) [20:10:25] the goal is definitely to hit caches for each of those fragments [20:10:41] so no fine control over which properties to include [20:11:03] (03CR) 10jenkins-bot: [V: 04-1] Make /*jshint -W024*/ global to allow 'static' as property [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [20:11:04] instead, define one response that tries to cover the vast majority of cases [20:11:32] even if it includes one or two properties more than needed in some cases [20:12:44] that makes sense [20:13:17] sounds like it woulfnt be much then to proxy to opensearch api and augment, if this user is interested [20:13:39] 10Outreachy, 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Actions to grow the diversity of our technical community - https://phabricator.wikimedia.org/T148598#2727385 (10Psychoslave) I think that T150417 would fall into the way to leverage technical barrier and grow our technica... [20:14:42] ebernhardson: do you think it would be useful for you to set up a meeting & brainstorm issues and options? [20:18:44] gwicke: i suppose it depends if we have a user (or maybe build it and they will come? dunno). For our current prod use cases i don't know if we need the extra info (although, i suppose pageimage's are coming to autocomplete) [20:20:25] 06Developer-Relations (Oct-Dec-2016), 10Wikimedia-Developer-Summit (2017): Drawing in new MW tech volunteers with Hackathons, and then what - https://phabricator.wikimedia.org/T148557#2796951 (1001tonythomas) [20:21:52] (03CR) 10Chad: [C: 032] "Kinda lame that requiresUnblock() defaults to true, but w/e :)" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/321710 (https://phabricator.wikimedia.org/T150791) (owner: 10Legoktm) [20:21:56] ebernhardson: my idea was more to sync up on what we are up to respectively, and see if there is anything we could help with [20:22:23] 10MediaWiki-Internationalization, 03Google-Code-In-2016: [CGI template easy task] Find and fix syntax errors in translated messages - https://phabricator.wikimedia.org/T148121#2796956 (10Psychoslave) Ok, sorry for the misunderstanding. [20:23:03] (03Merged) 10jenkins-bot: Allow blocked users to use Special:CiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/321710 (https://phabricator.wikimedia.org/T150791) (owner: 10Legoktm) [20:24:46] gwicke: we could i suppose, but my roadmap atm is more in the direction of cross-wiki results, es version upgrades, ML models for re-ordering top N results, not particularly related to updated api endpoints [20:25:15] (03PS13) 10Nuria: node-rdkafka event.stats callback that reports stats to statsd [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/319671 (https://phabricator.wikimedia.org/T145099) [20:27:05] 10MediaWiki-General-or-Unknown, 10MediaWiki-Page-editing, 10VisualEditor, 07Browser-Support-Apple-Safari, 07Regression: Some odd scrolling occurs on load, so the aimed section is not visible anymore, in Safari (?) - https://phabricator.wikimedia.org/T150135#2796967 (10Jdforrester-WMF) 05Open>03stalled... [20:27:17] 10Reading-Community-Engagement, 10Wikimedia-General-or-Unknown, 07Mobile: Bug: Text/Alignment issues in certain English Wikipedia portal pages - https://phabricator.wikimedia.org/T120238#2796972 (10Lbertolotti) Another bug from Android, Category pages are not visualizing: https://en.wikipedia.org/wiki/Catego... [20:27:28] 06Wikipedia-Android-App-Backlog, 07Technical-Debt: PageActivity should not have page load logic in it - https://phabricator.wikimedia.org/T150797#2796973 (10Niedzielski) [20:28:29] 10MediaWiki-General-or-Unknown, 10MediaWiki-Page-editing, 10VisualEditor, 07Browser-Support-Apple-Safari, 07Regression: Some odd scrolling occurs on load, so the aimed section is not visible anymore, in Safari (?) - https://phabricator.wikimedia.org/T150135#2774965 (10Jdforrester-WMF) I've tested this in... [20:28:30] (03CR) 10Ottomata: [C: 031] "Cool! Let's try this in labs." [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/319671 (https://phabricator.wikimedia.org/T145099) (owner: 10Nuria) [20:28:51] ebernhardson: okay, fair enough; I still think that we could use a bit more communication between discovery & services in particular, but understood that it's not top priority for you right now. [20:29:21] (03CR) 10Ppchelko: "Could you publish it on npm so that I could make a patch for change prop and try it in our context?" [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/319671 (https://phabricator.wikimedia.org/T145099) (owner: 10Nuria) [20:29:42] 10MediaWiki-General-or-Unknown, 10MediaWiki-Page-editing, 10VisualEditor: At click, do not do intempestive page scrolling, and put the cursor at the clicked place - https://phabricator.wikimedia.org/T150139#2796989 (10Jdforrester-WMF) 05Open>03stalled Though I understand that this is different from {T150... [20:31:40] 10Wikimedia-Site-requests, 13Patch-For-Review: Make __NOINDEX__ work on all namespaces on Meta-Wiki - https://phabricator.wikimedia.org/T150245#2796994 (10Dereckson) >>! In T150245#2796907, @Jdforrester-WMF wrote: > Alternatively we could just declare NS0 to not be content for meta, which would be more accurat... [20:34:23] (03CR) 10Arlolra: [C: 032] Add parser test for "Piped link with empty link text" [core] - 10https://gerrit.wikimedia.org/r/296064 (owner: 10Umherirrender) [20:35:04] (03PS1) 10Legoktm: Allow blocked users to use Special:CiteThisPage [extensions/CiteThisPage] (REL1_28) - 10https://gerrit.wikimedia.org/r/321723 (https://phabricator.wikimedia.org/T150791) [20:35:08] (03CR) 10Legoktm: [C: 032] Allow blocked users to use Special:CiteThisPage [extensions/CiteThisPage] (REL1_28) - 10https://gerrit.wikimedia.org/r/321723 (https://phabricator.wikimedia.org/T150791) (owner: 10Legoktm) [20:36:15] (03CR) 10Jforrester: [C: 032] Don't require write access for Special:CiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/321716 (owner: 10Legoktm) [20:37:45] (03CR) 10Jforrester: "I thought this functionality had been vetoed?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320718 (https://phabricator.wikimedia.org/T150419) (owner: 10Legoktm) [20:39:16] (03CR) 10Esanders: "recheck" [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [20:39:39] (03PS3) 10Esanders: Make /*jshint -W024*/ global to allow 'static' as property [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [20:43:06] (03Merged) 10jenkins-bot: Add parser test for "Piped link with empty link text" [core] - 10https://gerrit.wikimedia.org/r/296064 (owner: 10Umherirrender) [20:43:10] (03Merged) 10jenkins-bot: Allow blocked users to use Special:CiteThisPage [extensions/CiteThisPage] (REL1_28) - 10https://gerrit.wikimedia.org/r/321723 (https://phabricator.wikimedia.org/T150791) (owner: 10Legoktm) [20:43:14] (03Merged) 10jenkins-bot: Don't require write access for Special:CiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/321716 (owner: 10Legoktm) [20:43:22] 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Run load tests of cross-project searching to verify its stability - https://phabricator.wikimedia.org/T149740#2797004 (10EBernhardson) Initial 5% deployment had no noticable change to our load or lat... [20:46:23] (03CR) 10Legoktm: "I re-read T49946 and didn't see any kind of veto, just concerns about technical implementation. Unless you were thinking of a different ta" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320718 (https://phabricator.wikimedia.org/T150419) (owner: 10Legoktm) [20:50:30] 10Android-app-Bugs, 06Wikipedia-Android-App-Backlog: Changing system language doesn't invalidate feed card cache - https://phabricator.wikimedia.org/T150798#2797013 (10Niedzielski) [20:50:32] 10CirrusSearch, 06Discovery, 06Discovery-Search: CompletionSuggester produces IndexCreationException in CirrusSearch - https://phabricator.wikimedia.org/T150799#2797027 (10maiden_taiwan) [20:53:22] 10CirrusSearch, 06Discovery, 06Discovery-Search: CompletionSuggester produces IndexCreationException in CirrusSearch - https://phabricator.wikimedia.org/T150799#2797027 (10EBernhardson) This looks to be attempting to use the icu plugin[1], but it's not installed to your cluster. Can you verify it's not avail... [20:55:26] 10Connected-Open-Heritage-Batch-uploads: Create collaboration template on Wikimedia Commons for Connected Open Heritage - https://phabricator.wikimedia.org/T140782#2797068 (10Lokal_Profil) Ping to all of you that the vote has been concluded https://meta.wikimedia.org/wiki/Connected_Open_Heritage/Get_Involved/Logo [20:57:55] (03PS14) 10Nuria: node-rdkafka event.stats callback that reports stats to statsd [node-rdkafka-statsd] - 10https://gerrit.wikimedia.org/r/319671 (https://phabricator.wikimedia.org/T145099) [20:58:08] (03PS1) 10Legoktm: Don't require write access for Special:CiteThisPage [extensions/CiteThisPage] (REL1_28) - 10https://gerrit.wikimedia.org/r/321729 [20:58:12] (03CR) 10Legoktm: [C: 032] Don't require write access for Special:CiteThisPage [extensions/CiteThisPage] (REL1_28) - 10https://gerrit.wikimedia.org/r/321729 (owner: 10Legoktm) [20:58:23] 10Connected-Open-Heritage-Batch-uploads: Select logo for Conected Open Heritage - https://phabricator.wikimedia.org/T150801#2797069 (10Lokal_Profil) [20:58:34] (03CR) 10Arlolra: "recheck" [core] - 10https://gerrit.wikimedia.org/r/311849 (https://phabricator.wikimedia.org/T146304) (owner: 10C. Scott Ananian) [20:58:58] (03CR) 10Jforrester: "> I re-read T49946 and didn't see any kind of veto, just concerns about technical implementation. Unless you were thinking of a different " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/320718 (https://phabricator.wikimedia.org/T150419) (owner: 10Legoktm) [21:01:17] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2797094 (10chelsyx) In the [[ https://wikimedia-research.github.io/Discovery-Search-Test-BM25/#search_clustering | analysis ]] for the first BM25 test, @mpopov use Levenshtein (... [21:01:41] (03Merged) 10jenkins-bot: Don't require write access for Special:CiteThisPage [extensions/CiteThisPage] (REL1_28) - 10https://gerrit.wikimedia.org/r/321729 (owner: 10Legoktm) [21:04:57] (03CR) 10Esanders: "recheck" [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [21:05:42] 10Android-app-Bugs, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Android app missing translations for Featured article cards - https://phabricator.wikimedia.org/T150549#2797105 (10Niedzielski) 05Open>03Invalid p:05Triage>03Normal @Quiddity, thanks for the high quality report! I don't th... [21:06:59] (03PS1) 10Esanders: Fix typo in #getDateFromExif [core] - 10https://gerrit.wikimedia.org/r/321731 [21:07:02] (03PS1) 10Esanders: build: Replace jscs+jshint with eslint [core] - 10https://gerrit.wikimedia.org/r/321732 [21:07:06] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 10ChangeProp, 10Citoid, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2797114 (10GWicke) @akosiaris, thank you for taking care of etherpad! Overall, the only remaining service that still needs some work is kartoth... [21:07:19] 06Discovery, 06Discovery-Analysis (Current work): Compare ZRR for query features across other search engines - https://phabricator.wikimedia.org/T136377#2797117 (10debt) 05Open>03Resolved Thanks, all, resolving this ticket! [21:07:57] (03CR) 10Kaldari: [C: 032] Add first letter data for bn collation (Standard and Traditional) [core] - 10https://gerrit.wikimedia.org/r/318260 (https://phabricator.wikimedia.org/T148885) (owner: 10Brian Wolff) [21:08:33] (03CR) 10jenkins-bot: [V: 04-1] Add first letter data for bn collation (Standard and Traditional) [core] - 10https://gerrit.wikimedia.org/r/318260 (https://phabricator.wikimedia.org/T148885) (owner: 10Brian Wolff) [21:10:19] 10Datasets-General-or-Unknown, 07Privacy: Information leak on wikidata-externalid-url - https://phabricator.wikimedia.org/T150803#2797140 (10jeblad) [21:11:54] 06Discovery-Analysis: Investigate intriguing behaviors in search metrics for desktop events - https://phabricator.wikimedia.org/T150539#2797157 (10debt) p:05Triage>03Normal [21:11:57] (03PS1) 10JGirault: Convert tabs to spaces according to the project [mapdata] - 10https://gerrit.wikimedia.org/r/321734 [21:12:37] 06Discovery, 06Discovery-Analysis (Current work): Investigate intriguing behaviors in search metrics for desktop events - https://phabricator.wikimedia.org/T150539#2788949 (10debt) [21:14:05] 10CirrusSearch, 06Discovery, 06Discovery-Search: CompletionSuggester produces IndexCreationException in CirrusSearch - https://phabricator.wikimedia.org/T150799#2797166 (10maiden_taiwan) Here you go: ``` $ /usr/share/elasticsearch/bin/plugin --list Installed plugins: - experimental-highlighter-elasticse... [21:14:24] 06Developer-Relations: Wikimedia Workshop: Installation of MediaWiki (development env) and learning of VisualEditor (writing articles on Wikipedia) - https://phabricator.wikimedia.org/T149893#2797168 (10Eugene233) [21:14:54] 06Discovery, 06Discovery-Analysis: Implement the wiki/language selector in more search dashboards - https://phabricator.wikimedia.org/T150410#2797169 (10debt) [21:15:27] (03PS1) 10MarcoAurelio: Make two-factor messages use consistent wording [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321738 (https://phabricator.wikimedia.org/T150597) [21:15:36] 06Discovery, 06Discovery-Analysis: [Dashboard][Search] Sparklines for KPIs - https://phabricator.wikimedia.org/T150215#2797174 (10debt) [21:15:38] 10Datasets-General-or-Unknown, 07Privacy: Information leak on wikidata-externalid-url - https://phabricator.wikimedia.org/T150803#2797175 (10jeblad) Seriously, is it necessary to create an information leak for [[https://github.com/arthurpsmith/wikidata-tools/blob/master/wikidata-externalid-url/index.php | this... [21:15:49] 06Discovery, 06Discovery-Analysis (Current work): Add "well-behaved searchers" filter to dashboards - https://phabricator.wikimedia.org/T150370#2797176 (10debt) [21:17:16] 06Discovery, 06Discovery-Analysis (Current work), 07Epic: [EPIC] Learn about our databases and how to use them - https://phabricator.wikimedia.org/T143128#2797184 (10debt) yay! [21:18:21] (03PS2) 10MarcoAurelio: Make OATHAuth messages use consistent "two-factor authentication" wording [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/321738 (https://phabricator.wikimedia.org/T150597) [21:19:46] (03CR) 10MaxSem: [C: 032] Convert tabs to spaces according to the project [mapdata] - 10https://gerrit.wikimedia.org/r/321734 (owner: 10JGirault) [21:19:50] 10MediaWiki-extensions-OATHAuth, 10MediaWiki-extensions-TwoFactorAuthentication, 07I18n, 13Patch-For-Review: Messages related to two-factor authentication are not consistent - https://phabricator.wikimedia.org/T150597#2797193 (10MarcoAurelio) I've changed some messages but not on qqq.json as the Wikipedia... [21:20:08] (03Merged) 10jenkins-bot: Convert tabs to spaces according to the project [mapdata] - 10https://gerrit.wikimedia.org/r/321734 (owner: 10JGirault) [21:20:10] (03PS1) 10JGirault: eslint: Re-enable wrap-iife and partially enable dot-notation [mapdata] - 10https://gerrit.wikimedia.org/r/321739 [21:20:41] (03CR) 10JGirault: "Same as https://gerrit.wikimedia.org/r/#/c/321647/" [mapdata] - 10https://gerrit.wikimedia.org/r/321739 (owner: 10JGirault) [21:21:54] (03CR) 10Jforrester: [C: 04-1] "Close. Let's get this merged quickly as it'll conflict with pretty much everything. :-(" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/321732 (owner: 10Esanders) [21:23:17] (03CR) 10Jforrester: [C: 032] Make /*jshint -W024*/ global to allow 'static' as property [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [21:26:07] (03PS3) 10MarcoAurelio: Create a "centralnotice-shared-help-translate' temporary [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) [21:26:45] (03CR) 10MarcoAurelio: "Made the message optional in PS3" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/321639 (https://phabricator.wikimedia.org/T150750) (owner: 10MarcoAurelio) [21:27:13] 10MediaWiki-extensions-Page_Forms: Allowed values are no longer added when using special page "CreateClass" - https://phabricator.wikimedia.org/T150657#2797225 (10Yaron_Koren) 05Open>03Resolved a:03Yaron_Koren Sorry about that! I think I just fixed it. This was another issue related to the changeover to "P... [21:27:22] (03CR) 10Jforrester: "Also this needs to delete .jshintrc etc." [core] - 10https://gerrit.wikimedia.org/r/321732 (owner: 10Esanders) [21:28:07] (03PS2) 10Jforrester: build: Bump various devDependencies to latest [core] - 10https://gerrit.wikimedia.org/r/303501 [21:29:08] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2797231 (10TJones) @chelsyx: Good catch on the edit distance and Chinese. I believe @mpopov had to play around with the parameters a bit to find good ones for English query refo... [21:30:05] 06Discovery, 06Discovery-Analysis: Can we align Discernatron data with search user engagement data? - https://phabricator.wikimedia.org/T148604#2797235 (10mpopov) We decided not to go forward with this task. The Search Satisfaction event logging and Discernatron ranking datasets are two totally different and s... [21:30:08] 10Android-app-Bugs, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Android app missing translations for Featured article cards - https://phabricator.wikimedia.org/T150549#2797236 (10Quiddity) @Niedzielski Are there featured article feeds for any other languages? As above, I did also try this in F... [21:30:21] 06Team-Practices (This-Week): Write up Facilitator role for Annual Planning Retrospective - https://phabricator.wikimedia.org/T150805#2797237 (10ksmith) [21:31:03] 06Team-Practices (This-Week): Write up Facilitator role for Annual Planning Retrospective - https://phabricator.wikimedia.org/T150805#2797251 (10ksmith) Awaiting comments via email from @Awjrichards. [21:31:07] 06Team-Practices (This-Week): Write up Facilitator role for Annual Planning Retrospective - https://phabricator.wikimedia.org/T150805#2797254 (10ksmith) p:05Triage>03High [21:31:19] (03Merged) 10jenkins-bot: Make /*jshint -W024*/ global to allow 'static' as property [core] - 10https://gerrit.wikimedia.org/r/319392 (owner: 10Bartosz Dziewoński) [21:34:34] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Create a schedule table for sessions in a grid format for the developer summit - https://phabricator.wikimedia.org/T150150#2797264 (10Qgil) The priority is to have an informative and nice-looking schedule that is usable both on desktop and mob... [21:35:10] (03CR) 10Bartosz Dziewoński: [C: 032] Fix typo in #getDateFromExif [core] - 10https://gerrit.wikimedia.org/r/321731 (owner: 10Esanders) [21:36:53] (03CR) 10jenkins-bot: [V: 04-1] build: Bump various devDependencies to latest [core] - 10https://gerrit.wikimedia.org/r/303501 (owner: 10Jforrester) [21:37:23] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2797267 (10chelsyx) Thanks @TJones ! I will finish the analysis as soon as possible. [21:38:00] (03PS1) 10Sbisson: [WIP] Special:RC filter: userExpLevel [core] - 10https://gerrit.wikimedia.org/r/321744 (https://phabricator.wikimedia.org/T149637) [21:41:41] 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Featured articles should support more languages - https://phabricator.wikimedia.org/T150806#2797272 (10Niedzielski) [21:45:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Special:RC filter: userExpLevel [core] - 10https://gerrit.wikimedia.org/r/321744 (https://phabricator.wikimedia.org/T149637) (owner: 10Sbisson) [21:46:36] (03CR) 10jenkins-bot: [V: 04-1] Fix typo in #getDateFromExif [core] - 10https://gerrit.wikimedia.org/r/321731 (owner: 10Esanders) [21:51:47] (03CR) 10Arlolra: [C: 032] Log request source information passed along from PHP. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/314177 (https://phabricator.wikimedia.org/T97030) (owner: 10C. Scott Ananian) [21:52:18] (03CR) 10BearND: [C: 04-1] "It's getting close" (037 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/320712 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [21:53:04] (03Merged) 10jenkins-bot: Log request source information passed along from PHP. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/314177 (https://phabricator.wikimedia.org/T97030) (owner: 10C. Scott Ananian) [21:54:11] (03CR) 10Arlolra: [C: 032 V: 032] Revert "Add en.wiktionary.org to blacklist temporarily to prevent DoS." [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/314058 (https://phabricator.wikimedia.org/T147211) (owner: 10C. Scott Ananian) [21:54:54] (03CR) 10Jforrester: [C: 032] "Sucky unit tests are sucky." [core] - 10https://gerrit.wikimedia.org/r/321731 (owner: 10Esanders) [21:55:30] (03CR) 10BearND: [C: 04-1] "Looks good, just a string nit." (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321548 (https://phabricator.wikimedia.org/T150685) (owner: 10Mholloway) [21:57:52] 06Editing-Analysis: Calculate monthly mobile Wikipedia edits for Major Gifts report - https://phabricator.wikimedia.org/T149710#2797299 (10Neil_P._Quinn_WMF) [21:59:08] 06Editing-Analysis: Calculate monthly mobile Wikipedia edits for Major Gifts report - https://phabricator.wikimedia.org/T149710#2760395 (10Neil_P._Quinn_WMF) 05Open>03Resolved Done! Results are in the spreadsheet linked in the description. @JCuriel, let me know if you have any questions. [21:59:40] 06Wikipedia-Android-App-Backlog: App language should replace system language - https://phabricator.wikimedia.org/T142019#2797302 (10Niedzielski) p:05Triage>03High [22:00:14] (03PS1) 10Ottomata: Updates to package.json to use tagged kafka-sse [services/eventstreams] - 10https://gerrit.wikimedia.org/r/321782 [22:01:04] (03CR) 10Ottomata: [C: 032 V: 032] Updates to package.json to use tagged kafka-sse [services/eventstreams] - 10https://gerrit.wikimedia.org/r/321782 (owner: 10Ottomata) [22:01:49] (03PS13) 10Fjalapeno: Add announcements endpoint [services/mobileapps] - 10https://gerrit.wikimedia.org/r/320712 (https://phabricator.wikimedia.org/T145830) [22:02:18] (03CR) 10Fjalapeno: Add announcements endpoint (036 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/320712 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [22:03:03] (03Merged) 10jenkins-bot: Fix typo in #getDateFromExif [core] - 10https://gerrit.wikimedia.org/r/321731 (owner: 10Esanders) [22:03:19] (03PS1) 10Ottomata: Update eventstreams [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/321792 [22:03:28] (03CR) 10Ottomata: [C: 032 V: 032] Update eventstreams [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/321792 (owner: 10Ottomata) [22:03:57] (03CR) 10Dzahn: "needs to be submitted/deployed ?" [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/314058 (https://phabricator.wikimedia.org/T147211) (owner: 10C. Scott Ananian) [22:04:22] 10Android-app-Bugs, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Android app missing translations for Featured article cards - https://phabricator.wikimedia.org/T150549#2797311 (10Niedzielski) @Quiddity, I believe featured articles are only available in English currently. All other languages ar... [22:04:27] (03CR) 10jenkins-bot: [V: 04-1] Add announcements endpoint [services/mobileapps] - 10https://gerrit.wikimedia.org/r/320712 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [22:05:28] 06Security-Team, 10Wikimedia-Site-requests, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797316 (10MarcoAurelio) [22:05:35] 10Android-app-Bugs, 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: Android app missing translations for Featured article cards - https://phabricator.wikimedia.org/T150549#2797329 (10Niedzielski) BTW T142019 has been on our mental radar for a long time but never quite formalized in a ticket until... [22:08:12] (03CR) 10Cindy-the-browser-test-bot: "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321752 (owner: 10L10n-bot) [22:08:21] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/321752 (owner: 10L10n-bot) [22:08:58] (03PS1) 10Mooeypoo: Fix 'getTimestamp' default check in NotificationItem unit test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/321793 [22:09:03] 10New-Readers, 06Reading-Web-Backlog: Create Hindi and Spanish language versions of all 3 prototypes - https://phabricator.wikimedia.org/T150808#2797334 (10atgo) [22:09:16] 04(no projects): Expose EXIF data to search engine - https://phabricator.wikimedia.org/T150809#2797348 (10CKoerner_WMF) [22:09:24] (03PS1) 10Ottomata: Update eventstreams to 6d957a4 [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/321794 [22:09:34] 10CirrusSearch, 06Discovery, 06Discovery-Search: Expose EXIF data to search engine - https://phabricator.wikimedia.org/T150809#2797359 (10CKoerner_WMF) [22:09:36] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Reduce password reset spam - https://phabricator.wikimedia.org/T145952#2797361 (10tstarling) [22:09:48] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Reduce password reset spam - https://phabricator.wikimedia.org/T145952#2646063 (10tstarling) What is wrong with eliminating the problem? [22:10:04] (03CR) 10Ottomata: [C: 032 V: 032] Update eventstreams to 6d957a4 [services/eventstreams/deploy] - 10https://gerrit.wikimedia.org/r/321794 (owner: 10Ottomata) [22:10:36] 10CirrusSearch, 06Discovery, 06Discovery-Search: Expose EXIF data to search engine - https://phabricator.wikimedia.org/T150809#2797363 (10CKoerner_WMF) @Smalyshev could you provide some feedback on the feasibility of this task? [22:12:47] (03CR) 10Gergő Tisza: [C: 031] Better handling of Message objects as Message parameters [core] - 10https://gerrit.wikimedia.org/r/321402 (owner: 10Anomie) [22:14:23] (03PS2) 10Esanders: build: Replace jscs+jshint with eslint [core] - 10https://gerrit.wikimedia.org/r/321732 [22:14:50] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Reduce password reset spam - https://phabricator.wikimedia.org/T145952#2797372 (10Huji) It is shortsighted. Imagine we implement this. Then I promise not to forget my password, and ask for password reset to be disabled for me. Late, someone hacks into my ac... [22:15:17] (03CR) 10Esanders: build: Replace jscs+jshint with eslint (035 comments) [core] - 10https://gerrit.wikimedia.org/r/321732 (owner: 10Esanders) [22:15:22] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Reduce password reset spam - https://phabricator.wikimedia.org/T145952#2797374 (10Huji) [22:16:02] (03PS1) 10Pmiazga: Fix Beta optin on Beta cluser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/321796 (https://phabricator.wikimedia.org/T148975) [22:16:47] 10MediaWiki-extensions-Page_Forms: Allowed values are no longer added when using special page "CreateClass" - https://phabricator.wikimedia.org/T150657#2797382 (10Yaron_Koren) Oops - I didn't actually check in the change before. I just did that. [22:16:49] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Reduce password reset spam - https://phabricator.wikimedia.org/T145952#2797383 (10matmarex) [22:17:21] 10Reading-Community-Engagement, 10Wikimedia-General-or-Unknown, 07Mobile: Bug: Text/Alignment issues in certain English Wikipedia portal pages - https://phabricator.wikimedia.org/T120238#1848678 (10Niedzielski) This seems like a limitation of Parsoid: https://en.wikipedia.org/api/rest_v1/page/html/Category%3... [22:18:24] (03CR) 10BearND: [C: 04-1] "Nice work! I only got a really minor nit (in a string)." (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321084 (https://phabricator.wikimedia.org/T144109) (owner: 10Niedzielski) [22:22:17] (03PS1) 10BryanDavis: Throttler: improve log message compatibility with Monolog logger [core] - 10https://gerrit.wikimedia.org/r/321798 [22:24:54] (03CR) 10Mattflaschen: "If you use this.sandbox.useFakeTimers() , it should only tick the timer when you explicitly tell it to (rather than using real time)." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/321793 (owner: 10Mooeypoo) [22:25:38] 06Team-Practices (This-Week): Final review of proposed TPG Values (MB) - https://phabricator.wikimedia.org/T150683#2797403 (10MBinder_WMF) Reviewed, fine with changes made/being discussed. [22:28:06] (03PS3) 10Niedzielski: Use File page descriptions for picture of the day [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321084 (https://phabricator.wikimedia.org/T144109) [22:28:18] (03CR) 10Mooeypoo: "> If you use this.sandbox.useFakeTimers() , it should only tick the" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/321793 (owner: 10Mooeypoo) [22:28:26] (03CR) 10Niedzielski: Use File page descriptions for picture of the day (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321084 (https://phabricator.wikimedia.org/T144109) (owner: 10Niedzielski) [22:28:44] (03CR) 10jenkins-bot: [V: 04-1] Throttler: improve log message compatibility with Monolog logger [core] - 10https://gerrit.wikimedia.org/r/321798 (owner: 10BryanDavis) [22:29:37] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797424 (10MarcoAurelio) p:05Triage>03Lowest [22:29:53] 06Design-Research-Backlog, 06Research-and-Data, 10Research-outreach: Discuss workshop strategy for the second half of the year - https://phabricator.wikimedia.org/T147102#2797427 (10DarTar) Notes https://etherpad.wikimedia.org/p/ResearchConferencesFY1617 [22:30:55] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797316 (10MarcoAurelio) p:05Lowest>03Triage [22:32:10] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797434 (10MarcoAurelio) a:05MarcoAurelio>03None Not much avalaible these days for SWAT windows. [22:32:53] 06Design-Research-Backlog, 06Research-and-Data, 10Research-outreach: Discuss workshop strategy for the second half of the year - https://phabricator.wikimedia.org/T147102#2797436 (10DarTar) [22:33:15] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2797437 (10EBernhardson) For query reformulation, indeed everything is different in these three languages as compared to english in our first test. From various literature i've... [22:33:37] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797439 (10Legoktm) p:05Triage>03High [22:33:39] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2797441 (10EBernhardson) skipping query reformulation is also reasonable :) [22:37:18] (03PS2) 10Gergő Tisza: Throttler: improve log message compatibility with Monolog logger [core] - 10https://gerrit.wikimedia.org/r/321798 (owner: 10BryanDavis) [22:37:38] 06Editing-Analysis: Calculate monthly mobile Wikipedia edits for Major Gifts report - https://phabricator.wikimedia.org/T149710#2797450 (10JCuriel) Thanks very much, Neil! Really appreciate it. [22:38:11] thanks for fixing the test tgr. I started to do that and got distracted [22:38:17] (03CR) 10Legoktm: [C: 032] parserTests: Use a mock parser during article insertion [core] - 10https://gerrit.wikimedia.org/r/314490 (owner: 10Tim Starling) [22:38:52] I can relate to that :) [22:39:19] I started fixing the MediaViewer tests last Thursday [22:39:32] still haven't gotten undistracted since [22:41:53] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797457 (10Dereckson) a:03Dereckson I'll take care to schedule this at the next SWAT window. [22:46:05] (03PS6) 10MarcoAurelio: Fallback Livvi-Karelian (olo) to Finnish (fi) [core] - 10https://gerrit.wikimedia.org/r/313576 (https://phabricator.wikimedia.org/T146744) [22:47:22] (03CR) 10BearND: [C: 04-1] "The hints inline should help with the jshint error, too." (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/320712 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [22:47:24] (03Merged) 10jenkins-bot: parserTests: Use a mock parser during article insertion [core] - 10https://gerrit.wikimedia.org/r/314490 (owner: 10Tim Starling) [22:51:08] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797476 (10MarcoAurelio) Thank you @Dereckson but I think I'll be able to do the next SWAT window in an h... [22:51:42] 06Security-Team, 10Wikimedia-Site-requests, 13Patch-For-Review, 05Security: Add 'interface-editors' to the list of users who can enable OATHAuth on WMF wikis - https://phabricator.wikimedia.org/T150807#2797477 (10Dereckson) a:05Dereckson>03MarcoAurelio [22:57:01] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Organize/ prepare content for an informational google hangout session for new Google Code-In mentors - https://phabricator.wikimedia.org/T150636#2797485 (10srishakatux) [22:58:06] (03CR) 10Aaron Schulz: [C: 032] "Nothing to block on." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/321604 (owner: 10Tim Starling) [22:59:12] (03PS1) 10Yurik: Added mapdata to interactive [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/321800 [23:02:05] (03CR) 10Zppix: "Is this patch complete and ready if so im okay with merging it" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/321800 (owner: 10Yurik) [23:02:22] (03PS1) 10Mholloway: WIP: Add description editing success activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321802 [23:03:50] 10Android-app-feature-Description-Editing, 10Android-app-goals-2016-Oct-Dec-Q2, 06Wikipedia-Android-App-Backlog, 13Patch-For-Review: Build Wikidata description data client. - https://phabricator.wikimedia.org/T146641#2797487 (10bearND) >>! In T146641#2746265, @Mhurd wrote: > Then fetch central auth token (... [23:04:18] 06Discovery, 06Discovery-Analysis (Current work): Analyze results of the second BM25 test - https://phabricator.wikimedia.org/T147500#2797489 (10EBernhardson) fwiw, i had seen recently that spaCy (python NLP) had added the jieba library to tokenize chinese, maybe better (but this is just because i was interest... [23:05:17] (03CR) 10Zppix: [C: 032] Added mapdata to interactive [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/321800 (owner: 10Yurik) [23:05:57] (03Merged) 10jenkins-bot: Added mapdata to interactive [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/321800 (owner: 10Yurik) [23:06:26] (03Draft2) 10BBlack: Edit Project Config [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/321801 [23:08:13] (03Abandoned) 10BBlack: Modify access rules [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/293267 (owner: 10Sirishjoshi) [23:08:15] (03Abandoned) 10BBlack: Modify access rules [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/293254 (owner: 10Sirishjoshi) [23:08:35] (03CR) 10Jforrester: [C: 032] build: Replace jscs+jshint with eslint [core] - 10https://gerrit.wikimedia.org/r/321732 (owner: 10Esanders) [23:10:40] (03PS1) 10Gergő Tisza: Document AuthenticationRequestTestCase [core] - 10https://gerrit.wikimedia.org/r/321805 [23:11:32] (03PS2) 10Mholloway: Return expected responses for most-read requests with no results [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321548 (https://phabricator.wikimedia.org/T150685) [23:11:42] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Reduce password reset spam - https://phabricator.wikimedia.org/T145952#2646063 (10Jorm) I would very much like to have this spam reduced. While my username isn't a common name (like Angela), it is _short_ (4 characters). If I had my druthers, I'd prefer t... [23:11:45] (03CR) 10Mholloway: Return expected responses for most-read requests with no results (032 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/321548 (https://phabricator.wikimedia.org/T150685) (owner: 10Mholloway) [23:12:28] 06Wikipedia-Android-App-Backlog, 07Spike: Explore best practices for app specific UI localization - https://phabricator.wikimedia.org/T150812#2797508 (10Niedzielski) [23:12:40] (03PS2) 10Gergő Tisza: Document AuthenticationRequestTestCase [core] - 10https://gerrit.wikimedia.org/r/321805 [23:15:47] (03CR) 10Gergő Tisza: [C: 032] Throttler: improve log message compatibility with Monolog logger [core] - 10https://gerrit.wikimedia.org/r/321798 (owner: 10BryanDavis) [23:17:48] 06Design-Research-Backlog, 06Research-and-Data, 10Research-management, 07Epic: Wikimedia Research discoverability: designing a landing page for the department - https://phabricator.wikimedia.org/T107389#2797529 (10DarTar) [23:20:32] (03PS2) 10Gergő Tisza: Add emailauth role [vagrant] - 10https://gerrit.wikimedia.org/r/321705 [23:20:41] 06Design-Research-Backlog, 06Research-and-Data-Backlog, 10Research-management, 07Epic, 03Research-and-Data-2016-17-Q1: [Epic] Make Wikimedia Research content easier to discover - https://phabricator.wikimedia.org/T131204#2797540 (10DarTar) [23:20:43] 10Data-release, 06Research-and-Data: Create open data registry entries for Analytics data (PVs and UDs) - https://phabricator.wikimedia.org/T144604#2797539 (10DarTar) [23:21:25] (03PS1) 10Niedzielski: Hygiene: remove redundant manifest Activity export [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321807 [23:22:22] (03CR) 10jenkins-bot: [V: 04-1] build: Replace jscs+jshint with eslint [core] - 10https://gerrit.wikimedia.org/r/321732 (owner: 10Esanders) [23:22:25] 06Research-and-Data, 10Research-management: Apply for a Funder ID for WMF - https://phabricator.wikimedia.org/T144436#2599789 (10DarTar) Met with @klove to clarify scope. Obtained a response from Crossref, this is in the making but might take a few more weeks to be published in the funder registry. [23:23:25] (03PS3) 10Ppchelko: WIP: Fix swagger spec routes [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 (owner: 10Jdlrobson) [23:23:29] (03PS2) 10Mholloway: WIP: Add description editing success activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321802 [23:23:47] 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016): Help participants at the developer summit build meaningful connections with each other - https://phabricator.wikimedia.org/T150156#2797550 (10srishakatux) p:05Triage>03Low [23:24:02] (03CR) 10jenkins-bot: [V: 04-1] Throttler: improve log message compatibility with Monolog logger [core] - 10https://gerrit.wikimedia.org/r/321798 (owner: 10BryanDavis) [23:24:06] (03PS3) 10Jforrester: build: Replace jscs+jshint with eslint [core] - 10https://gerrit.wikimedia.org/r/321732 (owner: 10Esanders) [23:24:09] (03PS1) 10Jforrester: build: Bump eslint-config-wikimedia to v0.3.0 (already passes) [core] - 10https://gerrit.wikimedia.org/r/321809 [23:24:14] (03PS1) 10Mattflaschen: Add Flow External Store to addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321810 (https://phabricator.wikimedia.org/T128417) [23:24:21] 06Research-and-Data, 10WikiCite: Import Wikimedia Research output into Wikidata - https://phabricator.wikimedia.org/T150813#2797553 (10DarTar) [23:24:34] (03CR) 10Ppchelko: WIP: Fix swagger spec routes (031 comment) [services/trending-edits] - 10https://gerrit.wikimedia.org/r/321646 (owner: 10Jdlrobson) [23:25:16] 06Research-and-Data, 10Research-management: Wikimedia Research published output - https://phabricator.wikimedia.org/T144575#2797571 (10DarTar) [23:25:18] 06Research-and-Data, 10WikiCite: Import Wikimedia Research output into Wikidata - https://phabricator.wikimedia.org/T150813#2797570 (10DarTar) [23:25:45] 06Design-Research-Backlog, 06Research-and-Data-Backlog, 10Research-management, 07Epic, 03Research-and-Data-2016-17-Q1: [Epic] Make Wikimedia Research content easier to discover - https://phabricator.wikimedia.org/T131204#2797573 (10DarTar) [23:25:47] 06Research-and-Data, 10WikiCite: Import Wikimedia Research output into Wikidata - https://phabricator.wikimedia.org/T150813#2797553 (10DarTar) [23:25:50] (03CR) 10Aaron Schulz: [C: 032] Add ParserFetchTemplate hook [core] - 10https://gerrit.wikimedia.org/r/307073 (https://phabricator.wikimedia.org/T47096) (owner: 10Glaisher) [23:26:01] 06Design-Research-Backlog, 06Research-and-Data-Backlog, 10Research-management, 07Epic, 03Research-and-Data-2016-17-Q1: [Epic] Make Wikimedia Research content easier to discover - https://phabricator.wikimedia.org/T131204#2159210 (10DarTar) [23:26:03] 06Research-and-Data, 10Research-management: Wikimedia Research published output - https://phabricator.wikimedia.org/T144575#2604168 (10DarTar) [23:26:08] (03PS1) 10Arlolra: Display self-closed tags [extensions/Linter] - 10https://gerrit.wikimedia.org/r/321812 [23:27:19] (03CR) 10Jforrester: "Did this break CI? The two runs of mediawiki-phpunit-php55-trusty since this merged (https://integration.wikimedia.org/ci/job/mediawiki-ph" [core] - 10https://gerrit.wikimedia.org/r/314490 (owner: 10Tim Starling) [23:27:40] 10New-Readers, 06Reading-Admin, 06Reading-Web-Backlog, 07Epic: Prepare for November user research - https://phabricator.wikimedia.org/T148358#2797579 (10atgo) [23:27:50] 10New-Readers, 06Reading-Web-Backlog, 07Epic: Complete Saved Pages prototype for testing - https://phabricator.wikimedia.org/T148365#2797580 (10atgo) [23:28:10] 10New-Readers, 06Reading-Web-Backlog, 07Epic: Complete Saved Pages prototype for testing - https://phabricator.wikimedia.org/T148365#2721101 (10atgo) Updating the name to something that makes more sense for now... please forgive if I don't catch all the instances. [23:28:51] 10New-Readers, 06Reading-Web-Backlog: Prototype isn't working for saved pages offline - https://phabricator.wikimedia.org/T150077#2797582 (10atgo) [23:29:04] 10New-Readers, 06Reading-Web-Backlog: Prototype isn't working for saved pages offline - https://phabricator.wikimedia.org/T150077#2773404 (10atgo) @ovasileva this one should get pulled in [23:29:47] (03CR) 10Arlolra: Update lint errors via the job queue (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/321709 (owner: 10Legoktm) [23:30:21] (03CR) 10Arlolra: Update lint errors via the job queue (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/321709 (owner: 10Legoktm) [23:30:37] 10New-Readers: Come up with sub-brand name for Flashcards - https://phabricator.wikimedia.org/T149332#2797588 (10atgo) @Nirzar let's go with "Quickfact" [23:31:04] 06Reading-Web-Backlog (Design): Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2797589 (10Nirzar) [23:31:12] 07Design, 10New-Readers, 06Reading-Web-Backlog (Design), 03Reading-Web-Sprint-85-💩: Finish print styles for flashcard - https://phabricator.wikimedia.org/T148378#2797603 (10atgo) From T149332 let's call this "Quickfact" [23:31:23] 10New-Readers, 06Reading-Web-Backlog, 07Epic: Complete Flashcard prototype for testing - https://phabricator.wikimedia.org/T148364#2797607 (10atgo) [23:31:25] 10New-Readers: Come up with sub-brand name for Flashcards - https://phabricator.wikimedia.org/T149332#2749016 (10atgo) 05Open>03Resolved a:03atgo [23:36:20] (03Merged) 10jenkins-bot: Add ParserFetchTemplate hook [core] - 10https://gerrit.wikimedia.org/r/307073 (https://phabricator.wikimedia.org/T47096) (owner: 10Glaisher) [23:39:42] 06Discovery, 06Discovery-Analysis (Current work), 07Epic: [EPIC] Learn about our databases and how to use them - https://phabricator.wikimedia.org/T143128#2797630 (10debt) [23:39:45] 06Discovery-Analysis (Current work): From Zero To Hero 2: Electric Boogaloo - https://phabricator.wikimedia.org/T147216#2797628 (10debt) 05Open>03Resolved I've added the link to the pdf here https://www.mediawiki.org/wiki/Discovery_Analysis#Past_analyses and in the weekly status updates: https://www.mediawik... [23:40:16] 06Discovery, 06Discovery-Analysis (Current work), 07Epic: [EPIC] Learn about our databases and how to use them - https://phabricator.wikimedia.org/T143128#2557804 (10debt) 05Open>03Resolved ...and, done! :) [23:40:57] 10Wikimedia-Site-requests, 13Patch-For-Review: Make __NOINDEX__ work on all namespaces on Meta-Wiki - https://phabricator.wikimedia.org/T150245#2797635 (10MarcoAurelio) >>! In T150245#2796846, @Dereckson wrote: > @MarcoAurelio Could you discuss the issue on https://meta.wikimedia.org/wiki/Meta:Babel? Sure, d... [23:42:20] (03PS2) 10BearND: Hygiene: add base class for MW responses [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321701 [23:42:22] (03PS4) 10BearND: Wikidata description editing flow for logged in users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321703 (https://phabricator.wikimedia.org/T150705) [23:42:24] (03PS4) 10BearND: Add CentralAuthTokenClient [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321702 (https://phabricator.wikimedia.org/T150705) [23:42:26] (03PS7) 10BearND: Handle abusefilters in Wikidata description editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/320965 (https://phabricator.wikimedia.org/T150704) [23:42:51] (03CR) 10Niedzielski: [C: 04-1] "I like the way you've made a custom View! Please see early discussion feedback inline and ignore if it's not constructive!" (036 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/321802 (owner: 10Mholloway) [23:47:27] 10Social-Tools, 10WikiForum: WikiForum does not word wrap text correct - https://phabricator.wikimedia.org/T150816#2797641 (10GethN7) [23:48:46] 06Discovery, 06Discovery-Analysis: Can we align Discernatron data with search user engagement data? - https://phabricator.wikimedia.org/T148604#2797657 (10debt) 05Open>03declined Declining this ticket, based on @mpopov's comment (above) and our discussion about it. [23:49:46] (03CR) 10Ppchelko: Add announcements endpoint (033 comments) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/320712 (https://phabricator.wikimedia.org/T145830) (owner: 10Fjalapeno) [23:49:59] 06Reading-Web-Backlog (Design): Improve Page Preview visual design - https://phabricator.wikimedia.org/T150814#2797662 (10Nirzar) [23:50:13] (03PS2) 10Mattflaschen: Add Flow External Store to addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321810 (https://phabricator.wikimedia.org/T150764) [23:51:32] matt_flaschen: if you're inclined to check addWiki.php, there is also OAAUTHAuth to add (already in createExtensionTables) [23:53:37] 10MediaWiki-CrossWikiWatchlist, 10MediaWiki-extensions-CentralAuth, 03Community-Tech-Sprint, 07Community-Wishlist-Survey, 07Crosswiki: Update CentralAuth migration scripts to populate new lu_local_id and lu_global_id fields during migration - https://phabricator.wikimedia.org/T149111#2797665 (10kaldari)... [23:53:44] 07Design, 10MediaWiki-CrossWikiWatchlist, 10MediaWiki-Watchlist, 10MediaWiki-extensions-CentralAuth, and 8 others: Cross-wiki watchlists - https://phabricator.wikimedia.org/T5525#2797667 (10kaldari) [23:53:53] 10MediaWiki-CrossWikiWatchlist, 10MediaWiki-extensions-CentralAuth, 07Community-Wishlist-Survey, 07Crosswiki: Update CentralAuth migration scripts to populate new lu_local_id and lu_global_id fields during migration - https://phabricator.wikimedia.org/T149111#2797668 (10kaldari) [23:54:01] Dereckson, sorry, just fixing this because I essentially broke it (by adding a separate Flow external store on Beta, and soon prod) [23:58:01] (03PS1) 10Dereckson: Create OATHAuth tables when adding a wiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/321815