[00:01:15] (03PS2) 10EBernhardson: [WIP] Script to generate wmgCirrusSearchInterwikiSources [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/319498 (https://phabricator.wikimedia.org/T149740) [00:05:36] 10MediaWiki-Configuration, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release: Downgrade extensions that use manifest_version 2 in REL1_28 - https://phabricator.wikimedia.org/T149759#2766958 (10Reedy) [00:05:53] 10MediaWiki-Configuration, 05MW-1.28-release: Remove manifest_version 2 from REL1_28 - https://phabricator.wikimedia.org/T149757#2766961 (10Reedy) [00:05:55] 10MediaWiki-Configuration, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release: Downgrade extensions that use manifest_version 2 in REL1_28 - https://phabricator.wikimedia.org/T149759#2761939 (10Reedy) 05Open>03stalled Stalling this till we decide how we're proceeding in core [00:07:50] 10MediaWiki-Configuration, 05MW-1.28-release: Remove manifest_version 2 from REL1_28 - https://phabricator.wikimedia.org/T149757#2761898 (10Reedy) Stalled T149759 till we decide how to proceed. Don't mind fixing up (most) of them, but don't really want to do the work if we're gonna keep manifest_version 2 as i... [00:08:12] (03Merged) 10jenkins-bot: Follow-up Id0021594: Remove extra code for redlink suggestions [core] (wmf/1.29.0-wmf.1) - 10https://gerrit.wikimedia.org/r/319481 (https://phabricator.wikimedia.org/T149130) (owner: 10Jforrester) [00:08:54] 10MediaWiki-Configuration, 05MW-1.28-release: Remove manifest_version 2 from REL1_28 - https://phabricator.wikimedia.org/T149757#2766984 (10thcipriani) >>! In T149757#2766940, @Reedy wrote: > @thcipriani Do you have an idea when you'd ideally like to tag it by? I had the deadline to tag/release 1.28.0-rc.0 to... [00:15:26] 10MediaWiki-Configuration, 05MW-1.28-release: Remove manifest_version 2 from REL1_28 - https://phabricator.wikimedia.org/T149757#2766992 (10Reedy) >>! In T149757#2766984, @thcipriani wrote: >>>! In T149757#2766940, @Reedy wrote: >> @thcipriani Do you have an idea when you'd ideally like to tag it by? > > I ha... [00:16:16] 10Montage: Removing usernames from round doesn't necessarily remove them in the UI - https://phabricator.wikimedia.org/T148268#2766995 (10LilyOfTheWest) confirmed. [00:16:25] 10Montage: Removing usernames from round doesn't necessarily remove them in the UI - https://phabricator.wikimedia.org/T148268#2766997 (10LilyOfTheWest) 05Open>03Resolved [00:18:00] 10Montage: Improve performance for those on low-bandwidth connections - https://phabricator.wikimedia.org/T147724#2766998 (10LilyOfTheWest) @Yarl thanks for claiming this. Can you propose some options to address this when you're ready and we discuss? [00:19:47] (03CR) 10EBernhardson: "example output: https://phabricator.wikimedia.org/P4357" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/319498 (https://phabricator.wikimedia.org/T149740) (owner: 10EBernhardson) [00:19:50] 10MediaWiki-Interwiki, 10MediaWiki-Sites, 10Wikimedia-Developer-Summit (2017): Refactoring the Interwiki Map: status and outlook - https://phabricator.wikimedia.org/T149535#2755351 (10Smalyshev) Is the mediawiki link correct? It links to "How to manage our technical debt" [00:21:29] 10Montage: Disable add round option unless the previous round is finished - https://phabricator.wikimedia.org/T147911#2767003 (10LilyOfTheWest) No, I can create rounds for rounds that are not finished, and btw, this may require some backend work. [00:21:47] 10Montage: Create keyboard shortcuts for rating and yes/no rounds - https://phabricator.wikimedia.org/T147273#2767004 (10LilyOfTheWest) 05Open>03Resolved [00:21:52] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Optimise startup by merging regexes [core] - 10https://gerrit.wikimedia.org/r/318655 (owner: 10Krinkle) [00:25:09] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10VisualEditor, 05MW-1.28-release, and 3 others: [Regression wmf.23] MW's title suggestion widget displays a suggestion for "foo" and "Foo" for non-existing pages on input of "foo" (OK), and for "... - https://phabricator.wikimedia.org/T149130#2767007 [00:27:36] 10Montage: [Juror] Add the option for leaving comments for each photo - https://phabricator.wikimedia.org/T146857#2767010 (10LilyOfTheWest) @Yarl this is pretty much ready to be closed. However, in light of the recent confusions by a few jury members who had left their ranking in the review boxes, I suggest that... [00:28:30] 10Montage: Advancing to subsequent rounds - https://phabricator.wikimedia.org/T146858#2767013 (10LilyOfTheWest) [00:28:32] 10Montage: Create the option for a ranking round - https://phabricator.wikimedia.org/T148351#2767012 (10LilyOfTheWest) 05Open>03Resolved [00:29:07] (03PS2) 10EBernhardson: Only perform interwiki search with 'simple' searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/319484 [00:29:29] (03PS2) 10EBernhardson: [WIP] Add configuration value to run interwiki load test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/319485 (https://phabricator.wikimedia.org/T149740) [00:29:59] (03Merged) 10jenkins-bot: resourceloader: Optimise startup by merging regexes [core] - 10https://gerrit.wikimedia.org/r/318655 (owner: 10Krinkle) [00:40:28] 07Design, 06Community-Liaisons, 10Reading-Community-Engagement, 10Wikimedia-Developer-Summit (2017): Discuss creating a UI/UX design hub on mediawiki or meta - https://phabricator.wikimedia.org/T117482#2767061 (10pizzzacat) Adding to wiki page https://www.mediawiki.org/w/index.php?title=Wikimedia_Developer... [00:43:32] (03CR) 10Dzahn: "So was it possible restart the ssh gerrit connection without also killing the IRC connection or was it not. Since the status before all th" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [00:44:07] 10MediaWiki-Configuration, 05MW-1.28-release: Remove manifest_version 2 from REL1_28 - https://phabricator.wikimedia.org/T149757#2767064 (10Legoktm) >>! In T149757#2762048, @Krinkle wrote: > Per T149759, the new features in MediaWiki master enabled via manifest_version 2 are already being used by some extensio... [00:47:29] (03PS1) 10MaxSem: WIP: replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 [00:48:37] (03CR) 10Dzahn: "also i think the whole whitelist.js plan with parsing a wiki page and creating a db might be overkill and we'd be fine with a simple list " [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [00:58:03] 10MediaWiki-Configuration, 05MW-1.28-release: Remove manifest_version 2 from REL1_28 - https://phabricator.wikimedia.org/T149757#2767076 (10Reedy) * BlockAndNuke * timeline * TorBlock * TrustedXff all make use of the path feature Reverting them out will take a bit of effort, but not much in the grand scheme... [00:58:32] MaxSem: https://gerrit.wikimedia.org/r/#/c/312463/ !! [00:58:54] <3 legoktm [01:00:29] legoktm, mine is centered towards usability, yours still has the old interface that caused me to make my commit [01:01:37] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#2767086 (10jmatazzoni) [01:02:24] MaxSem: yeah, looks like it. Yours is probably a good start to continue refactoring further [01:02:48] sooo... [01:03:28] (03CR) 10Dzahn: [WIP] Adds a grrrit-wm restarting command for you to type in irc (035 comments) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [01:04:07] legoktm, also, I generally hate MediaWikiServices because boilerplate [01:04:10] XD [01:04:32] which boilerplate? [01:04:55] MaxSem: so you should continue working on your patch and I'll probably refactor on top of it later after its merged :P [01:05:23] MediaWiki\MediaWikiServices::getInstance()->getService( ... ) stuff [01:06:06] (03CR) 10Dzahn: [WIP] Adds a grrrit-wm restarting command for you to type in irc (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [01:09:48] 10MediaWiki-General-or-Unknown, 10Notifications, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2767093 (10jmatazzoni) [01:14:18] MaxSem: If you put it in the constructor or use DI it's not that bad [01:19:37] legoktm, principal difference: yours is persistent service, mine's one instance per shell exec [01:20:54] * legoktm doesn't say the Factory word [01:21:41] * MaxSem is silent about "moar boilerplate" :P [01:29:32] 10MobileFrontend, 06Reading-Web-Backlog: Evaluate providing section collapsing to older browsers where we do not run JS - https://phabricator.wikimedia.org/T148591#2767113 (10GWicke) @Jdlrobson, they would make styling of sections via CSS a lot easier. [01:32:25] 07Design, 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2767116 (10Whatamidoing-WMF) @DLynch, would it be easy enough to make it show wikitext ra... [01:33:38] (03CR) 10jenkins-bot: [V: 04-1] Only perform interwiki search with 'simple' searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/319484 (owner: 10EBernhardson) [01:41:01] (03PS2) 10MaxSem: WIP: replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 [01:54:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add configuration value to run interwiki load test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/319485 (https://phabricator.wikimedia.org/T149740) (owner: 10EBernhardson) [02:06:51] (03CR) 10EBernhardson: "I'll have to update the fixtures and verify the changes are as expected tomorrow" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/319484 (owner: 10EBernhardson) [02:07:58] (03PS18) 10Paladox: [WIP] Adds a grrrit-wm restarting command for you to type in irc [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) [02:10:27] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/319486 (https://phabricator.wikimedia.org/T144318) (owner: 10Niedzielski) [02:10:38] (03CR) 10Niedzielski: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/319487 (https://phabricator.wikimedia.org/T144318) (owner: 10Niedzielski) [02:13:42] (03PS19) 10Paladox: Adds a grrrit-wm restarting command for you to type in irc [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) [02:13:51] (03CR) 10Paladox: "Tested on the test bot and it worked." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:23:15] (03PS20) 10Paladox: Adds a grrrit-wm restarting command for you to type in irc [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) [02:28:49] (03PS3) 10MaxSem: WIP: replace wfShellExec() with a class [core] - 10https://gerrit.wikimedia.org/r/319505 [02:31:52] (03CR) 10MarkTraceur: [C: 04-1] "This is what a non-WIP patch should look like. Fantastic. Thanks. A few more small issues, mostly relating to code style, and we can move " (032 comments) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:34:50] (03CR) 10Paladox: "@MarkTraceur" (032 comments) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:35:34] (03CR) 10MarkTraceur: Adds a grrrit-wm restarting command for you to type in irc (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:35:37] 10MediaWiki-extensions-Page_Forms, 10Security-Reviews: Security review for PageForms - https://phabricator.wikimedia.org/T149869#2767134 (10Dereckson) [02:36:52] 10MediaWiki-extensions-Page_Forms, 10Security-Reviews: Security review for PageForms - https://phabricator.wikimedia.org/T149869#2767151 (10Dereckson) [02:37:18] 10MediaWiki-extensions-Page_Forms, 10Security-Reviews: Security review for PageForms - https://phabricator.wikimedia.org/T149869#2767134 (10Reedy) >Per https://www.mediawiki.org/wiki/Review_queue a security review is so needed to deploy PageForms on the Wikimedia cluster. Well, it's already deployed.. And we'... [02:37:41] (03CR) 10MarkTraceur: Adds a grrrit-wm restarting command for you to type in irc (032 comments) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:40:56] (03CR) 10Paladox: Adds a grrrit-wm restarting command for you to type in irc (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:42:05] (03PS21) 10Paladox: Adds a grrrit-wm restarting command for you to type in irc [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) [02:42:53] (03CR) 10MarkTraceur: Adds a grrrit-wm restarting command for you to type in irc (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:43:52] (03CR) 10Paladox: "@MarkTraceur" (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:45:13] (03CR) 10MarkTraceur: [C: 04-1] Adds a grrrit-wm restarting command for you to type in irc (032 comments) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:45:46] (03CR) 10MarkTraceur: Adds a grrrit-wm restarting command for you to type in irc (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) (owner: 10Paladox) [02:50:23] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2639200 (10Legoktm) Nice! :) [02:58:52] (03PS22) 10Paladox: Adds a grrrit-wm restarting command for you to type in irc [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/318976 (https://phabricator.wikimedia.org/T149609) [03:00:46] 10MediaWiki-extensions-Page_Forms, 10Security-Reviews: Security review for PageForms - https://phabricator.wikimedia.org/T149869#2767134 (10Yaron_Koren) For what it's worth, not much has changed in this extension recently, other than the name; though of course there are constantly edits to the code of one kind... [03:10:19] (03CR) 10Legoktm: [C: 04-1] OutputPage::getCategories(): Add a possibility to distinguish "normal" and "hidden" categories (031 comment) [core] - 10https://gerrit.wikimedia.org/r/298040 (owner: 10Florianschmidtwelzow) [03:18:24] 10Wikimedia-Developer-Summit (2017): Reader Engagement & Education Proto-Editor support - https://phabricator.wikimedia.org/T149871#2767221 (10Jseddon) [03:26:38] Hi, I am new here and willing to learn and contribute. I have some experience with coding. Looking for guidance! Thanks:) [03:35:12] hi [03:35:37] AbhinavG: I'd recommend starting with https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker if you haven't already [03:47:45] thanks @legoktm [04:06:56] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2767284 (10AndyRussG) [04:08:37] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 06Performance-Team, 03Fundraising Sprint Unbreaking Now, and 2 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2767299 (10AndyRussG) >>! In T144952#2753693, @aaron wrote: > I don't see any code to purge the corre... [04:10:24] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2767284 (10AndyRussG) >>! In T144952#2753693, @aaron wrote: > [...] To cover 11+ seconds of lag, MediaWiki lowers the CDN TTL to $wg... [04:12:07] 10MediaWiki-Cache, 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2767308 (10AndyRussG) [04:12:59] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 06Operations, 10Traffic: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2767310 (10AndyRussG) [04:17:38] (03CR) 10AndyRussG: MessageCache invalidation improvements (032 comments) [core] - 10https://gerrit.wikimedia.org/r/318488 (owner: 10Aaron Schulz) [04:22:19] (03PS8) 10Aaron Schulz: objectcache: detect default getWithSetCallback() set options [core] - 10https://gerrit.wikimedia.org/r/317304 [04:29:43] 10CirrusSearch, 06Discovery, 06Discovery-Search: Some system messages should not be bold ... - https://phabricator.wikimedia.org/T149815#2763935 (10Jay8g) It's a Monobook versus Vector issue. Kghbln is using Monobook, Deskana is using Vector. [04:31:39] (03CR) 10Aaron Schulz: "I guess the header() calls are there due to direct echo calls, though using setArticleBodyOnly() might do the trick (with lowerCDNMaxage a" [core] - 10https://gerrit.wikimedia.org/r/318488 (owner: 10Aaron Schulz) [04:33:18] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 06Operations, 10Traffic: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2767335 (10aaron) The first approach might work using Varnish xkey support. I'm not how far along we ar... [04:56:28] (03PS1) 10Aaron Schulz: Improve getUrlDomainDistance() return values [core] - 10https://gerrit.wikimedia.org/r/319511 [05:03:53] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 06Operations, 10Traffic: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873#2767345 (10aaron) Another idea is to add a cache-busting parameter to the URLs handed out, like the cac... [05:25:15] (03PS1) 10Aaron Schulz: DatabaseMysqlBase visibility cleanups [core] - 10https://gerrit.wikimedia.org/r/319513 [05:36:33] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07WorkType-Maintenance: Regexes in search queries can sometimes return fewer search results than they should - https://phabricator.wikimedia.org/T106685#2767353 (10Jonesey95) Just another example, if it helps to find a solution to this problem. Currently,... [05:39:52] 10CirrusSearch, 06Discovery, 06Discovery-Search, 07Wikimedia-log-errors: insource internal syntax error - https://phabricator.wikimedia.org/T99229#2767356 (10Jonesey95) I don't think this is a bug. The regex is malformed, so an error is returned. The regex in question should be: insource:/\