[00:02:27] 10New-Readers: show educational message for first time saved page user - https://phabricator.wikimedia.org/T149464#2753493 (10Nirzar) [00:02:48] 10New-Readers: show educational message for first time saved page user - https://phabricator.wikimedia.org/T149464#2753493 (10Nirzar) a:03Jhernandez [00:03:04] 10New-Readers: show educational message for first time saved page user - https://phabricator.wikimedia.org/T149464#2753493 (10Nirzar) @atgo you can add acceptance criteria if needed [00:10:51] 07Design, 10ProveIt-Gadget: Design improvement - https://phabricator.wikimedia.org/T149460#2753511 (10Iniquity) [00:11:33] 10MediaWiki-User-login-and-signup, 07Privacy: UserName cookie should not be set when "remember me" is disabled - https://phabricator.wikimedia.org/T149465#2753512 (10Tgr) [00:12:43] 10MobileFrontend, 07Wikimedia-log-errors: Warning: Not Found Error in /srv/mediawiki/php-1.28.0-wmf.23/extensions/MobileFrontend/includes/MobileFormatter.php on line 229 - https://phabricator.wikimedia.org/T149466#2753524 (10greg) [00:13:15] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-blocking, 06Support-and-Safety, 03Community-Tech-Sprint, 13Patch-For-Review: Send a cookie with each block - https://phabricator.wikimedia.org/T5233#2753537 (10Tgr) Silently recording a user identifier seems worse to me than the browser recor... [00:13:45] 10MobileFrontend, 07Wikimedia-log-errors: Not Found Error in MobileFormatter - https://phabricator.wikimedia.org/T149389#2753541 (10greg) [00:14:12] 10MobileFrontend, 07Wikimedia-log-errors: Not Found Error in MobileFormatter - https://phabricator.wikimedia.org/T149389#2750722 (10greg) [00:17:25] 06Discovery, 06Discovery-Analysis (Current work), 07Epic: [EPIC] Learning C++/Rcpp through ML bot detection - https://phabricator.wikimedia.org/T149440#2753546 (10mpopov) [00:20:04] (03PS7) 10Aaron Schulz: Postgres updater fixes to make update.php able to run [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) [00:20:44] (03CR) 10Aaron Schulz: "PS7 relies on the search path instead of explicit qualification." [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) (owner: 10Aaron Schulz) [00:28:36] (03CR) 10Gergő Tisza: [C: 032] "So as far as I see there is no relation between this patch and T149454. This patch affects schema prefixes; that bug is about the user_gro" [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) (owner: 10Aaron Schulz) [00:35:23] (03CR) 10Krinkle: [C: 031] Improve getLagTimes.php output and add statsD flag [core] - 10https://gerrit.wikimedia.org/r/318215 (https://phabricator.wikimedia.org/T149210) (owner: 10Aaron Schulz) [00:36:45] 10MediaWiki-Database, 10MediaWiki-extensions-CheckUser, 06Community-Tech: Add ability to search by user agent from CheckUser interface - https://phabricator.wikimedia.org/T146837#2753579 (10DannyH) [00:47:34] 10MediaWiki-Database, 10MediaWiki-Unit-tests, 05MW-1.28-release, 07Regression: 1.28-alpha / Error: 42P01 ERROR: table "unittest_user_groups" does not exist - https://phabricator.wikimedia.org/T149454#2753583 (10mwjames) > ... patch and T149454. This patch affects schema prefixes; that bug is about the use... [00:50:18] (03CR) 10Paladox: "@Gergő Tisza could you re c+2 please." [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) (owner: 10Aaron Schulz) [00:50:44] matt_flaschen: Added some links for your convenience at sp [00:50:54] at https://phabricator.wikimedia.org/tag/ladies-that-foss-mediawiki/ *& [01:22:38] 10MediaWiki-Database, 10MediaWiki-extensions-CheckUser, 06Community-Tech: Add ability to search by user agent from CheckUser interface - https://phabricator.wikimedia.org/T146837#2753586 (10DannyH) [01:23:02] (03CR) 10Gergő Tisza: [C: 032] Postgres updater fixes to make update.php able to run [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) (owner: 10Aaron Schulz) [01:28:11] 10MediaWiki-Database, 10MediaWiki-extensions-CheckUser, 06Community-Tech: Add ability to search by user agent from CheckUser interface - https://phabricator.wikimedia.org/T146837#2753589 (10DannyH) [01:30:06] 10MediaWiki-Database, 10MediaWiki-extensions-CheckUser, 06Community-Tech: Add ability to search by user agent from CheckUser interface - https://phabricator.wikimedia.org/T146837#2672515 (10DannyH) I've revamped the spec and wireframes, following our meeting with @Jalexander. Now you can only search by user... [01:31:03] (03Merged) 10jenkins-bot: Postgres updater fixes to make update.php able to run [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) (owner: 10Aaron Schulz) [01:39:38] (03PS1) 10Paladox: Postgres updater fixes to make update.php able to run [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/318661 (https://phabricator.wikimedia.org/T148628) [01:42:00] 10MediaWiki-Database: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2753598 (10mwjames) [01:51:34] 10MediaWiki-Database: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2753615 (10mwjames) > MediaWiki\Auth\LocalPasswordPrimaryAuthenticationProvider::providerChangeAuthenticationData, BotPassword::invalidateAllPasswordsForCentralId, User::saveSetti... [02:09:39] 10LDAP-Access-Requests: WMF or NDA LDAP access request for WMF employee - https://phabricator.wikimedia.org/T149187#2753622 (10chelsyx) Thank you @elukey ! [02:18:19] 10MediaWiki-extensions-LdapAuthentication: LDAP login no longer works with php7.0 - https://phabricator.wikimedia.org/T149469#2753623 (10NukeOperator) [02:30:17] 10Phabricator, 06Operations, 13Patch-For-Review: networking: allow ssh between iridium and phab2001 - https://phabricator.wikimedia.org/T143363#2753637 (10Dzahn) a:03Dzahn [02:34:08] 10MediaWiki-Database, 10MediaWiki-extensions-CheckUser, 06Community-Tech: Add ability to search by user agent from CheckUser interface - https://phabricator.wikimedia.org/T146837#2753638 (10Huji) [02:40:05] !class LocalisationCacheBulkLoad [02:40:05] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classLocalisationCacheBulkLoad.html [03:01:26] 10MediaWiki-Cache, 05MW-1.26-release: wincache_ucache_cas() expects parameter 2 to be long, string given - https://phabricator.wikimedia.org/T120896#1864321 (10Ciencia_Al_Poder) More reports: [[ https://www.mediawiki.org/wiki/Topic:Swpu5kupj4ypj3b5 | Topic:Swpu5kupj4ypj3b5 ]] * MW 1.26.2 / WinCache 2.0.0.4 (... [03:32:26] !class DatabaseBase [03:32:27] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classDatabaseBase.html [03:32:38] wtf [03:42:50] 04(no projects): Bug in the GIPBE or Global IP Block Exemptions - https://phabricator.wikimedia.org/T149425#2753652 (10Mbrt) @Aklapper I don't edit at enwiki, there was show " your ip has open proxy and blocked range from 8.37.225.0/24 expiry at 02:07, 2017 March 21. [04:33:55] (03CR) 10Aaron Schulz: [C: 032] Postgres updater fixes to make update.php able to run [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/318661 (https://phabricator.wikimedia.org/T148628) (owner: 10Paladox) [04:41:38] (03Merged) 10jenkins-bot: Postgres updater fixes to make update.php able to run [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/318661 (https://phabricator.wikimedia.org/T148628) (owner: 10Paladox) [04:45:15] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2753655 (10srishakatux) [04:46:44] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2753656 (10aaron) As of master, I can run update.php just fine. I'm not seeing any errors. [04:47:55] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2753657 (10srishakatux) Gerrit tool has been extremely useful for finding more information about the contributors :) I emailed Outreachy students and mentors from recent... [05:08:48] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753660 (10Yoshi24517) Once the first patch comes out (on what I hear to be Halloween at 23:00 UTC), how long will it be until the next patch gets deployed? [05:15:10] (03PS1) 10Aaron Schulz: Various small cleanups to DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318664 [05:19:17] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2753661 (10srishakatux) [05:25:04] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2753662 (10srishakatux) >>! In T148952#2745001, @Aklapper wrote: > We (well... I?) should also contact last year's GCI top students (we've never done that so far) if I ca... [05:35:31] (03PS2) 10Aaron Schulz: Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 [05:40:39] (03CR) 10jenkins-bot: [V: 04-1] Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 (owner: 10Aaron Schulz) [05:41:21] (03PS3) 10Aaron Schulz: Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 [05:45:38] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2739790 (10Urbanecm) The first deploy window is at Monday 13:00 UTC. But somebody (the patch author) must schedule it for this or another window. [05:46:44] (03CR) 10jenkins-bot: [V: 04-1] Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 (owner: 10Aaron Schulz) [05:52:35] 06Wikipedia-Android-App-Backlog: A special page isn't inserted correctly in Android app - https://phabricator.wikimedia.org/T149447#2752903 (10Kaartic) I guess this is related to T144619. [05:56:51] (03PS4) 10Aaron Schulz: Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 [06:05:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Prevent Special:NewItem from creating items multiple times (double-submitting) - https://phabricator.wikimedia.org/T147143#2753684 (10hoo) [06:05:24] 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata: Prevent Special:NewItem from creating items multiple times (double-submitting) - https://phabricator.wikimedia.org/T147143#2682546 (10hoo) [06:07:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Easy: Unhelpful error message on Special:MergeItems if items are already merged - https://phabricator.wikimedia.org/T130642#2753687 (10hoo) [06:08:23] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2753691 (10srishakatux) [06:08:44] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2737651 (10srishakatux) [06:13:32] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 06Performance-Team, 03Fundraising Sprint Testing on Production, and 3 others: Banner not showing up on site - https://phabricator.wikimedia.org/T144952#2753693 (10aaron) I don't see any code to purge the corresponding banner pages from CDN whenev... [06:53:21] 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata, 07Easy: Unhelpful error message on Special:MergeItems if items are already merged - https://phabricator.wikimedia.org/T130642#2753711 (10hoo) [06:55:19] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Ladies-That-FOSS-Wikidata, 10Wikidata, and 3 others: Search index a limited number of article placeholders for testing and evaluation purposes - https://phabricator.wikimedia.org/T144592#2753717 (10hoo) [07:04:48] (03PS1) 10Aaron Schulz: Rename JobQueueDB::getSlaveDB() to getReplicaDB() [core] - 10https://gerrit.wikimedia.org/r/318665 [07:05:23] 06Wikipedia-Android-App-Backlog, 10Outreachy (Round-13): Hacking: Wiki Radio (Outreachy 13 Proposal) - https://phabricator.wikimedia.org/T147953#2753718 (10Kaartic) @Nes Something I noted before but forgot to ask is, Don't the below questions seem redundant? >Will you have any other time commitments, such as... [07:12:27] 10Montage: Logging in on IE doesn't work - https://phabricator.wikimedia.org/T149472#2753720 (10LilyOfTheWest) [07:14:19] 10Montage: Logging in on IE doesn't work - https://phabricator.wikimedia.org/T149472#2753732 (10mahmoud) Are there any other details whatsoever? Like, do they get to the Wikimedia screen? Are they redirected back? Can we get a screenshot of where they get stuck? [07:16:23] Hello [07:21:25] 10Montage: Logging in on IE doesn't work - https://phabricator.wikimedia.org/T149472#2753733 (10LilyOfTheWest) @Richard_Nevell_WMUK may be able to get some information from the juror who experienced this problem, but before then, maybe we can ask @Effeietsanders to test this. Lodewijk, can you check if you run i... [07:36:10] Thanks, Krinkle. [07:36:14] 06Wikipedia-Android-App-Backlog, 10Outreachy (Round-13): Hacking: Wiki Radio (Outreachy 13 Proposal) - https://phabricator.wikimedia.org/T147953#2753735 (10Nes) @Kaartic Yes, they are redundant but one of them is from Mediawiki questions, and the other is from Outreachy questions. Additionally second one inclu... [07:53:54] 06Wikipedia-Android-App-Backlog, 07WorkType-NewFunctionality: Open in new tab entries don't appear in history - https://phabricator.wikimedia.org/T107471#1495790 (10Kaartic) It seems that the articles opened using the //Open in New tab// appears in History after the user switches to that tab. It wouldn't get e... [08:01:46] 06Wikipedia-Android-App-Backlog, 10Outreachy (Round-13): Hacking: Wiki Radio (Outreachy 13 Proposal) - https://phabricator.wikimedia.org/T147953#2753747 (10Kaartic) @Nes I thought it would have been better if you kept the second one alone as they are too similar and provide the same answer. Anyways you have a... [08:11:27] Hello all [08:11:43] 10MediaWiki-extensions-CollaborationKit: SpecialCreateCollaborationHubFeature: use input for icon, not select - https://phabricator.wikimedia.org/T149046#2740201 (10Harej) It's a combo box, not a dropdown select. You can choose from the dropdown //or// enter in your own filename. You are not limited to the pre-s... [08:13:39] 10Montage: Logging in on IE doesn't work - https://phabricator.wikimedia.org/T149472#2753753 (10Effeietsanders) I was surprised to find that MIE is still on my computer after I moved to Edge! Wow, another gem in life uncovered ;). But it's an app, not sure if it's the same. I can however confirm the bug: - I g... [08:16:18] 10MediaWiki-extensions-CollaborationKit: CollaborationHub: Make footer border only show up if there actually is a footer - https://phabricator.wikimedia.org/T149041#2740122 (10Harej) {F4672827} [08:34:51] 10MediaWiki-ResourceLoader, 07Browser-Support-Google-Chrome: Flaky loading Userscripts with Google Chrome - https://phabricator.wikimedia.org/T149449#2753757 (10Boshomi) [08:35:48] 10MediaWiki-Page-editing, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2753758 (10matej_suchanek) [08:40:00] 10MediaWiki-extensions-CollaborationKit: Come up with no-js fallback for canned icons so there isn't just nothing there - https://phabricator.wikimedia.org/T149048#2740229 (10Harej) I suppose we would have the PHP load just plain black icons and then the JavaScript would be used to change the color? [09:04:57] (03PS1) 10Brian Wolff: Make NumericUppercaseCollation use localized digit transforms [core] - 10https://gerrit.wikimedia.org/r/318666 (https://phabricator.wikimedia.org/T148873) [09:12:37] 10MediaWiki-ResourceLoader, 07Browser-Support-Google-Chrome: Flaky loading Userscripts with Google Chrome - https://phabricator.wikimedia.org/T149449#2753775 (10Boshomi) @Krinkle there are 5 Scripts, but with Fliegelflage.js (that contains multible userscripts) The script with the highes missing rate is Sch... [09:12:42] 10MediaWiki-Internationalization, 06Community-Tech, 07Need-volunteer, 13Patch-For-Review: Add support for Bengali to IcuCollation class - https://phabricator.wikimedia.org/T148885#2753777 (10Bawolff) >>! In T148885#2751809, @Bodhisattwa wrote: >>>! In T148885#2751708, @Bawolff wrote: > >> 2. Modify the ex... [09:13:34] (03CR) 10Brian Wolff: "It looks like bn doesn't want to go with uca. Nonetheless I think this patch should still be merged for the benefit of third parties or in" [core] - 10https://gerrit.wikimedia.org/r/318260 (https://phabricator.wikimedia.org/T148885) (owner: 10Brian Wolff) [09:16:40] (03CR) 10Brian Wolff: "Note, this won't result in any change for hewiki, as the hebrew localization does not define a digitTransformTable." [core] - 10https://gerrit.wikimedia.org/r/318666 (https://phabricator.wikimedia.org/T148873) (owner: 10Brian Wolff) [10:08:13] 10MediaWiki-JobQueue, 10ChangeProp, 06Operations, 06Performance-Team, and 2 others: Asynchronous processing in production: one queue to rule them all - https://phabricator.wikimedia.org/T149408#2753795 (10Joe) >>! In T149408#2753404, @bd808 wrote: >>>! In T149408#2753327, @Pchelolo wrote: >> @bd808 What ar... [10:16:49] (03PS1) 10Mglaser: ParamDefinitions: Fixed fatal by checking for wgParamDefinitions [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/318669 [10:52:06] 10MediaWiki-Database, 05MW-1.28-release, 07Regression: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2753832 (10Paladox) p:05Triage>03High [10:52:17] 10MediaWiki-Database, 05MW-1.28-release, 07Regression: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2753598 (10Paladox) Adding @aaron [10:52:34] (03CR) 10Paladox: "It seems that the web updater is broke https://phabricator.wikimedia.org/T149468" [core] - 10https://gerrit.wikimedia.org/r/317863 (https://phabricator.wikimedia.org/T148628) (owner: 10Aaron Schulz) [10:52:57] (03CR) 10Paladox: "Thanks." [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/318661 (https://phabricator.wikimedia.org/T148628) (owner: 10Paladox) [10:53:42] 10Wikimedia-Site-requests: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2753837 (10Peachey88) [10:54:42] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2753840 (10mwjames) > As of master, I can run update.php just fine. I'm not seeing any errors. Yes, the `upd... [11:33:37] (03PS1) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318671 [11:35:46] 10MediaWiki-Categories, 06Discovery, 06Maps: Include a map in categories about places - https://phabricator.wikimedia.org/T149477#2753849 (10Mohamed-Nadjib-Mami) [11:36:13] 10MediaWiki-Categories, 06Discovery, 06Maps: Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2753862 (10Mohamed-Nadjib-Mami) [11:37:19] 10MediaWiki-Categories, 06Discovery, 06Maps: Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2753849 (10Mohamed-Nadjib-Mami) [11:38:03] 10MediaWiki-Categories, 06Discovery, 06Maps: Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2753849 (10Mohamed-Nadjib-Mami) [11:40:45] 10MediaWiki-Categories, 06Maps: Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2753865 (10Mohamed-Nadjib-Mami) [11:45:45] (03PS1) 10Kghbln: Release version 0.3.1 [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318672 (https://phabricator.wikimedia.org/T123943) [11:49:46] (03CR) 10Kghbln: [C: 031] "Actually I have no idea who is maintaining this extension." [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318672 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [11:50:22] (03PS2) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318671 [11:52:03] (03CR) 10Kghbln: "Sorry that I am bothering you all the time. You know why you are my heroes!" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/316316 (https://phabricator.wikimedia.org/T138813) (owner: 10Kghbln) [11:57:29] 10ProveIt-Gadget: Ignore parameters after [[|]] - https://phabricator.wikimedia.org/T149479#2753890 (10Iniquity) [11:57:51] 10ProveIt-Gadget: Ignore parameters after [[|]] - https://phabricator.wikimedia.org/T149479#2753890 (10Iniquity) p:05Triage>03High [12:00:37] (03PS1) 10Brian Wolff: Add firstLetter data for ~50 additional languages [core] - 10https://gerrit.wikimedia.org/r/318674 [12:05:31] (03CR) 10jenkins-bot: [V: 04-1] Add firstLetter data for ~50 additional languages [core] - 10https://gerrit.wikimedia.org/r/318674 (owner: 10Brian Wolff) [12:09:30] 10MediaWiki-extensions-LdapAuthentication, 07NewPHP: LDAP login no longer works with php7.0 - https://phabricator.wikimedia.org/T149469#2753911 (10Reedy) [12:09:38] 10MediaWiki-extensions-LdapAuthentication, 07NewPHP: LDAP login no longer works with php7.0 - https://phabricator.wikimedia.org/T149469#2753623 (10Reedy) Any error messages in the logs etc? [12:10:24] 04(no projects): Extension:Approved Revs is missing an API module - https://phabricator.wikimedia.org/T149480#2753914 (10Gryllida) [12:10:43] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753925 (10Cenarium) >>! In T149019#2753665, @Urbanecm wrote: > I scheduled it for the same window (I think they can be merged to one patch by the way), so both of them wi... [12:11:00] 10MediaWiki-extensions-Other: Extension:Approved Revs is missing an API module - https://phabricator.wikimedia.org/T149480#2753926 (10Peachey88) [12:11:05] (03PS2) 10Brian Wolff: Add firstLetter data for ~50 additional languages [core] - 10https://gerrit.wikimedia.org/r/318674 [12:12:42] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753929 (10Urbanecm) Okay. Will a week delay do? I am going to revert myself. [12:13:07] 10MediaWiki-extensions-Other: Extension:Approved Revs is missing an API module - https://phabricator.wikimedia.org/T149480#2753914 (10Reedy) It may be worth "just" making ApprovedRevs a query page... And then it can work under the api list=querypage [12:13:48] (03PS3) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318671 [12:14:59] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753932 (10Urbanecm) Reverted. I can schedule for November 7th. Do you agree? [12:22:49] (03PS1) 10Reedy: Register SpecialApprovedRevsPage as a query page to expose via API et al [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/318676 (https://phabricator.wikimedia.org/T149480) [12:23:07] (03CR) 10jenkins-bot: [V: 04-1] Register SpecialApprovedRevsPage as a query page to expose via API et al [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/318676 (https://phabricator.wikimedia.org/T149480) (owner: 10Reedy) [12:23:59] 10MediaWiki-extensions-Other, 13Patch-For-Review: Extension:Approved Revs is missing an API module - https://phabricator.wikimedia.org/T149480#2753942 (10Reedy) >>! In T149480#2753930, @Reedy wrote: > It may be worth "just" making ApprovedRevs a query page... And then it can work under the api list=querypage... [12:25:22] (03PS1) 10Reedy: Move SpecialApprovedRevsPage to it's own file [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/318677 [12:25:43] (03CR) 10jenkins-bot: [V: 04-1] Move SpecialApprovedRevsPage to it's own file [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/318677 (owner: 10Reedy) [12:26:51] (03PS2) 10Reedy: Register SpecialApprovedRevsPage as a query page to expose via API et al [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/318676 (https://phabricator.wikimedia.org/T149480) [12:31:26] 10MediaWiki-General-or-Unknown, 07I18n, 07RTL: MWExceptionRenderer doesn't declare the UI language and direction - https://phabricator.wikimedia.org/T149481#2753944 (10Amire80) [12:32:11] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753958 (10Cenarium) A day or two should be enough, i.e. Thursday, November 03, if you can. [12:35:42] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753959 (10Urbanecm) Okay, November 03 13:00 UTC. Is it okay for you? [12:36:04] (03Abandoned) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318671 (owner: 10Paladox) [12:37:28] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753960 (10Cenarium) Yes, it's fine, thanks. [12:43:56] 10Wikimedia-Site-requests, 13Patch-For-Review: Add the patroller group to the English Wikipedia - https://phabricator.wikimedia.org/T149019#2753978 (10Urbanecm) You're welcome. [12:49:22] (03PS1) 10Umherirrender: Handle two digit years in Pager::getDateCond [core] - 10https://gerrit.wikimedia.org/r/318678 (https://phabricator.wikimedia.org/T149257) [13:03:53] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Ladies-That-FOSS-Wikidata, 10Wikidata, and 2 others: Introduce a setting for allowing article placeholders to be indexed by search engines - https://phabricator.wikimedia.org/T144590#2753992 (10oschposch) a:03oschposch [13:19:31] (03PS2) 10Reedy: Move SpecialApprovedRevsPage to it's own file [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/318677 [13:41:23] 10Wikimedia-Site-requests: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754002 (10MZMcBride) As noted on the talk page, a plain reading of 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata, 13Patch-For-Review: Prevent Special:NewItem from creating items multiple times (double-submitting) - https://phabricator.wikimedia.org/T147143#2754003 (10juliahimmel) a:03juliahimmel [13:46:23] (03CR) 10Florianschmidtwelzow: "Removing myself as reviewer (I usually don't review db changes, if I don't have to, sorry)." [core] - 10https://gerrit.wikimedia.org/r/318547 (https://phabricator.wikimedia.org/T146568) (owner: 10Paladox) [13:49:09] legoktm: hi :P Can I kindly ask you to review https://gerrit.wikimedia.org/r/#/c/250060/ ? :) [13:53:51] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] Release version 0.3.1 [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318672 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [13:53:52] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#2754006 (10matej_suchanek) [13:53:54] 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata, 13Patch-For-Review: Prevent Special:NewItem from creating items multiple times (double-submitting) - https://phabricator.wikimedia.org/T147143#2754005 (10matej_suchanek) [13:56:16] (03PS2) 10Florianschmidtwelzow: Release version 8.1.1 to get improvments to the public [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/316316 (https://phabricator.wikimedia.org/T138813) (owner: 10Kghbln) [13:56:24] (03CR) 10Florianschmidtwelzow: [C: 032] Release version 8.1.1 to get improvments to the public [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/316316 (https://phabricator.wikimedia.org/T138813) (owner: 10Kghbln) [13:57:24] (03Merged) 10jenkins-bot: Release version 8.1.1 to get improvments to the public [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/316316 (https://phabricator.wikimedia.org/T138813) (owner: 10Kghbln) [14:00:30] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata, 07Tracking: Prevent double submission of Special:MergeItems - https://phabricator.wikimedia.org/T149483#2754009 (10hoo) [14:00:37] 10ProveIt-Gadget: Ignore parameters after [[|]] - https://phabricator.wikimedia.org/T149479#2753890 (10Sophivorus) I tried to reproduce this bug on my localhost but failed. I then tried to find the problematic reference at https://ru.wikipedia.org/wiki/The_Elder_Scrolls_III:_Morrowind but also failed. :-( Could... [14:01:40] (03CR) 10Florianschmidtwelzow: "florian@florian-VirtualBox:/var/www/html/mediawiki/w/extensions/MassEditRegex$ git show-ref --tags" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/316316 (https://phabricator.wikimedia.org/T138813) (owner: 10Kghbln) [14:02:06] 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review: "MassEditRegex" extension / Undefined variables and Call to undefined method - https://phabricator.wikimedia.org/T138813#2754027 (10Florian) 05Open>03Resolved [14:17:36] 10MediaWiki-Search, 06Discovery, 06Discovery-Search (Current work), 05MW-1.28-release-notes, and 3 others: Put SITENAME in search box placeholder "searchsuggest-search" like in MobileFrontend's "mobile-frontend-placeholder" - https://phabricator.wikimedia.org/T144640#2754037 (10Liuxinyu970226) >>! In T1446... [14:21:02] 10MediaWiki-Logging, 10MediaWiki-Page-protection, 10MediaWiki-User-blocking, 10MediaWiki-Watchlist, and 2 others: Display an entry for page in watchlist when page protection expired; Display an entry in user page when user blocking expired - https://phabricator.wikimedia.org/T148649#2728925 (10Umherirrender... [14:22:39] (03PS2) 10Reedy: Remove FlaggedRevs.config.php [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316965 [14:22:53] 10MediaWiki-Page-protection, 05MW-1.27-release-notes: Magic word returning protection expiry - https://phabricator.wikimedia.org/T19354#2754047 (10Umherirrender) 05Open>03stalled a:03Cenarium [14:32:43] 10Wikimedia-Site-requests: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754051 (10Krenair) Yeah, this is not something MediaWiki allows us to do. [14:33:03] (03PS1) 10Umherirrender: Move count of revisions/files out of undelete log comment [core] - 10https://gerrit.wikimedia.org/r/318683 [14:34:57] 10MediaWiki-Page-protection, 05MW-1.27-release-notes: Magic word returning protection expiry - https://phabricator.wikimedia.org/T19354#2754053 (10Umherirrender) 05stalled>03Resolved [14:38:15] 10MediaWiki-History-or-Diffs: don't fatal on invalid timestamps in action=history - https://phabricator.wikimedia.org/T149415#2751560 (10Umherirrender) This is technical a duplicate of T149257 , because it is using the same code path [14:41:31] 10ProveIt-Gadget: Ignore parameters after [[|]] - https://phabricator.wikimedia.org/T149479#2754058 (10Iniquity) @Sophivorus [[https://en.wikipedia.org/w/index.php?title=The_Elder_Scrolls_III:_Morrowind&action=edit|try to check this]]. First source. [14:58:23] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Tracking: Wikibase special pages (tracking) - https://phabricator.wikimedia.org/T96040#2754069 (10juliahimmel) [14:58:25] 10MediaWiki-extensions-WikibaseRepository, 10Ladies-That-FOSS-Wikidata, 10Wikidata: Prevent Special:NewItem from creating items multiple times (double-submitting) - https://phabricator.wikimedia.org/T147143#2754067 (10juliahimmel) 05Open>03Resolved [15:06:12] 10MediaWiki-Page-editing, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2754071 (10matmarex) [15:20:39] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754076 (10Dereckson) Per MZMcBride comment here, and Andy Wang on the RfC talk page. [15:20:58] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754078 (10Xaosflux) +Consensus-needed tag as it has been questioned [15:23:28] (03PS1) 10Silke Meyer: Changing logging from wfDebug to PSR-3 [extensions/VipsScaler] (REL1_27) - 10https://gerrit.wikimedia.org/r/318686 (https://phabricator.wikimedia.org/T117385) [15:24:36] 10MediaWiki-General-or-Unknown, 10Community-IdeaLab: Allow to apply protection to user pages, excepted for the concerned user - https://phabricator.wikimedia.org/T149484#2754082 (10Dereckson) [15:25:31] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2752846 (10Dereckson) I've filled a task, T149484, to separate the development of the feature, and the en.wikipe... [15:27:09] 04(no projects): Bug in the GIPBE or Global IP Block Exemptions - https://phabricator.wikimedia.org/T149425#2754100 (10Aklapper) @Mbrt: I do not see any software bug here. From what you wrote, English Wikipedia administrators probably set a block for a certain IP range. Please explain what exactly is the //sof... [15:30:35] (03CR) 10BryanDavis: "Is there a reason this patch is for REL1_27 and not master?" (031 comment) [extensions/VipsScaler] (REL1_27) - 10https://gerrit.wikimedia.org/r/318686 (https://phabricator.wikimedia.org/T117385) (owner: 10Silke Meyer) [15:32:12] (03CR) 10Daniel Kinzler: [V: 032] More robust AssertTest [libs/Assert] - 10https://gerrit.wikimedia.org/r/316337 (owner: 10Thiemo Mättig (WMDE)) [15:33:00] (03PS5) 10Cicalese: Made comments searchable; refactored [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/318579 [15:33:04] 04(no projects): Global IP Block Exemptions aren't honored on en.wikipedia - https://phabricator.wikimedia.org/T149425#2754105 (10Dereckson) [15:34:35] (03PS2) 10Florianschmidtwelzow: Don't show warning header for non-standard workflows on login-continue [core] - 10https://gerrit.wikimedia.org/r/312110 (https://phabricator.wikimedia.org/T146317) [15:35:22] (03PS6) 10Cicalese: Made comments searchable; refactored [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/318579 [15:36:27] 04(no projects): Global IP Block Exemptions aren't honored on en.wikipedia - https://phabricator.wikimedia.org/T149425#2754109 (10Dereckson) [15:38:06] 04(no projects): Global IP Block Exemptions aren't honored on en.wikipedia - https://phabricator.wikimedia.org/T149425#2752034 (10Dereckson) 05stalled>03Open p:05Triage>03High [15:39:35] (03CR) 10Daniel Kinzler: [V: 032] More specific type hints [libs/Assert] - 10https://gerrit.wikimedia.org/r/316336 (owner: 10Thiemo Mättig (WMDE)) [15:39:56] 10MediaWiki-extensions-GlobalBlocking: Global IP Block Exemptions aren't honored on en.wikipedia - https://phabricator.wikimedia.org/T149425#2754116 (10Dereckson) [15:40:50] (03CR) 10Daniel Kinzler: [V: 032] Non-empty string assertion [libs/Assert] - 10https://gerrit.wikimedia.org/r/316324 (owner: 10Thiemo Mättig (WMDE)) [15:41:28] (03CR) 10Daniel Kinzler: [V: 032] Add Traversable as a pseudo-type [libs/Assert] - 10https://gerrit.wikimedia.org/r/316315 (owner: 10Thiemo Mättig (WMDE)) [15:42:44] (03PS1) 10Silke Meyer: Changing logging from wfDebug to PSR-3 [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/318687 (https://phabricator.wikimedia.org/T117385) [15:43:02] 10MediaWiki-extensions-GlobalBlocking: Global IP Block Exemptions aren't honored on en.wikipedia - https://phabricator.wikimedia.org/T149425#2752034 (10Dereckson) @Aklapper So there is an issue, because the GlobalBlocking extension allows some contributors to use blocked IP ranges. Blocked ranges tend to be used... [15:44:19] (03Abandoned) 10Silke Meyer: Changing logging from wfDebug to PSR-3 [extensions/VipsScaler] (REL1_27) - 10https://gerrit.wikimedia.org/r/318686 (https://phabricator.wikimedia.org/T117385) (owner: 10Silke Meyer) [15:44:26] (03PS7) 10Cicalese: Made comments searchable; refactored [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/318579 [15:46:00] (03CR) 10Silke Meyer: "It had this branch because I followed a tutorial that said so and I copy-pasted it. No special reason." [extensions/VipsScaler] (REL1_27) - 10https://gerrit.wikimedia.org/r/318686 (https://phabricator.wikimedia.org/T117385) (owner: 10Silke Meyer) [15:47:39] (03CR) 10Daniel Kinzler: "The unit test still calls wfDebug. It's not clear to me why a unit test would do that, but we should decide to either remove these calls, " [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/318687 (https://phabricator.wikimedia.org/T117385) (owner: 10Silke Meyer) [16:03:51] (03CR) 10Florianschmidtwelzow: [C: 04-1] Patched to work with MediaWiki 1.27.1 (033 comments) [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316476 (owner: 10Jkmartindale) [16:04:29] 10Wikimedia-General-or-Unknown: Gadget styles loaded twice on meta as anon - https://phabricator.wikimedia.org/T149485#2754131 (10Reedy) [16:05:49] (03CR) 10Florianschmidtwelzow: [C: 032] Edit Personal URL injection to play nicer with other extensions [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316518 (owner: 10Jkmartindale) [16:06:48] (03Merged) 10jenkins-bot: Edit Personal URL injection to play nicer with other extensions [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316518 (owner: 10Jkmartindale) [16:09:08] (03PS1) 10Gerrit Patch Uploader: Special:block: toggle hideuser checkbox based on expiry time [core] - 10https://gerrit.wikimedia.org/r/318690 (https://phabricator.wikimedia.org/T133036) [16:09:11] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/318690 (https://phabricator.wikimedia.org/T133036) (owner: 10Gerrit Patch Uploader) [16:11:02] (03PS3) 10Jkmartindale: Incorporate Tim Koester's German translation [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316569 [16:11:04] (03CR) 10Florianschmidtwelzow: [C: 032] Incorporate Tim Koester's German translation [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316569 (owner: 10Jkmartindale) [16:11:24] (03CR) 10Florianschmidtwelzow: [C: 032] Documented localization strings in qqq.json [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316820 (owner: 10Jkmartindale) [16:11:47] (03Merged) 10jenkins-bot: Incorporate Tim Koester's German translation [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316569 (owner: 10Jkmartindale) [16:11:55] 10MediaWiki-General-or-Unknown: #/talk/5 URL not working for some people - https://phabricator.wikimedia.org/T149487#2754157 (10Reedy) [16:12:07] (03Merged) 10jenkins-bot: Documented localization strings in qqq.json [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316820 (owner: 10Jkmartindale) [16:12:44] (03CR) 10Mattflaschen: "I paired with Greta on this, so another review would be welcome." [core] - 10https://gerrit.wikimedia.org/r/318690 (https://phabricator.wikimedia.org/T133036) (owner: 10Gerrit Patch Uploader) [16:14:10] 10Wikimedia-General-or-Unknown, 07Technical-Debt: Gadget styles loaded twice on meta as anon - https://phabricator.wikimedia.org/T149485#2754170 (10Reedy) [16:15:39] (03PS4) 10Jkmartindale: Patched to work with MediaWiki 1.27.1 [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316476 [16:18:55] 10MediaWiki-General-or-Unknown: #/talk/5 URL not working for some people - https://phabricator.wikimedia.org/T149487#2754184 (10Reedy) [16:21:06] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Apart from the minor variable assignment, this looks pretty nice and I'll merge this, after it is fixed :D" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/288197 (https://phabricator.wikimedia.org/T116354) (owner: 10Sethakill) [16:21:44] (03CR) 10Florianschmidtwelzow: [C: 032] "Thanks for the patch!" (031 comment) [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316476 (owner: 10Jkmartindale) [16:22:31] (03Merged) 10jenkins-bot: Patched to work with MediaWiki 1.27.1 [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/316476 (owner: 10Jkmartindale) [16:24:17] FlorianSW: https://gerrit.wikimedia.org/r/#/c/318664/ [16:24:22] (03PS1) 10Wikirina: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/318691 (https://phabricator.wikimedia.org/T45817) [16:25:18] (03PS8) 10Cicalese: Made comments searchable; refactored [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/318579 [16:25:32] (03CR) 10Florianschmidtwelzow: [C: 032] Various small cleanups to DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318664 (owner: 10Aaron Schulz) [16:25:40] AaronSchulz: ^ [16:25:48] \o/ [16:26:11] :D [16:29:17] (03CR) 10Wikirina: "this is just work in progress" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/318691 (https://phabricator.wikimedia.org/T45817) (owner: 10Wikirina) [16:30:19] (03PS2) 10Florianschmidtwelzow: Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) [16:31:06] (03CR) 10jenkins-bot: [V: 04-1] Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) (owner: 10Florianschmidtwelzow) [16:32:06] (03Abandoned) 10Florianschmidtwelzow: SpecialSearch: Duplicate the pager to the top [core] - 10https://gerrit.wikimedia.org/r/293731 (https://phabricator.wikimedia.org/T38923) (owner: 10Florianschmidtwelzow) [16:33:28] (03Merged) 10jenkins-bot: Various small cleanups to DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318664 (owner: 10Aaron Schulz) [16:34:44] (03PS3) 10Florianschmidtwelzow: Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) [16:35:26] FlorianSW: another easy one https://gerrit.wikimedia.org/r/#/c/318255/ [16:35:38] (03CR) 10jenkins-bot: [V: 04-1] Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) (owner: 10Florianschmidtwelzow) [16:37:13] AaronSchulz: I currently rebasing a change in my mediawiki/core checkout, after it I'll review yours :) [16:40:45] (03PS4) 10Florianschmidtwelzow: OutputPage::getCategories(): Add a possibility to distinguish "normal" and "hidden" categories [core] - 10https://gerrit.wikimedia.org/r/298040 [16:46:20] (03CR) 10Florianschmidtwelzow: [C: 032] Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 (owner: 10Aaron Schulz) [16:50:07] (03PS4) 10Florianschmidtwelzow: Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) [16:50:52] (03CR) 10jenkins-bot: [V: 04-1] Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) (owner: 10Florianschmidtwelzow) [16:55:24] (03Merged) 10jenkins-bot: Make LBFactoryTest.php pass for sqlite [core] - 10https://gerrit.wikimedia.org/r/318255 (owner: 10Aaron Schulz) [16:55:27] (03PS5) 10Florianschmidtwelzow: Don't add url parameters to an input box, if the parameter is empty [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/314070 (https://phabricator.wikimedia.org/T147048) [16:57:50] (03PS6) 10Florianschmidtwelzow: Rebuilt PHPVersionCheck to be an own class [core] - 10https://gerrit.wikimedia.org/r/310341 [17:02:20] (03PS1) 10Aaron Schulz: Fix missing commit() flag in postgres savepoint class [core] - 10https://gerrit.wikimedia.org/r/318692 [17:02:23] (03PS1) 10Aaron Schulz: Add missing Database::timestamp() calls [core] - 10https://gerrit.wikimedia.org/r/318693 [17:03:44] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2754195 (10aaron) I'm getting all but a few failures with https://gerrit.wikimedia.org/r/#/c/318692/ and http... [17:06:29] 10MediaWiki-Categories, 06Discovery, 10Kartographer, 06Maps: Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2754199 (10MaxSem) [17:06:56] 10MediaWiki-Database, 05MW-1.28-release, 07Regression: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2754201 (10Paladox) Fixed in https://gerrit.wikimedia.org/r/#/c/318692/ [17:09:07] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2754202 (10Paladox) @aaron there's T149454 which I think it's because we doint call tableName, see https://gi... [17:09:19] (03PS8) 10Florianschmidtwelzow: Add HHVM version check [core] - 10https://gerrit.wikimedia.org/r/310342 (https://phabricator.wikimedia.org/T123436) [17:09:22] (03PS7) 10Florianschmidtwelzow: Rebuilt PHPVersionCheck to be an own class [core] - 10https://gerrit.wikimedia.org/r/310341 [17:11:23] (03PS8) 10Florianschmidtwelzow: Rebuilt PHPVersionCheck to be an own class [core] - 10https://gerrit.wikimedia.org/r/310341 [17:17:15] 10MediaWiki-General-or-Unknown, 10Community-IdeaLab: Allow to apply protection to user pages, excepted for the concerned user - https://phabricator.wikimedia.org/T149484#2754206 (10MZMcBride) My understanding is that the `editmyusercss` and `editmyuserjs` user rights were introduced due to security concerns. T... [17:22:54] (03CR) 10Paladox: [C: 031] Rebuilt PHPVersionCheck to be an own class [core] - 10https://gerrit.wikimedia.org/r/310341 (owner: 10Florianschmidtwelzow) [17:23:09] (03CR) 10Paladox: [C: 031] Add HHVM version check [core] - 10https://gerrit.wikimedia.org/r/310342 (https://phabricator.wikimedia.org/T123436) (owner: 10Florianschmidtwelzow) [17:23:54] $ ssh -p 29418 Siteshpattanaik001@gerrit.wikimedia.org Permission denied (publickey). [17:24:02] i am getting this error , any help [17:25:15] 10MediaWiki-General-or-Unknown, 10Community-IdeaLab: Allow to apply protection to user pages, excepted for the concerned user - https://phabricator.wikimedia.org/T149484#2754207 (10MZMcBride) [17:27:09] 10MediaWiki-General-or-Unknown, 10Community-IdeaLab: Allow to apply protection to user pages, excepted for the concerned user - https://phabricator.wikimedia.org/T149484#2754082 (10MZMcBride) I tried to expand the task description, but there nuances that I'm not sure I captured. I described the issue with ver... [17:32:01] 07Design, 10MediaWiki-extensions-CookieWarning, 06Reading-Web-Backlog: Improve positioning of CookieWarning on mobile - https://phabricator.wikimedia.org/T146077#2754210 (10Florian) Ok, no response so far, so I registered, but: > You’re not invited to this project ... :( :( [17:32:35] (03CR) 10Florianschmidtwelzow: [C: 032] Add option to limit the cookie warning to specific regions [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) (owner: 10Florianschmidtwelzow) [17:33:21] 10MediaWiki-extensions-CookieWarning, 13Patch-For-Review: Add geolocation support (EU/non-EU) to CookieWarning - https://phabricator.wikimedia.org/T145780#2754212 (10Florian) @Paladox: For language-specific filtering, could you please open a new task? I'll close this one, as it is meant to merge the functional... [17:33:24] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754214 (10Florian) [17:33:26] 10MediaWiki-extensions-CookieWarning, 13Patch-For-Review: Add geolocation support (EU/non-EU) to CookieWarning - https://phabricator.wikimedia.org/T145780#2754213 (10Florian) 05Open>03Resolved [17:33:29] (03Merged) 10jenkins-bot: Add option to limit the cookie warning to specific regions [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) (owner: 10Florianschmidtwelzow) [17:34:42] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2639200 (10Florian) [17:36:16] 10MediaWiki-extensions-CookieWarning: Make the CookiePolicy extension read-only/deprecated in favour of CookieWarning - https://phabricator.wikimedia.org/T149489#2754217 (10Florian) [17:37:30] (03Draft1) 10Florianschmidtwelzow: Make this extension read-only [extensions/CookiePolicy] - 10https://gerrit.wikimedia.org/r/318694 (https://phabricator.wikimedia.org/T149489) [17:37:38] (03Abandoned) 10Florianschmidtwelzow: Make this extension read-only [extensions/CookiePolicy] - 10https://gerrit.wikimedia.org/r/318694 (https://phabricator.wikimedia.org/T149489) (owner: 10Florianschmidtwelzow) [17:38:46] 10MediaWiki-extensions-FlaggedRevs: Allow FlaggedRevs to prevent unreviewed changes to transcluded (template) pages being visible on pages that don't themselves have FlaggedRevs enabled - https://phabricator.wikimedia.org/T61102#2754235 (10andymw) There are articles that transclude sections of other articles (`#... [17:39:06] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754238 (10Florian) [17:39:08] 10MediaWiki-extensions-CookieWarning, 13Patch-For-Review: Make the CookiePolicy extension read-only/deprecated in favour of CookieWarning - https://phabricator.wikimedia.org/T149489#2754236 (10Florian) 05Open>03Resolved Marked as read-only. [17:39:23] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2639200 (10Florian) [17:42:08] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754240 (10Florian) [17:52:21] 10MediaWiki-Categories, 06Discovery, 10Kartographer, 06Maps: Include a map in category pages about places - https://phabricator.wikimedia.org/T149477#2754242 (10Mohamed-Nadjib-Mami) [17:55:11] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754243 (10Florian) [17:55:20] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2639200 (10Florian) 05Open>03Resolved a:03Florian Ok, finished! :D [17:56:38] (03Abandoned) 10Florianschmidtwelzow: Allow users to save reading lists to the external memory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300325 (https://phabricator.wikimedia.org/T130622) (owner: 10Florianschmidtwelzow) [17:59:00] (03CR) 10Umherirrender: [C: 032] Add missing Database::timestamp() calls [core] - 10https://gerrit.wikimedia.org/r/318693 (owner: 10Aaron Schulz) [18:02:31] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2754249 (10Paladox) @aaron maybe this rMW13384d9988dd2a484d4650a4939f2817951735a8 broke things? [18:03:34] 10MediaWiki-Search, 06Discovery, 06Discovery-Search (Current work), 05MW-1.28-release-notes, and 3 others: Put SITENAME in search box placeholder "searchsuggest-search" like in MobileFrontend's "mobile-frontend-placeholder" - https://phabricator.wikimedia.org/T144640#2754250 (10Deskana) >>! In T144640#2754... [18:05:56] (03PS1) 10Umherirrender: Pass user to Title::quickUserCan in InfoAction [core] - 10https://gerrit.wikimedia.org/r/318695 [18:08:53] (03CR) 10Kghbln: "Thanks a lot Florian for submitting and tagging! Great! Just updated the wiki!" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/316316 (https://phabricator.wikimedia.org/T138813) (owner: 10Kghbln) [18:09:22] 10MediaWiki-extensions-General-or-Unknown: "MassEditRegex" extension / Undefined variables and Call to undefined method - https://phabricator.wikimedia.org/T138813#2754251 (10Kghbln) [18:10:45] 10MediaWiki-General-or-Unknown, 10Community-IdeaLab: Allow to apply protection to user pages, excepted for the concerned user - https://phabricator.wikimedia.org/T149484#2754254 (10Funcrunch) MZMcBride, the RfC specifically included a provision for very new users to be able to edit their own user pages. This w... [18:11:14] 10AbuseFilter: AbuseFilter Messages shown as html - https://phabricator.wikimedia.org/T149490#2754255 (10Dmitry89) [18:14:17] 10AbuseFilter: AbuseFilter Messages shown as html - https://phabricator.wikimedia.org/T149490#2754269 (10Dmitry89) p:05Triage>03High [18:14:48] 10MediaWiki-Search, 06Discovery, 06Discovery-Search (Current work), 05MW-1.28-release-notes, and 3 others: Put SITENAME in search box placeholder "searchsuggest-search" like in MobileFrontend's "mobile-frontend-placeholder" - https://phabricator.wikimedia.org/T144640#2754270 (10Deskana) I believe that [[ht... [18:25:52] (03PS1) 10Umherirrender: Add LinkBatch to Special:UnwatchedPages [core] - 10https://gerrit.wikimedia.org/r/318696 [18:32:37] 10AbuseFilter: AbuseFilter Messages shown as html - https://phabricator.wikimedia.org/T149490#2754275 (10Jack_who_built_the_house) Related community discussion: [[https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%A2%D0%B5%D1%85%D0%BD%D0%B8%D1%... [18:42:14] 10MediaWiki-Special-pages, 10MediaWiki-User-blocking, 10Ladies-That-FOSS-MediaWiki, 07Easy, 07JavaScript: hideuser field on Special:block should be hidden with javascript when time field not indefinite - https://phabricator.wikimedia.org/T133036#2754280 (10Mattflaschen-WMF) a:03Margott [18:42:57] 04(no projects): A bunch of papers - https://phabricator.wikimedia.org/T149491#2754281 (10Umar) [18:43:35] 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-VipsScaler, 10Ladies-That-FOSS-MediaWiki, 07Easy, 13Patch-For-Review: VipsScaler should use new logging system - https://phabricator.wikimedia.org/T117385#2754292 (10Mattflaschen-WMF) a:03silke [18:45:15] 10AbuseFilter: AbuseFilter Messages shown as html - https://phabricator.wikimedia.org/T149490#2754294 (10Jack_who_built_the_house) Suspiciously similar bug: T147735 "Raw HTML shown in Authmanager-authn-autocreate-failed". Its author noted in the discussion mentioned above that it occurs on ruwiki but not on enwiki. [18:51:34] (03PS1) 10Umherirrender: Use Database::addQuotes in Special:WantedPages/UnwatchedPages [core] - 10https://gerrit.wikimedia.org/r/318697 [19:03:51] (03CR) 10Anirudh24seven: "Hi. Any updates for patch set 2?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/318052 (https://phabricator.wikimedia.org/T143732) (owner: 10Anirudh24seven) [19:18:08] (03PS1) 10Sophivorus: Fix parameters ignored after [[]] [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/318698 (https://phabricator.wikimedia.org/T149479) [19:19:04] (03PS2) 10Sophivorus: Fix parameters ignored after [[]] [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/318698 (https://phabricator.wikimedia.org/T149479) [19:19:09] (03CR) 10Sophivorus: [C: 032 V: 032] Fix parameters ignored after [[]] [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/318698 (https://phabricator.wikimedia.org/T149479) (owner: 10Sophivorus) [19:19:35] 10ProveIt-Gadget, 13Patch-For-Review: Ignore parameters after [[|]] - https://phabricator.wikimedia.org/T149479#2754300 (10Sophivorus) 05Open>03Resolved a:03Sophivorus [19:31:22] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2754304 (10mwjames) > I'm getting all but a few failures with https://gerrit.wikimedia.org/r/#/c/318692/ and... [19:32:40] 10MediaWiki-extensions-SemanticBundle: After moving a wiki, properties do not update, even with a newly created page - https://phabricator.wikimedia.org/T71894#2754306 (10Aklapper) 05Open>03Invalid In T64114, the SMW maintainers decided to track #MediaWiki-extensions-SemanticBundle issues in GitHub at https:... [19:32:42] 10MediaWiki-extensions-SemanticBundle: SemanticBundle class loading issue - https://phabricator.wikimedia.org/T66869#2754311 (10Aklapper) 05Open>03Invalid In T64114, the SMW maintainers decided to track #MediaWiki-extensions-SemanticBundle issues in GitHub at https://github.com/SemanticMediaWiki/SemanticMedi... [19:32:44] 10MediaWiki-extensions-SemanticBundle: enhance Semantic Result Formats Math to calculate Dates - https://phabricator.wikimedia.org/T64564#2754316 (10Aklapper) 05Open>03Invalid In T64114, the SMW maintainers decided to track #MediaWiki-extensions-SemanticBundle issues in GitHub at https://github.com/SemanticM... [19:32:46] 10MediaWiki-extensions-SemanticBundle: Semantic HTML for SMW - https://phabricator.wikimedia.org/T56853#2754320 (10Aklapper) 05Open>03Invalid In T64114, the SMW maintainers decided to track #MediaWiki-extensions-SemanticBundle issues in GitHub at https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues... [19:32:48] 10MediaWiki-extensions-SemanticBundle: [Header Tabs] Tab TOC has duplicate contents - https://phabricator.wikimedia.org/T47497#2754325 (10Aklapper) 05Open>03Invalid In T64114, the SMW maintainers decided to track #MediaWiki-extensions-SemanticBundle issues in GitHub at https://github.com/SemanticMediaWiki/Se... [19:32:50] 10MediaWiki-extensions-SemanticBundle: smwgUseCategoryHierarchy doesnt have any effect when querying for top level category only - https://phabricator.wikimedia.org/T46673#2754330 (10Aklapper) 05Open>03Invalid In T64114, the SMW maintainers decided to track #MediaWiki-extensions-SemanticBundle issues in GitH... [19:33:30] (03PS1) 10Kghbln: Fix breaking typo [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 [19:35:06] (03CR) 10Kghbln: "Thanks Florian. Very much appreciated!" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318672 (https://phabricator.wikimedia.org/T123943) (owner: 10Kghbln) [19:37:23] (03CR) 10Kghbln: [C: 031] "@Florian This is a follow up to https://gerrit.wikimedia.org/r/#/c/318672" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [19:38:04] 10MediaWiki-Database, 05MW-1.28-release, 07Regression: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2754335 (10mwjames) > https://gerrit.wikimedia.org/r/#/c/318692/ I won't have time to verify (via the web-installer) that this is solved. If... [19:38:32] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2754336 (10Paladox) @mwjames you could checkout master? And checkout the patches? [19:46:41] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2639200 (10Kghbln) One little nitpick: The "extension.json" file still holds 0.1.0 as this extension's version. [19:50:34] (03CR) 10Paladox: [C: 031] Fix missing commit() flag in postgres savepoint class [core] - 10https://gerrit.wikimedia.org/r/318692 (owner: 10Aaron Schulz) [20:09:47] 10ProveIt-Gadget, 13Patch-For-Review: Misinterpreting multiple templates within ref tag - https://phabricator.wikimedia.org/T148884#2754355 (10Sophivorus) I looked into this issue and it seems that the solution will require moving away from regexes and into full blown parsing. It's quite complicated I'm afraid... [20:13:36] (03PS1) 10Florianschmidtwelzow: Bump version number to 0.2.0 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/318702 (https://phabricator.wikimedia.org/T145723) [20:13:48] (03CR) 10Florianschmidtwelzow: [C: 032] Bump version number to 0.2.0 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/318702 (https://phabricator.wikimedia.org/T145723) (owner: 10Florianschmidtwelzow) [20:13:55] 10MediaWiki-extensions-CookieWarning, 13Patch-For-Review: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754359 (10Florian) Fixed :) [20:14:17] 06Developer-Relations (Oct-Dec-2016), 03Google-Code-In-2016: Recruit Google Code-in 2016 mentors - https://phabricator.wikimedia.org/T148952#2754360 (10Aklapper) >>! In T148952#2753662, @srishakatux wrote: > I might have missed this info, but do we have a full list of last year's students somewhere? @srishak... [20:14:50] (03CR) 10Florianschmidtwelzow: [C: 032] "hmm, lazy review from me :(" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [20:14:52] (03Merged) 10jenkins-bot: Bump version number to 0.2.0 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/318702 (https://phabricator.wikimedia.org/T145723) (owner: 10Florianschmidtwelzow) [20:18:30] (03CR) 10Florianschmidtwelzow: [C: 032] Add LinkBatch to Special:UnwatchedPages [core] - 10https://gerrit.wikimedia.org/r/318696 (owner: 10Umherirrender) [20:24:23] 06Wikimedia-DC: Make donate.wikimediadc.org a redirect - https://phabricator.wikimedia.org/T149493#2754364 (10Harej) [20:24:44] 06Wikimedia-DC: Develop a privacy policy for wikimediadc.org - https://phabricator.wikimedia.org/T116559#2754376 (10Harej) 05Open>03Resolved [20:28:10] (03Merged) 10jenkins-bot: Add LinkBatch to Special:UnwatchedPages [core] - 10https://gerrit.wikimedia.org/r/318696 (owner: 10Umherirrender) [20:29:12] (03PS7) 10Amire80: Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [20:30:06] (03CR) 10Amire80: [C: 04-1] "(-1 According to Niklas.)" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [20:31:41] FlorianSW: one more https://gerrit.wikimedia.org/r/#/c/318692/ [20:35:25] (03CR) 10Florianschmidtwelzow: [C: 032] Fix missing commit() flag in postgres savepoint class [core] - 10https://gerrit.wikimedia.org/r/318692 (owner: 10Aaron Schulz) [20:38:36] AaronSchulz: ^ [20:39:24] (03CR) 10Kghbln: "No worries. To many trivial changes to see all of this. I was me causing this due to not testing better. However, a merge will still be co" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [20:43:16] (03Merged) 10jenkins-bot: Fix missing commit() flag in postgres savepoint class [core] - 10https://gerrit.wikimedia.org/r/318692 (owner: 10Aaron Schulz) [20:43:59] 10MediaWiki-Database, 05MW-1.28-release, 07Regression: 1.28-alpha / Uncommitted DB writes (transaction from FOR SAVEPOINT) - https://phabricator.wikimedia.org/T149468#2754381 (10aaron) 05Open>03Resolved a:03aaron [20:46:58] (03CR) 10Aaron Schulz: [C: 032] Add missing Database::timestamp() calls [core] - 10https://gerrit.wikimedia.org/r/318693 (owner: 10Aaron Schulz) [20:47:05] (03PS2) 10Aaron Schulz: Add missing Database::timestamp() calls [core] - 10https://gerrit.wikimedia.org/r/318693 [20:47:10] (03PS1) 10Florianschmidtwelzow: Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 [20:47:19] (03CR) 10Ladsgroup: [C: 032] "I added as much as reviewer I could. No one reviewed in the past five days, it's just tests. I +2 it and if anyone disagree, I revert." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/317172 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [20:47:21] (03CR) 10Kghbln: "Could you also tag?" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [20:47:39] (03CR) 10Aaron Schulz: [C: 032] Add missing Database::timestamp() calls [core] - 10https://gerrit.wikimedia.org/r/318693 (owner: 10Aaron Schulz) [20:47:50] (03PS2) 10Florianschmidtwelzow: Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 [20:48:24] AaronSchulz: could you take a look at ^ [20:48:32] especially where I removed the check for isCached()? [20:48:33] https://gerrit.wikimedia.org/r/#/c/318729/2/includes/specials/SpecialMostcategories.php [20:49:04] If I'm not mistaken, LinkBatch can and should be used, even if the SpecialPage result isn't cached, as it just batches the title lookup into one query. [20:50:11] (03CR) 10Florianschmidtwelzow: Move LinkBatch operations for QueryPage to a helper function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/318729 (owner: 10Florianschmidtwelzow) [20:50:23] 10MediaWiki-extensions-CookieWarning, 13Patch-For-Review: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754385 (10Kghbln) >>! In T145723#2754359, @Florian wrote: > Fixed :) Cool. Thanks! [20:50:27] (03PS1) 10Paladox: Fix missing commit() flag in postgres savepoint class [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/318748 [20:51:38] (03PS1) 10Paladox: Add missing Database::timestamp() calls [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/318755 [20:51:56] yeah, isCached() should not make a difference [20:52:41] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/318710 (owner: 10L10n-bot) [20:52:47] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/318710 (owner: 10L10n-bot) [20:53:19] (03CR) 10Reedy: Add missing Database::timestamp() calls (031 comment) [core] - 10https://gerrit.wikimedia.org/r/318693 (owner: 10Aaron Schulz) [20:53:37] (03CR) 10Reedy: [C: 032] Remove FlaggedRevs.config.php [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316965 (owner: 10Reedy) [20:55:01] FlorianSW: is that ternary backwards for $ns? [20:55:30] (03CR) 10Kghbln: "For some reason you would have to start at the bottom from 0.1.0 up to 0.3.1 since the sorting is by timestamp tagged and not by tab. Will" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [20:55:54] (03Merged) 10jenkins-bot: Add CacheTest.php (was Extensive CI tests, part III) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/317172 (https://phabricator.wikimedia.org/T146560) (owner: 10Ladsgroup) [20:56:16] (03CR) 10jenkins-bot: [V: 04-1] Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 (owner: 10Florianschmidtwelzow) [20:56:39] (03Merged) 10jenkins-bot: Add missing Database::timestamp() calls [core] - 10https://gerrit.wikimedia.org/r/318693 (owner: 10Aaron Schulz) [20:57:18] (03Merged) 10jenkins-bot: Remove FlaggedRevs.config.php [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/316965 (owner: 10Reedy) [20:57:26] (03PS1) 10Reedy: Remove FlaggedRevs.config.php [extensions/FlaggedRevs] (REL1_28) - 10https://gerrit.wikimedia.org/r/318767 [20:57:41] (03CR) 10Reedy: [C: 032] "Might aswell clean this up in REL1_28 too" [extensions/FlaggedRevs] (REL1_28) - 10https://gerrit.wikimedia.org/r/318767 (owner: 10Reedy) [20:58:26] AaronSchulz: what exactly do you mean? :/ [20:59:13] (03CR) 10Florianschmidtwelzow: "I tagged this a bit different, from what I found in the git history. Not all versions are written in the version number, so this is what t" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [20:59:56] (03PS3) 10Florianschmidtwelzow: Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 [21:00:22] FlorianSW: it uses $ns if $ns is null [21:01:15] (03Merged) 10jenkins-bot: Remove FlaggedRevs.config.php [extensions/FlaggedRevs] (REL1_28) - 10https://gerrit.wikimedia.org/r/318767 (owner: 10Reedy) [21:02:57] AaronSchulz: whoops... [21:03:05] FlorianSW: Have you tested this? [21:03:06] that isn't correct :P [21:03:45] I wish tools grid would freakin work for me :/ [21:05:15] (03CR) 10Kghbln: "Thank you!!! I took the commits from GitHub so perhaps they are different. Does not matter. However having the 0.3.0 tag though it was not" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [21:06:30] Reedy: yes, but unfortunately only with Special:Mostlinkedcategories (as this was the special page, why I added this condition) [21:06:57] thinking about it, I now don't think, that this condition is needed at all? [21:09:14] (03PS4) 10Florianschmidtwelzow: Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 [21:11:53] 10MediaWiki-Database, 05MW-1.28-release, 13Patch-For-Review, 07Regression: 1.28-alpha / Error: 42P07 ERROR: relation "logging_log_id_seq" already exists - https://phabricator.wikimedia.org/T148628#2754388 (10mwjames) > Anyway, once the changes are merged I'll give it another shot. The original issue is f... [21:14:37] (03CR) 10Florianschmidtwelzow: "okok :P" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [21:15:00] (03CR) 10Florianschmidtwelzow: [V: 032] Fix breaking typo [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [21:15:19] (03CR) 10Florianschmidtwelzow: "damn, and one more, I'll fix the 0.3.1 tag to include this commit." [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [21:19:30] (03CR) 10Aaron Schulz: [C: 032] Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 (owner: 10Florianschmidtwelzow) [21:23:05] thx AaronSchulz :) [21:23:57] (03CR) 10Kghbln: "Yeah, now everything is fluffy. Thanks! Cool and the first public wiki is already running it successfully. :) Great collaboration! Have a " [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [21:26:23] (03CR) 10Florianschmidtwelzow: "You, too ;)" [extensions/DateDiff] - 10https://gerrit.wikimedia.org/r/318700 (owner: 10Kghbln) [21:28:40] (03Merged) 10jenkins-bot: Move LinkBatch operations for QueryPage to a helper function [core] - 10https://gerrit.wikimedia.org/r/318729 (owner: 10Florianschmidtwelzow) [21:31:15] 10AbuseFilter: AbuseFilter Messages shown as html - https://phabricator.wikimedia.org/T149490#2754493 (10Nirmos) [21:31:17] 10MediaWiki-Page-editing, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2754496 (10Nirmos) [21:34:50] 10MediaWiki-extensions-LiquidThreads, 13Patch-For-Review: Convert LiquidThreads to use extension registration - https://phabricator.wikimedia.org/T87935#1001635 (10Nemo_bis) LQT configuration is not obvious, it would be appropriate to not destroy the documentation. https://phabricator.wikimedia.org/rELQTc79c79... [21:36:54] 04(no projects): A bunch of papers - https://phabricator.wikimedia.org/T149491#2754499 (10Umar) In order to tie the article takes a long time, I have to refresh the page a few times, and it takes a lot of time. [21:37:09] (03PS1) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 [21:45:18] 10MediaWiki-Page-editing, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2754508 (10Urbanecm) p:05Triage>03Unbreak! UBN as this breaks almost all filters at cswiki with warn. At least a revert of mentoined change. [21:49:24] 10MediaWiki-Page-editing, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2753758 (10Paladox) The only recent change to AbuseFilter is rEABFb31d903900f62972b8a1e74f8c2b7dc6b80a44a5 rEABF0309113bd98b3cb68d3d996682606ea4b5927559 Did this only recently happen? Like l... [21:49:38] 10MediaWiki-Page-editing, 10AbuseFilter, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2754514 (10Paladox) [21:51:29] (03PS1) 10Paladox: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] - 10https://gerrit.wikimedia.org/r/318770 [21:51:57] (03CR) 10jenkins-bot: [V: 04-1] Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] - 10https://gerrit.wikimedia.org/r/318770 (owner: 10Paladox) [21:55:39] (03PS2) 10Paladox: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) [21:56:19] 10MediaWiki-extensions-FlaggedRevs: Allow FlaggedRevs to prevent unreviewed changes to transcluded (template) pages being visible on pages that don't themselves have FlaggedRevs enabled - https://phabricator.wikimedia.org/T61102#2754521 (10Cenarium) I've tested [[https://www.mediawiki.org/wiki/Extension:Labeled_... [21:56:29] (03PS3) 10Paladox: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) [21:57:10] (03PS4) 10Paladox: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) [21:58:20] 10MediaWiki-Page-editing, 10AbuseFilter, 13Patch-For-Review, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2754522 (10Dereckson) [21:59:44] (03CR) 10Dereckson: [C: 04-1] "Summary is > 72 characters" [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) (owner: 10Paladox) [22:00:29] 10MediaWiki-extensions-CookieWarning: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2754536 (10Kghbln) [22:01:34] (03PS5) 10Paladox: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) [22:02:16] (03CR) 10Paladox: "> Summary is > 72 characters" [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) (owner: 10Paladox) [22:03:14] (03CR) 10Dereckson: "Uses the adverb partially if you don't revert anything, and keep summary first line < 72 characters to avoid any title truncate." [core] - 10https://gerrit.wikimedia.org/r/318770 (https://phabricator.wikimedia.org/T149473) (owner: 10Paladox) [22:03:25] (03PS1) 10Paladox: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] (wmf/1.28.0-wmf.23) - 10https://gerrit.wikimedia.org/r/318772 (https://phabricator.wikimedia.org/T149473) [22:08:47] 10ProveIt-Gadget, 13Patch-For-Review: Misinterpreting multiple templates within ref tag - https://phabricator.wikimedia.org/T148884#2754544 (10Iniquity) @Sophivorus I think old prove it hasnt this problem, and it works with regex. May we steal smth from it? [22:10:49] (03CR) 10Reedy: [C: 032] Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] (wmf/1.28.0-wmf.23) - 10https://gerrit.wikimedia.org/r/318772 (https://phabricator.wikimedia.org/T149473) (owner: 10Paladox) [22:10:57] (03PS1) 10Paladox: Make determineCoreSchema a public function again in DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318773 [22:13:18] (03PS2) 10Paladox: Make determineCoreSchema a public function again in DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318773 [22:14:15] 10MediaWiki-General-or-Unknown, 10Community-IdeaLab: Allow to apply protection to user pages, excepted for the concerned user - https://phabricator.wikimedia.org/T149484#2754549 (10Dereckson) >>! In T149484#2754254, @Funcrunch wrote: > The task to enable that to happen was split off into a separate task, T1494... [22:14:30] (03PS2) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 [22:18:58] 10MediaWiki-Configuration, 10Community-IdeaLab: Allow users to apply semi protection to only their user: pages - https://phabricator.wikimedia.org/T149501#2754553 (10Zppix) [22:20:03] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2752846 (10Zppix) Created subtask T149501 [22:20:28] (03CR) 10Florianschmidtwelzow: [C: 032] Make determineCoreSchema a public function again in DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318773 (owner: 10Paladox) [22:20:41] (03Merged) 10jenkins-bot: Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox" [core] (wmf/1.28.0-wmf.23) - 10https://gerrit.wikimedia.org/r/318772 (https://phabricator.wikimedia.org/T149473) (owner: 10Paladox) [22:24:09] 10MediaWiki-Configuration, 10Community-IdeaLab: Allow users to apply semi protection to only their user: pages - https://phabricator.wikimedia.org/T149501#2754571 (10Zppix) {V12} [22:27:16] 10MediaWiki-Page-editing, 10AbuseFilter, 13Patch-For-Review, 07Regression: Edit warnings have escaped HTML - https://phabricator.wikimedia.org/T149473#2754575 (10Reedy) p:05Unbreak!>03High [22:28:10] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2752846 (10Urbanecm) Maybe an edit filter can do this. [22:28:39] (03Merged) 10jenkins-bot: Make determineCoreSchema a public function again in DatabasePostgres [core] - 10https://gerrit.wikimedia.org/r/318773 (owner: 10Paladox) [22:29:15] (03CR) 10Paladox: "thankyou." [core] - 10https://gerrit.wikimedia.org/r/318773 (owner: 10Paladox) [22:29:38] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754579 (10Zppix) >>! In T149445#2754577, @Urbanecm wrote: > Maybe an edit filter can do this. @musikanimal i k... [22:30:35] 10ProveIt-Gadget, 13Patch-For-Review: Misinterpreting multiple templates within ref tag - https://phabricator.wikimedia.org/T148884#2754581 (10Arg342) Well, according to this link for [[ https://regex101.com/r/lF0fI1/1 | regex recursion]] referred to in the stackoverflow discussion, regex might still be the an... [22:33:57] 10ProveIt-Gadget, 13Patch-For-Review: Misinterpreting multiple templates within ref tag - https://phabricator.wikimedia.org/T148884#2735712 (10Zppix) Theres a problem in general not with the gadget itself it appears to also affect {{cite}} templates and/or reflist templates [22:35:00] 10ProveIt-Gadget, 13Patch-For-Review: Misinterpreting multiple templates within ref tag - https://phabricator.wikimedia.org/T148884#2754586 (10Zppix) If i may add this was reported from enwiki user in enwiki help irc (no logs due to disallowed public logging) [22:39:20] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754589 (10Urbanecm) The only problem will be the 5th point. [22:43:05] (03PS3) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 [22:45:15] (03PS4) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 [22:45:59] (03PS5) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 [22:46:18] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup, 05MW-1.27-release: HTTP 500 on logout for "SpecialUser"s due to incorrect file name capitalization - https://phabricator.wikimedia.org/T149182#2754590 (10Reedy) 05Resolved>03Invalid [22:50:58] (03CR) 10jenkins-bot: [V: 04-1] Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 (owner: 10Paladox) [22:54:17] (03PS6) 10Paladox: Test do not submit [core] - 10https://gerrit.wikimedia.org/r/318769 [22:58:29] 10UI-Standardization, 10OOjs-UI, 07Accessibility: ToggleButtonWidget inherits `aria-checked="true"` which is wrong - https://phabricator.wikimedia.org/T149502#2754593 (10Volker_E) [23:14:57] 10UI-Standardization, 10OOjs-UI, 07Accessibility, 03UI-Standardization-Kanban: MediaWiki theme: Fix (text) color instances which are not level AA yet and align them to color palette - https://phabricator.wikimedia.org/T149503#2754610 (10Volker_E) [23:15:55] 10ProveIt-Gadget, 13Patch-For-Review: Misinterpreting multiple templates within ref tag - https://phabricator.wikimedia.org/T148884#2754625 (10Iniquity) >>! In T148884#2754581, @Arg342 wrote: > It would be nice if you could specifically handle the dead link template, but I realize that it is probably specific... [23:28:53] 10Wikimedia-Site-requests, 07Community-consensus-needed: Enable default create/edit/move semi-protection for base userpages of registered users on enwiki - https://phabricator.wikimedia.org/T149445#2754626 (10MusikAnimal) Yes, we can do this with an edit filter quite easily, and that seems like best solution g... [23:31:10] 10MediaWiki-Configuration, 10Community-IdeaLab, 07Community-consensus-needed: Allow users to apply semi protection to only their user: pages - https://phabricator.wikimedia.org/T149501#2754627 (10MusikAnimal)