[00:00:02] (03PS2) 10Aaron Schulz: Remove long-since unused cruft methods from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311089 [00:00:12] hmm, local automatic merge worked [00:01:14] 10Wikimedia-Site-requests: unknown change in "autoreviewer " permission in Arwiki - https://phabricator.wikimedia.org/T145946#2645951 (10Ibrahim.ID) [00:01:42] (03CR) 10Aaron Schulz: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [00:02:58] legoktm: https://gerrit.wikimedia.org/r/#/c/311085/ ended up just being pure renames [00:03:28] (03CR) 10Legoktm: [C: 032] Move mysql database classes to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311085 (owner: 10Aaron Schulz) [00:04:37] (03CR) 10Legoktm: [C: 04-1] "Few things missed in the wiki => domain rename" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/311080 (owner: 10Aaron Schulz) [00:04:38] 10Graphs: [Vega Err] PARSE DATA FAILED: countries TypeError: t.objects is undefined - https://phabricator.wikimedia.org/T145945#2645963 (10saper) [00:05:59] (03PS3) 10Aaron Schulz: Avoid MWDebug/wfLogDBError usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 [00:09:58] 10MediaWiki-Database, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): 1.28-alpha with DBConnectionError: Cannot access the database: Unknown database ... - https://phabricator.wikimedia.org/T145840#2645964 (10mwjames) 05Open>03Resolved a:03mwjames Well, I got som... [00:10:30] (03PS4) 10Aaron Schulz: Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 [00:10:44] (03Merged) 10jenkins-bot: Move mysql database classes to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311085 (owner: 10Aaron Schulz) [00:13:25] (03CR) 10Legoktm: [C: 032] Rebuild for jessie-backports [debian] (jessie) - 10https://gerrit.wikimedia.org/r/308148 (owner: 10Legoktm) [00:15:08] (03CR) 10Mwjames: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [00:16:38] (03PS5) 10Aaron Schulz: Move LBFactoryMulti to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311080 [00:19:07] (03CR) 10Aaron Schulz: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [00:19:44] legoktm: updated the "wiki" mentions [00:20:50] (03PS3) 10Aaron Schulz: Remove long-since unused cruft methods from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311089 [00:28:56] (03PS4) 10Legoktm: Ensure users are able to edit the page after changing the content model [core] - 10https://gerrit.wikimedia.org/r/309815 (https://phabricator.wikimedia.org/T145316) [00:31:49] 06Project-Admins: Create MediaWiki-extensions-CookieWarning project - https://phabricator.wikimedia.org/T145651#2645970 (10Paladox) @Aklapper he has now ^^ [00:36:52] (03CR) 10Mwjames: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [00:36:57] (03CR) 10Aaron Schulz: [C: 04-1] Ensure users are able to edit the page after changing the content model (031 comment) [core] - 10https://gerrit.wikimedia.org/r/309815 (https://phabricator.wikimedia.org/T145316) (owner: 10Legoktm) [00:51:10] (03CR) 10Legoktm: [C: 032] Move LBFactoryMulti to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311080 (owner: 10Aaron Schulz) [00:54:36] (03CR) 10Aaron Schulz: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [00:55:01] legoktm: https://gerrit.wikimedia.org/r/#/c/311185/ fixes the last dependency afaik [00:57:02] (03Merged) 10jenkins-bot: Move LBFactoryMulti to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311080 (owner: 10Aaron Schulz) [00:58:07] 10Wiki-Loves-Monuments (2016): Postmortem on WLM-RU photos deleted from Commons - https://phabricator.wikimedia.org/T145872#2645971 (10Atsirlin) Hedwig, let me remind you that fair use entails the actual use of images in the main namespace. Blind transfer of unused images will violate this basic principle. It is... [00:59:04] 10MediaWiki-extensions-Quiz, 10MOOC-Interface, 10Possible-Tech-Projects, 10Outreachy (Round-13), 07Pywikibot-Wikidata: Python library for quiz data, with serialisation - https://phabricator.wikimedia.org/T89761#2645972 (10Jsalsman) Is this for GIFT or Twee ( http://www.maximumverbosity.net/twine/Entweedl... [01:04:47] (03CR) 10Mwjames: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [01:04:57] (03PS1) 10Aaron Schulz: Move LoadBalancerSingle to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311303 [01:05:43] (03CR) 10Aaron Schulz: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [01:09:22] 10MediaWiki-Database: TransactionProfiler to suppress violations on TEMPORARY TABLE operations - https://phabricator.wikimedia.org/T145947#2645973 (10mwjames) [01:10:33] (03CR) 10Mwjames: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [01:14:19] AaronSchulz: hm, breaks the debug toolbar. I'll debug [01:16:29] (03PS4) 10Aaron Schulz: Stub out DatabaseBase::getSearchEngine() as a dummy method [core] - 10https://gerrit.wikimedia.org/r/311082 [01:17:16] legoktm: trivial change in the meanwhile https://gerrit.wikimedia.org/r/#/c/311303/ [01:20:08] (03CR) 10Legoktm: [C: 032] Move LoadBalancerSingle to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311303 (owner: 10Aaron Schulz) [01:20:24] (03PS5) 10Legoktm: Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 (owner: 10Aaron Schulz) [01:23:05] (03PS4) 10Aaron Schulz: Make rebuildFileCache cover ?action=history [core] - 10https://gerrit.wikimedia.org/r/310697 [01:26:20] I should move more ServiceWiring code to applyDefaultConfig()...it's kind random what gets decided there vs LBFactoryMW [01:27:51] (03Merged) 10jenkins-bot: Move LoadBalancerSingle to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311303 (owner: 10Aaron Schulz) [01:28:25] 10MediaWiki-Configuration: Automatically capitalize usernames on the password reset form - https://phabricator.wikimedia.org/T145948#2645986 (10Music1201) [01:34:58] (03PS6) 10Legoktm: Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 (owner: 10Aaron Schulz) [01:35:26] 10MediaWiki-User-login-and-signup: Automatically capitalize usernames on the password reset form - https://phabricator.wikimedia.org/T145948#2645998 (10Legoktm) [01:35:38] AaronSchulz: how does ^ look? [01:39:30] (03CR) 10jenkins-bot: [V: 04-1] Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 (owner: 10Aaron Schulz) [01:45:15] legoktm: teh jenkins :) [01:45:56] hmm [01:50:20] (03PS7) 10Legoktm: Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 (owner: 10Aaron Schulz) [01:50:31] AaronSchulz: ^ is a little hacky [01:50:45] but it should work [01:50:59] the whole MWDebug integration in LegacyLogger is already hacky :S [01:51:18] (03PS1) 10Aaron Schulz: Cleanup ServiceWiring/LBFactoryMW interaction [core] - 10https://gerrit.wikimedia.org/r/311305 [01:51:21] legoktm: ^ tremendous cleanups [01:52:27] legoktm: why not check $effectiveChannel? [01:52:48] ohh, I see [01:53:40] queryLogger is used for more than just logging queries [01:55:07] right [01:55:11] legoktm: what about $commentedSql? [01:56:43] AaronSchulz: the debug toolbar already displays the function name in a separate column [01:57:25] (03CR) 10Aaron Schulz: [C: 032] Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 (owner: 10Aaron Schulz) [01:57:36] right, and the user knows who the agent is already [01:57:44] I was thinking of general profiling [01:58:37] legoktm: https://github.com/wikimedia/mediawiki/blob/master/includes/libs/rdbms/lbfactory/LBFactorySingle.php haha, wrong file name [01:58:47] I'll move that proper [01:58:56] oops [02:00:15] (03PS1) 10Aaron Schulz: Fix file/class name mismatch from e2adcc89bbe [core] - 10https://gerrit.wikimedia.org/r/311307 [02:00:18] it all sounds the same :) [02:00:35] (03CR) 10Legoktm: [C: 032] Fix file/class name mismatch from e2adcc89bbe [core] - 10https://gerrit.wikimedia.org/r/311307 (owner: 10Aaron Schulz) [02:00:53] we should have a basename() and classname() non-voting test [02:01:21] one class per file and matching name...though that will be mildly annoying for "list-o-exception" class files [02:02:03] I wonder if LBFactorySingle should go in /libs [02:02:08] it's slightly hacky though [02:02:22] (03CR) 10Gergő Tisza: [C: 032] Remove long-since unused cruft methods from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311089 (owner: 10Aaron Schulz) [02:02:56] * AaronSchulz also has tremendous plans for FileBackend [02:03:41] (03Merged) 10jenkins-bot: Avoid MWDebug usage in DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311185 (owner: 10Aaron Schulz) [02:05:08] (03PS2) 10Aaron Schulz: Avoid using cascadingDeletes()/cleanupTriggers() [core] - 10https://gerrit.wikimedia.org/r/311090 [02:09:12] (03Merged) 10jenkins-bot: Fix file/class name mismatch from e2adcc89bbe [core] - 10https://gerrit.wikimedia.org/r/311307 (owner: 10Aaron Schulz) [02:12:52] (03Merged) 10jenkins-bot: Remove long-since unused cruft methods from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/311089 (owner: 10Aaron Schulz) [02:13:42] (03PS1) 10Aaron Schulz: Move LBFactorySingle to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311308 [02:13:43] 10MediaWiki-extensions-SemanticForms, 07Accessibility: Form inputs should use HTML