[00:00:16] 10MediaWiki-Special-pages, 06Community-Tech, 07IPv6: Add IP range support to Special:Contributions - https://phabricator.wikimedia.org/T145912#2645083 (10MusikAnimal) [00:00:43] 06Discovery, 06Discovery-Search (Current work): Search Results page: re-design page display of search results across languages - https://phabricator.wikimedia.org/T139310#2645085 (10debt) I've added two new epic tickets to track the work we'll be doing on this: T145918 for backend work and T145917 for front en... [00:00:56] 06Discovery, 06Discovery-Search (Current work): Search Results page: re-design page display of search results across languages - https://phabricator.wikimedia.org/T139310#2645088 (10debt) a:03debt [00:05:09] (03PS5) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [00:09:03] (03CR) 10jenkins-bot: [V: 04-1] Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [00:13:10] 10TPG-Essential-Functions, 06Team-Practices (This-Week): Create a "How to plan an offsite" or "Offsite best practices" wiki page - https://phabricator.wikimedia.org/T138777#2645094 (10Rfarrand) [00:13:12] 06Developer-Relations (Jul-Sep-2016): How to run an team Offsite page on office.wiki - https://phabricator.wikimedia.org/T114970#2645096 (10Rfarrand) [00:18:07] (03PS6) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [00:22:06] (03CR) 10jenkins-bot: [V: 04-1] Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [00:34:46] (03PS6) 10Mooeypoo: [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 [00:38:23] (03PS1) 10Aaron Schulz: Fix type doc in StatusValue [core] - 10https://gerrit.wikimedia.org/r/311204 [00:39:40] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add proper QUnit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/311063 (owner: 10Mooeypoo) [00:39:48] 06Wikipedia-Android-App-Backlog: [BUG] [API 16] Log in / out and settings overflow not available when search icon shown - https://phabricator.wikimedia.org/T145911#2644828 (10bearND) @Niedzielski The title says API 16 but then the details say API 23. I guess the former is correct. Maybe the API level doesn't eve... [00:44:04] (03CR) 10Gergő Tisza: "I don't think it's a good idea to add hooks whose sole reason is to support code which tries to do its own authentication. Everything that" [core] - 10https://gerrit.wikimedia.org/r/311146 (https://phabricator.wikimedia.org/T110464) (owner: 10Cicalese) [00:47:50] (03CR) 10Gergő Tisza: Update for MW 1.27 (036 comments) [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/299107 (https://phabricator.wikimedia.org/T110464) (owner: 10Cicalese) [00:49:04] 06Security-Team: Ability to alert when we get a sudden increase in bad passwords for privileged accounts, to possibly detect password brute-forcing - https://phabricator.wikimedia.org/T123243#1924467 (10Tgr) See also {T140942}. [00:54:00] 07Design, 10MobileFrontend, 06Reading-Web-Backlog: Mobile Media Viewer violates user settings - https://phabricator.wikimedia.org/T144571#2645116 (10Alsee) I just did some casual testing, loading the mobile site (en.m.wikipedia.org) using desktop, with preference Media Viewer off. Clicking images give unpred... [01:30:42] (03PS3) 10Zppix: Add Localisation to the links, add the link to Localisation in Languages/Language.php [core] - 10https://gerrit.wikimedia.org/r/304153 [01:33:38] (03PS4) 10Zppix: Add Localisation to the links, add the link to Localisation in Languages/Language.php [core] - 10https://gerrit.wikimedia.org/r/304153 [01:48:17] (03CR) 10Gergő Tisza: [C: 031] "IMO that looks good enough. You are probably better of following the recommendation of Bartosz but I'm fine with merging the current versi" [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [01:49:39] (03PS7) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [01:50:02] tgr|away: are you actually away? [01:50:22] no [01:50:30] just had to reboot [01:51:27] tgr: I have https://gerrit.wikimedia.org/r/#/c/311169/ and other tiny commits [01:51:40] everone seems to be on CR break today ;) [01:51:43] looking [01:54:03] (03PS2) 10Aaron Schulz: Cleanup setDomainPrefix() methods to handle existing LBs/DBs [core] - 10https://gerrit.wikimedia.org/r/311170 [01:57:22] (03PS3) 10Aaron Schulz: Make LoadBalancer domain handling more robust [core] - 10https://gerrit.wikimedia.org/r/311097 (https://phabricator.wikimedia.org/T145840) [02:00:25] (03PS2) 10Aaron Schulz: Rename domain => localDomain in LBFactory for consistency [core] - 10https://gerrit.wikimedia.org/r/311169 [02:00:28] (03PS4) 10Aaron Schulz: Make LoadBalancer domain handling more robust [core] - 10https://gerrit.wikimedia.org/r/311097 (https://phabricator.wikimedia.org/T145840) [02:00:45] (03Abandoned) 10Aaron Schulz: Cleanup setDomainPrefix() methods to handle existing LBs/DBs [core] - 10https://gerrit.wikimedia.org/r/311170 (owner: 10Aaron Schulz) [02:07:59] * AaronSchulz wonders if tgr wandered off :) [02:08:30] got distracted by looking at your Status patch [02:09:19] tgr: heh, cr that too if you want [02:10:39] next step will be to make warnings on GUI methods of status used when wrap() was not called at least once (via a tracking var) [02:11:45] then more stuff could start return raw StatusValue instead of using injected wrapper callbacks [02:16:51] is there some kind of CI upgrade going on? gerrit seems to be in readonly mode [02:17:42] ah, I'm looking at an old version of the patch [02:18:03] that was one of the less fortunate interface changes [02:18:15] (03CR) 10Gergő Tisza: [C: 032] Rename domain => localDomain in LBFactory for consistency [core] - 10https://gerrit.wikimedia.org/r/311169 (owner: 10Aaron Schulz) [02:23:32] tgr: https://gerrit.wikimedia.org/r/#/c/311097/4 fixes some bugs [02:24:57] (03Merged) 10jenkins-bot: Rename domain => localDomain in LBFactory for consistency [core] - 10https://gerrit.wikimedia.org/r/311169 (owner: 10Aaron Schulz) [02:30:37] (03CR) 10Gergő Tisza: [C: 032] Make LoadBalancer domain handling more robust [core] - 10https://gerrit.wikimedia.org/r/311097 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [02:31:16] (03PS5) 10Aaron Schulz: Make LoadBalancer domain handling more robust [core] - 10https://gerrit.wikimedia.org/r/311097 (https://phabricator.wikimedia.org/T145840) [02:31:57] (03CR) 10Aaron Schulz: [C: 032] Make LoadBalancer domain handling more robust [core] - 10https://gerrit.wikimedia.org/r/311097 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [02:33:07] tgr: https://gerrit.wikimedia.org/r/#/c/311204/1 tiny doc fix [02:33:08] heh, I was wondering about that (.) [02:33:34] decided it must be some convention for saying "arguments have been omitted here" [02:34:31] (03CR) 10Gergő Tisza: [C: 032] Fix type doc in StatusValue [core] - 10https://gerrit.wikimedia.org/r/311204 (owner: 10Aaron Schulz) [02:36:34] ooo, explode() takes negatives $limit too [02:36:39] * AaronSchulz will make use of that [02:38:49] (03Merged) 10jenkins-bot: Make LoadBalancer domain handling more robust [core] - 10https://gerrit.wikimedia.org/r/311097 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [02:39:09] (03PS5) 10Aaron Schulz: Move all of the reasonable DatabaseBase methods to Database class [core] - 10https://gerrit.wikimedia.org/r/311083 [02:39:22] tgr: https://gerrit.wikimedia.org/r/#/c/311083/ is mostly just moving code to another file [02:39:29] (03CR) 10jenkins-bot: [V: 04-1] Move all of the reasonable DatabaseBase methods to Database class [core] - 10https://gerrit.wikimedia.org/r/311083 (owner: 10Aaron Schulz) [02:41:14] merge conflict [02:41:15] (03Merged) 10jenkins-bot: Fix type doc in StatusValue [core] - 10https://gerrit.wikimedia.org/r/311204 (owner: 10Aaron Schulz) [02:52:03] (03PS6) 10Aaron Schulz: Move all of the reasonable DatabaseBase methods to Database class [core] - 10https://gerrit.wikimedia.org/r/311083 [03:01:31] AaronSchulz: is that whole tower ready to merge? [03:01:52] tgr: all of the patches are yeah [03:01:57] those some will merge conflict [03:02:22] k, gotta leave now but will look at them [03:06:15] 10Phabricator, 06Operations: networking: allow ssh between iridium and phab2001 - https://phabricator.wikimedia.org/T143363#2645176 (10mmodell) [03:11:23] 10Phabricator, 06Operations: networking: allow ssh between iridium and phab2001 - https://phabricator.wikimedia.org/T143363#2645178 (10mmodell) ssh from iridium to phab2001 still isn't working.. :( [03:15:35] (03PS1) 10Aaron Schulz: Avoid using bogus empty database names in queries [core] - 10https://gerrit.wikimedia.org/r/311208 [03:15:49] tgr: https://gerrit.wikimedia.org/r/311208 one stupid fix before you go [03:18:18] (03Abandoned) 10Aaron Schulz: Avoid using bogus empty database names in queries [core] - 10https://gerrit.wikimedia.org/r/311208 (owner: 10Aaron Schulz) [03:19:12] tgr: nevermind, false alarm, that was some other thing I was testing [03:21:56] (03CR) 10Gergő Tisza: Make Status extend StatusValue and start FileBackend update (037 comments) [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [03:28:16] 10MediaWiki-Revision-deletion, 06Labs: Need to access revision histories of wikipedia pages - https://phabricator.wikimedia.org/T122035#1894323 (10AlexMonk-WMF) @aklapper, any idea what to do with this? and what is the subtask? [03:30:07] 10Phabricator, 06Operations: networking: allow ssh between iridium and phab2001 - https://phabricator.wikimedia.org/T143363#2645192 (10mmodell) a:05mmodell>03None ok from phab2001 I can ssh to `10.64.32.186` but not to `10.64.32.150` and `host iridium.eqiad.wmnet` resolves to: ``` iridium.eqiad.wmnet has... [03:31:12] (03CR) 10Cicalese: "Gergő, thank you very much for your review. I appreciate your offer of assistance and will gladly accept. I have been trying to figure out" [core] - 10https://gerrit.wikimedia.org/r/311146 (https://phabricator.wikimedia.org/T110464) (owner: 10Cicalese) [03:35:54] (03PS8) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [03:36:08] tgr|away: updated [03:38:06] (03PS7) 10Aaron Schulz: Move all of the reasonable DatabaseBase methods to Database class [core] - 10https://gerrit.wikimedia.org/r/311083 [03:42:55] 10Wiki-Loves-Monuments (2016): Reach out - https://phabricator.wikimedia.org/T142945#2645205 (10LilyOfTheWest) [03:43:10] (03CR) 10Jackmcbarn: [C: 04-1] "Please don't do that. If you want to pick up my patch, use my Change-Id, and it will get added to that one automatically. With what you di" [core] - 10https://gerrit.wikimedia.org/r/310181 (https://phabricator.wikimedia.org/T27319) (owner: 10Huji) [04:05:45] (03CR) 10Smalyshev: [C: 032] PrefixSearch: Implement searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/141660 (https://phabricator.wikimedia.org/T67752) (owner: 10Nikerabbit) [04:08:43] 10MediaWiki-Parser: Stop adding xml:lang attributes to HTML5 pages - https://phabricator.wikimedia.org/T46609#512937 (10Izno) >>! In T46609#1202301, @TheDJ wrote: > Not sure when this got fixed, but our pages no longer emit xml:lang in html5 mode anymore. @TheDJ, there's at least one report at [[https://en.wiki... [04:09:34] 10Possible-Tech-Projects: Create tool to generate, track and show metrics for Tech News - https://phabricator.wikimedia.org/T91335#2645211 (10Sumit) >>! In T91335#2643676, @Tanmaysharma024 wrote: > Hey all. I want to know that is this project going to have a mentor? I really wish to contribute, for it will help... [04:13:15] (03Merged) 10jenkins-bot: PrefixSearch: Implement searching in multiple namespaces [core] - 10https://gerrit.wikimedia.org/r/141660 (https://phabricator.wikimedia.org/T67752) (owner: 10Nikerabbit) [04:17:18] 04(no projects): Add '*wmflabs.org' to the Content Security Policy of Slimapp - https://phabricator.wikimedia.org/T145921#2645218 (10Samwilson) [04:29:35] 04(no projects): Add '*wmflabs.org' to the Content Security Policy of Slimapp - https://phabricator.wikimedia.org/T145921#2645218 (10AlexMonk-WMF) Trusting the whole of labs is terrible for security. Is this for something running on a wikimedia.org domain? If so I doubt you'll be able to trust any of labs really. [04:42:36] 10MediaWiki-Special-pages, 03Community-Tech-Sprint, 07Community-Wishlist-Survey, 05MW-1.28-release-notes, and 2 others: Improve date range searches on Special:Contributions - https://phabricator.wikimedia.org/T120733#2645249 (10Sn1per) >>! In T120733#2642679, @Samwilson wrote: > @Sn1per, what's your status... [04:46:55] (03PS3) 10Aaron Schulz: Stub out DatabaseBase::getSearchEngine() as a dummy method [core] - 10https://gerrit.wikimedia.org/r/311082 [04:54:20] 04(no projects): Add '*wmflabs.org' to the Content Security Policy of Slimapp - https://phabricator.wikimedia.org/T145921#2645252 (10Samwilson) Hm, good point! Okay, how about changing it to `tools-static.wmflabs.org/cdnjs` ? This is a framework for building tools with, so pretty much all of them I'd imagine w... [05:00:52] 05Security: Add '*wmflabs.org' to the Content Security Policy of Slimapp - https://phabricator.wikimedia.org/T145921#2645258 (10AlexMonk-WMF) [05:19:40] 05Security: Add '*wmflabs.org' to the Content Security Policy of Slimapp - https://phabricator.wikimedia.org/T145921#2645259 (10Niharika) Poking @bd808 to look into this when he's back to work. Since Slimapp it's primarily his app, he should decide the fate of this task. Aside, @Samwilson It is not encouraged... [05:23:30] 05Security: Add '*wmflabs.org' to the Content Security Policy of Slimapp - https://phabricator.wikimedia.org/T145921#2645260 (10Niharika) >>! In T145921#2645252, @Samwilson wrote: > For example, CopyPatrol is currently [[ https://github.com/wikimedia/CopyPatrol/blob/be9662405037ce2d86061df19200a5e7ec05f44f/src/A... [05:29:36] 06Brickimedia: Editing on GBCW doesn't save - https://phabricator.wikimedia.org/T144657#2645264 (10SamanthaNguyen) For the time being, I'll mark this issue as invalid since it seems like submitting edit is possible on GBCW [05:29:51] 06Brickimedia: Editing on GBCW doesn't save - https://phabricator.wikimedia.org/T144657#2645265 (10SamanthaNguyen) 05Open>03Invalid [05:32:24] AaronSchulz: I was afk all of today but I can review stuff if you're still around [05:32:35] I'm up [05:33:00] * AaronSchulz was looking at T145840, which deals with long standing dash bugs [05:33:30] 10Commons-App-Android-Upload: {{Location|null}} in uploads of Android-App - https://phabricator.wikimedia.org/T145355#2645278 (10Aschroet) @josephine_l, for me this looks good. However, it was just a guess what i described. I did not reproduce this behavior on my phone. So it is up to you to decide if this fix i... [05:33:42] legoktm: https://gerrit.wikimedia.org/r/#/c/311083/ [05:39:13] (03CR) 10Legoktm: [C: 032] Move all of the reasonable DatabaseBase methods to Database class [core] - 10https://gerrit.wikimedia.org/r/311083 (owner: 10Aaron Schulz) [05:48:27] (03Merged) 10jenkins-bot: Move all of the reasonable DatabaseBase methods to Database class [core] - 10https://gerrit.wikimedia.org/r/311083 (owner: 10Aaron Schulz) [05:54:07] 10Commons-App-Android-Upload: {{Location|null}} in uploads of Android-App - https://phabricator.wikimedia.org/T145355#2645280 (10josephine_l) I will have to release a hotfix for another bug anyway, so no harm putting this in v1.31 and seeing how it goes. Do let me know. :) [05:59:34] 10MediaWiki-Database, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): 1.28-alpha with DBConnectionError: Cannot access the database: Unknown database ... - https://phabricator.wikimedia.org/T145840#2645281 (10Legoktm) [06:00:48] (03PS2) 10Aaron Schulz: Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 [06:00:54] (03CR) 10Aaron Schulz: [C: 032] Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [06:01:18] (03CR) 10jenkins-bot: [V: 04-1] Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [06:01:22] (03PS5) 10Aaron Schulz: Cleanups to DatabaseMysqlBase [core] - 10https://gerrit.wikimedia.org/r/311084 [06:01:42] legoktm: https://gerrit.wikimedia.org/r/#/c/311084/ [06:09:07] (03CR) 10Legoktm: [C: 032] Cleanups to DatabaseMysqlBase [core] - 10https://gerrit.wikimedia.org/r/311084 (owner: 10Aaron Schulz) [06:11:01] AaronSchulz: do you think you could look at https://gerrit.wikimedia.org/r/#/c/306873/ and https://gerrit.wikimedia.org/r/#/c/310242/ ? [06:11:30] right after fix this dash bug [06:13:25] ok :) [06:16:26] (03Merged) 10jenkins-bot: Cleanups to DatabaseMysqlBase [core] - 10https://gerrit.wikimedia.org/r/311084 (owner: 10Aaron Schulz) [06:22:57] 04(no projects): Need to reduce nsPage body edit box in horizontal view - https://phabricator.wikimedia.org/T145923#2645292 (10Alex_brollo) [06:23:33] 04(no projects): Need to reduce nsPage body edit box height in horizontal view - https://phabricator.wikimedia.org/T145923#2645303 (10Alex_brollo) [06:25:05] 04(no projects): Need to reduce nsPage body edit box height in horizontal view - https://phabricator.wikimedia.org/T145923#2645292 (10Alex_brollo) [06:36:18] (03PS1) 10Legoktm: Avoid wfMessage() [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/311213 [06:37:33] (03CR) 10jenkins-bot: [V: 04-1] Avoid wfMessage() [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/311213 (owner: 10Legoktm) [07:04:42] (03PS1) 10Legoktm: Avoid wfMessage() in AbuseFilter::buildVarDumpTable() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/311214 [07:12:39] (03PS4) 10Legoktm: Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [07:13:42] (03CR) 10Legoktm: [C: 032] Drop calls to WikiPage->getText (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [07:14:27] 10TimedMediaHandler, 13Patch-For-Review: Support 720p in ogv - https://phabricator.wikimedia.org/T108172#2645321 (10brion) 05Open>03Resolved this merged a while ago [07:14:54] (03Merged) 10jenkins-bot: Drop calls to WikiPage->getText [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/310874 (https://phabricator.wikimedia.org/T145751) (owner: 10Mattflaschen) [07:17:17] 10TimedMediaHandler-Player: WebM VP9 source videos are played back with higher priority than the VP8 transcodes - https://phabricator.wikimedia.org/T145925#2645324 (10brion) [07:17:33] 10MediaWiki-ContentHandler, 07Technical-Debt: WikiPage::getText() is deprecated - https://phabricator.wikimedia.org/T145750#2645337 (10Legoktm) [07:17:35] 10MediaWiki-extensions-PageCuration, 06Collaboration-Team-Triage, 13Patch-For-Review, 07Technical-Debt: PageTriage should not call WikiPage::getText() - https://phabricator.wikimedia.org/T145751#2645336 (10Legoktm) 05Open>03Resolved [07:26:20] 10MediaWiki-extensions-General-or-Unknown, 10Revision-Slider, 06TCB-Team, 13Patch-For-Review, and 5 others: Revision slider disconnects wikEdDiff - https://phabricator.wikimedia.org/T143199#2645345 (10Addshore) The deployment date might have altered slightly, but we will not know until next week. I'll try... [07:28:30] (03PS2) 10Legoktm: Avoid wfMessage() in AbuseFilter::buildVarDumpTable() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/311214 [07:30:28] 10ProofreadPage: Need to reduce nsPage body edit box height in horizontal view - https://phabricator.wikimedia.org/T145923#2645346 (10Peachey88) [07:33:39] (03PS3) 10Aaron Schulz: Move mysql database classes to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311085 [07:36:06] 10MediaWiki-General-or-Unknown, 06Discovery-Search, 07I18n: [[MediaWiki:Search-interwiki-results-acewiki/fi]] i18n issue - https://phabricator.wikimedia.org/T145926#2645350 (10Nikerabbit) [07:39:27] (03CR) 10Hoo man: [C: 032] Avoid wfMessage() in AbuseFilter::buildVarDumpTable() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/311214 (owner: 10Legoktm) [07:45:20] (03Merged) 10jenkins-bot: Avoid wfMessage() in AbuseFilter::buildVarDumpTable() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/311214 (owner: 10Legoktm) [07:51:40] https://usercontent.irccloud-cdn.com/file/SjXEEW8p/ [07:52:00] I am currently working in kubuntu and the terminal available is slightly of a different version. I have been trying to execute $ eval `ssh-agent` from yesterday and the message subsequently shown is "command not found". I am not able to configure where I am going wrong. [07:53:33] 10MediaWiki-General-or-Unknown, 06Discovery-Search, 07I18n: [[MediaWiki:Project-localized-name-bhwiki/fi]] i18n issue - https://phabricator.wikimedia.org/T145927#2645364 (10Nikerabbit) [08:08:02] (03PS1) 10Ladsgroup: DB_SLAVE -> DB_REPLICA [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311221 [08:14:59] (03CR) 10Nikerabbit: "What do you mean no longer needed?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/304612 (owner: 10Reedy) [08:17:27] (03PS1) 10Aaron Schulz: Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) [08:20:25] (03PS3) 10Fomafix: OutputPage: Use getPageViewLanguage for Content-language [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [08:21:33] (03CR) 10Fomafix: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [08:21:35] 10ProofreadPage: Need to reduce nsPage body edit box height in horizontal view - https://phabricator.wikimedia.org/T145923#2645380 (10Alex_brollo) [08:21:36] (03CR) 10jenkins-bot: [V: 04-1] Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [08:36:47] (03PS3) 10Aaron Schulz: Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 [08:40:42] (03CR) 10jenkins-bot: [V: 04-1] Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [08:49:23] 10MediaWiki-Internationalization, 10Wikimedia-Site-requests, 05MW-1.28-release-notes, 13Patch-For-Review, and 2 others: Change file namespace name in Urdu - https://phabricator.wikimedia.org/T144437#2645383 (10MuhammadShuaib) 2 days ago these changes implemented on urwiki and worked as expected. But after... [08:49:45] 10MediaWiki-Database, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): 1.28-alpha with DBConnectionError: Cannot access the database: Unknown database ... - https://phabricator.wikimedia.org/T145840#2645384 (10mwjames) To give you a quick feedback by running against [0]... [08:50:52] 10MediaWiki-Parser, 07Tracking: HTML validity (tracking) - https://phabricator.wikimedia.org/T2209#2645389 (10Redrose64) [08:50:54] 10MediaWiki-Parser: Stop adding xml:lang attributes to HTML5 pages - https://phabricator.wikimedia.org/T46609#2645387 (10Redrose64) 05Resolved>03Open Yes, I tested it recently, and it's happening when the `lang=` attribute is used on both `span` and `div` elements, so I assume that all other elements are als... [08:51:51] 10ProofreadPage: Need to reduce nsPage body edit box height in horizontal view - https://phabricator.wikimedia.org/T145923#2645292 (10AuFCL) @Alex_brollo Presumably you are aware that the default height is set (for both horizontal and vertical layouts) in Preference setting [[Special:Preferences#mw-input-wprows]... [09:08:17] (03CR) 10Aaron Schulz: [C: 032] DB_SLAVE -> DB_REPLICA [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311221 (owner: 10Ladsgroup) [09:09:30] (03Merged) 10jenkins-bot: DB_SLAVE -> DB_REPLICA [extensions/ORES] - 10https://gerrit.wikimedia.org/r/311221 (owner: 10Ladsgroup) [09:44:09] 10ProofreadPage: Need to reduce nsPage body edit box height in horizontal view - https://phabricator.wikimedia.org/T145923#2645412 (10Alex_brollo) Yes, two independent settings would be a great solution IMHO. In the meantime, I'm using a patch: [[ https://meta.wikimedia.org/wiki/User:Alex_brollo/global.js | my g... [09:48:23] (03CR) 10MarcoAurelio: [C: 032] Changing Submit Type from fast-forward only to merge if necessary. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/310525 (owner: 10Jdrewniak) [09:54:34] (03Merged) 10jenkins-bot: Changing Submit Type from fast-forward only to merge if necessary. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/310525 (owner: 10Jdrewniak) [10:02:04] (03CR) 10MarcoAurelio: "> This new wiki group could be merged with a generic tech admin group" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/308449 (https://phabricator.wikimedia.org/T144599) (owner: 10MarcoAurelio) [10:03:54] (03PS7) 10MarcoAurelio: Creating {{int:hello}} and {{int:thank-you}} messages for WMF sites [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/302197 (https://phabricator.wikimedia.org/T137127) [10:05:17] 10MediaWiki-Internationalization, 07I18n, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Language fallback for Lzh (Zh-classical) should be Zh_hant - https://phabricator.wikimedia.org/T125373#2645443 (10MarcoAurelio) 05Open>03Resolved Patch is merged. I'll be li... [10:06:07] 10MediaWiki-Internationalization, 07I18n, 05MW-1.28-release-notes, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Language fallback for Lzh (Zh-classical) should be Zh_hant - https://phabricator.wikimedia.org/T125373#2645445 (10MarcoAurelio) [10:07:45] 10Wikimedia-Site-requests, 13Patch-For-Review: Enable ExtraSignatureNamespaces for all namespaces for dewiki - https://phabricator.wikimedia.org/T145619#2645446 (10MarcoAurelio) >>! In T145619#2643922, @Jdforrester-WMF wrote: > This is exactly the reason I was worried about creating this configuration option... [10:11:25] 10Wikimedia-Site-requests, 13Patch-For-Review: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2645447 (10MarcoAurelio) a:03MarcoAurelio Since I worked on the patches. [10:26:10] (03PS1) 10Hoo man: Content handler demo [extensions/MOOC] - 10https://gerrit.wikimedia.org/r/311227 [10:26:25] 10Phabricator (Upstream), 07Upstream: Allow pastes to be deleted or to expire - https://phabricator.wikimedia.org/T145752#2645458 (10MarcoAurelio) Note that Phabricator admins seems to be able to delete users (at least there's "delete user" button in the user profile), which I think it'd be rather more radical... [10:29:18] (03Abandoned) 10Hoo man: Content handler demo [extensions/MOOC] - 10https://gerrit.wikimedia.org/r/311227 (owner: 10Hoo man) [10:30:03] 10Wikimedia-Site-requests, 13Patch-For-Review: Allow bureaucrats instead of sysops to add/remove users to/from interface editor group on ur.wikipedia - https://phabricator.wikimedia.org/T133564#2235938 (10MarcoAurelio) I agree with this. Editting the MediaWiki interface is a sensitive permission and on cases w... [10:32:47] 10Phabricator (Upstream), 07Upstream: Allow pastes to be deleted or to expire - https://phabricator.wikimedia.org/T145752#2639782 (10Peachey88) >>! In T145752#2642977, @MarcoAurelio wrote: > * **Phabricator admins** should be able to delete pastes easily without messing in the Phabricator database. IIRC, it's... [10:36:19] 10Wikimedia-Site-requests: AbuseFilter permissions spread all over InitialiseSettings and abusefilter.php: they should be in one place - https://phabricator.wikimedia.org/T145931#2645479 (10MarcoAurelio) [10:36:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07RfC: [RFC] Create a "number" datatype for exact values - https://phabricator.wikimedia.org/T112247#2645491 (10Esc3300) [10:36:54] 10Wikimedia-Site-requests: AbuseFilter permissions spread all over InitialiseSettings and abusefilter.php: they should be in one place - https://phabricator.wikimedia.org/T145931#2645492 (10MarcoAurelio) [11:06:20] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 13Patch-For-Review, 07Story, and 2 others: [Story] Cleanup after refactoring Add-/Remove-Toolbar - https://phabricator.wikimedia.org/T142695#2645499 (10Jonas) [11:06:31] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 13Patch-For-Review, 07Story, and 2 others: [Story] Cleanup after refactoring Add-/Remove-Toolbar - https://phabricator.wikimedia.org/T142695#2543368 (10Jonas) 05Open>03Resolved [11:09:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Special:NewItem does not validate maximum label length - https://phabricator.wikimedia.org/T145932#2645502 (10thiemowmde) [12:22:54] 10Editing-UX-Research: Misc (Discovery) review cross-wiki search result improvements docs - https://phabricator.wikimedia.org/T145029#2645527 (10Aklapper) For those interested, where could those "cross-wiki search result improvements docs" be found? [12:23:17] 10Editing-UX-Research: Misc (Discovery) review cross-wiki search result improvements docs - https://phabricator.wikimedia.org/T145029#2645529 (10Aklapper) Is this task related to / does it block T145918 maybe? [12:23:39] 06Discovery, 06Discovery-Search (Current work), 07Epic: [EPIC] Backend: cross-wiki search results functionality - https://phabricator.wikimedia.org/T145918#2645057 (10Aklapper) Duplicate of T109957 ? (And if not, how are these two tasks related?) [12:35:09] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 15User-Ladsgroup: Embed machine readable ores scores as data on pages where ORES scores things - https://phabricator.wikimedia.org/T143611#2645542 (10Ladsgroup) Okay, I looked into this. It seems hooks are not good enough to add attributes to rows... [12:36:19] 10Phabricator (Upstream), 07Upstream: Cannot horizontal scroll in Task-Graph, overflow is clipped - https://phabricator.wikimedia.org/T145806#2645543 (10Aklapper) >>! In T145806#2642596, @mmodell wrote: > I can't reproduce the issue in Firefox or Chromium on my machine. I guess it's only an issue in older vers... [12:42:43] 04(no projects): gilaki wikipedia infobox show - https://phabricator.wikimedia.org/T145350#2645546 (10Aklapper) >>! In T145350#2642682, @Mogoeilor wrote: > they do that edites you say but that problem is exists. No, they did not do any edits. See https://glk.wikipedia.org/w/index.php?title=%D9%85%D8%AF%D9%8A%... [12:48:26] 10BetaFeatures: add switch of censorship(like a blood, gore, sexual etc) - https://phabricator.wikimedia.org/T145864#2645548 (10Aklapper) 05Open>03declined There is nothing to implement technically as long as communities do not want such filtering. Also see https://en.wikipedia.org/wiki/Wikipedia:What_Wikip... [12:48:46] 10MediaWiki-extension-requests: Add switch to filter certain content (like a blood, gore, sexual etc) - https://phabricator.wikimedia.org/T145864#2645550 (10Aklapper) [12:52:15] 10Wikimedia-General-or-Unknown, 07I18n, 07RTL: Using IPad, Arabic text looks disjoint on Egyptian Arabic (arz) Wikipedia - https://phabricator.wikimedia.org/T135333#2645552 (10Aklapper) 05Open>03stalled Which exact fonts are used by the browser on the affected system? I don't see yet how this is a proble... [13:08:33] 10MediaWiki-Email, 10MediaWiki-Logging, 10MediaWiki-Watchlist: Link log watchlist emails to logger and not just to user page - https://phabricator.wikimedia.org/T145933#2645557 (10IKhitron) [13:14:42] (03CR) 10Jack Phoenix: [C: 031] "Looks good to me (although I didn't test it out)." [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310562 (https://phabricator.wikimedia.org/T145647) (owner: 10Florianschmidtwelzow) [13:14:59] (03CR) 10Jack Phoenix: [C: 031] "Awesome! :)" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311033 (https://phabricator.wikimedia.org/T145781) (owner: 10Florianschmidtwelzow) [13:19:14] (03CR) 10Jack Phoenix: [C: 031] "I recognize some of those sarcastic comments in the JS file. :P" (033 comments) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) (owner: 10Florianschmidtwelzow) [13:22:11] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 05MW-1.28-release-notes, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): PrefixSearch: Add support for multiple namespaces - https://phabricator.wikimedia.org/T32323#2645569 (10Nikerabbit) [13:23:00] 10MediaWiki-Interface: mediawiki.searchSuggest: Support user search namespace preferences - https://phabricator.wikimedia.org/T26214#2645573 (10Nikerabbit) [13:23:02] 10MediaWiki-Search, 06Discovery, 06Discovery-Search, 05MW-1.28-release-notes, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): PrefixSearch: Add support for multiple namespaces - https://phabricator.wikimedia.org/T32323#343277 (10Nikerabbit) 05Open>03Resolved [13:23:54] 10MediaWiki-Search: ApiOpensearch unable to search for pages in namespace starting with lower case letter - https://phabricator.wikimedia.org/T67752#2645576 (10Nikerabbit) [13:27:45] (03Abandoned) 10Paladox: Update zordius/lightncandy to 0.90 [core] - 10https://gerrit.wikimedia.org/r/296238 (owner: 10Paladox) [13:32:50] 10FileAnnotations (BetaFeature): FileAnnotations messes up the "Other resolutions" links on file page - https://phabricator.wikimedia.org/T144996#2645586 (10matmarex) 05Open>03Resolved a:03MarkTraceur [13:42:16] (03PS10) 10Cenarium: Bulk revision deletion and tag editing from contributions [core] - 10https://gerrit.wikimedia.org/r/210675 (https://phabricator.wikimedia.org/T28230) [13:46:14] (03CR) 10jenkins-bot: [V: 04-1] Bulk revision deletion and tag editing from contributions [core] - 10https://gerrit.wikimedia.org/r/210675 (https://phabricator.wikimedia.org/T28230) (owner: 10Cenarium) [13:54:46] (03PS11) 10Cenarium: Bulk revision deletion and tag editing from contributions [core] - 10https://gerrit.wikimedia.org/r/210675 (https://phabricator.wikimedia.org/T28230) [14:07:22] (03PS7) 10Bartosz Dziewoński: Rework UserContribs options section [core] - 10https://gerrit.wikimedia.org/r/307077 (https://phabricator.wikimedia.org/T143518) (owner: 10Ladsgroup) [14:07:37] (03CR) 10Bartosz Dziewoński: "PS7 also removes the
." [core] - 10https://gerrit.wikimedia.org/r/307077 (https://phabricator.wikimedia.org/T143518) (owner: 10Ladsgroup) [14:09:15] (03PS8) 10Ladsgroup: Rework UserContribs options section [core] - 10https://gerrit.wikimedia.org/r/307077 (https://phabricator.wikimedia.org/T143518) [14:09:23] (03CR) 10Bartosz Dziewoński: "And also a duplicate closing ." [core] - 10https://gerrit.wikimedia.org/r/307077 (https://phabricator.wikimedia.org/T143518) (owner: 10Ladsgroup) [14:09:43] (03CR) 10Bartosz Dziewoński: [C: 032] Rework UserContribs options section [core] - 10https://gerrit.wikimedia.org/r/307077 (https://phabricator.wikimedia.org/T143518) (owner: 10Ladsgroup) [14:19:23] (03Merged) 10jenkins-bot: Rework UserContribs options section [core] - 10https://gerrit.wikimedia.org/r/307077 (https://phabricator.wikimedia.org/T143518) (owner: 10Ladsgroup) [14:25:14] 10UI-Standardization: OOJS UI: Create/Standardize Flyout Component - https://phabricator.wikimedia.org/T145934#2645602 (10Jan_Dittrich) [14:25:44] 10UI-Standardization: OOJS UI: Create/Standardize Flyout Component - https://phabricator.wikimedia.org/T145934#2645614 (10Jan_Dittrich) [14:35:09] (03PS21) 10Bartosz Dziewoński: Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [14:35:14] (03PS19) 10Bartosz Dziewoński: [WIP] LoginSignupSpecialPage: Convert form to OOUI [core] - 10https://gerrit.wikimedia.org/r/284902 (https://phabricator.wikimedia.org/T85853) [14:35:17] (03PS1) 10Bartosz Dziewoński: LoginSignupSpecialPage: Reduce hackiness of "You are already logged in" warning [core] - 10https://gerrit.wikimedia.org/r/311231 [14:36:53] (03CR) 10Bartosz Dziewoński: "PS21 uses the old .warningbox colours, because the new ones were absolute murder. Also, I submitted https://gerrit.wikimedia.org/r/#/c/311" [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [14:38:24] (03CR) 10Bartosz Dziewoński: "PS19 is a rebase on top of https://gerrit.wikimedia.org/r/#/c/296938/ and https://gerrit.wikimedia.org/r/#/c/311231/ , which simplifies th" [core] - 10https://gerrit.wikimedia.org/r/284902 (https://phabricator.wikimedia.org/T85853) (owner: 10Bartosz Dziewoński) [14:42:46] (03CR) 10Bartosz Dziewoński: [C: 031] "Form-related and style-related stuff looks good to me." [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [14:43:24] 10MediaWiki-Interface, 10UI-Standardization, 07Accessibility, 07Mobile, 15User-Ladsgroup: Special:UserContributions styling problems on mobile due to inline styles - https://phabricator.wikimedia.org/T50544#2645615 (10matmarex) 05Open>03Resolved a:03Ladsgroup [14:43:26] 10MediaWiki-Special-pages, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 15User-Ladsgroup: Filter on user contribs has nowrap, causing issues - https://phabricator.wikimedia.org/T143518#2645619 (10matmarex) 05Open>03Resolved [14:45:55] (03PS12) 10Cenarium: Bulk revision deletion and tag editing from contributions [core] - 10https://gerrit.wikimedia.org/r/210675 (https://phabricator.wikimedia.org/T28230) [14:49:16] (03CR) 10Bartosz Dziewoński: [WIP] Validate upload filename (031 comment) [core] - 10https://gerrit.wikimedia.org/r/310880 (https://phabricator.wikimedia.org/T117498) (owner: 10Matthias Mullie) [14:49:56] (03PS6) 10Bartosz Dziewoński: Use new OOUI display format in most forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/205720 (https://phabricator.wikimedia.org/T96154) (owner: 10MarkTraceur) [14:50:05] (03PS4) 10Bartosz Dziewoński: Replace HTMLForm info fields with definition lists on management interface [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/309924 (https://phabricator.wikimedia.org/T96154) (owner: 10Gergő Tisza) [14:55:57] (03CR) 10Bartosz Dziewoński: [C: 032] mw.widgets.CategorySelector: Add client-side caching [core] - 10https://gerrit.wikimedia.org/r/310533 (owner: 10Prtksxna) [15:05:12] (03Merged) 10jenkins-bot: mw.widgets.CategorySelector: Add client-side caching [core] - 10https://gerrit.wikimedia.org/r/310533 (owner: 10Prtksxna) [15:12:33] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, and 2 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2645622 (10Sumit) [15:18:57] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2645624 (10Sumit) >>! In T2582#2638984, @Mattflaschen-WMF wrote: > I am interested in co-mentoring this. Thanks... [15:19:36] 06Developer-Relations (Jul-Sep-2016): Add documentation links to TechTalk Youtube Videos - https://phabricator.wikimedia.org/T1119#2645628 (10husn_shujaat) @Aklapper that worked! thanks :) [15:35:11] 10MediaWiki-extensions-CharInsert: Inserting linebreaks is broken in Extension:CharInsert - https://phabricator.wikimedia.org/T145276#2645629 (10Subfader) Fixed: https://www.mediawiki.org/w/index.php?title=Extension%3ACharInsert&type=revision&diff=2239365&oldid=2235689 This ticket can be closed. [15:37:52] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Epic: [Epic] Language fallback - https://phabricator.wikimedia.org/T76216#2645633 (10matej_suchanek) [15:40:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Epic, 07Tracking, 07User-notice: [Epic] Unit support - https://phabricator.wikimedia.org/T77977#2645648 (10matej_suchanek) [15:41:44] 10MediaWiki-extensions-CharInsert: CharInsert: Split displayed text from inserted code - https://phabricator.wikimedia.org/T25354#2645649 (10Subfader) 5 years later and it's still not possible to create a one word button for multiline code. E.g. ``` {{Infobox | }} 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Show only the most relevant sitelinks initially - https://phabricator.wikimedia.org/T87025#2645654 (10matej_suchanek) [15:46:19] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 10Wikidata, 07Need-volunteer: Feature request - prioritize relevant languages in sitelinks of Wikidata - https://phabricator.wikimedia.org/T141076#2645656 (10matej_suchanek) [15:47:18] 10MediaWiki-extensions-UniversalLanguageSelector, 10MediaWiki-extensions-WikibaseRepository, 10ULS-CompactLinks, 10Wikidata, 07Need-volunteer: Show only the most relevant sitelinks initially - https://phabricator.wikimedia.org/T87025#981888 (10matej_suchanek) p:05Normal>03Lowest [16:10:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer: Implement a special page to show items with the most sitelinks - https://phabricator.wikimedia.org/T48217#2645666 (10matej_suchanek) [16:13:17] 10MediaWiki-extensions-Gadgets: Gadget-DeluxeHistory - https://phabricator.wikimedia.org/T145936#2645671 (10Zoranzoki21) [16:14:39] 10MediaWiki-extensions-Gadgets: Gadget-DeluxeHistory - https://phabricator.wikimedia.org/T145936#2645684 (10Zoranzoki21) Please answer me as soon as possible. Thank you! [16:24:57] (03PS13) 10Cenarium: Bulk revision deletion and tag editing from contributions [core] - 10https://gerrit.wikimedia.org/r/210675 (https://phabricator.wikimedia.org/T28230) [16:25:28] 10MobileFrontend, 07Performance: isWideScreen is not cached - https://phabricator.wikimedia.org/T145908#2645686 (10Esanders) Does the cache need to be cleared if the device is rotated? [16:28:04] 10MediaWiki-General-or-Unknown, 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, and 3 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#2645687 (10Mooeypoo) I should have been explicit before, but I am also interested in co mentoring this. [16:32:34] 10MediaWiki-API, 06Operations, 07Availability, 07HHVM: HHVM is leaking memory on the API appservers - https://phabricator.wikimedia.org/T133674#2645688 (10Southparkfan) Is this the same as the recent behavior seen on various API appservers? https://ganglia.wikimedia.org/latest/?c=API%20application%20server... [16:41:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer: Implement a special page to show items with the most sitelinks - https://phabricator.wikimedia.org/T48217#2645692 (10Multichill) The page property wb-sitelinks got introduced. That might open some options. It's stored as a string so no... [17:00:31] 10MediaWiki-extensions-CharInsert: CharInsert: Split displayed text from inserted code - https://phabricator.wikimedia.org/T25354#2645702 (10Subfader) CharInsert.body.php 12a13,17 > > > global $charInsertArgs; > $charInsertArgs = $params; > 51c56,61 < if ( $eend == '' ) { --- > >... [17:05:26] (03PS6) 10Cenarium: Show only valid log types in logs [core] - 10https://gerrit.wikimedia.org/r/258413 (https://phabricator.wikimedia.org/T126124) [17:29:58] 10MobileFrontend, 07Performance: isWideScreen is not cached - https://phabricator.wikimedia.org/T145908#2645738 (10Esanders) Ah, saw comment on https://gerrit.wikimedia.org/r/#/c/311199/ . This method just checks the aspect ratio of the device, regardless of orientation. [17:30:10] (03PS3) 10Cenarium: Pre-save transform inside extension tags [core] - 10https://gerrit.wikimedia.org/r/272916 (https://phabricator.wikimedia.org/T4700) [17:39:41] 10Wikimedia-General-or-Unknown, 07I18n, 07RTL: Using IPad, Arabic text looks disjoint on Egyptian Arabic (arz) Wikipedia - https://phabricator.wikimedia.org/T135333#2645742 (10Meno25) >>! In T135333#2645552, @Aklapper wrote: > Which exact fonts are used by the browser on the affected system? I don't know. I... [17:47:46] (03PS4) 10Cenarium: Pre-save transform inside extension tags [core] - 10https://gerrit.wikimedia.org/r/272916 (https://phabricator.wikimedia.org/T4700) [17:49:39] (03CR) 10Cenarium: Pre-save transform inside extension tags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/272916 (https://phabricator.wikimedia.org/T4700) (owner: 10Cenarium) [17:54:28] 04(no projects): Handle geo coordinates on mobile pages - https://phabricator.wikimedia.org/T145711#2645744 (10Zuse) Thanks for merging my issue! [17:56:10] 07Design, 10MobileFrontend, 10Reading-Community-Engagement, 06Reading-Web-Backlog: Display coordinates in mobile version - https://phabricator.wikimedia.org/T91481#2645745 (10Zuse) Just to mention my idea here, too. On mobile we probably do not need a website (geohack) with many links. At least geo uri htt... [17:58:17] (03CR) 10Gergő Tisza: [C: 032] Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [18:00:36] (03CR) 10Gergő Tisza: "It would be nice to have this message always on top, not below the rest of the errors/warnings." [core] - 10https://gerrit.wikimedia.org/r/311231 (owner: 10Bartosz Dziewoński) [18:05:15] (03Merged) 10jenkins-bot: Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [18:05:18] (03Merged) 10jenkins-bot: Set the type of the message when calling AuthenticationResponse::newUI [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/301672 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [18:05:20] (03Merged) 10jenkins-bot: Show the first input as a warning, not as an error box [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/301163 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [18:33:03] 10Wiki-Loves-Monuments (2016): Create a survey to collect local jury status from the participating countries - https://phabricator.wikimedia.org/T145939#2645753 (10LilyOfTheWest) [18:33:05] 10MediaWiki-extensions-Gadgets: Gadget-DeluxeHistory - https://phabricator.wikimedia.org/T145936#2645766 (10Zoranzoki21) Will believes someone to respond , or not ? [18:33:24] 10Wiki-Loves-Monuments (2016): Create a survey to collect local jury status from the participating countries - https://phabricator.wikimedia.org/T145939#2645753 (10LilyOfTheWest) Done and sent out: https://docs.google.com/forms/d/e/1FAIpQLSf9WpKbI78Eakq97liWJkNTlhiPicDcxE3SJs2i8HADkBA9Hg/viewform [18:33:46] 10Data-release, 06Research-and-Data: Create open data registry entries for Analytics data (PVs and UDs) - https://phabricator.wikimedia.org/T144604#2645770 (10DarTar) [18:34:29] 10Wiki-Loves-Monuments (2016): Postmortem on WLM-RU photos deleted from Commons - https://phabricator.wikimedia.org/T145872#2643650 (10LilyOfTheWest) Waiting to hear back from at least one Commons admin as well as one person from the WLM international team. [18:34:55] 10Wiki-Loves-Monuments (2016): Postmortem on WLM-RU photos deleted from Commons - https://phabricator.wikimedia.org/T145872#2645775 (10LilyOfTheWest) a:03LilyOfTheWest [18:46:55] 10MediaWiki-extensions-Quiz, 10MOOC-Interface, 10Possible-Tech-Projects, 10Outreachy (Round-13), 07Pywikibot-Wikidata: Python library for quiz data, with serialisation - https://phabricator.wikimedia.org/T89761#1044821 (10MayS) I am interested in applying for this project as part of outreachy-13. Right n... [18:47:02] (03CR) 10Gergő Tisza: "Yup, looks good, thanks!" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/205720 (https://phabricator.wikimedia.org/T96154) (owner: 10MarkTraceur) [18:47:11] 10MediaWiki-Page-editing: Can't view source of empty page or revision in the MediaWiki namespace - https://phabricator.wikimedia.org/T50935#2645780 (10Quiddity) [18:53:03] (03CR) 10Gergő Tisza: "Needs to be updated for https://gerrit.wikimedia.org/r/#/c/296938/21/includes/Status.php" [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [19:01:57] 10MediaWiki-Page-editing: Can't view source of empty page or revision in the MediaWiki namespace - https://phabricator.wikimedia.org/T50935#531240 (10Platonides) Probably related to the magic of MediaWiki namespace, where some empty pages mean that the default should be used. [19:43:48] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-Pluggable-Auth, 06Reading-Infrastructure-Team, 13Patch-For-Review: Update PluggableAuth to use AuthManager - https://phabricator.wikimedia.org/T110464#2645809 (10cicalese) Linking earlier discussion about PluggableAuth on the AuthManager... [20:17:36] 10MediaWiki-extensions-ContentTranslation: Bug when enable CX / access to Special:ContentTranslation - https://phabricator.wikimedia.org/T145941#2645815 (10Framawiki) [20:29:30] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-Pluggable-Auth, 06Reading-Infrastructure-Team, 13Patch-For-Review: Update PluggableAuth to use AuthManager - https://phabricator.wikimedia.org/T110464#2645829 (10cicalese) I have several specific questions about the new authentication fra... [20:30:22] (03PS9) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [20:31:09] (03CR) 10Gergő Tisza: "Needs rebase for https://gerrit.wikimedia.org/r/#/c/311084/" [core] - 10https://gerrit.wikimedia.org/r/311089 (owner: 10Aaron Schulz) [20:34:30] (03PS2) 10Aaron Schulz: Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) [20:35:36] (03CR) 10jenkins-bot: [V: 04-1] Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [20:38:45] (03CR) 10jenkins-bot: [V: 04-1] Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [20:39:53] (03PS10) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [20:41:22] 10Wiki-Loves-Monuments (2016): Postmortem on WLM-RU photos deleted from Commons - https://phabricator.wikimedia.org/T145872#2645834 (10Hedwig_in_Washington) Well, I think a lot of people (sysops) on Commons felt a little steam rollered. :-) The request to keep unfree and potentially unfree images on Commons is a... [20:44:01] (03CR) 10jenkins-bot: [V: 04-1] Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [20:46:11] 10MediaWiki-Special-pages, 10Wikimedia-Site-requests, 15User-Josve05a: Remove MediaWiki:Querypage-no-updates from recently restarted querypages - https://phabricator.wikimedia.org/T145942#2645835 (10Josve05a) [20:48:43] 10MediaWiki-Special-pages, 10Wikimedia-Site-requests, 15User-Josve05a: Remove MediaWiki:Querypage-no-updates from recently restarted querypages - https://phabricator.wikimedia.org/T145942#2645853 (10Josve05a) [20:49:21] (03PS11) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [21:12:46] (03PS3) 10Aaron Schulz: Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) [21:19:03] 10MediaWiki-User-login-and-signup: AddNewAccount hook isn't run when auto-creating external accounts - https://phabricator.wikimedia.org/T13734#2645854 (10Tgr) 05Open>03Resolved a:03Tgr [[https://www.mediawiki.org/wiki/Manual:Hooks/AddNewAccount|AddNewAccount]] has been deprecated and superseded by [[https... [21:20:51] /12/22 [21:22:07] 10MediaWiki-User-login-and-signup: $wgAuth->getCanonicalName() is evil and should die in a fire - https://phabricator.wikimedia.org/T42024#2645857 (10Tgr) 05Open>03Resolved a:03Tgr AuthManager providers can resolve login name to username in arbitrary ways; that functionality is not used or exposed outside... [21:22:48] 10MediaWiki-User-login-and-signup: Allow authentication plugins to report error messages - https://phabricator.wikimedia.org/T18524#2645860 (10Tgr) 05Open>03Resolved a:03Tgr [21:23:19] 10MediaWiki-Authentication-and-authorization, 05MW-1.27-release-notes, 05MW-1.28-release-notes, 13Patch-For-Review: Create convenience base classes for AuthManager providers - https://phabricator.wikimedia.org/T111299#2645864 (10Tgr) 05Open>03Resolved a:03Tgr This was done as part of the original com... [21:25:11] 10MediaWiki-User-login-and-signup: Let AuthPlugin decide whether a specific user (name) can be auto created - https://phabricator.wikimedia.org/T25802#2645869 (10Tgr) 05Open>03Resolved a:03Tgr The signature we ended up with is `testUserForCreation( User $user, bool $autocreate )`. [21:29:51] (03CR) 10Cindy-the-browser-test-bot: "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/311260 (owner: 10L10n-bot) [21:30:21] (03CR) 10Cindy-the-browser-test-bot: "Phan static analysis done without errors!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/311260 (owner: 10L10n-bot) [21:30:40] 10MediaWiki-User-login-and-signup: Create AuthPlugin methods to capture every aspect of MW user object - https://phabricator.wikimedia.org/T4027#2645872 (10Tgr) 05Open>03Resolved a:03Tgr There is now a way for `AuthenticationProvider` subclasses to do arbitrary checks and return arbitrary error messages th... [21:34:10] (03PS2) 10Legoktm: [WIP] Add mergeMetadata method ParserOutput. [core] - 10https://gerrit.wikimedia.org/r/308070 (owner: 10Brian Wolff) [21:37:21] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 06Security-Team, 06Services, 06Services-next: Create password-authentication service for use by CentralAuth - https://phabricator.wikimedia.org/T120484#1854580 (10Tgr) Tokens (`user.user_token` / `globaluser.gu_auth_token`)... [21:39:11] 10Wiki-Loves-Monuments (2016): Postmortem on WLM-RU photos deleted from Commons - https://phabricator.wikimedia.org/T145872#2645880 (10Ymblanter) A reverse CommonsHelper (a tool which can transfer files from Commons to the projects) would definitely be extremely helpful, especially if it could work with batches... [21:41:51] (03CR) 10Florianschmidtwelzow: [C: 032] "Good idea! :)" [core] - 10https://gerrit.wikimedia.org/r/311231 (owner: 10Bartosz Dziewoński) [21:43:11] 10MediaWiki-Special-pages, 10Wikimedia-Site-requests, 15User-Josve05a: Remove MediaWiki:Querypage-no-updates from recently restarted querypages - https://phabricator.wikimedia.org/T145942#2645884 (10Josve05a) a:05Josve05a>03None [21:44:08] 07Design, 10MediaWiki-HTMLForm, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-OATHAuth, and 2 others: UI for entering the token shouldn't be a errorbox - https://phabricator.wikimedia.org/T139179#2645885 (10Florian) 05Open>03Resolved [21:45:20] legoktm: https://gerrit.wikimedia.org/r/#/c/311222/3 [21:48:51] (03Merged) 10jenkins-bot: LoginSignupSpecialPage: Reduce hackiness of "You are already logged in" warning [core] - 10https://gerrit.wikimedia.org/r/311231 (owner: 10Bartosz Dziewoński) [21:49:15] (03CR) 10Florianschmidtwelzow: "> The tiny coding style related nitpicks (inline) are something that can be fixed at a later date if you don't want to amend this commit -" (033 comments) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) (owner: 10Florianschmidtwelzow) [21:49:47] * legoktm looks [21:52:50] (03PS2) 10Florianschmidtwelzow: Add option to limit the cookie warning to specific regions [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) [21:53:45] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] "We should get someone who can merge the CI change, so we get tests for this extension :P" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311033 (https://phabricator.wikimedia.org/T145781) (owner: 10Florianschmidtwelzow) [21:53:58] 10MediaWiki-extensions-General-or-Unknown: CookieWarning and Cookie Policy doing nearly the same and could be merged - https://phabricator.wikimedia.org/T145723#2645890 (10Florian) [21:55:09] (03CR) 10Legoktm: [C: 04-1] "DatabaseDomain should have unit tests" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [21:55:26] AaronSchulz: I can write the unit tests if you don't want to [21:59:00] (03CR) 10Hashar: "recheck" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311033 (https://phabricator.wikimedia.org/T145781) (owner: 10Florianschmidtwelzow) [22:00:37] legoktm: if you really want to, I was mostly trying to get the new LBFactory tests to work. [22:00:39] (03CR) 10Aklapper: [C: 04-2] "Hi Aparna, , thank you and congratulations to your contribution in Gerrit! We would love to see more contributions from you! :) If you are" [extensions/examples] - 10https://gerrit.wikimedia.org/r/311115 (owner: 10Aparna a) [22:00:51] I guess there could be some encoding tests [22:02:13] (03Draft1) 10Paladox: Fix composer test error [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 [22:02:29] (03PS2) 10Florianschmidtwelzow: Allow non-JS users to dismiss the CookieWarning bar [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310562 (https://phabricator.wikimedia.org/T145647) [22:02:32] (03PS2) 10Paladox: Fix composer test error [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 [22:02:44] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] "PS2 is a rebase only." [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310562 (https://phabricator.wikimedia.org/T145647) (owner: 10Florianschmidtwelzow) [22:03:38] (03CR) 10jenkins-bot: [V: 04-1] Fix composer test error [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 (owner: 10Paladox) [22:04:06] (03CR) 10Paladox: "recheck" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 (owner: 10Paladox) [22:06:07] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-Pluggable-Auth, 06Reading-Infrastructure-Team, 13Patch-For-Review: Update PluggableAuth to use AuthManager - https://phabricator.wikimedia.org/T110464#2645895 (10Tgr) >>! In T110464#2645829, @cicalese wrote: > 1) Is it possible to begin a... [22:08:19] legoktm: when you finish that you can look at https://gerrit.wikimedia.org/r/#/c/311203/ too [22:12:01] AaronSchulz: well I found a bug while writing tests ;) [22:12:03] public function getSchema() { [22:12:03] return $this->database; [22:12:03] } [22:16:42] (03CR) 10Aaron Schulz: [C: 032] Allow filtering content model changes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/310242 (https://phabricator.wikimedia.org/T145489) (owner: 10Legoktm) [22:17:46] figures, nothing uses that, heh [22:17:57] not yet at least [22:19:20] (03PS3) 10Florianschmidtwelzow: Fix tests [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 (owner: 10Paladox) [22:20:28] (03CR) 10Florianschmidtwelzow: [C: 032] Fix tests [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 (owner: 10Paladox) [22:23:06] } [22:23:23] (03Merged) 10jenkins-bot: Allow filtering content model changes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/310242 (https://phabricator.wikimedia.org/T145489) (owner: 10Legoktm) [22:23:25] (03Merged) 10jenkins-bot: Fix tests [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 (owner: 10Paladox) [22:24:27] (03PS2) 10Florianschmidtwelzow: i18n: Make the OK button label translateable [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310563 [22:24:48] (03CR) 10Florianschmidtwelzow: [C: 032] "PS2 is a rebase only." [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310563 (owner: 10Florianschmidtwelzow) [22:24:52] } elseif ( $nextChar === '@' ) { [22:24:52] $decoded .= '@'; [22:24:52] ++$i; [22:25:01] AaronSchulz: shouldn't '@' be '?' ? [22:25:26] (03PS2) 10Florianschmidtwelzow: Use the short hooks definition in extension.json [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310565 [22:25:30] (03Merged) 10jenkins-bot: i18n: Make the OK button label translateable [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310563 (owner: 10Florianschmidtwelzow) [22:25:32] legoktm: yeah, I used to use @ and then decided on ? [22:26:28] (03CR) 10Paladox: "Thanks." [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311297 (owner: 10Paladox) [22:26:55] (03CR) 10Florianschmidtwelzow: [C: 032] Use the short hooks definition in extension.json [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310565 (owner: 10Florianschmidtwelzow) [22:27:48] (03Merged) 10jenkins-bot: Use the short hooks definition in extension.json [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310565 (owner: 10Florianschmidtwelzow) [22:30:11] (03PS4) 10Legoktm: Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [22:30:48] AaronSchulz: ^ review my changes? [22:30:52] and thank you for the AF merge :) [22:31:14] (03PS1) 10Aaron Schulz: Inject Profiler into Database objects [core] - 10https://gerrit.wikimedia.org/r/311298 [22:32:02] (03CR) 10Aaron Schulz: [C: 031] "Thanks :)" [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [22:32:10] legoktm: LGTM [22:32:28] (03CR) 10Legoktm: [C: 032] Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [22:33:01] (03PS2) 10Aaron Schulz: Inject Profiler into Database objects [core] - 10https://gerrit.wikimedia.org/r/311298 [22:35:51] 10MediaWiki-ContentHandler, 07Community-consensus-needed, 05MW-1.27-release-notes, 05MW-1.28-release-notes, and 2 others: Grant editcontentmodel right to all logged in users - https://phabricator.wikimedia.org/T85847#2645904 (10Legoktm) [22:35:55] 10MediaWiki-ContentHandler, 10AbuseFilter, 05MW-1.28-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-09-20_(1.28.0-wmf.20): Allow AbuseFilter to filter edits that change content models - https://phabricator.wikimedia.org/T145489#2645902 (10Legoktm) 05Open>03Resolved Documented: https://www.media... [22:36:55] legoktm: https://gerrit.wikimedia.org/r/#/c/311298/ too [22:37:05] (03PS2) 10Florianschmidtwelzow: Use short array syntax instead of array() [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310566 [22:37:11] ok, looking at the statusvalue one right now [22:38:29] (03PS12) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [22:38:33] (03CR) 10Florianschmidtwelzow: [C: 032] Use short array syntax instead of array() [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310566 (owner: 10Florianschmidtwelzow) [22:39:27] (03CR) 10Aaron Schulz: [C: 032] registration: Support 'ServiceWiringFiles' in extension.json [core] - 10https://gerrit.wikimedia.org/r/306873 (owner: 10Legoktm) [22:40:32] (03CR) 10Gergő Tisza: "What about LockManager classes returning Status but hinting StatusValue, could the returned objects be changed to match the hint?" [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [22:41:02] (03Merged) 10jenkins-bot: Make database classes handle hyphens in $wgDBname [core] - 10https://gerrit.wikimedia.org/r/311222 (https://phabricator.wikimedia.org/T145840) (owner: 10Aaron Schulz) [22:41:05] (03Merged) 10jenkins-bot: Use short array syntax instead of array() [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310566 (owner: 10Florianschmidtwelzow) [22:41:50] (03CR) 10Legoktm: Make Status extend StatusValue and start FileBackend update (032 comments) [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [22:41:53] 06Brickimedia, 10MediaWikiChat: Using the shortcut pipe trick for links doesn't output correctly in MediaWikiChat - https://phabricator.wikimedia.org/T145943#2645906 (10SamanthaNguyen) [22:42:16] (03PS2) 10Florianschmidtwelzow: build: Update to mediawiki-codesniffer 0.7.2 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310568 [22:42:20] (03CR) 10Legoktm: [C: 04-1] "See PS11 comments" [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [22:44:47] (03CR) 10Florianschmidtwelzow: [C: 032] build: Update to mediawiki-codesniffer 0.7.2 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310568 (owner: 10Florianschmidtwelzow) [22:45:19] (03Merged) 10jenkins-bot: registration: Support 'ServiceWiringFiles' in extension.json [core] - 10https://gerrit.wikimedia.org/r/306873 (owner: 10Legoktm) [22:45:36] (03Merged) 10jenkins-bot: build: Update to mediawiki-codesniffer 0.7.2 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/310568 (owner: 10Florianschmidtwelzow) [22:46:01] (03PS13) 10Aaron Schulz: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 [22:47:16] AaronSchulz: uh, Profile::profileIn/profileOut() are no-ops and just for BC... [22:47:52] why does Database still call them? [22:48:44] automatic profiling like hhvm will not do per-query profiling [22:48:57] ProfilerText can be injected into maintenance scripts too [22:49:05] so it's not dead yet [22:49:54] (03CR) 10Gergő Tisza: "> So, I did not approach this with an intent to bypass the new" [core] - 10https://gerrit.wikimedia.org/r/311146 (https://phabricator.wikimedia.org/T110464) (owner: 10Cicalese) [22:50:17] (03PS3) 10Florianschmidtwelzow: Add option to limit the cookie warning to specific regions [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) [22:50:17] ok [22:50:21] (03CR) 10Legoktm: [C: 032] Inject Profiler into Database objects [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [22:50:32] (03CR) 10Florianschmidtwelzow: "PS3 is a rebase." [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) (owner: 10Florianschmidtwelzow) [22:51:10] (03CR) 10jenkins-bot: [V: 04-1] Add option to limit the cookie warning to specific regions [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) (owner: 10Florianschmidtwelzow) [22:57:15] (03Merged) 10jenkins-bot: Inject Profiler into Database objects [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz) [23:03:40] (03Draft2) 10Paladox: Add CookieWarning to mediawiki/extensions [extensions] - 10https://gerrit.wikimedia.org/r/311299 [23:03:43] (03Draft1) 10Paladox: Add CookieWarning to mediawiki/extensions [extensions] - 10https://gerrit.wikimedia.org/r/311299 [23:04:09] AaronSchulz: also https://gerrit.wikimedia.org/r/#/c/309815/ is the last of the editcontentmodel blockers [23:05:31] (03CR) 10Paladox: [C: 031] Update extensions with sync-with-gerrit.py [extensions] - 10https://gerrit.wikimedia.org/r/306237 (owner: 10Nemo bis) [23:05:57] (03PS3) 10Paladox: Add CookieWarning to mediawiki/extensions [extensions] - 10https://gerrit.wikimedia.org/r/311299 [23:06:40] (03PS4) 10Paladox: Add CookieWarning to mediawiki/extensions [extensions] - 10https://gerrit.wikimedia.org/r/311299 [23:09:15] (03PS15) 10Aaron Schulz: Move LBFactorySimple to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/310924 [23:09:22] legoktm: ^ [23:09:54] * AaronSchulz keeps conflict merging [23:12:50] 10MediaWiki-extensions-CentralAuth: Don't autologin if local account doesn't exist (don't autocreate if user doesn't explicitly login) - https://phabricator.wikimedia.org/T21161#236912 (10Tgr) There are a couple options, each pretty bad: * don't do anything * disable CentralAuth autocreation completely ** very p... [23:13:05] (03PS16) 10Aaron Schulz: Move LBFactorySimple to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/310924 [23:17:26] tgr|away: anything else for https://gerrit.wikimedia.org/r/#/c/311203/? [23:18:15] AaronSchulz: all the LockManager classes are returning Status, can that be changed? [23:18:34] not safely I don't think [23:19:23] it seems scary that they say they return StatusValue but actually return Status and something somewhere depends on that [23:19:47] (03CR) 10Legoktm: [C: 032] Move LBFactorySimple to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/310924 (owner: 10Aaron Schulz) [23:20:53] tgr: why would something be bothered by a more specific/featured subclass? [23:20:59] e.g. liskov [23:21:42] (03CR) 10Legoktm: [C: 032] Add powered by Debian icon in footer [debian] - 10https://gerrit.wikimedia.org/r/310919 (owner: 10Legoktm) [23:21:46] in any case, it's just docs. I *want* callers to not assume anything more than StatusValue, but it will take more patches to enforce that [23:26:33] (03CR) 10Gergő Tisza: [C: 032] Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [23:27:30] (03Merged) 10jenkins-bot: Move LBFactorySimple to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/310924 (owner: 10Aaron Schulz) [23:29:33] (03PS4) 10Florianschmidtwelzow: Add option to limit the cookie warning to specific regions [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/311175 (https://phabricator.wikimedia.org/T145780) [23:34:33] (03Merged) 10jenkins-bot: Make Status extend StatusValue and start FileBackend update [core] - 10https://gerrit.wikimedia.org/r/311203 (owner: 10Aaron Schulz) [23:37:30] (03PS4) 10Aaron Schulz: Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 [23:37:32] legoktm: ^ getting closer to lbfactorymulti [23:37:44] 10Graphs: Error: URL hostname is not whitelisted: wikiraw:///Fertility-csv - https://phabricator.wikimedia.org/T145944#2645923 (10saper) [23:38:52] (03PS4) 10Aaron Schulz: Move mysql database classes to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311085 [23:39:27] tgr: https://gerrit.wikimedia.org/r/#/c/311085 [23:39:35] (03CR) 10Legoktm: [C: 032] Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [23:39:53] (03PS2) 10Aaron Schulz: Move LBFactoryMulti to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311080 [23:41:30] (03CR) 10jenkins-bot: [V: 04-1] Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [23:45:53] (03PS3) 10Aaron Schulz: Move LBFactoryMulti to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311080 [23:49:37] (03PS5) 10Aaron Schulz: Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 [23:50:15] legoktm: ^ fixed a functional merge conflict [23:50:42] (03CR) 10Legoktm: [C: 032] Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [23:53:13] (03PS4) 10Aaron Schulz: Move LBFactoryMulti to /libs/rdbms [core] - 10https://gerrit.wikimedia.org/r/311080 [23:54:10] legoktm: ^ \o/ [23:54:17] :D [23:56:49] 10Graphs: [Vega Err] PARSE DATA FAILED: countries TypeError: t.objects is undefined - https://phabricator.wikimedia.org/T145945#2645936 (10saper) [23:57:24] (03Merged) 10jenkins-bot: Clean up $wgDBmwschema handling and only apply it to mssql [core] - 10https://gerrit.wikimedia.org/r/310965 (owner: 10Aaron Schulz) [23:58:53] 10Graphs: [Vega Err] PARSE DATA FAILED: countries TypeError: t.objects is undefined - https://phabricator.wikimedia.org/T145945#2645950 (10saper) I have downloaded the JSON world data using http://tools.wikimedia.pl/~saper/b/index.php/WorldMap-iso3-json?action=raw and "jq" is parsing them fine, so the JSON for... [23:59:45] (03CR) 10Mwjames: Inject Profiler into Database objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/311298 (owner: 10Aaron Schulz)