[00:01:06] (03Merged) 10jenkins-bot: Set "run when DBs idle" DeferredUpdates logic in Maintenance [core] - 10https://gerrit.wikimedia.org/r/307975 (owner: 10Aaron Schulz) [00:02:54] (03PS4) 10Aaron Schulz: Move run-on-add logic in DeferredUpdates to addUpdate() [core] - 10https://gerrit.wikimedia.org/r/307979 [00:03:20] (03Merged) 10jenkins-bot: Remove $recursionGuard var from tryOpportunisticExecute() [core] - 10https://gerrit.wikimedia.org/r/307978 (owner: 10Aaron Schulz) [00:06:04] (03CR) 10Gergő Tisza: [C: 04-1] "Gives me" [vagrant] - 10https://gerrit.wikimedia.org/r/306487 (https://phabricator.wikimedia.org/T123951) (owner: 10Mattflaschen) [00:06:50] (03CR) 10Gergő Tisza: "Would be nice to include the PHP docs so the doc command works with builtins: https://github.com/bobthecow/psysh#downloading-the-manual" [vagrant] - 10https://gerrit.wikimedia.org/r/306487 (https://phabricator.wikimedia.org/T123951) (owner: 10Mattflaschen) [00:07:26] (03PS4) 10Aaron Schulz: Make DeferredUpdates able to run DataUpdates [core] - 10https://gerrit.wikimedia.org/r/308011 [00:07:43] (03PS10) 10Aaron Schulz: Enable DBO_TRX for DeferredUpdates::execute() in CLI mode [core] - 10https://gerrit.wikimedia.org/r/308007 [00:08:05] (03CR) 10Gergő Tisza: "> There is one bug I haven't figured out: When you shut down psysh, it" [vagrant] - 10https://gerrit.wikimedia.org/r/306487 (https://phabricator.wikimedia.org/T123951) (owner: 10Mattflaschen) [00:09:11] 06Language-Engineering, 10Wikimedia-Site-requests, 07I18n: Source Languages in import page - https://phabricator.wikimedia.org/T133483#2603846 (10JMinor) Hello, I don't think this related to the iOS app for Wikipedia. I have tagged Wikimedia-Site-requests since this seems related to upload widget. [00:09:47] (03PS2) 10Aaron Schulz: Always fail over to sync jobs when Special:RunJobs fails [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/307798 (https://phabricator.wikimedia.org/T68485) [00:09:58] (03CR) 10Krinkle: [C: 032] Always fail over to sync jobs when Special:RunJobs fails [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/307798 (https://phabricator.wikimedia.org/T68485) (owner: 10Aaron Schulz) [00:10:36] (03PS4) 10Mooeypoo: Add EventLogging for Special:RecentChanges filter usage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/308091 (https://phabricator.wikimedia.org/T144331) [00:11:53] (03PS5) 10Mooeypoo: Add EventLogging for Special:RecentChanges filter usage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/308091 (https://phabricator.wikimedia.org/T144331) [00:12:00] (03PS3) 10Niedzielski: Add NavTabViewTest and initial ViewTest framework [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307031 (https://phabricator.wikimedia.org/T140019) [00:12:02] (03PS5) 10Niedzielski: Add screenshot unit test support and diff script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/306821 (https://phabricator.wikimedia.org/T118102) [00:12:04] (03PS1) 10Niedzielski: Hygiene: remove unused constructors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308101 [00:12:06] (03PS1) 10Niedzielski: Hygiene: remove commented out code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308102 [00:12:08] (03PS1) 10Niedzielski: Hygiene: simplify CardLargeHeaderView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308103 [00:12:10] (03PS1) 10Niedzielski: Update ViewTest to include system font size [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308104 [00:12:12] (03PS1) 10Niedzielski: Add CardLargeHeaderViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308105 (https://phabricator.wikimedia.org/T144401) [00:13:00] (03CR) 10Krinkle: [C: 032] Move run-on-add logic in DeferredUpdates to addUpdate() [core] - 10https://gerrit.wikimedia.org/r/307979 (owner: 10Aaron Schulz) [00:13:46] 06Discovery-Search (Current work), 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Commit changes to implement ascii-folding for French - https://phabricator.wikimedia.org/T144429#2599556 (10EBernhardson) This is merged and will go out next week, it won't have any effect until all fr wikis have... [00:14:28] (03CR) 10Krinkle: [C: 04-1] "(Previous comments)" [core] - 10https://gerrit.wikimedia.org/r/308007 (owner: 10Aaron Schulz) [00:14:38] (03PS6) 10Mooeypoo: Add EventLogging for Special:RecentChanges filter usage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/308091 (https://phabricator.wikimedia.org/T144331) [00:14:46] (03CR) 10Dereckson: "Self-merge ok here, change discussed on #wikimedia-operations to keep parity between deployed code and repo code." [extensions/CirrusSearch] (wmf/1.28.0-wmf.16) - 10https://gerrit.wikimedia.org/r/308098 (owner: 10EBernhardson) [00:15:33] 06Reading-Web-Backlog, 03Reading-Web-Sprint-81-W, 07Spike: Spike: Determine impact of disabling lazy loaded references - https://phabricator.wikimedia.org/T144569#2603868 (10Jdlrobson) [00:15:47] (03Restored) 10EBernhardson: [WIP] Document level noop detection with a version field [search/extra] - 10https://gerrit.wikimedia.org/r/219118 (https://phabricator.wikimedia.org/T99244) (owner: 10EBernhardson) [00:15:52] (03PS9) 10EBernhardson: [WIP] Document level noop detection with a version field [search/extra] - 10https://gerrit.wikimedia.org/r/219118 (https://phabricator.wikimedia.org/T99244) [00:17:49] (03Merged) 10jenkins-bot: Always fail over to sync jobs when Special:RunJobs fails [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/307798 (https://phabricator.wikimedia.org/T68485) (owner: 10Aaron Schulz) [00:18:15] (03PS1) 10Harej: Adding license information for icons [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308106 [00:19:59] (03CR) 10Mooeypoo: "I'd +2 if I could, but it seems I don't have rights in this repo, so consider this my +1." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/280366 (owner: 10Mattflaschen) [00:20:46] (03CR) 10Mooeypoo: [C: 032] Don't actually flip direction of page for directionality unit tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/280366 (owner: 10Mattflaschen) [00:22:40] (03CR) 10EBernhardson: "I didn't get a chance to load this into an ES instance today, will do that tomorrow and pull off the [WIP] tag once validated." [search/extra] - 10https://gerrit.wikimedia.org/r/219118 (https://phabricator.wikimedia.org/T99244) (owner: 10EBernhardson) [00:23:57] (03Merged) 10jenkins-bot: Move run-on-add logic in DeferredUpdates to addUpdate() [core] - 10https://gerrit.wikimedia.org/r/307979 (owner: 10Aaron Schulz) [00:24:44] (03PS3) 10Esanders: Convert 'generic' icon to SVG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/278553 [00:25:08] (03CR) 10Catrope: [C: 032] Convert 'generic' icon to SVG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/278553 (owner: 10Esanders) [00:25:42] (03CR) 10Harej: [C: 032] Adding license information for icons [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308106 (owner: 10Harej) [00:26:35] (03Merged) 10jenkins-bot: Don't actually flip direction of page for directionality unit tests [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/280366 (owner: 10Mattflaschen) [00:30:09] (03PS1) 10EBernhardson: Create cirrus indexes in both search clusters [extensions/WikimediaMaintenance] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/308107 (https://phabricator.wikimedia.org/T142181) [00:30:21] 10MediaWiki-extensions-WikimediaMaintenance, 10CirrusSearch, 06Discovery, 06Discovery-Search (Current work), and 2 others: WikimediaMaintenance/addWiki.php should create cirrus indices on all available clusters - https://phabricator.wikimedia.org/T142181#2603918 (10EBernhardson) a:03EBernhardson [00:30:33] (03PS1) 10EBernhardson: Create cirrus indexes in both search clusters [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/308108 (https://phabricator.wikimedia.org/T142181) [00:30:45] (03Merged) 10jenkins-bot: Convert 'generic' icon to SVG [extensions/Echo] - 10https://gerrit.wikimedia.org/r/278553 (owner: 10Esanders) [00:30:48] (03Merged) 10jenkins-bot: Adding license information for icons [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308106 (owner: 10Harej) [00:30:50] (03Abandoned) 10EBernhardson: Create cirrus indexes in both search clusters [extensions/WikimediaMaintenance] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/308107 (https://phabricator.wikimedia.org/T142181) (owner: 10EBernhardson) [00:31:10] (03PS1) 10Esanders: Remove unused CSS and icon for old preferences button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308109 [00:31:32] (03PS5) 10Aaron Schulz: Make DeferredUpdates able to run DataUpdates [core] - 10https://gerrit.wikimedia.org/r/308011 [00:31:34] 10MediaWiki-extensions-CollaborationKit, 07Documentation: add readme for icon licensing info - https://phabricator.wikimedia.org/T141595#2603922 (10Harej) 05Open>03Resolved a:03Harej [00:33:19] (03Abandoned) 10Aaron Schulz: Enable DBO_TRX for DeferredUpdates::execute() in CLI mode [core] - 10https://gerrit.wikimedia.org/r/308007 (owner: 10Aaron Schulz) [00:33:53] (03PS2) 10EBernhardson: Create cirrus indexes in both search clusters [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/308108 (https://phabricator.wikimedia.org/T142181) [00:35:39] (03CR) 10Catrope: [C: 032] Remove unused CSS and icon for old preferences button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308109 (owner: 10Esanders) [00:37:34] (03PS4) 10Aaron Schulz: Disallow mismatched beginMasterChanges/commitMasterChanges [core] - 10https://gerrit.wikimedia.org/r/307430 [00:39:36] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: In the new wikitext editor, provide a preview function - https://phabricator.wikimedia.org/T142642#2603933 (10Jdforrester-WMF) a:03Esanders [00:42:46] (03Merged) 10jenkins-bot: Remove unused CSS and icon for old preferences button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308109 (owner: 10Esanders) [00:45:23] (03PS17) 10Legoktm: Add resources and enable the beta feature [extensions/WikiLabels] - 10https://gerrit.wikimedia.org/r/264415 (owner: 10Bmansurov) [00:46:15] 10Wikimedia-General-or-Unknown: Guapopedia - https://phabricator.wikimedia.org/T144276#2603956 (10Peachey88) Changing to Wikimedia-General till further info is provided. [00:50:32] 10Wikimedia-General-or-Unknown: Guapopedia - https://phabricator.wikimedia.org/T144276#2603972 (10Platonides) 05stalled>03declined I have no idea what you envision by Guapopedia, but given the name I can advance you that [it won't happen](https://en.wikipedia.org/wiki/Wikipedia:Snowball_clause) as a wikimedi... [00:53:23] * AaronSchulz knows of a cat named Guapo [00:53:47] Guapo would be pretty/handsome [00:54:02] (03PS1) 10Esanders: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 [00:55:45] Project performance-webpagetest-wpt-org build #1855: 04FAILURE in 23 min: https://integration.wikimedia.org/ci/job/performance-webpagetest-wpt-org/1855/ [00:57:04] (03PS2) 10Esanders: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 [00:58:11] (03CR) 10Aaron Schulz: [C: 031] Implement support for specifying type=styles [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/308096 (https://phabricator.wikimedia.org/T42284) (owner: 10Krinkle) [00:59:44] wait, is AaronSchulz trying to start a wiki based on said cat? I think #wikimedia-kawaii would be impressed >.> [01:02:00] (03CR) 10Legoktm: [C: 032] build: Pass --path vendor/bundle to bundle install [extensions/MobileFrontend] (REL1_27) - 10https://gerrit.wikimedia.org/r/307986 (https://phabricator.wikimedia.org/T143601) (owner: 10Phuedx) [01:02:29] (03CR) 10Legoktm: [C: 032] Don't cause fatals on preferences page when default skin is Minerva [extensions/MobileFrontend] (REL1_27) - 10https://gerrit.wikimedia.org/r/307963 (https://phabricator.wikimedia.org/T141099) (owner: 10Phuedx) [01:03:35] (03PS3) 10Esanders: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 [01:07:55] (03Merged) 10jenkins-bot: build: Pass --path vendor/bundle to bundle install [extensions/MobileFrontend] (REL1_27) - 10https://gerrit.wikimedia.org/r/307986 (https://phabricator.wikimedia.org/T143601) (owner: 10Phuedx) [01:08:22] (03Merged) 10jenkins-bot: Don't cause fatals on preferences page when default skin is Minerva [extensions/MobileFrontend] (REL1_27) - 10https://gerrit.wikimedia.org/r/307963 (https://phabricator.wikimedia.org/T141099) (owner: 10Phuedx) [01:12:27] 06Reading-Admin, 06Reading-Web-Backlog, 05Goal, 03Reading-Web-Planning: [GOAL] Lazy load references in mobile skin - https://phabricator.wikimedia.org/T123328#2604021 (10Jdlrobson) [01:12:29] 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Planning: Disable lazy loaded references experiment in production - https://phabricator.wikimedia.org/T144240#2604019 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson [01:26:29] (03PS1) 10Sbisson: Provide title when parsing wikitext [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308115 (https://phabricator.wikimedia.org/T141460) [01:26:36] (03PS1) 10Sbisson: Allow moderating resolved topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308116 (https://phabricator.wikimedia.org/T142779) [01:40:45] (03CR) 10Catrope: [C: 032] Provide title when parsing wikitext [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308115 (https://phabricator.wikimedia.org/T141460) (owner: 10Sbisson) [01:41:50] (03CR) 10Catrope: [C: 032] Allow moderating resolved topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308116 (https://phabricator.wikimedia.org/T142779) (owner: 10Sbisson) [01:48:34] (03Merged) 10jenkins-bot: Provide title when parsing wikitext [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308115 (https://phabricator.wikimedia.org/T141460) (owner: 10Sbisson) [01:48:54] (03Merged) 10jenkins-bot: Allow moderating resolved topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308116 (https://phabricator.wikimedia.org/T142779) (owner: 10Sbisson) [02:05:33] (03PS1) 10Arlolra: Smash the global promise [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/308118 [02:07:48] (03PS29) 10Aaron Schulz: Support masking the WRITE_SYNC latency from ChronologyProtector [core] - 10https://gerrit.wikimedia.org/r/306554 [02:11:50] (03CR) 10jenkins-bot: [V: 04-1] Support masking the WRITE_SYNC latency from ChronologyProtector [core] - 10https://gerrit.wikimedia.org/r/306554 (owner: 10Aaron Schulz) [02:12:57] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make it easy to pull data for bulk refunds - https://phabricator.wikimedia.org/T144570#2604059 (10awight) [02:13:33] (03PS30) 10Aaron Schulz: Support masking the WRITE_SYNC latency from ChronologyProtector [core] - 10https://gerrit.wikimedia.org/r/306554 [02:17:53] 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend: Mobile Media Viewer violates user settings - https://phabricator.wikimedia.org/T144571#2604073 (10Alsee) [02:21:16] (03PS1) 10Mattflaschen: Allow passing a jQuery-wrapped node to attachTo [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/308121 (https://phabricator.wikimedia.org/T143297) [02:25:28] (03PS5) 10Mattflaschen: Message tweaks for VE and vector-view-edit [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/305746 (https://phabricator.wikimedia.org/T143297) [02:26:26] (03CR) 10Mattflaschen: "Done" (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/305746 (https://phabricator.wikimedia.org/T143297) (owner: 10Mattflaschen) [02:32:57] (03CR) 10Mattflaschen: "> How do you hit that, exactly? I did not see anything similar." [vagrant] - 10https://gerrit.wikimedia.org/r/306487 (https://phabricator.wikimedia.org/T123951) (owner: 10Mattflaschen) [02:43:14] (03PS1) 10Harej: Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 [02:44:01] (03CR) 10Harej: [C: 032] Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 (owner: 10Harej) [02:44:46] (03CR) 10jenkins-bot: [V: 04-1] Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 (owner: 10Harej) [02:48:29] (03PS1) 10Harej: Removing errant whitespace [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308123 [02:49:15] (03CR) 10Harej: [C: 032] Removing errant whitespace [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308123 (owner: 10Harej) [02:50:00] (03CR) 10jenkins-bot: [V: 04-1] Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 (owner: 10Harej) [02:50:02] (03CR) 10jenkins-bot: [V: 04-1] Removing errant whitespace [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308123 (owner: 10Harej) [02:51:05] (03Abandoned) 10Harej: Removing errant whitespace [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308123 (owner: 10Harej) [02:51:55] (03PS2) 10Harej: Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 [02:52:42] (03CR) 10Harej: [C: 032] Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 (owner: 10Harej) [02:53:23] (03Merged) 10jenkins-bot: Removing type hinting since it causes bizarre error [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308122 (owner: 10Harej) [03:01:40] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10fundraising-tech-ops: Provide a sudo wrapper for running DonationInterface maintenance scripts - https://phabricator.wikimedia.org/T144572#2604090 (10awight) [03:02:27] 10MediaWiki-extensions-CollaborationKit, 13Patch-For-Review: Allow embedding pages of arbitrary content models in hub pages - https://phabricator.wikimedia.org/T136785#2604103 (10Harej) [03:02:29] 10MediaWiki-extensions-CollaborationKit: Implement CollaborationHubContent.php - https://phabricator.wikimedia.org/T136478#2604104 (10Harej) [03:03:17] 10MediaWiki-extensions-CollaborationKit: Disable editsection links for wikitext content-type - https://phabricator.wikimedia.org/T132012#2185903 (10Harej) I think changing our strategy on how to handle these pages has made this a non-issue. (I did a test to be safe.) [03:24:01] Hey [03:27:49] (03PS1) 10Harej: Removing type hint for the same reason as before [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308124 [03:28:28] (03CR) 10Harej: [C: 032] Removing type hint for the same reason as before [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308124 (owner: 10Harej) [03:28:44] Hello? [03:29:20] (03Merged) 10jenkins-bot: Removing type hint for the same reason as before [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308124 (owner: 10Harej) [03:33:38] 10MediaWiki-extensions-CollaborationKit: Set a default/placeholder project image for collaborationhubs - https://phabricator.wikimedia.org/T141565#2503078 (10Harej) 05Open>03Resolved [03:34:12] 10MediaWiki-extensions-CollaborationKit: Set a default/placeholder project image for collaborationhubs - https://phabricator.wikimedia.org/T141565#2503078 (10Harej) I created some test WikiProjects and there was a default logo of a key icon. Better than the nothing / awkward space that was there before. [03:41:16] 10Android-app-feature-Feeds, 06Wikipedia-Android-App-Backlog: As a reader, I would like to know why certain articles are trending - https://phabricator.wikimedia.org/T144574#2604128 (10Niedzielski) [03:46:10] 10MediaWiki-extensions-CollaborationKit: Move icon info for subpage features into hub page - https://phabricator.wikimedia.org/T141007#2604141 (10Harej) [03:58:13] 10MediaWiki-extensions-ContentTranslation, 07WorkType-NewFunctionality: Allow different users to translate the same topic independently - https://phabricator.wikimedia.org/T86151#2604148 (10santhosh) [03:58:56] (03PS1) 10Arlolra: Document some things on osx [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/308125 [04:04:53] (03CR) 10Krinkle: Make DeferredUpdates able to run DataUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:06:45] (03CR) 10Krinkle: Make DeferredUpdates able to run DataUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:09:58] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking, 13Patch-For-Review, 07Unplanned-Sprint-Work: Banners not allocated correctly - https://phabricator.wikimedia.org/T144393#2604156 (10AndyRussG) a:03AndyRussG [04:11:06] (03CR) 10Aaron Schulz: Make DeferredUpdates able to run DataUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:12:56] (03PS6) 10Aaron Schulz: Make DeferredUpdates able to run DataUpdates [core] - 10https://gerrit.wikimedia.org/r/308011 [04:23:56] 10MediaWiki-extensions-CollaborationKit: Implement CollaborationHubContent.php - https://phabricator.wikimedia.org/T136478#2604163 (10Harej) [04:23:58] 10MediaWiki-extensions-CollaborationKit: Move icon info for subpage features into hub page - https://phabricator.wikimedia.org/T141007#2604162 (10Harej) 05Open>03Resolved [04:24:44] 06Language-Engineering, 10Wikimedia-Site-requests, 07I18n: Source Languages in import page - https://phabricator.wikimedia.org/T133483#2604165 (10NehalDaveND) @JMinor So what should I do to solve this problem? Can suggest any name to ping? Because so long time went for this work. Please guide me. Thank you. [04:27:03] (03CR) 10Krinkle: Make DeferredUpdates able to run DataUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:30:54] (03PS1) 10Aaron Schulz: Replace DataUpdate::doUpdates() callers in maintenance/ [core] - 10https://gerrit.wikimedia.org/r/308127 [04:35:08] (03CR) 10Krinkle: Replace DataUpdate::doUpdates() callers in maintenance/ (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308127 (owner: 10Aaron Schulz) [04:35:19] AaronSchulz: Last comment on https://gerrit.wikimedia.org/r/#/c/308011/ - then good to go :) [04:35:43] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 13Patch-For-Review: Don't group by region when the list of languages is small - https://phabricator.wikimedia.org/T137870#2381961 (10santhosh) @Pginer-WMF, Ple... [04:36:31] (03CR) 10Krinkle: [C: 032] ImageHistoryList: Remove 'wpEditToken' parameter from the "revert" link for files [core] - 10https://gerrit.wikimedia.org/r/308074 (owner: 10Bartosz Dziewoński) [04:37:23] Krinkle: how did you "POSTSEND from PRESEND: Right after current update"? If the stage is PRESEND then you need 1 >= 2 for that to happen [04:37:37] (03CR) 10Krinkle: RevertAction: Prevent file revert if current version is identical (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308075 (https://phabricator.wikimedia.org/T53383) (owner: 10Bartosz Dziewoński) [04:38:51] AaronSchulz: POSTSEND (2) > PRESEND (1). addUpdate does: If executing stage >= added stage; add to sub queue. [04:39:02] Oh. [04:39:07] I got it reversed. [04:39:50] the PRESEND getting ignored is ok due to the eventual catchall DeferredUpdates::doUpdates( 'enqueue' ); in restInPeace/doMaintenance [04:40:06] (03CR) 10Krinkle: Make DeferredUpdates able to run DataUpdates (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:40:08] though I suppose it could also be handled in that class [04:40:09] (03CR) 10Krinkle: [C: 032] Make DeferredUpdates able to run DataUpdates [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:40:14] hmm [04:40:28] AaronSchulz: It shouldn't be. It'll be run in the same queue. [04:40:33] That's what this new code doees. [04:40:43] If we're executing POSTSEND, then a new presend update will go in the subqueue. [04:40:51] I guess when we do POSTSEND we just do ALL anyway [04:40:58] Yep [04:40:58] since there is no point in being specific by then [04:41:21] but if you did want to be, the class should respect that [04:42:05] As long as it doesn't run updates from a future queue in the sub queue, then it's fine. [04:42:16] Which I thought it did, but it doesn't. I looked at it the wrong way around. [04:42:27] k, signing off o/ [04:43:42] (03Merged) 10jenkins-bot: ImageHistoryList: Remove 'wpEditToken' parameter from the "revert" link for files [core] - 10https://gerrit.wikimedia.org/r/308074 (owner: 10Bartosz Dziewoński) [04:46:15] 06Research-and-Data, 10Research-management: Wikimedia Research publication list - https://phabricator.wikimedia.org/T144575#2604168 (10DarTar) [04:48:35] (03Merged) 10jenkins-bot: Make DeferredUpdates able to run DataUpdates [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [04:48:36] Yippee, build fixed! [04:48:37] Project performance-webpagetest-wpt-org build #1856: 09FIXED in 16 min: https://integration.wikimedia.org/ci/job/performance-webpagetest-wpt-org/1856/ [04:48:59] 06Research-and-Data, 10Research-management: Wikimedia Research publication list - https://phabricator.wikimedia.org/T144575#2604184 (10DarTar) [04:52:33] (03PS5) 10Aaron Schulz: Disallow mismatched beginMasterChanges/commitMasterChanges [core] - 10https://gerrit.wikimedia.org/r/307430 [04:58:12] 10MediaWiki-extensions-SemanticForms: Fix default value for field tag, for existing and new pages. - https://phabricator.wikimedia.org/T137701#2604186 (10Oetterer) > For the 2nd one, I'm still curious to hear what you guys think about my "mass field addition" idea. Oetterer - you wrote, "Some thoughts about your... [04:58:27] 06Research-and-Data, 10Research-management: Wikimedia Research publication list - https://phabricator.wikimedia.org/T144575#2604188 (10DarTar) I created a preliminary list in the Etherpad, as part of the T131204 epic. The list includes all published research output – journal articles; book chapters; conferen... [04:59:05] 06Research-and-Data, 10Research-management: Wikimedia Research publication list - https://phabricator.wikimedia.org/T144575#2604191 (10DarTar) BTW it's an impressive list! [05:02:59] 10MediaWiki-Internationalization: "MediaWiki:Emailuser" and "MediaWiki:Userrights" should support {{GENDER}} - https://phabricator.wikimedia.org/T142316#2604193 (10Guycn2) >>! In T142316#2603606, @TTO wrote: >>>! In T142316#2603440, @Nemo_bis wrote: >> That's the bug actually, message reuse. Probably the message... [05:04:50] 10MediaWiki-Internationalization, 06Collaboration-Team-Triage, 10Flow, 10Notifications, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2604194 (10Guycn2) [05:07:35] (03CR) 10Jcrespo: "This is a welcome change." [core] - 10https://gerrit.wikimedia.org/r/307078 (owner: 10Aaron Schulz) [05:08:54] 06Research-and-Data, 10Research-management: Make sure each team member with published research outputs has an ORCID - https://phabricator.wikimedia.org/T144576#2604195 (10DarTar) [05:12:56] 10MediaWiki-Database, 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, and 2 others: Wikibase\SqlIdGenerator::generateNewId: Explicit commit of implicit transaction. - https://phabricator.wikimedia.org/T143818#2580075 (10jcrespo) Thank you for the quick fix. It... [05:15:09] 06Research-and-Data, 10Research-management: Wikimedia Research published output - https://phabricator.wikimedia.org/T144575#2604213 (10DarTar) [05:18:13] 06Design-Research-Backlog, 06Research-and-Data-Backlog, 07Epic, 03Research-and-Data-2017-Q1: [Epic] Make Wikimedia Research content easier to discover - https://phabricator.wikimedia.org/T131204#2604215 (10DarTar) [05:18:37] 06Design-Research-Backlog, 06Research-and-Data-Backlog, 10Research-management, 07Epic, 03Research-and-Data-2017-Q1: [Epic] Make Wikimedia Research content easier to discover - https://phabricator.wikimedia.org/T131204#2159210 (10DarTar) a:03DarTar [05:18:45] (03CR) 1001tonythomas: "** need-review ** :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/304692 (https://phabricator.wikimedia.org/T138462) (owner: 1001tonythomas) [05:18:48] 06Design-Research-Backlog, 06Research-and-Data-Backlog, 10Research-management, 07Epic, 03Research-and-Data-2017-Q1: [Epic] Make Wikimedia Research content easier to discover - https://phabricator.wikimedia.org/T131204#2159210 (10DarTar) p:05Triage>03High [05:19:29] Hi? [06:03:43] 10Hovercards, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Spike: [ 8 hours ] Spike: Analyze Hovercards and general instrumentation code for potential sources of unexpected data outcomes - https://phabricator.wikimedia.org/T141922#2604226 (10Tbayer) PS: Perhaps it's more instructive to... [06:13:05] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5: Package apertium-srd, apertium-ita and apertium-srd-ita - https://phabricator.wikimedia.org/T144174#2604228 (10KartikMistry) [06:13:55] (03CR) 10Robert Vogel: [C: 032] UniversalExport: extension.json aftermath [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307725 (owner: 10Robert Vogel) [06:14:21] (03Merged) 10jenkins-bot: UniversalExport: extension.json aftermath [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307725 (owner: 10Robert Vogel) [06:14:38] (03CR) 10Robert Vogel: [C: 032] ExtensioInfo: Re-enabled WikiAdmin link [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307728 (owner: 10Robert Vogel) [06:15:03] (03Merged) 10jenkins-bot: ExtensioInfo: Re-enabled WikiAdmin link [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307728 (owner: 10Robert Vogel) [06:25:40] 05WMDE-Tech-Communication-Mentoring-And-Events, 03WMDE-Tech-Communication-Q1-2016, 03WMDE-Tech-Communication-Q2-2016: prep Com part of talk - https://phabricator.wikimedia.org/T144577#2604229 (10Juscwmde) [06:29:01] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Create mapping lists from metadata entries to Commons entries for DecArch - https://phabricator.wikimedia.org/T140728#2604247 (10Mattias_Ostmar-WMSE) [06:29:10] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Create a metadata field mapping document for DecArch - https://phabricator.wikimedia.org/T140727#2604250 (10Mattias_Ostmar-WMSE) [06:29:12] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Create mapping lists from metadata entries to Commons entries for DecArch - https://phabricator.wikimedia.org/T140728#2474288 (10Mattias_Ostmar-WMSE) 05Open>03Resolved [06:30:42] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Create mapping lists from metadata entries to Commons entries for DecArch - https://phabricator.wikimedia.org/T140728#2474288 (10Mattias_Ostmar-WMSE) Great feedback from @Haxpett and @jopparn - they helped spot a few warts. [06:34:18] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Create a metadata field mapping document for DecArch - https://phabricator.wikimedia.org/T140727#2604254 (10Mattias_Ostmar-WMSE) [06:36:20] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Map infobox/photograph for DecArch - https://phabricator.wikimedia.org/T143212#2604255 (10Mattias_Ostmar-WMSE) @Lokal_Profil: I added an explanatory text to the source field after discussion with @Haxpett - which was also something that @Jopparn was kind... [06:36:34] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Create a metadata field mapping document for DecArch - https://phabricator.wikimedia.org/T140727#2604257 (10Mattias_Ostmar-WMSE) [06:36:36] 10Connected-Open-Heritage-Batch-uploads (DecArch 2016-07): Map infobox/photograph for DecArch - https://phabricator.wikimedia.org/T143212#2604256 (10Mattias_Ostmar-WMSE) 05Open>03Resolved [06:37:01] (03PS1) 10Robert Vogel: BSApiWikiSubPageTreeStore: Added I18N desc [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308129 [06:37:54] 06Project-Admins, 06Developer-Relations (Jul-Sep-2016): Create Phabricator projects for the Wikimedia Developer Summit - https://phabricator.wikimedia.org/T142470#2604259 (10Aklapper) 05Resolved>03Open Nope, my mistake not reading closely enough. Let me rename/create/archive/move/edit later to fix this. Re... [06:44:11] (03CR) 10Robert Vogel: [V: 032] Added bs.icons.php [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/307919 (owner: 10Gerharddiller85) [06:44:27] (03CR) 10Robert Vogel: "recheck" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308129 (owner: 10Robert Vogel) [06:48:28] 10MediaWiki-Installer: 1.27.1 Installer does not connect to custom port on PostgreSQL, uses default wrong port - https://phabricator.wikimedia.org/T144535#2604265 (10Aklapper) [06:48:59] 10MediaWiki-Database, 07Tracking: PostgreSQL/pgsql support (tracking) - https://phabricator.wikimedia.org/T2384#2604267 (10Aklapper) [06:55:51] 10MediaWiki-Parser, 07I18n, 07Tracking: GENDER (tracking) - https://phabricator.wikimedia.org/T32443#2604271 (10Aklapper) [06:55:53] 10MediaWiki-Internationalization, 06Collaboration-Team-Triage, 10Flow, 10Notifications, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2604270 (10Aklapper) [06:56:08] 10MediaWiki-Internationalization, 06Collaboration-Team-Triage, 10Flow, 10Notifications, 07I18n: New Echo messages do not support {{GENDER:}} - https://phabricator.wikimedia.org/T144538#2602917 (10Aklapper) [ Edit Related Tasks > Edit Parent Tasks > Added {T32443} ] [06:56:25] 10MediaWiki-Installer, 07NewPHP: Don't warn about absense of APC on PHP7 - https://phabricator.wikimedia.org/T144531#2604275 (10Aklapper) [07:09:02] (03PS1) 10Robert Vogel: Added $bsgConfigFiles to extension.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308133 [07:09:44] 10MobileFrontend, 06Reading-Web-Backlog: Make it possible to search from the UC mini browser - https://phabricator.wikimedia.org/T136803#2604281 (10Peter) @dr0ptp4kt I don't know but my guess it is not, but we should check. I'm thinking that we miss the search button either is that UC Mini strips away that for... [07:09:49] (03CR) 10Robert Vogel: "recheck" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308133 (owner: 10Robert Vogel) [07:10:14] (03CR) 10jenkins-bot: [V: 04-1] Added $bsgConfigFiles to extension.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308133 (owner: 10Robert Vogel) [07:11:16] 10MediaWiki-Revision-deletion: Feature Request: request search engines to update caches of pages with rev deleted content - https://phabricator.wikimedia.org/T144559#2604282 (10Aklapper) Hi @M.A.Bruhn, thanks for taking the time to report this! Which underlying problem would you like to see solved here? What e... [07:17:05] (03CR) 10Robert Vogel: [C: 032] BSDashboards: Workaround for JS TypeError [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307950 (owner: 10Pwirth) [07:17:31] (03Merged) 10jenkins-bot: BSDashboards: Workaround for JS TypeError [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307950 (owner: 10Pwirth) [07:17:34] (03Abandoned) 10Robert Vogel: Rename mediawiki.action.history.diff to mediawiki.action.history.diff.styles [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307752 (owner: 10WMDE-leszek) [07:18:01] 10MediaWiki-extensions-RelatedArticles, 10MediaWiki-extensions-WikibaseClient, 06Reading-Web-Backlog, 10Wikidata, and 2 others: Change cache mode of pageterms API module to public or anon-public-user-private - https://phabricator.wikimedia.org/T144385#2604290 (10phuedx) Thanks @hoo! [07:22:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 07Wikimedia-log-errors: wikibase-addUsagesForPage generates transaction error logs "Implicit transaction already active" "Explicit commit of implicit transaction" "Implicit transaction expected" - https://phabricator.wikimedia.org/T144398#2604293 (10thiemowmd... [07:26:30] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 13Patch-For-Review: Don't group by region when the list of languages is small - https://phabricator.wikimedia.org/T137870#2604295 (10Pginer-WMF) >>! In T137870... [07:32:59] (03PS1) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 [07:36:47] 10MediaWiki-Revision-deletion: Feature Request: request search engines to update caches of pages with rev deleted content - https://phabricator.wikimedia.org/T144559#2604301 (10M.A.Bruhn) Hi @Aklapper ! The problem is that currently, if an admin uses revdel to remove information, like outing information, I can... [07:42:28] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2604306 (10phuedx) a:05Nirzar>03None [07:44:35] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2604323 (10phuedx) ^ Per the above – thanks @Issimo_15 [07:46:09] (03CR) 10Addshore: "I guess then this should be either mediawiki.diff or mediawiki.action.view.diff ?" [core] - 10https://gerrit.wikimedia.org/r/307316 (https://phabricator.wikimedia.org/T142636) (owner: 10WMDE-leszek) [07:49:12] 07Design, 10MobileFrontend, 03Reading-Web-Sprint-80-V-for-Vandalism: Beta footer appears obscured on diff pages - https://phabricator.wikimedia.org/T144579#2604326 (10phuedx) [07:50:33] (03CR) 10Fomafix: [C: 04-1] "The change from [...].diff to [...].diff.style is correct." [core] - 10https://gerrit.wikimedia.org/r/307705 (owner: 10WMDE-leszek) [07:52:25] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2604344 (10phuedx) Since it's a non-trivial bug, I've created T144579 to track it. Again, thanks @Issimo_15! [07:52:51] 07Design, 10MobileFrontend, 03Reading-Web-Sprint-80-V-for-Vandalism: [SUBTASK] Beta footer appears obscured on diff pages - https://phabricator.wikimedia.org/T144579#2604326 (10phuedx) [07:53:19] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2604347 (10phuedx) a:03ovasileva [07:55:17] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2576765 (10phuedx) Over to you @ovasileva (per T141002#2599985). [07:57:40] (03Abandoned) 10Addshore: DiscussionParserTest also test the action that triggered events [extensions/Echo] - 10https://gerrit.wikimedia.org/r/302903 (owner: 10Addshore) [08:04:10] (03CR) 10Fomafix: "A diff is also shown on action=submit and on Special:ComparePages and so mediawiki.action.view.diff is also not correct." [core] - 10https://gerrit.wikimedia.org/r/307316 (https://phabricator.wikimedia.org/T142636) (owner: 10WMDE-leszek) [08:08:08] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 13Patch-For-Review: Don't group by region when the list of languages is small - https://phabricator.wikimedia.org/T137870#2604358 (10Nikerabbit) The spacing lo... [08:13:08] (03CR) 10Fomafix: Allow skins to place notification container for mw.notify (031 comment) [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [08:19:23] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 13Patch-For-Review: Don't group by region when the list of languages is small - https://phabricator.wikimedia.org/T137870#2604366 (10Pginer-WMF) @Nikerabbit, t... [08:20:37] 10MediaWiki-Parser, 05MW-1.28-release-notes, 13Patch-For-Review: Don't always disable caching when special pages are transcluded - https://phabricator.wikimedia.org/T62561#2604367 (10Umherirrender) 05Open>03Resolved a:03Bawolff [08:23:25] (03PS5) 10Umherirrender: LogPager: Use normalized value for log_user_text in query condition [core] - 10https://gerrit.wikimedia.org/r/304620 (https://phabricator.wikimedia.org/T142755) (owner: 10Glaisher) [08:23:40] (03CR) 10Umherirrender: [C: 032] LogPager: Use normalized value for log_user_text in query condition [core] - 10https://gerrit.wikimedia.org/r/304620 (https://phabricator.wikimedia.org/T142755) (owner: 10Glaisher) [08:24:23] 10MediaWiki-Logging, 13Patch-For-Review: Can't look for logs for Global rename script - https://phabricator.wikimedia.org/T142755#2604383 (10Umherirrender) 05Open>03Resolved a:03Glaisher [08:26:32] 06Community-Liaisons, 10PerformanceInspector: Feedback/input/suggestions for Performance inspector - https://phabricator.wikimedia.org/T144474#2604385 (10Qgil) >>! In T144474#2603394, @Peter wrote: > Hi @Qgil preferable asap, sorry for missing that. We will try to give you an answer by the end of our team mee... [08:30:19] (03Merged) 10jenkins-bot: LogPager: Use normalized value for log_user_text in query condition [core] - 10https://gerrit.wikimedia.org/r/304620 (https://phabricator.wikimedia.org/T142755) (owner: 10Glaisher) [08:31:48] 10MediaWiki-extensions-ParserFunctions: Strange urlencode error - https://phabricator.wikimedia.org/T20794#2604393 (10Umherirrender) [08:31:50] 10MediaWiki-Parser, 07Tracking: Strip marker issues (tracking) - https://phabricator.wikimedia.org/T28213#2604392 (10Umherirrender) [08:31:53] 10Technical-Collaboration-Guideline, 10WMF-Product-Development-Process: Consolidate the Communities subpage of the product development process - https://phabricator.wikimedia.org/T125815#2604394 (10Qgil) What about scanning the content of https://www.mediawiki.org/wiki/WMF_product_development_process/Communiti... [08:35:53] 10MediaWiki-extensions-SemanticForms: Fix default value for field tag, for existing and new pages. - https://phabricator.wikimedia.org/T137701#2604396 (10Jongfeli) > Jongfeli: I really don't think it's true that default values were added when editing existing pages, in all SF versions before 2.4.1. In any case,... [08:36:04] 10MediaWiki-Database, 10TimedMediaHandler-Transcode, 05MW-1.28-release-notes: transcode connections open for minutes on s4 master - https://phabricator.wikimedia.org/T97641#2604397 (10hashar) [08:36:23] (03PS1) 10Aaron Schulz: Add caching to ResourceLoaderWikiModule::getTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 [08:36:25] 10MediaWiki-Database, 10MediaWiki-Installer, 10MediaWiki-Maintenance-scripts, 05MW-1.28-release-notes, 13Patch-For-Review: Transaction of DatabaseUpdater may get out of sync when populate script does own transaction handling - https://phabricator.wikimedia.org/T89363#2604398 (10Umherirrender) 05Open>0... [08:40:51] (03CR) 10jenkins-bot: [V: 04-1] Add caching to ResourceLoaderWikiModule::getTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz) [08:45:15] (03PS2) 10Aaron Schulz: Add caching to ResourceLoaderWikiModule::getTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 [08:47:28] 06Project-Admins, 06Developer-Relations (Jul-Sep-2016): Create Phabricator projects for Outreachy - https://phabricator.wikimedia.org/T144581#2604407 (10Qgil) [08:52:56] 10MediaWiki-extensions-WikibaseRepository, 06Commons, 10Wikidata, 07Story, 15User-Ladsgroup: [Story] Add a new datatype for linking to creators of artwork and more (smart URI) - https://phabricator.wikimedia.org/T127929#2604421 (10Jan_Dittrich) Hey, I talked with @Charlie_WMDE about possible designs. Tur... [08:53:03] 03WMDE-Tech-Communication-Q2-2016: tpt interview - https://phabricator.wikimedia.org/T144582#2604423 (10Juscwmde) [08:53:24] 05WMDE-Tech-Communication-Mentoring-And-Events, 03WMDE-Tech-Communication-Q1-2016, 03WMDE-Tech-Communication-Q2-2016: tpt interview - https://phabricator.wikimedia.org/T144582#2604437 (10Juscwmde) a:03Juscwmde [08:55:08] 10MediaWiki-Cache, 10MediaWiki-Page-editing, 10MediaWiki-Special-pages: Edit updates should be applied to redirects created from page moves - https://phabricator.wikimedia.org/T144566#2604441 (10Aklapper) p:05Triage>03Lowest Hi @GeoffreyT2000, thanks for taking the time to report this! What are "edit up... [08:56:00] 10WMDE-Tech-Communication-Communications, 03WMDE-Tech-Communication-Q1-2016, 03WMDE-Tech-Communication-Q2-2016: events calendar update - https://phabricator.wikimedia.org/T144583#2604444 (10Juscwmde) [08:57:09] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 13Patch-For-Review: Don't group by region when the list of languages is small - https://phabricator.wikimedia.org/T137870#2604460 (10Nikerabbit) >>! In T137870... [08:59:42] (03PS3) 10Aaron Schulz: Add caching to ResourceLoaderWikiModule::getTitleInfo() [core] - 10https://gerrit.wikimedia.org/r/308138 [09:10:51] 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-80-V-for-Vandalism, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Request cached copy of machine generated Related Articles - https://phabricator.wikimedia.org/T126455#2604468 (10phuedx) With @hoo's change... [09:14:18] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 13Patch-For-Review: Don't group by region when the list of languages is small - https://phabricator.wikimedia.org/T137870#2604470 (10Pginer-WMF) > This is the... [09:14:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Add Special:GoToLinkedPageElseGoToItem - https://phabricator.wikimedia.org/T144584#2604471 (10Karima) [09:16:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [feature request] Add Special:GoToLinkedPageElseGoToItem - https://phabricator.wikimedia.org/T144584#2604483 (10Karima) [09:48:20] (03PS1) 10Phuedx: Cache logged-in "morelike" requests too [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308143 (https://phabricator.wikimedia.org/T126455) [09:53:16] 10MediaWiki-extensions-ZeroBanner, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 5 others: [Spike: 2 hours] Page actions bar not showing on Wikipedia Zero - https://phabricator.wikimedia.org/T143425#2567770 (10phuedx) @dr0ptp4kt: Is this something that you can email the Reading Web team... [09:58:22] (03PS1) 10Umherirrender: Bypass cached field for new requests on ChangesListSpecialPages [core] - 10https://gerrit.wikimedia.org/r/308144 [10:04:59] (03PS1) 10Legoktm: Update gbp.conf for jessie [debian] (jessie) - 10https://gerrit.wikimedia.org/r/308146 [10:05:01] (03PS1) 10Legoktm: Update dependencies for jessie [debian] (jessie) - 10https://gerrit.wikimedia.org/r/308147 [10:05:03] (03PS1) 10Legoktm: Rebuild for jessie-backports [debian] (jessie) - 10https://gerrit.wikimedia.org/r/308148 [10:07:58] 10Community-Engagement-Insights, 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Coordinate Technical Collaboration's participation in Community Engagement Insights survey - https://phabricator.wikimedia.org/T143008#2604506 (10Qgil) p:05High>03Low The bulk of the work was done... [10:08:36] 10Community-Engagement-Insights, 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Coordinate Technical Collaboration's participation in Community Engagement Insights survey - https://phabricator.wikimedia.org/T143008#2604510 (10Qgil) [10:13:25] 06Community-Liaisons (Jul-Sep-2016), 07Surveys: Ask communities about how do they interact with WMF via CE Insights - https://phabricator.wikimedia.org/T126965#2604512 (10Qgil) [10:14:28] 06Developer-Relations (Jul-Sep-2016), 07Surveys: Organize a survey about developer events via CE Insights - https://phabricator.wikimedia.org/T132108#2604517 (10Qgil) [10:16:21] 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Review KPIs, workflows, and scorecards of the Technical Collaboration team - https://phabricator.wikimedia.org/T132499#2604522 (10Qgil) p:05Normal>03High [10:19:52] 10MediaWiki-General-or-Unknown: Line breaks may be inserted in preformatted text in tables - https://phabricator.wikimedia.org/T144585#2604526 (10Sebastian_Berlin-WMSE) [10:23:20] (03CR) 10Muehlenhoff: [C: 031] "Looks good to me" [debian] (jessie) - 10https://gerrit.wikimedia.org/r/308147 (owner: 10Legoktm) [10:42:53] 10MediaWiki-extensions-WikibaseRepository, 06Commons, 10Wikidata, 07Story, 15User-Ladsgroup: [Story] Add a new datatype for linking to creators of artwork and more (smart URI) - https://phabricator.wikimedia.org/T127929#2604549 (10daniel) >>! In T127929#2604421, @Jan_Dittrich wrote: > * @daniel You said... [10:54:33] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2604550 (10ovasileva) 05Open>03Resolved Closing and will keep an eye on the subtasks. Since this pulled over into this sprint and we... [11:08:26] 10Recommendation-API: Turn Recommendation API to a good open-source citizen - https://phabricator.wikimedia.org/T141025#2604555 (10schana) 05Open>03Resolved Generally, I think this task is done. The specific content of the CONTRIBUTING and AUTHORS (I only added myself since I think it should be an individual... [11:22:04] (03PS2) 10Bartosz Dziewoński: RevertAction: Prevent file revert if current version is identical [core] - 10https://gerrit.wikimedia.org/r/308075 (https://phabricator.wikimedia.org/T53383) [11:22:12] (03CR) 10Bartosz Dziewoński: RevertAction: Prevent file revert if current version is identical (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308075 (https://phabricator.wikimedia.org/T53383) (owner: 10Bartosz Dziewoński) [11:33:41] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5: Package apertium-srd, apertium-ita and apertium-srd-ita - https://phabricator.wikimedia.org/T144174#2604584 (10KartikMistry) [11:37:23] (03CR) 10Mobrovac: [C: 032] Add retry topics for new schema topics. [event-schemas] - 10https://gerrit.wikimedia.org/r/308081 (owner: 10Ppchelko) [11:43:33] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5: Update packaging configuration for Jessie migration - https://phabricator.wikimedia.org/T144588#2604591 (10KartikMistry) [11:44:12] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5: Update packaging configuration for Jessie migration - https://phabricator.wikimedia.org/T144588#2604608 (10KartikMistry) p:05Triage>03Normal [11:44:36] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 07WorkType-Maintenance: Use Extension:JsonConfig for storing the template param mapping between languages - https://phabricator.wikimedia.org/T143857#2604609 (10KartikMistry) [11:44:48] (03Merged) 10jenkins-bot: Add retry topics for new schema topics. [event-schemas] - 10https://gerrit.wikimedia.org/r/308081 (owner: 10Ppchelko) [11:44:52] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, and 2 others: Package apertium-srd, apertium-ita and apertium-srd-ita - https://phabricator.wikimedia.org/T144174#2604610 (10KartikMistry) [11:45:03] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5: Use Extension:JsonConfig for storing the template param mapping between languages - https://phabricator.wikimedia.org/T143857#2581342 (10KartikMistry) [11:45:13] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 5, 07WorkType-Maintenance: Update packaging configuration for Jessie migration - https://phabricator.wikimedia.org/T144588#2604591 (10KartikMistry) [11:46:06] 10MediaWiki-extensions-WikibaseRepository, 06Commons, 10Wikidata, 07Story, 15User-Ladsgroup: [Story] Add a new datatype for linking to creators of artwork and more (smart URI) - https://phabricator.wikimedia.org/T127929#2604613 (10Jan_Dittrich) > You usually have the URL (or URI) of the author, but not t... [12:07:32] 06Reading-Web-Backlog, 06Community-Liaisons (Jul-Sep-2016), 10Hovercards (2016-Q2-Goal): Share results of Hovercard A/B Test on Hungarian Wikipedia - https://phabricator.wikimedia.org/T139370#2604628 (10ovasileva) [12:08:40] (03PS2) 10Umherirrender: Special:MovePage: Use LinkBatch when constructing subpages [core] - 10https://gerrit.wikimedia.org/r/304690 (https://phabricator.wikimedia.org/T141029) (owner: 10Glaisher) [12:08:50] (03CR) 10Umherirrender: [C: 032] Special:MovePage: Use LinkBatch when constructing subpages [core] - 10https://gerrit.wikimedia.org/r/304690 (https://phabricator.wikimedia.org/T141029) (owner: 10Glaisher) [12:09:20] 06Reading-Web-Backlog, 06Community-Liaisons (Jul-Sep-2016), 10Hovercards (2016-Q2-Goal): Share results of Hovercard A/B Test on Hungarian Wikipedia - https://phabricator.wikimedia.org/T139370#2430004 (10ovasileva) @CKoerner_WMF - I edited the description to reflect the current situation. I think 2 and 3 are... [12:09:40] 10MediaWiki-Special-pages, 13Patch-For-Review: Loading of Special:MovePage is slow when the page contains many subpages - https://phabricator.wikimedia.org/T141029#2604631 (10Umherirrender) 05Open>03Resolved a:03Glaisher [12:11:54] (03CR) 10Dbrant: [C: 032] Hygiene: update Namespace Javadocs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307775 (owner: 10Niedzielski) [12:13:47] 10MediaWiki-Cache, 10MediaWiki-Page-editing, 10MediaWiki-Special-pages: Edit updates should be applied to redirects created from page moves - https://phabricator.wikimedia.org/T144566#2603751 (10Umherirrender) WikiPage::doEditUpdates is called for the redirect revision, so this maybe is a problem with a long... [12:16:01] (03Merged) 10jenkins-bot: Special:MovePage: Use LinkBatch when constructing subpages [core] - 10https://gerrit.wikimedia.org/r/304690 (https://phabricator.wikimedia.org/T141029) (owner: 10Glaisher) [12:18:31] (03Merged) 10jenkins-bot: Hygiene: update Namespace Javadocs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307775 (owner: 10Niedzielski) [12:24:42] (03CR) 10Raimond Spekking: [C: 031] "18n review" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308129 (owner: 10Robert Vogel) [12:33:14] 10MediaWiki-extensions-WikibaseRepository, 06Commons, 10Wikidata, 07Story, 15User-Ladsgroup: [Story] Add a new datatype for linking to creators of artwork and more (smart URI) - https://phabricator.wikimedia.org/T127929#2604636 (10daniel) >>! In T127929#2604613, @Jan_Dittrich wrote: >> You usually have t... [12:33:17] 10MediaWiki-Internationalization, 10Wikimedia-Site-requests: Change file namespace name in ur.wp - https://phabricator.wikimedia.org/T144437#2604637 (10MuhammadShuaib) [12:34:43] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Evaluate placeholder structure - https://phabricator.wikimedia.org/T144589#2604638 (10hoo) [12:36:06] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Make it possible to enable indexing for placeholders - https://phabricator.wikimedia.org/T144590#2604653 (10hoo) [12:36:22] 10Reading-Community-Engagement, 06Reading-Web-Backlog, 10Hovercards (2016-Q2-Goal), 03Reading-Web-Sprint-81-W: Initiate Hovercards A/B Test 2 - https://phabricator.wikimedia.org/T136746#2604667 (10ovasileva) [12:37:21] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Create a special page that lists all notable placeholders for indexing - https://phabricator.wikimedia.org/T144591#2604668 (10hoo) [12:37:37] 10Hovercards, 10Reading-Community-Engagement, 06Reading-Web-Backlog: Initiate Hovercards A/B Test 3 with Central Notice: October 2016 - https://phabricator.wikimedia.org/T141775#2604684 (10ovasileva) [12:41:05] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Limitted trial of search indexed article placeholders - https://phabricator.wikimedia.org/T144592#2604688 (10hoo) [12:41:41] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Create a special page that lists all notable placeholders for indexing - https://phabricator.wikimedia.org/T144591#2604703 (10hoo) [12:41:44] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Make it possible to enable indexing for placeholders - https://phabricator.wikimedia.org/T144590#2604704 (10hoo) [12:41:47] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Evaluate placeholder structure - https://phabricator.wikimedia.org/T144589#2604705 (10hoo) [12:41:50] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Limitted trial of search indexed article placeholders - https://phabricator.wikimedia.org/T144592#2604688 (10hoo) [12:43:09] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 07Story: Search index a limitted number of article placeholders for testing and evaluation purposes - https://phabricator.wikimedia.org/T144592#2604707 (10hoo) a:05Lucie>03None [12:47:32] (03CR) 10Mobrovac: "Deployed, the new topics have been created in both eqiad and codfw" [event-schemas] - 10https://gerrit.wikimedia.org/r/308081 (owner: 10Ppchelko) [12:55:58] (03PS63) 10Paladox: Add support for svg with png fallback for wgLogo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [12:56:45] (03CR) 10Paladox: "@Legoktm done, it may not be the way you wanted it to, but it is now merged into wgLogo, and the examples on how to use it are in the comm" [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox) [12:57:19] 07Design, 10MobileFrontend, 03Reading-Web-Sprint-80-V-for-Vandalism: [SUBTASK] Beta footer appears obscured on diff pages - https://phabricator.wikimedia.org/T144579#2604717 (10Issimo_15) Also, as you can see here in this screenshot, a part of the editor took the footer's color. {F4426063} [12:59:20] (03PS64) 10Paladox: Add support for svg with png fallback for wgLogo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [13:02:02] 10MediaWiki-Uploading, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604719 (10Pokefan95) [13:02:20] 10MediaWiki-Uploading, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604732 (10Pokefan95) p:05Triage>03Low [13:04:20] 10MediaWiki-Interface, 13Patch-For-Review: Allow SVG for wiki-logo - https://phabricator.wikimedia.org/T86229#2604737 (10Paladox) @Dvorapa hi, it is almost ready, need @legoktm to take another look at the patch I just updated now and if he says it is ok, it can then be merged :) [13:04:51] (03CR) 10jenkins-bot: [V: 04-1] Add support for svg with png fallback for wgLogo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox) [13:06:59] (03PS65) 10Paladox: Add support for svg with png fallback for wgLogo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [13:07:38] (03CR) 10Bartosz Dziewoński: "> Also Echo appends itself to the 'li' which is why I specified the 'a' as well. Are there any situations where a non-link is used in the " [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/306856 (owner: 10Esanders) [13:08:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Simple search suggestions box appears over Wikidata suggestions if search box is selected early - https://phabricator.wikimedia.org/T119492#2604740 (10Sjoerddebruin) Any status on this? Hugh annoyance. [13:09:13] 10MediaWiki-Codesniffer: Update squizlabs/PHP_CodeSniffer to 3.x - https://phabricator.wikimedia.org/T142474#2604741 (10Paladox) 3.0.0rc1 has been release now, getting closer to stable release https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0RC1 [13:09:46] 10MediaWiki-Uploading, 06Commons, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604742 (10Pokefan95) [13:10:32] (03PS1) 10Dbrant: Unify and normalize toolbar in MainActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 [13:17:50] 10Hovercards, 10Reading-Community-Engagement, 06Reading-Web-Backlog, 06Community-Liaisons (Jul-Sep-2016): Start discussion with Italian community about running a/b test for hovercards in October - https://phabricator.wikimedia.org/T143170#2604744 (10Elitre) Ok. I'll translate and post the announcement at s... [13:17:56] 10MediaWiki-extensions-PageAssessments, 03Community-Tech-Sprint, 13Patch-For-Review: Test PageAssessements on English Wikivoyage - https://phabricator.wikimedia.org/T142056#2604745 (10Niharika) The extension works on enwikivoyage: https://en.wikivoyage.org/w/api.php?action=query&prop=pageassessments&titles=U... [13:20:29] (03CR) 10Dbrant: [C: 032] Add screenshot unit test support and diff script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/306821 (https://phabricator.wikimedia.org/T118102) (owner: 10Niedzielski) [13:21:37] (03CR) 10Robert Vogel: [C: 032] BSApiWikiSubPageTreeStore: Added I18N desc [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308129 (owner: 10Robert Vogel) [13:22:02] (03CR) 10Robert Vogel: [C: 032] BSNotifications: Removed old unused left over files [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307952 (owner: 10Pwirth) [13:22:57] (03Merged) 10jenkins-bot: Add screenshot unit test support and diff script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/306821 (https://phabricator.wikimedia.org/T118102) (owner: 10Niedzielski) [13:22:59] (03Merged) 10jenkins-bot: BSApiWikiSubPageTreeStore: Added I18N desc [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308129 (owner: 10Robert Vogel) [13:23:01] (03Merged) 10jenkins-bot: BSNotifications: Removed old unused left over files [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/307952 (owner: 10Pwirth) [13:24:44] 10MediaWiki-Uploading, 06Commons, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604719 (10Ciencia_Al_Poder) Maybe those... [13:25:23] (03CR) 10Dbrant: [C: 032] Add NavTabViewTest and initial ViewTest framework [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307031 (https://phabricator.wikimedia.org/T140019) (owner: 10Niedzielski) [13:28:03] (03Merged) 10jenkins-bot: Add NavTabViewTest and initial ViewTest framework [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307031 (https://phabricator.wikimedia.org/T140019) (owner: 10Niedzielski) [13:28:28] (03CR) 10Dbrant: [C: 032] Hygiene: remove unused constructors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308101 (owner: 10Niedzielski) [13:30:28] (03Merged) 10jenkins-bot: Hygiene: remove unused constructors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308101 (owner: 10Niedzielski) [13:31:23] (03CR) 10Dbrant: [C: 032] Hygiene: remove commented out code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308102 (owner: 10Niedzielski) [13:32:04] (03CR) 10Bmansurov: [C: 04-1] Cache logged-in "morelike" requests too (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308143 (https://phabricator.wikimedia.org/T126455) (owner: 10Phuedx) [13:33:24] 10MediaWiki-Uploading, 06Commons, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604761 (10satdeep_gill) Ciencia_Al_Pode... [13:33:59] (03Merged) 10jenkins-bot: Hygiene: remove commented out code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308102 (owner: 10Niedzielski) [13:34:48] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-80-V-for-Vandalism, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): Fatal exception in Special:Preferences when setting Minerva as the default skin - https://phabricator.wikimedia.org/T141099#2604763 (10bmansurov) Wrong action at... [13:36:58] (03CR) 10Liuxinyu970226: [C: 031] Improve page display title handling [core] - 10https://gerrit.wikimedia.org/r/305991 (https://phabricator.wikimedia.org/T43720) (owner: 10Nikerabbit) [13:38:38] 07Design, 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog: Top center related pages thumbnails - https://phabricator.wikimedia.org/T144594#2604768 (10ovasileva) [13:38:58] 07Design, 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog: Top center related pages thumbnails - https://phabricator.wikimedia.org/T144594#2604780 (10ovasileva) @Nirzar - feel free to expand description as appropriate [13:40:30] (03CR) 10Dbrant: [C: 032] Hygiene: simplify CardLargeHeaderView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308103 (owner: 10Niedzielski) [13:42:16] (03Merged) 10jenkins-bot: Hygiene: simplify CardLargeHeaderView [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308103 (owner: 10Niedzielski) [13:43:01] (03PS1) 10DCausse: Fix integer overflow when counting the number of clauses [search/extra] - 10https://gerrit.wikimedia.org/r/308163 [13:43:21] 10MediaWiki-Revision-deletion: Feature Request: request search engines to update caches of pages with rev deleted content - https://phabricator.wikimedia.org/T144559#2603541 (10Krenair) It's not an exploit - as soon as a revision is saved, it's public, anyone can download it and republish it. What revision delet... [13:45:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-09-13: [Bug] Simple search suggestions box appears over Wikidata suggestions if search box is selected early - https://phabricator.wikimedia.org/T119492#2604825 (10thiemowmde) p:05Low>03High [13:45:12] 10MediaWiki-Uploading, 06Commons, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604719 (10matmarex) File extensions are... [13:45:30] (03CR) 10Dbrant: [C: 032] Update ViewTest to include system font size [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308104 (owner: 10Niedzielski) [13:47:21] (03PS1) 10Aaron Schulz: Convert Revision::fetchFromConds() to using more modern selectRow() [core] - 10https://gerrit.wikimedia.org/r/308164 [13:48:05] (03Merged) 10jenkins-bot: Update ViewTest to include system font size [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308104 (owner: 10Niedzielski) [13:50:34] (03CR) 10Dbrant: [C: 032] "fabulous." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308105 (https://phabricator.wikimedia.org/T144401) (owner: 10Niedzielski) [13:51:10] 10MediaWiki-Uploading, 06Commons, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2604853 (10Ciencia_Al_Poder) Fair enough... [13:51:38] 10MediaWiki-extensions-LdapAuthentication: Unable to synchronize LDAP groups with spaces - https://phabricator.wikimedia.org/T58425#2604855 (10HermannSchwaerzler) [13:51:41] 10MediaWiki-extensions-LdapAuthentication, 13Patch-For-Review: $wgLDAPUseLDAPGroups produces MediaWiki groups with invalid whitespace in names - https://phabricator.wikimedia.org/T87376#2604858 (10HermannSchwaerzler) [13:53:02] (03Merged) 10jenkins-bot: Add CardLargeHeaderViewTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308105 (https://phabricator.wikimedia.org/T144401) (owner: 10Niedzielski) [13:53:13] (03CR) 10jenkins-bot: [V: 04-1] Convert Revision::fetchFromConds() to using more modern selectRow() [core] - 10https://gerrit.wikimedia.org/r/308164 (owner: 10Aaron Schulz) [13:53:44] (03PS4) 10Dbrant: Rip out MainActivity, et al. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307819 (https://phabricator.wikimedia.org/T143441) [14:01:29] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2604880 (10MaxBioHazard) [14:01:51] (03CR) 10Hashar: "Paladox can you please STOP adding me as a reviewer to this change? I have no idea what that code path is doing." [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox) [14:05:37] (03PS1) 10Bartosz Dziewoński: SpecialGlobalGroupPermissions: Parse wikitext in 'right-*' messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/308167 [14:09:54] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: Regression: Maintenance/importDump.php is 20 times slower than before - https://phabricator.wikimedia.org/T144600#2604904 (10Tvoigt2) [14:10:26] 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: CirrusSearch: Support pausing writes to Elasticsearch - https://phabricator.wikimedia.org/T99244#2604918 (10debt) [14:10:45] 06Discovery, 07Epic: [EPIC] Elastic search service takes many hours to restart - https://phabricator.wikimedia.org/T102159#2604921 (10debt) [14:10:47] 06Discovery, 06Discovery-Search (Current work), 13Patch-For-Review: CirrusSearch: Support pausing writes to Elasticsearch - https://phabricator.wikimedia.org/T99244#1287956 (10debt) 05Resolved>03Open [14:12:06] 10MediaWiki-Authentication-and-authorization, 06Reading-Infrastructure-Team: Update Auth_remoteuser to use AuthManager - https://phabricator.wikimedia.org/T110292#1574367 (10Andreasfink) Hello. Pretty much on the same day like kwisatz i finished a rewrite of Auth_remoteuser to use the SessionProvider API. You... [14:15:55] (03PS1) 10Pwirth: [WIP] BSPageTemplates: Moved namespace activation to NamespaceManager [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/308170 [14:19:30] (03PS1) 10Aaron Schulz: Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 [14:19:39] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: Regression: Maintenance/importDump.php is 20 times slower than before - https://phabricator.wikimedia.org/T144600#2604938 (10TTO) Hmm, I really thought we'd seen the end of this issue... I'll have a look and see what can be done. Certainly if you... [14:23:50] 10Technical-Collaboration-Guideline, 06Community-Liaisons (Jul-Sep-2016): Recommendations for publishing project updates - https://phabricator.wikimedia.org/T137825#2604948 (10Trizek-WMF) [14:24:38] (03CR) 10jenkins-bot: [V: 04-1] Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 (owner: 10Aaron Schulz) [14:26:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-09-13: Add monolingual language code otk - https://phabricator.wikimedia.org/T137809#2604964 (10thiemowmde) [14:27:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-09-13: [Task] Add monolingual language code mnc - https://phabricator.wikimedia.org/T137808#2604966 (10thiemowmde) [14:27:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-09-13: [Task] Repeat the bad value in validator messages for easy error recovery - https://phabricator.wikimedia.org/T144303#2604968 (10thiemowmde) [14:27:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 03Wikidata-Sprint-2016-09-13, 07Wikimedia-log-errors: No RDF builder defined for data type time nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder - https://phabricator.wikimedia.org/T144248#2604969 (10thiemowmde) [14:28:27] (03PS2) 10Aaron Schulz: Convert Revision::fetchFromConds() to using more modern selectRow() [core] - 10https://gerrit.wikimedia.org/r/308164 [14:28:34] 10MediaWiki-Internationalization, 10MediaWiki-Page-editing, 06Community-Liaisons, 06Editing-Department, and 10 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2604974 (10thiemowmde) [14:28:40] (03PS5) 10Dbrant: Rip out MainActivity, et al. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307819 (https://phabricator.wikimedia.org/T143441) [14:29:56] (03CR) 10Sbisson: "This change broke Flow board categories." [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [14:30:25] (03PS2) 10Aaron Schulz: Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 [14:31:26] 10MediaWiki-extensions-SemanticForms: Fix default value for field tag, for existing and new pages. - https://phabricator.wikimedia.org/T137701#2604986 (10Yaron_Koren) Hi guys, Well, you made a lot of points - I don't know how much of it I should respond to. But let me bring up what I see as one glaring issue. I... [14:31:49] 10Wikimedia-Site-requests, 06Wiktionary: Install Translate Extension in the French Wiktionary - https://phabricator.wikimedia.org/T138972#2604987 (10Pamputt) Since it is the end of holidays for most of you, is there any chance to see this extension be installed quickly on French Wiktionary? Thanks in advance [14:35:29] (03CR) 10jenkins-bot: [V: 04-1] Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 (owner: 10Aaron Schulz) [14:35:33] (03CR) 10Dbrant: "@Niedzielski Thanks; tests should be working now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307819 (https://phabricator.wikimedia.org/T143441) (owner: 10Dbrant) [14:36:00] (03PS2) 10Dbrant: Remove "overhaul" designation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307876 (https://phabricator.wikimedia.org/T143441) [14:37:49] (03CR) 10Aaron Schulz: "Is that from flushDeferredQueue() I take it?" [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [14:38:01] (03CR) 10jenkins-bot: [V: 04-1] Remove "overhaul" designation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307876 (https://phabricator.wikimedia.org/T143441) (owner: 10Dbrant) [14:40:59] (03PS3) 10Dbrant: Remove "overhaul" designation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307876 (https://phabricator.wikimedia.org/T143441) [14:42:16] (03PS3) 10Aaron Schulz: Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 [14:43:15] (03PS3) 10Dbrant: Whoops: Fix showing of Explore overflow menu on all API versions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307888 [14:43:37] (03PS1) 10Robert Vogel: [WIP] Work work [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/308180 [14:43:39] 10Hovercards, 06Reading-analysis: Estimate how much of the Hovercards-caused pageview decrease comes from reduced usage of the back button - https://phabricator.wikimedia.org/T144603#2605010 (10Tbayer) [14:44:34] 06Research-and-Data, 10Research-outreach: Research showcase September 2016 - https://phabricator.wikimedia.org/T142145#2605026 (10DarTar) [14:47:02] (03CR) 10jenkins-bot: [V: 04-1] Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 (owner: 10Aaron Schulz) [14:47:03] 10MediaWiki-Uploading, 06Commons, 06Multimedia: Change the file extension of a file to the most commonly used extension in the time of uploading (like .JPG to .jpg for images, .ogg to .oga for audios, .ogg to ogv for videos) - https://phabricator.wikimedia.org/T144593#2605030 (10matmarex) I'm pretty sure thi... [14:48:49] (03PS2) 10Dbrant: Unify and normalize toolbar in MainActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 [14:50:05] (03CR) 10Sbisson: "Flow calls DataUpdate::runUpdates( $updates ); (which is deprecated)" [core] - 10https://gerrit.wikimedia.org/r/308011 (owner: 10Aaron Schulz) [14:54:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Need-volunteer, 13Patch-For-Review, 03Wikidata-Sprint-2016-08-30: Small feature request: recognize bracketed IDs as valid IDs - https://phabricator.wikimedia.org/T117763#1782879 (10thiemowmde) a:03thiemowmde [15:03:01] (03CR) 10Niedzielski: [C: 032] Rip out MainActivity, et al. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307819 (https://phabricator.wikimedia.org/T143441) (owner: 10Dbrant) [15:04:18] 07Design, 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog: Improve Related pages thumbnails positioning - https://phabricator.wikimedia.org/T144594#2605046 (10Nirzar) [15:05:29] (03Merged) 10jenkins-bot: Rip out MainActivity, et al. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307819 (https://phabricator.wikimedia.org/T143441) (owner: 10Dbrant) [15:06:33] (03CR) 10Niedzielski: [C: 032] Remove "overhaul" designation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307876 (https://phabricator.wikimedia.org/T143441) (owner: 10Dbrant) [15:08:59] (03Merged) 10jenkins-bot: Remove "overhaul" designation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307876 (https://phabricator.wikimedia.org/T143441) (owner: 10Dbrant) [15:12:36] 10Data-release, 06Research-and-Data: Get Analytics to create an open data registry entry for PVs and UCs - https://phabricator.wikimedia.org/T144604#2605058 (10DarTar) [15:12:42] (03PS4) 10Aaron Schulz: Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 [15:18:00] 07Design, 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1800243 (10mobrovac) >>! In T104479#2603646, @Esanders wrote: > I updated the parsoid config yaml to the new format, then vagrant git-updated everything Not sure what yo... [15:18:18] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: Regression: Maintenance/importDump.php is 20 times slower than before - https://phabricator.wikimedia.org/T144600#2605076 (10Tvoigt2) > Certainly if you want a quick fix you can just remove this code from your installations, as it is really meant f... [15:18:43] (03PS1) 10Sbisson: Fix category update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308184 [15:21:07] 06Discovery-Search (Current work), 07Epic: Initial BM25 A/B Test - https://phabricator.wikimedia.org/T143585#2605079 (10EBernhardson) Pulled some more specific numbers from hive. ``` select backendusertests[0], percentile(cast(tookms as int), 0.5), percentile(cast(tookms as int), 0.75),... [15:31:21] (03CR) 10Aaron Schulz: [C: 032] Fix category update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308184 (owner: 10Sbisson) [15:31:24] (03CR) 10Anomie: "The problem with trying to define an actual swagger spec is that swagger doesn't seem to be able to handle the action API's concept. It se" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/307913 (https://phabricator.wikimedia.org/T136839) (owner: 10Legoktm) [15:31:27] 10MediaWiki-Internationalization, 10MediaWiki-Page-editing, 07Epic, 07Upstream: Vertical writing support in MediaWiki - https://phabricator.wikimedia.org/T11436#2605100 (10Liuxinyu970226) What about editing interface, i.e. both [[ https://incubator.wikimedia.org/w/index.php?title=Wp/ase/AS14720S19220S1dc20... [15:32:01] (03PS2) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 [15:32:53] 'ello, I'm trying to start using Python to make a bot. Right now I'm just testing out the basics. How would one change it that instead of replacing the text in a page it adds it? [15:33:02] https://thepb.in/p/Elh18vzBYWWIm [15:33:23] (03PS3) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 [15:35:11] 06Wikipedia-Android-App-Backlog: [BUG] Because you read icon should be centered on clock face - https://phabricator.wikimedia.org/T144606#2605104 (10Niedzielski) [15:36:18] 10Data-release, 06Research-and-Data: Visualization of Wikimedia traffic by language, country and region - https://phabricator.wikimedia.org/T144607#2605119 (10DarTar) [15:36:29] (03PS1) 10Aaron Schulz: Remove spammy reuseConnection() wfDebug() call [core] - 10https://gerrit.wikimedia.org/r/308185 [15:38:10] 10MediaWiki-Authentication-and-authorization, 06Reading-Infrastructure-Team: Update Auth_remoteuser to use AuthManager - https://phabricator.wikimedia.org/T110292#1574367 (10Fstarnaud) Thanks Andreasfink! You could not have provided this at a better time. I was struggling with this yesterday and your code solv... [15:38:28] (03CR) 10jenkins-bot: [V: 04-1] Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 (owner: 10Aaron Schulz) [15:39:16] (03Merged) 10jenkins-bot: Fix category update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308184 (owner: 10Sbisson) [15:44:15] (03PS4) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 [15:48:25] (03PS1) 10Chad: Add EditOwn extension [extensions] - 10https://gerrit.wikimedia.org/r/308186 [15:48:40] (03CR) 10Chad: [C: 032 V: 032] Add EditOwn extension [extensions] - 10https://gerrit.wikimedia.org/r/308186 (owner: 10Chad) [15:52:07] (03PS1) 10Chad: Initial import of EditOwn extension [extensions/EditOwn] - 10https://gerrit.wikimedia.org/r/308187 [15:52:38] (03CR) 10Chad: [C: 032 V: 032] Initial import of EditOwn extension [extensions/EditOwn] - 10https://gerrit.wikimedia.org/r/308187 (owner: 10Chad) [15:53:14] ostriches: https://gerrit.wikimedia.org/r/#/c/307078/ [15:58:59] (03CR) 10Niedzielski: [C: 04-1] "App is looking really nice." (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant) [15:59:03] 10MediaWiki-Parser: Line breaks may be inserted in preformatted text in tables - https://phabricator.wikimedia.org/T144585#2605159 (10Aklapper) p:05Triage>03Low [16:04:54] 10MediaWiki-Internationalization: "MediaWiki:Emailuser" and "MediaWiki:Userrights" should support {{GENDER}} - https://phabricator.wikimedia.org/T142316#2605194 (10Liuxinyu970226) > But a lot of languages use different forms for "user" according to the gender. Huh? I looked https://translatewiki.net/w/i.php?titl... [16:09:49] (03CR) 10Paladox: "Nope I see in the error log there are some errors." [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox) [16:10:53] (03PS1) 10Chad: Add ChangeAuthor extension [extensions] - 10https://gerrit.wikimedia.org/r/308190 [16:11:01] (03CR) 10Chad: [C: 032 V: 032] Add ChangeAuthor extension [extensions] - 10https://gerrit.wikimedia.org/r/308190 (owner: 10Chad) [16:12:57] 07Design, 06Reading-Web-Backlog, 10Hovercards (2016-Q2-Goal): Hovercards: Fix the length of the extract, and add ellipses - https://phabricator.wikimedia.org/T67845#2605226 (10dr0ptp4kt) a:05dr0ptp4kt>03None [16:15:02] (03PS1) 10Chad: Initial import, from Subversion [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/308192 [16:15:14] (03CR) 10Chad: [C: 032 V: 032] Initial import, from Subversion [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/308192 (owner: 10Chad) [16:22:56] 10MediaWiki-extensions-CheckUser, 13Patch-For-Review: Drop legacy installer script from CheckUser extension (update.php hooks should already exist) - https://phabricator.wikimedia.org/T29431#2605243 (10Glaisher) Open patches that need reviewing (in dependent order): * https://gerrit.wikimedia.org/r/#/c/307141/... [16:23:59] (03PS2) 10Glaisher: Cleanup CheckUser setup and remove old files [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/307336 (https://phabricator.wikimedia.org/T29431) [16:25:26] 06Reading-Web-Backlog, 10Hovercards (2016-Q2-Goal): Add support for RESTBase endpoint consumption - https://phabricator.wikimedia.org/T123445#2605250 (10dr0ptp4kt) [16:25:28] (03PS3) 10Dbrant: Unify and normalize toolbar in MainActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 [16:25:53] 06Reading-Web-Backlog, 10Hovercards (2016-Q2-Goal): Add support for RESTBase endpoint consumption - https://phabricator.wikimedia.org/T123445#1930004 (10dr0ptp4kt) [16:27:05] 10PageImages, 06Reading-Web-Backlog: Pageimages returns both free and non-free images with 'free-ness' denoted as a property - https://phabricator.wikimedia.org/T131105#2605271 (10JKatzWMF) [16:30:21] (03CR) 10Dbrant: Unify and normalize toolbar in MainActivity. (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant) [16:35:57] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615#2605284 (10AndyRussG) [16:37:35] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice banner sequence: unit tests - https://phabricator.wikimedia.org/T144456#2605299 (10AndyRussG) [16:37:37] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#2605300 (10AndyRussG) [16:37:40] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking: CentralNotice banner sequence: implement feature for MVP - https://phabricator.wikimedia.org/T144453#2605301 (10AndyRussG) [16:37:43] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking: CentralNotice banner sequence: more precise, new UI mock-up - https://phabricator.wikimedia.org/T144452#2605302 (10AndyRussG) [16:37:46] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2605303 (10AndyRussG) [16:37:49] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615#2605298 (10AndyRussG) [16:37:52] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Spike, 07Technical-Debt: [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation? - https://phabricator.wikimedia.org/T143334#2605304 (10phuedx) > Remove. We can close T143337 and work on... [16:39:11] (03CR) 10Chad: [C: 032] Make insertSelect() do two separate queries in non-CLI mode [core] - 10https://gerrit.wikimedia.org/r/307078 (owner: 10Aaron Schulz) [16:39:22] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2297497 (10AndyRussG) Here are the notes we have for an MVP. I don't know if we should leave this task open until we finalize details of a more usa... [16:40:53] (03CR) 10Anomie: [C: 031] "Looks good at first read-through, haven't tested yet (remind me to if this seems to be languishing)." [core] - 10https://gerrit.wikimedia.org/r/307017 (https://phabricator.wikimedia.org/T143967) (owner: 10Legoktm) [16:43:08] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2605320 (10JEumerus) editcss, editjs and editinterface are sensitive permissions. Was this aspect discussed and is it really a good idea to have usergroups encompassing these permissions being assigned by a... [16:43:40] (03CR) 10Phuedx: Cache logged-in "morelike" requests too (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308143 (https://phabricator.wikimedia.org/T126455) (owner: 10Phuedx) [16:43:59] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking, 07Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2605321 (10DStrine) [16:44:13] 06Reading-Web-Backlog, 10Hovercards (2016-Q2-Goal): Add support for RESTBase endpoint consumption - https://phabricator.wikimedia.org/T123445#2605322 (10GWicke) > The RESTbase endpoint response needs to support appropriate image free / fair use considerations, taking into consideration on-wiki, from-app, and a... [16:44:36] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking, 07Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2297497 (10DStrine) This is fine to resolve. Thanks for working through this! [16:44:43] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 07Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615#2605325 (10DStrine) [16:44:46] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking, 07Spike: Spike: how to implement banner sequence feature - https://phabricator.wikimedia.org/T135398#2605324 (10DStrine) 05Open>03Resolved [16:45:06] ostriches: one easy s&r https://gerrit.wikimedia.org/r/#/c/308127/ [16:46:00] (03CR) 10Aaron Schulz: Replace DataUpdate::doUpdates() callers in maintenance/ (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308127 (owner: 10Aaron Schulz) [16:47:59] (03CR) 10jenkins-bot: [V: 04-1] Make insertSelect() do two separate queries in non-CLI mode [core] - 10https://gerrit.wikimedia.org/r/307078 (owner: 10Aaron Schulz) [16:49:41] (03CR) 10Chad: [C: 032] Replace DataUpdate::doUpdates() callers in maintenance/ [core] - 10https://gerrit.wikimedia.org/r/308127 (owner: 10Aaron Schulz) [16:50:38] (03PS2) 10Phuedx: Cache logged-in "morelike" requests too [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308143 (https://phabricator.wikimedia.org/T126455) [16:50:48] (03PS1) 10Fomafix: Rename CSS files for printing to a consistent file name [core] - 10https://gerrit.wikimedia.org/r/308193 [16:51:09] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/307078 (owner: 10Aaron Schulz) [16:51:39] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Align elements in article footer on beta - https://phabricator.wikimedia.org/T141002#2605329 (10MBinder_WMF) @ovasileva added [16:51:59] 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-80-V-for-Vandalism, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Request cached copy of machine generated Related Articles - https://phabricator.wikimedia.org/T126455#2014850 (10phuedx) Thanks for the ques... [16:52:38] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Spike, 07Technical-Debt: [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation? - https://phabricator.wikimedia.org/T143334#2605332 (10phuedx) @Jdlrobson, @Jhernandez, @jhobs: It'd be g... [16:53:04] (03PS1) 10Jack Phoenix: Version 1.1: extension registration support, PHP entry point removed; MW 1.25+ is required [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/308194 [16:54:12] (03CR) 10Niedzielski: [C: 04-1] Unify and normalize toolbar in MainActivity. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant) [16:54:24] (03CR) 10Jack Phoenix: [C: 032] Version 1.1: extension registration support, PHP entry point removed; MW 1.25+ is required [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/308194 (owner: 10Jack Phoenix) [16:54:28] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Footer broken in beta on diff views - https://phabricator.wikimedia.org/T144617#2605337 (10Jdlrobson) [16:56:03] 07Design, 10MobileFrontend, 03Reading-Web-Sprint-80-V-for-Vandalism: [SUBTASK] Beta footer appears obscured on diff pages - https://phabricator.wikimedia.org/T144579#2605365 (10Jdlrobson) [16:56:05] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): Footer broken in beta on diff views - https://phabricator.wikimedia.org/T144617#2605337 (10Jdlrobson) [16:56:20] (03Merged) 10jenkins-bot: Replace DataUpdate::doUpdates() callers in maintenance/ [core] - 10https://gerrit.wikimedia.org/r/308127 (owner: 10Aaron Schulz) [16:56:23] (03Merged) 10jenkins-bot: Version 1.1: extension registration support, PHP entry point removed; MW 1.25+ is required [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/308194 (owner: 10Jack Phoenix) [16:56:56] 06Wikipedia-Android-App-Backlog, 10Wikipedia-App-General-or-Unknown: Wikipedia App does not handle Shortened footnotes created using Sfn - https://phabricator.wikimedia.org/T144619#2605368 (10Kaartic) [16:57:42] 07Design, 10MobileFrontend, 03Reading-Web-Sprint-80-V-for-Vandalism: [SUBTASK] Beta footer appears obscured on diff pages - https://phabricator.wikimedia.org/T144579#2604326 (10Jdlrobson) @nirzar how do you want to deal with this? We have lots of custom styling on special pages and it would be great to unify... [16:57:45] (03PS66) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [16:58:07] (03PS1) 10Aaron Schulz: Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 [16:58:58] (03CR) 10Aaron Schulz: [C: 032] Make insertSelect() do two separate queries in non-CLI mode [core] - 10https://gerrit.wikimedia.org/r/307078 (owner: 10Aaron Schulz) [16:59:04] (03CR) 10Mattflaschen: Add server-side MessagePoster (037 comments) [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [16:59:45] (03CR) 10Paladox: "@Legoktm I kind of went back to the patch when you did -1, but there are changes now, it now does" [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox) [16:59:57] (03CR) 10Paladox: "All errors are gone now." [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox) [17:00:46] (03PS6) 10Mattflaschen: Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) [17:01:10] 10MediaWiki-extensions-SemanticForms: Undefined JS variable - https://phabricator.wikimedia.org/T144620#2605384 (10Seb35) [17:03:50] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2604880 (10Urbanecm) Past requests about adding sensitive permissions like editinterface by sysops has been declined, see T85713 and https://phabricator.wikimedia.org/T133472#2234186 for reference. [17:04:23] (03PS1) 10Ppchelko: Remove deprecated schemas [event-schemas] - 10https://gerrit.wikimedia.org/r/308196 [17:05:19] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2605404 (10Urbanecm) p:05Triage>03Low Low: Until we fully discuss the security problem this is low priority I think because //The change isn't needed before two weeks.// I think we'll get into it by two... [17:06:00] 10MediaWiki-extensions-SemanticForms: Undefined JS variable - https://phabricator.wikimedia.org/T144620#2605407 (10Seb35) I fixed the bug by declaring `var sfgShowOnSelect = mw.config.get( 'sfgShowOnSelect' );` in libs/SF_SemanticForms.js in function $.fn.setDependentAutocompletion. Then I checked if there were... [17:06:20] 10MediaWiki-extensions-SemanticForms: Undefined JS variable - https://phabricator.wikimedia.org/T144620#2605409 (10Seb35) p:05Triage>03Lowest [17:06:33] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2605410 (10Urbanecm) As ruwiki has 'crats I really recommend you to grant this group by sysops. [17:06:54] (03PS4) 10Ejegg: DonationInterface settings for running under the CRM [vagrant] - 10https://gerrit.wikimedia.org/r/306564 (https://phabricator.wikimedia.org/T141487) (owner: 10Awight) [17:06:57] 10MediaWiki-extensions-SemanticForms, 07JavaScript, 07Technical-Debt: Undefined JS variable - https://phabricator.wikimedia.org/T144620#2605384 (10Seb35) [17:06:59] (03CR) 10jenkins-bot: [V: 04-1] Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 (owner: 10Aaron Schulz) [17:07:11] (03CR) 10Ejegg: [C: 032] "Looks good!" [vagrant] - 10https://gerrit.wikimedia.org/r/306564 (https://phabricator.wikimedia.org/T141487) (owner: 10Awight) [17:08:39] (03Merged) 10jenkins-bot: Make insertSelect() do two separate queries in non-CLI mode [core] - 10https://gerrit.wikimedia.org/r/307078 (owner: 10Aaron Schulz) [17:08:42] (03Merged) 10jenkins-bot: DonationInterface settings for running under the CRM [vagrant] - 10https://gerrit.wikimedia.org/r/306564 (https://phabricator.wikimedia.org/T141487) (owner: 10Awight) [17:08:44] (03PS67) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) [17:09:35] (03CR) 10jenkins-bot: [V: 04-1] Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen) [17:09:55] stephanebisson: doConversion() runs in web requests, presend, and does wfWaitForSlaves() without clearing the repeatable-read snapshots. [17:10:15] not related probably, but that looks quite wrong [17:11:21] AaronSchulz: I'm in a meeting. I'll look at it in a few minutes. [17:11:28] (03PS1) 10Chad: Pass context user to UploadStash rather than relying on $wgUser [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/308197 [17:11:43] ostriches: ew MultiUpload [17:12:14] I was trying to be polite before I break the interface in core :p [17:12:20] But I can just break it! [17:12:32] it needs either a new maintainer or then it needs to die in a fire. I'm not sure which one (but I think I'll just side with the "kill it with fire" crowd) [17:12:49] mind you, I think that core should implement such a feature to allow multiple files to be uploaded at once [17:12:58] that way some other poor soul would have to maintain it! [17:13:22] (anyway MultiUpload is broken under 1.27 and it's been broken by design for a long time, yet it has somewhat worked under 1.26? I don't even...) [17:13:40] (03PS1) 10Chad: Pass this $wgUser to UploadStash than relying on core's $wgUser [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308198 [17:14:01] ashley: Oh well, I did my due diligence :p [17:14:11] (03CR) 10Chad: [C: 032] Pass context user to UploadStash rather than relying on $wgUser [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/308197 (owner: 10Chad) [17:14:31] heh [17:14:32] (03PS4) 10Dbrant: Unify and normalize toolbar in MainActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 [17:14:37] (03Merged) 10jenkins-bot: Pass context user to UploadStash rather than relying on $wgUser [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/308197 (owner: 10Chad) [17:14:53] https://www.mediawiki.org/wiki/Extension_talk:MultiUpload [17:15:13] I most certainly appreciate the effort :) you just can't know beforehand which extensions are usable and which ones are just a glorious mess [17:15:45] (03CR) 10Mooeypoo: [C: 032] "This is awesome, thanks!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 (owner: 10Esanders) [17:15:46] At least you can't blame me for breaking it further! ;-) [17:15:56] (03CR) 10Chad: [C: 032] Pass this $wgUser to UploadStash than relying on core's $wgUser [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308198 (owner: 10Chad) [17:16:43] (03PS1) 10Chad: Let a few unit tests actually be unit tests [core] - 10https://gerrit.wikimedia.org/r/308200 [17:18:04] MultiUpload is an interesting beast in the sense that it's a feature which many people -- dare I say "average users" -- want, yet it always keeps breaking and it just doesn't have a maintainer, even though it should be a lot simpler to maintain than, say, some of the social tools that I maintain [17:21:36] (03CR) 10Dbrant: Unify and normalize toolbar in MainActivity. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant) [17:21:37] I guess because it's trying to override logic from Special:Upload instead of star a new special page from scratch [17:21:43] *start [17:22:01] (03Merged) 10jenkins-bot: Fix notification page width responsiveness issues [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308113 (owner: 10Esanders) [17:22:04] (03Merged) 10jenkins-bot: Pass this $wgUser to UploadStash than relying on core's $wgUser [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/308198 (owner: 10Chad) [17:22:42] note there's a SpecialUpload.1.21.3.php file on the repo? xD that's hilarious [17:24:40] (03PS1) 10Aaron Schulz: Add wfWarn() to deferred updates failures [core] - 10https://gerrit.wikimedia.org/r/308202 [17:24:47] 10MediaWiki-extensions-DonationInterface, 10FR-Paypal, 10Fundraising-Backlog, 03Fundraising Sprint Qwerty Thwacking, 13Patch-For-Review: PayPal's payments-init messages are inaccurate - https://phabricator.wikimedia.org/T144562#2605452 (10Ejegg) [17:25:27] (03PS4) 10Ejegg: Repeat some more DonationInterface defaults [vagrant] - 10https://gerrit.wikimedia.org/r/306847 (owner: 10Awight) [17:25:39] (03CR) 10Ejegg: [C: 032] Repeat some more DonationInterface defaults [vagrant] - 10https://gerrit.wikimedia.org/r/306847 (owner: 10Awight) [17:25:49] (03Merged) 10jenkins-bot: Repeat some more DonationInterface defaults [vagrant] - 10https://gerrit.wikimedia.org/r/306847 (owner: 10Awight) [17:26:28] AaronSchulz: When you have a minute. [17:26:37] (03CR) 10Niedzielski: [C: 031] Unify and normalize toolbar in MainActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant) [17:26:39] I do [17:26:42] AaronSchulz: What do you mean by "without clearing the repeatable-read snapshots"? [17:27:16] (03CR) 10Niedzielski: "Added bearND and mdholloway manually since they were left off for some reason." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant) [17:27:20] as in committing the transaction before doing more reads. You can't do that though, since it runs in the main MW transaction round. [17:27:31] do you know why that wfWaitForSlaves() call was added for? [17:28:21] (03PS1) 10Jack Phoenix: [SECURITY] Version 3.3: add CSRF protection into the API module [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/308203 [17:28:28] AaronSchulz: "to wait for the slaves to pick up the move" according to the comment but I don't know if it's true or even make sense [17:28:45] (03CR) 10Jack Phoenix: [C: 032 V: 032] [SECURITY] Version 3.3: add CSRF protection into the API module [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/308203 (owner: 10Jack Phoenix) [17:29:17] AaronSchulz: you said it does a PRESEND also? is it somewhere inside the page move? [17:29:43] (03PS1) 10Jack Phoenix: Various updates to account for the recent UserStatus changes as well as some other stuff [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/308204 (https://phabricator.wikimedia.org/T135283) [17:30:17] 10MediaWiki-Parser, 10MediaWiki-Unit-tests, 10Architecture, 10Parsoid, 07RfC: [RFC]: Split parser tests info multiple files - https://phabricator.wikimedia.org/T111604#2605464 (10RobLa-WMF) [17:30:22] (03PS1) 10Chad: Clean up user handling in UploadStash [core] - 10https://gerrit.wikimedia.org/r/308205 [17:30:36] (03CR) 10jenkins-bot: [V: 04-1] Add wfWarn() to deferred updates failures [core] - 10https://gerrit.wikimedia.org/r/308202 (owner: 10Aaron Schulz) [17:30:51] 10TPG-2017Q1-Roll-Out-Engagement-Survey, 06Team-Practices (This-Week): Report on Light Engagement survey pilot, round 1 - https://phabricator.wikimedia.org/T141136#2488271 (10ggellerman) a:03ggellerman [17:31:04] (03CR) 10Jack Phoenix: [C: 032] Various updates to account for the recent UserStatus changes as well as some other stuff [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/308204 (https://phabricator.wikimedia.org/T135283) (owner: 10Jack Phoenix) [17:31:09] 10TPG-2017Q1-Roll-Out-Engagement-Survey, 06Team-Practices (This-Week): Refine the Light Engagement survey based on pilot results - https://phabricator.wikimedia.org/T141139#2488343 (10ggellerman) a:03ksmith [17:31:12] (03CR) 10DCausse: [C: 032] Add script to compare cluster document existence [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/308056 (owner: 10EBernhardson) [17:31:38] (03CR) 10Chad: "Actually, I disagree that Autoloader should know about those files, it's a mixing of contexts." [core] - 10https://gerrit.wikimedia.org/r/304956 (owner: 10Chad) [17:32:05] (03Merged) 10jenkins-bot: Various updates to account for the recent UserStatus changes as well as some other stuff [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/308204 (https://phabricator.wikimedia.org/T135283) (owner: 10Jack Phoenix) [17:33:27] (03CR) 10Aaron Schulz: [C: 032] Let a few unit tests actually be unit tests [core] - 10https://gerrit.wikimedia.org/r/308200 (owner: 10Chad) [17:36:05] (03PS1) 10Harej: [WIP] Bypassing permissions check upon CollaborationHub creation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308206 [17:36:50] stephanebisson: let me make a patch for you to test [17:37:02] AaronSchulz: sure [17:38:01] 06WMF-Legal, 05ContentTranslation-Release10, 05Language-Engineering July-September 2016: Please disable CX until drafts aren't completely private - https://phabricator.wikimedia.org/T141576#2605473 (10Slaporte) Hi all, I wanted to follow up with a more thorough response from the Wikimedia Legal department.... [17:38:09] (03Merged) 10jenkins-bot: Add script to compare cluster document existence [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/308056 (owner: 10EBernhardson) [17:39:45] (03PS1) 10Jack Phoenix: Remove PHP entry point in favor of extension.json; MW 1.25+ is now explicitly required [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/308207 [17:40:33] (03Merged) 10jenkins-bot: Let a few unit tests actually be unit tests [core] - 10https://gerrit.wikimedia.org/r/308200 (owner: 10Chad) [17:40:36] (03CR) 10Aaron Schulz: Clean up user handling in UploadStash (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308205 (owner: 10Chad) [17:40:56] (03PS2) 10Chad: Clean up user handling in UploadStash [core] - 10https://gerrit.wikimedia.org/r/308205 [17:41:01] (03CR) 10Aaron Schulz: [C: 032] Clean up user handling in UploadStash [core] - 10https://gerrit.wikimedia.org/r/308205 (owner: 10Chad) [17:41:21] (03CR) 10Jack Phoenix: [C: 032] Remove PHP entry point in favor of extension.json; MW 1.25+ is now explicitly required [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/308207 (owner: 10Jack Phoenix) [17:45:01] (03PS4) 10Bmansurov: Use mw.viewport to check when to load related pages [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs) [17:45:40] 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Technical-Debt: Trigger loading related pages using isElementCloseToViewport to avoid visible lag - https://phabricator.wikimedia.org/T135607#2605476 (10bmansurov) a:05jhobs>03... [17:46:43] 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Technical-Debt: Trigger loading related pages using isElementCloseToViewport to avoid visible lag - https://phabricator.wikimedia.org/T135607#2605480 (10bmansurov) Please review h... [17:48:29] (03Merged) 10jenkins-bot: Clean up user handling in UploadStash [core] - 10https://gerrit.wikimedia.org/r/308205 (owner: 10Chad) [17:48:32] (03Merged) 10jenkins-bot: Remove PHP entry point in favor of extension.json; MW 1.25+ is now explicitly required [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/308207 (owner: 10Jack Phoenix) [17:49:43] (03PS1) 10Chad: EditPage: Stop using $wgUser [core] - 10https://gerrit.wikimedia.org/r/308208 [17:50:32] (03PS1) 10Ottomata: Remove rev_by_bot field [event-schemas] - 10https://gerrit.wikimedia.org/r/308209 [17:51:21] (03CR) 10BearND: [C: 032] "Nice. This works now. Tested with the follow-up patch I549c790656862b56bd8efe7e2c0ba4b934ac4423" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307888 (owner: 10Dbrant) [17:52:28] (03PS7) 10Mooeypoo: Add EventLogging for Special:RecentChanges filter usage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/308091 (https://phabricator.wikimedia.org/T144331) [17:53:31] (03CR) 10Chad: [C: 032] Remove spammy reuseConnection() wfDebug() call [core] - 10https://gerrit.wikimedia.org/r/308185 (owner: 10Aaron Schulz) [17:53:55] (03Merged) 10jenkins-bot: Whoops: Fix showing of Explore overflow menu on all API versions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/307888 (owner: 10Dbrant) [17:56:23] (03CR) 10Ppchelko: [C: 032 V: 032] Remove rev_by_bot field [event-schemas] - 10https://gerrit.wikimedia.org/r/308209 (owner: 10Ottomata) [17:56:40] 10MediaWiki-Internationalization, 10MediaWiki-Page-editing, 07Epic, 07Upstream: Vertical writing support in MediaWiki - https://phabricator.wikimedia.org/T11436#2605493 (10Jdforrester-WMF) >>! In T11436#2605100, @Liuxinyu970226 wrote: > What about editing interface It looks like the gadget they've written... [17:57:03] (03CR) 10Ppchelko: "Don't forget to remove is from the extension before deploying this" [event-schemas] - 10https://gerrit.wikimedia.org/r/308209 (owner: 10Ottomata) [17:57:44] stephanebisson: what happens if the archive title is already there? can import still process via the GUI? [17:58:30] 06Reading-Web-Backlog, 10Hovercards (2016-Q2-Goal): Add support for RESTBase endpoint consumption - https://phabricator.wikimedia.org/T123445#2605497 (10dr0ptp4kt) > I remember there was a discussion about excluding problematic images from selection as a pageimage. RB just uses that information from the action... [18:00:27] (03Merged) 10jenkins-bot: Remove spammy reuseConnection() wfDebug() call [core] - 10https://gerrit.wikimedia.org/r/308185 (owner: 10Aaron Schulz) [18:01:27] 10MediaWiki-General-or-Unknown, 07Need-volunteer: Automatically show content from Wikidata by ading a new MediaWiki system message at the footer of content pages - https://phabricator.wikimedia.org/T138652#2605499 (10abian) [18:02:24] AaronSchulz: There's logic to find an archive title that's available based on a pattern. So if Page1/Archive_1 is already taken it will take Page1/Archive_2. [18:04:05] (03PS5) 10Jdlrobson: Use mw.viewport to check when to load related pages [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs) [18:04:15] (03CR) 10Jdlrobson: [C: 031] "@bmansurov I made a minor modification. Are you able to +2?" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs) [18:04:24] 10MediaWiki-General-or-Unknown, 07Need-volunteer: Add a new MediaWiki system message at the footer of content pages - https://phabricator.wikimedia.org/T138652#2605501 (10abian) [18:05:54] 10TextExtracts: Add exparagraphs parameter to API - https://phabricator.wikimedia.org/T144622#2605502 (10Sophivorus) [18:07:22] (03PS1) 10Aaron Schulz: Add flushReplicaSnapshots() method for just clearing snapshots [core] - 10https://gerrit.wikimedia.org/r/308210 [18:07:44] 10TextExtracts: Add exparagraphs parameter to API - https://phabricator.wikimedia.org/T144622#2605515 (10Sophivorus) [18:07:45] (03CR) 10Bmansurov: "This change was not needed as it's unrelated to the current patch and double margin wouldn't happen because of margin collapsing." (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs) [18:07:46] stephanebisson: I mean if you try to move-import once and the move where to succeed and not the import [18:07:56] could it pick up were it left off? [18:08:44] 10TextExtracts: Add exparagraphs parameter to API - https://phabricator.wikimedia.org/T144622#2605502 (10Sophivorus) [18:09:04] (03CR) 10Legoktm: [C: 04-1] "Let's do I6541b95c1867f8ec1e0d574f162eb8a6dd928905 instead please? I don't want to have to re-do that entire series of patches again." [core] - 10https://gerrit.wikimedia.org/r/308208 (owner: 10Chad) [18:10:12] AaronSchulz: If the move were to really fail (throw exception) I think the whole thing could be retried but in this case the move seems successfully and the Flow board gets created. The second time around it would probably bail saying that the Flow board is already there [18:10:27] (03Abandoned) 10Chad: EditPage: Stop using $wgUser [core] - 10https://gerrit.wikimedia.org/r/308208 (owner: 10Chad) [18:10:33] (03PS2) 10Harej: [WIP] Bypassing permissions check upon CollaborationHub creation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308206 [18:13:29] stephanebisson: what I'm getting as it: could movePage() and createArchiveCleanupRevision() be in two transactions or does it need to be one? [18:13:40] 10MediaWiki-extensions-ZeroBanner, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, and 4 others: [Spike: 2 hours] Page actions bar not showing on Wikipedia Zero - https://phabricator.wikimedia.org/T143425#2605531 (10Jdlrobson) [18:15:45] (03PS1) 10Chad: Don't mention $wgUser, it's ugly and it messes my grep-fu [core] - 10https://gerrit.wikimedia.org/r/308212 [18:15:50] ostriches: https://gerrit.wikimedia.org/r/#/c/308210/ [18:16:07] (03CR) 10Aaron Schulz: [C: 032] Don't mention $wgUser, it's ugly and it messes my grep-fu [core] - 10https://gerrit.wikimedia.org/r/308212 (owner: 10Chad) [18:16:14] AaronSchulz: lol thx [18:16:21] grep-fu is totally a thing...I'm not just OCD [18:16:22] AaronSchulz: I guess one transaction for the whole process would be better so we wouldn't end up with an error page and the job half-done. But I don't know what are the challenges here. [18:16:32] (03CR) 10Bearloga: [V: 031] "Looks good. What do you think about these minor suggestions?" (033 comments) [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/308099 (https://phabricator.wikimedia.org/T143726) (owner: 10Chelsyx) [18:17:04] (03CR) 10Chad: [C: 032] Add flushReplicaSnapshots() method for just clearing snapshots [core] - 10https://gerrit.wikimedia.org/r/308210 (owner: 10Aaron Schulz) [18:17:10] stephanebisson: well in that case, I'll have to flush the snapshot right there...which is a bit "rude" for another code. [18:17:20] not a huge deal though [18:19:15] 10MediaWiki-Interface, 10MediaWiki-jQuery-Tablesorter, 07JavaScript: Implement repeated/fixed/floating table headers - https://phabricator.wikimedia.org/T42763#2605553 (10Jdforrester-WMF) [18:19:22] (03CR) 10Bmansurov: "OK. Aren't logged in responses not cached, which means it needs `maxage` header in either case?" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308143 (https://phabricator.wikimedia.org/T126455) (owner: 10Phuedx) [18:20:43] 10Wikimedia-Site-requests, 06Wiktionary: Install Translate Extension in the French Wiktionary - https://phabricator.wikimedia.org/T138972#2605555 (10Dereckson) Okay, I'll deploy that this Monday. [18:21:18] 10Wikimedia-Site-requests, 06Wiktionary: Install Translate Extension in the French Wiktionary - https://phabricator.wikimedia.org/T138972#2605556 (10Dereckson) a:03Dereckson [18:23:14] 10MediaWiki-extensions-CheckUser, 13Patch-For-Review: Drop legacy installer script from CheckUser extension (update.php hooks should already exist) - https://phabricator.wikimedia.org/T29431#304655 (10Huji) Excellent! I am very happy that someone has finally submitted a patch to do away with `$wgCheckUserLog`,... [18:24:26] (03Merged) 10jenkins-bot: Don't mention $wgUser, it's ugly and it messes my grep-fu [core] - 10https://gerrit.wikimedia.org/r/308212 (owner: 10Chad) [18:24:36] 10Technical-Collaboration-Guideline, 06Community-Liaisons (Oct-Dec-2016): Review the Technical Collaboration Guideline - https://phabricator.wikimedia.org/T144625#2605564 (10Keegan) [18:24:47] (03PS1) 10Chad: Parser::transformMsg(): die $wgTitle die [core] - 10https://gerrit.wikimedia.org/r/308215 [18:25:05] 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Technical Collaboration quarterly goals for October - December 2016 - https://phabricator.wikimedia.org/T142355#2605582 (10Keegan) [18:27:23] (03Merged) 10jenkins-bot: Add flushReplicaSnapshots() method for just clearing snapshots [core] - 10https://gerrit.wikimedia.org/r/308210 (owner: 10Aaron Schulz) [18:27:27] ostriches: thanks, I needed that patch for something [18:27:32] (03CR) 10Jdlrobson: "@bmansurov it is needed as it causes a regression in the margin. Try master before and after and compare the visual difference." (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs) [18:27:38] (03PS1) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [18:28:06] stephanebisson: ^ that for the slave lag thing [18:28:37] stephanebisson: does that run in jenkins (so there would be mwerror data)? [18:29:01] (03PS1) 10Mooeypoo: Followup I3daae156d: Don't truncate body text for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308217 [18:29:30] (03CR) 10jenkins-bot: [V: 04-1] Parser::transformMsg(): die $wgTitle die [core] - 10https://gerrit.wikimedia.org/r/308215 (owner: 10Chad) [18:31:00] (03PS2) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [18:32:23] (03PS1) 10Ppchelko: Make performer.user_is_bot a required property [event-schemas] - 10https://gerrit.wikimedia.org/r/308218 [18:33:48] AaronSchulz: There's browser tests about it but they don't run in jenkins (too unstable). I'm testing it now. [18:34:33] 06Wikipedia-Android-App-Backlog, 07WorkType-NewFunctionality: Recommend UI enhancement: TOC drawer should appear in front of both the app bar and screen contents - https://phabricator.wikimedia.org/T108726#2605595 (10Niedzielski) [18:36:30] (03CR) 10Catrope: [C: 032] Followup I3daae156d: Don't truncate body text for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308217 (owner: 10Mooeypoo) [18:38:22] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2604880 (10Dereckson) The discussion explicitly considered who should close the procedure, sysops or bureaucrats. Arguments for bureaucrats have been given too, and it was a viable envisaged option. Furthe... [18:38:30] AaronSchulz: it errors out on the page with "Argument 1 passed to LBFactory::waitForReplication() must be an instance of array, string given" [18:38:48] AaronSchulz: if I remove the __METHOD__ argument, it fails with "Call to undefined method LBFactorySimple::flushReplicaSnapshots()" [18:39:08] AaronSchulz: am I missing something? [18:39:27] stephanebisson: pull in core [18:40:08] I was using a different lag method then switched and forgot that arg change [18:41:28] (03PS3) 10Aaron Schulz: Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 [18:42:01] 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2605631 (10Dereckson) [18:42:46] AaronSchulz: what should the args for waitForReplication() be? [18:42:52] (03Merged) 10jenkins-bot: Followup I3daae156d: Don't truncate body text for small screens [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308217 (owner: 10Mooeypoo) [18:43:00] stephanebisson: I just amended it [18:45:06] AaronSchulz: ok, same problem as before: the moved page is not found. [18:46:15] AaronSchulz: how do you think the change to DeferredUpdates affected MovePage? [18:50:37] 10MediaWiki-Parser: Line breaks may be inserted in preformatted text in tables - https://phabricator.wikimedia.org/T144585#2604526 (10Umherirrender) There are css rules with "white-space: pre-wrap" for the elements your are refer. So it looks like this works as expected. Try ``` 
...
[18:50:53] 	 stephanebisson: does it depend on the linker update running first in the main round somehow?
[18:51:14] 	 10MediaWiki-extensions-ZeroBanner, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, and 4 others: [Spike: 2 hours] Page actions bar not showing on Wikipedia Zero - https://phabricator.wikimedia.org/T143425#2605638 (10dr0ptp4kt) For later reference, I followed up separately...
[18:53:57] 	 (03PS1) 10Aaron Schulz: Fix deletion handling of rev_deleted [core] - 10https://gerrit.wikimedia.org/r/308220 
[18:55:52] 	 (03CR) 10C. Scott Ananian: [C: 032] Document some things on osx [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/308125 (owner: 10Arlolra)
[18:57:43] 	 (03Merged) 10jenkins-bot: Document some things on osx [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/308125 (owner: 10Arlolra)
[18:58:49] 	 (03CR) 10C. Scott Ananian: [C: 032] Smash the global promise [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/308118 (owner: 10Arlolra)
[18:58:57] 	 (03CR) 10C. Scott Ananian: [V: 032] Smash the global promise [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/308118 (owner: 10Arlolra)
[18:59:12] 	 (03CR) 10Amire80: [C: 032] i18n: Add Arabic translations [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/305548 (owner: 10Jforrester)
[18:59:24] 	 (03PS1) 10Jdlrobson: Remove styles for old Minerva design [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308221 
[18:59:58] 	 07Design, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog: Create wordmarks for all Wikipedia languages for use on the iOS iPad app and the Android app - https://phabricator.wikimedia.org/T142426#2605656 (10Niedzielski) o/ @RHo @nirzar @dbrant. Just a heads up that the devs just talked a little...
[18:59:59] 	 (03Merged) 10jenkins-bot: i18n: Add Arabic translations [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/305548 (owner: 10Jforrester)
[19:00:01] 	 (03PS1) 10Aaron Schulz: Fix deletion handling of rev_deleted [core] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/308222 
[19:00:57] 	 (03PS6) 10Jdlrobson: Use mw.viewport to check when to load related pages [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs)
[19:01:16] 	 (03PS2) 10Aaron Schulz: Fix deletion handling of rev_deleted [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) 
[19:01:24] 	 (03PS7) 10Jdlrobson: Use mw.viewport to check when to load related pages [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs)
[19:01:52] 	 (03CR) 10Jdlrobson: [C: 032] Use mw.viewport to check when to load related pages [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs)
[19:01:55] 	 (03PS2) 10Aaron Schulz: Fix deletion handling of rev_deleted [core] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/308222 (https://phabricator.wikimedia.org/T144484) 
[19:02:57] 	 (03CR) 10Bmansurov: [C: 032] Remove styles for old Minerva design [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308221 (owner: 10Jdlrobson)
[19:04:02] 	 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Spike, 07Technical-Debt: [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation? - https://phabricator.wikimedia.org/T143334#2605659 (10Jdlrobson) Sounds good @bmansurov but I'd recommen...
[19:05:15] 	 (03Merged) 10jenkins-bot: Remove styles for old Minerva design [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/308221 (owner: 10Jdlrobson)
[19:05:17] 	 (03Merged) 10jenkins-bot: Use mw.viewport to check when to load related pages [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/307547 (https://phabricator.wikimedia.org/T135607) (owner: 10Jhobs)
[19:06:25] 	 10Wikimedia-Site-requests: New "engineer" usergroup for ruwiki - https://phabricator.wikimedia.org/T144599#2604880 (10MarcoAurelio) I share objections raised by @Urbanecm and @Dereckson. Also, given T139246, the group should be called `editinterface`. The name can be customized locally modifying the local MediaW...
[19:06:28] 	 10MediaWiki-extensions-RelatedArticles, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-80-V-for-Vandalism, 07Technical-Debt: Trigger loading related pages using isElementCloseToViewport to avoid visible lag - https://phabricator.wikimedia.org/T135607#2605680 (10bmansurov) a:05bmansurov...
[19:06:28] 	 stephanebisson: so which ImportException error is it throwing (or is it returning null)?
[19:07:55] 	 AaronSchulz: Converter.php:288, $page->getRevision() returns null, where $page is the moved page 
[19:09:39] 	 (03CR) 10Catrope: [C: 032] Fix import Converter::doConversion commit/lag check logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz)
[19:11:50] 	 (03CR) 10Aaron Schulz: [C: 04-2] "Still not enough. Hold on." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz)
[19:12:03] 	 stephanebisson: duh, nothing commits yet, heh
[19:12:32] 	 but that takes us back to the two round solution or getting the later code in the importer to use the master
[19:12:58] 	 in any case, the move failure is something else
[19:13:25] 	 (03CR) 10Aaron Schulz: "No commit happens here, so the wait still won't work, duh :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308216 (owner: 10Aaron Schulz)
[19:15:32] 	 / If the page is moved but has not completed conversion that
[19:15:32] 	 			// means the previous import failed to complete. Try again.
[19:15:46] 	 stephanebisson: seems like it can handle recovering from that
[19:16:11] 	 RoanKattouw, stephanebisson: is it OK to push createArchiveCleanupRevision() to a second transaction round
[19:16:27] 	 "round" as in https://www.mediawiki.org/wiki/Database_transactions lingo
[19:17:17] * RoanKattouw is in over his head and steps away
[19:20:00] 	 AaronSchulz: It's worth a try. Is it a matter of commiting explicitely and then wrapping createArchiveCleanupRevision() in another explicit transaction?
[19:20:16] 	 I'm making another PS
[19:20:28] 	 more in line with what I wanted to do at first
[19:20:35] 	 (but never sent)
[19:27:57] 	 10MediaWiki-Page-deletion, 10MediaWiki-Revision-deletion, 05Security: [Regression] revision delete bitfield get lost on page deletion - https://phabricator.wikimedia.org/T144484#2605718 (10aaron)
[19:28:45] 	 (03PS1) 10Esanders: Remove apparently unused PNG files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 
[19:30:43] 	 (03CR) 10Esanders: "I grep'd the code for 'png' and it only appears in some test .txt files in references to files hosted on Commons. I also grepped for a few" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 (owner: 10Esanders)
[19:32:32] 	 (03PS7) 10Mattflaschen: Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) 
[19:34:26] 	 stephanebisson: wait, you mean $revision->getContent()?
[19:34:55] 	 AaronSchulz: no, $page->getRevision()
[19:35:09] 	 288 is by getContent()
[19:35:14] 	 (03PS1) 10Mattflaschen: Flow mentions: Don't allow invalid users (IPs are invalid) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308229 (https://phabricator.wikimedia.org/T144613) 
[19:35:19] 	 getRevision() is 280
[19:35:51] 	 (03CR) 10Catrope: [C: 032] Remove apparently unused PNG files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 (owner: 10Esanders)
[19:35:59] 	 "Converter.php:288, $page->getRevision() "
[19:36:01] 	 AaronSchulz: line number was based on your previsou patch, my bad
[19:36:28] 	 ah, no problem, heh
[19:36:44] 	 (03CR) 10Esanders: Allow skins to place notification container for mw.notify (031 comment) [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo)
[19:37:13] 	 stephanebisson: does the $page->getId() yield anything?
[19:37:27] 	 I'll try...
[19:38:58] 	 AaronSchulz: id: 0
[19:39:05] 	 (03CR) 10Catrope: [C: 032] Flow mentions: Don't allow invalid users (IPs are invalid) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308229 (https://phabricator.wikimedia.org/T144613) (owner: 10Mattflaschen)
[19:39:21] 	 (03CR) 10Mooeypoo: "> Interesting. I like where this is going. Perhaps we can even go as" [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo)
[19:39:33] 	 stephanebisson: and $movedFrom is not incorrectly set to a title?
[19:41:19] 	 (03CR) 10jenkins-bot: [V: 04-1] Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[19:41:33] 	 AaronSchulz: when I debug it always enters the second branch (not the "if ( $movedFrom )" branch)
[19:42:10] 	 (03Merged) 10jenkins-bot: Remove apparently unused PNG files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308226 (owner: 10Esanders)
[19:43:00] 	 stephanebisson: can you turn on $wgDebugDumpSql and the debug log to dump to a file?
[19:43:19] 	 sure
[19:44:16] 	 10MediaWiki-General-or-Unknown, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2605733 (10Mattflaschen-WMF)
[19:44:27] 	 10MediaWiki-extensions-OAuth, 06Collaboration-Team-Triage, 10Notifications: "Echo-pref-tooltip-oauth-owner" should have a period - https://phabricator.wikimedia.org/T144631#2605734 (10Guycn2)
[19:46:51] 	 AaronSchulz: how/where do I specify where to dump the sql log? or does it end up in the main debug log file?
[19:47:20] 	 $wgDebugLogFile
[19:47:55] 	 (03CR) 10Legoktm: "One more thought, maybe instead of an interface, we should have an abstract MessagePoster class that has a makeInternalApiRequest helper f" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[19:48:15] 	 (03Merged) 10jenkins-bot: Flow mentions: Don't allow invalid users (IPs are invalid) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308229 (https://phabricator.wikimedia.org/T144613) (owner: 10Mattflaschen)
[19:48:21] 	 (03PS2) 10Aaron Schulz: Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 
[19:48:46] 	 (03CR) 10Catrope: [C: 032] Hide xwiki widget separator when widget is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo)
[19:49:04] 	 (03CR) 10Legoktm: Add server-side MessagePoster (031 comment) [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[19:49:52] 	 those rollback() calls in Flow scare me
[19:50:02] 	 sourceStore->rollback()
[19:53:17] 	 AaronSchulz: it's a huge file: https://phabricator.wikimedia.org/P3967
[19:53:31] 	 (03CR) 10MarkTraceur: [C: 032] mw.Upload.BookletLayout: Use 'amenableparser' to handle templates in error messages [core] - 10https://gerrit.wikimedia.org/r/307530 (https://phabricator.wikimedia.org/T144237) (owner: 10Bartosz Dziewoński)
[19:54:46] 	 (03CR) 10jenkins-bot: [V: 04-1] Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 (owner: 10Aaron Schulz)
[19:55:38] 	 hashar: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/74404/console not bad
[19:55:51] 	 someone could knock those out in a weekend
[19:56:22] 	 (03Merged) 10jenkins-bot: Hide xwiki widget separator when widget is expanded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/308001 (https://phabricator.wikimedia.org/T142260) (owner: 10Mooeypoo)
[19:57:12] 	 10Phabricator-Sprint-Extension: Fatal error opening /project/sprint: Call to undefined method SprintListController::buildApplicationPage() - https://phabricator.wikimedia.org/T144295#2595298 (10Christopher) Fixed.  Patch is here: https://github.com/wikimedia/phabricator-extensions-Sprint/commit/92223987987c10a6a...
[19:58:01] 	 (03CR) 10BearND: [C: 032] "Looks great!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant)
[19:58:20] 	 stephanebisson: you should also set $wgDebugLogGroups['exception'] to another file
[19:58:39] 	 (03PS2) 10Mattflaschen: Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) 
[19:59:59] 	 (03Merged) 10jenkins-bot: mw.Upload.BookletLayout: Use 'amenableparser' to handle templates in error messages [core] - 10https://gerrit.wikimedia.org/r/307530 (https://phabricator.wikimedia.org/T144237) (owner: 10Bartosz Dziewoński)
[20:00:33] 	 (03Merged) 10jenkins-bot: Unify and normalize toolbar in MainActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/308161 (owner: 10Dbrant)
[20:01:44] 	 AaronSchulz: check this out: https://phabricator.wikimedia.org/P3968
[20:02:21] 	 stephanebisson: remember I suspected that when you first brought up the problem? :)
[20:05:52] 	 10MediaWiki-Uploading, 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, and 2 others: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2605820 (10MarkTraceur) 05Open>03Resolved
[20:08:45] 	 ebernhardson: do you remember 8fb475c6ddefbbbab04ea5f11875dce346a4aeac ?
[20:09:52] 	 (03PS1) 10Aaron Schulz: Fixup rc_minor if empty for STRICT mode in RecentChange [core] - 10https://gerrit.wikimedia.org/r/308231 
[20:10:17] 	 (03PS2) 10Aaron Schulz: Fixup rc_minor if empty for STRICT mode in RecentChange [core] - 10https://gerrit.wikimedia.org/r/308231 
[20:10:20] 	 AaronSchulz: looking
[20:10:31] 	 (03PS3) 10Aaron Schulz: Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 
[20:10:50] 	 AaronSchulz: not specifically :S
[20:10:55] 	 AaronSchulz: anything in particular?
[20:10:56] 	 yeah, great summary :)
[20:11:15] 	 ebernhardson: it's causing problems like https://phabricator.wikimedia.org/P3968
[20:11:42] 	 stephanebisson: also, the begin/commit/rollbacks will all eventually have to die
[20:12:07] * AaronSchulz is glad the last of the wikidata ones are gone
[20:13:11] 	 AaronSchulz: it's always seemed odd to me to not have code control it's own begin/commit/rollback sequence
[20:13:55] 	 well, you have startAtomic and callbacks
[20:14:54] 	 these can nest without blowing up when mixed together or when the wind blows the near wrong tree for a little too long
[20:15:33] 	 MW almost all compliant in terms of a coherent model...that took 3-4 years of backburner work
[20:15:40] 	 i wonder if it's still apropriate that that code flushes the deferred queue, that was done because when it was written it was a batch maintenance script
[20:16:17] 	 every wait for slaves, or commit(), or addUpdate() that happens when all DBs are idle will triggered deferred updates
[20:16:34] 	 (03CR) 10jenkins-bot: [V: 04-1] Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 (owner: 10Aaron Schulz)
[20:16:38] 	 so you don't normally have to call it unless there is some special ordering of the next operations or need for immediacy
[20:18:04] 	 (03PS3) 10Aaron Schulz: Fixup some rc_* fields if empty for STRICT mode in RecentChange [core] - 10https://gerrit.wikimedia.org/r/308231 
[20:18:22] 	 (03PS4) 10Aaron Schulz: Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 
[20:19:13] 	 ebernhardson: but I couldn't tell if there *was* a special reason
[20:22:50] 	 stephanebisson: i might suggest adjusting Importer::flushDeferredQueue() to run the updates directly instead of running the main DeferredUpdates::doUpdates()
[20:23:04] 	 just the ones in $this->deferredQueue
[20:24:03] 	 at Importer::begin it should be empty, on Importer::commit it will have some things that were delayed, like pushing to the recent changes table and sending echo notifications
[20:24:24] 	 so you just do Flow updates and begin()/commit() each? I guess if you can begin/commit without erroring out yet on the flow DB, you could do that.
[20:24:46] 	 eventually, if more stuff starts using ext1 that will start blowing up due to some random hooks or something.
[20:24:59] 	 AaronSchulz: once per imported page
[20:25:01] 	 but it seems sensible for now; and keeps relative order
[20:25:30] 	 (03CR) 10jenkins-bot: [V: 04-1] Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 (owner: 10Aaron Schulz)
[20:25:39] 	 AaronSchulz: keeps them independant of eachother, and in a maintenance script that was converting many many pages kept from having a long transaction but still keeping single page imports atomic
[20:26:29] 	 so it's *probably* fine to let them defer till full transaction round end?
[20:26:50] 	 probably, yes. although its been more than a year since i looked at any of this code
[20:26:51] 	 if they are independent (and the surrounding code is too)
[20:27:01] 	 10Data-release, 06Research-and-Data: Get Analytics to create an open data registry entry for PVs and UDs - https://phabricator.wikimedia.org/T144604#2605855 (10DarTar)
[20:32:29] 	 10TPG-2017Q1-Improve-Annual-Planning, 10TPG-Essential-Functions, 06Team-Practices (This-Week): Analyze annual planning retrospective survey data - https://phabricator.wikimedia.org/T138242#2394563 (10Awjrichards) Qualitative and quantitative data analyzed (at least sufficiently for TPG involvement purposes -...
[20:32:31] 	 10TPG-2017Q1-Roll-Out-Engagement-Survey, 06Team-Practices (This-Week): Administer Light Engagement survey pilot round 1 - https://phabricator.wikimedia.org/T141134#2605865 (10ggellerman) 05Open>03Resolved
[20:35:34] 	 10MediaWiki-extensions-WikimediaMessages: Migrate local group names to WikimediaMessages - https://phabricator.wikimedia.org/T139246#2423906 (10Dereckson) There is an agreement to sort between technician / editinterface names? That would be useful to have the definitve one for T144599.
[20:35:52] 	 10TPG-Essential-Functions, 07Epic, 06Team-Practices (This-Week): Identify themes from Q 4 TPG CSAT to inform open-ended questions in Q1 survey - https://phabricator.wikimedia.org/T143947#2605879 (10ksmith)
[20:39:26] 	 (03PS4) 10Aaron Schulz: Fixup some rc_* fields if empty for STRICT mode in RecentChange [core] - 10https://gerrit.wikimedia.org/r/308231 
[20:39:39] 	 (03PS5) 10Aaron Schulz: Try running DB tests in STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 
[20:40:05] 	 stephanebisson: do you have enough to go atm?
[20:41:23] 	 AaronSchulz: I'm figuring out what I can do with those deferred updates as Erik said, I'll let you know, thanks
[20:41:44] 	 ebernhardson: oh, do you know what was up with that wfWaitForSlaves in doConversion?
[20:42:37] 	 I guess it made half more sense when MovePage did commit(), but even then it didn't commit the slaves
[20:44:28] 	 10TPG-Essential-Functions, 07Category, 07Epic, 06Team-Practices (This-Week): [EPIC] Support teams using Phlogiston/Phragile Burnups in FY2016Q3 - https://phabricator.wikimedia.org/T125583#2605906 (10JAufrecht)
[20:44:37] 	 stephanebisson: I'd recommend dumping the class of jobs that are queued in that flow queue and then and seeing if they look safe to run a bit later (or just iterate through and call doUpdate)
[20:44:53] * AaronSchulz is curious what the classes are
[20:45:18] 	 10MediaWiki-extensions-WikimediaMessages: Migrate local group names to WikimediaMessages - https://phabricator.wikimedia.org/T139246#2605907 (10MarcoAurelio) Editinterface is the most used I think. I'd go with editinterface and later we can take care of technicians, renaming them to editinterface.
[20:45:26] 	 I'm also curious since I don't see where they get added to the queue
[20:45:41] 	 AaronSchulz: not sure, looks like matt added it, i don't remember it
[20:46:00] 	 matt_flaschen: ^
[20:46:48] 	 AaronSchulz, I think it had something to do with LQT.  ebernhardson, do you have the commit?
[20:46:58] 	 AaronSchulz: the classes will almost certainly be DeferrableCallback :(
[20:47:06] 	 matt_flaschen: Idb4c95d189c6de3df3a0c5103a619c7844296b20
[20:47:10] 	 (03PS2) 10Chelsyx: Generate invoke source and click position aggregates [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/308099 (https://phabricator.wikimedia.org/T143726) 
[20:47:15] 	 there are two bugs associated, might shed some light
[20:47:57] 	 stephanebisson: most likely they are listeners to the flow storage, so for example a post gets saved, the post listners get called, then the notifications thing defer's something that will create echo notifications 
[20:48:48] 	 ebernhardson: ah ok, those listeners
[20:49:20] 	 (03CR) 10Fomafix: Allow skins to place notification container for mw.notify (031 comment) [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo)
[20:50:07] 	 AaronSchulz, ebernhardson, I think it's just because we call ApiQueryLQTThreads internally, and that doesn't know to use a master query, even though we do everywhere we can in the Converter itself.
[20:50:50] 	 (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/308193 (owner: 10Fomafix)
[20:50:53] 	 matt_flaschen: but LQT uses the main DB slaves right? Wouldn't there have been SELECTs on it already?
[20:51:03] 	 So MovePage doesnt commit anymore, right? what's the relationship between that and those deferred updates?
[20:51:07] 	 so that data seen would be before the wfWaitForSlaves()
[20:51:24] 	 AaronSchulz, SELECTs before or after Converter's page move?
[20:51:37] 	 also, it happens in transaction round (I guess it used to be after a COMMIT by MovePage), so the writes didn't get issues to the slaves yet
[20:51:54] 	 matt_flaschen: before, by literally anything, say getting user_id from user name to load User
[20:52:13] 	 10MediaWiki-extensions-ZeroBanner, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, and 4 others: [Spike: 2 hours] Page actions bar not showing on Wikipedia Zero - https://phabricator.wikimedia.org/T143425#2605909 (10Issimo_15) Sections are also uneditable now. Can you chec...
[20:52:17] 	 I guess it's not needed then, since nothing is blowing up...perhaps
[20:52:45] 	 AaronSchulz, I guess probably (re your slave question).
[20:52:55] 	 10MediaWiki-extensions-OAuth, 06Collaboration-Team-Triage, 10Notifications, 07Easy: "Echo-pref-tooltip-oauth-owner" should have a period - https://phabricator.wikimedia.org/T144631#2605918 (10Tgr)
[20:52:57] 	 10TPG-2017Q1-Identify-Common-Pain, 06Team-Practices (This-Week): Communicate with WMF and broader community about upcoming statement of purpose of design process - https://phabricator.wikimedia.org/T144217#2605919 (10Awjrichards)
[20:53:01] 	 10Wiki-Loves-Monuments, 13Patch-For-Review: Import 'Daily_uploads' tool to heritage project - https://phabricator.wikimedia.org/T142570#2605922 (10Lokal_Profil) 05Open>03Resolved Many thanks to both of you!
[20:53:08] 	 AaronSchulz, is there a way to test slave lag locally?  I know there have been experiments, not sure what the current status is.
[20:53:30] 	 tgr: want to a review a string of 3 tiny patches? https://gerrit.wikimedia.org/r/#/c/308195/4 (and the two ancestors)
[20:53:51] 	 AaronSchulz, also re "also, it happens in transaction round (I guess it used to be after a COMMIT by MovePage), so the writes didn't get issues to the slaves yet", is that a recent change?
[20:53:52] 	 10TPG-Essential-Functions, 06Team-Practices (This-Week): Give phlogiston demo to stakeholders and document feedback - https://phabricator.wikimedia.org/T135780#2605925 (10ksmith)
[20:54:04] 	 We may not have done a LQT conversion since that change (this is only used in maint scripts), so it could be completely broken.
[20:54:20] 	 10MediaWiki-Uploading, 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, and 2 others: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2605929 (10matmarex) I think it would be good to backport those...
[20:55:04] 	 (03PS1) 10Bartosz Dziewoński: mw.api.messages: Allow passing extra parameters for the API call [core] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/308262 (https://phabricator.wikimedia.org/T144237) 
[20:55:25] 	 matt_flaschen: you can test snapshot issues easily: http://pastebin.com/3YTjZg73
[20:56:13] 	 (03PS1) 10Bartosz Dziewoński: mw.Upload.BookletLayout: Use 'amenableparser' to handle templates in error messages [core] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/308270 (https://phabricator.wikimedia.org/T144237) 
[20:56:46] 	 Project performance-webpagetest-wpt-org build #1860: 04FAILURE in 24 min: https://integration.wikimedia.org/ci/job/performance-webpagetest-wpt-org/1860/
[20:57:02] 	 matt_flaschen: slave lag is tricker: User:Aaron_Schulz/Quick_Vagrant_DB_Replication
[20:59:07] 	 AaronSchulz, thanks.  And is "also, it happens in transaction round (I guess it used to be after a COMMIT by MovePage), so the writes didn't get issues to the slaves yet" a recent change?
[20:59:38] 	 (03PS3) 10Chelsyx: Generate invoke source and click position aggregates [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/308099 (https://phabricator.wikimedia.org/T143726) 
[20:59:44] 	 MovePage not committing anymore is now too recent (e.g. year+)
[20:59:48] 	 10MediaWiki-Uploading, 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, and 2 others: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2605938 (10matmarex)
[21:00:09] 	 deferred updates not wanting to run inside the main round at all is new
[21:00:17] 	 it used to just be risky
[21:00:35] 	 they also don't run inside each other in CLI mode anymore
[21:01:32] 	 AaronSchulz, thanks.
[21:02:14] 	 (03Merged) 10jenkins-bot: Rename CSS files for printing to a consistent file name [core] - 10https://gerrit.wikimedia.org/r/308193 (owner: 10Fomafix)
[21:02:30] 	 it's good for deferredupdates since they can use getEmptyTrasansactionTicket() and commit/wait or do begin/commit on DBs or whatever (per https://www.mediawiki.org/wiki/Database_transactions)
[21:02:46] 	 some where already assuming they could safely do that
[21:03:13] 	 it's not as constraining as the main transaction round
[21:04:39] 	 for example, rollback() in the main round will usually throw an error and rollbackMasterChanges() should only be used by MW or if you are going to rethrow the error after doing some magic
[21:05:08] 	 in deferred updates, rollback() isn't so scary
[21:06:04] 	 (03PS11) 10BearND: Change way to get title from links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/303942 (https://phabricator.wikimedia.org/T136223) 
[21:06:11] 	 it's exactly catching errors and rolling back that made this Flow issue a bit tricky to debug (I kept staring at WikiPage/MovePage).
[21:06:23] 	 that stuff doesn't belong in the main round
[21:08:32] 	 (03CR) 10Smalyshev: Don't fail the whole reindexer thread when a single doc fails. (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/307555 (owner: 10DCausse)
[21:09:09] 	 (03CR) 10Krinkle: "See also T46362, which is about properly batching this. We already have preload and batching points in ResourceLoader, but this one doesn'" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz)
[21:11:21] 	 10MediaWiki-extensions-WikimediaMessages: Migrate 'technician' and 'technican' to 'editinterface' on WMF wikis - https://phabricator.wikimedia.org/T144638#2605947 (10MarcoAurelio)
[21:11:48] 	 10Wikimedia-Site-requests: Migrate 'technician' and 'technican' to 'editinterface' on WMF wikis - https://phabricator.wikimedia.org/T144638#2605962 (10MarcoAurelio)
[21:12:17] 	 10Wikimedia-Site-requests: Migrate 'technician' and 'technican' usergroup name to 'editinterface' on WMF wikis - https://phabricator.wikimedia.org/T144638#2605963 (10MarcoAurelio)
[21:15:12] 	 (03CR) 10Aaron Schulz: Add caching to ResourceLoaderWikiModule::getTitleInfo() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz)
[21:21:31] 	 10MediaWiki-Email, 07I18n: Long article URLs in watchlist notification email body due to encoding for non-ASCII scripts - https://phabricator.wikimedia.org/T72245#2605982 (10demon)
[21:21:57] 	 10MediaWiki-Documentation, 07Documentation: Add documentation for client-side HTML templating to Manual:HTML_templates - https://phabricator.wikimedia.org/T94085#2605984 (10demon)
[21:22:03] 	 10MediaWiki-General-or-Unknown, 07Performance: Investigate poor Hooks::run() performance in xhprof output - https://phabricator.wikimedia.org/T76677#2605986 (10demon)
[21:22:11] 	 10Librarization: Librarization wishlist cleanup - https://phabricator.wikimedia.org/T1118#2605987 (10demon)
[21:22:22] 	 (03PS6) 10Aaron Schulz: Run database-using tests in MySQL STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 
[21:22:25] 	 10MediaWiki-General-or-Unknown, 10Phabricator, 06Project-Admins: Allow to search tasks about MediaWiki core and core only (create MediaWiki umbrella project?) - https://phabricator.wikimedia.org/T76942#2605988 (10demon)
[21:22:34] 	 10MediaWiki-History-or-Diffs: Diff links between revdeleted versions in deleted histories cause PHP error: DifferenceEngine::generateContentDiffBody() must implement interface Content, null given - https://phabricator.wikimedia.org/T49193#2605990 (10demon)
[21:22:34] 	 (03CR) 10Krinkle: Add caching to ResourceLoaderWikiModule::getTitleInfo() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz)
[21:22:39] 	 10MediaWiki-General-or-Unknown, 07WorkType-NewFunctionality: Turn wfHttpError() into a wrapper for HttpError exception - https://phabricator.wikimedia.org/T36151#2605992 (10demon)
[21:23:32] 	 10MediaWiki-Page-deletion: Number of files in an inconsistent deletion state - https://phabricator.wikimedia.org/T35292#2605995 (10demon)
[21:23:49] 	 (03CR) 10Aaron Schulz: Add caching to ResourceLoaderWikiModule::getTitleInfo() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308138 (owner: 10Aaron Schulz)
[21:23:51] 	 10MediaWiki-Database: find a better fix on LoadBalancer connection error - https://phabricator.wikimedia.org/T35036#2606000 (10demon)
[21:29:18] 	 (03CR) 10Hashar: [C: 031] "Looks good" [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[21:34:45] 	 06Discovery-Search: Put SITENAME in search box, just like Mobile Frontend - https://phabricator.wikimedia.org/T144640#2606009 (10Jidanni)
[21:35:42] 	 (03CR) 10Krinkle: Allow passing a jQuery-wrapped node to attachTo (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/308121 (https://phabricator.wikimedia.org/T143297) (owner: 10Mattflaschen)
[21:36:43] 	 (03CR) 10Krinkle: Fix deletion handling of rev_deleted (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[21:38:53] 	 (03PS3) 10Aaron Schulz: Fix deletion handling of rev_deleted [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) 
[21:42:02] 	 (03CR) 10Krinkle: Fix deletion handling of rev_deleted (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[21:42:48] 	 (03PS1) 10Chad: HttpStatus: Support HTTP/2.0 [core] - 10https://gerrit.wikimedia.org/r/308283 
[21:44:08] 	 (03CR) 10Krinkle: "This seems innocent, but note that HTTP/2.0 doesn't actually work like this. And I don't think we should pretend to support possible futur" [core] - 10https://gerrit.wikimedia.org/r/308283 (owner: 10Chad)
[21:45:12] 	 10MediaWiki-General-or-Unknown, 05Goal, 07Technical-Debt: Reduce use of global and public variables - https://phabricator.wikimedia.org/T11968#2606035 (10demon)
[21:45:14] 	 10MediaWiki-General-or-Unknown, 07WorkType-NewFunctionality: Turn wfHttpError() into a wrapper for HttpError exception - https://phabricator.wikimedia.org/T36151#2606033 (10demon) 05Open>03declined Actually, I'm not convinced on this anymore. It's used in a couple of places, not just AjaxDispatcher. Plus s...
[21:45:21] 	 10Wikimedia-Site-requests, 13Patch-For-Review: Migrate 'technician' and 'technican' usergroup name to 'editinterface' on WMF wikis - https://phabricator.wikimedia.org/T144638#2606036 (10MarcoAurelio) Wikis affected will be trwiki and trwikiquote. Maybe we should inform them after merging the change that they s...
[21:46:42] 	 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#2606038 (10Quiddity)
[21:46:46] 	 10MediaWiki-Database, 10MediaWiki-Watchlist, 10DBA, 06TCB-Team, and 3 others: Add a wl_id field to the watchlist table - https://phabricator.wikimedia.org/T125990#2606037 (10Quiddity)
[21:47:04] 	 (03CR) 10Krinkle: Convert Revision::fetchFromConds() to using more modern selectRow() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308164 (owner: 10Aaron Schulz)
[21:48:15] 	 (03PS3) 10Aaron Schulz: Convert Revision::fetchFromConds() to using more modern selectRow() [core] - 10https://gerrit.wikimedia.org/r/308164 
[21:48:19] 	 (03CR) 10jenkins-bot: [V: 04-1] HttpStatus: Support HTTP/2.0 [core] - 10https://gerrit.wikimedia.org/r/308283 (owner: 10Chad)
[21:49:17] 	 10MediaWiki-extensions-ZeroBanner, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, and 4 others: [Spike: 2 hours] Page actions bar not showing on Wikipedia Zero - https://phabricator.wikimedia.org/T143425#2606039 (10bmansurov) I see the same problem. I don't think it's bec...
[21:49:24] 	 (03CR) 10Aaron Schulz: Fix deletion handling of rev_deleted (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[21:50:34] 	 (03CR) 10Chad: "It seemed innocent enough considering that someone could very easily configure their server to report the protocol as http/2.0 (more likel" [core] - 10https://gerrit.wikimedia.org/r/308283 (owner: 10Chad)
[21:50:55] 	 (03CR) 10Krinkle: [C: 031] Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 (owner: 10Aaron Schulz)
[21:52:30] 	 Krinkle: Wordpress has also had this discussion it would seem: https://core.trac.wordpress.org/ticket/37863
[21:53:56] 	 I guess theoretically you can always configure your server to report POOP/9.0 as your protocol, which we should fallback gracefully from. The ultimate question is what do we decide to serve back to clients.
[21:54:24] 	 ostriches: Sure, but HTTP/2.0 doesn't actually exist in that form today.
[21:54:31] 	 HTTP/2.0 wraps HTTP/1.1
[21:54:45] * ostriches nods
[21:54:53] 	 I guess it was premature future-proofing :)
[21:55:19] 	 It's a major version bump, so it may well proof that out response is invalid as HTTP/2.0 if they decide to use that in the future
[21:55:29] 	 but browsers may know how to deal with 1.1 responses still
[21:57:16] 	 (03PS4) 10Aaron Schulz: Fix deletion handling of rev_deleted [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) 
[21:57:33] 	 Krinkle: Fair enough
[21:57:43] 	 (03Abandoned) 10Chad: HttpStatus: Support HTTP/2.0 [core] - 10https://gerrit.wikimedia.org/r/308283 (owner: 10Chad)
[22:00:23] 	 10Wikimedia-Site-requests, 13Patch-For-Review: Migrate 'technician' and 'technican' usergroup name to 'editinterface' on WMF wikis - https://phabricator.wikimedia.org/T144638#2605947 (10Peachey88) >>! In T144638#2606036, @MarcoAurelio wrote: > Wikis affected will be trwiki and trwikiquote. Maybe we should info...
[22:02:35] 	 (03CR) 10Krinkle: Fixup some rc_* fields if empty for STRICT mode in RecentChange (032 comments) [core] - 10https://gerrit.wikimedia.org/r/308231 (owner: 10Aaron Schulz)
[22:02:58] 	 (03CR) 10Krinkle: [C: 032] Convert Revision::fetchFromConds() to using more modern selectRow() [core] - 10https://gerrit.wikimedia.org/r/308164 (owner: 10Aaron Schulz)
[22:03:50] 	 (03PS8) 10Mattflaschen: Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) 
[22:03:53] 	 (03CR) 10Aaron Schulz: "The failures are in PS1. Basically wikidata tests using ''." [core] - 10https://gerrit.wikimedia.org/r/308231 (owner: 10Aaron Schulz)
[22:04:28] 	 (03CR) 10Krinkle: [C: 032] Fix deletion handling of rev_deleted [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[22:04:49] 	 06Design-Research-Backlog: Design research user study privacy statement - https://phabricator.wikimedia.org/T144641#2606052 (10Capt_Swing)
[22:05:13] 	 (03CR) 10Mattflaschen: "> One more thought, maybe instead of an interface, we should have an abstract MessagePoster class that has a makeInternalApiRequest helper" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[22:06:36] 	 06Design-Research-Backlog: Update design research consent form - https://phabricator.wikimedia.org/T144642#2606066 (10Capt_Swing)
[22:06:37] 	 (03CR) 10Mattflaschen: "Flow one is at https://gerrit.wikimedia.org/r/#/c/307464/ , BTW." [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[22:06:56] 	 (03CR) 10Krinkle: [C: 031] Run database-using tests in MySQL STRICT mode [core] - 10https://gerrit.wikimedia.org/r/308195 (owner: 10Aaron Schulz)
[22:07:30] 	 (03CR) 10Krinkle: "Looks like that may just be casted from boolean false in the RecentChange method via getBool() ?" [core] - 10https://gerrit.wikimedia.org/r/308231 (owner: 10Aaron Schulz)
[22:07:48] 	 10MediaWiki-General-or-Unknown, 10Flow, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review: Implement a server-side mw.MessagePoster equivalent - https://phabricator.wikimedia.org/T123522#2606079 (10Mattflaschen-WMF)
[22:10:18] 	 (03Merged) 10jenkins-bot: Convert Revision::fetchFromConds() to using more modern selectRow() [core] - 10https://gerrit.wikimedia.org/r/308164 (owner: 10Aaron Schulz)
[22:11:44] 	 10MediaWiki-extensions-ZeroBanner, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-80-V-for-Vandalism, and 4 others: [Spike: 2 hours] Page actions bar not showing on Wikipedia Zero - https://phabricator.wikimedia.org/T143425#2606095 (10Issimo_15) Yes, I met the problem today, a few hours befo...
[22:12:34] 	 (03Merged) 10jenkins-bot: Fix deletion handling of rev_deleted [core] - 10https://gerrit.wikimedia.org/r/308220 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[22:13:43] 	 (03CR) 10jenkins-bot: [V: 04-1] Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[22:17:00] 	 (03PS5) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 
[22:18:17] 	 10MediaWiki-History-or-Diffs, 10MediaWiki-Parser, 07Tracking: Edit summary issues (tracking) - https://phabricator.wikimedia.org/T119681#2606110 (10Quiddity)
[22:18:23] 	 10MediaWiki-History-or-Diffs, 07Community-Wishlist-Survey, 13Patch-For-Review, 13Patch-Needs-Improvement: Correcting edit summaries - https://phabricator.wikimedia.org/T15937#2606108 (10Quiddity) 05Open>03declined There are 2 main difficulties with this task: 1) The user-interface. -- We don't want to...
[22:25:26] 	 10Wikimedia-Site-requests, 13Patch-For-Review: Migrate 'technician' and 'technican' usergroup name to 'editinterface' on WMF wikis - https://phabricator.wikimedia.org/T144638#2606113 (10MarcoAurelio) Sure thing. Will do tomorrow.
[22:27:06] 	 (03Merged) 10jenkins-bot: Fix deletion handling of rev_deleted [core] (wmf/1.28.0-wmf.17) - 10https://gerrit.wikimedia.org/r/308222 (https://phabricator.wikimedia.org/T144484) (owner: 10Aaron Schulz)
[22:33:02] 	 quiddity: I disagree that there would need to be DB changes to fix that if you just logged it (and you'd get supression/etc for free that way). But yes, the UI would be kludgy.
[22:33:17] 	 06Research-and-Data, 10Research-management: Make sure each team member with published research outputs has an ORCID - https://phabricator.wikimedia.org/T144576#2606117 (10Capt_Swing)
[22:33:32] 	 (03PS1) 10MusikAnimal: Add basic AbuseFilter reading writes for OAuth [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/308289 (https://phabricator.wikimedia.org/T143632) 
[22:34:14] 	 quiddity: Honestly, the backend/code side of it is *easy*, it's the UI/UX that would be ugly/hard :)
[22:35:55] 	 (03PS6) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 
[22:37:01] 	 Ok, good to know.
[22:38:56] 	 10Brickimedia: Clicking the Brickipedia logo in DeepSea takes one to "LEGO Wiki" rather than "Main Page" - https://phabricator.wikimedia.org/T144645#2606140 (10lcf119)
[22:40:01] 	 (03CR) 10MusikAnimal: Add basic AbuseFilter reading writes for OAuth (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/308289 (https://phabricator.wikimedia.org/T143632) (owner: 10MusikAnimal)
[22:42:57] 	 (03PS2) 10MusikAnimal: Add basic AbuseFilter reading writes for OAuth [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/308289 (https://phabricator.wikimedia.org/T126756) 
[22:43:50] 	 ostriches: https://gerrit.wikimedia.org/r/#/c/308172/4 moar caching
[22:54:00] 	 10Brickimedia: Clicking the Brickipedia logo in DeepSea takes one to "LEGO Wiki" rather than "Main Page" - https://phabricator.wikimedia.org/T144645#2606140 (10ashley) There's [[https://github.com/Brickimedia/LocalSettings/blob/master/LocalSettings_en.php#L152|a hooked function in Brickipedia's LocalSettings]] w...
[22:57:38] 	 (03CR) 10BryanDavis: Add basic AbuseFilter reading writes for OAuth (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/308289 (https://phabricator.wikimedia.org/T126756) (owner: 10MusikAnimal)
[22:58:25] 	 (03PS3) 10MusikAnimal: Add basic AbuseFilter reading rights for OAuth [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/308289 (https://phabricator.wikimedia.org/T126756) 
[22:58:34] 	 10Brickimedia, 10DeepSea: Clicking the Brickipedia logo in DeepSea takes one to "LEGO Wiki" rather than "Main Page" - https://phabricator.wikimedia.org/T144645#2606190 (10SamanthaNguyen) @ashley - Removing it sounds good to me!
[22:59:26] 	 (03PS1) 10Krinkle: resourceloader: Shorten cache expirty if 'version' query doesn't match [core] - 10https://gerrit.wikimedia.org/r/308290 (https://phabricator.wikimedia.org/T117587) 
[23:00:16] 	 (03PS1) 10Aaron Schulz: Use WAN cache adaptiveTTL() method in FileBackendStore [core] - 10https://gerrit.wikimedia.org/r/308291 
[23:01:08] 	 (03PS2) 10Krinkle: resourceloader: Shorten cache expiry if 'version' query doesn't match [core] - 10https://gerrit.wikimedia.org/r/308290 (https://phabricator.wikimedia.org/T117587) 
[23:04:49] 	 (03CR) 10MusikAnimal: Add basic AbuseFilter reading rights for OAuth (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/308289 (https://phabricator.wikimedia.org/T126756) (owner: 10MusikAnimal)
[23:06:36] 	 (03PS3) 10Krinkle: resourceloader: Shorten cache expiry if 'version' query doesn't match [core] - 10https://gerrit.wikimedia.org/r/308290 (https://phabricator.wikimedia.org/T117587) 
[23:07:16] 	 (03PS4) 10Krinkle: resourceloader: Shorten cache expiry if 'version' query doesn't match [core] - 10https://gerrit.wikimedia.org/r/308290 (https://phabricator.wikimedia.org/T117587) 
[23:08:36] 	 (03CR) 10Krinkle: [C: 032] "Wee, from 2013 :) - 79910f36d47270e802e9ff3a36b4f10b5f1fa686" [core] - 10https://gerrit.wikimedia.org/r/308291 (owner: 10Aaron Schulz)
[23:09:29] 	 (03PS2) 10Krinkle: OutputPage: Ensure setupSkinUserCss() always applies to headElement() [core] - 10https://gerrit.wikimedia.org/r/307659 (https://phabricator.wikimedia.org/T144301) 
[23:09:31] 	 Krinkle: yeah, I thought that was funny too. The first adaptive ttl use and I forgot to convert it.
[23:10:16] 	 (03CR) 10Bearloga: "Almost there..." (031 comment) [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/308099 (https://phabricator.wikimedia.org/T143726) (owner: 10Chelsyx)
[23:13:08] 	 AaronSchulz: What is the purpose of getConnectionRef()? I understand LazyRef, but not sure about getConnectionRef() in stead of getConnection.
[23:13:57] 	 it calls reuseConnection($conn) when it falls out of scope. That frees the handle for >selectDB() so it can be used for callers that want another wiki on the same shard (server).
[23:14:34] 	 if you don't call that method, the handle dangles around and callers wanting handles to wikis on that db will get a new connection instead
[23:15:28] 	 (03Merged) 10jenkins-bot: Use WAN cache adaptiveTTL() method in FileBackendStore [core] - 10https://gerrit.wikimedia.org/r/308291 (owner: 10Aaron Schulz)
[23:19:07] 	 (03PS1) 10Harej: Adds a new hook called AllowCustomContentModel. [core] - 10https://gerrit.wikimedia.org/r/308299 
[23:19:22] 	 AaronSchulz: Hm.. getConnection() doesn't reuse and make reusable connections by default?
[23:19:33] 	 So wfGetDB(DB_MASTER) and DB_SLAVE etc are not reusable?
[23:20:06] 	 in that calling them twice will not result in the same (or similar) objects using the same connection?
[23:20:34] 	 Krinkle: afaik you get the same object
[23:20:56] 	 (03CR) 10Catrope: [C: 032] Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo)
[23:21:17] 	 10TPG-2017Q1-Improve-Annual-Planning, 06Team-Practices (This-Week): Create an office wiki page for the annual plan review process. - https://phabricator.wikimedia.org/T144649#2606237 (10ksmith)
[23:21:43] 	 10Wikimedia-Site-requests: Rights from removed extension still to be removed from users - https://phabricator.wikimedia.org/T144650#2606251 (10MarcoAurelio)
[23:22:41] 	 (03PS3) 10Harej: [WIP] Bypassing permissions check upon CollaborationHub creation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308206 
[23:22:46] 	 10MediaWiki-extensions-CollaborationKit: Remove editcontentmodel permission requirement for creating hub pages - https://phabricator.wikimedia.org/T141562#2503033 (10Harej) a:03Harej
[23:22:51] 	 Krinkle: yeah, it kind of sucks. But that is only if it is foriegn
[23:23:14] 	 so if you do not pass $wiki or it == wfWikiId() you will get the same connection
[23:23:15] 	 Hm.. interesting. So we do reuse in general by default
[23:23:25] 	 (03PS9) 10Mattflaschen: Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) 
[23:23:30] 	 In fact, that's not even reuse that is multi-use at the same time
[23:23:37] 	 the local connection is so common it's a special case
[23:23:44] 	 it has a slot of it's own
[23:23:48] 	 10Brickimedia, 10DeepSea: Clicking the Brickipedia logo in DeepSea takes one to "LEGO Wiki" rather than "Main Page" - https://phabricator.wikimedia.org/T144645#2606265 (10ashley) 05Open>03Resolved a:03ashley [[https://github.com/Brickimedia/LocalSettings/commit/9a028b8abc8a995d42688e6b0a9f6c5bdb61707e|Do...
[23:23:48] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Bypassing permissions check upon CollaborationHub creation [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/308206 (owner: 10Harej)
[23:23:50] 	 unlike the other 950 wikis
[23:23:50] 	 AaronSchulz: reuse means itwill allow another caller to continue it after the caller is done with it, right?
[23:23:50] 	 (03CR) 10jenkins-bot: [V: 04-1] Adds a new hook called AllowCustomContentModel. [core] - 10https://gerrit.wikimedia.org/r/308299 (owner: 10Harej)
[23:24:00] 	 Krinkle: yep
[23:24:17] 	 or rather when they call reuse() which is typically at the end in maintenance scripts
[23:24:29] 	 so calling getConnectionRef() twice for the same foreign wiki will create two connections
[23:24:34] 	 all selectDb() does is change the implied DB being talked about, so we don't need enwiki.revision type queries all over the place
[23:24:37] 	 if the first one didn't deref/reuse yet
[23:24:47] 	 right
[23:24:59] 	 AaronSchulz: whereas for local wiki, it'll reuse concurrently?
[23:25:15] 	 yep, since it has a dedicated connection
[23:25:16] 	 Which I suppose is why we have nested transaction logic.
[23:25:23] 	 Okay, all makes sense now
[23:25:35] 	 we couldn't do dedicated wiki => conn handles for 950 wikis though
[23:25:50] 	 we only have 7 shards, so it's to just recycle them
[23:25:55] 	 *it's easy
[23:26:09] 	 AaronSchulz: So does wfGetLB( $this->mWiki )->getConnectionRef( DB_SLAVE ) override any positive behaviour for mWiki=false/local wikiid?
[23:26:31] 	 10MediaWiki-extensions-WikimediaMessages, 13Patch-For-Review: Migrate local group names to WikimediaMessages - https://phabricator.wikimedia.org/T139246#2606274 (10MarcoAurelio) Please see https://tools.wmflabs.org/rightstool/cgi-bin/rightsstats for further inconsistencies:  * fawiki autopatrol should be renam...
[23:26:32] 	 it will cause reuse* but that will no-op itself
[23:26:35] 	 Or is it effectively the same as wGetDB(DB_SLAVE) except being a ref con, and calling moot reuse()
[23:26:40] 	 Okay
[23:26:43] 	 it used to make a wfDebug() message I just killed today
[23:26:57] 	 it's so common and not worth logging 
[23:28:06] 	 Yeah.
[23:28:10] 	 (03Merged) 10jenkins-bot: Add confirmation popup widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306287 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo)
[23:29:41] 	 (03CR) 10Catrope: Add 'mark all read' button to the notification overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/306288 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo)
[23:29:57] 	 (03CR) 10Catrope: [C: 032] "Trying again now that the Echo patch has been merged and the i18n message should exist." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/306288 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo)
[23:29:59] 	 (03PS5) 10Aaron Schulz: Cache NS_TEMPLATE/NS_FILE titles in LinkCache persistently [core] - 10https://gerrit.wikimedia.org/r/308172 
[23:32:43] 	 (03CR) 10Krinkle: Cache revision lookups done by Parser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/308136 (owner: 10Aaron Schulz)
[23:35:48] 	 Krinkle: so you don't need to sort the module names when making the master hash?
[23:36:04] * AaronSchulz looks up the stack
[23:36:19] 	 AaronSchulz: Nope, should be the same order already. But let me verify.
[23:36:24] 	 (03Merged) 10jenkins-bot: Add 'mark all read' button to the notification overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/306288 (https://phabricator.wikimedia.org/T141404) (owner: 10Mooeypoo)
[23:37:43] 	 AaronSchulz: Client-side typically sorts the modules a-z in the load.php query parameter. And buildModulesString() compression in JS doesn't do re-ordering either.
[23:37:57] 	 And if a client changes the order, that would just work as expected.
[23:39:24] 	 Actually, while the client-side buildModulesString() doesn't do re-ordering, the server-side  makePackedModulesString() can sometimes change the order to improve compression. 
[23:39:42] 	 I recently made a unit test for that. Haven't decided what to do about that yet.
[23:39:46] 	 (03PS10) 10Mattflaschen: Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) 
[23:39:49] 	 ResourceLoaderTest:;providePackedModules
[23:40:53] 	 I just want to see that client (using code we give) and server use the same canonical order
[23:43:39] 	 AaronSchulz: Yep, confirmed they do. When the server produces a load.php url (ResourceLoaderClientHtml::makeLoad), it goes like this: sort(), $context->setModules(), createLoaderURL(), makePackedModulesString(). And in JavaScript: mw.loader.work(), batchRequest(), sort(), buildModulesString().
[23:43:44] 	 Using the same logic and the same order as such.
[23:44:16] 	 AaronSchulz: Per the test plan, it works in all cases we have by default. Since cache max-age is set correctly, but good to verify for edge cases.
[23:44:41] 	 (03PS11) 10Mattflaschen: Add server-side MessagePoster [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) 
[23:45:31] 	 AaronSchulz: So they both sort alphabetically and that applies to both the 'modules' query string and the function call that makes the hash. The order is done first.
[23:45:44] 	 (03PS7) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 
[23:46:12] 	 AaronSchulz: Where do we use Revision class with a foreign db?
[23:47:02] 	 it has lots of $db args in methods, so I decided to go with that too. It could be useful for anything transwiki, and is easy enough to support.
[23:47:13] 	 (since I'm adding a method anyway)
[23:47:26] 	 (03CR) 10Aaron Schulz: [C: 032] resourceloader: Shorten cache expiry if 'version' query doesn't match [core] - 10https://gerrit.wikimedia.org/r/308290 (https://phabricator.wikimedia.org/T117587) (owner: 10Krinkle)
[23:47:51] 	 (03PS3) 10Mattflaschen: Add a server-side MessagePoster for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/307464 (https://phabricator.wikimedia.org/T123522) 
[23:49:59] 	 (03CR) 10Krinkle: Add server-side MessagePoster (031 comment) [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[23:50:08] 	 (03CR) 10jenkins-bot: [V: 04-1] Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 (owner: 10Aaron Schulz)
[23:53:22] 	 (03PS8) 10Aaron Schulz: Cache revision lookups done by Parser [core] - 10https://gerrit.wikimedia.org/r/308136 
[23:54:40] 	 (03CR) 10Krinkle: Add server-side MessagePoster (032 comments) [core] - 10https://gerrit.wikimedia.org/r/307426 (https://phabricator.wikimedia.org/T123522) (owner: 10Mattflaschen)
[23:56:27] 	 (03Merged) 10jenkins-bot: resourceloader: Shorten cache expiry if 'version' query doesn't match [core] - 10https://gerrit.wikimedia.org/r/308290 (https://phabricator.wikimedia.org/T117587) (owner: 10Krinkle)