[00:03:44] (03CR) 10Mattflaschen: [C: 031] "Looks good (the current one is better than the alternative)." [core] - 10https://gerrit.wikimedia.org/r/301028 (owner: 10Krinkle) [00:03:55] 10MediaWiki-Configuration: Support autoconfirmed constants in extension registration - https://phabricator.wikimedia.org/T141223#2494341 (10Legoktm) Global constants are something we can support if necessary, but I'd like to move away from them if possible. The main problem is that extension.json is processed la... [00:08:22] (03CR) 10Reedy: "Apparently I completely missed this. Any chance you could please rebase ontop of extension.json changes?" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/267528 (owner: 10Umherirrender) [00:09:59] (03CR) 10Reedy: "Any particular reason this stalled?" [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [00:12:24] (03CR) 10Aaron Schulz: [C: 031] Change TimedMediaIframeOutput from getHeadScripts() to OutputPage::getRlClient() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/300452 (owner: 10Krinkle) [00:15:29] 10MediaWiki-Configuration: Support autoconfirmed constants in extension registration - https://phabricator.wikimedia.org/T141223#2494365 (10Reedy) >>! In T141223#2494341, @Legoktm wrote: > Global constants are something we can support if necessary, but I'd like to move away from them if possible. The main proble... [00:19:26] 10MediaWiki-Configuration: Unable to override cores default mediahandlers - https://phabricator.wikimedia.org/T141305#2494392 (10Legoktm) ``` case 'array_merge': $GLOBALS[$key] = array_merge( $val, $GLOBALS[$key] ); break; ``` The context here is that we want anything set in LocalSettings.php to w... [00:23:22] 10MediaWiki-Page-deletion, 06Commons, 06Operations, 10media-storage, and 3 others: Unable to delete file pages on commons: MWException/LocalFileLockError: "Could not acquire lock" - https://phabricator.wikimedia.org/T132921#2494394 (10aaron) 05Open>03Resolved [00:24:53] 10Collection, 07Composer, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): "package mediawiki/mediawiki could not be found in any version" - https://phabricator.wikimedia.org/T141221#2494395 (10Reedy) 05Open>03Resolved a:03Reedy [00:27:47] 10MediaWiki-Configuration: Unable to override cores default mediahandlers - https://phabricator.wikimedia.org/T141305#2494410 (10Legoktm) p:05Triage>03Normal a:03Legoktm [00:28:07] (03PS1) 10Legoktm: MediaHandler: Fix @return for getHandler() [core] - 10https://gerrit.wikimedia.org/r/301034 [00:29:14] legoktm: |bool or just |false? [00:29:47] (Can you do that in PHP doc?) [00:30:45] 06Wikipedia-Android-App-Backlog, 10Android-app-feature-Navigation (Android-app-feature-Navigation-MVP), 03Mobile-App-Android-Sprint-87-Francium, 07Unplanned-Sprint-Work: Move article actions into article action toolbar - https://phabricator.wikimedia.org/T135295#2294491 (10Deskana) I surveyed a bunch of th... [00:31:51] James_F: you can't do |false [00:32:46] (03PS1) 10Ladsgroup: Update ORES to the head [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/301035 [00:33:27] legoktm: Meh, lame. [00:33:33] (03CR) 10Jforrester: [C: 032] MediaHandler: Fix @return for getHandler() [core] - 10https://gerrit.wikimedia.org/r/301034 (owner: 10Legoktm) [00:34:23] 10Android-app-feature-Feeds, 06Wikipedia-Android-App-Backlog: The Feed should show content placeholder cards while loading - https://phabricator.wikimedia.org/T124811#1966679 (10Deskana) Implementing this would probably also fix {T140841}. It might be good to merge that task into this one. [00:35:31] @return bool always fase [00:35:33] false [00:35:46] (03CR) 10Krinkle: "I suspect we may have reasons not to want to show all this information on the special page visible too each own user." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [00:35:54] (03PS4) 10Gergő Tisza: Improve management IF return messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/222239 (https://phabricator.wikimedia.org/T63000) [00:35:56] (03PS4) 10Gergő Tisza: Send notifications about app management events [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231989 (https://phabricator.wikimedia.org/T62528) [00:35:58] (03PS3) 10Gergő Tisza: Remove queue name from OAuth consumer management URL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231746 (https://phabricator.wikimedia.org/T109163) [00:37:31] (03CR) 10jenkins-bot: [V: 04-1] Send notifications about app management events [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231989 (https://phabricator.wikimedia.org/T62528) (owner: 10Gergő Tisza) [00:37:35] (03CR) 10jenkins-bot: [V: 04-1] Improve management IF return messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/222239 (https://phabricator.wikimedia.org/T63000) (owner: 10Gergő Tisza) [00:37:57] 10MediaWiki-Vagrant, 07Regression: vagrant-provision failing due to _setup failing for all wikis - https://phabricator.wikimedia.org/T141301#2494435 (10Krinkle) [00:38:01] 10MediaWiki-Vagrant, 07Regression: vagrant-provision fails when enabling flow+echo (to _setup dependency for all wikis) - https://phabricator.wikimedia.org/T141301#2493697 (10Krinkle) [00:38:05] (03CR) 10jenkins-bot: [V: 04-1] Remove queue name from OAuth consumer management URL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231746 (https://phabricator.wikimedia.org/T109163) (owner: 10Gergő Tisza) [00:38:48] (03PS3) 10Jforrester: Have ScribuntoContentHandler extend CodeContentHandler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160411 (owner: 10Legoktm) [00:38:57] (03CR) 10Legoktm: "We could split this into two changes? One that does the backend refactoring and then another to add the special page?" [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [00:39:33] (03PS1) 10Ladsgroup: Add footer [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/301037 [00:39:44] (03CR) 10Catrope: "Just to clarify: what exactly does this allow that wasn't allowed before? Mentions in multi-section edits? Something else?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300528 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [00:39:50] (03CR) 10Ladsgroup: [C: 032 V: 032] Update ORES to the head [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/301035 (owner: 10Ladsgroup) [00:40:01] (03PS7) 10Mooeypoo: WIP: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [00:40:04] (03CR) 10Ladsgroup: [C: 032 V: 032] Add footer [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/301037 (owner: 10Ladsgroup) [00:40:06] (03CR) 10Krinkle: Make onTransactionIdle() safer for multi-DB commits (031 comment) [core] - 10https://gerrit.wikimedia.org/r/300698 (owner: 10Aaron Schulz) [00:40:21] (03PS8) 10Mooeypoo: BREAKING CHANGE: More ISO 8601 for seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300596 (owner: 10Mattflaschen) [00:41:07] (03Merged) 10jenkins-bot: MediaHandler: Fix @return for getHandler() [core] - 10https://gerrit.wikimedia.org/r/301034 (owner: 10Legoktm) [00:42:05] 06Wikipedia-Android-App-Backlog, 10Android-app-feature-Navigation (Android-app-feature-Navigation-MVP), 03Mobile-App-Android-Sprint-87-Francium, 07Unplanned-Sprint-Work: Move article actions into article action toolbar - https://phabricator.wikimedia.org/T135295#2494452 (10Nirzar) @Deskana Google design h... [00:45:19] (03CR) 10Krinkle: [C: 032] Convert onTransactionIdle() callers to DeferredUpdate subclasses [core] - 10https://gerrit.wikimedia.org/r/300338 (owner: 10Aaron Schulz) [00:46:21] (03PS1) 10BryanDavis: confirmedit: require MediaWiki::Extension before custom config [vagrant] - 10https://gerrit.wikimedia.org/r/301038 (https://phabricator.wikimedia.org/T141301) [00:46:41] Krinkle: can you try ^ to see if it fixes T141301 for you? [00:46:42] T141301: vagrant-provision fails when enabling flow+echo (to _setup dependency for all wikis) - https://phabricator.wikimedia.org/T141301 [00:47:58] bd808: thanks, running.. [00:48:24] I'm guessing this is a first clone issue for COnfirmEdit [00:49:07] (03PS3) 10Mooeypoo: [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) [00:49:46] (03CR) 10Esanders: "If you have an LTR title in an RTL wiki don't you have the more serious problem of the

rendering incorrectly on that page?" [core] - 10https://gerrit.wikimedia.org/r/292041 (https://phabricator.wikimedia.org/T136641) (owner: 10Eranroz) [00:52:00] (03CR) 10Krinkle: [C: 032] Convert deferred update to using AutoCommitUpdate [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/300504 (owner: 10Aaron Schulz) [00:52:17] (03Merged) 10jenkins-bot: Convert onTransactionIdle() callers to DeferredUpdate subclasses [core] - 10https://gerrit.wikimedia.org/r/300338 (owner: 10Aaron Schulz) [00:53:02] (03CR) 10Catrope: Redo the notification badges (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [00:53:08] (03Merged) 10jenkins-bot: Convert deferred update to using AutoCommitUpdate [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/300504 (owner: 10Aaron Schulz) [00:53:20] 10MediaWiki-Uploading, 06Commons, 06Multimedia, 07JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#2494463 (10Gunnex) >>! In T120867#2384233, @matmarex wrote:... [00:53:31] 07Design, 10MobileFrontend, 06Reading-Web-Backlog: Switch settings icon from cog to sliders to be consistent with VisualEditor? - https://phabricator.wikimedia.org/T97479#1243548 (10Nirzar) @Jdlrobson the sliders icon is not designed by anyone. VE should change it to cog or if we say we want sliders, we sho... [00:55:05] (03CR) 10Catrope: [C: 04-1] "There is a bug: if I have >0 alerts and >0 messages, then initially the page renders with numbers on top of both icons, but when I click o" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/299910 (https://phabricator.wikimedia.org/T115845) (owner: 10Mooeypoo) [00:58:57] (03CR) 10Jforrester: [C: 032] Have ScribuntoContentHandler extend CodeContentHandler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160411 (owner: 10Legoktm) [01:02:38] (03Merged) 10jenkins-bot: Have ScribuntoContentHandler extend CodeContentHandler [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/160411 (owner: 10Legoktm) [01:03:45] (03PS4) 10Legoktm: Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 [01:04:13] (03CR) 10jenkins-bot: [V: 04-1] Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [01:04:32] (03CR) 10Jforrester: Mark Linker::link() as @deprecated (031 comment) [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [01:06:31] (03PS5) 10Jforrester: Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [01:10:02] (03CR) 10jenkins-bot: [V: 04-1] Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [01:10:08] bd808: still fails the same way with that patch applied [01:10:27] It appears to be coming from update.php ""Could not create a new page. It already exists." [01:10:32] Krinkle: hmmm... did you start clean again? [01:10:37] bd808: define clean? [01:10:55] I removed those roles earlier and provisioned without errors [01:11:09] applied your patch, enabled the roles and provisioned with the errors [01:11:40] can you try rm'ing the FancyCaptcha settings file in settings.d before provisioning please? [01:11:41] (03PS4) 10Mooeypoo: [wip] Update and fetch seenTime per source [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301021 (https://phabricator.wikimedia.org/T134855) [01:12:03] I think that file got created too soon [01:12:23] before the confirm edit git repo was actually cloned [01:12:30] bd808: There is no such file [01:13:19] it would be settings.d/puppet-managed/11-ConfirmEdit_FancyCaptcha.php I think [01:13:57] Yeah, nothing matches "Fanc" anywhere in the tree inside settings.d/ [01:14:03] that's the file that tries to load extensions/ConfirmEdit/FancyCaptcha.php so it has to be there somewhere [01:14:33] I mean the file doesn't exist before I provision with the new roles for the first time [01:14:46] I guess the provision after disabling those roles deleted them already [01:14:55] bd808: https://gist.github.com/Krinkle/9f436d1c4407f2a36810a03c3737ae57 [01:15:03] ah. yeah it should [01:15:48] "Could not create a new page.  It already exists." is different than "File not found: /vagrant/mediawiki/extensions/ConfirmEdit/FancyCaptcha.php" [01:16:04] bd808: The former is from the provision output [01:16:04] are there multiple problems with this combo? [01:16:11] bd808: the latter is what I get over http after that failed provision [01:16:15] (03PS2) 10WMDE-Fisch: Echo notifications for successful mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) [01:16:26] have to run now [01:16:36] will check back tomorrow [01:16:36] k [01:19:18] 10MediaWiki-Interface, 10MediaWiki-extensions-CentralNotice: Local i18n for MediaWiki:Centralnotice-summary - https://phabricator.wikimedia.org/T138284#2494482 (10Bawolff) centralnotice-summary needs to be added to $wgForceUIMsgAsContentMsg on meta (Or changed to be not a content message in general depending o... [01:19:25] (03PS18) 10Catrope: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [01:20:29] 05MW-1.27-release: lighttpd 1.4.40 Redirect Loop - https://phabricator.wikimedia.org/T141328#2494483 (10DarkFeather) [01:22:20] (03PS5) 10Gergő Tisza: Improve management IF return messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/222239 (https://phabricator.wikimedia.org/T63000) [01:22:23] (03PS1) 10Gergő Tisza: Fix FormatJson capitalization [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/301041 [01:22:50] (03PS3) 10WMDE-Fisch: Echo notifications for successful mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) [01:24:21] (03PS1) 10Legoktm: Move MediaHandler defaults out of global scope [core] - 10https://gerrit.wikimedia.org/r/301042 (https://phabricator.wikimedia.org/T141305) [01:24:49] (03CR) 10Legoktm: [C: 032] Fix FormatJson capitalization [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/301041 (owner: 10Gergő Tisza) [01:24:56] 05MW-1.27-release: lighttpd 1.4.40 Redirect Loop - https://phabricator.wikimedia.org/T141328#2494483 (10Bawolff) This might be out of scope for phabricator, and more a http://mediawiki.org/wiki/project:Support_desk question. However in either case, please include all your short url related config (both mediawiki... [01:25:19] (03PS4) 10Gergő Tisza: Remove queue name from OAuth consumer management URL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231746 (https://phabricator.wikimedia.org/T109163) [01:25:28] (03Merged) 10jenkins-bot: Fix FormatJson capitalization [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/301041 (owner: 10Gergő Tisza) [01:26:41] (03PS5) 10Gergő Tisza: Send notifications about app management events [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231989 (https://phabricator.wikimedia.org/T62528) [01:28:07] (03CR) 10jenkins-bot: [V: 04-1] Send notifications about app management events [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231989 (https://phabricator.wikimedia.org/T62528) (owner: 10Gergő Tisza) [01:28:20] (03CR) 10jenkins-bot: [V: 04-1] Move MediaHandler defaults out of global scope [core] - 10https://gerrit.wikimedia.org/r/301042 (https://phabricator.wikimedia.org/T141305) (owner: 10Legoktm) [01:28:50] 05MW-1.27-release: lighttpd 1.4.40 Redirect Loop - https://phabricator.wikimedia.org/T141328#2494483 (10Ciencia_Al_Poder) Probably this lighttpd bug: https://redmine.lighttpd.net/issues/2738 Mentioned on IRC earlier: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/20160720.txt [01:29:16] (03PS6) 10Gergő Tisza: Send notifications about app management events [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231989 (https://phabricator.wikimedia.org/T62528) [01:29:49] 05MW-1.27-release: lighttpd 1.4.40 Redirect Loop - https://phabricator.wikimedia.org/T141328#2494502 (10DarkFeather) Here's my configuration: I have installed MediaWiki to /usr/share/webapps/mediawiki, symlinked as /srv/http/aninix.net/mediawiki/. Webroot is /srv/http/aninix.net. Direct access is via https://an... [01:30:44] 10MediaWiki-Configuration: Unable to override cores default mediahandlers - https://phabricator.wikimedia.org/T141305#2494503 (10Legoktm) Eh, this is going to be a bigger refactoring than I thought. [01:31:26] (03CR) 10Catrope: [C: 04-1] Allow self mentions (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [01:33:02] 05MW-1.27-release: lighttpd 1.4.40 Redirect Loop - https://phabricator.wikimedia.org/T141328#2494505 (10DarkFeather) That does seem related. Thanks, Ciencia -- I can post back when the lighttpd 1.4.41 patch releases and update. [01:35:21] (03PS2) 10Brian Wolff: Use truncated sha256 for token hmac [core] - 10https://gerrit.wikimedia.org/r/178285 (owner: 10CSteipp) [01:38:03] 05MW-1.27-release: lighttpd 1.4.40 Redirect Loop - https://phabricator.wikimedia.org/T141328#2494510 (10Bawolff) Additionally: Setting $wgUsePathInfo = true; is probably a bad idea (Its autodetected based on web server support). The lighttpd config you listed should not depend on $wgUsePathInfo = true as far as... [01:38:15] (03PS1) 10Gergő Tisza: Fix FormatJson capitalization [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/301044 [01:38:58] (03CR) 10Legoktm: [C: 032] Fix FormatJson capitalization [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/301044 (owner: 10Gergő Tisza) [01:39:27] (03CR) 10jenkins-bot: [V: 04-1] Use truncated sha256 for token hmac [core] - 10https://gerrit.wikimedia.org/r/178285 (owner: 10CSteipp) [01:40:30] (03Merged) 10jenkins-bot: Fix FormatJson capitalization [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/301044 (owner: 10Gergő Tisza) [01:45:42] 10GerritBot: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2494515 (10Catrope) [01:46:39] 10grrrit-wm: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2494528 (10Legoktm) [02:01:25] 06Research-and-Data, 10Research-consulting: Onboarding Brent Cohn - https://phabricator.wikimedia.org/T135457#2494558 (10Dzahn) [02:07:11] (03PS1) 10Legoktm: Remove & from GeoCrumbs::completeImplicitIsIn() [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/301047 [02:11:24] (03PS4) 10Aaron Schulz: Move NewPP limit report HTML comments to JS variables [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) [02:11:51] (03CR) 10jenkins-bot: [V: 04-1] Move NewPP limit report HTML comments to JS variables [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [02:13:55] (03CR) 10Liuxinyu970226: [C: 04-1] "No rebase action for two years" [core] - 10https://gerrit.wikimedia.org/r/87288 (https://bugzilla.wikimedia.org/35378) (owner: 10Liangent) [02:19:18] (03PS5) 10Aaron Schulz: Move NewPP limit report HTML comments to JS variables [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) [02:19:25] (03PS5) 10Aaron Schulz: Make onTransactionIdle() safer for multi-DB commits [core] - 10https://gerrit.wikimedia.org/r/300698 [02:24:06] (03CR) 10jenkins-bot: [V: 04-1] Make onTransactionIdle() safer for multi-DB commits [core] - 10https://gerrit.wikimedia.org/r/300698 (owner: 10Aaron Schulz) [02:32:47] (03PS6) 10Aaron Schulz: Make onTransactionIdle() safer for multi-DB commits [core] - 10https://gerrit.wikimedia.org/r/300698 [02:36:52] 10MediaWiki-API, 06Community-Liaisons, 13Patch-For-Review, 07Performance, 07User-notice: Require POST in ?action=purge - https://phabricator.wikimedia.org/T135170#2290536 (10Liuxinyu970226) >>! In T135170#2322828, @Nbdd0121 wrote: > I oppose this change, for users with purge right they should be able to... [02:38:02] someone decided to reinvent the wheel... or the scrollbars in this case. Blame gerrit [02:40:17] (03PS1) 10Aaron Schulz: Clean up forEachOpenConnection() loop and use the method more [core] - 10https://gerrit.wikimedia.org/r/301051 [02:41:20] (03Abandoned) 10Gergő Tisza: [WIP] Don't use user language in AFPUserVisibleException if unavailable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/288927 (https://phabricator.wikimedia.org/T135380) (owner: 10Gergő Tisza) [02:56:57] (03PS2) 10Legoktm: Move MediaHandler defaults out of global scope [core] - 10https://gerrit.wikimedia.org/r/301042 (https://phabricator.wikimedia.org/T141305) [02:57:00] (03PS1) 10Legoktm: Introduce MediaHandlerFactory to create MediaHandler objects [core] - 10https://gerrit.wikimedia.org/r/301054 [02:57:03] (03PS1) 10Legoktm: Override MediaHandlers in tests using MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/301055 [03:01:08] (03CR) 10jenkins-bot: [V: 04-1] Move MediaHandler defaults out of global scope [core] - 10https://gerrit.wikimedia.org/r/301042 (https://phabricator.wikimedia.org/T141305) (owner: 10Legoktm) [03:02:14] (03PS2) 10Legoktm: Override MediaHandlers in tests using MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/301055 [03:02:17] (03PS3) 10Legoktm: Move MediaHandler defaults out of global scope [core] - 10https://gerrit.wikimedia.org/r/301042 (https://phabricator.wikimedia.org/T141305) [03:02:42] (03CR) 10jenkins-bot: [V: 04-1] Introduce MediaHandlerFactory to create MediaHandler objects [core] - 10https://gerrit.wikimedia.org/r/301054 (owner: 10Legoktm) [03:06:56] (03CR) 10jenkins-bot: [V: 04-1] Move MediaHandler defaults out of global scope [core] - 10https://gerrit.wikimedia.org/r/301042 (https://phabricator.wikimedia.org/T141305) (owner: 10Legoktm) [03:08:22] (03CR) 10jenkins-bot: [V: 04-1] Override MediaHandlers in tests using MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/301055 (owner: 10Legoktm) [03:17:06] grrrrr. [03:23:36] 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: [BUG] Support GlobalUserPage extension - https://phabricator.wikimedia.org/T139678#2494644 (10Deskana) [03:23:38] 10GlobalUserPage, 06Wikipedia-Android-App-Backlog: clicking on a user name that has a global page coming from meta in the Android app results in "this page doesn't exist" - https://phabricator.wikimedia.org/T101407#2494646 (10Deskana) [03:26:17] 10GlobalUserPage, 06Wikipedia-Android-App-Backlog: clicking on a user name that has a global page coming from meta in the Android app results in "this page doesn't exist" - https://phabricator.wikimedia.org/T101407#2494648 (10Legoktm) 05duplicate>03Open Let's dupe the other way please so the older task sta... [03:26:30] 10GlobalUserPage, 06Wikipedia-Android-App-Backlog: clicking on a user name that has a global page coming from meta in the Android app results in "this page doesn't exist" - https://phabricator.wikimedia.org/T101407#2494652 (10Legoktm) [03:26:32] 10Mobile-Content-Service, 06Wikipedia-Android-App-Backlog: [BUG] Support GlobalUserPage extension - https://phabricator.wikimedia.org/T139678#2494654 (10Legoktm) [03:26:47] Deskana: ^ [03:31:24] (03CR) 10Legoktm: [C: 04-1] Update update for WMF usages (031 comment) [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/300569 (owner: 10Reedy) [03:31:38] (03CR) 10Legoktm: [C: 032] Don't need to return true in a hook anymore [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/300460 (owner: 10Reedy) [03:31:52] (03CR) 10Legoktm: [C: 032] Use correct string concat operator [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300201 (owner: 10Reedy) [03:32:10] (03CR) 10Legoktm: [C: 032] Fix mixed leading whitespace [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300198 (owner: 10Reedy) [03:32:48] (03CR) 10Legoktm: [C: 032] Update arrays, calls to deprecated functions [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/298379 (owner: 10Reedy) [03:33:24] (03CR) 10Legoktm: [C: 032] Split PoolCounter_ConnectionManager into seperate file [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/298380 (owner: 10Reedy) [03:34:22] (03CR) 10Legoktm: "This change is correct and fixes the linked bug, but I don't think we should be using non-fixed version numbers in composer.json for non-d" [core] - 10https://gerrit.wikimedia.org/r/300891 (https://phabricator.wikimedia.org/T141225) (owner: 10Reedy) [03:36:40] (03Merged) 10jenkins-bot: Don't need to return true in a hook anymore [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/300460 (owner: 10Reedy) [03:43:07] (03Merged) 10jenkins-bot: Use correct string concat operator [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300201 (owner: 10Reedy) [03:43:09] (03Merged) 10jenkins-bot: Fix mixed leading whitespace [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300198 (owner: 10Reedy) [03:43:11] (03Merged) 10jenkins-bot: Update arrays, calls to deprecated functions [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/298379 (owner: 10Reedy) [03:43:13] (03Merged) 10jenkins-bot: Split PoolCounter_ConnectionManager into seperate file [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/298380 (owner: 10Reedy) [03:54:42] 10Wikimedia-General-or-Unknown: Embedded image author, description, and copyright data in file metadata fields missing - https://phabricator.wikimedia.org/T137833#2494658 (10Jatpok) I just had troubles to login to this section ... I cannot fabricate a sample page myself, but I shall ask around. Maybe this matt... [04:28:15] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 07Community-consensus-needed, 07WorkType-NewFunctionality: Enable Machine Translation in English in the content translation tool - https://phabricator.wikimedia.org/T138711#2494666 (10Xaosflux) enwiki is currently discussing chall... [04:43:32] (03PS3) 10PleaseStand: RaggettWrapper: Don't use ReplacementArray [core] - 10https://gerrit.wikimedia.org/r/300255 [04:45:12] (03PS4) 10PleaseStand: RaggettWrapper: Don't use ReplacementArray [core] - 10https://gerrit.wikimedia.org/r/300255 [04:56:34] 10Gerrit, 07Regression, 07Upstream: Gerrit breaks Firefox keyboard shortcuts - https://phabricator.wikimedia.org/T141297#2493581 (10jayvdb) This will take some getting used to. Ctrl-T has hit me a few times. Not an UBN of course, but maybe priority High ? If a full upgrade to 2.12.3 (released July 6) isnt... [05:06:54] (03CR) 10Jforrester: [C: 031] "recheck" [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [05:11:40] (03CR) 10Jforrester: "Oy." [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [05:13:28] (03PS1) 10Tim Starling: Add MWTidy::factory() [core] - 10https://gerrit.wikimedia.org/r/301063 [05:16:54] (03PS1) 10Tim Starling: Use the new MWTidy::factory [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301064 [05:31:03] 06DC-Ops, 06Project-Admins: archive dc-ops people project? - https://phabricator.wikimedia.org/T132478#2494687 (10Dzahn) 05stalled>03declined [05:40:52] 10Gerrit: "needs Verified" error when C+2'ing changes (but patchsets get merged) - https://phabricator.wikimedia.org/T114214#2494690 (10Dzahn) @Paladox do you mean this situation? - user uploads PS1 - jenkins-bot sets V+2 on PS1 - gerrit adds "Verified" to the change in web ui - user amends / rebases and uploa... [06:14:32] 10MediaWiki-extensions-ParserFunctions: Strange urlencode error - https://phabricator.wikimedia.org/T20794#231358 (10Dalba) T24555 is a related newer and more general issue that contains more info. [06:15:34] (03CR) 10Aaron Schulz: "I don't like that the default seems to err on the side of checking less (e.g. if a caller is missing the boolean argument)." [core] - 10https://gerrit.wikimedia.org/r/300842 (https://phabricator.wikimedia.org/T140521) (owner: 10Bartosz Dziewoński) [06:20:56] (03CR) 10BearND: [C: 04-1] Handle page anchors in news titles (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/300985 (https://phabricator.wikimedia.org/T141307) (owner: 10Mholloway) [06:29:24] 10Gerrit: Gerrit login/password change: wikitech username has to be used for log-in instead of other user-name - https://phabricator.wikimedia.org/T64317#2494708 (10Nemo_bis) 05Open>03declined [06:43:51] (03PS1) 10Aaron Schulz: Simplify and cleanup SubmissionHandler transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301069 (https://phabricator.wikimedia.org/T141172) [06:46:16] 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 2, 13Patch-For-Review, and 2 others: cxsave API fails if the translation exist and in deleted status - https://phabricator.wikimedia.org/T137187#2494725 (10Nikerabbit) I don't think this actu... [06:46:49] (03CR) 10jenkins-bot: [V: 04-1] Simplify and cleanup SubmissionHandler transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301069 (https://phabricator.wikimedia.org/T141172) (owner: 10Aaron Schulz) [06:48:49] (03CR) 10Aaron Schulz: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301069 (https://phabricator.wikimedia.org/T141172) (owner: 10Aaron Schulz) [07:06:21] (03CR) 10Nikerabbit: "Usually I would say keep it simple, but if we transform the numbers in the code, we could make the message optional and not bother transla" [core] - 10https://gerrit.wikimedia.org/r/299108 (https://phabricator.wikimedia.org/T8948) (owner: 10Kaldari) [07:11:51] 10MediaWiki-extensions-Score: crackling at start of OGG renditions of MIDI files (fixed in TiMidity++ 2.14.0) - https://phabricator.wikimedia.org/T50029#520707 (10Stemby) I think timidity should be replaced by fluidsynth. ``` $ fluidsynth /usr/share/sounds/sf2/FluidR3_GM.sf2 -T oga -F my_file.ogg my_file.midi ``` [07:13:44] 10MediaWiki-extensions-Score, 10TimedMediaHandler: Move TiMidity conversion from Score into TimedMediaHandler - https://phabricator.wikimedia.org/T135597#2304173 (10Stemby) I think timidity should be replaced by fluidsynth. ``` $ fluidsynth /usr/share/sounds/sf2/FluidR3_GM.sf2 -T oga -F my_file.ogg my_file.mi... [07:16:39] 10MediaWiki-Database, 10DBA, 07User-notice, 07Wikimedia-log-errors: Special:Block request makes the database timeout on db1055 - https://phabricator.wikimedia.org/T140650#2494764 (10jcrespo) Bsadowski1: > block a user at the same time as another administrator completed the action > Special:Undelete are p... [07:16:51] 10MediaWiki-Database, 10DBA, 07User-notice, 07Wikimedia-log-errors: Special:Block request makes the database timeout on db1055 - https://phabricator.wikimedia.org/T140650#2494765 (10jcrespo) a:03jcrespo [07:27:25] 10Phabricator (Upstream), 07Upstream: Phabricator project page should not default to workboard - https://phabricator.wikimedia.org/T89865#2494776 (10Tgr) Thinking about this a bit more, the clever solution would be to take the user to the workboard if they are subscribed to the project, and to the project page... [07:27:54] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Wikidata descriptions are not showing in beta unless enabled in stable - https://phabricator.wikimedia.org/T141067#2494777 (10bmansurov) a:03bmansurov [07:35:02] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2494793 (10Gilles) [07:36:50] 10MediaWiki-extensions-WikibaseMediaInfo, 10Wikidata, 03Wikidata-Sprint-2016-07-19: Catchable fatal error: Argument 1 passed to MediaWiki\\Linker\\LinkRenderer::makeKnownLink() must implement interface MediaWiki\\Linker\\LinkTarget, null given in /var/www/wik... - https://phabricator.wikimedia.org/T141322#2494807 [07:37:57] 10MediaWiki-extensions-WikibaseMediaInfo, 10Wikidata, 03Wikidata-Sprint-2016-07-19: Catchable fatal error: Argument 1 passed to MediaWiki\\Linker\\LinkRenderer::makeKnownLink() must implement interface MediaWiki\\Linker\\LinkTarget, null given in /var/www/wik... - https://phabricator.wikimedia.org/T141322#2494277 [07:47:15] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Wikidata descriptions are not showing in beta unless enabled in stable - https://phabricator.wikimedia.org/T141067#2494811 (10bmansurov) 05Open>03stalled Wikidata descriptions as taglines are enabled only on the followin... [07:49:58] 10MediaWiki-extensions-Other, 07I18n: [[MediaWiki:Maps-googlemaps3-par-clustermaxzoom/he]] i18n issue - https://phabricator.wikimedia.org/T139935#2494827 (10Kghbln) 05Open>03declined Thanks for asking. Now tracked at [[ https://github.com/JeroenDeDauw/Maps/issues/188 | GitHub (issue 188)]]. [07:50:35] 10MediaWiki-Database, 10MediaWiki-JobRunner, 10DBA, 07Performance: /* RenameUserJob::run */ of user Burgundo created >1000 seconds of lag on itwiki (db1036), impacting recentchanges, whatchlist and log visualization of all s2 wikis - https://phabricator.wikimedia.org/T141340#2494829 (10jcrespo) [07:51:44] 10MediaWiki-Database, 10MediaWiki-JobRunner, 10DBA, 07Performance: /* RenameUserJob::run */ of user Burgundo created >1000 seconds of lag on itwiki (db1036), impacting recentchanges, whatchlist and log visualization of all s2 wikis - https://phabricator.wikimedia.org/T141340#2494842 (10jcrespo) [07:52:41] 07Design, 10MediaWiki-extensions-WikibaseRepository, 06WMDE-Design, 10Wikidata, and 2 others: [Story] making entities more visual - image in header - https://phabricator.wikimedia.org/T119493#2494843 (10Jan_Dittrich) [07:55:19] 07Design, 10MediaWiki-extensions-WikibaseRepository, 06WMDE-Design, 10Wikidata, and 2 others: [Story] making entities more visual - image in header - https://phabricator.wikimedia.org/T119493#2494845 (10Jan_Dittrich) @Jonas currently this issue seems to be stalled. I would assume that there are good reaso... [07:58:13] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2494860 (10Gilles) [08:00:22] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2494877 (10Gilles) [08:01:56] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2494793 (10Gilles) I'm waiting on the new labs project being created for a bigger instance, because I was stuck on a small one and building tar generates huge files a... [08:05:30] 07Design, 10MediaWiki-extensions-WikibaseRepository, 06WMDE-Design, 10Wikidata, and 2 others: [Story] making entities more visual - image in header - https://phabricator.wikimedia.org/T119493#2494885 (10Jonas) No, Adrians patches are only refactoring the JS code. The HTML structure is still the same. [08:12:17] 10MediaWiki-Database, 10MediaWiki-JobRunner, 10MediaWiki-extensions-Renameuser, 10DBA, 07Performance: /* RenameUserJob::run */ of user Burgundo created >1000 seconds of lag on itwiki (db1036), impacting recentchanges, watchlist and log visualization of al... - https://phabricator.wikimedia.org/T141340#2494908 [08:13:32] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Prepare mobile language button for deployment - https://phabricator.wikimedia.org/T140260#2458450 (10phuedx) a:03phuedx [08:18:39] 10MediaWiki-ResourceLoader, 07JavaScript: Remove JSON polyfill - https://phabricator.wikimedia.org/T141344#2494928 (10Schnark) [08:22:36] 10Collection: PDF (book) creation fails to render the table "Die zehn höchsten Scheitelwasserstände am Pegel Hohensaaten" on https://de.wikipedia.org/wiki/Oderbruch#Oderhochwasser - https://phabricator.wikimedia.org/T140414#2494946 (10Wikinaut) Update: I found, that when I use the "preview" of the PediaPress... [08:23:55] (03PS7) 10Aaron Schulz: Make onTransactionIdle() safer for multi-DB commits [core] - 10https://gerrit.wikimedia.org/r/300698 [08:24:56] 10Connected-Open-Heritage-New-data, 10Wiki-Loves-Monuments-Sources, 13Patch-For-Review: Add Albanian Wikipedia lists to database - https://phabricator.wikimedia.org/T140488#2494947 (10Lokal_Profil) >>! In T140488#2484825, @Liridon wrote: >>>! In T140488#2483495, @Lokal_Profil wrote: >>>>! In T140488#2483152,... [08:25:29] 10MediaWiki-extensions-Score, 10TimedMediaHandler: Move TiMidity conversion from Score into TimedMediaHandler - https://phabricator.wikimedia.org/T135597#2494948 (10Aklapper) @Stemby: Welcome to Phabricator and thanks for registering an account. Please note that "I think Blue looks better than Red" comments (e... [08:25:37] 10MediaWiki-extensions-Score: crackling at start of OGG renditions of MIDI files (fixed in TiMidity++ 2.14.0) - https://phabricator.wikimedia.org/T50029#2494949 (10Aklapper) @Stemby: Welcome to Phabricator and thanks for registering an account. Please note that "I think Blue looks better than Red" comments (espe... [08:28:11] (03PS6) 10Legoktm: Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 [08:32:23] (03Abandoned) 10Legoktm: [DNM] fail validation [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/301004 (owner: 10Legoktm) [08:35:16] 10Gerrit, 10Wikimedia-Logstash: Add gerrit event stream events to logstash - https://phabricator.wikimedia.org/T64505#2494955 (10hashar) [08:39:57] 10MediaWiki-extensions-Score, 10TimedMediaHandler: Move TiMidity conversion from Score into TimedMediaHandler - https://phabricator.wikimedia.org/T135597#2494959 (10Stemby) OK, sorry to bother you. Read my previous message as "please note that your work risks being lost time, because IMHO timidity should be re... [08:42:34] 10MediaWiki-extensions-Listings, 10Kartographer, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2494963 (10T.seppelt) [08:43:11] 10Wiki-Loves-Monuments-Sources, 13Patch-For-Review: Map sources using Wikidata to wd_item - https://phabricator.wikimedia.org/T140795#2494979 (10Lokal_Profil) [08:44:23] 10MediaWiki-extensions-Listings, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit Listings - https://phabricator.wikimedia.org/T48225#2494983 (10T.seppelt) [08:44:27] 10MediaWiki-extensions-Listings, 10Kartographer, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2494982 (10T.seppelt) [08:46:05] 10MediaWiki-extensions-Score: crackling at start of OGG renditions of MIDI files (fixed in TiMidity++ 2.14.0) - https://phabricator.wikimedia.org/T50029#2494987 (10Stemby) My comment IS focused. The previous command _does_ exactly MIDI conversion to OGG, without crackling at start. Please note that timidity ris... [08:46:49] 10MediaWiki-extensions-Listings, 06Discovery, 10Kartographer, 06Maps, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2494988 (10T.seppelt) [08:51:43] 10MediaWiki-Parser: setHook (et al) allows silly tag names - https://phabricator.wikimedia.org/T141283#2494996 (10Aklapper) [ Removing #Parsing-Team, setting #MediaWiki-Parser project] [09:00:44] 10MediaWiki-extensions-Listings, 06Discovery, 10Kartographer, 06Maps, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2494963 (10Esc3300) One of the issues currently preventing this at Wikivoyage seems to be that: for many of the standard-sized articles, the... [09:02:19] 10MediaWiki-extensions-Listings, 06Discovery, 10Kartographer, 06Maps, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2495024 (10Esc3300) I think this could be a good sample of using Wikidata to edit listings. [09:05:16] 10MediaWiki-extensions-Listings, 06Discovery, 10Kartographer, 06Maps, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2495029 (10T.seppelt) I think this shouldn't prevent us from creating the technical possibility of using Wikidata. And secondly we're going t... [09:07:24] 10MediaWiki-extensions-Listings, 06Discovery, 10Kartographer, 06Maps, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2495031 (10Esc3300) I think technically it's already possible (arbitrary access is available). [09:10:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Regression: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2495045 (10Sjoerddebruin) [09:10:20] 10MediaWiki-Parser: setHook (et al) allows silly tag names - https://phabricator.wikimedia.org/T141283#2492984 (10Legoktm) To be clear...this is about developers writing extensions with stupidly named hooks? And that MW doesn't prevent them from doing that? [09:10:44] 10MediaWiki-extensions-Listings, 06Discovery, 10Kartographer, 06Maps, 10Wikidata: Using Wikidata in Wikivoyage Listings - https://phabricator.wikimedia.org/T141345#2495050 (10T.seppelt) Yes. But can we omit the location parameters without breaking the parsing for the Kartographer maps? And on which level... [09:15:09] 10Gerrit: Gerrit bug search not (naively) working with Phabricator tasks - https://phabricator.wikimedia.org/T85002#2495069 (10Aklapper) The test case in the initial description can still be reproduced. Whether it's worth to care or not is a different question. :) [09:28:08] 10Wiki-Loves-Monuments-Sources, 13Patch-For-Review: Map sources using Wikidata to wd_item - https://phabricator.wikimedia.org/T140795#2495077 (10JeanFred) Not sure it worked though :-( https://tools.wmflabs.org/heritage/api/api.php?action=search&srcountry=gb-en&srwithwd_item=1&format=json [09:33:56] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Wikidata descriptions are not showing in beta unless enabled in stable - https://phabricator.wikimedia.org/T141067#2495079 (10Jhernandez) 05stalled>03Open @bmansurov wikidata descriptions are supposed to show up in beta... [09:34:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2495082 (10Lydia_Pintscher) [09:37:57] (03CR) 10Kghbln: "Ouch. I should not have merged this without testing. MediaWiki 1.27 fatals when trying to invoke this extension:" [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300556 (owner: 10Florianschmidtwelzow) [09:39:22] 06Developer-Relations (Jul-Sep-2016): Sort out PdfBook extension fork situation: Disable Wikimedia repo; link to GitHub repo - https://phabricator.wikimedia.org/T124978#2495089 (10Aklapper) I asked @Nad on https://www.mediawiki.org/wiki/User_talk:Nad#PdfBook_extension:_Canonical_source to hopefully sort this out... [09:43:54] (03CR) 10DCausse: [C: 031] "The mapping generated matches what we expect with default settings." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/288567 (https://phabricator.wikimedia.org/T89733) (owner: 10Smalyshev) [09:45:34] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Wikidata descriptions are not showing in beta unless enabled in stable - https://phabricator.wikimedia.org/T141067#2495094 (10bmansurov) OK, makes sense. [09:47:13] 10MediaWiki-extensions-Translate: Special:MessageGroupStats throws "Nothing to show for requested statistics." sometimes even when it should - https://phabricator.wikimedia.org/T118681#2495097 (10Glaisher) [09:47:19] (03CR) 10Kghbln: [C: 04-1] "I will fix master" (031 comment) [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300557 (https://phabricator.wikimedia.org/T137684) (owner: 10Florianschmidtwelzow) [09:48:40] (03CR) 10Kghbln: "version needs to be 1 I believe. Will do a patch-set" [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300556 (owner: 10Florianschmidtwelzow) [09:52:04] 10MediaWiki-extensions-Translate: Special:MessageGroupStats throws "Nothing to show for requested statistics." sometimes even when it should - https://phabricator.wikimedia.org/T118681#1806458 (10Glaisher) The statistics are stored in the DB and the output rows are cached in memcached. If something wrong gets ca... [09:57:02] 10SUL-Finalization: SUL-unify MediaWiki spam cleanup? - https://phabricator.wikimedia.org/T141251#2491504 (10Peachey88) Where does that account come from? I don't think its one used in a maintenance script anywhere… [09:59:04] (03PS1) 10Kghbln: Fix fatal and other tweaks [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/301086 [10:01:56] (03CR) 10Kghbln: "According to the docu version 1 is the only supported version for MediaWiki. See https://www.mediawiki.org/wiki/Manual:Developing_extensio" [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/301086 (owner: 10Kghbln) [10:03:05] (03CR) 10Kghbln: "See https://gerrit.wikimedia.org/r/301086 as a follow up" [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300556 (owner: 10Florianschmidtwelzow) [10:03:06] 10Collection: PDF (book) creation fails to render the table "Die zehn höchsten Scheitelwasserstände am Pegel Hohensaaten" on https://de.wikipedia.org/wiki/Oderbruch#Oderhochwasser - https://phabricator.wikimedia.org/T140414#2495147 (10Aklapper) >>! In T140414#2494946, @Wikinaut wrote: > pls. fix. Please see my... [10:04:47] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2495148 (10Gilles) [10:07:17] (03PS1) 10Bartosz Dziewoński: mediawiki.special.userlogin.signup: Remove unnecessary field hiding code [core] - 10https://gerrit.wikimedia.org/r/301089 [10:07:59] (03PS2) 10Bartosz Dziewoński: mediawiki.special.userlogin.signup: Remove unnecessary field hiding code [core] - 10https://gerrit.wikimedia.org/r/301089 [10:08:36] 10grrrit-wm: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2494515 (10Paladox) This is fixed in gerrit 2.12.3 See https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.11.9.html which was added into gerrit 2.12.3 Issue... [10:08:51] 10Gerrit, 10grrrit-wm: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2495161 (10Paladox) [10:09:01] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.special.userlogin.signup: Remove unnecessary field hiding code [core] - 10https://gerrit.wikimedia.org/r/301089 (owner: 10Bartosz Dziewoński) [10:09:23] 10Gerrit, 10grrrit-wm: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2494515 (10Paladox) [10:09:26] 10Gerrit: Update gerrit to 2.12.3 - https://phabricator.wikimedia.org/T141245#2495162 (10Paladox) [10:10:53] 10grrrit-wm: grrrit-wm reports edit publishes as changes by the owner even if another user did an edit - https://phabricator.wikimedia.org/T141271#2495165 (10Glaisher) [10:10:55] 10Gerrit, 10grrrit-wm: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2495168 (10Glaisher) [10:13:30] 07Design, 06Discovery, 06WMDE-Design, 10Wikidata, and 2 others: Product branding for Wikidata Query service - https://phabricator.wikimedia.org/T140577#2495170 (10Jonas) Not sure if reinventing the logo is a good idea. I think we should use a modified Wikidata logo. [10:16:06] 10Gerrit: Update gerrit to 2.12.3 - https://phabricator.wikimedia.org/T141245#2495173 (10jayvdb) [10:17:40] 10MediaWiki-extensions-WikibaseRepository, 10MediaWiki-extensions-WikibaseView, 10Wikidata: Simple html formatting within Wikidata labels - https://phabricator.wikimedia.org/T139573#2495176 (10VIGNERON) >>! In T139573#2488312, @Bugreporter wrote: > You may use characters ᵃᵇᶜᵈᵉᶠᵍʰⁱʲᵏˡᵐⁿᵒᵖʳˢᵗᵘᵛʷˣʸᶻ instead (no... [10:19:03] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2495186 (10Gilles) a:05Gilles>03fgiunchedi The needed backports all build successfully and are available here: https://github.com/gi11es/thumbor-debian/tree/mast... [10:21:27] 10MediaWiki-History-or-Diffs, 06Release-Engineering-Team, 07Beta-Cluster-reproducible, 05MW-1.28-release-notes, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Viewing diffs throws 503@beta - https://phabricator.wikimedia.org/T141272#2495201 (10Danny_B) [10:21:37] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2495202 (10Danny_B) [10:29:16] 10Dumps-Generation: Move misc cron jobs from snapshot1003 to new server(s) - https://phabricator.wikimedia.org/T133694#2495206 (10ArielGlenn) [10:30:35] 10Dumps-Generation: Move misc cron jobs from snapshot1003 to new server(s) - https://phabricator.wikimedia.org/T133694#2239545 (10ArielGlenn) [10:31:39] (03CR) 10DCausse: Push common search api parameters into SearchApi class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/292477 (owner: 10EBernhardson) [10:32:11] (03CR) 10Bartosz Dziewoński: "The default should be checking more, unless I messed up the logic somewhere. I'm not sure if it makes sense to use a more generic name, I " [core] - 10https://gerrit.wikimedia.org/r/300842 (https://phabricator.wikimedia.org/T140521) (owner: 10Bartosz Dziewoński) [10:36:34] 10Collection: PDF (book) creation fails to render the table "Die zehn höchsten Scheitelwasserstände am Pegel Hohensaaten" on https://de.wikipedia.org/wiki/Oderbruch#Oderhochwasser - https://phabricator.wikimedia.org/T140414#2495209 (10Wikinaut) @Aklapper I don't understand your comment. Fact is: >> PediaPress... [10:36:43] 04(no projects): Change the default mode of tags to mode=packed on English Wikipedia - https://phabricator.wikimedia.org/T141349#2495210 (10AdamCuerden) [10:38:07] 04(no projects): Change the default mode of tags to mode=packed on English Wikipedia - https://phabricator.wikimedia.org/T141349#2495222 (10Aklapper) [10:38:30] 10MediaWiki-Gallery, 10Wikimedia-Site-requests: Change the default mode of tags to mode=packed on English Wikipedia - https://phabricator.wikimedia.org/T141349#2495226 (10Aklapper) [10:42:17] 10Gerrit: Gerrit bug search not (naively) working with Phabricator tasks - https://phabricator.wikimedia.org/T85002#2495228 (10Paladox) Yep it Is still reproducible, I'm wondering if it is infact the plugins that do this if so maybe we can extend it in its-phabricator plugin, if not we can find where the source... [10:43:38] (03PS1) 10Aaron Schulz: Renamed MWCallableUpdate class file to match the class [core] - 10https://gerrit.wikimedia.org/r/301097 [10:44:49] (03CR) 10Addshore: Allow self mentions (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) (owner: 10Addshore) [10:44:54] (03PS4) 10Addshore: Allow self mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295489 (https://phabricator.wikimedia.org/T138080) [10:45:11] 10Gerrit: "needs Verified" error when C+2'ing changes (but patchsets get merged) - https://phabricator.wikimedia.org/T114214#2495232 (10Paladox) Nope it is the buttons you press, I belive if is because a user presses publish and submit with jenkins tested and it v+2 which makes it error out, but not sure if it h... [10:45:44] (03CR) 10Addshore: [C: 032] Renamed MWCallableUpdate class file to match the class [core] - 10https://gerrit.wikimedia.org/r/301097 (owner: 10Aaron Schulz) [10:52:05] (03Merged) 10jenkins-bot: Renamed MWCallableUpdate class file to match the class [core] - 10https://gerrit.wikimedia.org/r/301097 (owner: 10Aaron Schulz) [10:52:24] (03PS3) 10Addshore: Remove deprecated unused ProfileSection class [core] - 10https://gerrit.wikimedia.org/r/298956 [10:52:33] (03PS2) 10Addshore: Remove unused deprecated WatchedItem methods [core] - 10https://gerrit.wikimedia.org/r/298954 [10:56:45] (03CR) 10jenkins-bot: [V: 04-1] Remove deprecated unused ProfileSection class [core] - 10https://gerrit.wikimedia.org/r/298956 (owner: 10Addshore) [10:57:30] (03Abandoned) 10Addshore: Remove deprecated unused ProfileSection class [core] - 10https://gerrit.wikimedia.org/r/298956 (owner: 10Addshore) [11:10:56] 10Gerrit, 07Upstream: +10⇧/+10⇩ links for showing context are broken - https://phabricator.wikimedia.org/T60252#638574 (10Paladox) Is this still a problem since it seems fixed in gerrit 2.11 which were running gerrit 2.12? [11:13:28] (03CR) 10DCausse: "Nice cleanup, we are getting close to be able to allow extensions to customize search syntax." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/298112 (owner: 10EBernhardson) [11:13:56] (03PS1) 10Phuedx: Extract page action creators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301102 (https://phabricator.wikimedia.org/T140260) [11:13:58] (03PS1) 10Phuedx: [Hygiene] Test SkinMinerva#isAllowedPageAction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301103 (https://phabricator.wikimedia.org/T140260) [11:14:00] (03PS1) 10Phuedx: [Hygiene] Extend SkinMinerva#isAllowedPageAction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301104 (https://phabricator.wikimedia.org/T140260) [11:15:48] (03CR) 10Addshore: [V: 032] Change Toolbox link from Main contributors to Page contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/300713 (https://phabricator.wikimedia.org/T139887) (owner: 10Devirk) [11:16:45] (03PS4) 10Addshore: Change Toolbox link from Main contributors to Page contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/300713 (https://phabricator.wikimedia.org/T139887) (owner: 10Devirk) [11:17:03] (03CR) 10Addshore: Change Toolbox link from Main contributors to Page contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/300713 (https://phabricator.wikimedia.org/T139887) (owner: 10Devirk) [11:17:05] (03CR) 10Addshore: [C: 032] Change Toolbox link from Main contributors to Page contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/300713 (https://phabricator.wikimedia.org/T139887) (owner: 10Devirk) [11:17:09] (03PS31) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [11:19:36] (03CR) 10WMDE-Fisch: Echo notifications for mention failures (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:21:55] (03Merged) 10jenkins-bot: Change Toolbox link from Main contributors to Page contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/300713 (https://phabricator.wikimedia.org/T139887) (owner: 10Devirk) [11:28:27] (03PS19) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [11:28:55] (03CR) 10WMDE-Fisch: "PS19 is a manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) (owner: 10WMDE-Fisch) [11:30:41] 10MediaWiki-extensions-WikibaseRepository, 10MobileFrontend, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2495305 (10hoo) I looked at this: Special:Nearby is using the display title again, but per T1... [11:31:50] (03PS1) 10Hoo man: Don't override the wbptterms GET parameter in extendSearchParams [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) [11:32:57] 10Gerrit, 10grrrit-wm: Patchsets created through web interface attributed to the wrong user - https://phabricator.wikimedia.org/T141329#2495311 (10Paladox) Looking at it I'm not sure if it is fixed in gerrit 2.12.3 not really sure. Could you file this upstream please to see what there response is since it is... [11:33:44] 10MediaWiki-extensions-WikibaseRepository, 10MobileFrontend, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2495312 (10hoo) a:03hoo [11:33:54] (03CR) 10DCausse: [C: 032] Remove optional ns filter optimization [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300994 (owner: 10EBernhardson) [11:34:32] (03PS32) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [11:35:43] 07Design, 06Discovery, 06WMDE-Design, 10Wikidata, and 2 others: Product branding for Wikidata Query service - https://phabricator.wikimedia.org/T140577#2495314 (10Charlie_WMDE) I'm not sure if that's allowed. [11:36:00] (03CR) 10jenkins-bot: [V: 04-1] Don't override the wbptterms GET parameter in extendSearchParams [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [11:36:08] (03CR) 10WMDE-Fisch: [C: 04-1] "PS 31 is bit ... f** up o.O" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) (owner: 10WMDE-Fisch) [11:36:20] (03CR) 10DCausse: [C: 031] Take SearchConfig directly in SearchTextQueryBuilders [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300953 (owner: 10EBernhardson) [11:41:01] (03Merged) 10jenkins-bot: Remove optional ns filter optimization [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300994 (owner: 10EBernhardson) [11:47:32] (03PS33) 10WMDE-Fisch: Echo notifications for mention failures [extensions/Echo] - 10https://gerrit.wikimedia.org/r/295351 (https://phabricator.wikimedia.org/T136326) [11:51:35] (03PS20) 10WMDE-Fisch: Add mention failure notification for multiple section edits [extensions/Echo] - 10https://gerrit.wikimedia.org/r/298419 (https://phabricator.wikimedia.org/T138942) [11:52:16] (03CR) 10Legoktm: [C: 032] Remove unused deprecated WatchedItem methods [core] - 10https://gerrit.wikimedia.org/r/298954 (owner: 10Addshore) [11:52:27] legoktm: why are you awake! [11:52:41] oops [11:52:46] I was fighting with phpunit [11:52:52] xD [11:52:55] 10MediaWiki-extensions-UniversalLanguageSelector, 07I18n: Languages appear repeated for each region in search results despite being the only result - https://phabricator.wikimedia.org/T41921#2495321 (10Nikerabbit) 05Resolved>03Open Fix was reverted. I assume that means this needs to be reconsidered. [11:53:03] its 5am.... [11:53:06] 10MediaWiki-extensions-UniversalLanguageSelector, 07I18n: Languages appear repeated for each region in search results despite being the only result - https://phabricator.wikimedia.org/T41921#2495324 (10Nikerabbit) [11:57:13] (03PS4) 10WMDE-Fisch: Echo notifications for successful mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) [11:57:48] (03CR) 10WMDE-Fisch: "PS4 is a manual rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300856 (https://phabricator.wikimedia.org/T139623) (owner: 10WMDE-Fisch) [11:58:39] (03CR) 10Hoo man: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [11:59:37] (03Merged) 10jenkins-bot: Remove unused deprecated WatchedItem methods [core] - 10https://gerrit.wikimedia.org/r/298954 (owner: 10Addshore) [12:00:15] (03PS1) 10Addshore: dewiki_diffstats add rev timestamps & feature state [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/301110 (https://phabricator.wikimedia.org/T135751) [12:01:31] (03CR) 10Legoktm: "recheck" [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301064 (owner: 10Tim Starling) [12:02:03] legoktm: https://gerrit.wikimedia.org/r/#/c/301110/ ? ;) (as your awake)... [12:03:14] (03CR) 10Legoktm: [C: 032] Use the new MWTidy::factory [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301064 (owner: 10Tim Starling) [12:03:17] (03CR) 10Legoktm: [C: 032] Add MWTidy::factory() [core] - 10https://gerrit.wikimedia.org/r/301063 (owner: 10Tim Starling) [12:05:28] 10Continuous-Integration-Infrastructure (phase-out-gallium): Target architecture without gallium.wikimedia.org - https://phabricator.wikimedia.org/T133300#2495334 (10hashar) [12:06:49] (03CR) 10Legoktm: [C: 032] dewiki_diffstats add rev timestamps & feature state [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/301110 (https://phabricator.wikimedia.org/T135751) (owner: 10Addshore) [12:07:26] (03CR) 10Legoktm: [C: 032] Remove modulemessages from ApiParse and Output (deprecated in 1.26) [core] - 10https://gerrit.wikimedia.org/r/300995 (owner: 10Krinkle) [12:08:52] 10Collection: PDF (book) creation fails to render the table "Die zehn höchsten Scheitelwasserstände am Pegel Hohensaaten" on https://de.wikipedia.org/wiki/Oderbruch#Oderhochwasser - https://phabricator.wikimedia.org/T140414#2495335 (10Aklapper) >>! In T140414#2495209, @Wikinaut wrote: > Mediawiki/Wikipedia rende... [12:09:05] (03CR) 10Legoktm: [C: 032] SectionProfiler: Remove $profileOutCallback [core] - 10https://gerrit.wikimedia.org/r/300866 (owner: 10PleaseStand) [12:09:25] (03CR) 10Legoktm: [C: 032] syncFileBackend.php: ellapsed => elapsed [core] - 10https://gerrit.wikimedia.org/r/300875 (owner: 10PleaseStand) [12:10:38] (03Merged) 10jenkins-bot: Add MWTidy::factory() [core] - 10https://gerrit.wikimedia.org/r/301063 (owner: 10Tim Starling) [12:10:41] (03Merged) 10jenkins-bot: Use the new MWTidy::factory [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301064 (owner: 10Tim Starling) [12:10:45] (03Merged) 10jenkins-bot: dewiki_diffstats add rev timestamps & feature state [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/301110 (https://phabricator.wikimedia.org/T135751) (owner: 10Addshore) [12:11:16] (03CR) 10Legoktm: [C: 032] mediawiki.htmlform: Remove deprecated $.fn.liveAndTestAtStart [core] - 10https://gerrit.wikimedia.org/r/300850 (owner: 10Bartosz Dziewoński) [12:13:42] (03CR) 10Legoktm: [C: 032] WebRequest::getText(): Update more of the doc comment [core] - 10https://gerrit.wikimedia.org/r/300231 (owner: 10PleaseStand) [12:15:22] (03Merged) 10jenkins-bot: Remove modulemessages from ApiParse and Output (deprecated in 1.26) [core] - 10https://gerrit.wikimedia.org/r/300995 (owner: 10Krinkle) [12:15:45] (03CR) 10Legoktm: [C: 032] Make importTextFiles.php work with wildcards on the Windows shell [core] - 10https://gerrit.wikimedia.org/r/299286 (owner: 10TTO) [12:16:09] (03Merged) 10jenkins-bot: SectionProfiler: Remove $profileOutCallback [core] - 10https://gerrit.wikimedia.org/r/300866 (owner: 10PleaseStand) [12:16:22] (03CR) 10Legoktm: [C: 032] API: Use rev_user when possible for list=usercontribs [core] - 10https://gerrit.wikimedia.org/r/280047 (https://phabricator.wikimedia.org/T131065) (owner: 10Anomie) [12:18:35] (03CR) 10Legoktm: [C: 04-2] "Er what? Did you read the comment? It should be uncommented once the extension is no longer being loaded via the deprecated PHP entry poin" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/295378 (owner: 10Mholloway) [12:20:05] (03CR) 10Legoktm: "It was moved back right?" [core] - 10https://gerrit.wikimedia.org/r/299134 (owner: 10Umherirrender) [12:20:26] (03Merged) 10jenkins-bot: syncFileBackend.php: ellapsed => elapsed [core] - 10https://gerrit.wikimedia.org/r/300875 (owner: 10PleaseStand) [12:21:27] (03PS1) 10Bartosz Dziewoński: Don't magically make MediaWiki\Widget classes infusable [core] - 10https://gerrit.wikimedia.org/r/301111 [12:21:30] (03PS1) 10Bartosz Dziewoński: Do not automatically infuse any OOjs UI widgets [core] - 10https://gerrit.wikimedia.org/r/301112 [12:22:48] (03CR) 10Bartosz Dziewoński: "Having pondered on this for a year I'm increasingly convinced this makes things too magical and too difficult to work out when the magic f" [core] - 10https://gerrit.wikimedia.org/r/213505 (owner: 10Catrope) [12:23:44] (03Merged) 10jenkins-bot: mediawiki.htmlform: Remove deprecated $.fn.liveAndTestAtStart [core] - 10https://gerrit.wikimedia.org/r/300850 (owner: 10Bartosz Dziewoński) [12:23:47] (03CR) 10Legoktm: [C: 032] Apply $wgMaxArticleSize more exactly [core] - 10https://gerrit.wikimedia.org/r/296241 (owner: 10Anomie) [12:24:47] 07Design, 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, and 3 others: ULS basic visual design issues - https://phabricator.wikimedia.org/T138235#2394294 (10Nikerabbit) My attempt to follow the mock of @Pginer-WMF is at https://dev.translat... [12:25:50] (03CR) 10Reedy: Update update for WMF usages (032 comments) [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/300569 (owner: 10Reedy) [12:25:54] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10The-Wikipedia-Library, 10Wikimedia-General-or-Unknown, 13Patch-For-Review: Implement Schema:ExternalLinkChange - https://phabricator.wikimedia.org/T115119#2495363 (10Sadads) Finally! Yay! Super excited! [12:26:41] (03Merged) 10jenkins-bot: WebRequest::getText(): Update more of the doc comment [core] - 10https://gerrit.wikimedia.org/r/300231 (owner: 10PleaseStand) [12:30:22] (03Merged) 10jenkins-bot: Make importTextFiles.php work with wildcards on the Windows shell [core] - 10https://gerrit.wikimedia.org/r/299286 (owner: 10TTO) [12:33:55] (03Merged) 10jenkins-bot: API: Use rev_user when possible for list=usercontribs [core] - 10https://gerrit.wikimedia.org/r/280047 (https://phabricator.wikimedia.org/T131065) (owner: 10Anomie) [12:34:19] (03Merged) 10jenkins-bot: Apply $wgMaxArticleSize more exactly [core] - 10https://gerrit.wikimedia.org/r/296241 (owner: 10Anomie) [12:35:34] (03CR) 10Mholloway: "As a rule, we prefer not to have commented-out code cluttering codebases that we maintain. It can be added when it's needed. Is there a " [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/295378 (owner: 10Mholloway) [12:38:48] (03CR) 10DCausse: Move Searcher::searchText() into dedicated class (035 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300954 (owner: 10EBernhardson) [12:42:02] 10Continuous-Integration-Infrastructure (phase-out-gallium): Target architecture without gallium.wikimedia.org - https://phabricator.wikimedia.org/T133300#2495369 (10hashar) >>! In T133300#2491756, @faidon wrote: > The wiki page on the summary of the task seems to be deleted with a comment of "not needed anymore... [12:52:59] (03CR) 10WMDE-Fisch: "@Catrope here a short example what is fixed with that:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300528 (https://phabricator.wikimedia.org/T138938) (owner: 10Jakob) [12:59:58] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 2: Show languages that a wiki community added to the top of the interlanguage list in the Compact list - https://phabricator.wikimedia.org/T138973#2495406 (10Nikerab... [13:13:40] 10Wikimedia-Extension-setup, 07Tracking: Extensions needing to be removed from Wikimedia wikis - https://phabricator.wikimedia.org/T106123#2495418 (10Mholloway) [13:15:48] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 2: Nedersaksies doesn't appear in Compact Language List panel - https://phabricator.wikimedia.org/T139795#2495424 (10Nikerabbit) a:03Nikerabbit The proposed fix i... [13:17:56] 10Wikimedia-Extension-setup, 07Tracking: Extensions needing to be removed from Wikimedia wikis - https://phabricator.wikimedia.org/T106123#2495430 (10Mholloway) [13:24:25] 04(no projects): Discuss adding Wikidata desc to mobile web underneath title with communities - https://phabricator.wikimedia.org/T141354#2495435 (10Moushira) [13:26:19] 06Project-Admins, 10Phabricator (Upstream), 07Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555#833979 (10Danny_B) I don't think we need to use this task as tracking. Requests for private projects can be found in Projects to create column on #project-... [13:26:51] (03CR) 10Elukey: Properly reload tornado child processes during SIGHUP (031 comment) [eventlogging] - 10https://gerrit.wikimedia.org/r/300337 (https://phabricator.wikimedia.org/T140870) (owner: 10Ottomata) [13:27:48] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, 03Language-Q1-2016-17 Sprint 2, 03Wikidata-Sprint-2016-08-02: Show languages that a wiki community added to the top of the interlanguage list... - https://phabricator.wikimedia.org/T138973#2495451 [13:28:52] 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 03Language-Q1-2016-17 Sprint 2: Alemannic (gsw/als) doesn't appear when connecting from Switzerland - https://phabricator.wikimedia.org/T139949#2495455 (10Nikerabbit) a:03Nikerabbit Those other codes never appear in interwiki links, so I... [13:31:02] 10Reading-Community-Engagement: Helping add more visibility to our design work on our portal mediawiki - https://phabricator.wikimedia.org/T141355#2495458 (10Moushira) [13:31:53] 07Design, 06WMDE-Design, 10Wikidata: Improve usability of rank selector - https://phabricator.wikimedia.org/T139081#2495471 (10Lydia_Pintscher) Yeah let's do the title attribute for now. [13:32:13] 07Design, 06WMDE-Design, 10Wikidata: Improve usability of rank selector - https://phabricator.wikimedia.org/T139081#2495473 (10Lydia_Pintscher) As a future step let's work on ordering/collapsing based on rank. [13:32:27] (03PS1) 10Mholloway: Update bundled CSS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301116 [13:32:48] 10Reading-Community-Engagement: Helping add more visibility to our design work on our portal mediawiki - https://phabricator.wikimedia.org/T141355#2495475 (10Moushira) [13:32:50] 10Reading-Community-Engagement, 10WMF-Product-Development-Process, 06Community-Liaisons (Jul-Sep-2016): Explore a process for UX/UI discussion - https://phabricator.wikimedia.org/T121647#2495474 (10Moushira) [13:33:03] 10Wikimedia-Site-requests, 06Wiktionary, 07Community-consensus-needed, 13Patch-For-Review: On mk.wiktionary, rename namespace Wiktionary to Викиречник and change logo - https://phabricator.wikimedia.org/T140566#2495476 (10MarcoAurelio) >>! In T140566#2493563, @DenisWasRight wrote: >>>! In T140566#2483470,... [13:34:03] 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Technical Collaboration quarterly goals for July - September 2016 - https://phabricator.wikimedia.org/T131915#2495477 (10Moushira) [13:35:02] 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Technical Collaboration quarterly goals for July - September 2016 - https://phabricator.wikimedia.org/T131915#2182866 (10Moushira) [13:36:38] 04(no projects): Discuss adding Wikidata desc to mobile web underneath title with communities - https://phabricator.wikimedia.org/T141354#2495488 (10Moushira) [13:37:03] 04(no projects): Discuss adding Wikidata desc to mobile web underneath title with communities - https://phabricator.wikimedia.org/T141354#2495435 (10Moushira) p:05Triage>03Normal [13:37:53] (03CR) 10DCausse: Centralize document id generation (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300179 (https://phabricator.wikimedia.org/T139496) (owner: 10EBernhardson) [13:38:27] 04(no projects): Discuss adding Wikidata desc to mobile web underneath title with communities - https://phabricator.wikimedia.org/T141354#2495435 (10Moushira) [13:43:01] 10AbuseFilter, 06Stewards-and-global-tools: AbuseLog to let global search by given username - https://phabricator.wikimedia.org/T141356#2495497 (10MarcoAurelio) [13:50:04] 10CirrusSearch, 06Discovery, 03Discovery-Search-Sprint: Implement a new fulltext query - https://phabricator.wikimedia.org/T128073#2495552 (10dcausse) a:03dcausse [13:52:14] 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Technical Collaboration quarterly goals for July - September 2016 - https://phabricator.wikimedia.org/T131915#2495562 (10Johan) [13:52:40] 10Wiki-Loves-Monuments-Database: Harvesting is broken for (gb-eng,en) - https://phabricator.wikimedia.org/T141359#2495567 (10JeanFred) [13:52:53] 10Wiki-Loves-Monuments-Database: Harvesting is broken for (gb-eng,en) because of 'notes' field - https://phabricator.wikimedia.org/T141359#2495581 (10JeanFred) p:05Triage>03High [13:53:06] 06Community-Liaisons (Jul-Sep-2016), 06Developer-Relations (Jul-Sep-2016): Technical Collaboration quarterly goals for July - September 2016 - https://phabricator.wikimedia.org/T131915#2182866 (10Johan) [14:02:57] (03PS1) 10Addshore: dewiki_diffstats add rev timestamps & feature state [extensions/WikimediaEvents] (wmf/1.28.0-wmf.11) - 10https://gerrit.wikimedia.org/r/301119 (https://phabricator.wikimedia.org/T135751) [14:05:41] 04(no projects): stat1004 doesn't show up in ganglia - https://phabricator.wikimedia.org/T141360#2495588 (10JAllemandou) [14:07:16] (03CR) 10Bartosz Dziewoński: [C: 031] "Per the task, this is probably the best thing to do for now." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300046 (https://phabricator.wikimedia.org/T140908) (owner: 10Reedy) [14:08:15] 06Reading-Admin, 06Reading-Web-Backlog, 03Reading-Web-Planning: [GOAL] Lazy load references in mobile skin - https://phabricator.wikimedia.org/T123328#2495620 (10dr0ptp4kt) [14:08:19] 06Reading-Admin, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Deploy lazy loaded references and images to a large wiki - https://phabricator.wikimedia.org/T140197#2495618 (10dr0ptp4kt) 05Open>03Resolved Signing off. [14:08:40] (03CR) 10Nikerabbit: Do not automatically infuse any OOjs UI widgets (031 comment) [core] - 10https://gerrit.wikimedia.org/r/301112 (owner: 10Bartosz Dziewoński) [14:10:41] 10AbuseFilter: Users without abusefilter-modify can view [[Special:AbuseFilter/tools]] but do nothing with it - https://phabricator.wikimedia.org/T124096#2495636 (10MarcoAurelio) [14:11:13] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2495637 (10dr0ptp4kt) @jhernandez, @jhobs, @phuedx, @bmansurov, your review for signoff requested. [14:11:45] (03CR) 10Bartosz Dziewoński: Do not automatically infuse any OOjs UI widgets (031 comment) [core] - 10https://gerrit.wikimedia.org/r/301112 (owner: 10Bartosz Dziewoński) [14:12:00] (03PS2) 10Bartosz Dziewoński: Do not automatically infuse any OOjs UI widgets [core] - 10https://gerrit.wikimedia.org/r/301112 [14:12:35] 10MediaWiki-Debian, 10Continuous-Integration-Config: Set up CI auto-building for mediawiki/debian repository - https://phabricator.wikimedia.org/T122978#2495657 (10hashar) [14:12:55] (03CR) 10Hashar: "recheck" [debian] - 10https://gerrit.wikimedia.org/r/262746 (owner: 10Hashar) [14:16:36] c' /in go kaldari [14:17:56] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression: Search magnifying glass and placeholder text mashed together in Opera Mini - https://phabricator.wikimedia.org/T140490#2495663 (10dr0ptp4kt) A check on http://en.m.wikipedia.beta.wmflabs... [14:18:30] (03CR) 10Ottomata: [WIP] Replace kafka producer client with confluent-kafka (032 comments) [eventlogging] - 10https://gerrit.wikimedia.org/r/292976 (owner: 10Ottomata) [14:18:37] kaldari: sorry, you can ignore my hl, small tab issue on the keyboard [14:19:48] (03PS2) 10Ottomata: Add confluent-kafka reader and writer [eventlogging] - 10https://gerrit.wikimedia.org/r/292976 [14:19:54] (03PS7) 10Jforrester: Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [14:20:16] 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Add description when a user reviews an edit - https://phabricator.wikimedia.org/T136903#2351790 (10Halfak) This appears to be done and deployed. [14:20:26] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Add description when a user reviews an edit - https://phabricator.wikimedia.org/T136903#2495683 (10Halfak) [14:20:43] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Add description when a user reviews an edit - https://phabricator.wikimedia.org/T136903#2351790 (10Halfak) a:03Ladsgroup [14:21:55] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression, and 2 others: OOjs UI overrides close icon - https://phabricator.wikimedia.org/T140849#2495689 (10dr0ptp4kt) 05Open>03Resolved Signing off. [14:23:02] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2495693 (10dr0ptp4kt) a:05dr0ptp4kt>03None [14:23:43] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Add description when a user reviews an edit - https://phabricator.wikimedia.org/T136903#2495696 (10Ladsgroup) @Halfak, I don't think so. I think it meant if someone check out a diff page ([[ https://en.wikipedia.org/w/index.php?title=United_States_H... [14:27:45] 10MediaWiki-Debian, 10Continuous-Integration-Config: Set up CI auto-building for mediawiki/debian repository - https://phabricator.wikimedia.org/T122978#2495702 (10hashar) 05Open>03Resolved a:03hashar CI is configured. The repository trigger the job `debian-glue` which lookup for the distribution in `deb... [14:27:52] (03CR) 10Ottomata: [C: 032] Add confluent-kafka reader and writer [eventlogging] - 10https://gerrit.wikimedia.org/r/292976 (owner: 10Ottomata) [14:28:21] (03CR) 10Ottomata: "These both have been reviewed, and they will not affect any production processes. Merging." [eventlogging] - 10https://gerrit.wikimedia.org/r/292976 (owner: 10Ottomata) [14:28:24] (03CR) 10Ottomata: [V: 032] Add confluent-kafka reader and writer [eventlogging] - 10https://gerrit.wikimedia.org/r/292976 (owner: 10Ottomata) [14:29:15] (03PS3) 10Ottomata: service.py - Catch generic Exceptions during handle_events so we can log and produce them to error output [eventlogging] - 10https://gerrit.wikimedia.org/r/300944 [14:30:21] (03CR) 10Ottomata: [C: 032] service.py - Catch generic Exceptions during handle_events so we can log and produce them to error output [eventlogging] - 10https://gerrit.wikimedia.org/r/300944 (owner: 10Ottomata) [14:33:56] 10MediaWiki-Gallery, 06Multimedia, 10Wikimedia-Site-requests: Change the default mode of tags to mode=packed on English Wikipedia - https://phabricator.wikimedia.org/T141349#2495726 (10Jdforrester-WMF) p:05Triage>03Normal a:03Jdforrester-WMF [14:42:13] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [debian] - 10https://gerrit.wikimedia.org/r/262746 (owner: 10Hashar) [14:44:31] 07Design, 06WMDE-Design, 10Wikidata: infographic for quality processes around Wikidata - https://phabricator.wikimedia.org/T129065#2495756 (10Charlie_WMDE) Thanks @aude ! I would also love more feedback on the text, content and wording, since this was just a first draft and by no means a good solution in my... [14:47:07] 06Discovery, 03Discovery-Search-Sprint: "Help" on the search page for many WMF wikis points to the wrong place - https://phabricator.wikimedia.org/T141003#2495759 (10CKoerner_WMF) Cpiral echoes what PrimeHunter states above and mentions that MediaWiki installs may have redlinks if the default setting within Me... [14:48:57] 04(no projects): Discuss adding Wikidata desc to mobile web underneath title with communities - https://phabricator.wikimedia.org/T141354#2495763 (10Aklapper) Hi @Moushira. Please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task to allow othe... [14:49:24] (03PS14) 10MarcoAurelio: Set fallback language for lzh to zh-hant [core] - 10https://gerrit.wikimedia.org/r/272499 (https://phabricator.wikimedia.org/T125373) [14:50:06] 04(no projects): stat1004 doesn't show up in ganglia - https://phabricator.wikimedia.org/T141360#2495767 (10Aklapper) Hi @JAllemandou. Please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task to allow others to find this task when searching in... [14:51:36] 10MediaWiki-API, 10MediaWiki-Database, 06Commons, 10DBA, and 2 others: API: Contributions: Database query error - https://phabricator.wikimedia.org/T131065#2495771 (10Anomie) [14:53:45] (03CR) 10jenkins-bot: [V: 04-1] Set fallback language for lzh to zh-hant [core] - 10https://gerrit.wikimedia.org/r/272499 (https://phabricator.wikimedia.org/T125373) (owner: 10MarcoAurelio) [14:53:49] (03CR) 10Jforrester: [C: 032] Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [14:54:24] (03CR) 10MarcoAurelio: "> @MarcoAurelio: If I merge a patch set with a failing test, that" [core] - 10https://gerrit.wikimedia.org/r/272499 (https://phabricator.wikimedia.org/T125373) (owner: 10MarcoAurelio) [14:55:46] (03PS3) 10Reedy: Move efSchemaValidate to EventLogging class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300046 (https://phabricator.wikimedia.org/T140908) [14:55:48] (03CR) 10Paladox: "check experimental" [debian] - 10https://gerrit.wikimedia.org/r/299113 (owner: 10Legoktm) [14:55:57] (03CR) 10Paladox: "recheck" [debian] - 10https://gerrit.wikimedia.org/r/299113 (owner: 10Legoktm) [14:56:24] (03CR) 10Reedy: "Rebased to get rid of the merge conflict" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300046 (https://phabricator.wikimedia.org/T140908) (owner: 10Reedy) [14:56:57] MERGE ALL THE THINGS (and it's dependancies :P) [14:58:31] * mafk rebases Reedy [14:58:53] 10MediaWiki-Uploading, 06Multimedia: add support for firefogg - https://phabricator.wikimedia.org/T18927#2495783 (10Anomie) [14:58:55] 10MediaWiki-API: Support Upload Resume via Server Side File Concatenation - https://phabricator.wikimedia.org/T19255#2495781 (10Anomie) 05Open>03Resolved If someone wants to change the existing chunked upload provided by the action API, they should probably open a new task. Closing this. [15:01:04] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2493315 (10demon) I don't know what make gerrit is or what it's trying to do here :) I looked in MobileFrontend/dev-scripts/ (which is what the Makefile references) but I don't see said file. [15:01:28] (03CR) 10Jforrester: [C: 04-1] "Per discussion on task, this is stalled." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/271198 (https://phabricator.wikimedia.org/T127273) (owner: 10Legoktm) [15:01:32] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service: Set up grafana dashboard for ORES extension - https://phabricator.wikimedia.org/T141169#2495791 (10Ladsgroup) 05Open>03Resolved [15:01:39] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 10Wikidata, 13Patch-For-Review, and 3 others: ORES extension score only main namespace edits for Wikidata - https://phabricator.wikimedia.org/T139660#2495793 (10Ladsgroup) 05Open>03Resolved [15:01:44] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): More robust way of handling errors in Cache.php - https://phabricator.wikimedia.org/T137880#2495795 (10Ladsgroup) 05Open>03Resolved [15:04:24] (03Merged) 10jenkins-bot: Mark Linker::link() as @deprecated [core] - 10https://gerrit.wikimedia.org/r/298650 (owner: 10Legoktm) [15:06:07] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Add 'hovercardsSuppressedByGadget' field to Schema:Popups and update the codebase to take this field into account - https://phabricator.wikimedia.org/T137203#2495798... [15:06:10] 10Gerrit: "needs Verified" error when C+2'ing changes (but patchsets get merged) - https://phabricator.wikimedia.org/T114214#2495799 (10Paladox) 05Open>03Resolved a:03Paladox [15:06:19] 10Gerrit: "needs Verified" error when C+2'ing changes (but patchsets get merged) - https://phabricator.wikimedia.org/T114214#1688458 (10Paladox) a:05Paladox>03None [15:06:36] 10Gerrit: "needs Verified" error when C+2'ing changes (but patchsets get merged) - https://phabricator.wikimedia.org/T114214#2495803 (10Dzahn) We talked about this a bit and think that it's an outdated problem from the past. We agreed that it can be closed. [15:06:41] 10Gerrit: "needs Verified" error when C+2'ing changes (but patchsets get merged) - https://phabricator.wikimedia.org/T114214#2495804 (10Dzahn) We talked about this a bit and think that it's an outdated problem from the past. We agreed that it can be closed. [15:07:51] 10MediaWiki-API, 07I18n: Message MediaWiki:Apihelp-protect-example-unprotect seems self-contradictive. - https://phabricator.wikimedia.org/T141367#2495805 (10Purodha) [15:08:25] 10MediaWiki-extensions-ORES, 10ORES, 06Revision-Scoring-As-A-Service, 07Wikimedia-log-errors: [Investigate] ORES time out errors in logs - https://phabricator.wikimedia.org/T141368#2495817 (10Ladsgroup) [15:08:39] (03PS1) 10MarkTraceur: Fix image links [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/301134 (https://phabricator.wikimedia.org/T140503) [15:09:31] (03CR) 10jenkins-bot: [V: 04-1] Fix image links [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/301134 (https://phabricator.wikimedia.org/T140503) (owner: 10MarkTraceur) [15:11:19] (03PS1) 10Ladsgroup: Add revision_id to log for errors [extensions/ORES] (wmf/1.28.0-wmf.11) - 10https://gerrit.wikimedia.org/r/301135 (https://phabricator.wikimedia.org/T141368) [15:12:04] 10MediaWiki-API, 07I18n: Message MediaWiki:Apihelp-protect-example-unprotect seems self-contradictive. - https://phabricator.wikimedia.org/T141367#2495837 (10Anomie) 05Open>03Invalid And yet that's the way it works. Setting the restriction to "edit=sysop" means editing is restricted to sysops (or more spec... [15:12:38] (03CR) 10Florianschmidtwelzow: [C: 032] Don't magically make MediaWiki\Widget classes infusable [core] - 10https://gerrit.wikimedia.org/r/301111 (owner: 10Bartosz Dziewoński) [15:13:12] (03Abandoned) 10Ladsgroup: Add revision_id to log for errors [extensions/ORES] (wmf/1.28.0-wmf.11) - 10https://gerrit.wikimedia.org/r/301135 (https://phabricator.wikimedia.org/T141368) (owner: 10Ladsgroup) [15:13:52] 10MediaWiki-Search, 10CirrusSearch, 06Discovery, 06Discovery-Search-Backlog: Add DEFAULTSORT keys to wiki search autocomplete - https://phabricator.wikimedia.org/T134978#2495843 (10TJones) I have some additional observations. - "Bush, George W." is already indexed (as a redirect) and it doesn't come up i... [15:14:30] (03PS1) 10Ladsgroup: Add revision_id to log for errors [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301136 (https://phabricator.wikimedia.org/T141368) [15:14:42] (03PS1) 10Ottomata: Bring over other previously reverted changes [eventlogging] - 10https://gerrit.wikimedia.org/r/301137 [15:17:00] 06Discovery, 06Community-Liaisons (Jul-Sep-2016): Look into producing a list of frequent 'zero result' search terms on Wikimedia projects - https://phabricator.wikimedia.org/T127002#2495864 (10CKoerner_WMF) @TJones performed an investigation into the top unsuccessful search queries. The results show that gener... [15:19:42] (03PS3) 10Mholloway: Handle fragments in news links [services/mobileapps] - 10https://gerrit.wikimedia.org/r/300985 (https://phabricator.wikimedia.org/T141307) [15:20:06] 10CirrusSearch, 06Discovery, 03Discovery-Search-Sprint: Question mark in query causes it to turn up unrelated search results - https://phabricator.wikimedia.org/T133711#2495874 (10TJones) @ksmith, we decided to go with stripping all question marks (replacing them with spaces to preserve word boundaries) as t... [15:20:29] (03CR) 10Mholloway: Handle fragments in news links (031 comment) [services/mobileapps] - 10https://gerrit.wikimedia.org/r/300985 (https://phabricator.wikimedia.org/T141307) (owner: 10Mholloway) [15:21:14] 10Continuous-Integration-Infrastructure (phase-out-gallium): Target architecture without gallium.wikimedia.org - https://phabricator.wikimedia.org/T133300#2495877 (10Dzahn) >>! In T133300#2495369, @hashar wrote: >>>! In T133300#2491756, @faidon wrote: >> Having a properly Puppetized setup would help us in lower... [15:21:55] (03CR) 10Ottomata: [C: 032] Bring over other previously reverted changes [eventlogging] - 10https://gerrit.wikimedia.org/r/301137 (owner: 10Ottomata) [15:22:13] (03Merged) 10jenkins-bot: Don't magically make MediaWiki\Widget classes infusable [core] - 10https://gerrit.wikimedia.org/r/301111 (owner: 10Bartosz Dziewoński) [15:24:08] (03CR) 10Florianschmidtwelzow: [C: 031] "The change looks good and, at least from my testing, it looks that there're no side effects. However, I would love to read a seond review " [core] - 10https://gerrit.wikimedia.org/r/301112 (owner: 10Bartosz Dziewoński) [15:24:51] (03CR) 10Jforrester: [C: 04-1] "Let's discuss this before rushing in." [core] - 10https://gerrit.wikimedia.org/r/301112 (owner: 10Bartosz Dziewoński) [15:25:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "You know, this change actually makes no sense, 'hide-if' doesn't even implement the same functionality. (In addition to hiding some field," [core] - 10https://gerrit.wikimedia.org/r/301089 (owner: 10Bartosz Dziewoński) [15:25:56] (03CR) 10Florianschmidtwelzow: [C: 032 V: 032] Fix fatal and other tweaks [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/301086 (owner: 10Kghbln) [15:26:06] (03CR) 10Dbrant: [C: 032] Upgrade Android Support Libraries to v24.1.1 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300335 (owner: 10Niedzielski) [15:27:39] 10Continuous-Integration-Infrastructure (phase-out-gallium): Target architecture without gallium.wikimedia.org - https://phabricator.wikimedia.org/T133300#2495888 (10Paladox) What @hashar says is true that I got ci setupped in labs, I used bits and pices of puppet due to when I did it we were still using gerrit... [15:28:14] (03PS1) 10Bartosz Dziewoński: LoginSignupSpecialPage: Remove "HACK" comment about non-hacky thing [core] - 10https://gerrit.wikimedia.org/r/301140 [15:28:21] (03PS5) 10Florianschmidtwelzow: Convert this extension to AuthManager [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300557 (https://phabricator.wikimedia.org/T137684) [15:28:32] (03Merged) 10jenkins-bot: Upgrade Android Support Libraries to v24.1.1 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300335 (owner: 10Niedzielski) [15:28:43] (03CR) 10Florianschmidtwelzow: Convert this extension to AuthManager (031 comment) [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300557 (https://phabricator.wikimedia.org/T137684) (owner: 10Florianschmidtwelzow) [15:29:33] (03PS1) 10Bartosz Dziewoński: mediawiki.htmlform: Simplify parsing of 'hide-if' expressions [core] - 10https://gerrit.wikimedia.org/r/301141 [15:31:11] (03Abandoned) 10Bartosz Dziewoński: mediawiki.special.userlogin.signup: Remove unnecessary field hiding code [core] - 10https://gerrit.wikimedia.org/r/301089 (owner: 10Bartosz Dziewoński) [15:31:16] (03CR) 10Kghbln: "Great and thanks! Will do a field test tomorrow." [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/300557 (https://phabricator.wikimedia.org/T137684) (owner: 10Florianschmidtwelzow) [15:31:23] 10Reading-Community-Engagement: Discuss adding Wikidata desc to mobile web underneath title with communities - https://phabricator.wikimedia.org/T141354#2495890 (10Moushira) [15:32:00] 10Reading-Community-Engagement: Discuss, with communities, adding Wikidata desc to mobile web underneath title - https://phabricator.wikimedia.org/T141354#2495435 (10Moushira) [15:33:34] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.htmlform: Simplify parsing of 'hide-if' expressions [core] - 10https://gerrit.wikimedia.org/r/301141 (owner: 10Bartosz Dziewoński) [15:34:14] (03CR) 10Kghbln: "\m/ :)" [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/301086 (owner: 10Kghbln) [15:35:46] matt_flaschen: Hi :) Are you _currently_ working on https://phabricator.wikimedia.org/T141300 ??? If not, I would be happy to take it over :) [15:36:31] (03CR) 10Anomie: Send notifications about app management events (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231989 (https://phabricator.wikimedia.org/T62528) (owner: 10Gergő Tisza) [15:37:54] (03CR) 10Mholloway: [C: 031] "I did have to create a separate run configuration for this. But, I think that's a good thing, since imo it's more convenient to launch to" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300432 (owner: 10Niedzielski) [15:38:48] (03CR) 10Reedy: "Indeed, the intention was for the usages in UW etc which depend on EventLogging for the schema validation stuff..." [core] - 10https://gerrit.wikimedia.org/r/300755 (https://phabricator.wikimedia.org/T140908) (owner: 10Reedy) [15:38:55] (03CR) 10Mholloway: [C: 031] "lgtm as a strong start!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300433 (https://phabricator.wikimedia.org/T139192) (owner: 10Niedzielski) [15:42:13] 10MediaWiki-extensions-VipsScaler, 06Performance-Team, 10Thumbor: Backport VIPS 8 to Debian Jessie - https://phabricator.wikimedia.org/T141338#2495933 (10bd808) [15:42:41] 10Wiki-Loves-Monuments-Database: Harvesting is broken for (gb-eng,en) because of 'notes' field - https://phabricator.wikimedia.org/T141359#2495936 (10JeanFred) 05Open>03Invalid I was running harvesting manually, assuming the regeneration of SQL tables had taken place last night, but that was not the case. Go... [15:43:30] 06Wikipedia-Android-App-Backlog, 10Android-app-feature-Navigation (Android-app-feature-Navigation-MVP), 03Mobile-App-Android-Sprint-87-Francium: Identify dependencies of PageFragment upon MainActivity, and create an interface out of it. - https://phabricator.wikimedia.org/T141137#2495938 (10Mholloway) a:03M... [15:46:12] (03CR) 10Dbrant: [C: 032] Change default Activity for dev flavor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300432 (owner: 10Niedzielski) [15:47:25] 10Continuous-Integration-Infrastructure (phase-out-gallium): Target architecture without gallium.wikimedia.org - https://phabricator.wikimedia.org/T133300#2495958 (10Paladox) >>! In T133300#2495877, @Dzahn wrote: >>>! In T133300#2495369, @hashar wrote: >>>>! In T133300#2491756, @faidon wrote: > >>> Having a pro... [15:48:29] (03Merged) 10jenkins-bot: Change default Activity for dev flavor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300432 (owner: 10Niedzielski) [15:48:41] (03CR) 10Anomie: [C: 031] "Change seems sane. No idea whether it's better or not. Unit test failure seems unrelated." [core] - 10https://gerrit.wikimedia.org/r/301141 (owner: 10Bartosz Dziewoński) [15:51:33] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2495963 (10bmansurov) I think you need to run `make remotes` first and then look for remotes/gerrit.py. [15:51:46] (03CR) 10Anomie: [C: 031] Remove queue name from OAuth consumer management URL [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/231746 (https://phabricator.wikimedia.org/T109163) (owner: 10Gergő Tisza) [15:52:46] (03CR) 10EBernhardson: Push common search api parameters into SearchApi class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/292477 (owner: 10EBernhardson) [15:53:15] (03CR) 10Bartosz Dziewoński: [WIP] Update signup form validation to use AuthManager (032 comments) [core] - 10https://gerrit.wikimedia.org/r/283847 (https://phabricator.wikimedia.org/T42648) (owner: 10Gergő Tisza) [15:54:20] (03CR) 10Anomie: [C: 031] Improve management IF return messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/222239 (https://phabricator.wikimedia.org/T63000) (owner: 10Gergő Tisza) [15:55:54] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2495971 (10demon) I don't have MobileFrontend installed, so I can't. ``` chad@notsexy /a/ext/MobileFrontend (master)$ make remotes Makefile:3: *** MW_INSTALL_PATH is not set. Please set it to your root mediawiki i... [16:00:33] (03PS1) 10Bmansurov: Always show Wikidata descriptions in beta mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301146 (https://phabricator.wikimedia.org/T141067) [16:00:37] 10MediaWiki-API, 07Easy: API: Give user information for user ids - https://phabricator.wikimedia.org/T34494#2495980 (10Anomie) [16:00:44] 10MediaWiki-API, 07Easy: API: Give user information for user ids - https://phabricator.wikimedia.org/T34494#367043 (10Anomie) a:05TyA>03None [16:01:01] (03CR) 10Cscott: "+1 on the idea from me. I never understood why we added automatic infusion in the first place, I was against it from the start. FWIW, th" [core] - 10https://gerrit.wikimedia.org/r/301112 (owner: 10Bartosz Dziewoński) [16:01:06] (03CR) 10Dbrant: [C: 032] Add overhaul tabs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300433 (https://phabricator.wikimedia.org/T139192) (owner: 10Niedzielski) [16:01:21] (03PS11) 10EBernhardson: Push common search api parameters into SearchApi class [core] - 10https://gerrit.wikimedia.org/r/292477 [16:02:02] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2495986 (10bmansurov) [[ https://phabricator.wikimedia.org/P3573 | Sure thing ]]. [16:02:14] 10MediaWiki-API, 07Easy, 07I18n, 05MW-1.27-release-notes, and 2 others: In ApiHelp the module name header needs explicit direction - https://phabricator.wikimedia.org/T112364#2495988 (10Anomie) 05Open>03Resolved [16:03:20] (03Merged) 10jenkins-bot: Add overhaul tabs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300433 (https://phabricator.wikimedia.org/T139192) (owner: 10Niedzielski) [16:04:31] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10The-Wikipedia-Library, 10Wikimedia-General-or-Unknown, 13Patch-For-Review: Implement Schema:ExternalLinkChange - https://phabricator.wikimedia.org/T115119#2495992 (10Milimetric) The data is accessible from stat1003, if you'd like access to the raw da... [16:09:12] (03CR) 10EBernhardson: "i think more thought is going to be required to figure out how to handle a per-cluster multi-wiki indices setting. The difficulty is we th" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300179 (https://phabricator.wikimedia.org/T139496) (owner: 10EBernhardson) [16:09:32] 10Wikimedia-Site-requests, 06Wiktionary, 07Community-consensus-needed, 13Patch-For-Review: On mk.wiktionary, rename namespace Wiktionary to Викиречник and change logo - https://phabricator.wikimedia.org/T140566#2495999 (10MarcoAurelio) 05Open>03Resolved Should be all fixed. Some changes might take a wh... [16:09:42] 10Wikimedia-Site-requests, 06Wiktionary: On mk.wiktionary, rename namespace Wiktionary to Викиречник and change logo - https://phabricator.wikimedia.org/T140566#2496001 (10MarcoAurelio) [16:11:50] 06Project-Admins: Create a project for video2commons - https://phabricator.wikimedia.org/T134915#2496014 (10Aklapper) 05Open>03Resolved Requested project #video2commons has been created: https://phabricator.wikimedia.org/project/view/2141/ Please encourage interested people to visit the project and to join... [16:16:56] (03CR) 10Dbrant: [C: 032] Hygiene: convert member to local [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300434 (owner: 10Niedzielski) [16:19:07] (03Merged) 10jenkins-bot: Hygiene: convert member to local [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300434 (owner: 10Niedzielski) [16:19:35] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2496045 (10bmansurov) Looks good to me. [16:25:21] (03PS1) 10Florianschmidtwelzow: Deprecate getForm() and replace by getFormInformation() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/301147 (https://phabricator.wikimedia.org/T141300) [16:26:03] (03PS3) 10Jhobs: Sort languages under "All Languages" case-insensitive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/300438 (https://phabricator.wikimedia.org/T139759) [16:27:29] (03CR) 10Jhobs: "Still writing the PHPUnit test, but decided to upload the fixes to comments anyways." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/300438 (https://phabricator.wikimedia.org/T139759) (owner: 10Jhobs) [16:27:53] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks good, works in my testing. However, Mattflaschen should've enough time to test, too :)" [core] - 10https://gerrit.wikimedia.org/r/301028 (owner: 10Krinkle) [16:28:13] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression: Search magnifying glass and placeholder text mashed together in Opera Mini - https://phabricator.wikimedia.org/T140490#2496052 (10phuedx) @dr0ptp4kt: @Jdlrobson's change hasn't been merg... [16:28:32] (03CR) 10Florianschmidtwelzow: "This _shouldn't_ have an impact to extensions directly, that's why it's not marked as a "BREAKING CHANGE"." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/301147 (https://phabricator.wikimedia.org/T141300) (owner: 10Florianschmidtwelzow) [16:28:34] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2496053 (10demon) Ah ok, I see what's going on here: ``` lang=python reviews = change["labels"]["Code-Review"] approved = None if "approved" in reviews: approved = reviews["approved"]["name"] ``` It looks lik... [16:28:54] (03PS4) 10Jhobs: [WIP]Sort languages under "All Languages" case-insensitive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/300438 (https://phabricator.wikimedia.org/T139759) [16:29:22] (03PS1) 10Ottomata: Tornado should fork num_processes before instantiating eventlogging writers [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 [16:30:24] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault: Sort mobile web language switcher list case insensitive - https://phabricator.wikimedia.org/T139759#2441756 (10jhobs) Still needs more work because I'm writing the phpunit test, but moved back to Code R... [16:31:12] (03CR) 10jenkins-bot: [V: 04-1] Tornado should fork num_processes before instantiating eventlogging writers [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 (owner: 10Ottomata) [16:31:33] (03CR) 10jenkins-bot: [V: 04-1] Deprecate getForm() and replace by getFormInformation() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/301147 (https://phabricator.wikimedia.org/T141300) (owner: 10Florianschmidtwelzow) [16:31:38] 10WikiCon-Francophone-2016: Tote bags pour participants à la #WikiConFR 2016 - https://phabricator.wikimedia.org/T139069#2496059 (10Pyb) [16:31:52] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault: Sort mobile web language switcher list case insensitive - https://phabricator.wikimedia.org/T139759#2496060 (10jhobs) [16:32:00] 10MediaWiki-extensions-DonationInterface, 10FR-ActiveMQ, 10FR-Smashpig, 10Fundraising-Backlog, and 6 others: Move orphan rectifier out of payments - https://phabricator.wikimedia.org/T131275#2496061 (10awight) [16:32:10] (03PS2) 10Ottomata: Tornado should fork num_processes before instantiating eventlogging writers [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 [16:33:05] (03PS6) 10EBernhardson: Centralize document id generation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300179 (https://phabricator.wikimedia.org/T139496) [16:33:13] (03CR) 10Jdlrobson: [C: 032] Remove 'number-leading-zero' blacklist from stylelintrc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/298734 (owner: 10Esanders) [16:33:28] (03CR) 10jenkins-bot: [V: 04-1] Tornado should fork num_processes before instantiating eventlogging writers [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 (owner: 10Ottomata) [16:33:34] (03CR) 10Jdlrobson: [C: 04-2] "need to update commit msg" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/298734 (owner: 10Esanders) [16:33:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Sort languages under "All Languages" case-insensitive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/300438 (https://phabricator.wikimedia.org/T139759) (owner: 10Jhobs) [16:35:02] (03PS7) 10Esanders: Remove 'number-leading-zero' blacklist from stylelintrc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/298734 [16:35:41] (03CR) 10Jhernandez: [C: 032] Extract page action creators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301102 (https://phabricator.wikimedia.org/T140260) (owner: 10Phuedx) [16:35:44] (03CR) 10Jdlrobson: [C: 032] Remove 'number-leading-zero' blacklist from stylelintrc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/298734 (owner: 10Esanders) [16:36:10] (03CR) 10Dbrant: [C: 032] Fix privacy policy URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300998 (owner: 10Deskana) [16:38:43] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2496064 (10phuedx) a:03bmansurov ^ Looks like cookie licking to me… [16:39:11] 10UntitledNotificationExtensionGSoC2016, 05Google-Summer-of-Code-2016: [GSoC] Weekly Reports for Extension for page creating/editing notification - https://phabricator.wikimedia.org/T135587#2496066 (10Abhinand) [16:39:23] (03CR) 10Jhernandez: [C: 032] [Hygiene] Test SkinMinerva#isAllowedPageAction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301103 (https://phabricator.wikimedia.org/T140260) (owner: 10Phuedx) [16:41:23] (03CR) 10Jhernandez: [C: 032] [Hygiene] Extend SkinMinerva#isAllowedPageAction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301104 (https://phabricator.wikimedia.org/T140260) (owner: 10Phuedx) [16:41:59] 10WikiCon-Francophone-2016: social events pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T122303#2496101 (10Pyb) [16:42:06] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2496117 (10bmansurov) What seems to be the problem, officer @phuedx? I've checked the mediawiki-config repo for old... [16:42:57] (03Merged) 10jenkins-bot: Extract page action creators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301102 (https://phabricator.wikimedia.org/T140260) (owner: 10Phuedx) [16:43:30] 10Gerrit, 10MobileFrontend: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2496135 (10bmansurov) Thanks. I mainly use this script to find patches that need a review. [16:43:55] (03CR) 10Jhernandez: [C: 032] Always show Wikidata descriptions in beta mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301146 (https://phabricator.wikimedia.org/T141067) (owner: 10Bmansurov) [16:44:35] (03Merged) 10jenkins-bot: Remove 'number-leading-zero' blacklist from stylelintrc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/298734 (owner: 10Esanders) [16:44:37] (03Merged) 10jenkins-bot: Fix privacy policy URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300998 (owner: 10Deskana) [16:46:06] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2496141 (10phuedx) @bmansurov: You're now fully responsible for signing off this task! Congratulations! [16:46:10] (03Merged) 10jenkins-bot: [Hygiene] Test SkinMinerva#isAllowedPageAction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301103 (https://phabricator.wikimedia.org/T140260) (owner: 10Phuedx) [16:46:14] 10MobileFrontend: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496143 (10Jdlrobson) [16:46:24] 10MobileFrontend, 07Regression: Regression: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496155 (10Jdlrobson) [16:46:44] (03PS5) 10Jhobs: [WIP] Sort languages under "All Languages" case-insensitive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/300438 (https://phabricator.wikimedia.org/T139759) [16:47:02] (03CR) 10Dbrant: [C: 032] Remove summary from Wikipedia Zero FAQ button in Settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300740 (https://phabricator.wikimedia.org/T129937) (owner: 10Deskana) [16:47:17] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Wikidata descriptions are not showing in beta unless enabled in stable - https://phabricator.wikimedia.org/T141067#2496157 (10bmansurov) a:05bmansurov>03None [16:47:44] (03Merged) 10jenkins-bot: [Hygiene] Extend SkinMinerva#isAllowedPageAction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301104 (https://phabricator.wikimedia.org/T140260) (owner: 10Phuedx) [16:49:47] (03CR) 10Jdlrobson: Do not apply horizontal padding on basic search interface (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299575 (https://phabricator.wikimedia.org/T140490) (owner: 10Jdlrobson) [16:51:34] (03PS3) 10Niedzielski: Hygiene: remove redundant code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300586 [16:51:36] (03PS3) 10Niedzielski: Request location permission on action not on open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300585 [16:51:38] (03PS1) 10Niedzielski: Check hosting Fragment for callback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301151 [16:51:40] (03PS1) 10Niedzielski: Hygiene: remove CallbackFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301152 [16:51:42] (03PS1) 10Niedzielski: Add Reading Lists to overhaul [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301153 [16:51:44] (03PS1) 10Niedzielski: Refactor NearbyFragment to use callback pattern [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301154 (https://phabricator.wikimedia.org/T139194) [16:51:44] 10MobileFrontend, 07Regression: Regression: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496143 (10phuedx) Highly likely due to T139928. [16:51:46] (03PS1) 10Niedzielski: Hygiene: use newInstance pattern for Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301155 [16:51:48] (03PS1) 10Niedzielski: Hygiene: use Butter Knife in NearbyFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301156 [16:51:50] (03PS1) 10Niedzielski: Disable location listener when backgrounded [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301157 [16:51:52] (03PS1) 10Niedzielski: Refactor ReadingListsFragment to use callbacks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301158 (https://phabricator.wikimedia.org/T139194) [16:51:54] (03PS1) 10Niedzielski: Refactor HistoryFragment to use callback pattern [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301159 (https://phabricator.wikimedia.org/T139194) [16:51:56] (03PS1) 10Niedzielski: Add callback stubs for Feed in OverhaulFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301160 (https://phabricator.wikimedia.org/T139194) [16:53:48] (03Merged) 10jenkins-bot: Always show Wikidata descriptions in beta mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301146 (https://phabricator.wikimedia.org/T141067) (owner: 10Bmansurov) [16:53:50] (03Merged) 10jenkins-bot: Remove summary from Wikipedia Zero FAQ button in Settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300740 (https://phabricator.wikimedia.org/T129937) (owner: 10Deskana) [16:54:10] (03PS1) 10Ladsgroup: First CI test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301162 (https://phabricator.wikimedia.org/T140455) [16:55:49] (03PS3) 10Florianschmidtwelzow: Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) [16:58:40] (03PS1) 10Florianschmidtwelzow: Show the first input as a warning, not as an error box [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/301163 (https://phabricator.wikimedia.org/T139179) [16:59:10] 07Design, 10MediaWiki-HTMLForm, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-OATHAuth: UI for entering the token shouldn't be a errorbox - https://phabricator.wikimedia.org/T139179#2496188 (10Florian) a:03Florian [17:01:02] 10GoogleLogin, 07I18n: [[MediaWiki:Googlelogin-error-no-authentication-workflow/en]] wording issue - https://phabricator.wikimedia.org/T138594#2496206 (10Florian) a:03Florian [17:02:08] (03PS1) 10Anomie: ApiHelp: Add directionality to various things that are likely English-like [core] - 10https://gerrit.wikimedia.org/r/301164 [17:02:29] (03CR) 10jenkins-bot: [V: 04-1] First CI test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301162 (https://phabricator.wikimedia.org/T140455) (owner: 10Ladsgroup) [17:02:53] (03PS2) 10Ladsgroup: First CI test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301162 (https://phabricator.wikimedia.org/T140455) [17:03:22] (03CR) 10Umherirrender: "No, this is about .mw-plusminus-pos, .mw-plusminus-neg and .mw-plusminus-null which are still in that module. The .comment was moved back " [core] - 10https://gerrit.wikimedia.org/r/299134 (owner: 10Umherirrender) [17:04:11] 07Design, 10MobileFrontend, 06Reading-Web-Backlog: Table of Contents / Collapsed vs Expanded - https://phabricator.wikimedia.org/T94911#2496220 (10Jhernandez) [17:04:23] (03PS3) 10Ladsgroup: First CI test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301162 (https://phabricator.wikimedia.org/T140455) [17:04:28] 10Gerrit, 10MobileFrontend, 06Reading-Web-Backlog: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2496221 (10Jhernandez) [17:04:45] 10MobileFrontend, 06Reading-Web-Backlog, 07Regression: Regression: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496222 (10Jhernandez) [17:04:58] (03CR) 10jenkins-bot: [V: 04-1] Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [17:05:54] (03PS1) 10Florianschmidtwelzow: i18n: Change the wording of googlelogin-error-no-authentication-workflow [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/301165 (https://phabricator.wikimedia.org/T138594) [17:07:23] 10GoogleLogin, 07I18n: [[MediaWiki:Googlelogin-error-no-authentication-workflow/en]] wording issue - https://phabricator.wikimedia.org/T138594#2496231 (10Florian) Changed from: `You requested to continue an already started Google authentication workflow, but there's no already running one. Please start a new a... [17:07:59] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/boost_template_api.feature:3:7:11:15:19:23 features/combined_filters_api.f" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300179 (https://phabricator.wikimedia.org/T139496) (owner: 10EBernhardson) [17:09:53] (03CR) 10Florianschmidtwelzow: "Actually, one thing is missing: You should probably mention this change in the RELEASE-NOTES? :)" [core] - 10https://gerrit.wikimedia.org/r/301112 (owner: 10Bartosz Dziewoński) [17:11:35] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression: Regression: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496252 (10Jhernandez) p:05Triage>03High [17:13:27] 10Gerrit, 10MobileFrontend, 06Reading-Web-Backlog: `make gerrit` not working - https://phabricator.wikimedia.org/T141293#2496260 (10Jhernandez) 05Open>03declined This project lives in github, https://github.com/jdlrobson/GerritCommandLine/issues Please report the bug there!! {icon thumbs-up} [17:13:32] (03CR) 10Dbrant: [C: 032] Request location permission on action not on open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300585 (owner: 10Niedzielski) [17:14:16] 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt: Search emits duplicate requests for pageprops - https://phabricator.wikimedia.org/T141153#2496262 (10Jhernandez) p:05Triage>03Normal [17:14:42] (03PS2) 10Florianschmidtwelzow: Deprecate getForm() and replace by getFormInformation() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/301147 (https://phabricator.wikimedia.org/T141300) [17:15:06] 10MobileFrontend, 06Reading-Web-Backlog: Fatal exception in Special:Preferences when setting Minerva as the default skin - https://phabricator.wikimedia.org/T141099#2496264 (10Jhernandez) p:05Triage>03High [17:15:42] (03Merged) 10jenkins-bot: Request location permission on action not on open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300585 (owner: 10Niedzielski) [17:15:49] (03Merged) 10jenkins-bot: Hygiene: remove redundant code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300586 (owner: 10Niedzielski) [17:16:21] (03PS4) 10Florianschmidtwelzow: Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) [17:16:22] 10MobileFrontend, 06Reading-Web-Backlog: Implement Special:MobileFeatures special page - https://phabricator.wikimedia.org/T141122#2496268 (10Jhernandez) p:05Triage>03Normal [17:17:12] 10MobileFrontend, 06Reading-Web-Backlog: Migrate 5 features to basic feature management - https://phabricator.wikimedia.org/T141123#2496270 (10Jhernandez) p:05Triage>03Normal [17:17:16] 07Design, 10MobileFrontend, 06Reading-Web-Backlog: Switch settings icon from cog to sliders to be consistent with VisualEditor? - https://phabricator.wikimedia.org/T97479#2496272 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson This is an old bug and can be closed per If6847ef446eac6be3d2390d1a341977e4ae8... [17:17:36] 10MobileFrontend, 06Reading-Web-Backlog: Handle promoting feature from beta to stable - https://phabricator.wikimedia.org/T141124#2496277 (10Jhernandez) p:05Triage>03High [17:18:03] (03CR) 10Dbrant: [C: 032] Check hosting Fragment for callback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301151 (owner: 10Niedzielski) [17:18:50] FlorianSW_, yes, I am. Also, it was assigned to me. [17:19:39] matt_flaschen: really? o.O I just read my e-mails and haven't seen, that you assigned yourself :( Sorry :(( [17:20:16] (03Merged) 10jenkins-bot: Check hosting Fragment for callback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301151 (owner: 10Niedzielski) [17:20:52] 05WMF-NDA: Requesting WMF-NDA access for Pcoombe - https://phabricator.wikimedia.org/T141382#2496287 (10Pcoombe) [17:23:13] FlorianSW_, well, you basically did what Krinkle and I discussed, and what I did or was planning to do. I thought of the idea of shimming getForm as you did. [17:23:34] FlorianSW_, except I was debating whether the shim was a good idea, or would lead to confusion if someone used a third-party ConfirmEdit plugin that extended getForm (if it's replaced, no shim or deprecation warning anymore). I was leaning against it. [17:24:15] FlorianSW_, I will reassign it to you and review your patch. [17:25:58] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/300179 (https://phabricator.wikimedia.org/T139496) (owner: 10EBernhardson) [17:26:22] (03PS10) 10Umherirrender: Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 [17:26:40] 07Design, 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, and 3 others: ULS basic visual design issues - https://phabricator.wikimedia.org/T138235#2496312 (10Nirzar) @Nikerabbit looking good :) why do we have bullets? they also seem on ran... [17:26:46] (03PS1) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 [17:27:59] (03CR) 10Umherirrender: "Patch Set 10: Rebased" [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [17:28:03] matt_flaschen: ok. Yes, I thought about this, too. In a first version of the patch (locally only) I had replaced getForm with the code you see in getFormInformation(). After I remembered our last changes to getForm() (which were less disruptive), I considered a good idea to have a fall back and a non-breaking change. But I'm still not sure, because of the same points you mentioned already. Sorry again for interrupting your [17:28:03] workflow :( [17:28:45] 10MediaWiki-Vagrant: Archives directory /vagrant/apt-cache/partial is missing. - https://phabricator.wikimedia.org/T69976#2496324 (10bd808) If you get sick and tired of this causing you problems, you can globally disable the vbguest plugin by creating a `~/.vagrant/Vagrantfile` with this content: ``` Vagrant.con... [17:29:29] 06Editing-Analysis: Investigate last-edited cookies for anonymous editors - https://phabricator.wikimedia.org/T140183#2496325 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:29:39] (03PS2) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [17:30:04] 06Editing-Analysis: Participate in the development of the editing data warehouse - https://phabricator.wikimedia.org/T136715#2496329 (10Neil_P._Quinn_WMF) p:05High>03Normal [17:30:10] FlorianSW_, please do check in the future. You should assign it to yourself anyway (so someone else doesn't start working on a task *you're* working on), and you can check if it's already assigned at the same time. [17:31:09] matt_flaschen: yep, I normally do that. In ConfirmEdit I just haven't expect, that someone contributes to it :] [17:31:22] 06Editing-Analysis: Investigate why the editor month table gives a higher number of monthly active editors than Wikistats - https://phabricator.wikimedia.org/T123803#2496332 (10Neil_P._Quinn_WMF) 05Open>03Resolved a:03Neil_P._Quinn_WMF I'm now quite confident that it has to do with non-mainspace edits, pos... [17:33:06] 06Editing-Analysis: Evaluate dashboarding solutions - https://phabricator.wikimedia.org/T125146#2496336 (10Neil_P._Quinn_WMF) 05Open>03Resolved a:03Neil_P._Quinn_WMF I'm pretty confident we should go with Dashiki, since that's what Analytics Engineering supports. [17:33:13] FlorianSW_, on the plus side, we came to several of the same conclusions, such as changing the method name for clarity. [17:33:23] So hopefully that means those are good ideas. :) [17:33:31] (03PS6) 10Jdlrobson: Do not apply horizontal padding on basic search interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299575 (https://phabricator.wikimedia.org/T140490) [17:33:33] (03PS1) 10Jdlrobson: Hide clear icon @ 240px resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301171 [17:33:42] (03CR) 10jenkins-bot: [V: 04-1] Do not apply horizontal padding on basic search interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299575 (https://phabricator.wikimedia.org/T140490) (owner: 10Jdlrobson) [17:33:52] (03CR) 10jenkins-bot: [V: 04-1] Hide clear icon @ 240px resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301171 (owner: 10Jdlrobson) [17:34:00] 06Editing-Analysis, 07Documentation: Update documentation of Editing metrics - https://phabricator.wikimedia.org/T140706#2496341 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:34:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [17:34:21] 10MediaWiki-extensions-Campaigns, 06Editing-Analysis: Campaigns should add loginCTA parameter to login->signup link (again) - https://phabricator.wikimedia.org/T136727#2496342 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:34:21] (03CR) 10Anomie: Show warnings in HTMLForm and warnings as warnings on Login/Signup form (034 comments) [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [17:34:38] 06Reading-Web-Backlog: Create proposed technical goals - https://phabricator.wikimedia.org/T140352#2496343 (10jhobs) Documentation things: * Config variables are poorly documented. It's currently hard to tell //exactly// what they do and, as we've recently seen with wikidata descriptions, having a vague idea is... [17:34:58] (03CR) 10Anomie: [C: 04-1] Show warnings in HTMLForm and warnings as warnings on Login/Signup form [core] - 10https://gerrit.wikimedia.org/r/296938 (https://phabricator.wikimedia.org/T139179) (owner: 10Florianschmidtwelzow) [17:35:04] matt_flaschen: :P [17:37:50] (03CR) 10Dbrant: [C: 032] Hygiene: remove CallbackFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301152 (owner: 10Niedzielski) [17:38:24] 06Editing-Analysis: Automate updating of editor month table - https://phabricator.wikimedia.org/T141056#2496349 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:38:34] 06Editing-Analysis: Explore generating all editor model metrics from editor month table - https://phabricator.wikimedia.org/T141057#2496350 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:39:02] 10MediaWiki-Page-editing, 10Analytics, 06Collaboration-Team-Interested, 06Community-Tech, and 6 others: statistics about edit conflicts according to page type - https://phabricator.wikimedia.org/T139019#2496351 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:39:22] 06Editing-Analysis, 10Security-Data-Mapping: Editing Data Map - https://phabricator.wikimedia.org/T133235#2496353 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:39:34] 06Editing-Analysis: Consider whether and how to deprecate "new Wikipedian"-type measures in favor on "new active editors" - https://phabricator.wikimedia.org/T136723#2496354 (10Neil_P._Quinn_WMF) p:05Triage>03Normal [17:40:07] (03Merged) 10jenkins-bot: Hygiene: remove CallbackFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301152 (owner: 10Niedzielski) [17:40:21] (03PS1) 10Jdlrobson: Make space for clear icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301173 (https://phabricator.wikimedia.org/T141378) [17:40:28] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression: Regression: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496359 (10Jdlrobson) a:03Jdlrobson [17:43:30] (03PS7) 10Jdlrobson: Do not apply horizontal padding on basic search interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299575 (https://phabricator.wikimedia.org/T140490) [17:43:43] anomie, tgr|away, do you know what the "http://ca.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=ca&modules=startup&only=scripts&skin=vector [17:44:00] Sorry, the "Sessions are disabled for this entry point" at http://ca.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=ca&modules=startup&only=scripts&skin=vector . [17:44:05] (03CR) 10Dbrant: [C: 032] Add Reading Lists to overhaul [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301153 (owner: 10Niedzielski) [17:44:06] 06Editing-Analysis: Regenerate editor month table - https://phabricator.wikimedia.org/T141055#2496365 (10Neil_P._Quinn_WMF) [17:44:29] The only open one I see per https://phabricator.wikimedia.org/maniphest/query/fKklZ8rkIFdi/#R is T134562 which should not be enabled on Catalan Wikipedia. [17:44:29] T134562: SMW triggers "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T134562 [17:44:29] matt_flaschen: load.php doesn't allow accessing the session. Usually this happens because you try to use $wgUser or $wgLang. [17:44:42] anomie, I know, just wondering if you know the cause of this particular issue, or how I can track it down. [17:44:46] (03CR) 10Jdlrobson: Hygiene: Search input should be truly Mobile First (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299011 (owner: 10Jdlrobson) [17:44:56] anomie, is there a way to get a stack trace given that it's a warning? [17:45:34] anomie, oh, never mind, that is the exception mode. [17:45:42] I'll look for the trace. [17:45:46] 10MediaWiki-extensions-DonationInterface, 10FR-ActiveMQ, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496368 (10awight) [17:46:21] (03Merged) 10jenkins-bot: Add Reading Lists to overhaul [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301153 (owner: 10Niedzielski) [17:47:48] matt_flaschen: traces are sent to logstash [17:48:02] tgr, yeah, I found it (on deployment-fluorine in this case). Filing now. [17:48:51] 10MediaWiki-jQuery-Tablesorter: Force a sortable wikitable to automatically sort by one column upon rendering - https://phabricator.wikimedia.org/T124265#2496398 (10Quiddity) Much thanks for the explanation, and especially for the suggested alternative solutions. :-) Someone more technical than I am, will hav... [17:49:09] (03Abandoned) 10Jdlrobson: Hygiene: Search input should be truly Mobile First [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299011 (owner: 10Jdlrobson) [17:49:28] 07Design, 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, and 3 others: ULS basic visual design issues - https://phabricator.wikimedia.org/T138235#2496400 (10Nikerabbit) Re bullets: they are an approximation for testing the badge icons. The... [17:52:32] 10MediaWiki-extensions-DonationInterface, 10FR-ActiveMQ, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496418 (10awight) [17:52:39] 07Design, 10MediaWiki-extensions-UniversalLanguageSelector, 10ULS-CompactLinks, 05Language-Engineering July-September 2016, and 3 others: ULS basic visual design issues - https://phabricator.wikimedia.org/T138235#2496419 (10Nirzar) ahh got it [17:54:45] (03CR) 10Dbrant: [C: 032] "nice!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301154 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [17:55:34] matt_flaschen: Looks like it was caused by https://gerrit.wikimedia.org/r/#/c/301146/, effectively a re-open of T127860. [17:55:34] T127860: MobileFrontend using ResourceLoaderGetConfigVars hook with User dependent data - https://phabricator.wikimedia.org/T127860 [17:56:02] (03PS3) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [17:56:59] (03Merged) 10jenkins-bot: Refactor NearbyFragment to use callback pattern [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301154 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [17:57:37] anomie, didn't see the reopen, but yeah. [17:58:31] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2496436 (10Mattflaschen-WMF) [17:58:58] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2496449 (10Mattflaschen-WMF) [18:00:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [18:01:04] 10AbuseFilter, 06Stewards-and-global-tools: AbuseLog to let global search by given username - https://phabricator.wikimedia.org/T141356#2496455 (10Glaisher) The query condition is `WHERE afl_user = 'user id' AND afl_user_text = 'username'` and here the user id is for the current wiki user so it always searches... [18:01:14] 10Architecture, 06Developer-Relations: Update ownership list on [[mw:Developers/Maintainers]] - https://phabricator.wikimedia.org/T128370#2496457 (10RobLa-WMF) [18:01:18] 10MediaWiki-General-or-Unknown, 06ArchCom, 10ArchCom-RfC, 06Developer-Relations, 07RfC: Fix unclear maintenance responsibilities for some parts of MediaWiki core repository - https://phabricator.wikimedia.org/T115852#2496459 (10RobLa-WMF) [18:01:24] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2496460 (10Mattflaschen-WMF) [18:01:49] (03CR) 10Mattflaschen: "Caused T141386" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301146 (https://phabricator.wikimedia.org/T141067) (owner: 10Bmansurov) [18:06:20] 10MediaWiki-Watchlist: Watchlist emails should use canonical diff URLs - https://phabricator.wikimedia.org/T72319#2496472 (10Quiddity) [18:06:38] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10The-Wikipedia-Library, 10Wikimedia-General-or-Unknown, 13Patch-For-Review: Implement Schema:ExternalLinkChange - https://phabricator.wikimedia.org/T115119#2496479 (10Samwalton9) It would be useful to just check the data in order to verify that it's w... [18:10:56] 06ArchCom, 10Architecture, 07Tracking: Streamline the Architecture Committee and the RfC process (tracking) - https://phabricator.wikimedia.org/T87470#2496500 (10RobLa-WMF) [18:10:58] 10MediaWiki-Documentation, 06ArchCom, 10Architecture, 06Developer-Relations, 07Documentation: Define the architecture areas for MediaWiki core and platform extensions - https://phabricator.wikimedia.org/T1287#2496498 (10RobLa-WMF) [18:13:06] (03PS4) 10Umherirrender: Rewrite autopromote code with handlers [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/267528 [18:14:23] (03CR) 10Umherirrender: "Patch Set 4: Rebased on extension.json" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/267528 (owner: 10Umherirrender) [18:14:42] 10Connected-Open-Heritage-New-data, 10Wiki-Loves-Monuments-Sources, 13Patch-For-Review: Add Albanian Wikipedia lists to database - https://phabricator.wikimedia.org/T140488#2496507 (10Liridon) > > Thanks! > > I've prepared [a patch](https://gerrit.wikimedia.org/r/300233) which should start harvesting these... [18:17:13] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2470147 (10MBinder_WMF) @dr0ptp4kt Can you clarify if you needed one dev to signoff on this, or all 4 that were @-me... [18:17:51] (03CR) 10Nuria: [C: 032] Properly reload tornado child processes during SIGHUP [eventlogging] - 10https://gerrit.wikimedia.org/r/300337 (https://phabricator.wikimedia.org/T140870) (owner: 10Ottomata) [18:17:57] (03CR) 10jenkins-bot: [V: 04-1] Properly reload tornado child processes during SIGHUP [eventlogging] - 10https://gerrit.wikimedia.org/r/300337 (https://phabricator.wikimedia.org/T140870) (owner: 10Ottomata) [18:22:11] (03CR) 10Florianschmidtwelzow: [C: 032] Move remaining hooks to EventLoggingHooks.php [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300045 (https://phabricator.wikimedia.org/T87912) (owner: 10Reedy) [18:22:49] (03PS3) 10Ottomata: Properly reload tornado child processes during SIGHUP [eventlogging] - 10https://gerrit.wikimedia.org/r/300337 (https://phabricator.wikimedia.org/T140870) [18:23:06] 10MediaWiki-API, 10MediaWiki-Search, 06Discovery, 06Discovery-Search-Backlog: API query search: Search title and text together - https://phabricator.wikimedia.org/T141176#2496525 (10Subfader) Not in the internal API (MW 1.25) it seems. When srwhat is not defined, only titles are found and oddly also the n... [18:27:09] 10MediaWiki-extensions-DonationInterface, 10FR-Adyen, 10Fundraising-Backlog, 07Epic: [Epic] Create Adyen forms for CA, GB, AU, NZ and IE - https://phabricator.wikimedia.org/T138456#2496532 (10awight) [18:28:25] (03CR) 10Nuria: [C: 032] Properly reload tornado child processes during SIGHUP [eventlogging] - 10https://gerrit.wikimedia.org/r/300337 (https://phabricator.wikimedia.org/T140870) (owner: 10Ottomata) [18:29:31] (03Merged) 10jenkins-bot: Move remaining hooks to EventLoggingHooks.php [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300045 (https://phabricator.wikimedia.org/T87912) (owner: 10Reedy) [18:29:37] (03CR) 10Addshore: [C: 032] dewiki_diffstats add rev timestamps & feature state [extensions/WikimediaEvents] (wmf/1.28.0-wmf.11) - 10https://gerrit.wikimedia.org/r/301119 (https://phabricator.wikimedia.org/T135751) (owner: 10Addshore) [18:30:25] (03Merged) 10jenkins-bot: dewiki_diffstats add rev timestamps & feature state [extensions/WikimediaEvents] (wmf/1.28.0-wmf.11) - 10https://gerrit.wikimedia.org/r/301119 (https://phabricator.wikimedia.org/T135751) (owner: 10Addshore) [18:30:27] (03CR) 10Florianschmidtwelzow: [C: 032] Move efSchemaValidate to EventLogging class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300046 (https://phabricator.wikimedia.org/T140908) (owner: 10Reedy) [18:31:29] (03PS6) 10Ori.livneh: Move NewPP limit report HTML comments to JS variables [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [18:31:49] (03CR) 10Ori.livneh: [C: 032] Move NewPP limit report HTML comments to JS variables [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [18:32:09] (03PS7) 10Jdlrobson: Help old users discover newly positioned language switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299681 (https://phabricator.wikimedia.org/T139794) [18:32:34] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: "Impression diet" needs to be turned ON by default - https://phabricator.wikimedia.org/T139683#2496543 (10DStrine) [18:34:37] (03CR) 10Jdlrobson: "The issue with the second click was also impacting the first click on fast connections. The display of the pointer overlay needs to happen" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299681 (https://phabricator.wikimedia.org/T139794) (owner: 10Jdlrobson) [18:35:00] 07Design, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault: Show users that language button has moved - https://phabricator.wikimedia.org/T139794#2496546 (10Jdlrobson) Addressed the issue and https://gerrit.wikimedia.org/r/#/c/299681/6 is ready for a... [18:36:32] (03PS2) 10Jdlrobson: Hide clear icon @ 240px resolutions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301171 [18:36:34] (03PS8) 10Jdlrobson: Do not apply horizontal padding on basic search interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/299575 (https://phabricator.wikimedia.org/T140490) [18:37:39] (03Merged) 10jenkins-bot: Move efSchemaValidate to EventLogging class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300046 (https://phabricator.wikimedia.org/T140908) (owner: 10Reedy) [18:37:52] (03Merged) 10jenkins-bot: Move NewPP limit report HTML comments to JS variables [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [18:38:32] 10MediaWiki-Parser, 06Performance-Team, 10PerformanceInspector, 13Patch-For-Review: Convert NewPP report from an HTML comment to a JSON configuration object - https://phabricator.wikimedia.org/T110763#2496554 (10ori) 05Open>03Resolved [18:38:54] 10MediaWiki-extensions-WikibaseRepository, 10MobileFrontend, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2489366 (10Jdlrobson) I can see Wikidata descriptions on https://www.wikidata.org/wiki/Specia... [18:40:58] 10MediaWiki-extensions-WikibaseRepository, 10MobileFrontend, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2496560 (10Jdlrobson) [18:41:15] 10MediaWiki-extensions-WikibaseRepository, 10MobileFrontend, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show any labels on Wikidata - https://phabricator.wikimedia.org/T141175#2489366 (10Jdlrobson) I see. I've updated the description with replication instructions to av... [18:42:11] (03CR) 10Jdlrobson: [C: 04-1] "Given that it is clear this solution is very brittle - Im not convinced this is the right solution. Weve only repurposed config variables " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [18:42:15] (03PS4) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [18:42:24] (03CR) 10Dbrant: [C: 032] Hygiene: use newInstance pattern for Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301155 (owner: 10Niedzielski) [18:44:44] (03Merged) 10jenkins-bot: Hygiene: use newInstance pattern for Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301155 (owner: 10Niedzielski) [18:45:34] (03PS11) 10Umherirrender: Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 [18:46:06] 06WMF-NDA-Requests, 05WMF-NDA: Requesting WMF-NDA access for Pcoombe - https://phabricator.wikimedia.org/T141382#2496567 (10Danny_B) [18:46:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [18:46:40] (03CR) 10Umherirrender: "Patch Set 10: Removed frontend part around Special:Autopromote" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [18:46:52] (03CR) 10Dbrant: [C: 032] Hygiene: use Butter Knife in NearbyFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301156 (owner: 10Niedzielski) [18:47:55] (03CR) 10Jdlrobson: "Okay I see this cannot be fixed in config now - but we could certainly make this a little cleaner/less brittle." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [18:49:01] (03Merged) 10jenkins-bot: Hygiene: use Butter Knife in NearbyFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301156 (owner: 10Niedzielski) [18:49:17] (03CR) 10jenkins-bot: [V: 04-1] Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [18:49:35] (03PS5) 10Umherirrender: Rewrite autopromote code with handlers [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/267528 [18:49:41] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 06Security-Team, 06Services, 06Services-next: Create password-authentication service for use by CentralAuth - https://phabricator.wikimedia.org/T120484#2496570 (10Pchelolo) Here's a PR with a rough prototype of the API sche... [18:50:11] (03CR) 10Umherirrender: "Patch Set 5: Removed frontend part, see dependency comments for more information" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/267528 (owner: 10Umherirrender) [18:51:12] (03PS1) 10Niedzielski: Fix Nearby NPEs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301183 [18:51:14] (03PS1) 10Niedzielski: Retain Feed and OverhaulFragment state on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301184 [18:52:23] (03CR) 10Dbrant: [C: 032] Disable location listener when backgrounded [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301157 (owner: 10Niedzielski) [18:53:20] (03PS5) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [18:54:09] (03CR) 10EBernhardson: [WIP] Strip Question Marks from Queries by Default (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [18:54:41] (03Merged) 10jenkins-bot: Disable location listener when backgrounded [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301157 (owner: 10Niedzielski) [18:56:27] (03CR) 10Dbrant: [C: 032] Refactor ReadingListsFragment to use callbacks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301158 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [18:56:29] (03PS1) 10Reedy: Convert EventLogging to extension registration [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/301185 (https://phabricator.wikimedia.org/T87912) [18:57:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [18:57:51] (03CR) 10EBernhardson: "also i suppose i didn't document it anywhere, but the .expected files can be autogenerated. Basically delete the file and run the test, if" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [18:58:41] (03Merged) 10jenkins-bot: Refactor ReadingListsFragment to use callbacks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301158 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [18:59:58] (03CR) 10jenkins-bot: [V: 04-1] Convert EventLogging to extension registration [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/301185 (https://phabricator.wikimedia.org/T87912) (owner: 10Reedy) [19:01:16] (03PS6) 10Umherirrender: Rewrite autopromote code with handlers [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/267529 [19:01:49] (03CR) 10Umherirrender: "Patch Set 6: Patch Set 5: Removed frontend part, see dependency comments for more information" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/267529 (owner: 10Umherirrender) [19:02:33] (03PS2) 10Reedy: Convert EventLogging to extension registration [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/301185 (https://phabricator.wikimedia.org/T87912) [19:04:20] (03PS12) 10Umherirrender: Rewrite autopromote code with handlers [core] - 10https://gerrit.wikimedia.org/r/267527 [19:04:51] (03CR) 10Umherirrender: "Patch Set 12: Fixed extension registry documentation" [core] - 10https://gerrit.wikimedia.org/r/267527 (owner: 10Umherirrender) [19:07:43] (03PS1) 10Sbisson: Process bundled notifications when the base is filtered out [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301187 [19:10:55] 10MediaWiki-Parser: setHook (et al) allows silly tag names - https://phabricator.wikimedia.org/T141283#2496620 (10RobinHood70) Yes. I realize it's not going to be a priority, but if the code is going to check for stupidly named hooks at all, which it already does, I think it should at least account cover off bas... [19:12:01] 10MediaWiki-extensions-Examples, 07Easy: Convert Example extensions to extension registration - https://phabricator.wikimedia.org/T141389#2496628 (10Reedy) [19:12:27] 10MediaWiki-extensions-Examples, 07Easy: Convert Example extensions to extension registration - https://phabricator.wikimedia.org/T141389#2496641 (10Reedy) [19:12:29] 10MediaWiki-Configuration, 13Patch-For-Review, 07Tracking: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668#2496640 (10Reedy) [19:13:10] 06Discovery: Sometimes an existing redirect is not found in the search indexes, so VE and other tools assume it doesn't exist - https://phabricator.wikimedia.org/T140873#2496644 (10Jdforrester-WMF) [19:13:54] 10MediaWiki-extensions-Examples, 07Easy: Convert Example extensions to extension registration - https://phabricator.wikimedia.org/T141389#2496628 (10Reedy) [19:14:11] (03CR) 10Aaron Schulz: Pass $forImmediatePublishing to UploadVerifyFile hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/300842 (https://phabricator.wikimedia.org/T140521) (owner: 10Bartosz Dziewoński) [19:16:47] (03CR) 10Dbrant: [C: 032] Refactor HistoryFragment to use callback pattern [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301159 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [19:18:06] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/300699 (https://phabricator.wikimedia.org/T138571) (owner: 10Glaisher) [19:18:22] 10MediaWiki-Categories, 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor makes redlinked category index pages inacessible - https://phabricator.wikimedia.org/T139191#2422146 (10Jdforrester-WMF) p:05Triage>03Lowest [19:19:02] (03Merged) 10jenkins-bot: Refactor HistoryFragment to use callback pattern [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301159 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [19:19:35] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Add 'hovercardsSuppressedByGadget' field to Schema:Popups and update the codebase to take this field into account - https://phabricator.wikimedia.org/T137203#2360849... [19:20:00] (03CR) 10Dbrant: [C: 032] Add callback stubs for Feed in OverhaulFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301160 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [19:24:00] (03Merged) 10jenkins-bot: Generate user vars from User passed by hook instead of $wgUser in onArticleDelete [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/300699 (https://phabricator.wikimedia.org/T138571) (owner: 10Glaisher) [19:24:02] (03Merged) 10jenkins-bot: Add callback stubs for Feed in OverhaulFragment [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301160 (https://phabricator.wikimedia.org/T139194) (owner: 10Niedzielski) [19:25:58] (03Abandoned) 10Umherirrender: Syncronize VisualEditor: 65f4ba7..a86cfc8 [extensions] - 10https://gerrit.wikimedia.org/r/290065 (owner: 10Jenkins-mwext-sync) [19:26:09] (03CR) 10Dbrant: [C: 032] Fix Nearby NPEs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301183 (owner: 10Niedzielski) [19:27:31] (03CR) 10Hashar: [C: 04-1] "upstream-branch is not used unless upstream-tree=branch" (032 comments) [debian] - 10https://gerrit.wikimedia.org/r/299100 (owner: 10Legoktm) [19:28:08] (03CR) 10Hashar: [C: 032] Improve Breaks/Replaces for mediawiki-extensions-* packages [debian] - 10https://gerrit.wikimedia.org/r/299101 (owner: 10Legoktm) [19:28:23] (03Merged) 10jenkins-bot: Fix Nearby NPEs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301183 (owner: 10Niedzielski) [19:29:04] (03CR) 10Hashar: [C: 032] Update apache config for mod_php7 [debian] - 10https://gerrit.wikimedia.org/r/299102 (owner: 10Legoktm) [19:29:08] (03CR) 10Dbrant: [C: 032] Retain Feed and OverhaulFragment state on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301184 (owner: 10Niedzielski) [19:30:36] (03PS1) 10Mholloway: Create PageFragmentContainer interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301189 (https://phabricator.wikimedia.org/T141137) [19:30:47] (03CR) 10jenkins-bot: [V: 04-1] Create PageFragmentContainer interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301189 (https://phabricator.wikimedia.org/T141137) (owner: 10Mholloway) [19:31:12] 10MediaWiki-Interface, 07I18n, 07Tracking: Messages needing PLURAL support (tracking) - https://phabricator.wikimedia.org/T40781#2496704 (10MusikAnimal) [19:31:20] (03Merged) 10jenkins-bot: Retain Feed and OverhaulFragment state on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301184 (owner: 10Niedzielski) [19:32:00] (03CR) 10Hashar: Don't add custom PHP session configuration (031 comment) [debian] - 10https://gerrit.wikimedia.org/r/299113 (owner: 10Legoktm) [19:32:34] (03CR) 10Hashar: [C: 031] Update changelog for 1:1.27.0-2 release [debian] - 10https://gerrit.wikimedia.org/r/299103 (owner: 10Legoktm) [19:32:47] (03PS2) 10Mholloway: Create PageFragmentContainer interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301189 (https://phabricator.wikimedia.org/T141137) [19:32:57] (03CR) 10jenkins-bot: [V: 04-1] Create PageFragmentContainer interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301189 (https://phabricator.wikimedia.org/T141137) (owner: 10Mholloway) [19:33:11] (03CR) 10Dbrant: [C: 032] Convert remaining HttpURLConnection usages to OkHttp [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/299265 (https://phabricator.wikimedia.org/T134904) (owner: 10Mholloway) [19:34:54] (03CR) 10BearND: [C: 032] Handle fragments in news links [services/mobileapps] - 10https://gerrit.wikimedia.org/r/300985 (https://phabricator.wikimedia.org/T141307) (owner: 10Mholloway) [19:36:07] (03CR) 10Krinkle: Move NewPP limit report HTML comments to JS variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/299693 (https://phabricator.wikimedia.org/T110763) (owner: 10Aaron Schulz) [19:37:02] (03PS1) 10Reedy: Convert GlobalBlocking to extension registration [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/301191 (https://phabricator.wikimedia.org/T87923) [19:38:14] (03PS3) 10Mholloway: Create PageFragmentContainer interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301189 (https://phabricator.wikimedia.org/T141137) [19:38:14] 06WMF-NDA-Requests: Requesting access to WMF-NDA project for @XenoRyet - https://phabricator.wikimedia.org/T141147#2496722 (10XenoRyet) Adding @K4-713, my manager, to the task to see if she can help verify my identity. [19:38:16] (03Merged) 10jenkins-bot: Handle fragments in news links [services/mobileapps] - 10https://gerrit.wikimedia.org/r/300985 (https://phabricator.wikimedia.org/T141307) (owner: 10Mholloway) [19:39:04] (03CR) 10Krinkle: "rebased to resolve conflict." [core] - 10https://gerrit.wikimedia.org/r/299272 (https://phabricator.wikimedia.org/T87871) (owner: 10Krinkle) [19:39:12] (03CR) 10Dbrant: [C: 032] Update bundled CSS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301116 (owner: 10Mholloway) [19:41:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Move queue formatting out of OutputPage [core] - 10https://gerrit.wikimedia.org/r/299272 (https://phabricator.wikimedia.org/T87871) (owner: 10Krinkle) [19:42:29] (03Merged) 10jenkins-bot: Update bundled CSS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301116 (owner: 10Mholloway) [19:46:20] (03PS2) 10Dbrant: Remove ApiUtil [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301012 (owner: 10Mholloway) [19:48:18] 10WikiCon-Francophone-2016: social events pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T122303#2496749 (10Pyb) [19:51:28] 10MobileFrontend: Bug: zoom override / text wrapping disabled on mobile device - https://phabricator.wikimedia.org/T141392#2496766 (10MBeat33) [19:53:16] (03CR) 10Dbrant: [C: 032] Remove ApiUtil [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301012 (owner: 10Mholloway) [19:53:41] 10MobileFrontend, 07Wikimedia-log-errors: Undefined variable: {title,watchTemplate} in MobileFrontend/includes/skins/SkinMinerva.php - https://phabricator.wikimedia.org/T141393#2496778 (10thcipriani) [19:55:31] (03CR) 10Niedzielski: [C: 04-1] "This looks good to me except for one question about autoVerify inline. I checked all the links and they were fine." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300676 (owner: 10Mholloway) [19:55:38] (03Merged) 10jenkins-bot: Remove ApiUtil [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301012 (owner: 10Mholloway) [19:57:09] 10MediaWiki-Configuration, 13Patch-For-Review, 07Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#2496800 (10Reedy) [19:58:19] (03PS3) 10Reedy: Convert RSS to use new extension registration [extensions/RSS] - 10https://gerrit.wikimedia.org/r/264747 (https://phabricator.wikimedia.org/T87968) (owner: 10MtDu) [19:58:53] (03CR) 10Reedy: [C: 032] Convert RSS to use new extension registration [extensions/RSS] - 10https://gerrit.wikimedia.org/r/264747 (https://phabricator.wikimedia.org/T87968) (owner: 10MtDu) [19:59:20] (03CR) 10Dbrant: [C: 032] Make first letter of Reading List titles uppercase when creating a list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300992 (https://phabricator.wikimedia.org/T133118) (owner: 10Deskana) [19:59:28] (03Merged) 10jenkins-bot: Convert RSS to use new extension registration [extensions/RSS] - 10https://gerrit.wikimedia.org/r/264747 (https://phabricator.wikimedia.org/T87968) (owner: 10MtDu) [20:00:24] (03CR) 10Smalyshev: Make content handlers assemble content for search (036 comments) [core] - 10https://gerrit.wikimedia.org/r/289021 (https://phabricator.wikimedia.org/T89733) (owner: 10Smalyshev) [20:01:26] (03Merged) 10jenkins-bot: Make first letter of Reading List titles uppercase when creating a list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300992 (https://phabricator.wikimedia.org/T133118) (owner: 10Deskana) [20:01:56] (03PS7) 10Reedy: Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [20:04:12] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault: Remove deprecated wikibase config variables from configurations - https://phabricator.wikimedia.org/T140600#2496814 (10dr0ptp4kt) Just one will do. [20:07:35] (03CR) 10Niedzielski: [C: 04-1] "This sounds great! One question inline." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 (owner: 10Mholloway) [20:07:52] (03PS6) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [20:08:09] 06Research-and-Data, 10Research-outreach: Research showcase August 2016 - https://phabricator.wikimedia.org/T140427#2496820 (10leila) a:03leila [20:08:22] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice geotargeting broken - https://phabricator.wikimedia.org/T141236#2496823 (10AndyRussG) [20:09:19] (03PS30) 10Smalyshev: Make content handlers assemble content for search [core] - 10https://gerrit.wikimedia.org/r/289021 (https://phabricator.wikimedia.org/T89733) [20:09:22] (03CR) 10Mattflaschen: [C: 04-1] "Per IRC, I think we should remove getForm to avoid issues. Will review more today with details and separate items." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/301147 (https://phabricator.wikimedia.org/T141300) (owner: 10Florianschmidtwelzow) [20:09:41] (03PS8) 10Reedy: Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [20:09:57] 06Research-and-Data, 10Research-outreach: Research showcase August 2016 - https://phabricator.wikimedia.org/T140427#2496828 (10leila) @halfak please let me know if you want to use the 30-min in the August showcase. If you don't use it, I'll reach out to Amy (http://people.csail.mit.edu/axz/) who we want to ho... [20:10:11] 06Research-and-Data, 10Research-outreach: Research showcase August 2016 - https://phabricator.wikimedia.org/T140427#2496829 (10DarTar) [20:10:29] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Store referrer outside of 'donor' key - https://phabricator.wikimedia.org/T141152#2496830 (10DStrine) p:05Triage>03High [20:11:15] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: DonationInterface gateway/config/*.yaml should be overrideable by deployed configuration - https://phabricator.wikimedia.org/T140947#2496833 (10DStrine) p:05Triage>03Normal [20:11:16] (03CR) 10Reedy: [C: 032] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [20:11:38] 06Research-and-Data, 10Research-outreach: Research showcase August 2016 - https://phabricator.wikimedia.org/T140427#2496837 (10Halfak) Yup. I'm in. Good to mix internal and external speakers. [20:12:17] (03CR) 10Reedy: [V: 032] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [20:12:23] (03CR) 10Reedy: Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [20:12:28] damn it [20:14:49] (03PS16) 10Smalyshev: Make content handler produce field data [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/289115 (https://phabricator.wikimedia.org/T89733) [20:15:01] (03CR) 10Catrope: [C: 032] Process bundled notifications when the base is filtered out [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301187 (owner: 10Sbisson) [20:15:12] (03CR) 10Reedy: [C: 04-1] "Yeah, $wgVipsOptions ends up as an empty array..." [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [20:16:02] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression: Search magnifying glass and placeholder text mashed together in Opera Mini - https://phabricator.wikimedia.org/T140490#2496843 (10dr0ptp4kt) Ah, okay, thanks! Looks like I was checking o... [20:17:01] (03CR) 10Tjones: "@Ebernhardson: I updated wildcard_api.feature, but I can't find info on how to run the browser tests on my laptop. I've added Cindy as a r" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:17:49] 10MediaWiki-extensions-VipsScaler, 13Patch-For-Review: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1001872 (10Reedy) >>! In T87991#1917502, @Legoktm wrote: > Wait no, this is not a good GCI task, sorry. The $wgVipsOptions setting needs to be looked at closely. A... [20:18:21] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Muggle Baiting, 03Fundraising Sprint Nitpicking: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and action=edit pages - https://phabricator.wikimedia.org/T139439#2496847 (10DStrine) a:... [20:18:25] (03CR) 10EBernhardson: "running browser tests is pretty tricky, lots of gotchas...for the most part I let cindy do it for me. Now that jenkins is happy (cindy wil" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:18:44] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 03Fundraising Sprint Muggle Baiting, 03Fundraising Sprint Nitpicking: CentralNotice: finalize list of wild useless cookies for slurp, and push config change - https://phabricator.wikimedia.org/T135090#2496848 (10DStrine) a:03AndyRussG [20:19:10] 10MediaWiki-extensions-DonationInterface, 10Continuous-Integration-Config, 10Fundraising-Backlog, 03Fundraising Sprint Nitpicking, 07Unplanned-Sprint-Work: Continuous integration mw-ext composer behavior is not predictable - https://phabricator.wikimedia.org/T141309#2496849 (10DStrine) a:03awight [20:21:30] (03Merged) 10jenkins-bot: Process bundled notifications when the base is filtered out [extensions/Echo] - 10https://gerrit.wikimedia.org/r/301187 (owner: 10Sbisson) [20:21:40] (03CR) 10EBernhardson: [WIP] Strip Question Marks from Queries by Default (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:22:07] 10MediaWiki-extensions-DonationInterface, 10FR-ActiveMQ, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 03Fundraising Sprint Nitpicking: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496867 (10cwdent) a:03cwdent [20:22:42] 10MediaWiki-extensions-SecurePoll: Convert SecurePoll to use extension registration - https://phabricator.wikimedia.org/T87972#2496871 (10Reedy) 05Open>03Resolved a:03Reedy Was done in https://github.com/wikimedia/mediawiki-extensions-SecurePoll/commit/f0f5e666ee428081afc2b3c2fae2901c4b8bccab [20:22:44] 10MediaWiki-Configuration, 13Patch-For-Review, 07Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#2496874 (10Reedy) [20:23:44] (03CR) 10EBernhardson: "I totally forgot to mention actual directions...there are directions in tests/browser/README that are probably mostly up to date. The shor" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:25:23] 10MobileFrontend: Bug: zoom override / text wrapping disabled on mobile device - https://phabricator.wikimedia.org/T141392#2496766 (10Jdlrobson) Feels like this may be related to T140651 in some way Can anyone tell what device this is from the chrome (it looks like Android)? [20:25:36] (03PS3) 10Nuria: Tornado should fork num_processes before instantiating eventlogging writers [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 (owner: 10Ottomata) [20:26:11] (03CR) 10jenkins-bot: [V: 04-1] Tornado should fork num_processes before instantiating eventlogging writers [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 (owner: 10Ottomata) [20:28:19] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/create_new_page.feature:17:18 features/wildcard_api.feature:8:9:10:25:26:3" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:28:48] (03CR) 10Tjones: "Thanks for the help. I'll try running everything from inside vagrant." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:28:52] (03CR) 10Nuria: Tornado should fork num_processes before instantiating eventlogging writers (031 comment) [eventlogging] - 10https://gerrit.wikimedia.org/r/301148 (owner: 10Ottomata) [20:31:19] (03CR) 10EBernhardson: [WIP] Strip Question Marks from Queries by Default (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:31:24] (03PS1) 10Aaron Schulz: Only pretty-print the parser report JS vars [core] - 10https://gerrit.wikimedia.org/r/301195 [20:32:26] 07I18n, 07RTL: AceEditor in Graph Insert Dialog with RTL interface - text selection is broken - https://phabricator.wikimedia.org/T141395#2496890 (10eranroz) [20:32:28] (03CR) 10Jdlrobson: "Any reason this is a WIP patch?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/300438 (https://phabricator.wikimedia.org/T139759) (owner: 10Jhobs) [20:33:23] (03PS1) 10Reedy: Convert FundraisingEmailUnsubscrive to extension registration [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/301196 (https://phabricator.wikimedia.org/T108764) [20:33:30] (03CR) 10Tjones: [WIP] Strip Question Marks from Queries by Default (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [20:33:45] 10MediaWiki-extensions-DonationInterface, 10FR-ActiveMQ, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 03Fundraising Sprint Nitpicking: Queue messages should be in normalized form - https://phabricator.wikimedia.org/T141383#2496910 (10awight) [20:33:48] 10MediaWiki-extensions-DonationInterface, 10Fundraising Tech Backlog, 10Fundraising-Backlog: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2496908 (10awight) [20:35:41] 10MediaWiki-extensions-DonationInterface, 10Fundraising Tech Backlog, 10Fundraising-Backlog: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#1560019 (10awight) [20:35:44] 10MediaWiki-extensions-DonationInterface, 10FR-ActiveMQ, 10FR-Smashpig, 10Fundraising-Backlog, and 2 others: [Epic] Formalize schema for all message types - https://phabricator.wikimedia.org/T131272#2496916 (10awight) [20:36:48] 10MediaWiki-extensions-DonationInterface, 10Fundraising Tech Backlog, 10Fundraising-Backlog: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2496931 (10cwdent) a:03cwdent [20:36:59] 10CirrusSearch, 06Discovery, 03Discovery-Search-Sprint: Add method for more like api query to not boost pages by popularity - https://phabricator.wikimedia.org/T128822#2496934 (10Jdlrobson) @EBernhardson / @debt how do we use this in API? Could we have some sample API links to test with? Not clear from subta... [20:38:28] (03PS1) 10Mholloway: Update mobileapps to 1259b63 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/301197 [20:38:45] 10Android-app-feature-Feeds, 06Wikipedia-Android-App-Backlog: Feed contents should be configurable - https://phabricator.wikimedia.org/T141397#2496939 (10Niedzielski) [20:40:00] (03CR) 10Mholloway: [C: 032] Update mobileapps to 1259b63 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/301197 (owner: 10Mholloway) [20:40:49] (03Merged) 10jenkins-bot: Update mobileapps to 1259b63 [services/mobileapps/deploy] - 10https://gerrit.wikimedia.org/r/301197 (owner: 10Mholloway) [20:42:37] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault, 07Regression: Regression: Clear icon overlaps input text - https://phabricator.wikimedia.org/T141378#2496954 (10MBinder_WMF) [20:42:39] 10MobileFrontend, 06Reading-Web-Backlog, 07Browser-Support-Firefox, 13Patch-For-Review, and 2 others: Magnifying glass misaligned in Firefox on the language switcher overlay - https://phabricator.wikimedia.org/T139928#2496955 (10MBinder_WMF) [20:43:02] 10CirrusSearch, 06Discovery, 03Discovery-Search-Sprint: Add method for more like api query to not boost pages by popularity - https://phabricator.wikimedia.org/T128822#2496956 (10dcausse) @Jdlrobson you have a new qiprofile param that can take 3 arguments: * classic: default * classic_noboostlinks: Ranking b... [20:43:48] (03PS7) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [20:46:45] 06MediaWiki-Farmers: Create and add Mediawiki-Farmers phabricator project logo - https://phabricator.wikimedia.org/T87736#2496961 (10Luke081515) 05Open>03Resolved I uploaded that picture to the project. [20:48:10] (03PS1) 10Reedy: Move global functions to class [extensions/timeline] - 10https://gerrit.wikimedia.org/r/301211 [20:48:59] 10EasyTimeline: Convert EasyTimeline extension to use extension registration - https://phabricator.wikimedia.org/T88064#1003322 (10Reedy) Pre-requisite stuff done in https://gerrit.wikimedia.org/r/301211 [20:49:48] 10Hovercards, 06Reading-Web-Backlog, 13Patch-For-Review, 13Patch-Needs-Improvement, 03Reading-Web-Sprint-78-T: Fix hovercard preferences alignment issues [polish] - https://phabricator.wikimedia.org/T138612#2496966 (10Jdlrobson) The patch needs improvement. Please test this before submitting again. Also... [20:50:02] (03CR) 10Jdlrobson: [C: 04-1] "See https://phabricator.wikimedia.org/T138612#2496966" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/295946 (https://phabricator.wikimedia.org/T138612) (owner: 10VolkerE) [20:50:36] 10CirrusSearch, 06Discovery, 03Discovery-Search-Sprint: Add method for more like api query to not boost pages by popularity - https://phabricator.wikimedia.org/T128822#2496967 (10Jdlrobson) Thank you :) [20:52:01] 10MediaWiki-extensions-RelatedArticles: Related Pages should not boost pages by popularity - https://phabricator.wikimedia.org/T141398#2496968 (10Jdlrobson) [20:52:04] Reedy: https://gerrit.wikimedia.org/r/#/c/301051/ [20:52:15] 10CirrusSearch, 06Discovery, 03Discovery-Search-Sprint: Add method for more like api query to not boost pages by popularity - https://phabricator.wikimedia.org/T128822#2087141 (10Jdlrobson) @JKatzWMF I've setup T141398 [20:53:13] 06Research-and-Data, 10Research-outreach: Research showcase August 2016 - https://phabricator.wikimedia.org/T140427#2496986 (10Halfak) [20:53:25] 10MediaWiki-extensions-SemanticForms: Semantic Forms totally broken - https://phabricator.wikimedia.org/T140554#2468904 (10Seb35) Does it work for you? As said Nikerabbit, given Semantic Forms recently changed its loading, perhaps you need to clean up your installation. If you want to install it with Composer,... [20:53:30] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/289115 (https://phabricator.wikimedia.org/T89733) (owner: 10Smalyshev) [20:53:34] 10MediaWiki-extensions-Mailgun, 13Patch-For-Review, 05Security: Mailgun extension instructions recommend potentially insecure (and bad) way to store credentials - https://phabricator.wikimedia.org/T138275#2496991 (10Bawolff) [20:55:08] (03CR) 10Jdlrobson: "Florian. Sounds like a good idea for a future patchset but Im already suffering from code creep so would rather not do that hear until we " [core] - 10https://gerrit.wikimedia.org/r/280904 (https://phabricator.wikimedia.org/T121469) (owner: 10Jdlrobson) [20:55:23] 06Research-and-Data, 10Research-outreach: Research showcase August 2016 - https://phabricator.wikimedia.org/T140427#2496995 (10leila) sounds good. [20:56:55] (03CR) 10Hoo man: Don't override the wbptterms GET parameter in extendSearchParams (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [20:56:59] 10MediaWiki-extensions-SemanticForms: Semantic Forms totally broken - https://phabricator.wikimedia.org/T140554#2496998 (10Seb35) p:05Triage>03Normal [20:57:15] (03PS2) 10Hoo man: Don't override the wbptterms GET parameter in extendSearchParams [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) [20:59:02] (03PS1) 10Ottomata: Add page, revision, and user change schemas for more consistent change modeling [event-schemas] - 10https://gerrit.wikimedia.org/r/301284 (https://phabricator.wikimedia.org/T134502) [21:00:58] (03PS29) 10Jdlrobson: Allow one column diffs as well as side by side [core] - 10https://gerrit.wikimedia.org/r/280904 (https://phabricator.wikimedia.org/T121469) [21:01:25] (03CR) 10jenkins-bot: [V: 04-1] Allow one column diffs as well as side by side [core] - 10https://gerrit.wikimedia.org/r/280904 (https://phabricator.wikimedia.org/T121469) (owner: 10Jdlrobson) [21:01:28] 10MediaWiki-extensions-WikibaseRepository, 10MobileFrontend, 10Wikidata, 07Regression, 03Wikidata-Sprint-2016-08-02: Special:Nearby doesn't show human readable labels on Wikidata (shows item id) - https://phabricator.wikimedia.org/T141175#2497010 (10Jdlrobson) [21:02:57] (03PS2) 10Reedy: Clean up forEachOpenConnection() loop and use the method more [core] - 10https://gerrit.wikimedia.org/r/301051 (owner: 10Aaron Schulz) [21:03:04] (03CR) 10Reedy: [C: 032] Clean up forEachOpenConnection() loop and use the method more [core] - 10https://gerrit.wikimedia.org/r/301051 (owner: 10Aaron Schulz) [21:04:29] (03CR) 10Hoo man: "I verified that this actually fixes the problem by changing the value of the "wbptterms" parameter manually using my debugger." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [21:06:29] (03CR) 10Jdlrobson: [C: 04-1] "The test says it prioritizes MobileFrontend configuration. This is no longer true so please update the test name. Sam was there any reason" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [21:10:26] (03Merged) 10jenkins-bot: Clean up forEachOpenConnection() loop and use the method more [core] - 10https://gerrit.wikimedia.org/r/301051 (owner: 10Aaron Schulz) [21:12:26] 10Wikimedia-General-or-Unknown, 13Patch-For-Review: Update extensions in extension-list to use extension.json where they exist - https://phabricator.wikimedia.org/T139800#2497026 (10Reedy) ``` reedy@ubuntu64-web-esxi:~/git/operations/mediawiki-config/wmf-config$ grep php$ extension-list $IP/extensions/AbuseFil... [21:12:29] (03PS5) 10Jdlrobson: ResourceLoader should support deprecation of modules [core] - 10https://gerrit.wikimedia.org/r/299090 (https://phabricator.wikimedia.org/T137772) [21:12:42] (03CR) 10Jdlrobson: ResourceLoader should support deprecation of modules (032 comments) [core] - 10https://gerrit.wikimedia.org/r/299090 (https://phabricator.wikimedia.org/T137772) (owner: 10Jdlrobson) [21:14:36] 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Sprint-77-Segmentation-fault: Sort mobile web language switcher list case insensitive - https://phabricator.wikimedia.org/T139759#2441756 (10Jdlrobson) The patch is fine. Waiting on the PHPUnit test now so we can verify it does what... [21:15:00] (03CR) 10Niedzielski: [C: 04-1] Create PageFragmentContainer interface (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/301189 (https://phabricator.wikimedia.org/T141137) (owner: 10Mholloway) [21:15:05] (03PS3) 10Hoo man: Don't override the wbptterms GET parameter in extendSearchParams [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) [21:15:49] (03CR) 10Hoo man: "Splitted the test in one for the overrides and one for the adding of "description" if the feature is enabled." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) (owner: 10Hoo man) [21:18:02] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: features/create_new_page.feature:17:18" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [21:21:07] (03PS4) 10Hoo man: Don't override the wbptterms GET parameter in extendSearchParams [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301107 (https://phabricator.wikimedia.org/T141175) [21:21:56] (03CR) 10Mholloway: Update license content and handling (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300676 (owner: 10Mholloway) [21:22:03] (03PS1) 10Ejegg: Update payments-wiki account instructions [vagrant] - 10https://gerrit.wikimedia.org/r/301286 [21:22:37] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10The-Wikipedia-Library, 10Wikimedia-General-or-Unknown, 13Patch-For-Review: Implement Schema:ExternalLinkChange - https://phabricator.wikimedia.org/T115119#2497042 (10Milimetric) Sure, but I can't output everything due to the capsule containing privat... [21:28:18] 06Project-Admins: Replace tracking T40638 with project - https://phabricator.wikimedia.org/T140077#2497045 (10Danny_B) >>! In T140077#2490906, @Nemo_bis wrote: >> Would people agree to replace T40638 with a project instead? > > No. It would be very harmful, as people would start adding only the project and forg... [21:29:38] (03PS8) 10Tjones: [WIP] Strip Question Marks from Queries by Default [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) [21:33:49] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10The-Wikipedia-Library, 10Wikimedia-General-or-Unknown, 13Patch-For-Review: Implement Schema:ExternalLinkChange - https://phabricator.wikimedia.org/T115119#2497049 (10Samwalton9) Sounds great, done. [21:34:09] 10MediaWiki-extensions-Translate, 10CirrusSearch, 06Discovery, 06Discovery-Search-Backlog: Translation subpages should not be searched - https://phabricator.wikimedia.org/T125944#2497051 (10Cpiral) @debt, to solve //all// the problems listed, present a **search domain option based on language**, just as we... [21:34:37] (03PS1) 10Siddparmar: hoz chart update & minor fixes [wikimedia/TransparencyReport-private] - 10https://gerrit.wikimedia.org/r/301290 [21:35:07] (03CR) 10Siddparmar: [C: 032 V: 032] hoz chart update & minor fixes [wikimedia/TransparencyReport-private] - 10https://gerrit.wikimedia.org/r/301290 (owner: 10Siddparmar) [21:35:11] Eurgh. [21:35:26] Can we stop pushing Developers/Maintainers? It's flawed-by-design. :-( [21:36:09] 10Gerrit, 10Wikimedia-Logstash: Add gerrit event stream events to logstash - https://phabricator.wikimedia.org/T64505#2497053 (10hashar) >>! In T141324#2494439, @bd808 wrote: > Note I'm not sure if that is really useful or not. I think it was from the early Logstash days when I was filing "send X to Logstash"... [21:37:13] 10Gerrit, 10Wikimedia-Logstash: Add gerrit event stream events to logstash - https://phabricator.wikimedia.org/T64505#2497060 (10hashar) I could image use cases such as quickly finding out patches that got merged over a given time frame or creating some kind of dynamic dashboard of reviews. Unless there is a... [21:37:42] 04(no projects): Support console access for nova VMs - https://phabricator.wikimedia.org/T141399#2497061 (10Andrew) [21:38:09] (03CR) 10MtDu: "Just some things I don't understand. Doesn't mean you did it wrong." (033 comments) [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/301196 (https://phabricator.wikimedia.org/T108764) (owner: 10Reedy) [21:38:17] 10MediaWiki-extensions-SemanticForms: Form preview doesn't work when using Special:FormEdit?form=foo&target=bar syntax - https://phabricator.wikimedia.org/T125131#2497074 (10Seb35) p:05Triage>03Low [21:41:05] (03CR) 10Reedy: Convert FundraisingEmailUnsubscrive to extension registration (033 comments) [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/301196 (https://phabricator.wikimedia.org/T108764) (owner: 10Reedy) [21:41:08] (03CR) 10Legoktm: [C: 032] Add comment to ChangesList::showCharacterDifference [core] - 10https://gerrit.wikimedia.org/r/299134 (owner: 10Umherirrender) [21:41:22] Reedy: ping [21:41:30] MtDu: Hi [21:42:19] Reedy: So I have a bunch of questions. First, what specifically is a rebase? [21:42:32] Reedy: And btw, thanks for the reviews. [21:42:39] A rebase? [21:42:48] It's "basing" a commit ontop of a new commit [21:42:53] Crappy term [21:43:06] Basically, it's moving a commit from being ontop of whatever commit you made it on originally [21:43:13] Usually ontop of HEAD [21:43:24] But it's similar when you put it onto other branches too [21:43:41] Reedy: Ok. So what's the process of doing that? [21:44:04] (03CR) 10Cdentinger: [C: 032] Update payments-wiki account instructions [vagrant] - 10https://gerrit.wikimedia.org/r/301286 (owner: 10Ejegg) [21:44:34] MtDu: Well, you can just press the rebase button in gerrit [21:44:38] If it's trivial, it'll just do it [21:45:18] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/301170 (https://phabricator.wikimedia.org/T133711) (owner: 10Tjones) [21:45:37] Gotcha. [21:46:06] Or, you can do a more traditional locally with git [21:46:32] How do you do that? [21:47:08] the most basic one is [21:47:10] git rebase origin [21:47:58] (03Merged) 10jenkins-bot: Add comment to ChangesList::showCharacterDifference [core] - 10https://gerrit.wikimedia.org/r/299134 (owner: 10Umherirrender) [21:48:01] (03Merged) 10jenkins-bot: Update payments-wiki account instructions [vagrant] - 10https://gerrit.wikimedia.org/r/301286 (owner: 10Ejegg) [21:48:44] ok thanks [21:49:33] MtDu: Usually, rebasing means it saves a merge commit [21:49:40] Makes the history a bit cleaner [21:49:58] oh hey MtDu [21:51:07] 10MediaWiki-Uploading, 06Commons, 06Multimedia, 07JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#2497087 (10Gunnex) Finished now the analysis of cross-wiki-... [21:52:13] (03CR) 10MtDu: "Some more qs." (035 comments) [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/301196 (https://phabricator.wikimedia.org/T108764) (owner: 10Reedy) [21:52:19] (03CR) 10Krinkle: Only pretty-print the parser report JS vars (031 comment) [core] - 10https://gerrit.wikimedia.org/r/301195 (owner: 10Aaron Schulz) [21:52:23] OH-: Hello. [21:52:51] Reedy: And then I have some questions about this patchset i was looking at. [21:52:52] https://gerrit.wikimedia.org/r/#/c/301211/1/Timeline.php [21:53:20] (03PS1) 10Legoktm: ParserTest: Declare $recorder property [core] - 10https://gerrit.wikimedia.org/r/301295 [21:53:23] (03PS1) 10Legoktm: ParserTest: Remove warning about gd extension not being installed [core] - 10https://gerrit.wikimedia.org/r/301296 [21:53:35] Reedy: I don't quite understand how you determine which functions to make private, public. Also, is static the one you said that is "always just there"? [21:54:01] so, do you know what public, protected and private mean? [21:55:00] if it's not static (and public, for ease), you've got to do $foo = new MyClass(); $foo->myFunction(); [21:55:13] if it is static (and public) you can just do MyClass::myFunction() [21:55:19] Both have uses and benefits [21:55:52] Reedy: Is this explanation correct? http://stackoverflow.com/questions/4361553/php-public-private-protected [21:56:07] Yup [21:58:22] (03PS8) 10Krinkle: Make onTransactionIdle() safer for multi-DB commits [core] - 10https://gerrit.wikimedia.org/r/300698 (owner: 10Aaron Schulz) [21:59:15] (03PS1) 10Legoktm: Use $this->msg() where possible [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301298 [21:59:17] (03PS1) 10Legoktm: Fix casing of Title::getLocalURL() calls [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301299 [21:59:19] (03PS1) 10Legoktm: Remove unused variable [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301300 [21:59:21] (03PS1) 10Legoktm: Configure phpcs via "composer test" and fix issues [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301301 [21:59:23] (03CR) 10Reedy: Convert FundraisingEmailUnsubscrive to extension registration (032 comments) [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/301196 (https://phabricator.wikimedia.org/T108764) (owner: 10Reedy) [21:59:47] Reedy: So using the example of the class Grandpa in that explanation at the bottom. What syntax would I use to get the name if it was a private function? [22:00:03] private variable* [22:00:22] You wouldn't be able to [22:00:46] (03PS5) 10Mholloway: Fix lint errrors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 [22:01:08] Reedy: I see. So back to the original question. How do you determine which need to be which? [22:01:18] You can probably hack reflection to use it [22:01:23] (03CR) 10Mholloway: Fix lint errrors (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 (owner: 10Mholloway) [22:01:25] (03PS1) 10Ejegg: Add sample Amazon config to main page of paymentswiki [vagrant] - 10https://gerrit.wikimedia.org/r/301302 [22:01:31] So, protected is easy to answer here [22:01:46] You want subclasses to be able to access it, but you don't want the outside world to [22:01:52] (03CR) 10jenkins-bot: [V: 04-1] Fix lint errrors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 (owner: 10Mholloway) [22:01:54] private is you don't want the outside world to [22:02:02] public you want anyone to [22:02:46] (03PS6) 10Mholloway: Fix lint errrors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 [22:04:01] Reedy: Yeah ok. But how do you apply that knowledge to a function. How do you determine who you want to be able to use it? [22:04:13] That's a hard one [22:04:23] What's it doing? [22:04:35] Is it internal processing? Is it something obviously for everyone [22:04:44] It's something you get to learn as you program more [22:06:05] Reedy: Ok. [22:07:53] 10Gerrit, 10Wikimedia-Logstash: Add gerrit event stream events to logstash - https://phabricator.wikimedia.org/T64505#2497097 (10demon) 05Open>03declined >>! In T64505#2497060, @hashar wrote: > I could image use cases such as quickly finding out patches that got merged over a given time frame or creating s... [22:08:45] Reedy: What do you recommend for this? https://gerrit.wikimedia.org/r/#/c/263028/8/extension.json In the original php file, the options are the first definition. In the .i18n one, it sets it to none for testing I think. Is it ok to just leave it defined with all its values? [22:09:38] Sorry, I don't follow [22:10:10] (03CR) 10Niedzielski: [C: 032] Fix lint errrors (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 (owner: 10Mholloway) [22:11:29] 10Gerrit, 07Upstream: Sometimes gerrit mails don't go into same thread in gmail - https://phabricator.wikimedia.org/T38288#2497101 (10hashar) Now that we have upgraded to Gerrit 2.12 I have revisited the upstream bugs and replied there. Below is a summary of my conclusion: ---- https://bugs.chromium.org/p/ger... [22:12:02] Reedy: So right now, the problem is that VipsOptions is defined twice in the config in extension.json. The first definition is from https://gerrit.wikimedia.org/r/#/c/263028/8/VipsScaler.php file. The second is from https://gerrit.wikimedia.org/r/#/c/263028/8/VipsTest.php file. My question is, is the second definition even still necessary if I removed the entry point? [22:12:50] God I'm a moron [22:12:57] Yeah, I shouldn't have added it twice [22:12:57] (03Merged) 10jenkins-bot: Fix lint errrors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300691 (owner: 10Mholloway) [22:13:45] It wouldn't do anything in production... As test is loaded after the extension itself, and then overridden in WMF [22:14:04] Reedy: So the second def. wouldn't do anything? [22:14:13] Probably not [22:14:17] It's defintely wrong [22:14:30] Reedy: But the other things you added in the config would right? Because they're just assigning values, so those are still necessary? [22:14:32] Feel free to remove it :P [22:15:12] Reedy: Remove all of them or just the second definition of VipsOptions? [22:15:42] Just the second definition [22:15:43] (03CR) 10Krinkle: [C: 031] "LGTM. Nice :) Two minor suggestions." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/300698 (owner: 10Aaron Schulz) [22:15:52] Reedy: K. [22:16:03] The other 2 are needed for the test page thing [22:16:05] 04(no projects): debian signing keyid E84AFDD2 has expired - https://phabricator.wikimedia.org/T141400#2497106 (10cscott) [22:16:16] (03CR) 10Krinkle: [C: 032] Use $this->msg() where possible [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301298 (owner: 10Legoktm) [22:16:33] 10Gerrit, 07LDAP: Change LDAP cn to something more useful - https://phabricator.wikimedia.org/T141298#2497117 (10Danny_B) [22:16:41] (03CR) 10Niedzielski: [C: 031] "Hm, doesn't seem to harm anything but I'm not sure I notice the difference on my device. It just shows me whatever I used last. https://sl" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/300676 (owner: 10Mholloway) [22:16:57] (03Merged) 10jenkins-bot: Use $this->msg() where possible [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/301298 (owner: 10Legoktm) [22:20:37] 10MediaWiki-extensions-DonationInterface, 10Fundraising Tech Backlog, 10Fundraising-Backlog, 03Fundraising Sprint Nitpicking: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2497146 (10awight) [22:27:20] (03CR) 10Krinkle: [C: 031] Simplify and cleanup SubmissionHandler transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/301069 (https://phabricator.wikimedia.org/T141172) (owner: 10Aaron Schulz) [22:29:43] Thanks for answering my questions Reedy. I'll remove the second usage later. [22:29:45] 10MediaWiki-ResourceLoader, 07JavaScript: Remove JSON polyfill - https://phabricator.wikimedia.org/T141344#2497194 (10Jdforrester-WMF) @Krinkle I believe the last major browser for which we needed this was IE8, which indeed is now Grade C; is there any other reason we were holding back on this? [22:31:20] 10MediaWiki-Releasing, 10Parsoid, 06Release-Engineering-Team: debian signing keyid E84AFDD2 has expired - https://phabricator.wikimedia.org/T141400#2497197 (10greg) [22:32:32] 06WMF-NDA-Requests: Requesting WMF-NDA access for Pcoombe - https://phabricator.wikimedia.org/T141382#2497198 (10Peachey88) [22:33:06] 05MW-1.28-release-notes, 13Patch-For-Review, 07Performance: Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}} - https://phabricator.wikimedia.org/T137900#2497200 (10GWicke) These "preview-only" warnings are causing Parsoid render issues [like this](https://en.wikipedia.org/api/rest_v... [22:34:16] 10Gerrit, 07Upstream: Sometimes gerrit mails don't go into same thread in gmail - https://phabricator.wikimedia.org/T38288#2497201 (10demon) 05Open>03Resolved a:03demon Lacking some timestamp precision could kind of suck in theory. But since that ID is based on a single change and should be based on the... [22:35:11] 10MobileFrontend: Bug: zoom override / text wrapping disabled on mobile device - https://phabricator.wikimedia.org/T141392#2497205 (10MBeat33) The donor says the phone is an HTC One a9. From their reply: // ...Wikipedia continued to be useable for many weeks after I migrated to the HTC One, although the new ph... [22:36:48] 10MediaWiki-Releasing, 10Parsoid, 06Release-Engineering-Team: debian signing keyid E84AFDD2 has expired - https://phabricator.wikimedia.org/T141400#2497207 (10greg) Adding Filippo because it looks like he created it: ``` Date: Tue Jul 22 16:22:56 2014 +0000 From: git@palladium.eqiad.wmnet Subject: [Ops] [p... [22:37:28] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 06Security-Team, 06Services, 06Services-next: Create password-authentication service for use by CentralAuth - https://phabricator.wikimedia.org/T120484#2497209 (10GWicke) @Pchelolo also set up a demo of the draft API spec a... [22:37:36] 10MediaWiki-Releasing, 06Operations, 10Parsoid, 06Release-Engineering-Team: debian signing keyid E84AFDD2 has expired - https://phabricator.wikimedia.org/T141400#2497211 (10greg) [22:38:40] 14Trash: 高雄提案 - https://phabricator.wikimedia.org/T137624#2497212 (10Danny_B) 05Open>03Invalid [22:43:14] 10MediaWiki-ResourceLoader, 07JavaScript: Remove JSON polyfill - https://phabricator.wikimedia.org/T141344#2497223 (10Krinkle) @Schnark The module already has a skip-function that essentially implements such feature test but in a backward-compatible way. This doesn't have to block jQuery 3.0 (T124742), but I'... [22:47:08] 10Gerrit: Reviewing a patch in Gerrit and removing yourself from reviewers list deletes the review flag - https://phabricator.wikimedia.org/T115851#1734652 (10hashar) If you are no more a reviewer there is no point in keeping your vote, afterall you are not going to receive reply / new patchset notifications. I... [22:48:38] 10MediaWiki-Uploading, 06Commons, 06Multimedia, 07JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#2497235 (10Yann) Thanks @Gunnex for this great analysis. I... [22:50:50] (03CR) 10Krinkle: [C: 031] Make revision deletion acquire file locks to avoid races (031 comment) [core] - 10https://gerrit.wikimedia.org/r/300317 (owner: 10Aaron Schulz) [22:51:08] 10MediaWiki-ResourceLoader, 07JavaScript: Remove JSON polyfill - https://phabricator.wikimedia.org/T141344#2497241 (10Krinkle) [22:51:11] 10MediaWiki-ResourceLoader, 07JavaScript, 13Patch-For-Review: Upgrade to jQuery 3.0 - https://phabricator.wikimedia.org/T124742#2497240 (10Krinkle) [22:52:36] 10MediaWiki-ResourceLoader, 07JavaScript: Remove JSON polyfill - https://phabricator.wikimedia.org/T141344#2494928 (10Krinkle) [22:52:39] 10MediaWiki-ResourceLoader, 07JavaScript, 13Patch-For-Review: Upgrade to jQuery 3.0 - https://phabricator.wikimedia.org/T124742#1964781 (10Krinkle) [22:52:43] 10MediaWiki-ResourceLoader, 07JavaScript: Remove JSON polyfill - https://phabricator.wikimedia.org/T141344#2494928 (10Krinkle) [22:52:46] 10MediaWiki-ResourceLoader, 07JavaScript, 13Patch-For-Review: Upgrade to jQuery 3.0 - https://phabricator.wikimedia.org/T124742#1964781 (10Krinkle) [22:54:32] 10MediaWiki-Releasing, 06Operations, 10Parsoid, 06Release-Engineering-Team: debian signing keyid E84AFDD2 has expired - https://phabricator.wikimedia.org/T141400#2497264 (10greg) We should probably update https://wikitech.wikimedia.org/wiki/Releases.wikimedia.org (or add a new page and link to it from [[Re... [22:56:35] (03PS9) 10Reedy: Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [22:57:02] DAMN IT [22:57:09] (03PS1) 10Krinkle: rlfeature: Measure result of JSON feature test [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/301308 (https://phabricator.wikimedia.org/T141344) [22:57:23] (03PS10) 10Reedy: Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [22:59:28] (03CR) 10Reedy: "-1 removed by fixing the fail I introduced." [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [22:59:33] (03CR) 10MtDu: [C: 031] "Thanks for removing it Reedy." [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [23:03:42] 10Gerrit: Reviewing a patch in Gerrit and removing yourself from reviewers list deletes the review flag - https://phabricator.wikimedia.org/T115851#2497275 (10demon) 05Open>03declined Declining. The notice suffices. [23:03:44] (03CR) 10Krinkle: Use async API calls for wikitext parsing (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/276689 (https://phabricator.wikimedia.org/T46925) (owner: 10Mattflaschen) [23:04:37] 06Wikipedia-Android-App-Backlog, 13Patch-For-Review: Allow saving pages to external storage - https://phabricator.wikimedia.org/T130622#2140910 (10bearND) From IRC #wikimedia-mobile on June 21, 2016: Looks like we're disabling installing on external storage instead. The background is in https://developer.andr... [23:08:34] (03PS1) 10Jdlrobson: Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301310 [23:09:17] (03PS2) 10Jdlrobson: Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301310 (https://phabricator.wikimedia.org/T141386) [23:09:50] 10Wikimedia-Extension-setup, 07Tracking: Extensions needing to be removed from Wikimedia wikis - https://phabricator.wikimedia.org/T106123#2497295 (10Jdforrester-WMF) [23:10:08] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2497297 (10Jdlrobson) This is clarified in MobileFrontend's documentation: https://github.com/wikimedia/mediawiki-extensions-MobileFront... [23:11:23] (03CR) 10Krinkle: [C: 031] Don't actually flip direction of page for directionality unit tests (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/280366 (owner: 10Mattflaschen) [23:11:31] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2497299 (10Jdlrobson) @Mattflaschen-WMF do we need to SWAT deploy the above fix? [23:11:47] 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Sprint-77-Segmentation-fault, 05WMF-deploy-2016-07-26_(1.28.0-wmf.12): Wikidata descriptions are not showing in beta unless enabled in stable - https://phabricator.wikimedia.org/T141067#2497301 (10Jdlrobson) This is causing T141386 [23:13:05] (03PS8) 10Krinkle: resourceloader: Remove styles from 'site', depend on 'site.styles' [core] - 10https://gerrit.wikimedia.org/r/292973 (https://phabricator.wikimedia.org/T92459) [23:13:13] (03CR) 10Krinkle: "Unblocked." [core] - 10https://gerrit.wikimedia.org/r/292973 (https://phabricator.wikimedia.org/T92459) (owner: 10Krinkle) [23:16:08] 10Wikimedia-Site-requests: Load all Wikimedia-deployed extensions and skins via extension registration - https://phabricator.wikimedia.org/T140852#2497322 (10Jdforrester-WMF) [23:18:18] 10MediaWiki-Special-pages, 05MW-1.28-release-notes: Unexpected general module 'mediawiki.special.upload' in styles queue. - https://phabricator.wikimedia.org/T136364#2497323 (10Jdforrester-WMF) p:05Triage>03Normal [23:19:19] (03CR) 10Smalyshev: [C: 031] Push common search api parameters into SearchApi class [core] - 10https://gerrit.wikimedia.org/r/292477 (owner: 10EBernhardson) [23:24:57] 10Gerrit: Gerrit "Documentation" should link to in-house docs - https://phabricator.wikimedia.org/T55433#559896 (10demon) [[https://gerrit-review.googlesource.com/#/admin/projects/plugins/menuextender | There's a plugin to do this now]] :) [23:27:40] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2496436 (10Krinkle) This is also documented on and in hooks.tx... [23:29:09] 10Wikimedia-Site-requests, 13Patch-For-Review: Set $wgEnableUploads = false on ms.wikipedia.org - https://phabricator.wikimedia.org/T141227#2497355 (10MarcoAurelio) 05Open>03Resolved Deployed. Non-sysops are no longer able to do local uploads on mswiki as requested and discussed. [23:29:29] 10Wikimedia-Site-requests: Set $wgEnableUploads = false on ms.wikipedia.org - https://phabricator.wikimedia.org/T141227#2497360 (10MarcoAurelio) [23:32:04] 10MediaWiki-Parser, 06Commons: Max expansion depth error inside a strip marker causes exception. - https://phabricator.wikimedia.org/T141132#2488106 (10Tgr) >>! In T141132#2488762, @matmarex wrote: > (I'd paste the backtrace here but logstash no longer has them in a sane format.) {P3580} [23:33:53] (03PS3) 10Aaron Schulz: Make revision deletion acquire file locks to avoid races [core] - 10https://gerrit.wikimedia.org/r/300317 [23:39:28] 10MediaWiki-API, 07I18n: Message MediaWiki:Apihelp-protect-example-unprotect seems self-contradictive. - https://phabricator.wikimedia.org/T141367#2497384 (10Purodha) 05Invalid>03Open Please update whatever is needed - message text, message documentation, etc. As it is, it not i18n-able. [23:44:09] 10MediaWiki-Parser: Exception "Invalid marker...Expansion depth limit exceeded" thrown when template expansion limit is exceeded inside a strip marker - https://phabricator.wikimedia.org/T136401#2497386 (10Tgr) [23:46:54] 10MediaWiki-extensions-Translate, 06Language-Engineering: [TUX] Create easily reusable message editor component - https://phabricator.wikimedia.org/T72282#2497390 (10Danny_B) [23:47:51] (03PS1) 10Reedy: Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] (wmf/1.28.0-wmf.12) - 10https://gerrit.wikimedia.org/r/301312 (https://phabricator.wikimedia.org/T141386) [23:47:58] 06Editing-Analysis: Regenerate editor month table - https://phabricator.wikimedia.org/T141055#2497396 (10Neil_P._Quinn_WMF) [23:48:10] (03CR) 10Reedy: [C: 032] Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] (wmf/1.28.0-wmf.12) - 10https://gerrit.wikimedia.org/r/301312 (https://phabricator.wikimedia.org/T141386) (owner: 10Reedy) [23:48:37] 10MediaWiki-extensions-Translate, 06Language-Engineering: Add plural (.stringsdict) support to AppleFFS for iOS/Mac OS X translation files - https://phabricator.wikimedia.org/T69636#2497401 (10Danny_B) [23:49:20] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2497403 (10Jdforrester-WMF) [23:49:35] 10MediaWiki-extensions-Translate, 06Language-Engineering: Special:Translate doesn't degrade gracefully for non js users - https://phabricator.wikimedia.org/T106378#2497404 (10Danny_B) [23:50:14] 10MediaWiki-extensions-Translate, 06Language-Engineering: editing a message in List view doesn't update its author in Review view - https://phabricator.wikimedia.org/T51669#2497406 (10Danny_B) [23:51:11] (03CR) 10Legoktm: [C: 032] Add revision_id to log for errors [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301136 (https://phabricator.wikimedia.org/T141368) (owner: 10Ladsgroup) [23:52:19] 10MediaWiki-extensions-Translate, 06Language-Engineering, 06Reading-Web-Backlog, 13Patch-For-Review: Let mobile users reach a functioning Special:Translate without clicks - https://phabricator.wikimedia.org/T102922#2497408 (10Danny_B) [23:52:29] (03CR) 10Legoktm: [C: 032] "This doesn't really test much, but is a good start :)" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301162 (https://phabricator.wikimedia.org/T140455) (owner: 10Ladsgroup) [23:52:33] (03CR) 10Mattflaschen: [C: 032] Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301310 (https://phabricator.wikimedia.org/T141386) (owner: 10Jdlrobson) [23:52:50] 10MediaWiki-extensions-Translate, 06Language-Engineering, 07Easy: Add confirmation message after accepting/rejecting translator applications - https://phabricator.wikimedia.org/T60706#2497410 (10Danny_B) [23:53:15] 10MediaWiki-extensions-Translate, 10MediaWiki-extensions-UniversalLanguageSelector, 06Language-Engineering: ULS Language Selector search textbox is not accessible from the Translate Group Selector - https://phabricator.wikimedia.org/T94548#2497412 (10Danny_B) [23:53:21] 10MobileFrontend, 07Wikimedia-log-errors: onResourceLoaderGetConfigVars can not depend on user-specific info for wikidata settings - https://phabricator.wikimedia.org/T141386#2497414 (10Mattflaschen-WMF) >>! In T141386#2497297, @Jdlrobson wrote: > This is clarified in MobileFrontend's documentation: > https://... [23:53:52] 10MediaWiki-extensions-Translate, 06Language-Engineering, 07Browser-Support-Firefox: saving a message using Alt-Shift-S adds the 'S' letter to the textarea when jquery.ime is enabled - https://phabricator.wikimedia.org/T59288#2497416 (10Danny_B) [23:54:32] 10MediaWiki-extensions-Translate, 06Language-Engineering, 07Easy: Setting $wgTranslatePermissionUrl to false does not remove "Request permission" link. - https://phabricator.wikimedia.org/T56530#2497418 (10Danny_B) [23:55:15] 10MediaWiki-extensions-Translate, 06Language-Engineering: mw.translate.loadLanguageStats does not support stats in batches - https://phabricator.wikimedia.org/T56592#2497420 (10Danny_B) [23:55:48] 10MediaWiki-Parser: setHook (et al) allows silly tag names - https://phabricator.wikimedia.org/T141283#2497422 (10Legoktm) p:05Triage>03Low [23:55:58] 10MediaWiki-extensions-Translate, 06Language-Engineering: "Create account" in core doesn't create a sandbox account - https://phabricator.wikimedia.org/T62756#2497423 (10Danny_B) [23:56:33] (03Merged) 10jenkins-bot: Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] (wmf/1.28.0-wmf.12) - 10https://gerrit.wikimedia.org/r/301312 (https://phabricator.wikimedia.org/T141386) (owner: 10Reedy) [23:56:36] (03Merged) 10jenkins-bot: Add revision_id to log for errors [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301136 (https://phabricator.wikimedia.org/T141368) (owner: 10Ladsgroup) [23:56:39] (03Merged) 10jenkins-bot: First CI test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/301162 (https://phabricator.wikimedia.org/T140455) (owner: 10Ladsgroup) [23:58:48] 10MediaWiki-Parser: HTML self closed tag misparsed on markup font design - https://phabricator.wikimedia.org/T140358#2461861 (10Legoktm) Which wiki is this on? This seems like an issue with the cite web template... [23:58:53] 10MediaWiki-Internationalization, 06Language-Engineering: Make all language related qunit tests for all languages run in single qunit test - https://phabricator.wikimedia.org/T51119#2497431 (10Danny_B) [23:58:57] (03CR) 10MtDu: [C: 031] "Thanks for answering the questions. Looks good to me." [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/301196 (https://phabricator.wikimedia.org/T108764) (owner: 10Reedy) [23:59:20] 10MediaWiki-extensions-ContentTranslation, 06Language-Engineering, 07Epic, 07Tracking: [Epic] ContentTranslation - Translation Dashboard - https://phabricator.wikimedia.org/T76457#2497435 (10Danny_B) [23:59:40] (03Merged) 10jenkins-bot: Revert "Always show Wikidata descriptions in beta mode" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/301310 (https://phabricator.wikimedia.org/T141386) (owner: 10Jdlrobson) [23:59:55] 10MediaWiki-Internationalization, 06Language-Engineering, 07Tracking: getHumanTimestamp issues (tracking) - https://phabricator.wikimedia.org/T66430#2497438 (10Danny_B)