[00:08:31] (03PS1) 10Reedy: Fix mixed leading whitespace [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300198 [00:08:48] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Remove deprecated ResourceLoader::makeLoaderURL() [core] - 10https://gerrit.wikimedia.org/r/300093 (owner: 10Krinkle) [00:09:22] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Remove deprecated ResourceLoader::makeLoaderURL() [core] - 10https://gerrit.wikimedia.org/r/300093 (owner: 10Krinkle) [00:09:43] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Make createLoaderQuery() protected [core] - 10https://gerrit.wikimedia.org/r/300095 (owner: 10Krinkle) [00:09:53] 10MediaWiki-API, 10MediaWiki-extensions-OAuth, 10Notifications, 10VisualEditor: With some accounts but not others, API throws badsession error on OAuth options update - https://phabricator.wikimedia.org/T140006#2449675 (10Mattflaschen-WMF) If this was caused by Echo, it should be resolved now by {8dce65d48... [00:10:17] AaronSchulz: release note conflixt, rebasing.. [00:11:26] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Remove deprecated ResourceLoader::makeLoaderURL() [core] - 10https://gerrit.wikimedia.org/r/300093 (owner: 10Krinkle) [00:11:29] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Make createLoaderQuery() protected [core] - 10https://gerrit.wikimedia.org/r/300095 (owner: 10Krinkle) [00:11:39] 10MediaWiki-extensions-AntiSpoof, 06Community-Tech: Function ccnorm shouldn't convert "I" and "L" to "1", "O" to "0" and "S" to "5" - https://phabricator.wikimedia.org/T29987#2482574 (10kaldari) [00:11:42] 10MediaWiki-extensions-AntiSpoof, 03Community-Tech-Sprint: Run query to find all AbuseFilter filters that use ccnorm() or norm() - https://phabricator.wikimedia.org/T140791#2482571 (10kaldari) 05Open>03Resolved Results posted at P3522 (restricted access since some of the filters are private) [00:11:50] (03PS3) 10Krinkle: resourceloader: Remove deprecated ResourceLoader::makeLoaderURL() [core] - 10https://gerrit.wikimedia.org/r/300093 [00:12:00] (03PS2) 10Krinkle: resourceloader: Make createLoaderQuery() protected [core] - 10https://gerrit.wikimedia.org/r/300095 [00:12:01] 06Discovery, 03Discovery-Analysis-Sprint, 13Patch-For-Review: Wikipedia.org Portal Dashboard: Investigate spike in actions taken on the page - https://phabricator.wikimedia.org/T139109#2482576 (10mpopov) >>! In T139109#2482531, @debt wrote: > One question on wording: "...//snaply// determined as..." in the f... [00:12:22] (03PS1) 10Reedy: /* -> /** [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300199 [00:12:57] (03CR) 10Krinkle: "Submodule update?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300199 (owner: 10Reedy) [00:13:12] damn it [00:13:37] 10MediaWiki-extensions-AntiSpoof, 06Community-Tech: Function ccnorm shouldn't convert "I" and "L" to "1", "O" to "0" and "S" to "5" - https://phabricator.wikimedia.org/T29987#324521 (10kaldari) Fuller list of filters that will need to be fixed at P3522. (The list is restricted access since some of the filters... [00:13:58] (03PS1) 10Reedy: Use correct string concat operator [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300201 [00:14:38] 10UI-Standardization, 10Collab-Notifications-Page: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2482579 (10Etonkovidova) [00:15:18] (03CR) 10MaxSem: [C: 04-1] "* There's an empty
    at the end of the list, resulting in a stray bullet." [core] - 10https://gerrit.wikimedia.org/r/280904 (https://phabricator.wikimedia.org/T121469) (owner: 10Jdlrobson) [00:17:07] (03PS2) 10Reedy: /* -> /** [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300199 [00:17:55] 10MediaWiki-extensions-CentralAuth, 06Collaboration-Team-Interested: "Can only obtain a centralauthtoken when using CentralAuth sessions" during auto-creation - https://phabricator.wikimedia.org/T140127#2482606 (10Mattflaschen-WMF) >>! In T140127#2454269, @Anomie wrote: > You also can't use API action=centrala... [00:23:28] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Remove deprecated ResourceLoader::makeLoaderURL() [core] - 10https://gerrit.wikimedia.org/r/300093 (owner: 10Krinkle) [00:24:53] 10UI-Standardization, 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2482636 (10Etonkovidova) [00:25:51] (03PS27) 10Mooeypoo: Add a mark-all-read button and a settings menu to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) [00:28:36] (03CR) 10Mooeypoo: "That's a good point; I added the same behavior to markAllRead and markLocalNotificationsRead. The cross-wiki model actions manage and disc" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/296674 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [00:29:44] (03CR) 10Mattflaschen: [C: 032] Avoid API requests on scroll events in watchlist test [extensions/MobileFrontend] (REL1_26) - 10https://gerrit.wikimedia.org/r/295742 (https://phabricator.wikimedia.org/T116258) (owner: 10Mattflaschen) [00:30:20] (03Merged) 10jenkins-bot: resourceloader: Remove deprecated ResourceLoader::makeLoaderURL() [core] - 10https://gerrit.wikimedia.org/r/300093 (owner: 10Krinkle) [00:30:33] (03CR) 10VolkerE: [C: 04-1] "I'm not convinced by this approach:" [core] - 10https://gerrit.wikimedia.org/r/298637 (https://phabricator.wikimedia.org/T112933) (owner: 10Bartosz Dziewoński) [00:32:01] 10MediaWiki-extensions-DonationInterface, 10FR-PayPal-ExpressCheckout, 10Fundraising-Backlog, 07Technical-Debt: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2482638 (10awight) [00:33:53] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Make createLoaderQuery() protected [core] - 10https://gerrit.wikimedia.org/r/300095 (owner: 10Krinkle) [00:34:05] (03Merged) 10jenkins-bot: Avoid API requests on scroll events in watchlist test [extensions/MobileFrontend] (REL1_26) - 10https://gerrit.wikimedia.org/r/295742 (https://phabricator.wikimedia.org/T116258) (owner: 10Mattflaschen) [00:35:31] 10UI-Standardization, 10Collab-Notifications-Page, 03Collab-Team-Q1-July-Sep-2016: [minor] Notification page - usage of bold font - https://phabricator.wikimedia.org/T140962#2482579 (10Volker_E) @Etonkovidova Thanks, good catch! All those tabs and buttons (”Mark as unread“) are normally set bold in our https... [00:40:59] (03Merged) 10jenkins-bot: resourceloader: Make createLoaderQuery() protected [core] - 10https://gerrit.wikimedia.org/r/300095 (owner: 10Krinkle) [00:41:30] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Notifications, 10Wikimedia-General-or-Unknown, and 5 others: Could not find local user data for {Username}@{wiki} - https://phabricator.wikimedia.org/T119736#2482647 (10Tgr) >>! In T119736#2481988, @Anomie wrote: > I still see a fair... [00:41:32] (03PS1) 10Krinkle: Combine objects between lists and non-lists [WrappedString] - 10https://gerrit.wikimedia.org/r/300202 [00:41:48] (03CR) 10Krinkle: [C: 032] /* -> /** [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300199 (owner: 10Reedy) [00:44:21] (03PS9) 10Krinkle: [WIP] resourceloader: Move queue formatting out of OutputPage (DRAFT) [core] - 10https://gerrit.wikimedia.org/r/299272 (https://phabricator.wikimedia.org/T87871) [00:48:28] (03Merged) 10jenkins-bot: /* -> /** [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300199 (owner: 10Reedy) [00:50:13] (03CR) 10BryanDavis: [C: 032] Combine objects between lists and non-lists [WrappedString] - 10https://gerrit.wikimedia.org/r/300202 (owner: 10Krinkle) [00:50:59] (03Merged) 10jenkins-bot: Combine objects between lists and non-lists [WrappedString] - 10https://gerrit.wikimedia.org/r/300202 (owner: 10Krinkle) [00:51:34] (03CR) 10Krinkle: "Hm.. so how is this different from a plain addCallableUpdate? As recently introduced in https://gerrit.wikimedia.org/r/#/c/299860/1/inclu" [core] - 10https://gerrit.wikimedia.org/r/299857 (owner: 10Aaron Schulz) [00:51:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] resourceloader: Move queue formatting out of OutputPage (DRAFT) [core] - 10https://gerrit.wikimedia.org/r/299272 (https://phabricator.wikimedia.org/T87871) (owner: 10Krinkle) [00:55:59] (03PS1) 10Krinkle: Update wikimedia/wrappedstring to v2.2.0 [vendor] - 10https://gerrit.wikimedia.org/r/300204 [00:56:02] (03PS1) 10Krinkle: Update wikimedia/wrappedstring to v2.2.0 [core] - 10https://gerrit.wikimedia.org/r/300205 [00:56:05] (03CR) 10Aaron Schulz: "auto-commit mode commits each statement as they happen server-side, whereas other deferred updates commit once per each callback app-side." [core] - 10https://gerrit.wikimedia.org/r/299857 (owner: 10Aaron Schulz) [00:58:09] (03CR) 10Krinkle: "Okay, so for cases where there is only one statement, there is effectively no difference (like Title::invalidateCache)." [core] - 10https://gerrit.wikimedia.org/r/299857 (owner: 10Aaron Schulz) [00:58:48] 10MediaWiki-extensions-AntiSpoof, 06Community-Tech: Function ccnorm shouldn't convert "I" and "L" to "1", "O" to "0" and "S" to "5" - https://phabricator.wikimedia.org/T29987#2482653 (10MusikAnimal) I'll write my thoughts I posted on the paste here: Since this is a breaking change, I think the time between upd... [01:02:05] (03PS1) 10BryanDavis: Make unit tests a bit more readable by renaming helpers [WrappedString] - 10https://gerrit.wikimedia.org/r/300206 [01:08:04] (03PS1) 10Aaron Schulz: Avoid calling rollback() in setVisibility() when nothing changed [core] - 10https://gerrit.wikimedia.org/r/300207 [01:08:48] (03PS4) 10Catrope: Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) [01:14:26] 10MediaWiki-extensions-MapSources, 06Discovery, 10Kartographer, 06Maps, 03Maps-Sprint: Deprecate provided by MapSources in favor of Kartographer's - https://phabricator.wikimedia.org/T136768#2482664 (10MaxSem) >>! In T136768#2481827, @CKoerner_WMF wrote: > * Does this remove any fe... [01:15:29] 06Discovery, 03Discovery-Analysis-Sprint, 13Patch-For-Review: Wikipedia.org Portal Dashboard: Investigate spike in actions taken on the page - https://phabricator.wikimedia.org/T139109#2482665 (10debt) LOL, fair enough. ;) I was wondering which one of these options you wanted to try / go with, based on your... [01:24:39] (03CR) 10Mattflaschen: [C: 032] Move efStripKeyRecursive from global scope [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300043 (owner: 10Reedy) [01:31:15] (03Merged) 10jenkins-bot: Move efStripKeyRecursive from global scope [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/300043 (owner: 10Reedy) [01:32:07] 06Discovery, 03Discovery-Analysis-Sprint, 13Patch-For-Review: Wikipedia.org Portal Dashboard: Investigate spike in actions taken on the page - https://phabricator.wikimedia.org/T139109#2482673 (10mpopov) >>! In T139109#2482665, @debt wrote: > I was wondering which one of these options you wanted to try / go... [01:33:49] (03PS1) 10Aaron Schulz: Made non-exception rollback() calls safer [core] - 10https://gerrit.wikimedia.org/r/300209 [01:43:39] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 10Wikidata, 13Patch-For-Review, and 3 others: ORES extension score only main namespace edits for Wikidata - https://phabricator.wikimedia.org/T139660#2482682 (10Ladsgroup) It got deployed in June 20th, 23:40 UTC. After that time, we had 21 faile... [01:52:19] 10GeoCrumbs: Crumbs contain (disambiguation) in names which duplicates locations already in breadcrumb path - https://phabricator.wikimedia.org/T45313#2482685 (10LtPowers) >>! In T45313#2478598, @Legoktm wrote: > Should (state) be included or stripped? Strictly speaking, it should probably be included. In many... [01:53:26] 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 10Wikidata, 13Patch-For-Review, and 3 others: ORES extension score only main namespace edits for Wikidata - https://phabricator.wikimedia.org/T139660#2482688 (10Ladsgroup) Link to logstash if you want to check [[ https://logstash.wikimedia.org/a... [01:56:13] (03PS5) 10Catrope: Show a warning when leaving a page with unsaved text in an editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) [01:57:53] (03CR) 10Catrope: [C: 032] Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MW [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300176 (https://phabricator.wikimedia.org/T139993) (owner: 10Mattflaschen) [01:58:30] 10Wiki-Loves-Monuments-Database: Figure out improved matching of monuments for Iran - https://phabricator.wikimedia.org/T139258#2482689 (10LilyOfTheWest) >>! In T139258#2468435, @Lokal_Profil wrote: > @Mahmoud @Multichill @Lilyofthewest > Are the ids guaranteed to be integers (in whichever script) or can it some... [02:03:15] (03CR) 10Tim Starling: [C: 032] Minor bug fixes to Balancer. [core] - 10https://gerrit.wikimedia.org/r/299667 (owner: 10Cscott) [02:04:08] (03Merged) 10jenkins-bot: Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MW [extensions/Echo] - 10https://gerrit.wikimedia.org/r/300176 (https://phabricator.wikimedia.org/T139993) (owner: 10Mattflaschen) [02:09:07] (03CR) 10Catrope: "PS5 fixes the bugs Stephane reported and addresses Ed's comment" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296276 (https://phabricator.wikimedia.org/T96531) (owner: 10Catrope) [02:11:47] (03Merged) 10jenkins-bot: Minor bug fixes to Balancer. [core] - 10https://gerrit.wikimedia.org/r/299667 (owner: 10Cscott) [02:12:02] (03CR) 10Krinkle: [C: 032] Make unit tests a bit more readable by renaming helpers [WrappedString] - 10https://gerrit.wikimedia.org/r/300206 (owner: 10BryanDavis) [02:12:45] (03Merged) 10jenkins-bot: Make unit tests a bit more readable by renaming helpers [WrappedString] - 10https://gerrit.wikimedia.org/r/300206 (owner: 10BryanDavis) [02:34:36] (03PS1) 10Aaron Schulz: Provide onTransaction* callbacks with the transaction result [core] - 10https://gerrit.wikimedia.org/r/300210 [02:39:18] 10Phabricator (Upstream), 07Upstream: Projects dropdown should offer project descriptions - https://phabricator.wikimedia.org/T234#2482694 (10scfc) Just found it: If you click on the search icon in (any?) project field, the search results show the project descriptions. IMHO that's not very intuitive (and not... [02:46:24] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/300210/ [02:48:28] (03PS5) 10Tim Starling: Support tags in Balancer. [core] - 10https://gerrit.wikimedia.org/r/299034 (owner: 10Cscott) [02:48:43] Reading through the code path I don't see how that is true [02:49:15] Or for that matter the idle callbacks not being called on rollback [02:49:30] RoanKattouw: an error is thrown if there is no transaction when onTransactionResolution is called [02:49:38] so it can't be idle [02:50:01] rollback() has << $this->mTrxIdleCallbacks = []; // clear >> [02:52:58] AaronSchulz: What bothers me specifically is that the doc comments in https://gerrit.wikimedia.org/r/#/c/300210/1/includes/db/IDatabase.php claim that onTransactionResolution will only be called for COMMIT or ROLLBACK [02:53:28] Maybe the implementations check and throw an error, but that doesn't make that doc comment correct [02:53:40] 10MediaWiki-Page-deletion, 06Commons, 06Operations, 10media-storage, and 4 others: Unable to delete file pages on commons: MWException/LocalFileLockError: "Could not acquire lock" - https://phabricator.wikimedia.org/T132921#2482696 (10aaron) 05Open>03Resolved According to [[ https://logstash.wikimedia.... [02:54:19] RoanKattouw: the callback is only called after commit/rollback [02:54:27] But how? [02:54:27] not the method itself [02:54:36] In runOnTransactionIdleCallbacks I see nothing ensuring that [02:55:26] Oh I see the code now [02:55:34] Then I think the doc comment in IDatabase is wrong [02:55:37] * RoanKattouw leaves inline comment [02:56:34] RoanKattouw: the new doc comment? [02:56:37] Yes [02:57:16] (03CR) 10Catrope: [C: 04-1] Provide onTransaction* callbacks with the transaction result (031 comment) [core] - 10https://gerrit.wikimedia.org/r/300210 (owner: 10Aaron Schulz) [02:57:21] you can't register a resolution callback if there is no transaction active [02:57:28] Maybe I'm missing something? [02:57:39] Hmm OK [02:57:44] throw new DBUnexpectedError( $this, "No transaction is active." ); [02:57:48] Yes I do see that [02:57:55] (03Merged) 10jenkins-bot: Support