[00:00:26] tgr: Did you get my comment earlier before I disconnected? [00:01:05] oh, sorry, I didn't see you missed my answer [00:01:14] < tgr> MtDu: WikiPage::insertOn, it's in the part you highlighted [00:02:56] tgr: Yeah. I get that. Because $article is an instance of the WikiPage class and WikiPage has the insertOn. So what's wrong with my code and what do I need to do to make it work? [00:03:17] tgr: So the problem with it is that if ar_page_id exists, it doesn't insert anything? [00:03:49] well, yes, that's definitely a problem [00:04:06] furthermore, it should insert the page with the old id [00:04:35] which is currently not supported, so you need to modify the insertOn method [00:06:08] tgr: So is there a doc that teaches me how to do that? Because right now, all I see is that it is a method that a WikiPage object can call. [00:06:23] That's all I understand. I don't understand how to modify it. [00:09:10] MtDu_: something like http://devzone.zend.com/6/php-101-php-for-the-absolute-beginner/ I suppose? [00:09:17] especially the part about functions [00:12:59] 10MediaWiki-extensions-SemanticForms: Provide "minlength" and probably "fixedlength"? parameter to the "field" tag - https://phabricator.wikimedia.org/T123182#1923061 (10Kghbln) 3NEW [00:15:22] tgr: So this is the insertOn function. https://dpaste.de/z6Pu How would I change the page_id to use $row->ar_page_id? [00:16:08] Just replace it? [00:17:28] oh [00:17:59] pass it as an optional parameter of insertOn, use the ?: operator so nextSequenceValue() is a fallback to pageId [00:18:48] tgr: I get the optional parameter part. You lost me with the second part. [00:19:29] https://stackoverflow.com/questions/1276909/php-syntax-question-what-does-the-question-mark-and-colon-mean [00:19:35] $pageid ?: $dbw->nextSequenceValue( 'page_page_id_seq' ) [00:20:00] Oh, didn't know that ?: was a thing [00:20:05] you can use $a ?: $b to say "$a if it is not null(ish), otherwise $b" [00:20:09] TIL [00:21:48] tgr: So it would be something like $row->ar_page_id ?: $dbw->nextSequenceValue( 'page_page_id_seq' )? [00:23:07] (03CR) 10Paladox: [C: 031] Add extension.json, empty PHP entry point [extensions/ConfirmEdit] (REL1_25) - 10https://gerrit.wikimedia.org/r/250275 (https://phabricator.wikimedia.org/T88047) (owner: 10Florianschmidtwelzow) [00:23:10] MtDu_: I hope I am not coming across as rude, but are you sure this task is the right skill level for you? [00:23:36] tgr: Well, I wanted to learn some new stuff. I guess not then. :( [00:24:21] I think learning is most effective if you pick tasks that are challenging but you can still do them mostly on your own [00:26:59] I realize GCI doesn't offer much help in figuring out the difficulty level of each task, but if you ask GCI admins they can probably help you to find better suited ones [00:27:14] tgr: Would you like me to abandon this one then? [00:27:56] MtDu_: sorry, but that would be best I think [00:28:33] or if you think you can figure it out on your own that's fine, but you'd probably have to read some kind of PHP for beginners tutorial [00:28:41] about how function calls work and such [00:29:22] tgr: Ok. I'll keep on trying for a little bit, and if I still don't get it, then I'll abandon. [00:30:20] tgr: Sorry for seeming like I'm stupid. Hopefully, eventually, I'll be able to do some of your tasks, maybe next year! [00:32:51] MtDu_: nothing wrong with being unskilled at something and it's not the same as being stupid, but if you try doing tasks for which you lack the knowledge that will take up way more time than it should, both for you and your mentor, and I doubt you can even learn from it effectively [00:34:03] you should look for easier GCI tasks, or if there aren't any, then maybe something like https://www.codecademy.com/learn/php that's targeted at beginners might be better suited for you than GCI, for now [00:37:16] tgr: Yeah. I guess I just haven't mastered the fundamentals yet in certain things. Thanks for your advice. [00:39:40] tgr: I think the hard part for me is after learning the basics of a language, learning how to apply them at real world problems and learning how to use the language's tools. [00:39:51] tgr: Does that come with time and practice? [00:40:23] certainly [00:40:46] (03PS11) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [00:42:34] (03PS12) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [00:42:47] (03PS13) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [00:47:43] (03PS14) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [00:48:10] eh keep forgetting things [00:48:59] (03PS15) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [01:13:29] 6Repository-Ownership-Requests: Unarchive mediawiki/extensions/OOUIPlayground - https://phabricator.wikimedia.org/T122944#1923071 (10Volker_E) [01:19:09] (03CR) 10TTO: [C: 04-1] "Mostly looks good. Just some minor stuff. Haven't tested it yet." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) (owner: 10Georggi199) [01:21:22] tto: Is there a way for you to see if a task has been claimed? I was looking at https://phabricator.wikimedia.org/T85270 but I don't see it on the GCI website. [01:21:34] MtDu_: Yes, I can have a look for you [01:21:48] How's everything been going? I see you've been making pretty good progress :) [01:22:30] Yeah, another student claimed that task about 55 minutes ago :/ [01:22:41] tto: I'm doing pretty well. I've learned a lot, but still a ways to go to before I can do some of the tasks that are on there. [01:22:57] tto: Aw man. :p [01:23:18] Are you having a hard time finding a good task? [01:24:03] tto: Well. No not really. Just that I'm about to abandon one because it's too hard for me right now, and I saw that one earlier that looked pretty easy. [01:25:01] MtDu: That's a pity - that one is an issue that a few of us really want to see fixed! [01:25:18] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1923076 (10mwjames) > ... why the null is getting through, and why I want to be able to reproduce it locally If you add something like below (PS: This is to... [01:25:19] 10UI-Standardization, 10OOjs-UI, 7Accessibility, 7Easy: Use `not-allowed` cursor for disabled elements in OOjs UI - https://phabricator.wikimedia.org/T123183#1923077 (10Volker_E) 3NEW a:3Volker_E [01:28:53] 6Repository-Ownership-Requests: Unarchive mediawiki/extensions/OOUIPlayground - https://phabricator.wikimedia.org/T122944#1923085 (10Luke081515) Repo at phab is ready: rEUIP (I added the link to the extension). So we need a gerrit admin now to reactive, then phab will import the repo (after 6h or earlier)... [01:30:27] 6Repository-Ownership-Requests: Unarchive mediawiki/extensions/OOUIPlayground - https://phabricator.wikimedia.org/T122944#1923087 (10Legoktm) 5Open>3Resolved a:3Legoktm Done. [01:32:32] (03CR) 10Aude: "not looked in detail yet at this patch or how the extension works, but have small suggestion" (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/263184 (https://phabricator.wikimedia.org/T122535) (owner: 10Ladsgroup) [01:36:11] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1923091 (10TTO) Right, thanks, I can reproduce on REL1_26. It appears to be fixed on master. I'll investigate. >>! In T123166#1923076, @mwjames wrote: >>... [01:57:26] 6Repository-Ownership-Requests: Requesting access to gerrit group mediawiki for jzerebecki - https://phabricator.wikimedia.org/T116506#1923092 (10Legoktm) +1 from me. [01:58:19] 6Repository-Ownership-Requests: add BurntSushi to extension-SemanticLinks group - https://phabricator.wikimedia.org/T112916#1923095 (10Legoktm) 5Open>3Resolved a:3Legoktm Done, sorry about the delay. [01:58:55] 6Repository-Ownership-Requests: Taking ownership of extension Memcached - https://phabricator.wikimedia.org/T111331#1923100 (10Legoktm) You'll need to request a repo in gerrit first. [02:00:07] 10MediaWiki-Export-or-Import, 5MW-1.26-release: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1923102 (10TTO) This was fixed in https://gerrit.wikimedia.org/r/#/c/236784. Here's a patch for 1.26, it's based on 1.26.2 but should a... [02:00:52] 6Repository-Ownership-Requests: Add tosfos to Contributors extension - https://phabricator.wikimedia.org/T105712#1923105 (10Legoktm) 5Open>3Resolved a:3Legoktm Done, sorry about the delay. [02:00:58] (03PS1) 10TTO: Fix exception in Import, when import of a revision fails [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/263202 (https://phabricator.wikimedia.org/T108544) [02:01:14] (03PS2) 10TTO: Fix exception in Import, when import of a revision fails [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/263202 (https://phabricator.wikimedia.org/T108544) [02:02:22] (03CR) 10TTO: "@Chad: What's the process to get this patch into 1.26.3? It's a nasty bug that has been reported by two users." [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/263202 (https://phabricator.wikimedia.org/T108544) (owner: 10TTO) [02:03:02] 10MediaWiki-Export-or-Import: Argument 1 passed to WikiPage::factory() must be an instance of Title, null given - https://phabricator.wikimedia.org/T123075#1923113 (10TTO) [02:03:03] 10MediaWiki-Export-or-Import, 5MW-1.26-release, 5Patch-For-Review: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1923114 (10TTO) [02:03:09] tto: Just merge it [02:03:32] 10WikiProject-X: Create CollaborationKit extension and deploy on English Wikipedia - https://phabricator.wikimedia.org/T123028#1923117 (10Harej) [02:03:34] 10MediaWiki-extension-requests, 6Community-Tech, 7Community-Wishlist-Survey: MediaWiki extension for WikiProjects / on-wiki working groups - https://phabricator.wikimedia.org/T97210#1923116 (10Harej) [02:03:35] tto: Oh, wait. Add RELEASE-NOTES and just merge it [02:03:46] Reedy: Thanks :) [02:03:51] It'll be in the next release then [02:04:37] Yeah, RELEASE-NOTES are a bit more important for backports and point releases :) [02:05:01] But yeah, with that, you can self CR+2 [02:06:21] Just noticed https://github.com/wikimedia/mediawiki/commit/12568e1cacd0de32823ab297c70536bbfd9ed967 doesn't have notes [02:06:23] * Reedy grumbles [02:08:39] legoktm: https://en.wikipedia.org/wiki/User_talk:Peachey88#Mass_message_weirdness [02:09:27] o.O [02:09:34] (03PS3) 10TTO: Fix exception in Import, when import of a revision fails [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/263202 (https://phabricator.wikimedia.org/T108544) [02:10:12] p858snake: also, do you only check your talk page once a year or something? [02:10:25] (03PS1) 10MtDu: Clarify and document some OpenStackManager messages [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/263203 [02:10:32] legoktm: >.> [02:10:53] I probably have seen it already, just can't remember if I bugged you about it [02:11:21] (03CR) 10TTO: [C: 032] Fix exception in Import, when import of a revision fails [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/263202 (https://phabricator.wikimedia.org/T108544) (owner: 10TTO) [02:13:20] (03PS1) 10Legoktm: Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 [02:13:22] p858snake: ^^ [02:13:57] That was silly on my part. [02:14:09] (03CR) 10jenkins-bot: [V: 04-1] Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 (owner: 10Legoktm) [02:14:34] lol [02:14:38] wtf [02:14:39] 02:14:01 1) MassMessageListContentHandlerTest::testEdit [02:14:39] 02:14:01 Failed asserting that false is true. [02:15:01] (03PS1) 10TTO: Fix exception in Import, when import of a revision fails [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/263205 (https://phabricator.wikimedia.org/T108544) [02:15:14] $this->assertTrue( $result->isGood() ); [02:15:16] okay... [02:15:42] (03PS2) 10TTO: Fix exception in Import, when import of a revision fails [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/263205 (https://phabricator.wikimedia.org/T108544) [02:17:03] (03Merged) 10jenkins-bot: Fix exception in Import, when import of a revision fails [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/263202 (https://phabricator.wikimedia.org/T108544) (owner: 10TTO) [02:17:31] (03PS3) 10TTO: Fix exception in Import, when import of a revision fails [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/263205 (https://phabricator.wikimedia.org/T108544) [02:18:27] (03CR) 10TTO: [C: 032] Fix exception in Import, when import of a revision fails [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/263205 (https://phabricator.wikimedia.org/T108544) (owner: 10TTO) [02:20:28] 10MediaWiki-Export-or-Import, 5MW-1.26-release, 5Patch-For-Review: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1923122 (10TTO) 5Open>3Resolved a:3TTO You can apply the patch in my comment above, or wait for the next maint... [02:20:36] 10MediaWiki-Export-or-Import, 5MW-1.26-release: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1923125 (10TTO) [02:21:11] (03CR) 10jenkins-bot: [V: 04-1] Fix exception in Import, when import of a revision fails [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/263205 (https://phabricator.wikimedia.org/T108544) (owner: 10TTO) [02:24:51] 10MediaWiki-extensions-NSFileRepo, 7Easy: [[MediaWiki:Nsfilerepo-upload-target/en]]: "Namspace" typo - https://phabricator.wikimedia.org/T123157#1923127 (10MtDu) a:3MtDu [02:25:01] 10MediaWiki-extensions-NSFileRepo, 7Easy: [[MediaWiki:Nsfilerepo-upload-target/en]]: "Namspace" typo - https://phabricator.wikimedia.org/T123157#1922526 (10MtDu) I'll fix this. [02:25:18] Fstring(78) "

Editing the list through the API failed with error code readapidenied. [02:25:20] wtf?? [02:27:31] I am here for the GCI task [02:28:51] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1923129 (10josephine_l) Added 10k radius test results to the GitHub wiki. [02:29:55] (03PS1) 10MtDu: Fix typo in upload-target message [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/263206 (https://phabricator.wikimedia.org/T123157) [02:35:15] 10MediaWiki-Parser, 10MediaWiki-extensions-LabeledSectionTransclusion, 10MediaWiki-extensions-ProofreadPage, 7Regression: MediaWiki removes automatically the linebreak before "|-", breaking table on Wikisource - https://phabricator.wikimedia.org/T123174#1923137 (10GOIII) @He7d3r stop using the "dumbed down... [02:36:08] 10MediaWiki-extensions-Newsletter, 7Easy, 7I18n, 5Patch-For-Review: [[MediaWiki:Newsletter-email-batch-body/en]] needs GENDER support on $2. - https://phabricator.wikimedia.org/T122717#1923139 (10MtDu) a:3MtDu I will go ahead and do this. [02:37:53] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1923141 (10josephine_l) [02:40:40] (03PS1) 10Legoktm: Revert "RequestContext: Load the request object for getRequest on first call" [core] - 10https://gerrit.wikimedia.org/r/263207 [02:41:08] (03PS2) 10Legoktm: Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 [02:48:06] (03Abandoned) 10Legoktm: Revert "RequestContext: Load the request object for getRequest on first call" [core] - 10https://gerrit.wikimedia.org/r/263207 (owner: 10Legoktm) [02:48:45] (03PS3) 10Legoktm: Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 [02:48:47] (03PS1) 10Legoktm: Unbreak tests following MediaWiki core change [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263209 [02:54:06] (03CR) 10Krinkle: "Haven't tested yet, but using an extra field like this seems a bit fragile and shouldn't be needed." [core] - 10https://gerrit.wikimedia.org/r/262589 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [03:02:21] (03CR) 10Wctaiwan: [C: 032] Unbreak tests following MediaWiki core change [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263209 (owner: 10Legoktm) [03:02:37] (03CR) 10Wctaiwan: [V: 032] Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 (owner: 10Legoktm) [03:02:42] (03CR) 10Krinkle: "@Florian: I understand your concern regarding GET validation. That's why we should only use GET for the first form, not the second. That's" [core] - 10https://gerrit.wikimedia.org/r/262589 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [03:02:48] (03CR) 10Wctaiwan: Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 (owner: 10Legoktm) [03:03:05] (03CR) 10Wctaiwan: [C: 032] Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 (owner: 10Legoktm) [03:03:17] (03Merged) 10jenkins-bot: Unbreak tests following MediaWiki core change [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263209 (owner: 10Legoktm) [03:04:06] (03Merged) 10jenkins-bot: Use Title::getRootText() to get a user's name from Title [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/263204 (owner: 10Legoktm) [03:06:49] (03CR) 10Krinkle: [C: 04-1] "Sorry, all except one :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263037 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [03:07:09] p858snake: https://en.wikipedia.org/w/index.php?title=User_talk%3APeachey88%2FArchives%2F2015&type=revision&diff=699078209&oldid=699072257 yw [03:13:02] legoktm: interesting. How did you get from MM to ReqCtx::getLang? [03:14:15] Krinkle: I assumed it was a core change because nothing has changed in MM recently, and then git bisected [03:14:26] ah, ok [03:14:35] (03PS1) 10MtDu: Add GENDER to some Newsletter messages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/263210 [03:15:15] (03CR) 10Krinkle: [C: 032] "The second issue (which I forgot to write down) was a note to-self to double-check whether session storage can be assumed to be synchronou" [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [03:17:15] (03PS2) 10MtDu: Add GENDER to some Newsletter messages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/263210 (https://phabricator.wikimedia.org/T122717) [03:17:16] legoktm: ah, so it was requestcontext related. [03:17:18] https://gerrit.wikimedia.org/r/#/c/263209/1/tests/content/MassMessageContentHandlerTest.php [03:17:20] Nice catch [03:18:05] yeah :) I need to rewrite that code to not suck at some point... [03:18:38] Hm.. so why was 'new RequestContext' not working correctly? [03:19:03] https://github.com/search?l=php&q=%22new+RequestContext%22+%40wikimedia&ref=searchresults&type=Code [03:20:23] (03Merged) 10jenkins-bot: Preferences: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [03:20:41] 10MediaWiki-Interface, 7I18n, 7Tracking, 7Voice & Tone: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1923146 (10MtDu) [03:26:43] (03Abandoned) 10MtDu: Use ar_page_id in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/263080 (https://phabricator.wikimedia.org/T28123) (owner: 10MtDu) [04:15:37] 10MediaWiki-Special-pages, 7Easy, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Update dialog shown when clicking on the special page tab after saving preferences - https://phabricator.wikimedia.org/T26700#1923169 (10Sn1per) 5Open>3Resolved a:5Sn1per>3Fomafix [05:20:25] I am working on a bug and I need to install this rep from https://github.com/wikimedia/mediawiki-tools-codesniffer, but after i run composer test, it shows the "The Process timed out", I couldn't find out any solution. It would be nice if someone could help with this. [05:41:16] 10MediaWiki-extensions-RandomRootPage, 7Easy, 3Google-Code-In-2015: Merge RandomRootPage extension into MediaWiki core - https://phabricator.wikimedia.org/T109809#1923173 (10TiHoX1) Where does the special-page's setup file (Randomrootpage.php) go if it is located in /include/specials by default? The default... [05:44:08] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1923175 (10Volker_E) One thing to take into consideration is, that on Windows (at least up to Windows 7) the `not-allowed` cu... [05:54:14] 10MediaWiki-extensions-RandomRootPage, 7Easy, 3Google-Code-In-2015: Merge RandomRootPage extension into MediaWiki core - https://phabricator.wikimedia.org/T109809#1923176 (10Legoktm) The setup file goes away, core special pages get registered in includes/specialpage/SpecialPageFactory, autoload.php, etc. Ali... [06:19:57] haritha_: strange, it works for me perfectly. Can you run composer update --verbose, and paste the output, as I think this can be netework related. [06:22:53] tonythomas: I have got the below output [06:22:53] Loading composer repositories with package information [06:22:53] Updating dependencies (including require-dev) [06:22:53] Analyzed 964 packages to resolve dependencies [06:22:53] Analyzed 9629 rules to resolve dependencies [06:22:53] Nothing to install or update [06:22:53] Generating optimized autoload files [06:23:16] haritha_: in that case, it looks like the composer update went correct ? [06:25:56] 4(no projects): Add possibility to use default MediaWiki URLs on all wikis - https://phabricator.wikimedia.org/T123181#1923181 (10Nnemo) It is already the case, no? Can you give an example? Thank you. [06:29:37] 7Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization: Special:Contributions should display a legend - https://phabricator.wikimedia.org/T122553#1923186 (10Devirk) [07:24:38] 10MediaWiki-File-management, 10MediaWiki-extensions-PdfHandler, 6Commons, 6Multimedia, 7I18n: Add PLURAL support to exif-pdf-pagesize - https://phabricator.wikimedia.org/T123165#1923191 (10Liuxinyu970226) [07:24:39] 10MediaWiki-Interface, 7I18n, 7Tracking: Messages needing PLURAL support (tracking) - https://phabricator.wikimedia.org/T40781#1923190 (10Liuxinyu970226) [07:34:58] 10CirrusSearch, 6Discovery: Provide an option for ignoring combining characters when searching - https://phabricator.wikimedia.org/T123179#1923194 (10Krenair) [07:48:39] tto, hi! [07:48:50] legoktm, I am awake :P [07:50:47] victorbarbu_: oops. your patch is currently #3 in my queue [07:50:57] :( [07:51:12] victorbarbu_: Hi :) [07:51:23] how are you, tto [07:51:25] ? [07:52:27] 10MediaWiki-extensions-OpenStackManager: Pop-up notification when deleting an instance contains literal "$2" - https://phabricator.wikimedia.org/T123162#1923199 (10Krenair) My guess is this is from the JS code, and the second parameter is being passed as undefined. [08:02:24] 10MediaWiki-extensions-OpenStackManager: Pop-up notification when deleting an instance contains literal "$2" - https://phabricator.wikimedia.org/T123162#1923200 (10Krenair) Looks like it's expecting the data for `.novainstanceaction` elements to contain an `id` key, but it does not. [08:09:37] 6Wikimedia-DC: Deploy Graphs extension on Wikimedia DC wiki - https://phabricator.wikimedia.org/T123025#1923202 (10Legoktm) I'm guessing the Graphs extension requires a recent version of MW, so we'll probably need to upgrade before we can use it. I was planning to upgrade when 1.27 came out (~May), do you want t... [08:12:14] 10MediaWiki-extensions-OpenStackManager: Pop-up notification when deleting an instance contains literal "$2" - https://phabricator.wikimedia.org/T123162#1923203 (10Krenair) That just comes from `OpenStackNovaInstance::getInstanceId`, which looks up the instance's `OS-EXT-SRV-ATTR:instance_name` property. But som... [08:25:49] 6Wikimedia-DC: Develop a privacy policy for wikimediadc.org - https://phabricator.wikimedia.org/T116559#1923209 (10Legoktm) Quick start: * apache/varnish access/error logs (include IP address, timestamp, URL requested, server response code, bytes served, referer if provided, user agent) - we currently have a ye... [08:27:04] 6Wikimedia-DC: Deploy Graphs extension on Wikimedia DC wiki - https://phabricator.wikimedia.org/T123025#1923210 (10Harej) It’s not a high priority. — James Hare http://harej.co [08:48:42] Hi everyone! [08:50:28] 6Wikimedia-DC: Develop a privacy policy for wikimediadc.org - https://phabricator.wikimedia.org/T116559#1923211 (10Harej) This is a good start. Do we collect enough information to get page views for the website as a whole and per page, including breakdown of mobile vs. desktop? I would like to begin reporting s... [08:53:29] 6Wikimedia-DC: Develop a privacy policy for wikimediadc.org - https://phabricator.wikimedia.org/T116559#1923212 (10Harej) Another note: we use Instant Commons, meaning that images are pulled from the Wikimedia Foundation, technically a third party resource (from the perspective of Wikimedia DC's server). Or is t... [09:04:40] 6Wikimedia-DC: Develop a privacy policy for wikimediadc.org - https://phabricator.wikimedia.org/T116559#1923217 (10Harej) [09:07:48] No grrrit-wm at all? Is it double or nothing these days? :) [09:11:00] legoktm: still around ^ [09:11:43] apparently [09:36:48] legoktm, any change in you queue [09:42:36] 6Repository-Ownership-Requests: Requesting access to gerrit group mediawiki for jzerebecki - https://phabricator.wikimedia.org/T116506#1751221 (10hashar) +1 As much as @hoo and @daniel [09:53:59] 10MediaWiki-extensions-Scribunto, 7Tracking: Information can be passed between #invoke's (tracking) - https://phabricator.wikimedia.org/T67258#1923229 (10Rical) I do not want disturb this task. But to manage versions of a group of submodules inside one main module, I use package.loader and _G space to coordina... [10:00:28] legoktm, tto, is there really still no way to add a query to the API without duplicating the SQL and all the logic from special pages etc.? https://gerrit.wikimedia.org/r/#/c/263162/ [10:00:55] I remember there was some discussion on the topic but I forgot the outcome. [10:07:08] Nemo_bis: It shouldn't have to be that way [10:07:41] According to the model-view-component structure, there should be a "component" that is agnostic as to the output format [10:07:54] Unfortunately MW doesn't really follow MVC [10:08:09] Not sure of the discussion you refer to though [10:10:07] Nemo_bis: I'm sure Brad will have something to say about it, in any case [10:23:09] I have been trying to commit one of my changed for long and I am getting this error "fatal: cannot exec '.git/hooks/commit-msg': Text file busy". The error says its because of two perl file being accessed at same time .Can someone suggest a solution to this. [10:30:49] 10MediaWiki-extensions-BounceHandler, 7Documentation, 3Google-Code-In-2015: Create documentation for configuring BounceHandler with Postfix - https://phabricator.wikimedia.org/T114252#1923239 (1001tonythomas) I got this message in my IRC chatbox, but couldnt reply before the person quit. > 20:52 could anyone review this, please? https://gerrit.wikimedia.org/r/#/c/263196/ [11:30:33] 4(no projects): Add possibility to use default MediaWiki URLs on all wikis - https://phabricator.wikimedia.org/T123181#1923263 (10XXN) @Nnemo: for example no.wiki Recent changes page (https://no.wikipedia.org/wiki/Spesial:Siste_endringer) has some improvised interwiki sitelinks to some major and related wikiped... [11:36:22] 10UI-Standardization: Double check to make sure that less file is working with other frameworks with users - https://phabricator.wikimedia.org/T118919#1923268 (10Volker_E) Bootstrap 4 is an example where a Less variable file might be a problem. But we shouldn't stop at at Less variables file so or so, given the... [11:37:58] 10UI-Standardization: Standardize MediaWiki components - https://phabricator.wikimedia.org/T113560#1923274 (10Volker_E) [11:38:00] 10UI-Standardization, 10OOjs-UI: Remove `-ms-transition` & `-ms-animation` from OOjs UI as IE10 final understands unprefixed properties. - https://phabricator.wikimedia.org/T116453#1923271 (10Volker_E) 5Open>3Resolved [11:38:47] 10Living-Style-Guide, 10UI-Standardization, 7Accessibility: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1923275 (10Volker_E) [11:39:55] 10UI-Standardization: [GOAL] Basic styles implemented with base CSS & accompanying HTML - https://phabricator.wikimedia.org/T118917#1923277 (10Volker_E) [11:39:57] 10UI-Standardization: Double check to make sure that less file is working with other frameworks with users - https://phabricator.wikimedia.org/T118919#1923276 (10Volker_E) 5Open>3Resolved [11:42:15] 10UI-Standardization: [GOAL] Basic styles implemented with base CSS & accompanying HTML - https://phabricator.wikimedia.org/T118917#1923278 (10Volker_E) There has been an issue arising in mid-December. I've learnt that we're trying to move to Diffusion and away from Gerrit. Without support this won't easily hap... [11:45:44] 10UI-Standardization: [GOAL] Basic styles implemented with base CSS & accompanying HTML - https://phabricator.wikimedia.org/T118917#1923279 (10Volker_E) [11:46:53] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: [GOAL] Enhance accessibility of OOjs UI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users - https://phabricator.wikimedia.org/T111117#1923282 (10Volker_E) [11:49:02] 10MediaWiki-HTMLForm, 10UI-Standardization: OOUI HTMLForms doesn't show errors for forms with multiple sections - https://phabricator.wikimedia.org/T122691#1923287 (10Volker_E) [11:49:54] 10MediaWiki-HTMLForm, 10UI-Standardization: OOUI HTMLForms doesn't show errors for forms with multiple sections - https://phabricator.wikimedia.org/T122691#1911376 (10Volker_E) @Glaisher Do you have an example page, where you run into this? [11:50:51] 10MediaWiki-extensions-MultimediaViewer: MediaViewer: remove the uploader field - https://phabricator.wikimedia.org/T123184#1923291 (10Srittau) 3NEW [12:27:20] 10MediaWiki-extensions-MultimediaViewer: MediaViewer: remove the uploader field - https://phabricator.wikimedia.org/T123184#1923313 (10Tgr) [12:27:22] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Remove uploader's name from MediaViewer: only last uploader's name is shown - https://phabricator.wikimedia.org/T59308#1923314 (10Tgr) [12:28:19] Nemo_bis: could you publish https://codein.withgoogle.com/dashboard/tasks/5836377094619136/ ? [12:29:44] done [12:30:01] Thanks :) [12:38:09] 10MobileFrontend, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): ErrorException from line 705 of /data/mediawiki/extensions/MobileFrontend/includes/MobileFrontend.hooks.php: PHP Warning: array_search() expects parameter 2 to be an array or collect... - https://phabricator.wikimedia.org/T123169#1923317 [13:33:51] 10MediaWiki-extensions-Scribunto, 7Tracking: Information can be passed between #invoke's (tracking) - https://phabricator.wikimedia.org/T67258#1923337 (10TomT0m) >>! In T67258#1923048, @Anomie wrote: > Parsoid requires that each call to #invoke does not depend on anything else on the page, so it can parse the... [13:36:58] 10Wikimedia-Site-Requests, 6Wiktionary: English WIktionary: namespace abbreviations - https://phabricator.wikimedia.org/T123187#1923340 (10Daniel_Carrero) 3NEW [13:39:28] 10Wikimedia-Site-Requests, 6Wiktionary: English WIktionary: namespace abbreviations - https://phabricator.wikimedia.org/T123187#1923349 (10Daniel_Carrero) [13:47:05] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1923356 (10Icerat) Same issue, 1.26 on IIS8 with PHP5.6. I have open_basedir disabled. MW is successfully creating a... [13:47:21] 10MediaWiki-extensions-Babel, 10Wikimedia-Site-Requests: Localisation of user categories for nap.wiki - https://phabricator.wikimedia.org/T123188#1923357 (10Sannita) 3NEW [13:49:50] 10MediaWiki-extensions-Babel, 10Wikimedia-Site-Requests: Localisation of user categories for nap.wikipedia - https://phabricator.wikimedia.org/T123188#1923364 (10Sannita) [13:50:11] 10MediaWiki-extensions-Babel, 10Wikimedia-Site-Requests: Localisation of user categories for nap.wikipedia - https://phabricator.wikimedia.org/T123188#1923357 (10Sannita) [13:51:47] Krinkle: ping [13:52:00] He might still be on PST [13:57:15] 10MediaWiki-API, 5Patch-For-Review: API: Add mergehistory action - https://phabricator.wikimedia.org/T69742#1923370 (10jayvdb) @Sn1per, once this is merged, could you create a #Pywikibot-core task to implement support for this. If done before end of GCI, I can submit it as a Pywikibot GCI task if you are inter... [13:57:15] hmm, ok, thanks for the hint Reedy :) [13:57:25] on/in [13:57:26] :D [13:57:44] :P [13:57:52] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1923371 (10Ciencia_Al_Poder) >>! In T119934#1923356, @Icerat wrote: > Same issue, 1.26 on IIS8 with PHP5.6. I have o... [14:17:58] 10Wikimedia-Site-Requests, 6Wiktionary: English Wiktionary: namespace abbreviations - https://phabricator.wikimedia.org/T123187#1923373 (10JEumerus) [14:19:55] 10MediaWiki-extensions-Babel, 10Wikimedia-Site-Requests: Localisation of user categories for nap.wikipedia - https://phabricator.wikimedia.org/T123188#1923374 (10Reedy) [14:55:22] 10UI-Standardization, 10OOjs-UI, 7Accessibility, 7Easy, 5Patch-For-Review: Use `not-allowed` cursor for disabled elements in OOjs UI - https://phabricator.wikimedia.org/T123183#1923378 (10Esanders) While the semantics of this seem sensible at first glance, I'm not sure this common practice anywhere. I th... [14:57:50] 10MobileFrontend, 10SEO: If MobileFrontend auto detects, if the mobile view should be delivered, it should set a vary header - https://phabricator.wikimedia.org/T123189#1923379 (10Florian) 3NEW a:3Florian [14:59:33] 10UI-Standardization, 10OOjs-UI, 7Accessibility, 7Easy, 5Patch-For-Review: Use `not-allowed` cursor for disabled elements in OOjs UI - https://phabricator.wikimedia.org/T123183#1923387 (10Esanders) Indeed the rendering of not-allowed on my system is the drag and drop "grab hand" - with a struck circle ne... [15:01:13] 10Living-Style-Guide, 10UI-Standardization, 7Accessibility: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1923389 (10Esanders) While the semantics of this seem sensible at first glance, I'm not sure this common practice anywhere. I think not-al... [15:14:15] btw.: where is gerrit-wm? :D [15:21:25] 10Wikimedia-Site-Requests: Wrong value for {{NUMBEROFFILES}} on the Polish Wikipedia - https://phabricator.wikimedia.org/T123190#1923396 (10The_Polish) 3NEW [15:22:22] 4(no projects): Add possibility to use default MediaWiki URLs on all wikis - https://phabricator.wikimedia.org/T123181#1923404 (10Boshomi) Please make a wikidata item for all translation of special sites. This will not solve the issue complete, but could help a lot. [16:23:30] 10Wikimedia-Site-Requests: Localised sitename for my.wikipedia - https://phabricator.wikimedia.org/T123191#1923409 (10Ninjastrikers) 3NEW [16:37:09] 10Wikimedia-Site-Requests: Localised sitename for my.wikipedia - https://phabricator.wikimedia.org/T123191#1923427 (10Luke081515) p:5Normal>3Triage [16:46:19] 10MediaWiki-Special-pages, 7Easy, 3Google-Code-In-2015: Special:UserRights "you must login" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874#1923433 (10Dnysdk3435) I am not understanding exactly what is the bug.Can someone explain it please?? [17:05:52] 10MediaWiki-extensions-AbuseFilter: Filter local only abuse on the central global abuselog - https://phabricator.wikimedia.org/T123102#1923462 (10Glaisher) The 'wiki' field expects the dbname not the domain name so in the case of Meta, you have to use `metawiki` for it to work properly. Note that this didn't pre... [17:16:04] 10MediaWiki-extensions-Scribunto, 7Tracking: Information can be passed between #invoke's (tracking) - https://phabricator.wikimedia.org/T67258#1923464 (10Anomie) >>! In T67258#1923229, @Rical wrote: > Here we could imagine a space dedicated to the intermodules communications across an _I intermodule space, wit... [17:18:51] 10MediaWiki-User-blocking: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - https://phabricator.wikimedia.org/T55008#1923466 (10Rich_Farmbrough) > @Aklapper - best to ping me via my en:wp talk page Jack didn't really ask any questions, so I have simply resp... [17:29:43] 6Wikisource, 7JavaScript, 7Regression: Code from MediaWiki:Base.js removes the linebreak before "|-", breaking table on Wikisource - https://phabricator.wikimedia.org/T123174#1923470 (10He7d3r) [17:36:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Show interlanguage links on associated talk pages too - https://phabricator.wikimedia.org/T30604#1923475 (10Tacsipacsi) [17:44:27] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Access to item from talk page - https://phabricator.wikimedia.org/T123196#1923479 (10Tacsipacsi) 3NEW [18:14:13] 10MediaWiki-API, 5Patch-For-Review: API: Add mergehistory action - https://phabricator.wikimedia.org/T69742#1923502 (10Sn1per) >>! In T69742#1923370, @jayvdb wrote: > @Sn1per, once this is merged, could you create a #Pywikibot-core task to implement support for this. If done before end of GCI, I can submit it... [18:16:29] 10MediaWiki-API, 5Patch-For-Review: API: Add mergehistory action - https://phabricator.wikimedia.org/T69742#1923511 (10Sn1per) [18:19:48] grrrit died? [18:22:43] OH- Looks fine to me [18:26:48] I don't see any IRC gerrit bot updates [18:26:59] OH-: How do you guys restart it? :P [18:27:12] OH-: YES! I just pushed my code, can't see it here [18:27:54] https://gerrit.wikimedia.org/r/#/c/263185/ <--- this. Nemo_bis please review this i18n task? [18:55:01] Nemo_bis: typically the API has a different query plan than the special page, but it would be really nice if we *didn't* have to do that...I'll also leave it to anomie though :S [18:55:51] 6Mobile-Apps, 10Wikimedia-Hackathon-2016-Organization: Mobile apps priorities at for the Wikimedia Hackathon 2016 - https://phabricator.wikimedia.org/T123199#1923518 (10Qgil) 3NEW [18:56:21] 6Mobile-Apps, 10Wikimedia-Hackathon-2016-Organization: Mobile apps priorities at for the Wikimedia Hackathon 2016 - https://phabricator.wikimedia.org/T123199#1923526 (10Qgil) [18:56:40] 6Mobile-Apps, 10Wikimedia-Hackathon-2016-Organization: Mobile apps priorities at for the Wikimedia Hackathon 2016 - https://phabricator.wikimedia.org/T123199#1923518 (10Qgil) [18:56:41] 10Wikimedia-Hackathon-2016-Organization: Engaging developer communities for the Wikimedia Hackathon 2016 - https://phabricator.wikimedia.org/T119694#1923527 (10Qgil) [18:57:54] gerrit-wm why you leave us :( [19:01:26] grrrit's awol [19:06:39] 10MediaWiki-extensions-FlaggedRevs: New magic word like PROTECTIONLEVEL to give flag restrictions information - https://phabricator.wikimedia.org/T26004#1923529 (10Rich_Farmbrough) Thanks [19:09:31] https://www.mediawiki.org/wiki/User:Yuvipanda is the admin of grrrit-wm. He can restart it for us [19:10:26] https://wikitech.wikimedia.org/wiki/Grrrit-wm <-- these guys have access [19:10:46] legoktm: Can you restart it for us please? :) [19:10:54] I don't have access to it [19:10:56] Only Yuvi does [19:12:17] ananayarora: Labs folks are looking into it. [19:12:41] Okay. [19:13:40] I once saw gcibot timeout and rejoin on it's own. Maybe that's not the case with this one. [19:16:41] Nemo_bis: MatmaRex isn't online. Could you please take a look at my change? It's just a grammatical mistake that has been fixed. [19:16:51] https://gerrit.wikimedia.org/r/263185 [19:17:29] 10MediaWiki-User-blocking, 7Privacy: MediaWiki:Autoblocker etc. reveals to third party that a (blocked) user has used the same IP address - https://phabricator.wikimedia.org/T55008#1923530 (10Bawolff) [19:18:58] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1923531 (10Icerat) It's windows\temp and has write permissions. file uploads are working, so don't think that's the... [19:22:34] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1923532 (10Icerat) scratch that about uploads working - they're not any more - ``` Could not create directory "mwst... [19:30:47] 10Living-Style-Guide, 10UI-Standardization, 7Accessibility: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1923535 (10Volker_E) @Esanders To complete the picture, what is your system? And yes, those cursors are predominantly used for drag and dr... [19:38:34] Nemo_bis: I left you some comments on the GCI page. :) [19:47:32] ananayarora: You have an extraneous .DS_Store in that change [19:47:50] OH-: Huh? I did git rm .DS_Store :/ [19:48:01] OH-: repushing it. Sorry for that. [19:48:04] 10Living-Style-Guide, 10UI-Standardization, 7Accessibility: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1923538 (10Esanders) Chrome+Ubuntu. I see its used by bootstrap but maybe we should wait for it to become more common rather than trying t... [19:56:51] that's why I don't like commit -a [19:57:11] Yay grrrit is back [20:05:31] 6Research-and-Data: python-mwviews does not handle unicode in titles - https://phabricator.wikimedia.org/T123200#1923543 (10ResMar) 3NEW [20:06:08] 6Research-and-Data: python-mwviews does not handle unicode in titles - https://phabricator.wikimedia.org/T123200#1923550 (10ResMar) [20:08:49] 6Research-and-Data: python-mwapi fails on import in Python 2.7 - https://phabricator.wikimedia.org/T123201#1923555 (10ResMar) 3NEW [20:09:01] 10MediaWiki-extensions-DonationInterface, 10Continuous-Integration-Config: DonationInterface fails mwext-DonationInterface-testextension-zend test - https://phabricator.wikimedia.org/T123202#1923562 (10Paladox) 3NEW [20:16:37] legoktm: hi! are you therE? [20:16:39] there* [20:18:37] 4(no projects): python-mwviews does not handle unicode in titles - https://phabricator.wikimedia.org/T123200#1923573 (10ResMar) [20:19:36] (03PS1) 10Gerrit Patch Uploader: Title.php: Avoid wfGetLangObj for Language objects [core] - 10https://gerrit.wikimedia.org/r/263239 [20:19:38] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/263239 (owner: 10Gerrit Patch Uploader) [20:20:10] 4(no projects): python-mwapi fails on import in Python 2.7 - https://phabricator.wikimedia.org/T123201#1923576 (10ResMar) [20:22:44] 10Wikimedia-Site-Requests, 5Patch-For-Review: Localised sitename for my.wikipedia - https://phabricator.wikimedia.org/T123191#1923579 (10Luke081515) a:3Mdann52 [20:26:34] WHOIS grrrit-wm [20:27:19] ^ Sorry :P [20:27:55] 10WMUA-Tech, 10Wikimedia-Site-Requests, 5Patch-For-Review: Prevent indexing of User: namespace on uawikimedia - https://phabricator.wikimedia.org/T122732#1923587 (10Luke081515) a:3Base [20:27:58] Any idea where is MatmaRex? I need him to approve my task and he's been away for > 24 hours now :( [20:30:51] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1923606 (10Icerat) As others reported, chrome/edge console reports the following error - ``` Internal error Intern... [20:33:00] (03CR) 10Liangent: "You've already found the statement with hard-coded parentheses. However instead of replacing them, you attempted to add an extra pair of l" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [20:33:04] 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Flow-error-parsoid-failure/en]] i18n issue - https://phabricator.wikimedia.org/T123203#1923608 (10Macofe) 3NEW [20:33:31] (03CR) 10Liangent: [C: 04-1] Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [20:47:46] 6RevisionScoringAsAService: Draft final report - https://phabricator.wikimedia.org/T123204#1923619 (10ToAruShiroiNeko) 3NEW a:3ToAruShiroiNeko [20:48:43] 6RevisionScoringAsAService: Wikimania submission for a Revision Scoring Panel (deadline 17 January) - https://phabricator.wikimedia.org/T123205#1923628 (10ToAruShiroiNeko) 3NEW a:3ToAruShiroiNeko [20:51:13] 6RevisionScoringAsAService: Work out sphinx issues in revscoring docs (attributes not documented) - https://phabricator.wikimedia.org/T123124#1923638 (10ToAruShiroiNeko) [20:51:19] 6RevisionScoringAsAService: Determine how to build WP phrase-structure tree-bank. - https://phabricator.wikimedia.org/T122728#1923640 (10ToAruShiroiNeko) [20:51:24] 10Wikimedia-Site-Requests, 5Patch-For-Review: Three changes to Wuu Wikipedia - https://phabricator.wikimedia.org/T122476#1923642 (10Krenair) Have those characters on the logo been changed slightly? [20:51:40] 6RevisionScoringAsAService: Draft final report - https://phabricator.wikimedia.org/T123204#1923644 (10ToAruShiroiNeko) [20:51:59] OH-: There? [20:52:26] Yo [20:52:30] 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Smw-pa-property-predefined newp/en]] i18n issue - https://phabricator.wikimedia.org/T123206#1923646 (10Macofe) 3NEW [20:53:02] OH-: MatmaRex is offline for the past 24 horus :'( I need someone to check my task. Help me? [20:53:26] OH-: https://gerrit.wikimedia.org/r/#/c/263185/ It got rejected because of my Wrong English. [20:55:07] Looks fine to me, but I can't merge or approve for yu [20:55:12] " [20:55:14] :'( [20:55:18] matanya: There? [20:55:21] 10MobileFrontend, 10SEO, 5Patch-For-Review: If MobileFrontend auto detects, if the mobile view should be delivered, it should set a vary header - https://phabricator.wikimedia.org/T123189#1923654 (10BBlack) I'd like to understand this more before we push the change above. In general, "Vary: User-Agent" is v... [20:55:26] (03CR) 10BBlack: [C: 04-1] "See ticket" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263228 (https://phabricator.wikimedia.org/T123189) (owner: 10Florianschmidtwelzow) [20:56:17] marktraceur: There? [20:57:35] ananayarora: yes ? [20:59:00] matanya: Hello! Could you please review my task, as MatmaRex has been offline for the past 24 hours, and I got a -1 just because of wrong english? I'll be very grateful to you. https://gerrit.wikimedia.org/r/#/c/263185/ [20:59:11] matanya: Phab Task: https://phabricator.wikimedia.org/T118902 [20:59:28] ananayarora: i don't have merge rights [20:59:54] matanya: I've added you as a reviewer! [21:00:02] and BTW ananayarora Sut and Sun are weekends for devs [21:00:15] (03PS1) 10Cicalese: made sure is defined when using new Extension Registration mechanism [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/263241 [21:00:24] sorry, my JS really sucks [21:00:26] matanya: Uh Ohhh, Sorry, forgot about that. [21:01:03] try again tomorrow [21:01:49] (03PS2) 10Cicalese: make sure $wgHeaderTabsScriptPath is defined when using new Extension Registration mechanism [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/263241 [21:01:50] matanya: No problem :) I'll just ask someone else here [21:03:04] 10MediaWiki-extensions-AbuseFilter: Filter local only abuse on the central global abuselog - https://phabricator.wikimedia.org/T123102#1923662 (10Billinghurst) For the purpose of the exercise, might it be possible to have a check box next to the wiki field [labelled 'local only'] that applies Meta-Wiki, or whate... [21:03:10] legoktm, Reedy, FlorianSW if anyone is here, please review my task and merge it if everything is correct. I've added you all to the reviewer's list :) https://gerrit.wikimedia.org/r/#/c/263185/ [21:03:27] ... [21:13:25] (03PS1) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263243 (https://phabricator.wikimedia.org/T115175) [21:14:18] (03Abandoned) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263243 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [21:40:35] 10MediaWiki-extensions-CentralNotice, 7Easy, 3Google-Code-In-2015: CentralNotice changes being marked as bot edit - https://phabricator.wikimedia.org/T87324#1923668 (10KTC) No. The edits, while made using the CentralNotice extension interface, are made by human. Special:CentralNoticeLogs is not the most use... [21:49:52] (03Restored) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263243 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:03:45] (03PS2) 10Cicalese: added roles for Semantic MediaWiki and other useful extensions [vagrant] - 10https://gerrit.wikimedia.org/r/262833 (https://phabricator.wikimedia.org/T99858) [22:12:21] (03CR) 10Cicalese: "Known issues:" [vagrant] - 10https://gerrit.wikimedia.org/r/262833 (https://phabricator.wikimedia.org/T99858) (owner: 10Cicalese) [22:12:32] I wonder what patch ananayarora was talking about [22:12:44] Shame they pinged all those people only to get zero help [22:15:45] 10MobileFrontend, 10SEO, 5Patch-For-Review: If MobileFrontend auto detects, if the mobile view should be delivered, it should set a vary header - https://phabricator.wikimedia.org/T123189#1923677 (10Florian) But as far as I know, Vary doesn't provide a setting like "specialdevices", right? :/ Btw.: This does... [22:16:11] (03PS3) 10Cicalese: added roles for Semantic MediaWiki and other useful extensions [vagrant] - 10https://gerrit.wikimedia.org/r/262833 (https://phabricator.wikimedia.org/T99858) [22:17:49] (03PS4) 10Cicalese: added roles for Semantic MediaWiki and other useful extensions [vagrant] - 10https://gerrit.wikimedia.org/r/262833 (https://phabricator.wikimedia.org/T99858) [22:18:28] (03Restored) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:18:38] (03PS3) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) [22:19:01] (03Abandoned) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263243 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:20:29] (03PS4) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) [22:22:49] (03CR) 10Cindy-the-browser-test-bot: "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/263261 (owner: 10L10n-bot) [22:24:42] (03PS5) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) [22:26:45] (03Abandoned) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:27:04] (03CR) 10Prtksxna: "recheck" [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/259199 (owner: 10VolkerE) [22:27:20] (03CR) 10jenkins-bot: [V: 04-1] Fix minor code documentation flaw [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/259199 (owner: 10VolkerE) [22:27:50] (03PS5) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [22:28:48] 6Repository-Ownership-Requests: Unarchive mediawiki/extensions/OOUIPlayground - https://phabricator.wikimedia.org/T122944#1923686 (10Prtksxna) Still unable to merge https://gerrit.wikimedia.org/r/#/c/259199/ though. Does the patch need to be abandoned and re-submitted? [22:29:08] (03PS6) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [22:29:25] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1923687 (10Icerat) FYI, a completely fresh install is working fine, so clearly this is either (a) a clash with somet... [22:37:29] (03CR) 10Cicalese: "See reference to this patch at https://gerrit.wikimedia.org/r/#/c/262833" [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/263241 (owner: 10Cicalese) [22:41:28] 6RevisionScoringAsAService: Describe what campaigns are - https://phabricator.wikimedia.org/T123129#1923691 (10Halfak) Made some edits. Probably good enough for now. [22:55:36] 10MediaWiki-API, 10Wikidata: Adding a claim to a redirected item throws a incorrect wikibase-validator-no-such-entity error message - https://phabricator.wikimedia.org/T123208#1923695 (10Multichill) 3NEW [23:19:51] 10MediaWiki-skins-Slate, 6Phabricator, 10Gerrit: Remove Slate (skin) from Phabricator and Gerrit - https://phabricator.wikimedia.org/T123209#1923708 (10Prtksxna) 3NEW [23:20:35] 10MediaWiki-skins-Slate, 6Phabricator, 10Gerrit: Remove Slate (skin) from Phabricator and Gerrit - https://phabricator.wikimedia.org/T123209#1923715 (10Prtksxna) Is Archiving the project on Phabricator enough? [23:25:54] 10MediaWiki-Parser: An empty bullet in print - https://phabricator.wikimedia.org/T123093#1923716 (10Cpiral) [23:31:03] (03PS31) 10Llyrian: Implement datatype 'Math' for Wikidata [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) [23:34:46] (03PS1) 10Gerrit Patch Uploader: Add parameters to Gallery Format 'caption field' for setting field to use for image captions 'alt field' for setting field to use for alt 'link field' for setting field to use for image link [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/263308 [23:34:48] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/263308 (owner: 10Gerrit Patch Uploader) [23:36:38] (03CR) 10Prtksxna: [C: 031] mw.Upload.BookletLayout: Show an error rather than explode when uploads are disabled (031 comment) [core] - 10https://gerrit.wikimedia.org/r/257671 (https://phabricator.wikimedia.org/T119314) (owner: 10Bartosz Dziewoński) [23:38:40] Nemo_bis: In this change: https://gerrit.wikimedia.org/r/#/c/263166/ am I supposed to replace the $1 with $2? [23:43:24] Or anyone else ^ ? [23:44:28] Well, $1 means first parameter [23:44:40] $2 probably wouldn't work because there is only one parameter [23:44:48] ^ [23:44:59] I would think you need to pass in a number for the parameter $1 [23:45:23] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1923719 (10Quiddity) That seems reasonable to me. Thanks for the research. :-) [23:46:30] OH-: $1 is already an optional parameter [23:46:50] Guest14905: I think nemo is trying to tell you your documentation in qqq and your entries en en.json do not match up [23:46:51] OH-: So doesn't that mean I have to use $2? [23:47:09] ^ what unicornisaurous said [23:47:32] so don't I have to replace the $1 with $2 then? [23:48:05] Well, if $2 is the number of wikis, then the plural thingamajig should use $2 [23:48:12] Yes, it is [23:48:36] But then this: https://gerrit.wikimedia.org/r/#/c/263166/3/i18n/en.json ! [23:48:47] The third patch [23:49:34] I think Nemo meant that your PLURAL syntax didn't include the singular form of the word wiki? [23:49:39] * OH- shrug [23:49:57] * Guest33642 is confused [23:50:44] I don't know what to do now... [23:50:51] Guess I'll just wing it :) [23:51:31] 10MediaWiki-skins-Slate, 6Phabricator, 10Gerrit: Remove Slate (skin) from Phabricator and Gerrit - https://phabricator.wikimedia.org/T123209#1923723 (10greg) >>! In T123209#1923715, @Prtksxna wrote: > Is Archiving the project on Phabricator enough? yeah [23:51:42] OH-: Do you know if there are any other examples like that? [23:51:50] So I can refer to them? [23:51:53] You had {{PLURAL:$3|wiki|wikis}} for centralauth-rightslog-entry-newset, so why did you have {{PLURAL:$2|wikis}} for centralauth-log{in,out}-progress? [23:52:17] OH-: There are only 2 parameter for in/out [23:52:26] 10MediaWiki-skins-Slate, 6Phabricator, 10Gerrit: Remove Slate (skin) from Phabricator and Gerrit - https://phabricator.wikimedia.org/T123209#1923724 (10Prtksxna) >>! In T123209#1923723, @greg wrote: >>>! In T123209#1923715, @Prtksxna wrote: >> Is Archiving the project on Phabricator enough? > > yeah Cool!... [23:52:33] Not the $params. The {{PLURAL}} syntax. [23:52:35] But there were 3 (now 4) for newset [23:52:49] Oh you mean wiki|wikis? [23:52:51] {{PLURAL:$PARAM|wiki|wikis}} vs {{PLURAL:$PARAM|wikis}} [23:53:36] Yeah, that's because in the TWN thread, it mentioned that wikis were always plural; the issue in other languages only cropped up if there were more then 2 [23:53:47] than* [23:55:40] (03PS7) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [23:55:41] 10MediaWiki-extensions-Insider: Convert Insider to use extension registration - https://phabricator.wikimedia.org/T87932#1923729 (10MtDu) a:3MtDu I'll work on this. [23:55:55] (03CR) 10Prtksxna: Unbreak Visual Editor Toolbar & possible user styles layout (031 comment) [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/261779 (https://phabricator.wikimedia.org/T122117) (owner: 10VolkerE) [23:58:46] If that's not the issue then I don't know, sorry [23:59:46] OH-: I just uploaded a patch fixing that anyway. Thanks for your help!