[00:05:43] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922310 (10demon) Yep, that's it. Didn't realize we already had something filed for it. This task is meant to be a workaround really until that's solved. This should probably be blocked on th... [00:06:12] 3Team-Practices-This-Week: Update TPG Q3 goals spreadsheet/wiki - https://phabricator.wikimedia.org/T122988#1922311 (10ggellerman) [00:14:01] 6Language-Engineering, 10Wikimedia-General-or-Unknown: enWS revert to no differentiation between en/en-gb/en-ca mediawiki namespace messages and language settings - https://phabricator.wikimedia.org/T122712#1922319 (10Nikerabbit) Can you give a concrete example that does not work with expected outcome? [00:24:28] 10Unofficial-Apps-Wikipedia-Windows-8, 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1922334 (10Rezonansowy) [00:29:55] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922336 (10Peachey88) Has anyone tried to reach out to these accounts before disabling (emails/talk pages)? Coming back to find a disabled account might be a bit disheartening if they want to... [00:31:11] Nemo_bis: What should I do about this: https://gerrit.wikimedia.org/r/#/c/262459/ ? [00:31:42] 6Phabricator, 10Phabricator-Upstream: Phabricator needs to handle bounces/errors from non-existent email addresses - https://phabricator.wikimedia.org/T100400#1922337 (10Peachey88) Has anyone filed a upstream report about this yet since @aklapper asked for help in Jul? [00:32:41] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922340 (10demon) >>! In T123139#1922336, @Peachey88 wrote: > Has anyone tried to reach out to these accounts before disabling (emails/talk pages)? Coming back to find a disabled account migh... [00:34:04] ostriches: I wonder if any of those people might have alt emails already set up in phab that just need to be set to primary [00:34:11] no idea if admins can check that though [00:34:14] 10MediaWiki-extensions-ContentTranslation, 10Continuous-Integration-Infrastructure, 7WorkType-Maintenance: ContentTranslation phpunit run very slow due to inclusion of Scribunto and Wikibase - https://phabricator.wikimedia.org/T121595#1922341 (10Krinkle) Including those tests is also valuable since extension... [00:34:18] p858snake: They can't. [00:34:27] If I could've just adjusted settings for peeps myself I would've :p [00:35:14] 6Phabricator, 10Phabricator-Upstream: Phabricator needs to handle bounces/errors from non-existent email addresses - https://phabricator.wikimedia.org/T100400#1922342 (10demon) >>! In T100400#1922337, @Peachey88 wrote: > Has anyone filed a upstream report about this yet since @aklapper asked for help in Jul?... [00:35:30] 6Language-Engineering, 10Wikimedia-General-or-Unknown: enWS revert to no differentiation between en/en-gb/en-ca mediawiki namespace messages and language settings - https://phabricator.wikimedia.org/T122712#1922343 (10Billinghurst) Oops ... MediaWiki:Movepage-moved was the specific case. [[ https://en.wikiso... [00:37:04] p858snake: detaching from irc for now, will continue to follow up on the task(s) [00:39:39] 6Language-Engineering, 10Wikimedia-General-or-Unknown: enWS revert to no differentiation between en/en-gb/en-ca mediawiki namespace messages and language settings - https://phabricator.wikimedia.org/T122712#1922344 (10Billinghurst) @nikerabbit I have set a corresponding situation at test.wikipedia.org Test... [00:47:45] 10MediaWiki-Vagrant: Vagrant 'commons' role doesn't create proper database tables - https://phabricator.wikimedia.org/T122863#1922345 (10Tgr) 5Invalid>3Open If there was no obvious failure, then this is a bug. (Although I guess if there was one, that would also be a bug.) `vagrant provision` runs the updater... [00:49:29] 10MediaWiki-Vagrant: Running maintenance scripts without mwscript fails silently on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T123143#1922347 (10Tgr) >>! In T123143#1922219, @bd808 wrote: > # Make a hybrid of #1 & #2 where `mwscript --wiki=wiki` is assumed **until** more than one wiki instance has be... [00:49:55] Hi! I am a GCI student [00:50:04] I need some help on this: https://gerrit.wikimedia.org/r/#/c/262459/ [00:50:39] One of the reviewers said that it was way out of scope for a Google Code In task, so what should I do now? [00:54:04] Guest30503: choose a different task? [00:54:16] Brian is right, this is way harder than it looks [00:54:22] tgr: I would, but I've been working on this for a few days [00:54:34] So I want this task to be marked complete [00:54:47] This is only one part of the task [00:55:10] Guest30503: you should talk to your mentor about that [00:55:22] tgr: OK [00:55:40] Thanks! [00:55:47] maybe instead of submitting a patch, they will accept the work you have done to identify the deeper issue as enough to accept the task [00:56:35] tgr: ok [00:57:02] 6Phabricator: Mark existing projects as subprojects - https://phabricator.wikimedia.org/T123078#1922360 (10Aklapper) [00:57:03] 6Phabricator, 5Release: Next Phabricator Upgrade - https://phabricator.wikimedia.org/T120013#1922361 (10Aklapper) [00:59:01] (03CR) 10Gergő Tisza: Add "bot passwords" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [00:59:01] (03CR) 10Gergő Tisza: Add "bot passwords" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [00:59:54] 10MediaWiki-Page-editing: Live preview does not display map (from Mapframe template) on English wikivoyage - https://phabricator.wikimedia.org/T123061#1922370 (10TheDJ) ``` function insertIFrame( $content ) { $content.find( '#mapwrap' ); } ``` `jQuery(do... [01:00:50] 10MediaWiki-General-or-Unknown, 7I18n: Libraries used by MediaWiki do not support all languages MediaWiki supported - https://phabricator.wikimedia.org/T123080#1922373 (10Aklapper) [01:01:08] 10MediaWiki-General-or-Unknown, 7Documentation: Manual:Skinning on mediawiki.org is not up-to-date when it comes to skin/extension registration in JSON - https://phabricator.wikimedia.org/T123100#1922374 (10Aklapper) [01:03:54] 10MediaWiki-Special-pages, 7Easy, 3Google-Code-In-2015: Special:UserRights "you must login" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874#1922384 (10Aklapper) >>! In T118874#1920789, @NeerajBattan wrote: > can someone explain this bug, I wa... [01:06:16] 10Wikipedia-App-General-or-Unknown: Wikipedia mail (EmailUser) broken - https://phabricator.wikimedia.org/T123068#1922385 (10Aklapper) p:5High>3Triage Hi @GRuban, thanks for taking the time to report this! Is this really related to the Wikipedia Mobile App or to the version in your browser? Is this about //... [01:06:45] 10Wikipedia-App-General-or-Unknown: Emails sent via EmailUser function not working for user on en.wp - https://phabricator.wikimedia.org/T123068#1922388 (10Aklapper) [01:12:07] 10Wikimedia-Site-Requests: Activate WikidataPageBanner extension on French Wikivoyage's help and wikivoyage namespace - https://phabricator.wikimedia.org/T123084#1922393 (10Aklapper) [01:14:18] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1922397 (10Volker_E) @Elitre @Quiddity @violetto I need to reassure one more time, before putting this into patch sets. I'm critical, t... [01:15:09] there are two grrrrrits! [01:15:44] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1922398 (10josephine_l) Hmmm... but the new method has already been implemented, it just involved changing the ggsradius to 10000. :) But I ca... [01:19:27] (03CR) 10Yurik: "This was to solve Bug: T119779" [extensions/Graph] - 10https://gerrit.wikimedia.org/r/262345 (owner: 10Yurik) [01:19:27] (03CR) 10Yurik: "This was to solve Bug: T119779" [extensions/Graph] - 10https://gerrit.wikimedia.org/r/262345 (owner: 10Yurik) [01:20:46] (03CR) 10Yurik: "Ooops, wrong bug number." [extensions/Graph] - 10https://gerrit.wikimedia.org/r/262345 (owner: 10Yurik) [01:20:46] (03CR) 10Yurik: "Ooops, wrong bug number." [extensions/Graph] - 10https://gerrit.wikimedia.org/r/262345 (owner: 10Yurik) [01:22:06] 10MediaWiki-Debian: Investigate adjusting the installer text to tell the user to download LocalSettings to /etc/mediawiki/ - https://phabricator.wikimedia.org/T123151#1922404 (10Legoktm) 3NEW [01:25:10] 10MediaWiki-Page-editing, 10VisualEditor: Editing a table with VE triggers "your revision matches the latest version of this page", does not save changes - https://phabricator.wikimedia.org/T123083#1922411 (10Aklapper) [01:27:07] (03CR) 10Anomie: Add "bot passwords" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [01:27:08] (03CR) 10Anomie: Add "bot passwords" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [01:27:21] (03PS12) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [01:27:22] (03PS12) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [01:30:12] 10MediaWiki-Debian, 7HHVM: Support running the MediaWiki Debian package under HHVM - https://phabricator.wikimedia.org/T123152#1922418 (10Legoktm) 3NEW [01:30:41] (03PS1) 10Yurik: Cache JSON objects in memcached [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263160 [01:30:41] (03PS1) 10Yurik: Cache JSON objects in memcached [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263160 [01:32:17] Why've we got 2 gerrit bots? [01:32:33] It means they're becoming self-aware [01:33:05] (03PS2) 10Yurik: Cache JSON objects in memcached [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263160 (https://phabricator.wikimedia.org/T122489) [01:33:05] (03PS2) 10Yurik: Cache JSON objects in memcached [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263160 (https://phabricator.wikimedia.org/T122489) [01:33:26] (03PS3) 10Yurik: Cache JSON objects in memcached [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263160 (https://phabricator.wikimedia.org/T122489) [01:33:26] (03PS3) 10Yurik: Cache JSON objects in memcached [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263160 (https://phabricator.wikimedia.org/T122489) [01:40:45] 10Wikimedia-Site-Requests: Enable draft namespace on Kannada Wikipedia - https://phabricator.wikimedia.org/T123067#1922444 (10Liuxinyu970226) [01:40:47] 10Wikimedia-Site-Requests, 7Tracking: Issues related to the Draft namespace (tracking) - https://phabricator.wikimedia.org/T66539#1922443 (10Liuxinyu970226) [01:44:40] 10WikiProject-X: Track more than main namespace and draft namespace in project index. - https://phabricator.wikimedia.org/T116668#1922455 (10Liuxinyu970226) [01:44:42] 10Wikimedia-Site-Requests, 7Tracking: Issues related to the Draft namespace (tracking) - https://phabricator.wikimedia.org/T66539#1922454 (10Liuxinyu970226) [01:45:38] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Wikidata items for articles in the Draft namespace - https://phabricator.wikimedia.org/T122806#1922457 (10Liuxinyu970226) [01:45:40] 10Wikimedia-Site-Requests, 7Tracking: Issues related to the Draft namespace (tracking) - https://phabricator.wikimedia.org/T66539#685782 (10Liuxinyu970226) [01:48:20] 10MediaWiki-extensions-GettingStarted: Add AUTHORS file for GettingStarted - https://phabricator.wikimedia.org/T92084#1922458 (10Liuxinyu970226) [01:49:45] 10MediaWiki-Redirects: Investigate Draft namespace redirects - https://phabricator.wikimedia.org/T92093#1922461 (10Liuxinyu970226) [01:49:49] If i submit a task for review in google code in , time period to complete will be passed or will it be going on?? [01:50:32] 10MediaWiki-File-management, 10MediaWiki-Redirects, 6Commons, 6Multimedia, 5Patch-For-Review: File redirects do not work for files with "=" in the filename - https://phabricator.wikimedia.org/T108654#1922472 (10Liuxinyu970226) [01:57:03] sanjay: I think the time pauses while you're waiting for your mentor. [01:57:34] tto: [01:57:43] tto: ok thank you [02:04:15] (03CR) 10Kaldari: [C: 04-1] Initial commit for PageAssessments extension (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/259522 (https://phabricator.wikimedia.org/T121068) (owner: 10Niharika29) [02:04:15] (03CR) 10Kaldari: [C: 04-1] Initial commit for PageAssessments extension (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/259522 (https://phabricator.wikimedia.org/T121068) (owner: 10Niharika29) [02:11:08] (03PS5) 10Niedzielski: WIP: Add Spoon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248091 [02:11:08] (03PS5) 10Niedzielski: WIP: Add Spoon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248091 [02:11:11] 10Wikipedia-App-General-or-Unknown: Emails sent via EmailUser function not working for user on en.wp - https://phabricator.wikimedia.org/T123068#1922488 (10GRuban) Browser, I don't use the Mobile App.This happens on English Wikipedia and Wikimedia Commons.I have a Yahoo account now, but I tried switching to a Go... [02:13:04] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add Spoon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248091 (owner: 10Niedzielski) [02:13:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add Spoon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/248091 (owner: 10Niedzielski) [02:14:59] 10MediaWiki-Email, 10Wikimedia-General-or-Unknown: Emails sent via EmailUser function not working for user on en.wp - https://phabricator.wikimedia.org/T123068#1922489 (10Reedy) [02:39:26] 10MediaWiki-Interface, 10Wikimedia-Developer-Summit-2016: Let's discuss the skin creation process - https://phabricator.wikimedia.org/T114071#1922490 (10Isarra) Full notes paste: Session name: Skinning Meeting goal: Meeting style: Consensus: coming to agreement on one solution Why people make skins, what th... [02:40:59] 10MediaWiki-Email, 10Wikimedia-General-or-Unknown: Emails sent via EmailUser function not working for user on en.wp - https://phabricator.wikimedia.org/T123068#1922491 (10GRuban) And ... just now I was able to at least get the form to email myself. (on English Wikipedia) I filled it out, submitted it, and some... [03:07:59] how to download and install mediawiki [03:18:33] (03PS1) 10Sn1per: Expose visitedwatchers to API through action=query&prop=info [core] - 10https://gerrit.wikimedia.org/r/263162 (https://phabricator.wikimedia.org/T105392) [03:18:33] (03PS1) 10Sn1per: Expose visitedwatchers to API through action=query&prop=info [core] - 10https://gerrit.wikimedia.org/r/263162 (https://phabricator.wikimedia.org/T105392) [03:23:23] (03PS2) 10Sn1per: Expose visitedwatchers to API through action=query&prop=info [core] - 10https://gerrit.wikimedia.org/r/263162 (https://phabricator.wikimedia.org/T105392) [03:23:24] (03PS2) 10Sn1per: Expose visitedwatchers to API through action=query&prop=info [core] - 10https://gerrit.wikimedia.org/r/263162 (https://phabricator.wikimedia.org/T105392) [03:30:27] 6Language-Engineering, 10Wikimedia-General-or-Unknown: enWS revert to no differentiation between en/en-gb/en-ca mediawiki namespace messages and language settings - https://phabricator.wikimedia.org/T122712#1922503 (10Billinghurst) @matmarex would the above issue have any relationship to T86865? [03:32:04] Hi! My name is Rohit Agarwal and I am a participant of GCI 2015. [03:36:11] hi there [03:37:01] hi [04:00:31] (03CR) 10Sumit: [C: 031] importImages.php runs input file names through UTF8 normalization functions [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [04:00:32] (03CR) 10Sumit: [C: 031] importImages.php runs input file names through UTF8 normalization functions [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [04:01:47] 10MediaWiki-extensions-Translate: Provide a method to specity per-page CSS - https://phabricator.wikimedia.org/T123156#1922517 (10coren) 3NEW [04:02:03] (03PS2) 10Sumit: importImages.php should run input file names through UTF8 normalization. [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [04:02:04] (03PS2) 10Sumit: importImages.php should run input file names through UTF8 normalization. [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [04:02:41] (03PS1) 10Yurik: Removed duplicate alt & title attributes [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263163 [04:02:41] (03PS1) 10Yurik: Removed duplicate alt & title attributes [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263163 [04:04:02] 10MediaWiki-Email, 10Wikimedia-General-or-Unknown: Emails sent via EmailUser function not working for user on en.wp - https://phabricator.wikimedia.org/T123068#1922524 (1001tonythomas) >>! In T123068#1920812, @GRuban wrote: > I also tried mailing myself from Wikimedia Commons, and got the same lack of response... [04:04:10] Reedy: ^^ [04:06:30] Reedy: can you see and +2 https://gerrit.wikimedia.org/r/#/c/263153/ [04:11:17] 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Nsfilerepo-upload-target/en]] i18n issue - https://phabricator.wikimedia.org/T123157#1922526 (10Macofe) 3NEW [04:15:54] (03PS3) 10TTO: importImages.php: Run input file names through UTF8 normalization [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [04:15:54] (03PS3) 10TTO: importImages.php: Run input file names through UTF8 normalization [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [04:20:17] gerrit bot seems to be generating two notifications for each change :P [04:21:07] huh. [04:21:40] legoktm: why do we have two copies of grrrit-wm here, and can you kill one of them? [04:23:10] Also I’m pretty sure gcibot died too [04:25:15] ignacio: hmm, i think you run that one? ^ [04:40:15] tgr: Are you still there? [04:56:21] tgr: I need you to see if my logic is correct. [05:25:07] 10MediaWiki-General-or-Unknown: The real page name of Main page (next of Discussion) is not translated. - https://phabricator.wikimedia.org/T123116#1922541 (10Krenair) [05:53:03] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 7user-notice: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1922547 (10Vogone) I have a question concerning the user prefere... [06:19:42] (03PS2) 10Legoktm: Log URL changes to EventLogging if configured [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/263145 (https://phabricator.wikimedia.org/T115119) [06:19:42] (03PS2) 10Legoktm: Log URL changes to EventLogging if configured [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/263145 (https://phabricator.wikimedia.org/T115119) [06:20:02] MatmaRex: lets see... [06:20:49] MatmaRex: nope...I think only YuviPanda can since it's running on kubernetes... [06:53:22] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 7user-notice: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1922552 (10Ess) Visual Editor is not a good editing UI. It's hi... [07:12:38] (03CR) 10Legoktm: [C: 032] Fix last direct usage of UtfNormal in MW core [core] - 10https://gerrit.wikimedia.org/r/263148 (owner: 10Reedy) [07:12:38] (03CR) 10Legoktm: [C: 032] Fix last direct usage of UtfNormal in MW core [core] - 10https://gerrit.wikimedia.org/r/263148 (owner: 10Reedy) [07:17:07] (03CR) 10Legoktm: ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [07:17:08] (03CR) 10Legoktm: ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [07:18:11] (03CR) 10Legoktm: ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [07:18:11] (03CR) 10Legoktm: ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [07:19:26] (03Merged) 10jenkins-bot: Fix last direct usage of UtfNormal in MW core [core] - 10https://gerrit.wikimedia.org/r/263148 (owner: 10Reedy) [07:19:26] (03Merged) 10jenkins-bot: Fix last direct usage of UtfNormal in MW core [core] - 10https://gerrit.wikimedia.org/r/263148 (owner: 10Reedy) [07:20:52] (03PS3) 10Jdrewniak: [WIP] A/B/C test with typehead. **do not merge** [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/260073 [07:20:52] (03PS3) 10Jdrewniak: [WIP] A/B/C test with typehead. **do not merge** [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/260073 [07:21:36] (03CR) 10Legoktm: Update mediawiki/mediawiki-codesniffer to 0.5.1 (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262883 (owner: 10Paladox) [07:21:36] (03CR) 10Legoktm: Update mediawiki/mediawiki-codesniffer to 0.5.1 (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262883 (owner: 10Paladox) [07:21:39] 10MediaWiki-Codesniffer, 7Easy: Update mediawiki/tools/codesniffer repository to use phpcs.xml file - https://phabricator.wikimedia.org/T116866#1922553 (10Haritha28) @legoktm: I am currently working on this bug and is it that I have to create a new phpcs.xml file and add the parameters --standard , --extensi... [07:23:21] (03CR) 10Legoktm: [C: 032] Print which file we are running parsertests for [core] - 10https://gerrit.wikimedia.org/r/262872 (owner: 10TheDJ) [07:23:22] (03CR) 10Legoktm: [C: 032] Print which file we are running parsertests for [core] - 10https://gerrit.wikimedia.org/r/262872 (owner: 10TheDJ) [07:25:38] (03CR) 10Legoktm: [C: 032] ParserTests: Add a video file to parser test suite [core] - 10https://gerrit.wikimedia.org/r/262873 (owner: 10TheDJ) [07:25:38] (03CR) 10Legoktm: [C: 032] ParserTests: Add a video file to parser test suite [core] - 10https://gerrit.wikimedia.org/r/262873 (owner: 10TheDJ) [07:26:46] 10MediaWiki-Codesniffer, 7Easy: Update mediawiki/tools/codesniffer repository to use phpcs.xml file - https://phabricator.wikimedia.org/T116866#1922555 (10Legoktm) Yes, those parameters should go in the phpcs.xml file. See how it's setup in https://github.com/wikimedia/mediawiki-extensions-AbsenteeLandlord for... [07:29:05] (03Merged) 10jenkins-bot: Print which file we are running parsertests for [core] - 10https://gerrit.wikimedia.org/r/262872 (owner: 10TheDJ) [07:29:06] (03Merged) 10jenkins-bot: Print which file we are running parsertests for [core] - 10https://gerrit.wikimedia.org/r/262872 (owner: 10TheDJ) [07:30:40] 6Phabricator: Phabricator Task Daemon has problems - https://phabricator.wikimedia.org/T122408#1922557 (10scfc) Is the "Task Daemon" here the same as `PhabricatorTaskmasterDaemon` in T100400? If so, this task should be merged into that. [07:30:57] (03Merged) 10jenkins-bot: ParserTests: Add a video file to parser test suite [core] - 10https://gerrit.wikimedia.org/r/262873 (owner: 10TheDJ) [07:30:57] (03Merged) 10jenkins-bot: ParserTests: Add a video file to parser test suite [core] - 10https://gerrit.wikimedia.org/r/262873 (owner: 10TheDJ) [08:14:42] (03PS1) 10Ricordisamoa: Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/263164 [08:14:43] (03PS1) 10Ricordisamoa: Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/263164 [08:19:40] (03CR) 10Ricordisamoa: "Many excess newlines at the end of files. See I09822b8c2a32832b1875028739091dd893900783" [core] - 10https://gerrit.wikimedia.org/r/262600 (https://phabricator.wikimedia.org/T122634) (owner: 10TiHoX1) [08:19:40] (03CR) 10Ricordisamoa: "Many excess newlines at the end of files. See I09822b8c2a32832b1875028739091dd893900783" [core] - 10https://gerrit.wikimedia.org/r/262600 (https://phabricator.wikimedia.org/T122634) (owner: 10TiHoX1) [08:20:12] 10Adminbot: Test - https://phabricator.wikimedia.org/T123158#1922565 (10RealEWiki) p:5Triage>3Normal [08:24:30] (03CR) 10Mr. Stradivarius: "Originally I just wanted mw.uri.new to produce the same output as mw.uri.localUrl et al. I didn't realise that this would mean making brea" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/199911 (https://phabricator.wikimedia.org/T93059) (owner: 10Mr. Stradivarius) [08:24:30] (03CR) 10Mr. Stradivarius: "Originally I just wanted mw.uri.new to produce the same output as mw.uri.localUrl et al. I didn't realise that this would mean making brea" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/199911 (https://phabricator.wikimedia.org/T93059) (owner: 10Mr. Stradivarius) [08:24:42] 10Adminbot: Test - https://phabricator.wikimedia.org/T123158#1922570 (10scfc) a:3Aklapper [08:25:13] (03CR) 10Bartosz Dziewoński: [C: 032] "whatevs" [core] - 10https://gerrit.wikimedia.org/r/263164 (owner: 10Ricordisamoa) [08:25:13] (03CR) 10Bartosz Dziewoński: [C: 032] "whatevs" [core] - 10https://gerrit.wikimedia.org/r/263164 (owner: 10Ricordisamoa) [08:30:26] (03Merged) 10jenkins-bot: Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/263164 (owner: 10Ricordisamoa) [08:30:26] (03Merged) 10jenkins-bot: Remove excess newlines at the end of files [core] - 10https://gerrit.wikimedia.org/r/263164 (owner: 10Ricordisamoa) [08:35:48] (03CR) 10Victorbarbu: "Jdlrobson, if you took a look at the .hogan file that I modified, you would see that there are only these two elements so there is no need" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [08:35:48] (03CR) 10Victorbarbu: "Jdlrobson, if you took a look at the .hogan file that I modified, you would see that there are only these two elements so there is no need" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [08:54:18] 10Wikimedia-Site-Requests: Throttle exception for University of Haifa event on 2016-01-12 - https://phabricator.wikimedia.org/T123161#1922583 (10eranroz) 3NEW [09:03:45] (03CR) 10Ricordisamoa: "Unprecedented link to Wikipedia in en.json!!!!!1" [core] - 10https://gerrit.wikimedia.org/r/261776 (owner: 10Gergő Tisza) [09:03:46] (03CR) 10Ricordisamoa: "Unprecedented link to Wikipedia in en.json!!!!!1" [core] - 10https://gerrit.wikimedia.org/r/261776 (owner: 10Gergő Tisza) [09:05:56] (03CR) 10Nemo bis: [C: 031] "Seems sane, didn't test" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [09:05:57] (03CR) 10Nemo bis: [C: 031] "Seems sane, didn't test" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [09:19:23] Hi everyone! [09:22:00] (03CR) 10TTO: "I think Jon is suggesting that you be less specific: use "input" instead of "input[type=text]"." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [09:22:00] (03CR) 10TTO: "I think Jon is suggesting that you be less specific: use "input" instead of "input[type=text]"." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [09:26:19] (03PS5) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:26:19] (03PS5) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:28:01] (03CR) 10Ricordisamoa: [C: 04-1] "PS5 is rebase only" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 (owner: 10Ricordisamoa) [09:28:02] (03CR) 10Ricordisamoa: [C: 04-1] "PS5 is rebase only" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 (owner: 10Ricordisamoa) [09:33:55] (03PS6) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:33:55] (03PS6) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:38:05] (03PS7) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror, jQCloud and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:38:05] (03PS7) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror, jQCloud and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:44:18] (03PS8) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror, jQCloud and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:44:18] (03PS8) 10Ricordisamoa: Load jQuery, Bootstrap, CodeMirror, jQCloud and vis.js from cdnjs at Tool Labs [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 [09:48:36] (03CR) 10Ricordisamoa: [C: 04-1] "PS8 uses the correct version of Bootstrap from CDN (it had been updated in the meantime)" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 (owner: 10Ricordisamoa) [09:48:37] (03CR) 10Ricordisamoa: [C: 04-1] "PS8 uses the correct version of Bootstrap from CDN (it had been updated in the meantime)" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/250045 (owner: 10Ricordisamoa) [09:52:01] 10WikiCon-Francophone-2016: Recherche d'un local pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T118962#1922591 (10Psychoslave) Suite aux demandes par mél, j’ai relayé l’information à Rodrigue Galani pour évaluer les possibilités de faire ça sur Strasbourg. [09:53:59] hi Georggi [10:15:15] hi Nemo_bis [10:22:08] Reedy: I've pushed changes to this, and Sumit has given me a +1 here, so can we merge this? https://gerrit.wikimedia.org/r/#/c/263153/ [10:23:18] tto: I've pushed changes to this, and Sumit has given me a +1 here, so can we merge this? https://gerrit.wikimedia.org/r/#/c/263153/ [10:24:10] ananayarora: Is this for GCI? If so, best to wait for your mentor. (Unless Sumit is your mentor) [10:25:02] tto: Sumit is my mentor, and he has given me a +1. But I guess this needs someone else's approval too, so that this can be merged with the main repository. [10:25:04] :) [10:29:18] (03CR) 10TTO: [C: 032] importImages.php: Run input file names through UTF8 normalization [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [10:29:18] (03CR) 10TTO: [C: 032] importImages.php: Run input file names through UTF8 normalization [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [10:29:34] Double Grrrit! [10:36:21] (03Merged) 10jenkins-bot: importImages.php: Run input file names through UTF8 normalization [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [10:36:21] (03Merged) 10jenkins-bot: importImages.php: Run input file names through UTF8 normalization [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) (owner: 10Ananay) [10:36:38] tto: Thank You! ^_^ [10:36:47] tto: Can you approve the GCI task too? [10:37:05] ananayarora, link me to it? [10:37:25] tto: https://codein.withgoogle.com/dashboard/task-instances/6265607200702464/?sp-page=1 [10:37:27] importImages.php does not run input file names through UTF8 normalization functions || 3 days || Code, QA || Wikimedia [10:37:49] Done :) [10:38:18] tto: Thank You! :D [10:39:22] 10MediaWiki-Maintenance-scripts, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: importImages.php does not run input file names through UTF8 normalization functions - https://phabricator.wikimedia.org/T78060#1922617 (10ananayarora) a:3ananayarora [10:39:30] 10MediaWiki-Maintenance-scripts, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: importImages.php does not run input file names through UTF8 normalization functions - https://phabricator.wikimedia.org/T78060#1922618 (10ananayarora) 5Open>3Resolved [10:39:43] (03CR) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.5.1 (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262883 (owner: 10Paladox) [10:39:43] (03CR) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.5.1 (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262883 (owner: 10Paladox) [10:40:54] 10MediaWiki-Special-pages, 10Wikimedia-Interwiki-links: Special pages should link to all languages in a project. - https://phabricator.wikimedia.org/T123063#1922619 (10matej_suchanek) [10:41:23] 10MediaWiki-Special-pages, 10Wikimedia-Interwiki-links: Special pages should link to all languages in a project. - https://phabricator.wikimedia.org/T123063#1920249 (10matej_suchanek) This would resolve {T102888}. [10:42:47] Hi, I'm working on this: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Centralauth-login-progress/en [10:44:02] In the extension CentralAuth, in CentralAuthHooks, I need help finding a variable which stores the number of wikis [10:52:26] (03PS1) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [10:52:26] (03PS1) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [10:53:03] (03PS2) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [10:53:03] (03PS2) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [11:01:16] (03PS5) 10Victorbarbu: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) [11:01:17] (03PS5) 10Victorbarbu: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) [11:02:26] jdlrobson, hi! sorry for earlier, I didn't understand what you meant [11:02:32] I uploaded a new patch [11:07:50] (03PS30) 10Physikerwelt: Implement datatype 'Math' for Wikidata [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [11:07:51] (03PS30) 10Physikerwelt: Implement datatype 'Math' for Wikidata [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [11:10:58] heh we still have the grrrit-wm clone [11:14:34] 10MediaWiki-extensions-CentralAuth, 7I18n, 5Patch-For-Review: Add PLURAL support to some messages - https://phabricator.wikimedia.org/T111096#1922631 (10Nemo_bis) a:3Pranavmk98 [11:14:59] s/clone/twin/ [11:18:03] (03CR) 10Nemo bis: [C: 04-1] "You need numParams() https://www.mediawiki.org/wiki/Manual:Messages_API#Notes_about_gender.2C_grammar.2C_plural" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [11:18:03] (03CR) 10Nemo bis: [C: 04-1] "You need numParams() https://www.mediawiki.org/wiki/Manual:Messages_API#Notes_about_gender.2C_grammar.2C_plural" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [11:18:48] (03CR) 10Nemo bis: "As you're no longer working on this, please file a bug and abandon the changeset" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [11:18:48] (03CR) 10Nemo bis: "As you're no longer working on this, please file a bug and abandon the changeset" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [11:21:30] 10MediaWiki-extensions-OpenStackManager: Pop-up notification when deleting an instance contains literal "$2" - https://phabricator.wikimedia.org/T123162#1922632 (10scfc) 3NEW [11:27:30] 6Mobile-Apps: Mobile app does not use the usual markup to link to new talk page sections - https://phabricator.wikimedia.org/T123164#1922648 (10nyuszika7h) 3NEW [11:30:33] 6Mobile-Apps: Mobile app does not use the usual markup to link to new talk page sections - https://phabricator.wikimedia.org/T123164#1922655 (10nyuszika7h) Actually, I'm not even sure how people are creating new sections other than by editing the last one. I can't see an option, but I've seen the same edit summa... [11:34:25] 10MobileFrontend: Mobile site does not use the usual markup to link to new talk page sections - https://phabricator.wikimedia.org/T123164#1922657 (10nyuszika7h) [11:36:11] 10MobileFrontend: Mobile site does not use the usual markup to link to new talk page sections - https://phabricator.wikimedia.org/T123164#1922648 (10nyuszika7h) [11:39:58] (03PS3) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [11:39:58] (03PS3) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [11:44:01] 4(no projects): Fix "Exif-" Metadata - https://phabricator.wikimedia.org/T123165#1922662 (10Pranavmk98) 3NEW [11:44:03] 10MobileFrontend: Mobile site does not use the usual markup to link to new talk page sections - https://phabricator.wikimedia.org/T123164#1922668 (10nyuszika7h) [11:44:50] (03Abandoned) 10PranavK: [WIP] Add PLURAL support to exif-pdf-pagesize [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [11:44:50] (03Abandoned) 10PranavK: [WIP] Add PLURAL support to exif-pdf-pagesize [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [11:54:32] (03CR) 10Nemo bis: [C: 04-1] Add PLURAL support to some messages (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [11:54:33] (03CR) 10Nemo bis: [C: 04-1] Add PLURAL support to some messages (033 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [12:07:35] (03CR) 10PranavK: Add PLURAL support to some messages (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [12:07:35] (03CR) 10PranavK: Add PLURAL support to some messages (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [12:12:29] jdlrobson, could you please check my patch? [12:24:48] 4(no projects): Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922672 (10mwjames) 3NEW [12:26:34] (03PS1) 10IoannisKydonis: Inserted wfMessage("Parentheses"); Change-Id: I13798e5eed58aa650306ba3e3202f90016ca3113 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 [12:26:34] (03PS1) 10IoannisKydonis: Inserted wfMessage("Parentheses"); Change-Id: I13798e5eed58aa650306ba3e3202f90016ca3113 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 [12:27:39] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922678 (10TTO) [12:38:18] (03CR) 10Physikerwelt: [C: 04-1] Implement datatype 'Math' for Wikidata (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [12:38:19] (03CR) 10Physikerwelt: [C: 04-1] Implement datatype 'Math' for Wikidata (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [12:52:30] (03PS2) 10Nemo bis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [12:52:30] (03PS2) 10Nemo bis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [12:54:22] (03CR) 10Nemo bis: [C: 04-1] "No, this is not how it works. The current message *content* needs to be passed as argument to the message "parentheses", in the point wher" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [12:54:22] (03CR) 10Nemo bis: [C: 04-1] "No, this is not how it works. The current message *content* needs to be passed as argument to the message "parentheses", in the point wher" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [12:54:51] (03CR) 10jenkins-bot: [V: 04-1] Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [12:54:52] (03CR) 10jenkins-bot: [V: 04-1] Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263167 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [12:57:20] 10MediaWiki-File-management, 10MediaWiki-extensions-PdfHandler, 6Commons, 6Multimedia, 7I18n: Add PLURAL support to exif-pdf-pagesize - https://phabricator.wikimedia.org/T123165#1922684 (10Nemo_bis) p:5Triage>3Normal [12:57:35] (03CR) 10Physikerwelt: Implement datatype 'Math' for Wikidata (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [12:57:35] (03CR) 10Physikerwelt: Implement datatype 'Math' for Wikidata (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [12:59:24] (03PS4) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [13:01:07] bye bye kubernetes-grrrit-wm1 [13:10:32] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922692 (10TTO) Works for me on REL_1.26 from git: ``` $ php maintenance/importDump.php --dry-run < mwjamesdump.xml Done! You might want to run rebuildrecen... [13:11:27] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922693 (10TTO) >>! In T123166#1922692, @TTO wrote: > Probably one of the Property pages and a Wikibase extension, I'd be inclined to guess. Sorry, to me Pr... [13:15:50] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922696 (10TTO) Also which import options were you using? Paste the command line if by command line. [13:26:21] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922697 (10mwjames) Turning on Xdebug reports: ``` 3 0.9202 2743176 MediaWiki->main( ) ..\MediaWiki.php:476 4 1.1621 3166096 MediaWiki->performRequest( ) ..... [13:35:21] (03PS1) 10Georggi199: Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) [13:35:21] (03PS1) 10Georggi199: Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) [13:38:09] (03CR) 10Nemo bis: [C: 04-1] "Did you forget to commit the JSON files?" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [13:38:09] (03CR) 10Nemo bis: [C: 04-1] "Did you forget to commit the JSON files?" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [13:38:11] (03PS2) 10Georggi199: Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) [13:38:11] (03PS2) 10Georggi199: Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) [13:43:22] (03CR) 10jenkins-bot: [V: 04-1] Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) (owner: 10Georggi199) [14:04:12] (03PS5) 10PranavK: Add PLURAL support to some messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) [14:04:48] (03CR) 10PranavK: "Yeah, I forgot the JSONs :P" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [14:06:57] (03CR) 10PranavK: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/263166 (https://phabricator.wikimedia.org/T111096) (owner: 10PranavK) [14:13:25] (03PS1) 10IoannisKydonis: Added wfMessage('parentheses'). [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 [14:35:42] (03PS1) 10Paladox: Add to getExtraAutoloaderPaths extractInfo [core] - 10https://gerrit.wikimedia.org/r/263171 [14:45:05] (03CR) 10Florianschmidtwelzow: [C: 04-1] "???" [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [14:45:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [14:46:07] 10MediaWiki-extensions-WikiLexicalData-or-OmegaWiki: Notice: Undefined offset: 606 in /var/www/ow/extensions/WikiLexicalData/OmegaWiki/OmegaWikiRecordSets.php on line 837 - https://phabricator.wikimedia.org/T123168#1922715 (10Purodha) 3NEW [14:48:09] legoktm: ping :) [14:48:24] (03CR) 10Florianschmidtwelzow: ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [14:53:55] (03PS3) 10Jack Phoenix: Added a config variable $wgWhosOnlineTimeout to set the timeout period before WhosOnline decides a user has gone offline. Defaults to the original value of 3600 seconds. [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/259527 (owner: 10Jason.ji) [14:57:24] 10MobileFrontend: ErrorException from line 705 of /data/mediawiki/extensions/MobileFrontend/includes/MobileFrontend.hooks.php: PHP Warning: array_search() expects parameter 2 to be an array or collection - https://phabricator.wikimedia.org/T123169#1922722 (10Florian) 3NEW a:3Florian [14:58:03] (03CR) 10Jack Phoenix: [C: 032] "Thanks for the patch, Jason, and sorry about the delay!" [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/259527 (owner: 10Jason.ji) [14:58:33] (03Merged) 10jenkins-bot: Added a config variable $wgWhosOnlineTimeout to set the timeout period before WhosOnline decides a user has gone offline. Defaults to the original value of 3600 seconds. [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/259527 (owner: 10Jason.ji) [14:59:39] Hi! I am working on a bug in which I need to have this repo https://github.com/wikimedia/mediawiki-tools-codesniffer . It says to create a new a composer.json, is it necessary as I am already having one in my core and can I just add the required to the already existing composer.json . [15:00:25] Yes, you create one in that repo [15:01:14] Reedy, could you please review this? https://gerrit.wikimedia.org/r/#/c/263143/ [15:01:25] Reedy: Won't the already existing one be replaced with that and isn't there any problem with that. [15:01:59] Oh [15:02:06] I see.. [15:02:33] (03PS1) 10Florianschmidtwelzow: Fix undefined index error, when WikidataPageBanner isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263172 (https://phabricator.wikimedia.org/T123169) [15:02:41] haritha_: sorry. Yes, you can just add the necessery lines to your existing composer.json [15:02:57] ok [15:06:46] (03PS6) 10Florianschmidtwelzow: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [15:06:54] (03CR) 10Florianschmidtwelzow: [C: 032] Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [15:07:08] 7Design, 10MobileFrontend, 3Google-Code-In-2015, 5Patch-For-Review: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1922733 (10Florian) 5Open>3Resolved [15:12:35] (03Merged) 10jenkins-bot: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [15:15:20] (03CR) 10Paladox: "Woops sorry I only relised that when I was looking through the code. It dosent seem to be working. Please see https://gerrit.wikimedia.org" [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:24:44] (03PS1) 10Florianschmidtwelzow: Post-document hook AfterBuildFeedLinks [core] - 10https://gerrit.wikimedia.org/r/263173 [15:25:33] Reedy: I, by any chance, ask you to take a look at ^ and merge it? It's a documentation change only :) [15:29:34] (03CR) 10Florianschmidtwelzow: "The test results doesn't look like as if composer's autoloader wasn't loaded. How do you think it is the problem? I'm pretty sure, the fea" [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:32:30] (03CR) 10Florianschmidtwelzow: "Nope, I checked it, the loading of the autoloader works fine, so please provide a better commit message, why you need this change, and esp" [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:32:40] (03CR) 10Brian Wolff: [C: 031] "Im travelling and cant test this, but the code looks correct." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [15:33:36] (03CR) 10Florianschmidtwelzow: "Follow up: I9080a150354b978098b8bf4e279f26fdc2ac7c8e" [core] - 10https://gerrit.wikimedia.org/r/260060 (https://phabricator.wikimedia.org/T121774) (owner: 10Florianschmidtwelzow) [15:35:01] (03PS2) 10Paladox: Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 [15:37:22] (03CR) 10Paladox: "Oh. But why is https://gerrit.wikimedia.org/r/#/c/263008/ breaking since looking through the main php file it shows that autoloading is do" [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:37:37] (03PS3) 10Mhutti1: Fixed verification-error due to incorrect timeout handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) [15:38:13] (03CR) 10jenkins-bot: [V: 04-1] Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:39:09] (03CR) 10Mhutti1: "Removed extra redundant code from WikiChecks.php as it overrides a global variable and isn't used." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [15:40:32] 10MediaWiki-File-management, 10MediaWiki-extensions-PdfHandler, 6Commons, 6Multimedia, 7I18n: Add PLURAL support to exif-pdf-pagesize - https://phabricator.wikimedia.org/T123165#1922736 (10Bawolff) The problem is, that the metadata handler takes an array of message key for name of metadata field => expan... [15:41:05] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922738 (10mwjames) `userCan` hook is activated and returns for one imported article a false hence `$title = $titleAndForeignTitle[0];` containing a NULL ins... [15:41:24] (03PS3) 10Paladox: Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 [15:44:30] 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Regression: [Bug] Recent changes pages doesn't have anymore the interlingual wikilinks on the sidebar on some projects - https://phabricator.wikimedia.org/T102888#1922739 (10Aklapper) [15:44:54] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Show interlanguage links on associated talk pages too - https://phabricator.wikimedia.org/T30604#1922742 (10Aklapper) [15:45:07] 10MediaWiki-Special-pages, 10Wikimedia-Interwiki-links: Special pages should link to all languages in a project. - https://phabricator.wikimedia.org/T123063#1922747 (10Aklapper) p:5Triage>3Low [15:45:12] (03CR) 10jenkins-bot: [V: 04-1] Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:46:00] (03PS4) 10Paladox: Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 [15:46:55] (03PS5) 10Paladox: Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 [15:47:16] 10Adminbot: Test - https://phabricator.wikimedia.org/T123158#1922750 (10Aklapper) 5Open>3Invalid @RealEWiki: This is a production database used by the Wikimedia community. It is not a test system or something to play with. Please use http://phab-01.wmflabs.org/ if you want to test things. If you abuse phabri... [15:48:36] 10MediaWiki-extensions-NSFileRepo, 7I18n: [[MediaWiki:Nsfilerepo-upload-target/en]] i18n issue - https://phabricator.wikimedia.org/T123157#1922755 (10Aklapper) [15:48:43] (03CR) 10Florianschmidtwelzow: "I don't understand what you mean in your last sentence." [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:48:54] 10MediaWiki-extensions-NSFileRepo, 7Easy: [[MediaWiki:Nsfilerepo-upload-target/en]]: "Namspace" typo - https://phabricator.wikimedia.org/T123157#1922757 (10Aklapper) [15:49:08] 10MediaWiki-extensions-NSFileRepo, 7Easy: [[MediaWiki:Nsfilerepo-upload-target/en]]: "Namspace" typo - https://phabricator.wikimedia.org/T123157#1922526 (10Aklapper) I do not see a translation problem here, just a typo? [15:50:39] (03CR) 10jenkins-bot: [V: 04-1] Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:50:47] (03CR) 10Paladox: "Oh. Ok." [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:52:49] (03CR) 10Paladox: "But I think the problem is because it is merged into the core mediawiki composer file meaning it isent done in this extension file. So may" [core] - 10https://gerrit.wikimedia.org/r/263171 (owner: 10Paladox) [15:56:41] (03PS6) 10Paladox: Fix composer autoload autoloading not working [core] - 10https://gerrit.wikimedia.org/r/263171 [16:00:30] (03CR) 10Kelson: [C: 031] "I have reviewed the code and it looks good to me. I have also tested it (server side) with Mhutti1 MW instance and it seems to work perfec" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [16:04:20] (03CR) 10Reedy: [C: 04-1] Post-document hook AfterBuildFeedLinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263173 (owner: 10Florianschmidtwelzow) [16:11:42] (03CR) 10Brian Wolff: [C: 032] Fixed verification-error due to incorrect timeout handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [16:13:09] (03CR) 10Brian Wolff: "1+1+1 = 2!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [16:15:35] (03Merged) 10jenkins-bot: Fixed verification-error due to incorrect timeout handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) (owner: 10Mhutti1) [16:20:26] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, and 2 others: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1922769 (10Mhutti1) 5Open>3Resolved [16:21:57] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#1922771 (10Kelson) Should we not close that task because T119053 is fixed. It sounds to me to be a duplicate of T119053. [16:23:33] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, and 2 others: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1922775 (10Mhutti1) [16:23:37] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#1922773 (10Mhutti1) 5Open>3Resolved a:3Mhutti1 [16:24:01] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#1922776 (10Nemo_bis) [16:24:05] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, and 2 others: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1922777 (10Nemo_bis) [16:30:30] 10MediaWiki-extension-requests, 6Commons, 10Internet-Archive, 6Wikisource: Google Books > Internet Archive > Commons upload cycle - https://phabricator.wikimedia.org/T59813#1922779 (10jayantanth) BUB is back, Thanks Rohit. [16:39:54] (03CR) 10Reedy: "Plus the many qunit failures..." [core] - 10https://gerrit.wikimedia.org/r/262892 (https://phabricator.wikimedia.org/T123033) (owner: 10Gerrit Patch Uploader) [16:46:23] (03PS2) 10Florianschmidtwelzow: Post-document hook AfterBuildFeedLinks [core] - 10https://gerrit.wikimedia.org/r/263173 [16:46:27] (03CR) 10Florianschmidtwelzow: Post-document hook AfterBuildFeedLinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263173 (owner: 10Florianschmidtwelzow) [17:01:56] 10Datasets-General-or-Unknown, 5Patch-For-Review: Automate translation updates for DCAT-AP - https://phabricator.wikimedia.org/T122975#1922792 (10Nikerabbit) I think so. This is the first time we are doing i18n updates to ops repo, so there might be things to sort out how that is done. [17:03:08] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 3Wikidata-Sprint-2015-12-01: [Task] Make JS view code independent of ordering and grouping of statements in HTML - https://phabricator.wikimedia.org/T119946#1922793 (10matej_suchanek) [17:20:19] (03PS17) 10Paladox: Add require and require_once support in extension registration [core] - 10https://gerrit.wikimedia.org/r/209549 (https://phabricator.wikimedia.org/T98181) [17:27:46] (03CR) 10Reedy: [C: 032] Post-document hook AfterBuildFeedLinks [core] - 10https://gerrit.wikimedia.org/r/263173 (owner: 10Florianschmidtwelzow) [17:28:39] (03PS18) 10Paladox: Add require and require_once support in extension registration [core] - 10https://gerrit.wikimedia.org/r/209549 (https://phabricator.wikimedia.org/T98181) [17:28:57] (03PS19) 10Paladox: Add require and require_once support in extension registration [core] - 10https://gerrit.wikimedia.org/r/209549 (https://phabricator.wikimedia.org/T98181) [17:30:34] 10MediaWiki-extensions-LanguageSelector: languages stuck in sidebar - https://phabricator.wikimedia.org/T123171#1922799 (10jeblad) 3NEW [17:31:49] 10MediaWiki-extensions-LanguageSelector: Languages stuck in sidebar - https://phabricator.wikimedia.org/T123171#1922806 (10jeblad) [17:32:26] (03CR) 10Paladox: "@Florianschmidtwelzow please could you review or @Legoktm please." [core] - 10https://gerrit.wikimedia.org/r/209549 (https://phabricator.wikimedia.org/T98181) (owner: 10Paladox) [17:33:15] (03Merged) 10jenkins-bot: Post-document hook AfterBuildFeedLinks [core] - 10https://gerrit.wikimedia.org/r/263173 (owner: 10Florianschmidtwelzow) [17:34:32] (03PS20) 10Paladox: Add require and require_once support in extension registration [core] - 10https://gerrit.wikimedia.org/r/209549 (https://phabricator.wikimedia.org/T98181) [17:45:10] 10MediaWiki-Configuration: Impossible to override an array-valued global created by extension registration - https://phabricator.wikimedia.org/T121378#1922812 (10Paladox) Could they use array_merge. "_merge_strategy": "array_merge" [17:52:31] (03PS1) 10Paladox: Fix when no merge strategy is used [core] - 10https://gerrit.wikimedia.org/r/263177 [17:53:34] (03PS2) 10Paladox: Fix when no merge strategy is used [core] - 10https://gerrit.wikimedia.org/r/263177 (https://phabricator.wikimedia.org/T121378) [17:58:06] (03CR) 10jenkins-bot: [V: 04-1] Fix when no merge strategy is used [core] - 10https://gerrit.wikimedia.org/r/263177 (https://phabricator.wikimedia.org/T121378) (owner: 10Paladox) [17:59:29] (03PS1) 10Paladox: Add missing break statement [core] - 10https://gerrit.wikimedia.org/r/263178 [18:21:23] 10MediaWiki-Page-editing: Live preview does not display map (from Mapframe template) on English wikivoyage - https://phabricator.wikimedia.org/T123061#1922820 (10phabyogi) Thanks @Aklapper and others here! Will discuss this on local wiki and request there to fix the same. [18:25:19] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1922826 (10Paladox) I diged further into this and see that even though GroupPermissions is array_plus_2d it wont because it only loads the like "GroupPermission... [18:26:24] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1922827 (10Paladox) [18:26:29] 10MediaWiki-Configuration: Extension registration: GroupPermissions seems to only accept one sub-parameter - https://phabricator.wikimedia.org/T98347#1265235 (10Paladox) https://github.com/wikimedia/mediawiki/blob/e8a97808751526961a6e328b95cd221989a3241a/includes/GlobalFunctions.php#L3852 [18:31:33] (03CR) 10Florianschmidtwelzow: [C: 04-2] "Hmm, I'm not sure, where my -2 is, but the implementation hasn't changed, so it still applies." [core] - 10https://gerrit.wikimedia.org/r/209549 (https://phabricator.wikimedia.org/T98181) (owner: 10Paladox) [18:32:05] hmm [18:38:09] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Templates that have unnamed parameters and don't have TemplateData are hard to add in VisualEditor - https://phabricator.wikimedia.org/T119362#1922832 (10Krenair) [18:46:04] (03PS1) 10Paladox: Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 [18:47:40] (03PS2) 10Paladox: Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) [18:48:07] (03CR) 10Paladox: "I tested this and it does fix the problem with group permission for me." [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [18:51:09] (03PS1) 10Paladox: Add 'array' to merge strategy [core] - 10https://gerrit.wikimedia.org/r/263181 [18:52:44] (03CR) 10jenkins-bot: [V: 04-1] Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [18:54:20] 10MediaWiki-Configuration, 5Patch-For-Review: Add require file support in extension registration - https://phabricator.wikimedia.org/T98181#1922838 (10Florian) @Nikerabbit: Thanks for pointing to a specific use case :) If I understand the problem right, you provide a global function (`wfAddNamespace`) in your... [18:59:17] (03CR) 10Paladox: "I'm not sure why it is erroring out. Please could I help to fix it." [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [19:00:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add missing break statement (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263178 (owner: 10Paladox) [19:01:29] legoktm, hi! are you there? :) [19:01:30] (03Abandoned) 10Paladox: Add missing break statement [core] - 10https://gerrit.wikimedia.org/r/263178 (owner: 10Paladox) [19:07:42] (03CR) 10Florianschmidtwelzow: "If I understand the test correctly, it's very good, that it fails. The test checks, if a value, which is set in LocalSettings.php already " [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [19:09:18] victorbarbu_: maybe someone else can help you? :) [19:09:59] Hi, Florian :) [19:10:01] look at this [19:10:02] https://3v4l.org/cfCWY [19:10:16] is it correct usage of function_exists() to check if a function is global? [19:11:17] victorbarbu_: line 14 has a typo [19:11:58] https://3v4l.org/ZFBOh [19:12:00] victorbarbu_: if a function is _gloabl_? What do you mean with this? :) [19:12:17] but it's not a static function anyway [19:12:36] well, then how can I find out if a function is defined in the global scope? [19:12:37] method_exists( 'ClassName', 'functionName' ) [19:12:43] I'm wondering, what you want to check, in fact it doesn't really matter, if a function is global :) [19:12:53] victorbarbu_: why you want to check that? :) [19:13:02] https://phabricator.wikimedia.org/T122952 [19:13:45] victorbarbu_: hmm, in this case you even don't know the global functions name, right? ;) [19:13:58] (03CR) 10Paladox: "Oh." [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [19:14:00] sorry? [19:14:50] The script should check, if there are any global functions in the php entry point right? So your check wouldn't be, if function "xyz" is global, because you don't know, if there even is a global function named "xyz" :) [19:15:18] well [19:15:21] do you can't check, if a function exists, because you don't know the names of the global functions in the entry point [19:15:32] I tried to put that in handleHooks [19:15:39] see line 212 of that file [19:15:56] I think those are the only functions that should be taken into account [19:16:30] hmm? [19:16:44] I think you can't know, what functions are defined in an entry point? [19:18:00] (03CR) 10Paladox: "Maybe the reason group permission doesn't work properly is because if it checks local settings.php file. If it isent set there then it won" [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [19:18:20] I guess if it doesn't have a class qualifier and :: you can presume it's supposed to be global [19:18:21] have you looked at the file? [19:19:11] the file? [19:19:13] Maybe I misinterpret the task: Is it about _any_ global function _defined_ in the php entry point, or only about global functions _used_ in ExtensionFunctions? [19:19:16] 10MediaWiki-Configuration, 7Easy, 3Google-Code-In-2015: convertExtensionToRegistration.php script should die on global functions (like it does for closures) - https://phabricator.wikimedia.org/T122952#1922841 (10Victorbarbu) a:3Victorbarbu I am working on it! [19:19:37] FlorianSW: It should be both [19:19:44] (I interpret it as the first one, that an entry point can not be converted if a global function is defined) [19:19:51] Reedy: ^ :) [19:20:24] and for that, you can't know the name of the global functions defined in the entry point, so a check can't be done easily (without a name.. ;)) [19:20:26] foreach ( $value as $func ) { [19:20:27] if ( $func instanceof Closure ) { [19:20:27] $this->error( "Error: Closures cannot be converted to JSON. " . [19:20:27] "Please move your extension function somewhere else.", 1 [19:20:27] ); [19:20:27] but do those have to be converted to json? [19:20:28] } [19:20:30] } [19:20:38] Reedy: please use a pastebin :P :D [19:20:39] FlorianSW: That's done for both extensionfunctions and for hooks [19:21:07] Reedy, isn't that taken from handleHooks method? [19:21:08] That's what I see now, thats because I asked what the task wants :) [19:21:20] handleHooks and handleExtensionFunctions [19:21:25] But the same fix wants applying to both [19:21:26] oh [19:21:43] so then, I think it's the right way to go with function_exists [19:21:43] They should be static functions [19:21:57] I tested it for static functions as well [19:22:17] I think it sounds sane [19:22:31] huh? [19:22:33] function_exists() is only used for global functions [19:22:43] method_exists() for class functions [19:22:46] yeah [19:22:50] that's what I am saying [19:22:51] so you talk about usages of global functions inside extensionfunctions and hooks, yes? :D [19:23:00] Yes [19:23:01] yes [19:23:12] This sounds like something that could be proved by a unit test [19:23:22] but that's not a big deal [19:23:25] Jsut comment it well :) [19:23:39] I tested it in 3v4l [19:23:44] "jsut"? [19:23:50] just [19:23:51] typo [19:23:55] oh [19:23:56] sorry [19:23:59] 10MediaWiki-Configuration, 7Easy, 3Google-Code-In-2015: convertExtensionToRegistration.php script should die on global functions (like it does for closures) - https://phabricator.wikimedia.org/T122952#1922843 (10Florian) [19:24:22] I was free and clarified that (for me) :) Then I completly agree with Reedy :P [19:24:45] It's a shame there's not a class to identify globalfunctions like there is closures [19:24:53] yeah [19:25:03] The other way would be some more advance reflection [19:25:24] but meh [19:25:30] victorbarbu_: Go with that way :) [19:25:43] * FlorianSW loves php :D [19:26:46] (03CR) 10TheDJ: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (owner: 10TheDJ) [19:27:13] You could do strpos for :: to see if there's a static function on a class [19:27:23] But feels even hackier [19:29:54] checking for :: would be pretty hacky, but it would also work... [19:30:08] Heh [19:30:16] (03PS12) 10Victorbarbu: Provide short URL to file description page in imageinfo API [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) [19:30:18] (03PS1) 10Victorbarbu: Make convertExtensionToRegistration.php die on global functions [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) [19:30:29] Could have it as some sort of sanity check [19:30:49] https://gerrit.wikimedia.org/r/263182 [19:30:49] Unnecessary dependencies!! [19:30:54] review, please? :D [19:32:00] why does it depend on my not-merged patch? [19:32:51] Because you didn't git [19:33:05] git what? [19:33:08] You made your new patch ontop of it [19:33:31] Rather than a new branch, or resetting your working copy [19:34:02] can I move this one commit to a separate branch? [19:34:45] * victorbarbu_ feels git like a complete mystery [19:34:47] Yeah [19:34:52] yep [19:34:56] Cherry pick [19:35:15] Reedy: you can delete the commit, too, but cherry pick is easier :D [19:35:36] Gerrit will give you commands for the cherry pick [19:35:52] won't this break my local repo? [19:36:00] if I cherry pick on gerrit? [19:36:02] Why would it? [19:36:04] no, why? [19:36:06] No [19:36:09] You do it locally [19:36:22] Gerrit gives you the crafted command to run [19:36:31] some copy-paste things please? I have no idea [19:36:39] Exactly [19:37:15] git fetch https://gerrit.wikimedia.org/r/mediawiki/core refs/changes/15/262415/12 && git cherry-pick FETCH_HEAD [19:37:16] victorbarbu_: what do you want to do? Cherry picking can be done in gerrit directly, rewriting the git history is easier in your local checkout :) [19:37:29] Noting I'm not logged in [19:37:35] I don't care, whichever one is easier [19:37:45] He wants to remove the dependency [19:37:49] gerrit says "error, branch T122952 does not exists" [19:37:58] I know, that's possible in both ways, Reedy :) [19:38:12] Right [19:39:02] victorbarbu_: what command did you typed? I think something like git checkout T122952? [19:39:14] no, I went to gerrit [19:39:23] and hit the "cherry pick" button [19:39:24] :)) [19:39:55] ok, then I think master is the correct one :) (I must say, that I never cherry picked to master using the gerrit GUI) [19:40:11] I have... From a branch [19:40:23] I don't think it'll do master to master... Will it? [19:40:34] interesting question, I don't know :/ [19:40:58] Reset working copy [19:41:05] (03PS2) 10Victorbarbu: Make convertExtensionToRegistration.php die on global functions [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) [19:41:08] Copy cherry pick fro. Gerrit [19:41:15] Git review [19:41:18] Profit [19:41:38] victorbarbu_: what did you did now? It seems it worked :P [19:41:41] Looks like he did it ;) [19:41:54] I clicked the cherry pick button in gerrit [19:41:59] and typed "master" as branch [19:42:02] :)) [19:42:03] ah cool, good to know :D [19:42:24] Heh [19:42:47] "Fortune favours fools." did you know that? [19:42:48] :)) [19:42:56] you can review it now :) [19:44:43] I hope it's correct, because I will surely get stuck with git things for another commit :)) [19:45:06] Reset your working copy [19:45:24] "git pull --rebase origin master"? [19:46:22] I'm not sure rebasing actually helps get rid of those commits [19:46:31] If in doubt, I use [19:46:56] git reset HEAD~25 --hard [19:47:01] git pull [19:47:14] what is "HEAD~25"? [19:47:41] HEAD without the last 25 commits :) [19:47:41] hmm. [19:47:53] Oh [19:47:57] good to know [19:48:04] but still, I hope this is correct [19:51:26] You should either use branches, and checkout master after you've git reviewed them [19:51:42] Or reset your working copy [19:51:59] If working straight onto master [19:52:10] Otherwise you have these problems [19:52:24] And it gets worse if things don't get reviewed quickly [19:52:36] As gci students, you're getting very quick review [19:52:40] And merge [19:52:56] FlorianSW, could you approve my task as well? [19:54:37] victorbarbu_: why aswell? I haven't merged anything yet :P [19:54:41] Lolol [19:55:02] oh lol [19:55:10] I was looking at the wrong change [19:55:13] sorry [19:55:14] :P [19:55:15] my mistake [19:55:49] * victorbarbu_ made a mistake :D [19:58:04] Part of me is irked by the code duplication [19:58:06] But it's not new [20:00:39] Reedy? [20:00:50] code duplication? more people working on the same thing? [20:02:06] * victorbarbu_ plays agar.io while you guys are (probably) reviewing my patch [20:03:16] (03CR) 10VolkerE: "My comment was saved as a draft, oh Gerrit!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [20:08:20] (03CR) 10TheDJ: "I'm guessing I need wgFFmpegLocation set for this to work." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (owner: 10TheDJ) [20:09:06] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1922855 (10Volker_E) [20:09:29] (03CR) 10Victorbarbu: "Because the specification said I had to align the text with the "back" icon which was in a button with a width of 3.5em and the icon itsel" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [20:15:32] "...we’ll automatically add 3 bonus GB to your account! Your new Dropbox space limit will be -42 GB." ????? [20:16:09] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#1922859 (10Bawolff) There are many timeouts, one will still hit them given a big enough file, but the situation is much improved, so i do think it does make sense to close [20:16:18] (03PS3) 10TheDJ: Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 [20:20:25] (03CR) 10jenkins-bot: [V: 04-1] Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (owner: 10TheDJ) [20:25:58] (03CR) 10Umherirrender: Update mediawiki/mediawiki-codesniffer to 0.5.1 (034 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262883 (owner: 10Paladox) [20:28:29] (03CR) 10Umherirrender: Add missing break statement (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263178 (owner: 10Paladox) [20:31:26] Volker_E [20:31:28] ping [20:31:35] hey victorbarbu_ [20:32:19] victorbarbu_: I have to hurry out of the house in less than 2 mins [20:32:35] have you read my comment? [20:34:14] 10MediaWiki-General-or-Unknown: The real page name of Main page (next of Discussion) is not translated. - https://phabricator.wikimedia.org/T123116#1922890 (10Umherirrender) [20:34:16] 10MediaWiki-Internationalization, 5MW-1.26-release: Main page tab is not translated in 1.26 - https://phabricator.wikimedia.org/T119938#1922891 (10Umherirrender) [20:34:21] https://phabricator.wikimedia.org/T118902 [20:34:29] What do I have to do here? :$ [20:36:42] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922897 (10Umherirrender) Similar T123075 [20:36:53] ananayarora: bad parameters are being passed to a message [20:37:08] Find the place where that is happening and fix it [20:39:25] https://gerrit.wikimedia.org/r/#/c/263182/ [20:39:29] please review it [20:39:32] someone [20:42:11] (03CR) 10Umherirrender: [C: 032] "Underlying issue is tracked as T118205" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263049 (owner: 10Hashar) [20:42:44] (03Merged) 10jenkins-bot: i18n: missing metadata block in aeb-arab [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263049 (owner: 10Hashar) [20:44:58] 10MediaWiki-Parser, 10MediaWiki-extensions-LabeledSectionTransclusion, 10MediaWiki-extensions-ProofreadPage, 7Regression: MediaWiki removes automatically the linebreak before "|-", breaking table on Wikisource - https://phabricator.wikimedia.org/T123174#1922899 (10He7d3r) 3NEW [20:45:12] (03CR) 10Umherirrender: [C: 032] Add jsonlint to 'npm test' [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263047 (owner: 10Hashar) [20:45:44] (03Merged) 10jenkins-bot: Add jsonlint to 'npm test' [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263047 (owner: 10Hashar) [20:49:02] OH-: Got it! :) [20:49:23] MatmaRex_mobile: Are you the same MatmaRex? [20:49:48] (Just wanna clarify it once) [20:50:07] yes. hi :) [20:51:08] (03CR) 10Krinkle: "The caching is important and also avoids extensions from misbehaving. Values may not vary between calls. In general hooks should never fir" [core] - 10https://gerrit.wikimedia.org/r/263006 (owner: 10Jdlrobson) [20:51:11] (03CR) 10Umherirrender: "No forced merge possible in this repo (at least for me), so this patch set is unmergeable (jenkins always say no)" [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/259199 (owner: 10VolkerE) [20:51:26] (03CR) 10Krinkle: [C: 04-1] "See https://gerrit.wikimedia.org/r/263006" [core] - 10https://gerrit.wikimedia.org/r/263147 (owner: 10Jdlrobson) [20:51:52] (03PS1) 10Ladsgroup: Add onOldChangesListRecentChangesLine hook [extensions/ORES] - 10https://gerrit.wikimedia.org/r/263184 (https://phabricator.wikimedia.org/T122535) [20:52:06] ReverseChronologicalPager::getDateCond sets a public variable but doesn't return it, which is kind of contradictory to its name. Should that be changed? [20:52:43] (03CR) 10jenkins-bot: [V: 04-1] Add onOldChangesListRecentChangesLine hook [extensions/ORES] - 10https://gerrit.wikimedia.org/r/263184 (https://phabricator.wikimedia.org/T122535) (owner: 10Ladsgroup) [20:52:47] Another member function of ReverseChronologicalPager sets a variable but does return it [20:55:43] (03CR) 10Krinkle: "Code looks good, but two minor issues:" [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [20:57:07] (03PS2) 10Ladsgroup: Add onOldChangesListRecentChangesLine hook [extensions/ORES] - 10https://gerrit.wikimedia.org/r/263184 (https://phabricator.wikimedia.org/T122535) [20:58:44] (03CR) 10Umherirrender: [C: 032] Update .gitignore [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/241600 (owner: 10Hashar) [20:59:40] (03Merged) 10jenkins-bot: Update .gitignore [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/241600 (owner: 10Hashar) [21:09:43] MatmaRex_mobile: There's a problem here with the task I've claimed [21:09:56] MatmaRex_mobile: Messages mwe-upwiz-error-too-short and mwe-upwiz-error-too-long are reused, sometimes passed wrong parameters <-- this task [21:10:15] mhm? [21:10:26] this file doesn't exist -> /resources/mw.UploadWizardDescription.js [21:11:11] ugh. well, i guess it got renamed [21:11:13] and this file -> /resources/mw.UploadWizardDeed.js doesn't have the same code as shown in the phabricator details [21:11:29] try searching for the messages' names [21:11:46] i wrote that task a while ago, sorry :) [21:12:05] gj MatmaRex_mobile [21:12:06] (03CR) 10Nemo bis: [C: 04-1] "Please amend your original patch instead of creating a new changeset: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (owner: 10IoannisKydonis) [21:12:12] MatmaRex_mobile: Found the description one! It's named uw.DescriptionDetailsWidget.js [21:14:12] yay [21:16:06] MatmaRex_mobile: There are a million i18n JSON files in the i18n folder. Which one to edit? [21:16:09] en.json? [21:16:19] usually yes [21:16:21] and qqq.json [21:16:36] Nemo_bis: Thanks! [21:18:51] Nemo_bis: I can't find the same language error in qqq.json. It's correct over there [21:21:58] ananayarora: right, qqq is message documentation only [21:22:29] MatmaRex_mobile: Here you go! https://gerrit.wikimedia.org/r/#/c/263185/2 [21:25:49] (03CR) 10Legoktm: [C: 04-1] "Minor thing" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) (owner: 10Victorbarbu) [21:33:52] (03PS1) 10UltrasonicNXT: Fix errors with Captcha [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/263186 [21:34:10] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix errors with Captcha [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/263186 (owner: 10UltrasonicNXT) [21:43:32] (03CR) 10Victorbarbu: Make convertExtensionToRegistration.php die on global functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) (owner: 10Victorbarbu) [21:44:33] 10MediaWiki-Page-editing: Live preview does not display map (from Mapframe template) on English wikivoyage - https://phabricator.wikimedia.org/T123061#1922956 (10Fomafix) I integrated the change applied the [[ https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript | coding conventions ]] and fixed... [21:46:46] (03PS3) 10Victorbarbu: Make convertExtensionToRegistration.php die on global functions [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) [21:47:07] (03PS4) 10Victorbarbu: Make convertExtensionToRegistration.php die on global functions [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) [21:47:21] legoktm, please check that out [21:50:14] (03PS5) 10Legoktm: convertExtensionToRegistration.php: die on global functions [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) (owner: 10Victorbarbu) [21:50:21] (03CR) 10Legoktm: [C: 032] "Nice work!" [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) (owner: 10Victorbarbu) [21:53:50] (03PS1) 10IoannisKydonis: Add wfMessage('parentheses'). [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263189 [21:56:08] (03Merged) 10jenkins-bot: convertExtensionToRegistration.php: die on global functions [core] - 10https://gerrit.wikimedia.org/r/263182 (https://phabricator.wikimedia.org/T122952) (owner: 10Victorbarbu) [21:56:13] 10MediaWiki-extensions-ORES, 6RevisionScoringAsAService: [Spike] Investigate building a hook for abuse filter - https://phabricator.wikimedia.org/T123178#1922959 (10Ladsgroup) 3NEW a:3Ladsgroup [21:58:19] (03PS1) 10UltrasonicNXT: Fix some errors [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/263191 [21:58:35] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix some errors [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/263191 (owner: 10UltrasonicNXT) [22:00:01] (03PS2) 10IoannisKydonis: Add wfMessage('parentheses'). [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 [22:02:21] 10MediaWiki-Configuration, 7Easy, 3Google-Code-In-2015, 5MW-1.27-release-notes, and 2 others: convertExtensionToRegistration.php script should die on global functions (like it does for closures) - https://phabricator.wikimedia.org/T122952#1922969 (10Victorbarbu) 5Open>3Resolved [22:02:40] 10MediaWiki-extensions-ExtensionDistributor, 7Easy, 3Google-Code-In-2015: Link to the page of the downloaded extension on Special:ExtensionDistributor - https://phabricator.wikimedia.org/T31661#1922971 (10Victorbarbu) a:3Victorbarbu I am trying to solve this! [22:08:37] tgr: I left you a message on GCI. :) [22:10:29] (03CR) 10Ladsgroup: [C: 031] "I just put it in revscoring test wiki: http://mw-revscoring.wmflabs.org/wiki/Special:Watchlist?days=0&namespace=&action=submit" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/263184 (https://phabricator.wikimedia.org/T122535) (owner: 10Ladsgroup) [22:14:10] (03PS1) 10UltrasonicNXT: Fix errors [extensions/Comments] - 10https://gerrit.wikimedia.org/r/263194 [22:16:09] (03PS2) 10Reedy: API: Flag "user" parameters in various modules as type 'user' [core] - 10https://gerrit.wikimedia.org/r/262414 (https://phabricator.wikimedia.org/T122803) (owner: 10Anomie) [22:16:15] (03CR) 10Reedy: [C: 032] API: Flag "user" parameters in various modules as type 'user' [core] - 10https://gerrit.wikimedia.org/r/262414 (https://phabricator.wikimedia.org/T122803) (owner: 10Anomie) [22:21:57] (03Merged) 10jenkins-bot: API: Flag "user" parameters in various modules as type 'user' [core] - 10https://gerrit.wikimedia.org/r/262414 (https://phabricator.wikimedia.org/T122803) (owner: 10Anomie) [22:22:00] legoktm, could you please clarify the location of the link I have to add? [22:22:11] It is not very clear which page should contain it [22:22:36] victorbarbu_: https://www.mediawiki.org/wiki/Extension:$name [22:22:41] or https://www.mediawiki.org/wiki/Skin:$name [22:23:00] but how is that related to the extension in any matter? [22:23:25] http://localhost:8080/wiki/Special:ExtensionDistributor?extdist_name=$name [22:23:27] so now here? [22:24:01] not* [22:25:07] oh, I see you didn't get what I asked [22:25:18] Where should the link be? [22:25:28] I mean, I don't get what page should contain that link [22:25:35] 10MediaWiki-Export-or-Import: Import.php caused a Catchable fatal error: Argument 1 passed to WikiPage::factory - https://phabricator.wikimedia.org/T123166#1922980 (10TTO) But WikiImporter::processTitle has a check for null, so I'm having a hard time working out why the null is getting through, and why I want to... [22:27:08] 4(no projects): Provide an option for ignoring combining characters when searching - https://phabricator.wikimedia.org/T123179#1922981 (10Suzukaze-c) 3NEW [22:28:46] 4(no projects): Provide an option for ignoring combining characters when searching - https://phabricator.wikimedia.org/T123179#1922987 (10Suzukaze-c) [22:30:02] victorbarbu_: oh, so on the last page [22:30:14] I found it [22:30:16] victorbarbu_: https://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdist_name=AJAXPoll&extdist_version=REL1_26 [22:30:18] how long will be aroung? [22:30:22] around* [22:30:44] I would love to get some review within half an hour if that's ok for you [22:37:53] is there any method to build a link to https://www.mediawiki.org/wiki/Extension: [22:37:59] and for skin, respectively? [22:38:20] [https://www.mediawiki.org/wiki/Extension:$name $name] [22:38:25] yes, I'll be around most likely [22:41:48] (03PS8) 10Gerrit Patch Uploader: Preferences: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) [22:41:50] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [22:42:22] (03PS3) 10Paladox: Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) [22:43:19] (03CR) 10Fomafix: "I changed the session data key. But I do not understand what your second minor issue is." [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [22:45:03] (03PS6) 10Gerrit Patch Uploader: SpecialUserrights: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) [22:45:05] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [22:45:55] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [22:47:07] (03CR) 10jenkins-bot: [V: 04-1] Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [22:48:52] (03PS4) 10Paladox: Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) [22:49:33] (03CR) 10jenkins-bot: [V: 04-1] SpecialUserrights: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [22:53:52] (03CR) 10jenkins-bot: [V: 04-1] Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [22:54:46] (03PS5) 10Paladox: Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) [22:59:38] (03CR) 10jenkins-bot: [V: 04-1] Fix array_plus_2d in extension registration [core] - 10https://gerrit.wikimedia.org/r/263180 (https://phabricator.wikimedia.org/T98347) (owner: 10Paladox) [23:00:33] tgr: So what class is my pageid in? [23:01:56] MtDu_: well, the code is already using the $article object to insert a new page [23:02:02] you'll need to modify that [23:02:38] tgr: Yes. Ok. So is the page id in the page class? [23:02:57] tgr: I'm looking at this. https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html [23:03:40] tgr: I'm just confused where the actual id is that I need to use. [23:04:40] 10WikiGrok: (5) Add UserMerge support to WikiGrok - https://phabricator.wikimedia.org/T97979#1922998 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:42] 10WikiGrok: Consolidate similar config variables - https://phabricator.wikimedia.org/T95956#1923001 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:44] 10WikiGrok: Test the WikiGrok aggregation and pushing code - https://phabricator.wikimedia.org/T95304#1923004 (10Legoktm) 5stalled>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:45] 10WikiGrok: If Project:WikiGrok doesn't exist on repo wiki, edit summary is garbage - https://phabricator.wikimedia.org/T95051#1923007 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:46] 10WikiGrok: Refresh linked pages on rejection - https://phabricator.wikimedia.org/T94873#1923010 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:48] 10WikiGrok: Consider using job queue for submission - https://phabricator.wikimedia.org/T94521#1923013 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:50] 10Gather, 10PageImages, 10WikiGrok: Cropped images generated by PageImages don't always include main subject - https://phabricator.wikimedia.org/T94256#1923019 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:52] 10WikiGrok: Filter submissions by campaign - https://phabricator.wikimedia.org/T94460#1923016 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:04:54] 10WikiGrok: Wikigrok random fires ajax requests in qunit - causes tests to break occasionally - https://phabricator.wikimedia.org/T86776#1923025 (10Legoktm) 5Open>3declined Closing as declined, the WikiGrok extension is no longer maintained and has been archived. [23:05:23] there is mId, but you probably should not touch that, as it's supposed to be in sync with the database [23:05:25] 10Gather, 10PageImages, 10WikiGrok: Cropped images generated by PageImages don't always include main subject - https://phabricator.wikimedia.org/T94256#1923027 (10Legoktm) 5declined>3Open [23:06:02] it's better to add a new property or a new method parameter [23:06:22] (03PS1) 10Victorbarbu: Add link to extension/skin's page in ExtensionDistributor [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/263196 (https://phabricator.wikimedia.org/T31661) [23:06:35] an insertOn method parameter is better I guess [23:06:56] legoktm, [23:06:58] still there? [23:06:59] https://gerrit.wikimedia.org/r/263196 [23:08:09] victorbarbu_: wait I'm sorry, I gave you bad advice. Instead of building the URL manually, you should use Linker::link() [23:08:29] I saw that [23:08:33] but I don't understand [23:08:34] it [23:09:28] 10MediaWiki-Vagrant: Create vagrant role for master-slave DB setup - https://phabricator.wikimedia.org/T93047#1923032 (10Legoktm) https://www.mediawiki.org/wiki/User:Aaron_Schulz/Quick_Vagrant_DB_Replication [23:10:48] Linker::link(Title::newFromText('Extension:' . $name), 'text') [23:10:51] victorbarbu_: ^ [23:11:12] (03PS7) 10Gerrit Patch Uploader: SpecialUserrights: Use session data instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) [23:11:14] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [23:11:16] that will automatically map to https://mediawiki... ? [23:11:40] tgr: What class is insertOn a part of? Or is that SQL? [23:13:45] 10MediaWiki-extensions-Translate: Incomplete setup of translatable pages: FuzzyBot fails to generate /en subpage etc. - https://phabricator.wikimedia.org/T56579#1923035 (10coren) This occurs repeatedly on wikimania2017wiki, which uses language features heavily including translatable templates. [23:15:53] legoktm, that takes me to http://localhost:8080/w/index.php?title=Extension:AJAXPoll&action=edit&redlink=1 for example [23:16:12] victorbarbu_: that's because that page doesn't exist on your local wiki, but it does on mediawiki.org [23:16:21] well [23:16:29] should't it take me to mediawiki.org/... [23:16:30] ? [23:16:37] no [23:16:40] well, [23:16:44] it will take you to the local wiki [23:16:52] that's what I understand though [23:16:55] which unless you're developing something on a test wiki, will be mediawiki.org [23:17:07] oh [23:17:09] ooooh [23:17:10] I get it [23:17:17] uploading a new patch now [23:17:18] tgr: ^ I'm kind of confused. [23:17:32] (03PS3) 10Georggi199: Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) [23:17:50] 10MediaWiki-extensions-Scribunto, 7Tracking: Information can be passed between #invoke's (tracking) - https://phabricator.wikimedia.org/T67258#1923038 (10TomT0m) Hi, this is bugs, I'd like that this was a feature ... Explanation : We use lua and Wikidata to generate datas for example in this page : https://f... [23:17:53] (03PS2) 10Victorbarbu: Add link to extension/skin's page in ExtensionDistributor [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/263196 (https://phabricator.wikimedia.org/T31661) [23:18:15] legoktm, it should be right now [23:21:13] tgr: Is the article::getOldId what I'm suposed to use? [23:21:55] (03CR) 10jenkins-bot: [V: 04-1] Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) (owner: 10Georggi199) [23:23:49] (03PS1) 10Legoktm: Use load_composer_autoloader [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/263197 [23:24:07] 4(no projects): Add possibility to use default MediaWiki URLs on all wikis - https://phabricator.wikimedia.org/T123181#1923040 (10XXN) 3NEW [23:24:10] (03PS4) 10Georggi199: Export: Exporting now includes custom tags [core] - 10https://gerrit.wikimedia.org/r/263168 (https://phabricator.wikimedia.org/T22691) [23:24:37] 4(no projects): Add possibility to use default MediaWiki URLs on all wikis - https://phabricator.wikimedia.org/T123181#1923046 (10XXN) [23:28:06] (03PS1) 10Legoktm: Empty PHP entry point [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/263198 [23:28:08] (03PS1) 10Legoktm: Set load_composer_autoloader: true [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/263199 [23:32:21] legoktm, I have to go to bed in 10 minutes, it's aleady 1:30 here [23:33:11] victorbarbu_: it looks alright, but I won't have time to test it in 10 minutes [23:33:21] victorbarbu_: go to sleep, there will be comments for you in the morning :) [23:33:38] (03CR) 10Florianschmidtwelzow: [C: 032] "Hehe :)" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/263197 (owner: 10Legoktm) [23:33:55] FlorianSW: wanna look at the elastica ones too ^? [23:34:38] (03CR) 10Florianschmidtwelzow: [C: 032] Set load_composer_autoloader: true [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/263199 (owner: 10Legoktm) [23:34:38] ok then [23:34:53] but please, don't reject the task, because I will forget to submit it again [23:34:56] thank you!! [23:35:02] have a nice day, I guess [23:35:07] legoktm: did you forget to commit the extension.json? :D [23:35:18] uhh, no? [23:35:21] FlorianSW: it's already there [23:35:43] 10MediaWiki-extensions-Scribunto, 7Tracking: Information can be passed between #invoke's (tracking) - https://phabricator.wikimedia.org/T67258#1923048 (10Anomie) Parsoid requires that each call to #invoke does not depend on anything else on the page, so it can parse the wikitext piecemeal. [23:35:46] arghh! Sorry :) I thought you wanted to migrate to extension.json, sorry :) [23:36:06] 10MediaWiki-API, 10MediaWiki-Special-pages, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): case sensitivity with IPv6 usernames and &list=usercontribs API - https://phabricator.wikimedia.org/T122803#1923049 (10Anomie) 5Open>3Resolved [23:36:43] tgr: I guess my question, what is the next step to making my code work? Or am I just in the wrong direction? [23:36:47] (03CR) 10Florianschmidtwelzow: [C: 032] Empty PHP entry point [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/263198 (owner: 10Legoktm) [23:37:05] legoktm: do you want to take a look at my comment here: https://gerrit.wikimedia.org/r/#/c/250060/7/includes/registration/VersionChecker.php ? [23:38:29] tgr: Please post a comment on the GCI page. I won't be on IRC for a little bit. [23:38:30] FlorianSW: The special casing of MediaWiki: made me feel icky. [23:38:34] FlorianSW: I need to think about it a bit more. [23:38:57] MtDu: WikiPage::insertOn, it's in the part you highlighted [23:42:00] legoktm: do you mean, that "MediaWiki" should (for an ideal solution) has a prefix, too (like MediaWiki:MediaWiki)? Or the prefix itself, so that an ideal solution would have a require section just for MediaWiki, a require-extensions just for extensions and so on? [23:42:01] (03PS3) 10IoannisKydonis: Add wfMessage('parentheses'). [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 [23:42:13] FlorianSW: I don't knowwwwwwwww [23:42:19] FlorianSW: definitely not the latter. [23:42:20] :P [23:42:27] 10Phabricator-Sprint-Extension: UNRECOVERABLE FATAL ERROR After update - https://phabricator.wikimedia.org/T122451#1923052 (10Luke081515) [23:42:53] ah, that's good, I don't think, that this would be a good solution, too : [23:42:54] :) [23:44:14] (03Merged) 10jenkins-bot: Empty PHP entry point [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/263198 (owner: 10Legoktm) [23:45:46] (03PS44) 10Paladox: Add extension.json, empty PHP entry point [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/208523 (https://phabricator.wikimedia.org/T100425) [23:54:27] (03CR) 10Jack Phoenix: [C: 032] Fix errors [extensions/Comments] - 10https://gerrit.wikimedia.org/r/263194 (owner: 10UltrasonicNXT) [23:55:25] (03Merged) 10jenkins-bot: Fix errors [extensions/Comments] - 10https://gerrit.wikimedia.org/r/263194 (owner: 10UltrasonicNXT)