[00:01:05] 10MediaWiki-Parser: An empty bullet renders in print only - https://phabricator.wikimedia.org/T123093#1921078 (10Krenair) [00:01:06] (03CR) 10Niedzielski: Hygiene: refer to interfaces not implementations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262908 (owner: 10Niedzielski) [00:01:18] (03CR) 10CSteipp: "Thanks! Changes from Zhuyifei1999 and Reedy lgtm, if anyone wants to +2." [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/214092 (owner: 10CSteipp) [00:01:38] Heh [00:02:10] I think I might de-namespace and +2 it [00:03:08] 10Datasets-General-or-Unknown, 10Dumps-Generation: determine hardware needs for replacements for dataset1001, ms1001 - https://phabricator.wikimedia.org/T123094#1921081 (10ArielGlenn) 3NEW a:3ArielGlenn [00:03:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: refer to interfaces not implementations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262908 (owner: 10Niedzielski) [00:12:03] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015, 5Patch-For-Review: MMV only shows every n-th image after closing and reopening - https://phabricator.wikimedia.org/T122785#1921102 (10Tgr) 5Open>3Resolved Thanks Mhutti1! [00:18:03] 7Community-Wishlist-Survey: Reading List - https://phabricator.wikimedia.org/T120756#1921106 (10Jhernandez) As @jdlrobson mentioned, this is what https://www.mediawiki.org/wiki/Extension:Gather does. It is installed on en wiki, he wiki and wikivoyage (maybe somewhere else). You can see it in mobile web beta in... [00:18:15] (03PS1) 10Muehlenhoff: Handle the apache config using dh_apache2 [debian] - 10https://gerrit.wikimedia.org/r/263018 [00:20:17] 10UI-Standardization, 10OOjs-UI, 6Reading-Admin, 7Blocked-on-Editing, and 2 others: Date and time input widgets - https://phabricator.wikimedia.org/T91148#1921108 (10matmarex) Sooo... we now have the two in MediaWiki core. * DateTimeInputWidget by @Anomie: 57342159dab992bcd28d1e8fc4c1ca804bf61962 * DateIn... [00:23:42] 10MediaWiki-Interface, 7Easy, 7JavaScript, 5Patch-For-Review: jQuery.makeCollapsible: Font color of collapsible button cannot be set - https://phabricator.wikimedia.org/T63018#1921111 (10matmarex) Yeah, I'm afraid we can't really do this now. It would make the button not look clickable by default. You can... [00:23:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] "See my comment on the task." [core] - 10https://gerrit.wikimedia.org/r/262937 (https://phabricator.wikimedia.org/T63018) (owner: 10D3r1ck01) [00:24:56] 10TeaHouse: Use ORES to detect good-faith newcomers - https://phabricator.wikimedia.org/T123095#1921113 (10Halfak) 3NEW a:3Halfak [00:25:12] Anyone know if there's any yes/no/don't care type of rule to namespacing tests? [00:26:26] 10TeaHouse: Load Q&A archives from :en:WP:Teahouse into labs elastic search - https://phabricator.wikimedia.org/T123096#1921124 (10Halfak) 3NEW [00:27:34] 6Design-Research, 6Research-and-Data, 10Teahouse: Extend Teahouse retention analysis - https://phabricator.wikimedia.org/T116339#1921132 (10Halfak) [00:29:15] (03CR) 10Krinkle: [C: 04-1] "It may be better to solve this problem by making the method (as used by ResourceLoader) not static. RL is effectively used as a singleton " [core] - 10https://gerrit.wikimedia.org/r/263006 (owner: 10Jdlrobson) [00:29:20] 10Teahouse: Load Q&A archives from :en:WP:Teahouse into labs elastic search - https://phabricator.wikimedia.org/T123096#1921146 (10Halfak) a:3Capt_Swing [00:32:20] 10Teahouse: Convert HostBot into a PAWS bot - https://phabricator.wikimedia.org/T123098#1921153 (10Halfak) 3NEW [00:33:39] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Add way to transclude template or other page in the correct language, e.g. with Special:MyLanguage - https://phabricator.wikimedia.org/T47096#1921161 (10Nemo_bis) [00:36:37] (03CR) 10Reedy: [C: 04-1] "Minor nitpick (and perf issue waiting to happen ;))" (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/214092 (owner: 10CSteipp) [00:38:27] (03PS10) 10Reedy: Allow setting local email/realname from remote wiki [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/214092 (owner: 10CSteipp) [00:39:21] (03CR) 10Reedy: [C: 032] Allow setting local email/realname from remote wiki [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/214092 (owner: 10CSteipp) [00:39:52] (03Merged) 10jenkins-bot: Allow setting local email/realname from remote wiki [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/214092 (owner: 10CSteipp) [00:39:58] 7Documentation: Manual:Skinning on mediawiki.org is not up-to-date when it comes to skin/extension registration in JSON - https://phabricator.wikimedia.org/T123100#1921177 (10matmarex) 3NEW a:3Legoktm [00:41:11] 10MediaWiki-extensions-DeletePagesForGood, 6Security: Confirmation form in "DeletePagesForGood" extension lacks CSRF token - https://phabricator.wikimedia.org/T122540#1921185 (10csteipp) [00:42:33] 10Wikimedia-General-or-Unknown: enWS revert to no differentiation between en/en-gb/en-ca mediawiki namespace messages and language settings - https://phabricator.wikimedia.org/T122712#1921188 (10Billinghurst) Either way, in the /en language wikis, the system should be able to default text that is specific for th... [00:42:58] 6Language-Engineering, 10Wikimedia-General-or-Unknown: enWS revert to no differentiation between en/en-gb/en-ca mediawiki namespace messages and language settings - https://phabricator.wikimedia.org/T122712#1921189 (10Billinghurst) [00:44:58] (03PS11) 10Reedy: Move mwoauth-php lib to Composer, add phpcs [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [00:45:31] (03CR) 10jenkins-bot: [V: 04-1] Move mwoauth-php lib to Composer, add phpcs [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [00:46:25] (03PS12) 10Reedy: Move mwoauth-php lib to Composer, add phpcs [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [00:46:33] (03PS1) 10Muehlenhoff: Remove obsolete preinst [debian] - 10https://gerrit.wikimedia.org/r/263020 [00:46:35] (03PS1) 10Muehlenhoff: Remove stray commemts [debian] - 10https://gerrit.wikimedia.org/r/263021 [00:47:16] (03PS5) 10Reedy: Allow setting a custom callback URL [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248662 (owner: 10Gergő Tisza) [00:48:12] (03CR) 10Reedy: "Abandon in favor of merged https://gerrit.wikimedia.org/r/#/c/214092/ ?" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/250385 (owner: 10Gergő Tisza) [00:51:43] (03PS13) 10Reedy: [WIP] Use AuthManager [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/251930 (https://phabricator.wikimedia.org/T110460) (owner: 10Gergő Tisza) [00:52:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use AuthManager [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/251930 (https://phabricator.wikimedia.org/T110460) (owner: 10Gergő Tisza) [00:53:14] (03CR) 10Legoktm: [C: 032 V: 032] Handle the apache config using dh_apache2 [debian] - 10https://gerrit.wikimedia.org/r/263018 (owner: 10Muehlenhoff) [00:53:33] (03CR) 10Reedy: "Chris, is this ok for you now? Or do you still want to strip phpcs from the composer-ising (ish) of the patch?" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [00:53:55] (03CR) 10Legoktm: [C: 032 V: 032] Remove obsolete preinst [debian] - 10https://gerrit.wikimedia.org/r/263020 (owner: 10Muehlenhoff) [00:54:15] (03CR) 10Legoktm: [C: 032 V: 032] Remove stray commemts [debian] - 10https://gerrit.wikimedia.org/r/263021 (owner: 10Muehlenhoff) [00:54:28] good commit summary review legoktm [00:54:29] :P [00:54:47] (03CR) 10Krinkle: [C: 04-1] "(see also inline comments about internal code). User inteface review:" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) (owner: 10Anomie) [00:55:55] (03PS1) 10Legoktm: Remove jquery.validate.js, and assorted changes [debian] - 10https://gerrit.wikimedia.org/r/263023 [00:56:26] Reedy: oops [00:58:01] 10MediaWiki-extensions-AbuseFilter: Filter local only abuse on the central global abuselog - https://phabricator.wikimedia.org/T123102#1921203 (10Billinghurst) 3NEW [01:17:16] (03PS4) 10Unicornisaurous: Add maintenance script importTextFiles.php [core] - 10https://gerrit.wikimedia.org/r/262857 [01:18:02] (03CR) 10Unicornisaurous: "I think I fixed everything." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/262857 (owner: 10Unicornisaurous) [01:22:07] (03CR) 10Jberkel: "(one) problem has been addressed with 29266a9a0f650babab24793f7dc0118f10bcb5ce / change-id: Ic576b8c31c487c106593050538f9f2cc5b722b62" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/234707 (owner: 10Jberkel) [01:22:36] (03Abandoned) 10Jberkel: Don't fail if pattern character is nil [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/234707 (owner: 10Jberkel) [01:24:13] (03CR) 10CSteipp: [C: 031] "overall security direction looks ok" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [01:26:01] (03CR) 10TTO: [C: 032] Add maintenance script importTextFiles.php [core] - 10https://gerrit.wikimedia.org/r/262857 (owner: 10Unicornisaurous) [01:31:54] (03Merged) 10jenkins-bot: Add maintenance script importTextFiles.php [core] - 10https://gerrit.wikimedia.org/r/262857 (owner: 10Unicornisaurous) [01:34:22] 10MediaWiki-Parser: An empty bullet renders in print only - https://phabricator.wikimedia.org/T123093#1921215 (10Cpiral) [01:44:37] (03CR) 10Anomie: [WIP] Use AuthManager on Special:Userlogin (0341 comments) [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [01:45:07] (03CR) 10Anomie: "Really, most of the HTMLForm bits could probably be pulled out to a patch against master, and then I can just review and merge them easily" [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [01:46:47] (03CR) 10Anomie: Add "bot passwords" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [02:17:15] 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Other, and 5 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#1921226 (10Nikerabbit) Until January 18th I cann... [02:17:32] (03PS2) 10Mattflaschen: Fix various ordering issues [vagrant] - 10https://gerrit.wikimedia.org/r/262866 [02:22:28] (03PS4) 10Mattflaschen: Don't use MySQL root account for DB connection [vagrant] - 10https://gerrit.wikimedia.org/r/260097 (https://phabricator.wikimedia.org/T86373) [02:44:54] (03PS1) 10MtDu: [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) [02:45:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [02:49:35] (03PS1) 10TTO: DynamicPageListHooks: Set parser context title [extensions/intersection] - 10https://gerrit.wikimedia.org/r/263029 (https://phabricator.wikimedia.org/T25307) [02:50:57] (03PS1) 10TTO: Remove some uses of $wgTitle in core [core] - 10https://gerrit.wikimedia.org/r/263030 (https://phabricator.wikimedia.org/T25307) [02:51:02] (03PS2) 10MtDu: [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) [02:51:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [02:57:15] (03PS3) 10MtDu: [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) [02:57:44] 10MediaWiki-Vagrant, 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1921234 (10Mattflaschen) [02:57:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [02:58:45] 10MediaWiki-Vagrant, 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1842363 (10Mattflaschen) I'm changing it to French because Zero is already [using Spanish](https://git.wikimedia.org/blob/mediawiki%2F... [03:03:22] (03PS4) 10MtDu: [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) [03:03:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [03:25:03] 10MediaWiki-extensions-AbuseFilter, 6Editing-Department, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot to detect and correctly handle edits that trigger abusefilter rules - https://phabricator.wikimedia.org/T85656#1921237 (10jayvdb) [03:31:33] (03PS3) 10Mattflaschen: Fix various ordering issues [vagrant] - 10https://gerrit.wikimedia.org/r/262866 [03:34:25] 10MediaWiki-Special-pages: Special pages: Allow using templates / adding interwiki links - https://phabricator.wikimedia.org/T15489#1921241 (10Purodha) Yes, but that requires some labor which I expect to take time if done thoroughly. I prefer the solution offered in T123063 for the final goal though, which does... [03:40:17] (03CR) 10Krinkle: [C: 04-1] "@Reedy: jQuery 1/2 is not an API change, it's a support change. There is API parity between 2.0 and 1.10, 2.1 and 1.11, etc." [core] - 10https://gerrit.wikimedia.org/r/262892 (https://phabricator.wikimedia.org/T123033) (owner: 10Gerrit Patch Uploader) [03:42:19] 10Wikimedia-Interwiki-links: Special pages should link to all languages in a project. - https://phabricator.wikimedia.org/T123063#1921243 (10Purodha) This is the exact same question everyone would have to ask about any interlanguage link. They are not commonly used, and they eat up screen pace which is unused in... [03:55:55] (03PS1) 10Legoktm: Add release notes for 4a40a5d21729 [core] - 10https://gerrit.wikimedia.org/r/263031 [03:56:18] (03CR) 10Legoktm: [C: 032] Add release notes for 4a40a5d21729 [core] - 10https://gerrit.wikimedia.org/r/263031 (owner: 10Legoktm) [03:58:00] (03CR) 10Mattflaschen: "This should be ready for initial review (I'll upload the latest patch in a moment)." [vagrant] - 10https://gerrit.wikimedia.org/r/260713 (https://phabricator.wikimedia.org/T119999) (owner: 10Mattflaschen) [03:59:53] (03CR) 10Mattflaschen: "Oh, I forgot, the URLs are (you can substitute 6081 if you're using Varnish):" [vagrant] - 10https://gerrit.wikimedia.org/r/260713 (https://phabricator.wikimedia.org/T119999) (owner: 10Mattflaschen) [04:00:57] (03PS2) 10Mattflaschen: Cross-wiki notification support [vagrant] - 10https://gerrit.wikimedia.org/r/260713 (https://phabricator.wikimedia.org/T119999) [04:00:59] (03PS5) 10Mattflaschen: Don't use MySQL root account for DB connection [vagrant] - 10https://gerrit.wikimedia.org/r/260097 (https://phabricator.wikimedia.org/T86373) [04:01:28] (03Merged) 10jenkins-bot: Add release notes for 4a40a5d21729 [core] - 10https://gerrit.wikimedia.org/r/263031 (owner: 10Legoktm) [04:04:58] (03CR) 10jenkins-bot: [V: 04-1] Cross-wiki notification support [vagrant] - 10https://gerrit.wikimedia.org/r/260713 (https://phabricator.wikimedia.org/T119999) (owner: 10Mattflaschen) [04:06:48] 6Phabricator: Mark existing projects as subprojects - https://phabricator.wikimedia.org/T123078#1921245 (10mmodell) a:3mmodell @luke081515: Thank you for writing this up [04:07:10] 6Phabricator: Mark existing projects as subprojects - https://phabricator.wikimedia.org/T123078#1921247 (10mmodell) p:5Triage>3Normal [04:19:49] (03PS2) 10Legoktm: Fix lintian overrides for oojs-ui/demos/pages/dialogs.js [debian] - 10https://gerrit.wikimedia.org/r/263023 [04:24:31] (03CR) 10Yurik: [C: 032] Improve docs, fix deprecated functons usage, rm unused method [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262729 (owner: 10MaxSem) [04:25:00] (03PS2) 10Yurik: Move a function to where it belongs [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262733 (owner: 10MaxSem) [04:25:03] (03Merged) 10jenkins-bot: Improve docs, fix deprecated functons usage, rm unused method [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262729 (owner: 10MaxSem) [04:25:52] (03CR) 10Yurik: [C: 032] Move a function to where it belongs [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262733 (owner: 10MaxSem) [04:26:08] (03PS3) 10Yurik: Namespace this extension [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262741 (https://phabricator.wikimedia.org/T122339) (owner: 10MaxSem) [04:26:24] (03Merged) 10jenkins-bot: Move a function to where it belongs [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262733 (owner: 10MaxSem) [04:28:52] (03PS1) 10MtDu: Convert RelatedSites to use new extension registration [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/263032 (https://phabricator.wikimedia.org/T87966) [04:35:24] (03PS1) 10Legoktm: [WIP] Strip out jquery.validate [debian] - 10https://gerrit.wikimedia.org/r/263033 [04:42:21] (03PS1) 10Yurik: Minor cleanup [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/263034 [04:42:31] (03PS2) 10MtDu: Convert RelatedSites to use new extension registration [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/263032 (https://phabricator.wikimedia.org/T87966) [04:43:19] (03CR) 10Yurik: [C: 032] Minor cleanup [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/263034 (owner: 10Yurik) [04:44:41] (03Merged) 10jenkins-bot: Minor cleanup [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/263034 (owner: 10Yurik) [04:46:01] 10WikiProject-X: Specify a proper JSON Schema for WikiProjects - https://phabricator.wikimedia.org/T120928#1921256 (10Harej) [04:46:44] 10Commons-App-Android-Upload: Phase 1: Display nearby categories when user uploads a photo - https://phabricator.wikimedia.org/T119163#1921261 (10josephine_l) [04:46:45] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1921260 (10josephine_l) 5Open>3Resolved [04:50:13] (03CR) 10Legoktm: [C: 032] Reduce CAS errors due to concurrent web requests by a user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/259967 (https://phabricator.wikimedia.org/T95839) (owner: 10Aaron Schulz) [04:50:17] (03CR) 10Legoktm: [C: 032] Assorted transaction logic cleanups [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/257746 (https://phabricator.wikimedia.org/T120791) (owner: 10Aaron Schulz) [04:50:19] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1921262 (10josephine_l) [04:51:06] (03Merged) 10jenkins-bot: Reduce CAS errors due to concurrent web requests by a user [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/259967 (https://phabricator.wikimedia.org/T95839) (owner: 10Aaron Schulz) [04:51:09] (03Merged) 10jenkins-bot: Assorted transaction logic cleanups [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/257746 (https://phabricator.wikimedia.org/T120791) (owner: 10Aaron Schulz) [04:52:04] (03PS6) 10Yurik: Cleanup HTML output and modules [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 (owner: 10Esanders) [04:53:24] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1921267 (10josephine_l) New version (1.5) released, do let me know if problem persists. [05:01:36] (03PS1) 10Prtksxna: renderer: Unregister mouseleave handler on mw.popups.$popus on closePopup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/263035 (https://phabricator.wikimedia.org/T68315) [05:08:07] 10WikiProject-X: Create CollaborationKit extension and deploy on English Wikipedia - https://phabricator.wikimedia.org/T123028#1921272 (10Harej) [05:09:51] (03PS3) 10Bartosz Dziewoński: Allow patrol of moves [core] - 10https://gerrit.wikimedia.org/r/251794 (https://phabricator.wikimedia.org/T98617) (owner: 10Cenarium) [05:15:40] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1921279 (10josephine_l) p:5High>3Normal [05:16:20] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1907764 (10josephine_l) @Nicolas_Raoul @Niedzielski - Moving forward, shall I just do (1) and (2), and ditch the recursive calls entirely? I h... [05:17:11] 10Hovercards, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Hovercards: Add `lang` and `dir` attributes to the `.mwe-popups-extract` - https://phabricator.wikimedia.org/T68114#1921281 (10Prtksxna) Can we use the current page's content language/direction for the popup instead of the one from the... [05:17:16] 10Hovercards, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Hovercards: Add `lang` and `dir` attributes to the `.mwe-popups-extract` - https://phabricator.wikimedia.org/T68114#1921283 (10Prtksxna) 5Resolved>3Open [05:17:51] (03PS4) 10Bartosz Dziewoński: [WIP] rebuildrecentchanges.php: Don't create duplicate entries for upload/move/protect etc. [core] - 10https://gerrit.wikimedia.org/r/261316 (https://phabricator.wikimedia.org/T116809) [05:18:30] 10Hovercards: Hovercards: Fix the length of the extract, and add ellipses - https://phabricator.wikimedia.org/T67845#1921284 (10Prtksxna) @jkatzwmf @jdlrobson, mind taking a look at this? [05:23:24] legoktm: Where can I find the example Composer.local.json? (https://phabricator.wikimedia.org/T121791) [05:23:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] rebuildrecentchanges.php: Don't create duplicate entries for upload/move/protect etc. [core] - 10https://gerrit.wikimedia.org/r/261316 (https://phabricator.wikimedia.org/T116809) (owner: 10Bartosz Dziewoński) [05:25:23] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1921298 (10josephine_l) [05:26:08] 10Commons-App-Android-Upload, 3Outreachy-Round-11: Mid-term report - https://phabricator.wikimedia.org/T123103#1921287 (10josephine_l) [05:36:37] 10WikiProject-X: Create CollaborationKit extension and deploy on English Wikipedia - https://phabricator.wikimedia.org/T123028#1921303 (10Harej) [05:39:28] ananayarora: umm, lets see [05:40:00] ananayarora: the one in the commit message of https://github.com/wikimedia/mediawiki-extensions-SyntaxHighlight_GeSHi/commit/6484894497f59080eb3e62da4d11b658c84e19f4 is probably a good starting point [05:40:35] legoktm: This is what I'm added. Hold on, pushing it to gerrit. [05:41:21] legoktm: There's a problem, when I try to commit my work, I get this. [05:41:52] ? [05:42:01] legoktm: http://i.imgur.com/0iWww17.png [05:42:33] ananayarora: run git fetch --all and then try git review -R [05:42:37] 10WikiProject-X: Implement submodules - https://phabricator.wikimedia.org/T106840#1921305 (10Harej) 5Open>3declined [05:43:05] 10WikiProject-X: Implement submodules - https://phabricator.wikimedia.org/T106840#1479616 (10Harej) Closing task for lack of specificity. [05:45:42] legoktm: I want to delete my local commits, an do a fresh one [05:45:51] um [05:45:59] you can do that, but that will take a while [05:48:07] (03PS1) 10Ananay: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) [05:48:23] legoktm: A hard reset did the trick ;) https://gerrit.wikimedia.org/r/263036 [05:48:24] 10WikiProject-X: Implement (anonymous) tracking mechanisms to determine how frequently tools are used - https://phabricator.wikimedia.org/T116675#1921310 (10Harej) A point of consideration: the CollaborationKit extension T123028 may do this more directly through EventLogging, which may eliminate the need to impl... [05:49:54] 10WikiProject-X: Support generation of reports based on arbitrary lists of pages - https://phabricator.wikimedia.org/T116680#1921313 (10Harej) The planned extension T123028 is planning on doing this by defining WikiProjects in terms of categories/pages included/excluded. It will be a separate decision whether to... [05:56:21] 4(no projects): noreferencess.py destroys ... section - https://phabricator.wikimedia.org/T123104#1921315 (10JAnD) 3NEW [05:58:30] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1921321 (10josephine_l) [06:00:14] legoktm: Please take a look at it now. Jenkins approved too :) [06:01:55] https://gerrit.wikimedia.org/r/263036 [06:02:41] 10MediaWiki-Interface, 7Easy, 7JavaScript, 5Patch-For-Review: jQuery.makeCollapsible: Font color of collapsible button cannot be set - https://phabricator.wikimedia.org/T63018#1921322 (10D3r1ck01) So should I role back to original? Like undo what I just did? [06:11:23] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921328 (10josephine_l) @Nicolas_Raoul @Niedzielski - Okay, this is weird. My v1.5 update has gone through, and when testing it on my phone (Samsung Galaxy s4) I'm e... [06:12:44] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1822686 (10josephine_l) Having same issue, will discuss it at T119283 [06:15:51] (03CR) 10Anomie: "> Avoid using "mw:" interwiki prefix in interface messages as these do not always work on non-wmf wikis." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) (owner: 10Anomie) [06:15:59] (03PS23) 10Anomie: Add Special:ApiSandbox [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) [06:20:28] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1921333 (10Nicolas_Raoul) Stephen will know better than me for the Java part, but one thing needed about this new way to use the API is to eva... [06:21:03] (03CR) 10jenkins-bot: [V: 04-1] Add Special:ApiSandbox [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) (owner: 10Anomie) [06:22:28] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921334 (10Nicolas_Raoul) I rooted my phone so I think I can send you logcats if needed. [06:22:44] 10MediaWiki-Email, 10MediaWiki-Interface, 10MediaWiki-Special-pages, 5MW-1.27-release-notes, and 3 others: [Regression] Special:EmailUser and Special:ExpandTemplates broken after OOUI conversion - https://phabricator.wikimedia.org/T122907#1921336 (10TTO) On Special:ExpandTemplates, the checkbox that is sup... [06:23:30] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921337 (10josephine_l) @Nicolas_Raoul - That would be great, thanks. Please update to v1.5 first, as it has just been released. What Android version is your phone u... [06:25:55] (03PS24) 10Anomie: Add Special:ApiSandbox [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) [06:28:47] (03PS1) 10Florianschmidtwelzow: SpecialExpandTemplates: Fix false checkbox label for nowiki tag [core] - 10https://gerrit.wikimedia.org/r/263037 (https://phabricator.wikimedia.org/T122907) [06:32:01] (03CR) 10Legoktm: [C: 032] renderer: Unregister mouseleave handler on mw.popups.$popus on closePopup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/263035 (https://phabricator.wikimedia.org/T68315) (owner: 10Prtksxna) [06:33:23] 10Hovercards, 5Patch-For-Review: Hovercards: Yet another flicker-issue when moving the mouse pointer between hovercard and link - https://phabricator.wikimedia.org/T68315#1921339 (10Legoktm) 5Open>3Resolved a:3Prtksxna [06:33:34] (03Merged) 10jenkins-bot: renderer: Unregister mouseleave handler on mw.popups.$popus on closePopup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/263035 (https://phabricator.wikimedia.org/T68315) (owner: 10Prtksxna) [06:34:01] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921342 (10josephine_l) [06:34:12] (03CR) 10Legoktm: [C: 032] renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (owner: 10Prtksxna) [06:35:14] (03PS3) 10Florianschmidtwelzow: SpecialComparePages: Float the boxes, if available space is given [core] - 10https://gerrit.wikimedia.org/r/262592 (https://phabricator.wikimedia.org/T122907) [06:35:50] (03Merged) 10jenkins-bot: renderer: Use NavigationPopups settings where available [extensions/Popups] - 10https://gerrit.wikimedia.org/r/137897 (owner: 10Prtksxna) [06:38:54] (03PS8) 10Florianschmidtwelzow: ExtensionRegistration: Implement Extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [06:42:16] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921344 (10josephine_l) My logcat for USB device just keeps running so it's hard to see what's going on. But when I filter for tag:fr.free the only log I can see is... [06:45:38] (03CR) 10Florianschmidtwelzow: ExtensionRegistration: Implement Extension dependencies (035 comments) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [06:47:19] 10MediaWiki-General-or-Unknown, 7JavaScript: mw.util.getUrl should produce working URLs for titles ending in "?" - https://phabricator.wikimedia.org/T123062#1921349 (10matmarex) https://test.wikipedia.org/wiki/Bug%3F?action=history is a perfectly fine URL which should open the history page. It looks like Wikim... [06:50:22] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921350 (10josephine_l) ``` 01-08 19:39:35.203: D/fr.free.nrw.commons.upload.ShareActivity(16980): Uri: content://media/external/images/media/10716 01-08 19:39:35.20... [07:02:10] (03Abandoned) 10Gergő Tisza: [DO NOT MERGE] Get email from remote wiki [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/250385 (owner: 10Gergő Tisza) [07:04:24] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1921353 (10josephine_l) [07:06:27] 10MediaWiki-API, 7Easy, 3Google-Code-In-2015: Expose "actual watchers" as in "action=info" via API call {action: query, prop: info} - https://phabricator.wikimedia.org/T105392#1921354 (10Nemo_bis) [07:07:39] (03PS9) 10Florianschmidtwelzow: ExtensionRegistration: Implement Extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [07:09:04] (03PS10) 10Florianschmidtwelzow: ExtensionRegistration: Implement Extension dependencies [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) [07:11:16] (03PS1) 10Legoktm: Don't hardcode $wgStatsdMetricPrefix [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/263038 [07:13:37] (03PS3) 10Mattflaschen: Cross-wiki notification support [vagrant] - 10https://gerrit.wikimedia.org/r/260713 (https://phabricator.wikimedia.org/T119999) [07:15:38] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, 3Google-Code-In-2015: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1921359 (10Nemo_bis) [07:16:39] (03CR) 10Gergő Tisza: Allow setting local email/realname from remote wiki (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/214092 (owner: 10CSteipp) [07:18:12] (03CR) 10Gergő Tisza: Move mwoauth-php lib to Composer, add phpcs (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [07:23:31] (03PS1) 10Yurik: Fixed preview caching polluting parser cache [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263039 (https://phabricator.wikimedia.org/T119779) [07:26:02] 10MediaWiki-Internationalization, 10Graph: English version of HTML was generated with Japanese localization - https://phabricator.wikimedia.org/T122723#1921366 (10Yurik) 5Open>3Resolved a:3Yurik This should have been fixed with https://gerrit.wikimedia.org/r/#/c/262367/ [07:28:20] (03CR) 10Legoktm: [C: 032] "approving from kunal's laptop --alex" [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/263038 (owner: 10Legoktm) [07:28:48] 10MediaWiki-extension-requests, 10Graph: Need a webpage to produce Pie chart according to Graphic Lab's recommendations - https://phabricator.wikimedia.org/T14603#1921369 (10Yurik) Seems another graph was implemented as part of https://en.wikipedia.org/wiki/Template:Graph:Chart [07:29:04] (03Merged) 10jenkins-bot: Don't hardcode $wgStatsdMetricPrefix [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/263038 (owner: 10Legoktm) [07:34:58] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921376 (10josephine_l) [07:36:17] 10MediaWiki-Vagrant, 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1921380 (10Mattflaschen) > For browser testing, it would also be great if we could have all of the wikis initialize with "Selenium use... [07:39:49] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks fine to me. (I can merge if Nemo approves.)" [core] - 10https://gerrit.wikimedia.org/r/262818 (owner: 10MtDu) [07:45:39] (03CR) 10Florianschmidtwelzow: ExtensionRegistration: Implement Extension dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [07:49:23] 10MediaWiki-Parser, 10Graph, 5Patch-For-Review: Force re-parsing on save even if it was parsed for preview - https://phabricator.wikimedia.org/T119779#1921388 (10Yurik) @aaron, preview is different because it has to bring the graph's spec to the client from the start (interactive), because it is not stored a... [07:51:30] can anyone here give http://commons.wikimedia.beta.wmflabs.org/wiki/User:Yatu patroller rights? [07:51:48] (03CR) 10Nemo bis: [C: 031] Add documentation to clarify difference between save and upload message [core] - 10https://gerrit.wikimedia.org/r/262818 (owner: 10MtDu) [07:52:23] (03CR) 10Bartosz Dziewoński: [C: 032] Add documentation to clarify difference between save and upload message [core] - 10https://gerrit.wikimedia.org/r/262818 (owner: 10MtDu) [07:53:10] Steinsplitter: can you? ^ [07:53:33] (03PS2) 10Yurik: Fixed preview caching polluting parser cache [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263039 (https://phabricator.wikimedia.org/T119779) [07:53:57] (change visibility) 07:53, 8 January 2016 Legoktm (talk | contribs | block) changed group membership for Yatu from (none) to patroller (per request) [07:54:07] <3 legoktm [07:55:12] (03CR) 10Legoktm: [C: 032] Fixed preview caching polluting parser cache [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263039 (https://phabricator.wikimedia.org/T119779) (owner: 10Yurik) [07:55:15] np [07:55:56] 10MediaWiki-Parser, 10Graph, 5Patch-For-Review: Force re-parsing on save even if it was parsed for preview - https://phabricator.wikimedia.org/T119779#1921390 (10Yurik) 5Open>3Resolved a:3Yurik [07:56:48] \o/ file patrol [07:58:04] (03Merged) 10jenkins-bot: Add documentation to clarify difference between save and upload message [core] - 10https://gerrit.wikimedia.org/r/262818 (owner: 10MtDu) [07:58:06] (03Merged) 10jenkins-bot: Fixed preview caching polluting parser cache [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263039 (https://phabricator.wikimedia.org/T119779) (owner: 10Yurik) [07:58:52] (03CR) 10Physikerwelt: "FYI: there are good reasons, why the set of whitelisted commands is currently imutable." [extensions/Math] - 10https://gerrit.wikimedia.org/r/263011 (owner: 10Tim Landscheidt) [07:59:47] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921393 (10josephine_l) [08:00:07] (03CR) 10Legoktm: [C: 04-2] "This doesn't work. $wgRelatedSites is an *object*, not static functions." [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/263032 (https://phabricator.wikimedia.org/T87966) (owner: 10MtDu) [08:03:21] Nemo_bis, hi [08:03:44] Hi [08:06:12] 10MediaWiki-extensions-ExtensionDistributor, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): ExtensionDistributor tarballs should include .git metadata that makes the version show upon Special:Version - https://phabricator.wikimedia.org/T122769#1921400 (10Legoktm) 5Open... [08:08:09] 10WikiCon-Francophone-2016: Sponsors pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T121855#1921403 (10Pyb) [08:13:04] (03PS1) 10Christopher Johnson (WMDE): fixes call to undefined method setObjectUri Bug: T122451 [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/263040 (https://phabricator.wikimedia.org/T122451) [08:14:33] (03CR) 10Christopher Johnson (WMDE): [C: 032] fixes call to undefined method setObjectUri Bug: T122451 [phabricator/extensions/Sprint] - 10https://gerrit.wikimedia.org/r/263040 (https://phabricator.wikimedia.org/T122451) (owner: 10Christopher Johnson (WMDE)) [08:14:42] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921404 (10josephine_l) Uri output on my emulator: ``` 01-08 08:11:48.421: D/fr.free.nrw.commons.upload.ShareActivity(2188): Uri: content://com.android.providers.m... [08:15:22] 10MediaWiki-Releasing, 6Release-Engineering-Team, 7Security-Extensions: Backport security fixes to stable + LTS extension branches - https://phabricator.wikimedia.org/T108734#1921405 (10Tgr) Uh... sorry, I probably had something specific in mind but I can't remember at all now what it was. Would sure have be... [08:16:17] 10Phabricator-Sprint-Extension: UNRECOVERABLE FATAL ERROR After update - https://phabricator.wikimedia.org/T122451#1921407 (10Christopher) Thanks for finding this. See fix here: https://gerrit.wikimedia.org/r/#/c/263040/ [08:26:20] 10MediaWiki-extensions-CLDR, 10Wikidata, 7Upstream: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#1921412 (10adrianheine) Hi, just wanted to give you a heads-up that I am again actively working on this. I already imp... [08:39:51] (03PS13) 10Gergő Tisza: Move mwoauth-php lib to Composer, add phpcs [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 [08:41:12] (03PS6) 10Gergő Tisza: Allow setting a custom callback URL [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248662 [08:41:49] (03PS14) 10Gergő Tisza: [WIP] Use AuthManager [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/251930 (https://phabricator.wikimedia.org/T110460) [08:42:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use AuthManager [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/251930 (https://phabricator.wikimedia.org/T110460) (owner: 10Gergő Tisza) [08:48:58] tto, hi! awake? :D [08:49:13] victorbarbu_, g'day! [09:01:36] (03CR) 10Thiemo Mättig (WMDE): "Can you please link this to a Phabricator ticket? I really wonder why stuff gets merged *into* core, when dozens of other developers are t" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/262977 (owner: 10Anomie) [09:03:15] tto, put this task to gci project? https://phabricator.wikimedia.org/T22691 [09:03:26] Finally will work on it:) [09:03:49] 10WikiCon-Francophone-2016: Comptes-rendus des réunions préparatoires de la WikiconFR 2016 - https://phabricator.wikimedia.org/T123105#1921415 (10Pyb) 3NEW [09:04:32] 10MediaWiki-Change-tagging, 10MediaWiki-Export-or-Import, 3Google-Code-In-2015: The export and import processes should transport revision tags - https://phabricator.wikimedia.org/T22691#1921425 (10TTO) [09:09:48] 10WikiCon-Francophone-2016: Recherche d'un local pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T118962#1921430 (10Pyb) [09:12:57] 10WikiCon-Francophone-2016: Recherche d'un local à Limoges - https://phabricator.wikimedia.org/T118963#1921431 (10Pyb) [09:15:38] 10WikiCon-Francophone-2016: Recherche d'un local à Strasbourg - https://phabricator.wikimedia.org/T121515#1921433 (10Pyb) Lien utile : https://meta.wikimedia.org/wiki/WikiCon_2015/fr [09:20:30] (03CR) 10Paladox: "Whoops sorry this was meant for the REL1_26 branch" [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/262915 (owner: 10Paladox) [09:20:43] (03PS1) 10Paladox: Update .gitreview [extensions/DeletePagesForGood] (REL1_26) - 10https://gerrit.wikimedia.org/r/263041 [09:20:51] (03CR) 10Paladox: [C: 032] Update .gitreview [extensions/DeletePagesForGood] (REL1_26) - 10https://gerrit.wikimedia.org/r/263041 (owner: 10Paladox) [09:21:01] (03PS1) 10Paladox: Revert "Update .gitreview" [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/263042 [09:21:13] (03CR) 10Paladox: [C: 032] Revert "Update .gitreview" [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/263042 (owner: 10Paladox) [09:21:47] (03Merged) 10jenkins-bot: Update .gitreview [extensions/DeletePagesForGood] (REL1_26) - 10https://gerrit.wikimedia.org/r/263041 (owner: 10Paladox) [09:22:25] (03Merged) 10jenkins-bot: Revert "Update .gitreview" [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/263042 (owner: 10Paladox) [09:25:26] 4(no projects): rendering .png preview of .svg drawing is buggy - https://phabricator.wikimedia.org/T123106#1921435 (10Efa) 3NEW [09:25:52] (03CR) 10Raimond Spekking: "Thanks" [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/263042 (owner: 10Paladox) [09:29:01] 10WikiCon-Francophone-2016: Recherche d'un local à Strasbourg - https://phabricator.wikimedia.org/T121515#1921441 (10Pyb) [09:37:46] 10WikiCon-Francophone-2016: Recherche d'un local à Strasbourg - https://phabricator.wikimedia.org/T121515#1921444 (10Pyb) [09:38:09] 10WikiCon-Francophone-2016: Recherche d'un local à Strasbourg - https://phabricator.wikimedia.org/T121515#1921445 (10Pyb) 5declined>3Open [09:38:10] 10WikiCon-Francophone-2016: Recherche d'un local pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T118962#1921446 (10Pyb) [09:38:52] 10WikiCon-Francophone-2016: Recherche d'un local à Dijon - https://phabricator.wikimedia.org/T118964#1921447 (10Pyb) [09:39:31] (03CR) 10Gergő Tisza: [C: 032] Refactor session- and cookie-related code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248394 (owner: 10Anomie) [09:41:46] (03Merged) 10jenkins-bot: Refactor session- and cookie-related code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248394 (owner: 10Anomie) [09:43:02] 10MediaWiki-extensions-CentralNotice, 10Fundraising Tech Backlog, 10Fundraising-Backlog, 7Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#1921453 (10WMDE-leszek) [09:47:20] (03CR) 10Tim Landscheidt: "@Physikerwelt: What do you mean by that? They are not immutable, but defined by lexer.mll & Co." [extensions/Math] - 10https://gerrit.wikimedia.org/r/263011 (owner: 10Tim Landscheidt) [10:00:18] (03CR) 10Gergő Tisza: [C: 032] Update for SessionManager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 (owner: 10Anomie) [10:01:54] (03Merged) 10jenkins-bot: Update for SessionManager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 (owner: 10Anomie) [10:16:50] (03CR) 10Gergő Tisza: [C: 032] Update for SessionManager [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/247717 (owner: 10Anomie) [10:17:28] (03Merged) 10jenkins-bot: Update for SessionManager [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/247717 (owner: 10Anomie) [10:21:21] (03PS5) 10Hashar: Fix jenkins test failing for js [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262934 (https://phabricator.wikimedia.org/T63596) (owner: 10Paladox) [10:23:14] 10MediaWiki-extensions-Configure, 7Documentation: Add missing documentation messages for Configure extension - https://phabricator.wikimedia.org/T123107#1921470 (10hashar) 3NEW [10:23:41] (03PS1) 10Hashar: Add banana i18n checker [extensions/Configure] - 10https://gerrit.wikimedia.org/r/263044 (https://phabricator.wikimedia.org/T123107) [10:24:27] (03CR) 10jenkins-bot: [V: 04-1] Add banana i18n checker [extensions/Configure] - 10https://gerrit.wikimedia.org/r/263044 (https://phabricator.wikimedia.org/T123107) (owner: 10Hashar) [10:24:36] (03CR) 10Hashar: "recheck" [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262934 (https://phabricator.wikimedia.org/T63596) (owner: 10Paladox) [10:25:23] (03CR) 10Hashar: [C: 032] Fix jenkins test failing for js [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262934 (https://phabricator.wikimedia.org/T63596) (owner: 10Paladox) [10:25:33] 10MediaWiki-extensions-Configure, 5Patch-For-Review: Configure should pass jshint - https://phabricator.wikimedia.org/T63596#1921480 (10hashar) a:3Paladox [10:25:44] 10MediaWiki-extensions-Configure, 5Patch-For-Review: Configure should pass jshint - https://phabricator.wikimedia.org/T63596#1921482 (10hashar) 5Open>3Resolved [10:27:32] 10MediaWiki-extensions-SemanticDrilldown, 5Patch-For-Review: SemanticDrilldown should pass jshint - https://phabricator.wikimedia.org/T63627#1921487 (10hashar) [10:27:33] 10MediaWiki-extensions-SemanticDrilldown: SemanticDrilldown should pass jshint - https://phabricator.wikimedia.org/T63628#1921485 (10hashar) [10:37:07] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, 3Google-Code-In-2015: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1921507 (10Mhutti1) a:3Mhutti1 [10:37:49] 10MediaWiki-extensions-SemanticDrilldown, 5Patch-For-Review: SemanticDrilldown should pass jshint - https://phabricator.wikimedia.org/T63627#1921509 (10hashar) a:3Paladox [10:37:57] 10MediaWiki-extensions-SemanticDrilldown, 5Patch-For-Review: SemanticDrilldown should pass jshint - https://phabricator.wikimedia.org/T63627#1921510 (10hashar) 5Open>3Resolved [10:38:32] (03CR) 10Hashar: [C: 032] Fix jenkins test failing for js [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262934 (https://phabricator.wikimedia.org/T63596) (owner: 10Paladox) [10:39:26] (03Merged) 10jenkins-bot: Fix jenkins test failing for js [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262934 (https://phabricator.wikimedia.org/T63596) (owner: 10Paladox) [10:47:46] (03CR) 10Hashar: [C: 04-1] "Looking at the job console output, Zuul did craft a merge commit for mediawiki/core using https://gerrit.wikimedia.org/r/#/c/262873/ on ti" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (owner: 10TheDJ) [10:48:26] 10MediaWiki-extensions-Other, 5Patch-For-Review: FundraisingChart should pass jshint - https://phabricator.wikimedia.org/T68192#1921513 (10hashar) a:3Paladox [10:52:32] (03PS4) 10Hashar: Update some packages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262885 (owner: 10Paladox) [10:53:56] (03CR) 10D3r1ck01: "Remove D3r1ck as a reviewer, its still me, just allow D3r1ck01" [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [10:54:56] (03PS5) 10Hashar: Update some packages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262885 (owner: 10Paladox) [10:56:23] (03PS2) 10Hashar: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [10:58:19] 10Wikimedia-Site-Requests: Allow GWT uploads from ethz.ch - https://phabricator.wikimedia.org/T123109#1921521 (10Kelson) 3NEW [10:59:34] (03CR) 10Hashar: [C: 04-1] "Note /composer.local.json is in .gitignore, should prevent folks from uploading it by mistake." [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [11:00:12] (03CR) 10Hashar: [C: 032] Update some packages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262885 (owner: 10Paladox) [11:03:33] 10MediaWiki-History-or-Diffs: Diff: highlights everything in a long line - https://phabricator.wikimedia.org/T123110#1921528 (10Oliv0) 3NEW [11:04:54] hashar: Hi, about the composer.local.json, legoktm requested for a template that can be used [11:05:17] not requested, sorry, i mean to say suggested [11:06:54] d3r1ck: yup seen that :-} [11:07:05] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921535 (10josephine_l) [11:07:49] d3r1ck: no worries, I am just paranoid and afraid of folks suddenly loosing their local file whenever they install a new tarball. I guess Legoktm will reply later today [11:07:56] hashar: so .gitignore prevents it from being uploaded, yes for sure but its just acts as a template for dev's of media wiki to know what to add at what position in the composer.json file [11:07:57] d3r1ck: is that part of google code in ? [11:08:20] hashar: Yes it is :) Did you not check? [11:08:50] well welcome in a world where even a couple lines patch can takes days to land :-}}}}}}} [11:09:04] the git part should be fine [11:09:07] since it is in .gitignore [11:09:20] hashar: sure, i was immersed in the world since Sept 2015 [11:09:30] though I am wondering what will happen if we change it later, a git pull will cause a merge conflict / override if one had some local changes (havent checked) [11:09:49] but my main concern is people loosing the local file when upgrading from mw tarball :D [11:09:54] just plain paranoia [11:10:15] as for open source, it is hard [11:10:20] but rewarding :-} [11:10:38] hashar: But the composer.local.json file won't be updated or will it? Once the template is there, it will not be changed or modified :) [11:10:43] do you have any other tasks ? I dont mind reviewing [11:10:58] hashar: none for now :) [11:11:05] the git part should be fine ;D [11:11:12] again my concern is providing it in the tarball [11:11:15] hashar: yes it is. [11:11:15] but we can drop it [11:11:22] or maybe we can just rename the file with a .sample [11:11:33] there will be some discussions with legoktm on gerrit [11:11:42] and at some point it will surely land :-} [11:11:47] well, legoktm will handle that part. He suggested that so let him say something first :) [11:12:00] yeah :-} [11:12:03] hashar: yeah, i get you :) [11:12:12] so you can probably take another task now [11:12:14] and multitask ! [11:12:23] hahahaha.... [11:12:29] I am a mentor not a student :) [11:12:38] I am mentoring that task with legoktm :) [11:12:55] is a good one [11:13:03] and our de factor composer guru / lead [11:13:18] who? [11:13:21] you mean legoktm ? [11:13:45] yes [11:14:14] Yeah, he will surely land :D [11:15:40] (03CR) 10Physikerwelt: "Yes, you can change that locally." [extensions/Math] - 10https://gerrit.wikimedia.org/r/263011 (owner: 10Tim Landscheidt) [11:17:33] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1921537 (10Yann) >>! In T120867#1918149, @MarkTraceur wrote: >... [11:18:07] (03Merged) 10jenkins-bot: Update some packages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/262885 (owner: 10Paladox) [11:23:03] any UI guy here? [11:23:12] 10MediaWiki-extensions-WikibaseRepository, 10MediaWiki-extensions-WikibaseView, 10Wikidata, 3Wikidata-Sprint-2015-12-01: [Story] Put identifiers into separate section in the UI - https://phabricator.wikimedia.org/T117421#1921541 (10thiemowmde) [11:23:15] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-12-01: [Task] Make JS view code independent of ordering and grouping of statements in HTML - https://phabricator.wikimedia.org/T119946#1921539 (10thiemowmde) 5Open>3Resolved [11:35:28] 10MediaWiki-Configuration, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-12-01: [Task] Add initial configuration for an "Identifiers" statement section - https://phabricator.wikimedia.org/T123112#1921561 (10thiemowmde) 3NEW a:3thiemowmde [12:10:55] 10MediaWiki-API, 10TemplateData, 7Easy, 3Google-Code-In-2015: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1921576 (10Florian) [12:14:45] 10MediaWiki-Codesniffer, 7Easy: Update mediawiki/tools/codesniffer repository to use phpcs.xml file - https://phabricator.wikimedia.org/T116866#1921577 (10Haritha28) a:3Haritha28 [12:15:06] (03PS1) 10Hashar: Add jsonlint to 'npm test' [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263047 [12:15:42] (03CR) 10jenkins-bot: [V: 04-1] Add jsonlint to 'npm test' [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263047 (owner: 10Hashar) [12:20:39] (03PS1) 10Hashar: i18n: missing metadata block in aeb-arab [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263049 [12:21:06] (03PS2) 10Hashar: Add jsonlint to 'npm test' [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263047 [12:23:03] 10MediaWiki-General-or-Unknown, 10Math, 10Mathoid, 10Parsoid, and 2 others: Implement a single math rendering mode that works across all devices (MathML / SVG using mathoid) - https://phabricator.wikimedia.org/T78046#1921580 (10Physikerwelt) >>! In T78046#1754463, @Kulla wrote: > On de.WP there is a big su... [12:25:10] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, 3Google-Code-In-2015: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1921581 (10Kelson) @mhutti Really surprising to see you there too! But would be really really helpful i... [12:31:55] 10MediaWiki-API, 10TemplateData, 7Easy, 3Google-Code-In-2015: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#1921587 (10Florian) Imported as: https://codein.withgoogle.com/dashboard/tasks/6282664327774208/ [12:34:04] (03PS2) 10Devirk: Reworded the message when editing the current version of an article. [core] - 10https://gerrit.wikimedia.org/r/262701 [12:42:22] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, 3Google-Code-In-2015: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1921593 (10Mhutti1) @Kelson yeah I like mixing up the tasks I do :). Once there are some non-beginner k... [13:06:54] (03CR) 10Reedy: Move mwoauth-php lib to Composer, add phpcs (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [13:15:35] 10Commons-App-Android-Upload: Manual testing of app, bugfixes, release to Google Play. Recruit testers. - https://phabricator.wikimedia.org/T119283#1921597 (10josephine_l) [13:17:17] Hey I can't log in to Gerrit anymore… is there a way to reset my password? [13:18:17] Should be able to reset it by changing your wikitech password [13:21:50] Hmmm okay or I could try using that password ;) [13:21:51] thansk [13:29:01] 10MediaWiki-Page-editing: Live preview does not display map (from Mapframe template) on English wikivoyage - https://phabricator.wikimedia.org/T123061#1921610 (10phabyogi) @Aklapper, thank you for correcting the title! But any reason to change the task priority to **Lowest** from **Low**? Because of the T41272 b... [13:31:36] 10Wikimedia-Site-Requests, 5Patch-For-Review: Three changes to Wuu Wikipedia - https://phabricator.wikimedia.org/T122476#1921612 (10Mdann52) a:3Mdann52 [13:31:37] 6Parsing-Team: Section-scope declarations for Wiktionary template invocations - https://phabricator.wikimedia.org/T122934#1921615 (10TTO) >>! @tstarling wrote: > the current (most deeply nested)
tag As far as I can see, the preprocessor XML doesn't generate
tags, and neither does Parsoid. We... [13:35:08] 10MediaWiki-extensions-CLDR, 10Wikidata, 7Upstream: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#1921618 (10matej_suchanek) a:3adrianheine [14:18:09] 10MediaWiki-extensions-CheckUser, 6Stewards-and-global-tools: CheckUser "get edits" duplicates results on account creations - https://phabricator.wikimedia.org/T123114#1921619 (10MarcoAurelio) 3NEW [14:25:06] 10MediaWiki-extensions-Semantic-MediaWiki: Support parameters to control details of query printouts - https://phabricator.wikimedia.org/T18571#1921627 (10Kghbln) See also [[ https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/1357 | pull 1357 on GitHub ]] [14:40:31] (03PS4) 10Hashar: Enable karma debug log and use progress reporter [core] - 10https://gerrit.wikimedia.org/r/260388 [14:41:56] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy, 3Google-Code-In-2015: Uploads fail with verification-error due to incorrect timeout handling - https://phabricator.wikimedia.org/T119053#1921630 (10Nemo_bis) Great, I've added Kelson to mentors then. :) https://codein.withgoogle.com/dashboar... [14:43:47] (03CR) 10Hashar: "I have removed the client.captureConsole: true statement. Was not working anyway." [core] - 10https://gerrit.wikimedia.org/r/260388 (owner: 10Hashar) [15:06:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase repo tests tend to time out on jenkins - https://phabricator.wikimedia.org/T123115#1921632 (10hoo) 3NEW [15:21:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase repo tests tend to time out on jenkins - https://phabricator.wikimedia.org/T123115#1921642 (10hoo) [15:28:36] (03PS1) 10Dvogel hallowelt: Flexiskin: New RL implementation [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/263056 [15:28:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase repo tests tend to time out on jenkins - https://phabricator.wikimedia.org/T123115#1921644 (10hashar) Seems to be due to UsageTrackingIntegrationTest which interacts with CirrusSearch: ``` [runJobs] cirrusSearchDeletePages Item:Q11 id=18 cluster=... [15:28:56] (03CR) 10jenkins-bot: [V: 04-1] Flexiskin: New RL implementation [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/263056 (owner: 10Dvogel hallowelt) [15:31:33] 10MediaWiki-General-or-Unknown, 10Wikimedia-Apache-configuration, 7JavaScript: mw.util.getUrl should produce working URLs for titles ending in "?" - https://phabricator.wikimedia.org/T123062#1921645 (10He7d3r) [15:31:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase repo tests tend to time out on jenkins - https://phabricator.wikimedia.org/T123115#1921647 (10hoo) Thanks, @hashar. I'll try to look into that myself later on, or maybe @aude will (although she's still in SF, so she might not have time). [15:32:33] 10MediaWiki-API, 5MW-1.27-release-notes, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Remove deprecated response values from ApiLogin - https://phabricator.wikimedia.org/T121527#1921651 (10csteipp) [15:37:42] (03PS2) 10Dvogel hallowelt: Flexiskin: New RL implementation [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/263056 [15:37:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase repo tests tend to time out on jenkins - https://phabricator.wikimedia.org/T123115#1921658 (10hashar) On CI we have removed ElasticSearch entirely. {T89083} Been done by cherry picking the puppet patch https://gerrit.wikimedia.org/r/#/c/259301/... [15:38:01] (03CR) 10jenkins-bot: [V: 04-1] Flexiskin: New RL implementation [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/263056 (owner: 10Dvogel hallowelt) [15:39:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase repo tests tend to time out on jenkins - https://phabricator.wikimedia.org/T123115#1921660 (10hoo) We run all those jobs in `UsageTrackingIntegrationTest`… maybe we should be smarter there as well. [15:46:08] (03PS3) 10Dvogel hallowelt: Flexiskin: New RL implementation [extensions/BlueSpiceExtensions] (REL1_23) - 10https://gerrit.wikimedia.org/r/263056 [15:47:25] legoktm: There's a problem with my task. Please review? [15:47:47] 10Wikimedia-General-or-Unknown: MediaWiki namespace pages regularly fall back to an obsolete version, due to server cache effect - https://phabricator.wikimedia.org/T7092#1921661 (10He7d3r) [15:49:03] 10Wikimedia-General-or-Unknown: MediaWiki namespace pages regularly fall back to an obsolete version, due to server cache effect - https://phabricator.wikimedia.org/T7092#1921668 (10He7d3r) [15:59:53] 10MediaWiki-API, 10Analytics-EventLogging, 7Easy, 3Google-Code-In-2015: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91454#1921670 (10Florian) [16:02:42] 10MediaWiki-API, 10Analytics-EventLogging, 7Easy, 3Google-Code-In-2015: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91454#1921672 (10Florian) Imported as: https://codein.withgoogle.com/dashboard/tasks/4893750757163008/ [16:06:55] 10MediaWiki-extensions-CentralNotice, 7Easy, 3Google-Code-In-2015: CentralNotice changes being marked as bot edit - https://phabricator.wikimedia.org/T87324#1921675 (10Florian) Hmm, I'm not sure, but I think this is correct? The edit to the specific page was made by a software (~bot), and the primary log for... [16:17:47] 10MediaWiki-Revision-deletion, 10MobileFrontend: Wrong links on Special:MobileDiff to delete log when looking at revision deleted diff - https://phabricator.wikimedia.org/T122984#1921701 (10Florian) a:3Florian Oops.... [16:18:53] 10Wikimedia-Site-Requests, 5Patch-For-Review: User group rights changes on tr.wikiquote.org - https://phabricator.wikimedia.org/T122710#1921705 (10Luke081515) Signed up for SWAT at 14th january: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_11th [16:18:55] 10Wikimedia-Site-Requests, 5Patch-For-Review: Request to set $wgRestrictDisplayTitle = false at de.wikibooks - https://phabricator.wikimedia.org/T122433#1921706 (10Luke081515) Signed up for SWAT at 14th january: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_11th [16:18:57] 10Wikimedia-Site-Requests, 5Patch-For-Review: Add interface editor user group on urwiki - https://phabricator.wikimedia.org/T120348#1921708 (10Luke081515) Signed up for SWAT at 14th january: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_11th [16:18:58] 10Wikimedia-Site-Requests, 5Patch-For-Review: Add flood flag for Latvian Wikipedia - https://phabricator.wikimedia.org/T121238#1921707 (10Luke081515) Signed up for SWAT at 14th january: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_11th [16:25:36] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262940 (owner: 10Paladox) [16:36:10] (03PS1) 10Florianschmidtwelzow: Fix false inclusion of FULLPAGENAME on Special:MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263063 (https://phabricator.wikimedia.org/T122984) [16:37:23] (03PS3) 10Jforrester: build: Update jscs to latest [core] - 10https://gerrit.wikimedia.org/r/262940 (owner: 10Paladox) [16:37:33] (03CR) 10Jforrester: [C: 032] build: Update jscs to latest [core] - 10https://gerrit.wikimedia.org/r/262940 (owner: 10Paladox) [16:40:13] 10MediaWiki-Interface, 7Easy, 7JavaScript, 5Patch-For-Review: jQuery.makeCollapsible: Font color of collapsible button cannot be set - https://phabricator.wikimedia.org/T63018#1921735 (10D3r1ck01) @matmarex, what do you suggest we do the custom toggles? [16:41:10] (03CR) 10Paladox: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/262940 (owner: 10Paladox) [16:44:31] (03Merged) 10jenkins-bot: build: Update jscs to latest [core] - 10https://gerrit.wikimedia.org/r/262940 (owner: 10Paladox) [16:44:31] hi - if I want to build a mediawiki extension that reads data from a third party site (e.g. JIRA) and display it on a wiki page what is the best way to go about this? I know how to do this already, but I want to consider things like page load time, not calling JIRA every single time, or even maybe permanently including the content on that page after the first call. Any hints or links to info would be helpful [16:44:49] 10MediaWiki-General-or-Unknown, 10Librarization, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Add a composer.local.json-sample to MediaWiki core - https://phabricator.wikimedia.org/T122968#1921736 (10D3r1ck01) Imported to the GCI System as https://codein.withgoogle.com/dashboard/tasks/5080357154062336/ [16:45:45] (03PS1) 10Paladox: Test: DO NOT MERGE [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263066 [16:45:49] User__: MediaWiki has various caches you can use [16:48:12] If I built a hook for $wgParser (example: jira) and then include on the page, is this cached automatically via page caching or do I have to pro grammatically work with the cache? [16:49:32] You'd probably want to store things in the object cache yourself [16:49:57] There's a couple of extensions that do JIRA stuff already [16:53:05] (03CR) 10Paladox: "check experimental" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263066 (owner: 10Paladox) [16:57:24] 10MediaWiki-File-management, 6Commons, 6Multimedia: PHP Notice: Undefined offset: 0 in /.../includes/media/FormatMetadata.php on line 1057 - https://phabricator.wikimedia.org/T87572#1921740 (10Tgr) Thanks! Can you help figure out what EXIF data is causing the warning? You could try replacing ``` $formattedE... [17:00:23] (03PS1) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:03:20] 10MediaWiki-extensions-ContactPage: ContactPage Catchable fatal error - https://phabricator.wikimedia.org/T122430#1921742 (10EFFemeer) Via https://www.mediawiki.org/w/index.php?title=Topic:Sw39iixi0k8h2k0z&topic_showPostId=sw3cedhegj16cg45&fromnotif=1#flow-post-sw3cedhegj16cg45 I got the reaction that : The co... [17:08:46] (03CR) 10Gergő Tisza: Move mwoauth-php lib to Composer, add phpcs (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/248661 (owner: 10Gergő Tisza) [17:17:43] 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1921755 (10RobLa-WMF) Somewhat of a tangent: my vague understanding is that WordPerfect still is used as a document format the legal community. My theory is that... [17:22:49] (03PS1) 10Legoktm: Don't parse wikitext in edit-user-talk snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263071 (https://phabricator.wikimedia.org/T121994) [17:24:00] (03CR) 10Luke081515: [C: 031] Don't parse wikitext in edit-user-talk snippets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263071 (https://phabricator.wikimedia.org/T121994) (owner: 10Legoktm) [17:29:14] (03PS2) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:33:44] (03PS3) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:34:03] (03Abandoned) 10Paladox: Test: DO NOT MERGE [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263066 (owner: 10Paladox) [17:34:36] (03CR) 10Paladox: "check experimental" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 (owner: 10Paladox) [17:38:33] 10MediaWiki-File-management, 6Commons, 6Multimedia: PHP Notice: Undefined offset: 0 in /.../includes/media/FormatMetadata.php on line 1057 - https://phabricator.wikimedia.org/T87572#1921771 (10Kghbln) Unfortunately I do not get any EXIF data. However I now identified some files causing the trouble: - [[... [17:38:55] (03PS4) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:39:03] (03PS5) 10Anomie: Detect if ApiSandbox is in core [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/262977 (https://phabricator.wikimedia.org/T89386) [17:39:11] (03CR) 10Paladox: "check experimental" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 (owner: 10Paladox) [17:41:59] 4(no projects): python3 triangle.py causing high memory usage on tools-bastion-02 - https://phabricator.wikimedia.org/T123122#1921773 (10valhallasw) 3NEW [17:42:18] (03PS3) 10Muehlenhoff: Fix lintian overrides for oojs-ui/demos/pages/dialogs.js [debian] - 10https://gerrit.wikimedia.org/r/263023 (owner: 10Legoktm) [17:42:39] (03CR) 10Luke081515: [C: 031] Detect if ApiSandbox is in core [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/262977 (https://phabricator.wikimedia.org/T89386) (owner: 10Anomie) [17:42:41] (03CR) 10Muehlenhoff: [C: 032 V: 032] Fix lintian overrides for oojs-ui/demos/pages/dialogs.js [debian] - 10https://gerrit.wikimedia.org/r/263023 (owner: 10Legoktm) [17:42:43] (03PS5) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:44:42] (03PS6) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:46:35] (03CR) 10Muehlenhoff: "This is a bug in lintian, I wouldn't put any effort in this :-)" [debian] - 10https://gerrit.wikimedia.org/r/263033 (owner: 10Legoktm) [17:48:15] (03PS7) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:50:02] (03PS8) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:51:48] 10MediaWiki-Vagrant: Spin custom MediaWiki-Vagrant box with base packages pre-installed - https://phabricator.wikimedia.org/T123005#1921795 (10bd808) I don't have any hard numbers timing a destroy && up cycle but my seat of the pants inclination would be that the initial `apt-get update` takes much more time tha... [17:51:56] (03CR) 10DCausse: [C: 031] "not tested yet but looks good" [core] - 10https://gerrit.wikimedia.org/r/261294 (owner: 10EBernhardson) [17:53:54] (03PS55) 10Anomie: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) [17:54:08] (03PS7) 10Anomie: Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 [17:54:16] (03CR) 10jenkins-bot: [V: 04-1] Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) (owner: 10Anomie) [17:54:40] 6RevisionScoringAsAService, 10revscoring: Work out sphinx issues in revscoring docs (attributes not documented) - https://phabricator.wikimedia.org/T123124#1921797 (10Halfak) 3NEW a:3Halfak [17:54:44] (03PS9) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:54:46] (03CR) 10jenkins-bot: [V: 04-1] Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 (owner: 10Anomie) [17:54:50] (03PS9) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [17:55:18] (03PS10) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:55:54] (03CR) 10jenkins-bot: [V: 04-1] Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [17:56:09] (03CR) 10Paladox: "check experimental" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 (owner: 10Paladox) [17:58:19] (03PS10) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [17:58:35] (03CR) 10Anomie: Add "bot passwords" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [17:58:41] (03CR) 10jenkins-bot: [V: 04-1] Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [17:58:44] (03PS11) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [17:59:47] (03CR) 10Anomie: "... Forgot to fetch before rebasing. Sigh." [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) (owner: 10Anomie) [18:00:21] (03PS56) 10Anomie: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) [18:01:43] (03PS12) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [18:03:17] (03PS13) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [18:04:21] (03PS14) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 [18:04:41] (03CR) 10jenkins-bot: [V: 04-1] Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) (owner: 10Anomie) [18:05:00] (03CR) 10Paladox: "check experimental" [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 (owner: 10Paladox) [18:07:18] 6RevisionScoringAsAService, 10ores: Investigate RDB snapshot issue on ORES - https://phabricator.wikimedia.org/T122666#1921826 (10Halfak) @yuvipanda, where are we on this. Didn't you get another changeset merged and the problem was resolved. I seem to remember doing some manual restarts of the uwsgi processe... [18:08:05] 10MediaWiki-Uploading, 6Commons, 6Multimedia: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#1921828 (10Jarekt) 3NEW [18:09:06] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#1921839 (10Krenair) [18:09:11] 6RevisionScoringAsAService, 10rsaas-editquality: Implement balanced not-damaging/maybe-damaging edit extractor for `editquality` - https://phabricator.wikimedia.org/T120999#1921841 (10Halfak) a:5Ladsgroup>3Halfak [18:10:28] (03PS57) 10Anomie: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) [18:10:41] 6RevisionScoringAsAService: Create a talk page post regarding model history - https://phabricator.wikimedia.org/T120399#1921845 (10Halfak) @ToAruShiroiNeko any progress here? [18:10:54] (03PS8) 10Anomie: Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 [18:11:12] 10MediaWiki-extensions-ExtensionDistributor, 7Easy, 3Google-Code-In-2015: Link to the page of the downloaded extension on Special:ExtensionDistributor - https://phabricator.wikimedia.org/T31661#1921847 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/5840594081415168/ [18:11:18] (03PS1) 10Dbrant: Remove unused method. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/263074 [18:11:20] (03PS11) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [18:11:53] 6Research-and-Data, 6RevisionScoringAsAService, 10rsaas-editquality, 3RD-2016Q3: [Epic] Explore disparate impacts of damage detection and goodfaith prediction on anons and newcomers. - https://phabricator.wikimedia.org/T120138#1921848 (10Halfak) I ran a test with the new term frequency features and was abl... [18:12:50] 6RevisionScoringAsAService: Arabic language utilities - https://phabricator.wikimedia.org/T106845#1921849 (10Halfak) a:5ToAruShiroiNeko>3Ladsgroup [18:14:21] (03PS15) 10Niharika29: Initial commit for PageAssessments extension [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/259522 (https://phabricator.wikimedia.org/T121068) [18:14:36] 10MediaWiki-extensions-RandomRootPage, 7Easy, 3Google-Code-In-2015: Merge RandomRootPage extension into MediaWiki core - https://phabricator.wikimedia.org/T109809#1921858 (10Legoktm) Lets do it. https://codein.withgoogle.com/dashboard/tasks/5633643565285376/ [18:15:27] (03CR) 10Niharika29: "Removed logging stuff." [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/259522 (https://phabricator.wikimedia.org/T121068) (owner: 10Niharika29) [18:19:50] 6RevisionScoringAsAService: Describe what campaigns are - https://phabricator.wikimedia.org/T123129#1921860 (10Halfak) 3NEW a:3Halfak [18:19:54] 10MediaWiki-Configuration, 7Easy, 3Google-Code-In-2015: convertExtensionToRegistration.php script should die on global functions (like it does for closures) - https://phabricator.wikimedia.org/T122952#1921869 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/5711651110125568/ [18:23:33] 10MediaWiki-Maintenance-scripts, 7Easy, 3Google-Code-In-2015: importImages.php does not run input file names through UTF8 normalization functions - https://phabricator.wikimedia.org/T78060#1921871 (10Sumit) Imported as https://codein.withgoogle.com/dashboard/tasks/5182105331957760/ [18:26:50] (03PS15) 10Paladox: Add npm and composer-test tests [extensions/Spreadsheet] - 10https://gerrit.wikimedia.org/r/263069 (https://phabricator.wikimedia.org/T65668) [18:27:17] (03CR) 10Mholloway: [C: 032] Remove unused method. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/263074 (owner: 10Dbrant) [18:29:31] (03Merged) 10jenkins-bot: Remove unused method. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/263074 (owner: 10Dbrant) [18:46:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Misleading error message when using wrong datatype in wbcreateclaim and wbeditentity - https://phabricator.wikimedia.org/T93668#1921882 (10Jdlrobson) I'm getting this error for new mw.Api().postWithToken( 'csrf', { action: 'wbcreateclaim', en... [18:48:55] 4(no projects): Labs: High Replication Lag - https://phabricator.wikimedia.org/T123130#1921883 (10Boshomi) 3NEW [18:53:20] 10MediaWiki-Releasing, 6Release-Engineering-Team, 7Security-Extensions: Backport security fixes to stable + LTS extension branches - https://phabricator.wikimedia.org/T108734#1921889 (10greg) Yeah, I think there was some other context that we're forgetting, let's leave it open for a bit and hopefully we'll r... [18:58:23] (03PS2) 10TheDJ: Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 [18:58:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Misleading error message when using wrong datatype in wbcreateclaim and wbeditentity - https://phabricator.wikimedia.org/T93668#1921890 (10Rillke) > What am I doing wrong? The value POST arg must be set to the JSON representation of the value of the... [19:01:12] (03CR) 10jenkins-bot: [V: 04-1] Add parser tests for TMH output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (owner: 10TheDJ) [19:03:10] (03CR) 10Aklapper: "Seems like Legoktm has to clarify here (or in https://phabricator.wikimedia.org/T122968 )" [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [19:03:33] (03CR) 10TheDJ: [C: 04-1] "hmm, this will be interesting, since i cannot even see how you would ever generate content like that... Alternatives are usually either an" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/262926 (owner: 10TheDJ) [19:09:10] (03CR) 10Brian Wolff: [C: 031] "I cant test right now, but this looks correct and almost certainly should be +2'd" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/263029 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [19:13:03] (03CR) 10Legoktm: [C: 04-1] "The goal was to add a sample file, so the file should be named "composer.local.json-sample", and people can copy it over to the right spot" [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [19:14:02] (03CR) 10Legoktm: [C: 032] DynamicPageListHooks: Set parser context title [extensions/intersection] - 10https://gerrit.wikimedia.org/r/263029 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [19:14:47] (03Merged) 10jenkins-bot: DynamicPageListHooks: Set parser context title [extensions/intersection] - 10https://gerrit.wikimedia.org/r/263029 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [19:14:53] (03PS1) 10Legoktm: Fix a bunch of executable-not-elf-or-script lintian warnings [debian] - 10https://gerrit.wikimedia.org/r/263076 [19:17:52] (03PS1) 10Legoktm: Fix watch file [debian] - 10https://gerrit.wikimedia.org/r/263077 [19:28:32] 10MediaWiki-Special-pages: Add a core feature to delete a user - https://phabricator.wikimedia.org/T75280#1921907 (10Luke081515) I think this is not needed. If you want to delete a user, you can use usermerge-extension, and merge all users into one. [19:29:28] 10MediaWiki-Special-pages: Add definitions to Special:ListGroupRights from $wgAutopromote - https://phabricator.wikimedia.org/T16466#1921911 (10Luke081515) p:5Normal>3Triage [19:29:43] legoktm: https://gerrit.wikimedia.org/r/#/c/218584/ Do I just copy the commit message for the sample composer file [19:29:52] kinda yeah [19:30:04] 10MediaWiki-HTML-Templating, 10MediaWiki-HTMLForm: It's impossible to create 1-line vertical indent above or below templates and tables - https://phabricator.wikimedia.org/T123131#1921915 (10MaxBioHazard) 3NEW [19:34:03] 10MediaWiki-RfCs, 10Architecture, 10Graph, 10Graphoid, and 3 others: Graph/Graphoid/Kartographer - data storage architecture - https://phabricator.wikimedia.org/T119043#1921925 (10Yurik) A much simpler proposal that will solve most issues with very little effort: * On parse (view & parse), store hash->dat... [19:37:14] (03PS3) 10Ananay: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) [19:37:35] 10MediaWiki-Releasing, 6Release-Engineering-Team, 7Security-Extensions: Backport security fixes to stable + LTS extension branches - https://phabricator.wikimedia.org/T108734#1921937 (10demon) The context so far has basically been that we don't worry about backporting if it's not a bundled extension. That sh... [19:37:46] (03PS1) 10JGirault: Modifies Play button and layover because the previous layover was hiding the static graph [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263079 [19:40:49] (03CR) 10JGirault: "@yurik: we also need to remove the labels we introduced, right?" [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263079 (owner: 10JGirault) [19:42:49] (03CR) 10Legoktm: [C: 032 V: 032] Fix a bunch of executable-not-elf-or-script lintian warnings [debian] - 10https://gerrit.wikimedia.org/r/263076 (owner: 10Legoktm) [19:43:42] (03CR) 10Legoktm: [C: 032 V: 032] Fix watch file [debian] - 10https://gerrit.wikimedia.org/r/263077 (owner: 10Legoktm) [19:43:54] 6Phabricator: Mark existing projects as subprojects - https://phabricator.wikimedia.org/T123078#1921947 (10Luke081515) [19:48:08] (03PS2) 10JGirault: Modifies Play button and layover because the previous layover was hiding the static graph [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263079 (https://phabricator.wikimedia.org/T120146) [19:52:29] legoktm: pushed the new changes to https://gerrit.wikimedia.org/r/263036 [19:54:11] (03CR) 10MaxSem: "I'd like to get some credit for my extension that gets merged, albeit in a rewritten state." [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) (owner: 10Anomie) [19:54:51] (03PS1) 10MtDu: Use ar_page_id in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/263080 (https://phabricator.wikimedia.org/T28123) [20:01:51] 10MobileFrontend, 10Reading-Web: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1921962 (10Florian) [20:09:48] (03PS4) 10D3r1ck01: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:10:12] (03CR) 10Legoktm: Add a composer.local.json-sample to MediaWiki core (033 comments) [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:10:24] (03CR) 10Legoktm: [C: 04-1] "See comments on PS3." [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:10:54] 6Developer-Relations, 3DevRel-February-2016: Gather feedback from GCI mentors after GCI 2015 - https://phabricator.wikimedia.org/T123134#1921965 (10Aklapper) 3NEW [20:11:04] 6Developer-Relations, 3DevRel-February-2016: Gather feedback from GCI mentors after GCI 2015 - https://phabricator.wikimedia.org/T123134#1921965 (10Aklapper) a:3Aklapper [20:13:01] (03PS5) 10Ananay: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) [20:15:18] (03PS6) 10Ananay: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) [20:15:22] (03PS27) 10Llyrian: Implement datatype 'Math' for Wikidata [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) [20:16:12] (03CR) 10Yurik: [C: 032] Modifies Play button and layover because the previous layover was hiding the static graph [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263079 (https://phabricator.wikimedia.org/T120146) (owner: 10JGirault) [20:16:25] 10MediaWiki-extensions-Drafts: Enable draft namespace on Kannada Wikipedia - https://phabricator.wikimedia.org/T123067#1921972 (10Aklapper) Setting project to "Wikimedia-Site-Requests" project as this request is about settings / configuration of a Wikimedia website. For information about how to request these ki... [20:16:41] 10Wikimedia-Site-Requests: Enable draft namespace on Kannada Wikipedia - https://phabricator.wikimedia.org/T123067#1921973 (10Aklapper) p:5Normal>3Triage [20:17:40] (03Merged) 10jenkins-bot: Modifies Play button and layover because the previous layover was hiding the static graph [extensions/Graph] - 10https://gerrit.wikimedia.org/r/263079 (https://phabricator.wikimedia.org/T120146) (owner: 10JGirault) [20:17:54] d3r1ck: https://gerrit.wikimedia.org/r/263036 [20:18:40] 10MediaWiki-API, 10Wikimedia-General-or-Unknown: Consistently getting "Our servers are currently experiencing a technical problem." error to API queries - https://phabricator.wikimedia.org/T123030#1921990 (10Aklapper) 5Open>3stalled Changing status to "Stalled". Please reset to "open" once a test case has... [20:18:54] (03PS28) 10Physikerwelt: Implement datatype 'Math' for Wikidata [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [20:23:40] legoktm: Made the accordingly: https://gerrit.wikimedia.org/r/263036 [20:23:46] (03CR) 10Hashar: [C: 031] Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:24:01] hi [20:24:30] could you please tell me what should I do with my task? How am I supposed to do it if none of the responsible guys are available [20:24:30] ? [20:25:04] (03PS7) 10Legoktm: Add a composer.local.json-sample to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:25:15] (03CR) 10Legoktm: [C: 032] "Awesome!" [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:25:29] (03PS8) 10Legoktm: Add a composer.local.json-sample Bug: T122968 Change-Id: Ib13417b0c29b6fd2b3aaea6808fde3f3c12393e6 [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:25:39] (03PS9) 10Legoktm: Add a composer.local.json-sample [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:25:54] (03CR) 10Legoktm: [C: 032] "(sorry about the commit message changes)" [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:27:13] (03CR) 10D3r1ck01: "Hmmm, it looks good to me so far. Thanks for the work." [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:27:39] (03CR) 10Ananay: "Thank you everyone! :)" [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:28:03] 10MediaWiki-General-or-Unknown, 10Librarization, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Add a composer.local.json-sample to MediaWiki core - https://phabricator.wikimedia.org/T122968#1922021 (10ananayarora) a:3ananayarora [20:28:34] 10MediaWiki-General-or-Unknown, 10Librarization, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Add a composer.local.json-sample to MediaWiki core - https://phabricator.wikimedia.org/T122968#1922022 (10ananayarora) 5Open>3Resolved [20:28:50] 3Discovery-Analysis-Sprint: Write up version of portal report for Commons - https://phabricator.wikimedia.org/T123137#1922023 (10Ironholds_backup) 3NEW [20:28:54] legoktm: Its time to approve the task in the GCI system. Let me do that now :) [20:29:03] I already did [20:29:20] legoktm: Ohhh, nice. [20:29:44] Thank You d3r1ck & legoktm ^_^ [20:29:49] legoktm: didn't get a notification :) [20:30:15] 10MediaWiki-extensions-ContactPage: ContactPage Catchable fatal error (due to ConfirmEdit/ReCaptcha/QuestyCaptcha incompatibility?) - https://phabricator.wikimedia.org/T122430#1922030 (10Aklapper) [20:31:00] (03Merged) 10jenkins-bot: Add a composer.local.json-sample [core] - 10https://gerrit.wikimedia.org/r/263036 (https://phabricator.wikimedia.org/T122968) (owner: 10Ananay) [20:31:42] d3r1ck: Did you get a notification in Phabricator? [20:31:55] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922043 (10demon) 3NEW a:3demon [20:32:06] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922051 (10demon) 5Open>3Resolved [20:33:46] (03PS1) 10Florianschmidtwelzow: Fix lead section handling in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263081 (https://phabricator.wikimedia.org/T122471) [20:33:54] 10Wikimedia-SVG-rendering: rendering .png preview of .svg drawing is buggy - https://phabricator.wikimedia.org/T123106#1922057 (10brion) [20:37:17] 10MediaWiki-HTML-Templating, 10MediaWiki-HTMLForm: It's impossible to create 1-line vertical indent above or below templates and tables - https://phabricator.wikimedia.org/T123131#1922059 (10Aklapper) This does not seem to be related to [[ https://phabricator.wikimedia.org/project/profile/540/ | HTMLForm]] or... [20:37:36] 10MediaWiki-General-or-Unknown, 10MediaWiki-Templates: It's impossible to create 1-line vertical indent above or below templates and tables - https://phabricator.wikimedia.org/T123131#1922060 (10Aklapper) [20:37:42] 10MediaWiki-API, 10Wikimedia-General-or-Unknown: Consistently getting "Our servers are currently experiencing a technical problem." error to API queries - https://phabricator.wikimedia.org/T123030#1922063 (10Anomie) 5stalled>3Invalid a:3Anomie Even the reporter can't provide a test case, so for now I'm g... [20:37:55] 10MediaWiki-API, 10Wikimedia-General-or-Unknown: Consistently getting "Our servers are currently experiencing a technical problem." error to API queries - https://phabricator.wikimedia.org/T123030#1922066 (10Anomie) a:5Anomie>3None [20:38:10] 10MediaWiki-General-or-Unknown, 10MediaWiki-Templates: It's impossible to create 1-line vertical indent above or below templates and tables - https://phabricator.wikimedia.org/T123131#1921915 (10Aklapper) > How I can create 1-line vertical gap above or below template or table? Have you asked this support ques... [20:38:19] (03CR) 10Gergő Tisza: [C: 04-1] "Please test your patches before submitting them. If it's not clear how a given change can be tested, you can always ask on IRC or Phabrica" [core] - 10https://gerrit.wikimedia.org/r/263080 (https://phabricator.wikimedia.org/T28123) (owner: 10MtDu) [20:38:35] 10MediaWiki-General-or-Unknown, 10MediaWiki-Templates: Impossible to create 1-line vertical indent above or below templates and tables - https://phabricator.wikimedia.org/T123131#1922068 (10Aklapper) [20:39:41] 10MediaWiki-General-or-Unknown, 10MediaWiki-Templates: Impossible to create 1-line vertical indent above or below templates and tables - https://phabricator.wikimedia.org/T123131#1921915 (10Aklapper) Why do you want to create a 1-line vertical indent ? Please provide a use case / underlying problem definition... [20:41:55] tgr: How would I test this? https://gerrit.wikimedia.org/r/#/c/263080/ [20:42:48] (03CR) 10jenkins-bot: [V: 04-1] Fix lead section handling in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263081 (https://phabricator.wikimedia.org/T122471) (owner: 10Florianschmidtwelzow) [20:45:54] MtDu: make a page,check page id, delete, undelete it, check page id. Also create a page with the old id after a delete, undelete and check if any errors occur [20:47:36] violetto, are you there? [20:47:50] I hope restoring ar_page_id don't break grabbers :( [20:49:23] MtDu: you can see the page id under the "page info" link [20:49:35] it's in the left toolbar on the page [20:50:32] or you can query the DB if you prefer that, or run some php command via the maintenance/eval.php helper script which bootstraps the mediawiki environment for a PHP REPL, if you prefer that [20:50:53] so check the id, delete the page, undelete the page, check if the id is the same [20:51:01] tgr, are you aware of design things here? [20:51:28] victorbarbu_: probably not, although that's a pretty vague question [20:51:38] I am very lucky [20:51:53] my mentors are generally not available or don't care [20:51:55] I am aware of some as a random bystander but definitely not the best person to ask about design [20:52:09] I don't even know of what the tasks asks from me [20:52:18] https://phabricator.wikimedia.org/T104836 [20:52:28] what do you understand from this? [20:52:52] do they want me to change all instances of form overlays or that particular one? [20:53:33] 10MediaWiki-API, 10Wikimedia-General-or-Unknown: Consistently getting "Our servers are currently experiencing a technical problem." error to API queries - https://phabricator.wikimedia.org/T123030#1922077 (10Yurivict) No, your assumption is wrong. I have been seeing this for many months, and I am sure this wil... [20:53:45] (03PS1) 10Legoktm: Override source-is-missing for resources/lib/jquery/jquery.validate.js [debian] - 10https://gerrit.wikimedia.org/r/263082 [20:54:06] victorbarbu_: it says "talk overlays", so that's a specific form [20:54:13] but [20:54:25] (03CR) 10Legoktm: [C: 032 V: 032] Override source-is-missing for resources/lib/jquery/jquery.validate.js [debian] - 10https://gerrit.wikimedia.org/r/263082 (owner: 10Legoktm) [20:54:26] the stylesheets target all form-ish overlays [20:54:55] so you probably need to add a specific class, if there isn't one already [20:55:15] well, yeah, but it's a little bit strange. [20:55:16] whatever [20:56:16] 10MediaWiki-User-blocking, 7Community-Wishlist-Survey: Improve MediaWiki's blocking tools - https://phabricator.wikimedia.org/T120734#1922079 (10JEumerus) [20:56:35] victorbarbu_: try asking on #wikimedia-mobile [20:57:13] also today is not the best day for quick help, WMF has a teambuilding-ish event [20:57:55] i'll see if one of the designers is around though [20:59:40] tgr: Ugh. my vagrant seems to not be working again. Is there a way to test my local edits without that? [21:00:04] MtDu, what's the error? [21:00:17] 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1922080 (10PamD) Does the explanation for the problem account for the page where two sections had no edit icons and later icons referred to last-but-one... [21:00:24] victorbarbu_: 503 service error [21:00:31] well [21:00:37] try vagrant ssh [21:00:37] then [21:00:40] (03PS2) 10Florianschmidtwelzow: Fix lead section handling in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263081 (https://phabricator.wikimedia.org/T122471) [21:00:44] sudo service hhvm start [21:00:52] what do you get? [21:01:58] victorbarbu_: hhvm start/running, process 5596 [21:02:32] (03PS3) 10Florianschmidtwelzow: Fix lead section handling in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263081 (https://phabricator.wikimedia.org/T122471) [21:02:41] realod in the browser [21:03:31] if this solved it, then go back to your vm's interface and enter this [21:03:31] sudo update-rc.d hhvm defaults [21:03:45] (this will start you hhvm service at system startup) [21:04:40] victorbarbu: Ok thanks. Is core supposed to be located in vagrant/mediawiki? That's where I cloned it. [21:04:47] victorbarbu_:^ [21:05:10] you shouldn't have cloned it [21:05:15] didn't you get the whole vagrant? [21:05:23] I mean, the prepared one? [21:05:30] (03CR) 10Paladox: [C: 04-1] [WIP] Convert VipsScaler to use new extension registration (034 comments) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [21:05:59] victorbarbu_: Yeah, but where is it default located? [21:06:09] 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1922083 (10Florian) >>! In T122471#1922080, @PamD wrote: > Does the explanation for the problem account for the page where two sections had no edit icon... [21:06:21] in the vm (aka the guest), the core is in /vagrant/mediawiki [21:06:39] on your host, wherever you downloaded the vm + vagrant/mediawiki [21:07:08] Lots of ping timeouts and my client is slow too… [21:07:27] O_o https://phabricator.wikimedia.org/T16466#1921911 [21:08:07] victorbarbu_: well it's not. So is it okay if I cloned it? [21:08:32] go to your vm console [21:08:39] and enter [21:08:40] cd / [21:08:46] (03PS4) 10Florianschmidtwelzow: Fix lead section handling in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263081 (https://phabricator.wikimedia.org/T122471) [21:08:46] ls -la [21:08:55] do you see any "vagrant" there? [21:09:07] Hey victorbarbu_, have you had to use the ‘commons’ vagrant role, and did it work for you? It hasn’t been working for me (see T122863) [21:09:19] unicornisaurous: why an IRC server in the Netherlands? [21:09:29] Nemo_bis: uh [21:09:31] unicornisaurous, use it for what? [21:09:53] Nemo_bis: My IRC client kinda does whatever it wants to [21:10:39] victorbarbu_: Well I need to use it to test a patch that depends on commons. I have a patch that needs to depend on your imageinfo api patch :P [21:11:06] oh [21:11:09] link? :D [21:11:23] OMG THAT ONE WAS A PAIN [21:11:25] really [21:11:51] unicornisaurous: you could try morgan https://freenode.net/irc_servers.shtml [21:12:36] Volker_E, hi! [21:12:38] you there? [21:12:57] victorbarbu_: This is my patch from a week or so ago which needs to use what you added at some point: https://gerrit.wikimedia.org/r/#/c/260955/, I’ve been trying to test your patch out but I can’t since the commons role doesn’t work. So you didn’t have any problems with it? [21:12:57] Not really recommended to hardcode an IRC server but if your client chooses so badly then maybe [21:13:29] Nemo_bis: My server is entered in as irc.freenode.net :/ [21:13:44] unicornisaurous: can certainly be customised one way or another [21:13:53] unicornisaurous, the commons role worked for me [21:14:09] did you run vagrant roles-enable commons; vagrant provision; vagrant reload ? [21:14:12] Nemo_bis: Okie, I’ll try. I don’t think its picked badly in the past [21:14:14] ugh now I see your OS ;) then I rescind my certainty [21:14:25] :P [21:14:32] How can you see that? [21:14:43] victorbarbu_: Everything but the last one.. [21:15:06] I don’t think a reload would do anything database wise [21:15:43] I am not sure [21:15:56] don't you see a database like 'commonswiki'? [21:16:11] I do…but it doesn’t work, see T122863 [21:17:06] it worked for me [21:17:07] idk [21:17:09] :-? [21:21:36] victorbarbu_: unicornisaurous: vagrant reload is only needed when you update the vagrant code itself [21:22:00] ie when you do a git pull in the root directory [21:22:05] tgr: Ok, thats what I thought, thanks! [21:22:13] even then it's not needed most of the time [21:22:41] 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1922084 (10PamD) All the problems I have encountered and reported have been in article namespace - please read my earlier detailed posts. It was someone... [21:22:57] there are a few cases when a vagrant role needs a reload, to set up port forwards or add more CPU cores or something, but in those cases the provisioner should be able to trigger it [21:23:30] unicornisaurous: what's not working with the commons role? [21:24:08] ah, ok, you filed a bug about it [21:24:12] yes :) [21:25:40] so yeah, that's because the maintenance script that updates the DB schema was not successfully run [21:26:30] multiwiki is a horrible mess so don't even try debugging that :) [21:26:47] 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1922085 (10Florian) Sorry, I can't reproduce the problems you described at any page, nor on neither on https://en.m.wikipedia.org/w/index.php?title=Vija... [21:27:01] the correct way to run it is mwscript update.php --wiki commonswiki, if that does not work it's a bug [21:27:05] But when I run the update script myself, one of the things it prints says that the globalimagelinks table already exists. [21:27:24] I haven’t tried with mwscript [21:27:39] if you get the parameter wrong, it will just use the default wiki where it presumably does exist [21:27:47] But I tried invoking it with php - see T122868 [21:28:04] 10MediaWiki-Database: LoadBalancer::commitMasterChanges: Flushing an explicit transaction, getting out of sync! - https://phabricator.wikimedia.org/T45576#1922086 (10Nemo_bis) >>! In T45576#1919148, @aaron wrote: > Does this still occur (given https://gerrit.wikimedia.org/r/#/c/121402/ and many other changes sin... [21:29:09] Okay well mwscript gives an ugly error [21:29:21] can you paste that to the bug? [21:29:33] Give me a minute, I disabled the role since I wrote the bug [21:29:40] (03CR) 10Cindy-the-browser-test-bot: "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/263095 (owner: 10L10n-bot) [21:33:14] tgr: now that I ran it with mwscript it works fine :/ [21:33:44] that'a a :) as far as I am concerned :) [21:34:27] haha [21:34:37] granted, it's not great DX that the script allows itself to be run in wrong ways [21:35:09] but vagrant multiwiki has too much duct tape for me [21:35:24] Yeah, since running it using php instead of mwscript is still broken [21:35:43] feel free to file a bug about more intelligent error handling / better documentation [21:36:02] you are not supposed to do that [21:36:15] I know, would be nice if we actually told you... [21:36:51] Don't we have something on production that causes running scripts not in mwscript fails? [21:36:54] 10MediaWiki-Vagrant: Vagrant 'commons' role doesn't create proper database tables - https://phabricator.wikimedia.org/T122863#1922091 (10Unicornisaurous) 5Open>3Invalid a:3Unicornisaurous [21:37:11] OTOH if you are willing to fix that as a GCI task... :) [21:37:19] tgr: for checking if ar_page_id, I'm not supposed to check if it's true, just if it exists right? So I would use isset? [21:37:27] Reedy: only for running with the wrong user, I think? [21:37:36] * Reedy looks [21:37:37] 10MediaWiki-Maintenance-scripts: Maintenance script --wiki parameter doesn't seem to work - https://phabricator.wikimedia.org/T122868#1922095 (10Unicornisaurous) 5Open>3Invalid a:3Unicornisaurous Use mwscript! [21:37:41] but I'm not sure you need mwscript in production [21:37:53] the vagrant one has more magic in it IIRC [21:39:01] tgr: I’d do that as a task sometime [21:39:03] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922098 (10demon) [21:39:25] (03PS29) 10Llyrian: Implement datatype 'Math' for Wikidata [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) [21:39:29] reedy@tin:/srv/mediawiki-staging/php-1.27.0-wmf.9$ php maintenance/eval.php [21:39:29] No MWMultiVersion instance initialized! MWScript.php wrapper not used? [21:39:45] But vagrant multiversion is a fork of upstream [21:40:07] 10MediaWiki-Vagrant: Vagrant 'commons' role doesn't create proper database tables - https://phabricator.wikimedia.org/T122863#1922103 (10Tgr) `vagrant provision` shows error messages in red when something fails but it is easy to miss in the huge wall of text. I don't know if we have any way to control that; as I... [21:40:17] php maintenance/eval.php doesn’t complain for me in vagrant [21:40:51] Yeah [21:40:54] It probably should [21:40:56] Which is the bug [21:41:00] Same for the updater etc [21:41:14] bd808: ^ are you up to mentoring someone on improving vagrant multiwiki? :) [21:41:19] heh [21:41:25] Like I say, it's a fork of some sort [21:41:26] Cut down [21:41:32] I think someone cut too much code out of it :) [21:41:54] # Rewrite commands given to wfShellWikiCmd() to use Het-Deploy [21:41:54] $wgHooks['wfShellWikiCmd'][] = 'MWMultiVersion::onWfShellMaintenanceCmd'; [21:41:57] I *think* it's that [21:42:20] 10MediaWiki-Vagrant: Vagrant 'commons' role doesn't create proper database tables - https://phabricator.wikimedia.org/T122863#1922104 (10Unicornisaurous) @tgr: There wasn't any red I don't believe. If it was trying to run the updates on the main wiki instead of the commonswiki it would pretend to succeed anyway,... [21:43:06] tgr: ^ [21:43:50] MtDu: checking whether it's truish should be fine [21:44:16] 10MediaWiki-extensions-Gadgets, 3Community-Tech-Sprint, 7Documentation, 5Gadgets-2.0: Gadgets 2.0: Write documentation - https://phabricator.wikimedia.org/T118224#1922106 (10DannyH) a:3kaldari [21:45:18] (03PS1) 10Mhutti1: Fixed verification-error due to incorrect timeout handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T11905) [21:45:45] tgr: isn't it an integer though? [21:46:14] if it's set, sure [21:46:50] if it's not set, which is probably B/C for archive table records that have been created long ago, it's going to be null [21:47:01] does the resource loader work for autoprefixing in less? [21:47:14] tgr: I would totally work with someone on making mw-v's multiwiki better [21:47:17] (03PS2) 10Mhutti1: Fixed verification-error due to incorrect timeout handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/263142 (https://phabricator.wikimedia.org/T119053) [21:47:23] * bd808 reads backscroll [21:47:33] tgr: ok. So I'll leave it at what it is. Is there some case in missing? [21:48:02] bd808: short story, there is no warning / pointing to the right direction if you use php instead of mwscript [21:48:21] tgr: I'm* [21:48:24] things don't break in any obvious way but the result is probably still wrong [21:49:05] tgr: ah. that is actually a problem that has been talked about a bit before [21:49:08] MtDu: can you explain why you are doing what you are doing? [21:49:16] it does not make much sense to me [21:49:41] tgr: I'm checking if the ar_page_id exists [21:49:42] 10MediaWiki-extensions-EducationProgram: Localised name for Educational Program in russian - https://phabricator.wikimedia.org/T123140#1922116 (10Iniquity) 3NEW [21:50:10] I mean, the whole patch [21:50:11] tgr: if it does, then I use that. If it doesn't then I use the original code [21:51:12] MtDu: so here is the bird's eye view of the issue [21:51:39] (03PS1) 10Victorbarbu: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) [21:51:46] when you delete a page MediaWiki deletes the page row and stores the page id in the archive table [21:52:10] (currently; old versions didn't so you cannot always rely on it being stored there) [21:52:23] (03CR) 10Anomie: "At the moment there's no credit for anyone in this patch. What credit would you suggest, and where?" [core] - 10https://gerrit.wikimedia.org/r/209570 (https://phabricator.wikimedia.org/T89386) (owner: 10Anomie) [21:52:32] Ah [21:52:32] if ( !class_exists( 'MWMultiVersion' ) ) { [21:52:33] print "No MWMultiVersion instance initialized! MWScript.php wrapper not used?\n"; [21:52:33] exit(1); [21:52:33] } [21:53:02] ^ that [21:53:16] when you restore the page, a new row is inserted, and no id is specified, so the SQL engine just selects the next free id [21:53:40] 7Design, 10MobileFrontend, 3Google-Code-In-2015, 5Patch-For-Review: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1922126 (10Victorbarbu) I decided not to set the panel to fit the screen's width, It seems to look better. Also, the `max-width` seems to only show on deskt... [21:53:42] you need to find the place where the row is inserted and specify the id if there is one [21:53:52] your patch does not do anything like that [21:53:58] 10Hovercards, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Hovercards: Add `lang` and `dir` attributes to the `.mwe-popups-extract` - https://phabricator.wikimedia.org/T68114#1922127 (10Jdlrobson) [21:54:22] tgr: ok. Thanks for the birds eye view. I was kind of going in the dark [21:54:41] has anyone heard about baha [21:54:45] is he a real person? [21:54:54] victorbarbu_: yes. [21:55:13] he doesn't have a gerrit account [21:55:39] victorbarbu_: he's on phabricator isn't he? [21:55:47] 10MediaWiki-Revision-deletion, 10MobileFrontend, 5Patch-For-Review: Wrong links on Special:MobileDiff to delete log when looking at revision deleted diff - https://phabricator.wikimedia.org/T122984#1922128 (10Jdlrobson) p:5High>3Normal [21:55:55] it's bmansurov I think? [21:56:16] apparently not on my task [21:56:18] (03CR) 10Jdlrobson: [C: 032] Fix false inclusion of FULLPAGENAME on Special:MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263063 (https://phabricator.wikimedia.org/T122984) (owner: 10Florianschmidtwelzow) [21:56:20] even if he's the mentor [21:56:29] 10Unofficial-Apps-Wikipedia-Windows-8, 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1922130 (10Rezonansowy) Here's the Commons category for this app - https://commons.wikimedia.org/wiki/Category:Wikipedia_Metro_App [21:56:32] victorbarbu_: yeah it's me [21:56:34] what's up [21:56:34] ? [21:56:44] Ohh, that;s you [21:56:53] I have uploaded a patch related to my task [21:58:39] tgr: Ugh [21:58:40] https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/mediawiki/templates/multiwiki/CommonSettings.php.erb#L12-L18 [21:58:50] if no multiversion, default to default wiki [21:59:05] (03PS1) 10Legoktm: Log URL changes to EventLogging if configured [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/263145 (https://phabricator.wikimedia.org/T115119) [22:00:56] 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1922134 (10PamD) No, I do not know how to get a screen shot off my mobile phone. It's a Samsung Galaxy Ace 4, using Android 4.4.4 I believe I'm using a... [22:00:57] (03CR) 10jenkins-bot: [V: 04-1] Log URL changes to EventLogging if configured [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/263145 (https://phabricator.wikimedia.org/T115119) (owner: 10Legoktm) [22:01:57] (03PS2) 10Jdlrobson: Add ResourceLoader::resetLessVars method [core] - 10https://gerrit.wikimedia.org/r/263006 [22:02:16] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: [Task] Use HashSiteStore in Wikibase, instead of MockSiteStore - https://phabricator.wikimedia.org/T91511#1922135 (10aude) 5Open>3Resolved a:3hoo [22:02:43] (03PS1) 10Yaron Koren: Switched to using "middle dot" as delim for all list values [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/263146 [22:03:29] (03PS8) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [22:04:50] 10MediaWiki-Change-tagging, 10MediaWiki-Export-or-Import, 3Google-Code-In-2015: The export and import processes should transport revision tags - https://phabricator.wikimedia.org/T22691#1922139 (10Mattflaschen) This is out of scope for GCI. There are various issues, like extension-specific tags and local wi... [22:04:58] 10MediaWiki-Change-tagging, 10MediaWiki-Export-or-Import: The export and import processes should transport revision tags - https://phabricator.wikimedia.org/T22691#1922140 (10Mattflaschen) [22:05:04] (03PS9) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [22:05:19] (03PS3) 10Jdlrobson: Add ResourceLoader::resetLessVars method [core] - 10https://gerrit.wikimedia.org/r/263006 [22:06:10] (03CR) 10Jdlrobson: "getLessCompiler is static thus this also needs to be static." [core] - 10https://gerrit.wikimedia.org/r/263006 (owner: 10Jdlrobson) [22:06:54] (03CR) 10Yaron Koren: [C: 032 V: 031] Switched to using "middle dot" as delim for all list values [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/263146 (owner: 10Yaron Koren) [22:07:50] unicornisaurous: you can use Depends-On: for cross-repo dependencies [22:07:50] (03CR) 10Chad: "Are you sure about EditPage & co? Last I saw some of the Semantic* extensions still relied on them being set." [core] - 10https://gerrit.wikimedia.org/r/263030 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [22:08:04] tgr: I was literally just googling that [22:08:25] it's fairly new so it might not be documented well [22:08:42] (03Merged) 10jenkins-bot: Fix false inclusion of FULLPAGENAME on Special:MobileDiff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263063 (https://phabricator.wikimedia.org/T122984) (owner: 10Florianschmidtwelzow) [22:08:47] 10MediaWiki-RfCs, 10Architecture, 10Graph, 10Graphoid, and 3 others: Graph/Graphoid/Kartographer - data storage architecture - https://phabricator.wikimedia.org/T119043#1922146 (10tstarling) >>! In T119043#1921925, @Yurik wrote: > * if not exists, check Memcached for title, and fail if title exists and its... [22:09:20] Cool! I only rebased so far, I need to actually use what victorbarbu_’s patch exposed in the api now [22:10:14] Reedy: are you fixing that, or can I make a GCI task from it? [22:10:28] (03CR) 10Bmansurov: [C: 04-1] "You should use an input class from http://tools.wmflabs.org/styleguide/desktop/section-1.html#section-1.1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [22:10:57] (03PS10) 10Sn1per: Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) [22:10:59] tgr: https://github.com/wikimedia/mediawiki-vagrant/commit/27253a268a0d15064ed0556875a48d65f86137df [22:11:13] (03PS1) 10Jdlrobson: Do not cache less variables in static function [core] - 10https://gerrit.wikimedia.org/r/263147 [22:11:17] It looks like a deliberate change by bd808 [22:11:23] (03CR) 10Jdlrobson: "Alternative patch at https://gerrit.wikimedia.org/r/263147" [core] - 10https://gerrit.wikimedia.org/r/263006 (owner: 10Jdlrobson) [22:11:56] https://phabricator.wikimedia.org/T71520 [22:12:14] (03CR) 10Jdlrobson: [C: 032] Set mobile flag for autologin js [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/233091 (https://phabricator.wikimedia.org/T100413) (owner: 10CSteipp) [22:12:20] tgr: I guess, we should just be adding a message saying what it's doing [22:12:29] Rather than doing it silently, if we've already changed it for areason [22:12:36] (03Abandoned) 10Sn1per: Don't include success=1 in Special:Preferences "Special Page" tab link [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) (owner: 10Sn1per) [22:13:01] 10MediaWiki-extensions-CentralAuth, 6Commons, 6Security-Team, 5Patch-For-Review: "You are centrally logged in." toast on every page view on commons - https://phabricator.wikimedia.org/T100413#1922150 (10Jdlrobson) 5stalled>3Open [22:13:18] bd808 might disagree but I prefer throwing fatals over choosing potentially wrong defaults [22:13:19] (03CR) 10Sn1per: [C: 04-1] "Severe WIP, don't bother reviewing atm" [core] - 10https://gerrit.wikimedia.org/r/260681 (https://phabricator.wikimedia.org/T120733) (owner: 10Sn1per) [22:13:42] of course the old message wasn't really helpful [22:13:45] tgr: I guess a better message is needed [22:13:47] heh :) [22:13:47] 10MediaWiki-API, 7Easy, 3Google-Code-In-2015: Expose "actual watchers" as in "action=info" via API call {action: query, prop: info} - https://phabricator.wikimedia.org/T105392#1922152 (10Sn1per) a:3Sn1per [22:14:33] And/or we special case for phpunit [22:14:35] the really clever solution would be to only fatal if there are actually multiple wikis, no idea how difficult that is though [22:14:46] (03Merged) 10jenkins-bot: Set mobile flag for autologin js [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/233091 (https://phabricator.wikimedia.org/T100413) (owner: 10CSteipp) [22:14:48] Errm, shouldn't be too bad [22:14:49] Hang on [22:15:48] tgr: Nothing in the code now, but it should be easy [22:16:17] count( $wgLocalDatabases ) or similar should get most of the way [22:16:18] (03PS2) 10Victorbarbu: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) [22:16:23] tgr: So back to before. You said I need to find where the $row is inserted into $db in the file? [22:16:28] Do we have a task for this? [22:16:32] 10MobileFrontend, 10Reading-Web, 5Patch-For-Review: Mobile edit icon does not always point to correct section id - https://phabricator.wikimedia.org/T122471#1922165 (10Florian) It should be possible to use the "Volume Down" + "Power" key (press at the same time) to get a screenshot. It should be always poss... [22:17:01] 10MediaWiki-Revision-deletion, 10MobileFrontend, 5Patch-For-Review: Wrong links on Special:MobileDiff to delete log when looking at revision deleted diff - https://phabricator.wikimedia.org/T122984#1922166 (10Florian) 5Open>3Resolved [22:17:50] (03PS5) 10Paladox: [WIP] Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) (owner: 10MtDu) [22:19:03] tgr: I'll file a task? [22:19:11] Reedy: doing it [22:19:19] Ok, cool :) [22:19:26] task for what? [22:19:28] php-related? [22:19:42] 3Mobile-App-Android-Sprint-72-Hafnium, 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Expose definition end point in public REST API on Wiktionary - https://phabricator.wikimedia.org/T123142#1922168 (10GWicke) 3NEW a:3Mholloway [22:20:03] (03CR) 10Jdlrobson: [C: 031] Refine design on New Talk overlay (MobileFrontend) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [22:20:14] victorbarbu_: It could be a GCI task, and yes [22:20:23] Improving multiwiki handling in vagrant [22:20:27] I know for gci [22:20:31] but what is it about? [22:20:36] if it's php, i'm in [22:20:40] I didn't say it would be a GCI task [22:20:48] It could be, but isn't necesserily [22:21:06] uuuuuuu [22:21:11] niiiice [22:21:25] Wait for the task to be filed, and then we'll sort out :) [22:21:38] (03PS6) 10MtDu: Convert VipsScaler to use new extension registration [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/263028 (https://phabricator.wikimedia.org/T87991) [22:22:00] 10MediaWiki-Vagrant: Running maintenance scripts without mwscript fails silently on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T123143#1922179 (10Tgr) 3NEW [22:22:16] Reedy: https://phabricator.wikimedia.org/T123143 [22:23:09] 7Design, 10MobileFrontend, 7Epic: [Epic] push categories button to stable - https://phabricator.wikimedia.org/T24660#1922190 (10Jdlrobson) [22:24:16] MtDu_: how familiar are you with SQL? [22:24:38] (03PS3) 10Victorbarbu: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) [22:24:42] tgr: Not that familiar. Sorry. GCI has taught me a lot, but not SQL yet. [22:25:41] tgr: Um. Is there anything I should read? [22:26:33] tgr, about sql [22:26:36] Ifound out [22:26:43] that wikimedia wants to librarize [22:26:47] the modules [22:27:09] and since MediaWiki has the best DAL, in my opinion [22:27:17] I want to start working on a DAL library [22:27:41] how should I start? on my own, or I will be provided with a gerrit repo or something? [22:27:43] 10MediaWiki-Vagrant: Running maintenance scripts without mwscript fails silently on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T123143#1922206 (10Reedy) Change was made for T71520, and this task is a follow on from T122863 On WMF wikis we have ``` if ( !class_exists( 'MWMultiVersion' ) ) { p... [22:27:43] victorbarbu_: that sounds a bit too ambitious [22:28:03] 10MediaWiki-Email, 10MediaWiki-Interface, 10MediaWiki-Special-pages, 5MW-1.27-release-notes, and 3 others: [Regression] Special:EmailUser and Special:ExpandTemplates broken after OOUI conversion - https://phabricator.wikimedia.org/T122907#1922211 (10Krinkle) p:5High>3Unbreak! [22:28:12] although maybe I'm not thinking about the same thing you are when you say DAL [22:28:14] not really. the only thing that might be problematic is understanding the LoadBalancer [22:28:31] but the rest is not hard. it's just much work, because it's a big module [22:28:48] victorbarbu_: basically, you are trying to move the current DAL into its own library? [22:28:49] The DB classes are potentially highly coupled to WM core stuff [22:28:53] I want to implement this module in Hack for myself [22:28:54] yes [22:29:17] bd808: ^ [22:30:08] I'm not that familiar with that area but my impression is there are some "plumbing" classes that would have to be librarized first and that's harder than it looks [22:30:10] (03CR) 10Krinkle: "The other messages should be changed back as well from before b1ff754dd7889b757fa280d71905add34b7e566f." [core] - 10https://gerrit.wikimedia.org/r/263037 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [22:30:30] Message, Status, database exceptions [22:30:37] Yeah, exactly [22:30:49] the interaction with the configuration [22:30:58] I would work with database exceptions as well [22:31:08] but I think they should go in the same library with database [22:31:13] that seems logical [22:31:17] (03CR) 10Paladox: [C: 031] i18n: missing metadata block in aeb-arab [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263049 (owner: 10Hashar) [22:31:25] Yeah, it was [22:31:27] *it is [22:31:34] not the right term, I mean "the way it should be" [22:31:36] But what about Status etc? [22:31:37] (03CR) 10Paladox: [C: 031] "This can be merged please." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263047 (owner: 10Hashar) [22:32:20] When I start a deep research, I will evaluate the effort [22:32:29] and the number of classes that need to be ported [22:32:35] I need some help here [22:32:41] How do I use UtfNormal? [22:32:49] (03CR) 10Paladox: "This should be merged please." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/263049 (owner: 10Hashar) [22:32:55] Do I need to use require() to import the class? [22:33:00] victorbarbu_: look for some class dependancy graphs [22:33:03] ananayarora: Use it where? [22:33:21] I need to use it in a maintenance script [22:33:24] importImages.php [22:33:27] It's in the autoloader [22:33:32] So, no you don't need to require it [22:33:45] but, suppose I found everything that needs to be done [22:33:47] Reedy: Okay. So I can just use it like UtfNormal::function right? [22:33:51] will I get a gerrit repo? [22:34:04] or I do it on github? [22:34:19] You could [22:34:29] But converting it to Hack is going to cause other problems [22:34:41] ananayarora: Yes, that should work fine [22:34:48] Reedy: Okay! Thanks :) [22:34:51] I know [22:34:55] ananayarora: Though, if you read the code... [22:34:59] I have to find workarounds [22:35:01] * @deprecated since 1.25, use UtfNormal\Validator directly [22:35:13] because functions like selectField are problematic [22:35:17] since they return mixe [22:35:19] mixed& [22:35:39] tgr: What were you saying about SQL? [22:36:11] Reedy: I need to use the cleanUp function. It's gonna do the same thing if I use the validator or not [22:36:21] Also, there are going to be some troubles with references, If I remember correctly [22:36:26] ananayarora: Yes, but you shouldn't be using deprecated code, generally [22:36:29] there are references used [22:36:35] and hack does not support them [22:36:36] ananayarora: You should use the new version as it suggests [22:36:36] MtDu_: sorry, I'm at a meeting [22:36:59] Reedy: Okay. How do I include it? UtfNormal\Validator::cleanUp() ? [22:37:00] ananayarora: Introducing usages of deprecated code, especially where replacements exists, are reason to fail code review [22:37:12] Yup, that should work fine [22:37:24] (03CR) 10Jdlrobson: Refine design on New Talk overlay (MobileFrontend) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [22:37:34] (03CR) 10Bmansurov: Refine design on New Talk overlay (MobileFrontend) (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [22:38:32] (03PS1) 10Reedy: Fix last direct usage of UtfNormal in MW core [core] - 10https://gerrit.wikimedia.org/r/263148 [22:39:15] Reedy, according to the docs, TransactionProfiler, BagOStuff, IExpiringStore, LoggerInterface, LoggerAwareInterface are used [22:39:28] I will have to find out what classes inheriting these interfaces [22:40:24] I presume the logging ones will be well embedded [22:40:39] sorry? [22:41:13] LoggerInterface is used all over MW core [22:41:31] But it's not an MW specific class [22:41:33] oh, yeah, that's for sure [22:41:42] that's even better [22:41:50] I will start working on this after the contest ends [22:41:53] So, that wouldn't be too bad, if you setup composer stuff to bring it in [22:42:34] I would create a composer library, yeah [22:42:47] I estimate there won't be more than 12 thousand lines of code [22:42:53] which is not so horrible [22:43:42] a million wouldn't be bad if it was just a copy paste :P [22:43:54] tgr: Ok. Can you ping me when you're done? Thanks! [22:44:12] Reedy, but it's not isn't it? :)) [22:46:00] what would be a good approach for a function like "selectField(...)" which returns mixed? [22:46:10] No idea [22:46:17] I've not looked into Hack [22:46:45] I guess you either box it, or return everything to a string or you have selectInt, selectTimestamp, selectString [22:46:56] Not sure though [22:47:00] "box it"? [22:47:16] that's what I thought too [22:47:27] strings or selectInt etc [22:47:29] 10MediaWiki-Vagrant: Running maintenance scripts without mwscript fails silently on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T123143#1922219 (10bd808) The changes in https://gerrit.wikimedia.org/r/#/c/154472/ were made under the assumption that the primary MediaWiki-Vagrant use case is to run a sing... [22:48:30] 10MediaWiki-Change-tagging, 10MediaWiki-Export-or-Import: The export and import processes should transport revision tags - https://phabricator.wikimedia.org/T22691#1922220 (10Georggi199) It was already added to GCI https://codein.withgoogle.com/dashboard/task-instances/5800212228472832/ [22:48:31] Optionally add change tags to MediaWiki's export XML dumps || 5 days || Code || Wikimedia || Currently claimed [22:49:26] 10MediaWiki-Vagrant: Running maintenance scripts without mwscript fails silently on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T123143#1922221 (10Reedy) count( $wgLocalDatabases ) > 1 etc, you use mwscript... If you don't, it will fail (with a better error message!) I suspect just doing it silently i... [22:53:13] (03PS4) 10Victorbarbu: Refine design on New Talk overlay (MobileFrontend) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) [22:55:19] Reedy, Fred Emmott from fb says either selectInt, selectString etc, or select(...): T [22:55:26] I saw [22:57:03] Why is the size of mediawiki dev repo > 100 MB? [22:57:19] It's got a LOT of history [22:58:00] Over 67k commits [22:58:09] Lots of changes to localisation strings etc [22:58:33] oh, you're on #hhvm too [22:58:42] (03PS2) 10Florianschmidtwelzow: SpecialExpandTemplates: Fix false checkbox label for nowiki tag [core] - 10https://gerrit.wikimedia.org/r/263037 (https://phabricator.wikimedia.org/T122907) [23:00:17] It's 5... And I'm trying to get my way around Git. :( [23:01:28] 5AM in the morning to be precise [23:01:29] You can do a shallow clone [23:01:51] Should be enough for development [23:01:53] Reedy: The problem started when Git was trying to push multiple commits at once [23:01:56] But git blame won't work well [23:02:02] Did you have 2 remotes? [23:02:08] Reedy: Nope. [23:02:47] That's the usual reason [23:02:56] Or it's not using branches etc [23:03:14] Reedy: For example I complete 1 task on the core platform. (not any extension) [23:03:19] I push it. [23:03:20] ananayarora: This may help. https://www.mediawiki.org/wiki/Gerrit/Getting_started [23:03:29] Yeah it can get tricky. I just run git rebase git fetch --all and git stash in different orders till it fixes :) [23:03:32] So you either use branches [23:03:42] Or you just use git reset HEAD~1 --hard [23:03:46] after git review [23:03:54] Then when I complete the second one, it tries to push the old one too [23:04:16] Reedy: Tried it all, didn't work :'( [23:04:17] Yeah [23:04:24] Because you're not using branches or resetting properly [23:04:39] And creating unnecessary dependencies [23:04:50] It all got screwed, Got me mad, so I recloned. :$ [23:04:54] ananayarora, do you follow https://www.mediawiki.org/wiki/Gerrit/Tutorial ? [23:06:18] andre__: I was working with extensions for a long time, and it was working perfectly without pulling from master again and again [23:06:26] (03PS1) 10Yaron Koren: Fix for Special:ViewData for non-short URLs [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/263152 [23:06:46] ananayarora, what is the exact error message that you get "when I complete the second one, it tries to push the old one too"? [23:06:55] "You have more than one commit that you are about to submit." ? [23:07:04] andre__: Yes!!! that one [23:07:08] ananayarora, http://wikimedia.7.x6.nabble.com/git-review-wanting-to-submit-lot-of-changes-td4879828.html [23:07:28] tgr: Are the rows inserted here? https://dpaste.de/OSbf [23:07:41] ananayarora: but that's just *one* potential reason when I run into that. It does not mean that you face the same underlying reason. [23:09:12] (03PS1) 10Ananay: importImages.php runs input file names through UTF8 normalization functions [core] - 10https://gerrit.wikimedia.org/r/263153 (https://phabricator.wikimedia.org/T78060) [23:09:23] Yay! [23:09:51] *phew* https://gerrit.wikimedia.org/r/#/c/263153/ [23:10:31] tgr: I'll leave you a comment on GCI. [23:11:32] I must go now. It's 5 in the morning. Goodbye all! :) [23:12:37] ananayarora: Goodbye! [23:13:58] (03CR) 10Yaron Koren: [C: 032 V: 031] Fix for Special:ViewData for non-short URLs [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/263152 (owner: 10Yaron Koren) [23:16:50] 10MediaWiki-Change-tagging, 10MediaWiki-Export-or-Import, 3Google-Code-In-2015: The export and import processes should transport revision tags - https://phabricator.wikimedia.org/T22691#1922248 (10TTO) >>! In T22691#1922139, @Mattflaschen wrote: > This is out of scope for GCI. There are various issues, like... [23:27:44] (03CR) 10Jdlrobson: [C: 04-1] "see my comment on ps3" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/263143 (https://phabricator.wikimedia.org/T104836) (owner: 10Victorbarbu) [23:30:22] 10MediaWiki-extensions-EducationProgram: Localised name for Educational Program in russian - https://phabricator.wikimedia.org/T123140#1922256 (10Aklapper) Hi @Iniquity, thanks for taking the time to report this! The translations listed in this task seem to be already available on twn, like https://translatewik... [23:32:17] 10Wikimedia-SVG-rendering: PNG thumbnail preview of SVG misses some text - https://phabricator.wikimedia.org/T123106#1922257 (10Aklapper) p:5Triage>3Low [23:32:29] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1922260 (10Volker_E) Complementary information: Another usage of this approach are disabled element in Firefox Preferences (at least v43). [23:33:49] 6Phabricator, 7Mail: Disable Phab accounts with invalid e-mails that bounce - https://phabricator.wikimedia.org/T123139#1922262 (10Aklapper) Underlying problem is T100400 [23:35:58] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1922271 (10Aklapper) [23:36:00] 10MediaWiki-Page-editing: Live preview does not display map (from Mapframe template) on English wikivoyage - https://phabricator.wikimedia.org/T123061#1922268 (10Aklapper) 5Open>3Invalid a:3Aklapper >>! In T123061#1920684, @Fomafix wrote: > The problem is in https://en.wikivoyage.org/wiki/MediaWiki:Gadget-... [23:44:25] (03PS1) 10Dpatrick: Add Flow and VisualEditor scanning [wikimedia/security/automated-scanning] - 10https://gerrit.wikimedia.org/r/263155 [23:45:11] (03CR) 10Dpatrick: [C: 032 V: 032] Add Flow and VisualEditor scanning [wikimedia/security/automated-scanning] - 10https://gerrit.wikimedia.org/r/263155 (owner: 10Dpatrick) [23:45:39] 3Team-Practices-This-Week: Document active TPG Projects - Kristen - https://phabricator.wikimedia.org/T119465#1922286 (10JAufrecht) 5Open>3Resolved [23:57:52] (03PS2) 10Jdrewniak: [WIP] A/B/C test with typehead. **do not merge** [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/260073 [23:58:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] A/B/C test with typehead. **do not merge** [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/260073 (owner: 10Jdrewniak)