[00:00:07] kevinator and...I was using it incorrectly :) [00:00:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Lua's cache of Wikibase entities uses all available memory - https://phabricator.wikimedia.org/T86068#1919219 (10hoo) 5Open>3Resolved a:3hoo Has been fixed in 8773a4d8772ce17a9ad80cd1297342a4cdefc371. [00:02:24] 10MediaWiki-User-login-and-signup, 5Patch-For-Review: Passwords should be checked for strength before being set - https://phabricator.wikimedia.org/T5348#1919225 (10Parent5446) I think this bug can probably be closed since the technical requirements have been fulfilled. However, I still think we should actuall... [00:03:23] (03PS1) 10MaxSem: Use ParserOutput's extension data to store geotags [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262841 [00:03:37] 10MediaWiki-User-login-and-signup, 5Patch-For-Review: Passwords should be checked for strength before being set - https://phabricator.wikimedia.org/T5348#1919227 (10Parent5446) Some related tasks: T46788, T18435, T32574, T19544 [00:04:10] (03CR) 10Aude: "we might also want to put the test classes into a namespace (e.g. GeoData\Test) but suppose this is ok for now and is an improvement." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262741 (https://phabricator.wikimedia.org/T122339) (owner: 10MaxSem) [00:05:07] JonKatz: no worries. I thought you were going on pat leave... is that starting after the all-staff? [00:05:27] kevinator yeah! [00:05:30] legoktm: Why does https://www.mediawiki.org/wiki/User:Legoktm/ci not update IPSet? [00:06:49] "User:A_bot_that_updates_tables" Very descriptive and utilitarian name [00:06:56] Indeed. [00:09:30] 4(no projects): Test - https://phabricator.wikimedia.org/T123010#1919252 (10BGerstle-WMF) [00:09:38] 4(no projects): Test - https://phabricator.wikimedia.org/T123010#1919254 (10BGerstle-WMF) 5Open>3Invalid a:3BGerstle-WMF [00:12:04] pranavk_: you still here [00:12:42] bawolff: yes [00:12:50] actually just a second [00:13:09] Sure [00:14:09] bawolff: I was just adding an 'exifMsg' function to BitmapMetadatHandler [00:14:50] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Technical-Debt: [Task] Unit tests for ExternalRecentChange - https://phabricator.wikimedia.org/T45198#1919257 (10hoo) 5Open>3Invalid a:3hoo Class no longer exists. [00:15:26] Similar to that in FormatMetadata [00:16:56] (03CR) 10Firebus: "maybe this is the issue?" (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/221368 (https://phabricator.wikimedia.org/T87402) (owner: 1001tonythomas) [00:19:58] bawolff: sorry, i'm kind of short on time [00:20:17] bawolff: i only have about ~10 mins [00:20:18] ok, back now [00:20:25] OK [00:20:48] So I'm adding an exifMsg function to BitmapMetadataHandler [00:21:09] That would handle all exif messages, right? [00:22:09] (03CR) 10Cscott: [C: 04-1] "I love this, but it would be nice to have parser tests." [core] - 10https://gerrit.wikimedia.org/r/262347 (https://phabricator.wikimedia.org/T122787) (owner: 10TheDJ) [00:22:10] No, I don't think it would [00:22:18] as they're not in the same class inheritence [00:22:27] I mean, for the PdfHandler [00:22:59] Because a BitmapMetadata Hamdler is being created [00:23:29] FormatMetadata is in a separate inheritence chain from all the MediaHandlers, so you won't be overriding the function by adding it to a specific media handler [00:23:32] BitmapMetadataHandler object* [00:24:10] To clarify, what you're trying to do is add {{PLURAL: support to that page size exif message for pdfs? [00:24:10] Do all classes inherit FormatMetadata? [00:24:12] 10MediaWiki-extensions-Disambiguator, 6Community-Tech, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): remove disambiguation pages from Special:ShortPages - https://phabricator.wikimedia.org/T53124#1919266 (10kaldari) [00:24:19] bawolff: Yes [00:24:38] no, there are no classes that inherit FormatMetadata [00:24:45] ok [00:25:00] 3Wikipedia-Android-App: Sort out which app versions feeds which MobileWikiAppToCInteraction table - https://phabricator.wikimedia.org/T119664#1919268 (10Tbayer) @JKatzWMF Good point. FWIW, I installed [[https://releases.wikimedia.org/mobile/android/wikipedia/stable/wikipedia-2.0.105-releasesprod-2015-06-30.apk |... [00:25:04] so Nemo_bis said that I had to make a patch in core [00:25:12] He's correct [00:25:19] In order to start solving these exif problems [00:25:21] but its not an easy bug to fix [00:25:27] (03Abandoned) 10Deskana: Clean up AudioUrlSpan class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262835 (owner: 10Deskana) [00:25:38] Yes, so which class exactly should I create this function in? [00:25:56] I'm afraid it will be limited, right? [00:26:07] FormatMetadata is what would need to be changed [00:26:08] I mean, even if I try to solve this [00:26:19] So, should I make it public? [00:26:36] pranavk_: do you generally want to add plural support for any exif thing that can have a list of items? [00:26:48] I'm not sure what you mean by making it public [00:26:48] 3Wikipedia-Android-App: OutOfMemoryError when loading many large pages from History in succession. - https://phabricator.wikimedia.org/T121759#1919271 (10Dbrant) a:3Dbrant [00:26:54] Well, in the long run, yes [00:27:06] 3Mobile-App-Android-Sprint-73-Tantalum, 3Wikipedia-Android-App: OutOfMemoryError when loading many large pages from History in succession. - https://phabricator.wikimedia.org/T121759#1887432 (10Dbrant) [00:27:07] As of now, my GCI task is only for that specific mesage [00:27:43] oh, you're a GCI student [00:27:55] this is not what I would call an appropriate task for GCI [00:27:55] Right now, the exifmsg function in FormatMetadata is private, so would making it public, and then making other classes inherit it work? [00:28:02] Yes, I am :) [00:28:19] Its significantly more complex then what we normally make gci tasks be [00:28:44] Yeah, I realized :P [00:29:10] (and that wasn't attitude) :D [00:29:25] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Story: [Story] Allow Snak rendering in user language instead of content language for multilingual wikis - https://phabricator.wikimedia.org/T88924#1919275 (10hoo) [00:29:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Story: [Story] Make Snak rendering use user language instead of content language for multilingual wikis - https://phabricator.wikimedia.org/T88924#1919276 (10hoo) [00:29:50] bawolff: So how would I solve this for now? [00:30:14] umm, that's a very good question, that I'm not even sure what the answer is [00:30:34] Would my current patch work? [00:30:46] https://gerrit.wikimedia.org/r/#/c/262459/ [00:30:49] The problem is, that multiple values are collapsed to a single string prior to the tag name being converted to a message [00:31:09] Which line is that in? [00:31:12] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Story: [Story] Make Snak rendering use user language instead of content language for multilingual wikis - https://phabricator.wikimedia.org/T88924#1023472 (10hoo) [00:31:29] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Story: [Story] Make Snak rendering use user language instead of content language for multilingual wikis - https://phabricator.wikimedia.org/T88924#1919295 (10hoo) [00:32:01] umm, your current patch sort of works, but is kind of hacky, and would modify the behaviour of the API in a way O [00:32:05] I'm not a fan of [00:32:33] bawolff: Yeah :), but it's a temporary solution [00:32:44] 10MediaWiki-Interface, 5Patch-For-Review: Wrap MediaWiki toolbar menu to HTML5