[00:00:15] (03CR) 10jenkins-bot: [V: 04-1] Support low quality videos in webm and mp4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [00:00:24] (03CR) 10jenkins-bot: [V: 04-1] Support 4k in ogv videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234913 (owner: 10Paladox) [00:01:27] Well, qunit is broke. [00:01:29] (03CR) 10jenkins-bot: [V: 04-1] Change videoQuality to videoBitrate [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231788 (https://phabricator.wikimedia.org/T109184) (owner: 10Paladox) [00:01:41] 3Team-Practices-This-Week: finish tests for P2 - https://phabricator.wikimedia.org/T122418#1917175 (10ggellerman) @KLans_WMF @DStrine I think that we are done with tests for this Possibility and are seeking signoff on them in T122821, so I am going to move this task to Done. [00:02:01] 6Research-and-Data, 10Wikimedia-Developer-Summit-2016: Data analysis with (python) MediaWiki-Utilities -- A unix philosophy-inspired collection of packages - https://phabricator.wikimedia.org/T114247#1689343 (10Halfak) Thanks folks! [00:02:03] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:02:21] (03PS17) 10Paladox: Add support for svg with png format [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/226713 (https://phabricator.wikimedia.org/T106809) [00:02:33] (03PS7) 10Paladox: empty php entry point [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/228627 [00:02:45] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:03:09] (03PS17) 10Paladox: Move hooks from hooks file to Main php file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229470 [00:03:27] (03CR) 10jenkins-bot: [V: 04-1] Add support for h265 format [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231575 (https://phabricator.wikimedia.org/T108312) (owner: 10Paladox) [00:04:23] (03CR) 10Muehlenhoff: "This is getting really close, some additional remarks (mostly all removals due to the debconf change)" (0312 comments) [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [00:04:25] hey Jerkins why you no like that patch :/ [00:05:09] \o/ [00:05:14] (03PS1) 10Kaldari: Add hook to allow extensions to modify query used by Special:ShortPages [core] - 10https://gerrit.wikimedia.org/r/262680 [00:06:38] (03CR) 10jenkins-bot: [V: 04-1] Move hooks from hooks file to Main php file [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229470 (owner: 10Paladox) [00:06:44] (03PS2) 10Kaldari: Add hook to allow extensions to modify query used by Special:ShortPages [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) [00:06:58] (03CR) 10BryanDavis: "Jerkins!!" [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:07:03] (03PS7) 10Paladox: Add extension.json, empty php entry point [skins/Slate] - 10https://gerrit.wikimedia.org/r/229137 [00:07:14] (03CR) 10BryanDavis: [C: 032] "Try again" [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:08:16] (03PS15) 10Paladox: Update BlueSky tests [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/226634 [00:08:26] (03CR) 10BryanDavis: Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:08:28] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:08:28] 10WikiCon-Francophone-2016: Recherche d'un local pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T118962#1917184 (10Pyb) Check-list lors de la visite des lieux : Accessibilité - absence de marches - absence d'escaliers - ou présence d'ascenseurs - distance/trajet depuis transport en communs... [00:08:35] (03CR) 10BryanDavis: [C: 032] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:10:14] Does anybody know what a wacky qunit failure like this one means? -- https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/25497/consoleFull [00:10:18] (03PS4) 10Paladox: empty php entry point [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/226600 [00:11:23] (03CR) 10Paladox: "@Hashar please could you merge this." [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/226634 (owner: 10Paladox) [00:11:43] 3Team-Practices-This-Week: Create Milestone Roadmap showing what would have to be true to do fully evidence-based FY17 planning in Jan-April 2016 - https://phabricator.wikimedia.org/T122256#1917187 (10JAufrecht) [00:11:52] 6RevisionScoringAsAService, 10Wikimedia-Developer-Summit-2016: Quality control and newcomer socialization tools with revscoring and ORES - https://phabricator.wikimedia.org/T114246#1689313 (10Halfak) Thanks folks! [00:11:56] bd808: slave was overloaded and chromium stopped responding [00:12:11] 10Annual-Report, 10Security-Reviews, 6Security-Team: security review 15.wikipedia/annual2015 code review - https://phabricator.wikimedia.org/T119478#1917190 (10Dzahn) @csteipp correction, Steph uploaded a new version here https://gerrit.wikimedia.org/r/#/c/262679/ that should contain all files [00:12:32] (03PS16) 10Paladox: Update BlueSky tests [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/226634 [00:12:32] 3Team-Practices-This-Week: Document active TPG Projects - Kristen - https://phabricator.wikimedia.org/T119465#1917191 (10KLans_WMF) Done. [00:12:38] legoktm: *nod* I thought it looked like some resource issue [00:12:42] 10WikiCon-Francophone-2016: facilitator's toolbox pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T122939#1917192 (10Pyb) 3NEW [00:13:04] (03CR) 10Paladox: "check experimental" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/226634 (owner: 10Paladox) [00:13:11] 10WikiCon-Francophone-2016: Recherche d'un local pour la WikiConFR 2016 - https://phabricator.wikimedia.org/T118962#1917199 (10Trizek) Points à vérifier : - Internet -- accès aux outils de développement (en cas de mini-hackathon) - Lieu de la conférence -- Accès pour la cuisine -- Possibilité d'avoir un lieu a... [00:13:33] (03CR) 10jenkins-bot: [V: 04-1] Add hook to allow extensions to modify query used by Special:ShortPages [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [00:14:41] (03PS14) 10Paladox: Convert to globals and add composer support [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/225680 (https://phabricator.wikimedia.org/T86476) [00:15:04] (03CR) 10Kaldari: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [00:15:27] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:15:33] (03CR) 10Yaron Koren: "There needs to be some sort of version check here, given the problems with extension.json handling in MW 1.25. Maybe just enable it only f" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [00:15:53] (03CR) 10Ricordisamoa: [C: 031] "not tested myself" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/262436 (owner: 10Paladox) [00:16:33] (03CR) 10PranavK: Add PLURAL support to exif-pdf-pagesize (031 comment) [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [00:17:48] (03CR) 10Unicornisaurous: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [00:19:43] (03PS10) 10Paladox: Add extension.json, empty php entry point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) [00:20:23] (03CR) 10Paladox: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) (owner: 10Paladox) [00:22:08] (03PS11) 10Paladox: Add extension.json, empty php entry point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) [00:22:15] (03PS1) 10MaxSem: Climbing the Reichstag dressed as Spider-Man and removing PHP 5.3 support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262681 [00:22:19] (03CR) 10Paladox: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) (owner: 10Paladox) [00:22:32] (03PS1) 10MaxSem: Move API files under includes [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262682 [00:22:45] (03CR) 10jenkins-bot: [V: 04-1] Climbing the Reichstag dressed as Spider-Man and removing PHP 5.3 support [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262681 (owner: 10MaxSem) [00:22:58] (03CR) 10Paladox: "I have tested this new patch and works." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/262436 (owner: 10Paladox) [00:23:41] (03CR) 10Legoktm: [C: 032] Move API files under includes [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262682 (owner: 10MaxSem) [00:23:46] (03PS2) 10Dzahn: 15.wikipedia.org / annual 2015 - one commit to rule them all [wikimedia/annualreport] - 10https://gerrit.wikimedia.org/r/262679 (owner: 10Stephmonette) [00:23:51] 3Team-Practices-This-Week: Create Milestone Roadmap showing what would have to be true to do fully evidence-based FY17 planning in Jan-April 2016 - https://phabricator.wikimedia.org/T122256#1917203 (10JAufrecht) [00:24:07] (03CR) 10Paladox: "Because I thought it was the same reason as for SemanticForms but it wasent but just incase I am doing a custom prefix." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [00:24:12] 3Team-Practices-This-Week: Create Milestone Roadmap showing what would have to be true to do fully evidence-based FY17 planning in Jan-April 2016 - https://phabricator.wikimedia.org/T122256#1917205 (10JAufrecht) a:5JAufrecht>3None [00:24:14] (03PS3) 10PranavK: Add PLURAL support to exif-pdf-pagesize [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 [00:24:18] (03Merged) 10jenkins-bot: Move API files under includes [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262682 (owner: 10MaxSem) [00:24:23] 7Design, 10Front-end-Standards-Group, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: User interface presentation - https://phabricator.wikimedia.org/T119162#1917207 (10Krinkle) Real-time notes: https://etherpad.wikimedia.org/p/WikiDev16-T119162 > Take away points: > > * Improve bac... [00:24:38] 4(no projects): Update / repackage openvas - https://phabricator.wikimedia.org/T122940#1917209 (10csteipp) 3NEW [00:25:13] 6Security-Team: Update / repackage openvas - https://phabricator.wikimedia.org/T122940#1917215 (10csteipp) [00:25:15] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty php entry point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) (owner: 10Paladox) [00:25:56] (03CR) 10Paladox: "Extension registration handling in 1.25 was fixed in 1.25.3." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [00:26:29] 3Team-Practices-This-Week: Create Milestone Roadmap showing what would have to be true to do fully evidence-based FY17 planning in Jan-April 2016 - https://phabricator.wikimedia.org/T122256#1917219 (10JAufrecht) [00:26:52] (03PS3) 10Paladox: Re enable extension registration [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 [00:27:23] (03CR) 10Paladox: "You can use this config" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [00:28:15] (03CR) 10Paladox: "Unless you just want 1.25 to use the old main php file and 1.26 or higher to use extension.json." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [00:28:24] (03CR) 10jenkins-bot: [V: 04-1] Add PLURAL support to exif-pdf-pagesize [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [00:31:14] (03CR) 10PranavK: "recheck" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [00:32:23] 3Team-Practices-This-Week: TPG signoff for tests in Strategy Possibility 2 - https://phabricator.wikimedia.org/T122821#1917221 (10JAufrecht) [00:32:57] (03CR) 10BryanDavis: Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:33:05] (03CR) 10BryanDavis: [C: 032] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:36:19] Bug created for failing qunit builds: https://phabricator.wikimedia.org/T122941#1917229 [00:37:31] (03PS10) 10Paladox: Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 [00:37:35] (03CR) 10PranavK: "This bug: https://phabricator.wikimedia.org/T122941#1917229 ?" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [00:37:37] (03CR) 10GWicke: "We have implemented this by post-processing the response in RESTBase. A cleaner solution would still be desirable, but seems to be tricky." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/252276 (https://phabricator.wikimedia.org/T117082) (owner: 10Phuedx) [00:39:26] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [00:41:04] (03CR) 10Unicornisaurous: [C: 04-1] "I don't think we want 0.13.16. See upstream: https://github.com/karma-runner/karma/issues/1782" [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [00:42:03] (03CR) 10jenkins-bot: [V: 04-1] Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [00:42:36] (03CR) 10Paladox: "It is not just 0.13.16 release it is even the older ones." [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [00:42:40] (03CR) 10Krinkle: "Maybe we can use the method (GET vs POST) to distinguish this instead of this hidden field?" [core] - 10https://gerrit.wikimedia.org/r/262589 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [00:44:01] (03PS1) 10Paladox: Test: DO not merge [core] - 10https://gerrit.wikimedia.org/r/262684 [00:44:59] 3Team-Practices-This-Week: finish tests for P2 - https://phabricator.wikimedia.org/T122418#1917239 (10DStrine) I also think we are done but will wait for T122821 to be completed. [00:46:10] (03CR) 10Krinkle: [C: 032] Fix false message output method on Special:ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/262590 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [00:46:22] 6Community-Liaison, 10WMF-Product-Strategy, 10Wikimedia-Developer-Summit-2016: 10 tips for communicating with communities when developing software - https://phabricator.wikimedia.org/T113490#1917243 (10Trizek-WMF) Points discussed during the Dev Summit 2016: * Separate what we expect when interacting with c... [00:46:31] 6Community-Liaison, 10WMF-Product-Strategy, 10Wikimedia-Developer-Summit-2016: 10 tips for communicating with communities when developing software - https://phabricator.wikimedia.org/T113490#1917245 (10Trizek-WMF) [00:47:07] (03PS1) 10Krinkle: htmform: Document "text" methods that take HTML as such [core] - 10https://gerrit.wikimedia.org/r/262685 [00:47:46] (03CR) 10Unicornisaurous: "I'm pretty sure because of the way npm manages packages, this won't help since karma still depends on and will keep its own version of soc" [core] - 10https://gerrit.wikimedia.org/r/262684 (owner: 10Paladox) [00:48:54] (03PS2) 10Paladox: Fix Qunit tests [core] - 10https://gerrit.wikimedia.org/r/262684 (https://phabricator.wikimedia.org/T122941) [00:49:16] (03CR) 10Aaron Schulz: [C: 032] htmform: Document "text" methods that take HTML as such [core] - 10https://gerrit.wikimedia.org/r/262685 (owner: 10Krinkle) [00:49:26] (03CR) 10Unicornisaurous: "But I guess I'm wrong :P" [core] - 10https://gerrit.wikimedia.org/r/262684 (https://phabricator.wikimedia.org/T122941) (owner: 10Paladox) [00:49:27] 6WMF-NDA-Requests: Add hey_ok_deb to #wmf-nda - https://phabricator.wikimedia.org/T122920#1917257 (10Aklapper) [[ https://phabricator.wikimedia.org/p/hey_ok_deb/ | The Phab account ]] links to [[ https://www.mediawiki.org/wiki/User:Hey_ok_deb | this mw.org account ]]. [[ https://www.mediawiki.org/wiki/Special:Ce... [00:53:51] (03CR) 10jenkins-bot: [V: 04-1] htmform: Document "text" methods that take HTML as such [core] - 10https://gerrit.wikimedia.org/r/262685 (owner: 10Krinkle) [00:54:18] (03CR) 10jenkins-bot: [V: 04-1] Fix false message output method on Special:ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/262590 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [00:57:30] (03PS11) 10Paladox: Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 [01:00:41] (03PS12) 10Paladox: Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 [01:03:26] 10MediaWiki-Interface, 7JavaScript, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Add more mw.hook events for wikipage: diff, categories etc. - https://phabricator.wikimedia.org/T53583#1917260 (10matmarex) [01:03:41] (03PS1) 10Paladox: Update karma to 0.13.19 fixes Bug: T122941 [core] - 10https://gerrit.wikimedia.org/r/262686 (https://phabricator.wikimedia.org/T122941) [01:05:24] (03PS13) 10Paladox: Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 [01:05:32] (03CR) 10Bartosz Dziewoński: [C: 032] "CODE REVIEW ON THE BUS" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [01:07:57] \ [01:09:03] (03PS1) 10Aaron Schulz: Dependency inject TransactionProfiler into DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/262687 [01:09:17] (03PS2) 10Paladox: Update karma to 0.13.19 fixes Bug: T122941 [core] - 10https://gerrit.wikimedia.org/r/262686 (https://phabricator.wikimedia.org/T122941) [01:09:19] (03CR) 10jenkins-bot: [V: 04-1] Update karma to 0.13.19 fixes Bug: T122941 [core] - 10https://gerrit.wikimedia.org/r/262686 (https://phabricator.wikimedia.org/T122941) (owner: 10Paladox) [01:09:47] (03CR) 10jenkins-bot: [V: 04-1] hygiene: Goodbye custom event emitter and class code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [01:14:44] (03CR) 10jenkins-bot: [V: 04-1] Dependency inject TransactionProfiler into DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/262687 (owner: 10Aaron Schulz) [01:20:26] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1917267 (10josephine_l) @Nicolas_Raoul - Now that I can get the QuadTree methods to work (roughly speaking) with my data, I need to decide how I want to implement the... [01:33:30] (03PS1) 10Jonas Kress (WMDE): Fixes: [Bug] Save button inactive when changing mono language [data-values/value-view] - 10https://gerrit.wikimedia.org/r/262688 (https://phabricator.wikimedia.org/T95419) [01:36:09] (03CR) 10jenkins-bot: [V: 04-1] Fixes: [Bug] Save button inactive when changing mono language [data-values/value-view] - 10https://gerrit.wikimedia.org/r/262688 (https://phabricator.wikimedia.org/T95419) (owner: 10Jonas Kress (WMDE)) [01:45:54] I can't seem to find where the parameters are passed in Tooltip-pt-userpage/en message in mw core. Any hints on how to find it? I've tried finding using the message name, just pt-userpage, tooltip, but either there isn't a good result, or there are just too many. Any tips? [01:46:30] 10MobileFrontend: Mobile edit icon sometimes points to the previous section of the page - https://phabricator.wikimedia.org/T122471#1917271 (10TTO) [01:46:44] 10MobileFrontend: Mobile edit icon sometimes points to the previous section of the page - https://phabricator.wikimedia.org/T122471#1905229 (10TTO) I think Jon had it the wrong way around. [01:48:20] (03CR) 10TTO: "The test failures are some kind of JavaScript error, which is obviously not related to this patch." [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [01:49:04] (03CR) 10Unicornisaurous: "TTO:" [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [01:51:40] (03CR) 10TTO: [C: 04-1] Fix --pagelist for dumpBackup.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [01:52:06] MtDu: Hi! [01:52:13] tto: Hello! [01:53:47] I'm having a hard time remembering where the tooltips are generated! [01:54:21] tto: Take your time. [01:55:15] tto: Currently, I'm snooping around skintemplate.php, seems like that might be right...? But Idk. [01:55:18] It's in Linker.php I think. The line looks like $message = wfMessage( "tooltip-$name" ); [01:55:31] tto: I'll take a look. [01:57:35] (03PS2) 10Unicornisaurous: Fix --pagelist for dumpBackup.php [core] - 10https://gerrit.wikimedia.org/r/262678 [01:57:35] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1917273 (10Nicolas_Raoul) We don't need to store: it is very short-lived cache. No problem if it disappears every minute. [01:57:46] (03CR) 10Unicornisaurous: "done" [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [01:57:53] (03CR) 10Unicornisaurous: Fix --pagelist for dumpBackup.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [01:58:50] tto: So If I wanted to pass a user in for gender, I would just do this? https://dpaste.de/jkXF [01:59:48] tto: When you get a free moment (I can see you’re very busy), I did fix the Twinkle PR. [01:59:56] MtDu: Well, you couldn't do it like that. You can't just move the parameters of a public function [02:00:13] I think you're going to have to go for something a bit more involved [02:00:45] tto: Would global $wguser work? [02:01:00] MtDu: That is about the worst possible solution :( [02:01:07] You could add something to the $options array [02:01:46] Or you could add an extra optional parameter to the end of the parameter list, something like array $messageParams = array() or Message $message = null [02:01:58] (03CR) 10jenkins-bot: [V: 04-1] Fix --pagelist for dumpBackup.php [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [02:02:01] That would allow the caller to pass in custom parameters to the tooltip [02:04:15] unicornisaurous: OK, I'll take a look. Thanks for your patience! [02:04:16] tto: Could you explain the optional parameter? [02:06:10] MtDu: It's quite complicated, because the information we need is so far away from where we need it [02:09:21] MtDu: SkinTemplate, which has a User object, calls BaseTemplate::makeListItem, which calls BaseTemplate::makeLink, which calls Linker::titleAttrib [02:09:33] Somehow the user information has to be passed all the way up the chain [02:10:36] tto: Ok. And why is using $wgUser bad? [02:11:40] It's a global variable, and there is a general belief that globals are evil [02:11:52] To be honest, $wgUser is probably the least bad of the global variables [02:12:14] I really wonder if your mentor would be prepared to merge anything that uses $wgUser though [02:12:38] tto: I see. I'm just not sure how else to pass a user in. [02:12:59] tto: I see your comments, but I'm still trying to wrap my head around them. [02:13:13] Let's see if legoktm has an opinion :) [02:13:26] legoktm:^ [02:18:43] tto: Thanks for your help! If I need to go, should I just check the message logs later to see if lego responds? [02:19:09] MtDu: I just picked him because he's sometimes online at this time of day [02:19:32] You could send him, or your GCI task mentor, an email or an IRC memo [02:19:51] tto: I see. I guess I'll leave Nemo a comment on the GCI page. [02:20:01] Sure. [02:20:03] tto: Thanks for your help! [02:20:10] No problem :) Best of luck [02:21:21] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1917277 (10josephine_l) @Nicolas_Raoul Oh okay, thanks! [02:21:34] (03CR) 10Jdlrobson: [C: 032] "bad jenkins. please try that again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [02:22:07] (03PS1) 10Aaron Schulz: Log multi-DB transaction in MediaWiki [core] - 10https://gerrit.wikimedia.org/r/262689 (https://phabricator.wikimedia.org/T122387) [02:25:26] (03CR) 10jenkins-bot: [V: 04-1] hygiene: Goodbye custom event emitter and class code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [02:28:51] (03CR) 10jenkins-bot: [V: 04-1] Log multi-DB transaction in MediaWiki [core] - 10https://gerrit.wikimedia.org/r/262689 (https://phabricator.wikimedia.org/T122387) (owner: 10Aaron Schulz) [02:30:16] 10MediaWiki-extensions-SemanticForms, 6Labs, 10wikitech.wikimedia.org: "Edit with form" missing on a Tools access request page - https://phabricator.wikimedia.org/T118136#1917281 (10Krenair) That just made it return array(0){} in both cases. [02:31:46] 10MediaWiki-General-or-Unknown, 3Google-Code-In-2015, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Split PHP classes from WebRequest.php into separate files - https://phabricator.wikimedia.org/T122633#1917282 (10MtDu) 5Open>3Resolved [02:41:11] (03CR) 10Anomie: [C: 031] "Seems sane. Haven't tested." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [02:47:09] (03PS3) 10Bartosz Dziewoński: Update karma to 0.13.19 [core] - 10https://gerrit.wikimedia.org/r/262686 (https://phabricator.wikimedia.org/T122941) (owner: 10Paladox) [02:47:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/262686 (https://phabricator.wikimedia.org/T122941) (owner: 10Paladox) [02:48:11] 6Repository-Ownership-Requests: Unarchive mediawiki/extensions/OOUIPlayground - https://phabricator.wikimedia.org/T122944#1917294 (10Prtksxna) 3NEW [02:51:57] (03CR) 10Anomie: "The suggested fix isn't actually very tricky. But it does depend on someone having the time/interest to do it." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/252276 (https://phabricator.wikimedia.org/T117082) (owner: 10Phuedx) [02:54:03] (03Merged) 10jenkins-bot: Update karma to 0.13.19 [core] - 10https://gerrit.wikimedia.org/r/262686 (https://phabricator.wikimedia.org/T122941) (owner: 10Paladox) [03:05:05] (03PS1) 10Parent5446: Lock box version for VMWare Fusion [vagrant] - 10https://gerrit.wikimedia.org/r/262690 [03:17:23] (03PS3) 10Unicornisaurous: Fix --pagelist for dumpBackup.php [core] - 10https://gerrit.wikimedia.org/r/262678 [03:21:59] unicornisaurous, if you get rid of that now-unnecessary die statement, I'll merge that patch (or at least, I'll merge it when the Jenkins issue is fixed) [03:22:10] Dangit I forgot that [03:22:21] I think jenkins issue was merged [03:22:25] *patch was merged [03:22:44] yes jenkins likes it now, i just need to fix die [03:23:19] (03PS4) 10Unicornisaurous: Fix --pagelist for dumpBackup.php [core] - 10https://gerrit.wikimedia.org/r/262678 [03:23:26] TTO: ^ [03:24:07] unicornisaurous: Thanks for doing that! Above and beyond your GCI responsibilities :) [03:24:41] tto: I just reported the bug lol, I didn’t patch anything :P [03:25:53] (03CR) 10TTO: [C: 032] Fix --pagelist for dumpBackup.php [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [03:25:59] Thanks! [03:29:33] tto: Double thanks for merging the other task too! :D [03:30:12] I'm running out of open tasks! I'm going to have to spend this afternoon opening some new tasks in Twinkle and MediaWiki :) [03:30:36] (03Merged) 10jenkins-bot: Fix --pagelist for dumpBackup.php [core] - 10https://gerrit.wikimedia.org/r/262678 (owner: 10Unicornisaurous) [03:31:55] tto: That would be great! I’ll claim one if I can! [03:35:35] (03PS1) 10Bearloga: Deploy forecasting dashboard mvp [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262691 [03:35:58] (03CR) 10Bearloga: [C: 032 V: 032] Deploy forecasting dashboard mvp [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262691 (owner: 10Bearloga) [03:39:38] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1917329 (10josephine_l) [03:40:04] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1819835 (10josephine_l) [03:43:38] (03PS1) 10Bearloga: Add installation of forecast package [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262692 [03:43:48] (03CR) 10Bearloga: [C: 032 V: 032] Add installation of forecast package [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262692 (owner: 10Bearloga) [03:45:13] tto: Thanks for your comment. Could you go more in depth here? I have a little time to talk before I need to sleep. [03:46:55] tto: Are you saying having an extra paramter passed in to the function? Ex. messageParams? [03:47:44] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1917335 (10josephine_l) [03:47:58] (03PS1) 10Bearloga: Update forecast dash [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262693 [03:48:04] 10MediaWiki-History-or-Diffs: diff: as a pseudo namespace - https://phabricator.wikimedia.org/T21556#1917337 (10Ricordisamoa) Special:Diff has been in core for almost 2 years. Decline? [03:48:14] (03CR) 10Bearloga: [C: 032 V: 032] Update forecast dash [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262693 (owner: 10Bearloga) [03:51:11] (03PS1) 10Bearloga: Update forecast dash [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262694 [03:51:46] (03CR) 10Bearloga: [C: 032 V: 032] Update forecast dash [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262694 (owner: 10Bearloga) [03:52:43] (03PS6) 10Anomie: Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 [03:52:49] (03CR) 10Anomie: Move grant and IP restriction logic from OAuth to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259062 (owner: 10Anomie) [03:55:15] (03CR) 10jenkins-bot: [V: 04-1] Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 (owner: 10Anomie) [03:55:55] (03CR) 10Anomie: Update for SessionManager (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 (owner: 10Anomie) [03:56:08] (03PS14) 10Anomie: Update for SessionManager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 [03:56:58] tto:Are you available now? [03:59:07] unicornisaurous: want something less boring? :) [03:59:21] tto: lol are you watching what task I claim? [03:59:44] I’m going to do this one and then save my energy for what you come up with for tomorrow :P [04:00:08] MtDu: it looks to me like he is available lol [04:00:49] * tgr is not tto [04:01:29] unicornisaurous: what are you working on? [04:01:34] what areas, I mean? [04:01:40] oh wait [04:01:41] wow [04:01:43] I thought you were tto [04:02:02] Three letter username starting with T… [04:02:58] Well there isn’t much to work on as far as I can tell from the task…i’m just testing it and then submit to gerrit [04:03:20] Sorry I got confused tgr [04:03:27] nw [04:03:33] I mean, what kind of tasks are you interested in? [04:04:24] tgr: I’m interested in pretty much any mediawiki task [04:04:44] I’ve been doing a lot of maintenance script stuff [04:05:32] I think TTO was probably going to find some maintenance script task or import/export task to add tomorrow [04:06:23] ah, ok, I won't interfere then :) [04:06:44] tgr: What area was the task you had in mind regarding? [04:07:48] tgr: I’m open to tasks though, tto won’t be able to keep me busy forever! (or will he?) [04:08:14] tgr: Just threw up a patch for the task I claimed for you [04:08:17] I didn't have anything specific in mind [04:08:34] most of my past work was on multimedia, lots of interesting bugs there [04:09:46] tgr: I’d be willing to do more of those, are there any others open right now? [04:10:04] no [04:10:27] the problem with gci tasks is that there isn't a good way to group them by skill level [04:10:38] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.messagePoster: Minor code and docs clean up [core] - 10https://gerrit.wikimedia.org/r/260704 (owner: 10Krinkle) [04:11:02] so you either make them hard and then people with less experience will pick them and struggle and give up halfway [04:11:34] or select something easy and then it will be boring for more experienced students [04:12:34] so I'm trying to create the hard ones on demand for people who have done well with other tasks and seem interested in finding harder ones [04:12:41] tgr: Perhaps you should suggest to GCI to have a “difficulty” property on tasks which is more specific than Beginner/non-beginner? [04:13:59] it would be some improvement, but people's self-judgement of what level they are at is not always accurate [04:14:34] and of course it's hard to define levels in a way that gives you objective information [04:14:56] Very true [04:17:30] (03Merged) 10jenkins-bot: mediawiki.messagePoster: Minor code and docs clean up [core] - 10https://gerrit.wikimedia.org/r/260704 (owner: 10Krinkle) [04:18:05] 10MediaWiki-History-or-Diffs: diff: as a pseudo namespace - https://phabricator.wikimedia.org/T21556#1917361 (10jayvdb) 5Open>3declined a:3jayvdb >>! In T21556#235469, @demon wrote: > Was chatting with BC about this earlier, a couple of notes: > * It would probably be best as a namespace, not an IW link. R... [04:26:27] unicornisaurous: the first year of GCI there used to be three difficulty level for tasks, but it turned out that mentors were really bad at estimating the difficulty, so it was axed ;) [04:26:44] MatmaRex_mobile: Interesting! [04:28:26] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1917371 (10josephine_l) [04:29:52] (03Abandoned) 10Krinkle: Fix Qunit tests [core] - 10https://gerrit.wikimedia.org/r/262684 (https://phabricator.wikimedia.org/T122941) (owner: 10Paladox) [04:31:45] (03CR) 10Krinkle: [C: 04-1] Update karma (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [04:32:12] (03PS4) 10Krinkle: Fix false message output method on Special:ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/262590 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [04:33:14] 10MediaWiki-Unit-tests, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Qunit jobs consistently failing on all slaves - https://phabricator.wikimedia.org/T122941#1917378 (10Krinkle) [04:33:57] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [04:34:02] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262689 (https://phabricator.wikimedia.org/T122387) (owner: 10Aaron Schulz) [04:34:07] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262687 (owner: 10Aaron Schulz) [04:34:11] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262685 (owner: 10Krinkle) [04:34:22] (03CR) 10Krinkle: [C: 032] Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [04:42:15] (03Merged) 10jenkins-bot: Remove redundant DatabaseBase doc comments [core] - 10https://gerrit.wikimedia.org/r/262676 (owner: 10Aaron Schulz) [04:44:10] 10MediaWiki-extensions-LdapAuthentication: LdapAuthenticationPlugin::connect should use trim() instead of rtrim() - https://phabricator.wikimedia.org/T122948#1917380 (10Ariscop) 3NEW [04:44:33] 10MediaWiki-extensions-MultimediaViewer, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Media Viewer not invoking maxage nor smaxage for imageinfo - https://phabricator.wikimedia.org/T117750#1917388 (10Tgr) 5Open>3Resolved a:3Tgr Thanks Unicornisaurous! [04:51:59] 10MobileFrontend: Special:Contributions for users that don't exist show a bare error in Mobile - https://phabricator.wikimedia.org/T122949#1917396 (10wctaiwan) 3NEW [04:57:45] (03CR) 10Legoktm: Initial commit (038 comments) [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [04:58:05] (03CR) 10Legoktm: Initial commit (033 comments) [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [04:58:12] (03PS6) 10Legoktm: Initial commit [debian] - 10https://gerrit.wikimedia.org/r/241690 [04:59:24] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1917403 (10josephine_l) [05:02:23] 10MobileFrontend: Special:Contributions for users that don't exist shows a generic, unformatted error in Mobile - https://phabricator.wikimedia.org/T122949#1917405 (10wctaiwan) [05:09:36] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1917408 (10josephine_l) @Nicolas_Raoul - Is it okay for the cache to only return one nearby point with one nearby list of categories, or do we have to return all the... [05:14:25] 10MediaWiki-extensions-Other: Convert StrategyWiki extension to use extension registration - https://phabricator.wikimedia.org/T88061#1917426 (10Legoktm) AFAIS this extension is no longer Wikimedia deployed? Should it be archived? [05:15:08] legoktm: Yeah we could mark it r/o in gerrit and mark it as such on mw.org [05:15:19] It was undeployed...a couple months ago? [05:15:20] 10MediaWiki-Interface, 7JavaScript, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Add more mw.hook events for wikipage: diff, categories etc. - https://phabricator.wikimedia.org/T53583#1917428 (10Krinkle) >>! In T53583#1885706, @TheDJ wrote: > @Krinkle, probably yes, but I think that is a... [05:15:36] ostriches: I could not find a mw.o page for it >.> [05:15:53] Surprise :p [05:16:35] Anyway, task easily rejected :p [05:17:12] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1917434 (10demon) [05:18:21] legoktm: Marked r/o in gerrit and updated the repo desc to match. [05:20:16] ostriches: heh, thanks [05:20:26] I'm trying to find new GCI tasks [05:20:34] So far I've only found that EducationProgram is broken [05:20:46] lmao [05:21:44] 10MediaWiki-extensions-EducationProgram: EducationProgram conditional WikiEditor module dependency is broken - https://phabricator.wikimedia.org/T122950#1917436 (10Legoktm) 3NEW [05:24:31] 10MediaWiki-extensions-GettingStarted, 7Easy, 7Technical-Debt: GettingStarted should not conditionally register MessageCache::get hook - https://phabricator.wikimedia.org/T122951#1917446 (10Legoktm) 3NEW [05:27:51] 10Wikipedia-App-MobileApp-extension, 3Google-Code-In-2015: Convert MobileApp extension to use extension registration - https://phabricator.wikimedia.org/T88056#1917453 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/6252999357759488/ [05:39:11] (03CR) 10PranavK: "recheck" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [05:40:10] legoktm: I looked at T122951 and twitched. I hate $wgConf [05:40:37] it's just a really really bad hack :/ [05:40:47] and the $wgConf part sucks too [05:41:44] I suppose we should provide something like siteFromDB() in real config. [05:41:57] iirc it's the most often usecase for $wgConf in exts. [05:42:24] 10MediaWiki-extensions-TranslationNotifications, 3Google-Code-In-2015: Convert TranslationNotifications to use extension registration - https://phabricator.wikimedia.org/T87986#1917457 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/5115445325594624/ [05:44:43] 10MediaWiki-Configuration, 7Easy: convertExtensionToRegistration.php script should die on global functions (like it does for closures) - https://phabricator.wikimedia.org/T122952#1917460 (10Legoktm) 3NEW [05:48:01] 10MediaWiki-extensions-VipsScaler: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1917469 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/6005167665184768/ [05:48:17] 10MediaWiki-extensions-VipsScaler, 3Google-Code-In-2015: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1917471 (10Legoktm) [05:49:24] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1917476 (10Legoktm) [05:49:25] 10WikiGrok: Convert WikiGrok to use extension registration - https://phabricator.wikimedia.org/T87994#1917473 (10Legoktm) 5Open>3declined a:3Legoktm Extension was archived. [05:54:56] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1917479 (10Nicolas_Raoul) Second solution sounds best, if there is no big difficulty with it. [05:58:14] 10MediaWiki-extensions-WikimediaEvents, 6Analytics-Backlog, 10Analytics-EventLogging, 6Analytics-Kanban, 5Patch-For-Review: Provide oneIn() sampling function as part of standard library - https://phabricator.wikimedia.org/T112603#1917482 (10Krenair) [05:59:25] 10MediaWiki-Export-or-Import: Special:Import rejects valid XML and gives incorrect error - https://phabricator.wikimedia.org/T17913#1917484 (10TTO) 5Open>3Resolved [05:59:42] 10MediaWiki-Export-or-Import: Special:Import rejects valid XML and gives incorrect error - https://phabricator.wikimedia.org/T17913#201869 (10TTO) Per Ejegg, import was revamped some time after October 2008. [06:03:31] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1917490 (10josephine_l) [06:04:14] 10MediaWiki-Export-or-Import: Special:Export output missing XML encoding - https://phabricator.wikimedia.org/T17914#1917491 (10TTO) [06:05:35] 10MediaWiki-General-or-Unknown, 7Technical-Debt: Send $wgTitle to the fiery pit from whence it came - https://phabricator.wikimedia.org/T25307#1917494 (10demon) p:5Low>3Normal We should really get this done this year. It's 20-freaking-16. [06:05:54] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1917497 (10josephine_l) [06:08:25] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: importImages.php doesn't update comments when overwriting - https://phabricator.wikimedia.org/T21793#1917498 (10TTO) [06:09:09] 10MediaWiki-extensions-VipsScaler, 3Google-Code-In-2015: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1917502 (10Legoktm) Wait no, this is not a good GCI task, sorry. The $wgVipsOptions setting needs to be looked at closely. [06:09:30] 10MediaWiki-extensions-VipsScaler: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1917503 (10Legoktm) [06:13:02] 10MediaWiki-Maintenance-scripts: enhancement of importTextFile.php - https://phabricator.wikimedia.org/T17872#1917505 (10TTO) 5Open>3Invalid a:3TTO `importTextFile.php` was deleted years ago. [06:24:41] 10MediaWiki-Maintenance-scripts: enhancement of importTextFile.php - https://phabricator.wikimedia.org/T17872#1917512 (10demon) [[ https://gerrit.wikimedia.org/r/#/c/147877/ | Not even two yet ]] :P [06:24:48] tto: hehe :) [06:25:28] ostriches: Was 1.24 really so recent? [06:25:32] I guess so..! [06:38:12] (03CR) 10Alex Monk: [C: 04-1] "looks to me like this will break global filter stuff" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/145156 (https://bugzilla.wikimedia.org/25377) (owner: 10Legoktm) [06:44:33] (03CR) 10Alex Monk: [C: 04-1] "unaddressed comment from glaisher" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/252485 (owner: 10Legoktm) [06:50:30] 10MediaWiki-General-or-Unknown, 5MW-1.27-release-notes, 5Patch-For-Review, 7Technical-Debt, and 3 others: Pre MW 1.20 deprecation cleanup - https://phabricator.wikimedia.org/T122754#1917518 (10Florian) [06:50:34] 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, 10MediaWiki-extensions-EtherpadLite, and 16 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1917516 (10Flori... [06:51:23] 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, 10MediaWiki-extensions-EtherpadLite, and 16 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1913522 (10Flori... [06:54:13] * legoktm huggles Florian [06:54:47] (03CR) 10Florianschmidtwelzow: [C: 032] htmform: Document "text" methods that take HTML as such [core] - 10https://gerrit.wikimedia.org/r/262685 (owner: 10Krinkle) [06:54:57] (03PS7) 10Alex Monk: Check if the article exists first before actually displaying it. [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 (https://phabricator.wikimedia.org/T43417) (owner: 10Hydriz) [06:55:39] (03CR) 10Alex Monk: [C: 032] Check if the article exists first before actually displaying it. [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 (https://phabricator.wikimedia.org/T43417) (owner: 10Hydriz) [06:59:40] (03Merged) 10jenkins-bot: htmform: Document "text" methods that take HTML as such [core] - 10https://gerrit.wikimedia.org/r/262685 (owner: 10Krinkle) [06:59:43] (03Merged) 10jenkins-bot: Check if the article exists first before actually displaying it. [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 (https://phabricator.wikimedia.org/T43417) (owner: 10Hydriz) [07:06:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Pywikibot-tests: Overwriting a redirect using wbeditentity causes an exception - https://phabricator.wikimedia.org/T112243#1917530 (10hoo) Returns the following now: `{"error":{"code":"no-such-entity","info":"Could not find such an entity (Unresolved r... [07:34:00] 10MediaWiki-extensions-SemanticForms, 6Labs, 10wikitech.wikimedia.org: "Edit with form" missing on a Tools access request page - https://phabricator.wikimedia.org/T118136#1917537 (10Yaron_Koren) Oh well. I just looked again and noticed something unusual: the offending page (https://wikitech.wikimedia.org/wik... [08:11:07] 10MediaWiki-extensions-SemanticForms, 6Labs, 10wikitech.wikimedia.org: "Edit with form" missing on a Tools access request page - https://phabricator.wikimedia.org/T118136#1917540 (10Krenair) I used https://wikitech.wikimedia.org/w/api.php?action=purge&forcelinkupdate=true&titles=Nova_Resource:Tools/Access_Re... [08:11:36] 10MediaWiki-Releasing, 6Release-Engineering-Team, 5Patch-For-Review: Resolve/remove symlink of README.mediawiki in tarball - https://phabricator.wikimedia.org/T122502#1917541 (10demon) We could just copy the file at release time instead. [08:54:10] tto, hi! What you are saying by the comments here "Look at 'url' and 'descriptionurl' above though; exactly the same comments could apply to them The reason wfExpandUrl is needed is because LocalFile will return a relative path by default." is that I should expand the URL in the ForeignAPIFIle? [08:54:32] victorbarbu_, that was in response to Gergo's comment [08:54:53] Oh [08:54:56] Basically I'm agreeing with what you have done, instead of what he is suggesting [08:55:26] but... you see [08:55:47] I fI correctly understand this, then the value for a foreign api file will be published in the api locally [08:55:48] right? [08:58:54] I think so. I'm not sure if I quite understand what you're saying though [08:59:31] Well, then, how is the URL generated for a goreign wiki? [08:59:34] foreign* [09:00:17] By asking for it from the foreign API [09:01:05] yeah, but there in the ForeignAPI how is it created? [09:28:58] (03PS7) 10Victorbarbu: Provide short URL to file description page in imageinfo API [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) [09:29:16] (03CR) 10Victorbarbu: "recheck" [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [09:37:54] (03PS8) 10Victorbarbu: Provide short URL to file description page in imageinfo API [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) [09:48:52] (03CR) 10TTO: "Looks good to me, although the comment could be improved." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [09:53:54] (03PS9) 10Victorbarbu: Provide short URL to file description page in imageinfo API [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) [09:54:50] (03CR) 10TTO: [C: 031] "Looks good to me. Haven't tested. Hopefully Gergo can do the honours :)" [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [10:23:09] 10MediaWiki-extensions-CategoryTree, 3Google-Code-In-2015: Convert CategoryTree to use extension registration - https://phabricator.wikimedia.org/T87888#1917569 (10Nemo_bis) Why is this "clarification required"? [10:26:39] 10MediaWiki-extensions-CategoryTree, 3Google-Code-In-2015: Convert CategoryTree to use extension registration - https://phabricator.wikimedia.org/T87888#1917570 (10Legoktm) There's currently an open blocking task for it. [10:28:14] 10MediaWiki-extensions-SemanticForms, 6Labs, 10wikitech.wikimedia.org: "Edit with form" missing on a Tools access request page - https://phabricator.wikimedia.org/T118136#1917571 (10scfc) So to summarize: The problem was that when https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Access_Request/Edodero... [10:38:40] (03Abandoned) 10JadeMaveric: Document logentry-massaction-jobfailed [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/262114 (owner: 10JadeMaveric) [10:48:10] 10MediaWiki-extensions-Newsletter, 7I18n: Messages newsletter-notification-title and newsletter-notification-flyout need GENDER support on $3. - https://phabricator.wikimedia.org/T122954#1917585 (10Purodha) 3NEW [10:53:38] 10MediaWiki-extensions-DynamicSidebar: DynamicSidebar should pass jshint - https://phabricator.wikimedia.org/T63605#1917598 (10hashar) 5Open>3Resolved a:3hashar It is passing now. [11:03:09] 6Phabricator, 10Diffusion: Create a redirect script in phabricator so that if the repo dosent exist in diffusion we can see if it does in gitblit - https://phabricator.wikimedia.org/T122929#1917613 (10QChris) I only found [[https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects|docs on how t... [11:07:47] 10MediaWiki-extensions-Other: ReplaceSet should pass jshint - https://phabricator.wikimedia.org/T63623#1917627 (10hashar) 5Open>3Resolved a:3hashar it is passing now [11:20:27] (03PS74) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [11:26:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Pywikibot-tests: Overwriting a redirect using wbeditentity causes an exception - https://phabricator.wikimedia.org/T112243#1917646 (10jayvdb) p:5Triage>3Normal Still not very helpful, but at least it isnt an exception. [11:42:09] (03CR) 10Nemo bis: [C: 04-1] Add GENDER support for log and status messages. (032 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/262129 (owner: 10Tacsipacsi) [11:56:59] tto: Are you there? [11:57:14] MtDu: Yes! Sorry I missed you before, I was out buying wood [11:57:29] tto: That's ok! I'm trying to catch you before school. [11:57:39] Did you manage to figure out what I explained to you? [11:57:43] I admit, it was rather complicated [11:57:47] (03PS3) 10Nemo bis: Add GENDER support for log and status messages. [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/262129 (owner: 10Tacsipacsi) [11:57:51] But I think it will be the best way to solve this problem [11:57:58] Have you asked Nemo_bis for an opinion? [11:58:18] Nemo_bis: He said that you already responded. [11:58:31] Nemo_bis: So I assume that he agrees with your opinion. :) [11:58:35] tto:^ [11:58:40] Sorry wrong person. [11:59:13] OK. [11:59:29] tto: So for the parameters, are you saying pass in something like $messageParams? [11:59:41] tto: Which is an array? And then directly pass that into the wfmessage cal? [11:59:53] There is already an $options parameter, which can be used for extra options [12:00:01] No need to add actual parameters to the function call [12:00:27] tto: So why is it set to null right now? [12:00:35] Not used, I imagine [12:00:44] We're going to put it to use! [12:01:10] tto: But then in line 2183, it says if $option == 'withaccess'. [12:01:28] $options that is. [12:01:51] Oops! You're right [12:02:01] I think I was thinking of the $options parameter to another function [12:02:13] You will indeed have to add an extra parameter to that function. [12:02:46] Same for Linker::tooltipAndAccesskeyAttribs [12:03:47] Then, moving further up the tree, Linker::titleAttrib and Linker::tooltipAndAccesskeyAtrribs are both called from BaseTemplate::makeLink [12:03:58] *down the tree :) [12:04:55] tto: So pass something like $optionsParams = array()? [12:05:21] No I would just keep it simple to be honest, the new parameter can be called $messageParams [12:05:36] Sorry to confuse you! I thought the existing $options parameter worked differently [12:05:56] tto: And why do I have to add it to the second function you named? [12:06:16] Because it calls Linker::titleAttrib [12:06:36] So it needs to take the $messageParams parameter, in order to pass that information onto Linker::titleAttrib [12:06:41] tto: Gotcha. public static function titleAttrib( $name, $options = null, $messageParams = array() ) { [12:06:45] tto: Like that? [12:06:54] Looks good. [12:07:11] You may as well typehint that parameter like so: titleAttrib( $name, $options = null, array $messageParams = array() ) { [12:08:07] tto: Then I need to check if it actually has something before I pass it into wfmessage right? [12:09:01] You might have to check the best way to do that [12:09:42] tto: Ok. I'll take a look at that later. You were saying something about user param to something in skin template? [12:09:50] tto: With createpersonalurl? [12:09:52] Ah yes, you can just do wfMessage(... messagename... , $messageParams ) [12:10:16] So the place where this exciting code path starts out is SkinTemplate::buildPersonalUrls [12:10:49] That's where you should be specifying the message parameters, in each of those little arrays that has keys like 'name', 'href', etc [12:11:09] 10Wikimedia-Site-Requests: add additional import source for kn.wikisource - https://phabricator.wikimedia.org/T122955#1917649 (10Omshivaprakash) 3NEW [12:11:14] Those arrays are passed to BaseTemplate::makeListItem [12:12:00] So it's really a matter of making sure each function passes along the required information to the next function in the chain [12:12:29] Sometimes you might not need to add any new code, it might be taken care of already (e.g. if the whole settings array is passed along) [12:13:04] tto: Ok. So this check this function. https://dpaste.de/frEP [12:13:11] tto: Then the next one up in the chain is? [12:13:54] MtDu: It's BaseTemplate::makeLink. But I feel as though I make it too easy for you by telling you straight out :) [12:14:03] The way I found this out was by using git grep [12:14:16] tto: What's that? How do I use it and set it up? [12:14:38] Run it straight from a console: git grep tooltipAndAccesskeyAttribs [12:14:48] (you have to be changed into the /core directory) [12:15:08] tto: Gotcha. Let me try that. I never knew that. Before, I thought you guys were psychic. :) [12:15:47] tto: When I run it in git bash, I don't get any response. [12:16:09] That's odd. Sure you're in the right directory? [12:16:17] I cded into vagrant/mediawiki/core [12:16:25] Should work... [12:16:28] tto: I'm not sure if I cloned core into the right place. [12:16:48] You should be in the directory which is the git repository you're working off [12:17:02] tto: I ran git grep titleAttrib and that worked. [12:17:15] Maybe you misspelt it before :) [12:17:23] To exit from git grep, type q [12:18:18] tto: So if I ran the git grep for this, how do you sift through it? https://dpaste.de/ztxj So I can do this in the future. :) [12:19:31] Well, I ignore irrelevant stuff (we're working on tooltip-pt-userpage, which has nothing to do with EditPage, or the DifferenceEngine, or some random client-side JS) [12:19:56] Then I just open the relevant documents and do a quick Ctrl+F to see whether the results are meaningful [12:20:14] tto: Ok. [12:20:29] It's about following your nose :) [12:21:10] tto: Wait. So how did you get personalurl out of that? [12:21:15] In https://dpaste.de/frEP you should make the parameter optional. Adding extra non-optional parameters to a public function is a very bad idea [12:21:33] Oh, buildPersonalUrls is a few more steps away yet [12:21:43] tto: Gotcha. [12:21:50] See if you can tell me using git grep what calls BaseTemplate::makeLink [12:22:06] tto: I guess my next question is. How you make a parameter optional? I think I asked you this yesterday. [12:22:08] tto: On it. [12:22:45] function foo( $mandatoryParam, $optionalParam = null, $anotherOptionalParam = array(), $yetAnotherOptionalParam = -1 ) { } [12:23:20] Basically if the parameter is not specified, the part after the = is used as the value of the parameter [12:23:27] tto: Gotcha. [12:23:37] Same as C++, C#, and others [12:24:17] tto: I'm not sure if this helps me. https://dpaste.de/b3Yd [12:24:41] OK, so what are your thoughts upon looking at this git grep output? [12:25:04] tto: Nothing in the Linker.php helps [12:25:16] tto: Probably not indexpager [12:25:27] No, you can see that IndexPager defines its own function called makeLink [12:25:33] Nothing to do with us [12:25:46] tto: So maybe alphabetpager [12:25:50] tto: Let me check. [12:26:04] No, we aren't paging anything alphabetical :) [12:26:15] All the exciting stuff is in the "skins" directory [12:27:34] tto: So makelistitem? [12:27:40] Yes, indeed [12:28:33] BTW, it helps to write down the flow of logic, so you don't have to retrace your steps [12:29:45] tto: Ok. And just to make sure, am I doing this right? https://dpaste.de/1Jpg#L1,6 [12:30:12] Can't fault it :) [12:31:03] tto: So I keep on doing that up the chain. When I get to the attrib function, I'm not sure what to do. [12:31:20] tto: personalurl one [12:31:40] Which function? SkinTemplate::buildPersonalUrls or whatever it's called? [12:31:55] tto: Yep. [12:33:46] Well, you should add a parameter to those arrays with text, href, etc.. Something like 'params' => array( $this->getUser() ), [12:34:19] tto: Oh yeah! we talked about this yesterday, because the function had a user object. [12:34:27] tto: This all makes sense now. Gotcha. Gotcha. [12:34:34] Then in BaseTemplate::makeListItem and BaseTemplate::makeLink, you need logic to get that parameter passed across to the functions on Linker [12:35:09] Here's a hint if you need it: Each of those arrays with text, href etc. gets passed into the $item parameter of BaseTemplate::makeListItem [12:35:44] MtDu: Sorry, I said 'params' => array( $this->getUser() ), but these parameters are specifically for tooltip, so it would need to be 'tooltipParams' [12:36:04] tto: Yep. What do mean logic? Why? [12:36:31] tto: Just in case it's null? [12:36:52] Well, your 'tooltip-params' key isn't magically going to get passed into Linker::titleAttrib without you writing some extra code, or logic, in BaseTemplate [12:37:10] tto, +1 :)) [12:37:27] victorbarbu_: Haha, hello :) [12:37:48] tto: Ok. I got it. I'll try to figure it out, and if I run into any troubles, I'll ask you. Thank you so much for introducing me to git grep! [12:38:05] I have configured that stupid server [12:38:06] finally [12:38:10] in a vagrant machine [12:38:18] MtDu: Sure thing. git grep is incredibly useful (although some people have fancy things like PHPStorm... nudge nudge victorbarbu_) [12:38:28] 10Datasets-General-or-Unknown: pagecounts raw files missing - https://phabricator.wikimedia.org/T122877#1917662 (10DianaArq) any updates on this issue? Thanks [12:38:37] tto, :))) [12:38:46] it is really good [12:39:21] but for my hack project, I had to move to atom [12:39:43] because the guys at jetbrains are not really into adding support for hack [12:39:44] :| [12:39:53] Hm, I suppose Hack is an acquired taste [12:40:56] but many many peoplekeep asking for this [12:41:09] and we even pay for it [12:42:03] look at this. How rude! https://github.com/squizlabs/PHP_CodeSniffer/issues/602#issuecomment-105325204 [12:42:36] Not really rude. After all, they're not obliged to support Hack [12:42:53] that's not related to phpstorm [12:42:58] (03PS1) 10Devirk: Reworded the message when editing the current version of an article. [core] - 10https://gerrit.wikimedia.org/r/262701 [12:43:08] it's about a hack code sniffer [12:43:13] like hackcs :D [12:43:25] which is just a dream, of course [12:57:25] 10MediaWiki-Special-pages: Special pages: Allow using templates / adding interwiki links - https://phabricator.wikimedia.org/T15489#1917682 (10TTO) 5Open>3Invalid a:3TTO I did a quick check of core, and all special page summary messages appeared to accept wikitext. Without specific, up-to-date detail of wh... [12:58:58] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: Prevent "importImages.php" from creating a new revision when an existing file is not changed at all. - https://phabricator.wikimedia.org/T88423#1917687 (10TTO) [13:01:31] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: Using --report with dumpBackup.php causes division by zero - https://phabricator.wikimedia.org/T55258#1917688 (10TTO) [13:01:36] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: Using --report with dumpBackup.php causes division by zero - https://phabricator.wikimedia.org/T55258#1917693 (10TTO) 5Open>3Resolved a:3TTO Works now. [13:04:23] 10MediaWiki-Special-pages, 7Easy: Special:UserRights "you must login" link does not pass &returnto= on, so the user ends up at the main page - https://phabricator.wikimedia.org/T118874#1917697 (10Devirk) [13:05:19] 10MediaWiki-Maintenance-scripts, 6operations: WikiExporter does not respect groupLoadsByDB[$wiki]['dump'] - https://phabricator.wikimedia.org/T43668#1917699 (10TTO) This is an old task. Is it still relevant in the current context? [13:07:06] 10MediaWiki-extensions-TocTree: TocTree should pass jshint - https://phabricator.wikimedia.org/T63640#1917702 (10hashar) 5Open>3Resolved a:3hashar It is passing now [13:07:18] 10The-Wikipedia-Adventure: Warning to user when pressing buttons - https://phabricator.wikimedia.org/T122896#1917706 (10Samtar) p:5Lowest>3Low [13:07:25] 10The-Wikipedia-Adventure: Center help/about - https://phabricator.wikimedia.org/T122900#1917708 (10Samtar) p:5Low>3Lowest [13:09:17] 10MediaWiki-extensions-ZeroBanner: ZeroBanner should pass jshint - https://phabricator.wikimedia.org/T67817#1917710 (10hashar) It is fixed. [13:18:38] 10PronunciationRecording: PronunciationRecording should pass jshint and comply with coding conventions - https://phabricator.wikimedia.org/T56907#1917719 (10hashar) 5Open>3Resolved a:3hashar [13:18:54] 10MediaWiki-General-or-Unknown, 7Easy, 7I18n, 7Voice & Tone: "Pages transcluded onto the current version of this page:" could be clearer - https://phabricator.wikimedia.org/T75165#1917722 (10Devirk) a:3Devirk [13:26:19] 10MediaWiki-Export-or-Import, 10MediaWiki-Special-pages, 5Patch-For-Review: Add GET and PATH_INFO parameters to [[Special:Import]] URLs, allowing to populate the form - https://phabricator.wikimedia.org/T45426#1917724 (10TTO) a:5Dereckson>3None [13:26:46] 10MediaWiki-Export-or-Import, 10MediaWiki-Special-pages, 3Google-Code-In-2015, 5Patch-For-Review: Add GET and PATH_INFO parameters to [[Special:Import]] URLs, allowing to populate the form - https://phabricator.wikimedia.org/T45426#468291 (10TTO) No reply on Gerrit, so unassigning from Dereckson. I'll put... [13:30:33] (03PS1) 10Jack Phoenix: Removing some inline styles again [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/262702 (https://phabricator.wikimedia.org/T87148) [13:41:25] 7Browser-Support-Internet-Explorer: MS are dropping support for IE 8, 9 and 10 - https://phabricator.wikimedia.org/T122959#1917743 (10Reedy) 3NEW [14:07:29] (03CR) 10Nemo bis: "Did you read https://doc.wikimedia.org/mediawiki-core/master/php/classBitmapMetadataHandler.html#a555dfda6139e91cd781aa5689cf2e602 and the" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [14:07:40] (03PS4) 10Nemo bis: [WIP] Add PLURAL support to exif-pdf-pagesize [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [14:07:57] (03PS5) 10Nemo bis: [WIP] Add PLURAL support to exif-pdf-pagesize [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [14:09:16] 10MediaWiki-extensions-MultimediaViewer, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Media Viewer not invoking maxage nor smaxage for imageinfo - https://phabricator.wikimedia.org/T117750#1917755 (10Nemo_bis) a:5Tgr>3Unicornisaurous [14:11:54] 10MediaWiki-extensions-ContributionTracking, 5Patch-For-Review: ContributionTracking should pass jshint - https://phabricator.wikimedia.org/T63599#1917758 (10hashar) a:3hashar [14:12:36] 10MediaWiki-General-or-Unknown, 6Multimedia, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB) - https://phabricator.wikimedia.org/T54687#1917759 (10Nemo_bis) 5Resolved>3Invalid The original task is about more than one JavaScript mo... [14:19:55] (03CR) 10PranavK: "Yes, I read it. Should I add a function to the same class?" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/262459 (owner: 10PranavK) [14:20:52] (03PS2) 10Jack Phoenix: Removing some inline styles again [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/262702 (https://phabricator.wikimedia.org/T87148) [14:21:27] (03CR) 10Jack Phoenix: [C: 032] Removing some inline styles again [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/262702 (https://phabricator.wikimedia.org/T87148) (owner: 10Jack Phoenix) [14:24:21] (03Merged) 10jenkins-bot: Removing some inline styles again [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/262702 (https://phabricator.wikimedia.org/T87148) (owner: 10Jack Phoenix) [14:40:21] Nemo_bis: Would I need to create a new function in https://doc.wikimedia.org/mediawiki-core/master/php/BitmapMetadataHandler_8php_source.html ? [14:44:52] In order to add metadata message support? [14:47:39] (03PS5) 10Florianschmidtwelzow: Fix false message output method on Special:ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/262590 (https://phabricator.wikimedia.org/T122907) [14:48:52] Can I please get some help on adding parameter support to metadata messages? [14:50:31] 10MediaWiki-extensions-LdapAuthentication: Add SQLite Support to LDAP Authentication extension - https://phabricator.wikimedia.org/T108355#1917779 (10saper) p:5Triage>3Normal a:3saper [14:52:20] (03PS1) 10saper: Add SQLite Support to LDAP Authentication extension [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/262707 (https://phabricator.wikimedia.org/T108355) [14:54:26] 10MediaWiki-extensions-LdapAuthentication, 5Patch-For-Review: Add SQLite Support to LDAP Authentication extension - https://phabricator.wikimedia.org/T108355#1917784 (10saper) Hi @sbonds - I have pushed your patch to the "code review" (i.e. the red tape needed to get this thing included), I only would love to... [15:01:41] (03PS1) 10Paladox: Add full define support in extension registration. [core] - 10https://gerrit.wikimedia.org/r/262709 [15:03:00] 10MediaWiki-extensions-LdapAuthentication, 5Patch-For-Review: Add SQLite Support to LDAP Authentication extension - https://phabricator.wikimedia.org/T108355#1917787 (10saper) [15:03:02] 10MediaWiki-Database, 7Tracking: SQLite support (tracking) - https://phabricator.wikimedia.org/T22257#1917786 (10saper) [15:08:57] (03PS1) 10Hashar: Pass jshint and add it to 'npm test' command [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/262710 (https://phabricator.wikimedia.org/T63620) [15:09:31] (03CR) 10saper: "Pending patch author's email address" [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/262707 (https://phabricator.wikimedia.org/T108355) (owner: 10saper) [15:09:34] (03CR) 10jenkins-bot: [V: 04-1] Pass jshint and add it to 'npm test' command [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/262710 (https://phabricator.wikimedia.org/T63620) (owner: 10Hashar) [15:19:06] 10MediaWiki-Special-pages: Special pages: Allow using templates / adding interwiki links - https://phabricator.wikimedia.org/T15489#1917802 (10He7d3r) [15:20:22] 10MediaWiki-Special-pages: Special pages: Allow using templates / adding interwiki links - https://phabricator.wikimedia.org/T15489#173292 (10He7d3r) See T15489#173358 above. [15:22:58] 10MediaWiki-Watchlist, 6TCB-Team, 7German-Community-Wishlist, 3TCB-Team-Sprint-2016-01-06: Investigation: technical possibilities for backend of "Removing articles from watchlist after a custom timeframe" - https://phabricator.wikimedia.org/T101249#1917817 (10Tobi_WMDE_SW) [15:24:48] (03PS1) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [15:25:23] (03CR) 10Paladox: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) (owner: 10Paladox) [15:25:37] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) (owner: 10Paladox) [15:26:13] (03CR) 10Paladox: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) (owner: 10Paladox) [15:26:24] 10MediaWiki-Watchlist, 6TCB-Team, 7German-Community-Wishlist, 3TCB-Team-Sprint-2016-01-06: Investigation: technical possibilities for backend of "Removing articles from watchlist after a custom timeframe" - https://phabricator.wikimedia.org/T101249#1917823 (10Tobi_WMDE_SW) [15:27:05] (03PS1) 10Hashar: Add jshint to 'npm test' command [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/262712 (https://phabricator.wikimedia.org/T63640) [15:27:22] (03CR) 10jenkins-bot: [V: 04-1] Add jshint to 'npm test' command [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/262712 (https://phabricator.wikimedia.org/T63640) (owner: 10Hashar) [15:29:09] (03PS2) 10Hashar: Add jshint to 'npm test' command [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/262712 (https://phabricator.wikimedia.org/T63640) [15:31:27] (03PS14) 10Paladox: Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 [15:32:27] (03PS15) 10Paladox: Update packages to do with karma [core] - 10https://gerrit.wikimedia.org/r/261037 [15:32:49] (03CR) 10Dereckson: Add SQLite Support to LDAP Authentication extension (031 comment) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/262707 (https://phabricator.wikimedia.org/T108355) (owner: 10saper) [15:33:29] (03PS1) 10Paladox: Bump browserNoActivityTimeout to 2 mins instead of 1 min for karma [core] - 10https://gerrit.wikimedia.org/r/262713 [15:35:28] (03PS2) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [15:35:55] (03CR) 10Paladox: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) (owner: 10Paladox) [15:36:11] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) (owner: 10Paladox) [15:37:24] (03CR) 10saper: Add SQLite Support to LDAP Authentication extension (031 comment) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/262707 (https://phabricator.wikimedia.org/T108355) (owner: 10saper) [15:37:38] (03CR) 10Anomie: Provide short URL to file description page in imageinfo API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [15:37:57] (03CR) 10jenkins-bot: [V: 04-1] Bump browserNoActivityTimeout to 2 mins instead of 1 min for karma [core] - 10https://gerrit.wikimedia.org/r/262713 (owner: 10Paladox) [15:37:59] (03CR) 10Anomie: Provide short URL to file description page in imageinfo API (032 comments) [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [15:39:41] (03CR) 10Dereckson: Add SQLite Support to LDAP Authentication extension (031 comment) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/262707 (https://phabricator.wikimedia.org/T108355) (owner: 10saper) [15:46:45] (03CR) 10Hashar: "recheck" [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/261208 (https://phabricator.wikimedia.org/T120715) (owner: 10Bmansurov) [15:48:59] o7 [15:49:50] (03CR) 10jenkins-bot: [V: 04-1] Browser test check [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/261208 (https://phabricator.wikimedia.org/T120715) (owner: 10Bmansurov) [15:58:33] (03PS1) 10Hashar: Rake entry point and rubocop fix up [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/262716 (https://phabricator.wikimedia.org/T120715) [16:00:52] (03CR) 10Hashar: "https://gerrit.wikimedia.org/r/#/c/262716/ fix rake/rubocop" [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/261208 (https://phabricator.wikimedia.org/T120715) (owner: 10Bmansurov) [16:01:03] (03CR) 10jenkins-bot: [V: 04-1] Rake entry point and rubocop fix up [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/262716 (https://phabricator.wikimedia.org/T120715) (owner: 10Hashar) [16:01:25] 10MediaWiki-extensions-RelatedArticles, 5Patch-For-Review, 3Reading-Web-Sprint-63-Ellip…: RelatedArticles browser tests should run on a commit basis - https://phabricator.wikimedia.org/T120715#1917911 (10hashar) Browsertest for RelatedArticles is deployed at https://integration.wikimedia.org/ci/job/browserte... [16:01:37] 10MediaWiki-extensions-RelatedArticles, 10Continuous-Integration-Config, 5Patch-For-Review, 3Reading-Web-Sprint-63-Ellip…: RelatedArticles browser tests should run on a commit basis - https://phabricator.wikimedia.org/T120715#1917912 (10hashar) [16:06:32] 10MediaWiki-General-or-Unknown, 6Multimedia, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB) - https://phabricator.wikimedia.org/T54687#1917921 (10Jdforrester-WMF) 5Invalid>3Open >>! In T54687#1917759, @Nemo_bis wrote: > The origi... [16:21:20] (03PS1) 10Hashar: Add jshint to 'npm test' command [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/262717 [16:22:45] (03CR) 10BryanDavis: [C: 032] "Thanks Tyler." [vagrant] - 10https://gerrit.wikimedia.org/r/262690 (owner: 10Parent5446) [16:25:49] (03Merged) 10jenkins-bot: Lock box version for VMWare Fusion [vagrant] - 10https://gerrit.wikimedia.org/r/262690 (owner: 10Parent5446) [16:26:20] (03PS3) 10Jforrester: startup.js: Move IE8 down from Grade A to Grade C [core] - 10https://gerrit.wikimedia.org/r/252383 (https://phabricator.wikimedia.org/T118303) [16:26:44] (03CR) 10Jforrester: startup.js: Move IE8 down from Grade A to Grade C (031 comment) [core] - 10https://gerrit.wikimedia.org/r/252383 (https://phabricator.wikimedia.org/T118303) (owner: 10Jforrester) [16:29:15] (03PS1) 10Hashar: Add jshint to 'npm test' command [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/262718 [16:31:29] (03CR) 10Yurik: [C: 032] Add jshint to 'npm test' command [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/262718 (owner: 10Hashar) [16:34:05] 10MediaWiki-extensions-Disambiguator, 5Patch-For-Review: remove disambiguation pages from Special:ShortPages - https://phabricator.wikimedia.org/T53124#1918062 (10Addshore) [16:35:03] (03Merged) 10jenkins-bot: Add jshint to 'npm test' command [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/262718 (owner: 10Hashar) [16:36:07] 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, 10MediaWiki-extensions-EtherpadLite, and 16 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1918065 (10bd808... [16:40:31] 6Security-Team: Security Roadmap July - Sept 2015 (Q1 2015/2016) - https://phabricator.wikimedia.org/T105533#1918066 (10csteipp) 5Open>3Resolved a:3csteipp Dynamic Scanning: https://www.mediawiki.org/wiki/Wikimedia_Security_Team/ApplicationScanning Security bug metrics: https://www.mediawiki.org/wiki/Wikim... [16:41:43] (03PS2) 10Hashar: Pass jshint and add it to 'npm test' command [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/262710 (https://phabricator.wikimedia.org/T63620) [16:43:59] 6Security-Team: Automatically submit weekly core deployment branch (+skins, +vendor) to Veracode - https://phabricator.wikimedia.org/T121046#1918071 (10csteipp) [16:44:01] 6Security-Team: Goal: Implement static code analysis for security - https://phabricator.wikimedia.org/T110617#1918070 (10csteipp) [16:47:27] (03CR) 10Hashar: [C: 032] Add jshint to 'npm test' command [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/262717 (owner: 10Hashar) [16:48:16] (03Merged) 10jenkins-bot: Add jshint to 'npm test' command [extensions/AjaxLogin] - 10https://gerrit.wikimedia.org/r/262717 (owner: 10Hashar) [16:50:47] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1918074 (10Jdforrester-WMF) 3NEW [16:50:59] (03PS2) 10saper: Add SQLite Support to LDAP Authentication extension [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/262707 (https://phabricator.wikimedia.org/T108355) [16:51:54] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer, 7JavaScript, 5Patch-For-Review, and 2 others: Drop JavaScript support for IE8 (remove from "Grade A") - https://phabricator.wikimedia.org/T118303#1796846 (10Jdforrester-WMF) >>! In T118303#1855079, @Volker_E wrote: > Wouldn't this implicat... [17:03:59] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1918094 (10Niedzielski) @josephine_l, @NiharikaKohli, I do not get a ping of any kind for @ tags in a description change AFAIK. I do get an em... [17:10:35] (03CR) 10Jonas Kress (WMDE): "recheck" [data-values/value-view] - 10https://gerrit.wikimedia.org/r/262688 (https://phabricator.wikimedia.org/T95419) (owner: 10Jonas Kress (WMDE)) [17:11:34] 10Wikimedia-General-or-Unknown: Close #mediawiki-dev and redirect it to #wikimedia-dev - https://phabricator.wikimedia.org/T121687#1918112 (10Legoktm) [14:59:37] * domas has changed topic for #mediawiki-dev to: "http://mediawiki.org | you may want #wikimedia-dev or #mediawiki" Unfortunately people are still joi... [17:14:33] 6Security-Team: Goal: Implement static code analysis for security - https://phabricator.wikimedia.org/T110617#1918114 (10csteipp) 5Open>3Resolved a:3csteipp During Q2 we again investigated Veracode, Checkmarx and Pfff. * Pfff - taint-tracking is still closed-source at facebook. Variable analysis is too no... [17:26:37] hi."vagrant ssh" doesn't run on my machine . I've setup mediawiki-vagrant as per the intructions the corresponding page . Need help [17:27:40] 10Wikimedia-General-or-Unknown: Make domas' pageviews data available in semi-publicly queryable database format - https://phabricator.wikimedia.org/T44259#1918132 (10Slaporte) @Milimetric, when is pageview data from the previous day published? I noticed that data from January 5 [isn't available yet](https://wiki... [17:35:29] (03CR) 10Legoktm: [C: 032] Restore changes to WikiRevision that were lost in cdeba4cfc7c [core] - 10https://gerrit.wikimedia.org/r/262099 (owner: 10TTO) [17:35:51] 6Discovery, 3Discovery-Analysis-Sprint: Experimental forecast dashboard - https://phabricator.wikimedia.org/T122937#1918135 (10mpopov) Prototype up at http://discovery-experimental.wmflabs.org/forecast/ [17:38:00] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1918138 (10Jdforrester-WMF) CCing Scott as he said he was looking at this already in the... [17:38:46] 10MediaWiki-General-or-Unknown, 7Easy: Add a composer.local.json-sample to MediaWiki core - https://phabricator.wikimedia.org/T122968#1918140 (10Legoktm) 3NEW [17:39:04] Can I lobby for +1s on https://gerrit.wikimedia.org/r/#/c/252383/ ? :-) [17:39:59] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1918149 (10MarkTraceur) @ElveyLDAP I don't know how much you k... [17:42:28] legoktm: .sample and not .example? [17:42:31] (03Merged) 10jenkins-bot: Restore changes to WikiRevision that were lost in cdeba4cfc7c [core] - 10https://gerrit.wikimedia.org/r/262099 (owner: 10TTO) [17:43:19] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1918153 (10Jdforrester-WMF) [17:49:52] 6Reading-Admin: Feed service - https://phabricator.wikimedia.org/T122969#1918157 (10dr0ptp4kt) 3NEW [17:50:06] (03PS10) 10Alex Monk: Add support for PHP CodeSniffer checks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/241712 (owner: 10Siebrand) [17:50:48] 6Reading-Admin: Feed service - https://phabricator.wikimedia.org/T122969#1918170 (10dr0ptp4kt) [17:52:16] (03CR) 10jenkins-bot: [V: 04-1] Add support for PHP CodeSniffer checks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/241712 (owner: 10Siebrand) [17:52:58] dg711: Can you give more details on how `vagrant ssh` is failing for you? Maybe post a link to a pastebin of `vagrant ssh --debug` (it will be a lot of information) [17:56:29] 10MediaWiki-Internationalization, 10MediaWiki-RfCs, 3Wikidata-Sprint-2015-12-01: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1918177 (10cscott) Strawman proposal, based on conversations at the session and after: 1. Have the PHP parser track the... [17:57:43] 10MediaWiki-General-or-Unknown, 10Librarization, 7Easy: Add a composer.local.json-sample to MediaWiki core - https://phabricator.wikimedia.org/T122968#1918185 (10bd808) [17:59:55] (03PS11) 10Alex Monk: Add support for PHP CodeSniffer checks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/241712 (owner: 10Siebrand) [18:00:09] (03CR) 10Alex Monk: [C: 032] Add support for PHP CodeSniffer checks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/241712 (owner: 10Siebrand) [18:00:14] 10MediaWiki-Internationalization, 10MediaWiki-RfCs, 3Wikidata-Sprint-2015-12-01: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1918186 (10cscott) @tstarling It seems to me like step (1) above is possible, but you understand the PHP parser better t... [18:03:41] (03Merged) 10jenkins-bot: Add support for PHP CodeSniffer checks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/241712 (owner: 10Siebrand) [18:05:00] 4(no projects): add to alias - https://phabricator.wikimedia.org/T122927#1918194 (10eliza) Hello Krenair - unfortunately I am uncertain how to do this...can you guide me? [18:05:18] 10Phlogiston: Provide forecasts for categories without any velocity - https://phabricator.wikimedia.org/T122239#1918197 (10JAufrecht) [18:06:06] (03CR) 10Jdlrobson: [C: 032] "new day new attempt. cannot replicate locally.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [18:07:38] (03PS3) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [18:08:32] (03CR) 10Kaldari: Add hook to allow extensions to modify query used by Special:ShortPages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [18:08:54] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) (owner: 10Paladox) [18:09:14] It ran on git bash. I was trying to run on command prompt. My bad. Sorry to bother. [18:10:12] (03Merged) 10jenkins-bot: hygiene: Goodbye custom event emitter and class code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [18:10:12] 10Thumbor: Break down Thumbor response time - https://phabricator.wikimedia.org/T122971#1918207 (10ori) 3NEW a:3Gilles [18:10:44] dg711: No worries. It sounds like you got things working and that's what's important. :) [18:11:18] (03CR) 10Alex Monk: "Siebrand, would you mind i18n reviewing this please?" [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [18:11:29] (03PS4) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [18:12:37] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) (owner: 10Paladox) [18:13:06] (03CR) 10Muehlenhoff: Initial commit (035 comments) [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [18:18:09] (03CR) 10Gergő Tisza: [C: 04-1] "Looks good apart from the makeUrl issues." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [18:18:58] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1918218 (10TheDJ) I'd say, just use an IE conditional html5shim, but it's not a blocker.... [18:20:26] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015: MMV only shows every n-th image after closing and reopening - https://phabricator.wikimedia.org/T122785#1918221 (10Tgr) https://codein.withgoogle.com/dashboard/tasks/6258284147245056/ [18:21:32] (03PS2) 10Jdlrobson: Hygiene: Remove modules no longer needed now cache has cleared. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261299 [18:21:36] 10MediaWiki-extensions-RelatedArticles, 10Continuous-Integration-Config, 5Patch-For-Review, 3Reading-Web-Sprint-63-Ellip…: RelatedArticles browser tests should run on a commit basis - https://phabricator.wikimedia.org/T120715#1918228 (10bmansurov) Thanks, @hashar. What can we do to get https://gerrit.wikim... [18:22:11] (03PS3) 10Jdlrobson: Welcome to the future of module loading in ResourceLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260167 [18:22:43] bd808 : yeah! :D [18:23:07] 10MediaWiki-extensions-MultimediaViewer: Make MediaViewer error reporting link useful or remove it - https://phabricator.wikimedia.org/T111112#1918233 (10Tgr) [18:23:59] 10MediaWiki-Interface, 10MediaWiki-Tarball-Backports, 5MW-1.23-release: Backport mediawiki.skinning.content.parsoid to MW 1.23.x so VisualEditor master can run there - https://phabricator.wikimedia.org/T68812#1918248 (10greg) [18:24:33] 10MediaWiki-extensions-MultimediaViewer: Show personality rights warning - https://phabricator.wikimedia.org/T77397#1918251 (10Tgr) 5Open>3Resolved a:3Tgr Pretty sure this got fixed elsewhere. [18:25:04] 10MediaWiki-Releasing, 6Release-Engineering-Team: Unclear #MediaWiki-Tarball-Backports project usage - https://phabricator.wikimedia.org/T122501#1918255 (10greg) I vote for closing, and we just use the respective #MW-1.XX-release projects, eg #MW-1.27-release. I've updated the relevant backporting mw.org page... [18:26:24] 10MediaWiki-extensions-OAuth: RFC5849[2.3]: REQUIRED "oauth_token" and "oauth_token_secret" instead of "key" and "secret" - https://phabricator.wikimedia.org/T122122#1918256 (10Tgr) 5Open>3declined a:3Tgr Closing per csteipp. Feel free to reopen if you have further arguments. [18:26:27] (03CR) 10Anomie: [WIP] Implement action=mergehistory (0318 comments) [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) (owner: 10Sn1per) [18:26:35] (03CR) 10Anomie: [C: 04-1] [WIP] Implement action=mergehistory [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) (owner: 10Sn1per) [18:27:36] 10MediaWiki-Releasing, 6Release-Engineering-Team, 15User-greg: Unclear #MediaWiki-Tarball-Backports project usage - https://phabricator.wikimedia.org/T122501#1918268 (10greg) 5Open>3Resolved a:3greg {{done}} Updated description with what to do instead. Thanks for finding more places to clean up! :) [18:27:38] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Make metawiki the central OAuth wiki - https://phabricator.wikimedia.org/T59336#1918274 (10Tgr) [18:27:39] 10MediaWiki-extensions-OAuth, 7Documentation: Move Wikimedia OAuth documentation to Meta - https://phabricator.wikimedia.org/T109392#1918271 (10Tgr) 5Open>3Resolved a:3Tgr This happened, mostly. [18:27:56] 6Phabricator, 10Diffusion: Create a redirect script in phabricator so that if the repo dosent exist in diffusion we can see if it does in gitblit - https://phabricator.wikimedia.org/T122929#1918277 (10demon) >>! In T122929#1917613, @QChris wrote: > I only found [[https://www.mediawiki.org/wiki/Phabricator/Crea... [18:27:58] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Make metawiki the central OAuth wiki - https://phabricator.wikimedia.org/T59336#1918278 (10Tgr) 5Open>3Resolved a:3Tgr Migrated some time ago. [18:30:12] https://fr.wikipedia.org/wiki/MediaWiki:Gadget-AdvancedResearch.js I need help with this please. I don't get the expected error in console. There seems to be a problem with this task. [18:30:22] https://codein.withgoogle.com/dashboard/task-instances/4636942012514304/?sp-page=1 [18:30:23] Fix AdvancedResearch gadget on French Wikipedia || 5 days || Code || Wikimedia || Currently claimed [18:30:59] (03CR) 10jenkins-bot: [V: 04-1] Welcome to the future of module loading in ResourceLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260167 (owner: 10Jdlrobson) [18:32:40] (03CR) 10Mholloway: [C: 032] Fix Javadoc errors in MccMncStateHandler class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262326 (owner: 10Deskana) [18:32:46] (03PS10) 10Jdlrobson: Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/260517 [18:32:51] 6Parsing-Team: Section-scope declarations for Wiktionary template invocations - https://phabricator.wikimedia.org/T122934#1918310 (10cscott) Possibly related: T114454 -- "handlebars" style templates have a context object they pass down through nested invocations. [18:34:15] (03PS5) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [18:34:36] 4(no projects): Administer new CSAT - https://phabricator.wikimedia.org/T122974#1918314 (10DStrine) 3NEW [18:35:15] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) (owner: 10Paladox) [18:35:18] (03Merged) 10jenkins-bot: Fix Javadoc errors in MccMncStateHandler class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262326 (owner: 10Deskana) [18:35:46] legoktm: https://gerrit.wikimedia.org/r/#/c/253651/ [18:36:07] (03CR) 10Anomie: [C: 032] Add largest allowed range as parameter to block form message [core] - 10https://gerrit.wikimedia.org/r/261776 (owner: 10Gergő Tisza) [18:36:09] (03PS4) 10Jdlrobson: Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/261457 (https://phabricator.wikimedia.org/T93675) [18:36:12] 10MediaWiki-Releasing, 10MediaWiki-Tarball-Backports, 6Release-Engineering-Team, 7Security-Extensions: Backport security fixes to stable + LTS extension branches - https://phabricator.wikimedia.org/T108734#1918325 (10greg) Are you sure that there is "no effort" to backport security fixes to release branche... [18:36:21] (03PS6) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [18:38:22] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) (owner: 10Paladox) [18:39:48] 10MediaWiki-Internationalization, 10MediaWiki-RfCs, 3Wikidata-Sprint-2015-12-01: RFC: make Parser::getTargetLanguage aware of multilingual wikis - https://phabricator.wikimedia.org/T114640#1918339 (10cscott) @tstarling and @daniel think that it would be too hard to properly parse html-style tags in the prepr... [18:40:26] (03PS7) 10Paladox: Add extension.json, empty PHP entry point [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/262711 (https://phabricator.wikimedia.org/T88054) [18:42:21] (03Merged) 10jenkins-bot: Add largest allowed range as parameter to block form message [core] - 10https://gerrit.wikimedia.org/r/261776 (owner: 10Gergő Tisza) [18:42:44] (03CR) 10Hoo man: [C: 032] "Manually tested" [data-values/value-view] - 10https://gerrit.wikimedia.org/r/262688 (https://phabricator.wikimedia.org/T95419) (owner: 10Jonas Kress (WMDE)) [18:43:03] (03CR) 10jenkins-bot: [V: 04-1] Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/261457 (https://phabricator.wikimedia.org/T93675) (owner: 10Jdlrobson) [18:44:11] (03PS5) 10Jdlrobson: Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/261457 (https://phabricator.wikimedia.org/T93675) [18:44:40] (03Merged) 10jenkins-bot: Fixes: [Bug] Save button inactive when changing mono language [data-values/value-view] - 10https://gerrit.wikimedia.org/r/262688 (https://phabricator.wikimedia.org/T95419) (owner: 10Jonas Kress (WMDE)) [18:45:08] 10Security-Reviews, 6Security-Team, 10Thumbor: Thumbor Security Review - https://phabricator.wikimedia.org/T114414#1918343 (10dpatrick) == General Observations == - Positive - Code is well-organized into small, readable, uni-purpose classes - Negative - Very few inline comments and documentation == Issu... [18:45:10] 10MediaWiki-Releasing, 6Release-Engineering-Team, 7Security-Extensions: Backport security fixes to stable + LTS extension branches - https://phabricator.wikimedia.org/T108734#1918344 (10greg) [18:45:12] 10MediaWiki-Unit-tests, 5MW-1.23-release: Backport support for phpunit.phar, composer to 1.23.* LTS - https://phabricator.wikimedia.org/T96828#1918345 (10greg) [18:45:14] 10MediaWiki-Interface, 5MW-1.23-release: Backport mediawiki.skinning.content.parsoid to MW 1.23.x so VisualEditor master can run there - https://phabricator.wikimedia.org/T68812#1918346 (10greg) [18:45:29] (03CR) 10Anomie: [C: 04-1] Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called (033 comments) [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) (owner: 10Florianschmidtwelzow) [18:46:21] (03CR) 10Krinkle: [C: 04-1] Upgrade mismatched commit() warnings to exceptions [core] - 10https://gerrit.wikimedia.org/r/260888 (owner: 10Aaron Schulz) [18:46:46] 10MediaWiki-extensions-WikibaseRepository, 10ValueView, 10Wikidata, 7Regression: [Bug] Save button inactive when changing language on monolingual text statements - https://phabricator.wikimedia.org/T95419#1918348 (10hoo) 5Open>3Resolved [18:48:58] (03CR) 10jenkins-bot: [V: 04-1] Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/261457 (https://phabricator.wikimedia.org/T93675) (owner: 10Jdlrobson) [18:49:40] 10Wikimedia-Developer-Summit-2016-Organization: WikiDev16 Wrap-up session - https://phabricator.wikimedia.org/T121641#1918355 (10RobLa-WMF) == Snapshot of [notes from Etherpad](https://etherpad.wikimedia.org/p/WikiDev16-WrapUp) == Session name: Wrap-up Meeting goal: Main outcomes of each area + Community Wishli... [18:50:01] (03CR) 10Krinkle: [C: 04-1] "Since the message is generated server-side and not client-side (like with postEdit), and generated on the same private page (Special:Prefe" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [18:50:31] (03PS6) 10Krinkle: [WIP] Port mediawiki.util to requires module [core] - 10https://gerrit.wikimedia.org/r/260883 (owner: 10Jdlrobson) [18:51:00] (03CR) 10Krinkle: [C: 04-1] "Pending in-depth review." [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [18:51:32] (03CR) 10Mholloway: [C: 032] "We should probably have a utility method for this, but that's a different patch." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/261798 (https://phabricator.wikimedia.org/T122714) (owner: 10Deskana) [18:53:19] (03PS1) 10Jdlrobson: Remove Schema.extend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/262727 [18:53:21] (03PS1) 10MaxSem: Rm b/c code [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262728 [18:53:23] (03PS1) 10MaxSem: Improve docs, fix deprecated functons usage, rm unused method [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262729 [18:53:29] yurik, ^^ [18:54:23] (03CR) 10jenkins-bot: [V: 04-1] Improve docs, fix deprecated functons usage, rm unused method [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262729 (owner: 10MaxSem) [18:54:26] (03PS1) 10Kaldari: Exclude disambiguation pages from Special:ShortPages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/262730 (https://phabricator.wikimedia.org/T53124) [18:54:31] (03CR) 10Yurik: [C: 032] Rm b/c code [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262728 (owner: 10MaxSem) [18:54:58] 6Community-Liaison: Record the Community Liaison team's KPIs for December 2015 - https://phabricator.wikimedia.org/T118011#1918362 (10Whatamidoing-WMF) This is done. A number of page views were down; this is probably due to seasonal changes. We haven't significantly interacted with any new users on several pag... [18:54:58] (03PS3) 10Kaldari: Add hook to allow extensions to modify query used by Special:ShortPages [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) [18:55:02] (03CR) 10EBernhardson: [C: 032] Add initial .gitignore file [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/258034 (owner: 10EBernhardson) [18:55:10] (03CR) 10Smalyshev: "So, is this patch good to go now or still needs improvement?" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [18:55:15] (03CR) 10Alex Monk: Add mw-changeslist-(log|ns)-* class to OldChangesList as well (031 comment) [core] - 10https://gerrit.wikimedia.org/r/241678 (https://phabricator.wikimedia.org/T111666) (owner: 10Glaisher) [18:55:24] 10Datasets-General-or-Unknown: Automate translation updates for DCAT-AP - https://phabricator.wikimedia.org/T122975#1918364 (10hoo) 3NEW [18:55:24] (03CR) 10EBernhardson: [C: 032] Add empty lib/ directory in oozie/popularity_score [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/258036 (owner: 10EBernhardson) [18:55:27] (03Merged) 10jenkins-bot: Rm b/c code [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262728 (owner: 10MaxSem) [18:55:58] (03PS5) 10EBernhardson: Update annotations to be more sane [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258637 [18:56:02] 10MediaWiki-extensions-MultimediaViewer: Media Viewer ignores EXIF rotation - https://phabricator.wikimedia.org/T70320#1918371 (10Turnstep) Are there any temporary workarounds? Willing to monkeypatch as heavy as needed.... [18:56:04] (03Merged) 10jenkins-bot: Add initial .gitignore file [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/258034 (owner: 10EBernhardson) [18:56:42] (03Merged) 10jenkins-bot: Prevent app from inserting HTML tags into edit summaries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/261798 (https://phabricator.wikimedia.org/T122714) (owner: 10Deskana) [18:56:44] (03Merged) 10jenkins-bot: Add empty lib/ directory in oozie/popularity_score [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/258036 (owner: 10EBernhardson) [18:57:08] (03PS2) 10MaxSem: Improve docs, fix deprecated functons usage, rm unused method [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262729 [18:57:16] (03CR) 10Mholloway: "It might be even clearer to statically import the getBaseContentUri method directly from the base PersistenceHelper class in each case. S" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/261799 (owner: 10Deskana) [18:59:09] Krinkle: looks fine to me, are you looking for a +2? [18:59:10] (03PS1) 10MaxSem: Move a function to where it belongs [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262733 [18:59:15] legoktm: yeah [18:59:20] (03CR) 10Anomie: [C: 04-1] "For testing, I hacked getMaxResults() to 10 locally, then tested with limit=4 on Special:LinkSearch." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261325 (owner: 10Brian Wolff) [19:00:26] (03CR) 10jenkins-bot: [V: 04-1] Remove Schema.extend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/262727 (owner: 10Jdlrobson) [19:01:14] (03Abandoned) 10EBernhardson: [WIP] Collect per-node fetch/query latency percentiles [search/extra] - 10https://gerrit.wikimedia.org/r/258720 (owner: 10EBernhardson) [19:01:27] (03CR) 10Krinkle: "We should probably use googleoff instead. See https://www.google.com/support/enterprise/static/gsa/docs/admin/70/gsa_doc_set/admin_crawl/p" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/261758 (https://phabricator.wikimedia.org/T11209) (owner: 10PleaseStand) [19:01:41] 6Phabricator, 10Diffusion: Phabricator diffusion fails markup rendering for large files - https://phabricator.wikimedia.org/T122875#1918383 (10greg) [19:02:05] (03PS7) 10Legoktm: RequestContext: Load the request object for getRequest on first call [core] - 10https://gerrit.wikimedia.org/r/253651 (owner: 10Florianschmidtwelzow) [19:02:11] (03CR) 10Legoktm: [C: 032] RequestContext: Load the request object for getRequest on first call [core] - 10https://gerrit.wikimedia.org/r/253651 (owner: 10Florianschmidtwelzow) [19:02:21] (03PS1) 10Jdlrobson: Gather should use OO.mfExtend [extensions/Gather] (dev) - 10https://gerrit.wikimedia.org/r/262734 [19:02:51] (03PS1) 10Gerrit Patch Uploader: Rework JavaScript [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/262735 [19:02:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/262735 (owner: 10Gerrit Patch Uploader) [19:02:54] (03PS2) 10Jdlrobson: Remove Schema.extend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/262727 [19:03:33] (03CR) 10Legoktm: Initial commit (034 comments) [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [19:03:39] 10Security-Reviews, 6Security-Team, 10Thumbor: Thumbor Security Review - https://phabricator.wikimedia.org/T114414#1918388 (10csteipp) Darian asked me to look at crypto.py too. They were using a pretty broken encryption scheme for DoS prevention, and deprecated it. Follow their advice and use the HMAC signat... [19:03:39] (03CR) 10EBernhardson: "currently untested, waiting on getting a user account that discovery team members can share to "own" the deployment rather than reusing th" [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/261585 (owner: 10EBernhardson) [19:04:02] (03PS3) 10Jdlrobson: Remove Schema.extend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/262727 [19:04:16] (03PS7) 10Legoktm: Initial commit [debian] - 10https://gerrit.wikimedia.org/r/241690 [19:05:59] (03CR) 10Muehlenhoff: [C: 031] "Looks good to me :-)" [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [19:06:24] (03CR) 10Muehlenhoff: [C: 032 V: 032] Initial commit [debian] - 10https://gerrit.wikimedia.org/r/241690 (owner: 10Legoktm) [19:09:47] (03CR) 10Nikerabbit: [C: 04-1] "This will need a follow-up to move the tests for grammar to test grammarTransformations directly. I would consider embedding examples in t" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/241499 (https://phabricator.wikimedia.org/T115217) (owner: 10Amire80) [19:10:19] (03Merged) 10jenkins-bot: RequestContext: Load the request object for getRequest on first call [core] - 10https://gerrit.wikimedia.org/r/253651 (owner: 10Florianschmidtwelzow) [19:11:30] (03CR) 10Krinkle: Modern module loading (034 comments) [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [19:11:40] (03PS5) 10Esanders: WIP: VisualEditor support [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262448 [19:11:42] (03PS1) 10Esanders: Cleanup HTML output [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 [19:13:13] (03CR) 10jenkins-bot: [V: 04-1] Cleanup HTML output [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 (owner: 10Esanders) [19:14:02] (03CR) 10jenkins-bot: [V: 04-1] WIP: VisualEditor support [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262448 (owner: 10Esanders) [19:14:59] 10MediaWiki-extensions-MultimediaViewer: Media Viewer ignores EXIF rotation - https://phabricator.wikimedia.org/T70320#1918451 (10Tgr) You could change override `TransformationalImageHandler::mustRender` to always return true (that will enable generation of thumbnails with the exact same size as the image; norma... [19:16:09] (03CR) 10jenkins-bot: [V: 04-1] Gather should use OO.mfExtend [extensions/Gather] (dev) - 10https://gerrit.wikimedia.org/r/262734 (owner: 10Jdlrobson) [19:17:03] 3Team-Practices-This-Week: What have we learned from piloting burn-up charts? - https://phabricator.wikimedia.org/T121601#1918462 (10KLans_WMF) a:3JAufrecht [19:17:05] 10Thumbor: Create Phabricator tasks for items from Jan 6 2016 Thumbor meeting - https://phabricator.wikimedia.org/T122980#1918464 (10ori) 3NEW [19:17:28] 3Team-Practices-This-Week: Process CSAT results from Q2 - https://phabricator.wikimedia.org/T122981#1918474 (10DStrine) 3NEW [19:20:00] (03CR) 10jenkins-bot: [V: 04-1] Remove Schema.extend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/262727 (owner: 10Jdlrobson) [19:20:49] (03PS21) 10Jdlrobson: Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [19:21:00] (03CR) 10Jdlrobson: [C: 04-1] "other comments are going to require more thought/help" [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [19:22:33] (03Abandoned) 10Christopher Johnson (WMDE): adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [19:23:53] Hey everyone! In 1.23, the deprecated makeSizeLinkObj was removed. What should it be replaced with? (Level of knowledge is very basic, so simple words please. :D) [19:24:42] Sorry, that's Linker::makeSizeLinkObj, just to be perfectly clear. [19:25:12] (03CR) 10Krinkle: "Debug log level and progress reporter makes sense. I would recommend to keep client logging disabled as it was. Those logs are extremely v" [core] - 10https://gerrit.wikimedia.org/r/260388 (owner: 10Hashar) [19:26:25] (03CR) 10Krinkle: [C: 04-1] "The styles need to be specific to the page so that they don't break when loaded on a different page (e.g. after ajax navigation)." [core] - 10https://gerrit.wikimedia.org/r/262592 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [19:26:28] (03PS1) 10Mforns: Remove queue of event batches from mysql consumer [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) [19:26:28] 10Thumbor: Estimate working set size for thumbnail storage - https://phabricator.wikimedia.org/T122983#1918523 (10ori) 3NEW a:3Gilles [19:26:53] (03CR) 10jenkins-bot: [V: 04-1] Remove queue of event batches from mysql consumer [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) (owner: 10Mforns) [19:26:56] (03CR) 10Mforns: [C: 04-1] "Still WIP!" [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) (owner: 10Mforns) [19:27:16] (03PS1) 10Legoktm: Update signing key and watch file [debian] - 10https://gerrit.wikimedia.org/r/262739 [19:27:40] 10Security-Reviews, 6Security-Team, 10Thumbor: Thumbor Security Review - https://phabricator.wikimedia.org/T114414#1918536 (10Gilles) Thanks a lot! Thumbor instances won't be public-facing and all the content it's dealing with (images) has no privacy implications. Regarding EXIF, I've written a Thumbor ext... [19:27:53] 10MediaWiki-extensions-CLDR, 10Wikidata, 7Upstream: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#1918537 (10jeblad) There was an old bug report about other languages in Bugzilla, not sure how to find it. Only two o... [19:29:56] 10Security-Reviews, 6Security-Team, 10Thumbor: Thumbor Security Review - https://phabricator.wikimedia.org/T114414#1918544 (10Gilles) I'm in the office today, btw, so we can sit down and talk about it at some point today if you want. [19:30:37] 6WMF-NDA-Requests: Add hey_ok_deb to #wmf-nda - https://phabricator.wikimedia.org/T122920#1918545 (10Deskana) >>! In T122920#1917257, @Aklapper wrote: > [[ https://phabricator.wikimedia.org/p/hey_ok_deb/ | The Phab account ]] links to [[ https://www.mediawiki.org/wiki/User:Hey_ok_deb | this mw.org account ]]. [[... [19:31:19] (03CR) 10Krinkle: Convert Special:EmailUser to use OOUIHTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [19:31:47] 10MediaWiki-Interface, 10MediaWiki-Special-pages, 5Patch-For-Review, 7Regression: [Regression] Special:EmailUser and Special:ExpandTemplates broken after OOUI conversion - https://phabricator.wikimedia.org/T122907#1918547 (10Krinkle) [19:31:58] (03PS4) 10Jdlrobson: Allow other skins to be the mobile skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261202 [19:32:05] (03CR) 10Krinkle: [C: 032] Fix false message output method on Special:ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/262590 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [19:32:13] (03CR) 10Anomie: [C: 032] Add hook to allow extensions to modify query used by Special:ShortPages [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [19:32:15] (03CR) 10Anomie: [C: 032] Exclude disambiguation pages from Special:ShortPages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/262730 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [19:32:17] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1918548 (10cscott) The required output is really very simple. In the `` (or at th... [19:32:19] (03PS2) 10Jdlrobson: Gather should use OO.mfExtend [extensions/Gather] (dev) - 10https://gerrit.wikimedia.org/r/262734 [19:33:21] (03CR) 10Jdlrobson: "recheck" [extensions/Gather] (dev) - 10https://gerrit.wikimedia.org/r/261276 (https://phabricator.wikimedia.org/T121946) (owner: 10Jdlrobson) [19:35:06] (03Abandoned) 10Jdlrobson: WIP: Use hooks to control RelatedArticles during VisualEditor experience [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/258078 (owner: 10Jdlrobson) [19:35:45] (03PS1) 10Ananay: Convert MobileApp extension to use extension.json [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/262740 (https://phabricator.wikimedia.org/T88056) [19:36:01] 10MediaWiki-Revision-deletion, 10MobileFrontend: Wrong links on Special:MobileDiff to delete log when looking at revision deleted diff - https://phabricator.wikimedia.org/T122984#1918555 (10Umherirrender) 3NEW [19:36:07] (03Abandoned) 10Jdlrobson: WIP: Add InlineDifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/250081 (owner: 10Jdlrobson) [19:36:22] (03CR) 10Krinkle: [C: 04-1] Dependency inject TransactionProfiler into DatabaseBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262687 (owner: 10Aaron Schulz) [19:36:25] How do I add jenkins-bot? [19:36:32] to Gerrit [19:36:50] it will run automatically [19:37:18] So I don't need to add it as a reviewer? [19:38:08] no [19:38:39] 10MediaWiki-Revision-deletion, 10MobileFrontend: Special:MobileDiff shows revision deleted content to priviliged users by default - https://phabricator.wikimedia.org/T122985#1918572 (10Umherirrender) 3NEW [19:38:47] (03Merged) 10jenkins-bot: Fix false message output method on Special:ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/262590 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [19:39:10] 6Parsing-Team: Section-scope declarations for Wiktionary template invocations - https://phabricator.wikimedia.org/T122934#1918582 (10CodeCat) In the request thread, I mentioned the alternative of letting templates and modules access the full "tree" of headings they are nested in. For Wiktionary's purposes, custo... [19:40:44] (03PS1) 10MaxSem: Namespace this extension [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262741 (https://phabricator.wikimedia.org/T122339) [19:40:52] (03CR) 10Krinkle: [C: 032] Update packages to do with karma [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [19:41:02] (03Merged) 10jenkins-bot: Add hook to allow extensions to modify query used by Special:ShortPages [core] - 10https://gerrit.wikimedia.org/r/262680 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [19:41:02] 10MediaWiki-extensions-CLDR, 10Wikidata, 7Upstream: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#1918586 (10Nemo_bis) >>! In T74590#1918537, @jeblad wrote: > There was an old bug report about other languages Please... [19:41:04] (03Merged) 10jenkins-bot: Exclude disambiguation pages from Special:ShortPages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/262730 (https://phabricator.wikimedia.org/T53124) (owner: 10Kaldari) [19:41:11] 6Phabricator, 10Diffusion: Create a redirect script in phabricator so that if the repo dosent exist in diffusion we can see if it does in gitblit - https://phabricator.wikimedia.org/T122929#1918589 (10QChris) >>! In T122929#1918277, @demon wrote: > Via [[ /diffusion/new/ | this page ]]. Cool beans. https://w... [19:42:13] (03CR) 10Muehlenhoff: [C: 032 V: 032] Update signing key and watch file [debian] - 10https://gerrit.wikimedia.org/r/262739 (owner: 10Legoktm) [19:42:39] tto: Are you there? [19:43:00] (03PS6) 10Krinkle: Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/261457 (https://phabricator.wikimedia.org/T93675) (owner: 10Jdlrobson) [19:43:09] (03CR) 10Mooeypoo: [C: 032] "lgtm" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258521 (owner: 10Esanders) [19:43:51] legoktm: https://gerrit.wikimedia.org/r/#/c/262740/ Did you soo many reviewers? :O [19:44:09] (03PS3) 10Jforrester: Use ve.ui.Surface#setDisabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259284 (owner: 10Esanders) [19:44:16] I'll get to it in a bit [19:44:25] legoktm: Okay! [19:46:19] 10MobileFrontend: Special:Contributions for users that don't exist shows a generic, unformatted error in Mobile - https://phabricator.wikimedia.org/T122949#1918598 (10Jdlrobson) [19:46:20] 10MediaWiki-Special-pages, 10MobileFrontend, 7Epic, 7Milestone: Make Special:Contributions in core mobile friendly - https://phabricator.wikimedia.org/T122305#1918599 (10Jdlrobson) [19:47:08] 10MediaWiki-Revision-deletion: Add log excerpts to revdeleted diffs - https://phabricator.wikimedia.org/T23175#1918600 (10Nemo_bis) > the time of RevDel be added to the diff message That would be useful, but still requires a (simple) message change. [19:47:37] 10MobileFrontend: Special:Contributions for users that don't exist shows a generic, unformatted error in Mobile - https://phabricator.wikimedia.org/T122949#1918602 (10Jdlrobson) p:5Triage>3Lowest We need to fix T122305 rather than invest more time in this workaround feature as it will never meet expectations... [19:48:12] (03Merged) 10jenkins-bot: Change flow target to inherit from ve.init.mw.Target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258521 (owner: 10Esanders) [19:48:38] (03CR) 10jenkins-bot: [V: 04-1] Set threshold for is a tablet in LESS variable [core] - 10https://gerrit.wikimedia.org/r/261457 (https://phabricator.wikimedia.org/T93675) (owner: 10Jdlrobson) [19:49:35] (03CR) 10Florianschmidtwelzow: [C: 032] Hygiene: Remove modules no longer needed now cache has cleared. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261299 (owner: 10Jdlrobson) [19:49:49] (03CR) 10jenkins-bot: [V: 04-1] Update packages to do with karma [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [19:52:26] (03CR) 10Florianschmidtwelzow: Convert Special:EmailUser to use OOUIHTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [19:52:42] (03CR) 10jenkins-bot: [V: 04-1] Gather should use OO.mfExtend [extensions/Gather] (dev) - 10https://gerrit.wikimedia.org/r/262734 (owner: 10Jdlrobson) [19:52:59] (03PS2) 10Mforns: Remove queue of event batches from mysql consumer [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) [19:53:23] (03Merged) 10jenkins-bot: Hygiene: Remove modules no longer needed now cache has cleared. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261299 (owner: 10Jdlrobson) [19:54:11] (03PS7) 10Mr. Stradivarius: Standardise URI query formatting [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/199911 (https://phabricator.wikimedia.org/T93059) [19:54:36] 10MediaWiki-Interface, 7JavaScript, 5MW-1.27-release-notes: Add more mw.hook events for wikipage: diff, categories etc. - https://phabricator.wikimedia.org/T53583#1918614 (10Krinkle) [19:54:57] 10MediaWiki-Debian, 10Continuous-Integration-Config: Set up CI auto-building for mediawiki/debian repository - https://phabricator.wikimedia.org/T122978#1918615 (10Legoktm) [19:55:17] (03CR) 10Mforns: [C: 04-1] "Still WIP!" [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) (owner: 10Mforns) [19:55:47] 10MediaWiki-Internationalization, 10Deployment-Systems, 6Performance-Team, 7Performance: Experiment with plain .php files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740#1918619 (10Krinkle) [19:56:45] (03CR) 10jenkins-bot: [V: 04-1] Remove queue of event batches from mysql consumer [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) (owner: 10Mforns) [19:58:36] 10MediaWiki-Internationalization, 10Deployment-Systems, 6Performance-Team, 7Performance: Experiment with plain .php files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740#1918640 (10Krinkle) a:5Krinkle>3None [19:59:23] (03PS3) 10Mforns: Remove queue of event batches from mysql consumer [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) [20:00:10] (03CR) 10Mforns: [C: 04-1] "Still WIP!" [eventlogging] - 10https://gerrit.wikimedia.org/r/262738 (https://phabricator.wikimedia.org/T121151) (owner: 10Mforns) [20:00:38] (03PS6) 10Esanders: WIP: VisualEditor support [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262448 [20:00:40] (03PS2) 10Esanders: Cleanup HTML output [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 [20:00:56] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [debian] - 10https://gerrit.wikimedia.org/r/262746 [20:01:23] (03CR) 10Hashar: "check experimental" [debian] - 10https://gerrit.wikimedia.org/r/262746 (owner: 10Hashar) [20:01:32] #wmhack for upcoming sessions [20:01:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: VisualEditor support [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262448 (owner: 10Esanders) [20:02:19] (03CR) 10Florianschmidtwelzow: "> Maybe we can use the method (GET vs POST) to distinguish this instead of this hidden field?" [core] - 10https://gerrit.wikimedia.org/r/262589 (https://phabricator.wikimedia.org/T122907) (owner: 10Florianschmidtwelzow) [20:02:23] (03PS6) 10Gerrit Patch Uploader: Preferences: Use cookie instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) [20:02:26] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [20:02:27] (03CR) 10jenkins-bot: [V: 04-1] Cleanup HTML output [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 (owner: 10Esanders) [20:02:33] (03CR) 10Fomafix: "rebased" [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [20:03:09] (03CR) 10Krinkle: "May need back-compat for existing parser cache." [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 (owner: 10Esanders) [20:03:19] (03PS4) 10Florianschmidtwelzow: Fix Special:EmailUser [core] - 10https://gerrit.wikimedia.org/r/262589 (https://phabricator.wikimedia.org/T122907) [20:04:04] 10Annual-Report, 10Security-Reviews, 6Security-Team: security review 15.wikipedia/annual2015 code review - https://phabricator.wikimedia.org/T119478#1918661 (10csteipp) @Dzahn, the twitter urls there point to http://15.wikipedia.org. Do we have https on that domain? [20:04:36] 10MediaWiki-Debian, 10Continuous-Integration-Config, 5Patch-For-Review: Set up CI auto-building for mediawiki/debian repository - https://phabricator.wikimedia.org/T122978#1918663 (10hashar) I have send a test change https://gerrit.wikimedia.org/r/#/c/262746/ and ran the `debian-glue` job there. Obviously f... [20:06:13] (03CR) 10Florianschmidtwelzow: Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called (033 comments) [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) (owner: 10Florianschmidtwelzow) [20:06:26] (03PS19) 10Florianschmidtwelzow: Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) [20:06:35] 3Team-Practices-This-Week: Update TPG Q3 goals spreadsheet/wiki - https://phabricator.wikimedia.org/T122988#1918666 (10ggellerman) 3NEW a:3ggellerman [20:06:42] (03PS20) 10Florianschmidtwelzow: Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) [20:06:57] (03PS4) 10Florianschmidtwelzow: Replace multiple lists of page_ table data in multiple places with one central place [core] - 10https://gerrit.wikimedia.org/r/261590 [20:07:03] 10MediaWiki-extension-requests, 6Commons, 6Discovery, 10Kartographer, 10Maps: Generate location maps dynamically, producing actual images - https://phabricator.wikimedia.org/T120809#1918677 (10TheDJ) There is some overlap here with what @aude, @jdlrobson and myself worked on 2 years ago in zurich, namely... [20:08:08] (03CR) 10Fomafix: Preferences: Use cookie instead of URL parameter for success (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [20:08:23] 10MediaWiki-extensions-RelatedArticles, 10Continuous-Integration-Config, 5Patch-For-Review, 3Reading-Web-Sprint-63-Ellip…: RelatedArticles browser tests should run on a commit basis - https://phabricator.wikimedia.org/T120715#1918679 (10hashar) Oops eggs and chicken really. Since the browser tests are fail... [20:09:51] (03CR) 10Florianschmidtwelzow: "What is false with If359e391b763ca6cf0358a604c2a04276f14ca53 ???? I think this can be abandoned and you could work in this change :)" [core] - 10https://gerrit.wikimedia.org/r/262709 (owner: 10Paladox) [20:10:06] 10MediaWiki-Configuration, 5Patch-For-Review: Add define support to extension registration converter - https://phabricator.wikimedia.org/T99089#1918680 (10Florian) a:5Florian>3None [20:10:54] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [20:15:23] (03PS2) 10Gerrit Patch Uploader: SpecialUserrights: Use cookie instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) [20:15:26] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [20:17:25] (03PS12) 10Paladox: Add extension.json, empty php entry point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/222566 (https://phabricator.wikimedia.org/T87876) [20:17:53] (03PS1) 10Esanders: Make ext.graph a dependecy of VE module [extensions/Graph] - 10https://gerrit.wikimedia.org/r/262751 [20:18:04] (03PS1) 10Paladox: Update mediawiki/mediawiki-codesniffer to 0.5.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/262752 [20:19:47] (03PS2) 10Paladox: Bump browserNoActivityTimeout to 2 mins instead of 1 min for karma [core] - 10https://gerrit.wikimedia.org/r/262713 [20:20:46] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki/mediawiki-codesniffer to 0.5.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/262752 (owner: 10Paladox) [20:21:12] (03CR) 10Paladox: "Sorry forgot about that one. I will do that. I will update that patch instead." [core] - 10https://gerrit.wikimedia.org/r/262709 (owner: 10Paladox) [20:23:43] (03PS1) 10Lokal Profil: Issue badges through API and add e-mail requirments [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/262754 (https://phabricator.wikimedia.org/T103845) [20:25:03] (03PS2) 10Paladox: Add full define support in extension registration. [core] - 10https://gerrit.wikimedia.org/r/262709 [20:25:33] 10MediaWiki-extensions-CLDR, 10Wikidata, 7Upstream: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant) - https://phabricator.wikimedia.org/T74590#1918701 (10Nikki) T74126 is the one where we've been collecting requests. Out of the ones listed on these two tickets... [20:26:53] 10MediaWiki-extensions-Disambiguator, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): remove disambiguation pages from Special:ShortPages - https://phabricator.wikimedia.org/T53124#1918703 (10kaldari) 5Open>3Resolved a:3kaldari [20:26:56] (03PS8) 10Paladox: Add full define support in extension registration. [core] - 10https://gerrit.wikimedia.org/r/211130 (https://phabricator.wikimedia.org/T99089) [20:27:20] (03Abandoned) 10Paladox: Add full define support in extension registration. [core] - 10https://gerrit.wikimedia.org/r/262709 (owner: 10Paladox) [20:27:21] 10MediaWiki-RfCs, 5MW-1.27-release: RfC: Raise MediaWiki's PHP version requirement and update coding standards - https://phabricator.wikimedia.org/T118932#1918705 (10Legoktm) Adding this as a 1.27 blocker because I think we'd like this issue to be resolved before that is released. [20:28:29] (03CR) 10Yaron Koren: "Hi," [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [20:30:57] (03PS8) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [20:31:12] (03PS76) 10Anomie: WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [20:32:35] hell [20:32:38] hello* [20:32:40] (03PS77) 10Anomie: WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [20:33:41] (03CR) 10jenkins-bot: [V: 04-1] Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) (owner: 10Anomie) [20:34:03] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [20:34:06] (03PS1) 10Isarra: Refactor monobook to be better organised and more modern [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/262755 [20:34:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [20:34:33] (03PS3) 10Gerrit Patch Uploader: SpecialUserrights: Use cookie instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) [20:34:35] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [20:34:38] (03CR) 10Bartosz Dziewoński: "CI wa broken yesterday for a few hours because Karma has a fuzzy dependency on some upstream library, and that library released a point ve" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/237394 (owner: 10Jdlrobson) [20:34:56] (03CR) 10Paladox: "Most of the code was backported into 1.25 including fixes." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [20:35:04] (03CR) 10jenkins-bot: [V: 04-1] Refactor monobook to be better organised and more modern [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/262755 (owner: 10Isarra) [20:36:57] * legoktm hugs Isarra [20:37:32] (03CR) 10Victorbarbu: Provide short URL to file description page in imageinfo API (033 comments) [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [20:38:18] (03PS10) 10Victorbarbu: Provide short URL to file description page in imageinfo API [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) [20:38:30] (03PS4) 10Paladox: Re enable extension registration [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 [20:39:08] tgr, I uploaded a new patch [20:39:32] thx, will check soon [20:40:12] I will also submit the task for review, if I haven't already [20:40:14] :) [20:41:08] (03CR) 10Legoktm: [C: 04-1] "See inline comments" (032 comments) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/262740 (https://phabricator.wikimedia.org/T88056) (owner: 10Ananay) [20:41:41] (03CR) 10Victorbarbu: "reheck" [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [20:41:56] (03Abandoned) 10Hashar: Update phpunit to 4.8.* [AhoCorasick] - 10https://gerrit.wikimedia.org/r/254539 (owner: 10Paladox) [20:41:59] (03Abandoned) 10Hashar: Update phpunit to 4.8.* [utfnormal] - 10https://gerrit.wikimedia.org/r/254559 (owner: 10Paladox) [20:42:11] legoktm: Apparently someone started adding organisation already. Like vector. [20:42:19] Which is horrible. [20:42:33] 10MobileFrontend, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1918720 (10Legoktm) [20:42:34] 10MediaWiki-Configuration: Allow comments in the extension.json and skin.json files - https://phabricator.wikimedia.org/T108332#1918717 (10Legoktm) 5declined>3Open @yurik would like me/us to reconsider this. [20:42:52] 10MediaWiki-Configuration: Allow comments in the extension.json and skin.json files - https://phabricator.wikimedia.org/T108332#1918721 (10Legoktm) a:5Legoktm>3None [20:43:07] 10MediaWiki-Configuration: Allow comments in the extension.json and skin.json files - https://phabricator.wikimedia.org/T108332#1518182 (10Legoktm) [20:43:09] 10MobileFrontend, 5Patch-For-Review: Convert MobileFrontend extension to use extension registration - https://phabricator.wikimedia.org/T88057#1003253 (10Legoktm) [20:43:16] (03Abandoned) 10Hashar: Rename to CREDITS.mediawiki, add symlink [core] - 10https://gerrit.wikimedia.org/r/249307 (https://phabricator.wikimedia.org/T116690) (owner: 10Spage) [20:43:56] 10MediaWiki-Configuration: Allow comments in the extension.json and skin.json files - https://phabricator.wikimedia.org/T108332#1918725 (10Yurik) CC: @TheDJ who said "Me too" [20:44:23] (03CR) 10Esanders: "This extension hasn't been deployed anywhere yet." [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 (owner: 10Esanders) [20:44:25] (03Abandoned) 10Hashar: Updated todo to refer to T118932 [core] - 10https://gerrit.wikimedia.org/r/258175 (owner: 10Albert221) [20:45:40] (03Abandoned) 10Hashar: Add grunt-jscs [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/255423 (owner: 10Paladox) [20:45:42] (03CR) 10Yaron Koren: "Alright, great - I'm reassured now. Thanks for the explanation. I'm looking forward to having Cargo finally use extension.json. Only one o" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [20:45:53] 6Phabricator, 10Diffusion: Create a redirect script in phabricator so that if the repo dosent exist in diffusion we can see if it does in gitblit - https://phabricator.wikimedia.org/T122929#1918728 (10demon) >>! In T122929#1918589, @QChris wrote: > https://www.mediawiki.org/wiki/Phabricator/Diffusion/Callsign_... [20:47:21] (03CR) 10Nemo bis: "Can someone point me to a guideline that says code comments are not worth improving? Can we just remove the comment?" [core] - 10https://gerrit.wikimedia.org/r/258175 (owner: 10Albert221) [20:48:06] (03PS4) 10Tacsipacsi: Add GENDER support for log and status messages. [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/262129 [20:48:35] 10MediaWiki-Codesniffer, 5Patch-For-Review: Add sniff to detect double empty lines in php code - https://phabricator.wikimedia.org/T120570#1918737 (10polybuildr) 5Open>3Resolved I've also opened an issue upstream: https://github.com/squizlabs/PHP_CodeSniffer/issues/851 [20:49:06] (03CR) 10Fomafix: "A server-side storage seams also be possible." [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [20:49:22] (03PS1) 10Legoktm: Display Cite errors in the user language [extensions/Cite] - 10https://gerrit.wikimedia.org/r/262758 (https://phabricator.wikimedia.org/T33216) [20:49:33] legoktm: Gadgets.php also has a return: true; statement. Should I put that too? [20:49:41] victorbarbu_: btw you don’t have to comment recheck every time, jenkins automatically looks at new patchsets. You usually only need recheck if something fails that shouldn’t have. [20:49:41] In MobileApp.php [20:49:46] ananayarora: no, don't need that [20:50:06] unicornisaurous, thanks [20:50:16] (03Abandoned) 10Hashar: Add jshint to npm [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/254477 (owner: 10Paladox) [20:50:27] legoktm: Okay. And wfWarn() as a comment, not as code. Right? [20:50:39] (03PS2) 10Isarra: Refactor monobook to be better organised and more modern [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/262755 [20:50:39] yes [20:51:33] 6Phabricator, 6Project-Creators, 6operations: Create policy projects and convert people projects to open - https://phabricator.wikimedia.org/T90491#1918744 (10RobH) [20:52:13] legoktm: https://gerrit.wikimedia.org/r/#/c/262740/1/extension.json In here, do I remove only localBasePath, or the whole config { } block? [20:52:21] 6Phabricator, 10Diffusion: Create a redirect script in phabricator so that if the repo dosent exist in diffusion we can see if it does in gitblit - https://phabricator.wikimedia.org/T122929#1918746 (10Paladox) @demon what would callsigns be replaced with. Will it is tead use the extension name. [20:52:22] ananayarora: the whole config block [20:53:16] (03PS2) 10Ananay: Convert MobileApp extension to use extension.json [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/262740 (https://phabricator.wikimedia.org/T88056) [20:54:58] (03PS5) 10Paladox: Re enable extension registration [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 [20:56:21] 6Reading-Admin, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Replicate custom exit interstitial behavior in Android App - https://phabricator.wikimedia.org/T119126#1918752 (10Mholloway) a:3Mholloway [20:57:12] (03PS78) 10Anomie: WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [20:57:28] 10MediaWiki-extensions-Translate, 10Continuous-Integration-Infrastructure: mediawiki-extensions-hhvm: MessageGroupStatesUpdaterJobTest::testHooks is intermittent failing - https://phabricator.wikimedia.org/T88554#1918756 (10hashar) 5Open>3Resolved a:3hashar [20:58:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [20:59:50] 6MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit-2016, 3DevRel-December-2015: Meeting with MW Stakeholders and WMF - https://phabricator.wikimedia.org/T119403#1918762 (10Legoktm) Here's the etherpad copy: WMDS session with MediaWiki Stakeholders group/WMF Cindy talked a bit about MITRE and thei... [21:01:28] (03CR) 10Yurik: Make ext.graph a dependecy of VE module (031 comment) [extensions/Graph] - 10https://gerrit.wikimedia.org/r/262751 (owner: 10Esanders) [21:02:25] (03CR) 10Yaron Koren: "Sorry - the comments on lines 14-16 should still be there. I apologize for making you do all this extra work. I think this will be the las" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [21:03:47] (03CR) 10Bartosz Dziewoński: "Has to be reconciled with https://gerrit.wikimedia.org/r/#/c/244508/" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/262758 (https://phabricator.wikimedia.org/T33216) (owner: 10Legoktm) [21:03:52] (03PS2) 10Brian Wolff: Follow-up e33d6f45a. Fix some mistakes w/ limit on QueryPage [core] - 10https://gerrit.wikimedia.org/r/261325 [21:03:56] 10MediaWiki-Debian, 10Continuous-Integration-Config: Set up CI auto-building for mediawiki/debian repository - https://phabricator.wikimedia.org/T122978#1918780 (10hashar) p:5Triage>3Normal [21:03:59] (03CR) 10Bartosz Dziewoński: "Has to be reconciled with https://gerrit.wikimedia.org/r/#/c/262758/" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/244508 (owner: 10Amire80) [21:05:20] (03PS13) 10Parent5446: Refactored special pages into HTMLForm and proxy [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134789 [21:05:22] (03PS2) 10Parent5446: Allow for using separate database for OATH creds [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213764 (https://phabricator.wikimedia.org/T100374) [21:05:23] (03PS16) 10Parent5446: Refactor extension key storage [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134050 [21:06:15] (03CR) 10jenkins-bot: [V: 04-1] Refactored special pages into HTMLForm and proxy [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134789 (owner: 10Parent5446) [21:06:29] (03CR) 10jenkins-bot: [V: 04-1] Allow for using separate database for OATH creds [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213764 (https://phabricator.wikimedia.org/T100374) (owner: 10Parent5446) [21:07:07] (03CR) 10Gergő Tisza: [C: 031] "Looks good, I'll test it in a short while." [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) (owner: 10Victorbarbu) [21:08:39] 10OpenBadges: Make OpenBadges compatible with v. 1.1 specs - https://phabricator.wikimedia.org/T122991#1918785 (10Lokal_Profil) 3NEW [21:11:57] (03PS2) 10Parent5446: Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) [21:12:18] (03PS39) 10Paladox: Update Moment.js from 2.8.4 to 2.11.0 [core] - 10https://gerrit.wikimedia.org/r/183903 (https://phabricator.wikimedia.org/T117136) [21:12:34] (03CR) 10jenkins-bot: [V: 04-1] Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) (owner: 10Parent5446) [21:13:56] 4(no projects): Support developer use cases in mediawiki-containers - https://phabricator.wikimedia.org/T122992#1918793 (10GWicke) 3NEW [21:14:12] 10mediawiki-containers: Support developer use cases in mediawiki-containers - https://phabricator.wikimedia.org/T122992#1918799 (10GWicke) [21:16:33] (03PS2) 10Parent5446: Make OATHAuth respect $wgSecureLogin [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213770 (https://phabricator.wikimedia.org/T55197) [21:16:55] (03Abandoned) 10Parent5446: Move token login to separate page [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135597 (https://bugzilla.wikimedia.org/53195) (owner: 10Parent5446) [21:17:00] (03CR) 10jenkins-bot: [V: 04-1] Make OATHAuth respect $wgSecureLogin [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213770 (https://phabricator.wikimedia.org/T55197) (owner: 10Parent5446) [21:17:43] (03PS14) 10Parent5446: Refactored special pages into HTMLForm and proxy [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/134789 [21:18:57] (03PS15) 10Zfilipin: WIP WebDriverJs + Mocha [core] - 10https://gerrit.wikimedia.org/r/256404 (https://phabricator.wikimedia.org/T108874) [21:19:04] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Make metawiki the central OAuth wiki - https://phabricator.wikimedia.org/T59336#1918812 (10He7d3r) @Tgr: Just for curiosity: can I check that by going to some Special page, or making some api call, or only looking at some line in the config files used for WMF wi... [21:19:19] (03CR) 10jenkins-bot: [V: 04-1] WIP WebDriverJs + Mocha [core] - 10https://gerrit.wikimedia.org/r/256404 (https://phabricator.wikimedia.org/T108874) (owner: 10Zfilipin) [21:20:48] 10Wikimania-Hackathon-2015: Building a Visual Video Editor for the Web - https://phabricator.wikimedia.org/T105970#1918813 (10TheDJ) [[ http://popcorn-editor.wmflabs.org | Demo instance ]] [21:22:38] (03PS3) 10Parent5446: Allow for using separate database for OATH creds [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213764 (https://phabricator.wikimedia.org/T100374) [21:22:42] (03PS3) 10Parent5446: Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) [21:22:44] (03PS1) 10Jforrester: build: Update development dependencies [IPSet] - 10https://gerrit.wikimedia.org/r/262817 [21:22:46] (03PS3) 10Parent5446: Make OATHAuth respect $wgSecureLogin [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213770 (https://phabricator.wikimedia.org/T55197) [21:23:08] 10MediaWiki-extension-requests, 10TimedMediaHandler: tag for audio playlists - https://phabricator.wikimedia.org/T3954#1918828 (10TheDJ) [21:23:22] (03CR) 10jenkins-bot: [V: 04-1] Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) (owner: 10Parent5446) [21:23:35] 10MediaWiki-extensions-Gadgets: The CSS of each gadget is included two times - https://phabricator.wikimedia.org/T42284#1918832 (10He7d3r) [21:24:08] tgr, thanks for the review, I hope it is okay and my task will be approved :D [21:24:51] 10MediaWiki-extension-requests, 10TimedMediaHandler: tag for audio playlists - https://phabricator.wikimedia.org/T3954#1918839 (10TheDJ) Someone build a radio station that has some playlist ideas to it as well. https://tools.wmflabs.org/wikiradio/ [21:25:11] 10MediaWiki-extensions-Gadgets, 6Community-Tech, 6Community-Tech-fixes: rl2.wmflabs.org: RL executes the module before the i18n messages are available - https://phabricator.wikimedia.org/T41027#1918841 (10He7d3r) [21:25:27] (03PS4) 10Parent5446: Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) [21:25:40] (03PS40) 10Paladox: Update Moment.js from 2.8.4 to 2.11.0 [core] - 10https://gerrit.wikimedia.org/r/183903 (https://phabricator.wikimedia.org/T117136) [21:25:42] (03CR) 10Legoktm: [C: 032] build: Update development dependencies [IPSet] - 10https://gerrit.wikimedia.org/r/262817 (owner: 10Jforrester) [21:25:54] (03CR) 10jenkins-bot: [V: 04-1] Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) (owner: 10Parent5446) [21:25:57] 10MediaWiki-extensions-Gadgets, 6Community-Tech, 10WikiProject-tools: Gadgets 2.0: "hidden" doesn't work - https://phabricator.wikimedia.org/T41025#1918843 (10He7d3r) [21:26:30] (03Merged) 10jenkins-bot: build: Update development dependencies [IPSet] - 10https://gerrit.wikimedia.org/r/262817 (owner: 10Jforrester) [21:26:56] (03PS1) 10MtDu: Reword upload-dialog-button-save message differently -Finnish translations use the same word for save and upload. [core] - 10https://gerrit.wikimedia.org/r/262818 [21:26:58] 4(no projects): Add a hook to override behaviour for anon users in ULS - https://phabricator.wikimedia.org/T122994#1918849 (10coren) 3NEW [21:27:01] 10MediaWiki-extensions-Gadgets, 7JavaScript: Provide standard way to create/run QUnit tests for Gadgets and user scripts - https://phabricator.wikimedia.org/T39230#1918855 (10He7d3r) [21:27:42] (03CR) 10Legoktm: [C: 032] "Please submit the GCI task so I can approve it" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/262740 (https://phabricator.wikimedia.org/T88056) (owner: 10Ananay) [21:27:46] 10Wikimedia-General-or-Unknown, 7Documentation, 7JavaScript: Auto-generated gadget documentation with JsDuck - https://phabricator.wikimedia.org/T53651#1918867 (10He7d3r) [21:28:03] 4(no projects): Add a hook to override behaviour for anon users in ULS - https://phabricator.wikimedia.org/T122994#1918868 (10coren) [21:28:17] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1918871 (10Legoktm) [21:28:20] 10MediaWiki-extensions-WikibaseClient, 10ArticlePlaceholder, 10Wikidata, 7Story: [Story] Caching for the article placeholders - https://phabricator.wikimedia.org/T109458#1918872 (10hoo) [21:28:43] 4(no projects): Add a hook to override behaviour for anon users in ULS - https://phabricator.wikimedia.org/T122994#1918849 (10coren) [21:29:02] (03PS6) 10Paladox: Re enable extension registration [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 [21:29:35] legoktm: Submitted! Let me do the same with the Phabricator task. [21:29:54] 10MediaWiki-extensions-AbuseFilter: Provide ability to watch for changes on filters - https://phabricator.wikimedia.org/T62588#1918879 (10He7d3r) [21:30:00] 10Wikipedia-App-MobileApp-extension, 3Google-Code-In-2015, 5Patch-For-Review: Convert MobileApp extension to use extension registration - https://phabricator.wikimedia.org/T88056#1918889 (10ananayarora) a:3ananayarora [21:30:17] 10Wikipedia-App-MobileApp-extension, 3Google-Code-In-2015, 5Patch-For-Review: Convert MobileApp extension to use extension registration - https://phabricator.wikimedia.org/T88056#1918891 (10ananayarora) 5Open>3Resolved [21:30:23] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1918892 (10ananayarora) [21:30:39] 10MediaWiki-extensions-AbuseFilter: AbuseFilter should let users to mark log entries as false positives - https://phabricator.wikimedia.org/T30213#1918893 (10He7d3r) [21:30:44] 3Wikipedia-Android-App: Sort out which app versions feeds which MobileWikiAppToCInteraction table - https://phabricator.wikimedia.org/T119664#1918896 (10JKatzWMF) @Tbayer @dbrant I was talking with somebody on the Android team a short while ago about the TOC and they mentioned that they thought the onboarding fo... [21:30:58] (03Merged) 10jenkins-bot: Convert MobileApp extension to use extension.json [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/262740 (https://phabricator.wikimedia.org/T88056) (owner: 10Ananay) [21:31:36] 10MediaWiki-extensions-AbuseFilter, 5Patch-For-Review: Condition limit is broken: consumes 100,000+ conditions limit is set to 1000 - https://phabricator.wikimedia.org/T53294#1918899 (10He7d3r) [21:32:05] ___ ____ [21:32:05] ⎛ ⎛ ,---- [21:32:06] \ //==--' [21:32:08] _//| .·//==--' ____________________________ [21:32:10] _OO≣=- ︶ ᴹw ⎞_§ ______ ___\ ___\ ,\__ \/ __ \ [21:32:12] (∞)_, ) ( | ______/__ \/ /__ / /_/ / /_/ / [21:32:15] ¨--¨|| |- ( / _______\___/ \___/ \__^_/ .__/ [21:32:17] ««_/ «_/ jgs/bd808 /_/ [21:32:19] (03CR) 10Anomie: Standardise URI query formatting (037 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/199911 (https://phabricator.wikimedia.org/T93059) (owner: 10Mr. Stradivarius) [21:33:28] legoktm: Necessary. :-P [21:33:58] What do the words at the end say? I can't read :P [21:34:03] scap! [21:34:05] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229470 (owner: 10Paladox) [21:34:13] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231788 (https://phabricator.wikimedia.org/T109184) (owner: 10Paladox) [21:34:22] oh [21:34:33] It looks like a rabbit to me [21:34:36] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231575 (https://phabricator.wikimedia.org/T108312) (owner: 10Paladox) [21:34:47] https://www.mediawiki.org/wiki/Deployment_tooling/Notes/What_does_scap_do ohhhhhhhhh [21:34:56] https://wikitech.wikimedia.org/wiki/Wikimedia_binaries#scap [21:34:57] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [21:35:04] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234913 (owner: 10Paladox) [21:36:08] it's a flying pig! [21:36:16] https://doc.wikimedia.org/mw-tools-scap/#what-does-scap-mean [21:36:30] ▄▄▄▄▄▄▄░▄▄▄▄▄▄▄░▄▄▄▄▄▄░▄▄▄▄▄ [21:36:32] ░░▀███░░░░▀██░░░░██▀░░░░██░░ [21:36:34] ░░░▀██░░░░░▀██░░▄█░░░░░▄█░░░ [21:36:36] ░░░░███░░░░░▀██▄█░░░░░░█░░░░ [21:36:39] ░░░░░███░░░░░▀██░░░░░░█▀░░░░ [21:36:41] ░░░░░░███░░░░▄███░░░░█▀░░░░░ [21:36:43] ░░░░░░░██▄░░▄▀░███░░█▀░░░░░░ [21:36:45] ░░░░░░░▀██▄█▀░░░███▄▀░░░░░░░ [21:36:47] ░░░░░░░░▀██▀░░░░░███░░░░░░░░ [21:36:50] ░░░░░░░░░▀▀░░░░░░░▀░░░░░░░░░ [21:36:59] doesn't work as well with proportional font :D [21:37:01] The day the ASCII art rose [21:37:18] now back to work ;) [21:37:26] 80 columns ought to be enough for anybody [21:37:31] (03PS7) 10Paladox: Support 4k in ogv videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234913 [21:38:39] ASCII Art because IRC doesn't support digital media :3 [21:38:40] (03PS5) 10Paladox: Update extension name [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237520 [21:38:42] 6Reading-Admin, 3Wikipedia-Android-App: Improve retention of customized 'preload' APK ID - https://phabricator.wikimedia.org/T115396#1918916 (10Niedzielski) I must reverse my preference on implementation. Unpacking and reading the contents of the apk is quite doable and requires no additional permissions. Howe... [21:38:44] 10MediaWiki-Interface, 7JavaScript, 5MW-1.27-release-notes: Add more mw.hook events for wikipage: diff, categories etc. - https://phabricator.wikimedia.org/T53583#1918917 (10TheDJ) @Krinkle you do not think there is enough value if hotcat only hooks into this after VE saved the page ? [21:40:12] 10MediaWiki-Interface, 7JavaScript, 5MW-1.27-release-notes: Add more mw.hook events for wikipage: diff, categories etc. - https://phabricator.wikimedia.org/T53583#1918918 (10Krinkle) >>! In T53583#1918917, @TheDJ wrote: > @Krinkle you do not think there is enough value if hotcat only hooks into this after VE... [21:41:48] 10MobileFrontend, 10Reading-Web: External Links header showing up even when all content is hidden - https://phabricator.wikimedia.org/T122997#1918919 (10jhobs) 3NEW [21:42:06] :o [21:44:08] * legoktm spies a mrstradivarius! [21:44:16] (03PS4) 10Paladox: Remove css code related to wikihow extension [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/251805 (https://phabricator.wikimedia.org/T111446) [21:44:32] legoktm: Yo [21:44:48] 10Reading-Web: [EPIC] All templates on wiki should work in mobile - https://phabricator.wikimedia.org/T109152#1918935 (10Jdlrobson) [21:44:49] 10MobileFrontend, 10Reading-Web: External Links header showing up even when all content is hidden - https://phabricator.wikimedia.org/T122997#1918936 (10Jdlrobson) [21:45:01] (03CR) 10Paladox: "check experimental" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/251805 (https://phabricator.wikimedia.org/T111446) (owner: 10Paladox) [21:45:31] 10Reading-Web: [EPIC] All templates on wiki should work in mobile - https://phabricator.wikimedia.org/T109152#1541688 (10Jdlrobson) [21:49:40] 10TimedMediaHandler: Support MPEG DASH for multiple webm files - https://phabricator.wikimedia.org/T44591#1918945 (10TheDJ) Video.js has a plugin to support DASH btw. [21:50:51] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Make metawiki the central OAuth wiki - https://phabricator.wikimedia.org/T59336#1918947 (10Tgr) You can see it in the config files (the patch is in T108648). Not sure about the other two; you can check whether the consumer management special pages work, but that... [21:51:31] (03PS3) 10Jforrester: Cleanup HTML output, simplify RL modules [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262736 (owner: 10Esanders) [21:53:33] (03PS2) 10MaxSem: Namespace this extension [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262741 (https://phabricator.wikimedia.org/T122339) [21:53:54] Anybody know where James_F is? [21:54:04] (03CR) 10Mr. Stradivarius: "So, should the goal here be to mirror wfCgiToArray precisely? I didn't do that this time because it would contradict with the existing doc" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/199911 (https://phabricator.wikimedia.org/T93059) (owner: 10Mr. Stradivarius) [21:54:08] hexmode: 3rd. [21:54:14] * hexmode msgs James_F [21:55:00] (03CR) 10Bartosz Dziewoński: [C: 032] "What's the worst that could happen?" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/262758 (https://phabricator.wikimedia.org/T33216) (owner: 10Legoktm) [21:56:01] 10MediaWiki-Debian, 10Continuous-Integration-Config: Set up CI auto-building for mediawiki/debian repository - https://phabricator.wikimedia.org/T122978#1918953 (10MoritzMuehlenhoff) The mediawiki/debian repo has it's file in the top level directory of the repo, while apparently debian-glue expects it in a deb... [21:56:04] 4(no projects): Test - https://phabricator.wikimedia.org/T122982#1918954 (10BGerstle-WMF) [21:58:05] (03CR) 10Legoktm: [C: 032] Option to associate a rev id to a RC log entry, allowing unpatrolled status [core] - 10https://gerrit.wikimedia.org/r/211656 (https://phabricator.wikimedia.org/T122089) (owner: 10Cenarium) [21:58:12] (03CR) 10Niedzielski: [C: 031] "@Mholloway, I don't think I follow. getBaseContentURI() is non-static and returns a Uri. I think the usages Dan changed require the column" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/261799 (owner: 10Deskana) [21:58:30] (03Merged) 10jenkins-bot: Display Cite errors in the user language [extensions/Cite] - 10https://gerrit.wikimedia.org/r/262758 (https://phabricator.wikimedia.org/T33216) (owner: 10Legoktm) [22:00:57] (03CR) 10Legoktm: Allow patrol of uploads (031 comment) [core] - 10https://gerrit.wikimedia.org/r/251795 (https://phabricator.wikimedia.org/T11501) (owner: 10Cenarium) [22:01:45] (03CR) 10Legoktm: [C: 032] LogEntry: Boring whitespace and comment changes, some documentation too [core] - 10https://gerrit.wikimedia.org/r/261313 (owner: 10Bartosz Dziewoński) [22:03:48] (03PS1) 10Paladox: Update some packages [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262821 [22:04:10] (03CR) 10John Vandenberg: Pass jshint and add it to 'npm test' command (031 comment) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/262710 (https://phabricator.wikimedia.org/T63620) (owner: 10Hashar) [22:04:13] (03Merged) 10jenkins-bot: Option to associate a rev id to a RC log entry, allowing unpatrolled status [core] - 10https://gerrit.wikimedia.org/r/211656 (https://phabricator.wikimedia.org/T122089) (owner: 10Cenarium) [22:06:35] (03PS2) 10Paladox: Update some packages [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262821 [22:09:01] (03CR) 10Legoktm: [C: 032] Update some packages [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/262821 (owner: 10Paladox) [22:09:34] (03CR) 10Paladox: "This needs to be +2ed again please." [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [22:09:56] (03PS5) 10Parent5446: Add user right for enabling two-factor auth [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/213768 (https://phabricator.wikimedia.org/T100376) [22:10:17] (03CR) 10Paladox: "recheck" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/226634 (owner: 10Paladox) [22:11:11] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1918981 (10Volker_E) @cscott Given the long history of html5shiv, it's widely tested, su... [22:12:55] (03CR) 10Yurik: [C: 031] Namespace this extension [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/262741 (https://phabricator.wikimedia.org/T122339) (owner: 10MaxSem) [22:13:02] (03CR) 10Legoktm: [C: 032] Update packages to do with karma [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [22:14:12] (03CR) 10Legoktm: [C: 032] mediawiki.Upload: Add #getApi method, use it instead of undocumented properties [core] - 10https://gerrit.wikimedia.org/r/257670 (owner: 10Bartosz Dziewoński) [22:14:41] (03PS1) 10Physikerwelt: Fix link to PNG fallback for IE 8 and older [extensions/Math] - 10https://gerrit.wikimedia.org/r/262822 [22:16:23] (03PS2) 10Physikerwelt: Fix link to PNG fallback for IE 8 and older [extensions/Math] - 10https://gerrit.wikimedia.org/r/262822 [22:17:06] Krinkle: Are we going ahead with https://gerrit.wikimedia.org/r/#/c/252383/ now? If so, I need to put it in Tech/News now. :-) [22:17:57] does anyone in the office right now have a Lenovo T550? :) [22:18:39] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1918986 (10Ejegg) 3NEW [22:18:45] (03CR) 10Legoktm: [C: 032] Setup.php: Ensure that defaults for 'rcdays' and 'watchlistdays' are not invalid [core] - 10https://gerrit.wikimedia.org/r/261357 (owner: 10Bartosz Dziewoński) [22:19:24] (03CR) 10Physikerwelt: "comments from daniel" [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [22:19:25] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (10Ejegg) 3NEW [22:19:29] (03Merged) 10jenkins-bot: Update packages to do with karma [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [22:19:42] 10WikiProject-X: Migrate from Tool Labs to dedicated Labs instance - https://phabricator.wikimedia.org/T123003#1919002 (10Harej) 3NEW a:3Harej [22:19:49] 10WikiProject-X: Migrate from Tool Labs to dedicated Labs instance - https://phabricator.wikimedia.org/T123003#1919010 (10Harej) [22:20:00] (03CR) 10Physikerwelt: "comments from daniel..." (035 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [22:20:25] 10MobileFrontend, 10Reading-Web: Empty sections are confusing - https://phabricator.wikimedia.org/T122997#1919013 (10jhobs) [22:20:57] 10MobileFrontend, 10Reading-Web: Empty sections are confusing on mobile - https://phabricator.wikimedia.org/T122997#1918919 (10jhobs) [22:21:43] (03Merged) 10jenkins-bot: mediawiki.Upload: Add #getApi method, use it instead of undocumented properties [core] - 10https://gerrit.wikimedia.org/r/257670 (owner: 10Bartosz Dziewoński) [22:24:23] (03Merged) 10jenkins-bot: Setup.php: Ensure that defaults for 'rcdays' and 'watchlistdays' are not invalid [core] - 10https://gerrit.wikimedia.org/r/261357 (owner: 10Bartosz Dziewoński) [22:24:46] (03PS1) 10Isarra: Add lang to the firstheading [skins/Example] - 10https://gerrit.wikimedia.org/r/262824 [22:26:41] (03CR) 10Legoktm: [C: 032] Add lang to the firstheading [skins/Example] - 10https://gerrit.wikimedia.org/r/262824 (owner: 10Isarra) [22:27:11] (03Merged) 10jenkins-bot: Add lang to the firstheading [skins/Example] - 10https://gerrit.wikimedia.org/r/262824 (owner: 10Isarra) [22:29:43] (03PS1) 10Chad: Don't call a hook parameter $wgTitle, it isn't [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/262825 [22:30:18] 5Patch-For-Review, 3Wikipedia-Android-App: App should not insert HTML tags into edit summaries - https://phabricator.wikimedia.org/T122714#1919021 (10Deskana) 5Open>3Resolved a:3Deskana Fixed now. Thanks all. :-) [22:30:23] 10MediaWiki-Vagrant, 7Easy, 7Puppet: MediaWiki-Vagrant guest OS clock gets out of sync - https://phabricator.wikimedia.org/T116507#1919024 (10Mattflaschen) [22:30:43] (03PS1) 10Chad: Remove unused $wgTitle global [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/262826 [22:31:30] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919027 (10Volker_E) [22:31:50] 10Wikimedia-Developer-Summit-2016: Unconf: brainstorm/feedback how should we move from beta to full-rollout - https://phabricator.wikimedia.org/T122859#1919030 (10JKatzWMF) Updating with Summarized etherpad content from: https://etherpad.wikimedia.org/p/beta_to_rollout Slides for Intro https://docs.google.com/p... [22:32:06] (03PS2) 10Legoktm: Add optional $name-summary message for Special:GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/252485 [22:32:25] 10WikiProject-X: Incorporate information from Wikidata into WikiProject Directory - https://phabricator.wikimedia.org/T122538#1919031 (10Harej) [22:32:40] (03PS1) 10Lokal Profil: Make compatible with Open badges specification v. 1.1 [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/262827 (https://phabricator.wikimedia.org/T122991) [22:35:01] (03PS1) 10Bearloga: Update forecast dashboard [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262829 [22:35:16] (03CR) 10Bearloga: [C: 032 V: 032] Update forecast dashboard [wikimedia/discovery/experimental] - 10https://gerrit.wikimedia.org/r/262829 (owner: 10Bearloga) [22:36:20] (03PS1) 10Chad: Stop using $wgTitle, no need to be the global [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/262830 [22:40:17] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1919041 (10Eileenmcnaughton) should this be linked to https://phabricator.wikimedia.org/T86248 (blocker to it?) [22:40:31] 10OpenBadges: Support non-local badge images - https://phabricator.wikimedia.org/T123004#1919042 (10Lokal_Profil) 3NEW [22:40:34] (03PS1) 10Chad: Stop using $wgTitle, we already have a $target title on hand [extensions/RPED] - 10https://gerrit.wikimedia.org/r/262831 [22:41:00] (03PS11) 10Victorbarbu: Provide short URL to file description page in imageinfo API [core] - 10https://gerrit.wikimedia.org/r/262415 (https://phabricator.wikimedia.org/T122439) [22:41:07] (03CR) 10jenkins-bot: [V: 04-1] Stop using $wgTitle, we already have a $target title on hand [extensions/RPED] - 10https://gerrit.wikimedia.org/r/262831 (owner: 10Chad) [22:41:36] 10MediaWiki-Vagrant: Spin custom MediaWiki-Vagrant box with base packages pre-installed - https://phabricator.wikimedia.org/T123005#1919049 (10Mattflaschen) 3NEW [22:41:42] (03PS2) 10Legoktm: GitInfo: Allow cache to be in the extension directory itself [core] - 10https://gerrit.wikimedia.org/r/262360 (https://phabricator.wikimedia.org/T122769) [22:41:43] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Do not directly access $_SESSION superglobal in DonationInterface - https://phabricator.wikimedia.org/T123006#1919056 (10cwdent) 3NEW [22:41:49] (03CR) 10Legoktm: GitInfo: Allow cache to be in the extension directory itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262360 (https://phabricator.wikimedia.org/T122769) (owner: 10Legoktm) [22:41:59] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1919063 (10awight) [22:42:22] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (10awight) [22:42:23] 10MediaWiki-extensions-DonationInterface, 10Fundraising Tech Backlog: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1919066 (10awight) [22:42:27] Who do I ask for permission to create a repo via Diffusion? [22:42:33] is that turned on yet? [22:42:39] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1919069 (10awight) [22:42:41] 10MediaWiki-extensions-DonationInterface, 10Fundraising Tech Backlog: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#964453 (10awight) [22:43:11] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (10awight) @eileenmcnaughton: Yes, thanks! [22:43:14] (03CR) 10Niedzielski: [C: 04-1] "Beta event logging doesn't seem to be operating quite right on the backend but I see this error:" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/260771 (https://phabricator.wikimedia.org/T121909) (owner: 10Mholloway) [22:43:29] * hexmode thinks -dev isn't the right placd [22:44:03] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919077 (10GWicke) [22:44:30] (03PS2) 10Lokal Profil: Make compatible with Open badges specification v. 1.1 [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/262827 (https://phabricator.wikimedia.org/T122991) [22:45:12] (03Abandoned) 10Parent5446: Fixed hook names and code style [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/135520 (owner: 10Parent5446) [22:45:46] (03PS1) 10Chad: Stop using $wgTitle, EditPage already provides one [extensions/MsCatSelect] - 10https://gerrit.wikimedia.org/r/262832 [22:47:02] gwicke: Following our conversation yesterday, I've added you to https://phabricator.wikimedia.org/T122965 as well [22:47:30] gwicke: Oh, already on it :) [22:48:07] Just installed MediaWiki's UniversalLanguageSelector. How please would I create an inter-lingual template between 2 languages based on this for example - http://worlduniversity.wikia.com/wiki/SUBJECT_TEMPLATE ? [22:48:21] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919080 (10Paladox) There is a patch in gerrit that is disabling ie8 for javasc... [22:49:07] ... and, for example, here - http://worlduniversityandschool.org/WUaS_Wiki/index.php?title=Languages ... [22:51:10] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919086 (10Volker_E) [22:51:12] 10MediaWiki-Parser, 7Tracking: HTML5 features (tracking) - https://phabricator.wikimedia.org/T21719#1919085 (10Volker_E) [22:51:38] (03PS30) 10Paladox: Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) [22:53:13] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) (owner: 10Paladox) [22:53:13] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919090 (10Volker_E) [22:53:15] 10MediaWiki-Interface, 7Tracking: Use semantic HTML (tracking) - https://phabricator.wikimedia.org/T12467#1919089 (10Volker_E) [22:54:14] (03PS31) 10Paladox: Add extension.json, empty PHP entry point [extensions/Flow] - 10https://gerrit.wikimedia.org/r/213837 (https://phabricator.wikimedia.org/T87916) [22:55:06] (03PS1) 10Cicalese: added Semantic MediaWiki role [vagrant] - 10https://gerrit.wikimedia.org/r/262833 (https://phabricator.wikimedia.org/T99858) [22:57:21] 10Annual-Report, 10Security-Reviews, 6Security-Team: security review 15.wikipedia/annual2015 code review - https://phabricator.wikimedia.org/T119478#1919097 (10csteipp) From https://gerrit.wikimedia.org/r/#/c/262679/, I think 1 thing is needed before it's deployed: * app.js still references both twitter and... [22:57:33] tgr|away, anything? [22:57:37] (03PS3) 10Bartosz Dziewoński: Allow patrol of uploads [core] - 10https://gerrit.wikimedia.org/r/251795 (https://phabricator.wikimedia.org/T11501) (owner: 10Cenarium) [22:58:20] (03CR) 10Parent5446: [C: 04-1] Issue badges through API and add e-mail requirments (033 comments) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/262754 (https://phabricator.wikimedia.org/T103845) (owner: 10Lokal Profil) [22:58:26] (03PS2) 10Aaron Schulz: Dependency inject TransactionProfiler into DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/262687 [22:58:56] (03CR) 10Bartosz Dziewoński: [C: 031] "I think this is fine now, but please check the caching logic in Article.php carefully before merging." [core] - 10https://gerrit.wikimedia.org/r/251795 (https://phabricator.wikimedia.org/T11501) (owner: 10Cenarium) [23:00:01] 10Annual-Report, 10Security-Reviews, 6Security-Team: security review 15.wikipedia/annual2015 code review - https://phabricator.wikimedia.org/T119478#1919099 (10csteipp) > And not security, but masonry.js, chart.js, and bodymovin.js all look like MIT licensed libraries, but their license comments are missing.... [23:00:18] (03CR) 10Parent5446: [C: 04-1] Make compatible with Open badges specification v. 1.1 (031 comment) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/262827 (https://phabricator.wikimedia.org/T122991) (owner: 10Lokal Profil) [23:01:08] 10Annual-Report, 10Security-Reviews, 6Security-Team: security review 15.wikipedia/annual2015 code review - https://phabricator.wikimedia.org/T119478#1919102 (10Slaporte) I'll take a look. [23:02:02] (03CR) 10Paladox: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [23:02:50] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259284 (owner: 10Esanders) [23:04:42] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919103 (10TheDJ) @paladox we are aware, but that means disabling support for a... [23:06:03] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Make metawiki the central OAuth wiki - https://phabricator.wikimedia.org/T59336#1919105 (10csteipp) >>! In T59336#1918812, @He7d3r wrote: > @Tgr: Just for curiosity: can I check that by going to some Special page, or making some api call, or only looking at some... [23:06:28] (03PS1) 10Chad: Remove WebRequest::appendQuery() [core] - 10https://gerrit.wikimedia.org/r/262834 [23:06:31] (03Merged) 10jenkins-bot: Use ve.ui.Surface#setDisabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259284 (owner: 10Esanders) [23:06:48] 10Wikimedia-General-or-Unknown: Close #mediawiki-dev and redirect it to #wikimedia-dev - https://phabricator.wikimedia.org/T121687#1919106 (10Legoktm) 5Open>3Resolved a:3tstarling [23:06:57] 10Wikimedia-General-or-Unknown: Close #mediawiki-dev and redirect it to #wikimedia-dev - https://phabricator.wikimedia.org/T121687#1885426 (10Legoktm) Thank you Tim! [23:06:58] 10MediaWiki-Export-or-Import: Notice during xml file import with Special:Import: LoadBalancer::commitMasterChanges: Flushing an explicit transaction, getting out of sync! - https://phabricator.wikimedia.org/T53105#1919110 (10aaron) This could have been the result of some Lua exception or something? Does this sti... [23:06:59] (03PS1) 10Deskana: Clean up AudioUrlSpan class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262835 [23:07:16] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer: Provide a way to support HTML5 elements in browsers that don't support it and don't have JS shipped, like IE8 and below - https://phabricator.wikimedia.org/T122965#1919112 (10Paladox) >>! In T122965#1919103, @TheDJ wrote: > @paladox we are awa... [23:09:30] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer, 7JavaScript, 5Patch-For-Review, and 2 others: Drop JavaScript support for IE8 (remove from "Grade A") - https://phabricator.wikimedia.org/T118303#1919114 (10Jdforrester-WMF) [23:12:41] 10MediaWiki-Parser, 7Accessibility: Enable, whitelist, and incorporate semantic HTML5 elements: article, aside, figcaption, figure, footer, header, hgroup, main, mark, nav, picture, progress, section, time - https://phabricator.wikimedia.org/T25932#1919123 (10Volker_E) @Rezonansowy You're right as there is no... [23:13:33] (03CR) 10Jdlrobson: Modern module loading (035 comments) [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [23:13:54] (03PS22) 10Jdlrobson: Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [23:14:35] ^ Krinkle [23:14:50] lemme know if you want to talk over it while we can be in person :) [23:15:08] 10MediaWiki-Parser, 7Accessibility: Enable, whitelist, and incorporate semantic HTML5 elements: article, aside, figcaption, figure, footer, header, hgroup, main, mark, nav, picture, progress, section, time - https://phabricator.wikimedia.org/T25932#1919126 (10Volker_E) [23:15:20] (03PS1) 10Chad: WebRequest::appendQuery*() functions no longer take $onlyquery [core] - 10https://gerrit.wikimedia.org/r/262837 [23:16:02] (03CR) 10Yaron Koren: [C: 032 V: 031] "Thanks a lot - this is great!" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [23:17:01] (03CR) 10TheDJ: "so who will merge this ? :)" [core] - 10https://gerrit.wikimedia.org/r/254039 (owner: 10TheDJ) [23:17:24] 10MediaWiki-Categories, 6Community-Tech, 7Community-Wishlist-Survey, 7Milestone: Natural number sorting in category listings - https://phabricator.wikimedia.org/T8948#1919130 (10Bawolff) So we need to set ->setAttribute( Collator::NUMERIC_COLLATION, Collator::ON ); on the Collator object to do this. Proba... [23:18:04] (03CR) 10TheDJ: [C: 032] jquery.accessKeyLabel: make modifier info public [core] - 10https://gerrit.wikimedia.org/r/254039 (owner: 10TheDJ) [23:19:00] (03Draft2) 10Aude: Add links and examples for api modules [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/262732 [23:19:23] (03CR) 10Krinkle: [C: 04-1] Preferences: Use cookie instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [23:20:06] 10MediaWiki-Categories, 6Community-Tech, 7Community-Wishlist-Survey, 7Milestone: Natural number sorting in category listings - https://phabricator.wikimedia.org/T8948#1919137 (10Bawolff) For reference ``` diff --git a/includes/Collation.php b/includes/Collation.php index 7fa5c6e..04fc682 100644 --- a/inclu... [23:20:12] (03CR) 10Legoktm: [C: 032] Remove WebRequest::appendQuery() [core] - 10https://gerrit.wikimedia.org/r/262834 (owner: 10Chad) [23:20:47] 4(no projects): Requests to beta cluster with "X-Wikimedia-Security-Audit: 1" header are hanging - https://phabricator.wikimedia.org/T123007#1919139 (10dpatrick) 3NEW a:3thcipriani [23:21:05] (03CR) 10Legoktm: [C: 032] WebRequest::appendQuery*() functions no longer take $onlyquery [core] - 10https://gerrit.wikimedia.org/r/262837 (owner: 10Chad) [23:21:36] (03CR) 10CSteipp: [C: 031] Update for SessionManager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 (owner: 10Anomie) [23:21:41] (03CR) 10Paladox: "Thanks." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/259291 (owner: 10Paladox) [23:22:24] 10MediaWiki-Export-or-Import: Notice during xml file import with Special:Import: LoadBalancer::commitMasterChanges: Flushing an explicit transaction, getting out of sync! - https://phabricator.wikimedia.org/T53105#1919146 (10aaron) >>! In T53105#1919110, @aaron wrote: > This could have been the result of some Lu... [23:22:47] 10MediaWiki-Database: LoadBalancer::commitMasterChanges: Flushing an explicit transaction, getting out of sync! - https://phabricator.wikimedia.org/T45576#1919148 (10aaron) Does this still occur (given https://gerrit.wikimedia.org/r/#/c/121402/ and many other changes since then) [23:23:03] (03CR) 10Niedzielski: [C: 031] "It looks like the dependencies are all merged up but this patch doesn't seem to work for me on prod or development master at the moment. I" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/257695 (https://phabricator.wikimedia.org/T118737) (owner: 10Mholloway) [23:24:36] (03Merged) 10jenkins-bot: jquery.accessKeyLabel: make modifier info public [core] - 10https://gerrit.wikimedia.org/r/254039 (owner: 10TheDJ) [23:27:27] (03CR) 10Mholloway: "Hmm, thanks for the heads-up, I'll take a look later but we probably don't want to merge in any case until the endpoint is deployed (next " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/257695 (https://phabricator.wikimedia.org/T118737) (owner: 10Mholloway) [23:28:08] (03CR) 10Niedzielski: [C: 04-1] Clean up AudioUrlSpan class (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262835 (owner: 10Deskana) [23:30:39] (03CR) 10Deskana: "Replies." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262835 (owner: 10Deskana) [23:32:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: parser function to access number of links in an item - https://phabricator.wikimedia.org/T47659#1919163 (10hoo) 5Open>3declined a:3hoo Indeed, this is to specific for a parser function, the Lua APIs should be used. [23:32:58] (03Merged) 10jenkins-bot: Remove WebRequest::appendQuery() [core] - 10https://gerrit.wikimedia.org/r/262834 (owner: 10Chad) [23:33:02] (03Merged) 10jenkins-bot: WebRequest::appendQuery*() functions no longer take $onlyquery [core] - 10https://gerrit.wikimedia.org/r/262837 (owner: 10Chad) [23:33:18] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Reduce memory footprint of Change objects by zipping diffs - https://phabricator.wikimedia.org/T49283#1919169 (10hoo) 5Open>3Invalid a:3hoo No longer relevant, change handling significantly changed. See also T107722. [23:35:03] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: [Task] Split wikibase.git - https://phabricator.wikimedia.org/T75863#1919174 (10JanZerebecki) [23:35:16] 10MediaWiki-User-login-and-signup, 5Patch-For-Review: Passwords should be checked for strength before being set - https://phabricator.wikimedia.org/T5348#1919177 (10csteipp) Password policies have been implemented since https://gerrit.wikimedia.org/r/#/c/206156/, and can vary by group. The User object is passe... [23:35:42] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/262732 (owner: 10Aude) [23:37:53] 6Discovery, 7Epic: EPIC: Improve Language Identification for use in Cirrus Search - https://phabricator.wikimedia.org/T118278#1919183 (10TJones) **TextCat and Language Detection** Back before the holidays (12/23/2015), Stas and Trey had a conversation on IRC about TextCat and Lang ID. There was lots of good s... [23:38:10] 10MediaWiki-extensions-WikibaseRepository, 10MediaWiki-extensions-WikibaseView, 10Wikidata, 7Tracking: [Task] Move JS and PHP view code to separate repo - https://phabricator.wikimedia.org/T75020#1919190 (10JanZerebecki) [23:38:13] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: [Task] Split wikibase.git - https://phabricator.wikimedia.org/T75863#1919189 (10JanZerebecki) [23:38:42] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: Convert TextCat to PHP Library for Language Identification in Cirrus Search - https://phabricator.wikimedia.org/T121538#1881188 (10TJones) Notes on a detailed discussion on IRC about TextCat and Lang ID here: https://phabricator.wikimedia.org/T118278#1919183 [23:40:03] 10MediaWiki-RfCs, 10Wikidata, 10Wikimedia-Developer-Summit-2016: RFC: Streamlining Composer usage - https://phabricator.wikimedia.org/T105638#1919192 (10JanZerebecki) Copy of the etherpad: ``` (missing start of talk, a minute or so) Step 4: CI job that automatically triggers after changes to core or ext * r... [23:41:22] 10MediaWiki-RfCs, 10Wikidata, 10Wikimedia-Developer-Summit-2016: RFC: Streamlining Composer usage - https://phabricator.wikimedia.org/T105638#1919193 (10JanZerebecki) Steps mentioned at the beginning of the session are https://www.mediawiki.org/wiki/Requests_for_comment/Streamlining_Composer_usage#Workflow_e... [23:45:04] Hi! I need some help with metadata messages. [23:45:39] Specifically, passing parameters to them [23:46:11] 10MediaWiki-Parser, 7Accessibility: Enable, whitelist, and incorporate semantic HTML5 elements: article, aside, figcaption, figure, footer, header, hgroup, main, mark, nav, picture, progress, section, time - https://phabricator.wikimedia.org/T25932#1919198 (10Volker_E) For completing the discussion, regarding... [23:46:52] (03CR) 10Divec: [C: 032] startup.js: Move IE8 down from Grade A to Grade C [core] - 10https://gerrit.wikimedia.org/r/252383 (https://phabricator.wikimedia.org/T118303) (owner: 10Jforrester) [23:47:45] (03CR) 10Niedzielski: Clean up AudioUrlSpan class (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/262835 (owner: 10Deskana) [23:53:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: clean up PHP namespaces - https://phabricator.wikimedia.org/T64523#1919207 (10hoo) 5Open>3Invalid a:3hoo Way to broad, not actionable at all. [23:53:51] (03Merged) 10jenkins-bot: startup.js: Move IE8 down from Grade A to Grade C [core] - 10https://gerrit.wikimedia.org/r/252383 (https://phabricator.wikimedia.org/T118303) (owner: 10Jforrester) [23:54:36] 10MediaWiki-Interface, 7Browser-Support-Internet-Explorer, 7JavaScript: New jquery.placeholder.js is slow/placeholder text does not disappear in IE8 - https://phabricator.wikimedia.org/T60536#1919214 (10Jdforrester-WMF) [23:54:38] 10MediaWiki-General-or-Unknown, 7Browser-Support-Internet-Explorer, 7JavaScript, 5Patch-For-Review, and 2 others: Drop JavaScript support for IE8 (remove from "Grade A") - https://phabricator.wikimedia.org/T118303#1919211 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [23:54:50] (03CR) 10Bartosz Dziewoński: "It is abstracted there. But it's copied here because this code is terrible. ManualLogEntry doesn't have support for updating an existing l" [core] - 10https://gerrit.wikimedia.org/r/261314 (https://phabricator.wikimedia.org/T122089) (owner: 10Bartosz Dziewoński) [23:58:09] kevinator hey kevin, all of a sudden the "sum" function on the log table doesn't seem to be working...any idea why? [23:58:23] kevinator on stat 1003