[00:00:03] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace makeKnownLinkObj function calls with Linker::link [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262042 (owner: 10Florianschmidtwelzow)
[00:00:18] <Reedy>	 FlorianSW: I already did it
[00:00:19] <FlorianSW>	 oops, no not news
[00:00:23] <FlorianSW>	 :P
[00:00:30] <Reedy>	 I've 5 commits outstanding ;)
[00:00:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace makeKnownLinkObj function calls with Linker::link [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262042 (owner: 10Florianschmidtwelzow)
[00:00:45] <FlorianSW>	 Wait, I was sooo slow? :D
[00:01:03] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Remove makeKnownLinkObj() commented out [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/262041 (owner: 10Reedy)
[00:01:18] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Remove makeKnownLinkObj() commented out [extensions/News] - 10https://gerrit.wikimedia.org/r/262040 (owner: 10Reedy)
[00:01:22] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace makeKnownLinkObj calls with Linker::link [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/262045 (owner: 10Florianschmidtwelzow)
[00:01:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove makeKnownLinkObj() commented out [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/262041 (owner: 10Reedy)
[00:01:38] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeKnownLinkObj() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262043 (owner: 10Reedy)
[00:01:52] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeKnownLinkObj() [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/262044 (owner: 10Reedy)
[00:01:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove makeKnownLinkObj() commented out [extensions/News] - 10https://gerrit.wikimedia.org/r/262040 (owner: 10Reedy)
[00:01:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace makeKnownLinkObj calls with Linker::link [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/262045 (owner: 10Florianschmidtwelzow)
[00:02:11] <Reedy>	 Gotta wait for gerrit to reindex now :P
[00:02:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace makeKnownLinkObj() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262043 (owner: 10Reedy)
[00:02:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace makeKnownLinkObj() [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/262044 (owner: 10Reedy)
[00:04:27] <FlorianSW>	 But it looks good (I used github and opened the master branch file for every one found) :)
[00:04:44] <Reedy>	 Did we do WYSIWYG?
[00:05:04] <FlorianSW>	 yep
[00:05:04] <FlorianSW>	 https://github.com/wikimedia/mediawiki-extensions-WYSIWYG/commit/b3e81952dc7e03cd59f35eebabaa1cd601609b70
[00:05:20] <Reedy>	 Wheee
[00:05:41] <FlorianSW>	 I think, this is good to go :)
[00:05:51] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] "*yay*" [core] - 10https://gerrit.wikimedia.org/r/262019 (owner: 10Reedy)
[00:06:03] <Reedy>	 Yeah, we've certainly done best efforts to clean up the remaining
[00:06:20] <wikibugs>	 10MediaWiki-Categories, 5Patch-For-Review: Category pages causes articles to list in one row and the "letter" in another - https://phabricator.wikimedia.org/T104541#1912987 (10matmarex) >>! In T104541#1912889, @Nnemo wrote: > Maybe putting the "h2" inside the "ul"? Is that allowed?  It's probably not, but it w...
[00:07:18] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Linker::makeLinkObj() was removed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy)
[00:07:20] <FlorianSW>	 Reedy: ^
[00:07:26] <FlorianSW>	 this should be Linker::link, right?
[00:07:39] <Reedy>	 lolol
[00:07:40] <Reedy>	 Yup
[00:07:50] <Reedy>	 let me fix
[00:09:14] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "We should never include prefixed properties without testing them in the particular browser they're aimed at. That's the whole point of pre" [core] - 10https://gerrit.wikimedia.org/r/261723 (https://phabricator.wikimedia.org/T104541) (owner: 10Bartosz Dziewoński)
[00:09:24] <Reedy>	 Sweet
[00:09:27] <Reedy>	 So 13 in includes
[00:09:34] <Reedy>	 I've got 2 to be merged
[00:09:38] <Reedy>	 You've got one when we've done the WMF config
[00:09:41] <Reedy>	 So that's 10
[00:09:52] <Reedy>	 class FSRepo extends FileRepo {
[00:09:58] <Reedy>	 Have to ask AaronSchulz what to do about that one...
[00:10:23] <Reedy>	 FlorianSW: So we've just wfMsg*() in GlobalFunctions to deal with now :)
[00:10:53] <Reedy>	 60 usages of wfMsgHtml :(
[00:11:03] <FlorianSW>	 That sounds very productive :P We could use: https://phabricator.wikimedia.org/T70750 which I've updated just some time ago :)
[00:11:04] <Reedy>	 126 of wfMsgExt
[00:11:33] <Reedy>	 wfMsgGetKey is just used internally (yay)
[00:12:03] <Reedy>	 I don't quite know about fixing these up
[00:12:05] <FlorianSW>	 I would say: Just do it :) I'll take MassEditRegex as my first candidate :)
[00:12:28] <FlorianSW>	 or would you do it the other way around to go function based, not extension.based?
[00:12:34] <Reedy>	 Doesn't really matter
[00:12:40] <Reedy>	 Either works towards the goal :)
[00:12:47] <FlorianSW>	 that's right :P
[00:13:02] <FlorianSW>	 I would do it extension-based, if I already checked it out and working on it :)
[00:13:02] <Reedy>	 I don't know how to fix these up
[00:13:31] <Reedy>	 Aha, wfMsgForContentNoTrans only has one extension usage
[00:13:43] <FlorianSW>	 Mostly this helps: https://www.mediawiki.org/wiki/Manual:Messages_API#Help_with_replacing_deprecated_wfMsg.2A_functions
[00:14:07] <Reedy>	 Aha, nice
[00:14:09] <Reedy>	 ty
[00:14:16] <grrrit-wm>	 (03PS4) 10Reedy: Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 
[00:14:18] <FlorianSW>	 but that could be a bit trickier, because mostly, the output method doesn't fit, which means, that you need to look, if you use text() or escaped() (mostly these both)
[00:14:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Linker::makeKnownLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262019 (owner: 10Reedy)
[00:16:30] <grrrit-wm>	 (03PS1) 10Reedy: Replace wfMsgForContentNoTrans() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262046 
[00:16:39] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262047 (https://phabricator.wikimedia.org/T70750) 
[00:16:41] <FlorianSW>	 InterwikiIntegration
[00:21:53] <grrrit-wm>	 (03PS1) 10Reedy: wfMsgForContentNoTrans() was removed [core] - 10https://gerrit.wikimedia.org/r/262048 
[00:22:06] <grrrit-wm>	 (03CR) 10Ricordisamoa: "What about future and third-party MessagePosters which may support HTML only? "The markup supported is implementation-specific"" [core] - 10https://gerrit.wikimedia.org/r/261794 (owner: 10Mattflaschen)
[00:22:38] <grrrit-wm>	 (03PS2) 10Reedy: wfMsgForContentNoTrans() was removed [core] - 10https://gerrit.wikimedia.org/r/262048 (https://phabricator.wikimedia.org/T70750) 
[00:24:02] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262047 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:24:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262047 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:24:47] <Reedy>	 FlorianSW: https://gerrit.wikimedia.org/r/262021 can go from core now :D
[00:25:43] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy)
[00:25:46] <FlorianSW>	 blub :D
[00:27:38] <neeraj>	 can someone give me the url for downloading the source code for mediawiki
[00:28:23] <d3r1ck>	 neeraj: There are many ways you can do that. But Let me look for a tutorial and give you a link
[00:28:42] <Reedy>	 FlorianSW: How up to date is your grepping?
[00:29:21] <d3r1ck>	 neeraj: https://www.mediawiki.org/wiki/Gerrit/Tutorial
[00:29:38] <FlorianSW>	 Reedy: from Dec 29 :/
[00:29:38] <d3r1ck>	 neeraj: follow that tutorials well and you will find the answer to your question
[00:29:45] <unicornisaurous>	 neeraj: If you login to gerrit, you can find the mediawiki/core repo, and it will generate a git clone command for you to use.
[00:29:51] <neeraj>	 thank you derik.
[00:30:00] <Reedy>	 Some fixed then... Not most
[00:30:40] <neeraj>	 thank you unicornisaurous.
[00:31:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy)
[00:32:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Third-party MessagePosters should better conform to the documented contract ;)" [core] - 10https://gerrit.wikimedia.org/r/261794 (owner: 10Mattflaschen)
[00:33:07] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* and friends [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262049 (https://phabricator.wikimedia.org/T70750) 
[00:33:36] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace wfMsgForContentNoTrans() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262046 (owner: 10Reedy)
[00:33:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* and friends [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262049 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:34:10] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "rebase needed :P" [core] - 10https://gerrit.wikimedia.org/r/262048 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy)
[00:34:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsgForContentNoTrans() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262046 (owner: 10Reedy)
[00:34:46] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Replace wfMsg* and friends [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262049 (https://phabricator.wikimedia.org/T70750) 
[00:34:59] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] wfMsgForContentNoTrans() was removed [core] - 10https://gerrit.wikimedia.org/r/262048 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy)
[00:36:01] <d3r1ck>	 neeraj: what does that word mean?
[00:37:07] <d3r1ck>	 neeraj: sorry not you
[00:39:22] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/262050 (https://phabricator.wikimedia.org/T70750) 
[00:41:43] <grrrit-wm>	 (03PS3) 10Reedy: wfMsgForContentNoTrans() was removed [core] - 10https://gerrit.wikimedia.org/r/262048 (https://phabricator.wikimedia.org/T70750) 
[00:42:21] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/262051 (https://phabricator.wikimedia.org/T70750) 
[00:42:24] <Reedy>	 FlorianSW: You're fixing commented out code now? :P
[00:42:59] <FlorianSW>	 I thought about removing it, but there was so many commented out code, so I did this one :D
[00:43:07] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/262050 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:43:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/262050 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:43:55] <grrrit-wm>	 (03CR) 10Reedy: [C: 031] Remove Language::armourMath() and friends [core] - 10https://gerrit.wikimedia.org/r/262004 (owner: 10Florianschmidtwelzow)
[00:45:09] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/262051 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:45:43] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* and friends [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262052 (https://phabricator.wikimedia.org/T70750) 
[00:47:35] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* and friends [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262052 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:48:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/262051 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:48:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* and friends [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262052 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:48:15] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/262053 (https://phabricator.wikimedia.org/T70750) 
[00:49:38] <grrrit-wm>	 (03PS1) 10Reedy: Fixup authors. Remove email from wgExtensionCredits [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262054 
[00:50:30] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/262053 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:50:44] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/262055 (https://phabricator.wikimedia.org/T70750) 
[00:50:46] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* and friends [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262049 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:50:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/262053 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:51:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* and friends [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262049 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:51:40] <OH->	 Is the messageMap in ApiBase still used? If I am adding an API error message, should I use the i18n system or should I add to the messagemap?
[00:51:51] <OH->	 *still used as in used in new things
[00:52:04] <grrrit-wm>	 (03CR) 10VolkerE: Implement skip-to links and importing mediawiki.stateful-classes.less (032 comments) [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/237870 (https://phabricator.wikimedia.org/T112308) (owner: 10VolkerE)
[00:54:00] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/262055 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:54:12] <FlorianSW>	 Reedy: can you take a look at: https://github.com/wikimedia/mediawiki/blob/6b1642ca6b6ddb73ffbdc962aeb9e26c47569fd0/includes/OutputPage.php#L1776 this private member seems to be unused, right?
[00:54:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/262055 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[00:54:43] <Reedy>	 OH-: I'd suggest asking anomie
[00:55:25] <Reedy>	 FlorianSW: Looks to be, yup
[00:58:20] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove not used private member variable mParserWarnings from OutputPage [core] - 10https://gerrit.wikimedia.org/r/262056 
[00:59:34] <MatmaRex>	 OH-: i think it is, sadly
[01:00:22] <MatmaRex>	 OH-: i think you can write your code not to rely on it, by using ApiMessage rather than regular Message. i did something with this in TitleBlacklist once
[01:04:12] <wikibugs>	 10UI-Standardization, 7Accessibility: Improve color palette to comply with WCAG 2.0 min level AA and color-deficiency-friendly. - https://phabricator.wikimedia.org/T109915#1913004 (10Volker_E) @violetto I want to add one little thing here, I'd rather prefer a clearly stated (hex) color code, implementable in p...
[01:06:57] <grrrit-wm>	 (03CR) 10Paladox: "But there were feature backports in the mw 1.25 release." [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/261597 (https://phabricator.wikimedia.org/T119766) (owner: 10Paladox)
[01:08:32] <wikibugs>	 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure, 5Patch-For-Review: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1913009 (10yuvipanda) I've manually removed this class from LDAP to unblock Luke.
[01:10:07] <OH->	 Interesting, I'll take a look. Thanks
[01:15:41] <wikibugs>	 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 20 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1913018 (10Reedy)
[01:15:44] <wikibugs>	 10MediaWiki-General-or-Unknown, 7Tracking: Pre MW 1.20 deprecation cleanup - https://phabricator.wikimedia.org/T122754#1913020 (10Reedy)
[01:15:48] <wikibugs>	 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 20 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1191016 (10Reedy)
[01:16:04] <wikibugs>	 10MediaWiki-General-or-Unknown, 7Tracking, 7WorkType-Maintenance: Pre MW 1.20 deprecation cleanup - https://phabricator.wikimedia.org/T122754#1913011 (10Reedy)
[01:16:50] <MtDu>	 FlorianSW: I see you and Reedy are busy removing the use of the wfmsg stuff. 
[01:17:16] <wikibugs>	 10MediaWiki-General-or-Unknown, 7WorkType-Maintenance: Cleanup pre MW 1.20 deprecations in Wikibits.js - https://phabricator.wikimedia.org/T122755#1913024 (10Reedy) 3NEW
[01:17:21] <MtDu>	 FlorianSW: Is it ok if I work on removing it in another extension? I'm waiting on Nemo to approve something, so I'm kinda bored. :)
[01:17:31] <Reedy>	 MtDu: Yes please, feel free! :D
[01:17:47] <Reedy>	 MtDu: We've moved onto that as we'd done pretty much the rest of the PHP pre 1.20 cleanup
[01:17:58] <Reedy>	 That's (and wikibits) are the biggest issues now
[01:18:01] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* and friends [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262057 (https://phabricator.wikimedia.org/T70750) 
[01:18:22] <FlorianSW>	 Reedy: this one was hard :P ^
[01:18:29] <grrrit-wm>	 (03PS4) 10Reedy: Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[01:18:51] <grrrit-wm>	 (03PS2) 10Reedy: Remove $wgCopyrightIcon [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262000 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[01:19:02] <FlorianSW>	 MtDu: yes, yes, yes! It would be nice, if you post the name of the extension you're currently working on here in irc, so we don't end up doing it twice :P
[01:19:03] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove $wgCopyrightIcon [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262000 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[01:19:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[01:19:20] <MtDu>	 FlorianSW: Currently working on IndexFunction
[01:19:29] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] "<3" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/261906 (https://phabricator.wikimedia.org/T122733) (owner: 10Alex Monk)
[01:19:31] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Fixup authors. Remove email from wgExtensionCredits [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262054 (owner: 10Reedy)
[01:19:35] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Fixup authors. Remove email from wgExtensionCredits [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262054 (owner: 10Reedy)
[01:19:58] <FlorianSW>	 ImageLink is the next one
[01:20:01] <MtDu>	 FlorianSW: Quick question. Why didn't you ->text() on line 15? https://gerrit.wikimedia.org/r/#/c/262052/1/WhoIsWatching_body.php Could you explain when not to ->text()?
[01:20:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove $wgCopyrightIcon [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262000 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[01:20:38] <FlorianSW>	 MtDu: setPageTitle() takes the whole Message object :) It's documented, wait...
[01:20:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: NovaPrivateHost: Ensure puppetclass/puppetvar LDAP attributes get modified [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/261906 (https://phabricator.wikimedia.org/T122733) (owner: 10Alex Monk)
[01:20:49] <FlorianSW>	 https://doc.wikimedia.org/mediawiki-core/master/php/classOutputPage.html#a62445ed80350b6e3432d92d3986ddaf9
[01:21:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixup authors. Remove email from wgExtensionCredits [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/262054 (owner: 10Reedy)
[01:21:18] <FlorianSW>	 it takes a string or a message object, so I simply pass the Message object and let OutputPage decide, what output method to use :)
[01:21:20] <FlorianSW>	 MtDu: ^
[01:21:38] <MtDu>	 FlorianSW: Ok. 
[01:21:41] <wikibugs>	 10MediaWiki-General-or-Unknown, 7JavaScript, 7WorkType-Maintenance: Cleanup pre MW 1.20 deprecations in Wikibits.js - https://phabricator.wikimedia.org/T122755#1913041 (10Reedy)
[01:22:54] <MtDu>	 FlorianSW: Is it ok if I just use wfmessage, or would it be better to use $this->msg where applicable? 
[01:23:34] <Reedy>	 The latter is better still
[01:23:47] <Reedy>	 If it's in a special page, you should
[01:24:27] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace some wfMsg* calls [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/262058 (https://phabricator.wikimedia.org/T70750) 
[01:24:40] <MtDu>	 Reedy: Gotcha. Will do. 
[01:24:54] <MtDu>	 Reedy: Also, do you want me to replace wgout and others? 
[01:25:04] <Reedy>	 You don't have to :)
[01:25:16] <Reedy>	 It's extra work that is nice, but unnecessary
[01:25:31] <Reedy>	 We're mostly focusing on stuff so we can remove it from MW core
[01:25:40] <FlorianSW>	 Reedy: Like Reedy said. the advantage of $this->msg is, that you get a localized message object (with the user language), not in the content language. But when I see such old extensions, I only use $this->msg() is it's obvious :P
[01:25:47] <MtDu>	 Reedy: Gotcha. 
[01:25:51] <MtDu>	 FlorianSW: Ok.
[01:26:11] <Reedy>	 MatmaRex: Any idea bout cleaning up the shit in wikibits? :P
[01:26:15] <MtDu>	 FlorianSW: Will do that. I'm trying to spam some msges so I can read your whole message. This stupid windows notification is stuck there. 
[01:26:47] <FlorianSW>	 Doing SemanticMediaWiki now
[01:27:00] <MatmaRex>	 Reedy: ori and Krinkle have some on-wiki usage logs of it somewhere
[01:27:12] <MatmaRex>	 as in, on-wiki usage.
[01:27:13] <Reedy>	 Is that most of the issues? Onwiki usages?
[01:27:15] <MatmaRex>	 not on-wiki logs.
[01:27:24] <MtDu>	 FlorianSW: I'm using wfmessage where it's static and an object isn't passed in. 
[01:27:30] <MatmaRex>	 Reedy: i think so. never really cared to check. :P
[01:27:56] <Reedy>	 MatmaRex: ugh, fucking seriously
[01:27:59] <Reedy>	 52 usages of is_gecko onwiki
[01:28:23] <MatmaRex>	 i know, right?
[01:28:38] <wikibugs>	 10MediaWiki-General-or-Unknown, 7JavaScript, 7WorkType-Maintenance: Cleanup pre MW 1.20 deprecations in Wikibits.js - https://phabricator.wikimedia.org/T122755#1913045 (10Reedy)
[01:28:45] <Reedy>	 BREAK IT ALL
[01:28:56] <FlorianSW>	 MtDu: correctly (but you can use msg() only, where it is defined :))
[01:29:10] <MatmaRex>	 Reedy: try the latter ones. importScriptURI surely has thousands
[01:29:27] <FlorianSW>	 Doing CongressLookup now
[01:29:34] <MatmaRex>	 and importScript has so many, we undeprecated it :P
[01:29:35] <Reedy>	 We should be able to fix a lot of these using a bot type of thing
[01:29:55] <Reedy>	 532 of importScriptURI
[01:30:04] <Reedy>	 1387 importScript
[01:30:04] <MatmaRex>	 true. want to write one? :D
[01:30:16] <Reedy>	 I'd just use AWB :P
[01:30:30] <Reedy>	 Except, it doesn't do crosswiki so well
[01:30:35] <MatmaRex>	 Reedy: AWB is a pain when you need to edit 800 different wikis
[01:30:37] <MatmaRex>	 yeah, exactly
[01:30:53] <Reedy>	 Well, scripting something to use AWB wouldn't be too bad
[01:30:56] <Reedy>	 Doing it programatically
[01:31:06] <MatmaRex>	 heh
[01:31:07] <Reedy>	 Reuse it's ApiEdit stuff
[01:31:27] <Reedy>	 And/or, searching for all of the stuff via mwgrep
[01:31:33] <Reedy>	 Making a unique list of pages per wiki
[01:31:40] <Reedy>	 And edit them using a set of defined replacements/regexs
[01:31:52] <MatmaRex>	 AWB should follow interwiki prefixes in pages added to the list. gogogo do it
[01:32:12] <Reedy>	 heh
[01:32:14] <MatmaRex>	 great weekend project for before the dev summit
[01:32:26] <Reedy>	 I'm not going to the dev summit :(
[01:32:33] <MatmaRex>	 no? :(
[01:33:48] <MtDu>	 FlorianSW: I use wfMessage in those lines right? https://dpaste.de/Eb7F#L26,39 or can I do $parser->msg? 
[01:33:49] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/262060 (https://phabricator.wikimedia.org/T70750) 
[01:34:25] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/262060 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[01:34:27] <FlorianSW>	 MtDu: does Parser implement a msg() method?
[01:34:59] <FlorianSW>	 doing Push now
[01:35:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/262060 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[01:35:07] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] Replace some wfMsg* calls (031 comment) [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/262058 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[01:35:32] <MtDu>	 FlorianSW: Nope. 
[01:35:46] <MtDu>	 FlorianSW: This is helpful. :)
[01:35:49] <FlorianSW>	 MtDu: then wfMessage is fine :P
[01:35:50] <MtDu>	 FlorianSW: https://doc.wikimedia.org/mediawiki-core/master/php/classParser.html
[01:36:00] <MtDu>	 FlorianSW: Bookmarked. :)
[01:36:18] <FlorianSW>	 MtDu: the whole doc.wikimedia.org is your friend :P
[01:36:34] <unicornisaurous>	 Since y’all sound like you’re having so much fun fixing deprecated i18n functions, I think I’ll have to join in.
[01:38:37] <unicornisaurous>	 What extensions are left?
[01:39:48] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/262061 (https://phabricator.wikimedia.org/T70750) 
[01:41:12] <MtDu>	 FlorianSW: ^ Please take a look. :)
[01:41:18] <MtDu>	 Reedy:^
[01:41:33] <Reedy>	 unicornisaurous: There's a loooooad of them :D
[01:41:49] <Reedy>	 https://phabricator.wikimedia.org/T70750
[01:42:01] <unicornisaurous>	 Gerrit is really slow so I’m having trouble seeing which are already done
[01:42:04] <Reedy>	 Look in the summary
[01:42:14] <Reedy>	 I suspect we should update the greps
[01:43:31] <unicornisaurous>	 I’m going to do SemanticComments extension since it doesn’t appear to be done
[01:43:34] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/262061 (https://phabricator.wikimedia.org/T70750) 
[01:43:41] <unicornisaurous>	 (even though I have no idea what it does)
[01:43:55] <Reedy>	 You're not the only one ;)
[01:44:36] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace some wfMsg* calls [extensions/Push] - 10https://gerrit.wikimedia.org/r/262062 
[01:44:48] <MtDu>	 Anyone done wikilog? 
[01:44:55] <FlorianSW>	 MtDu: already done
[01:45:08] <MtDu>	 Doing SecurePoll
[01:45:10] <wikibugs>	 10MediaWiki-General-or-Unknown, 7Easy, 5MW-1.23-release, 5MW-1.25-release, and 3 others: Bail out early if $wgArticlePath is non-absolute - https://phabricator.wikimedia.org/T48998#1913063 (10matmarex) Yeah, probably.
[01:45:10] <FlorianSW>	 Reedy: updating the grep takes, at least in tool labs, a looooong time :)
[01:45:28] <Reedy>	 Is that hint hint for me to do it? :P
[01:45:34] <MtDu>	 Actually. I'll start from bottom
[01:45:43] <MtDu>	 Doing Newsignuppage
[01:46:16] <grrrit-wm>	 (03CR) 10MtDu: "recheck" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/262061 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[01:46:38] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg* functions [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/262061 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[01:46:58] <FlorianSW>	 Reedy: no, but if it's faster on your pc :P
[01:47:01] <FlorianSW>	 do it :D
[01:47:20] <FlorianSW>	 (but no, it wasn't, just as an information)
[01:47:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/262061 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[01:47:54] <wikibugs>	 10MediaWiki-General-or-Unknown, 7JavaScript, 7WorkType-Maintenance: Cleanup pre MW 1.20 deprecations in Wikibits.js - https://phabricator.wikimedia.org/T122755#1913065 (10Reedy) ``` addCheckboxClickHandlers checkboxClickHandler ff2_bugs is_chrome_mac is_chrome is_ff2 is_ff2_win is_ff2_x11 is_opera_preseven i...
[01:48:10] <Reedy>	 I might do it tomorrow when we've stopped
[01:48:14] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Replace some wfMsg* calls [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/262058 (https://phabricator.wikimedia.org/T70750) 
[01:48:15] <Reedy>	 and everything merged
[01:48:17] <Reedy>	 Gonna go to bed soon
[01:48:39] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] wfMsgForContentNoTrans() was removed [core] - 10https://gerrit.wikimedia.org/r/262048 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy)
[01:49:25] * FlorianSW too
[01:50:23] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/262063 (https://phabricator.wikimedia.org/T70750) 
[01:51:12] <MtDu>	 Doing ProofreadPage
[01:51:32] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Validate that $wgVariantArticlePath is absolute, too [core] - 10https://gerrit.wikimedia.org/r/262064 (https://phabricator.wikimedia.org/T48998) 
[01:52:16] <MtDu>	 FlorianSW: Patch above. 
[01:52:19] <MtDu>	 Reedy:^
[01:52:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Untested. Somebody please check the variable-variables stuff carefully." [core] - 10https://gerrit.wikimedia.org/r/262064 (https://phabricator.wikimedia.org/T48998) (owner: 10Bartosz Dziewoński)
[01:53:06] <MtDu>	 Proofreadpage seems to be done already
[01:53:18] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg* functions [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/262063 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[01:53:27] <MtDu>	 Doing premoderation
[01:53:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: wfMsgForContentNoTrans() was removed [core] - 10https://gerrit.wikimedia.org/r/262048 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy)
[01:53:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/262063 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[01:54:31] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 (https://phabricator.wikimedia.org/T122754) 
[01:56:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Validate that $wgVariantArticlePath is absolute, too [core] - 10https://gerrit.wikimedia.org/r/262064 (https://phabricator.wikimedia.org/T48998) (owner: 10Bartosz Dziewoński)
[02:01:20] <Reedy>	 MatmaRex: Ugh, one has over 20k usages :(
[02:01:33] <Reedy>	 think it was write
[02:01:45] <unicornisaurous>	 dang
[02:02:35] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/262065 (https://phabricator.wikimedia.org/T70750) 
[02:03:15] <MtDu>	 FlorianSW: Patch. 
[02:03:17] <MtDu>	 Reedy: ^
[02:04:41] <MtDu>	 Doing createredirect now
[02:05:31] <MtDu>	 Createredirect seems to be done
[02:05:42] <MtDu>	 Doing favorites
[02:08:39] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 7Wikimedia-log-errors: Call to a member function getSiteLinkList() on a non-object (NULL) in ClientParserOutputDataUpdater - https://phabricator.wikimedia.org/T122747#1913086 (10aude)
[02:08:42] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Wikimedia-log-errors: [Bug] BadMethodCallException from line 131 of Wikibase/client/includes/ParserOutputDataUpdater.php: Call to a member function getSiteLinkList() on a non-object (NULL) - https://phabricator.wikimedia.org/T118580#1913087 (10aude)
[02:08:53] <unicornisaurous>	 I think I did it right: https://gerrit.wikimedia.org/r/#/c/262066/
[02:09:26] <unicornisaurous>	 ^ FlorianSW and Reedy 
[02:10:05] <unicornisaurous>	 gerrit-wm didn’t say anything I guess
[02:10:25] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "Some work needed :)" (0321 comments) [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/262065 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:11:21] <unicornisaurous>	 oh crap I forgot all about $this->msg
[02:13:13] <MtDu>	 FlorianSW: Sorry. I'm getting careless. I guess this is too exciting. :)
[02:13:28] <FlorianSW>	 :)
[02:17:52] <wikibugs>	 10MediaWiki-General-or-Unknown, 5Patch-For-Review, 7Tracking, 7WorkType-Maintenance: Pre MW 1.20 deprecation cleanup - https://phabricator.wikimedia.org/T122754#1913089 (10Florian)
[02:18:09] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/262067 (https://phabricator.wikimedia.org/T70750) 
[02:18:14] <MtDu>	 FlorianSW: I finished Favorites first. There it is. 
[02:18:27] <wikibugs>	 10MediaWiki-General-or-Unknown, 7JavaScript, 7WorkType-Maintenance: Cleanup pre MW 1.20 deprecations in Wikibits.js - https://phabricator.wikimedia.org/T122755#1913091 (10Reedy) {F3196199}  {F3196200}  {F3196201}  {F3196202}  {F3196203}  {F3196204}  {F3196205}  {F3196206}  {F3196207}  {F3196208}  {F3196209}...
[02:19:16] <MtDu>	 FlorianSW: So on https://gerrit.wikimedia.org/r/#/c/262065/1/SpecialPremoderation.php, you want me to use escaped() on 133, 134, 135, and 136 as well? 
[02:19:17] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* functions (032 comments) [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/262067 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:19:33] <FlorianSW>	 MtDu: yep
[02:20:26] <unicornisaurous>	 FlorianSW: New changeset. I guess this repo isn’t on gerrit-wm
[02:21:09] <tto>	 unicornisaurous, it's probably redirected to some other IRC channel
[02:23:12] * FlorianSW fall into bed tired
[02:23:17] <FlorianSW>	 * falls
[02:23:23] <unicornisaurous>	 Can you approve my task first? :P
[02:24:02] <unicornisaurous>	 Thanks! :)
[02:27:56] <MtDu>	 Reedy: You still there? 
[02:28:08] <Reedy>	 Yup, doing some Python :P
[02:29:32] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/262065 (https://phabricator.wikimedia.org/T70750) 
[02:29:50] <MtDu>	 Reedy: Can you still do code reviews? 
[02:33:24] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/262067 (https://phabricator.wikimedia.org/T70750) 
[02:33:29] <Reedy>	 Yeah
[02:33:33] <Reedy>	 I need to go to bed soon though
[02:33:48] <MtDu>	 Reedy: Great. Well, let's finish these two, and we can both get some rest. :)
[02:34:04] <MtDu>	 Reedy: The two patches are above. 
[02:35:15] <MtDu>	 If I'm not mistaken, all that's left is ReplaceSet and the ones in core, assuming we did all the ones before the one Unicornisaurus did. :)
[02:35:52] <Reedy>	 I can't believe they've all been done tonight ;)
[02:37:20] <MtDu>	 Reedy: Go team! :)
[02:37:31] <MtDu>	 Reedy: I'll go ahead and do replaceset
[02:38:22] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace deprecated wfMsg* functions [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/262067 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:38:37] <MtDu>	 Reedy: What do you want me to do about this? https://dpaste.de/sCNs
[02:38:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/262067 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:38:56] <Reedy>	 MtDu: unicornisaurous If we need to do something to give you guys credit for these commits for GCI, poke us tomorrow ;)
[02:39:31] <unicornisaurous>	 Reedy: Florian took care of mine while falling into bed
[02:39:37] <Reedy>	 heh
[02:39:45] <unicornisaurous>	 Thanks though :)
[02:40:02] <unicornisaurous>	 I’m going to do more later probably
[02:40:18] <MtDu>	 Reedy: I've already done this task before. Just wanted to help you guys out. If I get credit for it, well that's great. :)
[02:40:31] <Reedy>	 If we can give you credit, I don't mind doing so
[02:40:46] <MtDu>	 unicornisaurous: I think all we have left is a few of them in core. :)
[02:41:20] <Reedy>	 It should just be the functions in core
[02:41:23] <unicornisaurous>	 wow
[02:41:26] <Reedy>	 The callers mostly should've been fixed
[02:41:30] <unicornisaurous>	 I thought somebody said theres a “bunch”
[02:41:47] <Reedy>	 There was :P
[02:41:50] <MtDu>	 unicornisaurous: Well, we reduced that bunch. :)
[02:41:58] <Reedy>	 MtDu: https://gerrit.wikimedia.org/r/#/c/262059/1/includes/datavalues/SMW_DataValue.php,unified is what FlorianSW|away did for another like that
[02:42:21] <MtDu>	 Reedy: Ok. And Reedy: Ok. That's great. Do I need to poke you tomorrow or what? On the GCI page, it just says I've completed that one. Not sure if it'll let me do it again. 
[02:42:32] <Reedy>	 will it not?
[02:42:37] <Reedy>	 That's a bit silly for this sort of task
[02:42:43] <Reedy>	 where it's discretely different
[02:43:26] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace deprecated wfMsg* functions [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/262065 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:43:39] <MtDu>	 Reedy: Yeah. I did a task, and Nemo told me that I could do it again if I wanted since there was a lot more left, and I tried to, but it just said completed and gave me my history of submission. I did another task, and tried to go back, but it didn't work. 
[02:43:54] <MtDu>	 Reedy: But if it doesn't work out, that's fine. I just wanted to help you guys out. :)
[02:43:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/262065 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:43:55] <Reedy>	 Hmm. Maybe we ask him about it tomorrow then :)
[02:44:29] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "Needs rebase..." [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[02:46:06] <MtDu>	 Reedy: For the one I mentioned earlier, do you want me to use escaped()? Look at the Premoderation ones, Florian told me to use escaped. 
[02:46:17] <Reedy>	 Sounds fine :)
[02:46:38] <Reedy>	 Gets a little confusing with all the similarilty
[02:47:56] <Reedy>	 Gonna run an grep and see waht state we're in
[02:48:01] <Reedy>	 Know there's a few more unmerged
[02:48:45] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace some wfMsg* calls [extensions/Push] - 10https://gerrit.wikimedia.org/r/262062 (owner: 10Florianschmidtwelzow)
[02:49:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace some wfMsg* calls [extensions/Push] - 10https://gerrit.wikimedia.org/r/262062 (owner: 10Florianschmidtwelzow)
[02:49:36] <Reedy>	 MtDu: unicornisaurous There's quite a few more to go :P
[02:50:06] <MtDu>	 Reedy: Is there a list somewhere? 
[02:50:11] <Reedy>	 I'm just making one
[02:50:14] <Reedy>	 Will update the task
[02:50:37] <Reedy>	 Note there's a few false positives from the unmerged tasks
[02:50:41] <Reedy>	 *changes
[02:51:24] <unicornisaurous>	 Maybe nemo will make a “series” of tasks like he did for the translation tasks
[02:51:52] <MtDu>	 unicornisaurus: Lol. Can I like chain submit then? 
[02:52:06] <MtDu>	 unicornisaurous: Lol. Can we like chain submit then? 
[02:52:28] <Reedy>	 There's possibly a thousand to fix :/
[02:53:13] <unicornisaurous>	 Wellllllll, he’d probably make the first task only one patch, the second one 5 patches, the third 25, the fourth 125, or something like that
[02:53:17] <Reedy>	 why does it look like some are new
[02:53:55] <MtDu>	 unicornisaurous: Well. Better get busy. :p
[02:54:16] <MtDu>	 Reedy: Really? Dang. 
[02:54:24] <Reedy>	 There's maybe 10% or so less on that
[02:54:30] <Reedy>	 Wikilog (which has a patch) has over 100
[02:55:00] <MtDu>	 Reedy: Ok. 
[02:55:08] <MtDu>	 Reedy: And how do I rebase? I've never done that before. 
[02:55:21] <Reedy>	 git review -d 12345
[02:55:24] <Reedy>	 git rebase origin
[02:55:27] <Reedy>	 See what complains :)
[02:55:36] <unicornisaurous>	 git rebase gerrit/master
[02:55:56] <wikibugs>	 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 20 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1913098 (10Reedy)
[02:56:48] <unicornisaurous>	 Something will be broken if gerrit didn’t do it for you. So then its like resolving a merge conflict. Then just git rebase - -continue
[02:57:08] <wikibugs>	 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 20 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1692282 (10Reedy) `...
[02:57:24] <Reedy>	 https://phabricator.wikimedia.org/T70750#1913098
[02:57:28] <Reedy>	 I just added a lot more :P
[02:58:15] <MtDu>	 Reedy: It says Current branch review/mtdu/261761 is up to date.
[02:58:27] <Reedy>	 git checkout master
[02:58:28] <Reedy>	 git pull
[02:58:29] <Reedy>	 then try again
[02:58:30] <MtDu>	 Reedy: When I rebase. 
[02:59:12] <unicornisaurous>	 If you’ve already rebased then you’re done
[02:59:14] <unicornisaurous>	 try git review
[02:59:24] <Reedy>	 His master isn't going to be up to date
[02:59:29] <Reedy>	 gerrit is complaing about it can't rebase
[02:59:48] <unicornisaurous>	 I thought he meant after he resolved stuff
[03:00:03] <MtDu>	 Reedy: Justin@Du MINGW64 ~/vagrant/mediawiki/extensions/LiveTranslate (review/mtdu/261761)
[03:00:03] <MtDu>	 $ git rebase origin
[03:00:03] <MtDu>	 Current branch review/mtdu/261761 is up to date.
[03:00:04] <MtDu>	 Justin@Du MINGW64 ~/vagrant/mediawiki/extensions/LiveTranslate (review/mtdu/261761)
[03:00:04] <MtDu>	 $ git checkout master
[03:00:04] <MtDu>	 Switched to branch 'master'
[03:00:06] <MtDu>	 Your branch is ahead of 'origin/master' by 1 commit.
[03:00:08] <MtDu>	   (use "git push" to publish your local commits)
[03:00:10] <MtDu>	 Justin@Du MINGW64 ~/vagrant/mediawiki/extensions/LiveTranslate (master)
[03:00:12] <MtDu>	 $ git pull
[03:00:16] <MtDu>	 remote: Counting objects: 247, done
[03:00:18] <MtDu>	 remote: Finding sources: 100% (7/7)
[03:00:20] <MtDu>	 remote: Total 7 (delta 5), reused 7 (delta 5)
[03:00:22] <MtDu>	 Unpacking objects: 100% (7/7), done.
[03:00:24] <MtDu>	 From https://gerrit.wikimedia.org/r/mediawiki/extensions/LiveTranslate
[03:00:26] <MtDu>	    672c08a..e78a40c  master     -> origin/master
[03:00:27] <unicornisaurous>	 paste.de pls
[03:00:28] <MtDu>	 Auto-merging api/ApiImportTranslationMemories.php
[03:00:30] <MtDu>	 Auto-merging LiveTranslate.hooks.php
[03:00:32] <MtDu>	 CONFLICT (content): Merge conflict in LiveTranslate.hooks.php
[03:00:34] <MtDu>	 Automatic merge failed; fix conflicts and then commit the result.
[03:00:36] <MtDu>	 Justin@Du MINGW64 ~/vagrant/mediawiki/extensions/LiveTranslate (master|MERGING)
[03:01:35] <Reedy>	 Need to fix those then :)
[03:01:46] <unicornisaurous>	 I think he pasted too much :)
[03:02:01] <Reedy>	 lol
[03:02:16] <Reedy>	 !pastebin | MtDu
[03:02:16] <wm-bot>	 MtDu: To avoid overflowing the channel with inane amounts of text, use https://phabricator.wikimedia.org/paste/create/ or other awesome pastebin sites to share code, errors, and other large texts.
[03:02:47] <MtDu>	 Reedy: Sorry about that text. I forgot to copy the pastebin link. 
[03:02:55] <MtDu>	 Did you get the link at the end? 
[03:02:59] <unicornisaurous>	 So now its just like resolving merge conflicts
[03:03:10] <unicornisaurous>	 no we did not get the list
[03:03:11] <unicornisaurous>	 *link
[03:03:17] <MtDu>	 https://dpaste.de/NfmP
[03:03:53] <Reedy>	 LiveTranslate.hooks.php: needs merge
[03:03:58] <Reedy>	 Open the file, look for conflict markers
[03:05:45] <unicornisaurous>	 Does he really want to do that? IIRC, he should do a git fetch - -all and then checkout his review branch again for the rebase to gerrit/master. Now he will be dealing with merge conflicts twice I think. (Once to pull into master, then again to rebase)
[03:05:50] <unicornisaurous>	 Reedy ^
[03:06:18] <Reedy>	 Are the commits ontop of master?
[03:06:35] <Reedy>	 Your branch is ahead of 'origin/master' by 1 commit.
[03:06:37] <Reedy>	 looks like it
[03:06:42] <Reedy>	 git reset HEAD~5 --hard
[03:06:43] <Reedy>	 git pull
[03:06:45] <Reedy>	 git review -d 1234
[03:06:48] <Reedy>	 git rebase origin
[03:07:04] <unicornisaurous>	 I think a git review from master will suffie
[03:07:06] <unicornisaurous>	 *suffice
[03:07:29] <Reedy>	 Sometimes easier to keep it cleaner
[03:07:41] <Reedy>	 If I commit ontop of master, I reset it away after to save divergence
[03:07:46] <MtDu>	 Reedy: One sec. I restarted machine. 
[03:07:50] <unicornisaurous>	 Well usually after I do a rebase I end up resetting everything
[03:07:59] <unicornisaurous>	 (since i break stuff)
[03:08:08] <MtDu>	 Reedy: 4gb ram is not enough sometimes. 
[03:09:19] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/262069 (https://phabricator.wikimedia.org/T70750) 
[03:09:23] * unicornisaurous looks at his 34 Chrome tabs and wonders how MtDu lives with 4GB.
[03:09:48] <Reedy>	 The only time I have anything less than 4GB is headless stuff...
[03:09:51] <MtDu>	 Reedy: Alright. Now that is outta the way. 
[03:10:05] <MtDu>	 Reedy: It's ok. I got an ssd. :)
[03:10:27] <unicornisaurous>	 my mediawiki vagrant instance probably has 4 by itself
[03:10:29] <Reedy>	 Saying that, my NAS has 16GB :P
[03:10:56] <MtDu>	 Reedy: So I'm starting by git review -d that patch right? 
[03:11:10] <Reedy>	 I'd suggest tidying up your master first
[03:11:12] <MtDu>	 Reedy: Then run those commands you sent me starting at 21:06:35?
[03:11:16] <MtDu>	 Reedy: Ok. 
[03:11:21] <MtDu>	 Reedy: How so? 
[03:11:32] <Reedy>	 git checkout master
[03:11:37] <Reedy>	 git reset HEAD~5 --hard
[03:11:37] <Reedy>	 git pull
[03:12:01] <unicornisaurous>	 Then fix merge conflicts! Yay!
[03:12:02] <MtDu>	 Reedy: Then download the change? 
[03:12:08] <wikibugs>	 10MediaWiki-Export-or-Import, 3Google-Code-In-2015: [Import/export compatibility] Special:Import and importDump.php should ignore unrecognized tags - https://phabricator.wikimedia.org/T43938#1913102 (10TTO) https://codein.withgoogle.com/dashboard/tasks/5520672822394880/
[03:12:10] <Reedy>	 yeah
[03:13:13] <wikibugs>	 10MediaWiki-Export-or-Import, 7Testme: Export function doesn't work with apache module mod_gzip - https://phabricator.wikimedia.org/T11997#1913105 (10TTO) p:5Low>3Lowest
[03:14:04] <MtDu>	 Reedy: Then I just commit --amend and git review? 
[03:14:19] <Reedy>	 did you git review -d 1234 your patch?
[03:14:28] <MtDu>	 Reedy: yep
[03:16:26] <MtDu>	 Reedy:^ and btw, https://gerrit.wikimedia.org/r/#/c/262069
[03:18:53] <Reedy>	 Did you rebase and sort the conflicts too?
[03:19:40] <MtDu>	 Reedy: No. Can you guide me through it?
[03:20:11] <MtDu>	  Reedy: All I did was checkout master, and then git review -d my patch. 
[03:20:22] <Reedy>	 is your master up to date?
[03:20:30] <unicornisaurous>	 (See also: https://www.mediawiki.org/wiki/Gerrit/resolve_conflict)
[03:22:46] <MtDu>	 Reedy: I think so. This is my git bash log. https://dpaste.de/FEXa
[03:23:07] <Reedy>	 so yeah
[03:23:08] <Reedy>	 git rebase origin
[03:23:12] <Reedy>	 then it should complain about conflicts
[03:23:27] <Reedy>	 I think the conflict will be the change Florian did earlier that crashes with yours
[03:25:18] <MtDu>	 Reedy: It does. https://dpaste.de/VuzV
[03:25:30] <Reedy>	 git diff?
[03:27:20] <MtDu>	 Reedy: It doesn't show anything. Want me to git show HEAD?
[03:27:46] <Reedy>	 Why are you on ConventionExtension?
[03:28:11] <MtDu>	 Reedy: Woops, wrong tab
[03:28:21] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace deprecated wfMsg* functions [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/262069 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[03:28:21] <MtDu>	 Reedy: Was working on that one earlier. 
[03:28:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/ReplaceSet] - 10https://gerrit.wikimedia.org/r/262069 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[03:29:21] <MtDu>	 Reedy: Speaking of which, I'm done with actualyl. 
[03:30:01] <Reedy>	 03:30
[03:31:09] <MtDu>	 Reedy: Here is the dpaste. https://dpaste.de/795O
[03:32:04] <Reedy>	 git rebase origin
[03:32:56] <MtDu>	 Reedy: There we go. https://dpaste.de/BG3R
[03:33:05] <Reedy>	 CONFLICT (content): Merge conflict in LiveTranslate.hooks.php
[03:33:11] <unicornisaurous>	 Yay
[03:33:12] <Reedy>	 Have a look in that file for <<< or >>>
[03:34:19] <MtDu>	 Reedy: Ok. Hold on. Let me push that patch for ConventionExtension before I forget. 
[03:34:42] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/262070 (https://phabricator.wikimedia.org/T70750) 
[03:35:49] <wikibugs>	 10MediaWiki-Search, 10CirrusSearch, 6Discovery: English Wikipedia search results are incomplete - https://phabricator.wikimedia.org/T122566#1913127 (10MZMcBride) @Deskana: I don't pay much attention to workboards, but regarding "Deskana moved this task to Advanced search syntax on the CirrusSearch workboard....
[03:36:05] <MtDu>	 Reedy: Can you send me that link again to what Florian did? 
[03:39:17] <MtDu>	 Reedy: I'm not sure what to do. https://dpaste.de/1q0F My brain's getting fuzzy. 
[03:41:58] <MtDu>	 Reedy: Ok. So I find the <<< and >>>. Then what do I do? 
[03:42:06] <Reedy>	 You pick one of the changes to use
[03:42:22] <Reedy>	 The bottom one is yours, the top one is what Florian changed it to
[03:43:38] <Reedy>	 Then delete the other lines
[03:43:42] <MtDu>	 Reedy: Which one do you think? I think Florian might have told me to use the $article method.
[03:43:51] <MtDu>	 Reedy: But I think I should go with what Florian did. 
[03:43:53] <Reedy>	 Either is valid
[03:44:15] <MtDu>	 Is there one you prefer? 
[03:44:39] <Reedy>	 I think I'd probably go with yours
[03:44:53] <Reedy>	 As you're deglobali[sz]ing the file at the same time
[03:45:53] <wikibugs>	 10MediaWiki-extensions-AbuseFilter, 10MobileFrontend: Abusefilter not tagging mobile edits - https://phabricator.wikimedia.org/T122639#1913129 (10Techman224) Now it seems to work with this edit, https://commons.wikimedia.org/wiki/Special:AbuseLog/1143562. user_mobile is 1
[03:46:02] <Reedy>	 https://gerrit.wikimedia.org/r/#/c/262059/1/includes/datavalues/SMW_DataValue.php,unified is that change that Florian did
[03:46:08] <Reedy>	 for the call_user_func
[03:46:14] <MtDu>	 Reedy: Ok. So I get rid of these lines? https://dpaste.de/1q0F#L130,131,132,134,146,147,148,150
[03:46:34] <Reedy>	 Yup, exactly
[03:47:20] <MtDu>	 Reedy: Then I do git rebase --continue? 
[03:47:51] <Reedy>	 I think you need to git add the file first iirc
[03:48:13] <MtDu>	 What's iirc?
[03:48:32] <Reedy>	 if i remember correctly
[03:49:06] <MtDu>	 Reedy: Ok. I did that. Now I run the git rebase --continue? 
[03:49:09] <Reedy>	 yup
[03:50:02] <MtDu>	 Reedy: Success! Now what do I do? 
[03:50:07] <Reedy>	 git review
[03:50:27] <MtDu>	 No git commit first? 
[03:50:31] <MtDu>	 Or remote update? 
[03:50:56] <MtDu>	 Reedy:^
[03:50:57] <Reedy>	 nope
[03:51:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Enable and configure jscs, fix some errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 (owner: 10Ricordisamoa)
[03:51:37] <wikibugs>	 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Remove sitelinks and subscriptions+sitelinks lookup modes in change dispatcher - https://phabricator.wikimedia.org/T118265#1913130 (10hoo) 5Open>3Resolved
[03:51:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Enable and configure jscs, fix some errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 (owner: 10Ricordisamoa)
[03:51:44] <grrrit-wm>	 (03PS11) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) 
[03:52:07] <Reedy>	 tada
[03:52:22] <MtDu>	 Reedy: Yay! Thanks for the help. Also take a look at https://gerrit.wikimedia.org/r/262070
[03:52:33] <Reedy>	 I really need to go to bed :P
[03:52:35] <Reedy>	 It's nearly 4am here
[03:52:39] <MtDu>	 Reedy: Should I do any more? Or are you heading to bed after this? 
[03:52:45] <MtDu>	 Reedy: Ok. 
[03:53:08] <Reedy>	 As long as it's not something Florian has already done (he's only got a couple of commits left of these to review), you can feel free to do any others you want
[03:53:15] <Reedy>	 One or both of us will look at it after we've slept
[03:53:33] <MtDu>	 Reedy: Ok. So if I just do some from the list you posted, it'll be ok? 
[03:53:42] <Reedy>	 Yup, should be fine :)
[03:53:54] <unicornisaurous>	 Go to sleep!
[03:54:05] <MtDu>	 Reedy: Well, thanks for the help and thanks for staying up! Get some rest. You deserve it. :)
[03:54:11] <Reedy>	 It's not as bad as New Years eve/day
[03:54:20] <Reedy>	 I got home at 5am, and had to clean up dog poop
[03:54:21] <Reedy>	 :D
[03:54:42] <Reedy>	 I've done over 190 commits today
[03:54:45] <Reedy>	 Pretty productive
[03:54:57] <MtDu>	 Reedy: Nice job! 
[03:55:11] <Reedy>	 https://github.com/wikimedia/mediawiki/blob/master/RELEASE-NOTES-1.27#L201-L214
[03:55:15] <Reedy>	 And that lot has been removed from core
[03:56:41] <wikibugs>	 7Design, 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, and 4 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1913134 (10Quiddity) I have now tested this at http://en.wikipedia.beta.wmflabs.org/wiki/U...
[03:58:54] <MtDu>	 Working on TweetaNew
[04:00:24] <MtDu>	 unicornisaurous: Do you recognize these extensions? I don't. 
[04:00:42] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Looks sensible." [core] - 10https://gerrit.wikimedia.org/r/258116 (owner: 10Thiemo Mättig (WMDE))
[04:01:24] <Reedy>	 We have a lot of extensions in our git repo that have almost been abandoned
[04:01:30] <Reedy>	 Most aren't used by the WMF
[04:02:08] <MtDu>	 Reedy: I see. 
[04:02:22] <Reedy>	 So we use this to guage whether we can delete stuff
[04:02:22] <unicornisaurous>	 The one I was fixing i18n functions on was marked “unmaintained” on MediaWiki
[04:02:36] <Reedy>	 And try to be good custodians and not break stuff
[04:03:10] <unicornisaurous>	 Go to bed! :P
[04:05:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix positioning of jQuery.tipsy tooltip arrows [core] - 10https://gerrit.wikimedia.org/r/258116 (owner: 10Thiemo Mättig (WMDE))
[04:07:24] <grrrit-wm>	 (03PS6) 10Ricordisamoa: build: Enable and configure jscs, fix some errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 
[04:10:41] <wikibugs>	 10MediaWiki-Export-or-Import: WikiImporter should not open the XML stream in the constructor. - https://phabricator.wikimedia.org/T89268#1913137 (10TTO) 5Open>3stalled @daniel: Can you confirm that this is no longer an issue for you?
[04:11:56] <grrrit-wm>	 (03CR) 10Ricordisamoa: "PS6 is rebase only" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 (owner: 10Ricordisamoa)
[04:12:07] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/262071 (https://phabricator.wikimedia.org/T70750) 
[04:15:28] <MtDu>	 Working on smoothgallery
[04:18:25] <grrrit-wm>	 (03CR) 10Anomie: Update for SessionManager (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 (owner: 10Anomie)
[04:18:32] <grrrit-wm>	 (03PS13) 10Anomie: Update for SessionManager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 
[04:18:34] <grrrit-wm>	 (03PS7) 10Anomie: Refactor session- and cookie-related code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248394 
[04:23:17] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262072 (https://phabricator.wikimedia.org/T70750) 
[04:25:34] <MtDu>	 Last one for tonight. Working on SolrStore
[04:26:57] <grrrit-wm>	 (03CR) 10TTO: "Dereckson: Do you still plan to work on this? If not, I can give it to a Google Code-In student to work on." [core] - 10https://gerrit.wikimedia.org/r/198215 (https://phabricator.wikimedia.org/T45426) (owner: 10Dereckson)
[04:34:14] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913142 (10josephine_l)
[04:35:36] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1907764 (10josephine_l)
[04:44:11] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913144 (10josephine_l)
[04:48:08] <wikibugs>	 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1913145 (10josephine_l)
[04:49:05] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] Convert SubpageSortkey to use extension registration (031 comment) [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK)
[04:53:53] <wikibugs>	 10MediaWiki-Configuration, 5MW-1.27-release: Support $wgAction in extension registration - https://phabricator.wikimedia.org/T117197#1913147 (10Legoktm) It's already there? https://github.com/wikimedia/mediawiki/blob/master/docs/extension.schema.json#L675
[04:55:13] <wikibugs>	 6Education-Collab: Mentorship an online ambassador - https://phabricator.wikimedia.org/T122344#1913148 (10Walaa)
[05:02:58] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913151 (10josephine_l)
[05:06:06] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262072 (https://phabricator.wikimedia.org/T70750) 
[05:07:18] <wikibugs>	 10MediaWiki-Search, 10CirrusSearch, 6Discovery: English Wikipedia search results are incomplete - https://phabricator.wikimedia.org/T122566#1913152 (10Deskana) >>! In T122566#1913127, @MZMcBride wrote: > @Deskana: I don't pay much attention to workboards, but regarding "Deskana moved this task to Advanced se...
[05:11:44] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/262070 (https://phabricator.wikimedia.org/T70750) 
[05:16:35] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/262074 (https://phabricator.wikimedia.org/T70750) 
[05:44:51] <futurefad>	 hi all im futurefad new here
[05:50:50] <wikibugs>	 7Design, 10MediaWiki-Special-pages, 3Google-Code-In-2015, 5Patch-For-Review: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1913157 (10Volker_E) @Tgr @Reedy @PauGiner @Jdlrobson I have to agree with Pau on his general feedback on the task.  For Reedy's ques...
[06:05:19] <wikibugs>	 7Design, 10Front-end-Standards-Group, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: User interface presentation - https://phabricator.wikimedia.org/T119162#1913164 (10RobLa-WMF) Per @cscott's edit from earlier today ([schedule edit](https://www.mediawiki.org/w/index.php?title=Wikim...
[06:09:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Mark as unmaintained. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/259598 (owner: 10Mattflaschen)
[06:10:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Mark as unmaintained. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/259598 (owner: 10Mattflaschen)
[06:10:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Enable and configure jscs, fix some errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 (owner: 10Ricordisamoa)
[06:14:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable and configure jscs, fix some errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 (owner: 10Ricordisamoa)
[06:18:07] <wikibugs>	 10MediaWiki-Export-or-Import, 10Wikimedia-Site-Requests, 6Wikisource: Broken revisions with rev_page=0 - https://phabricator.wikimedia.org/T18674#1913165 (10TTO) Many of the revisions on knwiki with `rev_page = 0` occurred when a user ran a simultaneous transwiki and upload import of the same pages. The tran...
[06:22:43] <wikibugs>	 7Design, 10Front-end-Standards-Group, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: User interface presentation - https://phabricator.wikimedia.org/T119162#1913167 (10RobLa-WMF)
[06:31:07] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization: Define the list of "must have" sessions for WikiDev '16 - https://phabricator.wikimedia.org/T119593#1913168 (10cscott) Since the dev summit is nigh upon us, I've gone ahead and implemented the schedule change above (descheduling the T114072 session, and moving T112...
[06:40:43] <tto>	 Anyone around with access to the wfDebug logs on production?
[06:40:43] <tto>	 I'd like to see if there are recent entries for testwiki from the wfDebug on line 684 of Import.php:
[06:40:44] <tto>	 "Page ID " . $this->mPage . " mismatches the ID " . $this->mTitle->getArticleID() . " provided by the Title object."
[06:43:10] <legoktm>	 hi tto
[06:43:42] <tto>	 hi legoktm :)
[06:44:21] <legoktm>	 tto: I  grepped for 'provided by the' and no results
[06:44:36] <legoktm>	 how recent?
[06:45:00] <tto>	 Hmmm interesting
[06:45:02] <legoktm>	 it's about 3 hours of logs, I can look at older stuff if you want
[06:45:12] <tto>	 Something I did a few minutes ago ought to have triggered that
[06:45:27] <tto>	 (well, within the last hour)
[06:46:29] <tto>	 Thanks anyway!
[06:46:40] <legoktm>	 anytime
[06:48:11] <grrrit-wm>	 (03PS5) 10Legoktm: Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK)
[06:49:39] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK)
[06:50:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK)
[06:51:04] <wikibugs>	 10MediaWiki-extensions-SubpageSortkey, 3Google-Code-In-2015, 5Patch-For-Review: Convert SubpageSortkey to use extension registration - https://phabricator.wikimedia.org/T87975#1913173 (10Legoktm) 5Open>3Resolved a:3Pranavmk98
[06:51:09] <wikibugs>	 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1913175 (10Legoktm)
[07:07:29] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032] Use valid spdx license identifier [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/261885 (owner: 10Legoktm)
[07:07:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use valid spdx license identifier [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/261885 (owner: 10Legoktm)
[07:14:20] <wikibugs>	 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 7Story: [Story] Direct link to download the raw JSON data of each Entity - https://phabricator.wikimedia.org/T66515#1913184 (10hoo)
[07:14:23] <wikibugs>	 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: It should be possible to get entity id from page title - https://phabricator.wikimedia.org/T67507#1913181 (10hoo) 5Open>3Resolved a:3hoo `Wikibase\Store\EntityIdLookup::getEntityIdForTitle` can do this.
[07:15:31] <ananayarora>	 I don't understand what to translate :(
[07:15:37] <ananayarora>	 Every thing is pre translated 
[07:20:18] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata: InvalidArgumentException from line 34 of PageEntityUsages.php: $pageId must be an integer > 0 - https://phabricator.wikimedia.org/T114352#1913186 (10hoo) 5Open>3Resolved a:3hoo No more log entries regarding this since at least October 10 (all logs we kee...
[07:25:11] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Implement change replication for all entities - https://phabricator.wikimedia.org/T42721#1913191 (10hoo) 5Open>3Invalid a:3hoo No longer relevant.
[07:28:03] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Need-volunteer: Do not show language section on talk pages - https://phabricator.wikimedia.org/T47582#1913195 (10hoo) 5Open>3declined a:3hoo We no longer force that AFAIK, but ULS does nowadays (but that's not what this bug is about).
[07:29:19] <grrrit-wm>	 (03CR) 10Gergő Tisza: Update for SessionManager (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/248395 (owner: 10Anomie)
[07:39:31] <grrrit-wm>	 (03CR) 10Legoktm: "Leaving it totally up to implementations isn't very useful, as the point of this abstraction is so things that want to post don't have to " [core] - 10https://gerrit.wikimedia.org/r/261794 (owner: 10Mattflaschen)
[08:28:23] <victorbarbu_>	 tto: hi!
[08:28:47] <tto>	 victorbarbu_: Hi Victor! Did you manage to get in touch with Ankita?
[08:28:56] <victorbarbu_>	 nope :(
[08:30:21] <tto>	 How long since you last heard from her?
[08:30:55] <victorbarbu_>	 more than 24 hours
[08:31:04] <victorbarbu_>	 on the 1st actually
[08:32:03] <tto>	 victorbarbu_: Our guidelines state that "It could take your mentor(s) up to 36 hours to receive a review of the work that you have submitted."
[08:45:59] <Georggi>	 Hi tto!
[08:46:14] <tto>	 Georggi: G'day!
[08:48:01] <Georggi>	 tto, lets go into private to not spam here:)
[08:51:27] <ananayarora>	 I still don't understand what to do 
[08:51:42] <ananayarora>	 for the Translation task
[08:53:03] <grrrit-wm>	 (03CR) 10TTO: ""-1"" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous)
[08:54:51] <victorbarbu_>	 ananayarora: I feel you ;)
[08:56:34] <tto>	 Nemo_bis might be able to help you, if he is here
[09:01:45] <victorbarbu_>	 tto, have you had the time to look at my patch?
[09:01:52] <victorbarbu_>	 if yes, what do you think?
[09:02:07] <victorbarbu_>	 should I re-implement those JS files as classes?
[09:02:28] <tto>	 victorbarbu_, I'll take another look - can you link me it?
[09:02:42] <victorbarbu_>	 of course https://gerrit.wikimedia.org/r/261911
[09:06:57] <Georggi>	 tto, sorry, internet went down:(
[09:07:47] <grrrit-wm>	 (03PS1) 10TTO: Import: Try to stop revisions getting created with rev_page = 0 [core] - 10https://gerrit.wikimedia.org/r/262078 (https://phabricator.wikimedia.org/T18674) 
[09:07:54] <tto>	 Sorry guys, I was just submitting that patch ^
[09:10:40] <tto>	 victorbarbu_, to test that, do I have to install both UniversalLanguageSelector and SpellingDictionary?
[09:10:59] <victorbarbu_>	 yes
[09:11:24] <victorbarbu_>	 and you should have two test steps: 1) JS disabled 2) JS enabled
[09:11:29] <wikibugs>	 10MediaWiki-Page-editing: Wrap 4-tilde and 5-tilde timestamps in <time> - https://phabricator.wikimedia.org/T122759#1913202 (10mxn) 3NEW
[09:12:29] <victorbarbu_>	 brb in 5 minutes
[09:14:38] <wikibugs>	 10MediaWiki-Interface, 7I18n: Support client-side date/time formatting for user's timezone, language, and preferred format (JavaScript) - https://phabricator.wikimedia.org/T21992#1913213 (10mxn) I incorporated the `<time>` and Moment.js ideas into [a rewrite of the CommentsInLocalTime user script](https://en.w...
[09:17:35] <victorbarbu_>	 back
[09:18:09] <victorbarbu_>	 does xdebug work for Hack as well?
[09:19:06] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913214 (10josephine_l)
[09:26:07] <tto>	 victorbarbu_: [09e4f29a] /wiki/index.php/Main_Page MWException from line 564 of C:\Users\TTO\Documents\Programming\MediaWiki\core\includes\cache\LocalisationCache.php: LocalisationCache::readJSONFile: Invalid JSON file: C:\Users\TTO\Documents\Programming\MediaWiki\SpellingDictionary/i18n/en.json
[09:26:27] <victorbarbu_>	 whaat?
[09:26:30] <victorbarbu_>	 checking it out now
[09:27:27] <victorbarbu_>	 I broke my repo
[09:27:33] <victorbarbu_>	 and I was about to lose my changes
[09:27:52] <victorbarbu_>	 and I've done something that appended <<<EOF blahblah
[09:27:55] <victorbarbu_>	 to my files
[09:28:47] <victorbarbu_>	 does json allow trailing comma?
[09:29:08] <tto>	 victorbarbu_: No, json doesn't allow trailing commas
[09:29:18] <victorbarbu_>	 that's why you got this exception
[09:29:23] <victorbarbu_>	 but it's strange 
[09:29:28] <victorbarbu_>	 that I didn't get any exception
[09:29:59] <grrrit-wm>	 (03PS3) 10Victorbarbu: Replace language selection dropdown with ULS [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) 
[09:30:27] <victorbarbu_>	 tto, sorry
[09:30:33] <victorbarbu_>	 I re-patched it
[09:30:52] <tto>	 When I fixed that, I tried submitting Special:SpellingDictionary form and got a DB query error because I hadn't updated the tables
[09:31:05] <tto>	 But when I visited the installer to update tables, I got an exception
[09:31:13] <tto>	 This is a separate bug in SpellingDictionary extension, I think
[09:31:18] <victorbarbu_>	 what exception? what's happening there?
[09:31:22] <victorbarbu_>	 those are not from me
[09:31:46] <tto>	 No, not your fault
[09:31:57] <tto>	 /wiki/mw-config/?page=ExistingWiki MWException from line 339 of C:\Users\TTO\Documents\Programming\MediaWiki\core\includes\MagicWord.php: Error: invalid magic word 'echo'
[09:32:11] <tto>	 I'll try working around it
[09:32:13] <victorbarbu_>	 so it's not my fault
[09:32:14] <victorbarbu_>	 ?
[09:32:48] <wikibugs>	 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1913215 (10Lokal_Profil) Adding an `owners` tag to each patch will only fix the problem if each of these groups (at least when non-volonteers) also has a clear mandate, and the allocat...
[09:34:15] <tto>	 Not your fault, but it is preventing me from running the update script right now, so it may be a while
[09:38:45] <tto>	 victorbarbu_: Strict Standards: Non-static method AdminRights::displayAllWords() should not be called statically, assuming $this from incompatible context in C:\Users\TTO\Documents\Programming\MediaWiki\SpellingDictionary\specials\SpecialViewAll.php on line 17
[09:38:50] <tto>	 Is that your fault? Not sure
[09:38:57] <victorbarbu_>	 nope
[09:39:01] <victorbarbu_>	 it was already there
[09:39:12] <victorbarbu_>	 and I was told once not to make unrelated changes
[09:39:15] <victorbarbu_>	 so I didn't
[09:39:22] <victorbarbu_>	 I noticed that as well
[09:40:10] <tto>	 victorbarbu_: Feel free to amend it in a follow-up patch if you feel generous :)
[09:40:12] <tto>	 Two more issues:
[09:40:25] <tto>	 Strict Standards: Non-static method AdminRights::displayByLanguage() should not be called statically, assuming $this from incompatible context in C:\Users\TTO\Documents\Programming\MediaWiki\SpellingDictionary\specials\SpecialViewByLanguage.php on line 48
[09:40:36] <tto>	 And the submit button on Special:ViewByLanguage has no label
[09:41:03] <victorbarbu_>	 what do you mean by "has no label"? doesn't it have any text on it?
[09:41:06] <tto>	 Yes
[09:41:11] <victorbarbu_>	 strange
[09:41:14] <victorbarbu_>	 I'll check that
[09:41:17] <victorbarbu_>	 thank you for testing
[09:41:34] <victorbarbu_>	 I'll come back with a new patch very soon :D
[09:44:26] <victorbarbu_>	 tto, for solving those "non-static methods" should I commit that in the same patch?
[09:44:43] <victorbarbu_>	 and add "Also solved some warnings" blah in the commit message?
[09:45:10] <tto>	 victorbarbu_, probably best to put it in a separate patch. After all, looking more closely, I see that you didn't introduce any of them
[09:45:34] <victorbarbu_>	 no, I didn't
[09:46:49] <grrrit-wm>	 (03PS4) 10Victorbarbu: Replace language selection dropdown with ULS [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) 
[09:47:30] <victorbarbu_>	 shouldn't we have a bug report for that? 
[09:47:34] <victorbarbu_>	 that would be fair
[09:49:50] <tto>	 Yes, you're certainly not obliged to fix it
[09:50:12] <tto>	 Not sure if there is a component for SpellingDictionary in PHabricator, you may have to use MediaWiki-Extensions-Other
[09:50:29] <victorbarbu_>	 I will check that out
[09:50:43] <victorbarbu_>	 it is a project
[09:50:47] <victorbarbu_>	 SpellingDictionary
[09:52:51] <wikibugs>	 10MediaWiki-Vendor, 10MediaWiki-extensions-PagedTiffHandler, 10MediaWiki-extensions-SemanticResultFormats, 10Score, and 2 others: Non-existent files are (conditionally?) included by MW, vendors' libraries and extensions - https://phabricator.wikimedia.org/T122760#1913217 (10alex-mashin) 3NEW
[09:55:17] <wikibugs>	 10Spelling-Dictionary: Non-static methods are called statically - https://phabricator.wikimedia.org/T122761#1913224 (10Victorbarbu) 3NEW a:3Victorbarbu
[09:57:35] <victorbarbu_>	 tto, some help please
[09:57:37] <victorbarbu_>	 The outstanding commits are:
[09:57:37] <victorbarbu_>	 e4435dc (HEAD, master) Change methods in class AdminRights to be static
[09:57:37] <victorbarbu_>	 a2426d7 Replace language selection dropdown with ULS
[09:57:42] <victorbarbu_>	 what do I do with these?
[09:58:01] <tto>	 If you want to submit them both to Gerrit, type "yes"
[09:58:13] <tto>	 I'm assuming this is in git-review :)
[09:58:18] <victorbarbu_>	 yes
[09:58:30] <grrrit-wm>	 (03PS1) 10Victorbarbu: Change methods in class AdminRights to be static [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/262080 (https://phabricator.wikimedia.org/T122761) 
[09:58:43] <victorbarbu_>	 ok, here you go https://gerrit.wikimedia.org/r/262080
[09:58:50] <victorbarbu_>	 you should have no warnings now
[09:59:48] <victorbarbu_>	 gerrit says this depends on "Replace language selection dropdown with ULS" but it doesn't
[09:59:58] <victorbarbu_>	 I shouldn't have sent these two commits together
[09:59:59] <victorbarbu_>	 :))
[10:00:15] <tto>	 Ideally you would have them on separate branches, but it doesn't matter for now
[10:06:37] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Does the job required i.e. document the extra parameters" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261811 (owner: 10MtDu)
[10:20:16] <wikibugs>	 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Wikibase-rc-hide-wikidata/en]] i18n issue - https://phabricator.wikimedia.org/T122762#1913235 (10Shirayuki) 3NEW
[10:24:35] <wikibugs>	 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1913242 (10Nemo_bis) >>! In T87875#1887234, @Nemo_bis wrote: > We run out of task proposals for GCi. :) https://phabricator.wik...
[10:26:46] <neeraj>	 after adding a key into gerrit account I am trying to ssh but it is showing an error: "ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable"
[10:27:10] <neeraj>	 can someone tell me what can I do?
[10:32:36] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913243 (10josephine_l) @Nicolas_Raoul , @Niedzielski - I'm having problems with this task, that are described above. Sorry for pinging twice,...
[10:38:47] <tto>	 neeraj: SSH might be blocked on your network. Try running "ssh github.com" - what you do see?
[10:57:19] <victorbarbu_>	 tto, so?
[10:57:54] <victorbarbu_>	 at Nemo_bis' recommendation, I added some screenshots, here http://imgur.com/a/yFeyD
[11:04:20] <tto>	 victorbarbu_, it looks good. Since it seems you have been waiting a long time, I will merge the patch and approve the GCI task
[11:04:37] <victorbarbu_>	 thank you so much!
[11:11:32] <neeraj>	 tto: it is showing "ssh: connect to host github.com port 22: Connection refused"
[11:12:04] <victorbarbu_>	 OMG, Nuclide has become a beast!
[11:12:25] <neeraj>	 but I think it is because git doesn't give access to its shell.
[11:12:39] <victorbarbu_>	 no it's not
[11:13:04] <tto>	 neeraj: When I run "ssh github.com" it does connect to the server
[11:13:21] <victorbarbu_>	 if it works, you will get something like: "hello <username>, github has no ssh access"
[11:13:57] <neeraj>	 so what can I do about that error. 
[11:14:32] <tto>	 neeraj: Try running "ssh -p 80 github.com". Does it say "Connection closed by remote host"?
[11:14:50] <victorbarbu_>	 unfortunately, I am not a git/ssh expert myself... maybe tto will be more helpful
[11:15:26] <neeraj>	 no it is showing "ssh: connect to host github.com port 80: Connection refused"
[11:16:45] <tto>	 Hm, that's odd. Port 80 should be open, it's what you use to connect to HTTP
[11:17:24] <tto>	 There might be a problem with the network you are connected to. Some networks block certain kinds of traffic
[11:52:40] <wikibugs>	 10MediaWiki-Configuration, 5MW-1.27-release: Support $wgAction in extension registration - https://phabricator.wikimedia.org/T117197#1913245 (10Paladox) Oh ok thanks for finding that.
[11:55:23] <pranavk_>	 Nemo_bis: To add GENDER support to a message, can we just take the currently logged in user's gender, or should we pass the gender as a parameter to the message?
[11:59:19] <pranavk_>	 Or anyone? :)
[12:00:09] <pranavk_>	 If a message is already gender-neutral, how can we GENDERize it?
[12:01:40] <grrrit-wm>	 (03PS1) 10Georggi199: Import: Handle uploads with sha1 starting with 0 properly [core] - 10https://gerrit.wikimedia.org/r/262083 (https://phabricator.wikimedia.org/T65010) 
[12:03:13] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:03:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:05:05] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg* functions [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/262071 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:05:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/262071 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:05:44] <grrrit-wm>	 (03PS5) 10TTO: Replace language selection dropdown with ULS [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) (owner: 10Victorbarbu)
[12:06:36] <grrrit-wm>	 (03CR) 10TTO: [C: 032 V: 032] Replace language selection dropdown with ULS [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) (owner: 10Victorbarbu)
[12:07:03] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* functions (031 comment) [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262072 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:07:35] <grrrit-wm>	 (03PS2) 10TTO: Change methods in class AdminRights to be static [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/262080 (https://phabricator.wikimedia.org/T122761) (owner: 10Victorbarbu)
[12:07:59] <pranavk_>	 Can someone please help me with converting a message to support GENDER?
[12:08:06] <grrrit-wm>	 (03CR) 10TTO: [C: 032 V: 032] Change methods in class AdminRights to be static [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/262080 (https://phabricator.wikimedia.org/T122761) (owner: 10Victorbarbu)
[12:13:38] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* functions (033 comments) [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/262070 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:14:16] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* functions (031 comment) [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/262074 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[12:16:59] <tto>	 pranavk_: Which message?
[12:17:20] <pranavk_>	 tto: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Newsletter-notification-flyout/en
[12:17:30] <pranavk_>	 tto: and https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Newsletter-notification-title/uk
[12:18:12] <pranavk_>	 For the English one, it is already a gender-neutral sentence, and replacing the username with he/she would be vague
[12:18:40] <Nemo_bis>	 pranavk_: in the first case you only need the gender of the subject, which is not the current user, so you have to pass the username as parameter
[12:19:08] <Nemo_bis>	 same in the second
[12:19:20] <pranavk_>	 Yes, but how can I change the message?
[12:19:51] <pranavk_>	 Would I make it like this: "newsletter-notification-flyout": "$3 has {{GENDER:$3|announced}} a new issue of $1.", ?
[12:20:02] <Nemo_bis>	 yes
[12:20:16] <Nemo_bis>	 keeping in mind https://www.mediawiki.org/wiki/Manual:Messages_API#Notes_about_gender.2C_grammar.2C_plural
[12:20:24] <pranavk_>	 All right, and for Ukranian?
[12:20:25] <pranavk_>	 OK
[12:20:35] <Nemo_bis>	 You only work on en and qqq
[12:20:57] <pranavk_>	 Even for the uk message?
[12:21:18] <Nemo_bis>	 only translators edit translations
[12:21:20] <pranavk_>	 OH OK I get it!
[12:21:25] <pranavk_>	 Thanks!
[12:21:38] <Nemo_bis>	 your job is to give them the tools for a good translation
[12:21:57] <pranavk_>	 Got it! 
[12:22:06] <pranavk_>	 One q: 
[12:22:17] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/262084 (https://phabricator.wikimedia.org/T70750) 
[12:22:23] <pranavk_>	 In qqq, do I just add a line saying "Supports GENDER"?
[12:22:39] <pranavk_>	 Or is there a specific format I need to follow?
[12:23:32] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsgNoTrans() [extensions/Push] - 10https://gerrit.wikimedia.org/r/262085 (https://phabricator.wikimedia.org/T70750) 
[12:25:08] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsgNoTrans() [extensions/NaturalLanguageList] - 10https://gerrit.wikimedia.org/r/262086 (https://phabricator.wikimedia.org/T70750) 
[12:25:49] <Nemo_bis>	 pranavk_: as mentioned in https://www.mediawiki.org/wiki/Localisation#.E2.80.A6on_user_names_via_GENDER , the support is shown by the usage of GENDER in the English message
[12:26:02] <Nemo_bis>	 hehe FlorianSW exterminating wfMsg
[12:29:24] <FlorianSW>	 Nemo_bis: :P Reedy and I started to kill deprecated functiosn yesterday night, and it turns out, wfMsg* is one of the biggest ussages left :P
[12:33:28] <grrrit-wm>	 (03PS1) 10Purodha: Move empasis into message. [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/262087 
[12:33:49] <grrrit-wm>	 (03PS1) 10PranavK: Add GENDER support to two Newsletter messages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 
[12:37:02] <wikibugs>	 10MediaWiki-General-or-Unknown, 6Developer-Relations: Unclear maintenance responsibilities for some parts of MediaWiki core repository - https://phabricator.wikimedia.org/T115852#1913270 (10Nemo_bis)
[12:37:15] <pranavk_>	 Nemo_bis: https://gerrit.wikimedia.org/r/#/c/262088/
[12:37:20] <grrrit-wm>	 (03CR) 10Edokter: "So Blink has not implemented it yet, but they will; it already fully accepts the property and the value. Seriously, just add them, OR remo" [core] - 10https://gerrit.wikimedia.org/r/261723 (https://phabricator.wikimedia.org/T104541) (owner: 10Bartosz Dziewoński)
[12:46:04] <Georggi>	 bye guys
[12:53:28] <grrrit-wm>	 (03CR) 10Nemo bis: "Please link the TWN threads" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 (owner: 10PranavK)
[12:58:49] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/262090 (https://phabricator.wikimedia.org/T70750) 
[13:00:29] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove wfMsgNoTrans() [core] - 10https://gerrit.wikimedia.org/r/262091 (https://phabricator.wikimedia.org/T70750) 
[13:01:29] <grrrit-wm>	 (03CR) 10Edokter: "Relevant bugs:" [core] - 10https://gerrit.wikimedia.org/r/261723 (https://phabricator.wikimedia.org/T104541) (owner: 10Bartosz Dziewoński)
[13:02:10] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Depends on:" [core] - 10https://gerrit.wikimedia.org/r/262091 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:04:45] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/262084 (https://phabricator.wikimedia.org/T70750) 
[13:08:24] <grrrit-wm>	 (03PS2) 10PranavK: Add GENDER support to two Newsletter messages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 
[13:15:54] <grrrit-wm>	 (03CR) 10TTO: [C: 032] Import: Handle uploads with sha1 starting with 0 properly [core] - 10https://gerrit.wikimedia.org/r/262083 (https://phabricator.wikimedia.org/T65010) (owner: 10Georggi199)
[13:16:34] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove Linker::makeImageLink2 usage [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262092 (https://phabricator.wikimedia.org/T122754) 
[13:18:17] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove makeImageLink2 usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262093 (https://phabricator.wikimedia.org/T122754) 
[13:20:38] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove makeImageLink2 comment [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/262094 (https://phabricator.wikimedia.org/T122754) 
[13:21:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Import: Handle uploads with sha1 starting with 0 properly [core] - 10https://gerrit.wikimedia.org/r/262083 (https://phabricator.wikimedia.org/T65010) (owner: 10Georggi199)
[13:22:11] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove Linker::makeImageLink2 [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) 
[13:24:51] <wikibugs>	 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts: maintenance/importDump.php is unable to import files whose sha1 starts with 0 - https://phabricator.wikimedia.org/T65010#1913295 (10TTO) 5Open>3Resolved a:3Georggi199
[13:25:47] <wikibugs>	 10Spelling-Dictionary, 3Google-Code-In-2015, 5Patch-For-Review: Use ULS for language selection - https://phabricator.wikimedia.org/T87244#1913300 (10TTO) 5Open>3Resolved
[13:27:01] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/262096 (https://phabricator.wikimedia.org/T122754) 
[13:27:53] <grrrit-wm>	 (03CR) 10JadeMaveric: [C: 031] 18n: Reword some Wikidata/Wikibase system messages (Wikimedia) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric)
[13:28:00] <grrrit-wm>	 (03PS2) 10Nemo bis: I18n: Reword some Wikidata/Wikibase system messages (Wikimedia) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric)
[13:29:02] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/262097 (https://phabricator.wikimedia.org/T122754) 
[13:29:15] <grrrit-wm>	 (03CR) 10Nemo bis: "Please edit the commit message to link the TWN thread you are addressing" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric)
[13:29:58] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsgNoTrans() [extensions/Push] - 10https://gerrit.wikimedia.org/r/262085 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:30:05] <MtDu>	 Nemo_bis: Regarding your comment, Reedy was talking about that earlier. It would be great if I could get some tasks for the T70750 stuff. :)
[13:30:21] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsgNoTrans() [extensions/NaturalLanguageList] - 10https://gerrit.wikimedia.org/r/262086 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:30:24] <MtDu>	 FlorianSW: It's a fresh day. Time for some more patches. Thanks for your comments. 
[13:30:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsgNoTrans() [extensions/Push] - 10https://gerrit.wikimedia.org/r/262085 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:30:46] <grrrit-wm>	 (03PS2) 10TTO: Import: Try to stop revisions getting created with rev_page = 0 [core] - 10https://gerrit.wikimedia.org/r/262078 (https://phabricator.wikimedia.org/T18674) 
[13:30:55] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/262090 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:30:57] <FlorianSW>	 Reedy is awake! :D *yay* :P
[13:31:34] <Reedy>	 FlorianSW: I was still up at 04:30 my time I think :P
[13:32:13] <FlorianSW>	 I read some of your conversation about rebasing :P
[13:34:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsgNoTrans() [extensions/NaturalLanguageList] - 10https://gerrit.wikimedia.org/r/262086 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:34:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/262090 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[13:35:09] <MtDu>	 FlorianSW: For this, did you take a look at lines 193,197,202? 
[13:35:15] <MtDu>	 FlorianSW: Are they ok? 
[13:36:52] <MtDu>	 FlorianSW: Wait nvm. 
[13:37:19] <grrrit-wm>	 (03PS3) 10MtDu: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/262070 (https://phabricator.wikimedia.org/T70750) 
[13:40:22] <grrrit-wm>	 (03PS3) 10MtDu: Replace deprecated wfMsg* functions [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262072 (https://phabricator.wikimedia.org/T70750) 
[13:45:02] <grrrit-wm>	 (03CR) 10TTO: "The changes to WikiRevision::importLogItem made in Ic4463ab8d3a7b2779f43efb92cb790dbc1d88064 seem to have got lost in this commit :(" [core] - 10https://gerrit.wikimedia.org/r/261285 (https://phabricator.wikimedia.org/T122532) (owner: 10Neonowy)
[13:45:54] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913309 (10Tacsipacsi) 5Resolved>3Open This group was intended to maintain gadgets and other scripts, so we need the appropriate rights after starting "Gadgets 2.0"...
[13:47:20] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262098 (https://phabricator.wikimedia.org/T122754) 
[13:48:33] <MtDu>	 FlorianSW: FYI, this didn't come up on the chat. https://gerrit.wikimedia.org/r/#/c/262073/2 Other two are above. 
[13:48:51] <grrrit-wm>	 (03CR) 10Nemo bis: "Echo is annoying... https://www.mediawiki.org/w/index.php?title=Talk%3AEcho_%28Notifications%29%2FDeveloper_guide&type=revision&diff=20010" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 (owner: 10PranavK)
[13:51:33] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/262074 (https://phabricator.wikimedia.org/T70750) 
[13:53:52] <MtDu>	 Nemo_bis: To add gender to those messages, don't you have to pass another plain text username? I'm reading https://www.mediawiki.org/wiki/Manual:Messages_API#Notes_about_gender.2C_grammar.2C_plural
[13:55:47] <grrrit-wm>	 (03PS1) 10TTO: Restore changes to WikiRevision that were lost in cdeba4cfc7c [core] - 10https://gerrit.wikimedia.org/r/262099 
[13:56:07] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913315 (10JEumerus) Is there a consensus to add these other userrights? The discussion linked does not mention these additional userrights, only the ones in the alread...
[13:57:28] <grrrit-wm>	 (03CR) 10Nemo bis: "In EchoNewsletterPresentationModel and EchoEventPresentationModel I don't see anything that would pass the username as parameter nor set t" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 (owner: 10PranavK)
[13:59:46] <MtDu>	 Nemo_bis: Can you take a look at my above message? 
[14:03:54] <grrrit-wm>	 (03PS1) 10TTO: Refactor console reporting for importDump.php [core] - 10https://gerrit.wikimedia.org/r/262100 (https://phabricator.wikimedia.org/T121997) 
[14:04:09] <grrrit-wm>	 (03CR) 10Nemo bis: "i.e. https://translatewiki.net/wiki/Thread:Translating_talk:MediaWiki/About_MediaWiki:Logentry-massaction-jobfailed/en" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric)
[14:07:04] <grrrit-wm>	 (03PS1) 10MtDu: Add GENDER to talkpage and userpage messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 
[14:09:12] <Nemo_bis>	 MtDu: not "another", just one
[14:09:25] <MtDu>	 Nemo_bis: That's what I did. :)
[14:09:36] <MtDu>	 Nemo_bis: I was saying for the one's pranavk was doing. 
[14:09:53] <MtDu>	 Nemo_bis: And I'm pushing another patch. I think I added a stray colon
[14:09:54] <Nemo_bis>	 there is no direct message call there
[14:10:07] <MtDu>	 Nemo_bis: Gotcha.
[14:10:33] <grrrit-wm>	 (03PS2) 10MtDu: Add GENDER to talkpage and userpage messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 
[14:10:47] <MtDu>	 Nemo_bis: There you go. I'll close the threads. :)
[14:12:04] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913330 (10Tacsipacsi) Yes, there is. The linked discussion's first sentence ends with: "a szkripteket és segédeszközöket is", which means "also the scripts and gadgets...
[14:12:24] <grrrit-wm>	 (03CR) 10PranavK: "I haven't tested this, but when I used git grep for 'notification-flyout', 'flyout-message', 'notification-title', or 'title-message', I d" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 (owner: 10PranavK)
[14:15:28] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatched [wikimedia/wlm-api] - 10https://gerrit.wikimedia.org/r/262103 (https://phabricator.wikimedia.org/T122754) 
[14:15:47] <MtDu>	 Nemo_bis: And can you and Reedy talk about what to do with the T70750 stuff I did? I think Unicornisaurous did more than one? (Not sure). Communicate with me through GCI. I posted a comment on my task for you there. Thanks! :)
[14:17:00] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatched [skins/Synagonism] - 10https://gerrit.wikimedia.org/r/262104 (https://phabricator.wikimedia.org/T122754) 
[14:17:39] <grrrit-wm>	 (03CR) 10PranavK: "I just tested it, and it works (the username shows up properly)." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 (owner: 10PranavK)
[14:18:42] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] Remove Linker::makeImageLink2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[14:20:15] <grrrit-wm>	 (03CR) 10Nemo bis: "The point of adding (explicit) GENDER support is that the developer verifies, on behalf of the translator, that GENDER actually works. If " [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/262088 (owner: 10PranavK)
[14:22:56] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/262106 (https://phabricator.wikimedia.org/T122754) 
[14:24:35] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 04-1] "The first line should summarise the entire changeset https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 (owner: 10MtDu)
[14:27:00] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userisWatching [skins/webplatform] - 10https://gerrit.wikimedia.org/r/262107 (https://phabricator.wikimedia.org/T122754) 
[14:27:57] <Reedy>	 FlorianSW: Have we finished with wfMsg*()? :P
[14:28:06] <grrrit-wm>	 (03PS3) 10MtDu: Add GENDER to reword a few messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 
[14:28:53] <Nemo_bis>	 Reedy: sounds unlikely :)
[14:29:08] <grrrit-wm>	 (03PS4) 10MtDu: Add GENDER to and reword a few messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 
[14:29:17] <Reedy>	 I posted an updated list last night which included some of the large patches that weren't merged yet
[14:29:36] <Nemo_bis>	 Reedy: were https://gerrit.wikimedia.org/r/#/q/owner:justin.d128+message:wfMsg,n,z used for some task yet?
[14:29:41] <wikibugs>	 10MediaWiki-extensions-ORES, 6RevisionScoringAsAService: ORES "r" flag doesn't work when grouping in recent changes is disabled - https://phabricator.wikimedia.org/T122766#1913337 (10Ladsgroup) 3NEW
[14:29:47] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/262109 (https://phabricator.wikimedia.org/T122754) 
[14:30:12] <Reedy>	 Nemo_bis: I didn't do anything on the GCI side yet, but the intention was to do so if we could
[14:30:32] <FlorianSW>	 Reedy: haha :P Not really, no :D But it takes a lot of time and "brain work" to do this, so I give myself a break :)
[14:30:45] <Reedy>	 easy deprecations instead? ;)
[14:30:46] <FlorianSW>	 But: as far as I can tell, I finished any wfMsgNoTrans :P
[14:30:53] <FlorianSW>	 Reedy: yep :D
[14:31:23] <Reedy>	 Need to get all those outstanding patches merged... Update my clones again and see what sort of state we're in
[14:31:38] <victorbarbu_>	 guys
[14:31:44] <victorbarbu_>	 are you familiar with tgr?
[14:31:51] <Reedy>	 Familiar how?
[14:31:54] <Reedy>	 I know him AFK :)
[14:31:59] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace deprecated wfMsg* functions [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/262074 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[14:32:17] <victorbarbu_>	 familiar = ever heard of him, ever talked to him
[14:32:29] <victorbarbu_>	 he's my mentor for a task, but I see he's away
[14:32:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/CreditTab] - 10https://gerrit.wikimedia.org/r/262074 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[14:32:54] <Reedy>	 It's the holidays for a lot of people, so it's not a surprise :)
[14:33:12] <victorbarbu_>	 yep, true
[14:33:28] <ananayarora>	 Nemo_bis: Translations to this language in this group have been disabled.
[14:33:30] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace deprecated wfMsg* functions [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262072 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[14:33:39] <ananayarora>	 I get this when I try to translate the page
[14:33:57] <ananayarora>	 Nemo_bis: https://www.mediawiki.org/wiki/Manual:$wgUseEAccelShm Here's the page 
[14:34:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262072 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[14:34:22] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/262070 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[14:34:27] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/262110 (https://phabricator.wikimedia.org/T122754) 
[14:34:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/262070 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[14:35:19] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/262109 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[14:35:48] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* and friends [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262057 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[14:36:00] <FlorianSW>	 victorbarbu_: I already talked to him iirc, so: yes, he's a real person ;)
[14:36:29] <victorbarbu_>	 FlorianSW, I had no doubt about that
[14:36:37] <victorbarbu_>	 I know he's the guy with UI or something
[14:37:16] <Reedy>	 He's a multimedia guy
[14:37:28] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace Title::userIsWatching [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/262111 (https://phabricator.wikimedia.org/T122754) 
[14:37:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/262109 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[14:37:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* and friends [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262057 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[14:37:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace some wfMsg* calls [extensions/ImageLink] - 10https://gerrit.wikimedia.org/r/262058 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[14:38:16] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/262084 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[14:38:31] <victorbarbu_>	 guys, off topic
[14:38:41] <victorbarbu_>	 I created a vagrant vm
[14:38:50] <victorbarbu_>	 and I have it in /devenv/1/
[14:39:16] <victorbarbu_>	 I enabled shared folder : host = /devenv/1/config/nginx/, guest = /etc/nginx
[14:39:34] <victorbarbu_>	 I opened the file at /devenv/1/config/nginx/sites-enabled/default
[14:39:51] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Remove Linker::makeImageLink2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[14:39:54] <FlorianSW>	 Reedy: ^
[14:40:01] <victorbarbu_>	 it has the exact same contents as the config file on my host
[14:40:11] <victorbarbu_>	 I mean, as the server installed on my host
[14:40:14] <ananayarora>	 victorbarbu_: Are you a mentor?
[14:40:20] <victorbarbu_>	 nope
[14:40:22] <victorbarbu_>	 but the file in vagrant is different
[14:40:26] <victorbarbu_>	 how is this possible?
[14:41:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Ratings] - 10https://gerrit.wikimedia.org/r/262084 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[14:41:11] <grrrit-wm>	 (03CR) 10Reedy: Remove Linker::makeImageLink2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[14:43:35] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Title::userIsWatching was removed [core] - 10https://gerrit.wikimedia.org/r/262112 (https://phabricator.wikimedia.org/T122754) 
[14:49:16] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913360 (10Luke081515) 5Open>3stalled I think we can stall this, till we have Gadgets 2.0 at that wiki. Before that, no one should have these rights.
[14:50:26] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913362 (10Tacsipacsi) OK, so I don't have to start another discussion?
[14:51:51] <MtDu>	 Nemo_bis: Thanks for the comment. I'll do that after I finish this task. 
[14:52:25] <MtDu>	 Nemo_bis: I uploaded a new patch for the Timeless task I'm doing, but it still has a -1 for code review from you. Could you take a look again? 
[14:57:05] <ananayarora>	 Nemo_bis: https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-Manual%3A%24wgUseEAccelShm&language=en&action=page&filter=
[14:58:21] <Nemo_bis>	 ananayarora: "English is the source language. "
[14:58:32] <Nemo_bis>	 ananayarora: you have to select your target language in the top-right
[14:59:25] <ananayarora>	 Nemo_bis: Oh. Okay. Sorry, I'm a noob :$ 
[14:59:34] <ananayarora>	 with this stuff
[15:01:43] <grrrit-wm>	 (03CR) 10Nemo bis: Add GENDER to and reword a few messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 (owner: 10MtDu)
[15:03:24] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 04-1] Add GENDER to and reword a few messages (031 comment) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 (owner: 10MtDu)
[15:03:53] <MtDu>	 Nemo_bis: Wow. I'm stupid. :p
[15:04:00] <MtDu>	 Nemo_bis: I went and googled it. 
[15:04:25] <ananayarora>	 Nemo_bis: Where do I get the translated stuff from ? I've chosen françias as the language
[15:04:32] <Nemo_bis>	 You're only proving the need for a patch ;)
[15:04:52] <Nemo_bis>	 ananayarora: see number 3 bullet 1 https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list#Google_Code-in_task_description
[15:05:29] <Nemo_bis>	 ananayarora: but someone else already did that page, choose another https://www.mediawiki.org/w/index.php?title=Manual:$wgUseEAccelShm/fr&action=history
[15:06:09] <MtDu>	 Nemo_bis: So what abut the y in WMFy? 
[15:06:45] <Nemo_bis>	 MtDu: https://en.wiktionary.org/wiki/-y#Suffix
[15:07:42] <Nemo_bis>	 Finally we went under 200 but I'd hope for GCI to close at least 100 more https://translatewiki.net/wiki/Category:Open_support_requests_for_MediaWiki
[15:07:59] <grrrit-wm>	 (03PS5) 10MtDu: Add GENDER to and reword a few messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 
[15:08:17] <MtDu>	 Nemo_bis: I think that should fix it. :)
[15:09:04] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 04-1] "-y is jargon too, just use "styles by the Wikimedia Foundation"" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 (owner: 10MtDu)
[15:09:17] <Nemo_bis>	 MtDu: use some imagination!
[15:10:32] <MtDu>	 Nemo_bis: I just saw the examples on the page you sent me and went with it. 
[15:10:42] <MtDu>	 Nemo_bis: Sorry. I'll be sure to keep that in mind. :)
[15:11:50] <grrrit-wm>	 (03PS6) 10MtDu: Add GENDER to and reword a few messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 
[15:12:42] <MtDu>	 Nemo_bis:^
[15:15:45] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7I18n: [[MediaWiki:Wikibase-rc-hide-wikidata/en]] i18n issue - https://phabricator.wikimedia.org/T122762#1913365 (10Nemo_bis)
[15:16:04] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7I18n: [[MediaWiki:Wikibase-rc-hide-wikidata/en]] i18n issue - https://phabricator.wikimedia.org/T122762#1913367 (10Nemo_bis) p:5Triage>3Normal
[15:17:13] <Reedy>	 FlorianSW: 
[15:17:14] <Reedy>	 -rw-rw-r-- 1 reedy reedy  84689 Jan  3 15:16 wfmsg2.txt
[15:17:15] <Reedy>	 -rw-rw-r-- 1 reedy reedy 135323 Jan  3 02:51 wfmsg.txt
[15:17:19] <Reedy>	 That's quite a lot removed!
[15:17:50] <wikibugs>	 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 20 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1913368 (10Reedy) `...
[15:18:16] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] Add GENDER to and reword a few messages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/262101 (owner: 10MtDu)
[15:18:27] <MtDu>	 Nemo_bis: Do you want me to submit it now? 
[15:19:14] <FlorianSW>	 Reedy: yay :D
[15:19:53] <Reedy>	 I think that's my checkout up to date :P
[15:19:55] <Nemo_bis>	 MtDu: ok
[15:20:18] <MtDu>	 Nemo_bis: Submitted. :)
[15:20:22] <Nemo_bis>	 Reedy: are you updating the task?
[15:20:29] <Reedy>	 Which task?
[15:20:41] <MtDu>	 The internationalism of the functions one, I suppose? 
[15:20:47] <Nemo_bis>	 Reedy: https://phabricator.wikimedia.org/T70750
[15:20:56] <Reedy>	 I just did :P
[15:21:30] <FlorianSW>	 hmm, this change looks abandoned? :( https://gerrit.wikimedia.org/r/#/c/183473/5
[15:21:30] <Nemo_bis>	 Reedy: can you review https://gerrit.wikimedia.org/r/#/c/261948/
[15:22:57] <MtDu>	 Nemo_bis: Do you want me to just submit the internationalism tasks? Do I need to add the links, or can you just look at my page since all of them are merged? 
[15:23:20] <Nemo_bis>	 Reedy: 72 extensions left? :(
[15:24:00] <MtDu>	 Nemo_bis: We can do it! I can do some more if needed. 
[15:24:03] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Converted GoogleNewsSitemap to new extension registration (031 comment) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[15:24:31] <Nemo_bis>	 MtDu: at least one-way links please
[15:24:44] <MtDu>	 Nemo_bis: What do you mean? 
[15:24:57] <Nemo_bis>	 well nevermind, I can count
[15:25:08] <FlorianSW>	 Reedy: I think the changes, which aren't merged yet, aren't in your list anymore, right?
[15:25:23] <Reedy>	 Which aren't merged?
[15:25:41] <grrrit-wm>	 (03PS3) 10JadeMaveric: 18n: Reword some Wikidata/Wikibase system messages (Wikimedia) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 
[15:26:08] <MtDu>	 Nemo_bis: I just submitted the 2nd one. :)
[15:26:19] <mhutti1>	 FlorianSW: What dyoo you mean by an option in extension registration?
[15:26:29] <FlorianSW>	 Reedy: :O You already merged them all? :D
[15:26:43] <Reedy>	 I thoguht so...
[15:27:37] <FlorianSW>	 mhutti1: FeedClasses is actually in the config option, which means, that it's a config of this extension. But wgFeedClasses is a mediawiki core config option and should therefore be set in the same level as AutoloadClasses, I think (maybe this would need a change in extension registration)
[15:27:42] <MtDu>	 Nemo_bis: For the 3rd one, does that mean 10 total, or 10 more on top of that? 
[15:28:16] <mhutti1>	 FlorianSW: So should I wait for lego to clarify?
[15:28:25] <FlorianSW>	 mhutti1: yep :)
[15:28:27] <Reedy>	 Isn't it setting a merge strategy?
[15:28:46] <FlorianSW>	 I haven't looked into it :P
[15:29:00] <Nemo_bis>	 MtDu: 10 more
[15:29:24] <Nemo_bis>	 MtDu: so you need 4 more than you did
[15:29:28] <MtDu>	 Nemo_bis: Gotcha. 
[15:29:36] <Nemo_bis>	 the next is 15 more
[15:29:40] <MtDu>	 Nemo_bis: I guess I'll go ahead and do it since I'm already halfway. 
[15:29:49] <Nemo_bis>	 that's the idea :p
[15:30:09] <MtDu>	 Nemo_bis: Man. So many tasks. I want to take a shot at the translation ones soon. :p
[15:32:34] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) 
[15:33:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:33:23] <MtDu>	 Nemo_bis: I'll do another GENDER one first. 
[15:33:51] <grrrit-wm>	 (03PS1) 10JadeMaveric: 18n: Reword some Wikidata/Wikibase system messages (Wikimedia) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/262114 
[15:34:14] <grrrit-wm>	 (03CR) 10Raimond Spekking: Implement skip-to links and importing mediawiki.stateful-classes.less (032 comments) [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/237870 (https://phabricator.wikimedia.org/T112308) (owner: 10VolkerE)
[15:34:40] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/262115 (https://phabricator.wikimedia.org/T70750) 
[15:34:42] <grrrit-wm>	 (03CR) 10Nemo bis: "Who is eating your "i" in "I18n"? :) vim?" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/262114 (owner: 10JadeMaveric)
[15:36:06] <grrrit-wm>	 (03CR) 10JadeMaveric: "Done. (But I've got the end of line space at the end.)" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric)
[15:36:08] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/262116 (https://phabricator.wikimedia.org/T70750) 
[15:36:58] <grrrit-wm>	 (03PS1) 10MtDu: Clarify case sensitivity in stats-table-case message [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/262117 
[15:37:56] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/PdfBook] - 10https://gerrit.wikimedia.org/r/262118 (https://phabricator.wikimedia.org/T70750) 
[15:39:20] <grrrit-wm>	 (03PS1) 10MtDu: Add GENDER support to welcome message [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/262119 
[15:39:43] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace misleading wfMsg* comment [extensions/RSS] - 10https://gerrit.wikimedia.org/r/262120 (https://phabricator.wikimedia.org/T70750) 
[15:40:34] <wikibugs>	 10Wikimedia-Extension-setup: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1913374 (10Dave_Braunschweig) Yes, that resolves this issue.  I took the code and put it into a different template: https://en.wikiversity.org/wiki/Template:Review_question  This version wraps the r...
[15:45:34] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/262121 (https://phabricator.wikimedia.org/T70750) 
[15:46:12] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Hmm, I don't plan to fix these missing docs :/" [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:52:10] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/HTMLets] - 10https://gerrit.wikimedia.org/r/262122 (https://phabricator.wikimedia.org/T70750) 
[15:53:27] <grrrit-wm>	 (03PS2) 10JadeMaveric: i18n: Reword some Wikidata/Wikibase system messages (Wikimedia) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/262114 
[15:54:00] <grrrit-wm>	 (03CR) 10Paladox: [C: 032 V: 032] "Thanks." [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:54:20] <grrrit-wm>	 (03CR) 10Paladox: Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:54:35] <grrrit-wm>	 (03CR) 10Paladox: [C: 032 V: 032] Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:54:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:54:49] <grrrit-wm>	 (03CR) 10JadeMaveric: "You sound like my English teacher. So yeah, my 'vim' ate my 'i'. XD. But now I've got two patches addressing the same problem. (This one's" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/262114 (owner: 10JadeMaveric)
[15:54:53] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/262123 (https://phabricator.wikimedia.org/T70750) 
[15:55:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[15:56:29] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262124 (https://phabricator.wikimedia.org/T70750) 
[15:57:16] <grrrit-wm>	 (03CR) 10MtDu: "I'm not done yet. Will push another patch later." [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/262117 (owner: 10MtDu)
[15:58:08] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/262125 (https://phabricator.wikimedia.org/T70750) 
[15:59:42] <grrrit-wm>	 (03PS1) 10Paladox: Disable banana checker, Update package [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262126 
[16:00:25] <grrrit-wm>	 (03CR) 10Paladox: [C: 032] Disable banana checker, Update package [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262126 (owner: 10Paladox)
[16:00:28] <wikibugs>	 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1913380 (10RobLa-WMF) >>! In T114419#1906664, @JanZerebecki wrote: >>>! In T114419#1905752, @RobLa-WMF wrote: >> Both [deployments on weekends that take down the site] and [user-invisi...
[16:01:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable banana checker, Update package [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262126 (owner: 10Paladox)
[16:01:19] <grrrit-wm>	 (03PS2) 10Paladox: Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[16:01:41] <grrrit-wm>	 (03PS2) 10Paladox: Use __METHOD__ for DB begin/commit calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/261744 (owner: 10Aaron Schulz)
[16:02:05] <grrrit-wm>	 (03CR) 10Paladox: Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[16:02:13] <grrrit-wm>	 (03CR) 10Paladox: [C: 032] Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[16:02:31] <grrrit-wm>	 (03CR) 10Paladox: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/261744 (owner: 10Aaron Schulz)
[16:02:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/262113 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[16:03:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/Reflect] - 10https://gerrit.wikimedia.org/r/261744 (owner: 10Aaron Schulz)
[16:04:25] <grrrit-wm>	 (03CR) 10Nemo bis: "See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric)
[16:08:18] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/ArticleComments] - 10https://gerrit.wikimedia.org/r/262127 (https://phabricator.wikimedia.org/T70750) 
[16:09:27] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/YetAnotherKeywords] - 10https://gerrit.wikimedia.org/r/262128 (https://phabricator.wikimedia.org/T70750) 
[16:10:02] <grrrit-wm>	 (03PS1) 10Tacsipacsi: Add GENDER support for log abd status messages. [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/262129 
[16:10:42] <grrrit-wm>	 (03PS2) 10Tacsipacsi: Add GENDER support for log and status messages. [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/262129 
[16:10:54] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfmsg* calls [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/262130 (https://phabricator.wikimedia.org/T70750) 
[16:16:32] <unicornisaurous>	 Nemo_bis: So the task you linked me to on GCI isn’t the same thing as the wfMsg fixes, right? Its just “pick any 3 i18n tasks”
[16:16:32] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262133 (https://phabricator.wikimedia.org/T70750) 
[16:17:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262133 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[16:17:11] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913387 (10Luke081515) If you want these rights, you have to, because we need a community descision every time. But I don't know, who gets this rights you mentioned abo...
[16:18:07] <wikibugs>	 10Wikimedia-Site-Requests, 5Patch-For-Review: Create interface-editor group on Hungarian Wikipedia - https://phabricator.wikimedia.org/T109408#1913388 (10Luke081515) 5stalled>3Resolved (But I will close this task, because the original task is resolved, and this is a case for a new task, when gadgets 2.0 is...
[16:19:27] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/262134 (https://phabricator.wikimedia.org/T70750) 
[16:20:36] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/262135 (https://phabricator.wikimedia.org/T70750) 
[16:30:17] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262133 (https://phabricator.wikimedia.org/T70750) 
[16:31:42] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/262138 (https://phabricator.wikimedia.org/T70750) 
[16:34:35] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/262139 (https://phabricator.wikimedia.org/T70750) 
[16:35:36] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Offline] - 10https://gerrit.wikimedia.org/r/262140 (https://phabricator.wikimedia.org/T70750) 
[16:36:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/Offline] - 10https://gerrit.wikimedia.org/r/262140 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[16:38:44] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/262141 (https://phabricator.wikimedia.org/T70750) 
[16:39:43] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert edit page to use OOUI - https://phabricator.wikimedia.org/T120736#1913397 (10Dvorapa)
[16:39:52] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913398 (10Dvorapa) 3NEW
[16:40:00] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913398 (10Dvorapa)
[16:40:05] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/262142 (https://phabricator.wikimedia.org/T70750) 
[16:40:08] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert edit page to use OOUI - https://phabricator.wikimedia.org/T120736#1860336 (10Dvorapa)
[16:42:11] <Nemo_bis>	 unicornisaurous: yes; I also created another one of wfmsg though
[16:42:27] <Nemo_bis>	 unicornisaurous: except I feel FlorianSW will you beat you all at that :D 
[16:42:38] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/262143 (https://phabricator.wikimedia.org/T70750) 
[16:43:43] <FlorianSW>	 I got only the half, just from feeling, so there's enough work to be done :O
[16:43:46] <FlorianSW>	 * :P
[16:43:50] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913411 (10Dvorapa)
[16:43:53] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Replace use of jQuery UI and MW UI with OOjs UI across all Wikimedia-deployed extensions and core - https://phabricator.wikimedia.org/T100270#1913410 (10Dvorapa)
[16:44:09] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913398 (10Dvorapa)
[16:44:12] <wikibugs>	 10UI-Standardization, 7Epic: Convert all of MediaWiki core to OOUI PHP (tracking) - https://phabricator.wikimedia.org/T100161#1913412 (10Dvorapa)
[16:44:22] <wikibugs>	 10UI-Standardization: Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OO UI FormSpecialPage or explicit OO UI PHP - https://phabricator.wikimedia.org/T101471#1913415 (10Dvorapa)
[16:44:23] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913398 (10Dvorapa)
[16:45:19] <grrrit-wm>	 (03CR) 10Umherirrender: "With this new function inside the LogEntry the connection between logs and revisions get stronger." [core] - 10https://gerrit.wikimedia.org/r/261314 (https://phabricator.wikimedia.org/T122089) (owner: 10Bartosz Dziewoński)
[16:47:05] <grrrit-wm>	 (03Abandoned) 10Umherirrender: Remove APCOND_FR_NEVERDEMOTED [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261118 (owner: 10Umherirrender)
[16:48:35] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913419 (10Dvorapa)
[16:48:38] <wikibugs>	 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1913418 (10Dvorapa)
[16:50:22] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913398 (10Dvorapa)
[16:50:24] <wikibugs>	 10UI-Standardization: Convert Special:Preferences to OOUI - https://phabricator.wikimedia.org/T117781#1913421 (10Dvorapa)
[16:50:57] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/262144 (https://phabricator.wikimedia.org/T70750) 
[16:50:58] <FlorianSW>	 ^ that's a beast!
[16:52:25] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Comments] - 10https://gerrit.wikimedia.org/r/262145 (https://phabricator.wikimedia.org/T70750) 
[16:53:28] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Loops] - 10https://gerrit.wikimedia.org/r/262146 (https://phabricator.wikimedia.org/T70750) 
[16:53:35] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to OOUI - https://phabricator.wikimedia.org/T117781#1913426 (10Dvorapa)
[16:55:03] <unicornisaurous>	 All of the gerrit homepage is FlorianSW 
[16:56:24] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to OOUI - https://phabricator.wikimedia.org/T117781#1913429 (10Dvorapa)
[16:56:26] <wikibugs>	 10UI-Standardization, 7Epic: Convert all of MediaWiki core to OOUI PHP (tracking) - https://phabricator.wikimedia.org/T100161#1913428 (10Dvorapa)
[16:56:52] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/OpenStreetMapSlippyMap] - 10https://gerrit.wikimedia.org/r/262147 (https://phabricator.wikimedia.org/T70750) 
[16:59:10] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace misleading wfMsg* comment [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/262148 (https://phabricator.wikimedia.org/T70750) 
[16:59:21] <MtDu>	 Nemo_bis: For this, https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Phalanx-stats-table-case/sv, I don't think Case sensitive makes sense. Should it be something like Case (sensitive)? 
[17:00:05] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Create CSS-only version of OOjs UI - https://phabricator.wikimedia.org/T120749#1913433 (10Dvorapa)
[17:03:16] <grrrit-wm>	 (03PS2) 10MtDu: Clarify case sensitivity in stats-table-case message [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/262117 
[17:05:18] <grrrit-wm>	 (03PS5) 10Martineznovo: [WIP] Various fixes to grabNewText.php [tools/grabbers] - 10https://gerrit.wikimedia.org/r/236429 
[17:07:19] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262149 (https://phabricator.wikimedia.org/T70750) 
[17:08:11] * FlorianSW needs a break
[17:08:20] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913436 (10NiharikaKohli) Hi @josephine_l, yup, task description gives you a ping as well. I believe the delay in response is due to the holid...
[17:08:58] <wikibugs>	 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 20 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.18 (notices in 1.21) - https://phabricator.wikimedia.org/T70750#1913437 (10Florian)...
[17:10:19] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "recheck" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/262140 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[17:11:08] <Georggi>	 Hi unicornisaurous
[17:11:13] <unicornisaurous>	 hello
[17:11:17] <Georggi>	 Is this task claimed by you? https://codein.withgoogle.com/tasks/5520672822394880/?sp-status=2&sp-is_exhausted=False&sp-page=1
[17:11:17] <gcibot>	 Write a unit test to check MediaWiki's handling of unknown XML tags in import dumps || 3 days || Code, QA || Wikimedia
[17:11:32] <unicornisaurous>	 Ehhhhhhhhh
[17:11:34] <unicornisaurous>	 no
[17:11:36] <unicornisaurous>	 why
[17:11:41] <Georggi>	 ?
[17:11:52] <unicornisaurous>	 I don’t have it claimed
[17:11:56] <unicornisaurous>	 its on my list though
[17:11:59] <unicornisaurous>	 but you can take it
[17:12:02] <unicornisaurous>	 why do you ask?
[17:12:14] <Georggi>	 Well I've seen that you are subscriber:D
[17:12:27] <unicornisaurous>	 Oh well thats how I remember tasks I want to do
[17:12:40] <unicornisaurous>	 It must’ve just gotten publichsed
[17:12:44] <unicornisaurous>	 *published
[17:13:12] <Georggi>	 Did you see that recent comment on one of your patches from tto?
[17:13:26] <unicornisaurous>	 Yeah
[17:13:43] <Georggi>	 $options is also not defined:)
[17:13:57] <Georggi>	 I kind of found it:)
[17:14:28] <unicornisaurous>	 Thanks
[17:14:51] <unicornisaurous>	 Obviously neither TTO nor I tested the pagelist portion of the code
[17:15:26] <Georggi>	 I got some errors in my test for my task, so that's why I found it
[17:15:38] <unicornisaurous>	 Whats your task?
[17:15:44] <wikibugs>	 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add screenshots to extension and skin infoboxes on mediawiki.org - https://phabricator.wikimedia.org/T121332#1913438 (10NiharikaKohli) 5Open>3Resolved >>! In T121332#1912015, @ananayarora wrote: > I've added the screenshot for the 'Dusk' sk...
[17:17:20] <wikibugs>	 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1913440 (10RobLa-WMF) >>! In T114419#1907952, @matmarex wrote: > If we hypothetically were to remove mandatory code review, I think we should make reverting problematic changes less of...
[17:19:32] <grrrit-wm>	 (03CR) 10Unicornisaurous: "I'll fix this later today" [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous)
[17:23:08] <victorbarbu_>	 guys
[17:23:37] <victorbarbu_>	 can anyone give me any clue about "?curid"?
[17:27:44] <wikibugs>	 10MediaWiki-Installer, 10MediaWiki-extensions-SemanticForms, 7Composer, 5Patch-For-Review: CLI installer failure: Could not insert main page: Invalid callback SFFormUtils::purgeCache in hooks for ArticleSave - https://phabricator.wikimedia.org/T121322#1913442 (10Paladox) I doint think it is related to comp...
[17:28:01] <wikibugs>	 10MediaWiki-Installer, 10MediaWiki-extensions-SemanticForms, 7Composer, 5Patch-For-Review: CLI installer failure: Could not insert main page: Invalid callback SFFormUtils::purgeCache in hooks for ArticleSave - https://phabricator.wikimedia.org/T121322#1913443 (10Paladox) @saper could you test my patch I up...
[17:30:18] <Georggi>	 unicornisaurous, it was a small one to fix handling of sha1 in uploads
[17:30:54] <unicornisaurous>	 Oh ok. I’m surprised you had to use pagelist for that, but its a good thing you did!
[17:31:57] <Vulpix>	 victorbarbu_: "curid" in URLs usually mean "current revision ID", the revision id of the page being displayed. It should be the rev_id field of the revision table
[17:32:29] <Georggi>	 I actually didnt, but at first testing command had pagelist
[17:35:46] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Create CSS-only version of OOjs UI - https://phabricator.wikimedia.org/T120749#1913446 (10Jdforrester-WMF) I'm not sure this makes sense as something we could deliver. The whole point of OOUI is to abstract the DOM representation into a constructor; applying random CSS...
[17:43:57] <victorbarbu_>	 where can I browse the core repo online?
[17:44:27] <mhutti1>	 github
[17:44:51] <unicornisaurous>	 github is a good choice. there used to be a viewer elsewhere but it seems to be either down or I can’t find it
[17:45:02] <victorbarbu_>	 I can only find core-vendor
[17:45:03] <victorbarbu_>	 there
[17:45:06] <victorbarbu_>	 not core
[17:45:15] <unicornisaurous>	 https://github.com/wikimedia/mediawiki
[17:46:48] <Vulpix>	 phabricator has all repositories also. Core is in https://phabricator.wikimedia.org/diffusion/MW/
[17:46:49] <victorbarbu_>	 nvm
[17:46:50] <victorbarbu_>	 found it
[17:49:12] <victorbarbu_>	 thx unicornisaurous 
[17:58:09] <wikibugs>	 10MediaWiki-General-or-Unknown, 10MediaWiki-ResourceLoader, 6Language-Engineering: momentjs does not support zh zh-hans zh-hant? - https://phabricator.wikimedia.org/T122768#1913448 (10Zoglun) 3NEW
[17:59:41] <wikibugs>	 6Phabricator: Enable notification server (real-time pop-up notifications) in Phabricator - https://phabricator.wikimedia.org/T765#1913456 (10Luke081515) What's the status?
[18:06:55] <grrrit-wm>	 (03PS1) 10Aude: Remove unused, deprecated ChangesList::usePatrol [core] - 10https://gerrit.wikimedia.org/r/262153 
[18:15:24] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Create CSS-only version of OOjs UI - https://phabricator.wikimedia.org/T120749#1913460 (10Dvorapa) >>! In T120749#1913446, @Jdforrester-WMF wrote: > I'm not sure this makes sense as something we could deliver. The whole point of OOUI is to abstract the DOM representati...
[18:17:13] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262155 (https://phabricator.wikimedia.org/T70750) 
[18:20:25] <wikibugs>	 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1913464 (10RobLa-WMF) One other point: the bold, revert, discuss (BRD) cycle on code only works well when the "revert" step is done quickly.  The dangerous thing behind relying on BRD...
[18:20:25] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/262157 (https://phabricator.wikimedia.org/T70750) 
[18:29:35] <grrrit-wm>	 (03CR) 10Nemo bis: Clarify case sensitivity in stats-table-case message (031 comment) [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/262117 (owner: 10MtDu)
[18:30:36] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/262158 (https://phabricator.wikimedia.org/T70750) 
[18:31:23] <dg711>	 Hi there ,
[18:31:23] <dg711>	 I've been trying to set up mediawiki-vagrant on my machine . But Vagrant crashes everytime .
[18:31:23] <dg711>	 It says that vagrant home directory address has spaces.
[18:31:23] <dg711>	 But I've installed vagrant at  C:\HashiCorp\Vagrant .
[18:31:23] <dg711>	 and cloned medaiwiki-vagrant at C:/myMediawiki/vagrant
[18:31:24] <dg711>	 Need help for troubleshooting.
[18:31:41] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Create CSS-only version of OOjs UI - https://phabricator.wikimedia.org/T120749#1913467 (10Jdforrester-WMF) >>! In T120749#1913460, @Dvorapa wrote: >>>! In T120749#1913446, @Jdforrester-WMF wrote: >> I'm not sure this makes sense as something we could deliver. The whole...
[18:31:53] <dg711>	 screenshot :https://drive.google.com/file/d/0B5mFX46GRIoIZS1vWU9aaE8zdUtXdHlWZ2RNUGRNXzNVcWhR/view?usp=sharing
[18:31:57] <dg711>	 https://drive.google.com/file/d/0B5mFX46GRIoIZS1vWU9aaE8zdUtXdHlWZ2RNUGRNXzNVcWhR/view?usp=sharing
[18:32:42] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "+1/-1 Needs RELEASE-NOTES :)" [core] - 10https://gerrit.wikimedia.org/r/262153 (owner: 10Aude)
[18:33:36] <Reedy>	 FlorianSW: Oh noes, aude is cutting in on our game!
[18:33:41] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/262159 (https://phabricator.wikimedia.org/T70750) 
[18:34:31] <FlorianSW>	 Reedy: hehe :D
[18:35:36] <aude>	 :)
[18:36:21] <Reedy>	 Maybe we can persuade her to do some CR too ;)
[18:37:06] <grrrit-wm>	 (03PS2) 10Aude: Remove unused, deprecated ChangesList::usePatrol [core] - 10https://gerrit.wikimedia.org/r/262153 
[18:37:12] <aude>	 :D
[18:37:52] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "Needs rebase too. Lol" [core] - 10https://gerrit.wikimedia.org/r/262153 (owner: 10Aude)
[18:37:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove unused, deprecated ChangesList::usePatrol [core] - 10https://gerrit.wikimedia.org/r/262153 (owner: 10Aude)
[18:38:31] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/262111 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[18:38:46] <Reedy>	 aude: There's a load of wfMsg*() conversions to review... And easier stuff like that one above that I'm just starting on
[18:40:03] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/262161 (https://phabricator.wikimedia.org/T70750) 
[18:42:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/262111 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[18:42:57] <grrrit-wm>	 (03CR) 10Aude: [C: 04-1] "appears still used in some extensions, such as LiquidThreads (is that still deployed?)" [core] - 10https://gerrit.wikimedia.org/r/262112 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[18:43:25] <Reedy>	 aude: There's commits for removing those outstanding too :)
[18:43:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/262161 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[18:43:32] <Reedy>	 I just merged the LQT one
[18:43:32] <aude>	 ah, i see 
[18:43:41] <aude>	 -1 until those are merged
[18:43:51] <aude>	 and maybe mention them in the commit message
[18:43:52] <Reedy>	 Aye :)
[18:44:18] <Reedy>	 It's a bit harder for the wfMsg ones which are used in a tonne of places and create a tonne of dependancies :)
[18:44:52] <Nemo_bis>	 victorbarbu_: re https://phabricator.wikimedia.org/T122439 , the task is to make the code at https://gerrit.wikimedia.org/r/#/c/260955/6/resources/mmv/mmv.EmbedFileFormatter.js,cm work
[18:44:57] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Remove not used private member variable mParserWarnings from OutputPage [core] - 10https://gerrit.wikimedia.org/r/262056 (owner: 10Florianschmidtwelzow)
[18:45:32] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/262162 (https://phabricator.wikimedia.org/T70750) 
[18:47:02] <victorbarbu_>	 so...is the task already made, or what?
[18:47:04] <Nemo_bis>	 victorbarbu_: AFAIK, the function EFFP.getShortUrl mostly works but has to be made more solid; a start would be to install the multimedia extensions and see how media viewer interacts with core with that patch
[18:49:54] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/262163 (https://phabricator.wikimedia.org/T70750) 
[18:50:01] <victorbarbu_>	 Nemo_bis, is the task already done?
[18:50:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove not used private member variable mParserWarnings from OutputPage [core] - 10https://gerrit.wikimedia.org/r/262056 (owner: 10Florianschmidtwelzow)
[18:52:11] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/RightFunctions] - 10https://gerrit.wikimedia.org/r/262164 (https://phabricator.wikimedia.org/T70750) 
[18:53:24] <grrrit-wm>	 (03CR) 10Jaideraf: [C: 032 V: 032] "Thanks." [extensions/PdfBook] - 10https://gerrit.wikimedia.org/r/262118 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[18:54:42] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/ParserFun] - 10https://gerrit.wikimedia.org/r/262165 (https://phabricator.wikimedia.org/T70750) 
[18:55:27] <wikibugs>	 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add screenshots to extension and skin infoboxes on mediawiki.org - https://phabricator.wikimedia.org/T121332#1913477 (10Nemo_bis) 5Resolved>3Open This is a general task and there are 22+1934 more to do. :)
[18:55:57] <wikibugs>	 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add screenshots to extension and skin infoboxes on mediawiki.org - https://phabricator.wikimedia.org/T121332#1913479 (10Nemo_bis) a:5ananayarora>3None
[18:56:11] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/262166 (https://phabricator.wikimedia.org/T70750) 
[18:56:44] <grrrit-wm>	 (03CR) 10Wikinaut: "@Nemo thanks. I will try to find some time to check the patch, and to review." [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/262148 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[18:57:03] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/262167 (https://phabricator.wikimedia.org/T70750) 
[18:57:16] <grrrit-wm>	 (03CR) 10Wikinaut: "@Nemo thanks. I will try to find some time to check the patch, and to review." [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/262130 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[18:57:48] <grrrit-wm>	 (03CR) 10Wikinaut: "thanks. I will try to find some time to check the patch, and to review." [extensions/RSS] - 10https://gerrit.wikimedia.org/r/262120 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[18:58:47] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/RelationLinks] - 10https://gerrit.wikimedia.org/r/262168 (https://phabricator.wikimedia.org/T70750) 
[19:03:12] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/262170 (https://phabricator.wikimedia.org/T70750) 
[19:05:00] <Reedy>	 Readonly repos in WMF which aren't the canonical source?
[19:05:03] <Reedy>	 What could go wrong
[19:07:35] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/262172 (https://phabricator.wikimedia.org/T70750) 
[19:09:47] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/262173 
[19:09:58] <grrrit-wm>	 (03PS3) 10Aude: Remove unused, deprecated ChangesList::usePatrol [core] - 10https://gerrit.wikimedia.org/r/262153 
[19:12:40] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/262174 (https://phabricator.wikimedia.org/T70750) 
[19:13:55] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/262175 (https://phabricator.wikimedia.org/T70750) 
[19:15:27] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Poll] - 10https://gerrit.wikimedia.org/r/262176 (https://phabricator.wikimedia.org/T70750) 
[19:16:29] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/262177 (https://phabricator.wikimedia.org/T70750) 
[19:17:17] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/262178 (https://phabricator.wikimedia.org/T70750) 
[19:19:04] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) 
[19:19:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[19:21:05] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/262180 (https://phabricator.wikimedia.org/T70750) 
[19:21:51] <MtDu>	 Nemo_bis: I'm making them both case sensitive.
[19:22:17] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Remove unused, deprecated ChangesList::usePatrol [core] - 10https://gerrit.wikimedia.org/r/262153 (owner: 10Aude)
[19:22:22] <MtDu>	 Nemo_bis: Should I make the second one like this though? Case (sensitive)? I changed the wrong one in patch 2 
[19:22:39] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/RPED] - 10https://gerrit.wikimedia.org/r/262181 (https://phabricator.wikimedia.org/T70750) 
[19:22:43] <MtDu>	 FlorianSW: Should I claim which extensions I'm working on now before they're gone? 
[19:23:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/RPED] - 10https://gerrit.wikimedia.org/r/262181 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[19:25:01] <FlorianSW>	 There aren't so many left: ImageTagging (doing it now), RT, Spark, BlueSpiceExtensions, UserPageViewTracker, SelectCategory, DPLforum, SolrStore, SemanticPageSeries, TemplateData, SemanticPageMarker and WikiLoveMonuments. Nevertheless, I think I will upload changes to all of them, because it would take more work to have a list, which I shouldn't do, as I simply do it, when I'm in the "flow" :P
[19:25:05] <FlorianSW>	 MtDu: ^
[19:25:32] <MtDu>	 FlrianSW: I need to do 4 more to complete the third task, which is to do 10. :p
[19:25:39] <MtDu>	 FlorianSW: I've already done SolrStore
[19:26:11] <MtDu>	 FlorianSW:^
[19:27:19] <wikibugs>	 10MediaWiki-Redirects, 10Wikimedia-Site-Requests: redirects to a page not updated after move - https://phabricator.wikimedia.org/T32359#1913497 (10Mdann52)
[19:27:27] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262182 (https://phabricator.wikimedia.org/T70750) 
[19:27:28] <wikibugs>	 10MediaWiki-Redirects, 10Wikimedia-Site-Requests: redirects to a page not updated after move - https://phabricator.wikimedia.org/T32359#1913500 (10Mdann52) a:3Mdann52
[19:27:31] <MtDu>	 FlorianSW: I'll do RT
[19:27:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused, deprecated ChangesList::usePatrol [core] - 10https://gerrit.wikimedia.org/r/262153 (owner: 10Aude)
[19:28:48] <wikibugs>	 10MediaWiki-Redirects, 10Wikimedia-Site-Requests: redirects to a page not updated after move - https://phabricator.wikimedia.org/T32359#348800 (10Mdann52)
[19:28:50] <wikibugs>	 10Wikimedia-Site-Requests: Increase $wgMaxRedirects on enwiki - https://phabricator.wikimedia.org/T67064#1913503 (10Mdann52)
[19:29:40] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/RT] - 10https://gerrit.wikimedia.org/r/262183 (https://phabricator.wikimedia.org/T70750) 
[19:29:53] <MtDu>	 FlorianSW: Can I please do 4 of them? 
[19:29:59] <wikibugs>	 10Wikimedia-Site-Requests: Increase $wgMaxRedirects on enwiki - https://phabricator.wikimedia.org/T67064#1913506 (10Mdann52) a:3Mdann52 Merged together as these seek the same thing - the merged one seeks to achieve this. I'm doing some testing to see if this works as intended on a private wiki before pushing t...
[19:30:20] <MtDu>	 FlorianSW: Doing wikilovemonuments
[19:30:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/RT] - 10https://gerrit.wikimedia.org/r/262183 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[19:30:36] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/Spark] - 10https://gerrit.wikimedia.org/r/262184 (https://phabricator.wikimedia.org/T70750) 
[19:31:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/Spark] - 10https://gerrit.wikimedia.org/r/262184 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[19:33:06] <wikibugs>	 10UI-Standardization, 10OOjs-UI, 7Epic: Convert Special:Preferences to use OOUI - https://phabricator.wikimedia.org/T122767#1913510 (10Jdforrester-WMF)
[19:33:08] <wikibugs>	 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1913509 (10Jdforrester-WMF)
[19:34:17] <MtDu>	 FlorianSW: Here's wikilovesmonuments.  https://gerrit.wikimedia.org/r/262185
[19:34:55] <aude>	 it's a hoo!
[19:35:35] <MtDu>	 FlorianSW: Doing TemplateData
[19:36:11] <hoo>	 hi aude :)
[19:36:18] <aude>	 in sf yet?
[19:36:25] * hoo is in Detroit waiting for his connecting flight
[19:36:25] <MtDu>	 FlorianSW: TemplateData appears to be done
[19:36:29] <aude>	 ah
[19:37:06] <MtDu>	 FlorianSW: Doing DPLForum
[19:37:20] <grrrit-wm>	 (03PS1) 10Hoo man: Slightly simplify QueryPage::outputResults [core] - 10https://gerrit.wikimedia.org/r/262186 
[19:37:46] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "See inline comment. extension.json doesn't fully support this extension yet, but I'll approve the task once this patch is set up as if it " (032 comments) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[19:37:58] <legoktm>	 mhutti1: ^ sorry about the delayed review
[19:39:23] <mhutti1>	 np
[19:40:55] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262188 (https://phabricator.wikimedia.org/T70750) 
[19:41:06] <MtDu>	 FlorianSW: There is DPLforum
[19:42:32] <MtDu>	 FlorianSW: Doing SelectCategory
[19:42:59] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Replace deprecated wfMsg* functions (031 comment) [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262188 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:43:47] * FlorianSW is wondering, why BlueSpiceExtensions neds over 130 MiB of data :O
[19:43:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Slightly simplify QueryPage::outputResults [core] - 10https://gerrit.wikimedia.org/r/262186 (owner: 10Hoo man)
[19:44:14] <grrrit-wm>	 (03PS2) 10MtDu: Replace deprecated wfMsg* functions [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262188 (https://phabricator.wikimedia.org/T70750) 
[19:44:33] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg* functions [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262188 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:45:04] <mhutti1>	 legoktm: Validating the schema fails it but I assume thats expected
[19:45:08] <legoktm>	 yep
[19:45:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262188 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:45:14] <hoo>	 oh, right
[19:45:16] <hoo>	 how do we deprecate something which is supposed to be overwritten?
[19:45:16] <hoo>	 Just slap the @deprecated on it?
[19:45:38] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/262189 (https://phabricator.wikimedia.org/T70750) 
[19:45:47] <MtDu>	 FlorianSW: There's selectcategroy
[19:46:15] <grrrit-wm>	 (03PS3) 10Mhutti1: Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) 
[19:46:49] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg* functions [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/262189 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:47:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/262189 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:48:00] <MtDu>	 FlorianSW: Update. https://gerrit.wikimedia.org/r/#/c/262185/
[19:48:12] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "unrelated jenkins failure :)" [extensions/Spark] - 10https://gerrit.wikimedia.org/r/262184 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[19:48:48] <mhutti1>	 legoktm: K it should be in the right place now :)
[19:49:22] <wikibugs>	 10MediaWiki-extensions-ExtensionDistributor: ExtensionDistributor tarballs should include .git metadata that makes the version show upon Special:Version - https://phabricator.wikimedia.org/T122769#1913527 (10Legoktm) 3NEW
[19:50:10] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Looks good, I'll approve the task now :)" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[19:50:46] <wikibugs>	 10MediaWiki-extensions-GoogleNewsSitemap, 3Google-Code-In-2015, 5Patch-For-Review: extension.json should allow setting $wgFeedClasses - https://phabricator.wikimedia.org/T122770#1913539 (10Legoktm) 3NEW
[19:50:59] <wikibugs>	 10MediaWiki-Configuration: extension.json should allow setting $wgFeedClasses - https://phabricator.wikimedia.org/T122770#1913546 (10Legoktm) p:5Low>3High
[19:51:04] * legoktm grumbles about hitting enter too early
[19:51:43] <FlorianSW>	 legoktm: :P :)
[19:52:09] <FlorianSW>	 200 MiB!!!
[19:52:20] <grrrit-wm>	 (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262190 (https://phabricator.wikimedia.org/T70750) 
[19:52:29] <MtDu>	 FlorianSW: THere's UserPageViewTracker
[19:52:51] <legoktm>	 FlorianSW: oh yeah, BlueSpice is giant because they used to have binary .jar files in the repo or something. Do a shallow clone?
[19:53:25] <wikibugs>	 10Wikimedia-Site-Requests, 7Community-consensus-needed: set $wgMaxRedirects = 2 on dewiki - https://phabricator.wikimedia.org/T65388#1913559 (10Mdann52) 5Open>3stalled Tested on mw 1.26.2, and this does not work with the current config - will set a blocking task.
[19:53:32] <tgr>	 victorbarbu_: hi
[19:53:41] <wikibugs>	 10Wikimedia-Site-Requests: Increase $wgMaxRedirects on enwiki - https://phabricator.wikimedia.org/T67064#1913563 (10Mdann52) 5Open>3stalled Tested on mw 1.26.2, and this does not work with the current config - will set a blocking task.
[19:53:47] <victorbarbu_>	 tgr, hi!
[19:54:13] <tgr>	 the task is about making it possible to show page id in the imageinfo API output
[19:54:14] <FlorianSW>	 legoktm: possible, but I'm at 99% and won't hit Ctrl + C :P
[19:54:24] <MtDu>	 FlorianSW: All that's left is BlueSpiceExtensions, SemanticPageSeries, SemanticPageMarker. TemplateData has one line, but it's a comment, so it doesn't matter. 
[19:54:26] <FlorianSW>	 MtDu: please do SemanticPageSeries ;)
[19:54:42] <tgr>	 which is tricky because MediaWiki has this concept of remote files
[19:55:01] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Replace deprecated wfMsg* functions [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262190 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:55:04] <tgr>	 like, you upload Example.png on commons.wikimedia.org
[19:55:21] <MtDu>	 FlorianSW: Doing that now. :)
[19:55:25] <tgr>	 then you refer to [[File:Example.png]] in mywiki.com
[19:55:30] <tgr>	 and it magically works
[19:55:47] <tgr>	 https://www.mediawiki.org/wiki/InstantCommons has more information about that
[19:56:12] <wikibugs>	 10MediaWiki-Redirects: $wgMaxRedirects does not appear to work as intended - https://phabricator.wikimedia.org/T122771#1913567 (10Mdann52) 3NEW
[19:56:30] <MtDu>	 FlorianSW: SemanticPageSeries seems to be done. :)
[19:56:37] <FlorianSW>	 legoktm: would git review possible on a shallow clone? :/ it takes tooo much time to download the whole repo :(
[19:57:00] <tgr>	 victorbarbu_: the way this works internally is that MediaWiki has a class called File, which contains all kinds of information about a file (which could be a remote file)
[19:57:04] <FlorianSW>	 MtDu: then do SemanticPageMaker :D (damn, I want, that you do one more with mor then one line :P)
[19:57:14] <MtDu>	 FlorianSW: Ok. :)
[19:57:15] <wikibugs>	 10MediaWiki-Redirects: $wgMaxRedirects does not appear to work as intended - https://phabricator.wikimedia.org/T122771#1913578 (10Mdann52)
[19:57:15] <tgr>	 the imageinfo API gets its data from File
[19:57:15] <legoktm>	 FlorianSW: uhhm don't know, I don't use git review
[19:57:17] <wikibugs>	 10Wikimedia-Site-Requests, 7Community-consensus-needed: set $wgMaxRedirects = 2 on dewiki - https://phabricator.wikimedia.org/T65388#1913577 (10Mdann52)
[19:57:26] <victorbarbu_>	 tgr, ok, I think I get it
[19:57:35] <wikibugs>	 10MediaWiki-Redirects: $wgMaxRedirects does not appear to work as intended - https://phabricator.wikimedia.org/T122771#1913567 (10Mdann52)
[19:57:37] <victorbarbu_>	 how should I go about this?
[19:57:37] <wikibugs>	 10Wikimedia-Site-Requests: Increase $wgMaxRedirects on enwiki - https://phabricator.wikimedia.org/T67064#1913581 (10Mdann52)
[19:57:44] <FlorianSW>	 legoktm: ok, would git push be possible :P It doesn't matter how, but i wan't to make sure, that I can submit it for review :D
[19:57:55] <FlorianSW>	 ah, nevermind, git finished :D
[19:57:56] <wikibugs>	 6Developer-Relations, 10Wikimedia-Developer-Summit-2016-Organization, 3DevRel-December-2015: Public transportation Info for participants for WikiDev 2016 - https://phabricator.wikimedia.org/T122542#1913584 (10Rfarrand) 5Open>3Resolved it is up on the event page and will also be sent out in today final em...
[19:57:57] <tgr>	 so basically the File subclasses need to be modified to preserve the page id of their original page
[19:58:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262190 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu)
[19:58:40] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization, 3DevRel-December-2015: Confirm that the main points of the MediaWiki Developer Summit 2015 Lessons Learned document are being followed - https://phabricator.wikimedia.org/T111810#1913589 (10Rfarrand)
[19:59:24] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization: Wikimedia Developer Summit 2016 Logistics - https://phabricator.wikimedia.org/T111799#1913593 (10Rfarrand)
[19:59:25] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization: Monday night social event plan - https://phabricator.wikimedia.org/T111801#1913591 (10Rfarrand) 5Open>3Resolved Have confirmed dinner leaders signed up on the event page - will email out about this in tonights final email to participants.
[19:59:57] <grrrit-wm>	 (03PS2) 10Hoo man: Slightly simplify QueryPage::outputResults [core] - 10https://gerrit.wikimedia.org/r/262186 
[20:00:15] <tgr>	 victorbarbu_: this task was created for a specific student who made very quick progress with another task
[20:00:29] <tgr>	 which is not to say you cannot take it, just that it is harder than average
[20:00:34] <tgr>	 fair warning :)
[20:00:35] <wikibugs>	 6Developer-Relations, 10Wikimedia-Developer-Summit-2016-Organization, 3DevRel-December-2015: Public transportation Info for participants for WikiDev 2016 - https://phabricator.wikimedia.org/T122542#1913596 (10Rfarrand)
[20:00:36] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization: Busses/Transportation plan to/from Wikimedia Dev Summit - https://phabricator.wikimedia.org/T111809#1913594 (10Rfarrand) 5Open>3Resolved Buses will take anybody who wants a ride from MBC to WMF on Monday and Tuesday at 5pm. This is finalized and up on the sched...
[20:00:37] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization: Wikimedia Developer Summit 2016 Logistics - https://phabricator.wikimedia.org/T111799#1616781 (10Rfarrand)
[20:00:42] <MtDu>	 FlorianSW: What do I do about this? Haven't seen it before. Just ->escaped? 
[20:00:44] <MtDu>	 <h2>' . wfMsgWikiHtml( 'wf_title', $widget->getText() ) . '</h2>
[20:00:47] <tgr>	 victorbarbu_: File has three subclasses that matter
[20:00:47] <MtDu>	 FlorianSW:^
[20:01:03] <victorbarbu_>	 well, it wouldn't be my first hard task, but I just need to get familiar with this
[20:01:04] <legoktm>	 mhutti1: any chance you want to try https://phabricator.wikimedia.org/T122770 ? :)
[20:01:06] <tgr>	 LocalFile, ForeignAPIFile, ForeignDBFile
[20:01:29] <grrrit-wm>	 (03PS1) 10Reedy: /* -> /** [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262191 
[20:01:33] <victorbarbu_>	 the one that is problematic is ForeignAPIFile, right?
[20:01:37] <tgr>	 LocalFile is what it sounds, the file is stored locally on disk, file metadata is stored in local DB
[20:01:42] <wikibugs>	 10MediaWiki-Configuration, 7Easy: extension.json should allow setting $wgFeedClasses - https://phabricator.wikimedia.org/T122770#1913598 (10Legoktm) Should be as simple as {2d534f3ea6ab39c463ac27692c1121c3faf5c92a}.
[20:02:15] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization: Wikimedia Developer Summit 2016 Logistics - https://phabricator.wikimedia.org/T111799#1913603 (10Rfarrand)
[20:02:16] <wikibugs>	 10Wikimedia-Developer-Summit-2016-Organization, 3DevRel-December-2015: Confirm that the main points of the MediaWiki Developer Summit 2015 Lessons Learned document are being followed - https://phabricator.wikimedia.org/T111810#1913601 (10Rfarrand) 5Open>3Resolved Suggested changes for the next Developer Su...
[20:02:27] <mhutti1>	 legoktm: yeah will look at now
[20:03:00] <MtDu>	 FlorianSW: Here you go. https://gerrit.wikimedia.org/r/262192
[20:03:00] <MtDu>	  :)
[20:03:10] <wikibugs>	 10MediaWiki-Configuration, 7Easy: extension.json should allow setting $wgFeedClasses - https://phabricator.wikimedia.org/T122770#1913605 (10Mhutti1) a:3Mhutti1
[20:03:22] <tgr>	 ForeignDBFile means the file is stored on disk (in practice probably some kind of shared file system but the class does not need to know about that, we have a separate abstraction for it in the form of FileBackend classes which won't be relevant for this task)
[20:03:48] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/262193 (https://phabricator.wikimedia.org/T70750) 
[20:03:51] <FlorianSW>	 Finally: ^^ :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D 
[20:03:59] <tgr>	 and metadata is stored in a non-standard DB (such as the database of another wiki on the same database server)
[20:04:11] <Nemo_bis>	 FlorianSW: they should give you a medal :)
[20:04:16] <Nemo_bis>	 oooh that's a tgr :)
[20:04:21] <legoktm>	 mhutti1: yay :) I'll also create a GCI task for it
[20:04:23] <FlorianSW>	 Reedy: ready for review? :D
[20:04:52] <tgr>	 ForeignAPIRepo is a file on a remote wiki, the file and metadata is fetched by making HTTP calls
[20:05:08] <mhutti1>	 legoktm: cool
[20:05:21] <tgr>	 victorbarbu_: neither is particularly problematic but all three need different code to make it work
[20:05:29] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/RT] - 10https://gerrit.wikimedia.org/r/262183 (https://phabricator.wikimedia.org/T70750) 
[20:05:53] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "unrelated jenkins failure :)" [extensions/RPED] - 10https://gerrit.wikimedia.org/r/262181 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:06:16] <wikibugs>	 10MediaWiki-Configuration, 7Easy, 3Google-Code-In-2015: extension.json should allow setting $wgFeedClasses - https://phabricator.wikimedia.org/T122770#1913607 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/5514403025780736/
[20:06:20] <legoktm>	 Nemo_bis: could you publish ^ please? :)
[20:06:30] <grrrit-wm>	 (03PS2) 10Reedy: Replace Title::userIsWatching() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262098 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:06:42] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262098 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:06:53] <victorbarbu_>	 tgr, hmm
[20:07:08] <Reedy>	 FlorianSW: I removed your global usages because a user object exists :P
[20:07:08] <tgr>	 victorbarbu_: for LocalFile you need to write a DB query to get the page id, you can look at LocalFile::getDescriptionTouched for inspiration
[20:07:31] <FlorianSW>	 Reedy: oops :( Where?
[20:07:34] <tgr>	 for ForeignDBFile it's the same, you just have to be careful to use the right DB
[20:07:38] <FlorianSW>	 ah, flaggedrevs?
[20:07:40] <Reedy>	 I just fixed it in that commit above
[20:08:10] <FlorianSW>	 sorry for this error :(
[20:08:10] <MtDu>	 FlorianSW: There's semanticpagemaker. https://gerrit.wikimedia.org/r/262192
[20:08:22] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "recheck" [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:08:23] <Reedy>	 FlorianSW: that's the point of CR ;)
[20:08:36] <tgr>	 for ForeignAPIFile you need first to do the other two, expose the data in the imageinfo API, then make sure ForeignAPIFile uses it 
[20:08:58] <FlorianSW>	 Reedy: that's right :)
[20:09:07] <tgr>	 it already does an imageinfo query to get other kinds of metadata so it won't be a huge change
[20:09:12] <Reedy>	 FlorianSW: Have we met AFK btw?
[20:09:18] <MtDu>	 FlorianSW: Look at the page. Nemo said to not change the text files. Is that right? 
[20:09:40] <Nemo_bis>	 So much trust :)
[20:09:41] <FlorianSW>	 Reedy: not yet, iirc, unfortunately :)
[20:09:48] <victorbarbu_>	 tgr, so I have to work on server-side for the first two, then change the API so theat ForeignAPIFile can use it
[20:09:52] <victorbarbu_>	 right?
[20:10:02] <tgr>	 right
[20:10:02] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Jenkins you're a liar :(" [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:10:08] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/262110 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:10:08] <MtDu>	 Nemo_bis: I trust you. 
[20:10:13] <tgr>	 although all three are server-side
[20:10:17] <Reedy>	 FlorianSW: You were in SF for the dev summit last January?
[20:10:29] <tgr>	 ForeignAPIFile is one server talking to another server
[20:10:30] <victorbarbu_>	 well, I think I can handle that
[20:10:34] <MtDu>	 Nemo_bis: It's just that all the extensions have been one line fixes. :p
[20:10:37] <FlorianSW>	 Reedy: yep :) In in Lyon (last european hackathon)
[20:10:43] <tgr>	 like, your local vagrant wiki fetching a file from Commons
[20:10:46] <Reedy>	 I wasn't in Lyon... But I was in SF
[20:11:00] <MtDu>	 Nemo_bis: About the other task, the one I'm doing for phalanx, do you want me to just chane both to case sensitive? 
[20:11:13] <tgr>	 victorbarbu_: which is, um, challenging to test
[20:11:23] <wikibugs>	 10Gather, 7Easy, 3Google-Code-In-2015, 3Reading-Web-Sprint-63-Ellip…: Cannot remove items from Gather collections - https://phabricator.wikimedia.org/T122543#1913612 (10Nemo_bis)
[20:11:34] <victorbarbu_>	 that's what I was typing
[20:11:49] <victorbarbu_>	 first of all, I should install multimediaviewer
[20:11:50] <FlorianSW>	 Reedy: hmm, maybe we have seen us, but I wouldn't name it "met" :)
[20:12:02] <tgr>	 you can create a weird setup where your test wiki is its own foreign repo
[20:12:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262098 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:12:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/262110 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:12:22] <Reedy>	 FlorianSW: I'm just trying to put a face to a name :P
[20:12:29] <Nemo_bis>	 MtDu: please don't change the message which was unrequested, unless you know its context
[20:12:35] <tgr>	 victorbarbu_: MediaViewer is not related to this task (apart from being the API client that will benefit from it)
[20:12:49] <victorbarbu_>	 so I need it
[20:12:52] <tgr>	 you can just test by making an imageinfo API call and checking the output
[20:13:06] <victorbarbu_>	 oh
[20:13:17] <victorbarbu_>	 "you can create a weird setup where your test wiki is its own foreign repo" ?
[20:13:23] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Replace wfMsg* calls [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/262161 (https://phabricator.wikimedia.org/T70750) 
[20:13:48] <MtDu>	 Nemo_bis: I looked in the qqq json file for the context. 
[20:13:57] <tgr>	 victorbarbu_: look at the code block at https://www.mediawiki.org/wiki/InstantCommons#Debugging
[20:14:08] <FlorianSW>	 Reedy: :P It will be difficult to find an actual one of me in the internet :)
[20:14:20] <tgr>	 you can do something like that but point to the local wiki instead of Commons
[20:14:46] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/262106 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:15:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/262106 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:15:06] <grrrit-wm>	 (03PS3) 10MtDu: Clarify case sensitivity in stats-table-case message [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/262117 
[20:15:12] <MtDu>	 Nemo_bis: ^
[20:15:30] <MtDu>	 Nemo_bis: I'll revert those text files. :)
[20:15:44] <tgr>	 victorbarbu_: the way foreign files are configured is that there is an identical FileRepo class hierarchy for repositories (LocalFile -> LocalRepo etc)
[20:15:58] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Sorry for not mention this, but sure, this change shouldn't be merged, before any usage was fixed. You can follow (and maybe help) the cod" [core] - 10https://gerrit.wikimedia.org/r/262112 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:16:09] <Reedy>	 FlorianSW: https://gerrit.wikimedia.org/r/#/c/262191/
[20:16:22] <tgr>	 and the $wgForeignFileRepos site configuration variable holds an array of Repo objects
[20:16:32] <FlorianSW>	 phpstorm, right Reedy? :D
[20:16:39] <Reedy>	 Yeah
[20:16:54] <Reedy>	 https://upload.wikimedia.org/wikipedia/commons/1/1f/MediaWiki_Developer_Summit_-_January_2015_-_Photo_17.jpg
[20:17:00] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "looks good, except one thing? :)" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262191 (owner: 10Reedy)
[20:17:04] <tgr>	 and whenever you request a file in a some way, like an imageinfo call, it will go through that list and try to fetch the file from each
[20:17:05] <FlorianSW>	 Reedy: ^^
[20:17:24] <Reedy>	 lol
[20:17:57] <tgr>	 victorbarbu_: so you can define a new foreign repo which is actually your local wiki, and when you use that the will make API calls to itself
[20:18:00] <MtDu>	 Nemo_bis: SemanticPageMaker. https://gerrit.wikimedia.org/r/#/c/262192/
[20:18:10] <MtDu>	 FlorianSW: IS there another list, or are there any left? 
[20:18:25] <grrrit-wm>	 (03PS2) 10Reedy: /* -> /** [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262191 
[20:18:37] <FlorianSW>	 Reedy: on that picture: I found you (I think), but I can't see me :P Iirc I was at the far end of the hall at this session, but I can't see me :(
[20:18:37] <tgr>	 the tricky part is that normally LocalRepo is looked up first so there will be some hacking needed to prevent it from finding the file
[20:19:05] <FlorianSW>	 MtDu: I think all have changes, let's wait until all are merged and we can look for missed ones :)
[20:19:28] <MtDu>	 FlorianSW: Ok. :)
[20:19:30] <tgr>	 like, if a certain URL parameter is used, make LocalRepo::findFiles return false, and then use that parameter when you are testing
[20:19:33] <MtDu>	 FlorianSW: Let me know
[20:19:59] <tgr>	 victorbarbu_: the less hacky but more cumbersome approach is to set up two local wikis
[20:20:11] <tgr>	 hm, wait, we actually have a vagrant role for that
[20:20:18] <FlorianSW>	 MtDu: if you're subscribed to the task, you'll get informed :P
[20:20:34] <Reedy>	 FlorianSW: Found you
[20:20:34] <Reedy>	 xD
[20:20:35] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] /* -> /** [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262191 (owner: 10Reedy)
[20:20:44] <FlorianSW>	 :D
[20:21:01] <Reedy>	 https://upload.wikimedia.org/wikipedia/commons/3/39/Hackathon_Wikim%C3%A9dia_Lyon_2015_07.jpg
[20:21:14] <victorbarbu_>	 tgr, which one?
[20:21:14] <tgr>	 victorbarbu_: yup, the 'commons' vagrant role will set up a second local wiki and configure it as a foreign repo for the first one
[20:21:18] <tgr>	 so you can use that
[20:21:23] <FlorianSW>	 Reedy: ähhhh, a terrible picture :D
[20:21:28] <victorbarbu_>	 hm, ok
[20:21:32] <victorbarbu_>	 I will check it out
[20:21:37] <Reedy>	 Schrecklich
[20:21:43] <FlorianSW>	 Genau das meinte ich :D
[20:21:53] <Reedy>	 I *think* we have probably met then
[20:22:31] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "unrelated error message :)" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/262140 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:22:43] <wikibugs>	 10MediaWiki-Search, 6Discovery, 3Google-Code-In-2015: Split PHP classes from SearchResultSet.php into separate files - https://phabricator.wikimedia.org/T122637#1913622 (10Nemo_bis) https://codein.withgoogle.com/dashboard/tasks/4938345855582208/
[20:22:51] <wikibugs>	 10MediaWiki-Special-pages, 3Google-Code-In-2015: Split PHP classes from SpecialConfirmemail.php into separate files - https://phabricator.wikimedia.org/T122636#1913624 (10Nemo_bis) https://codein.withgoogle.com/dashboard/tasks/5386150738919424/
[20:23:01] <wikibugs>	 10MediaWiki-Installer, 3Google-Code-In-2015: Split PHP classes from WebInstallerPage.php into separate files - https://phabricator.wikimedia.org/T122634#1913626 (10Nemo_bis) https://codein.withgoogle.com/dashboard/tasks/5012580791746560/
[20:23:11] <wikibugs>	 10MediaWiki-General-or-Unknown, 3Google-Code-In-2015: Split PHP classes from WebRequest.php into separate files - https://phabricator.wikimedia.org/T122633#1913628 (10Nemo_bis) https://codein.withgoogle.com/dashboard/tasks/5861467656028160/
[20:23:14] <FlorianSW>	 hmm, then I can't remember :(
[20:23:27] <Reedy>	 Heh
[20:24:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: /* -> /** [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/262191 (owner: 10Reedy)
[20:26:25] <wikibugs>	 10Spelling-Dictionary, 3Google-Code-In-2015, 5Patch-For-Review: Use ULS for language selection - https://phabricator.wikimedia.org/T87244#1913635 (10Nemo_bis)
[20:26:26] <wikibugs>	 10MediaWiki-extensions-UniversalLanguageSelector, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): The cancel event handler closes the ULS even if a descendant of the trigger is clicked - https://phabricator.wikimedia.org/T122722#1913633 (10Nemo_bis) 5Open>3Resolved Thanks Santhosh for the merg...
[20:26:54] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatched [skins/Synagonism] - 10https://gerrit.wikimedia.org/r/262104 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:27:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatched [skins/Synagonism] - 10https://gerrit.wikimedia.org/r/262104 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:28:46] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/262096 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:29:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/262096 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:29:58] <victorbarbu_>	 tgr, what is the db table where local files are kept?
[20:31:25] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userIsWatching [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/262097 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:31:50] <wikibugs>	 10MediaWiki-Page-deletion: Deletion log excerpt (mw-warning-with-logexcerpt) not shown when only curid given and page has been deleted - https://phabricator.wikimedia.org/T73578#1913639 (10Tgr) @jcrespo what do you think of the previous comment? Is it feasible to use that query, or to add a new index that covers...
[20:32:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userIsWatching [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/262097 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:32:28] <tgr>	 victorbarbu_: file metadata is in the image table, page id is in the page table
[20:32:40] <victorbarbu_>	 I found them, thank you :)
[20:32:44] <tgr>	 the actual files are kept as filesystem files
[20:32:49] <victorbarbu_>	 of course
[20:32:55] <victorbarbu_>	 tgr, are you in the USA?
[20:32:59] <tgr>	 yes
[20:33:15] <victorbarbu_>	 so you are on GMT-7?
[20:34:06] <tgr>	 no, PST
[20:34:19] <tgr>	 that's GMT/UTC-8 at this time of year
[20:35:03] <victorbarbu_>	 oh, 10 hours behind me
[20:35:40] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace Title::userisWatching [skins/webplatform] - 10https://gerrit.wikimedia.org/r/262107 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:36:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace Title::userisWatching [skins/webplatform] - 10https://gerrit.wikimedia.org/r/262107 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:36:09] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove Linker::makeImageLink2 usage [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262092 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:36:35] <victorbarbu_>	 can't I use the Title's getArticleId() method?
[20:36:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove Linker::makeImageLink2 usage [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262092 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:37:10] <victorbarbu_>	 to get the page id
[20:37:31] <grrrit-wm>	 (03CR) 10Jackmcbarn: [C: 032] Use correct variable in ustring.lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/261947 (owner: 10Anomie)
[20:38:33] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove makeImageLink2 comment [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/262094 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:39:11] <grrrit-wm>	 (03PS2) 10Reedy: Remove makeImageLink2 usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262093 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:39:16] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove makeImageLink2 usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262093 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:40:44] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "+1/-1 Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/262091 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:40:49] <FlorianSW_>	 legoktm: got your Memo :P
[20:41:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use correct variable in ustring.lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/261947 (owner: 10Anomie)
[20:41:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove makeImageLink2 comment [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/262094 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:41:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove makeImageLink2 usage [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262093 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:41:46] <wikibugs>	 10MediaWiki-extensions-Scribunto: Pure-Lua ustring doesn't always report errors - https://phabricator.wikimedia.org/T122772#1913649 (10Jackmcbarn) 3NEW
[20:42:04] <FlorianSW_>	 I can't remember when I had so many extensions in my local mediawiki installation :P
[20:42:35] <Reedy>	 lol
[20:42:47] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] "+1/-1 Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:43:02] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Remove wfMsgNoTrans() [core] - 10https://gerrit.wikimedia.org/r/262091 (https://phabricator.wikimedia.org/T70750) 
[20:43:25] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove wfMsgNoTrans() [core] - 10https://gerrit.wikimedia.org/r/262091 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:45:03] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Remove Linker::makeImageLink2 [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) 
[20:45:26] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "> maybe rebase ontop of wfMsgNoTrans commit" [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:45:47] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove Linker::makeImageLink2 [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:49:09] <wikibugs>	 5Patch-For-Review, 3Wikipedia-Android-App: App should not insert HTML tags into edit summaries - https://phabricator.wikimedia.org/T122714#1913657 (10TheDJ) summaries are not plaintext btw, they are a reduced set of wikitext... (we actually have 3 parsers, wikitext, summaries and headers... sort of. I know. .....
[20:52:28] <grrrit-wm>	 (03CR) 10Cindy-the-browser-test-bot: "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/262201 (owner: 10L10n-bot)
[20:52:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove wfMsgNoTrans() [core] - 10https://gerrit.wikimedia.org/r/262091 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:54:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove Linker::makeImageLink2 [core] - 10https://gerrit.wikimedia.org/r/262095 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[20:55:44] <wikibugs>	 5Patch-For-Review, 3Wikipedia-Android-App: App should not insert HTML tags into edit summaries - https://phabricator.wikimedia.org/T122714#1913660 (10Deskana) >>! In T122714#1913657, @TheDJ wrote: > summaries are not plaintext btw, they are a reduced set of wikitext... (we actually have 3 parsers, wikitext, su...
[20:58:43] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace misleading wfMsg* comment [extensions/RSS] - 10https://gerrit.wikimedia.org/r/262120 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:59:07] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace misleading wfMsg* comment [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/262148 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:59:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace misleading wfMsg* comment [extensions/RSS] - 10https://gerrit.wikimedia.org/r/262120 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[20:59:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace misleading wfMsg* comment [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/262148 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:00:24] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/262170 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:01:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/262170 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:01:13] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/262172 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:01:42] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/262175 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:01:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/262172 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:02:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/262175 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:02:53] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/262193 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:03:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/262193 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:04:09] <grrrit-wm>	 (03PS2) 10Krinkle: Update jakub-onderka/php-parallel-lint to 0.9.2 [core] - 10https://gerrit.wikimedia.org/r/261914 (owner: 10Paladox)
[21:04:49] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls (031 comment) [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/262143 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:05:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/ErrorHandler] - 10https://gerrit.wikimedia.org/r/262143 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:05:54] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/262159 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:06:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/262159 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:06:40] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262133 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:07:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262133 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:07:38] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/262177 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:10:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/262177 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:12:56] <grrrit-wm>	 (03CR) 10Krinkle: "fixme: Except this one:" [core] - 10https://gerrit.wikimedia.org/r/261923 (owner: 10Reedy)
[21:13:34] <grrrit-wm>	 (03CR) 10Krinkle: ".. but beware that extension is incompatible with MW 1.26+ in other ways already (for one, it isn't async, so it's broken and won't work w" [core] - 10https://gerrit.wikimedia.org/r/261923 (owner: 10Reedy)
[21:13:38] <MtDu>	 Reedy: Do you guys have an updated list of what's left? 
[21:13:55] <Reedy>	 MtDu: I thought FlorianSW_ had done the rest... Mostly awaiting review
[21:14:39] <MtDu>	 Reedy: Gotcha. That's what he told me. If there's anything left after the reviews, let me know. 
[21:16:02] <grrrit-wm>	 (03PS1) 10Reedy: Remove OutputPage::includeJQuery call [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/262238 
[21:16:36] <unicornisaurous>	 Dang I was hoping to get some of those after I finished with my current task.
[21:16:37] <grrrit-wm>	 (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/262238" [core] - 10https://gerrit.wikimedia.org/r/261923 (owner: 10Reedy)
[21:17:27] <unicornisaurous>	 My list of future tasks is rapidly shrinking
[21:19:26] <MtDu>	 unicornisaurous: Whatcha workin on now? 
[21:19:35] <unicornisaurous>	 somethin with twinkle
[21:22:46] <wikibugs>	 10MediaWiki-Revision-deletion: Add log excerpts to revdeleted diffs - https://phabricator.wikimedia.org/T23175#1913675 (10Scott) >>! In T23175#244971, @Nemo_bis wrote: > See also bug 23730.  This is now T25730.
[21:22:53] <wikibugs>	 10MediaWiki-Revision-deletion: Revision deletion log does not specify which revisions were affected to non-Sysops - https://phabricator.wikimedia.org/T25730#1913681 (10Scott) >>! In T25730#273879, @Nemo_bis wrote: > (In reply to comment #1) >> Next useful thing to do would be a warning with a revision-specific l...
[21:33:44] <wikibugs>	 10MediaWiki-Revision-deletion: Add log excerpts to revdeleted diffs - https://phabricator.wikimedia.org/T23175#1913686 (10Scott) jake wrote in the description of this bug: > Right now when an unprivileged user tries to view a deleted diff they are told that the revision has been hidden, but no why or who by.  Mo...
[21:38:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set manifest_version in extension.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/261883 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm)
[21:38:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set manifest_version in extension.json [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/261881 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm)
[21:38:58] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set manifest_version in extension.json [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/261882 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm)
[21:39:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set manifest_version in extension.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/261880 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm)
[21:39:09] <grrrit-wm>	 (03PS7) 10Sn1per: [WIP] Add day to date filter for ReverseChronologicalPager [core] - 10https://gerrit.wikimedia.org/r/260636 (https://phabricator.wikimedia.org/T120733) 
[21:39:11] <grrrit-wm>	 (03PS1) 10Mhutti1: extension.json accepts setting of $wgFeedClasses [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) 
[21:39:16] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 032] Remove OutputPage::includeJQuery call [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/262238 (owner: 10Reedy)
[21:39:33] <grrrit-wm>	 (03CR) 10Jforrester: [V: 032] build: Updating development dependencies [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/261470 (owner: 10Legoktm)
[21:39:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Use valid spdx license identifier [extensions/Petition] - 10https://gerrit.wikimedia.org/r/261884 (owner: 10Legoktm)
[21:39:53] <wikibugs>	 10MediaWiki-Revision-deletion, 7Tracking: RevDelete/HideUser (tracking) - https://phabricator.wikimedia.org/T20840#1913693 (10Luke081515) Can we decline this task? We have already #mediawiki-revision-deletion
[21:41:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set manifest_version in extension.json [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/261881 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm)
[21:42:56] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/262142 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:42:58] <grrrit-wm>	 (03CR) 10Mhutti1: "The validation script still isnt liking the extension.json" [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[21:43:26] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/HTMLets] - 10https://gerrit.wikimedia.org/r/262122 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:43:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set manifest_version in extension.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/261880 (https://phabricator.wikimedia.org/T100745) (owner: 10Legoktm)
[21:43:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove OutputPage::includeJQuery call [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/262238 (owner: 10Reedy)
[21:43:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use valid spdx license identifier [extensions/Petition] - 10https://gerrit.wikimedia.org/r/261884 (owner: 10Legoktm)
[21:43:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Loops] - 10https://gerrit.wikimedia.org/r/262146 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:43:53] <unicornisaurous>	 I see we’re keeping jenkins busy today.
[21:43:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/262142 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:44:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/HTMLets] - 10https://gerrit.wikimedia.org/r/262122 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:44:16] <legoktm>	 jenkins lives to serve (and let people down)
[21:44:46] <Reedy>	 lol
[21:45:26] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/262134 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:45:47] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/262125 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:45:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/262134 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:46:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/262125 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:49:01] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/262141 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:49:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/262141 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:49:58] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/RightFunctions] - 10https://gerrit.wikimedia.org/r/262164 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:50:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/RightFunctions] - 10https://gerrit.wikimedia.org/r/262164 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:50:52] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:52:15] <grrrit-wm>	 (03CR) 10Mhutti1: "Nevermind it works fine. I was checking the wrong file :(" [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[21:54:01] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Replace wfMsg* calls [extensions/Spark] - 10https://gerrit.wikimedia.org/r/262184 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:54:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace wfMsg* calls [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:54:34] <grrrit-wm>	 (03CR) 10Reedy: [V: 032] Replace wfMsg* calls [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/262179 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:55:24] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Replace wfMsg* calls [extensions/Offline] - 10https://gerrit.wikimedia.org/r/262140 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:56:05] <grrrit-wm>	 (03PS3) 10Reedy: Import: Try to stop revisions getting created with rev_page = 0 [core] - 10https://gerrit.wikimedia.org/r/262078 (https://phabricator.wikimedia.org/T18674) (owner: 10TTO)
[21:56:11] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Import: Try to stop revisions getting created with rev_page = 0 [core] - 10https://gerrit.wikimedia.org/r/262078 (https://phabricator.wikimedia.org/T18674) (owner: 10TTO)
[21:56:56] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Replace wfMsg* calls [extensions/RPED] - 10https://gerrit.wikimedia.org/r/262181 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:57:23] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/262116 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:57:25] <grrrit-wm>	 (03PS2) 10Mhutti1: extension.json accepts setting of $wgFeedClasses [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) 
[21:57:26] <MtDu>	 Nemo_bis: I changed the one that wasn't supposed to be changed back. Sorry about that. 
[21:57:50] <MtDu>	 Nemo_bis: Take a look when you get a chance. Also, I pushed a patch for adding GENDER to the Nimbus message. :)
[21:58:13] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/262115 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:58:49] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/YetAnotherKeywords] - 10https://gerrit.wikimedia.org/r/262128 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:59:13] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/262135 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:59:31] <grrrit-wm>	 (03CR) 10Legoktm: extension.json accepts setting of $wgFeedClasses (032 comments) [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[21:59:36] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/OpenStreetMapSlippyMap] - 10https://gerrit.wikimedia.org/r/262147 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[21:59:46] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "See minor inline comments on patchset 1" [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[22:00:28] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Poll] - 10https://gerrit.wikimedia.org/r/262176 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:00:52] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/262166 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:01:36] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/RT] - 10https://gerrit.wikimedia.org/r/262183 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:01:50] <grrrit-wm>	 (03PS3) 10Mhutti1: extension.json accepts setting of $wgFeedClasses [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) 
[22:02:01] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/ParserFun] - 10https://gerrit.wikimedia.org/r/262165 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:02:03] <grrrit-wm>	 (03PS4) 10Mhutti1: extension.json accepts setting of $wgFeedClasses [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) 
[22:02:37] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/262163 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:02:57] <grrrit-wm>	 (03PS4) 10Legoktm: Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[22:02:59] <grrrit-wm>	 (03PS5) 10Legoktm: Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[22:03:17] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/RelationLinks] - 10https://gerrit.wikimedia.org/r/262168 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:03:19] <grrrit-wm>	 (03PS5) 10Legoktm: registration: Allow setting $wgFeedClasses in extension.json [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[22:03:42] <legoktm>	 umm
[22:03:42] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/262174 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:03:48] <legoktm>	 https://gerrit.wikimedia.org/r/#/c/261948/ The page you requested was not found, or you do not have permission to view this page. wtf??
[22:03:56] <wikibugs>	 10MediaWiki-Redirects: $wgMaxRedirects does not appear to work as intended - https://phabricator.wikimedia.org/T122771#1913712 (10Fomafix) @Mdann52 What does not work with $wgMaxRedirects > 1? What do you expect how it should work?
[22:04:01] <Reedy>	 WFM
[22:04:09] <mhutti1>	 legoktm: ? I can see
[22:04:21] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "Nice work :)" [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[22:04:22] <legoktm>	 wtf
[22:04:26] <legoktm>	 Reedy: could you +2 it then?
[22:04:36] <legoktm>	 works for me in private browsing...
[22:04:37] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/262157 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:05:31] <Reedy>	 The page you requested was not found, or you do not have permission to view this page.
[22:05:32] <Reedy>	 wut
[22:06:11] <Reedy>	 https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/GoogleNewsSitemap,access
[22:06:19] <mhutti1>	 Try again i added you as review
[22:06:36] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[22:06:42] <Reedy>	 It's not that
[22:06:42] <legoktm>	 km@km-tp ~> bash plustwo.sh 261948,5
[22:06:45] <legoktm>	 whatever
[22:07:16] <legoktm>	 km@km-tp ~> cat plustwo.sh 
[22:07:16] <legoktm>	 ssh gerrit.wikimedia.org -p 29418 gerrit review $1 --code-review 2
[22:07:17] <legoktm>	 hehe
[22:07:32] <mhutti1>	 whatever happened also kicked lego as a review on the patch as well
[22:07:39] <Reedy>	 Has jenkins died
[22:08:08] <legoktm>	 just slow
[22:08:11] <James_F>	 Reedy: Just… yeah.
[22:10:50] <wikibugs>	 10MediaWiki-Redirects: $wgMaxRedirects does not appear to work as intended - https://phabricator.wikimedia.org/T122771#1913714 (10Mdann52) So what happens is that the expected behaviour should be it follows X redirects (so if x=2, it will go a>b>c), however currently it only follows one (and shows the redirect p...
[22:10:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Import: Try to stop revisions getting created with rev_page = 0 [core] - 10https://gerrit.wikimedia.org/r/262078 (https://phabricator.wikimedia.org/T18674) (owner: 10TTO)
[22:11:22] <Reedy>	 there he goes
[22:12:08] <unicornisaurous>	 Theres a failed build at the top of zend gate-and-submit, shouldn’t that be going somewhere?
[22:12:21] <FlorianSW_>	 Reedy: thanks for clearing my open change list :)
[22:12:30] <Reedy>	 Still quite a lot
[22:12:33] <Reedy>	 to do
[22:12:35] <FlorianSW_>	 unicornisaurous: it will take a bit of time
[22:13:29] <unicornisaurous>	 Okay, it just looks like things aren’t clearing zuul
[22:13:57] * James_F glares at RPED.
[22:14:02] <Reedy>	 jenkins does look pretty idle
[22:14:11] <James_F>	 It might need a kick.
[22:14:33] <legoktm>	 zuul looks stuck
[22:14:55] <legoktm>	 that weird gerrit change might have messed with it
[22:15:32] <Reedy>	 This is why we shouldn't keep these shitty repos about
[22:15:33] <Reedy>	 :D
[22:15:38] <mhutti1>	 lego did  you mean to update the commit message twice or was it a bug?
[22:15:51] <legoktm>	 bug
[22:15:58] <legoktm>	 I might have hit save twice or something
[22:16:08] <Reedy>	 Or gerrit sucks
[22:16:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/262116 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/262115 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:24] <mhutti1>	 yey +2 on a patch :) Its working slowly
[22:16:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/YetAnotherKeywords] - 10https://gerrit.wikimedia.org/r/262128 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/262135 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/OpenStreetMapSlippyMap] - 10https://gerrit.wikimedia.org/r/262147 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Poll] - 10https://gerrit.wikimedia.org/r/262176 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/RT] - 10https://gerrit.wikimedia.org/r/262183 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/ParserFun] - 10https://gerrit.wikimedia.org/r/262165 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/262163 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/RelationLinks] - 10https://gerrit.wikimedia.org/r/262168 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:16:43] <unicornisaurous>	 oh hello there jenkins, nice to see you again
[22:16:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/262174 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:17:11] <Reedy>	 lolol
[22:17:27] <legoktm>	 in conclusion, it was "just slow"
[22:17:48] <unicornisaurous>	 So nobody kicked it?
[22:18:20] <legoktm>	 nope
[22:18:33] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfmsg* calls [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/262130 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:18:33] <FlorianSW_>	 I see this far often in my own instance of zuul, especially in a submit queue, zuul takes a very very long time, when a change doesn't pass all jenkins tests and there are other passed changes :/
[22:20:27] <wikibugs>	 10MediaWiki-Vagrant: 'vagrant share' does not work with MediaWiki-Vagrant with a non-default port - https://phabricator.wikimedia.org/T122773#1913727 (10Tgr) 3NEW
[22:21:35] <MtDu>	 Reedy: There's more to do? 
[22:21:44] <Reedy>	 MtDu: More code revieew
[22:21:49] <MtDu>	 Reedy: I see. 
[22:22:01] <Reedy>	 21 commits I think
[22:22:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: registration: Allow setting $wgFeedClasses in extension.json [core] - 10https://gerrit.wikimedia.org/r/262239 (https://phabricator.wikimedia.org/T122770) (owner: 10Mhutti1)
[22:22:03] <Reedy>	 Some are pretty big
[22:22:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/262157 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:22:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1)
[22:22:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfmsg* calls [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/262130 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:22:13] <Reedy>	 He's off again
[22:22:15] <mhutti1>	 Yey ^
[22:22:23] <MtDu>	 Nice! 
[22:23:16] <wikibugs>	 10MediaWiki-Vagrant, 7Upstream: 'vagrant share' does not work with MediaWiki-Vagrant with a non-default port - https://phabricator.wikimedia.org/T122773#1913738 (10Tgr) There does not seem to be a general way in Vagrant to modify the behavior of a default command. `vagrant share` is apparently not opensource a...
[22:23:17] <wikibugs>	 10MediaWiki-extensions-GoogleNewsSitemap, 3Google-Code-In-2015, 5Patch-For-Review: Convert GoogleNewsSitemap to use extension registration - https://phabricator.wikimedia.org/T87926#1913741 (10Legoktm)
[22:23:19] <wikibugs>	 10MediaWiki-Configuration, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: extension.json should allow setting $wgFeedClasses - https://phabricator.wikimedia.org/T122770#1913740 (10Legoktm) 5Open>3Resolved
[22:23:45] <wikibugs>	 10MediaWiki-extensions-GoogleNewsSitemap, 3Google-Code-In-2015, 5Patch-For-Review: Convert GoogleNewsSitemap to use extension registration - https://phabricator.wikimedia.org/T87926#1913742 (10Mhutti1) 5Open>3Resolved
[22:23:51] <wikibugs>	 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1913743 (10Mhutti1)
[22:24:38] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/262180 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:25:00] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/262178 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:25:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/262180 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:25:27] <legoktm>	 mhutti1: yay :)
[22:25:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/262178 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:25:51] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/262158 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:26:03] <legoktm>	 https://tools.wmflabs.org/extreg-wos/ we're pretty close to 200
[22:26:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/262158 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:27:14] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/262121 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:27:23] <FlorianSW_>	 Reedy: If some are too big to review in one change, let me know and I split them into two or more :)
[22:27:35] <FlorianSW_>	 But now I need to go to bed, good night all! :D
[22:27:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/262121 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:29:55] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/262123 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:29:57] <MtDu>	 FlorianSW_: Good night! Great job. :)
[22:30:18] <James_F>	 Bye FlorianSW_.
[22:30:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/262123 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:30:31] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Replace Title::userIsWatched [wikimedia/wlm-api] - 10https://gerrit.wikimedia.org/r/262103 (https://phabricator.wikimedia.org/T122754) (owner: 10Florianschmidtwelzow)
[22:32:13] <wikibugs>	 10MediaWiki-Redirects: $wgMaxRedirects does not appear to work as intended - https://phabricator.wikimedia.org/T122771#1913752 (10Fomafix) When you create an article //c// and a redirect //b// pointing to //c// and a redirect //a// pointing to //b//.  When you now open title=a&redirect=no you get * with `$wgMaxR...
[22:34:35] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262124 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:35:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/262124 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:35:53] <unicornisaurous>	 I think jenkins might have been something other than “just slow”: https://tools.wmflabs.org/nagf/?project=integration
[22:36:11] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/ArticleComments] - 10https://gerrit.wikimedia.org/r/262127 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:36:37] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/262139 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:36:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/ArticleComments] - 10https://gerrit.wikimedia.org/r/262127 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:37:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/262139 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:37:36] <MtDu>	 Reedy: You still there? 
[22:37:52] <unicornisaurous>	 well he just reviewed something
[22:39:10] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/262162 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:39:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/PdfExport] - 10https://gerrit.wikimedia.org/r/262162 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:40:07] <legoktm>	 unicornisaurous: the actual jenkins and zuul server don't live in labs (they're on gallium), the servers that run the jobs are in the "integration" labs project
[22:40:09] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/262138 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:40:28] <unicornisaurous>	 Well they don’t look to be having a good evening
[22:40:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/262138 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:41:20] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/262144 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:41:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/262144 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:42:37] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Comments] - 10https://gerrit.wikimedia.org/r/262145 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:43:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Comments] - 10https://gerrit.wikimedia.org/r/262145 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:43:47] <grrrit-wm>	 (03PS2) 10Reedy: Replace wfMsg* calls [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262149 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:43:53] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262149 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:44:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/262149 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:44:40] <grrrit-wm>	 (03PS2) 10Reedy: Replace wfMsg* calls [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262155 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:44:45] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262155 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:45:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262155 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:46:51] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/262167 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:47:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/262167 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:49:00] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/262173 (owner: 10Florianschmidtwelzow)
[22:49:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/262173 (owner: 10Florianschmidtwelzow)
[22:50:14] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262182 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:50:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262182 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:51:49] <MtDu>	 Reedy: Are you busy? 
[22:51:58] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Replace wfMsg* calls [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/262161 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:52:10] <grrrit-wm>	 (03CR) 10Reedy: [V: 032] Replace wfMsg* calls [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/262166 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:52:46] <andre__>	 If grrrit-wm does not lie, it looks like. :P
[22:53:13] <MtDu>	 andre__: Yep. 
[22:55:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace wfMsg* calls [extensions/FlvHandler] - 10https://gerrit.wikimedia.org/r/262161 (https://phabricator.wikimedia.org/T70750) (owner: 10Florianschmidtwelzow)
[22:55:49] <unicornisaurous>	 I bet he is trying to merge everything before he goes to bed
[23:00:17] <MtDu>	 unicornisaurous: Yep. Me too. I think they want to get this done ASAP. 
[23:00:41] <grrrit-wm>	 (03PS1) 10Reedy: Remove wfMsg*() methods [core] - 10https://gerrit.wikimedia.org/r/262245 (https://phabricator.wikimedia.org/T70750) 
[23:00:52] <unicornisaurous>	 Well I think its a low priority task they just want to get over with :P
[23:00:59] <Reedy>	 Trying to prevent rebase hell :P
[23:01:08] <Reedy>	 It's seriously low hanging fruit
[23:01:28] <MtDu>	 Reedy: I know man. :p
[23:01:49] <MtDu>	 Reedy: If I did one of the tasks you were a mentor on, would you be able to take a look at it tonight? Or would you be sleeping after this? 
[23:02:19] <Reedy>	 How long would it take you? :P
[23:02:34] <Reedy>	 I'm planning on going to bed, and doing some backlogged reading
[23:02:44] <MtDu>	 Reedy: Not long. It'll be like 5 min till I can push it? 
[23:02:52] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-2] "-2 until I've had to update all my clones etc and checked things" [core] - 10https://gerrit.wikimedia.org/r/262245 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy)
[23:03:05] * unicornisaurous mumbles something about easy tasks
[23:03:08] <MtDu>	 Reedy: It's one of the split a class into different files ones. Do I just push it to mediawiki? 
[23:05:12] <Reedy>	 push it to mediawiki?
[23:05:28] <MtDu>	 Like if the file is in mediawiki, ex. the autoload php
[23:05:35] <MtDu>	 And the rest are in a folder in mediawiki. 
[23:05:53] <MtDu>	 So autoload is in mediawiki and the other files are in a folder which is inside mediawiki. 
[23:05:57] <unicornisaurous>	 It shouldn’t matter
[23:06:01] <MtDu>	 So do I just cd into mediawiki and push it? 
[23:06:37] <unicornisaurous>	 You should be able to push from anywhere in the core repo
[23:07:21] <MtDu>	 Reedy: Alright. just claimed it. Will push very soon. 
[23:08:11] <grrrit-wm>	 (03CR) 10Gergő Tisza: Move grant and IP restriction logic from OAuth to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259062 (owner: 10Anomie)
[23:12:21] <grrrit-wm>	 (03PS1) 10MtDu: Split SearchResultSet.php classes [core] - 10https://gerrit.wikimedia.org/r/262249 (https://phabricator.wikimedia.org/T122637) 
[23:12:34] <MtDu>	 Reedy: There it is. :)
[23:19:00] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Split SearchResultSet.php classes [core] - 10https://gerrit.wikimedia.org/r/262249 (https://phabricator.wikimedia.org/T122637) (owner: 10MtDu)
[23:25:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split SearchResultSet.php classes [core] - 10https://gerrit.wikimedia.org/r/262249 (https://phabricator.wikimedia.org/T122637) (owner: 10MtDu)
[23:26:45] <MtDu>	 Reedy: I submitted the task. Can you approve it before you sleep?
[23:38:53] <MtDu_>	 Reedy: It's merged now. Did you get my submission? Thanks! :)
[23:39:50] <MtDu_>	 Reedy: Do I need to claim it on Phabricator? 
[23:40:00] <MtDu_>	 Reedy: So you can resolve it or whatever? 
[23:40:06] <Reedy>	 If you resolve the task on phab it'll assign it to you
[23:40:56] <wikibugs>	 10MediaWiki-Search, 6Discovery, 3Google-Code-In-2015, 5Patch-For-Review: Split PHP classes from SearchResultSet.php into separate files - https://phabricator.wikimedia.org/T122637#1913786 (10MtDu) 5Open>3Resolved
[23:41:03] <MtDu_>	 Reedy: Resolved it. 
[23:41:30] <Reedy>	 Approved in GCI
[23:41:40] <MtDu_>	 Reedy: Thanks. :) Are you sleeping now? 
[23:41:55] <Reedy>	 If I was sleep IRC-ing that'd be pretty cool ;)
[23:42:12] <MtDu_>	 Reedy: If not, I'll do another one real quick. :)
[23:42:43] <MtDu_>	 Reedy: It's really weird having tests taking that long. I've never pushed to core before. 
[23:42:52] <Reedy>	 heh
[23:42:54] <Reedy>	 I need to go to bed, and sort some other problems
[23:43:07] <Reedy>	 If you do another, I'll be able to review in probably 12 hours or so
[23:43:41] <MtDu_>	 Reedy: Alright. Thanks for being a mentor and helping me out. Also, great work. Get some rest. :) 
[23:45:39] <MtDu_>	 Reedy: I'll see you tomorrow. 
[23:51:25] <wikibugs>	 10MediaWiki-Search, 6Discovery, 3Google-Code-In-2015, 5Patch-For-Review: Split PHP classes from SearchResultSet.php into separate files - https://phabricator.wikimedia.org/T122637#1913789 (10MtDu) a:3MtDu
[23:55:45] <wikibugs>	 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1913791 (10josephine_l) Thanks @NiharikaKohli :) No worries, I just didn't know if the description was the right place to ping since I've only...