[00:02:33] (03Merged) 10jenkins-bot: mw.Upload.BookletLayout: Don't show file extension in the filename input [core] - 10https://gerrit.wikimedia.org/r/261273 (owner: 10Bartosz Dziewoński) [00:02:39] (03Merged) 10jenkins-bot: mw.Upload.BookletLayout: Add help text for name and description fields [core] - 10https://gerrit.wikimedia.org/r/253550 (https://phabricator.wikimedia.org/T116086) (owner: 10Prtksxna) [00:02:44] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261814 (owner: 10Reedy) [00:02:46] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261812 (owner: 10Reedy) [00:02:48] (03Merged) 10jenkins-bot: PSR-0 -> PSR-4 [vendor] - 10https://gerrit.wikimedia.org/r/261770 (owner: 10Reedy) [00:02:50] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/261867 (owner: 10Reedy) [00:02:52] (03Merged) 10jenkins-bot: Fix protected member variable access [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261872 (owner: 10Reedy) [00:04:58] it's alive! ori and legoktm seem to have gotten the lost workers to join back up with Jenkins and get zuul unstuck [00:09:06] 6RevisionScoringAsAService: Urdu language utilities - https://phabricator.wikimedia.org/T120172#1912349 (10MuhammadShuaib) >>! In T120172#1852588, @Ladsgroup wrote: > https://tools.wmflabs.org/dexbot/ur_bad_words.txt > > https://tools.wmflabs.org/dexbot/ur_stop_words.txt These files seem to have wrongly encode... [00:09:46] 10MediaWiki-Configuration, 5MW-1.27-release: Support $wgAction in extension registration - https://phabricator.wikimedia.org/T117197#1912351 (10Legoktm) 5Open>3Invalid a:3Legoktm The variable is actually named `$wgActions` ([[https://www.mediawiki.org/wiki/Manual:$wgActions|doc]]) and is supported in the... [00:13:02] 10MediaWiki-Configuration: Make name field optional in extension.json - https://phabricator.wikimedia.org/T113509#1912354 (10Legoktm) 5Open>3declined a:3Legoktm The `name` field is required because the ExtensionRegistry uses it to determine what is already loaded. [00:14:48] 10MediaWiki-Configuration, 10MediaWiki-ResourceLoader, 5MW-1.27-release-notes, 5Patch-For-Review: extension.json schema does not support custom parameters/classes for "ResourceModules" - https://phabricator.wikimedia.org/T105236#1912358 (10Legoktm) 5Open>3Resolved [00:15:38] 10MediaWiki-Configuration: convertExtensionToRegistration missed a localBasePath/remoteBasePath setting - https://phabricator.wikimedia.org/T104934#1912359 (10Legoktm) 5Open>3Invalid a:3Legoktm Please re-open if it's doing incorrect things. [00:15:59] 10MediaWiki-Configuration, 10MediaWiki-Maintenance-scripts: Warning: array_key_exists() in maintenance/convertExtensionToRegistration.php - https://phabricator.wikimedia.org/T101003#1912362 (10Legoktm) 5Open>3stalled [00:16:29] 10MediaWiki-Configuration, 7Documentation, 7Easy, 5MW-1.25-release, and 2 others: Wrong comment in the generated LocalSettings.php about how to enable new extensions - https://phabricator.wikimedia.org/T100940#1912363 (10Legoktm) 5Open>3Resolved a:3Legoktm [00:54:26] 6RevisionScoringAsAService: Urdu language utilities - https://phabricator.wikimedia.org/T120172#1912375 (10Ladsgroup) you need to either download them and open it with notepad (gedit, or anything suitable) **or** in your browser check for encoding option (probably in view menu) and choose "UTF-8" or "Unicode" T... [01:00:10] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1912376 (10Aklapper) As an outcome of {T101686} I have collected a bunch of potential Code Review factors and potential {social, technical, organizational} actions on https://www.media... [01:16:09] 6RevisionScoringAsAService: Edit quality campaign for Khowar Wikipedia - https://phabricator.wikimedia.org/T122725#1912388 (10Liuxinyu970226) FWIW, Khowar Wikipedia is still testing on [[ https://incubator.wikimedia.org/wiki/Wp/khw | Incubator ]]. [01:19:36] 7Design, 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, and 4 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1912390 (10Jdforrester-WMF) Can we deem this fixed? [01:33:56] (03PS1) 10PranavK: Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) [01:39:15] legoktm: I need some help with extension registration [01:39:44] legoktm: Can you please help me? [01:48:44] (03CR) 10Mattflaschen: [C: 04-1] Clarify loss of internet connection as source of error in error message (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261809 (https://phabricator.wikimedia.org/T118680) (owner: 10MtDu) [01:50:41] (03PS1) 10Legoktm: Set manifest_version in extension.json [extensions/cldr] - 10https://gerrit.wikimedia.org/r/261880 (https://phabricator.wikimedia.org/T100745) [01:50:50] (03PS1) 10Legoktm: Set manifest_version in extension.json [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/261881 (https://phabricator.wikimedia.org/T100745) [01:50:54] (03PS1) 10Legoktm: Set manifest_version in extension.json [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/261882 (https://phabricator.wikimedia.org/T100745) [01:50:58] (03PS1) 10Legoktm: Set manifest_version in extension.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/261883 (https://phabricator.wikimedia.org/T100745) [01:52:54] (03PS1) 10Legoktm: Use valid spdx license identifier [extensions/Petition] - 10https://gerrit.wikimedia.org/r/261884 [01:53:07] (03PS4) 10MtDu: Clarify loss of internet connection as source of error in error message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261809 (https://phabricator.wikimedia.org/T118680) [01:53:41] Mattflaschen: Is it better now? :) [01:54:16] matt_flaschen: Is it better now? :) [01:54:21] (03PS1) 10Legoktm: Use valid spdx license identifier [extensions/ShoutWikiAPI] - 10https://gerrit.wikimedia.org/r/261885 [01:54:47] pranavk_: I'm about to go out right now, if you leave your comments on gerrit or phabricator, I will take a look when I get home in about 5 hours. [01:55:13] legoktm: sure, I just wanted to make sure what i did was right: https://gerrit.wikimedia.org/r/#/c/261879/ [02:00:21] (03CR) 10MtDu: Convert SubpageSortkey to use extension registration (031 comment) [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [02:02:28] (03CR) 10Mattflaschen: [C: 032] Clarify loss of internet connection as source of error in error message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261809 (https://phabricator.wikimedia.org/T118680) (owner: 10MtDu) [02:02:42] MtDu, yep, thanks. [02:03:13] matt_flaschen: Thanks for pointing that out. [02:03:25] (03CR) 10MtDu: Convert SubpageSortkey to use extension registration (031 comment) [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [02:06:07] (03Merged) 10jenkins-bot: Clarify loss of internet connection as source of error in error message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261809 (https://phabricator.wikimedia.org/T118680) (owner: 10MtDu) [02:08:51] (03CR) 10Reedy: [C: 04-1] Convert SubpageSortkey to use extension registration (031 comment) [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [02:11:54] (03CR) 10Reedy: [C: 032 V: 032] Don't use User::getSkin() [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261813 (owner: 10Reedy) [02:15:19] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1912403 (10josephine_l) Thanks! I will get started on that as soon as I can get the bug in this week's task ironed out. [02:17:09] 10Commons-App-Android-Upload: Cache categories, establishing a short-lived area->categories dictionary - https://phabricator.wikimedia.org/T119282#1912404 (10josephine_l) [02:21:15] 10Wikimedia-Site-Requests, 5Patch-For-Review: User group rights changes on tr.wikiquote.org - https://phabricator.wikimedia.org/T122710#1912405 (10Mavrikant) I didnt know that we can rename groups on our wiki. Ok we will change that pages. Ops. I forget to write that change to local community but it should be... [02:21:28] 10Commons-App-Android-Upload: Implement recursive calls to the MediaWiki API until a certain number of categories are obtained - https://phabricator.wikimedia.org/T122568#1912406 (10josephine_l) [02:22:19] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1912407 (10josephine_l) [02:23:02] (03PS1) 10Yurik: Bumped vega2 lib [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261886 [02:23:33] (03CR) 10Yurik: [C: 032] Bumped vega2 lib [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261886 (owner: 10Yurik) [02:24:26] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/261887 [02:24:36] (03Merged) 10jenkins-bot: Bumped vega2 lib [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261886 (owner: 10Yurik) [02:26:33] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/261888 [02:28:44] 6Phabricator: Upgrade to "Projects V3" - https://phabricator.wikimedia.org/T120772#1912408 (10mmodell) Some early prototype work from projects V3 is now deployed on https://phab-01.wmflabs.org [02:29:11] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/261889 [02:29:59] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/261890 [02:31:01] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/261891 [02:31:53] 6Phabricator, 6Developer-Relations, 10Phabricator-Sprint-Extension, 6Release-Engineering-Team: Let's all stay in the loop on the Projects V3 update - https://phabricator.wikimedia.org/T120276#1912411 (10mmodell) The latest upstream changes are nearing a point of usability and I have deployed them to https:... [02:34:28] (03CR) 10Jforrester: [C: 032] mw.Upload.BookletLayout: Avoid serializing DOM to HTML and parsing it right back [core] - 10https://gerrit.wikimedia.org/r/260632 (owner: 10Bartosz Dziewoński) [02:34:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Hmm. I'll find out." [core] - 10https://gerrit.wikimedia.org/r/260583 (owner: 10Bartosz Dziewoński) [02:36:45] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261893 [02:40:07] (03PS1) 10Reedy: Don't use User::getSkin()\nBits of deglobalisation [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261894 [02:40:29] (03PS2) 10Reedy: Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261894 [02:43:20] (03PS1) 10Reedy: Fix private member variable access [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261895 [02:49:59] (03PS1) 10Reedy: User::getSkin() was removed [core] - 10https://gerrit.wikimedia.org/r/261896 [02:50:27] (03CR) 10Reedy: [C: 04-1] "Some patches to be merged still, and a few still to be made..." [core] - 10https://gerrit.wikimedia.org/r/261896 (owner: 10Reedy) [02:55:10] (03PS1) 10Reedy: Replace WikiPage::getUsedTemplates() call. [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/261897 [02:56:28] (03PS1) 10Reedy: WikiPage::getUsedTemplates() was removed [core] - 10https://gerrit.wikimedia.org/r/261898 [02:59:50] (03PS1) 10Reedy: Don't use wfEmptyMsg() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261899 [03:04:08] (03CR) 10Reedy: [C: 04-1] "Depends on https://gerrit.wikimedia.org/r/261897" [core] - 10https://gerrit.wikimedia.org/r/261898 (owner: 10Reedy) [03:05:18] (03PS1) 10Reedy: wfEmptyMsg() was removed [core] - 10https://gerrit.wikimedia.org/r/261901 [03:06:35] (03CR) 10Reedy: [C: 04-1] "Depends on https://gerrit.wikimedia.org/r/261899 and https://gerrit.wikimedia.org/r/261900" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261901 (owner: 10Reedy) [03:06:57] ori: ^ Prep to get rid of 3 more long deprecated functions [03:07:52] (03CR) 10Hoo man: "AFAIR" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261901 (owner: 10Reedy) [03:09:19] (03CR) 10Reedy: wfEmptyMsg() was removed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261901 (owner: 10Reedy) [03:18:40] 10Wikimedia-Site-Requests, 5Patch-For-Review: Prevent indexing of User: namespace on uawikimedia - https://phabricator.wikimedia.org/T122732#1912419 (10Base) [03:19:04] 10Wikimedia-Site-Requests, 5Patch-For-Review: Prevent indexing of User: namespace on uawikimedia - https://phabricator.wikimedia.org/T122732#1912289 (10Base) Lazy @gerritbot. https://gerrit.wikimedia.org/r/#/c/261902/ [03:25:21] (03CR) 1020after4: [C: 032] Gerrit: /r/project redirect paths are public [phabricator/extensions] - 10https://gerrit.wikimedia.org/r/261725 (https://phabricator.wikimedia.org/T122674) (owner: 10Alex Monk) [03:27:38] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912427 (10scfc) [03:36:13] 6Phabricator, 5Patch-For-Review: Make all /r/project/* paths in phabricator accessible without login - https://phabricator.wikimedia.org/T122674#1912430 (10mmodell) 5Open>3Resolved I've just deployed @krenair's patch and it fixed the issue. [03:43:16] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1912438 (10josephine_l) [03:48:22] 6Phabricator: Phabricator Task Daemon has problems - https://phabricator.wikimedia.org/T122408#1912440 (10mmodell) @luke081515: Where do you see "task daemon not running?" Can you link to it? [03:51:53] 6Phabricator: Understand phabricator scalability (a.k.a. avoiding Phabricator's 503s) - https://phabricator.wikimedia.org/T112776#1912441 (10mmodell) I think the root cause of connection spikes is usually misbehaving search indexers, either hitting pages that they shouldn't (excluded in robots.txt) or hitting us... [03:55:15] 6Phabricator, 10Phabricator-Upstream: Make new tasks within a specific project use a template in description field - https://phabricator.wikimedia.org/T91538#1912443 (10mmodell) See https://phab-01.wmdlabs.org which has been updated with the forms code. It does seem feasible to implement this now (as soon as w... [04:00:01] (03PS2) 10Mattflaschen: Update MessagePoster topic title docs [core] - 10https://gerrit.wikimedia.org/r/261794 [04:02:22] (03CR) 10Mattflaschen: "Thanks, Legoktm. Good suggestion, done." [core] - 10https://gerrit.wikimedia.org/r/261794 (owner: 10Mattflaschen) [04:04:06] (03CR) 10Jack Phoenix: [C: 032] Don't use User::getSkin() [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/261891 (owner: 10Reedy) [04:07:06] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/261891 (owner: 10Reedy) [04:07:30] (03CR) 10Ori.livneh: [C: 032] Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261893 (owner: 10Reedy) [04:07:41] (03CR) 10Ori.livneh: [C: 032] Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261894 (owner: 10Reedy) [04:07:59] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261893 (owner: 10Reedy) [04:08:03] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261894 (owner: 10Reedy) [04:33:23] (03PS2) 10PranavK: Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) [04:40:21] (03CR) 10MtDu: "PranavK," [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [04:45:39] (03PS3) 10PranavK: Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) [04:46:38] (03CR) 10PranavK: "MtDu: Yeah, I was just working on it! :) Hope it's fixed now!" [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [04:48:32] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1912455 (10josephine_l) [04:55:40] (03CR) 10MtDu: "Some more thoughts. :)" (034 comments) [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [05:23:09] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1912457 (10mmodell) >>! In T114419#1912376, @Aklapper wrote: > * and only if we have time left, [[ https://www.mediawiki.org/wiki/User:AKlapper_%28WMF%29/Code_Review#Hard_to_identify_g... [05:35:51] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912458 (10Krenair) >>! In T122733#1912425, @scfc wrote: > `wikitech` claims that it has "successfully modified" the instance when it hasn't... [05:54:18] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912459 (10Krenair) Ah, no, actually, after playing around with the code live on silver, I think I see what's going wrong here. [06:06:56] (03PS1) 10Alex Monk: NovaPrivateHost: Ensure puppetclass/puppetvar LDAP attributes get modified [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/261906 (https://phabricator.wikimedia.org/T122733) [06:07:18] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure, 5Patch-For-Review: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912463 (10Krenair) a:3Krenair [06:09:38] (03PS1) 10JadeMaveric: 18n: Reword some Wikidata/Wikibase system messages (Wikimedia) [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 [06:11:04] (03CR) 10JadeMaveric: "recheck" [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/261907 (owner: 10JadeMaveric) [06:29:10] (03CR) 10Tim Landscheidt: NovaPrivateHost: Ensure puppetclass/puppetvar LDAP attributes get modified (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/261906 (https://phabricator.wikimedia.org/T122733) (owner: 10Alex Monk) [06:30:34] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure, 5Patch-For-Review: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912464 (10scfc) So looking at the code you mean that the bug always existed, but noone encountered it? (Which would b... [06:33:04] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure, 5Patch-For-Review: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912466 (10yuvipanda) Yeah, and removing all puppet classes is also only very recently possible since we used to includ... [06:36:43] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure, 5Patch-For-Review: Cannot remove all Puppet classes from a Labs instance - https://phabricator.wikimedia.org/T122733#1912467 (10scfc) Ah, yes, that was in LDAP. Makes sense. [06:53:54] (03PS1) 10Legoktm: registration: Handle $wgExtensionCredits inside the ExtensionProcessor [core] - 10https://gerrit.wikimedia.org/r/261908 (https://phabricator.wikimedia.org/T108269) [07:06:32] (03CR) 10Legoktm: "Why not put the file_exists call into the conversion script? checkComposerLockUpToDate.php already has file_exists calls." [core] - 10https://gerrit.wikimedia.org/r/261633 (https://phabricator.wikimedia.org/T119766) (owner: 10Florianschmidtwelzow) [07:13:51] (03PS1) 10Legoktm: registration: Allow setting $wgCentralIdLookupProviders [core] - 10https://gerrit.wikimedia.org/r/261909 [07:14:26] (03CR) 10Legoktm: Add a central ID lookup service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/254300 (https://phabricator.wikimedia.org/T111302) (owner: 10Anomie) [07:14:56] (03PS2) 10Legoktm: registration: Allow setting $wgCentralIdLookupProviders [core] - 10https://gerrit.wikimedia.org/r/261909 [07:28:55] hello [07:32:55] (03CR) 10Legoktm: [C: 04-1] "See inline comments" (033 comments) [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) (owner: 10PranavK) [07:33:54] (03CR) 10Legoktm: [C: 032] Update MessagePoster topic title docs [core] - 10https://gerrit.wikimedia.org/r/261794 (owner: 10Mattflaschen) [07:38:49] (03Merged) 10jenkins-bot: Update MessagePoster topic title docs [core] - 10https://gerrit.wikimedia.org/r/261794 (owner: 10Mattflaschen) [08:04:42] Hello...I am Aswathy [08:08:46] hello, aswathy [08:08:55] hi [08:10:10] 10CirrusSearch, 6Discovery: URL internal links are hardly searchable - https://phabricator.wikimedia.org/T121379#1912489 (10Cpiral) [08:18:26] aswathy: Hi! Are you a Google Code-In student? [08:18:35] yes [08:20:08] aswathy: Welcome! [08:20:19] thankyou [08:22:07] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1912490 (10josephine_l) [08:25:01] I have selected the task 'get on IRC'.....is this the correct procedure what I am doing? [08:26:09] aswathy: Yes, well, you are here and talking to us :) Be sure to stay on IRC for at least 1 hour in order to complete the task. [08:26:23] What tasks do you think you will take up next? [08:26:28] okay thankyou [08:27:05] Well, I would like to take something related to C++. [08:39:51] hello, tto [08:40:21] aswathy: I think Huggle is written in C++ so you might want to look at some of the Huggle tasks. [08:40:25] victorbarbu_: Hi! [08:40:44] aswathy, yes Huggle is written in C++ with Qt [08:40:54] tto, I managed to create the interface [08:40:57] and the form submission [08:41:11] I have one more page to rewrite [08:41:19] but I have another problem [08:41:45] should the submit callback of an HTMLForm (PHP) be static? [08:41:51] it reports that $this is null [08:41:57] oh okay...i will select that...thankyou [08:43:25] victorbarbu_: Not necessarily [08:43:35] Maybe pastebin your PHP code so I can have a look [08:44:07] there you go https://dpaste.de/MgJA [08:45:15] victorbarbu_, you'll be wanting to put $this as the first element of the array passed to setSubmitCallback [08:47:22] array( $this, 'SpecialViewByLanguage', 'showSpellings' ) [08:47:24] like this? [08:47:36] array( $this, 'showSpellings' ) [08:47:44] oh [08:47:49] oooh, I get it now [08:54:37] tto, what do you think about this? http://imgur.com/a/S6QLE [08:55:49] victorbarbu_: Looks good! [08:55:56] I see you got the i18n messages sorted out? [08:56:02] yes [08:56:52] How did you do it, just from curiosity? [08:57:34] I added all of these 'jquery.uls', 'oojs-ui', 'jquery.i18n', 'mediawiki.jqueryMsg', 'ext.uls.messages', 'ext.SpellingDictionary.styles' [08:57:40] as dependencies [08:57:50] I don't know which of them does the job, because of the damn cache [08:57:53] but it works [08:58:29] Most likely all of 'jquery.i18n', 'mediawiki.jqueryMsg', 'ext.uls.messages' are required [08:58:53] yeah, probably [09:00:23] Looks like you're practically done then! [09:00:51] Yep, I have the submit-word page left which will take about half an hour, I hope [09:03:50] tto, hi! [09:04:07] Georggi, hi [09:04:08] Georggi: Hi! [09:04:10] can you give me a page to export? [09:04:16] hi victorbaru_ [09:04:23] Georggi: You can use Main Page if you want [09:04:44] Just type Main Page in the big textbox on Special:Export [09:06:21] I have stayed on IRC for about 1 hour I think...now can submit this task? [09:06:43] don't forget to add your IRC nick [09:08:13] tto, so it looks like this 6 7 -2... [09:08:32] I guess it has to be in id order? [09:09:06] Georggi: Yes, I actually need to make some comments on the code. Just hold on a minute or two [09:09:24] (03CR) 10Legoktm: [C: 032] Replace WikiPage::getUsedTemplates() call. [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/261897 (owner: 10Reedy) [09:09:56] (03CR) 10Legoktm: [C: 032] WikiPage::getUsedTemplates() was removed [core] - 10https://gerrit.wikimedia.org/r/261898 (owner: 10Reedy) [09:10:01] (03Merged) 10jenkins-bot: Replace WikiPage::getUsedTemplates() call. [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/261897 (owner: 10Reedy) [09:10:24] (03CR) 10Legoktm: [C: 032] Fix private member variable access [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261895 (owner: 10Reedy) [09:10:46] I have submitted my task but it says "Your work is currently being reviewed by your mentor. When the mentor accepts your work, you will then be able to choose another task to work on." [09:11:06] __DIR__ or dirname ( __FILE__ ) ? which one is recommended [09:11:07] ? [09:11:18] (03CR) 10Legoktm: [C: 032] Don't use User::getSkin() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/261890 (owner: 10Reedy) [09:11:31] aswathy, so that's it. now you have to wait for your mentor to accept the task [09:11:42] okay [09:11:44] (03CR) 10Legoktm: [C: 032] Don't use User::getSkin() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/261889 (owner: 10Reedy) [09:12:33] (03CR) 10Legoktm: [C: 032] Don't use User::getSkin() [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/261888 (owner: 10Reedy) [09:13:33] (03CR) 10Legoktm: [C: 04-1] "Uhh, why not $this->getSkin()?" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/261887 (owner: 10Reedy) [09:14:12] (03CR) 10Legoktm: "Actually the $sk variable is unused..." [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/261887 (owner: 10Reedy) [09:16:38] Reedy: +397, -475 nice :D [09:16:42] (03CR) 10Legoktm: [C: 032] Fixup excessive indenting [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261876 (owner: 10Reedy) [09:16:59] (03Merged) 10jenkins-bot: WikiPage::getUsedTemplates() was removed [core] - 10https://gerrit.wikimedia.org/r/261898 (owner: 10Reedy) [09:17:01] (03Merged) 10jenkins-bot: Fix private member variable access [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261895 (owner: 10Reedy) [09:17:04] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/261890 (owner: 10Reedy) [09:17:06] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/261889 (owner: 10Reedy) [09:17:08] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/261888 (owner: 10Reedy) [09:17:26] (03Merged) 10jenkins-bot: Fixup excessive indenting [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261876 (owner: 10Reedy) [09:19:53] (03CR) 10Legoktm: [C: 032] Use Maintenance DB transaction methods [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/261787 (owner: 10Aaron Schulz) [09:20:08] (03CR) 10Legoktm: [C: 032] Use Maintenance DB transaction methods [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/261784 (owner: 10Aaron Schulz) [09:20:17] (03CR) 10Legoktm: [C: 032] Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261783 (owner: 10Aaron Schulz) [09:20:33] (03CR) 10Legoktm: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261782 (owner: 10Aaron Schulz) [09:20:38] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/261787 (owner: 10Aaron Schulz) [09:20:40] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/261784 (owner: 10Aaron Schulz) [09:22:16] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261783 (owner: 10Aaron Schulz) [09:24:06] (03CR) 10Legoktm: [C: 032] Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261782 (owner: 10Aaron Schulz) [09:24:43] (03CR) 10Legoktm: [C: 032] Use Maintenance DB transaction methods [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/261781 (owner: 10Aaron Schulz) [09:25:17] (03CR) 10Legoktm: [C: 032] Use Maintenance DB transaction methods [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/261780 (owner: 10Aaron Schulz) [09:25:47] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261782 (owner: 10Aaron Schulz) [09:25:50] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/261781 (owner: 10Aaron Schulz) [09:25:52] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/261780 (owner: 10Aaron Schulz) [09:26:04] legoktm, who has the rights to approve the creation of a new repo in gerrit? [09:26:24] did you make a request on-wiki? [09:26:31] (03CR) 10Legoktm: [C: 04-1] Add largest allowed range as parameter to block form message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261776 (owner: 10Gergő Tisza) [09:26:52] ankita said she did for the SpellingDictionary [09:27:04] and I was wondering whether is was approved or not [09:28:22] according to https://www.mediawiki.org/wiki/Git/New_repositories/Requests not yet [09:28:38] qchris typically does them, but he might not be around due to holidays, etc. [09:29:25] Let me do them now... I wanted to go through the list today anyways ... [09:29:39] qchris, hello :) [09:29:44] thank you [09:29:51] legoktm, thank you for the info [09:29:57] :) np [09:30:14] I've almost finished my task [09:30:22] (03CR) 10Legoktm: [C: 032] Add summary back to echo web notifications [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/261774 (https://phabricator.wikimedia.org/T122663) (owner: 1001tonythomas) [09:30:49] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/Survey] - 10https://gerrit.wikimedia.org/r/261750 (owner: 10Aaron Schulz) [09:30:54] (03Merged) 10jenkins-bot: Add summary back to echo web notifications [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/261774 (https://phabricator.wikimedia.org/T122663) (owner: 1001tonythomas) [09:31:02] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261743 (owner: 10Aaron Schulz) [09:31:19] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/261742 (owner: 10Aaron Schulz) [09:31:21] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/Survey] - 10https://gerrit.wikimedia.org/r/261750 (owner: 10Aaron Schulz) [09:31:28] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/261740 (owner: 10Aaron Schulz) [09:31:35] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261743 (owner: 10Aaron Schulz) [09:31:38] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261737 (owner: 10Aaron Schulz) [09:31:48] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/261734 (owner: 10Aaron Schulz) [09:32:16] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/261742 (owner: 10Aaron Schulz) [09:32:18] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/261740 (owner: 10Aaron Schulz) [09:32:20] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/261733 (owner: 10Aaron Schulz) [09:32:26] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261737 (owner: 10Aaron Schulz) [09:32:31] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/Configure] - 10https://gerrit.wikimedia.org/r/261732 (owner: 10Aaron Schulz) [09:32:37] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/261734 (owner: 10Aaron Schulz) [09:32:46] (03CR) 10Legoktm: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/261730 (owner: 10Aaron Schulz) [09:33:34] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/261733 (owner: 10Aaron Schulz) [09:33:35] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/Configure] - 10https://gerrit.wikimedia.org/r/261732 (owner: 10Aaron Schulz) [09:33:37] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/261730 (owner: 10Aaron Schulz) [09:34:53] Krenair, are you here? [09:37:03] victorbarbu_: Done. [09:37:29] thank you@ [09:37:30] ! [09:37:30] Hello, I'm wm-bot. The database for this channel is published at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [09:38:20] (03CR) 10Legoktm: "What's the rationale for backporting this?" [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/261597 (https://phabricator.wikimedia.org/T119766) (owner: 10Paladox) [09:38:37] legoktm, ankita might not be available the next 2 days, but I've already finished my work [09:38:55] (03CR) 10Legoktm: [C: 032] Add more cases to MediaWikiTestCaseTest [core] - 10https://gerrit.wikimedia.org/r/261570 (https://phabricator.wikimedia.org/T122598) (owner: 10Addshore) [09:38:58] 10TimedMediaHandler: Provide API to detect TimedText for a video - https://phabricator.wikimedia.org/T122736#1912494 (10Schnark) 3NEW [09:39:05] if she is not available, who could accept my task? [09:39:11] victorbarbu_: ok, do you want me to review something? [09:39:16] maybe me, what's the task? [09:39:45] https://codein.withgoogle.com/dashboard/task-instances/5484394240278528/?sp-page=1 [09:39:46] Change language selection method in the Spelling Dictionary extension || 7 days || Code || Wikimedia || Currently claimed [09:44:08] (03Merged) 10jenkins-bot: Add more cases to MediaWikiTestCaseTest [core] - 10https://gerrit.wikimedia.org/r/261570 (https://phabricator.wikimedia.org/T122598) (owner: 10Addshore) [09:46:04] 10TimedMediaHandler: Broken URL for track element - https://phabricator.wikimedia.org/T122737#1912502 (10Schnark) 3NEW [09:50:14] (03PS19) 10Legoktm: build: Update mediawiki/mediawiki-codesniffer to 0.5.1 [core] - 10https://gerrit.wikimedia.org/r/248379 (owner: 10Paladox) [09:50:23] (03CR) 10Legoktm: [C: 032] build: Update mediawiki/mediawiki-codesniffer to 0.5.1 [core] - 10https://gerrit.wikimedia.org/r/248379 (owner: 10Paladox) [09:50:40] victorbarbu_: is there a patch associated with it? [09:50:56] not yet [09:51:00] will be in 10 minutes [09:52:30] (03PS12) 10Georggi199: Export: Added namespace aliases to siteinfo [core] - 10https://gerrit.wikimedia.org/r/261269 (https://phabricator.wikimedia.org/T64109) [09:54:00] (03CR) 10Legoktm: [C: 032] rebuildrecentchanges.php: Document a little bit [core] - 10https://gerrit.wikimedia.org/r/261315 (owner: 10Bartosz Dziewoński) [09:54:31] (03Abandoned) 10Legoktm: Convert OAI Extension to use extension registration [extensions/OAI] - 10https://gerrit.wikimedia.org/r/261324 (https://phabricator.wikimedia.org/T87948) (owner: 10PranavK) [09:57:34] 6Phabricator, 6Developer-Relations, 10Phabricator-Sprint-Extension, 6Release-Engineering-Team: Let's all stay in the loop on the Projects V3 update - https://phabricator.wikimedia.org/T120276#1912511 (10Christopher) Can you please reference what exactly you have deployed? I really have no idea what you ar... [10:00:31] Nemo_bis: Could you please unpublish https://codein.withgoogle.com/dashboard/tasks/4752218481754112/ ? It's a duplicate of another task [10:04:51] (03CR) 10jenkins-bot: [V: 04-1] build: Update mediawiki/mediawiki-codesniffer to 0.5.1 [core] - 10https://gerrit.wikimedia.org/r/248379 (owner: 10Paladox) [10:07:10] 10MediaWiki-Codesniffer, 5Patch-For-Review: Add sniff to detect double empty lines in php code - https://phabricator.wikimedia.org/T120570#1912514 (10Legoktm) No, we can have it as a local sniff for now. [10:08:01] (03CR) 10Legoktm: [C: 032] "try again..." [core] - 10https://gerrit.wikimedia.org/r/248379 (owner: 10Paladox) [10:09:54] (03PS4) 10PranavK: Convert SubpageSortkey to use extension registration [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/261879 (https://phabricator.wikimedia.org/T87975) [10:12:30] (03Merged) 10jenkins-bot: rebuildrecentchanges.php: Document a little bit [core] - 10https://gerrit.wikimedia.org/r/261315 (owner: 10Bartosz Dziewoński) [10:14:22] 6Phabricator, 6Developer-Relations, 10Phabricator-Sprint-Extension, 6Release-Engineering-Team: Let's all stay in the loop on the Projects V3 update - https://phabricator.wikimedia.org/T120276#1912516 (10Christopher) See also https://secure.phabricator.com/phame/post/view/754/development_notes_2015_week_52/ [10:18:57] legoktm: Can you please review https://gerrit.wikimedia.org/r/#/c/261879/ and tell me whether I need to make any more changes? [10:21:10] (03Merged) 10jenkins-bot: build: Update mediawiki/mediawiki-codesniffer to 0.5.1 [core] - 10https://gerrit.wikimedia.org/r/248379 (owner: 10Paladox) [10:22:08] (03PS1) 10Victorbarbu: Replace language selection dropdown with ULS [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) [10:24:35] (03CR) 10Victorbarbu: Replace language selection dropdown with ULS (031 comment) [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) (owner: 10Victorbarbu) [10:26:19] (03PS2) 10Victorbarbu: Replace language selection dropdown with ULS [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) [10:26:55] (03CR) 10Victorbarbu: "recheck" [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) (owner: 10Victorbarbu) [10:37:19] how can I see if jenkins is running tests on my change? [10:38:11] victorbarbu_: http://integration.wikimedia.org/zuul [10:38:40] tto, and from there? [10:38:47] victorbarbu_: Since it's a brand new repository, Jenkins probably hasn't been set up yet [10:39:02] oh, yeah, probably [10:39:28] is there anything I can do for setting up jenkins? [10:40:21] You can ask in #wikimedia-releng, but it might take them some time to set it up. [10:40:39] Basically, with no jenkins, we have to be a bit more careful, particularly by running php -l on all the touched files [10:40:45] legoktm, https://gerrit.wikimedia.org/r/261911 this is the patch [10:45:58] (03CR) 10TTO: Replace language selection dropdown with ULS (031 comment) [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) (owner: 10Victorbarbu) [10:49:57] (03CR) 10Victorbarbu: Replace language selection dropdown with ULS (031 comment) [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/261911 (https://phabricator.wikimedia.org/T87244) (owner: 10Victorbarbu) [10:51:26] unicornisaurous: Having some connection problems? You're kind of spamming the channel with quit and join messages [10:51:38] Seems to be every 10 minutes, you disconnect [10:52:39] tto, 'section' key in https://gerrit.wikimedia.org/r/#/c/261911/2/specials/SpecialViewByLanguage.php [10:54:35] (03PS1) 10Georggi199: Export: Added check for subpages [core] - 10https://gerrit.wikimedia.org/r/261912 (https://phabricator.wikimedia.org/T64109) [11:01:33] (03PS2) 10Georggi199: Export: Added check for subpages [core] - 10https://gerrit.wikimedia.org/r/261912 (https://phabricator.wikimedia.org/T64109) [11:02:51] (03CR) 10TTO: [C: 04-2] "Good!" [core] - 10https://gerrit.wikimedia.org/r/261912 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [11:03:44] (03CR) 10Paladox: "So that this works in mw 1.26." [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/261597 (https://phabricator.wikimedia.org/T119766) (owner: 10Paladox) [11:05:21] 10MediaWiki-Configuration, 5Patch-For-Review: $wgExtensionCredits handling in ExtensionProcessor/ExtensionRegistry is weird - https://phabricator.wikimedia.org/T108269#1912522 (10Paladox) [11:17:56] 10MediaWiki-Export-or-Import: Import errors on elements - https://phabricator.wikimedia.org/T23000#1912523 (10TTO) Importing protected redirects seems to work fine these days. [11:18:04] 10MediaWiki-Export-or-Import: Import errors on elements - https://phabricator.wikimedia.org/T23000#1912525 (10TTO) 5Open>3Resolved a:3TTO [11:21:14] 6Developer-Relations: Create a user friendly encouraging-to-contribute site - https://phabricator.wikimedia.org/T91633#1912528 (10Steinsplitter) ... and for Wikimedia Commons: http://whatcanidoforwikimediacommons.org/ :-) [11:21:22] (03CR) 10Polybuildr: "Did you mean to -2 the change?" [core] - 10https://gerrit.wikimedia.org/r/261912 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [11:22:29] lol [11:22:39] (03CR) 10Georggi199: "Yes he did, he wants to merge all tasks about XSD at once." [core] - 10https://gerrit.wikimedia.org/r/261912 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [11:22:47] ? [11:23:33] (03CR) 10Polybuildr: "Ah, okay. Sorry! I just thought it was very weird that the comment said "Good!" but it was a CR-2. :P" [core] - 10https://gerrit.wikimedia.org/r/261912 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [11:23:41] victorbarbu_: He commented "Good!" and then -2'ed the change [11:24:18] It's fine prahavk_ :) [11:24:39] Georggi: Yeah, I got it :P [11:34:58] 6Developer-Relations: Create a user friendly encouraging-to-contribute site - https://phabricator.wikimedia.org/T91633#1912529 (10jrbs) >>! In T91633#1887220, @Qgil wrote: > Let's find a place to link this site from https://mediawiki.org homepage and/or [[ https://www.mediawiki.org/wiki/How_to_contribute | How t... [12:01:01] Nemo_bis: Could you publish https://codein.withgoogle.com/dashboard/tasks/5234716852617216/ ? [12:02:16] 10MediaWiki-Codesniffer: Bug in MW codesniffer 0.5.1 now sniffs the .git folder - https://phabricator.wikimedia.org/T122738#1912530 (10Paladox) 3NEW [12:02:23] 10MediaWiki-Codesniffer: Bug in MW codesniffer 0.5.1 now sniffs the .git folder - https://phabricator.wikimedia.org/T122738#1912537 (10Paladox) [12:03:40] 10MediaWiki-Codesniffer: Add $IP to a global blacklist in MW codesniffer - https://phabricator.wikimedia.org/T122739#1912539 (10Paladox) 3NEW [12:03:57] what does it say? [12:04:19] victorbaru_ uhm? [12:04:29] that unpublished task [12:04:54] It is related to export-import [12:05:10] To this one https://phabricator.wikimedia.org/T65010 [12:05:16] oh [12:05:20] I asked tto to add one:) [12:13:32] 10MediaWiki-extensions-Other, 3Google-Code-In-2015: Convert LandingCheck to use extension registration - https://phabricator.wikimedia.org/T88055#1912552 (10Mhutti1) a:3Mhutti1 [12:17:23] (03PS1) 10Paladox: Update jakub-onderka/php-parallel-lint to 0.9.2 [core] - 10https://gerrit.wikimedia.org/r/261914 [12:19:26] (03CR) 10Paladox: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/248379 (owner: 10Paladox) [12:48:17] (03PS2) 10Reedy: Don't use User::getSkin() [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/261887 [12:57:43] 10MediaWiki-Configuration, 5MW-1.27-release: Support $wgAction in extension registration - https://phabricator.wikimedia.org/T117197#1912557 (10Paladox) Please could this then be added to the schema please. [13:13:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Testme: Merge with conflicting sitelinks is not rejected - https://phabricator.wikimedia.org/T87524#1912560 (10matej_suchanek) This is from last Tuesday: - https://www.wikidata.org/w/index.php?title=Q5108005&diff=286796667&oldid=258499082 - https://... [14:17:45] 10MediaWiki-API, 7Technical-Debt: ApiQueryImageInfo is crufty, needs rewrite - https://phabricator.wikimedia.org/T89971#1912578 (10Anomie) [14:17:46] 10MediaWiki-API, 10TimedMediaHandler: Using imageinfo and videoinfo together in one API request throws error - https://phabricator.wikimedia.org/T122716#1912577 (10Anomie) [14:42:51] (03CR) 10Alex Monk: NovaPrivateHost: Ensure puppetclass/puppetvar LDAP attributes get modified (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/261906 (https://phabricator.wikimedia.org/T122733) (owner: 10Alex Monk) [14:44:32] (03PS2) 10Alex Monk: NovaPrivateHost: Ensure puppetclass/puppetvar LDAP attributes get modified [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/261906 (https://phabricator.wikimedia.org/T122733) [14:44:52] (03PS1) 10Reedy: Fix indenting [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261916 [14:45:34] 6Phabricator: Phabricator Task Daemon has problems - https://phabricator.wikimedia.org/T122408#1912595 (10Luke081515) I can see it every time I edit a repo. Normaly the repo shows the status of the daemon, because it is important for pulling, so you can look at every repo to find it. This issue still ocurs today... [14:45:55] (03Merged) 10jenkins-bot: Fix indenting [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261916 (owner: 10Reedy) [14:47:28] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261917 [14:48:15] (03PS2) 10Reedy: Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261917 [14:51:38] (03PS1) 10Reedy: Fix fail from I11d7bf3b8c125f52bf96392268451c06c917b128 [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261918 [14:51:56] (03CR) 10Reedy: [C: 032] Fix fail from I11d7bf3b8c125f52bf96392268451c06c917b128 [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261918 (owner: 10Reedy) [14:52:32] (03Merged) 10jenkins-bot: Fix fail from I11d7bf3b8c125f52bf96392268451c06c917b128 [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261918 (owner: 10Reedy) [14:53:56] So much horrible code [14:54:34] and duplicate [14:55:37] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261919 [14:56:21] Quite [14:57:03] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261920 [14:57:57] (03PS1) 10Reedy: Don't use User::getSkin() [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 [14:58:02] I think that's the lot of them now [14:59:29] SOMEONE MERGE PL0X [15:18:11] (03PS1) 10Reedy: Removed OutputPage::includeJQuery() [core] - 10https://gerrit.wikimedia.org/r/261923 [15:19:33] 10MediaWiki-Redirects: redirects to a page not updated after move - https://phabricator.wikimedia.org/T32359#1912612 (10petr.matas) >>! In T32359#1421924, @Paine_Ellsworth wrote: > Was wondering - when double redirects are allowed, will there also be "triple redirects", "quadruple redirects" and so on? And will... [15:20:21] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/261924 [15:20:39] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261925 [15:21:07] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261926 [15:22:03] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/261927 [15:22:46] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/261928 [15:23:06] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/261929 [15:23:30] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/261930 [15:23:47] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/261931 [15:24:10] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/261932 [15:24:41] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/261933 [15:25:17] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/261934 [15:25:40] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261935 [15:26:13] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/261936 [15:26:44] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Push] - 10https://gerrit.wikimedia.org/r/261937 [15:28:24] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/261938 [15:29:52] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/261940 [15:30:02] gj Reedy [15:30:23] MatmaRex: merge pl0x [15:30:24] 10WMUA-Tech, 10Wikimedia-Site-Requests, 5Patch-For-Review: Prevent indexing of User: namespace on uawikimedia - https://phabricator.wikimedia.org/T122732#1912615 (10Krenair) [15:30:40] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/261941 [15:31:00] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/261942 [15:31:24] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/261943 [15:31:28] can do later [15:31:50] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261944 [15:32:25] (03CR) 10jenkins-bot: [V: 04-1] Throw PermissionsError exception directly [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261944 (owner: 10Reedy) [15:32:32] lol [15:33:37] (03PS1) 10Reedy: Throw PermissionsError exception directly [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/261945 [15:34:22] (03CR) 10Reedy: "Unrelated failure" [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261944 (owner: 10Reedy) [15:37:47] (03PS1) 10Reedy: OutputPage::permissionRequired() was removed [core] - 10https://gerrit.wikimedia.org/r/261946 [15:43:54] (03PS2) 10Florianschmidtwelzow: registration: Handle $wgExtensionCredits inside the ExtensionProcessor [core] - 10https://gerrit.wikimedia.org/r/261908 (https://phabricator.wikimedia.org/T108269) (owner: 10Legoktm) [15:44:00] (03CR) 10Florianschmidtwelzow: [C: 032] registration: Handle $wgExtensionCredits inside the ExtensionProcessor [core] - 10https://gerrit.wikimedia.org/r/261908 (https://phabricator.wikimedia.org/T108269) (owner: 10Legoktm) [15:44:14] 10MediaWiki-Configuration: $wgExtensionCredits handling in ExtensionProcessor/ExtensionRegistry is weird - https://phabricator.wikimedia.org/T108269#1912617 (10Florian) 5Open>3Resolved p:5Triage>3Normal a:3Legoktm [15:50:06] (03PS1) 10Anomie: Use correct variable in ustring.lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/261947 [15:51:03] (03Merged) 10jenkins-bot: registration: Handle $wgExtensionCredits inside the ExtensionProcessor [core] - 10https://gerrit.wikimedia.org/r/261908 (https://phabricator.wikimedia.org/T108269) (owner: 10Legoktm) [15:54:44] (03PS5) 10Florianschmidtwelzow: Maintenance: convertExtensionToRegistration: Detect if composer autoloader is needed [core] - 10https://gerrit.wikimedia.org/r/261633 (https://phabricator.wikimedia.org/T119766) [16:09:25] (03PS3) 10Florianschmidtwelzow: registration: Allow setting $wgCentralIdLookupProviders [core] - 10https://gerrit.wikimedia.org/r/261909 (owner: 10Legoktm) [16:09:32] (03CR) 10Florianschmidtwelzow: [C: 032] registration: Allow setting $wgCentralIdLookupProviders [core] - 10https://gerrit.wikimedia.org/r/261909 (owner: 10Legoktm) [16:13:30] (03CR) 10Florianschmidtwelzow: [C: 04-1] "https://www.mediawiki.org/wiki/Backporting_policy" [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/261597 (https://phabricator.wikimedia.org/T119766) (owner: 10Paladox) [16:16:57] MtDu: ^ Please give me a short feedback, what you want to do :) [16:17:08] MtDu: sorry, I mean this change: https://gerrit.wikimedia.org/r/#/c/261915/ [16:18:23] FlorianSW: You mean me? [16:18:47] FlorianSW! [16:18:50] *facepalm* sorry MtDu, yes, I mean you mhutti1 [16:18:56] :( [16:19:01] FlorianSW: If you want to merge things... I've loads of patches :D [16:19:36] 10MediaWiki-General-or-Unknown, 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1912628 (10Esanders) >>! In T115861#1903543, @Pginer-W... [16:19:42] "Throw PermissionsError exception directly" & "Don't use User::getSkin()" -> you're very active Reedy :D [16:20:05] FlorianSW: Ill edit the extension page [16:20:20] (03Merged) 10jenkins-bot: registration: Allow setting $wgCentralIdLookupProviders [core] - 10https://gerrit.wikimedia.org/r/261909 (owner: 10Legoktm) [16:20:22] FlorianSW: shit that should've died years ago :) [16:20:26] mhutti1: ok, thanks for the feedback :) [16:20:59] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use User::getSkin() [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/261887 (owner: 10Reedy) [16:21:43] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/261887 (owner: 10Reedy) [16:21:52] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261917 (owner: 10Reedy) [16:22:11] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261917 (owner: 10Reedy) [16:22:44] (03CR) 10Florianschmidtwelzow: Don't use User::getSkin() (031 comment) [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261919 (owner: 10Reedy) [16:23:21] Hi unicornisaurous ! [16:23:27] Hi [16:23:33] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use User::getSkin() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261920 (owner: 10Reedy) [16:24:00] Apperantly my computer was spamming the channel overnight with join/quit messages. Thats cool. [16:24:07] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/261920 (owner: 10Reedy) [16:24:09] (03PS5) 10Reedy: Convert Special:ComparePages to OOUI [core] - 10https://gerrit.wikimedia.org/r/251013 (https://phabricator.wikimedia.org/T117752) (owner: 10Florianschmidtwelzow) [16:25:08] (03CR) 10Reedy: [C: 032] "Yay, prettyness" [core] - 10https://gerrit.wikimedia.org/r/251013 (https://phabricator.wikimedia.org/T117752) (owner: 10Florianschmidtwelzow) [16:25:37] (03PS2) 10Reedy: Convert Special:Export to OOUI [core] - 10https://gerrit.wikimedia.org/r/255438 (https://phabricator.wikimedia.org/T117753) (owner: 10Florianschmidtwelzow) [16:25:49] I'm rebasing and then reviewing :P [16:26:55] (03CR) 10Reedy: [C: 032] Convert Special:Export to OOUI [core] - 10https://gerrit.wikimedia.org/r/255438 (https://phabricator.wikimedia.org/T117753) (owner: 10Florianschmidtwelzow) [16:27:12] (03PS2) 10Reedy: Convert Special:ExpandTemplates to OOUI [core] - 10https://gerrit.wikimedia.org/r/255912 (https://phabricator.wikimedia.org/T117748) (owner: 10Florianschmidtwelzow) [16:27:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] Don't use User::getSkin() (032 comments) [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 (owner: 10Reedy) [16:27:33] Reedy: thanks :D [16:28:18] mhutti1: If you finished editing the extension page, please give me a feedback, here or on the changem please :) [16:28:39] Almost done just getting formating right [16:29:06] (03CR) 10Reedy: [C: 032] Convert Special:ExpandTemplates to OOUI [core] - 10https://gerrit.wikimedia.org/r/255912 (https://phabricator.wikimedia.org/T117748) (owner: 10Florianschmidtwelzow) [16:29:21] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/261924 (owner: 10Reedy) [16:29:32] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261925 (owner: 10Reedy) [16:29:45] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261926 (owner: 10Reedy) [16:30:06] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/261927 (owner: 10Reedy) [16:30:06] 10Design Research Archive, 5Design Research Project Documentation 2015Q2: add CC user testing participant videos to commons - https://phabricator.wikimedia.org/T108212#1912666 (10aripstra) [16:30:34] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/261928 (owner: 10Reedy) [16:30:45] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/261929 (owner: 10Reedy) [16:30:47] (03PS2) 10Reedy: Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261919 [16:30:59] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/261931 (owner: 10Reedy) [16:31:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] Throw PermissionsError exception directly (031 comment) [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/261930 (owner: 10Reedy) [16:31:39] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/261932 (owner: 10Reedy) [16:31:40] FlorianSW: Oh come on [16:31:47] I removed most of the returns I found :P [16:31:58] There was like 30 odd of those updates :( [16:31:59] yeah, in the next change you did, too :D [16:32:12] If you want, I merge it so :) [16:32:20] it's just a minor styling thing :P [16:32:34] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/261933 (owner: 10Reedy) [16:32:47] Yeah, I'll fix it [16:32:47] heh [16:32:57] Just looking at the HelpCommons one [16:33:04] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/261934 (owner: 10Reedy) [16:33:09] (03Merged) 10jenkins-bot: Convert Special:ComparePages to OOUI [core] - 10https://gerrit.wikimedia.org/r/251013 (https://phabricator.wikimedia.org/T117752) (owner: 10Florianschmidtwelzow) [16:34:13] Reedy: to the HelpCommons: I think the one hook uses SkinTemplate, too, even if the doc block says it's a Title object. The doc on mediawiki.org doesn't say anything about the value of the var :) So, if you don't know ad hoc, I'll look into the code of MW 1.18 [16:34:16] 10Design Research Archive, 10Research collaborations, 6Research-and-Data: Research presentation at Metrics - December 2015 - https://phabricator.wikimedia.org/T115673#1912669 (10aripstra) [16:34:25] (03Merged) 10jenkins-bot: Convert Special:Export to OOUI [core] - 10https://gerrit.wikimedia.org/r/255438 (https://phabricator.wikimedia.org/T117753) (owner: 10Florianschmidtwelzow) [16:34:29] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261935 (owner: 10Reedy) [16:34:36] * @param $skin Title [16:34:38] ffs [16:34:40] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Push] - 10https://gerrit.wikimedia.org/r/261937 (owner: 10Reedy) [16:34:43] WHAT IS THIS I DON'T EVEN [16:34:50] * @param $sktemplate Title [16:34:55] 10Design Research Archive, 5Design Research and product team collaboration: Recruit for Focus Group with Wikimedia Foundation User Interface Design team - https://phabricator.wikimedia.org/T120402#1912671 (10aripstra) [16:34:56] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/261938 (owner: 10Reedy) [16:34:59] Horrible code [16:35:06] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/261936 (owner: 10Reedy) [16:35:33] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/261940 (owner: 10Reedy) [16:35:49] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/261941 (owner: 10Reedy) [16:35:55] (03CR) 10Florianschmidtwelzow: [V: 032] Throw PermissionsError exception directly [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/261941 (owner: 10Reedy) [16:35:59] 10Design Research Archive, 5Design Research Workshop 2015Q2: Create website for Design Research Methods - https://phabricator.wikimedia.org/T116396#1912673 (10aripstra) [16:36:22] ah, we have a sudo extension? :D mediawiki/extensions/Sudo [16:36:28] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/261942 (owner: 10Reedy) [16:36:38] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/261943 (owner: 10Reedy) [16:36:40] (03Merged) 10jenkins-bot: Convert Special:ExpandTemplates to OOUI [core] - 10https://gerrit.wikimedia.org/r/255912 (https://phabricator.wikimedia.org/T117748) (owner: 10Florianschmidtwelzow) [16:36:43] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/261924 (owner: 10Reedy) [16:36:45] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261925 (owner: 10Reedy) [16:36:47] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261926 (owner: 10Reedy) [16:36:49] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261944 (owner: 10Reedy) [16:36:52] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/261927 (owner: 10Reedy) [16:36:53] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/261928 (owner: 10Reedy) [16:36:55] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/261929 (owner: 10Reedy) [16:36:57] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/261933 (owner: 10Reedy) [16:36:59] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/261934 (owner: 10Reedy) [16:37:01] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261935 (owner: 10Reedy) [16:37:03] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Push] - 10https://gerrit.wikimedia.org/r/261937 (owner: 10Reedy) [16:37:04] 10Design Research Archive, 6Increasing content coverage, 7Article-Recommendation: User testing of article recommendations - https://phabricator.wikimedia.org/T110355#1912675 (10aripstra) [16:37:05] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/261938 (owner: 10Reedy) [16:37:07] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/261945 (owner: 10Reedy) [16:37:36] 10Design Research Archive, 5Design Research Workshop 2015Q2: Build Design Research in product development lifecycle {liger} - https://phabricator.wikimedia.org/T105530#1912676 (10aripstra) [16:38:02] 10Design Research Archive, 5Persona research: create protocol for interviewing readers for persona research - https://phabricator.wikimedia.org/T114825#1912677 (10aripstra) [16:38:28] 10Design Research Archive, 5Design Research Workshop 2015Q2: focus the outline for the DR workshop to be held November 20, 2015 - https://phabricator.wikimedia.org/T116953#1912678 (10aripstra) [16:38:46] 10Design Research Archive, 5Design Research Workshop 2015Q2: Design Research workshop {liger} - https://phabricator.wikimedia.org/T105528#1912680 (10aripstra) [16:39:14] 10Design Research Archive, 5Design Research Workshop 2015Q2: build deck describing design process and generative/ evaluative design research - https://phabricator.wikimedia.org/T105531#1912681 (10aripstra) [16:39:24] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/261936 (owner: 10Reedy) [16:39:28] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/261940 (owner: 10Reedy) [16:39:30] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/261942 (owner: 10Reedy) [16:39:32] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/261943 (owner: 10Reedy) [16:39:34] (03CR) 10jenkins-bot: [V: 04-1] Throw PermissionsError exception directly [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261944 (owner: 10Reedy) [16:39:47] FlorianSW:https://www.mediawiki.org/wiki/Extension:LandingCheck [16:39:52] 10Data release, 10Design Research Archive, 10Research collaborations, 6Research-and-Data: Generate dataset of teahouse and afc template postings - https://phabricator.wikimedia.org/T117565#1912682 (10aripstra) [16:40:23] mhutti1: great :) [16:40:33] 10Design Research Archive, 10Research collaborations: Finish exec summary, collaborations section of CSCW 2015 OCS workshop - https://phabricator.wikimedia.org/T117269#1912683 (10aripstra) [16:40:35] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/261945 (owner: 10Reedy) [16:41:01] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1912687 (10Florian) [16:41:02] 10MediaWiki-extensions-Other, 3Google-Code-In-2015: Convert LandingCheck to use extension registration - https://phabricator.wikimedia.org/T88055#1912685 (10Florian) 5Open>3Resolved [16:41:04] 10Design Research Archive, 5Design Research and product team collaboration: Recruit for Cross-Wiki Notifications Study (R2) - https://phabricator.wikimedia.org/T120401#1912688 (10aripstra) [16:41:21] 10Design Research Archive, 5Design Research participant outreach, 5Design Research recruitment process: Invite Fundraising donors list to Participant Database - https://phabricator.wikimedia.org/T118007#1912691 (10aripstra) [16:42:10] 10Design Research Archive, 5Design Research and product team collaboration: Conduct heuristic evaluation of image search and insert flow in the VisualEditor - https://phabricator.wikimedia.org/T114832#1912693 (10aripstra) [16:42:18] (03CR) 10Florianschmidtwelzow: [V: 032] Throw PermissionsError exception directly [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/261944 (owner: 10Reedy) [16:43:04] 10Design Research Archive, 5Design Research recruitment process: add CAPTCHA, "gotcha" question to recruiting survey to screen out spam {robin} - https://phabricator.wikimedia.org/T107049#1912694 (10aripstra) [16:44:18] Reedy: to this change: https://gerrit.wikimedia.org/r/#/c/261900/ it works so, and it's fine from me, but it would be much more great, if you could use $this->msg(), wouldn't it? :) [16:44:29] 10MediaWiki-API, 6RevisionScoringAsAService: [Discussion] api.php integration with ORES - https://phabricator.wikimedia.org/T122689#1912701 (10Anomie) [16:44:41] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use wfEmptyMsg() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261899 (owner: 10Reedy) [16:45:11] (03Merged) 10jenkins-bot: Don't use wfEmptyMsg() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261899 (owner: 10Reedy) [16:45:15] (03PS2) 10Reedy: Don't use User::getSkin() [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 [16:45:40] FlorianSW: Whatever really. I'm not married to how they're fixed, more, that htey are :) [16:46:26] 10Design Research Archive, 10Research management, 6Research-and-Data-Archive: High-level goals for Q2 and beyond (roadmap) for Eng offsite - https://phabricator.wikimedia.org/T107961#1912714 (10aripstra) 5Open>3Resolved [16:47:02] (03PS2) 10Reedy: Throw PermissionsError exception directly [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/261930 [16:47:48] 10MediaWiki-extensions-GoogleNewsSitemap, 3Google-Code-In-2015: Convert GoogleNewsSitemap to use extension registration - https://phabricator.wikimedia.org/T87926#1912715 (10Mhutti1) a:3Mhutti1 [16:48:26] Reedy: would you like to remove your -1 from: https://gerrit.wikimedia.org/r/#/c/261901/1 ? :) [16:48:51] FlorianSW: for that one, I need to update the RELEASE-NOTES [16:48:52] (03CR) 10Florianschmidtwelzow: [C: 032] Throw PermissionsError exception directly [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/261930 (owner: 10Reedy) [16:49:23] (03Merged) 10jenkins-bot: Throw PermissionsError exception directly [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/261930 (owner: 10Reedy) [16:49:28] ah right, I read the comments but haven't seen the code :) [16:50:39] (03CR) 10Florianschmidtwelzow: [C: 032] Remove usage of FSRepo [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/258902 (owner: 10Reedy) [16:51:48] (03Merged) 10jenkins-bot: Remove usage of FSRepo [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/258902 (owner: 10Reedy) [16:52:47] (03PS2) 10Reedy: wfEmptyMsg() was removed [core] - 10https://gerrit.wikimedia.org/r/261901 [16:52:49] FlorianSW: ^^ edited and rebased [16:52:55] As that needed doing too :P [16:54:04] I'll merge as soon as jenkins gives his +2 :) [16:54:38] (03CR) 10Reedy: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/227334 (https://phabricator.wikimedia.org/T117734) (owner: 10Florianschmidtwelzow) [16:54:43] (03CR) 10Florianschmidtwelzow: "Hmm, technically ok, but it seems. that at least Nemo would love to see another target for the link? :)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/254440 (https://phabricator.wikimedia.org/T119209) (owner: 10Reedy) [16:55:25] (03PS5) 10Reedy: Convert Special:ConfirmEmail to OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251283 (https://phabricator.wikimedia.org/T117792) (owner: 10Florianschmidtwelzow) [16:55:32] (03PS6) 10Reedy: Convert Special:EmailUser to use OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [16:57:55] bleugh, can't test confirmemail easily :P [16:58:25] (03PS3) 10Florianschmidtwelzow: Update wfGetDB calls in Maintenance scripts to use getDB() [core] - 10https://gerrit.wikimedia.org/r/261751 (owner: 10Reedy) [16:58:31] (03CR) 10Florianschmidtwelzow: [C: 032] Update wfGetDB calls in Maintenance scripts to use getDB() [core] - 10https://gerrit.wikimedia.org/r/261751 (owner: 10Reedy) [16:59:00] Reedy: me too, I had to bypass any sending and mail check in the code :D Would you trust me, if I say: It works? :P [17:00:22] (03PS3) 10Florianschmidtwelzow: wfEmptyMsg() was removed [core] - 10https://gerrit.wikimedia.org/r/261901 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy) [17:00:30] (03CR) 10Florianschmidtwelzow: [C: 032] wfEmptyMsg() was removed [core] - 10https://gerrit.wikimedia.org/r/261901 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy) [17:03:04] (03PS5) 10Florianschmidtwelzow: Use OOUI on Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/227334 (https://phabricator.wikimedia.org/T117734) [17:03:19] (03CR) 10Florianschmidtwelzow: "PS5 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/227334 (https://phabricator.wikimedia.org/T117734) (owner: 10Florianschmidtwelzow) [17:03:48] (03PS1) 10Mhutti1: Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 [17:04:35] Nemo_bis: https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list from this list, do I need to know the languages specified like French or German? [17:05:08] (03CR) 10Florianschmidtwelzow: [C: 04-1] Don't use User::getSkin() (031 comment) [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 (owner: 10Reedy) [17:05:34] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261919 (owner: 10Reedy) [17:06:02] (03PS2) 10Mhutti1: Converted GoogleNewsSitemap to new extension registration [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) [17:06:06] (03Merged) 10jenkins-bot: Update wfGetDB calls in Maintenance scripts to use getDB() [core] - 10https://gerrit.wikimedia.org/r/261751 (owner: 10Reedy) [17:06:19] (03CR) 10Florianschmidtwelzow: [V: 032] Throw PermissionsError exception directly [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/261932 (owner: 10Reedy) [17:06:29] (03CR) 10Florianschmidtwelzow: [V: 032] Throw PermissionsError exception directly [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/261931 (owner: 10Reedy) [17:08:21] 10Wikimedia-Developer-Summit-2016: How should Wikimedia software support non-Wikimedia deployments of its software? - https://phabricator.wikimedia.org/T113210#1912727 (10Gilles) I've prepared some slides for that session, trying to keep it as short as possible: https://docs.google.com/presentation/d/1_UaZXN3uds... [17:08:53] (03Merged) 10jenkins-bot: wfEmptyMsg() was removed [core] - 10https://gerrit.wikimedia.org/r/261901 (https://phabricator.wikimedia.org/T70750) (owner: 10Reedy) [17:08:55] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261919 (owner: 10Reedy) [17:09:21] (03CR) 10Florianschmidtwelzow: [C: 04-1] "needs rebase :(" [core] - 10https://gerrit.wikimedia.org/r/261946 (owner: 10Reedy) [17:18:02] ananayarora: no [17:19:27] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1912730 (10Tkinkhorst) I can confirm seeing this on 1.23.12 and 1.23.13 although it's a different file and line number than reported above: `Warning: hash_equals(): Expected user_s... [17:19:45] Nemo_bis: how do I translate the stuff then? Google Translate? :$ [17:27:31] 4(no projects): Bad getter call: getURI - After Update - https://phabricator.wikimedia.org/T122745#1912731 (10Ionutcp) 3NEW [17:27:50] 10Phabricator-Sprint-Extension: Bad getter call: getURI - After Update - https://phabricator.wikimedia.org/T122745#1912738 (10Ionutcp) [17:34:35] (03PS2) 10Reedy: OutputPage::permissionRequired() was removed [core] - 10https://gerrit.wikimedia.org/r/261946 [17:34:47] ananayarora: If you don't know the language, you can't translate [17:35:15] :'( [17:35:43] Reedy: I should've taken French or German in school instead of Sanskrit. :'( [17:35:48] (03CR) 10Nikerabbit: [C: 032] Add Icelandic (is) namespace translations [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/261878 (https://phabricator.wikimedia.org/T122718) (owner: 10Legoktm) [17:35:56] Thats not what the tasksa about though is it? [17:36:03] Its about adding the translate tags [17:36:22] (03Merged) 10jenkins-bot: Add Icelandic (is) namespace translations [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/261878 (https://phabricator.wikimedia.org/T122718) (owner: 10Legoktm) [17:36:23] You copy the translation thats already there [17:37:36] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-WikimediaMessages, 10Wikimedia-General-or-Unknown, 5Patch-For-Review: Override acct_creation_throttle_hit in WikimediaMessages to tell people to file a task if they're an an event etc - https://phabricator.wikimedia.org/T119209#1912745 (10RobLa-WMF)... [17:40:58] (03CR) 10RobLa: "Florianschmidtwelzow, thanks for the bump! I responded to Nemo here: https://phabricator.wikimedia.org/T119209#1912745" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/254440 (https://phabricator.wikimedia.org/T119209) (owner: 10Reedy) [17:41:45] 10MediaWiki-extensions-Newsletter, 5Patch-For-Review: Summary is no longer present in echo web notifications - https://phabricator.wikimedia.org/T122663#1912746 (1001tonythomas) Deployed in http://newsletter-test.wmflabs.org/wiki/Special:Newsletters @Glaisher, tell me if the notifications looks okey - and pl... [17:45:17] (03CR) 10Florianschmidtwelzow: [C: 032] OutputPage::permissionRequired() was removed [core] - 10https://gerrit.wikimedia.org/r/261946 (owner: 10Reedy) [17:46:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Only load the entity revision in wbgetentities if needed - https://phabricator.wikimedia.org/T122746#1912748 (10hoo) 3NEW [17:46:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Only load the entity revision in wbgetentities if needed - https://phabricator.wikimedia.org/T122746#1912755 (10hoo) [17:50:43] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1912760 (10Florian) [17:50:45] 10UI-Standardization, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Convert Special:ExpandTemplates to OOUI - https://phabricator.wikimedia.org/T117748#1912757 (10Florian) 5Open>3Resolved [17:50:50] (03CR) 10Mglaser: [C: 032] "Ah, sorry. I thought it was both for BlueSpiceFoundation. All good :)" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261624 (owner: 10Robert Vogel) [17:51:02] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1485020 (10Florian) [17:51:03] 10UI-Standardization, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Convert Special:ComparePages to OOUI - https://phabricator.wikimedia.org/T117752#1912761 (10Florian) 5Open>3Resolved a:3Florian [17:51:23] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1485020 (10Florian) [17:51:25] 10UI-Standardization, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Convert Special:Export to OOUI - https://phabricator.wikimedia.org/T117753#1912765 (10Florian) 5Open>3Resolved [17:52:24] 10MediaWiki-extensions-ORES, 6RevisionScoringAsAService: Deploy ORES extension to production and ask for consensus to enable - https://phabricator.wikimedia.org/T120923#1912770 (10Anomie) Shouldn't this be blocked by {T106867}? [17:53:23] 3Wikipedia-Android-App: Sort out which app versions feeds which MobileWikiAppToCInteraction table - https://phabricator.wikimedia.org/T119664#1912772 (10Tbayer) Update: Looked at this with Dmitry [[http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-mobile/20151202.txt | on IRC]] earlier and he confirmed that the... [17:54:26] (03Merged) 10jenkins-bot: OutputPage::permissionRequired() was removed [core] - 10https://gerrit.wikimedia.org/r/261946 (owner: 10Reedy) [17:54:29] (03Merged) 10jenkins-bot: Composer.json: Added more information [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261624 (owner: 10Robert Vogel) [17:56:44] 10Gerrit, 5Patch-For-Review: Full Phabricator links are being expanded weirdly in gerrit - https://phabricator.wikimedia.org/T75997#1912775 (10RobLa-WMF) I tried to link to T119209#1912745 from https://gerrit.wikimedia.org/r/#/c/254440/ and caused weirdness in the escaping code. Basically, I tried to work aro... [17:58:49] 10MediaWiki-API, 6RevisionScoringAsAService: [Discussion] api.php integration with ORES - https://phabricator.wikimedia.org/T122689#1912779 (10Anomie) There are generically four kinds of modules in the action API: # Query "prop" modules, that return information about pages (in sets of up to 5000 pages). # Que... [18:00:04] 6Phabricator, 10Gerrit: Allow links to phabricator comments from gerrit messages. - https://phabricator.wikimedia.org/T76459#1912783 (10RobLa-WMF) I tried working around this, and failed. See my attempt to link to T119209#1912745 from https://gerrit.wikimedia.org/r/#/c/254440/ Assuming we stay with Gerrit, w... [18:00:39] 10Gerrit, 5Patch-For-Review: Full Phabricator links are being expanded weirdly in gerrit - https://phabricator.wikimedia.org/T75997#787908 (10RobLa-WMF) [18:00:40] 6Phabricator, 10Gerrit: Allow links to phabricator comments from gerrit messages. - https://phabricator.wikimedia.org/T76459#1912789 (10RobLa-WMF) [18:02:45] (03PS6) 10Reedy: Use OOUI on Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/227334 (https://phabricator.wikimedia.org/T117734) (owner: 10Florianschmidtwelzow) [18:02:50] (03CR) 10Reedy: [C: 032] Use OOUI on Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/227334 (https://phabricator.wikimedia.org/T117734) (owner: 10Florianschmidtwelzow) [18:04:51] * Reedy assigns all blame for to FlorianSW for the next release [18:04:54] "ZOMG THINGS CHANGED" [18:05:00] DAS IST VERBOTEN [18:05:34] :D [18:06:17] I hope it won't be too much :) [18:06:29] I think it looks good generally [18:06:45] ananayarora: indeed, as mhutti1 says translating is forbidden; the task is only about migrating the translations we already have [18:06:59] 10OCG-General-or-Unknown, 7Community-Wishlist-Survey: Allow exporting MediaWiki pages in EPUB format - https://phabricator.wikimedia.org/T97672#1912792 (10Tpt) Wikisource is currently using the Wsexport tool to export its content in ePub: https://tools.wmflabs.org/wsexport/tool/book.php [18:07:15] and even if it wouldn't be the best, I think the main goal is to implement a standardised way for as most forms as possible. That would make changing them to a better look and feel much easier :D [18:08:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Call to a member function getSiteLinkList() on a non-object (NULL) in ClientParserOutputDataUpdater - https://phabricator.wikimedia.org/T122747#1912793 (10hoo) 3NEW [18:09:06] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Wikimedia-log-errors: Call to a member function getSiteLinkList() on a non-object (NULL) in ClientParserOutputDataUpdater - https://phabricator.wikimedia.org/T122747#1912801 (10hoo) [18:10:08] * FlorianSW goes and tries to find something to eat in the kitchen [18:11:14] (03Merged) 10jenkins-bot: Use OOUI on Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/227334 (https://phabricator.wikimedia.org/T117734) (owner: 10Florianschmidtwelzow) [18:11:51] (03PS7) 10Reedy: Convert Special:EmailUser to use OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [18:11:57] (03CR) 10Reedy: [C: 032] Convert Special:EmailUser to use OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [18:13:08] 10Phabricator-Sprint-Extension: Bad getter call: getURI - After Update - https://phabricator.wikimedia.org/T122745#1912807 (10Christopher) The Sprint commit message clearly indicates that it is current with 10ed33052361be82cbc09884118d65ec0601bd55 from 27 December. Your phabricator version is from 26 Decembe... [18:14:50] 10MediaWiki-Configuration: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912808 (10Paladox) 3NEW [18:15:34] 10MediaWiki-Configuration: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912815 (10Reedy) [18:15:48] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912808 (10Reedy) [18:17:59] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912818 (10Paladox) The workaround is to be everything in the callback hook in extension.json which would make the file pointless if we have too do that. [18:18:05] (03Merged) 10jenkins-bot: Convert Special:EmailUser to use OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [18:18:59] 10Gerrit, 5Patch-For-Review: Full Phabricator links are being expanded weirdly in gerrit - https://phabricator.wikimedia.org/T75997#1912823 (10mmodell) The way gerrit matches links is very limited, there is no straightforward way to fix it. [18:21:34] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912825 (10Florian) I really don't understand, what you mean/want? What should be run in a callback and why? [18:21:38] (03PS6) 10Reedy: Convert Special:ConfirmEmail to OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251283 (https://phabricator.wikimedia.org/T117792) (owner: 10Florianschmidtwelzow) [18:21:43] (03CR) 10Reedy: [C: 032] Convert Special:ConfirmEmail to OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251283 (https://phabricator.wikimedia.org/T117792) (owner: 10Florianschmidtwelzow) [18:21:48] 10Phabricator-Sprint-Extension: Bad getter call: getURI - After Update - https://phabricator.wikimedia.org/T122745#1912826 (10Ionutcp) That's because I use the stable branch for phabricator (last commit 571960e712276083be4a0d2a67119c5aade02d25) and master branch for phabricator-sprint. I should also switch phabr... [18:23:55] Reedy: Woo. [18:24:06] James_F: What're we wooing for? [18:24:17] Reedy: T117791. :-) [18:24:20] Progress. :-) [18:24:48] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1912829 (10Reedy) [18:24:50] 10UI-Standardization, 5Patch-For-Review: Convert Special:EmailUser to OOUI - https://phabricator.wikimedia.org/T117791#1912827 (10Reedy) 5Open>3Resolved [18:24:53] We're fixing/merging lots of tech debt today [18:25:23] 10UI-Standardization, 5Patch-For-Review: Convert Special:BlockList to OOUI - https://phabricator.wikimedia.org/T117734#1912830 (10Reedy) a:3Florian [18:25:29] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1485020 (10Reedy) [18:25:31] 10UI-Standardization, 5Patch-For-Review: Convert Special:BlockList to OOUI - https://phabricator.wikimedia.org/T117734#1912832 (10Reedy) 5Open>3Resolved [18:25:56] 10UI-Standardization, 5Patch-For-Review: Convert Special:ConfirmEmail to OOUI - https://phabricator.wikimedia.org/T117792#1912835 (10Reedy) 5Open>3Resolved [18:25:58] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1485020 (10Reedy) [18:27:37] (03Merged) 10jenkins-bot: Convert Special:ConfirmEmail to OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251283 (https://phabricator.wikimedia.org/T117792) (owner: 10Florianschmidtwelzow) [18:29:04] (03PS3) 10Reedy: Don't use User::getSkin() [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 [18:29:37] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912840 (10Paladox) Well because wikibase file looks like for example https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/WikibaseClient.php some is a callba... [18:31:13] * James_F nods. [18:32:31] Nemo_bis: Okay. [18:32:56] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261951 [18:33:58] 10Wikimedia-Developer-Summit-2016, 7I18n: Let's discuss LanguageConverter - https://phabricator.wikimedia.org/T113002#1912842 (10cscott) @Santhosh yes, that's an important part of the UX difference. One question is: can we add a mode to ContentTranslation that works in this way -- we get a machine translation... [18:34:57] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261952 [18:36:03] (03PS2) 10Reedy: Replace OutputPage::blockedPage() [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261952 [18:36:58] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/261953 [18:37:35] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/261954 [18:38:16] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/261955 [18:39:26] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/261956 [18:39:38] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/261957 [18:40:01] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/261958 [18:40:31] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261959 [18:41:03] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/261960 [18:41:41] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/261961 [18:42:30] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/261962 [18:43:30] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/261963 [18:43:50] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/261964 [18:44:49] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/261965 [18:45:06] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/261966 [18:45:39] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/261967 [18:47:26] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/261969 [18:48:19] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/261970 [18:48:43] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/261971 [18:49:03] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/261972 [18:49:24] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/261973 [18:52:07] (03PS1) 10Reedy: Replace OutputPage::blockedPage() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/261974 [18:52:10] FlorianSW: Sorry [18:52:11] xD [18:53:37] (03PS1) 10Reedy: OutputPage::blockedPage() was removed [core] - 10https://gerrit.wikimedia.org/r/261975 [18:53:53] Reedy: yay, more fun :D I'll take a look in some minutes :) [18:53:57] <3 [18:53:59] Thanks! [18:54:04] All should be relatively easy again [18:54:54] Need to work out what to do about includeJQuery() [18:55:04] Some extensions include ooold jquery :/ [18:57:31] But that's a lot of effort to remove < 10 lines from core [18:57:32] Lol [18:57:58] 10Wikimedia-Developer-Summit-2016: How should Wikimedia software support non-Wikimedia deployments of its software? - https://phabricator.wikimedia.org/T113210#1912844 (10cscott) The current scheduling seems to indicate that I'm going to be off in R2-land while this topic is discussed in R1. So I'm going to wri... [19:02:57] wooow^^^ RIP gcibot [19:05:28] 10MediaWiki-Configuration: Update load_composer_autoloader to allow users to specify the path to the autoload.php file in extension registration - https://phabricator.wikimedia.org/T122749#1912851 (10Paladox) 3NEW [19:05:45] 6Phabricator, 10Gerrit, 5Patch-For-Review: Allow links to phabricator comments from gerrit messages. - https://phabricator.wikimedia.org/T76459#1912858 (10scfc) (No, I just linked Thiemo's patch to this task as it would resolve it.) [19:06:11] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261951 (owner: 10Reedy) [19:06:41] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/261951 (owner: 10Reedy) [19:06:54] 10Gerrit, 5Patch-For-Review: Full Phabricator links are being expanded weirdly in gerrit - https://phabricator.wikimedia.org/T75997#1912860 (10scfc) @mmodell: If you think that Thiemo's patch does not resolve this task, please explain in the review. [19:07:06] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261952 (owner: 10Reedy) [19:07:22] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/261954 (owner: 10Reedy) [19:07:35] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/261952 (owner: 10Reedy) [19:07:41] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/261955 (owner: 10Reedy) [19:08:02] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/261956 (owner: 10Reedy) [19:08:13] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/261953 (owner: 10Reedy) [19:08:15] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/261955 (owner: 10Reedy) [19:08:24] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/261957 (owner: 10Reedy) [19:08:37] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/261956 (owner: 10Reedy) [19:08:42] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/261958 (owner: 10Reedy) [19:09:17] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() (031 comment) [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261959 (owner: 10Reedy) [19:09:30] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/261960 (owner: 10Reedy) [19:09:43] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/261961 (owner: 10Reedy) [19:09:59] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/261962 (owner: 10Reedy) [19:10:23] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/261963 (owner: 10Reedy) [19:10:35] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/261964 (owner: 10Reedy) [19:10:49] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/261966 (owner: 10Reedy) [19:11:01] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/261967 (owner: 10Reedy) [19:11:16] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/261965 (owner: 10Reedy) [19:11:25] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/261953 (owner: 10Reedy) [19:11:27] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/261957 (owner: 10Reedy) [19:11:29] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/261958 (owner: 10Reedy) [19:11:31] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/261959 (owner: 10Reedy) [19:11:33] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/261960 (owner: 10Reedy) [19:11:35] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/261961 (owner: 10Reedy) [19:11:37] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/261962 (owner: 10Reedy) [19:11:41] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/261963 (owner: 10Reedy) [19:11:43] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/261964 (owner: 10Reedy) [19:11:48] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/261969 (owner: 10Reedy) [19:11:57] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/261966 (owner: 10Reedy) [19:12:00] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/261970 (owner: 10Reedy) [19:12:05] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/261967 (owner: 10Reedy) [19:12:12] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/261971 (owner: 10Reedy) [19:12:25] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/261972 (owner: 10Reedy) [19:12:39] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/261973 (owner: 10Reedy) [19:13:08] (03CR) 10Florianschmidtwelzow: [C: 032] Replace OutputPage::blockedPage() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/261974 (owner: 10Reedy) [19:13:30] so jenkins, it's your turn :D [19:14:55] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/261965 (owner: 10Reedy) [19:14:58] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/261969 (owner: 10Reedy) [19:15:01] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/261970 (owner: 10Reedy) [19:15:03] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/261971 (owner: 10Reedy) [19:15:05] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/261972 (owner: 10Reedy) [19:15:07] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/261973 (owner: 10Reedy) [19:15:08] (03Merged) 10jenkins-bot: Replace OutputPage::blockedPage() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/261974 (owner: 10Reedy) [19:16:08] (03CR) 10Florianschmidtwelzow: [C: 032] Don't use User::getSkin() [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 (owner: 10Reedy) [19:16:39] (03Merged) 10jenkins-bot: Don't use User::getSkin() [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/261921 (owner: 10Reedy) [19:17:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] "needs rebase." [core] - 10https://gerrit.wikimedia.org/r/261923 (owner: 10Reedy) [19:19:10] (03PS2) 10Florianschmidtwelzow: OutputPage::blockedPage() was removed [core] - 10https://gerrit.wikimedia.org/r/261975 (owner: 10Reedy) [19:19:15] (03CR) 10Florianschmidtwelzow: [C: 032] OutputPage::blockedPage() was removed [core] - 10https://gerrit.wikimedia.org/r/261975 (owner: 10Reedy) [19:20:44] Hi, I am a newbie in developing can anyone help me get started? [19:20:59] (03CR) 10Florianschmidtwelzow: [C: 04-1] "rebase needed." [vendor] - 10https://gerrit.wikimedia.org/r/260165 (owner: 10Reedy) [19:21:12] (03PS3) 10Florianschmidtwelzow: Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 (owner: 10Reedy) [19:21:37] (03CR) 10jenkins-bot: [V: 04-1] Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 (owner: 10Reedy) [19:26:47] (03Merged) 10jenkins-bot: OutputPage::blockedPage() was removed [core] - 10https://gerrit.wikimedia.org/r/261975 (owner: 10Reedy) [19:28:06] Hi, I am a newbie in developing I want to start contributing can somebody give me an easy bug to fix? [19:28:28] neeraj: A good point to start would be https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker :) [19:28:49] Easy bugs can be found in our phabricator instance, normally marked with easy. Wait one second, I'll give you a link [19:29:02] https://phabricator.wikimedia.org/tag/easy/ [19:29:26] thank you FlorianSW. [19:29:34] (03CR) 10Florianschmidtwelzow: [V: 032] Replace OutputPage::blockedPage() [extensions/ImportFreeImages] - 10https://gerrit.wikimedia.org/r/261954 (owner: 10Reedy) [19:31:07] (03PS3) 10Reedy: Update zordius/lightncandy to v0.23 [vendor] - 10https://gerrit.wikimedia.org/r/260165 [19:31:51] (03PS4) 10Reedy: Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 [19:34:32] (03PS2) 10Reedy: User::getSkin() was removed [core] - 10https://gerrit.wikimedia.org/r/261896 [19:36:25] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912863 (10Florian) >>! In T122748#1912840, @Paladox wrote: > What I think we should do is have an extension.json file that is the main file then add code for "example require-extensi... [19:38:27] (03PS1) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 [19:38:55] (03PS2) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 [19:39:14] (03PS3) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) [19:39:20] (03PS2) 10Reedy: Removed OutputPage::includeJQuery() [core] - 10https://gerrit.wikimedia.org/r/261923 [19:42:00] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update load_composer_autoloader config in extension registration (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [19:42:13] Nemo_bis: I posted some messages on the GCI site. Take a look when you get a chance. [19:43:22] FlorianSW: Are you likely to merge that lightncandy commit? Just wondering about making a dependancy ontop of it :D [19:44:15] 10MediaWiki-Configuration, 5Patch-For-Review: Update load_composer_autoloader to allow users to specify the path to the autoload.php file in extension registration - https://phabricator.wikimedia.org/T122749#1912868 (10Florian) This leaves too much space for unconditional behaviour, because we can't and don't... [19:44:33] Reedy: I planned to merge it, yes :) [19:45:39] 10MediaWiki-Configuration, 10Wikidata, 5Patch-For-Review: Update load_composer_autoloader to allow users to specify the path to the autoload.php file in extension registration - https://phabricator.wikimedia.org/T122749#1912869 (10Florian) [19:45:42] (03PS1) 10Reedy: Update ruflin/elastica v2.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/261982 [19:45:59] hi [19:46:00] 10MediaWiki-extensions-Newsletter, 7Easy, 7I18n: [[MediaWiki:Newsletter-email-batch-body/en]] needs GENDER support on $2. - https://phabricator.wikimedia.org/T122717#1912872 (10NeerajBattan) I would like to work on this bug can someone explain me the bug? [19:46:07] (03CR) 10Florianschmidtwelzow: [C: 032] Update zordius/lightncandy to v0.23 [vendor] - 10https://gerrit.wikimedia.org/r/260165 (owner: 10Reedy) [19:46:22] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912873 (10Paladox) Sorry I doint have steps to reproduce since it isent broken. this is a feature request. Currently wikibase uses callbacks for some of its code. In extension.json... [19:46:32] (03PS1) 10Reedy: Update ruflin/elastica v2.2.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261983 [19:47:09] (03PS2) 10Reedy: Update ruflin/elastica v2.2.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261983 [19:47:34] FlorianSW: hello! [19:47:44] victorbarbu_: hi :) [19:47:55] hi victorbarbu_ [19:48:01] Georggi: hi :D [19:48:21] why is gcibot reconnecting constantly? [19:48:23] (03CR) 10Paladox: Update load_composer_autoloader config in extension registration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [19:48:40] guys, can anyone of you approve my task on gci? [19:48:45] my mentor is not available [19:48:59] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica v2.2.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261983 (owner: 10Reedy) [19:49:01] who is your mentor? [19:49:05] ankita [19:49:19] and she might not be available for the next 2 days, from what we've talked [19:49:21] oh, if it would of been tto, he wont be happy:D [19:49:26] (03CR) 10Paladox: Update load_composer_autoloader config in extension registration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [19:49:46] because she's travelling to her college [19:50:17] and I wouldn't want those 36 hours to pass because she might not be available however [19:50:20] (03CR) 10MtDu: Converted GoogleNewsSitemap to new extension registration (031 comment) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/261948 (https://phabricator.wikimedia.org/T87926) (owner: 10Mhutti1) [19:50:42] I guess you might want to ask Nemo_bis? [19:51:05] FlorianSW: we need https://gerrit.wikimedia.org/r/#/c/260166/ too to save breaking everything ;D [19:51:13] Reedy: do you have a quick solution to check, if User::getSkin() is used? It turns out, github search isn't very useful for that :D [19:51:26] Reedy: My plan was to wait until the vendor change is merged without any problems :) [19:51:42] probably. tto said that it would be ok if she wouldn't be available [19:51:42] I was using PhpStorm [19:51:46] I already have a gerrit interface open with "+2" marked any ready to press submit :) [19:51:49] Nemo_bis: hi [19:52:07] Just not got everything fully up to date... [19:52:11] Reedy: hmm, I hoped you have a way, where I don't need to download all extensions (e.g. tool labs :P) [19:52:19] I do [19:52:24] Just all my clones won't be up to date [19:52:27] Takes a little while :P [19:52:27] (03Merged) 10jenkins-bot: Update zordius/lightncandy to v0.23 [vendor] - 10https://gerrit.wikimedia.org/r/260165 (owner: 10Reedy) [19:52:45] Reedy: That was what I want to avoid :P [19:52:51] I can check in a bit [19:52:54] (03CR) 10Florianschmidtwelzow: [C: 032] Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 (owner: 10Reedy) [19:53:13] Reedy: no rush :) Thanks! [19:53:52] (03CR) 10Florianschmidtwelzow: [C: 032] Removed OutputPage::includeJQuery() [core] - 10https://gerrit.wikimedia.org/r/261923 (owner: 10Reedy) [19:56:02] (03CR) 10Florianschmidtwelzow: [C: 04-2] "This would allow a developer to load _any_ php file, no matter if it is a composer auotloader or not. That's inacceptable." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [19:56:42] (03PS1) 10Jonas Kress (WMDE): Bottom Navbar Styles [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/261985 [20:00:26] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912874 (10Florian) "putting extension.json in a callback" doesn't make sense for me :) I'm pretty sure, if Wikibase will be converted to extension.json, that it will work with the c... [20:00:33] (03Merged) 10jenkins-bot: Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 (owner: 10Reedy) [20:05:18] hoo: hey, hi [20:05:21] long time [20:05:31] hi d3r1ck :) [20:08:03] is there any way of using browserify from php to create bundles on the fly? [20:08:51] I can't find any way of doing this [20:09:07] 10MediaWiki-ResourceLoader: Add support for (custom) loadScript sources to ResourceLoader - https://phabricator.wikimedia.org/T32022#1912876 (10Tacsipacsi) [20:10:05] (03PS1) 10Jonas Kress (WMDE): Make it easier to select example [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/261986 [20:12:05] 10MediaWiki-General-or-Unknown: Magic word to add noindex to a page's header - https://phabricator.wikimedia.org/T10068#1912880 (10Wbm1058) [20:12:06] 10MediaWiki-General-or-Unknown: Addition of __NOSPIDER__ token for pages - https://phabricator.wikimedia.org/T16209#1912879 (10Wbm1058) [20:12:26] victorbarbu_: wouldn't this be a performance monster? :) [20:12:35] not sure [20:13:14] I think that with good servers and a good cache system... [20:15:10] mediawiki minifies js and css on the fly [20:15:29] of course, minification is much faster that bundling [20:19:57] 10MediaWiki-extensions-CodeEditor, 10Graph, 10VisualEditor: "Script file not found: worker-json.js" appears after opening the Graph editor dialog - https://phabricator.wikimedia.org/T118895#1912887 (10ferdbold) 5Open>3Resolved [20:20:23] 10MediaWiki-Categories, 5Patch-For-Review: Category pages causes articles to list in one row and the "letter" in another - https://phabricator.wikimedia.org/T104541#1912889 (10Nnemo) @MaxSem I am afraid that @matmarex is right. Breaking the list would be ugly; the first item belongs to the list. Maybe putting... [20:21:22] 10MediaWiki-extensions-CodeEditor, 10Graph, 10VisualEditor: "Script file not found: worker-json.js" appears after opening the Graph editor dialog - https://phabricator.wikimedia.org/T118895#1811924 (10ferdbold) Closing this as is doesn't happen anymore in local as well as on mediawiki.org [20:21:38] (03CR) 10Reedy: "recheck" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261983 (owner: 10Reedy) [20:22:09] 10Wikimedia-Site-Requests: Userspace pages should be added to robots.txt list - https://phabricator.wikimedia.org/T16333#1912891 (10Wbm1058) [20:22:11] 10Wikimedia-Site-Requests: add user talk namespace of En.Wikipedia to Robots.txt - https://phabricator.wikimedia.org/T15890#1912893 (10Wbm1058) [20:24:11] (03CR) 10Paladox: "Could we do something like setting the folder that autoload is set in." [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [20:25:42] (03CR) 10Jonas Kress (WMDE): [C: 032] Avoid full qualified class names and prefer require [data-values/value-view] - 10https://gerrit.wikimedia.org/r/259757 (owner: 10Thiemo Mättig (WMDE)) [20:26:50] 6Education-Collab: Create a Collab barnstar - https://phabricator.wikimedia.org/T114077#1912896 (10Selsharbaty-WMF) Done. The Barnstar lives here: https://outreach.wikimedia.org/wiki/Template:Ed_Collab/Barnstar1 [20:27:04] 6Education-Collab: Create a Collab barnstar - https://phabricator.wikimedia.org/T114077#1912898 (10Selsharbaty-WMF) 5Open>3Resolved [20:27:43] (03Merged) 10jenkins-bot: Avoid full qualified class names and prefer require [data-values/value-view] - 10https://gerrit.wikimedia.org/r/259757 (owner: 10Thiemo Mättig (WMDE)) [20:28:37] FlorianSW: Can nearly tell you :P [20:28:57] wohoo :D [20:29:15] Reedy: do you have a fibre glass connection in GB? :) [20:29:19] (03CR) 10Florianschmidtwelzow: "That would be the same? :)" [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [20:29:21] Bahaha [20:29:22] No [20:29:30] I've got bonded adsl to give about 5Mbps [20:29:36] But atm, one of the lines has a fault [20:29:44] So it's about 3-3.2 [20:29:53] ouch, sorry for the question :P [20:29:59] That#s really bad :/ [20:30:08] Just a bit [20:30:10] heh [20:31:10] Santa didn't bring be fibre to the chimney :( [20:31:29] Lines are 8-8.5KM long to the exchange [20:31:38] And not much closer to the VDSL cabinets [20:33:57] FlorianSW: All gone :D [20:34:06] 8 kilometers? It's great to have 2.5 Mbps then! :) [20:34:14] Reedy: that sounds great! Thanks for checking :P [20:34:35] Yeah, pretty good generally for the length [20:34:39] (03CR) 10Florianschmidtwelzow: [C: 032] User::getSkin() was removed [core] - 10https://gerrit.wikimedia.org/r/261896 (owner: 10Reedy) [20:34:56] iirc you wouldn't get dsl in germany, let me check :) [20:35:26] Isn't ISDN more prevelant over there? [20:36:50] ISDN has a max length of 6 km for 0,4mm cu cables, and 8 km for 0,6mm :/ [20:37:23] Hmm [20:37:31] They're pushign satellite now [20:37:32] Ughhhh [20:38:17] That doesn't sound much better :/ [20:39:04] * FlorianSW doesn't find this damn table of max. DSL cable lengths... [20:39:19] http://www.increasebroadbandspeed.co.uk/2013/chart-bt-fttc-vdsl2-speed-against-distance [20:39:29] That's VDSL [20:39:46] http://www.increasebroadbandspeed.co.uk/2012/graph-ADSL-speed-versus-distance [20:39:56] Not quite sure how I get the speeds I do [20:41:20] I have 6 or 7 km in my head for a dsl 1000 kBit/s, that might be true, but maybe not :P [20:41:46] There's a lot you can do with line profiles, newer tech etc [20:42:00] You can, in fact, use a higher bandwidth, if you want, but the problem is, that you will interrupt other connections in the same cable :P Or your connection isn't really stable [20:42:07] Yeah [20:42:42] That's why Deutsche Telekom has really hard limits when and when not to provide a specific dsl bandwidth [20:42:46] S.O.S [20:42:53] (03Merged) 10jenkins-bot: User::getSkin() was removed [core] - 10https://gerrit.wikimedia.org/r/261896 (owner: 10Reedy) [20:42:55] FlorianSW: please, save me [20:42:56] stability before performance [20:42:56] (03Merged) 10jenkins-bot: Removed OutputPage::includeJQuery() [core] - 10https://gerrit.wikimedia.org/r/261923 (owner: 10Reedy) [20:43:15] victorbarbu_: ? [20:43:21] FlorianSW: My ISP let you choose your line profile via their website [20:43:27] What do I do to get my task approved? [20:43:29] :( [20:43:29] And all sorts of other things [20:43:57] Reedy: oha, that sounds interesting and like a nightmare for a customer support, at least here in germany :P [20:44:12] Is it a special provider or someone who provides these things to _all_ customers? [20:44:23] They will, yeah [20:44:30] They're xkcd/806 compliant too [20:44:38] victorbarbu_: if you ask your mentor, he will appove the task if he think it's finished :) [20:44:43] https://en.wikipedia.org/wiki/Andrews_%26_Arnold [20:44:52] she will not be available for the next 2 days [20:45:08] victorbarbu_: There are plenty of wikimedia bugs out there for you to work on. :) [20:45:29] but they won't get higher on the hierarchy [20:45:30] Theres a 36 hour limit i think after you submit as well so an admin will mark it complete if theres sufficient evidence its done. [20:45:49] but 36 hours is enormous [20:46:02] I waited 35 for the one before lasdt :) [20:46:02] FlorianSW: I just found one that isn't used already :D [20:46:32] victorbarbu_: Nemo_bis taught me this lesson. "non ti corre dietro un treno", meaning "no need to hurry." :) [20:47:10] mhutti1: So you know that feeling as well. [20:47:29] xkcd/806 sounds like a nightmare for the guy who receives the "SHIPBOLEET" calls and a dream for anyone else :P [20:47:32] yeah, because you couldn't know if your mentor would be available in that interval [20:47:36] (03PS1) 10Reedy: WikiPage::updateRestrictions() was removed [core] - 10https://gerrit.wikimedia.org/r/261987 [20:47:44] I know my mentor won't be available for the next 48 hours [20:48:47] Reedy: 1000 pounds/month [20:48:52] For? [20:49:07] Reedy: "primarily serving businesses and "technical" home users." that sounds interesting :) [20:49:12] company you use as internet provider [20:49:19] (03PS1) 10Reedy: Remove WikiPage::preSaveTransform() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261988 [20:49:23] victorbarbu_: Far from that [20:49:48] (03PS3) 10Gergő Tisza: Add largest allowed range as parameter to block form message [core] - 10https://gerrit.wikimedia.org/r/261776 [20:49:58] that would be a loooot for a 5mbps connection :P [20:51:21] (03PS2) 10Reedy: Remove WikiPage::preSaveTransform() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261988 [20:51:23] They're worth the money [20:51:27] They're relentless with BT [20:52:13] but 1000 Pounds per month? :/ [20:52:21] Nope [20:52:26] 75 gbp [20:52:30] for 300GB [20:52:42] A third of that is because I need 2 lines ot get a useable amount of speed [20:52:53] (03PS7) 10Ferdbold: Handle empty datasets in graphs [extensions/Graph] - 10https://gerrit.wikimedia.org/r/253777 (https://phabricator.wikimedia.org/T118898) [20:54:23] ah, ok, that sounds like a good price. Does 300 GB mean, you have a limit after 300gb transmitted data? [20:54:33] usually a topup [20:54:45] They're releasing a 1TB package very soon [20:55:19] http://aa.net.uk/news-2016-terabyte.html [20:55:24] 60 GBP a month [20:55:35] upto 80 Mb/s [20:55:45] hmm, anyone is crying in germany, if someone wants to establish such a model :) [20:55:54] You have a limit on data? 0_0 [20:56:13] Yeah [20:56:15] Georggi: why not? That sounds reasonable for me :) [20:56:16] Most ISPs do [20:56:20] "The service is a VDSL (Fibre to the Cabinet) based service" [20:56:22] not in germany ;) [20:56:31] like I said [20:56:42] 100 mb\s, unlimited data, ~3Euro\month [20:56:49] 3? [20:56:52] Yes [20:56:53] 3 [20:56:58] .... [20:57:02] Well I converted from my currency [20:57:04] That's obscene [20:57:25] Where are you? Romania? [20:57:35] Ukraine:) [20:57:35] a good question! [20:57:41] aha [20:57:48] (03PS1) 10Reedy: WikiPage::testPreSaveTransform() was removed [core] - 10https://gerrit.wikimedia.org/r/261989 [20:58:20] So ping is quite good too [20:58:36] (03CR) 10Paladox: "Oh how can we allow them to choose the path to autoload.php without breaking the security." [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [20:58:39] You don't want to know how much a 100 mb/s unlimited connection would cost me [20:58:42] "Mid January we expect to open this to selected customers (we'll ask on irc)" nice [20:58:51] Krenair: They're pretty awesome [20:58:55] hoo: I am in Romania [20:59:01] I had nearly 20 BT engineers out in 2015 [20:59:37] Reedy: how much? [20:59:40] 10MediaWiki-Configuration, 10Wikidata: Support putting extension.json in a callback - https://phabricator.wikimedia.org/T122748#1912901 (10Paladox) How can I migrate wikibase to extension registration since I have tried here https://gerrit.wikimedia.org/r/#/c/229119/ but keeps failing and I am not sure why. [20:59:41] I've a 16 MBit/s unlimited connection and pay far away from 3 Euro/month [20:59:45] an engineer every 2-3 weeks? doesn't sound very reliable [20:59:48] 10MediaWiki-extensions-Newsletter, 7Easy, 7I18n: [[MediaWiki:Newsletter-email-batch-body/en]] needs GENDER support on $2. - https://phabricator.wikimedia.org/T122717#1912902 (10Purodha) The message - text to be found in .../i18n/en.json - needs the magic word {{GENDER:$2|....}} added so as to correctly talk... [20:59:52] Krenair: It was over a few months [20:59:57] To resolve some dropping faults [20:59:59] Think 2 lines [21:00:10] I know ISP in my city which provides 1Gbit\s for around same price [21:00:11] In Milan it's ~39 €/m for 300/20 [21:00:12] I had 2 engineers at a time out on 2 days [21:00:31] Like for 3 GBP [21:00:48] but they dont give open ports and static ip adress for free [21:01:00] my ISP does [21:01:01] all ports closed? :P [21:01:10] :D [21:01:21] well, obviously not all I guess [21:01:26] I pay 10 euros/month for a 200mbps unlimited [21:01:27] but most [21:01:28] with ipv6 [21:01:59] Georggi: only an internet connection or telephone included? [21:02:00] I still dont get what ipv6 gives you [21:02:08] well, only internet [21:02:14] When there's no IPv4 addresses left... [21:02:16] you as a customer? An IP adress :P [21:02:16] I dont have home telephone [21:02:26] And you don't want consumer grade NAT at your ISP.. [21:02:29] but it costs like 1 Euro [21:03:03] my ISP doesn't block any port, that's like a standard here, and it's good so :) [21:03:22] Well my doesnt either [21:03:28] wait what 200 mbps? where can I get that? [21:03:43] FTTP :P [21:03:43] i don't know where [21:03:47] in romania [21:03:47] Go to Romania:D [21:03:49] :)) [21:03:52] NOO [21:03:54] don't come here [21:04:18] Well, you can go to my city for 1Gbit\s for 3GBP [21:04:34] Do you actually get these silly speeds 24/7? [21:04:40] Or is it shared between some larger amount? [21:04:47] and additional 1 GBP for static ip adress and open ports [21:04:53] you know, it might be cheap for you unicornisaurous [21:05:02] Well I have it any time I want [21:05:04] but in romania, lowest salaries are around 200 euros [21:05:09] think about it ;) [21:05:16] Phh [21:05:31] Ukraine, lowest salary - ~60$ [21:05:47] 60$ per Month? o.O [21:05:57] FlorianSW: Merge some more stuff bitte :D [21:06:24] I'm gonna have tackle Linker soon... And wfMsg in GlobalFunctions [21:06:44] Reedy: ah, let me see, what you did :P wfMsg would be great! :D [21:06:51] Not yet ;) [21:07:24] Well, lowest legal salary is 57.5$ here FlorianSW [21:07:33] per Month [21:07:35] ukraine? [21:07:39] Yeah:( [21:07:51] oh, surprisingly, romania is better than someone [21:07:52] But if cost of living etc is a lot cheaper... :) [21:08:05] Reedy: it's not [21:08:13] in Romania, at least [21:08:46] but here, in Eastern Europe... [21:08:55] I guess, this applies to almost every country [21:09:01] Compared to the UK Romania is quite cheap [21:09:07] Well, it is a lot cheaper, but when you need to buy something like computer components,, it suddenly becomes very expensive [21:09:18] yep [21:09:44] even though for some countries 400$ component is relativly cheap [21:09:54] a bottle of water is around $0.5 here [21:10:12] 1L? [21:10:19] 0.5L [21:10:22] ;) [21:10:40] 2L is around $1 [21:10:42] You can buy 6L here;) for that price [21:10:48] :)))) [21:10:51] (03PS1) 10Reedy: Remove LogPage::logName() [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/261990 [21:10:54] technically, you can ven buy 12L for that [21:10:56] I'll come to Ukraine for buying water [21:11:05] but you need to know where [21:11:13] supermarket, i guess [21:11:29] No, supermarket is more expensive, because you are buying bottle too [21:11:42] oh, you mean buying the water itself [21:11:44] (03CR) 10Florianschmidtwelzow: [C: 032] WikiPage::updateRestrictions() was removed [core] - 10https://gerrit.wikimedia.org/r/261987 (owner: 10Reedy) [21:11:51] (03PS1) 10Reedy: Remove LogPage::logName() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261991 [21:12:22] (03CR) 10Florianschmidtwelzow: [C: 032] WikiPage::testPreSaveTransform() was removed [core] - 10https://gerrit.wikimedia.org/r/261989 (owner: 10Reedy) [21:12:35] The last time I saw speeds above 100mbps was at an Apple conference, where we had ~600 down ~900 up during peak usage [21:12:57] wow [21:12:59] nice [21:13:03] But still, when you need to buy something imported... Prices are too high for most of people [21:13:05] https://gerrit.wikimedia.org/r/261911 can anyone look at this? [21:13:24] Georggi: unlike western countries [21:13:26] or us [21:13:55] (03CR) 10Florianschmidtwelzow: [C: 032] Remove WikiPage::preSaveTransform() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261988 (owner: 10Reedy) [21:14:44] (03PS1) 10Reedy: Remove LogPage::logName() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261992 [21:14:46] (03CR) 10Florianschmidtwelzow: [C: 032] Remove LogPage::logName() [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/261990 (owner: 10Reedy) [21:14:49] You could wait for tto, he will come in 2 hours [21:14:56] (03CR) 10Florianschmidtwelzow: [C: 032] Remove LogPage::logName() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261991 (owner: 10Reedy) [21:15:08] 6Security, 10Wikimedia-Site-Requests: Enable $wgCrossSiteAJAXdomains for sites hosted at WMF Labs and Tool Labs - https://phabricator.wikimedia.org/T122720#1912904 (10Krenair) > Labs (`*.wmflabs.org`) and Tool Labs (`tools.wmflabs.org`) Tools is part of labs, and matches the first domain. I think this is one... [21:15:15] (03CR) 10jenkins-bot: [V: 04-1] Remove LogPage::logName() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261992 (owner: 10Reedy) [21:15:26] I'll be sleeping in 2 hours [21:15:29] I hope [21:15:55] 6Security, 10Wikimedia-Site-Requests: Add labs to $wgCrossSiteAJAXdomains - https://phabricator.wikimedia.org/T122720#1912907 (10Krenair) [21:16:17] (03PS1) 10Reedy: LogPage::logName() was removed [core] - 10https://gerrit.wikimedia.org/r/261993 [21:16:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] Remove LogPage::logName() (031 comment) [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261992 (owner: 10Reedy) [21:16:34] By the way, I dont think jenkins accepts recheck from you victorbarbu_:) [21:16:45] he does [21:16:49] I am whitelisted [21:16:49] I'm pretty sure it does [21:16:51] hopefully :P [21:16:56] Why I am not whitelisted:( [21:17:03] but Jenkins is not configured for that repo [21:17:05] Georggi: you never asked :P [21:17:12] Really?:D [21:17:20] (03PS2) 10Reedy: LogPage::logName() and logHeader() were removed [core] - 10https://gerrit.wikimedia.org/r/261993 [21:17:25] What's your e-mail in gerrit, or with what you commit changes? [21:17:31] 6Security, 10Wikimedia-Site-Requests: Enable $wgCrossSiteAJAXdomains for sites hosted at localhost - https://phabricator.wikimedia.org/T122721#1912909 (10Krenair) [21:17:58] let me check.. [21:18:06] or you could make a change to add yourself, like I did, and then add somebody like florian as a reviewer [21:18:12] 6Security, 10Wikimedia-Site-Requests: Add localhost to $wgCrossSiteAJAXdomains - https://phabricator.wikimedia.org/T122721#1912912 (10Krenair) [21:18:13] bmp2558@gmail.com [21:18:22] or so :P [21:18:32] (03Merged) 10jenkins-bot: WikiPage::updateRestrictions() was removed [core] - 10https://gerrit.wikimedia.org/r/261987 (owner: 10Reedy) [21:18:44] Georggi: you're a GCI student, right? [21:18:57] (03PS2) 10Reedy: Remove LogPage::logName() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261992 [21:19:09] Of course:) [21:19:46] FlorianSW: With those 3 core removals above... 13 more PHP functions still to be removed! :D [21:19:48] Georggi: do you want to propose your self in gerrit? [21:19:59] Reedy: I'm here :D [21:20:11] let me do one, too :D [21:20:24] $wgCopyrightIcon is a bugger [21:20:49] (03Merged) 10jenkins-bot: WikiPage::testPreSaveTransform() was removed [core] - 10https://gerrit.wikimedia.org/r/261989 (owner: 10Reedy) [21:20:51] (03Merged) 10jenkins-bot: Remove WikiPage::preSaveTransform() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261988 (owner: 10Reedy) [21:20:53] (03Merged) 10jenkins-bot: Remove LogPage::logName() [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/261990 (owner: 10Reedy) [21:20:55] (03Merged) 10jenkins-bot: Remove LogPage::logName() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/261991 (owner: 10Reedy) [21:21:37] What do you mean by propose myself in gerrit? [21:22:03] Georggi: Make a change to the integration/config repo, like https://gerrit.wikimedia.org/r/#/c/260028/ [21:22:03] Georggi [21:22:05] https://gerrit.wikimedia.org/r/#/c/261606/ [21:22:28] (03Abandoned) 10Reedy: Update ruflin/elastica v2.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/261982 (owner: 10Reedy) [21:22:33] (03Abandoned) 10Reedy: Update ruflin/elastica v2.2.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261983 (owner: 10Reedy) [21:22:35] Add lego as a reviewer, he seems to be the one approving those [21:22:37] ah ok [21:23:26] 10MediaWiki-extensions-Gadgets, 7I18n, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Adding Icelandic (is) namespaces for Gadgets extension - https://phabricator.wikimedia.org/T122718#1912917 (10Legoktm) 5Open>3Resolved a:3Legoktm [21:23:40] Reedy: let me remove wgCopyrightIcon :P [21:23:47] FlorianSW: <3 [21:23:55] You'll need to update mediawiki-config for that onet oo [21:24:01] Who is the person doing lots of Make MediaWiki documentation translatable tasks? [21:24:37] What makes you think someone is doing those? [21:24:53] Georggi: Nemo_bis [21:25:04] oh no [21:25:18] Nemo_bis does the ones with "make mediawiki translatable" [21:25:23] I mean who is student doing lots of them [21:25:35] Yeah I thought you meant student [21:25:44] What makes you think they are getting done? [21:25:50] They are instanced [21:26:03] Multpile people can do at once [21:26:06] There are so many of those(20) because someone is doing lots of them [21:26:46] I guess he\she is not here [21:27:44] Just because nemo decided to make a lot of them doesn’t mean they are all getting done [21:28:16] They are, at least according to what tto said [21:28:25] Nemo said someone was [21:28:33] he said there is a student who is doing lots of them [21:28:46] he might be in i18n channel though [21:29:07] Or he might not be in IRC at all, ya never know [21:29:53] The 20th task requires 1400 (!!!!) units [21:29:56] (03PS1) 10Ferdbold: [WIP] Support Vega2 graphs in VE [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261995 (https://phabricator.wikimedia.org/T122750) [21:30:57] (03PS1) 10Florianschmidtwelzow: Remove $wgCopyrightIcon [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/261996 [21:31:34] (03CR) 10Reedy: [C: 032] Remove $wgCopyrightIcon [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/261996 (owner: 10Florianschmidtwelzow) [21:31:54] (03Merged) 10jenkins-bot: Remove $wgCopyrightIcon [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/261996 (owner: 10Florianschmidtwelzow) [21:32:49] FlorianSW: $wgCopyrightIcon = str_replace( $urlText, htmlspecialchars( $url ), $this->oldCopyrightIcon); [21:32:58] that's still in dumphtml :P [21:33:46] AHHHH! [21:35:15] (03PS1) 10Florianschmidtwelzow: Really remove $wgCopyrightIcon [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/261998 [21:36:26] Georggi: Theres some GCI students on https://www.mediawiki.org/w/index.php?title=Special:ListUsers&offset=&limit=500&username=&group=translationadmin, so we know at least somebody is doing them :P [21:36:34] (03CR) 10Reedy: [C: 032] Really remove $wgCopyrightIcon [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/261998 (owner: 10Florianschmidtwelzow) [21:36:51] (03Merged) 10jenkins-bot: Really remove $wgCopyrightIcon [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/261998 (owner: 10Florianschmidtwelzow) [21:37:13] mhutti, wow, you did 24 tasks 0_0 [21:38:25] If you’re counting gerrit reviews, you don’t know if all his tasks were code tasks, and you also don’t know if there were multiple reviews for one tasks. [21:38:28] *task [21:38:34] true [21:38:41] Yeah I have only done 23 ... [21:39:19] But some of them took me days others 20 mins so its really not that important the number you do i guess [21:39:32] Reedy: you, by any chance, know what this do? https://github.com/wikimedia/mediawiki-extensions-Configure/blob/master/settings/Settings-core.php [21:40:03] What do you mean? [21:40:49] Georggi: Yeah keep in mind you only have to get top 10 to be eligible for finalist/grand prize for the wikimedia. Even if you’re #10 then they could still pick you [21:41:46] FlorianSW: I think you just remove it from there tbh :P [21:41:51] I kind of feel more confident when I've done a lot of tasks:D [21:42:06] Reedy: that was my idea, too :P [21:42:44] Just make sure the replacement goes into the release-notes [21:42:45] (03CR) 10Victorbarbu: "recheck" [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [21:42:54] I was trying to download the source code for wikimedia in a step I was supposed to ssh into git but GitHub doesn't provide shell access so what am I supposed to do instead? [21:43:10] hi neeraj [21:43:20] what repository are you trying to download? [21:44:37] Krenair, I think "core" [21:44:42] Hello Krenair, actually as for now I was only trying whether ssh works on my machine or not but it give me an error- [21:44:53] ssh: connect to host github.com port 22: Connection refused: [21:44:59] Are you using gerrit? [21:45:05] yes. [21:45:16] victorbarbu_, because they're connecting to github instead of gerrit, I thought maybe not [21:45:30] Have you checked out https://www.mediawiki.org/wiki/Gerrit/Getting_started ? [21:45:32] Krenair :) [21:45:41] yes. [21:45:49] I was following those instructions. [21:45:57] (03PS1) 10Florianschmidtwelzow: Remove $wgCopyrightIcon [extensions/Configure] - 10https://gerrit.wikimedia.org/r/262000 [21:46:25] github is not mentioned on that page neeraj [21:47:11] in the step:- Set Up SSH Keys in Gerrit [21:47:22] I followed the link. [21:48:24] and I was supposed to generate an SSH key [21:48:33] you're looking at https://help.github.com/articles/generating-ssh-keys ? [21:49:08] yes. [21:49:39] you got it all wrong [21:49:41] (03PS1) 10Florianschmidtwelzow: Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 [21:50:24] okay [21:50:26] (03PS2) 10Florianschmidtwelzow: Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 [21:50:27] I see where the confusion is [21:50:38] ?? [21:50:43] https://www.mediawiki.org/w/index.php?title=Gerrit/Getting_started&diff=2000209&oldid=1921464 [21:51:04] legoktm, hi, pls review https://gerrit.wikimedia.org/r/#/c/262002/ [21:51:25] neeraj, so you have an SSH key, did you add it to gerrit? [21:51:51] (03CR) 10Florianschmidtwelzow: [C: 032] Remove LogPage::logName() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261992 (owner: 10Reedy) [21:51:51] 10MediaWiki-Search, 6Discovery: CompletionSuggester prepends extra / to Wikipedia: namespace searches in Hungarian Wikipedia - https://phabricator.wikimedia.org/T122751#1912941 (10Tgr) 3NEW [21:51:52] No. [21:51:59] 10MediaWiki-Search, 6Discovery: CompletionSuggester prepends extra / to Wikipedia: namespace searches in Hungarian Wikipedia - https://phabricator.wikimedia.org/T122751#1912949 (10Tgr) Side note: please don't put `search` in all the Discovery sprint project name aliases. It spams the project dropdown in Phabri... [21:52:09] (03CR) 10Paladox: "But woulden the user already have access to change the path directly." [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [21:52:24] neeraj, okay, you should do that and then you can confirm it with ssh @gerrit.wikimedia.org -p 29418 [21:52:35] (03Merged) 10jenkins-bot: Remove LogPage::logName() [extensions/InterwikiIntegration] - 10https://gerrit.wikimedia.org/r/261992 (owner: 10Reedy) [21:52:49] thank you krenair. [21:52:56] yw, let me know if you get stuck [21:53:54] (03CR) 10Mhutti1: Reformatted documentation for $wgFooterIcons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [21:54:32] (03CR) 10Florianschmidtwelzow: [C: 032] LogPage::logName() and logHeader() were removed [core] - 10https://gerrit.wikimedia.org/r/261993 (owner: 10Reedy) [21:55:03] (03CR) 10Reedy: Remove $wgCopyrightIcon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262001 (owner: 10Florianschmidtwelzow) [21:55:44] (03CR) 10Victorbarbu: "I know!" [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [21:57:27] (03CR) 10jenkins-bot: [V: 04-1] Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 (owner: 10Florianschmidtwelzow) [21:57:35] lol [21:57:53] (03PS4) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) [21:58:36] (03CR) 10Reedy: [C: 04-1] Remove $wgCopyrightIcon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262001 (owner: 10Florianschmidtwelzow) [21:58:55] (03CR) 10Paladox: Update load_composer_autoloader config in extension registration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) (owner: 10Paladox) [21:59:44] (03PS1) 10Florianschmidtwelzow: Remove Language::armourMath() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262003 [21:59:57] 10MediaWiki-Search, 10CirrusSearch, 6Discovery: CompletionSuggester prepends extra / to Wikipedia: namespace searches in Hungarian Wikipedia - https://phabricator.wikimedia.org/T122751#1912950 (10Tgr) [22:00:27] (03PS5) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) [22:02:15] (03PS6) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) [22:02:24] (03Merged) 10jenkins-bot: LogPage::logName() and logHeader() were removed [core] - 10https://gerrit.wikimedia.org/r/261993 (owner: 10Reedy) [22:02:53] (03PS1) 10Florianschmidtwelzow: Remove Language::armourMath() and friends [core] - 10https://gerrit.wikimedia.org/r/262004 [22:03:13] (03CR) 10jenkins-bot: [V: 04-1] Remove Language::armourMath() and friends [core] - 10https://gerrit.wikimedia.org/r/262004 (owner: 10Florianschmidtwelzow) [22:04:57] Reedy: I donÄt understand you second command here: https://gerrit.wikimedia.org/r/#/c/262001/2/includes/skins/Skin.php :/ [22:04:59] (03PS1) 10Reedy: Replace Linker::makeLinkObj() [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/262005 [22:05:29] FlorianSW: You can ignore it mostly [22:05:35] I think [22:05:36] ok :P [22:05:45] ? :) [22:06:02] (03PS3) 10Florianschmidtwelzow: Remove $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/262001 [22:06:05] Where $wgFooterIcons are processed... copyright copyright is output? [22:07:16] (03PS1) 10Reedy: Replace Linker::makeLinkObj() [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/262006 [22:07:22] (03PS7) 10Paladox: Update load_composer_autoloader config in extension registration [core] - 10https://gerrit.wikimedia.org/r/261976 (https://phabricator.wikimedia.org/T122749) [22:07:55] (03PS1) 10Reedy: Replace Linker::makeLinkObj() [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262007 [22:08:08] Reedy: https://github.com/wikimedia/mediawiki/blob/e76fd07e7cb43f4ddee55deaf0626edbb7380a7c/includes/skins/SkinTemplate.php#L405-L422 ? [22:08:38] 4(no projects): #invoke seems do not record the module, for some weeks. - https://phabricator.wikimedia.org/T122752#1912951 (10Rical) 3NEW [22:09:05] (03PS2) 10Florianschmidtwelzow: Remove Language::armourMath() and friends [core] - 10https://gerrit.wikimedia.org/r/262004 [22:09:27] (03PS1) 10Reedy: Fix undefined $db [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262008 [22:10:04] FlorianSW: Does copyright copyright get ignored then? [22:11:04] (03PS1) 10Reedy: Replace Linker::makeLinkObj() [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/262009 [22:11:04] I think it depends on, if the skin uses the copyrightico data and renders all the footericons data, too :) [22:13:50] (03PS37) 10Paladox: Add extension.json, empty PHP entry point [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/208519 (https://phabricator.wikimedia.org/T87889) [22:14:38] (03PS1) 10Reedy: Replace Linker::makeLinkObj() [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/262011 [22:17:50] (03PS19) 10Paladox: empty PHP entry point [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/209865 (https://phabricator.wikimedia.org/T87891) [22:18:23] (03PS1) 10Reedy: Replace Linker::makeKnownLinkObj() [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262012 [22:18:50] (03PS13) 10Paladox: Add extension.json, empty php entry point [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/214072 (https://phabricator.wikimedia.org/T87923) [22:19:49] (03PS1) 10Reedy: Replace Linker::makeKnownLinkObj() [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/262013 [22:31:49] (03PS1) 10Florianschmidtwelzow: Remove ApiMain::getModules() and ApiQuery::getModules() [core] - 10https://gerrit.wikimedia.org/r/262014 [22:32:14] (03CR) 10Florianschmidtwelzow: [C: 032] Fix undefined $db [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262008 (owner: 10Reedy) [22:32:43] (03Merged) 10jenkins-bot: Fix undefined $db [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262008 (owner: 10Reedy) [22:33:42] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeLinkObj() [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/262005 (owner: 10Reedy) [22:33:57] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeLinkObj() [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/262006 (owner: 10Reedy) [22:34:07] (03PS2) 10Florianschmidtwelzow: Replace Linker::makeLinkObj() [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262007 (owner: 10Reedy) [22:34:14] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeLinkObj() [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262007 (owner: 10Reedy) [22:34:18] (03PS1) 10Reedy: Replace Linker::makeKnownLinkObj() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/262015 [22:34:38] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeLinkObj() [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/262009 (owner: 10Reedy) [22:34:40] (03Merged) 10jenkins-bot: Replace Linker::makeLinkObj() [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/262005 (owner: 10Reedy) [22:34:42] (03Merged) 10jenkins-bot: Replace Linker::makeLinkObj() [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/262006 (owner: 10Reedy) [22:35:45] (03Merged) 10jenkins-bot: Replace Linker::makeLinkObj() [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/262009 (owner: 10Reedy) [22:35:49] (03PS1) 10Reedy: Replace Linker::makeKnownLinkObj() [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262016 [22:35:53] (03Merged) 10jenkins-bot: Replace Linker::makeLinkObj() [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/262011 (owner: 10Reedy) [22:36:08] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeKnownLinkObj() [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262012 (owner: 10Reedy) [22:36:21] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeKnownLinkObj() [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/262013 (owner: 10Reedy) [22:36:35] Happy new year everybody :) [22:36:47] (03Merged) 10jenkins-bot: Replace Linker::makeKnownLinkObj() [extensions/ImageTagging] - 10https://gerrit.wikimedia.org/r/262012 (owner: 10Reedy) [22:36:50] (03Merged) 10jenkins-bot: Replace Linker::makeKnownLinkObj() [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/262013 (owner: 10Reedy) [22:38:35] (03PS1) 10Reedy: Replace Linker::makeKnownLinkObj() [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/262017 [22:39:59] (03PS16) 10Paladox: Rename table page_counter to htc_page_counter [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/220932 [22:41:01] (03CR) 10Paladox: "check experimental" [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/220932 (owner: 10Paladox) [22:41:50] (03PS1) 10Reedy: Linker::makeKnownLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262019 [22:41:54] FlorianSW: ^ That's an exciting one :D [22:42:17] :D [22:44:46] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeKnownLinkObj() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/262015 (owner: 10Reedy) [22:44:58] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeKnownLinkObj() [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262016 (owner: 10Reedy) [22:45:19] (03Merged) 10jenkins-bot: Replace Linker::makeKnownLinkObj() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/262015 (owner: 10Reedy) [22:45:25] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeKnownLinkObj() [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/262017 (owner: 10Reedy) [22:45:37] (03Merged) 10jenkins-bot: Replace Linker::makeKnownLinkObj() [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/262016 (owner: 10Reedy) [22:47:08] 10MediaWiki-Interface, 7I18n, 7Tracking, 7Voice & Tone: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1912961 (10matmarex) [22:47:09] (03Merged) 10jenkins-bot: Replace Linker::makeKnownLinkObj() [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/262017 (owner: 10Reedy) [22:47:22] (03PS1) 10Reedy: Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 [22:47:42] (03CR) 10Reedy: [C: 04-1] "Still a few more of these to fix up" [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy) [22:50:02] (03PS1) 10Florianschmidtwelzow: Remove wfCheckLimits [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262023 [22:51:05] (03PS1) 10Florianschmidtwelzow: Remove wfCheckLimits [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/262024 [22:52:32] (03PS1) 10Florianschmidtwelzow: Remove wfCheckLimits [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/262025 [22:53:50] (03PS1) 10Reedy: Replace Linker::makeLinkObj() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/262026 [22:54:06] That's the last one of those :D [22:54:35] (03CR) 10Reedy: "Commits are all in gerrit now!" [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy) [22:55:08] (03CR) 10Reedy: [C: 032] Remove wfCheckLimits [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262023 (owner: 10Florianschmidtwelzow) [22:55:23] FlorianSW: You could pick some 1.1[0-9] deprecations to remove ;) [22:55:41] (03CR) 10Reedy: [C: 032] Remove wfCheckLimits [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/262024 (owner: 10Florianschmidtwelzow) [22:55:59] (03CR) 10Reedy: [C: 032] Remove wfCheckLimits [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/262025 (owner: 10Florianschmidtwelzow) [22:56:06] Reedy: that was the plan, but then I saw this easy one :P Sorry to interrupt your "kill all the very very very very old deprecated things" flow :( [22:56:14] heh [22:56:16] It's fine :D [22:56:25] You're merging stuff thats keeping it going [22:56:29] I'll take an older one next time :P [22:56:47] (03PS1) 10Florianschmidtwelzow: Remove wfCheckLimits [core] - 10https://gerrit.wikimedia.org/r/262028 [22:58:02] (03CR) 10Florianschmidtwelzow: [C: 032] Replace Linker::makeLinkObj() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/262026 (owner: 10Reedy) [22:58:13] (03Merged) 10jenkins-bot: Remove wfCheckLimits [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262023 (owner: 10Florianschmidtwelzow) [22:58:15] (03Merged) 10jenkins-bot: Remove wfCheckLimits [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/262024 (owner: 10Florianschmidtwelzow) [22:58:17] (03Merged) 10jenkins-bot: Remove wfCheckLimits [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/262025 (owner: 10Florianschmidtwelzow) [22:58:25] (03Merged) 10jenkins-bot: Replace Linker::makeLinkObj() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/262026 (owner: 10Reedy) [23:00:04] Reedy: there are some usages of SkinTemplate::makeLinkObj o.O [23:00:06] :D [23:00:08] (03CR) 10Reedy: "RELEASE-NOTES ?" [core] - 10https://gerrit.wikimedia.org/r/262028 (owner: 10Florianschmidtwelzow) [23:00:46] (03CR) 10Florianschmidtwelzow: "I swear I wrote them! :( But haven't commit..." [core] - 10https://gerrit.wikimedia.org/r/262028 (owner: 10Florianschmidtwelzow) [23:00:52] Where are those? :/ [23:01:35] (03PS2) 10Florianschmidtwelzow: Remove wfCheckLimits [core] - 10https://gerrit.wikimedia.org/r/262028 [23:02:26] https://github.com/wikimedia/mediawiki-extensions-UserPageViewTracker/blob/576d258b39f1b89d60e7551c37f2117b05cdd302/SpecialUserPageViewTracker.php#L120 [23:02:39] https://github.com/wikimedia/mediawiki-extensions-LastUserLogin/blob/master/LastUserLogin.body.php#L112 [23:03:07] (03CR) 10Reedy: [C: 04-1] "WikiObjectModel uses ApiMain::getModules()" [core] - 10https://gerrit.wikimedia.org/r/262014 (owner: 10Florianschmidtwelzow) [23:03:15] oh, and some Linker::makeLinkObj() https://github.com/wikimedia/mediawiki-extensions-WYSIWYG/blob/master/WYSIWYG/CKeditorSkin.body.php#L248 [23:03:37] https://github.com/wikimedia/mediawiki-extensions-SemanticMediaWiki/blob/master/src/Query/PrintRequest.php#L99 [23:03:43] and so on: https://github.com/search?utf8=%E2%9C%93&q=%40wikimedia+makeLinkObj&type=Code&ref=searchresults [23:04:57] Stupid calls [23:05:07] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.action.edit.preview: Combine two the consecutive .push [core] - 10https://gerrit.wikimedia.org/r/261778 (owner: 10Gerrit Patch Uploader) [23:05:24] (03PS1) 10Reedy: Replace makeLinkObj() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/262029 [23:06:05] everyone is on planes, so you guys are having a merge party? :P [23:06:15] Yup [23:06:16] (03PS1) 10Reedy: Replace makeLinkObj() [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262030 [23:06:23] MatmaRex: I'm gonna deploy it all tomorrow [23:06:24] ;D [23:06:53] i suppose the deployment wasn't interesting enough just yet. :P [23:07:14] Most of the usages are in shitty extensions no one cares about :) [23:09:37] (03PS1) 10Reedy: Replace makeLinkObj() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/262032 [23:09:41] (03PS7) 10Anomie: Update for SessionManager [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/247717 [23:10:07] (03PS1) 10Florianschmidtwelzow: Replace ApiMain::getModules [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/262033 [23:10:24] $html .= $uri. "\n"; // @todo Replace makeLinkObj with link as soon as we drop MW1.12 compatibility [23:10:27] .. [23:10:41] FlorianSW: I think that's the rest [23:10:53] ok, I'll take a look :) [23:11:05] We don't have to hurry merge the core change ;) [23:11:24] Reedy: only, if I'm pretty sure, that there is no usage anymore :P [23:11:43] If there are, they are easy to fix up [23:11:49] And they should've fixed them a long time ago :P [23:11:53] (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeLinkObj() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/262029 (owner: 10Reedy) [23:12:06] :D [23:12:08] (03CR) 10Reedy: [C: 032] "Noooo mine now need rebasing ;)" [core] - 10https://gerrit.wikimedia.org/r/262028 (owner: 10Florianschmidtwelzow) [23:12:38] getSkin()->makeLinkObj() already doesn't work for 3 (?) releases :D [23:12:51] Didn't it? [23:12:52] (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeLinkObj() [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262030 (owner: 10Reedy) [23:12:57] Or is it a magic function? [23:13:11] (03CR) 10Reedy: [C: 032] Remove Language::armourMath() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262003 (owner: 10Florianschmidtwelzow) [23:13:14] (03Merged) 10jenkins-bot: mediawiki.action.edit.preview: Combine two the consecutive .push [core] - 10https://gerrit.wikimedia.org/r/261778 (owner: 10Gerrit Patch Uploader) [23:13:17] (03Merged) 10jenkins-bot: Replace makeLinkObj() [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/262029 (owner: 10Reedy) [23:13:23] Hmm, I'm pretty sure, that it shouldn't work, but haven't checked :) [23:13:42] (03CR) 10Reedy: [C: 032] Replace ApiMain::getModules [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/262033 (owner: 10Florianschmidtwelzow) [23:14:00] (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeLinkObj() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/262032 (owner: 10Reedy) [23:15:37] (03CR) 10Reedy: [C: 04-1] Remove ApiMain::getModules() and ApiQuery::getModules() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262014 (owner: 10Florianschmidtwelzow) [23:16:12] Probably about time to wait for Jenkins again [23:17:15] yep [23:17:32] (03Merged) 10jenkins-bot: Remove wfCheckLimits [core] - 10https://gerrit.wikimedia.org/r/262028 (owner: 10Florianschmidtwelzow) [23:17:35] (03Merged) 10jenkins-bot: Replace makeLinkObj() [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262030 (owner: 10Reedy) [23:17:37] (03Merged) 10jenkins-bot: Remove Language::armourMath() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262003 (owner: 10Florianschmidtwelzow) [23:17:39] (03Merged) 10jenkins-bot: Replace ApiMain::getModules [extensions/WikiObjectModel] - 10https://gerrit.wikimedia.org/r/262033 (owner: 10Florianschmidtwelzow) [23:17:43] (03Merged) 10jenkins-bot: Replace makeLinkObj() [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/262032 (owner: 10Reedy) [23:17:45] (03PS8) 10Anomie: Update for SessionManager [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/247717 [23:17:48] (03PS4) 10Anomie: Move grant and IP restriction logic from OAuth to core [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 [23:17:49] He's off again :P [23:17:50] (03PS5) 10Anomie: Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 [23:17:58] (03CR) 10Florianschmidtwelzow: Remove ApiMain::getModules() and ApiQuery::getModules() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/262014 (owner: 10Florianschmidtwelzow) [23:19:47] (03PS2) 10Florianschmidtwelzow: Remove ApiMain::getModules() and ApiQuery::getModules() [core] - 10https://gerrit.wikimedia.org/r/262014 [23:20:43] (03CR) 10Reedy: [C: 032] Remove ApiMain::getModules() and ApiQuery::getModules() [core] - 10https://gerrit.wikimedia.org/r/262014 (owner: 10Florianschmidtwelzow) [23:22:01] (03CR) 10jenkins-bot: [V: 04-1] Move grant and IP restriction logic from OAuth to core [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 (owner: 10Anomie) [23:22:14] (03CR) 10jenkins-bot: [V: 04-1] Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 (owner: 10Anomie) [23:25:05] (03CR) 10Florianschmidtwelzow: "Still some usages :)" [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy) [23:25:18] FlorianSW: What usages? Where? :P [23:25:24] I linked them :D [23:25:43] Ah, found some [23:25:56] WYSIWYG has its own makeLinkObj [23:26:39] yep :) [23:27:01] We don't care about it though :P [23:27:40] stupid thing [23:27:57] FlorianSW: the WYSIWYG one at the end is fixed [23:28:14] ah, ok :) [23:28:15] Or did I not commit it? [23:28:24] Ah, nope [23:28:24] FFS [23:29:00] 10MediaWiki-skins-Blueprint: Blueprint should use MediaWiki core's Less mixins - https://phabricator.wikimedia.org/T122753#1912967 (10Volker_E) 3NEW a:3Volker_E [23:29:06] (03PS1) 10Reedy: Replace makeLinkObj() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262034 [23:29:19] Reedy: I checked it, but in github, it's still there [23:29:22] ah, ok... [23:29:25] lol [23:29:35] (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeLinkObj() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262034 (owner: 10Reedy) [23:30:19] (03Merged) 10jenkins-bot: Remove ApiMain::getModules() and ApiQuery::getModules() [core] - 10https://gerrit.wikimedia.org/r/262014 (owner: 10Florianschmidtwelzow) [23:30:25] (03Merged) 10jenkins-bot: Replace makeLinkObj() [extensions/WYSIWYG] - 10https://gerrit.wikimedia.org/r/262034 (owner: 10Reedy) [23:30:33] Reedy: do you want to fix https://github.com/search?utf8=%E2%9C%93&q=%40wikimedia+makeLinkObj&type=Code&ref=searchresults ? ;) There are some older ones, trying to use makeKnownLinkObj on objects, that shouldn't work currently, too :) Or should we leave them as they are? [23:30:49] (03PS1) 10VolkerE: Use MediaWiki core mixins [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/262036 (https://phabricator.wikimedia.org/T122753) [23:30:54] sorry, I mean https://github.com/search?utf8=%E2%9C%93&q=%40wikimedia+makeKnownLinkObj&type=Code&ref=searchresults [23:32:29] 10Wikimedia-Extension-setup: Add Extension:Variables to en.wikiversity - https://phabricator.wikimedia.org/T113859#1912978 (10matmarex) Hello, sorry for late reply. As it was pointed out earlier, using the HTML tags `
    `/`
  1. ` is a good start. (Unfortunately, wikitext list syntax doesn't work for content spa... [23:32:37] (03PS1) 10Reedy: Replace makeLinkObj() [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262037 [23:34:03] There's a couple more fixed [23:34:37] (03CR) 10Florianschmidtwelzow: [C: 032] Replace makeLinkObj() [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262037 (owner: 10Reedy) [23:35:02] Semantic one too :P [23:35:09] (03Merged) 10jenkins-bot: Replace makeLinkObj() [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/262037 (owner: 10Reedy) [23:37:03] (03CR) 10Reedy: "There's a couple of comments in Parser about makeLinkObj we should probably clean up too..." [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy) [23:37:58] (03CR) 10VolkerE: [C: 032] "Exchanging properties with mixin notation, tested locally and on LSG server-side." [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/262036 (https://phabricator.wikimedia.org/T122753) (owner: 10VolkerE) [23:38:43] (03Merged) 10jenkins-bot: Use MediaWiki core mixins [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/262036 (https://phabricator.wikimedia.org/T122753) (owner: 10VolkerE) [23:39:15] 10MediaWiki-skins-Blueprint, 5Patch-For-Review: Blueprint should use MediaWiki core's Less mixins - https://phabricator.wikimedia.org/T122753#1912981 (10Volker_E) [23:39:17] 10MediaWiki-skins-Blueprint, 10Web-APIs-Hub: Deploy Blueprint on mediawiki.org as optional and experimental skin - https://phabricator.wikimedia.org/T93613#1912980 (10Volker_E) [23:40:12] (03PS2) 10Reedy: Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 [23:40:23] 10MediaWiki-skins-Blueprint, 10Web-APIs-Hub: Deploy Blueprint on mediawiki.org as optional and experimental skin - https://phabricator.wikimedia.org/T93613#1141991 (10Volker_E) [23:40:24] 10MediaWiki-skins-Blueprint: Blueprint should use MediaWiki core's Less mixins - https://phabricator.wikimedia.org/T122753#1912983 (10Volker_E) 5Open>3Resolved [23:40:32] (03CR) 10jenkins-bot: [V: 04-1] Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 (owner: 10Reedy) [23:41:56] (03PS2) 10Reedy: Linker::makeKnownLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262019 [23:42:07] (03PS3) 10Reedy: Linker::makeLinkObj() was removed [core] - 10https://gerrit.wikimedia.org/r/262021 [23:42:20] Let me fix up the makeKnown stuff now.. [23:46:49] (03PS1) 10Florianschmidtwelzow: Replace makeKnownLinkObj with Linker::link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/262038 [23:46:57] Reedy: ^ don't start with this one :P [23:47:04] DAMN IT [23:47:06] I already had [23:47:07] xD [23:47:09] sorry :P [23:47:13] I was only doing the first 2 [23:47:13] (03CR) 10jenkins-bot: [V: 04-1] Replace makeKnownLinkObj with Linker::link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/262038 (owner: 10Florianschmidtwelzow) [23:47:36] ok, then let me do the rest :) [23:47:50] I meant in that file [23:48:05] FlorianSW: ^ Fix that one up first :P [23:48:18] (03PS2) 10Florianschmidtwelzow: Replace makeKnownLinkObj with Linker::link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/262038 [23:48:35] Reedy: ah, ok, I misunderstood you :P [23:48:36] I'll do semanticpagemaker [23:49:17] I'll do DPLforum [23:51:51] (03CR) 10Reedy: [C: 032] Replace makeKnownLinkObj with Linker::link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/262038 (owner: 10Florianschmidtwelzow) [23:52:04] Should we remove those commented out ones? [23:52:27] (03Merged) 10jenkins-bot: Replace makeKnownLinkObj with Linker::link [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/262038 (owner: 10Florianschmidtwelzow) [23:52:33] /fix them [23:53:22] (03PS1) 10Reedy: Remove makeKnownLinkObj() commented out [extensions/News] - 10https://gerrit.wikimedia.org/r/262040 [23:54:15] (03PS1) 10Reedy: Remove makeKnownLinkObj() commented out [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/262041 [23:54:31] MassEditRegex next [23:54:34] (03PS1) 10Florianschmidtwelzow: Replace makeKnownLinkObj function calls with Linker::link [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262042 [23:54:44] Reedy: I would remove them, it's just confusing :) [23:54:50] Yeah, I have :D [23:54:56] DumpHTML next :) [23:54:58] great :P [23:55:03] (03CR) 10jenkins-bot: [V: 04-1] Replace makeKnownLinkObj function calls with Linker::link [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262042 (owner: 10Florianschmidtwelzow) [23:55:31] lol [23:55:55] (03PS1) 10Reedy: Replace makeKnownLinkObj() [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/262043 [23:56:03] Patroller [23:56:10] Is today armageddon of the deprecated functions? [23:56:21] Yup [23:56:25] JFDI [23:56:26] :D [23:56:34] Well, really old deprecated functions [23:56:34] Bye o/ [23:56:43] XD [23:57:30] Sometimes you just need to be disruptive :) [23:57:41] (03PS1) 10Reedy: Replace makeKnownLinkObj() [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/262044 [23:59:04] (03PS2) 10Reedy: Replace makeKnownLinkObj function calls with Linker::link [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/262042 (owner: 10Florianschmidtwelzow) [23:59:22] (03PS1) 10Florianschmidtwelzow: Replace makeKnownLinkObj calls with Linker::link [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/262045 [23:59:57] News