[00:00:03] (03PS1) 10Aaron Schulz: Use __METHOD__ for DB begin/commit calls [extensions/Survey] - 10https://gerrit.wikimedia.org/r/261750 [00:05:22] (03CR) 10Parent5446: Add loadWithArgv() to Maintenance class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [00:07:36] (03CR) 10Unicornisaurous: Add loadWithArgv() to Maintenance class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [00:08:06] (03PS1) 10Reedy: Update wfGetDB calls in Maintenance scripts to use getDB() [core] - 10https://gerrit.wikimedia.org/r/261751 [00:08:32] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/261728 (owner: 10Aaron Schulz) [00:08:48] parent5446: We really should refactor our arg handling at some point to be less DIY [00:08:54] It's very ugly and error-prone. [00:09:05] No kidding :) [00:10:05] Granted, I wrote it before getopt() worked on Windows :p [00:10:41] (03PS1) 10Aaron Schulz: Make maintenance scripts use beginTranscation/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 [00:10:52] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/261728 (owner: 10Aaron Schulz) [00:11:02] Windows messing things up is a common pattern in PHP (or rather, just a common pattern in general) [00:11:10] (03PS2) 10Reedy: Update wfGetDB calls in Maintenance scripts to use getDB() [core] - 10https://gerrit.wikimedia.org/r/261751 [00:11:22] (03PS15) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [00:12:04] parent5446: I wonder if we could have a more productive conversation about Windows support than we've had re: packaging and various types of hosting environments :p [00:12:20] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [00:12:53] Mhm, in reality, what we really need (and this is the problem with database support as well) is better testing for it [00:13:02] (03PS5) 10Unicornisaurous: Add loadWithArgv() to Maintenance class [core] - 10https://gerrit.wikimedia.org/r/261707 [00:13:16] Something to have Jenkins run on Windows before we release [00:13:20] (or something like that) [00:13:29] (03PS16) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [00:13:47] parent5446: I prefer https://secure.phabricator.com/book/phabricator/article/installation_guide/ 's approach [00:13:52] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [00:14:23] uhhhhhhhhh [00:14:25] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261735 (owner: 10Aaron Schulz) [00:14:36] Ah you just mean something like better documentation? [00:15:40] parent5446: No, focusing on just a few platforms that actually work and telling the others to go away :p [00:15:49] Ah [00:16:09] Yeah tbh I wouldn't mind that, although I just know it'll start a whole war over which platforms we should support [00:16:20] (That's pretty much exactly what's happening with the shared hosting argument) [00:18:14] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261735 (owner: 10Aaron Schulz) [00:18:22] (03CR) 10jenkins-bot: [V: 04-1] Update wfGetDB calls in Maintenance scripts to use getDB() [core] - 10https://gerrit.wikimedia.org/r/261751 (owner: 10Reedy) [00:21:24] (03PS17) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [00:21:45] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [00:21:54] (03PS1) 10Aaron Schulz: Fix numerious errors in RecompressTracked [core] - 10https://gerrit.wikimedia.org/r/261753 [00:22:01] Reedy: ^ [00:22:22] heh that code is not actually Maintenance ;) [00:26:02] oh, it's AaronSchulz [00:26:09] (03PS6) 10Reedy: Export: Added namespace aliases to siteinfo [core] - 10https://gerrit.wikimedia.org/r/261269 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [00:26:25] AaronSchulz: what do you think about the queries in https://gerrit.wikimedia.org/r/#/c/261314/2/includes/filerepo/file/LocalFile.php,cm ? [00:26:37] (03CR) 10Reedy: "Rebased after file name changes in core" [core] - 10https://gerrit.wikimedia.org/r/261269 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [00:26:59] 00:18:19 1) TimingTest::testMark [00:26:59] 00:18:19 Failed asserting that 1451520951.385 is greater than 1451520951.385. [00:27:16] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261751 (owner: 10Reedy) [00:27:24] 10CirrusSearch: Replace the prefixsearch used in the search box at the top right of pages with something better - https://phabricator.wikimedia.org/T116706#1910666 (10Savig) I think the completion suggester will be a nice tool to help users, but I don't see how that is similar to solving the problem I described... [00:27:45] (03PS6) 10Unicornisaurous: Add loadWithArgv() to Maintenance class [core] - 10https://gerrit.wikimedia.org/r/261707 [00:28:26] (03PS18) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [00:28:42] 10CirrusSearch, 6Discovery: URL internal links are hardly searchable - https://phabricator.wikimedia.org/T121379#1910683 (10Deskana) p:5Triage>3Lowest [00:28:55] (03CR) 10Reedy: [C: 032] Fix numerious errors in RecompressTracked [core] - 10https://gerrit.wikimedia.org/r/261753 (owner: 10Aaron Schulz) [00:29:09] (03PS19) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [00:29:54] (03CR) 10jenkins-bot: [V: 04-1] Export: Added namespace aliases to siteinfo [core] - 10https://gerrit.wikimedia.org/r/261269 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [00:30:06] 10CirrusSearch, 6Discovery, 5Patch-For-Review: Build out grafana dashboards for the elasticsearch clusters to monitor various aspects of cluster health - https://phabricator.wikimedia.org/T117284#1910692 (10Deskana) [00:30:11] (03CR) 10Unicornisaurous: "Something went wrong." [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [00:30:20] (03CR) 10Unicornisaurous: [C: 04-1] Add loadWithArgv() to Maintenance class [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [00:31:37] 10CirrusSearch, 6Discovery: Investigate usage of elasticsearch field data circuit-breaker to cut off expensive queries - https://phabricator.wikimedia.org/T119587#1910703 (10Deskana) p:5Triage>3Low [00:32:02] MaxSem: seems OKish. I suspect when doEditContent uses start/endAtomic it can maybe be simplified [00:32:13] no need to block on those patches though [00:33:29] 10CirrusSearch, 6Discovery: Bump master Cirrus version to 0.3 - https://phabricator.wikimedia.org/T965#1910714 (10Deskana) 5Open>3Invalid a:3Deskana I'm going to assume that this is so old as to basically be irrelevant now. Please feel free to reopen if this is incorrect. [00:33:40] 10CirrusSearch, 6Discovery: Search for term with " quotation marks does not show "Create the page on this wiki!" message for non-existing article - https://phabricator.wikimedia.org/T85836#1910718 (10Deskana) [00:33:49] Reedy: isn't this reasonable result? :D [00:34:22] 10CirrusSearch, 6Discovery: Wildcard (suffix) search does not match - https://phabricator.wikimedia.org/T90090#1910722 (10Deskana) p:5Triage>3Lowest [00:34:31] (03CR) 10TTO: [C: 04-1] "What went wrong?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [00:34:56] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [00:35:32] 10wb_vandalism: 284477427 results in TypeError: Failed to process - https://phabricator.wikimedia.org/T122679#1910727 (10Halfak) [00:35:33] 10wb_vandalism: WikiData model: Unsupported operand type(s) for /: 'NoneType' and 'float' - https://phabricator.wikimedia.org/T117802#1910728 (10Halfak) [00:35:37] 10MediaWiki-Search, 10CirrusSearch, 6Discovery, 10VisualEditor, and 2 others: [Regression] Redirects no longer indexed in search suggestions - https://phabricator.wikimedia.org/T88621#1910730 (10Deskana) 5Open>3Resolved a:3Deskana This appears to have been resolved a long time ago. [00:35:55] (03CR) 10Alex Monk: [C: 032] Fix numerious errors in RecompressTracked [core] - 10https://gerrit.wikimedia.org/r/261753 (owner: 10Aaron Schulz) [00:35:57] 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content access and APIs - https://phabricator.wikimedia.org/T119029#1910734 (10Tfinc) I agree with Gabriel that having https://phabricator.wikimedia.org/T113540 informal and for feedback would be best. The phab task has already been really... [00:35:58] (03Merged) 10jenkins-bot: Fix numerious errors in RecompressTracked [core] - 10https://gerrit.wikimedia.org/r/261753 (owner: 10Aaron Schulz) [00:36:02] 10MediaWiki-Search, 10CirrusSearch, 6Discovery: Searching "intitle" in all namespaces should return main namespaces result at the top - https://phabricator.wikimedia.org/T87150#1910735 (10Deskana) [00:36:06] FlorianSW: Can you please help me with this: https://gerrit.wikimedia.org/r/#/c/261307/4/ui/user/SpecialAuthorRegister.php ? [00:36:07] 10MediaWiki-Search, 10CirrusSearch, 6Discovery: Searching "intitle" in all namespaces should return main namespaces result at the top - https://phabricator.wikimedia.org/T87150#1910738 (10Deskana) p:5Triage>3Lowest [00:36:36] pranavk_: sure, that's why I'm here :) What do you want to know? :) [00:37:07] FlorianSW: thanks! so am I supposed to escape all $template->set() messages? [00:37:17] or only the errormsg ones? [00:37:40] 10CirrusSearch, 6Discovery: Bump master Cirrus version to 0.3 - https://phabricator.wikimedia.org/T965#1910748 (10demon) Eh, version numbers are dumb. Either they should bump regularly or not exist at all. 0.2-forever is a kinda lame version :p [00:37:46] Deskana|Away: lol ^ [00:37:51] 10CirrusSearch, 6Discovery: CirrusSearch generates PHP notices when server is down - https://phabricator.wikimedia.org/T105887#1910749 (10Deskana) p:5Triage>3Low [00:37:58] Objections if I actually change it to 0.2-forever? [00:37:59] :p [00:38:15] pranavk_: all, which aren't escaped in the template :) That's maybe a bit confusing, but QuickTemplate::set (QuickTemplate is the template class which most templates are based on) only sets the data to an array called data, so you can access this data from the template :) [00:38:15] (03CR) 10Mglaser: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/261727 (owner: 10Aaron Schulz) [00:39:18] FlorianSW: oook, so basically since QuickTemplate doesn't escape anything, we have to escape everything beforehand (over here) [00:39:22] And in the template, the developer can use different ways to output this data, mostly using QuickTemplate::html() which simply does echo $data['key']; or QuickTemplate::text(), which escapes the output [00:39:27] see, e.g.: https://doc.wikimedia.org/mediawiki-core/master/php/QuickTemplate_8php_source.html#l00093 [00:39:44] FlorianSW: yes, I'm looking at it right now [00:40:02] so how would we know if text() or html() is used? [00:40:02] pranavk_: not entirely correct :) You need to check, if the value passed to the template is escaped in the usage of the template :) The best friend here is a good search, e.g. I use github for this :P [00:40:12] pranavk_: look into the template :) [00:40:19] let me find a good example, one second [00:41:41] (03CR) 10Mglaser: [C: 032] Composer.json: Added more information [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/261623 (owner: 10Robert Vogel) [00:42:30] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/261727 (owner: 10Aaron Schulz) [00:42:46] (03CR) 10Mglaser: [C: 04-2] "This should be abandoned in favour of https://gerrit.wikimedia.org/r/#/c/261623/" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261624 (owner: 10Robert Vogel) [00:42:50] FlorianSW: after reading through the github ErrorTemplate class, i kind of get it now [00:43:13] Does SpecialAuthorRegister.php only use the ErrorTemplate? [00:43:29] see the usage here: https://github.com/wikimedia/mediawiki-extensions-ConventionExtension/blob/master/ui/user/SpecialAuthorRegister.php#L516 The $template var is an instance of ErrorTemplate (see the line above, where the template is created), so you need to find out, where this ErrorTemplate is defined. Here again: Github or any other search/grep is your friend :P In this case, it's a template inside the ConventionExtension [00:43:30] extension, defined here: https://github.com/wikimedia/mediawiki-extensions-ConventionExtension/blob/master/templates/ErrorTemplate.php Now you need to check every usage of errorMsg in this template (Ctrl + F is great here) and check, if it is escaped or not. In this case, it's not, so you need to escape it yourself when passing the value to the template (here with the message output type escaped) [00:43:43] Sorry for ^ I had to finish wrote it, even if you understood it :P [00:43:53] (03Merged) 10jenkins-bot: Composer.json: Added more information [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/261623 (owner: 10Robert Vogel) [00:44:23] pranavk_: Haven't checked, but you could check it yourself and look (if a message is passed to a template), what class is used to create a template :) [00:44:42] 10Phabricator-Upstream: Cannot move cards to workboards on mobile devices without drag and drop functionality - https://phabricator.wikimedia.org/T85370#1910771 (10Aklapper) >>! In T85370#1910652, @doctaxon wrote: > Bug reported: https://secure.phabricator.com/T10073 @doctaxon: Why? This task description links... [00:44:43] FlorianSW: i just checked, and it is ErrorTemplate [00:44:55] ok, great :) [00:45:05] Is the underlying problem clear now? :) [00:45:26] yes, it is [00:45:30] thanks for your help! [00:45:38] 6Discovery, 3Discovery-UX-Sprint, 5Patch-For-Review: Send geo country with EL on the portals page - https://phabricator.wikimedia.org/T121038#1910773 (10Deskana) p:5Triage>3Normal [00:45:45] 6Discovery, 3Discovery-UX-Sprint: [PAB2] Describe upcoming portal A/B test - https://phabricator.wikimedia.org/T121027#1910774 (10Deskana) p:5Triage>3Normal [00:46:26] pranavk_: great, have a great day/night/whatever :D I go to sleep now, if you have further questions, just leave it in gerrit :) [00:46:44] FlorianSW: got it! [00:46:58] FlorianSW: but if you don't mind, would you please review my work now? [00:47:24] oh noooo, a second too late [00:50:40] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261736 (owner: 10Aaron Schulz) [00:51:34] 10MediaWiki-extensions-ORES, 6RevisionScoringAsAService, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1910783 (10Ladsgroup) [00:51:47] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/261738 (owner: 10Aaron Schulz) [00:52:08] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/261739 (owner: 10Aaron Schulz) [00:52:50] I am trying to test the wm-bot in refference to page changes. Are there any test pages tracked by huggle-rc.wmflabs.org that I can edit? [00:53:44] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/OAI] - 10https://gerrit.wikimedia.org/r/261741 (owner: 10Aaron Schulz) [00:54:02] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261736 (owner: 10Aaron Schulz) [00:54:06] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/261738 (owner: 10Aaron Schulz) [00:54:09] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/261739 (owner: 10Aaron Schulz) [00:54:20] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/OAI] - 10https://gerrit.wikimedia.org/r/261741 (owner: 10Aaron Schulz) [00:57:24] (03CR) 10Alex Monk: [C: 032] Use __METHOD__ for DB begin/commit calls [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/261746 (owner: 10Aaron Schulz) [00:57:54] (03Merged) 10jenkins-bot: Use __METHOD__ for DB begin/commit calls [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/261746 (owner: 10Aaron Schulz) [00:58:02] 10Phabricator-Upstream: Cannot move cards to workboards on mobile devices without drag and drop functionality - https://phabricator.wikimedia.org/T85370#1910784 (10doctaxon) A better link: https://secure.phabricator.com/T6027 [01:01:37] (03PS1) 10Reedy: Fix corrupt © [core] - 10https://gerrit.wikimedia.org/r/261754 [01:01:39] mhutti1: ^^ seems you've got encoding problems :P [01:02:15] Reedy: What kind ? [01:02:29] What text editor are you using? [01:02:39] Reedy: notepad++ [01:02:40] Hmm [01:02:43] They look the same in gerri [01:02:44] t [01:02:53] But wrong in my IDE.. [01:03:12] Reedy: What looks wrong with them? [01:03:20] 10MediaWiki-extensions-MultimediaViewer, 7Easy, 3Google-Code-In-2015: $wgNetworkPerformanceSamplingFactor should be called $wgMediaViewerNetworkPerformanceSamplingFactor - https://phabricator.wikimedia.org/T91465#1910785 (10Aklapper) [01:03:21] � [01:03:25] ah [01:03:27] It's showing as a ? in a black box [01:03:37] Should be © [01:03:38] Thats weird [01:03:54] I can't remember what settings notepad++ uses [01:04:08] (03CR) 10Alex Monk: [C: 032] Fix some FileOpBatch IDEA errors [core] - 10https://gerrit.wikimedia.org/r/261332 (owner: 10Aaron Schulz) [01:04:27] 10Wikimedia-General-or-Unknown: Empty article displayed on nl.wp - https://phabricator.wikimedia.org/T116684#1910786 (10Aklapper) 5Open>3Resolved a:3Aklapper >>! In T116684#1875726, @Aklapper wrote: > I guess this was a duplicate of T101224 and null edits should fix this, hence I'm proposing to close this... [01:04:52] Notepad++ should show the encoding at the bottom right on the status bar [01:05:13] What should it be? [01:05:32] UTF-8 is what most everyone uses [01:05:39] Gerrit's handling of that is scary... [01:05:46] I don't see a difference in characters there, Reedy [01:05:58] Yeah, indeed [01:06:03] Which explains why I missed it in CR [01:06:13] Krenair: s/handling of that// [01:06:15] Yeah its showing Ansi in my editor [01:06:17] {{fixed}} [01:06:24] 10MediaWiki-extensions-ProofreadPage, 10pywikibot-core: Sometimes the anchor links generated by an Index: page's do not have the expected class attribute and value set - https://phabricator.wikimedia.org/T114318#1910789 (10GOIII) @Ankry I pretty much figured somebody "fixed it" given the amount of... [01:06:34] Ansi? *gasp* [01:06:50] No idea... [01:06:56] Never even herd of that one before [01:07:08] Notepad++ has an Encoding menu at the top [01:07:12] 6Community-Liaison: Increase engagement/efficiency of IRC office hours - https://phabricator.wikimedia.org/T121787#1910790 (10Aklapper) While "increasing engagement" could probably be measured by number of people writing lines, how would "efficiency" be measured? [01:07:32] "ANSI encoding is a slightly generic term used to refer to the standard code page on a system, usually Windows. It is more properly referred to as Windows-1252." [01:08:07] (03CR) 10Parent5446: [C: 032] Fix corrupt © [core] - 10https://gerrit.wikimedia.org/r/261754 (owner: 10Reedy) [01:08:15] Well im currently editing some C# I guess that should be ansi? [01:08:25] (03CR) 10Alex Monk: [C: 032] "Scary. Fetched and checked in git show." [core] - 10https://gerrit.wikimedia.org/r/261754 (owner: 10Reedy) [01:08:32] Nope [01:08:43] SOLUTION: just use (c) [01:08:46] Then everybody wins! [01:08:46] heh [01:08:58] ostriches: And we'll stop supporting non en [01:08:58] 10MediaWiki-extensions-SemanticForms, 7Easy: Remove deprecated html elements like from SF - https://phabricator.wikimedia.org/T121911#1910791 (10Aklapper) [01:09:12] that sounds good :) [01:09:24] Wait [01:09:26] We need en-gb [01:09:55] Yeah :) Stupid american english [01:10:26] British english is my favourite [01:10:42] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1910792 (10Aklapper) @Arnaud_Cheritat: Thanks for testing. I assume that makes this task invalid, as there is nothing that can be changed in the MediaWiki codebase itself? [01:11:15] (03Merged) 10jenkins-bot: Fix some FileOpBatch IDEA errors [core] - 10https://gerrit.wikimedia.org/r/261332 (owner: 10Aaron Schulz) [01:11:35] mhutti1: Mine too, even though I don't speak it. [01:11:43] I set my server locale to en_GB as Reedy can vouch for :p [01:12:01] He's secretely British [01:12:21] Trouble is the Zs creeping into british now so we don't know if its an s or a z [01:12:31] I'm going to the soo [01:12:48] we should convert to en-ca for default >.> [01:12:49] I dunno what you're zaying [01:13:52] (03CR) 10Alex Monk: [C: 032] Fix some FSFileBackend IDEA errors [core] - 10https://gerrit.wikimedia.org/r/261333 (owner: 10Aaron Schulz) [01:14:12] Eh, plane wifi going off in a minute and battery dying anyway. Later folks [01:14:14] * ostriches detaches [01:14:17] * Krenair waves [01:14:50] *wave [01:14:56] (03Merged) 10jenkins-bot: Fix corrupt © [core] - 10https://gerrit.wikimedia.org/r/261754 (owner: 10Reedy) [01:15:02] what part of your body are you detaching ostriches? [01:15:14] * mhutti1 wave [01:15:15] (03CR) 10Unicornisaurous: "Oh, it looks like it fixed itself. Gerrit was showing changes which weren't from my patch." [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [01:15:44] So should everything be in UTF-8 always ? [01:15:50] yes [01:16:00] No matter what ? [01:16:17] Well, if you were only using simple a-zA-Z0-9, it wouldn't matter [01:16:39] But when you're touching stuff that's not those, it's generally saner/easier/better to use utf-8 [01:17:46] Ok Another thing I need to edit in notepad++ what IDE do you use? [01:18:49] (03Merged) 10jenkins-bot: Fix some FSFileBackend IDEA errors [core] - 10https://gerrit.wikimedia.org/r/261333 (owner: 10Aaron Schulz) [01:18:54] (03PS7) 10Unicornisaurous: Add loadWithArgv() to Maintenance class [core] - 10https://gerrit.wikimedia.org/r/261707 [01:19:07] (03CR) 10Unicornisaurous: Add loadWithArgv() to Maintenance class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [01:19:41] (03PS20) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [01:23:00] (03PS21) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [01:24:04] 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1910796 (10RobLa-WMF) Hi @cscott, here's the main change I made to the description of this task yesterday: >=== Central problem === >How do we make manipulating ou... [01:30:54] (03CR) 10TTO: [C: 032] Add loadWithArgv() to Maintenance class [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [01:31:03] (03CR) 10Unicornisaurous: "I ended up renaming backupTextPass.inc to dumpTextPass.php and deleting the old dumpTextPass.php since dumpTextPass.php did basically noth" [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [01:33:05] 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1910801 (10RobLa-WMF) [01:33:57] 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1815747 (10RobLa-WMF) I added this to the central question: > **Alternative version (2015-12-30)**: What format should we use for the authoritative version of our... [01:34:19] (03PS5) 10PranavK: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) [01:36:40] (03Merged) 10jenkins-bot: Add loadWithArgv() to Maintenance class [core] - 10https://gerrit.wikimedia.org/r/261707 (owner: 10Unicornisaurous) [01:38:19] 6Discovery, 7Elasticsearch: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1910805 (10Zoglun) 3NEW [01:39:14] 6RevisionScoringAsAService: [Investigate] Wikidata revert model's precision and recall (filter rate) - https://phabricator.wikimedia.org/T122687#1910813 (10Halfak) 3NEW [01:39:38] 6RevisionScoringAsAService: [Investigate] Wikidata revert model's precision and recall (filter rate) - https://phabricator.wikimedia.org/T122687#1910821 (10Halfak) Started some work here. This is based off of a random sample of wikidata edits https://etherpad.wikimedia.org/p/revscoring_wikidata_reverted_set [01:41:11] (03PS6) 10PranavK: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) [01:42:47] 10MediaWiki-extensions-DismissableSiteNotice, 7Regression: DismissableSiteNotice's close link is shown even when JavaScript is disabled - https://phabricator.wikimedia.org/T94374#1910824 (10PleaseStand) 5Open>3Resolved a:3kaldari [01:43:33] 10MediaWiki-extensions-DismissableSiteNotice, 7Regression: DismissableSiteNotice's close link is shown even when JavaScript is disabled - https://phabricator.wikimedia.org/T94374#1161227 (10PleaseStand) Option #1 was implemented in 4479c9f309c0. [01:46:27] p858snake: one of my toes. 10 is overrated [01:52:45] 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1910829 (10RobLa-WMF) Note: @gwicke and I discussed this extensively in {E131}. See the comment at E131#1260 for the transcript of that part of our conversation.... [01:56:55] (03CR) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [01:57:10] (03CR) 10Unicornisaurous: [C: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [02:16:13] (03PS22) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [02:17:07] (03PS23) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [02:20:13] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [02:23:13] (03PS24) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [02:27:32] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [02:29:09] (03PS25) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [02:31:27] (03PS26) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [02:31:29] (03PS1) 10Unicornisaurous: Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 [02:32:24] (03PS27) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [02:34:30] (03PS2) 10Unicornisaurous: Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 [02:35:59] (03PS3) 10Unicornisaurous: Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 [02:36:13] (03PS4) 10Unicornisaurous: Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 [02:36:20] yay rebase [02:40:18] (03CR) 10jenkins-bot: [V: 04-1] Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 (owner: 10Unicornisaurous) [02:41:15] (03CR) 10Anomie: [C: 04-1] "Looks like a good start." (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) (owner: 10Sn1per) [02:45:52] (03CR) 10Sn1per: "Sorry about the confusion; I was basing this off of ApiMovepage and MovePage and at the time had not finished replacing everything :P" [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) (owner: 10Sn1per) [02:55:34] (03PS28) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [03:00:16] (03PS5) 10Unicornisaurous: Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 [03:00:31] (03PS6) 10Unicornisaurous: Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 [03:05:28] (03CR) 10jenkins-bot: [V: 04-1] Add 7zip-compression param [core] - 10https://gerrit.wikimedia.org/r/261755 (owner: 10Unicornisaurous) [03:11:17] 10CirrusSearch, 6Discovery, 7Elasticsearch: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1910840 (10Legoktm) [03:12:22] (03PS7) 10Unicornisaurous: Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) [03:12:31] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1910805 (10Legoktm) https://github.com/ruflin/Elastica/issues/1014 [03:19:09] 10MediaWiki-extensions-BlogPage, 10MediaWiki-extensions-BookManager, 10MediaWiki-extensions-CustomUserSignup, 10MediaWiki-extensions-EditUser, and 18 others: [Various] Deprecated: Use of wfMsg* was deprecated in MediaWiki 1.21 - https://phabricator.wikimedia.org/T70750#1910849 (10MtDu) Working on extension... [03:24:53] (03CR) 10TTO: "Sorry, my comments are spread over two patch sets." (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [03:25:03] (03CR) 10TTO: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses (035 comments) [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [03:29:56] (03PS1) 10PleaseStand: Remove code to hide the site notice from search engines [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/261758 (https://phabricator.wikimedia.org/T11209) [03:31:53] 10MediaWiki-extensions-CentralAuth: CentralAuth Autologin should emit an event after logging in the user, for other components to listen to - https://phabricator.wikimedia.org/T122655#1910861 (10Mattflaschen) [03:32:18] 10MediaWiki-extensions-CentralAuth: CentralAuth Autologin should emit an event after logging in the user, for other components to listen to - https://phabricator.wikimedia.org/T122655#1909952 (10Mattflaschen) mw.hook may be a good candidate for this, since it should only happen once per page load. [03:33:51] 10MediaWiki-Search, 10CirrusSearch, 6Discovery: Track down missing regex search results on commons - https://phabricator.wikimedia.org/T94830#1910866 (10Deskana) p:5Normal>3Lowest [03:34:41] 10CirrusSearch, 6Discovery: Search on Special:IndexPages with OR and incategory does not work - https://phabricator.wikimedia.org/T67231#1910871 (10Deskana) p:5Normal>3Lowest [03:40:15] 10CirrusSearch, 6Discovery, 7Epic: [EPIC] Create a Relevance Lab which helps us measure the effect on search result relevance of proposed changes to search - https://phabricator.wikimedia.org/T114673#1910880 (10Deskana) 5Open>3Resolved a:3Deskana This was done, and is available here: https://github.com... [03:40:44] 10MediaWiki-General-or-Unknown, 10MediaWiki-Maintenance-scripts, 10SyntaxHighlight: Let update.php check for composer updates in extensions - https://phabricator.wikimedia.org/T119711#1910884 (10Legoktm) Now that {T119766} is resolved, we should definitely be able to do this. [03:41:23] 10MediaWiki-extensions-MultimediaViewer: can't open the almost all pics in wiki. - https://phabricator.wikimedia.org/T122688#1910888 (10Ychmath) 3NEW [03:42:50] 10CirrusSearch, 6Discovery: Expose elasticsearch responses for debugging purposes - https://phabricator.wikimedia.org/T108358#1910896 (10Deskana) p:5Triage>3Low [03:43:32] Does anyone know if it is possible to download a full mediawiki article through python? [03:43:37] 6RevisionScoringAsAService: [Investigate] Wikidata revert model's precision and recall (filter rate) - https://phabricator.wikimedia.org/T122687#1910900 (10Halfak) OK. If we draw the cutoff at 0.93, we'll catch 100/10000 edits and that will account for (as far as we can tell) //all of the vandalism//! [03:43:43] specifically a wikipedia article [03:44:41] Well, if you just need to download one article in wikitext you can use the requests module + mediawiki API [03:44:51] 10CirrusSearch, 6Discovery: Warning: array_merge() expects parameter 1 to be array, null given - https://phabricator.wikimedia.org/T117877#1910908 (10Deskana) p:5Triage>3Low [03:45:07] parker: You've heard of http://docs.python-requests.org/en/latest/ ? [03:45:18] what I am trying to do is to get the entire article, images and all, including css, js, etc. [03:45:27] OH-: yeah I have [03:46:22] Oh, you mean like straight up download it? [03:46:42] basically yes. [03:47:17] 10CirrusSearch, 6Discovery: Type-ahead search on en.wp: Entering "pass by" only lists two entries while there are more - https://phabricator.wikimedia.org/T85514#1910913 (10Deskana) [03:47:39] right now it seems that my only option is to use wget through python, which will download the source code of the page, and then use beautifulsoup to parse it for things like css, js and media [03:47:42] (03PS5) 10Legoktm: dumpBackup.php: Remove --force-normal option [core] - 10https://gerrit.wikimedia.org/r/242093 (owner: 10PleaseStand) [03:48:02] (03CR) 10Legoktm: [C: 032] "PS5: Rebased release notes" [core] - 10https://gerrit.wikimedia.org/r/242093 (owner: 10PleaseStand) [03:48:10] download those with, and then somehow correct the links so they are correct in the article's source. [03:48:16] wget can download everything: http://stackoverflow.com/a/1581553/3246662 [03:48:18] which would be a really big pain in the ass [03:48:35] 10CirrusSearch, 6Discovery: insource:"A, B et C (Le Prisonnier)" should match interwiki links such as [[fr:A, B et C (Le Prisonnier)]] - https://phabricator.wikimedia.org/T74902#1910925 (10Deskana) p:5Normal>3Lowest [03:48:38] I'm not sure about if Python can do it, but I know wget is supposed to be able to [03:49:57] 6RevisionScoringAsAService: [Discussion] api.php integration with ORES - https://phabricator.wikimedia.org/T122689#1910930 (10Halfak) 3NEW [03:50:02] 10CirrusSearch, 6Discovery, 7Upstream: CirrusSearch does not find all JavaScript and CSS pages when using insource syntax - https://phabricator.wikimedia.org/T64733#1910940 (10Deskana) [03:50:03] parker: have you looked at https://www.mediawiki.org/wiki/API:Client_code#Python ? [03:50:21] hmmm. when I tried it on /wiki/New_York it download just the source. [03:50:35] legoktm: no I haven't one moment. [03:53:07] 10CirrusSearch, 6Discovery: Search snippet should exclude exclude same info as extracts - https://phabricator.wikimedia.org/T118775#1910945 (10Deskana) [03:53:09] 10CirrusSearch, 6Discovery: Search result snippets should skip parenthetical phrases - https://phabricator.wikimedia.org/T30088#1910946 (10Deskana) [03:53:18] 10CirrusSearch, 6Discovery: Search result snippets should skip parenthetical phrases (like textextracts does) - https://phabricator.wikimedia.org/T30088#1910948 (10Deskana) [03:53:24] 10CirrusSearch, 6Discovery: Search result snippets should skip parenthetical phrases (like textextracts does) - https://phabricator.wikimedia.org/T30088#338660 (10Deskana) p:5Normal>3Lowest [03:54:00] 10CirrusSearch, 6Discovery: incategory should work with wildcards - https://phabricator.wikimedia.org/T23276#1910957 (10Deskana) p:5Low>3Lowest [03:54:40] 10MediaWiki-File-management, 6Commons, 6Discovery, 6Multimedia, 7Elasticsearch: Store Pdf extracted text in a structured table instead of img_metadata - https://phabricator.wikimedia.org/T99263#1910962 (10Deskana) [03:55:45] (03Merged) 10jenkins-bot: dumpBackup.php: Remove --force-normal option [core] - 10https://gerrit.wikimedia.org/r/242093 (owner: 10PleaseStand) [03:56:29] 10MediaWiki-Search, 10CirrusSearch, 6Discovery, 7Elasticsearch: Consider auto-completing of "insource:" and other magic prefixes when using search inputs (perhaps similar to Gerrit) - https://phabricator.wikimedia.org/T103637#1910967 (10Deskana) p:5Triage>3Lowest [03:58:48] 10CirrusSearch, 6Discovery, 5Patch-For-Review: CirrusSearch: -"quoted phrase" doesn't remove the phrase from the search results - https://phabricator.wikimedia.org/T72301#1910975 (10Deskana) 5Open>3Resolved a:3Deskana A quick test indicates that this now works as intended. [04:05:42] 10MediaWiki-Installer, 7Easy, 5MW-1.27-release-notes, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): MediaWiki and CC 4.0 license - https://phabricator.wikimedia.org/T96077#1910983 (10Legoktm) 5Open>3Resolved a:3Legoktm [04:07:29] 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content access and APIs - https://phabricator.wikimedia.org/T119029#1910985 (10RobLa-WMF) The part of the discussion that @Halfak and @Anomie are having at T112956#1909946 seem like a broader meta point for discussion in this area. In a nu... [04:07:30] (03PS1) 10MtDu: Replace deprecated wfMsg* functions [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/261760 (https://phabricator.wikimedia.org/T70750) [04:11:02] (03PS1) 10MtDu: Replaced some deprecated wfMsg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [04:30:55] (03PS2) 10Glaisher: Rewrite Special:CheckUserLog search form with HTMLForm [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261639 [04:32:48] (03CR) 10Glaisher: Rewrite Special:CheckUserLog search form with HTMLForm (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261639 (owner: 10Glaisher) [04:44:48] (03CR) 10Glaisher: HTMLUserTextField: Enable suggestions for non-OOUI mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/249793 (https://phabricator.wikimedia.org/T117067) (owner: 10Florianschmidtwelzow) [04:59:36] 10MediaWiki-HTMLForm, 5Patch-For-Review: HTMLTitleTextField should support ajax autocompletion - https://phabricator.wikimedia.org/T117033#1910995 (10Glaisher) [04:59:36] 10MediaWiki-HTMLForm, 5Patch-For-Review: HTMLUserTextField should support suggestions in div/table/... mode, too - https://phabricator.wikimedia.org/T117067#1910994 (10Glaisher) [04:59:38] 10MediaWiki-General-or-Unknown, 5Patch-For-Review, 7Tracking: Implement autocompletion / search suggestion / auto-complete / autocomplete / auto-suggest throughout MediaWiki (tracking) - https://phabricator.wikimedia.org/T50240#1910993 (10Glaisher) [05:02:13] 10CirrusSearch, 6Discovery, 7Epic: EPIC: Test if a reverse field can help to display more and better suggestions - https://phabricator.wikimedia.org/T107427#1911009 (10Deskana) p:5Triage>3Normal [05:02:21] 10CirrusSearch, 6Discovery, 5Patch-For-Review: Add a "reverse" suggestion field to workaround the prefix length limitation (typos suggestion) - https://phabricator.wikimedia.org/T107006#1911010 (10Deskana) p:5Triage>3Normal [05:02:37] 10CirrusSearch, 6Discovery: Files uploaded to localwiki and then commons show up twice in search results - https://phabricator.wikimedia.org/T104257#1911012 (10Deskana) p:5Triage>3Lowest [05:03:03] 10CirrusSearch, 6Discovery: "Ignoring nonexistent page" that does exist - https://phabricator.wikimedia.org/T69869#1911016 (10Deskana) p:5Triage>3Low [05:03:32] 10CirrusSearch, 6Discovery: boolean intitle: 40 hits in old search, zero hits in new search: - https://phabricator.wikimedia.org/T69735#1911018 (10Deskana) p:5Triage>3Lowest [05:04:59] 10CirrusSearch, 6Discovery: ignore diacritics whenever appropriate (for some value of appropriate) - https://phabricator.wikimedia.org/T104814#1911026 (10Deskana) p:5Triage>3Low [05:05:11] (03PS1) 10Yurik: Bumped bugfix Vega 2.4.2 and d3 3.5.12 [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261762 [05:05:34] (03CR) 10Yurik: [C: 032] Bumped bugfix Vega 2.4.2 and d3 3.5.12 [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261762 (owner: 10Yurik) [05:06:36] (03Merged) 10jenkins-bot: Bumped bugfix Vega 2.4.2 and d3 3.5.12 [extensions/Graph] - 10https://gerrit.wikimedia.org/r/261762 (owner: 10Yurik) [05:09:45] 10CirrusSearch, 6Discovery: CirrusSearch throws a fatal on some (php) setups - https://phabricator.wikimedia.org/T98059#1911233 (10Deskana) [05:10:10] 10MediaWiki-Vagrant, 10CirrusSearch, 6Discovery, 5Patch-For-Review: Move browser test settings for CirrusSearch on MediaWiki-Vagrant from Jenkins.php to a separate CirrusSearch test wiki (using mediawiki::wiki). - https://phabricator.wikimedia.org/T87296#1911261 (10Deskana) [05:10:51] 10CirrusSearch, 6Discovery: Search results not updating on the English Wikipedia - https://phabricator.wikimedia.org/T93323#1911291 (10Deskana) [05:11:23] 10MediaWiki-JobQueue, 10CirrusSearch, 6Discovery: Handle large bursts of jobs more elegantly - https://phabricator.wikimedia.org/T62348#1911299 (10Deskana) [05:11:56] 10CirrusSearch, 6Discovery: Figure out why there are often so many mgwiktionary CirrusLinks jobs - https://phabricator.wikimedia.org/T93219#1911304 (10Deskana) [05:12:30] 10CirrusSearch, 6Discovery: Figure out why there are often so many mgwiktionary CirrusLinks jobs - https://phabricator.wikimedia.org/T93219#1911310 (10Deskana) p:5Triage>3Low [05:13:18] 6Discovery, 3Discovery-UX-Sprint, 5Patch-For-Review: Suggestions dropdown is freezing when typing too fast in Wikipedia Portal - https://phabricator.wikimedia.org/T116795#1911313 (10Deskana) p:5Triage>3Normal [05:13:26] 6Discovery, 3Discovery-UX-Sprint, 5Patch-For-Review: Suggestions dropdown is freezing when typing too fast in Wikipedia Portal - https://phabricator.wikimedia.org/T116795#1911316 (10Deskana) 5Open>3Resolved [05:15:07] 6Discovery, 3Discovery-Cirrus-Sprint, 7Epic: Run test with different library for detection language through the relevance lab, to decide how promising it is to invest further - https://phabricator.wikimedia.org/T118287#1911324 (10Deskana) 5Open>3Resolved [05:15:08] 6Discovery, 7Epic: EPIC: Improve Language Identification for use in Cirrus Search - https://phabricator.wikimedia.org/T118278#1911326 (10Deskana) [05:15:19] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: Investigate Updating Cybozu / ES Plugin for Language Identification - https://phabricator.wikimedia.org/T121540#1911327 (10Deskana) p:5Triage>3Normal [05:15:29] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: Investigate Updating Cybozu / ES Plugin for Language Identification - https://phabricator.wikimedia.org/T121540#1911330 (10Deskana) 5Open>3Resolved [05:15:30] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: Do an A/B Test on enwiki using TextCat for Language Identification - https://phabricator.wikimedia.org/T121542#1911331 (10Deskana) [05:15:32] 6Discovery, 7Epic: EPIC: Improve Language Identification for use in Cirrus Search - https://phabricator.wikimedia.org/T118278#1796238 (10Deskana) [05:21:02] (03CR) 10Phoenix303: "Thanks Mattflaschen for the update." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/191848 (https://phabricator.wikimedia.org/T88150) (owner: 10Phoenix303) [05:21:17] (03Abandoned) 10Phoenix303: Fixed suggestion box alignment on activation of fixed header [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/191848 (https://phabricator.wikimedia.org/T88150) (owner: 10Phoenix303) [05:21:43] (03Abandoned) 10Phoenix303: Fixed suggestion box alignment on activation of fixed header [core] - 10https://gerrit.wikimedia.org/r/191847 (https://phabricator.wikimedia.org/T88150) (owner: 10Phoenix303) [05:24:17] 10MediaWiki-extensions-VectorBeta, 5Patch-For-Review: Activation of Fixed header misaligns content translation search suggestion box - https://phabricator.wikimedia.org/T88150#1911346 (10Phoenix303) 5Open>3Invalid a:3Phoenix303 [05:40:09] (03PS29) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [05:40:30] (03CR) 10jenkins-bot: [V: 04-1] Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [05:41:20] 10Wikimedia-Developer-Summit-2016: How should Wikimedia software support non-Wikimedia deployments of its software? - https://phabricator.wikimedia.org/T113210#1911351 (10RobLa-WMF) >>! In T113210#1900470, @Nikerabbit wrote: > I read the logs of those two meetings and summary seems to be something like: > * Cont... [05:47:17] (03PS30) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [05:53:26] (03CR) 10Unicornisaurous: "Should something be done about the output the tests are generating? It's just getting thrown into the test output." [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [06:19:56] (03PS31) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [06:32:25] 10MediaWiki-HTMLForm, 10UI-Standardization: OOUI HTMLForms doesn't show errors for forms with multiple sections - https://phabricator.wikimedia.org/T122691#1911376 (10Glaisher) 3NEW [06:34:30] (03CR) 10Robert Vogel: "Why did you vote -2 here? BlueSpiceExtensions _and_ BlueSpiceFoundation are now on packagist.org" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/261624 (owner: 10Robert Vogel) [06:34:54] 10MediaWiki-extensions-Newsletter, 5Patch-For-Review: Add user rights for Newsletter extension - https://phabricator.wikimedia.org/T110327#1911386 (10Glaisher) >>! In T110327#1910039, @Glaisher wrote: > Yes. Special:ManageNewsletter doesn't work correctly with the permissions. I'll be fixing that along with la... [06:58:12] (03PS32) 10Unicornisaurous: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) [07:44:07] 10MediaWiki-ResourceLoader, 7Performance, 7Technical-Debt: User and site CSS loaded twice - https://phabricator.wikimedia.org/T108590#1911390 (10Nemo_bis) [07:45:53] 10MediaWiki-ResourceLoader, 7Performance, 7Technical-Debt: User and site CSS loaded twice - https://phabricator.wikimedia.org/T108590#1524271 (10Nemo_bis) [07:46:36] 10MediaWiki-ResourceLoader, 7Performance, 7Technical-Debt: User and site CSS loaded twice - https://phabricator.wikimedia.org/T108590#1911399 (10Nemo_bis) > The proper solution (which will be enforced by T92459 soon) is to not have a single module used as both addModules() and addModuleStyles(). Are you say... [07:55:54] hey everyone [08:05:17] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/260380 (owner: 10Robert Vogel) [08:09:19] I don't know but i just ran a git pull to get updates for Wikimedia Core and i get public key error [08:09:23] Any help/ [08:09:24] ? [08:09:29] All my configs are Ok [08:17:22] there is no wikimedia core, which repository do you mean? [08:20:06] 10Wikimedia-Site-Requests, 7Wikimedia-log-errors: Translate extension seemingly broken / partially installed on wikimedia2017wiki - https://phabricator.wikimedia.org/T122675#1911402 (10Nikerabbit) Translate uses ElasticSearch in production, so none of the tm* tables are necessary (nor possible, as you found ou... [08:21:00] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Thanks for the review!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/249793 (https://phabricator.wikimedia.org/T117067) (owner: 10Florianschmidtwelzow) [08:25:26] Nikerabbit: i mean mediawiki/core.git [08:25:30] I think i fix the problem [08:25:49] my .git directory was not writable for some reason [08:26:04] i just changed the permission of it and its working fine now :) [08:26:48] Nikerabbit: but the error was really funny, talking about Public key error does not have any link with this :) [08:34:58] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-cxserver, 7WorkType-Maintenance: Markup transfer for Template:Coord in ContentTranslation fails - https://phabricator.wikimedia.org/T113487#1911412 (10Amire80) p:5Triage>3Normal [08:35:17] 10MediaWiki-extensions-ContentTranslation, 7Easy, 7WorkType-Maintenance: X icon in ContentTranslation's MT card is not well aligned - https://phabricator.wikimedia.org/T122282#1911415 (10Amire80) p:5Triage>3Normal [08:35:38] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: The loading indicator bubbles look weird on Special:CXStats - https://phabricator.wikimedia.org/T122495#1905762 (10Amire80) [08:35:48] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Analytics, 3LE-CX7-Sprint break, 5Patch-For-Review, 7WorkType-Maintenance: CXStats shows 0 values for 2015-12-31 in cumulative graph and bar chart - https://phabricator.wikimedia.org/T122642#1909617 (10Amire80) [08:37:12] 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Provide TMX formatted parallel corpora - https://phabricator.wikimedia.org/T122042#1911422 (10Amire80) [08:37:22] 4(no projects): The proposed dialog for single edit tab is bad for new users - https://phabricator.wikimedia.org/T122692#1911424 (10Alsee) 3NEW [08:38:01] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint break, 5Patch-For-Review, 7WorkType-Maintenance: Fix cxserver on beta labs - https://phabricator.wikimedia.org/T122498#1911430 (10Amire80) [08:42:00] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1911432 (10Arnaud_Cheritat) Indeed it is very likely a bug in ImageMagick. I suppose that one could change the way ImageMagick is called but it would make no sense to adapt MW to... [08:42:56] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1911433 (10Arnaud_Cheritat) 5stalled>3Invalid [08:44:15] 10MediaWiki-extensions-DismissableSiteNotice, 7JavaScript, 5Patch-For-Review: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1911434 (10Nemo_bis) >>! In T108811#1910853, @gerritbot wrote: > Change 261758 had a related patch set uploaded (by PleaseStand): > Remove code t... [08:46:32] 6RevisionScoringAsAService: [Spike] Look into error correcting output codes in SciKit Learn - https://phabricator.wikimedia.org/T105517#1911435 (10ToAruShiroiNeko) clf = OutputCodeClassifier(LinearSVC(random_state=0), code_size=2, random_state=0) ECOC basically converts a single k class multi-class problem to (... [08:55:12] 6Phabricator, 5Patch-For-Review: Make all /r/project/* paths in phabricator accessible without login - https://phabricator.wikimedia.org/T122674#1911438 (10Nemo_bis) [09:01:22] 10Spelling-Dictionary, 3Google-Code-In-2015: Use ULS for language selection - https://phabricator.wikimedia.org/T87244#1911440 (10Ankitashukla) @Victorbarbu The dropdown currently is only a dummy implementation with a few languages. The purpose here is to replace the dropdown by the ULS by setting the position... [09:05:26] ankita_: no problem :) [09:09:00] ankita_, hello! [09:09:20] victorbarbu_: hello! :) [09:09:31] did you receive my email? [09:09:52] * victorbarbu_ isn't sure if he got your email address right [09:10:36] Yes and replied too! :D [09:18:47] guys, where can I find all the supported form fields along with their properties? [09:21:01] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Translation pages: display outdated translations as such, without removing them - https://phabricator.wikimedia.org/T60429#1911441 (10Nemo_bis) According to https://www.mediawiki.org/wiki/Special:MessageGroupStats/agg-Help_pages combined with a sample check... [09:26:38] victorbarbu_: https://www.mediawiki.org/wiki/Manual:Forms and https://www.mediawiki.org/wiki/HTMLForm [09:26:53] I've already checked that [09:27:00] But I can't even create a button :)) [09:27:32] I set the type to "button" and it asks me for "class" which, as the docs state, is a subclass or something, but I can't figure out possible vales [09:27:35] values* [09:30:21] ooh, found it [09:30:22] nevermind [09:30:34] Maybe you can check this out https://www.mediawiki.org/wiki/HTMLForm/tutorial3 [09:31:00] cool! :) [09:37:11] 6Language-Engineering, 6RevisionScoringAsAService: Investigate how Chinese writing variants are stored - https://phabricator.wikimedia.org/T119687#1911447 (10ToAruShiroiNeko) Chinese Wikipedia holds five variants: zh-cn, zh-sg, zh-hk, zh-tw, zh-mo. First two of these use Simplified Chinese and latter three use... [09:41:40] 6Language-Engineering, 6RevisionScoringAsAService: Investigate how Chinese writing variants are stored - https://phabricator.wikimedia.org/T119687#1911448 (10Liuxinyu970226) @ToAruShiroiNeko: We have a much easier way: use template {{[[ https://zh.wikipedia.org/wiki/Template:NoteTA/lua | noteTA ]]}}. [09:43:41] 6Language-Engineering, 6RevisionScoringAsAService: Investigate how Chinese writing variants are stored - https://phabricator.wikimedia.org/T119687#1911449 (10Liuxinyu970226) Pinging @Liangent and @Chiefwei for more information about that template. [09:44:53] what are OOUI forms? there's nothing about them in the docs I read [09:45:51] 6Language-Engineering, 6RevisionScoringAsAService: Investigate how Chinese writing variants are stored - https://phabricator.wikimedia.org/T119687#1911451 (10ToAruShiroiNeko) The idea here is to identify user input from each revision even if the template is not used but we would of course benefit of training o... [09:48:22] victorbarbu_: OOJS is another name for OOjs UI [09:48:29] That might help you to search more info? [09:49:23] yes, I hope. thank you! [09:55:50] 6Language-Engineering, 6RevisionScoringAsAService: Investigate how Chinese writing variants are stored - https://phabricator.wikimedia.org/T119687#1911453 (10zhaofengli) FYI, the hardcoded conversion table is [[ https://github.com/wikimedia/mediawiki/blob/master/includes/ZhConversion.php | includes/ZhConversio... [09:58:13] (03CR) 10Isarra: [C: 032] Fix [30-Dec-2015 19:45:19] PHP Notice: Undefined variable: wgMetrolookSearchBar in ..\skins\Metrolook\SkinMetrolookHooks.php on line 173 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/261643 (owner: 10Jack Phoenix) [09:59:19] (03Merged) 10jenkins-bot: Fix [30-Dec-2015 19:45:19] PHP Notice: Undefined variable: wgMetrolookSearchBar in ..\skins\Metrolook\SkinMetrolookHooks.php on line 173 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/261643 (owner: 10Jack Phoenix) [10:00:25] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 10ContentTranslation-Analytics, 10Ops-Access-Requests, and 2 others: access for amire80 to stat1002.eqiad.wmnet - https://phabricator.wikimedia.org/T122524#1911454 (10Arrbee) Hello, the request is approved from my side. Thanks. [10:17:18] 10Wikimedia-Site-Requests: Change title or sitename and logo for gu.wiktionary - https://phabricator.wikimedia.org/T122407#1911455 (10BhatakatiAatma) p:5Normal>3Triage [10:18:21] 6Language-Engineering, 6RevisionScoringAsAService: Investigate how Chinese writing variants are stored - https://phabricator.wikimedia.org/T119687#1911458 (10He7d3r) ...and there is also these local tables: https://zh.wikipedia.org/wiki/Special:PrefixIndex/MediaWiki:Conversiontable/zh [10:19:05] (03PS33) 10TTO: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [10:22:23] 10MediaWiki-extensions-SemanticForms, 7Easy: Remove deprecated html elements like from SF - https://phabricator.wikimedia.org/T121911#1911459 (10D3r1ck01) a:3D3r1ck01 [10:28:57] 10Wikimedia-Site-Requests: Request to Change title or sitename and logo for localisation and update namespaces on gujarati wikiquote (gu.wikiquote) - https://phabricator.wikimedia.org/T121853#1911461 (10BhatakatiAatma) p:5Normal>3Triage [10:29:13] 10CirrusSearch: Replace the prefixsearch used in the search box at the top right of pages with something better - https://phabricator.wikimedia.org/T116706#1911465 (10Savig) Please note that I opened this ticket to report NOT a problem with the prefixsearch, but a problem with Wikimedia's regular search results.... [10:32:30] 10CirrusSearch: Bad search results when you don't include the preposition in your search query - https://phabricator.wikimedia.org/T116706#1911466 (10TTO) 5Invalid>3Open [10:32:43] 10CirrusSearch: Bad search results when you don't include the preposition in your search query - https://phabricator.wikimedia.org/T116706#1756029 (10TTO) Reopening this. I think Dan misunderstood the reporter's comment. [11:00:58] 10MediaWiki-extensions-Interwiki, 10Wikidata: Local interwiki link bloks the "link with page" dialog - https://phabricator.wikimedia.org/T122693#1911474 (10SJu) 3NEW [11:07:20] (03CR) 10PranavK: [C: 04-1] "Just some thoughts :)" (032 comments) [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [11:13:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I think you missed one (see my 2nd comment), otherwise looks good!" (032 comments) [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [11:20:51] apergos: I'm going to merge https://gerrit.wikimedia.org/r/#/c/261311 very soon, as it is a time-sensitive GCI task. Ideally I'd get you to review, but there isn't time, I think [11:20:53] (03CR) 10Florianschmidtwelzow: Rewrite Special:CheckUserLog search form with HTMLForm (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261639 (owner: 10Glaisher) [11:33:04] (03PS7) 10PranavK: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) [11:36:38] (03CR) 10Florianschmidtwelzow: [C: 031] "So I assume you want to keep the call to call_user_func_array()? :)" [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [11:37:07] (03CR) 10PranavK: Replace deprecated wfMsg* functions (031 comment) [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [11:37:29] (03CR) 10PranavK: "Yeah, I do! :)" [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [11:40:33] (03CR) 10Florianschmidtwelzow: [C: 032] "Boom! :D" [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/261760 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [11:43:38] (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/261760 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [11:47:39] (03CR) 10PranavK: "Did you read my comment? (I'm not sure if it has been published o not)." [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [11:50:04] 6RevisionScoringAsAService: [Investigate] Wikidata revert model's precision and recall (filter rate) - https://phabricator.wikimedia.org/T122687#1911486 (10Ladsgroup) \o/ [11:52:31] 6MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit-2016, 3DevRel-December-2015: Meeting with MW Stakeholders and WMF - https://phabricator.wikimedia.org/T119403#1911487 (10Aklapper) @MarkAHershberger: I didn't follow this task closely but as "unconference slot" seems to be the preferred option (inst... [11:53:05] is wikimedia using code sniffer for js? [11:55:44] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Some comments :) Thanks for the change! If you still have questions about when you can use $this->msg() and when not, feel free to ping me" (036 comments) [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [11:58:28] (03CR) 10Florianschmidtwelzow: [C: 032] "Yep, was published :)" (031 comment) [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [11:59:00] (03Merged) 10jenkins-bot: Replace deprecated wfMsg* functions [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/261307 (https://phabricator.wikimedia.org/T70750) (owner: 10PranavK) [12:00:07] (03CR) 10Florianschmidtwelzow: [C: 031] "I tested PS1 and I'm pretty sure, that PS2 should work, too, but this would need one more test before being merged :)" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261639 (owner: 10Glaisher) [12:03:07] (03PS4) 10Florianschmidtwelzow: Maintenance: convertExtensionToRegistration: Detect if composer autoloader is needed [core] - 10https://gerrit.wikimedia.org/r/261633 (https://phabricator.wikimedia.org/T119766) [12:03:55] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 10ContentTranslation-Analytics, 10Ops-Access-Requests, and 2 others: access for amire80 to stat1002.eqiad.wmnet - https://phabricator.wikimedia.org/T122524#1911500 (10jcrespo) The access is now in review, a minimum of 3 days is required for security r... [12:22:23] (03PS1) 10Glaisher: Move special page navigation links to the subtitle [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261765 [12:24:22] (03CR) 10Glaisher: "Right, it's better to be careful. :)" (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261639 (owner: 10Glaisher) [12:27:41] is anyone around here? [12:29:49] (03PS2) 10Glaisher: Move special page navigation links to the subtitle [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261765 [12:30:06] victorbarbu_: Many are here. :) [12:31:26] (03PS3) 10Glaisher: Move special page navigation links to the subtitle [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261765 [12:32:07] victorbarbu_: Oh. I just saw your question from earlier. No, we use JSHint. [12:42:04] 10MediaWiki-Database, 10DBA: Wrong Statistic of Sanskrit Wikipedia Articles - https://phabricator.wikimedia.org/T122695#1911503 (10NehalDaveND) 3NEW a:3TTO [12:43:26] 10MediaWiki-API: Api: Allow creation of new section without header but with summary - https://phabricator.wikimedia.org/T54747#1911511 (10Perhelion) Maybe this is owing to the //hack of the German// Common.js, which does (enforces an section edit to all new red-link edits): ``` /** * Fügt eine Betreffzeile auf... [12:43:32] 10Wikimedia-Site-Requests: Wrong Statistic of Sanskrit Wikipedia Articles - https://phabricator.wikimedia.org/T122695#1911512 (10Reedy) a:5TTO>3None [12:44:54] Reedy: Aw, why would you deprive me of some fun?... [12:44:58] ;) [12:45:06] Can you fix it? :O [12:45:09] *:P [12:45:19] No [12:45:26] He assigns everything to me for some reason [12:45:29] lol [12:45:36] Though, you probably could [12:45:44] I don't have shell access [12:45:49] Don't need it [12:45:49] it needs the s [12:45:54] 9/10 those type of bugs are a misunderstanding of how the counting is done [12:46:01] Links, size etc [12:46:14] Oh right, yeah it's probably that [12:46:52] I guess http://stats.wikimedia.org/EN/TablesWikipediaSA.htm is using raw literal counts of all pages in namespace 0 [12:48:13] 10Wikimedia-Site-Requests: Wrong Statistic of Sanskrit Wikipedia Articles - https://phabricator.wikimedia.org/T122695#1911517 (10Reedy) ``` reedy@tin:~$ mwscript initSiteStats.php sawiki --update Refresh Site Statistics Counting total edits...354334 Counting number of articles...10040 Counting total pages...351... [12:48:16] Heh, script says 10040 [12:48:46] 4(no projects): The proposed dialog for single edit tab is bad for new users - https://phabricator.wikimedia.org/T122692#1911518 (10Aklapper) Hi @Alsee, thanks for taking the time to report this! Where to see "the current demo for single edit tab"? What are steps to reproduce this problem? Which project is thi... [12:50:12] tto: no it does not [12:50:34] 10Wikimedia-Site-Requests: Wrong Statistic of Sanskrit Wikipedia Articles - https://phabricator.wikimedia.org/T122695#1911521 (10Reedy) Please see https://www.mediawiki.org/wiki/Manual:$wgArticleCountMethod sawiki is set to 'link' > 'link': the page must contain a wiki link to be considered valid Do all the p... [12:51:30] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1911522 (10Aklapper) >>! In T121984#1911432, @Arnaud_Cheritat wrote: > @Aklapper: my tentative to update MW from 1.22 to 1.26 failed : Trying to do the update it on the web interf... [12:51:36] Nemo_bis: Well, I don't know if we can believe https://www.mediawiki.org/wiki/Analytics/Metric_definitions, if that's what you're referring to [12:51:45] What else would explain the discrepancy? An outdated dump, I suppose [12:51:50] hello, Nemo_bis [12:51:53] Or something else that I don't know about [12:52:16] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911523 (10Aklapper) [12:52:44] tto: I already found the reason [12:53:44] Nemo_bis: Do tell? [12:56:32] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911527 (10Reedy) > Bool is deprecated now, you can use B... [12:57:55] I was typing [12:59:22] 10MediaWiki-extensions-MultimediaViewer: can't open the almost all pics in wiki. - https://phabricator.wikimedia.org/T122688#1911532 (10Aklapper) [12:59:27] 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 6Commons, 6Multimedia: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#1911533 (10Aklapper) [12:59:31] 10MediaWiki-extensions-MultimediaViewer: can't open the almost all pics in wiki. - https://phabricator.wikimedia.org/T122688#1910888 (10Aklapper) Hi @Ychmath, thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system as T115563, but please feel free... [13:00:01] tto: So, yeah. I was right, as usual [13:00:04] ;) [13:01:40] Reedy: haha :) [13:01:56] I mean, you should know, you were the doyen of shell requests for a while [13:05:06] 10MediaWiki-extensions-Translate, 7Easy: Replace Elastica\Query\Bool usage in ttmserver - https://phabricator.wikimedia.org/T122696#1911538 (10Reedy) 3NEW [13:05:18] 10Wikimedia-Developer-Summit-2016: How should Wikimedia software support non-Wikimedia deployments of its software? - https://phabricator.wikimedia.org/T113210#1911545 (10MarkAHershberger) >>! In T113210#1911351, @RobLa-WMF wrote: > If we could get step 1 of 3 above completed in this session, that would be big p... [13:05:23] 10MediaWiki-extensions-Translate, 7Easy: Replace Elastica\Query\Bool usage in ttmserver - https://phabricator.wikimedia.org/T122696#1911547 (10Reedy) [13:05:25] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911546 (10Reedy) [13:08:36] guys? where can I find a list of available icons? [13:08:44] for OOjs-UI [13:08:45] ? [13:11:22] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911552 (10Reedy) Seems Translate was the only usage of Q... [13:11:37] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911553 (10Reedy) p:5Normal>3Low [13:13:58] victorbarbu_, there's https://www.mediawiki.org/wiki/OOjs_UI/Widgets/Icons,_Indicators,_and_Labels, and there is a complete listing in the JSON files in MediaWiki core resources/lib/oojs-ui/themes/mediawiki [13:14:30] 6RevisionScoringAsAService: [Investigate] Wikidata revert model's precision and recall (filter rate) - https://phabricator.wikimedia.org/T122687#1911554 (10Ladsgroup) I made some analysis and posted it in https://www.wikidata.org/wiki/Wikidata_talk:ORES/Report_mistakes. [13:25:08] (03CR) 10Edokter: [C: 04-1] "Unless it actually breaks rendering, even if you cannot reproduce expected behaviour in certain conditions, you should still include the v" [core] - 10https://gerrit.wikimedia.org/r/261723 (https://phabricator.wikimedia.org/T104541) (owner: 10Bartosz Dziewoński) [13:38:48] (03PS8) 10TTO: Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) (owner: 10Unicornisaurous) [13:44:53] (03CR) 10TTO: [C: 032] "Let's do this!" [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [13:48:56] (03CR) 10Reedy: [C: 04-1] "Hmm. Not sure if we can do this yet..." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/260160 (owner: 10Reedy) [13:49:11] (03CR) 10Reedy: "Hmm. Not sure if we can do this yet..." [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [13:49:22] the two comments above are funny [13:50:33] (03Merged) 10jenkins-bot: Refactor dumpBackup.php and dumpTextPass.php to be Maintenance subclasses [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [13:51:24] Reedy: according to https://github.com/ruflin/Elastica/tree/2.3.1 yes that can be a problem [13:51:39] The comment is vague [13:51:43] As to whether it now supports [13:51:49] Or it only supports that version as a min [13:51:56] (03CR) 10TTO: [C: 04-1] Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) (owner: 10Unicornisaurous) [13:52:08] (03PS1) 10Reedy: Update ruflin/elastica v2.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/261768 [13:52:12] Reedy: the page clearly says minimum version imho [13:52:26] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica v2.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/261768 (owner: 10Reedy) [13:52:28] Reedy: what is WMF running now? I am running 1.7.3 [13:52:35] 1.7.1 [13:52:56] so we are stuck with https://github.com/ruflin/Elastica/tree/2.2.0 it seems [13:53:12] sorry, https://github.com/ruflin/Elastica/tree/2.2.1 [13:53:35] Reedy: quite a dependency hell I would say ;) [13:53:49] Mmm [13:53:49] (03PS1) 10Reedy: Update ruflin/elastica v2.2.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261769 [13:54:07] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica v2.2.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261769 (owner: 10Reedy) [13:54:20] Updating the vendor repos is a PITA [13:54:39] I guess we need to poke the WMF at updating ES soon ;) [13:54:59] Nikerabbit: 1.7.4 is out!! [13:55:04] Reedy: let alone keeping third party users in sync... [13:55:08] Reedy: since when? [13:55:15] 16 days ago [13:55:23] https://github.com/elastic/elasticsearch/releases/tag/v1.7.4 [13:55:30] 11375 commits to master since this tag [13:55:31] lol [13:55:39] I presume they mean the 1.7 branch [13:56:30] Reedy: oh you are correct, I am running 1.7.4 [13:56:37] :) [13:57:11] 6Discovery, 7Elasticsearch: Upgrade ElasticSearch to 1.7.4 - https://phabricator.wikimedia.org/T122697#1911562 (10Reedy) 3NEW [13:58:05] 6MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit-2016, 3DevRel-December-2015: Meeting with MW Stakeholders and WMF - https://phabricator.wikimedia.org/T119403#1911570 (10MarkAHershberger) @aklapper, thanks for the help. I appreciate all the pointers and patience as we try to make this happen. Sen... [13:58:10] 6Discovery, 7Elasticsearch: Upgrade ElasticSearch to version 2 - https://phabricator.wikimedia.org/T122698#1911571 (10Reedy) 3NEW [13:58:20] 6Discovery, 7Elasticsearch: Upgrade ElasticSearch to 1.7.4 - https://phabricator.wikimedia.org/T122697#1911580 (10Reedy) [13:58:21] 6Discovery, 7Elasticsearch: Upgrade ElasticSearch to version 2 - https://phabricator.wikimedia.org/T122698#1911579 (10Reedy) [13:58:36] (03PS2) 10Reedy: Update nmred/kafka-php to v0.1.5 [vendor] - 10https://gerrit.wikimedia.org/r/260156 [13:58:45] (03PS4) 10Reedy: Update symfony/process to v2.6.11 [vendor] - 10https://gerrit.wikimedia.org/r/260157 [13:59:03] (03PS4) 10Reedy: Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 [13:59:09] (03CR) 10Reedy: [C: 04-1] Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [13:59:12] (03PS2) 10Reedy: Update ruflin/elastica v2.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/261768 [14:00:08] 10MediaWiki-Export-or-Import, 3Google-Code-In-2015, 5Patch-For-Review: dumpBackup.php: offer option to use 7za -mx=4 instead of -mx=5 - https://phabricator.wikimedia.org/T78669#1911582 (10Nemo_bis) > Unicornisaurous added a blocking task: T122587: Make dumpBackup.php subclass Maintenance. OMG look what I tr... [14:01:34] 10MediaWiki-extensions-Translate, 7Easy, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Replace Elastica\Query\Bool usage in ttmserver - https://phabricator.wikimedia.org/T122696#1911586 (10Nikerabbit) a:3Reedy [14:01:45] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911589 (10Nikerabbit) [14:01:46] 10MediaWiki-extensions-Translate, 7Easy, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Replace Elastica\Query\Bool usage in ttmserver - https://phabricator.wikimedia.org/T122696#1911588 (10Nikerabbit) 5Open>3Resolved [14:01:47] 6Discovery, 7Elasticsearch: Upgrade ElasticSearch to 1.7.4 - https://phabricator.wikimedia.org/T122697#1911590 (10Reedy) [14:07:14] FlorianSW: Thanks for the comments. Working on it now. It makes a lot more sense. :) [14:07:22] Nemo_bis:^ [14:07:33] MtDu: great :] [14:08:36] Wm-bot isnt hosted on gerrit is it? [14:10:26] No it's another (virtual) server [14:11:42] (03CR) 10Reedy: [C: 04-2] "Blocked by T122697" [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [14:11:46] FlorianSW: So line 141 in LiveTranslate_Functions.php should look something like this? https://dpaste.de/A3MZ [14:11:47] (03CR) 10Reedy: [C: 04-2] "Blocked by T122697" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/260160 (owner: 10Reedy) [14:12:00] (03CR) 10Reedy: "recheck" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/261769 (owner: 10Reedy) [14:12:06] FlorianSW: Sorry, LiveTranslate.hooks.php [14:12:41] $article->getContext()->msg()( 'livetranslate-dictionary-goto-edit' )->text() -> will throw an error :) [14:12:50] you should use $article->getContext()->msg( 'livetranslate-dictionary-goto-edit' )->text() [14:12:52] :) [14:14:03] FlorianSW: Saw that just before I checked the chat. :) [14:17:20] :D [14:17:37] tto: unless it's already deployed, that's fine [14:18:24] great to see that done [14:20:36] tto: why the -1 on the 7z compression arg? I don't see any comments on the review [14:21:04] FlorianSW: I'm working on replacing wgout and others now. :) So to make sure I'm soing this right, an example would be changing this https://dpaste.de/rRTd to https://dpaste.de/4Jvm? [14:21:07] apergos, there are meant to be 2 comments, I don't know where they went. [14:21:11] Wrong patch set probably [14:21:25] looking [14:21:52] (03CR) 10TTO: Add 7zip compression level param to BackupDumper (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) (owner: 10Unicornisaurous) [14:21:55] apergos: ^ [14:22:38] gotcha [14:22:44] cool thanks, tto! [14:22:52] no problems! Thanks for taking a look [14:23:05] sorry couldn't respond earlier, I was out [14:25:51] FlorianSW:^ [14:27:55] MtDu: yes, you can save the return value of getRequest/getUser/getOutput in a local variable, if you use it more then once :) [14:32:01] (03PS2) 10Reedy: Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 [14:32:21] (03CR) 10Reedy: [C: 04-1] "Needs rebase" [vendor] - 10https://gerrit.wikimedia.org/r/260165 (owner: 10Reedy) [14:32:31] (03CR) 10Reedy: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [14:32:40] (03CR) 10jenkins-bot: [V: 04-1] Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 (owner: 10Reedy) [14:34:28] 3Mobile-App-Android-Sprint-72-Hafnium, 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Add route to provide Wiktionary definition of requested word or phrase. - https://phabricator.wikimedia.org/T119235#1911596 (10Nemo_bis) > The language code is part of th... [14:36:06] (03PS2) 10Reedy: Update nmred/kafka-php to v0.1.5 [core] - 10https://gerrit.wikimedia.org/r/260170 [14:38:59] FlorianSW: Is there a replacement for $wgLanguageCode? I couldn't seem to find one on the web. [14:40:05] MtDu: wgLanguageCode? This is a config variable, for this you can use the Config object: IContextSource::getConfig()->get( 'LanguageCode' ); [14:40:29] FlorianSW: Would you want me to do that or just leave it as is? [14:41:11] I would say you can do that, too? :P [14:42:04] MtDu: Can you link me to the file, where wgLanguageCode is used? [14:42:27] guys, how can I render a submit button in an ooui-js form? [14:42:53] do I have to add 'method' and 'action' to the form itself? [14:43:05] because I have the button, but it still does not look like a submit button [14:43:09] FlorianSW: This one uses wgLanguageCode, https://dpaste.de/jQps, and this one uses wgLang. [14:43:34] victorbarbu_: with OOJs UI PHP or JS? [14:43:39] js [14:44:01] it's very intuitive in php [14:44:02] but js... [14:44:06] victorbarbu_: https://doc.wikimedia.org/oojs-ui/master/js/ :P [14:44:15] (03PS2) 10Reedy: Update zordius/lightncandy to v0.23 [vendor] - 10https://gerrit.wikimedia.org/r/260165 [14:45:04] FlorianSW: Also, tell me if you want me to replace anything else. :) [14:45:11] (03CR) 10TTO: "[-1]" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/261269 (https://phabricator.wikimedia.org/T64109) (owner: 10Georggi199) [14:46:12] MtDu: I think you can leave all usages of wgLanguageCode like they are currently. You can't easily access a context object there. [14:46:32] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260166 (owner: 10Reedy) [14:46:41] Btw.: https://dpaste.de/jQps#L10,148 this won't work, you can't access $this in a static context :) [14:47:23] (03PS1) 10Reedy: PSR-0 -> PSR-4 [vendor] - 10https://gerrit.wikimedia.org/r/261770 [14:48:59] FlorianSW: Right. So in this case, https://dpaste.de/Tk9t, I would instead do $currentLang->getRequest() instead? [14:49:15] FlorianSW: I'm not sure about this. [14:49:29] 10Spelling-Dictionary: Move Spelling-Dictionary extension to Git/Gerrit - https://phabricator.wikimedia.org/T92436#1911607 (10Ankitashukla) Have submitted a request for a Gerrit repo. [14:49:29] FlorianSW, thank you, but it's not more than I wrote. I mean, it seems lik tere can't be done anything special [14:50:16] MtDu: what is the value $currentlang? That's the important thing, for me it seems to be string, not any object where you can get anything from :/ [14:50:39] victorbarbu_: sorry, maybe I miss something, but what special do you want to do? [14:51:14] FlorianSW: So I use the class name instead? LiveTranslateFunctions? [14:52:13] FlorianSW, please take a look here http://imgur.com/a/oBpK4 [14:54:50] ? No :) I think I should explain it a bit more :) What you really do with something like $foo->bar() is, that you call the function bar on the instance of an object, which is saved in $bar. That only works, if: a) the function you want to call is defined in the class itself, or in any class of the inheritance hierarchy (e.g. msg() isn't a function of OutputPage, but it is defined in ContextSource, where the OutputPage is [14:54:50] inherited from) and b) $bar needs to hold an instance of an object. So for using getRequest() you need an object of a class, which implements the function getRequest :) [14:54:57] MtDu: ^ :) [14:55:36] victorbarbu_: what JS class do you use to create the button? [14:55:50] ButtonInputWidget [14:56:00] In general you can pass so called "flags" to it, which means, that you can pass "primary" and "constructive" to achieve what you want :) [14:56:15] ooh, that's what I was missing [14:56:28] you got a beer! [14:56:48] great :) Thanks :P [14:57:33] FlorianSW: So, in this case, what would the object be? [14:59:08] FlorianSW: So this it e whole file. https://dpaste.de/bKpM The function is under the class LiveTranslateFunctions. [14:59:46] supported flags are: constructive, destructive, progressire [14:59:49] progressive* [14:59:52] nothing about primary et [14:59:54] etc* [15:00:27] I quit that for a moment. do you have any idea if I can hook the submit event? [15:01:13] victorbarbu_: where do you read this? I'm pretty sure, that primary is supported :) [15:01:25] MtDu: which function (sorry if I missed that :()? :) [15:01:50] FlorianSW: https://dpaste.de/bKpM#L180 [15:02:08] FlorianSW: For static functions, should I just leave wgout and wguser and wgrequest there? [15:02:28] MtDu: for the time being, I would say, that you just leave them as they are. [15:02:38] FlorianSW: Ex. IN this case. https://gerrit.wikimedia.org/r/#/c/261761/1/includes/LiveTranslate_Functions.php It would mess up the $this->msg [15:02:46] Additionally, I think this will not work, too: https://dpaste.de/bKpM#L22,180 [15:03:19] oh, no , not "supported flags", "flags include" [15:03:20] sorry [15:03:24] FlorianSW: Yep. I'll just leave everything the way it was in the static functions. :) [15:04:08] MtDu: I think the easiest thing for the start would be any function, where you can cleary access a context object :) Like in special pages, or where you get an outputpage object or something else. [15:04:19] (e.g. some hooks provide objects) [15:04:37] FlorianSW, now I have to find out how to hook the submit event [15:04:53] for the other ones: There are ways, too, but that's mostly more complicated and would require a rewrite of the function call itself. But I think that's too much for now :) [15:05:40] victorbarbu_: submit or click event? A button does not have a submit event, so you can not hook into it :) [15:05:57] the form has the submit [15:06:14] how do you create the form? [15:06:15] nit the click of a submit button is equivalent to the form's submit [15:06:23] with OO.ui.FormLayout [15:07:48] a FormLayout emit's a submit event, when it is submitted, so it should work, if you add an event listener for the submit event to the form: formLayout.on( 'submit', function() {} ); [15:08:06] okay [15:08:07] another way is to use connect [15:08:07] thank you [15:08:16] https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.EventEmitter-method-connect [15:08:22] checking it out now [15:08:25] thank you [15:08:44] FlorianSW: So in this function, https://dpaste.de/7gt3 the object is article? [15:08:53] Btw.: I'm happy to help as much as I can, but it would be nice, if you would try to find it out yourself, that are mostly things, which are documented in the docs: doc.wikimedia.org :] [15:09:13] MtDu: exactly [15:09:35] it is passed to the function and because there is a type hinting, you can safely assume, that it holds an instance of Article :) [15:09:42] FlorianSW: So instead of the Wgout, I can use $article->getContext->getOutput? [15:09:54] getContext(), yes [15:09:57] not getContext [15:10:11] FlorianSW: Ok. And could you explain why the getContext is necessary again? [15:10:50] * Hi_Im_Pearli slaps FlorianSW around a bit with a large fishbot [15:11:27] 10Spelling-Dictionary: Replace manual list population of the languages by Language List Populator - https://phabricator.wikimedia.org/T122699#1911609 (10Ankitashukla) 3NEW [15:11:30] MtDu: If you refer to the inheritance diagram for Article. https://doc.wikimedia.org/mediawiki-core/master/php/classArticle.html# you see, that it inherits from Page, so you need to find out, how you can access what you want. We want a "msg" function, which isn't implemented in the class. [15:11:53] but if you look to the collaboration diagram you see, that Article holds an instance of ContextSource [15:12:26] so normally there's a way to get this instance, in this case it's getContext(). And IContextSource implements the required msg() function (or getOutput() or getUser() or something else). [15:13:02] you can look at the list of functions, which are implemented in this class and look, which one matches your usage or gives you a way to get what you want :) [15:13:27] It looks a bit tricky if you see it the first time, maybe, but makes sense, once you understand the whole thing. [15:13:55] * FlorianSW ignores Hi_Im_Pearli as best as he can [15:16:24] FlorianSW: So getContext gets the ContextSource object, and then IContextSource gives me what I need? [15:18:57] ContextSource implements IContextSource (IContextSource is an interface, ContextSource an abstract class, it normally is an implementation of these, mostly RequestContext) :) [15:19:25] that's what you see in the inheritance diagram. What class inherits from, e.g. RequestContext: [15:19:38] https://doc.wikimedia.org/mediawiki-core/master/php/classRequestContext.html# [15:19:43] implements IContextSource [15:21:35] FlorianSW: So from the diagram, I see article then $mcontext then icontextsource. When I look at the docs for $mcontext, it says referenced by getContext(). So then it can implement IcontextSource? [15:22:28] FlorianSW: Just trying to make sure I got this down. :) [15:22:58] Hello I am Dragernix trying a task for GCI!! :) [15:23:32] Dragernix: Welcome! It's great to have you here. :) [15:23:57] Dragernix: Are you doing the task of staying in the IRC for 1 hour+? [15:24:06] I'm currently trying to follow your thoughts :D But I assume, your on the right track :) It's simplier to look, if IContextSource is referenced somewhere and look into the function list, the most common functions has the same name :) [15:24:09] * names [15:24:39] FlorianSW: Ok. I'll let it sink in. Anyways, is this right now? I'm currently trying to follow your thoughts :D But I assume, your on the right track :) It's simplier to look, if IContextSource is referenced somewhere and look into the function list, the most common functions has the same name :) [15:24:42] FlorianSW, when I do element.uls( ... ) the ULS seems to *appear* but it has display: none by default [15:24:52] FlorianSW: Sorry, this. https://dpaste.de/bGEt [15:25:07] how can I truly show it? [15:25:27] MtDu: except L24, that'll not work :) [15:25:30] 10Spelling-Dictionary: Improve the forms (to OOjs UI Form) - https://phabricator.wikimedia.org/T122701#1911629 (10Ankitashukla) 3NEW [15:25:52] FlorianSW: Hm. I never touched that. I'll delte the extra -> [15:26:10] victorbarbu_: uhm, I don't know anything about uls, how does the main code launch it? [15:26:30] MtDu: it definitly wasn't there by default (I hope :P) :D [15:28:32] MtDu: it's, btw., easier to see a diff, to find out, what you've changed :) [15:28:46] FlorianSW: Yep. [15:31:11] (03PS2) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [15:32:48] Dragernix: hello [15:33:30] Dragernix: you may also want to register your nickname, which is free https://meta.wikimedia.org/wiki/IRC/Instructions#Register_your_nickname.2C_identify.2C_and_enforce [15:37:40] haha sure! [15:38:00] Hello everyone! I'm member:Dunia, a participant in Google Code-In. [15:38:50] dunia: Hello! Welcome. Refer to Nemo_bis' comment above to Dragernix. [15:39:25] Thanks! [15:39:58] (03PS3) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [15:40:26] FlorianSW|away: New patch. [15:40:45] Hello dunia [15:40:48] Nemo_bis: New patch. I think Florian is busy, so please take a look. :) https://gerrit.wikimedia.org/r/261761 [15:41:31] uh just in time to stop me from the pause I was about to take [15:41:48] Nemo_bis: Sorry. [15:43:06] (03CR) 10Florianschmidtwelzow: "Just a short look." (034 comments) [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [15:45:21] but I'm too slow [15:47:36] Nemo_bis, are you familiar with ULS [15:47:37] ? [15:53:08] 10MediaWiki-extensions-Babel: Babel AutoCreate should not recreate deleted categories - https://phabricator.wikimedia.org/T63995#1911636 (10Dereckson) 5Open>3declined a:3Dereckson Consensus not to implement this feature request. [15:56:43] (03PS4) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [15:56:54] 10MediaWiki-extensions-Babel: Babel language codes should be normalised to lower case when used in categories - https://phabricator.wikimedia.org/T63993#1911641 (10Dereckson) @MarcoAurelio @MrStradivarius Would it be reasonable to implement a fix where the extension always use lowercase language code? [15:56:55] 10Wikispeech: Set up documentation page - https://phabricator.wikimedia.org/T121417#1911643 (10Jopparn) p:5Triage>3Normal a:3Jopparn [15:57:18] (03CR) 10jenkins-bot: [V: 04-1] Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [15:57:25] 10MediaWiki-Special-pages, 7Regression: Special:Preferences asks for form data save confirmation beforeunload even if nothing was changed - https://phabricator.wikimedia.org/T122702#1911646 (10Glaisher) 3NEW [15:57:29] 10MediaWiki-extensions-Babel: Babel language codes should be normalised to lower case when used in categories - https://phabricator.wikimedia.org/T63993#1911653 (10Dereckson) p:5Triage>3High Priority set to high, per T112868. [15:58:28] 10MediaWiki-extensions-Babel, 10Wikidata: Access user language preferences (including Babel) via standard API - https://phabricator.wikimedia.org/T122000#1911657 (10Dereckson) p:5Triage>3Low [15:58:39] FlorianSW|away: Why can't I define those variables there? [15:58:39] victorbarbu_: have you looked at examples such as https://github.com/wikimedia/mediawiki-extensions-Translate/blob/master/resources/js/ext.translate.special.translate.js#L246-L267 ? [15:58:54] 10MediaWiki-extensions-Translate, 7Easy, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Replace Elastica\Query\Bool usage in ttmserver - https://phabricator.wikimedia.org/T122696#1911660 (10Ricordisamoa) [15:59:50] 10MediaWiki-extensions-Babel, 7Upstream: Incorrect output for cmn on Meta - https://phabricator.wikimedia.org/T117161#1911664 (10Dereckson) Per Nemo_bis comment. [16:00:02] Nemo_bis: Why can't I define those variables there? https://gerrit.wikimedia.org/r/261761 [16:00:24] MtDu: nonono :D Sorry, if I wasn't clear. I mean a function-level variable if I say "local" variable. You try to define class level variables :) [16:00:56] FlorianSW|away: How do I define them if I want every function to be able access them, instead of defining them in every function? [16:01:28] FlorianSW|away: Or do I just define them in every function? [16:01:37] 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 6Commons, 6Multimedia: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#1911666 (10zhuyifei1999) What is the status of this? The first error describes an exactly like {T108449} (Dec... [16:02:19] Nikerabbit, I checked that out. NO luck [16:02:27] the div is created with display block by default [16:02:51] I could do a work around, to set display to block on click, but it wouldn't be a good solution [16:03:50] (03CR) 10Glaisher: "seems to cause T122702" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [16:04:23] victorbarbu_: ok I think I am missing some context here [16:05:29] the context does not matter [16:05:48] but to explain you, I have a special page, a button which, when clicked, should display the ULS [16:06:00] so I've done $button.uls( ... ) [16:06:26] and the created div has display: none [16:06:40] MtDu: define them in every function, if you need to :) It's the easiest way [16:07:04] victorbarbu_: and when you click the button? [16:07:09] Glaisher: ping [16:07:14] ? [16:07:16] pong [16:07:34] Regarding T122702, do you click on watchlist etc. before JS is done loading? I'm having difficulty reproducing it [16:07:37] Nikerabbit, I click the button when I want to click the button [16:07:42] :)) [16:07:54] the language selection popup should appear when you click the button, not when you call $button.uls [16:07:58] (probably due to my ineptness in understanding written langauge) [16:08:12] OH-: After everything finishes loading. Note that it doesn't happen if JS is disabled. [16:08:28] I'm not getting it in Chrome. Lemme try Firefox [16:09:44] (03PS5) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [16:10:01] and how do I do that? [16:10:19] Nikerabbit [16:10:47] just set $button.uls when page loads or button is created? [16:11:01] or call click() on the button again afterwards (that's what the interlanguage stuff does) [16:11:07] FlorianSW|away: I defined all of them locally. For the functions that only used them once, I just left them as is. Let me know if anything's wrong. :) [16:11:33] I might have explained you wrong [16:11:38] let me make myself clear [16:11:46] I call $button.uls() on page load [16:11:48] then I click the button [16:11:52] Glaisher: Nope, still can't reproduce. What OS are you on? [16:11:54] the div is created, but not displayed [16:12:00] OH-: Ubuntu [16:12:30] Which firefox version? [16:12:35] 43 [16:12:48] OH-: Which version are you on? [16:12:50] Hmm, I'm on FF 43 on windows. Let me try it on Fedora [16:14:18] Nikerabbit, here https://www.mediawiki.org/wiki/Universal_Language_Selector/Technical_Design#jQuery_plugin_architecture [16:14:20] says [16:14:24] An example showing integration of ULS with an element is given below. Clicking on the element will open ULS. This example uses onSelect option to show the autonym of the selected language as text for element #pageLanguage. [16:14:33] so the ULS should show up on click [16:14:37] just by adding that snippet [16:16:02] (03PS6) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [16:16:21] FlorianSW|away: I took out the $user variable LiveTranslate.hooks.php because that was only used once. [16:16:31] FF 42 on Fedora doesn't get the dialog (I don't think 43 is in the repos yet) [16:16:35] I have to go [16:16:43] Happy new year everyone!! [16:16:44] awfully strange [16:16:48] FlorianSW|away: Let me know if anything's wrong, and tell me when to submit. Thanks! [16:17:00] victorbarbu_: Happy New Year! Thanks! [16:17:15] victorbarbu_: Well, New Year's Eve, that is. [16:18:56] (03CR) 10Florianschmidtwelzow: "Some notes" (034 comments) [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [16:19:02] 10MediaWiki-Special-pages, 7Regression: Special:Preferences asks for form data save confirmation beforeunload even if nothing was changed - https://phabricator.wikimedia.org/T122702#1911668 (10Sn1per) [16:20:11] 10MediaWiki-Special-pages, 7Regression: Special:Preferences asks for form data save confirmation beforeunload even if nothing was changed - https://phabricator.wikimedia.org/T122702#1911671 (10Glaisher) [16:20:30] hold up, maybe my repos are out of date [16:22:08] FlorianSW|away: For this, https://gerrit.wikimedia.org/r/#/c/261761/5/includes/LiveTranslate_Functions.php I referred to https://www.mediawiki.org/wiki/Manual:Messages_API#Help_with_replacing_deprecated_wfMsg.2A_functions (wfMsgForContentNoTrans)) [16:22:25] FlorianSW|away: Do I need to change it to text()? [16:22:59] 10MediaWiki-extensions-CentralAuth, 7Easy: CentralAuth Autologin should emit an event after logging in the user, for other components to listen to - https://phabricator.wikimedia.org/T122655#1911673 (10TheDJ) I agree this might be a good candidate for an mw.hook. We could call it ... user.login ? [16:23:14] 10MediaWiki-Special-pages, 7Regression: Special:Preferences asks for form data save confirmation beforeunload even if nothing was changed - https://phabricator.wikimedia.org/T122702#1911675 (10Sn1per) I can't seem to reproduce this with Chrome 47 on Windows, Firefox 43 on Windows, or Firefox 42 on Fedora. Coul... [16:24:14] MtDu: ah, no, that's fine then, I haven't found that. But you shouldn't use inContentLanguage() :) [16:25:38] (03PS7) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [16:26:36] FlorianSW|away: Hopefully everything is good to go. :) [16:33:03] 3Mobile-App-Android-Sprint-72-Hafnium, 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Add route to provide Wiktionary definition of requested word or phrase. - https://phabricator.wikimedia.org/T119235#1911679 (10Mholloway) Hi @Nemo_bis, The dialogs (and... [16:33:17] FlorianSW|away:^ [16:39:55] Nemo_bis: Are you back? [16:41:57] 3Mobile-App-Android-Sprint-72-Hafnium, 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Add route to provide Wiktionary definition of requested word or phrase. - https://phabricator.wikimedia.org/T119235#1911681 (10Mholloway) @GWicke, following on my note to... [16:46:49] FlorianSW_: https://gerrit.wikimedia.org/r/261761 [16:47:04] FlorianSW_: I've been waiting for you to get back. :) [16:48:17] (03CR) 10Unicornisaurous: "Thanks TTO for finishing this up!" [core] - 10https://gerrit.wikimedia.org/r/261311 (https://phabricator.wikimedia.org/T122587) (owner: 10Unicornisaurous) [16:50:15] 10CirrusSearch, 6Discovery, 7Elasticsearch, 7Newphp, 7Upstream: PHP7 Fatal error: Cannot use 'Bool' as class name as it is reserved in extensions/Elastica/Elastica/lib/Elastica/Query/Bool.php on line 15 - https://phabricator.wikimedia.org/T122686#1911683 (10Reedy) @zoglun Does the library not work becau... [16:53:26] 6Discovery, 7Elasticsearch: Upgrade ElasticSearch to 1.7.4 - https://phabricator.wikimedia.org/T122697#1911684 (10Reedy) I presume, we can get ops to import the deb, and then start upgrading logstash etc? [16:56:20] FlorianSW_: Please take a look at the patch when you get a chance. :) [16:56:57] No need to ping him every ten minutes :) It's new years [16:58:32] FlorianSW_: Sorry about the pinging. [16:58:45] 3Mobile-App-Android-Sprint-72-Hafnium, 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Add route to provide Wiktionary definition of requested word or phrase. - https://phabricator.wikimedia.org/T119235#1911693 (10GWicke) @Mholloway, the main reason for inc... [17:00:42] So ping him to apologise :} [17:01:13] 6Discovery, 10Wikimedia-Logstash, 7Elasticsearch: Upgrade ElasticSearch to 1.7.4 - https://phabricator.wikimedia.org/T122697#1911697 (10Reedy) [17:02:07] Am I allowed to +2 this? https://gerrit.wikimedia.org/r/#/c/261606/ [17:02:23] Do you have the rights to do so? [17:02:49] Reedy: I'm not sure. All I know is that I'm on the whitelist. [17:02:49] Though, as you won't have the rights to deploy it, I'd suggest against doing so [17:02:54] Reedy: Ok. [17:03:14] If you're on it, it means jenkins will run more tests for you [17:03:14] Reedy: Could you do it? Pranavk has been waiting for that for some time now. :) [17:03:28] I think I have access, but I don't know how to deploy it without looking it up [17:05:10] Whitelist !== +2 rights [17:05:17] 6Discovery, 10Wikimedia-Logstash, 7Elasticsearch: Upgrade ElasticSearch to version 2 - https://phabricator.wikimedia.org/T122698#1911698 (10Reedy) [17:05:27] +2 rights are a great power that comes with great responsibility [17:05:30] I think hes used tabs instead of spaces so its failed test anyway and he needs to update [17:23:10] 10Wikimedia-Site-Requests, 7Wikimedia-log-errors: Translate extension seemingly broken / partially installed on wikimedia2017wiki - https://phabricator.wikimedia.org/T122675#1911703 (10Krenair) 5Open>3Resolved Thanks @Nikerabbit. I dropped those tm* tables. I think this should be fixed now. [17:25:52] 10Wikimedia-Site-Requests, 7Wikimedia-log-errors: Translate extension seemingly broken / partially installed on wikimedia2017wiki - https://phabricator.wikimedia.org/T122675#1911709 (10Nikerabbit) Great. Is there any place to add a note for future deployers? `InitializeSettings.php` comes to my mind first. [17:28:32] 10Wikimedia-Site-Requests, 7Wikimedia-log-errors: Translate extension seemingly broken / partially installed on wikimedia2017wiki - https://phabricator.wikimedia.org/T122675#1911710 (10Krenair) Maybe... However, I just noticed that it's actually one of the extensions supported by Extension:WikimediaMaintenance... [17:38:25] 10CirrusSearch: Bad search results when you don't include the preposition in your search query - https://phabricator.wikimedia.org/T116706#1911722 (10Deskana) >>! In T116706#1911466, @TTO wrote: > Reopening this. I think Dan misunderstood the reporter's comment. Thanks. There wasn't much context for me to go on... [17:42:17] 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer, 6Commons, 6Multimedia: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#1911734 (10Tgr) >>! In T115563#1911666, @zhuyifei1999 wrote: > What is the status of this? The first error de... [17:42:58] 10MediaWiki-extensions-CentralAuth, 7Easy: CentralAuth Autologin should emit an event after logging in the user, for other components to listen to - https://phabricator.wikimedia.org/T122655#1911735 (10TheDJ) Actual.. maybe we already have one: mw.hook( 'centralauth-p-personal-reset' ).fire(); in modules/inlin... [17:45:55] 10Wikimedia-Developer-Summit-2016, 7I18n: Let's discuss LanguageConverter - https://phabricator.wikimedia.org/T113002#1911736 (10cscott) @RobLa-WMF -- perhaps. It really depends on who shows up and what the context of the summit is; whether folks feel empowered. @TStarling, @nemo_bis -- I agree with your poi... [17:50:59] 10Phabricator-Upstream: Phantom unread notifications when users are subscribed to objects they are not allowed to view - https://phabricator.wikimedia.org/T102653#1911737 (10matmarex) This is happening to me again, eh. [17:57:39] 10MediaWiki-extensions-CentralAuth: CentralAuth autologin does not update the global JS variables - https://phabricator.wikimedia.org/T122652#1911738 (10TheDJ) Should probably include these in the toolslist response of `includes/specials/SpecialCentralAutoLogin.php` ``` $json = FormatJSON::encode( array( 'tools... [18:09:23] (03CR) 10Alex Monk: [C: 032] registration: Prevent loading the same thing twice [core] - 10https://gerrit.wikimedia.org/r/261608 (https://phabricator.wikimedia.org/T121493) (owner: 10Legoktm) [18:15:57] (03Merged) 10jenkins-bot: registration: Prevent loading the same thing twice [core] - 10https://gerrit.wikimedia.org/r/261608 (https://phabricator.wikimedia.org/T121493) (owner: 10Legoktm) [18:17:37] (03PS9) 10Unicornisaurous: Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) [18:18:14] (03CR) 10Unicornisaurous: "Done." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) (owner: 10Unicornisaurous) [18:18:20] (03PS10) 10Unicornisaurous: Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) [18:19:22] 10MediaWiki-Export-or-Import, 3Google-Code-In-2015, 5Patch-For-Review: dumpBackup.php: offer option to use 7za -mx=4 instead of -mx=5 - https://phabricator.wikimedia.org/T78669#1911755 (10Unicornisaurous) [18:19:22] 10MediaWiki-Maintenance-scripts, 7Technical-Debt: Migrate the rest of the maintenance scripts to subclass maintenance - https://phabricator.wikimedia.org/T27782#1911756 (10Unicornisaurous) [18:19:24] 10MediaWiki-Maintenance-scripts, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Make dumpBackup.php subclass Maintenance - https://phabricator.wikimedia.org/T122587#1911753 (10Unicornisaurous) 5Open>3Resolved :) [18:22:08] 7Design, 10Front-end-Standards-Group, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: User interface presentation - https://phabricator.wikimedia.org/T119162#1911758 (10cscott) Note that I'm leading the session "across the hall" in R2 in this time slot ({T112987}). So I wouldn't be... [18:26:22] (03PS1) 10TheDJ: [Untested] Pick up config variables after autologin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/261772 (https://phabricator.wikimedia.org/T122652) [18:29:00] (03CR) 10jenkins-bot: [V: 04-1] [Untested] Pick up config variables after autologin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/261772 (https://phabricator.wikimedia.org/T122652) (owner: 10TheDJ) [18:30:53] Hi.Where can I find the code for autosuggest feature at wiktionary ? https://en.wiktionary.org/wiki/Wiktionary:Main_Page [18:31:26] Which autosuggest? [18:31:55] The suggestions that come up when we type our word on the text-field [18:32:18] In the search box? [18:32:29] yeah [18:33:22] Happy New Year to everyone! :D [18:33:25] https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki.searchSuggest.jsv [18:33:28] https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki.searchSuggest.js [18:33:39] I'm from India, and it's 12 am already. [18:34:15] Thannks Reedy . Yeah ananay . I'm from New Delhi too. Happy New Year. [18:34:46] dg711: You're a participant of GCI too? [18:36:21] whats GCI ? [18:36:37] ohh . no [18:36:54] code-in , right? No. [18:38:20] Ahh, okay. [18:38:36] How many are participating in GCI in Wikimedia? :$ [18:39:52] You can use phabricator to get a rough esitimate. I dont think that many though [18:41:06] theres quite a high barrier to entrance as you need to get gerrit setup [18:41:30] Not really [18:41:34] you don't have to use git review [18:41:46] cough gerrit patch uploader cough [18:42:07] 10MediaWiki-Page-deletion: Restore form should allow specifying a new name for the page - https://phabricator.wikimedia.org/T122707#1911763 (10Huji) 3NEW [18:42:09] Personally not that big a fan of gerrit patch uploader because it makes it hard to keep track of what one person has done [18:42:27] It took me at least twice as long geting setup as any subsequent task. Theres was a single wikipage and i just followed it thourgh [18:45:03] Just out of intrest is there a reason why you dont use github to host the main repos? [18:46:30] Github's backend is not open source [18:46:45] Also, we want to control our source [18:46:50] etc. [18:46:58] Ok but why not use vanilla git then with git push? [18:50:04] because code review, I assume [18:50:54] well git hub has pull requests [18:51:12] gut it guess gerrits nicer to review [18:51:22] 10MediaWiki-Configuration, 5Patch-For-Review: Exception encountered, of type "InvalidArgumentException" in update.php when 'vector' is symlinked to 'Vector' - https://phabricator.wikimedia.org/T121493#1911770 (10Legoktm) 5Open>3Resolved [18:53:40] Hello everyone, I am here to get to know IRC chat for Google Code In. [18:54:24] I like to code and play video games. I also like to watch Netflix. [18:54:37] hi :) Im also doing GCI [18:54:46] 6Discovery: Wikimedia search UI should offer users an easy way to do title-only searches - https://phabricator.wikimedia.org/T102078#1911772 (10PamD) My T121496 has been merged into this task, so let me clarify my request here: the ability to search on titles of both articles and redirects together - thus pickin... [18:54:55] Video games? I can't hold interest [18:55:28] Im no hardcore gamer either but I like to play the classics [19:01:43] OH-, paarthri, you can use private chat please. [19:02:32] You are spamming 177 dev's in the channel with (you) inclusive :) [19:02:43] No need. It was a passing comment and the conversation is over :P [19:02:55] OH-, paarthri, GCI students? [19:03:22] Sorta. I participate in GCI but I've been here for a while [19:07:10] OH-: Ok, nice [19:07:18] I am mentoring GCI :) [19:13:31] 10MediaWiki-extensions-Newsletter: Summary is no longer present in echo web notifications - https://phabricator.wikimedia.org/T122663#1911774 (1001tonythomas) a:301tonythomas [19:16:18] interesting [19:16:20] tonythomas' name in wikibugs output broke my irc client's colouring [19:16:24] it dropped the 0 and made the rest of his name grey instead of the usual red (?) for assignees [19:17:53] or maybe it just caused wikibugs to output an invalid code [19:17:58] Krenair: wow. I am using a web-client, and its still intact ( always 01 used to cause something strange :D ) [19:18:50] 10Wikimedia-Developer-Summit-2016: Semantic image styles / beautiful layout - https://phabricator.wikimedia.org/T112991#1911775 (10cscott) @violetto Could I get your help leading this session? I know it's last minute, but if you'd be willing to present the screenshots and ideas you posted above, it would be a g... [19:20:29] (03CR) 10Nemo bis: Replace deprecated wfMsg*() and wg*() functions (031 comment) [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) (owner: 10MtDu) [19:20:38] Reedy, hi I have issues with my PC, I probably will fix them tomorrow, just so you and tto know:( [19:21:32] I might have to reinstall windows.. [19:21:44] (03PS1) 10Alex Monk: List Special:PetitionData/csv as a subpage in prefixsearch [extensions/Petition] - 10https://gerrit.wikimedia.org/r/261773 [19:22:59] And happy New Year everyone:) [19:23:46] :) [19:25:04] Nemo_bis one questiin, how can you know if lets say kid has a parent who is programmer, and that psrent is doing all the work? [19:26:10] Maybe somebody knows, is that normal that in windows recovery console starts with x:\ not with c:\ [19:26:17] Yeah [19:26:24] yes [19:26:54] Georggi: well I guess we can never be 100 % sure, but we wiki people have experience with sockpuppets and meatpuppets and so far I've not seen someone whose pattern of contribution could be compatible with such a scenario [19:27:23] Oh, ok, nice to hear that:) [19:28:32] 10MobileFrontend: Mobile edit icon giving wrong section - https://phabricator.wikimedia.org/T122471#1911776 (10PamD) Sorry not to reply sooner - I've been away from email, and hence Phabricator notifications, for a few days. It's an intermittent problem. Currently,looking at some of "Category:Stubs": "FileCl... [19:30:18] Nemo_bis: So, based off your comment, I should change it to parse? [19:31:44] 10Wikimedia-Developer-Summit-2016-Organization: Define the list of "must have" sessions for WikiDev '16 - https://phabricator.wikimedia.org/T119593#1911777 (10cscott) Can I ask why so many people (@bmansurov, @dr0ptp4kt, @Tnegrin, @JMinor, @KLans_WMF, @JKatzWMF, @MBinder_WMF, @Niedzielski, @jhobs) listed {T11407... [19:32:04] MtDu: you could test :) [19:32:50] (03PS8) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [19:34:00] Nemo_bis: They passed. :) [19:35:26] 10Wikimedia-Developer-Summit-2016-Organization: Define the list of "must have" sessions for WikiDev '16 - https://phabricator.wikimedia.org/T119593#1911781 (10cscott) (For some context, I'm the proposer of a task in all but two of the sessions currently in R2. I'd really prefer to drop T114072 on the floor and... [19:37:11] Nemo_bis: So parse is a better option for security reasons? [19:38:23] MtDu: I meant that you should test whether you are able to inject javascript via one of those system messages [19:38:42] checkout your code on a test wiki, edit the system messages with some nasty content, see what happens [19:46:23] Nemo_bis: So I changed it to plain again locally, and I'm on vagrant on 127 special page livetranslate. [19:46:43] Nemo_bis: How do I test it now? [19:48:20] FlorianSW_: Any thoughts on this? [19:48:27] or you could fiddle with hhvmsh, right? [19:48:34] Interactive php console [19:51:45] Nemo_bis: I don't quite understand. Could you help me? [19:58:00] Nemo_bis: Changing back to plain for now. When Florian took a look, we discussed it on the IRC. He said plain was fine. But I'm not sure. [19:58:06] (03PS9) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [19:59:36] MrDu: Why cant use use parse? [19:59:54] MtDu: this might not be too exact, but sometimes input/output messages can give way to injection vulnerabilities like https://www.owasp.org/index.php/Testing_for_Cross_site_scripting#Description_of_Cross-site_scripting_Vulnerabilities when you dont parse down the content, strip it off dangerous tags and so on [20:01:09] tonythomas: Ok. [20:01:13] hhvmsh is a great tool [20:01:28] https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/hhvm/files/hhvmsh [20:02:27] 10Wikimedia-Developer-Summit-2016-Organization: Define the list of "must have" sessions for WikiDev '16 - https://phabricator.wikimedia.org/T119593#1911782 (10Tnegrin) From my perspective, I want T114072 to happen because it helps with presentation issues but I don't have the context to part of a discussion. Rea... [20:03:20] (03PS10) 10MtDu: Replace deprecated wfMsg*() and wg*() functions [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/261761 (https://phabricator.wikimedia.org/T70750) [20:14:15] (03CR) 10TTO: [C: 032] Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) (owner: 10Unicornisaurous) [20:18:05] Ok, guys, is it normal that on recovery console checking disk C shows that it has only around 70MB free space? [20:18:14] (03PS1) 1001tonythomas: Add summary back to echo web notifications [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/261774 (https://phabricator.wikimedia.org/T122663) [20:19:16] (03PS2) 1001tonythomas: Add summary back to echo web notifications [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/261774 (https://phabricator.wikimedia.org/T122663) [20:20:04] (03CR) 10BryanDavis: [C: 032] Update nmred/kafka-php to v0.1.5 [vendor] - 10https://gerrit.wikimedia.org/r/260156 (owner: 10Reedy) [20:20:28] (03Merged) 10jenkins-bot: Add 7zip compression level param to BackupDumper [core] - 10https://gerrit.wikimedia.org/r/261755 (https://phabricator.wikimedia.org/T78669) (owner: 10Unicornisaurous) [20:20:54] tto, if you are here, can you add a few days to my task? [20:22:37] (03CR) 10BryanDavis: [C: 04-1] "Why are we downgrading from 2.7.3 to 2.6.11?" [vendor] - 10https://gerrit.wikimedia.org/r/260157 (owner: 10Reedy) [20:24:39] (03PS1) 10Mholloway: Put page/ back in endpoint path [services/mobileapps] - 10https://gerrit.wikimedia.org/r/261775 (https://phabricator.wikimedia.org/T119235) [20:26:22] (03Merged) 10jenkins-bot: Update nmred/kafka-php to v0.1.5 [vendor] - 10https://gerrit.wikimedia.org/r/260156 (owner: 10Reedy) [20:26:30] (03CR) 10StudiesWorld: [C: 031] Put page/ back in endpoint path [services/mobileapps] - 10https://gerrit.wikimedia.org/r/261775 (https://phabricator.wikimedia.org/T119235) (owner: 10Mholloway) [20:27:23] 3Mobile-App-Android-Sprint-72-Hafnium, 3Mobile-Content-Service, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-NewFunctionality: Add route to provide Wiktionary definition of requested word or phrase. - https://phabricator.wikimedia.org/T119235#1911788 (10Mholloway) @Gwicke, makes sense. I just p... [20:27:38] (03PS1) 10Gergő Tisza: Add largest allowed range as parameter to block form message [core] - 10https://gerrit.wikimedia.org/r/261776 [20:33:31] (03CR) 10jenkins-bot: [V: 04-1] Add largest allowed range as parameter to block form message [core] - 10https://gerrit.wikimedia.org/r/261776 (owner: 10Gergő Tisza) [20:35:17] (03CR) 10Fomafix: [C: 04-1] "This change adds three new IDs. They should follow the coding convections:" [core] - 10https://gerrit.wikimedia.org/r/118246 (https://phabricator.wikimedia.org/T64316) (owner: 10Gerrit Patch Uploader) [20:38:12] (03PS2) 10Gergő Tisza: Add largest allowed range as parameter to block form message [core] - 10https://gerrit.wikimedia.org/r/261776 [20:39:43] 10MediaWiki-Page-editing, 10MediaWiki-RfCs, 10MediaWiki-extensions-CodeEditor, 6Editing-Department, and 3 others: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#1911792 (10cscott) We'd like to eventually allow extension authors to distribute... [20:42:59] (03PS16) 10Gerrit Patch Uploader: EditPage: Render wpSummaryLabel and wpSummary on one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 (https://phabricator.wikimedia.org/T64316) [20:43:01] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (https://phabricator.wikimedia.org/T64316) (owner: 10Gerrit Patch Uploader) [20:47:05] (03PS7) 10VolkerE: Implement skip-to links and importing mediawiki.stateful-classes.less [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/237870 (https://phabricator.wikimedia.org/T112308) [20:49:50] (03PS8) 10VolkerE: Implement skip-to links and importing mediawiki.stateful-classes.less [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/237870 (https://phabricator.wikimedia.org/T112308) [20:54:04] 7Performance: Avoid ShortUrl master writes on page view - https://phabricator.wikimedia.org/T122708#1911793 (10aaron) 3NEW a:3aaron [20:54:14] 7Performance: Avoid ShortUrl master writes on page view - https://phabricator.wikimedia.org/T122708#1911793 (10aaron) a:5aaron>3None [20:57:34] 10Wikimedia-Developer-Summit-2016, 7I18n: Let's discuss LanguageConverter - https://phabricator.wikimedia.org/T113002#1911802 (10RobLa-WMF) I think I have to concur with @TStarling's statement "//I think it's potentially distracting from the technical discussion we need to have at the dev summit.//" Note, we... [21:03:47] (03CR) 10VolkerE: [C: 032] "PS 7 added helper class back as long as T119444 isn't resolved, all of TheDJs feedback is covered. Helper class is needed for unblocking T" [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/237870 (https://phabricator.wikimedia.org/T112308) (owner: 10VolkerE) [21:04:31] (03Merged) 10jenkins-bot: Implement skip-to links and importing mediawiki.stateful-classes.less [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/237870 (https://phabricator.wikimedia.org/T112308) (owner: 10VolkerE) [21:09:02] 10Living-Style-Guide, 10MediaWiki-skins-Blueprint, 7Accessibility: Implement accessibility "bar" in Blueprint - https://phabricator.wikimedia.org/T122709#1911806 (10Volker_E) 3NEW a:3Volker_E [21:09:13] (03CR) 10Bartosz Dziewoński: "That would be silly. I am not going to do it. We've been actively removing non-functional prefixed properties for a while, we shouldn't be" [core] - 10https://gerrit.wikimedia.org/r/261723 (https://phabricator.wikimedia.org/T104541) (owner: 10Bartosz Dziewoński) [21:09:53] Nemo_bis: I read the doc and changed it to parse. What else do I need to do? [21:11:43] 10Living-Style-Guide, 10MediaWiki-skins-Blueprint, 7Accessibility, 5Patch-For-Review: Blueprint should include skip-to-nav and skip-to-content links - https://phabricator.wikimedia.org/T112308#1911817 (10Volker_E) @violetto I'd urge for opening another task for the toolbar and stay with the two links as a... [21:15:17] 10Wikimedia-Site-Requests: User group rights changes on tr.wikiquote.org - https://phabricator.wikimedia.org/T122710#1911820 (10Mavrikant) 3NEW [21:15:24] 10Living-Style-Guide, 10MediaWiki-skins-Blueprint, 7Accessibility: Implement accessibility "bar" in Blueprint - https://phabricator.wikimedia.org/T122709#1911827 (10Volker_E) Citing from [[ https://phabricator.wikimedia.org/T112308#1903021 | @violetto's comment ]]: > https://invis.io/NZ5F7S4EQ > > Hitti... [21:15:44] (03PS17) 10Gerrit Patch Uploader: EditPage: Render wpSummaryLabel and wpSummary in one line with full width [core] - 10https://gerrit.wikimedia.org/r/118246 (https://phabricator.wikimedia.org/T64316) [21:15:46] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/118246 (https://phabricator.wikimedia.org/T64316) (owner: 10Gerrit Patch Uploader) [21:17:05] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: [GOAL] Enhance accessibility of OOjs UI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users - https://phabricator.wikimedia.org/T111117#1911832 (10Volker_E) [21:17:08] 10MediaWiki-skins-Blueprint, 10Web-APIs-Hub: Deploy Blueprint on mediawiki.org as optional and experimental skin - https://phabricator.wikimedia.org/T93613#1911833 (10Volker_E) [21:17:11] 10Living-Style-Guide, 10MediaWiki-skins-Blueprint, 7Accessibility: Blueprint should include skip-to-nav and skip-to-content links - https://phabricator.wikimedia.org/T112308#1911829 (10Volker_E) 5Open>3Resolved [21:18:00] 10Wikimedia-Developer-Summit-2016, 7I18n: Let's discuss LanguageConverter - https://phabricator.wikimedia.org/T113002#1911834 (10cscott) I'm pretty sure @tstarling was not proposing that we drop this session from the summit. He was merely referring to the "splitting the wikis" wording -- which I agree, is inf... [21:20:42] 10Living-Style-Guide, 10MediaWiki-skins-Blueprint, 7Accessibility: Blueprint should include skip-to-nav and skip-to-content links - https://phabricator.wikimedia.org/T112308#1911840 (10violetto) >>! In T112308#1911817, @Volker_E wrote: > @violetto I'd urge for opening another task for the toolbar and stay wi... [21:23:55] (03PS2) 10Aaron Schulz: Make maintenance scripts use beginTranscation/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 [21:24:30] (03PS1) 10VolkerE: `#toctitle` should be readable by screen reader users [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/261777 (https://phabricator.wikimedia.org/T118546) [21:26:48] (03CR) 10VolkerE: [C: 032] "Changing the one CSS selector to screen reader accessibility." [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/261777 (https://phabricator.wikimedia.org/T118546) (owner: 10VolkerE) [21:28:39] 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1911846 (10ssastry) I think it is fair to say that wikitext, as it exists today, is not a format that enables easy and robust ways of extracting semantic pieces ou... [21:28:46] (03CR) 10jenkins-bot: [V: 04-1] Make maintenance scripts use beginTranscation/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [21:30:20] FlorianSW_: I changed the plain to parse in the patch. Is there anything else I need to do? [21:33:26] (03Merged) 10jenkins-bot: `#toctitle` should be readable by screen reader users [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/261777 (https://phabricator.wikimedia.org/T118546) (owner: 10VolkerE) [21:36:04] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: [GOAL] Enhance accessibility of OOjs UI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users - https://phabricator.wikimedia.org/T111117#1911856 (10Volker_E) [21:40:08] 10MediaWiki-skins-Blueprint: Bootstrap's CSS rule "box-sizing: border-box;" breaks VE toolbar - https://phabricator.wikimedia.org/T122117#1911857 (10Volker_E) [21:52:07] (03PS1) 10Gerrit Patch Uploader: mediawiki.action.edit.preview: Combine two the consecutive .push [core] - 10https://gerrit.wikimedia.org/r/261778 [21:52:09] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261778 (owner: 10Gerrit Patch Uploader) [21:53:05] (03PS1) 10VolkerE: Unbreak Visual Editor Toolbar layout [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/261779 (https://phabricator.wikimedia.org/T122117) [21:55:49] 10MediaWiki-skins-Blueprint, 5Patch-For-Review: Bootstrap's CSS rule "box-sizing: border-box;" breaks VE toolbar - https://phabricator.wikimedia.org/T122117#1897086 (10Volker_E) [21:55:51] 10MediaWiki-skins-Blueprint, 10Web-APIs-Hub: Deploy Blueprint on mediawiki.org as optional and experimental skin - https://phabricator.wikimedia.org/T93613#1911863 (10Volker_E) [21:56:12] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/261780 [22:01:54] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/261781 [22:02:36] (03PS3) 10BryanDavis: Make maintenance scripts use beginTransaction/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [22:02:44] (03CR) 10BryanDavis: Make maintenance scripts use beginTransaction/commitTransaction (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [22:02:57] (03CR) 10BryanDavis: [C: 032] Make maintenance scripts use beginTransaction/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [22:04:06] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261782 [22:06:30] (03CR) 10jenkins-bot: [V: 04-1] Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261782 (owner: 10Aaron Schulz) [22:07:42] (03CR) 10jenkins-bot: [V: 04-1] Make maintenance scripts use beginTransaction/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [22:09:42] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261783 [22:11:09] 10MediaWiki-Export-or-Import, 3Google-Code-In-2015, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): dumpBackup.php: offer option to use 7za -mx=4 instead of -mx=5 - https://phabricator.wikimedia.org/T78669#1911866 (10Unicornisaurous) 5Open>3Resolved yay :) [22:11:37] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/261784 [22:14:18] Theres a grand total of 2 mediawiki core tasks left for GCI :( [22:15:21] Or possibly only one [22:15:41] Perhaps some of them are not categorized as mediawiki-general [22:16:18] unicornisaurous, hi, how many tasks have you done? [22:16:35] About 10 I think [22:17:27] The amount of work I put into each varied a lot though [22:17:33] Nice, I have done 8 so far, but my hdd most likely died:( [22:18:05] Nemo_bis, are you here? [22:18:28] (03PS1) 10Aaron Schulz: Avoid using rollback() when nothing was written [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/261785 [22:18:41] unicornisaurous: Find some cool bugs to work on [22:18:52] I’m looking lol [22:19:08] Yeah. I have run out of stuff. My current task is the irc bot [22:19:38] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/261786 [22:19:57] mhutti1: Oh cool, I was going to take one of those tasks and learn me some C# [22:20:21] mhutti1: ooooh theres still one task for wm-bot left :D [22:20:41] Yeah its pretty similar to php I can give you some help setting it up if you want :) [22:21:05] I think I’m going to have to figure it out myself given that I’m on a mac but I think I can handle it :) [22:21:38] “Similar to PHP” is not necessarily what I wanted to hear haha, PHP isn’t my favorite. [22:21:40] (03CR) 10Ricordisamoa: "recheck" [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/209701 (owner: 10Ricordisamoa) [22:21:54] Yeah I did mine on linux vm so it should be simialr :) [22:22:14] There are also tasks for python I think? [22:22:22] If you have any questions just ask [22:22:23] mhutti: Oh ok, I’ll let you know if I run into any problems. [22:22:32] Guys, where are you from? [22:22:45] Georggi: Yeah I dont like python. No curly brackets :( and im from UK [22:22:48] I did one for the pywikibot but I sortof prefer developing for core [22:23:32] I’m from the US [22:23:48] I am from Ukraine, so I am from the future :)) [22:24:16] Happy new year then! [22:24:38] Yeah:) thx! [22:25:10] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/261787 [22:26:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Story, 3Wikidata-Sprint-2015-12-01: [Story] allow editing of more languages in the in other languages box than the ones defined via babel boxes - https://phabricator.wikimedia.org/T92759#1911868 (10Pengo) The site is basically bro... [22:35:51] 10MediaWiki-Special-pages, 7Regression: Special:Preferences asks for form data save confirmation beforeunload even if nothing was changed - https://phabricator.wikimedia.org/T122702#1911870 (10TheDJ) At which wiki was this ? It might be that form contribution by an extension might influence something. [22:36:30] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [22:41:36] The future?!?!?! [22:41:58] Yesss, I am from 2016!!!;) [22:42:02] Does everyone have gigabit internet yet? [22:42:52] Happy new year [22:43:31] Cant say you, Ive been told that it is top secret information)) [22:43:40] Thx! [22:46:02] (03PS2) 10Sn1per: [WIP] Implement action=mergehistory [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) [22:46:23] 10MediaWiki-extensions-ShortUrl, 7Performance: Avoid ShortUrl master writes on page view - https://phabricator.wikimedia.org/T122708#1911872 (10Krenair) [22:50:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Implement action=mergehistory [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) (owner: 10Sn1per) [23:12:11] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261788 [23:13:20] 10MediaWiki-Special-pages, 7Regression: Special:Preferences asks for form data save confirmation beforeunload even if nothing was changed - https://phabricator.wikimedia.org/T122702#1911882 (10matmarex) I can't reproduce either. I tried Firefox 43 on Ubuntu 15 (inside a VM), locally and on Beta labs. [23:14:31] (03PS1) 10Aaron Schulz: Remove pointless commit() call [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/261789 [23:16:18] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/Configure] - 10https://gerrit.wikimedia.org/r/261790 [23:19:33] (03PS1) 10Aaron Schulz: Use Maintenance DB transaction methods [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261791 [23:30:44] (03PS1) 10Aaron Schulz: Make Maintenance::commitTransaction() do slave wait checks [core] - 10https://gerrit.wikimedia.org/r/261792 [23:32:26] (03CR) 10BryanDavis: Make maintenance scripts use beginTransaction/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [23:32:40] (03CR) 10BryanDavis: [C: 032] "Try again" [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [23:38:37] (03Merged) 10jenkins-bot: Make maintenance scripts use beginTransaction/commitTransaction [core] - 10https://gerrit.wikimedia.org/r/261752 (owner: 10Aaron Schulz) [23:46:44] 10MediaWiki-ResourceLoader, 7Performance, 7Technical-Debt: User and site CSS loaded twice - https://phabricator.wikimedia.org/T108590#1911883 (10Krinkle) >>! In T108590#1911399, @Nemo_bis wrote: >> The proper solution (which will be enforced by T92459 soon) is to not have a single module used as both addModu... [23:48:30] (03CR) 10Krinkle: [C: 032] Remove pointless commit() call [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/261789 (owner: 10Aaron Schulz) [23:49:23] (03Merged) 10jenkins-bot: Remove pointless commit() call [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/261789 (owner: 10Aaron Schulz) [23:52:25] (03CR) 10Krinkle: [WIP] Implement action=mergehistory (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261617 (https://phabricator.wikimedia.org/T69742) (owner: 10Sn1per) [23:52:43] (03CR) 10Krinkle: [C: 032] Use Maintenance DB transaction methods [extensions/Configure] - 10https://gerrit.wikimedia.org/r/261790 (owner: 10Aaron Schulz) [23:53:04] (03CR) 10Krinkle: [C: 032] Use Maintenance DB transaction methods [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261791 (owner: 10Aaron Schulz) [23:53:13] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/Configure] - 10https://gerrit.wikimedia.org/r/261790 (owner: 10Aaron Schulz) [23:53:56] (03CR) 10Krinkle: [C: 032] Use Maintenance DB transaction methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261788 (owner: 10Aaron Schulz) [23:57:49] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261791 (owner: 10Aaron Schulz) [23:57:51] (03Merged) 10jenkins-bot: Use Maintenance DB transaction methods [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261788 (owner: 10Aaron Schulz)