[00:08:10] 10WikiCon-Francophone-2016: Recherche d'un local à Bordeaux - https://phabricator.wikimedia.org/T121514#1905068 (10Pyb) Temps d'accès (avion/train/voiture) : Lille 1h20 / 5h00 / 7h00 Lyon 1h05 / 5h00 / 7h00 Marseille 1h05 / 6h00 / 6h00 Montpellier - 4h00 / 4h30 Nantes 0h50 / 4h00 / 4h00 Nice 1h15 / 6h30 / 6h30... [00:14:36] (03CR) 10Aaron Schulz: [C: 032] Fix APCOND_FR_UNIQUEPAGECOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261101 (owner: 10Umherirrender) [00:16:42] (03CR) 10Paladox: "I was testing weather updating would fix the timing out problem but it didn't." [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [00:18:07] (03Merged) 10jenkins-bot: Fix APCOND_FR_UNIQUEPAGECOUNT [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261101 (owner: 10Umherirrender) [00:25:22] (03PS9) 10Paladox: Update karma [core] - 10https://gerrit.wikimedia.org/r/261037 [00:29:48] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261034 (owner: 10Paladox) [00:31:23] 10WikiCon-Francophone-2016: Recherche d'un local à Bordeaux - https://phabricator.wikimedia.org/T121514#1905069 (10Pyb) [00:39:48] Hi! My name is Yago, and I'm participating on Google Code-In! [00:40:25] Welcome! [00:40:42] Thank you! [00:41:20] (03CR) 10Paladox: "Plus it would be using the latest version from grunt-karma since that pulls in the very latest." [core] - 10https://gerrit.wikimedia.org/r/261037 (owner: 10Paladox) [01:14:16] 10MediaWiki-Parser, 10MediaWiki-extensions-LabeledSectionTransclusion, 10MediaWiki-extensions-ProofreadPage, 10Cite, and 2 others: Ruffhead Statutes Transcription at Wikisource [tracking] - https://phabricator.wikimedia.org/T122340#1905072 (10ShakespeareFan00) [01:16:47] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1905073 (10josephine_l) [01:26:06] 10MediaWiki-extensions-Babel: Babel AutoCreate should check for duplicate categories - https://phabricator.wikimedia.org/T63994#1905075 (10Liuxinyu970226) [01:27:57] 10MediaWiki-extensions-Babel: Babel AutoCreate should not recreate deleted categories - https://phabricator.wikimedia.org/T63995#1905080 (10Liuxinyu970226) [01:47:45] 10MediaWiki-Internationalization: "Anglo-Saxon" to be rendered as Ænglisc - https://phabricator.wikimedia.org/T25283#1905083 (10Liuxinyu970226) [01:50:20] 10MediaWiki-Internationalization, 7Easy, 7I18n: Change name of Neapolitan language from "Nnapulitano" to "Napulitano" - https://phabricator.wikimedia.org/T45793#1905086 (10Liuxinyu970226) [01:50:50] 10MediaWiki-Internationalization: Incorrect native name for Ossetian language - https://phabricator.wikimedia.org/T31091#1905087 (10Liuxinyu970226) [01:52:43] 10MediaWiki-Internationalization, 7I18n: Add "Wikidata" grammar cases for Bosnian - https://phabricator.wikimedia.org/T118639#1905088 (10Liuxinyu970226) [01:53:22] WHY ARE YOU NULL EDITING [01:58:28] 10MediaWiki-extensions-Other: [IssueTracker] Implement issue change history - https://phabricator.wikimedia.org/T61665#1905105 (10Liuxinyu970226) [01:59:29] 10MediaWiki-extensions-WikiLexicalData-or-OmegaWiki: Notice: Undefined offset: X in /var/www/ow/extensions/WikiLexicalData/OmegaWiki/OmegaWikiRecordSets.php on line 232 - https://phabricator.wikimedia.org/T121972#1905107 (10Liuxinyu970226) [01:59:47] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1905109 (10josephine_l) [02:05:19] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1905112 (10josephine_l) [02:08:02] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1905114 (10josephine_l) [02:18:09] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1905127 (10josephine_l) [02:28:43] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1905129 (10josephine_l) [02:34:42] 4(no projects): Display Text - https://phabricator.wikimedia.org/T122466#1905130 (10Djcad2014) 3NEW [02:35:26] 7Mobile: Display Text - https://phabricator.wikimedia.org/T122466#1905136 (10Reedy) [02:36:32] 7Mobile, 5iOS-app-v5-production: Display Text - https://phabricator.wikimedia.org/T122466#1905138 (10Krenair) [02:36:40] 7Mobile, 5iOS-app-v5-production: Display Text - https://phabricator.wikimedia.org/T122466#1905140 (10Djcad2014) None [02:37:09] Krenair: app version 5 != ios 5 [02:37:23] (03PS5) 10Unicornisaurous: Add --rootpage parameter to importDump.php [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) [02:38:23] tto: I just submitted a new patchset which prints the error message from the status as requested. [02:41:48] (03CR) 10jenkins-bot: [V: 04-1] Add --rootpage parameter to importDump.php [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) (owner: 10Unicornisaurous) [02:42:24] unicornisaurous: Also a comment from me to come in a sec [02:43:01] tto: great [02:43:36] (03CR) 10TTO: [C: 04-1] "Works better now, thanks. Two minor things." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) (owner: 10Unicornisaurous) [02:44:25] (03PS6) 10Unicornisaurous: Add --rootpage parameter to importDump.php [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) [02:45:03] tto: Resubmitted in less than a minute 8) [02:48:15] tto: the return value doesn’t appear to be used though… [02:53:42] (03PS7) 10Unicornisaurous: Add --rootpage parameter to importDump.php [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) [02:54:15] (03CR) 10Unicornisaurous: "It makes more sense to return false since importer->doImport will return true if it succeeds, and in this case the operation did not succe" [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) (owner: 10Unicornisaurous) [03:12:31] (03CR) 10TTO: [C: 032] "Bewdy!" [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) (owner: 10Unicornisaurous) [03:12:35] unicornisaurous: It's poor form for a function to sometimes return a value, sometimes not. [03:14:40] tto: Sure, but I don’t see any reason that function needs to return _anything_ since the returned value is not used anywhere. I guess its convenient to see if the operation suceeded, but that currently isn’t used. [03:15:40] Yeah, I don't know what's with that. You don't have to spend much time working with our import code before you realise that it has been mostly unloved for 10 years or so [03:17:05] Theres a lot of code that could use some love [03:19:00] (03Merged) 10jenkins-bot: Add --rootpage parameter to importDump.php [core] - 10https://gerrit.wikimedia.org/r/261031 (https://phabricator.wikimedia.org/T72272) (owner: 10Unicornisaurous) [03:19:45] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts, 3Google-Code-In-2015, 5Patch-For-Review: importDump.php should have a parameter to add a prefix to the page titles of imported revisions - https://phabricator.wikimedia.org/T72272#1905148 (10Unicornisaurous) 5Open>3Resolved [03:20:06] unicornisaurous: If you see anything in https://phabricator.wikimedia.org/tag/mediawiki-export-or-import/ that you think would have a good GCI task, please let me know :) [03:20:11] Good work as always on this one [03:20:16] I'll go and mark it as complete now [03:21:35] tto: Great, thanks! [03:22:21] 10MediaWiki-extensions-LabeledSectionTransclusion, 6Wikisource: LST material transcluded cross-wiki does not load consistently - https://phabricator.wikimedia.org/T122196#1905150 (10Billinghurst) Does the transclusion work consistently or inconsistently at laWS? Then which way is inconsistent? laWS to enWS or... [03:28:57] 10MediaWiki-Export-or-Import, 3Google-Code-In-2015, 5Patch-For-Review: Export and import page content language - https://phabricator.wikimedia.org/T118114#1905152 (10TTO) a:3Georggi199 [03:34:47] tto: T91363 and T12568 look interesting. I’ve added myself as a subscriber to both, so if either end up becoming GCI tasks I’ll get emailed. [03:38:45] (03PS1) 10Sn1per: Refactor mobile.settings tests to work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261102 (https://phabricator.wikimedia.org/T106628) [03:40:42] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia, 7Easy: GWT - https://phabricator.wikimedia.org/T119053#1905162 (10Bawolff-alt) There's a bug in WikiChecks::increaseHTTPTimeout(). It increases the timeout incorrectly. As a result the wrong timeout is applied to gwtoolset. Thus... [03:52:06] Can someone tell me if this is claimed/deleted/or what? I was hoping to claim it but I can’t find it on GCI: T103715. Mentor URL: https://codein.withgoogle.com/dashboard/tasks/6256770984968192/ [03:52:19] Dang, gcibot can’t help me here [03:54:23] it's a seeeeecret [03:54:50] Apperantly… [03:54:50] (so it seems) [03:56:12] Probably somebody claimed it and just didn’t claim it on phabricator. I should have claimed it immediately after completing its blocking task, but for some reason I didn’t… [03:56:57] or maybe it's unpublished? [03:57:52] Possible…possible indeed. [03:58:15] …fancy ellipses you got there… [03:58:31] silly mac os x [03:58:44] I love my fancy ellipses… [04:02:14] (03PS2) 10Sn1per: Refactor mobile.settings tests to work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261102 (https://phabricator.wikimedia.org/T106628) [04:11:54] 4(no projects): "Desktop" link on Wikipedia Zero error page leads to mobile version - https://phabricator.wikimedia.org/T122467#1905169 (10APerson) 3NEW [04:12:05] how does one measure qunit test coverage for MobileFrontend? [04:13:46] unicornisaurous, sorry, I'm back [04:13:59] Did you figure out what was up with the task you posted the link to? [04:14:13] tto: No, I did not. Could you check for me? [04:14:36] "This task has not been published." [04:14:42] "NOTE: This task cannot be claimed or worked on until https://codein.withgoogle.com/dashboard/tasks/5656198728646656/ is resolved!" [04:15:18] I notice that that has already happened. [04:15:19] I think i did that [04:15:22] 10MediaWiki-extensions-ZeroPortal, 10MobileFrontend: "Desktop" link on Wikipedia Zero error page leads to mobile version - https://phabricator.wikimedia.org/T122467#1905175 (10Glaisher) [04:15:58] But I’m working on another for just a moment so don’t publish it yet or someone might steal it ;) [04:16:14] I can't publish tasks, only Andre, Nemo and Petr can do that [04:16:31] They're all in Europe, hence asleep now [04:17:04] Okay thats fine, I’ve got a commit all ready to submit to gerrit whenever it gets published. I’ll make a note on the phabricator task. [04:17:47] Feel free to send one of them an email if you like [04:18:04] Alright, I [04:18:08] might do that [04:23:37] 10MediaWiki-General-or-Unknown, 7Easy, 3Google-Code-In-2015, 7JavaScript: Support fragments in getUrl() of mw.Title - https://phabricator.wikimedia.org/T103715#1905177 (10Unicornisaurous) Since the blocking task was completed, could this task get published @Aklapper? Thanks. [04:24:24] is there any standard automated method of finding which functions need qunit tests? [04:34:36] OH-: There are some automated reports somewhere, I think. [04:34:39] Let me go and look for them [04:36:10] thanks. I read somewhere that karma could do it, but I have yet to successfully run it locally :P [04:37:47] OH-: It seems that the reports I was thinking of are PHPUnit reports, so not what you are looking for [04:38:47] ah, ok. thanks, I'll keep looking :) [04:41:44] OH-: We use "istanbul" for our JS code coverage, apparently. But the best place to ask is probably #wikimedia-releng channel. [04:43:13] got it, thanks again :) [05:03:59] (03CR) 10TTO: [C: 04-1] "This seems like it would work, and would certainly be an improvement over the status quo." [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [05:12:48] (03CR) 10MZMcBride: For source code pages, index page contents as `source_text` (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260903 (https://phabricator.wikimedia.org/T88247) (owner: 10Ori.livneh) [05:41:51] (03PS3) 10Legoktm: Add PLURAL support and "human readable" sizes for mediastatistics messages [core] - 10https://gerrit.wikimedia.org/r/260627 (owner: 10Florianschmidtwelzow) [05:41:57] (03CR) 10Legoktm: [C: 031] Add PLURAL support and "human readable" sizes for mediastatistics messages [core] - 10https://gerrit.wikimedia.org/r/260627 (owner: 10Florianschmidtwelzow) [05:42:47] (03CR) 10Legoktm: [C: 04-1] "Ehhh, I think sticking this in SkinTemplate is a bad idea. I don't have any alternatives off the top of my head right now, sorry." [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) (owner: 10Sn1per) [05:44:22] (03CR) 10Legoktm: [C: 032] Make sure docs encourage __METHOD__ use for begin/commit [core] - 10https://gerrit.wikimedia.org/r/260891 (owner: 10Aaron Schulz) [05:49:08] (03CR) 10Legoktm: [C: 032] Change multiple documentations in DairkiDiff [core] - 10https://gerrit.wikimedia.org/r/259954 (owner: 10AndyTechGuy) [05:49:38] 10MediaWiki-Templates: {{{{{blah}}}}} in a template should include the template whose name is the value of {{{blah}}} - https://phabricator.wikimedia.org/T2016#1905187 (10Liuxinyu970226) [05:51:06] 10Wikimedia-Bugzilla: Test - https://phabricator.wikimedia.org/T50000#1905190 (10Liuxinyu970226) [05:52:18] 10MediaWiki-Internationalization, 7I18n: Add adjective declension to ksh GRAMMAR - https://phabricator.wikimedia.org/T33751#1905192 (10Liuxinyu970226) [05:52:27] (03Merged) 10jenkins-bot: Make sure docs encourage __METHOD__ use for begin/commit [core] - 10https://gerrit.wikimedia.org/r/260891 (owner: 10Aaron Schulz) [05:56:56] (03Merged) 10jenkins-bot: Change multiple documentations in DairkiDiff [core] - 10https://gerrit.wikimedia.org/r/259954 (owner: 10AndyTechGuy) [06:09:49] 10MediaWiki-Configuration: load.php crashes when loading an extension.json within a symlinked directory (Windows) - https://phabricator.wikimedia.org/T117863#1905193 (10Liuxinyu970226) [06:10:28] 10MediaWiki-Configuration: SiteConfiguration->getConfig() serialization failures - https://phabricator.wikimedia.org/T121127#1905194 (10Liuxinyu970226) [06:10:40] 10MediaWiki-Configuration: convertExtensionToRegistration.php should automatically create a shim file - https://phabricator.wikimedia.org/T121141#1905195 (10Liuxinyu970226) [06:10:44] 10MediaWiki-Configuration: Support using a defined version in extension registration - https://phabricator.wikimedia.org/T121320#1905196 (10Liuxinyu970226) [06:11:07] (03PS2) 10Legoktm: installer should set CACHE_ACCEL as the default if available [core] - 10https://gerrit.wikimedia.org/r/248560 (https://phabricator.wikimedia.org/T49162) (owner: 10saper) [06:13:09] wtf are they doing [06:19:10] 10MediaWiki-General-or-Unknown, 7Easy, 5Patch-For-Review: Add link to protect log on action=info - https://phabricator.wikimedia.org/T52190#1905198 (10TTO) I would suggest to put the log link either in the heading, like so: ----- # Page protection ([[#|log]]) ----- or in a separate line beneath the table i... [06:19:12] (03CR) 10TTO: [C: 04-1] "I don't like the way this has been implemented. See the task." [core] - 10https://gerrit.wikimedia.org/r/138184 (https://bugzilla.wikimedia.org/50190) (owner: 10Gerrit Patch Uploader) [06:22:11] (03PS3) 10Legoktm: installer: Choose CACHE_ACCEL as the default if available [core] - 10https://gerrit.wikimedia.org/r/248560 (https://phabricator.wikimedia.org/T49162) (owner: 10saper) [06:22:39] (03Abandoned) 10Ed Hoo: [Cargo] Fix T120583: #cargo_query HOLDS check used in multi-value fields [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/257266 (https://phabricator.wikimedia.org/T120583) (owner: 10Ed Hoo) [06:23:19] (03CR) 10Legoktm: [C: 031] "PS3:" [core] - 10https://gerrit.wikimedia.org/r/248560 (https://phabricator.wikimedia.org/T49162) (owner: 10saper) [06:23:41] 10MediaWiki-extensions-Cargo, 5Patch-For-Review: #cargo_query HOLDS check is over inclusive - https://phabricator.wikimedia.org/T120583#1905200 (10EdHoo) 5Open>3Resolved Fixed by https://gerrit.wikimedia.org/r/#/c/258753/ https://gerrit.wikimedia.org/r/#/c/260531/ https://gerrit.wikimedia.org/r/#/c/260951/ [06:33:30] 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1905202 (10zhaofengli) 3NEW [06:33:46] 10MediaWiki-extensions-Cargo: #cargo_query use of DB_SLAVE does not account for replication lag - https://phabricator.wikimedia.org/T122469#1905210 (10EdHoo) 3NEW a:3EdHoo [06:34:15] 10MediaWiki-extensions-Cargo: Cargo use of DB_SLAVE does not account for replication lag - https://phabricator.wikimedia.org/T122469#1905218 (10EdHoo) [06:44:16] (03CR) 10Legoktm: [C: 032] Tweak wording for 'passwordreset-emailsentemail', 'passwordreset-emailsentusername' [core] - 10https://gerrit.wikimedia.org/r/259297 (owner: 10Bartosz Dziewoński) [06:46:27] 4(no projects): Mobile app edit icon giving wrong section - https://phabricator.wikimedia.org/T122471#1905229 (10PamD) 3NEW [06:51:35] (03Merged) 10jenkins-bot: Tweak wording for 'passwordreset-emailsentemail', 'passwordreset-emailsentusername' [core] - 10https://gerrit.wikimedia.org/r/259297 (owner: 10Bartosz Dziewoński) [06:56:42] (03PS1) 10Ed Hoo: Use of DB_MASTER in order to consider replication lag [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261105 (https://phabricator.wikimedia.org/T122469) [07:35:42] (03PS1) 10Ed Hoo: Use of DB_MASTER in order to consider replication lag [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261106 (https://phabricator.wikimedia.org/T122469) [07:37:14] (03Abandoned) 10Ed Hoo: Use of DB_MASTER in order to consider replication lag [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261106 (https://phabricator.wikimedia.org/T122469) (owner: 10Ed Hoo) [07:42:02] (03PS2) 10Ed Hoo: Use of DB_MASTER in order to consider replication lag [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261105 (https://phabricator.wikimedia.org/T122469) [07:45:31] (03PS3) 10Ed Hoo: Use of DB_MASTER in order to consider replication lag [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261105 (https://phabricator.wikimedia.org/T122469) [07:51:15] 10MobileFrontend: Mobile app edit icon giving wrong section - https://phabricator.wikimedia.org/T122471#1905246 (10TTO) [07:52:47] 10MobileFrontend: Mobile app edit icon giving wrong section - https://phabricator.wikimedia.org/T122471#1905229 (10TTO) Does this relate to the mobile **app** (e.g. Wikipedia iOS app), or to the mobile **website** (e.g. `en.m.wikipedia.org`)? [08:05:34] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1905252 (10Nemo_bis) I agree, `?curid=` is definitely the way to go. [08:05:52] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1905254 (10Nemo_bis) [08:05:54] 10MediaWiki-General-or-Unknown, 7I18n: [Short URLs] Safe permanent link to a page (e.g. using one of its history id) - https://phabricator.wikimedia.org/T23572#1905253 (10Nemo_bis) [08:14:34] Hi tto! [08:33:44] hello! [08:34:26] Georggi: victorbarbu_: Hello folks! [08:34:38] tto: how are you? [08:37:35] victorbarbu_: Not too bad thanks [08:42:12] that getPageLanguage() function returns Language object, if its not a langCode, how to get actual language code then? [08:45:29] 10MediaWiki-User-preferences: Place a password strength bar on en.wiki - https://phabricator.wikimedia.org/T32574#1905259 (10TTO) [08:45:30] 10Wikimedia-General-or-Unknown: Implement results of enwiki Security review RfC - https://phabricator.wikimedia.org/T121186#1905258 (10TTO) [08:46:33] Georggi: I think there is a function on the Language class that can help you. Take a look at Language.php in the languages folder and see if there is something useful [08:48:19] omg, what is this... $strongDirRegex its so long... [08:52:36] I think I found it.. [09:06:18] (03PS1) 10Victorbarbu: Autoload Composer's autoloader in Extension Registry [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) [09:06:45] (03PS2) 10Georggi199: Export: Added language to the export dumps [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) [09:06:52] tto ^^ [09:08:54] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [core] - 10https://gerrit.wikimedia.org/r/260627 (owner: 10Florianschmidtwelzow) [09:09:59] Georggi: Excellent, it looks a lot better! [09:10:21] I just need to check some technicalities around canonical/BCP 47 codes, which could take a little while [09:10:48] (03CR) 10Florianschmidtwelzow: "Just one thing after a short review." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [09:12:38] (03PS2) 10Victorbarbu: Autoload Composer's autoloader in Extension Registry [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) [09:22:17] 10MediaWiki-extensions-LabeledSectionTransclusion, 6Wikisource: LST material transcluded cross-wiki does not load consistently - https://phabricator.wikimedia.org/T122196#1905264 (10ShakespeareFan00) The current transclusion is in the la->ws to en->ws direction :) [09:29:10] 10MediaWiki-extensions-LabeledSectionTransclusion, 6Wikisource: LST material transcluded cross-wiki does not load consistently - https://phabricator.wikimedia.org/T122196#1905266 (10Billinghurst) well, try the other way to see if it is an issue. Will need to be done, and it pairs the works and gives informatio... [09:31:06] (03CR) 10Kunalgrover05: [C: 04-1] "Minor nitpicks." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [09:32:35] (03CR) 10TTO: [C: 04-1] Export: Added language to the export dumps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [09:34:25] (03PS1) 10Gilles: Make engine command-line based [thumbor/vips-engine] - 10https://gerrit.wikimedia.org/r/261108 (https://phabricator.wikimedia.org/T119184) [09:35:22] (03PS2) 10Gilles: Make engine subprocess-based [thumbor/vips-engine] - 10https://gerrit.wikimedia.org/r/261108 (https://phabricator.wikimedia.org/T119184) [09:44:13] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-12-01: [Task] Make client change handling scale by batching updates - https://phabricator.wikimedia.org/T107722#1905270 (10hoo) [09:46:17] 10MediaWiki-extensions-LabeledSectionTransclusion, 6Wikisource: LST material transcluded cross-wiki does not load consistently - https://phabricator.wikimedia.org/T122196#1905271 (10ShakespeareFan00) The two sandbox. https://la.wikisource.org/wiki/Usor:ShakespeareFan00/Sandbox https://en.wikisource.org/wiki... [10:01:33] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-WikibaseClient, 6Collaboration-Team-Backlog, 10Flow, 10Wikidata: mw.wikibase.getEntity(nil) returns an entity object on Flow page preview, but nil on page save - https://phabricator.wikimedia.org/T119735#1905272 (10hoo) I looked at this briefly and... [10:06:03] (03CR) 10Fomafix: "With https://gerrit.wikimedia.org/r/261033 I implemented a complete different solution." [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) (owner: 10Sn1per) [10:08:26] (03CR) 10Fomafix: Export: Added language to the export dumps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [10:10:27] (03CR) 10TTO: Export: Added language to the export dumps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [10:16:01] (03CR) 10Fomafix: Add format-bold-Iab image for lang ce (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [10:16:43] (03PS1) 10Gilles: Initial commit [thumbor/proxy-loader] - 10https://gerrit.wikimedia.org/r/261110 [10:16:57] (03CR) 10Gilles: [C: 032 V: 032] Initial commit [thumbor/proxy-loader] - 10https://gerrit.wikimedia.org/r/261110 (owner: 10Gilles) [10:17:56] Hallo. [10:19:14] (03PS1) 10Gilles: Proxy loader [thumbor/proxy-loader] - 10https://gerrit.wikimedia.org/r/261111 (https://phabricator.wikimedia.org/T120205) [10:20:44] (03PS1) 10Gilles: Iinitial commit [thumbor/video-loader] - 10https://gerrit.wikimedia.org/r/261112 [10:21:38] (03CR) 10Gilles: [C: 032 V: 032] Iinitial commit [thumbor/video-loader] - 10https://gerrit.wikimedia.org/r/261112 (owner: 10Gilles) [10:22:46] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Label of Wikidata item is not changed by rename of the source article - https://phabricator.wikimedia.org/T121978#1905288 (10hoo) p:5Triage>3Lowest [10:24:58] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Label of Wikidata item is not changed by rename of the source article - https://phabricator.wikimedia.org/T121978#1905293 (10hoo) This could be made optional by providing a check box during page moves. This is quite... [10:27:42] 10MediaWiki-Releasing: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#1905295 (10Nemo_bis) [10:27:45] 10MediaWiki-Installer, 6MediaWiki-Stakeholders-Group: Provide Amazon Web Services (AWS) image for ready-to-go MediaWiki - https://phabricator.wikimedia.org/T60896#1905294 (10Nemo_bis) [10:27:57] 10MediaWiki-Installer, 6MediaWiki-Stakeholders-Group: Provide Amazon Web Services (AWS) image for ready-to-go MediaWiki - https://phabricator.wikimedia.org/T60896#609616 (10Nemo_bis) [10:27:57] (03PS1) 10Gilles: Video loader [thumbor/video-loader] - 10https://gerrit.wikimedia.org/r/261113 (https://phabricator.wikimedia.org/T120205) [10:28:00] 10MediaWiki-Releasing, 10Architecture, 10Parsoid, 6Release-Engineering-Team, and 2 others: Evaluate and decide on a distribution strategy targeted at VMs - https://phabricator.wikimedia.org/T87774#1905296 (10Nemo_bis) [10:31:44] (03PS3) 10Georggi199: Export: Added language to the export dumps [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) [10:34:59] tto: https://gerrit.wikimedia.org/r/#/c/260961/ [10:43:20] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Problems with page_props on clients - https://phabricator.wikimedia.org/T119738#1905304 (10hoo) I can't reproduce these issues locally, might have been something failing a long time ago. Null editing the pages in question should fix the rows. Do you have an r... [10:48:44] (03CR) 10TTO: Export: Added language to the export dumps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [10:48:58] Georggi: ^ [10:49:33] (03CR) 10Fomafix: Export: Added language to the export dumps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [10:59:22] Georggi: Sorry for the confusion, I momentarily forgot about getHtmlCode! [10:59:31] whoops, he's not here [11:06:16] 10MediaWiki-Authentication-and-authorization: Incorrectly getting "You successfully removed your own rights. As such, you are no longer able to access this page." after promoting user to sysop and logging in as him - https://phabricator.wikimedia.org/T60492#1905307 (10Fomafix) a:3Fomafix [11:08:56] (03PS2) 10Gilles: Video loader [thumbor/video-loader] - 10https://gerrit.wikimedia.org/r/261113 (https://phabricator.wikimedia.org/T120205) [11:14:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Forward to mobile if visiting Special:GoToLinkedPage in mobile mode - https://phabricator.wikimedia.org/T115805#1905327 (10hoo) 5Open>3Invalid a:3hoo Per above. [11:23:31] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-WikibaseClient, 6Collaboration-Team-Backlog, 10Flow, 10Wikidata: mw.wikibase.getEntity(nil) returns an entity object on Flow page preview, but nil on page save - https://phabricator.wikimedia.org/T119735#1905332 (10MrStradivarius) >>! In T119735#19... [11:29:50] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 6operations: Make the command `sql wikishared` work on terbium like `sql enwiki`, `sql centralauth`, etc. - https://phabricator.wikimedia.org/T122474#1905337 (10Amire80) 3NEW [11:35:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Problems with page_props on clients - https://phabricator.wikimedia.org/T119738#1905351 (10matej_suchanek) Both cases can indeed be fixed by doing a null edit. For the issue, the most recent case would be https://cs.wikipedia.org/w/index.php?title=Mistr_Kloste... [11:39:48] (03PS4) 10Georggi199: Export: Added language to the export dumps [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) [11:40:13] tto: check it? [11:41:49] Georggi: sure [11:46:38] (03PS3) 10Victorbarbu: Autoload Composer's autoloader in Extension Registry [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) [11:48:18] legoktm: hi! could you, please, review my patch here https://gerrit.wikimedia.org/r/#/c/261107/ ? [11:54:59] victorbarbu_: It's 4am in legoktm's time zone :) [11:57:21] 6Developer-Relations, 3Google-Code-In-2015: Sort out places for MediaWiki and Wikimedia tech presentations - https://phabricator.wikimedia.org/T85593#1905352 (10husn_shujaat) @Aklapper :) Okay, but don't I have to do more, like link in the pages/files? [11:57:44] (03CR) 10Paladox: "Thanks for working on this." [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [11:59:48] 10Wikimedia-Site-Requests: Three changes to Wuu Wikipedia - https://phabricator.wikimedia.org/T122476#1905353 (10Lantern) 3NEW [12:00:34] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [12:05:30] (03CR) 10TTO: "Georggi: I have discovered some problems here. What I am going to do is:" [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [12:05:41] (03CR) 10TTO: [C: 04-2] Export: Added language to the export dumps [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [12:08:08] tto, I guess it is harder than you was expecting? [12:08:17] Georggi: Yes it is [12:08:47] You see, the getPageLanguage function was written years before $wgPageLanguageUseDB was added [12:09:05] The support for $wgPageLanguageUseDB was just hacked in, and not very well, if you ask me [12:09:27] Georggi: Your code and research on the task isn't going to waste though, I will continue to use it :) [12:11:02] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 6operations: Make the command `sql wikishared` work on terbium like `sql enwiki`, `sql centralauth`, etc. - https://phabricator.wikimedia.org/T122474#1905369 (10KartikMistry) Try and see if --wikidb=wikishared works? [12:12:49] Aha, well, let me at least look on what you will change:) [12:14:01] 10MediaWiki-Export-or-Import, 3Google-Code-In-2015, 5Patch-For-Review: Export and import page content language - https://phabricator.wikimedia.org/T118114#1905370 (10TTO) a:5Georggi199>3TTO [12:17:52] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 6operations: Make the command `sql wikishared` work on terbium like `sql enwiki`, `sql centralauth`, etc. - https://phabricator.wikimedia.org/T122474#1905372 (10Amire80) >>! In T122474#1905369, @KartikMistry wrote: > Try and see if --wikidb=wikishared w... [12:43:50] 4(no projects): Denik.cz new zotero translator - https://phabricator.wikimedia.org/T122478#1905374 (10Frettie) 3NEW [12:44:32] (03PS1) 10Frettie: new denik.cz translator [services/zotero/translators] - 10https://gerrit.wikimedia.org/r/261115 (https://phabricator.wikimedia.org/T122478) [12:45:33] 10MediaWiki-extensions-WikimediaMessages, 6Community-Advocacy, 6Stewards-and-global-tools, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Provide a way to report local hideuser blocks for global CentralAuth oversight - https://phabricator.wikimedia.org/T121639#1905383 (10Glaisher) @MarcoAurel... [12:52:12] 10MediaWiki-Export-or-Import, 7Easy, 3Google-Code-In-2015: Add canonical namespaces and aliases to XML dumps - https://phabricator.wikimedia.org/T64109#1905387 (10Nemo_bis) > And what about interwiki links? Would you assume that [[commons:Foo]] would be also a page in the main namespace? WikiTeam always sav... [13:02:33] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 10ContentTranslation-Analytics, 6operations: schedule a daily run of ContentTranslation analytics scripts on terbium - https://phabricator.wikimedia.org/T122479#1905388 (10Amire80) 3NEW [13:05:18] 10MediaWiki-Export-or-Import: Special:Export changes Project namespace prefix to SITENAME - https://phabricator.wikimedia.org/T42010#1905396 (10TTO) 5Open>3Resolved a:3TTO The underlying issue here was fixed in 1.25 or 1.26 (Wiki1:About would now be imported to Wiki2:About as expected). As far as I can see... [13:24:03] (03PS1) 10Gilles: Purge should always be attempted [thumbor/purger] - 10https://gerrit.wikimedia.org/r/261117 [13:29:23] (03PS1) 10Umherirrender: Remove APCOND_FR_NEVERDEMOTED [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261118 [14:02:49] (03PS3) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [14:13:37] 10MediaWiki-Export-or-Import, 7Easy, 3Google-Code-In-2015: Add canonical namespaces and aliases to XML dumps - https://phabricator.wikimedia.org/T64109#1905401 (10TTO) Note that the GCI task only relates to namespace aliases. As for the namespaces themselves, I'd like to know what information should be prov... [14:14:00] Nemo_bis: Could you please publish https://codein.withgoogle.com/dashboard/tasks/4814568354217984/ ? [14:18:54] (03CR) 10TTO: [C: 032] "Great work! I'm not sure I would have been able to write such a nice test myself, to be honest :)" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [14:20:11] (03CR) 10TTO: [C: 04-2] "Whoops! I can't approve this yet. You need to clean up the line breaks in the code." [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [14:21:42] (03CR) 10TTO: Added a simple smoke test for export (036 comments) [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [14:25:31] tto: done, thanks [14:26:04] 10MediaWiki-Export-or-Import, 3Google-Code-In-2015: dumpBackup.php: offer option to use 7za -mx=4 instead of -mx=5 - https://phabricator.wikimedia.org/T78669#1905402 (10Nemo_bis) [14:26:34] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [14:28:09] I see unicornisaurus is doing all the archive-y things I like :D https://phabricator.wikimedia.org/T56551#1905182 [15:03:25] (03CR) 10Yaron Koren: [C: 032 V: 031] "Thank you, this looks good! This also clears up the incorrect naming that was in the code before ($dbr instead of $dbw)." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261105 (https://phabricator.wikimedia.org/T122469) (owner: 10Ed Hoo) [15:04:19] (03Merged) 10jenkins-bot: Use of DB_MASTER in order to consider replication lag [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/261105 (https://phabricator.wikimedia.org/T122469) (owner: 10Ed Hoo) [15:21:20] 10MediaWiki-File-management, 6Commons, 6Multimedia, 10Structured-Multimedia-Data, 10Wikidata: Provide a way to curate and fetch titles (short descriptions) for media files - https://phabricator.wikimedia.org/T122381#1905406 (10Lydia_Pintscher) This is pretty much one of the things structured data for Com... [16:00:00] 4(no projects): MWException from line 111 of /srv/mediawiki/w/includes/page/WikiPage.php: Invalid or virtual namespace -1 given - https://phabricator.wikimedia.org/T122480#1905407 (10Reception123) 3NEW [16:04:17] 10MediaWiki-extensions-LiquidThreads: MWException from line 111 of /srv/mediawiki/w/includes/page/WikiPage.php: Invalid or virtual namespace -1 given - https://phabricator.wikimedia.org/T122480#1905414 (10Glaisher) [16:10:31] 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-SpamBlacklist: MWException from line 111 of /srv/mediawiki/w/includes/page/WikiPage.php: Invalid or virtual namespace -1 given - https://phabricator.wikimedia.org/T122480#1905417 (10Ciencia_Al_Poder) This comes from [[ https://www.mediawiki.org/wiki/... [16:24:24] 4(no projects): DBperformance issues - https://phabricator.wikimedia.org/T122482#1905427 (10Reception123) 3NEW [16:24:51] 7Community-Wishlist-Survey: Automatic numbering of pictures - https://phabricator.wikimedia.org/T120744#1905434 (10Debenben) see also T7600 [16:46:19] (03PS1) 10Gerrit Patch Uploader: SpecialUserrights: Use cookie instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) [16:46:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261121 (https://phabricator.wikimedia.org/T60492) (owner: 10Gerrit Patch Uploader) [16:49:30] grunt qunit:cov tells me that PhantomJS timed out. Is this an issue with my vagrant being too slow or did I screw up some config? [16:52:09] 10MediaWiki-Export-or-Import, 7Easy, 3Google-Code-In-2015: Add canonical namespaces and aliases to XML dumps - https://phabricator.wikimedia.org/T64109#1905439 (10Nemo_bis) > Actually, from the perspective of a dump, the canonical name is surely just another alias. Could we just include it in the list of nam... [17:00:45] huh, phantomjs wasn't installed even though I could've sworn it was. [17:02:47] welp, that didn't work either [17:04:09] 7Design, 10Math, 5Patch-For-Review: Provide an "indented display" styling for formulæ in lieu of the ":" hack - https://phabricator.wikimedia.org/T111712#1905440 (10Debenben) I totally agree with Physikerwelt. However: * If the long term goal is to replace the : syntax, then the new semantics has... [17:18:32] 7Design, 10Math, 5Patch-For-Review: Provide an "indented display" styling for formulæ in lieu of the ":" hack - https://phabricator.wikimedia.org/T111712#1905444 (10Physikerwelt) >>! In T111712#1905440, @Debenben wrote: > I totally agree with Physikerwelt. However: > * If the long term goal is to repla... [17:26:33] ohhhhhhhh grunt-qunit-istanbul was not installed [17:30:12] why wasn't that installed with `npm install` ? 〳 ◔ Ĺ̯ ◔ 〵 [17:30:45] Now I get "ReferenceError: Can't find variable: QUnit" [17:47:01] 10Gerrit: Project access history links broken - https://phabricator.wikimedia.org/T120658#1905447 (10Paladox) This is a know problem in diffusion on Wikipedia since there's a problem replicating any thing from refs/meta and refs/changes [17:49:39] (03PS1) 10Umherirrender: Remove various double empty newlines [core] - 10https://gerrit.wikimedia.org/r/261122 [17:49:58] 10Gerrit, 10Phabricator-Upstream: Provide a Github-like web editor to make small edits to code - https://phabricator.wikimedia.org/T116246#1905449 (10Paladox) Could this be changed to stalled since territory 2.12 includes this so unless we update that would not be available. [17:52:57] 10Gerrit: Upgrade gerrit to 2.12 - https://phabricator.wikimedia.org/T70271#1905450 (10Paladox) Gerrit 2.12 includes support for signed pushes now which some users on Wikipedia use. Release notes at https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.12.html [17:53:23] 10Gerrit: Upgrade gerrit to 2.12 - https://phabricator.wikimedia.org/T70271#1905451 (10Paladox) [17:54:28] 7Design, 10Math, 5Patch-For-Review: Provide an "indented display" styling for formulæ in lieu of the ":" hack - https://phabricator.wikimedia.org/T111712#1905452 (10Debenben) >>! In T111712#1905444, @Physikerwelt wrote: >>>! In T111712#1905440, @Debenben wrote: >> I totally agree with Physikerwelt.... [17:55:43] 10MediaWiki-Logging: Allow regex or advanced search in Special:Log - https://phabricator.wikimedia.org/T122483#1905453 (10XXN) 3NEW [17:59:17] looks like my vagrant is too slow to load QUnit before Istanbul fires up [18:00:59] (03PS4) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [18:02:24] (03CR) 10Mhutti1: "I don't understand why zend failed?" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [18:05:58] (03PS5) 10Gerrit Patch Uploader: Preferences: Use cookie instead of URL parameter for success [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) [18:06:00] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/261033 (https://phabricator.wikimedia.org/T26700) (owner: 10Gerrit Patch Uploader) [18:07:47] 10MediaWiki-Parser, 10Wikidata, 10Wikidata-Page-Banner: Banners fail to show up occassionally on Russian Wikivoyage - https://phabricator.wikimedia.org/T121135#1905463 (10Wrh2) Yes, this problem occurs regularly on English Wikivoyage. Forcing an update to https://en.wikivoyage.org/wiki/Template:Pagebanner t... [18:09:23] 10MediaWiki-Parser, 10Wikidata, 10Wikidata-Page-Banner: Banners fail to show up occassionally on Russian Wikivoyage - https://phabricator.wikimedia.org/T121135#1905464 (10Wrh2) Just to clarify (since it seems there may be some confusion), the problem on both Russian and English Wikivoyage isn't that the bann... [18:14:54] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [18:35:59] (03CR) 10Umherirrender: [C: 032] "Resubmit to give jenkins another chance" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260947 (owner: 10Smalyshev) [18:37:21] (03Abandoned) 10Umherirrender: Use Article::fetchContent instead of loadContent [extensions/Offline] - 10https://gerrit.wikimedia.org/r/257346 (owner: 10Addshore) [18:40:53] (03Merged) 10jenkins-bot: Fix gen-autoload.php which I messed up. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260947 (owner: 10Smalyshev) [18:49:21] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1905465 (10Krenair) >>! In T122423#1904508, @Aklapper wrote: >>>! In T122423#1904317, @Krenair wrote: >> It also needs to be documented at {T103700}. > > We should exclude Wikimedia chapter projects... [18:55:15] (03PS2) 10Florianschmidtwelzow: Remove various double empty newlines [core] - 10https://gerrit.wikimedia.org/r/261122 (owner: 10Umherirrender) [18:55:32] (03CR) 10Florianschmidtwelzow: [C: 032] "Couldn't this be checked by phplint, too? :)" [core] - 10https://gerrit.wikimedia.org/r/261122 (owner: 10Umherirrender) [18:58:44] (03PS5) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [18:59:11] (03CR) 10Mhutti1: "zend check" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [18:59:44] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [19:04:35] (03Merged) 10jenkins-bot: Remove various double empty newlines [core] - 10https://gerrit.wikimedia.org/r/261122 (owner: 10Umherirrender) [19:11:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Some things :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [19:15:41] If anyone's interested, this is the output of `grunt qunit:cov --debug`: https://dpaste.de/ujdb [19:30:02] (03PS6) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [19:30:22] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [19:32:46] 10MobileFrontend: Nearby doesn't work with umlauts as page title - https://phabricator.wikimedia.org/T122484#1905471 (10Florian) 3NEW a:3Florian [19:35:18] Maybe if I use vagrant on windows something will magically work :3 [19:35:56] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [19:38:41] (03PS1) 10Florianschmidtwelzow: Fix url decoding in Nearby's #/page/ feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261157 (https://phabricator.wikimedia.org/T122484) [19:41:24] 10MediaWiki-extension-requests, 10Graph: Need a webpage to produce Pie chart according to Graphic Lab's recommendations - https://phabricator.wikimedia.org/T14603#1905483 (10Yurik) So now that we have [[ https://en.wikipedia.org/wiki/Template:Graph:PieChart | PieChart ]], should we close this task? P.S. Pleas... [19:41:37] (03PS7) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [19:42:03] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [19:44:13] (03CR) 10Reedy: [C: 032] Fix "Undefined property: DiffEngine::$seq" under HHVM in DairikiDiff.php [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/260962 (https://phabricator.wikimedia.org/T116266) (owner: 10Nemo bis) [19:45:36] (03PS2) 10Reedy: PostgreSQL: Add quotes to timestamp [core] - 10https://gerrit.wikimedia.org/r/259636 (https://phabricator.wikimedia.org/T121743) (owner: 10Jjanes) [19:45:42] (03CR) 10Reedy: [C: 032] PostgreSQL: Add quotes to timestamp [core] - 10https://gerrit.wikimedia.org/r/259636 (https://phabricator.wikimedia.org/T121743) (owner: 10Jjanes) [19:47:09] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [19:47:53] (03CR) 10Reedy: "Be nice if we could just have this and make it non voting..." [core] - 10https://gerrit.wikimedia.org/r/260598 (owner: 10Anomie) [19:48:03] (03PS3) 10Reedy: Add missing API i18n messages [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/260399 (owner: 10Anomie) [19:48:12] (03CR) 10Reedy: [C: 032] "Try again, Jenkins" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/260399 (owner: 10Anomie) [19:50:20] (03CR) 10Reedy: [C: 04-1] Better error handling for HTMLForm (032 comments) [core] - 10https://gerrit.wikimedia.org/r/260582 (owner: 10MarkAHershberger) [19:50:56] (03CR) 10jenkins-bot: [V: 04-1] Fix url decoding in Nearby's #/page/ feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261157 (https://phabricator.wikimedia.org/T122484) (owner: 10Florianschmidtwelzow) [19:52:15] (03Merged) 10jenkins-bot: Fix "Undefined property: DiffEngine::$seq" under HHVM in DairikiDiff.php [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/260962 (https://phabricator.wikimedia.org/T116266) (owner: 10Nemo bis) [19:57:02] (03PS8) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [19:57:19] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [19:58:24] (03PS2) 10Reedy: Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 (owner: 10Aaron Schulz) [19:58:29] (03CR) 10Reedy: [C: 032] Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 (owner: 10Aaron Schulz) [19:59:30] (03Merged) 10jenkins-bot: PostgreSQL: Add quotes to timestamp [core] - 10https://gerrit.wikimedia.org/r/259636 (https://phabricator.wikimedia.org/T121743) (owner: 10Jjanes) [20:00:12] (03PS1) 10Florianschmidtwelzow: Add error handler for Nearby page search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261158 [20:00:20] (03PS2) 10Reedy: Remove pointless wfSuppressWarnings() call [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261028 (owner: 10Aaron Schulz) [20:00:24] (03CR) 10Reedy: [C: 032] Remove pointless wfSuppressWarnings() call [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261028 (owner: 10Aaron Schulz) [20:00:31] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261157 (https://phabricator.wikimedia.org/T122484) (owner: 10Florianschmidtwelzow) [20:01:22] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:01:48] (03CR) 10Reedy: [C: 032] Remove pointless begin/commit calls [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/260486 (owner: 10Aaron Schulz) [20:05:00] (03Merged) 10jenkins-bot: Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 (owner: 10Aaron Schulz) [20:05:03] (03Merged) 10jenkins-bot: Remove pointless wfSuppressWarnings() call [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261028 (owner: 10Aaron Schulz) [20:05:06] (03Merged) 10jenkins-bot: Remove pointless begin/commit calls [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/260486 (owner: 10Aaron Schulz) [20:08:38] (03CR) 10Umherirrender: "The php part of this patch set could be detected by phpcs, see T120570" [core] - 10https://gerrit.wikimedia.org/r/261122 (owner: 10Umherirrender) [20:08:59] welp, windows couldn't even get vagrant to work [20:09:30] 10MediaWiki-Codesniffer: Add sniff to detect double empty lines in php code - https://phabricator.wikimedia.org/T120570#1905489 (10Umherirrender) See https://gerrit.wikimedia.org/r/#/c/261122/ for various double empty lines (just look at the php files) [20:09:51] not uncommon :) [20:10:34] (03CR) 10jenkins-bot: [V: 04-1] Add error handler for Nearby page search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261158 (owner: 10Florianschmidtwelzow) [20:11:40] anyone know how to fix a grunt phantomjs timeout for MobileFrontend? :P [20:13:58] derp-a-derp turns out it's https://phabricator.wikimedia.org/T112568 [20:17:31] 10MediaWiki-Unit-tests: Support phpunit-old.phar - https://phabricator.wikimedia.org/T122485#1905491 (10Reedy) 3NEW [20:20:27] 10MobileFrontend, 3Google-Code-In-2015: Write tests for modules that are in stable and have low code coverage - https://phabricator.wikimedia.org/T103440#1905498 (10Sn1per) a:5Sn1per>3None Requires T112568 to be unblocked first [20:22:14] (03PS1) 10Reedy: Support phpunit-old.phar [core] - 10https://gerrit.wikimedia.org/r/261159 (https://phabricator.wikimedia.org/T122485) [20:23:39] FlorianSW: ^ Any chance you could review that? :D [20:24:14] Reedy: sure, give me a second :P [20:24:32] stream_resolve_include_path returns false if it can't find it [20:24:38] just to save you looking it up [20:24:39] xD [20:25:18] Actually [20:25:20] Minor improvement to that [20:26:13] (03PS2) 10Reedy: Support phpunit-old.phar [core] - 10https://gerrit.wikimedia.org/r/261159 (https://phabricator.wikimedia.org/T122485) [20:26:27] (03CR) 10Florianschmidtwelzow: [C: 032] Support phpunit-old.phar [core] - 10https://gerrit.wikimedia.org/r/261159 (https://phabricator.wikimedia.org/T122485) (owner: 10Reedy) [20:26:52] ty :D [20:27:14] Reedy: I haven't reviewed your check to === false :D [20:27:26] heh [20:27:32] Just seems pointless trying to include false [20:27:33] But looks great, that would make the @include_once unneded, you can use include_once, directly? [20:28:22] 10MediaWiki-Unit-tests: Support phpunit-old.phar - https://phabricator.wikimedia.org/T122485#1905507 (10Florian) 5Open>3Resolved p:5Triage>3Normal a:3Reedy [20:28:25] PHPUnit/Runner/Version.php doesn't exist either [20:28:34] uh, that can be a string, but still not exist either [20:28:56] not sure why we don't file_exists [20:29:04] Overheads? [20:29:58] hmm, I think it would make sense to check if the file exists, if an error message/debug message get's logged, but this doesn't seem to be very useful at all. [20:30:15] maybe that's why just trying to include was the choosed way :D [20:30:27] and @ [20:30:28] lol [20:30:32] sure :P [20:30:43] Shouldn't we be using.. [20:31:11] mediawiki/at-ease and suppressWarnings [20:31:12] Meh [20:31:22] load vendor to run unit tests? lololol [20:31:51] it needs to be loaded anyway, otherwise it would fatal in the code where libs are used? [20:32:20] Dunno if it'll be done so early in the process [20:32:25] (03Merged) 10jenkins-bot: Support phpunit-old.phar [core] - 10https://gerrit.wikimedia.org/r/261159 (https://phabricator.wikimedia.org/T122485) (owner: 10Reedy) [20:32:30] Isn't this done in Maintenance.php? [20:33:03] doMaintenace.php [20:33:13] So, I guess we could [20:33:47] (03PS9) 10Reedy: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:36:06] hello! how do I display a fatal error? what's the function? [20:36:47] (03PS1) 10Florianschmidtwelzow: Use wikimedia/at-ease insteaad of @ [core] - 10https://gerrit.wikimedia.org/r/261160 [20:36:50] Reedy: ^ [20:36:53] tested and works [20:37:07] victorbarbu_: throw new Exception(); [20:37:08] ??? [20:37:20] but why you want to do this? [20:37:34] because that's what you said [20:37:42] either a debug message or a fatal [20:37:51] and a fatal is easier to see [20:37:54] I think [20:38:12] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:38:39] FlorianSW: is there anything special about writing debug messages? [20:38:48] can I simply say "file does not exist"? [20:38:57] victorbarbu_: uhh, sorry, doesn't mentioned, that you respond to a comment of me :P [20:39:49] victorbarbu_: you should maybe be more specific, something like: "Extension {$extName} requested to load composer autoloader, which does not exist. Did you forget to run 'composer update'?" [20:40:24] FlorianSW: oh, I get it [20:41:00] 10Phabricator-Sprint-Extension: Add task/edit task not functional from sprint workboard - https://phabricator.wikimedia.org/T122486#1905513 (10manaschaudhari) 3NEW [20:41:17] (03CR) 10Reedy: [C: 032] Use wikimedia/at-ease insteaad of @ [core] - 10https://gerrit.wikimedia.org/r/261160 (owner: 10Florianschmidtwelzow) [20:41:36] andre__: hello! [20:43:15] 10MediaWiki-Redirects, 5MW-1.23-release, 5MW-1.25-release, 5MW-1.26-release, 5Patch-For-Review: Special:MyPage, Special:MyTalk, and Special:MyContributions return fatal error - https://phabricator.wikimedia.org/T121892#1905521 (10Porplemontage) I applied the proposed 1.23.13 changes and I'm still seeing... [20:43:19] ty Reedy :) [20:43:27] Was just waiting for jenkins ;) [20:44:25] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:44:42] (03CR) 10Umherirrender: Use wikimedia/at-ease insteaad of @ (032 comments) [core] - 10https://gerrit.wikimedia.org/r/261160 (owner: 10Florianschmidtwelzow) [20:45:01] (03PS1) 10Umherirrender: Copy in release notes for last maintenance releases into HISTORY [core] - 10https://gerrit.wikimedia.org/r/261161 [20:45:46] (03CR) 10Reedy: [C: 04-1] "Hmm, -1 per CR" [core] - 10https://gerrit.wikimedia.org/r/261160 (owner: 10Florianschmidtwelzow) [20:46:06] Was the codingstandardsignore for the @ or random include? [20:46:53] hmm, seems so [20:47:59] (03PS4) 10Victorbarbu: Autoload Composer's autoloader in Extension Registry [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) [20:48:11] (03PS2) 10Reedy: Copy in release notes for last maintenance releases into HISTORY [core] - 10https://gerrit.wikimedia.org/r/261161 (owner: 10Umherirrender) [20:48:18] (03CR) 10Reedy: [C: 032] Copy in release notes for last maintenance releases into HISTORY [core] - 10https://gerrit.wikimedia.org/r/261161 (owner: 10Umherirrender) [20:48:30] will it work if I comment "recheck" on my patch? [20:48:52] Will what work? [20:49:07] if you're whitelisted it'll rerun tests [20:49:39] (03PS10) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [20:50:05] (03CR) 10Paladox: [C: 031] "Havent't tested but code looks good." [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [20:50:25] It doesn't look like you're whitelisted at the momenth [20:50:36] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:51:23] (03PS2) 10Florianschmidtwelzow: Use wikimedia/at-ease insteaad of @ [core] - 10https://gerrit.wikimedia.org/r/261160 [20:51:35] Reedy: ^ :) [20:52:38] (03CR) 10Reedy: [C: 032] Use wikimedia/at-ease insteaad of @ [core] - 10https://gerrit.wikimedia.org/r/261160 (owner: 10Florianschmidtwelzow) [20:52:42] FlorianSW: [20:52:55] ? [20:54:30] someone made a solarized dark theme for IRCcloud :o :o :o [20:54:30] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905522 (10Porplemontage) 3NEW [20:54:36] (03PS12) 10Paladox: Add format-bold-Iab image for lang ce [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [20:54:50] FlorianSW: I think victorbarbu_ needs jenkins whitelisting [20:55:21] If you're good, yeah, just to check my code [20:55:43] (03CR) 10Sn1per: "recheck" [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [20:56:04] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905530 (10Reedy) Got a line number etc? Also, what PHP version? [20:58:20] (03PS1) 10Umherirrender: Replace \r\n with \n in resources\src\mediawiki\bookletlayout\*.svg [core] - 10https://gerrit.wikimedia.org/r/261162 [20:58:29] (03CR) 10Reedy: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:58:47] (03Merged) 10jenkins-bot: Copy in release notes for last maintenance releases into HISTORY [core] - 10https://gerrit.wikimedia.org/r/261161 (owner: 10Umherirrender) [20:59:23] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 10ContentTranslation-Analytics, 6operations: schedule a daily run of ContentTranslation analytics scripts on terbium - https://phabricator.wikimedia.org/T122479#1905531 (10yuvipanda) This should probably run on one of the stat* boxes rather than terbium. [20:59:27] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905532 (10Porplemontage) Oops, I missed copying the line number. It's 136. Warning: hash_equals(): Expected user_string to be a string, NULL given in /includes/GlobalFunctions.php... [21:00:29] (03Merged) 10jenkins-bot: Use wikimedia/at-ease insteaad of @ [core] - 10https://gerrit.wikimedia.org/r/261160 (owner: 10Florianschmidtwelzow) [21:01:49] (03PS2) 10Umherirrender: Replace \r\n with \n in resources\src\mediawiki\bookletlayout\*.svg [core] - 10https://gerrit.wikimedia.org/r/261162 [21:04:22] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905535 (10Porplemontage) I found that the issue was caused by this change: https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/ad1fdc3b216daa3d3e88ecd47fcd7f604853da4b Undo... [21:05:05] OH-: in general, the basic tests should be enough or is there a special reason to run the full test suite victorbarbu_ ? :) [21:06:14] eh, the other GCI students are whitelisted, so why not? :P (https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L421) [21:11:26] Being able to run the full test suites is nice, since it means you don’t have to wait for someone to give it a recheck. But it’s even better if you can run all the tests on your development machine before submitting to gerrit [21:13:30] unicornisaurous: maybe, but requires a lot of setup etc. I set up part of the tests but it's still hard for me to set all the others. And, as you said, it's great to be able to test my work without waiting for someone [21:15:40] FlorianSW: sorry to bother, but could you, please, review my work and see if it fits my GCI task? I would like to pick another one [21:17:22] If you really really want another task [21:17:29] I encourage you to check out some open bugs tagged 'easy' [21:17:41] https://phabricator.wikimedia.org/maniphest/query/gAIUVhikQEuC/ [21:17:53] technically not a GCI task but still fun to do [21:18:04] 10MediaWiki-extensions-ContentTranslation, 10Analytics, 10ContentTranslation-Analytics, 6operations: schedule a daily run of ContentTranslation analytics scripts on terbium - https://phabricator.wikimedia.org/T122479#1905536 (10Amire80) Whatever works, as long as I get the data :) [21:18:38] you could find a task you like and start working on it, and hope nobody claims it before you get done with your current one. Then once your current one is accepted you could immediately submit work for the next one. [21:19:13] Code review isn’t usually very quick [21:20:51] 10Phabricator-Sprint-Extension: Add task/edit task not functional from sprint workboard - https://phabricator.wikimedia.org/T122486#1905541 (10Luke081515) I tried to reproduce it here: https://phabricator.wikimedia.org/project/sprint/board/1384/ Works here. [21:21:27] (03CR) 10Florianschmidtwelzow: [C: 04-1] "one minor thing." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [21:23:00] FlorianSW: Don't suppose you're familiar with simplexml by any chance? [21:23:28] unicornisaurous: "hope", yeah [21:23:37] hi victorbarbu_! [21:23:48] andre__: how are you? [21:23:54] Reedy: unfortunately, not really, no :( I remember that I worked one or two times with it, but that'S far away from say "I'm familar" :P [21:24:00] heh [21:24:03] victorbarbu_, fine but a bit tired - just came back from travelling :) [21:27:22] "Code review isn’t usually very quick" if we think about the scope of this task (code-review), I'm pretty sure, you know why. First of all: Some reviewers, who theoretically could submit a change, do the work in the spare time, not as a full 8-hours job. Secondly: Code-review is an important thing, which is a gate between code and (theoretically) a big number of really big sites. Code-Reviewers are one gateway, which sort [21:27:22] s "good" code and "bad" code. This means, that any +2 a reviewer give is a kind of "yes, this code is good to work, performant and doesn't open security problems", any of these criteria is really important and a big deal in software development. So please, give reviewers the time they need to be sure, that a change earns a +2, or not and give you a change to make it better. The 36 hours aren't just for fun. Any try to get a [21:27:23] faster review could potentially result in a "Ok, I stop revieweing here and start again next day" :D [21:27:53] Reedy: but maybe, if you ask a question I (or any other person) can help :P [21:27:59] (03PS5) 10Victorbarbu: Autoload Composer's autoloader in Extension Registry [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) [21:27:59] Anyone know how to get an element called namespace out of phps SimpleXMLElement? [21:28:03] Works in newer PHP, but 5.3 fails [21:28:16] FlorianSW: fixed that comma [21:28:17] $xmlObject->siteinfo->namespaces->namespace [21:29:41] I think you mean: https://gerrit.wikimedia.org/r/#/c/260968/ ? :D I tried to find that out, too, but... yeah... no luck so far :/ [21:30:04] I thought something like ->{'namespace'} might work [21:30:32] I'm tempted to just do a str_replace or something :P [21:30:39] FlorianSW: I never said I didn’t think code review was important ;) [21:31:04] Reedy: would it work, if you cast $xmlObject->siteinfo to an array and use that? [21:31:11] Ah, that might [21:31:32] unicornisaurous: maybe a bad example, that you wrote this, and my intention wasn't to say, that you said that :) Just in general :D [21:31:35] (03PS6) 10Victorbarbu: Autoload Composer's autoloader in Extension Registry [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) [21:32:01] FlorianSW: I think that works [21:32:11] (03CR) 10Florianschmidtwelzow: [C: 031] "@legoktm What does you say?" [core] - 10https://gerrit.wikimedia.org/r/261107 (https://phabricator.wikimedia.org/T119766) (owner: 10Victorbarbu) [21:32:16] Reedy: \o/ [21:33:01] one more reason to drop php 5.3 support :D [21:33:49] 10Phabricator-Sprint-Extension: Add task/edit task not functional from sprint workboard - https://phabricator.wikimedia.org/T122486#1905544 (10Aklapper) What does your browser's error console say? [21:35:56] 4(no projects): DBperformance issues - https://phabricator.wikimedia.org/T122482#1905545 (10Aklapper) 5Open>3stalled Hi @Reception123, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce the problem, please [[ https://www.medi... [21:36:05] FlorianSW: would you please accept my task, since you gave +1 on my code? :D [21:37:03] Reedy: do you have a php5.3 installation to test? Otherwise I would comment on the change and let Mhutti1 upload a new patchset :)) [21:37:22] a-ha! chrome's JS debugger is magical [21:37:24] FlorianSW: I'm discussing with him in #mediawiki [21:37:28] FlorianSW: It's called Wikimedia :D [21:37:35] victorbarbu_: sorry, I accept the task, when the task is accepted, ok? :) [21:37:36] :D [21:38:15] how did I not know this existed [21:38:39] 6Developer-Relations, 3Google-Code-In-2015: Sort out places for MediaWiki and Wikimedia tech presentations - https://phabricator.wikimedia.org/T85593#1905547 (10Aklapper) As I wrote, I first want to have a good, convincing, complete concept in place. Only after that we can actually change page content. :) [21:39:01] victorbarbu_: if you are bored, you can already start working on one of my tasks, like https://codein.withgoogle.com/tasks/5596007547011072/ ;D [21:39:02] Make MediaWiki documentation translatable for your first time: just one page! || 3 days || Documentation, Outreach / Research || Wikimedia || Currently claimed || Instances: 2/20 [21:39:15] (03CR) 10Florianschmidtwelzow: Added a simple smoke test for export (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [21:39:16] ignacio is always so helpful [21:39:36] Nemo_bis, oh do you miss me? :D [21:39:44] * OH- feeds gcibot moar RAM [21:39:56] I miss you too :) [21:40:16] *hi* [21:40:40] victorbarbu_: no need to miss each other before the end of GCI :p [21:41:06] Nemo_bis: yeah, true. I don't have 20 contributions [21:41:31] victorbarbu_: uh I may have missed something, what happens above 20 ? [21:41:40] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905548 (10Reedy) [21:41:48] Nemo_bis is grabbing for students, right? :P [21:41:55] "To have this first task marked done, you need at least ONE page marked for translation; and a total of at least 20 contributions in the "Translations" namespace, as visible from your [[Special:Contributions]] page." [21:42:10] victorbarbu_, but that means at the end of the task [21:42:17] Thanks for telling me, I'll clarify [21:42:54] Nemo_bis: I know it means "at the end of the task" but will a translation sum up 20 contributions? [21:43:10] * ignacio hates summer [21:43:36] sure feels like summer here in the northern hemisphere thanks to el nino + global warming [21:43:52] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905556 (10Reedy) Cheers for the debugging So $val is null... [21:44:07] 29ºC here, I feel like it's more. but well [21:44:25] (03CR) 10Reedy: "Caused T122487" [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/259901 (https://phabricator.wikimedia.org/T119309) (owner: 10Chad) [21:44:40] 6RevisionScoringAsAService, 10rsaas-editquality, 10wikilabels: Edit quality campaign for Dutch Wikipedia - https://phabricator.wikimedia.org/T114510#1905559 (10Woodcutterty) >>! In T114510#1900144, @Halfak wrote: > We're still lacking translations and a list of trusted user groups for nlwiki. Can someone he... [21:45:38] 10MediaWiki-Special-pages, 5MW-1.23-release: String warning appears on Special:Upload - https://phabricator.wikimedia.org/T122487#1905560 (10Reedy) Wonder if other versions are affected too [21:45:50] 7Mobile, 5iOS-app-v5-production: Display Text - https://phabricator.wikimedia.org/T122466#1905561 (10Aklapper) Hi @Djcad2014, thanks for taking the time to report this! Can you please provide a screenshot here? [21:46:20] victorbarbu_: check the text now, clearer? «https://www.zalando.fi/spyder-pitkaehihainen-paita-black-electric-blue-sy042g009-q11.html» [21:46:28] ahem paste fail «Before submitting this task, you need: at least ONE page marked for translation; and a total of at least 20 paragraphs imported from a previous translation (technically, 20 contributions in the "Translations" namespace, as visible from your [[Special:Contributions]] page).» [21:46:48] I love how ignacio appears out of nowhere as soon as he is mentioned by Nemo [21:46:58] unicornisaurous: that's called pinging :D [21:47:06] and ¿ponging? (?) [21:47:23] Nemo_bis: You linked me to a 95 euros jacket [21:47:25] :)) [21:47:28] ignacio: only recently went under 7 °C here, never rains either [21:47:30] (03PS11) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [21:47:33] I just haven’t seen the username here at all and then he just appeared... [21:47:54] I love our winter, well, is not real winter like Poland one [21:47:55] magic [21:48:04] Just -5C at 5AM or in nights, but it's perfect [21:48:09] we don't have snow btw [21:48:47] (03CR) 10Mhutti1: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [21:50:26] ignacio: it would be nice to verify the theory that nordic countries have bigger Wikipedias because people stay home editing during the dark nights [21:50:43] who said that? :P [21:50:50] is a fact? [21:50:52] multiple people [21:50:58] not really, impossibly to verify [21:51:02] (03CR) 10Aaron Schulz: "What about "Unrecognized condition" errors?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/261118 (owner: 10Umherirrender) [21:51:08] I need proofs [21:51:08] But I had no idea of -5 in your country, could be a comparison [21:53:26] (03CR) 10Florianschmidtwelzow: "see my comment on PS11, too :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [21:55:08] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [21:55:39] (03PS12) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [21:55:47] 10MediaWiki-General-or-Unknown, 7Easy, 3Google-Code-In-2015, 7JavaScript: Support fragments in getUrl() of mw.Title - https://phabricator.wikimedia.org/T103715#1905570 (10Aklapper) @Unicornisaurous: Sure! Done. [21:56:23] 10MediaWiki-Special-pages, 7Community-Wishlist-Survey, 5Patch-For-Review: Improve date range searches on Special:Contributions - https://phabricator.wikimedia.org/T120733#1905573 (10Sn1per) [21:56:25] 10MediaWiki-Special-pages: Easy date selection for Special:Newimages - https://phabricator.wikimedia.org/T13836#1905572 (10Sn1per) [21:56:32] (03PS13) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [21:56:41] 10Unofficial-Apps-Wikipedia-Windows-8, 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1905574 (10Aklapper) [21:57:41] andre_: Thanks for getting that task published! Now I just hope nobody takes it before I can claim it :P [21:59:35] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1905577 (10Aklapper) @Krenair: Why do you see sense in making each chapter list every software project they start (under their very own prefix)? [21:59:49] (03PS3) 10Aaron Schulz: Added IDatabase::doAtomicSection() convenience method [core] - 10https://gerrit.wikimedia.org/r/260708 (https://phabricator.wikimedia.org/T122115) [22:00:03] Nemo_bis: are these the pages for translation? https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list#Help [22:00:58] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1905578 (10Unicornisaurous) This is really a core mediawiki bug, right? The change needs to be made to core API files. [22:01:30] 10MediaWiki-API, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1905579 (10Unicornisaurous) [22:02:01] 10Gerrit: Project access history links broken - https://phabricator.wikimedia.org/T120658#1905581 (10Aklapper) That last comment did not make sense as Diffusion is not "on Wikipedia" and "there's a problem" isn't helpful without naming the problem... [22:02:21] victorbarbu_: well, probably not the best choices [22:02:37] Nemo_bis: why? [22:03:11] test-like or hard to verify [22:03:18] victorbarbu_: something like https://www.mediawiki.org/wiki/Manual:$wgUploadPath is usually easier [22:03:31] you can also easily test whether the content is correct, if you want [22:04:38] unicornisaurous: It might be a MultimediaViewer bug too, if it wants to use it ;) [22:04:42] (03PS14) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [22:05:23] Reedy: Theres a bug it blocks (which I happen to have already partially completed) for MultimediaViewer [22:05:30] 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning, 6Reading-Admin, 10Reading-Community-Engagement, and 2 others: [GOAL] Promote related pages to production (on for everyone) on all wikis - https://phabricator.wikimedia.org/T122260#1905584 (10Aklapper) >>! In T122260#1904543, @Cpt.a.haddock wro... [22:05:32] Hmm [22:05:35] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1905585 (10Krenair) That's the status quo, for most project types anyway. I'm asking you to justify making a special exception for chapter projects. [22:05:45] (03PS15) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [22:05:47] It could be still tagged for it, but it doesn't matter so much :) [22:07:20] Nemo_bis: this is very ambiguous. The GCI Page states "You must not add new translations yourself, that's forbidden by the rules" and the MediaWiki page here https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list says that I have to translate. What didn't I get? [22:07:48] victorbarbu_: where does it say you have to translate? [22:08:43] OMG I will give another read to that page [22:08:51] It's a hard lecture [22:09:12] yeah I know, this task has a hard start [22:09:33] If you help me make the description clearer that will be very useful [22:10:23] Slightly edited now [22:12:26] We "only" have 700 pages left, they used to be thousands. :) Some of those are really huge though [22:13:05] (03CR) 10Reedy: "check zend" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [22:13:07] Nemo_bis: I don't have a "translate" link on the page you gave me [22:13:38] victorbarbu_: the link appears after the page has been approved for translation [22:14:29] (03PS1) 10Jack Phoenix: Fix the navigation menu for MW 1.26+ by ditching inline JS [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/261165 [22:14:30] victorbarbu_: see e.g. https://www.mediawiki.org/wiki/How_to_contribute/ro [22:14:48] 10MediaWiki-Export-or-Import, 10MediaWiki-Unit-tests, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Write a simple smoke test for export - https://phabricator.wikimedia.org/T116883#1905589 (10Reedy) [22:14:48] (03CR) 10jenkins-bot: [V: 04-1] Fix the navigation menu for MW 1.26+ by ditching inline JS [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/261165 (owner: 10Jack Phoenix) [22:15:06] "versiunea tradusă" or "traducere" [22:15:33] can I translate that one? is it valid for the task? [22:15:59] since it's my native language [22:17:34] victorbarbu_: no [22:17:41] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks good from my side :)" [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [22:17:52] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix the navigation menu for MW 1.26+ by ditching inline JS [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/261165 (owner: 10Jack Phoenix) [22:18:09] victorbarbu_: you can mark this page https://www.mediawiki.org/wiki/Manual:Interwiki and then copy this translation though: https://www.mediawiki.org/wiki/Manual:Interwiki/ro [22:20:13] (03PS1) 10Jack Phoenix: Remove old PHP entry point [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/261166 [22:20:23] This task is good as crash course for multiple features of MediaWiki editing ^_^ [22:21:15] (03CR) 10Jack Phoenix: [C: 032 V: 032] Remove old PHP entry point [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/261166 (owner: 10Jack Phoenix) [22:22:13] (03PS16) 10Reedy: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [22:22:15] (03CR) 10Reedy: [C: 032] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [22:22:23] 10MobileFrontend, 5Patch-For-Review: Nearby doesn't work with umlauts as page title - https://phabricator.wikimedia.org/T122484#1905595 (10Krenair) What is linking to the version with the page name encoded? [22:23:19] Nemo_bis: I am not a translation administrator [22:23:24] I cannot mark pages [22:23:38] victorbarbu_: most of the work is adding newlines, translate tags, tvar etc. [22:23:55] You already made me improve the description https://www.mediawiki.org/w/index.php?title=Project:Language_policy/Migration_list&diff=1983555&oldid=1975670 [22:27:46] victorbarbu_: clearer now? https://www.mediawiki.org/w/index.php?title=Project%3ALanguage_policy%2FMigration_list&type=revision&diff=1983560&oldid=1983555 [22:28:06] We should probably let all users access special:pagepreparation [22:28:06] Nemo_bis: I am going to cry :)) That page does not have a translate link and I cannot add tags to mark it for translation as the tutorial says [22:28:17] ????? [22:28:35] 4(no projects): Graph extension's static image broken on first render - https://phabricator.wikimedia.org/T122489#1905599 (10Tgr) 3NEW [22:28:43] (1) find a page that has to be marked for translation but ahsn't [22:28:45] hasn;t [22:28:50] hasn't [22:29:04] victorbarbu_: which page? [22:29:35] Nemo_bis: https://www.mediawiki.org/wiki/Manual:Interwiki the one you linked me to [22:30:03] (03Merged) 10jenkins-bot: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [22:30:05] I am tired, so I am not at maximum performance, but that page does not have a translation link [22:30:13] https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration#Segmentation [22:30:23] victorbarbu_: the task is composed of several steps which must be performed in order [22:31:32] victorbarbu_: you need to make edits similar to https://www.mediawiki.org/w/index.php?title=Manual%3AInterwiki&type=revision&diff=1983562&oldid=1983559 [22:31:49] * Nemo_bis concludes that an example diff is required for the instructions [22:31:55] (03PS6) 10Alex Monk: Show user names as subpages of special pages in autocomplete search [core] - 10https://gerrit.wikimedia.org/r/256745 (owner: 10Umherirrender) [22:32:30] Nemo_bis: I've wrapped the page in tag, but It says "page has changes not approved blah blah" [22:32:58] You have to wait for a Translation Admin to approve your changes [22:33:49] Do you understand how the Translate extension works? [22:36:50] I guess [22:37:22] You know how MediaWiki etc. have their UI message divided into a bunch of different strings? [22:37:37] yeah [22:37:53] Same way with documentation. It's easier to translate a paragraph than to translate everything at once [22:38:07] Also, if you change one paragraph, you only have to change one part of the translation, instead of the whole thing [22:38:42] that's logical, yeah [22:39:08] So for this task, you are taking old doc pages from the pre-Translate extension era, [22:39:23] you are using tags to divide the page into easy-to-translate blocks (usually by paragraph) [22:40:10] and when a Translation administrator approves your changes, you are migrating the old translations so that each of the blocks in each translation maps to a block in the updated, -divided text [22:40:38] (03CR) 10Alex Monk: [C: 04-1] "Doesn't deal with hideuser blocks" [core] - 10https://gerrit.wikimedia.org/r/256745 (owner: 10Umherirrender) [22:40:51] Here's a guide on how to divide a documentation page with etc.: https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration#Segmentation [22:42:08] OH-: Let me check if I got it all clear: 1) I add tags on the page to prepare it for translation. 2) Wait for an administrator to approve that edit. 3) Map the translated blocks. Is this right? [22:44:55] 10MediaWiki-extensions-MultimediaViewer, 6WMF-Legal, 3Google-Code-In-2015, 5Patch-For-Review: Shorten MediaViewer credit lines - https://phabricator.wikimedia.org/T119686#1905613 (10Anomie) [22:44:57] 10MediaWiki-General-or-Unknown, 7I18n: [Short URLs] Safe permanent link to a page (e.g. using one of its history id) - https://phabricator.wikimedia.org/T23572#1905614 (10Anomie) [22:44:59] 10MediaWiki-API, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1905610 (10Anomie) 5Open>3declined a:3Anomie The page_id is already available from the API. Construct the URL client-side as proposed in the task description. [22:49:07] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1905615 (10Aklapper) Justification: Because documenting a chapter-only project feels heavy-weight for no good reason. [22:49:10] victorbarbu_: more or less like that :) [22:49:33] ok, great. thank you [22:53:18] Nemo_bis, whou, you added *lots* of GCI tasks. Thanks! [22:53:39] andre__: yeah because Ioannis is too fast :D [22:53:58] We'll see if someone picks up the i18n ones [22:55:44] Nemo_bis: they are ugly [22:58:40] sure [22:58:52] Sometimes one feels adventurous and wants to visit some of those wastelands [23:02:40] 10Unofficial-Apps-Wikipedia-Windows-8, 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1905618 (10Rezonansowy) Here Windows Store link: https://www.microsoft.com/en-us/store/apps/wikipedia/9wzdncrfhwm4 [23:03:04] 10Unofficial-Apps-Wikipedia-Windows-8, 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1905619 (10Rezonansowy) [23:16:58] 10MobileFrontend: Mobile app edit icon giving wrong section - https://phabricator.wikimedia.org/T122471#1905621 (10PamD) Sorry, I think it's website not app. In Android on Galaxy Ace 4. [23:43:29] (03PS1) 10Aaron Schulz: Move MaxUserDBWriteDuration logic to LBFactory [core] - 10https://gerrit.wikimedia.org/r/261167 [23:45:03] 10Unofficial-Apps-Wikipedia-Windows-8, 7Software-Licensing: No license specified for apps/win8/wikipedia - https://phabricator.wikimedia.org/T122468#1905626 (10TheDJ) a:3brion Brion wrote this if I remember correctly. By default, that probably means it is GPL2, unless Brion blesses it with a more liberal lic... [23:49:34] 10MediaWiki-API, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1905628 (10Tgr) Page ID is not available for images from foreign repositories (when queried by the imageinfo API). For ForeignAPIRepo files one could fetch it with an e... [23:59:06] 10MobileFrontend, 5Patch-For-Review: Nearby doesn't work with umlauts as page title - https://phabricator.wikimedia.org/T122484#1905629 (10Florian) Nothing at the moment, I thought it is used in a "near this page" button at the bottom of a page, but it isn't (anymore). But a user can link to this page.