[00:08:12] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1903848 (10Aklapper) a:3intracer [00:09:16] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1903809 (10Aklapper) [00:12:03] 6Community-Liaison: Publish a VE newsletter for December 2015 - https://phabricator.wikimedia.org/T121906#1903852 (10Elitre) 5Open>3Resolved Just published to over 550 pages in 16 languages + English. When the German version is available, I'll manually overwrite the current text at de.wiki. [00:27:34] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 7FR-Smashpig: Rename GlobalCollect to Ingenico - https://phabricator.wikimedia.org/T122420#1903855 (10Ppena) That's correct. I think we only need to change in the UI (customer facing). They shouldn't care what... [00:27:51] 6Developer-Relations, 3Google-Code-In-2015: Sort out places for MediaWiki and Wikimedia tech presentations - https://phabricator.wikimedia.org/T85593#1903856 (10Aklapper) Hi husn_shujaat, could you please reply to my questions in T85593#1901365 ? Thanks! [00:42:04] 6Developer-Relations, 3Google-Code-In-2015: Sort out places for MediaWiki and Wikimedia tech presentations - https://phabricator.wikimedia.org/T85593#1903861 (10Aklapper) >>! In T85593#1902046, @husn_shujaat wrote: >> what is your proposal to avoid duplicated content? > I propose, that maybe we could https://... [01:08:26] (03CR) 10Smalyshev: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260164 (owner: 10Smalyshev) [01:14:40] legoktm: when you get a chance, take a look at my patch. https://gerrit.wikimedia.org/r/260904 Have a merry Christmas!!!! [01:14:51] Merry Christmas to all! [01:20:00] Merry Christmas MtDu [01:46:07] (03PS1) 10Mholloway: Add 1px right margin to external link style [skins/Vector] - 10https://gerrit.wikimedia.org/r/260954 (https://phabricator.wikimedia.org/T121002) [02:10:51] (03PS2) 10Ed Hoo: Fix HOLDS operator parsing and adds corresponding NOT functionality [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/260951 [02:23:21] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1903878 (10josephine_l) [02:25:56] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1903879 (10violetto) >>! In T104836#1899624, @violetto wrote: > {F3136481} > > We probably need to add new classes for the couple other changes I made: > - Double the size o... [03:00:34] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: [GOAL] Enhance accessibility of OOjs UI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users - https://phabricator.wikimedia.org/T111117#1903891 (10violetto) [03:00:38] 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 7Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#1903893 (10violetto) [03:00:42] 10UI-Standardization, 7Accessibility, 7Documentation: Consolidate documentation for recommended color palette - https://phabricator.wikimedia.org/T110727#1903892 (10violetto) [03:00:45] 10UI-Standardization, 7Accessibility: Improve color palette to comply with WCAG 2.0 min level AA and color-deficiency-friendly. - https://phabricator.wikimedia.org/T109915#1903889 (10violetto) 5Open>3Resolved I’m satisfied with the consensus that we’ve come up with (also in such timely manner), and I am pr... [03:02:20] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1903894 (10violetto) Yikes, I just noticed your message @Volker_E, feel free to attach the image next time without waiting on me! {F3... [03:02:58] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: [GOAL] Enhance accessibility of OOjs UI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users - https://phabricator.wikimedia.org/T111117#1903898 (10violetto) [03:03:02] 10UI-Standardization, 7Accessibility: Improve color palette to comply with WCAG 2.0 min level AA and color-deficiency-friendly. - https://phabricator.wikimedia.org/T109915#1903899 (10violetto) [03:03:05] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1903895 (10violetto) 5Open>3Resolved a:3violetto Thanks @Elitre for raising this issue and thanks for all of your input. This has... [03:05:30] 10UI-Standardization, 7Accessibility: Improve color palette to comply with WCAG 2.0 min level AA and color-deficiency-friendly. - https://phabricator.wikimedia.org/T109915#1903903 (10violetto) [03:05:33] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1903901 (10violetto) 5Resolved>3Open [03:05:41] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1031956 (10violetto) a:5violetto>3Volker_E [03:07:31] (03CR) 10jenkins-bot: [V: 04-1] Moved JS files to end of body [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/260005 (https://phabricator.wikimedia.org/T120196) (owner: 10Jonas Kress (WMDE)) [03:11:18] 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 7Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#1903911 (10violetto) a:3Volker_E T109915 is now resolved and consensus has also been reached at T89... [03:18:02] 10UI-Standardization, 10OOjs-UI: Consider consolidating progressive and constructive buttons - https://phabricator.wikimedia.org/T110555#1903918 (10violetto) a:3Volker_E Passing the baton over to you @volker_e! [03:27:42] 7Design, 10UI-Standardization: Provide a color palette and design for buttons that are purely highlighted links, to distinguish them from actual UI buttons - https://phabricator.wikimedia.org/T116549#1903927 (10violetto) a:3violetto @Quiddity, do you think the solution [[ https://phabricator.wikimedia.org/T1... [03:43:06] 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Page number inclusion on transcluded works is confused or undefined under certain conditions... - https://phabricator.wikimedia.org/T122395#1903930 (10Billinghurst) The issue that you are facing is that the page numbers are anchors when trancluded, when you ad... [03:49:02] Phab added doge memes to their homepage! [03:52:20] (03CR) 10Legoktm: [C: 04-1] "Minor thing left :)" (031 comment) [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/260904 (https://phabricator.wikimedia.org/T87995) (owner: 10MtDu) [03:56:43] (03PS10) 10MtDu: Convert wikihiero to use extension registration [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/260904 (https://phabricator.wikimedia.org/T87995) [04:02:37] legoktm: Last patch, hopefully. https://gerrit.wikimedia.org/r/#/c/260904/ :) [04:15:03] (03CR) 10Legoktm: [C: 032] "Nice work :)" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/260904 (https://phabricator.wikimedia.org/T87995) (owner: 10MtDu) [04:15:53] (03Merged) 10jenkins-bot: Convert wikihiero to use extension registration [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/260904 (https://phabricator.wikimedia.org/T87995) (owner: 10MtDu) [05:00:00] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1903935 (10josephine_l) [05:09:48] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1903938 (10Justin-Leung) So the changes we want set will be the ones listed below. Also with the additions of new classes. //Changes//: # Double the size of left/right paddi... [05:15:44] (03CR) 10EBernhardson: [C: 032] Fix gen-autoload.php which I messed up. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260947 (owner: 10Smalyshev) [05:19:28] (03CR) 10jenkins-bot: [V: 04-1] Fix gen-autoload.php which I messed up. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260947 (owner: 10Smalyshev) [05:30:52] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: codfw has six unassigned shards - https://phabricator.wikimedia.org/T122425#1903951 (10EBernhardson) 3NEW [05:47:52] (03PS1) 10MtDu: Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) [05:50:08] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1903962 (10josephine_l) [05:51:04] (03CR) 10jenkins-bot: [V: 04-1] Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [05:54:56] (03PS2) 10MtDu: Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) [05:58:25] (03CR) 10jenkins-bot: [V: 04-1] Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [06:17:51] Can someone explain to me what a tac: write error is in this case? https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/24526/console [06:21:12] (03CR) 10MtDu: "recheck" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [06:22:07] legoktm: Is this an error on my end or the tests end? https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/24526/console [06:28:35] legoktm: It was an error with the tests. [06:38:57] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1903963 (10violetto) Yes, sounds good. mm [06:56:33] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1903964 (10josephine_l) [07:01:04] 10Commons-App-Android-Upload: Display the resulting categories to the user alongside the "previous categories" that are currently already displayed - https://phabricator.wikimedia.org/T119281#1903965 (10josephine_l) [07:26:35] 10MediaWiki-Recent-changes, 5Patch-For-Review: Contributions appearing out of order - https://phabricator.wikimedia.org/T46841#1903967 (10Legoktm) [07:32:23] 10MediaWiki-RfCs, 6Phabricator, 10Gerrit, 10Gitblit, and 5 others: [RfC]: Migrate code review / management to Phabricator from Gerrit - https://phabricator.wikimedia.org/T119908#1903970 (10Legoktm) >>! In T119908#1903835, @RobLa-WMF wrote: > I'll note that the one question I received in my [WikiDev '16 Lig... [07:35:35] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1903971 (10Justin-Leung) @violetto ok I'll add the changes and submit the patch set. Have a great christmas! [07:40:51] (03CR) 10Legoktm: Add extension boilerplate (033 comments) [extensions/WikiLabels] - 10https://gerrit.wikimedia.org/r/257290 (owner: 10Bmansurov) [07:41:17] (03PS15) 10Christopher Johnson (WMDE): adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 [07:48:43] Merry Christmas! [08:06:17] Hi tto, Merry Christmas everyone, can you help right now? [08:08:47] Georggi: I also need some guidance, but I don't think anyone is available right now :( [08:37:37] Merry Christmas to one and all! I hope Christmas is a lot cooler where you are - I just sweltered through a 37 degree day (almost 100 degrees Fahrenheit)! [08:37:57] And to all who don't celebrate Christmas, have a happy holiday season. [08:38:04] Georggi: victorbarbu_: I am here :) [08:38:15] :( [08:38:45] tto: I am working on auto-configuring the composer autoloader for an extension [08:39:14] tto: this one https://phabricator.wikimedia.org/T119766 [08:40:00] I don't really understand the mechanism. Where should that function be put (I mean the one that require()s the autoloader) ? [08:40:18] should it be in the extension itself, or the extensions shouldn't worry about it [08:40:20] ? [08:40:28] I'll just give the task a read, and let you know what I think in a sec [08:41:22] Legoktm's comment on that task seems quite helpful. [08:41:29] It points you to the ExtensionProcessor class [08:41:38] (03CR) 10jenkins-bot: [V: 04-1] adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [08:42:49] victorbarbu_: So for a start, you should add a function definition to the Processor interface [08:43:04] (03PS1) 10Jack Phoenix: More MW 1.26 tweaks [extensions/Video] - 10https://gerrit.wikimedia.org/r/260957 [08:43:34] (03CR) 10Jack Phoenix: [C: 032] More MW 1.26 tweaks [extensions/Video] - 10https://gerrit.wikimedia.org/r/260957 (owner: 10Jack Phoenix) [08:43:48] Then implement that function in the ExtensionProcessor class to return the autoload PHP file path (probably as the lone element of an array) [08:44:10] (03Merged) 10jenkins-bot: More MW 1.26 tweaks [extensions/Video] - 10https://gerrit.wikimedia.org/r/260957 (owner: 10Jack Phoenix) [08:45:25] Then call the function from ExtensionRegistry [08:45:32] tto: That's what I thought as well, but I wasn't sure if that's ok [08:46:36] It seems that the new processing should occur after line 212, but I can't be sure of that [08:46:42] This is not my area of expertise at all. [08:46:59] My advice would be to have a go, and let the experts review the patch [08:47:16] thank you so much [08:47:21] Better still, try to rig up a test installation with some extensions, and see if you can get your code to work. A lot harder that way, though [08:47:37] I will test it myself [08:47:44] I want my work to be good [08:47:52] by the way, where are you ? why are there 30 degrees? [08:48:00] I'm in Australia :) [08:48:05] woow [08:48:06] so nice [08:48:12] It gets hot here at Christmastime! [08:48:19] I am the other side of the planet :) [08:48:33] Europe, I'm guessing? [08:48:37] yeah [08:48:39] romania [08:48:48] no snow, thought [08:49:08] I guess that's a good thing in some ways! [08:49:15] yes and no [08:49:32] it's my first Christmas with 12 degrees outside [08:49:39] which is sad...really sad [09:08:31] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 7user-notice: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1903974 (10matej_suchanek) [09:10:06] Who wrote me? I had to leave:) [09:10:50] tto? [09:11:00] It was me indeed [09:11:07] Ahh, [09:11:45] Is my task all about editing export-0-10? [09:12:10] Is this the page language task? [09:12:18] That's one aspect of it. [09:12:35] The other aspect is to modify the PHP code in Export.php to actually export the new element in XML dumps [09:12:46] aha ok [09:12:56] To be honest, I'm most interested in the PHP aspect. The XSD part is just a little bit of fun along the side [09:13:23] (if you can call XSD fun; I'm not sure many people would call it fun) [09:13:41] I am just not sure where to add it:( [09:13:45] in Export.php [09:14:36] (03CR) 10Jonas Kress (WMDE): [C: 032] Moved JS files to end of body [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/260005 (https://phabricator.wikimedia.org/T120196) (owner: 10Jonas Kress (WMDE)) [09:14:38] Let me go and have a look. [09:14:55] It's quite a mess for me:) [09:15:09] Wow, it exports XML by concatenating strings! [09:15:15] Looks like export code is just as bad as import [09:16:31] So each page needs a element [09:17:03] (03CR) 10Jonas Kress (WMDE): "recheck" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [09:17:23] Georggi: I'd put it on line 622, before the hook [09:17:39] That's where the code for the element is generated [09:28:23] 7Design, 10Vector, 7Easy, 5Patch-For-Review: Double quote (") immediately after an external link looks ugly: icon is too close to the double quote - https://phabricator.wikimedia.org/T121002#1903977 (10Edokter) From what I can see, the content is evenly spaced on both sides inside the quotes. Adding the ma... [09:30:30] (03PS1) 10Jack Phoenix: Fixing a strange search box CSS issue [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/260958 [09:31:04] (03CR) 10Jack Phoenix: [C: 032] Fixing a strange search box CSS issue [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/260958 (owner: 10Jack Phoenix) [09:49:04] why won't wfDebug work from inside ExtensionRegistry? aren't those functions called? :| [09:50:51] victorbarbu_, looks like debugging is initialised after extensions are registered [09:50:58] You might have to fall back to "echo" statements [09:54:06] tto: still nothing [09:54:10] it's frustrating [09:54:43] victorbarbu_: It's possible that the code is not being run. Try adding a "die" in there [09:57:47] tto: apparently, that code does not run, which is strange, since I was in the loadFromQueue() function [09:59:01] victorbarbu_: I wonder if it is hitting the if statement on line 118 [09:59:34] in ExtensionRegistry? [09:59:46] tto: yeah, it's hitting that [10:00:17] 10Wikimedia-Site-Requests: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904004 (10Liuxinyu970226) 3NEW [10:00:23] You need to register an extension! [10:00:40] tto, hmmm, I am not sure though where page language is stored... [10:00:50] victorbarbu_: Download some extension that looks nice, and register it in LocalSettings.php by calling wfLoadExtension( ... ) [10:01:01] I have it [10:01:06] WIkidataPageBanner [10:01:09] is one of them [10:01:31] 10Wikimedia-Site-Requests: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904004 (10Liuxinyu970226) [10:01:45] Georggi: There's a function Title::getPageLanguage [10:02:05] 10Wikimedia-Site-Requests: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904004 (10Liuxinyu970226) [10:02:13] But I also need to consider that glopal $wg... value? [10:02:14] victorbarbu_: Does that extension have an extension.json file? If not, then it is still using the old PHP loading mechanism, which AFAIK bypasses ExtensionRegistry [10:02:15] global* [10:02:39] it has the extension.json [10:02:58] it's using extension registry [10:03:04] Georggi: I don't think so [10:03:12] The tag should be output unconditionally [10:03:48] should it be or [10:03:49] ? [10:04:09] I would personally make it . Since it is already inside the element, we know it relates to the page [10:05:46] victorbarbu_: So wfLoadExtension calls ExtensionRegistry::queue() which then sets $queued to a truthy value [10:05:58] I don't see why it could be getting cleared. [10:06:53] Try commenting out all your wfLoadExtension calls and other extension inclusions in LocalSettings.php except for one really simple extension, like InputBox [10:07:02] 10Wikimedia-Site-Requests, 7Community-consensus-needed: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904014 (10Liuxinyu970226) [10:07:46] 10Wikimedia-Site-Requests: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904015 (10TTO) [10:07:57] 10Wikimedia-Site-Requests: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904004 (10TTO) No community consensus is needed for this simple MediaWiki core translation request. [10:08:06] 10MediaWiki-Internationalization: Change the Min Dong translation of MediaWiki: namespace back to English - https://phabricator.wikimedia.org/T122428#1904018 (10TTO) [10:09:39] If only legoktm was here! [10:10:54] (03CR) 10Jack Phoenix: [V: 032] Fixing a strange search box CSS issue [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/260958 (owner: 10Jack Phoenix) [10:11:23] tto: done! now what [10:11:33] what's the issue? [10:12:14] Nikerabbit: I am trying to implement this https://phabricator.wikimedia.org/T119766 [10:12:35] and some code seems not to be running in the ExtensionRegistry [10:12:45] I mean, it seems not to be called by anything at all [10:13:45] victorbarbu_: After removing all extensions except InputBox, $this->queued is still empty? [10:14:55] (03CR) 10jenkins-bot: [V: 04-1] Moved JS files to end of body [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/260005 (https://phabricator.wikimedia.org/T120196) (owner: 10Jonas Kress (WMDE)) [10:15:11] it's not empty [10:15:22] says Array ( [/vagrant/mediawiki/skins/Vector/skin.json] => 1449928566 [/vagrant/mediawiki/extensions/InputBox/extension.json] => 1451038188 ) [10:15:29] and this seems right [10:16:52] (03CR) 10Bmansurov: Unread notifications now visible (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260943 (owner: 10Nicoco007) [10:17:52] victorbarbu_: and where is that require_once code placed? [10:17:57] Hi Nikerabbit Marry Xmas! [10:18:11] Nikerabbit: what require_once ? [10:18:47] ah you are trying to implement it? [10:18:53] yeah [10:18:57] that's my task [10:20:26] I see [10:22:03] and have you tried following the code execution from includes/Setup.php where it calls loadFromQueue to see where it goes and doesn't? [10:23:00] To anybody with Lua skills: I need some help about the data model and the Skribontu interface. I managed to get mw related data structure open **show** at https://test.wikipedia.org/?curid=86949#MW [10:23:59] Nikerabbit: ammmm, noo [10:27:08] Nikerabbit, tto: now, that function is called and it runs ok. so, what I did: I created a function getAutoloaderPaths in Processor interface and implemented it in ExtensionProcessor (it checks if the $info array contains the wanted key, and if true, it returns "$dir/vendor/autoloader.php"). Now should I call it in loadFromQueue() ? [10:27:29] victorbarbu_: Give it a go :) [10:27:47] As I said, it sounds as though legoktm wants it to be placed inside the end of the foreach loop [10:29:57] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1904020 (10Nemo_bis) > I miss that when I would merge something but don't have permission, to distinguish it from "I reviewed this part, but the rest still needs review". To indicate... [10:33:38] 10MediaWiki-General-or-Unknown, 7Tracking: Incorporate analytics into MediaWiki's info action (tracking) - https://phabricator.wikimedia.org/T43326#1904023 (10Nemo_bis) [10:39:07] (03PS1) 10TTO: Namespace translations for Gilaki (glk) [core] - 10https://gerrit.wikimedia.org/r/260960 (https://phabricator.wikimedia.org/T122127) [10:40:36] 10MediaWiki-Internationalization, 5Patch-For-Review: Translation of namespaces for Gilaki - https://phabricator.wikimedia.org/T122127#1904035 (10TTO) @Varg: Please check https://gerrit.wikimedia.org/r/#/c/260960/1/languages/messages/MessagesGlk.php for mistakes. For NS_PROJECT_TALK, the `$1` is replaced with... [10:50:47] 10MediaWiki-Internationalization, 5Patch-For-Review: Translation of namespaces for Gilaki - https://phabricator.wikimedia.org/T122127#1904036 (10TTO) 5Open>3stalled Please confirm the names of the following namespaces: TimedText talk Module talk Gadget talk Gadget definition talk [10:55:28] (03PS1) 10Georggi199: Export: Added language to the export dumps [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) [10:56:22] tto https://gerrit.wikimedia.org/r/260961 [11:04:26] 10MediaWiki-Special-pages, 10DBA, 7Performance: Batch update of special pages creates slave lag on s3 over WAN - https://phabricator.wikimedia.org/T122429#1904041 (10jcrespo) 3NEW [11:07:46] 10MediaWiki-File-management, 10MediaWiki-Vagrant, 6Commons, 6Multimedia: InstantCommons does not work in Vagrant (again) - https://phabricator.wikimedia.org/T122275#1904051 (10Tgr) 5Open>3Resolved Cannot reproduce anymore, even on the same machine. I there was some temporary change to Commons. Anyway,... [11:13:24] 6Developer-Relations, 3Google-Code-In-2015: Sort out places for MediaWiki and Wikimedia tech presentations - https://phabricator.wikimedia.org/T85593#1904055 (10husn_shujaat) >>I propose, that maybe we could https://wikimediafoundation.org/wiki/Press_room/WMF_Presentations, thats only what I could think. And i... [11:14:43] (03CR) 10TTO: [C: 04-1] "(Note to other reviewers: I am aware that the schema version needs to be bumped, but I'm not asking the GCI student to do this yet, as the" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/260961 (https://phabricator.wikimedia.org/T118114) (owner: 10Georggi199) [11:15:50] (03CR) 10TheDJ: "Opened https://gerrit.wikimedia.org/r/#/c/260952 to deal with the issue that 1b797b7f6a tried to solve." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260513 (owner: 10Krinkle) [11:17:17] is there any way to disable the cache for my local devwiki? [11:17:54] it's annoying [11:19:35] You can put $wgMainCacheType = CACHE_NONE; [11:19:36] in LocalSettings.php [11:19:41] But I wonder what you really mean by "cache" [11:24:49] for example, if I change something in my php code (related to Extension*), I have to make some changes in the extension.json to reflect my changes in the code, because they are cached or something [11:25:19] (03CR) 10He7d3r: [C: 031] Remove non-working #{{special:mypage}} from help [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260952 (https://phabricator.wikimedia.org/T44107) (owner: 10TheDJ) [11:27:48] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1903809 (10intracer) Hi, we want to use this project to coordinate activities like administration of Wikimedia Ukraine's server. At least for some tasks we do not want them to be public, but available only... [11:28:44] victorbarbu_: Yeah, I was trying to help someone with that the other day, without much success [11:33:20] and even with cache set to none, it keeps doing that [11:33:30] but it's fine, I will learn to live with it [11:33:46] after i've generated the include path for the autoloader.php, what should I do? [11:40:32] 10MediaWiki-General-or-Unknown: Rollback all user edits - https://phabricator.wikimedia.org/T13712#1904061 (10Liuxinyu970226) [11:47:35] tto: victorbarbu_ $this->cache = ObjectCache::getLocalServerInstance(); [11:48:17] Reedy: what's with it? [11:48:20] Reedy: What does that code snippet do? [11:48:42] That's the cache used in ExtensionRegistry [11:48:50] So it uses apc by default [11:49:09] apc then xcache then wincache [11:49:25] So, generally, restart your webserver etc [11:57:37] 6Discovery, 10Maps: [WikiMaps Warper] Failure on "Edit tab" (Sorry you do not have permission to view that.) - https://phabricator.wikimedia.org/T121344#1904064 (10Chippyy) Yes, I think it might be better to create a new project in the long term. There have been times when end users have reported outages which... [11:57:38] 6Discovery, 10Maps: [WikiMaps Warper] Failure on "Edit tab" (Sorry you do not have permission to view that.) - https://phabricator.wikimedia.org/T121344#1904065 (10Chippyy) Yes, I think it might be better to create a new project in the long term. There have been times when end users have reported outages which... [12:26:26] 10MediaWiki-History-or-Diffs, 5MW-1.27-release-notes, 5Patch-For-Review: Undefined property: DiffEngine::$seq - https://phabricator.wikimedia.org/T116266#1904067 (10alex-mashin) What about backporting to REL1_26? [12:45:45] (03CR) 10Fomafix: [C: 031] Remove non-working #{{special:mypage}} from help [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260952 (https://phabricator.wikimedia.org/T44107) (owner: 10TheDJ) [12:48:35] (03CR) 10Fomafix: [C: 04-1] Use mw.Message#text() instead of plain() in wikiEditor.autoMsg() (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260513 (owner: 10Krinkle) [12:56:20] (03CR) 10Fomafix: Remove non-working #{{special:mypage}} from help (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260952 (https://phabricator.wikimedia.org/T44107) (owner: 10TheDJ) [12:59:16] 10MediaWiki-Internationalization: Min Nan Chinese - Bân-lâm-gú localisation on Taiwan (new language code: nan-tw) - https://phabricator.wikimedia.org/T33162#1904068 (10Liuxinyu970226) [13:11:56] (03PS1) 10Nemo bis: Fix "Undefined property: DiffEngine::$seq" under HHVM in DairikiDiff.php [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/260962 (https://phabricator.wikimedia.org/T116266) [13:15:04] 10MediaWiki-Internationalization, 7I18n: If the default value of a system message is the empty string, treated as a non-existent page in mediawiki namespace - https://phabricator.wikimedia.org/T29697#1904075 (10Liuxinyu970226) [13:15:11] 10MediaWiki-Internationalization, 7I18n: $namespaceNames does not work with language fallback - https://phabricator.wikimedia.org/T30707#1904077 (10Liuxinyu970226) [13:22:20] 10MediaWiki-Special-pages, 10DBA, 6operations, 7Performance: Batch update of special pages creates slave lag on s3 over WAN - https://phabricator.wikimedia.org/T122429#1904079 (10jcrespo) I cannot say for sure if it is the Special pages or wbc_entity_usage updates, one of the two: {F3146353} [13:22:46] 10MediaWiki-Special-pages, 10DBA, 6operations, 7Performance: Batch update of special pages creates slave lag on s3 over WAN - https://phabricator.wikimedia.org/T122429#1904081 (10jcrespo) Setting db2018 as MIXED temporarily to see if that helps. [13:27:12] 10MediaWiki-Special-pages, 10DBA, 6operations, 7Performance: Batch updated create slave lag on s3 over WAN - https://phabricator.wikimedia.org/T122429#1904082 (10jcrespo) [13:27:23] 10MediaWiki-extensions-WikibaseClient, 10DBA, 10Wikidata, 7Performance: [Bug] EntityUsageTable::touchUsageBatch slow query - https://phabricator.wikimedia.org/T111769#1904085 (10jcrespo) This may be one of the reasons of T122429. [13:32:34] 10MediaWiki-Special-pages, 10DBA, 6operations, 7Performance: Batch updates create slave lag on s3 over WAN - https://phabricator.wikimedia.org/T122429#1904087 (10jcrespo) [13:34:35] !db archive [13:34:35] See http://www.mediawiki.org/wiki/Manual:archive_table [14:03:39] 10MediaWiki-extensions-ContactPage: ContactPage Catchable fatal error - https://phabricator.wikimedia.org/T122430#1904088 (10EFFemeer) 3NEW [14:42:20] 10MediaWiki-extensions-MultimediaViewer: error: could not load image from https://upload.wikimedia.org/wikipedia/commons/thumb/0/00/Triestecathedral.jpg/1024px-Triestecathedral.jpg URL: https://pt.wikipedia.org/wiki/Trieste#/media/File:Triestecathedral.jpg user ... - https://phabricator.wikimedia.org/T122431#1904098 [14:42:52] 10MediaWiki-extensions-MultimediaViewer: error: could not load image from https://upload.wikimedia.org/wikipedia/commons/thumb/0/00/Triestecathedral.jpg/1024px-Triestecathedral.jpg URL: https://pt.wikipedia.org/wiki/Trieste#/media/File:Triestecathedral.jpg user a... - https://phabricator.wikimedia.org/T122431#1904105 [14:47:12] 10MediaWiki-extensions-MultimediaViewer: Error details: error: could not load image from https://upload.wikimedia.org/wikipedia/commons/thumb/0/00/Triestecathedral.jpg/1024px-Triestecathedral.jpg URL: https://pt.wikipedia.org/wiki/Trieste#/media/File:Triestecath... - https://phabricator.wikimedia.org/T122432#1904106 [14:57:54] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI, 7Accessibility: [GOAL] Enhance accessibility of OOjs UI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users - https://phabricator.wikimedia.org/T111117#1904115 (10Rezonansowy) @Volker_E Well, OK. If the article... [15:21:30] 10MobileFrontend: Bug: Lead image shows and then immediately hides when there's no image to display - https://phabricator.wikimedia.org/T103967#1904123 (10Unicornisaurous) This should be removed from the GCI site since its fixed. [15:46:39] (03CR) 10Jonas Kress (WMDE): "recheck" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/260005 (https://phabricator.wikimedia.org/T120196) (owner: 10Jonas Kress (WMDE)) [16:10:38] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1904127 (10Luke081515) You have to change the policy of each task (maybe you need rights for this, that's the thing of @aklapper), but if you make a project private, the task are **NOT** private, and at the... [16:37:36] 10Wikimedia-Site-Requests: Request to set $wgRestrictDisplayTitle = false at de.wikibooks - https://phabricator.wikimedia.org/T122433#1904128 (10Juetho) 3NEW [16:40:57] 10MediaWiki-extensions-WikiLexicalData-or-OmegaWiki: Cannot add class attributes option values - https://phabricator.wikimedia.org/T122434#1904135 (10Purodha) 3NEW [16:44:46] 10Wikimedia-Site-Requests: Request to set $wgRestrictDisplayTitle = false at de.wikibooks - https://phabricator.wikimedia.org/T122433#1904142 (10Luke081515) a:3Luke081515 [16:45:03] 10Wikimedia-Site-Requests: Request to set $wgRestrictDisplayTitle = false at de.wikibooks - https://phabricator.wikimedia.org/T122433#1904128 (10Luke081515) p:5Triage>3Normal [16:53:21] 10MediaWiki-Internationalization, 10MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, 7I18n: Wrong interface language in AJAX popup - https://phabricator.wikimedia.org/T122435#1904145 (10Purodha) 3NEW [16:54:45] (03PS1) 10TheDJ: Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) [16:58:46] (03CR) 10jenkins-bot: [V: 04-1] Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [17:15:42] (03CR) 10TheDJ: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [17:58:55] 6Discovery, 10Maps, 10Wikimedia-Developer-Summit-2016: Discuss the future of Maps and Geo-related projects at WMDS2016 - https://phabricator.wikimedia.org/T113526#1904163 (10GWicke) As it stands, this sounds like it would be a brainstorming / feature idea gathering session. @yurik, if your intention is to... [18:27:59] (03PS1) 10Ananay: Convert SandboxLink to use extension registration [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 [18:28:40] (03PS2) 10Ananay: Convert SandboxLink to use extension registration [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) [18:29:09] (03PS4) 10Nicoco007: Unread notifications now visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260943 (https://phabricator.wikimedia.org/T119597) [18:33:01] (03CR) 10jenkins-bot: [V: 04-1] Convert SandboxLink to use extension registration [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [18:51:04] 10MediaWiki-RfCs, 6Phabricator, 10Gerrit, 10Gitblit, and 5 others: [RfC]: Migrate code review / management to Phabricator from Gerrit - https://phabricator.wikimedia.org/T119908#1904172 (10demon) Eh, lots of projects have already decided that the closed-sourceness of Github doesn't bother them working on t... [19:20:14] 10MediaWiki-RfCs, 6Phabricator, 10Gerrit, 10Gitblit, and 5 others: [RfC]: Migrate code review / management to Phabricator from Gerrit - https://phabricator.wikimedia.org/T119908#1904174 (10Yurik) @demon, agree 144%. What is more important to us - attracting more open source developer contributions to buil... [19:47:40] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks good, works and could be approved, but there is the open thing about the constant CLDR_VERSION. @MtDu has asked how to handle this i" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [19:49:34] 10MediaWiki-extensions-CLDR, 3Google-Code-In-2015, 5Patch-For-Review: Convert cldr to use extension registration - https://phabricator.wikimedia.org/T87895#1904177 (10Florian) a:3MtDu [19:51:55] (03CR) 10Aklapper: "If Jenkins errors can be trusted, please add a license. https://www.mediawiki.org/wiki/Extension:SandboxLink implies that it's under MIT. " [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [19:52:46] (03CR) 10Aklapper: "Ignore my last comment... looks like it's in there already. Hmm." [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [19:52:48] (03PS1) 10Sn1per: Remove success=1 from Special:Preferences "Special Page" tab after notif display [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) [19:53:01] 10MediaWiki-extensions-SandboxLink, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Convert SandboxLink to use extension registration - https://phabricator.wikimedia.org/T122094#1904181 (10Florian) a:3ananayarora [19:53:46] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1904184 (10Aklapper) [19:53:48] 10WikiHiero, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Convert wikihiero to use extension registration - https://phabricator.wikimedia.org/T87995#1904182 (10Aklapper) 5Open>3Resolved a:3MtDu [19:55:15] (03CR) 10Florianschmidtwelzow: [C: 04-1] "One thing only :) Haven't tested yet, too." (031 comment) [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [19:57:32] (03CR) 10Legoktm: "The only usage I saw was in extensions/Wikibase/lib/tests/phpunit/LanguageNameLookupTest.php, so lets update that to use ExtensionRegistry" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [19:57:56] (03CR) 10jenkins-bot: [V: 04-1] Remove success=1 from Special:Preferences "Special Page" tab after notif display [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) (owner: 10Sn1per) [19:58:15] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1904185 (10Florian) a:5KHammerstein>3Justin-Leung @Justin-Leung Great to see that you want to work on this task! If you've any question, feel free to ask :) [19:59:55] (03CR) 10Sn1per: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) (owner: 10Sn1per) [20:00:44] FlorianSW: So should the updated thing look like this? https://dpaste.de/QCbm [20:01:36] MtDu: Hi! :) [20:01:54] MtDu: Just from looking at the code line, it looks good and should work :) [20:02:09] However, it would need some testing :) [20:02:13] MtDu: Hi. Merry Christmas! And great. :) How do you want me to push it? [20:02:23] FlorianSW: [20:02:23] MtDu: Hi. Merry Christmas! And great. :) How do you want me to push it? [20:02:29] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1904188 (10violetto) Thanks Justin, happy holidays to you too! mm [20:02:50] MtDu: what OS do you use? Windows or Linux/Unix? [20:03:12] FlorianSW: I'm on a windows machine. [20:03:29] FlorianSW: Gute Weihnachten! [20:03:49] MtDu: Ok, you're using git directly or any other client? (Dir auch frohe Weihnachten! :P) [20:03:58] FlorianSW: I use vagrant and git. [20:04:07] (sorry, I know that you wrote this in GCI, but I haven't the task open, now :P) [20:04:49] ok, can you install git review? (I haven't used vagrant so far :P) That would be the easiest way :) https://www.mediawiki.org/wiki/Gerrit/git-review#Installation [20:05:25] FlorianSW: I have that installed. That's what I used to push the other patch. I'm just asking how to push this one because there is no bug id for this, so I don't think it will let me push a patch. [20:05:56] FlorianSW: (sorry, that might not make sense ) [20:06:03] Is the hook installed? [20:06:11] If so, it should just amend it and add one automaticall [20:06:13] MtDu: Argh, sorry, I was confused and thought you were another GCI student :P You can push a change without a bug [20:06:29] Reedy: iirc he want to push a new change to another extension :) [20:06:37] sure [20:06:38] FlorianSW: So I would only have a commit message? No bug-id? [20:06:41] MtDu: but in your case, you can reuse the same task, it's related to it :) [20:06:56] MtDu: in practice, you can, but shouldn't in this case :) [20:07:10] but on my install, if there's no change id, it'll install the hook, amend, then push [20:07:16] Reedy: sorry, misunderstood you :( It's not my day :( [20:07:23] in my, too [20:07:38] Too much German beer? [20:07:48] DAS IST NICHT EFFICIENT [20:08:00] FlorianSW: So I would push the patch to the other extension (WikiData), and put the bug id of the cldr task? [20:08:13] Yeah [20:08:30] Reedy: I don't drink any alcohol :D [20:08:37] Maybe you should [20:08:40] (03CR) 10Legoktm: "Looks good pending fixing the composer error" [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [20:08:50] hmm, maybe that's the problem I have, you're right! :P [20:09:05] Everything can always be solved by (more|less) alcohol [20:09:17] My git review is saying I am aobut 30 commits ahead. Any ideas on how to fix this? [20:09:24] git fetch --all [20:09:25] that sounds like an universal solution for any problem :D [20:09:33] Usually means you've got multiple remotes [20:10:11] that seemed to work thanks [20:10:26] You can fix it another way, but it's a bit of a pain, and is "deprecated" [20:10:56] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1904190 (10Matthewrbowker) 5Open>3Resolved Appears to be fixed, there is a recent log entry. ``` intracer changed the visibility from "Custom Policy" to "Public (No Login Required)". ``` I will close t... [20:11:42] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260948 (owner: 10Jdlrobson) [20:11:46] FlorianSW: My Steam just changed itself to German [20:11:47] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Hmm, shouldn't there a way to add a complete new section?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260948 (owner: 10Jdlrobson) [20:11:59] Reedy: isn't that a good thing? :D [20:12:08] My german isn't great [20:12:36] Ok, then it isn't good :( Are you in germany or in GB? [20:12:54] GB/UK [20:13:22] hmm, strange :P [20:13:45] FlorianSW: Here you go. https://gerrit.wikimedia.org/r/#/c/260967/ :) [20:14:08] (03PS3) 10Ananay: Convert SandboxLink to use extension registration [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) [20:14:55] FlorianSW: Language teaching in the UK is awful [20:14:57] MtDu: ähm, sorry that I haven't mentioned this, but as far as I know, you shouldn't update the Wikidata repo manually, please use the Wikibase repo: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/4597bf6cc62eae89ba5a24e371aa49c390edf74b/lib/tests/phpunit/LanguageNameLookupTest.php [20:15:30] (03PS1) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [20:16:00] finally :) [20:16:15] FlorianSW: So which branch should I switch to? [20:16:17] Reedy: really? In Germany you need to learn english (if I'm right, from the 2nd class in these times) and a second one starting in the 7th class (e.g. fr or ru) [20:16:26] Yeah [20:16:41] I've got a qualification in German (exams at 16), but what they teach is mostly useless [20:16:45] Yeah I have a GCSE in german and I cant really say much [20:16:53] Heh, exactly [20:17:00] It's conversational, at best [20:17:01] German isn't really difficult :P [20:17:03] I can waffle about the enviroment and holidays but thats all [20:17:10] FlorianSW: Es tut mir leid [20:17:16] Thats too bad [20:17:18] mhutti1: You should choose more exciting topic branch names [20:17:24] I mean, we did a trip to Koln at Christmas [20:17:27] Reedy: Muss dir nicht Leid tun, hört man öfter, dass Deutsch eher schwierig zu erlenen ist :D [20:17:35] FlorianSW:^ [20:17:37] Pizza hut asked us if we wanted to take it away... We had no idea what they were saying [20:17:51] Some other customer just repeated it in English for us before we had chance to question it [20:17:58] Like this one: https://gerrit.wikimedia.org/r/#/c/260966/ [20:17:59] :D [20:18:15] (don't take what i said seriously) [20:18:16] MtDu: sorry, you should push to extensions/Wikibase instead of extensions/Wikidata :) [20:18:25] OH-: nice name :) [20:18:26] haha, yeah [20:18:35] Wikidata is a meta repo [20:18:57] FlorianSW: Will it still recognize that my change is there? [20:19:07] MtDu: hmm? [20:19:19] FlorianSW: Nevermind. I got it. Give me a minute. [20:19:20] Do you mean, will it run tests? [20:19:25] You can cherry pick it into the other repo [20:19:28] Roughly [20:19:51] It's a one line change, I think it's easier to copy paste :P [20:19:55] At least on windows hosts :D [20:19:55] (03CR) 10jenkins-bot: [V: 04-1] Convert SandboxLink to use extension registration [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [20:19:56] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1904196 (10Aklapper) @intracer: See https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects and https://www.mediawiki.org/wiki/Phabricator/Project_management (and their discussion pages). [20:20:20] haha [20:20:38] 6Phabricator, 6Project-Creators: Fix a 'Restricted project' - https://phabricator.wikimedia.org/T122423#1904198 (10Aklapper) @intracer: Please fix the Join Policy of #WMUA-Tech which is against the guidelines. Reopening this task. [20:20:53] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1904199 (10Aklapper) [20:20:59] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1903809 (10Aklapper) 5Resolved>3Open [20:21:11] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [20:22:09] ah, and MtDu It would be great, if you could mention the change ID of the cldr change in the Wikibase change's commit message. So anyone can simply go to the related change in cldr :) [20:22:29] FlorianSW: Will do. :) [20:22:35] (03CR) 10jenkins-bot: [V: 04-1] Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) (owner: 10Mhutti1) [20:22:43] 10MediaWiki-Special-pages, 7Community-Wishlist-Survey, 5Patch-For-Review: Improve date range searches on Special:Contributions - https://phabricator.wikimedia.org/T120733#1904201 (10Sn1per) p:5Triage>3Normal [20:23:37] Is it a dependancy? [20:23:59] Reedy: yap [20:24:08] Depends-On: I12345 [20:24:31] (03PS2) 10Mhutti1: Added a simple smoke test for export [core] - 10https://gerrit.wikimedia.org/r/260968 (https://phabricator.wikimedia.org/T116883) [20:24:45] ahh, right! MtDu you can add the full change ID as a "Depends-On:" line before the change ID :) [20:24:51] thanks for the hint Reedy :) [20:28:45] (03PS3) 10TheDJ: Remove non-working {{#special:mypage}} from help [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260952 (https://phabricator.wikimedia.org/T44107) [20:33:45] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks good" [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/260965 (https://phabricator.wikimedia.org/T122094) (owner: 10Ananay) [20:33:56] (03PS3) 10TheDJ: Use mw.Message#text() instead of plain() in wikiEditor.autoMsg() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260513 (owner: 10Krinkle) [20:34:25] (03CR) 10Fomafix: [C: 04-1] "A client side solution does not solve the problem when JavaScript is disabled." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) (owner: 10Sn1per) [20:35:05] (03PS2) 10Neonowy: Use OO.ui.confirm() for the confirmation dialog in ext.tmh.transcodetable [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260892 (https://phabricator.wikimedia.org/T117078) [20:36:04] FlorianSW: Here you go. https://gerrit.wikimedia.org/r/#/c/260969/ Hopefully that's right. :) [20:36:23] (03CR) 10Fomafix: [C: 031] Use mw.Message#text() instead of plain() in wikiEditor.autoMsg() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/260513 (owner: 10Krinkle) [20:36:35] MtDu: that looks better :) Thanks! I'll take a look at both changes later, ok? :) [20:36:50] FlorianSW: Ok. Do you want me to submit the task now? [20:37:00] MtDu: yes, please :) [20:38:09] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1904203 (10Krenair) And the edit policy? [20:38:21] FlorianSW: Submitted. :) [20:51:41] 10MobileFrontend: mw-notification-area present on every page load - https://phabricator.wikimedia.org/T122356#1904211 (10Florian) a:3Florian I'll take a look :) [20:55:18] (03PS1) 10Florianschmidtwelzow: Use mw.notify as an entry point for mediawiki notifications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261023 (https://phabricator.wikimedia.org/T122356) [20:59:20] 6Community-Liaison: Publish a VE newsletter for December 2015 - https://phabricator.wikimedia.org/T121906#1904216 (10Elitre) I also need to overwrite https://meta.wikimedia.org/wiki/VisualEditor/Newsletter/2015/December/vi . [21:01:35] (03PS2) 10Sn1per: Don't include success=1 in Special:Preferences "Special Page" tab link [core] - 10https://gerrit.wikimedia.org/r/260966 (https://phabricator.wikimedia.org/T26700) [21:02:48] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/Gather] (dev) - 10https://gerrit.wikimedia.org/r/260991 (owner: 10L10n-bot) [21:07:12] (03CR) 10Cindy-the-browser-test-bot: "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260979 (owner: 10L10n-bot) [21:09:51] (03CR) 10jenkins-bot: [V: 04-1] Use mw.notify as an entry point for mediawiki notifications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/261023 (https://phabricator.wikimedia.org/T122356) (owner: 10Florianschmidtwelzow) [21:11:08] 10MediaWiki-extensions-RelatedArticles, 6translatewiki.net: Unable to commit translations with defaultbranch=dev - https://phabricator.wikimedia.org/T120581#1856811 (10Raymond) See T122438 for same issue with Gather [21:16:02] FlorianSw: Sorry about the confusion. I was trying to see the error and came upon lego's comment on my other patch, so I took his advice to see if it would fix the errors. I will fix it now. Should it be like this? https://dpaste.de/VyBd#L51 [21:16:38] FlorianSW:^ [21:20:16] (03PS10) 10TheDJ: Check each Special:Preferences input for changes [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [21:22:17] (03CR) 10TheDJ: Check each Special:Preferences input for changes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [21:27:04] (03CR) 10TheDJ: [C: 032] "Discretionary self merge" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/257407 (owner: 10TheDJ) [21:27:18] 6Phabricator, 6Project-Creators: Fix restricted project "WMUA-Tech" - https://phabricator.wikimedia.org/T122423#1904241 (10Luke081515) 5Open>3Resolved All policys are at setting "all users" (visibilty is public) [21:27:18] (03CR) 10jenkins-bot: [V: 04-1] Check each Special:Preferences input for changes [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [21:28:50] (03CR) 10TheDJ: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [21:31:14] (03CR) 10jenkins-bot: [V: 04-1] Remove an old test that doesn't work anymore. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/257407 (owner: 10TheDJ) [21:32:42] (03CR) 10TheDJ: [V: 032] "stupid qunit" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/257407 (owner: 10TheDJ) [21:33:28] (03CR) 10TheDJ: [C: 032] Remove an old test that doesn't work anymore. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/257407 (owner: 10TheDJ) [21:36:29] (03CR) 10TheDJ: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [21:37:29] (03Merged) 10jenkins-bot: Remove an old test that doesn't work anymore. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/257407 (owner: 10TheDJ) [21:44:54] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1904244 (10Justin-Leung) @Florian @violetto thank you! I was wondering where the code base is located for this change? Or if I need to install any extensions. Thank you [21:48:35] FlorianSW: All is good. I hope. https://gerrit.wikimedia.org/r/#/c/260969/ :) [21:51:21] (03CR) 10Paladox: "Needs re c+2 again." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [21:51:37] (03CR) 10Paladox: Remove standalone mwEmbedLoader [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [21:55:11] (03PS1) 10Aaron Schulz: Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 [21:55:30] (03PS1) 10Aaron Schulz: Remove pointless wfSuppressWarnings() call [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261028 [21:59:48] (03CR) 10jenkins-bot: [V: 04-1] Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 (owner: 10Aaron Schulz) [22:08:52] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015: Provide short URL to file description page in imageinfo API - https://phabricator.wikimedia.org/T122439#1904251 (10Tgr) 3NEW [22:11:06] (03CR) 10TheDJ: "I've added yuri to the reviewers in the hopes that he can somewhat explain the difference here between the buttons and why that might be d" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [22:14:41] 10MediaWiki-Special-pages, 7Easy, 5Patch-For-Review: Update dialog shown when clicking on the special page tab after saving preferences - https://phabricator.wikimedia.org/T26700#1904259 (10Fomafix) The //Printable version// also generates a success message. [22:17:10] (03CR) 10TheDJ: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [22:17:21] * thedj kicks qunit [22:18:16] AaronSchulz: why are they pointless exactly ? [22:19:16] (03CR) 10TheDJ: [C: 032] Remove standalone mwEmbedLoader [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [22:25:07] (03Merged) 10jenkins-bot: Remove standalone mwEmbedLoader [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [22:31:07] 10MediaWiki-extension-requests, 10Parsoid, 6Wikisource: Request for feature: automatic figure and equation (formula) numbering - https://phabricator.wikimedia.org/T7600#1904261 (10Ruphy) Hi all, in the WikiToLearn project (see wikitech-l for a brief introduction of what we do), we would love to support this... [22:31:59] 7Design, 10MobileFrontend, 3Google-Code-In-2015: Talk overlay inputs don't have borders - https://phabricator.wikimedia.org/T104836#1904265 (10Florian) The code is located in the [[ https://www.mediawiki.org/wiki/Extension:MobileFrontend | MobileFrontend extension ]], hosted in gerrit: https://gerrit.wikimed... [22:33:22] FlorianSW: New patch. https://gerrit.wikimedia.org/r/#/c/260969/4 [22:36:28] FlorianSW|away:^ [22:37:58] (03CR) 10Florianschmidtwelzow: [C: 032] Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [22:38:10] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1904273 (10Florian) [22:38:12] 10MediaWiki-extensions-CLDR, 3Google-Code-In-2015, 5Patch-For-Review: Convert cldr to use extension registration - https://phabricator.wikimedia.org/T87895#1904272 (10Florian) 5Open>3Resolved [22:43:30] (03CR) 10jenkins-bot: [V: 04-1] Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [22:45:22] (03CR) 10TheDJ: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [22:46:19] (03CR) 10Florianschmidtwelzow: [C: 032] "Ok Jenkins, 2nd try, it's christmas time, so... come on! :D" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [22:52:47] (03Merged) 10jenkins-bot: Convert cldr to use extension registration [extensions/cldr] - 10https://gerrit.wikimedia.org/r/260956 (https://phabricator.wikimedia.org/T87895) (owner: 10MtDu) [23:11:17] (03CR) 10TheDJ: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [23:18:27] (03CR) 10TheDJ: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [23:19:10] 7 rechecks [23:26:54] (03CR) 10TheDJ: [C: 032] Check each Special:Preferences input for changes [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [23:31:54] (03CR) 10Yaron Koren: [C: 032 V: 031] "Fantastic! This works great, and the new "HOLDS NOT" and "HOLDS NOT LIKE" options are a nice addition to the functionality. Thank you." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/260951 (owner: 10Ed Hoo) [23:32:54] (03Merged) 10jenkins-bot: Fix HOLDS operator parsing and adds corresponding NOT functionality [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/260951 (owner: 10Ed Hoo) [23:33:26] (03CR) 10jenkins-bot: [V: 04-1] Check each Special:Preferences input for changes [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [23:37:46] (03CR) 10TheDJ: [C: 032] Check each Special:Preferences input for changes [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [23:39:21] (03PS13) 10TheDJ: LivePreview: Update page status indicators [core] - 10https://gerrit.wikimedia.org/r/186757 (https://phabricator.wikimedia.org/T87557) (owner: 10Gerrit Patch Uploader) [23:45:41] (03CR) 10jenkins-bot: [V: 04-1] LivePreview: Update page status indicators [core] - 10https://gerrit.wikimedia.org/r/186757 (https://phabricator.wikimedia.org/T87557) (owner: 10Gerrit Patch Uploader) [23:46:57] (03Merged) 10jenkins-bot: Check each Special:Preferences input for changes [core] - 10https://gerrit.wikimedia.org/r/255652 (https://phabricator.wikimedia.org/T119732) (owner: 10Sn1per) [23:50:12] (03CR) 10TheDJ: [C: 032] LivePreview: Update page status indicators [core] - 10https://gerrit.wikimedia.org/r/186757 (https://phabricator.wikimedia.org/T87557) (owner: 10Gerrit Patch Uploader) [23:50:51] 10MediaWiki-User-preferences, 5Patch-For-Review: Special:Preferences does not display unsaved preferences warning if changes made before JS is done loading - https://phabricator.wikimedia.org/T119732#1904290 (10TheDJ) 5Open>3Resolved [23:54:47] (03CR) 10Yurik: "The discussion was moved to archive. Basically they were discussing how best to create an icon for the bold font for Chechen wiki. I will " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [23:56:34] (03CR) 10jenkins-bot: [V: 04-1] LivePreview: Update page status indicators [core] - 10https://gerrit.wikimedia.org/r/186757 (https://phabricator.wikimedia.org/T87557) (owner: 10Gerrit Patch Uploader)