[00:00:08] (03PS6) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [00:00:10] (03PS1) 10Jdlrobson: DONOTMERGE: For testing [core] - 10https://gerrit.wikimedia.org/r/260163 [00:00:20] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015, 7I18n: Add gender support to Multimediaviewer-text-embed-credit-text-tbls - https://phabricator.wikimedia.org/T85685#1891988 (10MtDu) [00:01:34] (03PS7) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [00:02:07] 10MediaWiki-Interface: Interwiki links broken with Russian interface language - https://phabricator.wikimedia.org/T121836#1891995 (10MaxBioHazard) I use Chrome and Monobook. {F3121861} [00:03:38] (03CR) 10PranavK: "So will the task in GCI be accepted?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/259655 (https://phabricator.wikimedia.org/T115874) (owner: 10PranavK) [00:04:04] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint Zapp: Fix GeoIP lookup for IPv6 - https://phabricator.wikimedia.org/T121938#1891998 (10awight) [00:04:21] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint Zapp: Fix GeoIP lookup for IPv6 - https://phabricator.wikimedia.org/T121938#1891975 (10awight) [00:05:49] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: composer broken on DonationInterface vendor repo - https://phabricator.wikimedia.org/T121932#1892002 (10Reedy) p:5Triage>3Low [00:05:55] 3Mobile-Content-Service: Remove transclusion data-mw provided by Parsoid - https://phabricator.wikimedia.org/T121881#1892012 (10bearND) I'll need to check with @GWicke about the comment out function since he wrote it. We do actually already remove the data-mw attributes in most cases, see applyOptionalParsoidSpe... [00:07:01] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: composer broken on DonationInterface vendor repo - https://phabricator.wikimedia.org/T121932#1891904 (10Reedy) https://github.com/composer/composer/issues/4717 Filed an upstream task. Suspecting it's going to be WONTFIX-ed, but I tried. It is fa... [00:08:16] (03CR) 10jenkins-bot: [V: 04-1] DONOTMERGE: For testing [core] - 10https://gerrit.wikimedia.org/r/260163 (owner: 10Jdlrobson) [00:09:03] (03CR) 10jenkins-bot: [V: 04-1] WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [00:11:11] 6Reading-Admin: Review Reading Web Boards, Refine Existing Epics / Create New Ones, Groom Backlog for Q3 - https://phabricator.wikimedia.org/T121942#1892025 (10dr0ptp4kt) 3NEW a:3dr0ptp4kt [00:11:49] (03Abandoned) 10Reedy: Update zordius/lightncandy to v0.93 [vendor] - 10https://gerrit.wikimedia.org/r/260158 (owner: 10Reedy) [00:11:49] 10CirrusSearch, 6Discovery: CompletionSuggested not enabled until I force refreshed the page - https://phabricator.wikimedia.org/T121943#1892034 (10hashar) 3NEW [00:13:56] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Wikimedia-Fundraising: Donors need an option to pay from another country - https://phabricator.wikimedia.org/T96047#1892043 (10awight) There is no solution that I know of, we'll always have some number of who fall into this zone. Use cases:... [00:13:58] (03CR) 10Legoktm: [C: 04-1] Converted NavigationTiming to new extension registration (033 comments) [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [00:14:48] 6Reading-Admin: Visioning, Mock Press Release for Q3 Reading Web Outcomes - https://phabricator.wikimedia.org/T121944#1892049 (10dr0ptp4kt) 3NEW [00:16:12] 10MediaWiki-Releasing: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#1892064 (10GWicke) After some more testing on Jessie labs VMs I have now created a simple shell script to start the vms. This drops the dependency on docker-compose, making it even easier to get started.... [00:17:36] (03PS8) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [00:18:33] (03PS2) 10Reedy: Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 [00:20:57] 10Gather: Search box bug on Special:Gather - https://phabricator.wikimedia.org/T121946#1892083 (10Quiddity) 3NEW [00:21:30] 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Librarization: Update zordius/lightncandy v0.89 - https://phabricator.wikimedia.org/T121947#1892090 (10Reedy) 3NEW [00:22:10] 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 6Collaboration-Team-Backlog, 10Flow, 10Librarization: Update zordius/lightncandy v0.89 - https://phabricator.wikimedia.org/T121947#1892097 (10Reedy) [00:23:39] (03CR) 10jenkins-bot: [V: 04-1] WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [00:23:45] (03PS1) 10Smalyshev: Add implementation for TextCat language detection [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260164 [00:25:12] (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [00:25:52] 10Reading Web Planning, 6Reading-Admin: [EPIC] Improve in-article language switching on mobile - https://phabricator.wikimedia.org/T121919#1892106 (10dr0ptp4kt) [00:26:01] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: GeoIP lookup for IPv6 connections delays banner loading - https://phabricator.wikimedia.org/T121925#1892108 (10awight) [00:26:04] 10Reading Web Planning: Language button on footer - https://phabricator.wikimedia.org/T119658#1892110 (10dr0ptp4kt) [00:26:17] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [00:26:33] 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1892113 (10kaldari) The first iteration for this is bas... [00:26:39] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: GeoIP lookup for IPv6 connections delays banner loading - https://phabricator.wikimedia.org/T121925#1891807 (10awight) [00:26:42] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint Zapp: Fix GeoIP lookup for IPv6 - https://phabricator.wikimedia.org/T121938#1892116 (10awight) [00:26:50] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [00:27:33] (03PS73) 10Anomie: WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [00:27:55] (03PS1) 10Reedy: Update zordius/lightncandy to v0.23 [vendor] - 10https://gerrit.wikimedia.org/r/260165 [00:30:13] legoktm: Thanks for renaming that task. It sounds more funny now :P [00:30:20] All FR at work to make sure I can see a banner :D [00:30:21] (03PS1) 10Reedy: Update zordius/lightncandy to v0.23 [core] - 10https://gerrit.wikimedia.org/r/260166 [00:33:12] (03PS2) 10Reedy: Update symfony/process to v3.0.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 [00:33:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) (owner: 10Anomie) [00:34:03] (03CR) 10Reedy: [C: 04-1] ""php": ">=5.5.9"" [vendor] - 10https://gerrit.wikimedia.org/r/260157 (owner: 10Reedy) [00:34:34] (03CR) 10jenkins-bot: [V: 04-1] Update symfony/process to v3.0.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 (owner: 10Reedy) [00:35:13] (03PS3) 10Reedy: Update symfony/process to ~2.6 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 [00:35:25] (03PS9) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [00:35:27] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260164 (owner: 10Smalyshev) [00:36:17] (03CR) 10jenkins-bot: [V: 04-1] Update symfony/process to ~2.6 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 (owner: 10Reedy) [00:36:40] (03CR) 10jenkins-bot: [V: 04-1] Update zordius/lightncandy to v0.23 [vendor] - 10https://gerrit.wikimedia.org/r/260165 (owner: 10Reedy) [00:38:24] (03PS1) 10Jdlrobson: Welcome to the future of module loading in ResourceLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260167 [00:39:28] (03CR) 10Ed Hoo: "Here we go," [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 (owner: 10Ed Hoo) [00:39:36] (03PS2) 10Reedy: Update symfony/process to v2.6.11 [vendor] - 10https://gerrit.wikimedia.org/r/260157 [00:40:21] Oh ffs [00:42:01] (03CR) 10jenkins-bot: [V: 04-1] WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [00:42:09] 10Wikimedia-Wikimania-Scholarships: Use banana-checker for wikimedia/wikimania-scholarships - https://phabricator.wikimedia.org/T121927#1892154 (10bd808) I'd really like to move to `composer test` for this project as well but that is blocked by {T92605} [00:42:10] (03PS3) 10Reedy: Update symfony/process to v2.6.11 [vendor] - 10https://gerrit.wikimedia.org/r/260157 [00:45:06] (03PS3) 10Reedy: Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 [00:45:38] (03CR) 10jenkins-bot: [V: 04-1] Update symfony/process to v2.6.11 [vendor] - 10https://gerrit.wikimedia.org/r/260157 (owner: 10Reedy) [00:47:06] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/260157 (owner: 10Reedy) [00:47:39] 7Mobile: Vertical lines produced by templates Clade and Phylogeny do not appear on smartphone in the Mobile FrontEnd - https://phabricator.wikimedia.org/T121952#1892174 (10Thnidu) 3NEW [00:48:57] (03CR) 10jenkins-bot: [V: 04-1] Welcome to the future of module loading in ResourceLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260167 (owner: 10Jdlrobson) [00:48:59] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/260165 (owner: 10Reedy) [00:49:03] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [00:51:29] (03PS10) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [00:51:37] 10CirrusSearch, 6Discovery: URL-style internal wikilinks are not easily searchable - https://phabricator.wikimedia.org/T121379#1892191 (10Cpiral) [00:52:25] (03PS1) 10Catrope: Add secondary link to Flow board for flow-thanks notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260168 [00:53:24] (03PS2) 10Catrope: Add secondary link to Flow board for flow-thanks notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260168 (https://phabricator.wikimedia.org/T121954) [00:54:38] (03CR) 10jenkins-bot: [V: 04-1] Update symfony/process to v2.6.11 [vendor] - 10https://gerrit.wikimedia.org/r/260157 (owner: 10Reedy) [00:55:23] mw.util.addPortletLink is misbehaving [00:56:12] (03CR) 10jenkins-bot: [V: 04-1] Add secondary link to Flow board for flow-thanks notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260168 (https://phabricator.wikimedia.org/T121954) (owner: 10Catrope) [00:56:35] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/260157 (owner: 10Reedy) [00:57:11] (03CR) 10jenkins-bot: [V: 04-1] WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) (owner: 10Jdlrobson) [01:00:00] (03PS1) 10Reedy: Update cssjanus/cssjanus to v1.1.2 [core] - 10https://gerrit.wikimedia.org/r/260169 [01:00:02] (03PS1) 10Reedy: Update nmred/kafka-php to v0.1.5 [core] - 10https://gerrit.wikimedia.org/r/260170 [01:02:31] 6Reading-Admin: Refine quarterly goalsetting process - https://phabricator.wikimedia.org/T121958#1892233 (10dr0ptp4kt) 3NEW [01:07:53] (03CR) 10jenkins-bot: [V: 04-1] Update nmred/kafka-php to v0.1.5 [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:08:27] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:08:38] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [01:08:52] (03CR) 10Reedy: "recheck" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/260160 (owner: 10Reedy) [01:09:01] (03CR) 10Reedy: "recheck" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 (owner: 10Reedy) [01:09:24] bd808: still around? [01:09:33] (03CR) 10jenkins-bot: [V: 04-1] Update symfony/process to ~2.6 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 (owner: 10Reedy) [01:09:39] gwicke: kinda. what's up? [01:10:07] * bd808 is waiting for the pizza and beer guy to show up with dinner [01:10:09] hey; I'm wondering if nginx would be the better choice for a minimal mediawiki image [01:10:13] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica to v2.3.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/260160 (owner: 10Reedy) [01:10:55] gwicke: it might be I guess. I'm an Apache geek and never really have learned nginx well [01:11:11] are you worried about memory footprint? [01:11:18] Krenair: ping :) [01:11:45] bd808: a little bit, but configuration, spdy support etc all seem to be simpler with nginx [01:12:17] FlorianSW, pong [01:12:47] gwicke: yeah if you are trying to setup spdy or http/2 nginx will probably be easier [01:13:05] Krenair: Hi :) I hope you can help me: Can you say me, when I should use WindowTool (https://github.com/wikimedia/VisualEditor/blob/master/src/ui/tools/ve.ui.WindowTool.js) and when FragmentWindowTool (https://github.com/wikimedia/VisualEditor/blob/master/src/ui/tools/ve.ui.FragmentWindowTool.js) in VisualEditor context? [01:13:14] bd808: https://letsencrypt.org/ seems to work quite well [01:13:22] nice [01:13:28] I see both usages for tools: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/search?utf8=%E2%9C%93&q=WindowTool&type=Code & https://github.com/wikimedia/mediawiki-extensions-VisualEditor/search?utf8=%E2%9C%93&q=FragmentWindowTool&type=Code [01:13:38] I ended up switching lighttpd -> nginx for letsencrypt [01:13:47] Then when I did it, the nginx support was actually disabled [01:14:11] FlorianSW, um... actually I don't know much about either of those classes [01:14:24] Reedy: yeah, I think the apache support is still more mature [01:14:34] (03CR) 10jenkins-bot: [V: 04-1] Update nmred/kafka-php to v0.1.5 [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:14:41] I did this a couple of months ago back when it was in closed beta [01:14:58] FlorianSW, I think the point is to make a simple tool that opens a window [01:14:59] *nod* [01:15:33] Reedy: did you set up a cron script to renew every three months? [01:15:38] Nah [01:15:42] (03CR) 10jenkins-bot: [V: 04-1] Update ruflin/elastica v2.3.1 [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [01:16:04] Krenair: ah, ok, sorry for bother you with the question :) But thanks for your indication. I think I will simply try and upload a change and wait for suggestions from people who may know that :) (Maybe esanders?) [01:16:06] With the amount of ongoing development to letsencrypt, git pull needed first etc [01:16:12] Not much work to do it manually [01:16:16] I will eventually though [01:16:20] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1892265 (10Volker_E) 3NEW a:3Volker_E [01:16:41] Krenair: ah, I think the commit message makes it a bit more clear: * ve.ui.WindowTool, which becomes active iff the associated window [01:16:42] is open. [01:16:42] * ve.ui.FragmentWindowTool, which becomes active iff the selected [01:16:42] fragment covers a related model. [01:16:42] https://gerrit.wikimedia.org/r/#/c/257387/ [01:16:45] FlorianSW, I guess it would help if I knew more about what you're doing :) [01:16:54] ahh [01:16:56] Reedy: I'm one of those who easily forget.. [01:17:23] Krenair: ah, yes, sorry :) I'm trying to fix https://phabricator.wikimedia.org/T121596 and I know that it is caused by https://github.com/wikimedia/VisualEditor/commit/e5367796305a849804eea958fe95095be4f8e91c mainly, because the WindowTool doesn't has a "isCompatibleWith" method anymore. [01:17:33] Mine expires end of January, so at the start, I'll probably update the certs [01:17:47] Now think about, if the TransclusionDialog should be a FragmentWindowTool or if the WindowTool needs a isCompatibleWith method :) [01:18:44] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:18:45] and with the commit mesasge in mind I would say, that it should be a FragmentWindowTool :) [01:19:38] 7Design, 10UI-Standardization, 10OOjs-UI, 10VisualEditor, and 2 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1892286 (10Volker_E) I actually meant a picture in here, because the jsfiddle might change (given its link to the github project) or ge... [01:22:03] gwicke: I set up calendar reminders 2 weeks before my certs expire [01:23:04] legoktm: that's the human cron job ;) [01:24:19] 10Living-Style-Guide, 10UI-Standardization, 10OOjs-UI: Use `not-allowed` cursor for disabled elements within WMF products - https://phabricator.wikimedia.org/T121960#1892316 (10Volker_E) [01:25:04] (03CR) 10jenkins-bot: [V: 04-1] Update nmred/kafka-php to v0.1.5 [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:25:13] stfu jenkins [01:26:16] (03PS1) 10Florianschmidtwelzow: Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260172 (https://phabricator.wikimedia.org/T121596) [01:26:56] (03CR) 10jenkins-bot: [V: 04-1] Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260172 (https://phabricator.wikimedia.org/T121596) (owner: 10Florianschmidtwelzow) [01:27:15] (03PS2) 10Florianschmidtwelzow: Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260172 (https://phabricator.wikimedia.org/T121596) [01:35:27] mw.util.addPortletLink (specifically the 'nextnode' parameter) does not seem to work as expected [01:35:36] * Hydronium digs deeper [01:35:51] Hydronium: file a task :) [01:37:06] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:38:24] * FlorianSW thinks, that Jenkins had a bad day, right? :( [01:38:32] :P lemme check the source code to make sure I'm not misusing it [01:38:34] His minions are misbehaving [01:38:59] And some of my commits have some nice weird dependancy trees [01:39:04] Probably doesn't like that much :D [01:39:35] I think, that's the dark side of Jenkins :) [01:40:57] a good time to go sleep. Good night! :) [01:42:53] 10MediaWiki-API, 10MediaWiki-extensions-ApiSandbox, 6Reading-Infrastructure-Team, 5Patch-For-Review: Merge ApiSandbox extension into core - https://phabricator.wikimedia.org/T89386#1892388 (10Liuxinyu970226) [01:42:55] 10MediaWiki-General-or-Unknown, 7Tracking: Extensions that should really be core functionality (tracking) - https://phabricator.wikimedia.org/T28751#1892387 (10Liuxinyu970226) [01:43:02] (03CR) 10jenkins-bot: [V: 04-1] Update nmred/kafka-php to v0.1.5 [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [01:43:46] 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 6Collaboration-Team-Backlog, 10Flow, 10Librarization: Update zordius/lightncandy v0.89 - https://phabricator.wikimedia.org/T121947#1892399 (10Reedy) [01:44:29] 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 6Collaboration-Team-Backlog, 10Flow, 10Librarization: Update zordius/lightncandy v0.89 - https://phabricator.wikimedia.org/T121947#1892090 (10Reedy) [01:45:48] 6Community-Liaison, 6Developer-Relations, 3DevRel-December-2015: A printed panel explaining Community Liaison and Developer Relations - https://phabricator.wikimedia.org/T120920#1864789 (10Rdicerb) Thank you, @mcruzWMF! [01:47:40] (03PS11) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [01:48:03] (03PS2) 10Jdlrobson: Welcome to the future of module loading in ResourceLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260167 [01:48:37] (03PS12) 10Jdlrobson: WIP/DONOTMERGE(yet): Modern module loading [core] - 10https://gerrit.wikimedia.org/r/260071 (https://phabricator.wikimedia.org/T108655) [01:48:58] (03CR) 10jenkins-bot: [V: 04-1] Welcome to the future of module loading in ResourceLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260167 (owner: 10Jdlrobson) [01:50:34] 6Increasing content coverage, 6Research-and-Data, 3RD-2016Q3: [Epic] Article recommendation to more users - https://phabricator.wikimedia.org/T121962#1892406 (10leila) 3NEW [02:03:44] (03CR) 10VolkerE: Align to CSS coding guidelines and fix CSSLint errors & warnings (032 comments) [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [02:05:06] (03CR) 10VolkerE: "@Krinkle Just in case, on resetting MS proprietary filters: http://stackoverflow.com/questions/1768161/how-do-i-reset-or-override-ie-css-f" [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [02:11:20] 10MediaWiki-Vagrant, 10Flow, 3Collaboration-Team-Current: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1892421 (10Mattflaschen) AFAICT, this would break update.php done naively, since that expects to use the main database. I brought up t... [02:20:49] Reedy: nevermind, my blind self had been missing a parameter -_- [02:27:46] (03CR) 10Mattflaschen: [C: 032] Fix definition and call for getModerationChangeTypes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259875 (owner: 10Mattflaschen) [02:28:47] (03PS1) 10saper: Non-destructive migration, allow update on 1.24. [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/260173 [02:29:19] (03CR) 10jenkins-bot: [V: 04-1] Non-destructive migration, allow update on 1.24. [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/260173 (owner: 10saper) [02:32:05] 10MediaWiki-extensions-HitCounters: Installation does not work for MW 1.26+ due to removal of hitcounter table - https://phabricator.wikimedia.org/T120216#1892427 (10saper) I have published https://gerrit.wikimedia.org/r/#/c/260173/ it should be now possible to migrate the tables even on 1.24, before 1.25 or... [02:33:15] (03Merged) 10jenkins-bot: Fix definition and call for getModerationChangeTypes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259875 (owner: 10Mattflaschen) [02:54:20] (03CR) 10Ricordisamoa: "Getting the special click prevented may look surprising at first. However, for what it's worth, I use to keep Ctrl pressed just in case me" [core] - 10https://gerrit.wikimedia.org/r/259786 (owner: 10Krinkle) [03:19:02] 10MediaWiki-extensions-Babel, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Gadgets: Language code «no» used during addition of labels - https://phabricator.wikimedia.org/T116168#1892429 (10Liuxinyu970226) @jeblad: ^-^ [03:32:14] 10Wikimedia-Site-Requests, 7Community-consensus-needed, 5Patch-For-Review: Set 'WP' namespace alias to NS_PROJECT in my.wikipedia - https://phabricator.wikimedia.org/T119807#1892430 (10Liuxinyu970226) [03:34:03] 10MediaWiki-Database, 7Wikimedia-log-errors, 7user-notice: Query Special Pages periodically fail. - https://phabricator.wikimedia.org/T113721#1892432 (10Krenair) This is currently running on terbium: ```UID PID PPID C STIME TTY TIME CMD www-data 20519 20510 0 Dec16 ? 00:00:00 /bin/b... [03:35:10] 10Wikimedia-Site-Requests: Ladino Wikipedia: Requesting installation of Extension:SandboxLink - https://phabricator.wikimedia.org/T121524#1892435 (10Liuxinyu970226) [03:47:38] 10Commons-App-Android-Upload: Phase 1: Display nearby categories when user uploads a photo - https://phabricator.wikimedia.org/T119163#1892442 (10josephine_l) [03:47:39] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1892441 (10josephine_l) 5Open>3Resolved [04:11:15] (03PS4) 10Gilles: Configure thumbor video support [vagrant] - 10https://gerrit.wikimedia.org/r/259727 (https://phabricator.wikimedia.org/T120205) [04:12:48] 10MediaWiki-extensions-AbuseFilter: Abusefilter moved_to_namespace variable has unexpected values - https://phabricator.wikimedia.org/T121963#1892447 (10Xaosflux) 3NEW [04:12:51] (03CR) 10Gilles: Configure thumbor video support (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/259727 (https://phabricator.wikimedia.org/T120205) (owner: 10Gilles) [04:18:38] (03PS6) 10Gilles: Thumbor filter to sharpen conditionally [thumbor/conditional-sharpen] - 10https://gerrit.wikimedia.org/r/251427 (https://phabricator.wikimedia.org/T112545) [04:18:52] (03CR) 10Gilles: Thumbor filter to sharpen conditionally (032 comments) [thumbor/conditional-sharpen] - 10https://gerrit.wikimedia.org/r/251427 (https://phabricator.wikimedia.org/T112545) (owner: 10Gilles) [04:22:10] (03Abandoned) 10Gilles: Define Thumbor subprocess limits [vagrant] - 10https://gerrit.wikimedia.org/r/258121 (owner: 10Gilles) [04:28:34] (03PS4) 10Gilles: Custom thumbor filter for conditional sharpening [vagrant] - 10https://gerrit.wikimedia.org/r/249755 (https://phabricator.wikimedia.org/T112545) [04:29:03] T117837: I need to client-side display a Page History tab [04:29:09] 10MediaWiki-Internationalization, 10Deployment-Systems, 6Performance-Team, 7Performance: Experiment with plain .php files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740#1892455 (10EBernhardson) Since this is resolved, what was the result of the experiment? [04:29:19] Skins like Vector use a separate message i.e. vector-page-history or something similar to that [04:29:45] How would I include that message for ResourceLoader? [04:29:48] oh wait, I think I got it [04:30:22] (03PS5) 10Gilles: Custom thumbor filter for conditional sharpening [vagrant] - 10https://gerrit.wikimedia.org/r/249755 (https://phabricator.wikimedia.org/T112545) [04:31:23] (03CR) 10Gilles: [C: 04-1] "Depends on I49ec108d11a2bfd544e454e073f872f52b9148c1" [vagrant] - 10https://gerrit.wikimedia.org/r/249755 (https://phabricator.wikimedia.org/T112545) (owner: 10Gilles) [04:41:47] 10MediaWiki-extensions-SemanticFormsInputs: datepicker in MW 1.26 - https://phabricator.wikimedia.org/T121964#1892457 (10Kc5vcx) 3NEW [05:05:41] (03PS1) 10EBernhardson: Remove unused searchSuggest experiment [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 [05:06:40] (03CR) 10Krinkle: "Thanks Ricordisamoa, that's exactly what I was hoping people would think. It's not just me." [core] - 10https://gerrit.wikimedia.org/r/259786 (owner: 10Krinkle) [05:06:50] (03Abandoned) 10Krinkle: mediawiki.page: Don't interfere with special clicks in ajax patrol and watch [core] - 10https://gerrit.wikimedia.org/r/259786 (owner: 10Krinkle) [05:07:26] (03CR) 10Krinkle: [C: 031] Remove unused searchSuggest experiment [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 (owner: 10EBernhardson) [05:10:22] (03CR) 10Krinkle: "Should the $wgWMEEnableCompletionExperiment variable be removed as well?" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 (owner: 10EBernhardson) [05:10:42] (03PS2) 10EBernhardson: Remove unused searchSuggest experiment [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 [05:10:56] (03CR) 10EBernhardson: "yes it should, removed now" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 (owner: 10EBernhardson) [05:11:59] (03CR) 10Krinkle: [C: 032] Remove unused searchSuggest experiment [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 (owner: 10EBernhardson) [05:12:45] (03Merged) 10jenkins-bot: Remove unused searchSuggest experiment [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/260175 (owner: 10EBernhardson) [05:12:52] ebernhardson: Can you also prepare a patch to remove the wmg and wg variants in mediawiki-config? We could push that one out any time you like since it'll fallback gracefully in both directions (as being false by default) [05:13:22] Ideally slightly before the train so that it'll be disabled at once instead of slowly over 3 days [05:16:09] Krinkle: sure [05:16:58] Krinkle: and maybe this is a silly question, but unrelated to this (but our other thing in WME). Is there any sane way to share information between wiki's in tests? One test we run gives people interwiki search results and we kinda gave up on linking the data [05:17:49] ebernhardson: I'm not sure exactly what you mean. [05:18:02] ebernhardson: interwiki ajax? Or building an interwiki ? [05:18:26] Krinkle: i mean in the search satisfaction schema we give people a session id in localstorage and measure their dwell time on pages for 10 minutes after their search [05:18:38] Krinkle: but with interwiki links that we now serve up, we don't have access to that info [05:18:48] (on the other side of the interwiki link) [05:19:21] (03CR) 10Krinkle: Align to CSS coding guidelines and fix CSSLint errors & warnings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [05:19:23] i'm also dubious about collecting dwell time past the first page...but our analyists seem to have found it useful [05:20:12] ebernhardson: You mean associating sessions across domains? [05:20:17] Krinkle: yes [05:20:33] That'd be difficult to do beyond logged-in users. [05:20:54] (in which case the server could use central auth session id) [05:21:15] Krinkle: hmm, well that would at least be some data i suppose even if its only logged in users. thanks for the idea! [05:21:35] Could be done in theory using a domain like login.wikimedia.org to act as liaison for the session id cookie. [05:21:44] (for logged-out users) [05:21:53] but that'll require a fair amount of infrastructure and sec review. [05:22:02] Aiming for logged-in users at first will get you a long way [05:22:17] which, now that I think about it, wouldn't even require a session id per se since our accounts are unified now. [05:22:27] so username is all you need. [05:22:38] ofc you'd want to anonimise [05:23:11] oh indeed, the usernames now uniquely identify someone [05:23:41] we would need some sort of rotating salt to hash with to anonimise them, hmm [05:24:25] but if its delivered to js...everyone knows the salt for a given time. might have to check with analytics about re-using the salt they use on ip's [05:24:30] (on the backend) [05:25:54] ebernhardson: We could also have the server-side generate a random session token (not the real session token, but any token that lives for remainder of the session) and store it in the ca session and export on the page via mw.config [05:26:15] e.g. mw.config wgCentralAuthSessionRand or something like that [05:26:21] which would naturally match between domains [05:26:37] very cheap in overhead [05:26:44] yea that makes sense [05:47:50] 10MediaWiki-extensions-BounceHandler, 7Documentation, 3Google-Code-In-2015: Create documentation for configuring BounceHandler with Postfix - https://phabricator.wikimedia.org/T114252#1892464 (1001tonythomas) >>! In T114252#1891449, @Aklapper wrote: > That is up to your judgment and if you feel like being ab... [06:01:02] (03PS1) 10EBernhardson: Add some request set payload values [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260177 [06:01:13] (03PS2) 10EBernhardson: Add some request set payload values [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260177 [06:07:16] 10Wikimedia-Site-Requests: update namespaces for gujarati wikiquote (gu.wikiquote) - https://phabricator.wikimedia.org/T121853#1892471 (10BhatakatiAatma) [06:10:01] (03PS3) 10EBernhardson: Add some request set payload values [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260177 [06:11:02] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Wikimedia-Fundraising: Donors need an option to pay from another country - https://phabricator.wikimedia.org/T96047#1892473 (10Krinkle) > Allow donors to manually switch their country. There should be a flag icon on every donation page, which... [06:12:19] (03PS2) 10Krinkle: Update cssjanus/cssjanus to v1.1.2 [vendor] - 10https://gerrit.wikimedia.org/r/260155 (owner: 10Reedy) [06:12:56] (03CR) 10Krinkle: "Despite the packagist package being named cssjanus/cssjanus, the repo is at cssjanus/php-cssjanus. Corrected diff-link as it was pointing " [vendor] - 10https://gerrit.wikimedia.org/r/260155 (owner: 10Reedy) [06:13:47] (03CR) 10Krinkle: [C: 032] Update cssjanus/cssjanus to v1.1.2 [vendor] - 10https://gerrit.wikimedia.org/r/260155 (owner: 10Reedy) [06:14:31] (03PS2) 10Krinkle: jquery.suggestions: Improve comment about avoid click interference [core] - 10https://gerrit.wikimedia.org/r/259784 [06:15:17] (03CR) 10jenkins-bot: [V: 04-1] Update cssjanus/cssjanus to v1.1.2 [vendor] - 10https://gerrit.wikimedia.org/r/260155 (owner: 10Reedy) [06:16:27] (03PS3) 10Krinkle: jquery.suggestions: Improve comment about avoiding click interference [core] - 10https://gerrit.wikimedia.org/r/259784 [06:16:30] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260177 (owner: 10EBernhardson) [06:21:54] (03Merged) 10jenkins-bot: Update cssjanus/cssjanus to v1.1.2 [vendor] - 10https://gerrit.wikimedia.org/r/260155 (owner: 10Reedy) [06:24:10] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/259784 (owner: 10Krinkle) [06:24:19] (03CR) 10jenkins-bot: [V: 04-1] jquery.suggestions: Improve comment about avoiding click interference [core] - 10https://gerrit.wikimedia.org/r/259784 (owner: 10Krinkle) [06:24:35] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/259784 (owner: 10Krinkle) [06:30:15] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint Zapp: Fix GeoIP lookup for IPv6 - https://phabricator.wikimedia.org/T121938#1892474 (10Krinkle) > the US had 1.36M en.m.wikipedia.org page views and 1.17M impressions on v4 networks (86% impression rat... [06:37:23] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/260177 (owner: 10EBernhardson) [06:42:41] (03CR) 1001tonythomas: "@Pranavk : yeah, it should be. Contact your mentors to close down the same as 'Resolved'" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/259655 (https://phabricator.wikimedia.org/T115874) (owner: 10PranavK) [06:42:53] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, and 2 others: Consider removing the extra asterisk for the required parameters inside the template dialog - https://phabricator.wikimedia.org/T107544#1892477 (10Duckworld) I've taken over the GCI task for this and it tur... [06:50:35] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 7Technical-Debt: Clean up DonationInterface validation - https://phabricator.wikimedia.org/T121966#1892485 (10awight) 3NEW [06:51:33] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 7Technical-Debt: Decouple session and token handling from payment gateway class - https://phabricator.wikimedia.org/T121967#1892492 (10awight) 3NEW [06:58:31] 10Wikimedia-Site-Requests: Request to Change title or sitename for localisation and update namespaces on gujarati wikiquote (gu.wikiquote) - https://phabricator.wikimedia.org/T121853#1892498 (10BhatakatiAatma) [07:03:57] (03CR) 10Aaron Schulz: [C: 032] Document mw.user.options and mw.user.tokens properties [core] - 10https://gerrit.wikimedia.org/r/259204 (owner: 10Krinkle) [07:09:32] 10MediaWiki-General-or-Unknown, 10Fundraising-Backlog: Investigate porting GeoIP for HHVM or using GeoIP2-php - https://phabricator.wikimedia.org/T64990#1892502 (10awight) [07:12:48] (03CR) 10jenkins-bot: [V: 04-1] Document mw.user.options and mw.user.tokens properties [core] - 10https://gerrit.wikimedia.org/r/259204 (owner: 10Krinkle) [07:14:15] 10MediaWiki-General-or-Unknown, 10Fundraising-Backlog: Investigate porting GeoIP for HHVM or using GeoIP2-php - https://phabricator.wikimedia.org/T64990#1892503 (10awight) 5declined>3Open Reopening, we need to run geoip as a fallback on donatewiki and paymentswiki when cookies are missing. The HHVM librar... [07:42:41] 10MediaWiki-extensions-Scribunto: Include a RegEx library for Lua - https://phabricator.wikimedia.org/T52454#1892506 (10alex-mashin) > http://www.inf.puc-rio.br/~roberto/lpeg/lpeg.html looks nice, including `lpeg.setmaxstack` to cause crazy regex to fail. Just like PECL it won't work until you hack luasandbox (a... [07:45:16] 10WMF-Call-To-Action: WMF to integrate, consolidate, and pause or stop stalled initiatives - https://phabricator.wikimedia.org/T98358#1892507 (10Nemo_bis) >>! In T98358#1484139, @Nemo_bis wrote: >>>! In T98358#1447195, @Nemo_bis wrote: >> it would be useful to check whether it's true that all this stuff is worke... [07:49:39] 6Increasing content coverage, 6Research-and-Data, 3RD-2016Q2: [Epic] Article recommendation productization/integration - https://phabricator.wikimedia.org/T112321#1892509 (10Nemo_bis) [07:49:41] 10MediaWiki-extensions-ContentTranslation, 6Increasing content coverage, 6Language-Engineering, 6Research-and-Data, and 4 others: Article recommendation experiment: French Wikipedia - https://phabricator.wikimedia.org/T101944#1892510 (10Nemo_bis) [07:49:43] 6Increasing content coverage, 6Research-and-Data, 3RD-2016Q3: [Epic] Article recommendation to more users - https://phabricator.wikimedia.org/T121962#1892508 (10Nemo_bis) [07:49:46] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7Epic, and 2 others: [Epic] ContentTranslation - Lists of articles to translate - https://phabricator.wikimedia.org/T96147#1892511 (10Nemo_bis) [07:51:46] 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1892514 (10Nemo_bis) > Do you think the priority could be review as "unbreak now" ? No, there is a workaround: use CentralNotice. https://meta.wikimedia.org/wiki/CentralNotice/Usag... [07:52:21] Hello tto [07:52:38] 10MediaWiki-extensions-DismissableSiteNotice, 7JavaScript: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1892515 (10Nemo_bis) [07:53:42] Nemo_bis, can you review this old you asked me to do? https://gerrit.wikimedia.org/r/#/c/185551/ [07:55:32] (03CR) 10Ricordisamoa: "It could still be a topic for discussion in Phabricator" [core] - 10https://gerrit.wikimedia.org/r/259786 (owner: 10Krinkle) [07:57:33] 10MediaWiki-extensions-LiquidThreads: Overlapping fields in messages - https://phabricator.wikimedia.org/T121968#1892516 (10Purodha) 3NEW [08:08:23] 10MediaWiki-Interface: Interwiki links broken with Russian interface language - https://phabricator.wikimedia.org/T121836#1892523 (10Base) I observe it too with ?useskin=monobook&uselang=ru . See just links provided by #CX suggestion. Which BTW should not appear actually I think. [08:13:28] Georggi: Hello! [08:13:32] Where were we up to? [08:14:49] Reviewing changes? [08:15:10] https://gerrit.wikimedia.org/r/#/c/259987 [08:22:35] (03CR) 10Aaron Schulz: [C: 032] handle parent_revision_id on page creation [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [08:22:54] Georggi: I'm currently reviewing another GCI student's work, give me a few minutes [08:23:05] (03CR) 10jenkins-bot: [V: 04-1] handle parent_revision_id on page creation [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [08:25:22] (03CR) 10TTO: [C: 04-1] "Just some minor issues of code style. Then I'll merge." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/259442 (https://phabricator.wikimedia.org/T102063) (owner: 10Unicornisaurous) [08:29:25] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-WikimediaMessages, 10Wikimedia-General-or-Unknown, 5Patch-For-Review: Override acct_creation_throttle_hit in WikimediaMessages to tell people to file a task if they're an an event etc - https://phabricator.wikimedia.org/T119209#1892526 (10Nemo_bis)... [08:40:16] 10MediaWiki-extensions-ContributionTracking, 10Fundraising-Backlog, 7Technical-Debt: Remove premium and paypal things from ContributionTracking - https://phabricator.wikimedia.org/T121969#1892533 (10awight) 3NEW [08:41:03] 10MediaWiki-extensions-Scribunto, 7HHVM: Luasandbox is broken under HHVM 3.10 - https://phabricator.wikimedia.org/T115779#1892540 (10alex-mashin) >>! In T115779#1889439, @ori wrote: > I can't reproduce this with the current HEAD of facebook/hhvm (3.12): Thank you, after replacing `cmake .` with `cmake . -DCMA... [08:42:49] 10MediaWiki-extensions-Scribunto, 7HHVM: Luasandbox is broken under HHVM 3.10 - https://phabricator.wikimedia.org/T115779#1892541 (10alex-mashin) 5Open>3Resolved [08:43:05] (03CR) 10TTO: [C: 04-1] "One minor thing. Code works well." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [08:43:08] Georggi: ^ [08:46:05] (03PS5) 10Mhutti1: Converted NavigationTiming to new extension registration [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) [08:46:30] (03CR) 10jenkins-bot: [V: 04-1] Converted NavigationTiming to new extension registration [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [08:46:32] (03PS4) 10Georggi199: Fixed multiple problems in Import.php and ImportDump.php [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) [08:46:34] tto ^ [08:47:46] (03CR) 10Mhutti1: "recheck" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [08:50:27] (03CR) 10Mhutti1: "recheck" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [08:52:04] (03CR) 10Mhutti1: "I only changed your suggestions and now Jenkins is throwing random errors." [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [08:53:39] (03CR) 10TTO: [C: 032] "Ariel and Daniel: Because of the time-sensitive nature of this GCI task, I am going to merge this now. If you have any concerns, Georggi o" [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [08:53:43] Georggi: Done [08:53:57] legoktm: Jenkins doesnt like it but it seems to be failing on something unrelated. [08:54:16] Thanks tto! [08:55:22] (03CR) 10Thiemo Mättig (WMDE): [C: 031] build: Enable and configure jscs, fix some errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/237917 (owner: 10Ricordisamoa) [08:57:34] Georggi: If you'd like to work on "(1) make it so that both revisions of "revision with contributor deleted.xml" are imported correctly" I will create another GCI task for you. [08:57:51] Now that you've completed this task, the follow-up should be much easier for you [08:59:17] Especially that I have already setup vagrant:) [08:59:26] Yeah, lets do that I think [09:00:00] One question, do I actually have to re-clone mediawiki to vagrant? [09:01:01] (03CR) 10jenkins-bot: [V: 04-1] Fixed multiple problems in Import.php and ImportDump.php [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [09:01:34] tto, why it failed?^^ [09:03:04] (03CR) 10TTO: "The extensions failure seem bogus, but the phpcs is a genuine issue." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [09:03:31] Georggi: You can upload an amended patch and I'll +2 it [09:05:44] 10MediaWiki-Interface: Interwiki links broken with Russian interface language - https://phabricator.wikimedia.org/T121836#1892544 (10Schnark) I can reproduce this in Vector (and Firefox, though the browser shouldn't matter as the language links are already missing in the HTML, even before JS execution): {F3123599} [09:06:54] (03PS5) 10Georggi199: Fixed multiple problems in Import.php and ImportDump.php [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) [09:07:00] I see that Jenkins doesnt like tabs?:D [09:07:45] tto, uploaded new patch, can you give me a link to a new task? [09:08:04] andre__, Nemo_bis: could you please publish https://codein.withgoogle.com/dashboard/tasks/5663353187860480/ ? [09:08:18] Georggi: It doesn't like whitespace at the end of a line [09:09:01] (03CR) 10TTO: [C: 032] Fixed multiple problems in Import.php and ImportDump.php [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [09:09:36] 10MediaWiki-Interface: Interwiki links broken with Russian interface language - https://phabricator.wikimedia.org/T121836#1892545 (10Schnark) Disabling all beta preferences does not fix the issue, so we can't blame "Compact language links" or "Content Translation". [09:11:03] 10MediaWiki-Interface: Interwiki links broken with Russian interface language - https://phabricator.wikimedia.org/T121836#1892547 (10Glaisher) I did a null edit and all the interwiki links started to appear in ?uselang=ru now.. [09:11:38] 10MediaWiki-Interface, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Interwiki-links: Interwiki links broken with Russian interface language - https://phabricator.wikimedia.org/T121836#1892548 (10Glaisher) [09:14:44] (03CR) 10jenkins-bot: [V: 04-1] Fixed multiple problems in Import.php and ImportDump.php [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [09:23:23] 10MassMessage, 6Reading-Infrastructure-Team: Same MassMessage is being sent more than once - https://phabricator.wikimedia.org/T93049#1892551 (10Tacsipacsi) It's also a problem on [[//hu.wikisource.org/w/index.php?title=Wikiforr%C3%A1s%3AKocsmafal&diff=85819&oldid=85803|hu.wikisource]]. This wasn't the first d... [09:27:24] (03PS9) 10Glaisher: Clean up and make SpecialGlobalBlock use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/210644 (https://phabricator.wikimedia.org/T60537) [09:27:52] (03CR) 10jenkins-bot: [V: 04-1] Clean up and make SpecialGlobalBlock use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/210644 (https://phabricator.wikimedia.org/T60537) (owner: 10Glaisher) [09:28:07] (03Abandoned) 10Glaisher: Trim reason before inserting to the table [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/260046 (https://phabricator.wikimedia.org/T98891) (owner: 10Glaisher) [09:29:33] (03CR) 10Glaisher: "jenkins failure looks unrelated" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/210644 (https://phabricator.wikimedia.org/T60537) (owner: 10Glaisher) [09:30:55] (03PS10) 10Glaisher: Clean up and make SpecialGlobalBlock use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/210644 (https://phabricator.wikimedia.org/T60537) [09:31:20] (03CR) 10jenkins-bot: [V: 04-1] Clean up and make SpecialGlobalBlock use FormSpecialPage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/210644 (https://phabricator.wikimedia.org/T60537) (owner: 10Glaisher) [09:32:49] 10MediaWiki-extensions-CLDR, 7I18n, 7Testme: CLDR doesn't build pt files correctly - https://phabricator.wikimedia.org/T36760#1892554 (10Liuxinyu970226) [09:36:40] 10MediaWiki-extensions-CLDR: Make the name of the country available as parserfunction - https://phabricator.wikimedia.org/T55786#1892558 (10Liuxinyu970226) [09:36:54] 10MediaWiki-extensions-CLDR: Add support for ordinal numbers - https://phabricator.wikimedia.org/T59903#1892560 (10Liuxinyu970226) [09:37:00] 10MediaWiki-extensions-CLDR, 7Upstream: MWTimestamp::getHumanTimestamp() (aka timestamps in echo) not translated into Chechen - https://phabricator.wikimedia.org/T64607#1892562 (10Liuxinyu970226) [09:38:06] 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR: Implement new #country preprocessor function, similar to #language - https://phabricator.wikimedia.org/T105993#1892563 (10Liuxinyu970226) [09:38:59] tto: done [09:39:53] Nemo_bis: Could you also publish https://codein.withgoogle.com/dashboard/tasks/5236386596651008/ [09:44:24] Georggi: https://codein.withgoogle.com/dashboard/tasks/5663353187860480/ [09:44:29] Nemo_bis: Thanks! [09:44:39] tto I claimed it already:) [09:47:31] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 10Wikimedia-Site-Requests: Correction of namespace names in Sanskrit - https://phabricator.wikimedia.org/T101634#1892567 (10TTO) [09:47:33] 10MediaWiki-extensions-Scribunto, 7I18n: Rename namespace module to Malayalam in Malayalam language wikis - https://phabricator.wikimedia.org/T56951#1892568 (10TTO) [09:47:35] 10MediaWiki-Internationalization, 7I18n, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Allow namespace aliases to be defined in extension i18n - https://phabricator.wikimedia.org/T108427#1892564 (10TTO) 5Open>3Resolved a:3TTO Should work now. [09:50:24] (03PS6) 10TTO: Handle missing titles and usernames when importing log items [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [09:50:40] Georggi: No idea what is wrong with that patch. I'm blaming Jenkins [09:51:14] Thx for changing commit message:) I am quite bad in describing that:) [09:52:32] (03PS3) 10Hashar: Update packages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [09:52:58] Georggi: sorry, no time to review code today; I'm rushing to review tasks before I go afk for an extended period [09:53:10] If Siebrand is among reviewers, surely your patch will be eventually merged [09:53:15] Nemo_bis np [09:53:40] (03CR) 10jenkins-bot: [V: 04-1] Update packages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [09:55:32] (03CR) 10Nemo bis: "Looks good, can be made even more informative" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/259618 (owner: 10AndyTechGuy) [09:56:33] (03CR) 10jenkins-bot: [V: 04-1] Handle missing titles and usernames when importing log items [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [09:57:43] (03CR) 10Hashar: [C: 032] Update cssjanus/cssjanus to v1.1.2 [core] - 10https://gerrit.wikimedia.org/r/260169 (owner: 10Reedy) [09:58:37] (03CR) 10Nemo bis: "Nice, we really needed some work on this file!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/259954 (owner: 10AndyTechGuy) [09:58:39] (03CR) 10Hashar: "The change in vendor got merged before and that broke bunch of jobs." [core] - 10https://gerrit.wikimedia.org/r/260169 (owner: 10Reedy) [10:04:20] (03Merged) 10jenkins-bot: Update cssjanus/cssjanus to v1.1.2 [core] - 10https://gerrit.wikimedia.org/r/260169 (owner: 10Reedy) [10:04:38] ^^^^ should fix mw jobs that have been falling for a few hours [10:05:59] (03CR) 10Hashar: [C: 04-2] handle parent_revision_id on page creation [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [10:06:36] (03CR) 10Hashar: "recheck" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [10:06:45] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [10:10:30] (03CR) 10Hashar: [C: 032] "Unrelated Jenkins failure" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 (owner: 10Catrope) [10:11:16] (03CR) 10Hashar: [C: 032] "Unrelated Jenkins failure." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [10:12:22] (03CR) 10Paladox: "Thanks the problem is now fixed." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [10:14:29] (03Merged) 10jenkins-bot: Remove link from mention notification header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 (owner: 10Catrope) [10:15:15] 10MediaWiki-extensions-SemanticForms: Use templates, to avoid inserting a hidden div that is cloned with JS - https://phabricator.wikimedia.org/T121970#1892571 (10TheDJ) 3NEW a:3Yaron_Koren [10:16:24] (03Merged) 10jenkins-bot: Add mw-echo-payload class to body in Special:Notifications as well [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [10:19:18] (03CR) 10TTO: Handle missing titles and usernames when importing log items [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [10:19:26] (03CR) 10TTO: [C: 032] Handle missing titles and usernames when importing log items [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [10:24:42] (03PS12) 10Christopher Johnson (WMDE): adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 [10:26:55] (03Merged) 10jenkins-bot: Handle missing titles and usernames when importing log items [core] - 10https://gerrit.wikimedia.org/r/259987 (https://phabricator.wikimedia.org/T121338) (owner: 10Georggi199) [10:30:58] (03PS13) 10Christopher Johnson (WMDE): adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 [10:44:29] (03CR) 10Christopher Johnson (WMDE): adds dataTables (035 comments) [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [10:52:09] (03CR) 10Christopher Johnson (WMDE): "Comments on PS 13:" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [10:55:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Editing a label gives an error saying another item has the same description when it doesn't - https://phabricator.wikimedia.org/T121851#1892587 (10matej_suchanek) [11:08:01] (03PS1) 10Tchanders: Force Ace Editor to resize after the dialog has appended [extensions/Math] - 10https://gerrit.wikimedia.org/r/260180 (https://phabricator.wikimedia.org/T121164) [11:08:19] (03CR) 10saper: "Obviously it does not fix https://phabricator.wikimedia.org/T120216 yet." [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/260173 (owner: 10saper) [11:10:36] 10MediaWiki-extensions-Translate, 10Wikimedia-Site-Requests: Install Translate Extension in the WMRU wiki - https://phabricator.wikimedia.org/T121766#1892601 (10Kaganer) a:5Amire80>3None [11:11:44] 10MediaWiki-extensions-WikiLexicalData-or-OmegaWiki: Notice: Undefined offset: X in /var/www/ow/extensions/WikiLexicalData/OmegaWiki/OmegaWikiRecordSets.php on line 232 - https://phabricator.wikimedia.org/T121972#1892603 (10Purodha) 3NEW [11:11:50] 10MediaWiki-extensions-HitCounters: In 1.25, hitcounter does not save counts in hit_counter and hit_counter_extensions tables - https://phabricator.wikimedia.org/T121749#1892611 (10saper) @Sebastianlutter I have prepared a patch that most probably fixes the data migration problem, if you didn't upgrade to 1.26 y... [11:14:03] 10MediaWiki-extensions-HitCounters: hitcounter should not do destructive db updates - https://phabricator.wikimedia.org/T116891#1892614 (10saper) @Bawolff can you have a look at https://gerrit.wikimedia.org/r/#/c/260173/ ? It is not fully ready yet (it does not fix T120216 yet), but it should migrate existing... [11:16:12] 10MediaWiki-extensions-HitCounters: hitcounter should not do destructive db updates - https://phabricator.wikimedia.org/T116891#1892618 (10saper) a:3saper [11:25:27] 10MediaWiki-Internationalization, 10Deployment-Systems, 6Performance-Team, 7Performance: Experiment with plain .php files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740#1892621 (10Reedy) >>! In T99740#1892455, @EBernhardson wrote: > Since this is resolved, what was the result of t... [11:29:00] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/260170 (owner: 10Reedy) [11:36:01] (03CR) 10Reedy: "recheck" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260161 (owner: 10Reedy) [11:36:24] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/260159 (owner: 10Reedy) [11:36:38] (03CR) 10Reedy: "recheck" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/260160 (owner: 10Reedy) [11:43:25] Georggi: Hey! Feel free to mark the GCI task for https://gerrit.wikimedia.org/r/#/c/259987/ as "ready for review" as your patch has been merged so a GCI mentor can approve it. Thanks! :) [11:44:22] andre__ it was already approved:) [11:46:06] Georggi: oh really? Then... hmm. The GCI site shows it as open to me. That's.... weird. [11:46:30] (or rather "in progress" and claimed by you, but not reviewed) [11:46:45] I think its another task you are talking about [11:46:51] that change was about this task https://codein.withgoogle.com/dashboard/task-instances/5742754080489472/?sp-page=1 [11:46:52] Fix Undefined index: id & timestamp in MediaWiki's Import.php || 5 days || Code || Wikimedia || All instances done [11:47:17] I am working on this one https://codein.withgoogle.com/dashboard/task-instances/6504798484430848/ [11:47:18] Make the import process play nicely with hidden usernames || 3 days || Code || Wikimedia || Currently claimed [11:49:11] (03CR) 10Bartosz Dziewoński: [C: 032] Update packages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [11:50:15] Georggi: Ah. I think I see now what confused me: Your first (already approved/closed) task links to https://phabricator.wikimedia.org/T34876 in its GCI task description and to https://gerrit.wikimedia.org/r/#/c/259987/ in your comment, and in Gerrit the commit message links to https://phabricator.wikimedia.org/T121338 instead (different Phab task) [11:50:34] Georggi: Alright then. Sorry, just wanted to speed up the process a bit :) [11:50:59] * andre__ should get a coffee before trying to think on a Saturday morning [11:53:46] (03Merged) 10jenkins-bot: Update packages [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [11:56:14] (03CR) 10Aklapper: "@Mhutti1: There are currently some Jenkins problems. See https://phabricator.wikimedia.org/T120824 for more technical info if you're inter" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [11:56:37] (03CR) 10Bartosz Dziewoński: [C: 032] jquery.suggestions: Improve comment about avoiding click interference [core] - 10https://gerrit.wikimedia.org/r/259784 (owner: 10Krinkle) [11:59:41] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: Mark GWToolset uploads with a change tag - https://phabricator.wikimedia.org/T121877#1890710 (10Steinsplitter) GWT has a own logentry. https://commons.wikimedia.org/w/index.php?title=Special%3ALog&type=gwtoolset&user=&page=&year=&month=-1&tagfilter=&hi... [12:01:58] (03CR) 10Esanders: [C: 032] Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260172 (https://phabricator.wikimedia.org/T121596) (owner: 10Florianschmidtwelzow) [12:03:32] (03Merged) 10jenkins-bot: jquery.suggestions: Improve comment about avoiding click interference [core] - 10https://gerrit.wikimedia.org/r/259784 (owner: 10Krinkle) [12:03:35] (03Merged) 10jenkins-bot: Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/260172 (https://phabricator.wikimedia.org/T121596) (owner: 10Florianschmidtwelzow) [12:03:51] 10MediaWiki-extensions-GWToolset, 6Commons, 6Multimedia: Mark GWToolset uploads with a change tag - https://phabricator.wikimedia.org/T121877#1892642 (10matmarex) Right, but the uploads still appear on https://commons.wikimedia.org/wiki/Special:Log/upload or https://commons.wikimedia.org/wiki/Special:NewFi... [12:11:25] tto, are you still there? [12:11:50] [14:10] == wikibugs [tools.wiki@wikimedia/bot/pywikibugs] has quit [Excess Flood] Wait what?:D [12:12:12] Georggi: Yes, still here for a little while longer [12:12:22] wikibugs sometimes randomly goes down [12:13:00] Possibly someone was performing a batch operation on Phabricator , so wikibugs got kicked off for spamming some other channel [12:13:05] After trying to import that file it has just said "Done!" [12:13:23] Oh no, some idiot's created a spam task: https://phabricator.wikimedia.org/T121975 [12:13:31] let me handle that. [12:14:08] derp [12:14:13] User disabled. Thanks revi and tto! [12:14:17] :D [12:14:25] Georggi: It should show 2 revisions on the imported page. I'm guessing you only get 1? [12:15:09] How does Import page url looks like? [12:16:00] Hm? Not sure what you mean. [12:16:32] What do you mean by imported page? [12:18:26] That dump imports to "User:Grenavitar/Film" IIRC? [12:18:33] You should go to that page and look at the revision history. [12:18:54] There should be 2 entries. One with Grenavitar's username, and one with your username [12:19:11] The expected result is there are 3 entries. One with Grenavitar's username, one with "Unknown user", and one with your username [12:20:22] why does wikibugs have no sane restart instructions [12:20:56] There are like tons of films there:D I guess that big Dump on previous task made that [12:22:18] But there is no my username, nor Grenavitar nor Unknown user [12:25:15] Maybe delete "User:Grenavitar/Film" and start over [12:25:32] The page content itself is long, but we're only interested in the revision history tab [12:25:42] Georggi: ^ [12:27:55] What in the world was https://phabricator.wikimedia.org/T121973? [12:29:28] Krenair: revi: ^ [12:29:43] just a spammer [12:30:04] and mine was phabricator silently overwriting edit conflict [12:30:42] (03CR) 10Paladox: "Thanks." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/259486 (owner: 10Paladox) [12:32:24] revi: How do you remove so many projects, though? :P [12:32:41] easy [12:32:53] backspace key [12:32:55] (03PS1) 10PranavK: Make Special:MediaStatistics show a total count of file sizes [core] - 10https://gerrit.wikimedia.org/r/260182 (https://phabricator.wikimedia.org/T117606) [12:33:00] keep it pushed [12:33:03] and it gets magically removed [12:33:05] revi: fair point. [12:33:16] (03CR) 10jenkins-bot: [V: 04-1] Make Special:MediaStatistics show a total count of file sizes [core] - 10https://gerrit.wikimedia.org/r/260182 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [12:33:17] haha [12:33:39] revi: how'd he add so many projects though? :P Conduit? [12:33:47] probably. I also wonder. [12:34:23] Via Web [12:34:27] from phabricator [12:34:42] if you created bug via conduit it says via Conduit, obviously [12:35:58] https://issue.librewiki.net/T126 [12:36:12] tried it, if I made it through conduit it says it's from conduit [12:36:17] True. Hmm. [12:36:52] (03PS2) 10PranavK: Make Special:MediaStatistics show a total count of file size [core] - 10https://gerrit.wikimedia.org/r/260182 (https://phabricator.wikimedia.org/T117606) [12:37:11] (03CR) 10jenkins-bot: [V: 04-1] Make Special:MediaStatistics show a total count of file size [core] - 10https://gerrit.wikimedia.org/r/260182 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [12:37:21] so he put all the possible projects on the projects tab just in few seconds.... Not sure if it's possible [12:37:22] So... he copied all the tasks from a conduit query and pasted them into the projects field? I'm just curious. Such a mystery. [12:37:36] Best not to think about it too much, DNFTT and all that [12:37:42] heh [12:38:02] now I will go back to find a way to sue a wiki troll :-p [12:38:16] who insulted me with my real name [12:39:16] 10MediaWiki-extensions-SemanticFormsInputs: intermittent datepicker issues in MW 1.26, like "jQuery is not defined" - https://phabricator.wikimedia.org/T121964#1892702 (10Aklapper) [12:43:10] (03PS1) 10PranavK: Make Special:MediaStatistics show a total count of file sizes [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) [12:43:30] (03CR) 10jenkins-bot: [V: 04-1] Make Special:MediaStatistics show a total count of file sizes [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [12:44:13] (03CR) 10PranavK: "Why is this happening?" [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [12:46:13] (03PS1) 10Esanders: Fix spelling mistakes in comments [core] - 10https://gerrit.wikimedia.org/r/260184 [12:47:16] 10MediaWiki-Interface, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Interwiki-links: Interwiki links not shown for specific en.wp article with Russian interface language - https://phabricator.wikimedia.org/T121836#1892707 (10Aklapper) [12:47:31] 10MediaWiki-Interface, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Interwiki-links: Interwiki links not shown for specific en.wp article with Russian interface language - https://phabricator.wikimedia.org/T121836#1892710 (10Aklapper) p:5Normal>3Triage [12:48:14] 10MediaWiki-extension-requests, 6Commons, 6Discovery, 10Maps: Generate location maps dynamically, producing actual images - https://phabricator.wikimedia.org/T120809#1892712 (10Alexrk2) Beside the technical issues, discussed here, I like to note, that there are lot of reasons, why we use hand made maps tod... [12:50:11] (03CR) 10Polybuildr: "I don't know anything about this specific case, but generally:" [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [12:51:59] (03PS2) 10PranavK: Make Special:MediaStatistics show a total count of file sizes [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) [12:54:42] tto, looking inside that dump, there is 2 lines with one after the notes with username, and one inside the title but with no contributor [12:54:53] Dont know how should it show my username [12:54:56] 7Design, 6Collaboration-Team-Backlog, 10Echo, 7Easy: Notification icons are not ready for high-density displays (use SVG instead of PNG where supported) - https://phabricator.wikimedia.org/T55875#1892713 (10Esanders) [12:55:06] and Grenavitar too [12:55:07] 10MediaWiki-extensions-LiquidThreads: lqt-thread-toolbar (with long translated command names) overlaps with lqt-thread-signature - https://phabricator.wikimedia.org/T121968#1892714 (10Aklapper) [12:56:29] 10UI-Standardization, 10OOjs-UI, 10VisualEditor: Duplicate icons: 'Translation' and 'TextLanguage' - https://phabricator.wikimedia.org/T111040#1892718 (10Esanders) [12:58:27] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892719 (10Esanders) 3NEW [12:59:33] 10MediaWiki-Redirects, 6Security, 6Security-Team, 5MW-1.23-release, and 7 others: A combination of Special:MyPage redirects and pagecounts allows an external site to know the wikipedia login of an user - https://phabricator.wikimedia.org/T109724#1892727 (10xcombelle) >>! In T109724#1889831, @Nemo_bis wrote... [13:00:06] 10UI-Standardization, 10OOjs-UI, 10VisualEditor: Duplicate icons: 'Translation' and 'TextLanguage' - https://phabricator.wikimedia.org/T111040#1892735 (10Esanders) [13:00:07] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892734 (10Esanders) [13:00:27] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892719 (10Esanders) [13:10:05] 10MediaWiki-Redirects, 6Security, 6Security-Team, 5MW-1.23-release, and 7 others: A combination of Special:MyPage redirects and pagecounts allows an external site to know the wikipedia login of an user - https://phabricator.wikimedia.org/T109724#1892740 (10xcombelle) >>! In T109724#1889830, @Nemo_bis wrote... [13:17:19] (03PS6) 10Paladox: Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [13:18:14] 10MediaWiki-extension-requests, 6Commons, 6Discovery, 10Maps: Generate location maps dynamically, producing actual images - https://phabricator.wikimedia.org/T120809#1892742 (10Alexrk2) PS: we have to differentiate between location maps and locator maps. * Location maps are blank maps used for Template:Lo... [13:22:25] (03CR) 10Hashar: [C: 032] "I meant CR+2 per Aaron. The Jenkins failure is unrelated." [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [13:22:54] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/259204 (owner: 10Krinkle) [13:23:02] (03Merged) 10jenkins-bot: handle parent_revision_id on page creation [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [13:23:36] (03CR) 10Hashar: "recheck" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/210644 (https://phabricator.wikimedia.org/T60537) (owner: 10Glaisher) [13:23:36] (03PS7) 10Paladox: Add format-bold-Iab image for lang ru, Add format-bold-ru image to lang uk [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [13:23:54] (03CR) 10Aklapper: "Yurik: Could you reply to Umherirrender's last comment please? This five-liner patch has been sitting here for 15 months, what's the plan?" [core] - 10https://gerrit.wikimedia.org/r/161878 (owner: 10Yurik) [13:24:21] (03CR) 10Hashar: "recheck" [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/259877 (https://phabricator.wikimedia.org/T87944) (owner: 10Mhutti1) [13:25:12] (03CR) 10Paladox: "Merged in https://gerrit.wikimedia.org/r/#/c/258674/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [13:25:30] (03Abandoned) 10Paladox: Use the same icon as the russian for the ukraine [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258674 (https://phabricator.wikimedia.org/T25914) (owner: 10Paladox) [13:25:49] (03CR) 10Physikerwelt: [C: 031] "works for me." [extensions/Math] - 10https://gerrit.wikimedia.org/r/260180 (https://phabricator.wikimedia.org/T121164) (owner: 10Tchanders) [13:26:07] (03PS8) 10Paladox: Add format-bold-Iab image for lang ru, Add format-bold-ru image to lang uk [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [13:27:30] (03CR) 10Physikerwelt: "... and if the ve change got merged..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/260180 (https://phabricator.wikimedia.org/T121164) (owner: 10Tchanders) [13:29:25] (03CR) 10Aklapper: [C: 04-1] "Patch needs manual rebase now hence setting -1." [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/33688 (owner: 10KarenEddy) [13:31:16] (03CR) 10Aklapper: "@mmullie: This eight-liner patch has been sitting here for more than a year without review or merge and is among the oldest unreviewed one" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/135762 (https://bugzilla.wikimedia.org/65807) (owner: 10Matthias Mullie) [14:03:19] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Some comments :) Thanks for your work!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [14:05:09] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1892751 (10josephine_l) [14:11:36] (03CR) 10Bartosz Dziewoński: [C: 032] Fix spelling mistakes in comments [core] - 10https://gerrit.wikimedia.org/r/260184 (owner: 10Esanders) [14:12:09] (03CR) 10Reedy: Make Special:MediaStatistics show a total count of file sizes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [14:13:55] (03Abandoned) 10Reedy: Make Special:MediaStatistics show a total count of file size [core] - 10https://gerrit.wikimedia.org/r/260182 (https://phabricator.wikimedia.org/T117606) (owner: 10PranavK) [14:16:21] yay spellchecking, gci period? :) [14:18:51] (03PS3) 10Reedy: API: Add a unit test to check all modules' i18n [core] - 10https://gerrit.wikimedia.org/r/260031 (owner: 10Anomie) [14:19:14] (03CR) 10Reedy: [C: 032] "LGTM. Probably will need enhancement in the future, but good for now" [core] - 10https://gerrit.wikimedia.org/r/260031 (owner: 10Anomie) [14:19:48] (03Merged) 10jenkins-bot: Fix spelling mistakes in comments [core] - 10https://gerrit.wikimedia.org/r/260184 (owner: 10Esanders) [14:25:35] (03CR) 10Reedy: [C: 04-1] Add support for renaming tables in mediawiki and extensions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247085 (owner: 10Paladox) [14:25:47] (03Merged) 10jenkins-bot: API: Add a unit test to check all modules' i18n [core] - 10https://gerrit.wikimedia.org/r/260031 (owner: 10Anomie) [14:28:50] (03Abandoned) 10Reedy: Make DatabaseBz2 an abstract class [extensions/Offline] - 10https://gerrit.wikimedia.org/r/244959 (https://phabricator.wikimedia.org/T112398) (owner: 10Paladox) [14:35:26] (03CR) 10Reedy: [C: 04-2] Import changes from https://github.com/OSAS/strapping-mediawiki [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/237897 (owner: 10Paladox) [14:37:31] (03PS9) 10Reedy: Move functions and class to separate files [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/214815 (owner: 10Paladox) [14:40:07] (03CR) 10Reedy: [C: 04-1] "Why has LdapAuthenticationPlugin.hooks.php got a hooks suffix?" (031 comment) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/214815 (owner: 10Paladox) [14:45:33] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: DBPageLanguage isn't returned by Title::getPageLanguage - https://phabricator.wikimedia.org/T121666#1892760 (10Florian) Hmm, after some investigation, it seems, that the Title object returned by `Title::newFromtext()` (probably) under some condi... [14:51:14] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: DBPageLanguage isn't returned by Title::getPageLanguage - https://phabricator.wikimedia.org/T121666#1892761 (10Florian) [14:53:11] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: DBPageLanguage isn't returned by Title::getPageLanguage - https://phabricator.wikimedia.org/T121666#1885103 (10Florian) [15:04:25] 10MediaWiki-extensions-AbuseFilter: Abusefilter moved_to_namespace variable has unexpected values - https://phabricator.wikimedia.org/T121963#1892766 (10Xaosflux) [15:04:51] 10MediaWiki-extensions-AbuseFilter: Abusefilter moved_to_namespace variable has unexpected values - https://phabricator.wikimedia.org/T121963#1892447 (10Xaosflux) Additional test cases added, verified behavior is also present on test.wikipedia.org [15:04:53] (03PS1) 10Amire80: Replace "Wikimedians" in a message with "editors" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260199 [15:05:49] (03CR) 10Alex Monk: [C: 032] Replace "Wikimedians" in a message with "editors" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260199 (owner: 10Amire80) [15:06:52] 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7I18n, 7RTL: VisualEditor citation hint box image should not flip the digits for RTL - https://phabricator.wikimedia.org/T117949#1892770 (10Krenair) 5Open>3Resolved [15:09:55] (03Merged) 10jenkins-bot: Replace "Wikimedians" in a message with "editors" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/260199 (owner: 10Amire80) [15:18:34] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892775 (10Liuxinyu970226) +1, it may also derived from "大丈夫" (no problem) [15:18:49] (03CR) 10Aklapper: [C: 04-1] Import changes from https://github.com/OSAS/strapping-mediawiki [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/237897 (owner: 10Paladox) [15:19:10] 10MediaWiki-extension-requests, 6Commons, 6Discovery, 10Maps: Generate location maps dynamically, producing actual images - https://phabricator.wikimedia.org/T120809#1892776 (10Yurik) @Alexrk2, thanks for the great in-depth reply! * Geodata - do you think we should introduce support for the user-contributa... [15:22:40] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Microsoft Translator not working with new authorisation model - https://phabricator.wikimedia.org/T46679#1892777 (10Reedy) [15:22:59] (03PS9) 10Amire80: Convert to extension.json and deprecate PHP entry point [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/212927 (https://phabricator.wikimedia.org/T88000) (owner: 10Jforrester) [15:23:18] (03PS3) 10PranavK: Make Special:MediaStatistics show a total count of file sizes [core] - 10https://gerrit.wikimedia.org/r/260183 (https://phabricator.wikimedia.org/T117606) [15:25:05] 10MediaWiki-extensions-Translate, 5Patch-For-Review: Microsoft Translator not working with new authorisation model - https://phabricator.wikimedia.org/T46679#1892784 (10Reedy) >>! In T46679#1699696, @C0nnex wrote: > Since I need this for my wiki, I started updating the code to current master I've fixed the mi... [15:25:07] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate: DBPageLanguage isn't returned by Title::getPageLanguage - https://phabricator.wikimedia.org/T121666#1892785 (10Florian) [15:25:21] 10MediaWiki-General-or-Unknown, 7Tracking: Extensions that should really be core functionality (tracking) - https://phabricator.wikimedia.org/T28751#1892787 (10MGChecker) Would it be useful to add ParserFunctions to this list? [15:25:55] (03CR) 10Amire80: [C: 031] "It would be super-nice to get this merged." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/212927 (https://phabricator.wikimedia.org/T88000) (owner: 10Jforrester) [15:29:23] (03PS1) 10Florianschmidtwelzow: Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) [15:33:59] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1892797 (10Aklapper) [15:34:01] 10Score, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Convert Score to use extension registration - https://phabricator.wikimedia.org/T87970#1892795 (10Aklapper) 5Open>3Resolved a:3ananayarora [15:35:20] (03CR) 10jenkins-bot: [V: 04-1] Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) (owner: 10Florianschmidtwelzow) [15:37:13] Is anyone familiar with Multimediaviewer extension? I need some help in guiding what I need to be doing. https://phabricator.wikimedia.org/T85685. [15:38:09] I don't think it's MultimediaViewer specific [15:38:31] Looks like a fairly detailed explanation was already given on the task [15:40:32] MtDu_, #wikimedia-multimedia might also be a good channel (though I don't know how many people are around on a weekend) [15:42:55] andre__: Ok thanks. [15:47:46] (03PS2) 10Florianschmidtwelzow: Fix not-loaded DbPageLanguage when Title::getPageLanguage() get's called [core] - 10https://gerrit.wikimedia.org/r/260203 (https://phabricator.wikimedia.org/T121666) [15:48:49] 10Wikimedia-Site-Requests, 7Community-consensus-needed, 5Patch-For-Review: Set 'WP' namespace alias to NS_PROJECT in my.wikipedia - https://phabricator.wikimedia.org/T119807#1892803 (10Dr.Leonhart) Not only "WP", the other shortcuts "CAT", and the "Portal" are creating as article pages. ``` 'CAT' = ကဏ္ဍ or... [16:04:55] (03PS2) 10AndyTechGuy: Change multiple documentations in DairkiDiff [core] - 10https://gerrit.wikimedia.org/r/259954 [16:05:28] 3Mobile-Content-Service: Expected audio file URLs not found - https://phabricator.wikimedia.org/T121670#1892812 (10bearND) 5Open>3Invalid I tend to agree. Thank you for investigating! [16:13:16] (03PS9) 10Unicornisaurous: Prevent blocked users from changing tags [core] - 10https://gerrit.wikimedia.org/r/259442 (https://phabricator.wikimedia.org/T102063) [16:14:54] 4(no projects): U+00AD SOFT HYPHEN shouldn't be allowed in wiki article titles - https://phabricator.wikimedia.org/T121979#1892814 (10Yurivict) 3NEW [16:23:56] 10MediaWiki-extensions-Collection, 10OCG-PDF-renderer: Cannot download `Philosophy of mind` as a PDF - https://phabricator.wikimedia.org/T121980#1892820 (10Reedy) 3NEW [16:24:36] 10MediaWiki-extensions-Collection, 10OCG-PDF-renderer: Cannot download `Philosophy of mind` as a PDF - https://phabricator.wikimedia.org/T121980#1892827 (10Reedy) [16:36:08] (03PS6) 10Paladox: Import changes from https://github.com/OSAS/strapping-mediawiki [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/237897 [16:36:45] (03CR) 10Paladox: "Ok ive changed the author too Garrett Lesage in commit msg." [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/237897 (owner: 10Paladox) [16:45:08] (03CR) 10Jonas Kress (WMDE): "We could make the bottom navbar half transparent." [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [16:54:01] 10MediaWiki-skins-BlueSky: BlueSky TOC error - https://phabricator.wikimedia.org/T121981#1892836 (10Jonasborch1) 3NEW [16:58:07] (03CR) 10Jonas Kress (WMDE): "And maybe add some scrollTo JS" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [16:58:46] sorry, I have forgotten [16:59:04] but if I am removing an i18n message, does it need to be removed from all of the jsons? [16:59:59] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1892843 (10Ryan7273) There are open_basedir restrictions in place, but the root of the wikimedia install is included... [17:05:32] Hello, [17:05:50] Hello? [17:05:52] Any devs that can help us with an error we have with the skin BlueSky on hacked.com/wiki [17:06:35] I'm not familiar with that skin but if you pastebin the error someone should know [17:06:41] but #mediawiki may be more appropriate [17:07:30] 11:59 but if I am removing an i18n message, does it need to be removed from all of the jsons? |---| Nevermind, I answered my own question 11:59 but if I am removing an i18n message, does it need to be removed from all of the jsons? [17:07:38] oops, pasted that twice [17:08:49] You don't have to remove it from all. Usual practice is to remove from en and qqq [17:11:10] Ok, thanks [17:16:48] (03PS1) 10Reedy: Swap isset() to is_array() [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/260205 [17:17:27] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892845 (10Pginer-WMF) When looking for a representation of "language" I initially proposed the... [17:18:15] andre__: Could you point me to that channel again? [17:18:23] (03CR) 10Reedy: "[17-Dec-2015 13:01:41 UTC] PHP Warning: Invalid argument supplied for foreach() in /public_html/wiki/skins/BlueSky/BlueSky.skin.php on li" [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/260205 (owner: 10Reedy) [17:25:25] MtDu_, #wikimedia-multimedia [17:26:21] andre__: Found it. Thanks! [17:27:39] jonasborchgrevin: what is "the error"? Page looks fine to me. [17:27:50] I think I fixed it [17:28:03] http://pastebin.com/A9xLHT36 [17:28:10] (Reedy) [17:28:35] Reedy: if ( isset( $wgBlueSkyTOC ) && count( $wgBlueSkyTOC ) > 0 ) { [17:28:36] [6:17pm] Reedy: for [17:28:36] [6:17pm] Reedy: if ( is_array( $wgBlueSkyTOC ) && count( $wgBlueSkyTOC ) > 0 ) { [17:33:09] 10MobileFrontend, 7Technical-Debt: Audit MobileFrontend-related extensions for proper cache invalidation of page contents - https://phabricator.wikimedia.org/T121466#1892861 (10BBlack) [17:37:15] (03PS2) 10Physikerwelt: VE MWMathDialog: Fix documentation [extensions/Math] - 10https://gerrit.wikimedia.org/r/259403 (owner: 10Esanders) [17:37:23] (03CR) 10Physikerwelt: [C: 032] VE MWMathDialog: Fix documentation [extensions/Math] - 10https://gerrit.wikimedia.org/r/259403 (owner: 10Esanders) [17:39:35] (03Merged) 10jenkins-bot: VE MWMathDialog: Fix documentation [extensions/Math] - 10https://gerrit.wikimedia.org/r/259403 (owner: 10Esanders) [17:40:15] 10MediaWiki-extensions-SemanticForms: Feature request: "remote autocompletion" on "mapping template" or a different approach? - https://phabricator.wikimedia.org/T86959#1892872 (10planetenxin) (1) would support an easier filling of forms in one go (2) would support probably a more feature rich search but interru... [17:43:07] (03CR) 10Physikerwelt: "Jforrester: Do you know anyone who might have the competence to review this change?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/167019 (owner: 10Frédéric Wang) [17:45:39] (03Abandoned) 10Physikerwelt: Update onLoadExtensionSchemaUpdates function [extensions/Math] - 10https://gerrit.wikimedia.org/r/248076 (https://phabricator.wikimedia.org/T111681) (owner: 10Paladox) [17:56:21] 6Phabricator: Broken link in email notification - https://phabricator.wikimedia.org/T121983#1892879 (10Glaisher) 3NEW [17:59:46] (03CR) 10Umherirrender: [C: 032] "Resubmit to give jenkins a second try" [core] - 10https://gerrit.wikimedia.org/r/259204 (owner: 10Krinkle) [18:05:49] (03CR) 10Umherirrender: "This conflicts with already merged I8117ad6942894e5baf976690772ff0e4a28b4653" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/257346 (owner: 10Addshore) [18:07:26] (03Merged) 10jenkins-bot: Document mw.user.options and mw.user.tokens properties [core] - 10https://gerrit.wikimedia.org/r/259204 (owner: 10Krinkle) [18:14:07] (03CR) 10Aklapper: "Name still misspelled in commit message. Commit message does not describe what this import actually tries to achieve/fix/improve: The inte" [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/237897 (owner: 10Paladox) [18:17:28] 10Phabricator-Upstream: Incorrect link in HTML email notification for URLs without protocol (starting with "//") - https://phabricator.wikimedia.org/T121983#1892889 (10Aklapper) p:5Triage>3Lowest [18:18:27] 10Phabricator-Upstream: Incorrect link in HTML email notification for URLs without protocol (starting with "//") - https://phabricator.wikimedia.org/T121983#1892879 (10Aklapper) No link for me in plain text email notifications... A HTML email source (without private info) would be welcome plus info about the ema... [18:21:17] 10MediaWiki-General-or-Unknown: U+00AD SOFT HYPHEN shouldn't be allowed in wiki article titles - https://phabricator.wikimedia.org/T121979#1892902 (10Aklapper) p:5Triage>3Low [18:21:57] 10MediaWiki-General-or-Unknown: U+00AD SOFT HYPHEN shouldn't be allowed in wiki article titles - https://phabricator.wikimedia.org/T121979#1892814 (10Aklapper) I thought this was fixed in T5696... (For future reference, [[ https://mediawiki.org/wiki/How_to_report_a_bug | please associate a project to tasks ]]. T... [18:22:25] 10Wikimedia-Site-Requests: Add Category namespace (NS:14) to $wgNamespacesWithSubpages on Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T121985#1892908 (10Meno25) 3NEW [18:22:43] (03CR) 10Umherirrender: "The files are named like the canonical form of the special pages (from MessagesEn.php):" [core] - 10https://gerrit.wikimedia.org/r/259861 (owner: 10Bartosz Dziewoński) [18:29:57] (03CR) 10Umherirrender: Removed Article::loadContent() (deprecated since 1.19) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/259414 (owner: 10Reedy) [18:31:56] (03CR) 10Ladsgroup: "Actually It's not a problem of this patch. We need to wait until some patches in the extension gets merged. Which it seems to take more th" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/259211 (https://phabricator.wikimedia.org/T118584) (owner: 10Awight) [18:36:41] 10MediaWiki-extension-requests, 6Commons, 6Discovery, 10Maps: Generate location maps dynamically, producing actual images - https://phabricator.wikimedia.org/T120809#1892920 (10Alexrk2) Yurik, as you said, I think user-contributed geodata is an essential key to this problems. Because at Wikipedia we all wa... [18:47:47] 10MediaWiki-General-or-Unknown, 7Regression: Restore fragment in broken links - https://phabricator.wikimedia.org/T121986#1892923 (10PeterBowman) 3NEW [18:49:05] 6Discovery, 3Discovery-Cirrus-Sprint, 7I18n, 5Patch-For-Review, and 2 others: Completion suggester beta feature is missing an RTL logo - https://phabricator.wikimedia.org/T121832#1892932 (10Amire80) [18:53:10] 10MediaWiki-General-or-Unknown, 7Regression: Restore fragment in broken links - https://phabricator.wikimedia.org/T121986#1892933 (10PeterBowman) Posibly related code in [[https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/includes%2FLinker.php#L278|Linker.php]]: ```lang=php private static function li... [19:08:30] 6Discovery, 3Discovery-Cirrus-Sprint, 7I18n, 5Patch-For-Review, and 2 others: Completion suggester beta feature is missing an RTL logo - https://phabricator.wikimedia.org/T121832#1892936 (10Deskana) The above patch fixes the issue, but given the holiday deployment schedule this fix won't be pushed out unti... [19:28:07] 10MediaWiki-Configuration, 10MediaWiki-skins-Metrolook, 10MediaWiki-skins-Slate, 10Vector, and 3 others: composer/installers and wfLoadSkin do not assume the same path ('skin-name' vs. 'SkinName') - https://phabricator.wikimedia.org/T117856#1892939 (10saper) Thanks for quick merge and discussion. I actuall... [19:38:55] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892940 (10Esanders) >>! In T121976#1892845, @Pginer-WMF wrote: > When looking for a representat... [19:52:20] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1892951 (10Aklapper) [19:56:49] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892954 (10Etonkovidova) @Esanders and @Pginer-WMF: iOS Mobile apps uses the following icon to v... [20:13:01] (03PS10) 10Paladox: Move functions and class to separate files [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/214815 [20:14:51] 10MediaWiki-extensions-ContentTranslation: Dont' use 大 ("big") character in ContentTranslation notifications - https://phabricator.wikimedia.org/T121977#1892955 (10Legoktm) [20:15:31] (03PS1) 10Llyrian: Fix composer test issues and remove unneccesary comments [extensions/Math] - 10https://gerrit.wikimedia.org/r/260210 (https://phabricator.wikimedia.org/T67397) [20:17:27] (03PS12) 10Paladox: Add support for renaming tables in mediawiki and extensions [core] - 10https://gerrit.wikimedia.org/r/247085 [20:18:22] (03CR) 10Paladox: Add support for renaming tables in mediawiki and extensions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/247085 (owner: 10Paladox) [20:20:42] (03CR) 10Paladox: "Ok. It seems that I can now do the db install without the errors stoping it but I still do get two errors but in the log." [extensions/Math] - 10https://gerrit.wikimedia.org/r/248076 (https://phabricator.wikimedia.org/T111681) (owner: 10Paladox) [20:22:02] (03PS2) 10Paladox: Fix jenkins tests [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259045 [20:22:21] (03CR) 10Paladox: "check experimental" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259045 (owner: 10Paladox) [20:31:10] (03PS6) 10Paladox: Let the signature button wikitext be over-ridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) [20:55:05] (03CR) 10Legoktm: "Were other extensions outside of the mediawiki-extensions-* job checked to make sure they pass?" [core] - 10https://gerrit.wikimedia.org/r/260031 (owner: 10Anomie) [21:03:26] 10MediaWiki-extensions-AbuseFilter, 6Collaboration-Team-Backlog, 10Thanks: Allow thanking users for edits to edit filters - https://phabricator.wikimedia.org/T121988#1892960 (10He7d3r) 3NEW [21:06:02] 10MediaWiki-ResourceLoader, 6Performance-Team, 7HHVM: Don't use PHP files on-disk for lesscache - https://phabricator.wikimedia.org/T121519#1892968 (10saper) if we go with serialized PHP, will HHVM Authoritative Repo mode be able to load it? [21:14:21] 10Phabricator-Upstream: Cannot move cards to workboards on mobile devices without drag and drop functionality - https://phabricator.wikimedia.org/T85370#1892971 (10doctaxon) Is anyone still working on it? [21:17:11] 10MediaWiki-extensions-SemanticForms, 5Patch-For-Review: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1892976 (10saper) @Yaron_Koren I have reviewed Paladox patches' and this thing is going beyond their scope. Btw. I have just found... [21:20:35] 10MediaWiki-General-or-Unknown: U+00AD SOFT HYPHEN shouldn't be allowed in wiki article titles - https://phabricator.wikimedia.org/T121979#1892985 (10Yurivict) This may have been fixed for the new articles, but I spotted this ones created on 2015-06-29. [21:22:46] 10MediaWiki-Internationalization, 7I18n: Typo in message Transaction-duration-limit-exceeded - https://phabricator.wikimedia.org/T121821#1892986 (10Amire80) a:3Amire80 [21:23:08] 10MediaWiki-Internationalization, 7I18n: Typo in message Transaction-duration-limit-exceeded - https://phabricator.wikimedia.org/T121821#1889340 (10Amire80) It should also have PLURAL. Patch in a minute. [21:24:07] (03PS1) 10Amire80: Fix transaction-duration-limit-exceeded [core] - 10https://gerrit.wikimedia.org/r/260211 (https://phabricator.wikimedia.org/T121821) [21:25:13] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint break, 7WorkType-NewFunctionality: Clarify the procedure for maintaining category-based campaigns - https://phabricator.wikimedia.org/T121841#1889813 (10Amire80) [21:25:17] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10Vector, 5MW-1.26-release: MW 1.26.0: Vector not displaying but other skins load correctly - https://phabricator.wikimedia.org/T119934#1892999 (10saper) Looks like a perfect candidate to be a reason. `open_basedir` is tricky, I haven't yet had time t... [21:25:22] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Dont' use 大 ("big") character in ContentTranslation notifications - https://phabricator.wikimedia.org/T121977#1893001 (10Amire80) [21:25:31] 10MediaWiki-extensions-ContentTranslation, 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, and 2 others: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1893002 (10Amire80) [21:29:01] 10Phabricator-Upstream: Cannot move cards to workboards on mobile devices without drag and drop functionality - https://phabricator.wikimedia.org/T85370#1893005 (10Aklapper) >>! In T85370#1892971, @doctaxon wrote: > Is anyone still working on it? I don't think anybody ever worked on this (if someone did, refere... [21:30:57] 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 7WorkType-Maintenance: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1893006 (10Amire80) [21:31:12] (03CR) 10Raimond Spekking: [C: 032] Fix transaction-duration-limit-exceeded [core] - 10https://gerrit.wikimedia.org/r/260211 (https://phabricator.wikimedia.org/T121821) (owner: 10Amire80) [21:31:29] 10UI-Standardization, 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 7WorkType-Maintenance: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1892719 (10Amire80) If I understand correctly, T121977 is for CX, so I removed the CX tag from this task. [21:32:22] (03CR) 10saper: "Thank you very much!" [core] - 10https://gerrit.wikimedia.org/r/143373 (https://phabricator.wikimedia.org/T69041) (owner: 10Rohan013) [21:34:55] (03PS5) 10VolkerE: Align to CSS coding guidelines and fix CSSLint errors & warnings [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) [21:35:39] 10Phabricator-Bot-Requests: Approval of "Luke081515Bot" - https://phabricator.wikimedia.org/T121989#1893011 (10Luke081515) 3NEW [21:35:42] (03CR) 10VolkerE: Align to CSS coding guidelines and fix CSSLint errors & warnings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [21:37:30] 10MediaWiki-extensions-AbuseFilter, 6Collaboration-Team-Backlog, 10Thanks: Allow thanking users for edits to edit filters - https://phabricator.wikimedia.org/T121988#1893021 (10Luke081515) T60485 is a kind of a dup, because every edit of a abusefilter creates a logentry... [21:37:37] (03Merged) 10jenkins-bot: Fix transaction-duration-limit-exceeded [core] - 10https://gerrit.wikimedia.org/r/260211 (https://phabricator.wikimedia.org/T121821) (owner: 10Amire80) [21:38:34] (03PS10) 10TTO: Prevent blocked users from modifying change tags [core] - 10https://gerrit.wikimedia.org/r/259442 (https://phabricator.wikimedia.org/T102063) (owner: 10Unicornisaurous) [21:38:41] (03PS11) 10TTO: Prevent blocked users from modifying change tags [core] - 10https://gerrit.wikimedia.org/r/259442 (https://phabricator.wikimedia.org/T102063) (owner: 10Unicornisaurous) [21:38:51] (03CR) 10TTO: [C: 032] Prevent blocked users from modifying change tags [core] - 10https://gerrit.wikimedia.org/r/259442 (https://phabricator.wikimedia.org/T102063) (owner: 10Unicornisaurous) [21:39:19] tto: Thanks! [21:40:11] 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: [Regression] Galleries are not displaying correctly in VisualEditor (one image per row with large gaps, rather than multiple images per row) due to wrapping CSS - https://phabricator.wikimedia.org/T121557#1893024 (10TheDJ)... [21:40:39] : tto: Thanks! [21:42:17] 10MediaWiki-Internationalization, 7I18n, 5Patch-For-Review: Typo in message Transaction-duration-limit-exceeded - https://phabricator.wikimedia.org/T121821#1893025 (10Amire80) 5Open>3Resolved [21:43:38] * Hydronium waves at unicornisaurous [21:43:58] (03CR) 10Jonas Kress (WMDE): adds dataTables (032 comments) [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [21:44:08] unicornisaurous: Approved! [21:44:23] * unicornisaurous waves back at Hydronium [21:44:34] Have some hot chocolate [21:44:39] andre__ Could you please publish https://codein.withgoogle.com/dashboard/tasks/5072539130789888/ and https://codein.withgoogle.com/dashboard/tasks/5094205630185472/ ? [21:44:44] * unicornisaurous wonders why he’s waving [21:45:06] saying hi [21:45:16] 5MW-1.25-release: Special:MyPage does not work on 1.25.4 - https://phabricator.wikimedia.org/T121990#1893027 (10ComputeVictory) 3NEW [21:45:26] 10MediaWiki-extensions-RelatedArticles: Related articles Beta throws JS errors in production - https://phabricator.wikimedia.org/T121991#1893034 (10TheDJ) 3NEW [21:46:41] tto: Thanks for the approval! Did you end up getting any tasks published related to the last one? [21:47:02] (03CR) 10Fomafix: [C: 04-1] "Please separate removing of browser workarounds in a separate change." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [21:47:41] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1893041 (10Arnaud_Cheritat) Thanks for replying. I am trying to upgrade. That is looks a risky thing, though. I hope the extension will still work. It takes time. I am stuck at t... [21:47:56] (03Merged) 10jenkins-bot: Prevent blocked users from modifying change tags [core] - 10https://gerrit.wikimedia.org/r/259442 (https://phabricator.wikimedia.org/T102063) (owner: 10Unicornisaurous) [21:49:59] (03CR) 10Krinkle: [C: 032] Replace deprecated wfMsg and wfMsgHtml with wfMessage() (031 comment) [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/260069 (owner: 10Ori.livneh) [21:50:42] (03Merged) 10jenkins-bot: Replace deprecated wfMsg and wfMsgHtml with wfMessage() [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/260069 (owner: 10Ori.livneh) [21:51:38] 10MediaWiki-Change-tagging, 3Google-Code-In-2015, 5Patch-For-Review: Blocked users can change tags - https://phabricator.wikimedia.org/T102063#1893043 (10Unicornisaurous) 5Open>3Resolved [21:53:08] (03CR) 10Krinkle: [C: 031] Convert page creation to using startAtomic()/endAtomic() [core] - 10https://gerrit.wikimedia.org/r/258743 (https://phabricator.wikimedia.org/T120718) (owner: 10Aaron Schulz) [21:53:54] (03CR) 10Krinkle: Replace deprecated wfMsg and wfMsgHtml with wfMessage() (031 comment) [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/260069 (owner: 10Ori.livneh) [21:55:17] (03CR) 10VolkerE: Align to CSS coding guidelines and fix CSSLint errors & warnings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [21:56:48] (03CR) 10Krinkle: [C: 04-1] Align to CSS coding guidelines and fix CSSLint errors & warnings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [21:58:29] (03PS2) 10Krinkle: Avoid calling lazyImportLocalNames() in a few spaces [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/258402 (owner: 10Aaron Schulz) [22:00:15] (03CR) 10Krinkle: [C: 032] Avoid calling lazyImportLocalNames() in a few spaces [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/258402 (owner: 10Aaron Schulz) [22:00:17] (03CR) 10jenkins-bot: [V: 04-1] Avoid calling lazyImportLocalNames() in a few spaces [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/258402 (owner: 10Aaron Schulz) [22:01:23] 5MW-1.25-release: Special:MyPage does not work on 1.25.4 - https://phabricator.wikimedia.org/T121990#1893051 (10Aklapper) [22:01:24] 10MediaWiki-Redirects, 5MW-1.23-release: Special:MyPage, Special:MyTalk, and Special:MyContributions return fatal error - https://phabricator.wikimedia.org/T121892#1893052 (10Aklapper) [22:01:33] 5MW-1.25-release: Special:MyPage does not work on 1.25.4 - https://phabricator.wikimedia.org/T121990#1893027 (10Aklapper) Hi @ComputeVictory, thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system as T121892, but please feel free to report any fu... [22:02:04] 10MediaWiki-Redirects, 5MW-1.23-release, 5MW-1.25-release: Special:MyPage, Special:MyTalk, and Special:MyContributions return fatal error - https://phabricator.wikimedia.org/T121892#1891011 (10Aklapper) [22:02:23] (03CR) 10jenkins-bot: [V: 04-1] Avoid calling lazyImportLocalNames() in a few spaces [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/258402 (owner: 10Aaron Schulz) [22:04:19] legoktm: hello! are you there [22:04:21] ? [22:04:43] (03CR) 10Krinkle: [C: 032] Avoid calling lazyImportLocalNames() in a few spaces [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/258402 (owner: 10Aaron Schulz) [22:05:23] (03PS3) 10Krinkle: Add a maintenance script for finding deprecated interfaces [core] - 10https://gerrit.wikimedia.org/r/259162 (owner: 10Ori.livneh) [22:06:38] (03CR) 10jenkins-bot: [V: 04-1] Avoid calling lazyImportLocalNames() in a few spaces [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/258402 (owner: 10Aaron Schulz) [22:07:56] (03CR) 10Krinkle: [C: 032] Add a maintenance script for finding deprecated interfaces [core] - 10https://gerrit.wikimedia.org/r/259162 (owner: 10Ori.livneh) [22:09:00] 10MediaWiki-User-blocking, 7IPv6: IPv6 range blocks should be limited to /48s, not /19s - https://phabricator.wikimedia.org/T58252#1893059 (10saper) I am not sure that CU viewfinder and maximum block ranges should be necessarily in sync. If CheckUsers can't easily see a wider range, they won't event know if th... [22:10:24] what happens if my mentor does not accept my task in the 5 days that I had to complete it? [22:13:51] (03PS1) 10Krinkle: Remove use of deprecated OutputPage::includeJQuery() [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/260212 [22:14:24] (03CR) 10jenkins-bot: [V: 04-1] Remove use of deprecated OutputPage::includeJQuery() [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/260212 (owner: 10Krinkle) [22:14:44] (03Merged) 10jenkins-bot: Add a maintenance script for finding deprecated interfaces [core] - 10https://gerrit.wikimedia.org/r/259162 (owner: 10Ori.livneh) [22:15:16] 10MediaWiki-General-or-Unknown, 7Easy, 3Google-Code-In-2015, 7JavaScript: Support fragments in mw.util.getUrl() - https://phabricator.wikimedia.org/T103553#1893064 (10Unicornisaurous) a:3Unicornisaurous I've claimed this on the GCI website. [22:15:24] (03PS1) 10Krinkle: Remove use of deprecated OutputPage::includeJQuery() [extensions/Push] - 10https://gerrit.wikimedia.org/r/260213 [22:15:33] victorbarbu_: Can I ask who your mentor is? Have you talked to him? [22:15:59] FlorianSW: legoktm is the mentor. he seems to be offline... [22:16:02] (03CR) 10jenkins-bot: [V: 04-1] Remove use of deprecated OutputPage::includeJQuery() [extensions/Push] - 10https://gerrit.wikimedia.org/r/260213 (owner: 10Krinkle) [22:16:16] (he's been offline for the last 3 days and I pushed something to gerrit) [22:16:27] Hmm, what task is it? Is the change in gerrit merged already? [22:18:05] this is the Gerrit change [22:18:05] https://gerrit.wikimedia.org/r/#/c/259794/ [22:18:23] (03CR) 10Krinkle: "recheck" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/260212 (owner: 10Krinkle) [22:18:25] and this is the task https://codein.withgoogle.com/dashboard/task-instances/5999564335087616/?sp-page=1 [22:18:25] Convert MediaWiki extension "OATHAuth" to use extension registration || 5 days || Code || Wikimedia [22:19:07] (03CR) 10Krinkle: "recheck" [extensions/Push] - 10https://gerrit.wikimedia.org/r/260213 (owner: 10Krinkle) [22:19:20] Oooh cool, gcibot... [22:19:47] (03CR) 10Florianschmidtwelzow: [C: 04-1] "You need to stub the php entry point. You can use the Gadgets php entry point as an example:" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/259794 (https://phabricator.wikimedia.org/T87949) (owner: 10Victorbarbu) [22:19:49] FlorianSW: the gerrit change is not merged yet. it is not even reviewed [22:21:01] As long as you hit submit in GCI, nothing bad will happen. If they review your patch and decide they want more work, they can send it back to you and they can give you an extension (at least thats the way it was last year) [22:21:30] victorbarbu_: I think, that legoktm has a very stressful change, and I think he will take care of your change :] If not, you maybe can ask an org admin (andre__ or Nemo_bis or qgil, iirc) what to do :) I would not like to accept the work without any feedback from legoktm, that wouldn't be very fair. [22:21:49] victorbarbu_: Remember, that a GCI mentor has 36 hours to review a task :) [22:23:33] FlorianSW: should I keep all those variables in OATHAuth.php ? [22:23:43] victorbarbu_: what variables? [22:25:09] FlorianSW: I don't know where to find that repository online to show you the code [22:25:38] github.com/wikimedia/mediawiki-extension-OATHAuth for eample :) [22:25:58] github.com/wikimedia/mediawiki-extensions-OATHAuth sorry [22:26:08] (03PS1) 10Krinkle: Remove use of deprecated OutputPage::includeJQuery() [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/260214 [22:26:43] (03PS1) 10Krinkle: Remove use of deprecated OutputPage::includeJQuery() [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/260215 [22:26:58] FlorianSW: https://github.com/wikimedia/mediawiki-extensions-OATHAuth/blob/master/OATHAuth.php#L46 the next 10-20 lines of code [22:28:49] victorbarbu_: no, remove them all. They are now in the extension.json and are loaded by extension registration :) [22:29:23] okay, doing it now! [22:29:55] 10MediaWiki-Special-pages, 10MediaWiki-User-preferences, 7Easy, 3Google-Code-In-2015, 7JavaScript: Inaccessible anchors in the special preferences page - https://phabricator.wikimedia.org/T54469#1893079 (10Scimonster) a:3Scimonster [22:30:10] (03PS5) 10Krinkle: Styleing improvements of ReCaptcha NoCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [22:30:38] (03PS6) 10Krinkle: Styling improvements of ReCaptcha NoCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [22:30:49] (03PS1) 10Scimonster: [Special:Preferences] Switch tabs when hash is set to an item in another tab. [core] - 10https://gerrit.wikimedia.org/r/260216 (https://phabricator.wikimedia.org/T54469) [22:33:03] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1893083 (10Arnaud_Cheritat) [22:36:51] (03CR) 10Krinkle: Styling improvements of ReCaptcha NoCaptcha (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [22:38:49] (03CR) 10Krinkle: HTMLUserTextField: Enable suggestions for non-OOUI mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/249793 (https://phabricator.wikimedia.org/T117067) (owner: 10Florianschmidtwelzow) [22:39:22] 10MediaWiki-extensions-CLDR, 3Google-Code-In-2015: Convert cldr to use extension registration - https://phabricator.wikimedia.org/T87895#1893085 (10Florian) [22:43:11] 10MediaWiki-extensions-JsonConfig: Convert JsonConfig extension to use extension registration - https://phabricator.wikimedia.org/T88054#1893089 (10Florian) [22:43:47] (03CR) 10Krinkle: [C: 04-1] RequestContext: Load the request object for getRequest on first call (031 comment) [core] - 10https://gerrit.wikimedia.org/r/253651 (owner: 10Florianschmidtwelzow) [22:45:19] legoktm: I rechecked the tasks I moved to GCI yesterday and put the one's where I'm not sure anymore (after checking the entry points), if they fit the GCI scope to "needs clarification" or removed the GCI project. The corresponding tasks in GCI I set to "DONOTPUBLISH" :) Sorry for the confusion yesterday! [22:47:35] (03CR) 10Florianschmidtwelzow: [C: 04-1] HTMLUserTextField: Enable suggestions for non-OOUI mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/249793 (https://phabricator.wikimedia.org/T117067) (owner: 10Florianschmidtwelzow) [22:48:58] (03PS2) 10Florianschmidtwelzow: HTMLUserTextField: Enable suggestions for non-OOUI mode [core] - 10https://gerrit.wikimedia.org/r/249793 (https://phabricator.wikimedia.org/T117067) [22:53:23] (03CR) 10Florianschmidtwelzow: [C: 04-1] Styling improvements of ReCaptcha NoCaptcha (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [22:54:22] (03CR) 10Florianschmidtwelzow: Styling improvements of ReCaptcha NoCaptcha (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [22:56:09] (03PS7) 10Florianschmidtwelzow: Styling improvements of ReCaptcha NoCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 [22:57:11] (03CR) 10Florianschmidtwelzow: RequestContext: Load the request object for getRequest on first call (031 comment) [core] - 10https://gerrit.wikimedia.org/r/253651 (owner: 10Florianschmidtwelzow) [22:58:38] (03PS5) 10Florianschmidtwelzow: RequestContext: Load the request object for getRequest on first call [core] - 10https://gerrit.wikimedia.org/r/253651 [22:58:55] MWException Could not acquire lock for on upload [22:59:31] maybe some folder that needs chmod'ing? [22:59:33] (03PS2) 10Ori.livneh: Use ExtensionRegistry to determine whether TextExtracts is installed [extensions/Popups] - 10https://gerrit.wikimedia.org/r/260091 (https://phabricator.wikimedia.org/T121777) (owner: 10Legoktm) [22:59:36] (03CR) 10jenkins-bot: [V: 04-1] Styling improvements of ReCaptcha NoCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [22:59:55] Hydronium: is it for the one file, or have you tried others? [23:00:07] For all uploads [23:00:08] Hydronium: {$wgUploadDirectory}/lockdir [23:00:10] (on vagrant) [23:01:09] (03PS1) 10Unicornisaurous: Support fragments in mw.util.getUrl() [core] - 10https://gerrit.wikimedia.org/r/260217 (https://phabricator.wikimedia.org/T103553) [23:03:32] ori: that did the trick, thanks! [23:03:46] (03PS1) 10Florianschmidtwelzow: SpecialPageLanguage: Use title input (enable suggestions) and autofocus [core] - 10https://gerrit.wikimedia.org/r/260218 [23:04:37] (03CR) 10jenkins-bot: [V: 04-1] Support fragments in mw.util.getUrl() [core] - 10https://gerrit.wikimedia.org/r/260217 (https://phabricator.wikimedia.org/T103553) (owner: 10Unicornisaurous) [23:05:02] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/237682 (owner: 10Florianschmidtwelzow) [23:08:51] 10MediaWiki-General-or-Unknown: Thumbnails of a PNG with a gamma chunk are computed wrong - https://phabricator.wikimedia.org/T121984#1893093 (10Arnaud_Cheritat) OK I made tests and it's definitely a bug in ImageMagick 6.7.7. Version 6.9 seems to do a slightly better job, unfortunately I cannot update it, I hav... [23:10:34] (03PS3) 10Victorbarbu: Upgrade Extension:OATHAuth to the registration system [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/259794 (https://phabricator.wikimedia.org/T87949) [23:11:58] FlorianSW: I uploaded a new patch. please check it out. I have to go. I will see any comments on gerrit [23:15:07] (03CR) 10Florianschmidtwelzow: [C: 04-1] "some things :)" (034 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/259794 (https://phabricator.wikimedia.org/T87949) (owner: 10Victorbarbu) [23:17:22] (03PS2) 10Unicornisaurous: Support fragments in mw.util.getUrl() [core] - 10https://gerrit.wikimedia.org/r/260217 (https://phabricator.wikimedia.org/T103553) [23:19:43] (03PS1) 10Ori.livneh: Stop calling ApiQueryBase::titleToKey() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260220 [23:21:02] Reedy: ^ [23:22:13] (03PS2) 10Ori.livneh: Stop calling ApiQueryBase::titleToKey() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260220 [23:38:02] (03CR) 10Gergő Tisza: "Not sure if sig_sample is a good name for this, it's not really a sample. Maybe sig_text?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [23:40:55] (03CR) 10Gergő Tisza: [C: 04-1] "Same problem with ~~~~ as in the other patch. Also, maybe the message should just contain {{int:sig_sample}} (or whatever that message nam" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [23:48:14] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [23:49:39] (03CR) 10Physikerwelt: [C: 04-2] "You can not correct the problems with one commit in another commit." [extensions/Math] - 10https://gerrit.wikimedia.org/r/260210 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [23:50:04] (03CR) 10Physikerwelt: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/260210 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [23:57:31] (03PS2) 10Aaron Schulz: [WIP] Convert page modification to using startAtomic()/endAtomic() [core] - 10https://gerrit.wikimedia.org/r/258744 (https://phabricator.wikimedia.org/T120718)