[00:04:50] (03Merged) 10jenkins-bot: Cleanup test jobs better [core] - 10https://gerrit.wikimedia.org/r/258646 (owner: 10Aaron Schulz) [00:05:37] (03Merged) 10jenkins-bot: Check User::getId() in makeTestEdits.php [core] - 10https://gerrit.wikimedia.org/r/258640 (owner: 10Aaron Schulz) [00:05:39] (03Merged) 10jenkins-bot: Fix MWOAuthDAO IDEA errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258741 (owner: 10Aaron Schulz) [00:06:19] (03CR) 10Legoktm: [C: 032] Move inline $wgStatsdMetricPrefix default to DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/258072 (owner: 10Krinkle) [00:07:25] (03PS5) 10Aaron Schulz: Make sure edits are not timestamped before the last edit [core] - 10https://gerrit.wikimedia.org/r/258723 [00:09:37] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876812 (10Josve05a) >>! In T120867#1876793, @matmarex wrote: > Experienced users (>= 10 edits in... [00:09:56] (03CR) 10Legoktm: [C: 031] Fix PPNode_Hash_Tree::getChildrenOfType return value [core] - 10https://gerrit.wikimedia.org/r/257950 (owner: 10Anomie) [00:10:49] (03CR) 10Legoktm: [C: 04-1] "Needs rebase, data-mw (and data-parsoid) are now already whitelisted in the Sanitizer." [core] - 10https://gerrit.wikimedia.org/r/256665 (owner: 10Krinkle) [00:13:06] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876814 (10matmarex) Counting edits on Commons only. [00:13:16] (03Merged) 10jenkins-bot: Move inline $wgStatsdMetricPrefix default to DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/258072 (owner: 10Krinkle) [00:13:21] (03CR) 10Legoktm: [C: 032] Set Language in SpecialSearchTest.php [core] - 10https://gerrit.wikimedia.org/r/257374 (owner: 10Umherirrender) [00:13:58] (03CR) 10Legoktm: [C: 032] "Is there a bug associated with this? I think we want to backport this to 1.26?" [core] - 10https://gerrit.wikimedia.org/r/257311 (owner: 10Billm) [00:15:43] (03CR) 10Legoktm: [C: 032] "This is fine for now IMO, I think having a comment explaining why it isn't enabled is useful." [core] - 10https://gerrit.wikimedia.org/r/257210 (owner: 10Umherirrender) [00:15:55] (03CR) 10Legoktm: [C: 032] Remove dead code about nlinks from Special:Wantedpages [core] - 10https://gerrit.wikimedia.org/r/257211 (owner: 10Umherirrender) [00:16:39] (03CR) 10Legoktm: [C: 04-1] "I agree with Bartosz." [core] - 10https://gerrit.wikimedia.org/r/256030 (owner: 10Florianschmidtwelzow) [00:17:59] (03CR) 10Legoktm: [C: 032] Adjust datetime in email confirmation email [core] - 10https://gerrit.wikimedia.org/r/256113 (https://phabricator.wikimedia.org/T29158) (owner: 10Umherirrender) [00:18:13] (03Abandoned) 10Legoktm: Adjust date and time in email confirmation email [core] - 10https://gerrit.wikimedia.org/r/119936 (https://phabricator.wikimedia.org/T29158) (owner: 1001tonythomas) [00:19:12] (03PS7) 10Paladox: Allow removing edit toolbar from the editing form [core] - 10https://gerrit.wikimedia.org/r/120357 (https://phabricator.wikimedia.org/T55448) (owner: 10Deepali) [00:19:43] (03CR) 10Paladox: "Updating the commit msg to use the new phabricator bug id." [core] - 10https://gerrit.wikimedia.org/r/120357 (https://phabricator.wikimedia.org/T55448) (owner: 10Deepali) [00:19:54] (03CR) 10Legoktm: [C: 032] PHP 7 compatibility: Fix variable interpolation in RevisionDeleter.php [core] - 10https://gerrit.wikimedia.org/r/256731 (https://phabricator.wikimedia.org/T115250) (owner: 10Umherirrender) [00:20:15] (03CR) 10Legoktm: [C: 032] PHP 7 compatibility: Fix variable interpolation in ImageGalleryBase.php [core] - 10https://gerrit.wikimedia.org/r/256727 (https://phabricator.wikimedia.org/T115249) (owner: 10Umherirrender) [00:20:16] 10Reading-Web, 10Wikimedia-Developer-Summit-2016, 7Mobile: The future of MobileFrontend - https://phabricator.wikimedia.org/T114065#1876823 (10Tnegrin) Hi Quim -- we'll take a look next week. It's very connected to the work on the mobile presentation that we're doing right now. -Toby [00:21:07] (03CR) 10Legoktm: [C: 032] PHP 7 compatibility: Fix variable interpolation in BaseBlacklist.php [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/256732 (https://phabricator.wikimedia.org/T115254) (owner: 10Umherirrender) [00:21:26] (03Merged) 10jenkins-bot: Set Language in SpecialSearchTest.php [core] - 10https://gerrit.wikimedia.org/r/257374 (owner: 10Umherirrender) [00:21:30] (03Merged) 10jenkins-bot: Remove INSERT value for page_counter variable [core] - 10https://gerrit.wikimedia.org/r/257311 (owner: 10Billm) [00:22:55] (03Merged) 10jenkins-bot: Comment out getSubpagesForPrefixSearch of Special:Tags [core] - 10https://gerrit.wikimedia.org/r/257210 (owner: 10Umherirrender) [00:23:13] (03CR) 10Legoktm: [C: 032] Call Skin::setRelevantUser on Special:UserRights [core] - 10https://gerrit.wikimedia.org/r/256036 (owner: 10Umherirrender) [00:23:29] (03Abandoned) 10Legoktm: SpecialUserRights: Set the relevant user for the skin if possible [core] - 10https://gerrit.wikimedia.org/r/234310 (owner: 10Legoktm) [00:24:49] (03Merged) 10jenkins-bot: Remove dead code about nlinks from Special:Wantedpages [core] - 10https://gerrit.wikimedia.org/r/257211 (owner: 10Umherirrender) [00:24:51] (03CR) 10Legoktm: [C: 032] "Release notes would be nice" [core] - 10https://gerrit.wikimedia.org/r/256033 (owner: 10Umherirrender) [00:26:03] (03CR) 10Jcrespo: "LegoKTM, see topic/branch: T116759" [core] - 10https://gerrit.wikimedia.org/r/257311 (owner: 10Billm) [00:26:33] (03PS1) 10Yurik: Support group='*' for all modes [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/258912 [00:28:02] (03CR) 10Legoktm: "Ah, thanks. @Billm: In the future, please mention the bug in the commit message as explained at (03CR) 10Alex Monk: [C: 032] "seems to have been true for years - https://phabricator.wikimedia.org/rSVN82034" [core] - 10https://gerrit.wikimedia.org/r/256033 (owner: 10Umherirrender) [00:29:21] (03Merged) 10jenkins-bot: Adjust datetime in email confirmation email [core] - 10https://gerrit.wikimedia.org/r/256113 (https://phabricator.wikimedia.org/T29158) (owner: 10Umherirrender) [00:29:25] (03Merged) 10jenkins-bot: PHP 7 compatibility: Fix variable interpolation in RevisionDeleter.php [core] - 10https://gerrit.wikimedia.org/r/256731 (https://phabricator.wikimedia.org/T115250) (owner: 10Umherirrender) [00:29:30] (03Merged) 10jenkins-bot: PHP 7 compatibility: Fix variable interpolation in ImageGalleryBase.php [core] - 10https://gerrit.wikimedia.org/r/256727 (https://phabricator.wikimedia.org/T115249) (owner: 10Umherirrender) [00:29:33] (03Merged) 10jenkins-bot: PHP 7 compatibility: Fix variable interpolation in BaseBlacklist.php [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/256732 (https://phabricator.wikimedia.org/T115254) (owner: 10Umherirrender) [00:30:19] (03Abandoned) 10Legoktm: Commit 1 [core] - 10https://gerrit.wikimedia.org/r/255382 (owner: 10Wojsal) [00:30:23] (03Abandoned) 10Legoktm: Commit 1 [core] - 10https://gerrit.wikimedia.org/r/255381 (owner: 10Wojsal) [00:30:40] (03PS4) 10Legoktm: Running a SELECT statement on a missing table causes errors. [core] - 10https://gerrit.wikimedia.org/r/255294 (https://phabricator.wikimedia.org/T54294) (owner: 10Alexia) [00:33:18] (03CR) 10Reedy: [C: 032 V: 032] Fix some syntax errors, implement method stubs [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258909 (owner: 10Reedy) [00:33:49] (03PS17) 10Reedy: Add composer.json with parallel-lint [extensions/Offline] - 10https://gerrit.wikimedia.org/r/245929 (owner: 10Paladox) [00:34:15] (03CR) 10jenkins-bot: [V: 04-1] Add composer.json with parallel-lint [extensions/Offline] - 10https://gerrit.wikimedia.org/r/245929 (owner: 10Paladox) [00:34:17] (03CR) 10Legoktm: [C: 031] "Looks sane, but I'm not sure if it'll have any unintended effects." [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [00:34:54] (03Merged) 10jenkins-bot: Call Skin::setRelevantUser on Special:UserRights [core] - 10https://gerrit.wikimedia.org/r/256036 (owner: 10Umherirrender) [00:34:57] (03Merged) 10jenkins-bot: Remove uncalled Skin::getNamespaceNotice [core] - 10https://gerrit.wikimedia.org/r/256033 (owner: 10Umherirrender) [00:35:03] (03CR) 10Reedy: "Do we really need to exclude vendor if the extension doesn't have a vendor repo?" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/245929 (owner: 10Paladox) [00:36:01] (03PS2) 10Legoktm: Add user and previous rev to HistoryRevisionTools, and user to DiffRevisionTools [core] - 10https://gerrit.wikimedia.org/r/254640 (owner: 10Cenarium) [00:36:32] (03CR) 10Reedy: [C: 032 V: 032] Replace deprecated editToken with getEditToken [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/258906 (owner: 10Reedy) [00:36:49] (03CR) 10Reedy: "NB unrelated test failure" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/258906 (owner: 10Reedy) [00:38:34] parent5446: around? [00:40:55] 10MediaWiki-extensions-MsUpload, 10Continuous-Integration-Config: jshint:all fails on MsUpload - https://phabricator.wikimedia.org/T121367#1876838 (10Reedy) Warnings above should be fixed. Or at minimum, make the test non voting until it is [00:41:25] (03CR) 10Legoktm: [C: 032] "Thanks! This will be useful in the Thanks extension :-)" [core] - 10https://gerrit.wikimedia.org/r/254640 (owner: 10Cenarium) [00:45:02] (03CR) 10Legoktm: "Shouldn't this go in the examples extension?" [core] - 10https://gerrit.wikimedia.org/r/254583 (https://phabricator.wikimedia.org/T119240) (owner: 10Spage) [00:47:43] (03PS4) 10Legoktm: RequestContext: Load the request object for getRequest on first call [core] - 10https://gerrit.wikimedia.org/r/253651 (owner: 10Florianschmidtwelzow) [00:49:03] (03PS2) 10Yurik: Support group='*' for all modes, preprocess params [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/258912 [00:50:43] (03CR) 10Legoktm: [C: 032] Add error checking for file argument [core] - 10https://gerrit.wikimedia.org/r/252851 (owner: 10MarkAHershberger) [00:50:56] (03CR) 10Paladox: "I'm not sure since I think when composer is run that the packages here are merged in mediawiki core so it is located there and ran there." [extensions/Offline] - 10https://gerrit.wikimedia.org/r/245929 (owner: 10Paladox) [00:52:04] (03CR) 10Paladox: [C: 032] "Thanks." [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/258903 (owner: 10Reedy) [00:53:58] (03CR) 10Alex Monk: Show user names as subpages of special pages in autocomplete search (031 comment) [core] - 10https://gerrit.wikimedia.org/r/256745 (owner: 10Umherirrender) [00:55:13] (03Merged) 10jenkins-bot: Add user and previous rev to HistoryRevisionTools, and user to DiffRevisionTools [core] - 10https://gerrit.wikimedia.org/r/254640 (owner: 10Cenarium) [00:55:25] (03CR) 10Alex Monk: Show user names as subpages of special pages in autocomplete search (031 comment) [core] - 10https://gerrit.wikimedia.org/r/256745 (owner: 10Umherirrender) [00:56:04] (03CR) 10Yuvipanda: [C: 032 V: 032] "Thank you very much :)" [extensions/NotebookViewer] - 10https://gerrit.wikimedia.org/r/258773 (owner: 10Raimond Spekking) [00:57:42] (03CR) 10Paladox: Add i18n file (031 comment) [extensions/NotebookViewer] - 10https://gerrit.wikimedia.org/r/258773 (owner: 10Raimond Spekking) [01:00:08] (03CR) 10Legoktm: [C: 032] SpecialPagesWithProp: Use 'combobox' field and convert to OOUI [core] - 10https://gerrit.wikimedia.org/r/251827 (https://phabricator.wikimedia.org/T117730) (owner: 10Bartosz Dziewoński) [01:01:22] 10UI-Standardization, 7Easy, 5Patch-For-Review: Convert Special:PagesWithProp to OOUI - https://phabricator.wikimedia.org/T117730#1876854 (10Legoktm) Err, why does T118120 block this? [01:01:46] (03Merged) 10jenkins-bot: Add error checking for file argument [core] - 10https://gerrit.wikimedia.org/r/252851 (owner: 10MarkAHershberger) [01:01:48] (03Merged) 10jenkins-bot: Replace deprecated editToken with getEditToken [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/258903 (owner: 10Reedy) [01:01:54] (03CR) 10Legoktm: SpecialPagesWithProp: Use 'combobox' field and convert to OOUI [core] - 10https://gerrit.wikimedia.org/r/251827 (https://phabricator.wikimedia.org/T117730) (owner: 10Bartosz Dziewoński) [01:02:09] 6Phabricator: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876856 (10Paladox) 3NEW [01:02:29] 6Phabricator: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876863 (10Paladox) @deamon can I add you to task since your the one that does this. [01:02:48] 10UI-Standardization, 7Easy, 5Patch-For-Review: Convert Special:PagesWithProp to OOUI - https://phabricator.wikimedia.org/T117730#1876865 (10matmarex) I must say I have no idea. It would've been more reasonable for T118119 to block it, I probably meant that. [01:03:04] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Update Special:OAuthConsumerRegistration to use the new HTMLComboboxField rather than HTMLAutoCompleteSelectField - https://phabricator.wikimedia.org/T118120#1876869 (10matmarex) [01:03:06] 10MediaWiki-HTMLForm, 5MW-1.27-release-notes, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Implement HTMLComboboxField - https://phabricator.wikimedia.org/T118119#1791955 (10matmarex) [01:03:09] 10UI-Standardization, 7Easy, 5Patch-For-Review: Convert Special:PagesWithProp to OOUI - https://phabricator.wikimedia.org/T117730#1876868 (10matmarex) [01:03:21] 6Phabricator: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876856 (10Paladox) [01:03:30] (03CR) 10Legoktm: [C: 032] SpecialPagesWithProp: Use 'combobox' field and convert to OOUI [core] - 10https://gerrit.wikimedia.org/r/251827 (https://phabricator.wikimedia.org/T117730) (owner: 10Bartosz Dziewoński) [01:04:34] (03PS2) 10Cenarium: Allow to regroup log types [core] - 10https://gerrit.wikimedia.org/r/258410 (https://phabricator.wikimedia.org/T121177) [01:05:44] 6Phabricator, 10Diffusion: When creating repo in gerrit a repo should also be created in phabricator - https://phabricator.wikimedia.org/T121371#1876873 (10Paladox) 3NEW [01:05:58] (03CR) 10Legoktm: [C: 032] DefaultSettings.php: Use .invalid as invalid e-mail address (RFC 2606) [core] - 10https://gerrit.wikimedia.org/r/251636 (owner: 10Gerrit Patch Uploader) [01:06:59] (03CR) 10jenkins-bot: [V: 04-1] Running a SELECT statement on a missing table causes errors. [core] - 10https://gerrit.wikimedia.org/r/255294 (https://phabricator.wikimedia.org/T54294) (owner: 10Alexia) [01:07:08] (03CR) 10Cenarium: "I went with a config var instead. It's a bit more complicated but that way, extensions don't have anything to do." [core] - 10https://gerrit.wikimedia.org/r/258410 (https://phabricator.wikimedia.org/T121177) (owner: 10Cenarium) [01:08:15] (03Merged) 10jenkins-bot: SpecialPagesWithProp: Use 'combobox' field and convert to OOUI [core] - 10https://gerrit.wikimedia.org/r/251827 (https://phabricator.wikimedia.org/T117730) (owner: 10Bartosz Dziewoński) [01:09:00] 6Phabricator, 10Diffusion: When creating repo in gerrit a repo should also be created in phabricator - https://phabricator.wikimedia.org/T121371#1876881 (10Paladox) [01:09:34] 10UI-Standardization, 7Epic: Convert all MW core special pages to OOUI - https://phabricator.wikimedia.org/T107037#1876885 (10matmarex) [01:09:37] 10UI-Standardization, 7Easy, 5Patch-For-Review: Convert Special:PagesWithProp to OOUI - https://phabricator.wikimedia.org/T117730#1876883 (10matmarex) 5Open>3Resolved a:3matmarex [01:11:06] (03PS3) 10Legoktm: $wgUsersNotifiedOnAllChanges should not send mail twice [core] - 10https://gerrit.wikimedia.org/r/143373 (https://phabricator.wikimedia.org/T69041) (owner: 10Rohan013) [01:13:51] (03CR) 10jenkins-bot: [V: 04-1] OutputPage: Use getPageViewLanguage for Content-language [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [01:14:56] (03Merged) 10jenkins-bot: DefaultSettings.php: Use .invalid as invalid e-mail address (RFC 2606) [core] - 10https://gerrit.wikimedia.org/r/251636 (owner: 10Gerrit Patch Uploader) [01:16:45] (03CR) 10Legoktm: [C: 04-1] "+1, needs rebase though." [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [01:19:31] (03CR) 10Yurik: [C: 032 V: 032] Support group='*' for all modes, preprocess params [extensions/Kartographer] - 10https://gerrit.wikimedia.org/r/258912 (owner: 10Yurik) [01:19:33] (03Abandoned) 10Legoktm: Mark TestORMRowTest as broken [core] - 10https://gerrit.wikimedia.org/r/172662 (https://phabricator.wikimedia.org/T39601) (owner: 10saper) [01:19:54] 10MediaWiki-Database, 7Tracking: PostgreSQL/pgsql support (tracking) - https://phabricator.wikimedia.org/T2384#1876894 (10Legoktm) [01:19:56] 10MediaWiki-Unit-tests, 5Patch-For-Review: Tests introduced in tests/phpunit/includes/db/TestORMRowTest.php fail on PostgreSQL - https://phabricator.wikimedia.org/T39601#1876891 (10Legoktm) 5Open>3Resolved a:3Legoktm Resolved by removing all of the ORM related code out of core. [01:20:06] (03CR) 10Reedy: "I was going to -1 for array( 'addTable', 'msg_resource', 'patch-msg_resource.sql' ), still being there, but it's removed in the dependant " [core] - 10https://gerrit.wikimedia.org/r/251660 (owner: 10Krinkle) [01:21:23] (03PS3) 10Cenarium: Allow to prevent categorization except by specially marked categories [core] - 10https://gerrit.wikimedia.org/r/255428 (https://phabricator.wikimedia.org/T17941) [01:21:58] (03PS1) 10Awight: Fix case of wfWikiID calls [core] - 10https://gerrit.wikimedia.org/r/258915 [01:22:53] (03CR) 10Reedy: [C: 032] Fix case of wfWikiID calls [core] - 10https://gerrit.wikimedia.org/r/258915 (owner: 10Awight) [01:23:21] (03PS6) 10Reedy: resourceloader: Remove obsolete msg_resource_links table [core] - 10https://gerrit.wikimedia.org/r/251660 (owner: 10Krinkle) [01:23:28] (03CR) 10Reedy: [C: 032] resourceloader: Remove obsolete msg_resource_links table [core] - 10https://gerrit.wikimedia.org/r/251660 (owner: 10Krinkle) [01:24:29] (03PS2) 10Reedy: resourceloader: Remove obsolete msg_resource database table [core] - 10https://gerrit.wikimedia.org/r/258033 (owner: 10Krinkle) [01:24:35] (03CR) 10Reedy: [C: 032] resourceloader: Remove obsolete msg_resource database table [core] - 10https://gerrit.wikimedia.org/r/258033 (owner: 10Krinkle) [01:26:04] legoktm: Next WMF branch is gonna have a lot of changes :P [01:27:08] (03CR) 10Bartosz Dziewoński: "> The desired interface is the one that is most effective at turning away copyvios *and* at encouraging good contributions. You should hav" [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) (owner: 10Bartosz Dziewoński) [01:27:25] ori: thanks for your comments :) [01:30:38] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876895 (10awight) I just checked, and our toollabs wiki currently has wiki ID `s52782__wikidb_p`. It sounds like the easiest way to continue testing is if I write a patch that overrides how mw-ext-ORES gets the wiki ID, to rep... [01:33:41] (03PS1) 10Awight: [DO NOT MERGE] Force 'testwiki' ID [extensions/ORES] - 10https://gerrit.wikimedia.org/r/258916 [01:36:32] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876896 (10awight) @halfak The extension uses the `damaging` model now. Please add that model to your test data generator, or just replace `reverted`. @Ladsgroup Please apply the https://gerrit.wikimedia.org/r/#/c/258916/ patc... [01:37:54] (03Merged) 10jenkins-bot: Fix case of wfWikiID calls [core] - 10https://gerrit.wikimedia.org/r/258915 (owner: 10Awight) [01:38:57] Reedy: and this one was only a week! [01:41:53] (03Merged) 10jenkins-bot: resourceloader: Remove obsolete msg_resource_links table [core] - 10https://gerrit.wikimedia.org/r/251660 (owner: 10Krinkle) [01:43:16] (03PS1) 10Neonowy: Special:Preferences Remove red box in email and changed confirm error to warning [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) [01:43:46] (03CR) 10Parent5446: Running a SELECT statement on a missing table causes errors. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/255294 (https://phabricator.wikimedia.org/T54294) (owner: 10Alexia) [01:46:22] (03Merged) 10jenkins-bot: resourceloader: Remove obsolete msg_resource database table [core] - 10https://gerrit.wikimedia.org/r/258033 (owner: 10Krinkle) [01:46:39] parent5446, legoktm[NE]: any thoughts on https://gerrit.wikimedia.org/r/#/c/256745/ ? [01:50:12] (03PS2) 10Neonowy: Special:Preferences Remove red box in email and changed confirm error to warning [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) [01:53:51] (03CR) 10Alex Monk: [C: 04-1] Allow easy suppression of multiple deleted revs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [02:02:51] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1876913 (10josephine_l) @Niedzielski @Nicolas_Raoul What do you think of using [[ http://developer.android.com/reference/android/media/ExifInterface.html... [02:04:37] (03CR) 10Alex Monk: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [02:08:34] 10MobileFrontend, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Use CSS to create mw-ui-icon-arrow-down from mw-ui-icon-arrow-up - https://phabricator.wikimedia.org/T102154#1876919 (10bmansurov) looks good [02:12:31] (03PS4) 10Yurik: Compress graph_specs page property [extensions/Graph] - 10https://gerrit.wikimedia.org/r/255914 (https://phabricator.wikimedia.org/T100942) [02:13:08] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876920 (10Ladsgroup) @awight: I did exactly this since the beginning both for my localhost and ores test wiki but I used enwiki since there wasn't testwiki at that moment. I change it to test wiki and see what happens [02:15:43] 6Phabricator: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876922 (10Aklapper) See and read T616 (no additional comment needed). [02:15:51] 6Phabricator: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876924 (10Aklapper) [02:16:12] 6Phabricator, 10Diffusion: When creating repo in gerrit a repo should also be created in phabricator - https://phabricator.wikimedia.org/T121371#1876928 (10Aklapper) See and read T616 (no additional comment needed). [02:16:24] 6Phabricator, 10Diffusion: When creating repo in gerrit a repo should also be created in phabricator - https://phabricator.wikimedia.org/T121371#1876930 (10Aklapper) [02:16:47] 10Diffusion: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876856 (10Aklapper) [02:16:52] 10Diffusion: When creating repo in gerrit a repo should also be created in phabricator - https://phabricator.wikimedia.org/T121371#1876873 (10Aklapper) [02:17:09] 10Diffusion: Create MediaWiki/extension/NotebookViewer repo in phabricator - https://phabricator.wikimedia.org/T121370#1876856 (10Aklapper) Not #Phabricator but #Diffusion [02:17:14] 10Diffusion: When creating repo in gerrit a repo should also be created in phabricator - https://phabricator.wikimedia.org/T121371#1876873 (10Aklapper) Not #Phabricator but #Diffusion [02:17:36] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876936 (10Ladsgroup) Not working, db is still empty. [02:25:05] 10MediaWiki-Gallery, 7Easy, 5MW-1.27-release-notes, 7Newphp, and 2 others: PHP 7 compatibility: Fix variable interpolation in ImageGalleryBase.php - https://phabricator.wikimedia.org/T115249#1876938 (10Aklapper) 5Open>3Resolved Patch merged; closing as resolved. Thanks, @Umherirrender! [02:25:09] 10MediaWiki-Revision-deletion, 7Easy, 5MW-1.27-release-notes, 7Newphp, and 2 others: PHP 7 compatibility: Fix variable interpolation in RevisionDeleter.php - https://phabricator.wikimedia.org/T115250#1876940 (10Aklapper) 5Open>3Resolved Patch merged; closing as resolved. Thanks, @Umherirrender! [02:25:11] 10MediaWiki-extensions-SpamBlacklist, 7Easy, 7Newphp, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): PHP 7 compatibility: Fix variable interpolation in BaseBlacklist.php - https://phabricator.wikimedia.org/T115254#1876942 (10Aklapper) 5Open>3Resolved Patch merged; closing as resolved. Than... [02:26:29] (03CR) 10Legoktm: [C: 04-1] Bug:T87960 (031 comment) [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) (owner: 10Ananay) [02:35:45] 10MediaWiki-extensions-EducationProgram: Use a single log (log_type) for any Education Program log_action - https://phabricator.wikimedia.org/T47755#1876944 (10Cenarium) >>! In T47755#1876163, @Nemo_bis wrote: >>>! In T47755#1872054, @Cenarium wrote: >> In fact, we don't //have// to use different log_actions, we... [02:52:46] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876946 (10Ladsgroup) Okay, I just added @awight and @halfak to the tools project. What you need to do right now is: ``` ssh awight@tools.wmflabs.org become ores cd public_html/mediawiki ``` Then you can do whatever you want a... [03:17:27] (03PS2) 10Ananay: Bug:T87960 [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) [03:34:04] 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup: User can't login from cernain IP, CentralAuth don't work - https://phabricator.wikimedia.org/T121372#1876951 (10MaxBioHazard) 3NEW [03:38:08] 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: User can't login from cernain IP, CentralAuth don't work - https://phabricator.wikimedia.org/T121372#1876962 (10Peachey88) [03:40:54] 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: User can't login from cernain IP, CentralAuth don't work - https://phabricator.wikimedia.org/T121372#1876965 (10Krenair) ```2015-12-14 03:36:12 mw1219 ruwiki exception ERROR: [9a41aec5] /wiki/%D0%A1%D0%BB%D1%83%... [03:41:20] 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: User:Туча is broken - https://phabricator.wikimedia.org/T121372#1876966 (10Krenair) [03:50:27] (03PS10) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [03:50:41] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (033 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [03:55:06] 4(no projects): #mediawiki-core - search results show "\n" at the bottom of the page - https://phabricator.wikimedia.org/T121373#1876968 (10Steinlaus) 3NEW [03:59:09] (03CR) 10Alex Monk: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [04:05:20] 10MediaWiki-extensions-Gadgets, 3Community-Tech-Sprint: Add a list of default gadgets to Special:GadgetUsage - https://phabricator.wikimedia.org/T121133#1876972 (10NiharikaKohli) a:3NiharikaKohli [04:05:54] (03PS11) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [04:06:01] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [04:19:00] 10MediaWiki-Revision-deletion, 7Easy: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1876976 (10lfaraone) Should this be implemented in JS, server-side, or both? (JS default with a server-side fallback) [04:27:17] (03PS1) 10Brian Wolff: Fix missing semi-colon:   ->   [core] - 10https://gerrit.wikimedia.org/r/258924 [04:27:17] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1876979 (10josephine_l) [04:42:29] (03CR) 10Ed Hoo: "Sure." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 (owner: 10Ed Hoo) [04:51:27] 10Wikimedia-Interwiki-links, 5Patch-For-Review: azb, lrc and gom language prefixes not recognized - https://phabricator.wikimedia.org/T120937#1876985 (10Liuxinyu970226) [04:59:16] 10MediaWiki-extensions-Renameuser, 7Technical-Debt: Refactor Special:RenameUser to use FormSpecialPage - https://phabricator.wikimedia.org/T100263#1876987 (10Liuxinyu970226) [05:01:44] 10MediaWiki-General-or-Unknown: Concentrate content related error messages in one place - https://phabricator.wikimedia.org/T118377#1876990 (10Liuxinyu970226) [05:03:03] 10MediaWiki-extensions-LogEntry: No form in MediaWiki 1.26 - https://phabricator.wikimedia.org/T121270#1876991 (10Liuxinyu970226) [05:09:33] (03CR) 10Legoktm: [C: 04-1] "InlineDiffFormatter in the MobileFrontend extension is still echo'ing stuff, could you submit a corresponding patch to update that one?" [core] - 10https://gerrit.wikimedia.org/r/244632 (owner: 10PleaseStand) [05:10:27] (03PS2) 10Legoktm: Fix missing semi-colon:   ->   [core] - 10https://gerrit.wikimedia.org/r/258924 (owner: 10Brian Wolff) [05:10:32] (03CR) 10Legoktm: [C: 032] Fix missing semi-colon:   ->   [core] - 10https://gerrit.wikimedia.org/r/258924 (owner: 10Brian Wolff) [05:14:11] 10MediaWiki-Revision-deletion, 7Easy: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1876993 (10Legoktm) JS seems fine for now given it's just an enhancement. Server-side would be nice, but that might be non-trivial? [05:14:28] 10Wikimedia-Developer-Summit-2016: Vision discussion: The Future of Wikipedia - https://phabricator.wikimedia.org/T121044#1876994 (10RobLa-WMF) 5declined>3stalled [05:15:52] (03CR) 10Ed Hoo: "Hmmm okay," [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 (owner: 10Ed Hoo) [05:17:22] (03CR) 10Prtksxna: [C: 04-1] "As a matter of practice, we usually make changes only to the source files in one patch and push the changes after running `middleman build" (033 comments) [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/258689 (owner: 10JustinLeung) [05:17:37] (03Merged) 10jenkins-bot: Fix missing semi-colon:   ->   [core] - 10https://gerrit.wikimedia.org/r/258924 (owner: 10Brian Wolff) [05:24:50] (03PS1) 10Niharika29: Append default gadgets to Special:GadgetUsage table with 'Default' in place of stats [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) [05:28:01] (03CR) 10Florianschmidtwelzow: "Thanks for fixing this! I haven't seen this and could swear, that it worke d in my test with Google chrome :/" [core] - 10https://gerrit.wikimedia.org/r/258924 (owner: 10Brian Wolff) [05:29:23] (03PS1) 10Pastakhov: Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/258926 [05:32:28] (03PS2) 10Gerrit Patch Uploader: OutputPage: Use getPageViewLanguage for Content-language [core] - 10https://gerrit.wikimedia.org/r/255178 [05:32:30] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [05:35:11] 10Wikimedia-Developer-Summit-2016: Vision discussion: The Future of Wikipedia - https://phabricator.wikimedia.org/T121044#1876999 (10RobLa-WMF) @yurik: there really isn't a lot of time to pull something together, especially given the topic. In order for this to be a successful proposal, it will need the very si... [05:35:46] (03CR) 10Ori.livneh: Work around APCu memory corruption bug (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258734 (https://phabricator.wikimedia.org/T120267) (owner: 10Ori.livneh) [05:36:05] (03PS2) 10Ori.livneh: Work around APCu memory corruption bug [core] - 10https://gerrit.wikimedia.org/r/258734 (https://phabricator.wikimedia.org/T120267) [05:47:26] 10MediaWiki-Interface, 10OOjs-UI, 7Performance: Make using OOjs UI in MediaWiki more lightweight - https://phabricator.wikimedia.org/T113677#1877004 (10RobLa-WMF) Per discussion on wikitech-l, @jdlrobson suggested last week (see [[https://lists.wikimedia.org/pipermail/wikitech-l/2015-December/084306.html | W... [05:50:45] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: References are not getting updated cleanly - https://phabricator.wikimedia.org/T121093#1877008 (10Arrbee) >>! In T121093#1876695, @Amire80 wrote: > The screenshot looks incorrect for several reasons - the paragraph appears twice, there is no sec... [05:52:25] (03CR) 10Pastakhov: [C: 032] Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/258926 (owner: 10Pastakhov) [05:52:59] (03Merged) 10jenkins-bot: Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/258926 (owner: 10Pastakhov) [05:54:43] (03PS1) 10Pastakhov: Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] (REL1_26) - 10https://gerrit.wikimedia.org/r/258927 [05:55:00] (03CR) 10Pastakhov: [C: 032] Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] (REL1_26) - 10https://gerrit.wikimedia.org/r/258927 (owner: 10Pastakhov) [05:55:31] (03Merged) 10jenkins-bot: Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] (REL1_26) - 10https://gerrit.wikimedia.org/r/258927 (owner: 10Pastakhov) [06:06:56] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1877011 (10josephine_l) [06:08:21] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1877012 (10josephine_l) [06:09:37] (03CR) 10Gergő Tisza: [C: 031] "Looks good. I wonder though if this should use a core message, given that the core editor has a signature button as well." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [06:10:13] (03PS3) 10Legoktm: Add extension.json, empty PHP entry point [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) (owner: 10Ananay) [06:10:41] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1877014 (10josephine_l) [06:11:15] (03CR) 10Legoktm: [C: 032] "Nice work" [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) (owner: 10Ananay) [06:11:21] (03PS1) 10Legoktm: Remove now unused i18n shim [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258928 [06:12:28] (03Merged) 10jenkins-bot: Add extension.json, empty PHP entry point [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) (owner: 10Ananay) [06:12:57] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1877018 (10Legoktm) [06:12:58] 10MediaWiki-extensions-PoolCounter, 3Google-Code-In-2015, 5Patch-For-Review: Convert PoolCounter to use extension registration - https://phabricator.wikimedia.org/T87960#1877016 (10Legoktm) 5Open>3Resolved a:3Legoktm [06:13:44] 10MediaWiki-extensions-PoolCounter, 3Google-Code-In-2015, 5Patch-For-Review: Convert PoolCounter to use extension registration - https://phabricator.wikimedia.org/T87960#1001740 (10Legoktm) a:5Legoktm>3ananayarora [06:14:58] (03CR) 10Legoktm: [C: 032] Work around APCu memory corruption bug [core] - 10https://gerrit.wikimedia.org/r/258734 (https://phabricator.wikimedia.org/T120267) (owner: 10Ori.livneh) [06:15:22] 10MediaWiki-Configuration, 5MW-1.26-release, 5Patch-For-Review: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1877020 (10Legoktm) [06:16:26] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1877021 (10josephine_l) [06:19:04] (03CR) 10Florianschmidtwelzow: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [06:20:22] (03PS2) 10Gergő Tisza: Move PSR-3 support check right after autoloader setup [core] - 10https://gerrit.wikimedia.org/r/248809 [06:21:06] (03Merged) 10jenkins-bot: Work around APCu memory corruption bug [core] - 10https://gerrit.wikimedia.org/r/258734 (https://phabricator.wikimedia.org/T120267) (owner: 10Ori.livneh) [06:26:18] (03CR) 10Billm: "Ok @Legoktm thanks very much for reviewing and merging my patch. Sorry for not having mentioned the bug in the commit message.Will be much" [core] - 10https://gerrit.wikimedia.org/r/257311 (owner: 10Billm) [06:26:49] (03Abandoned) 10Florianschmidtwelzow: Usability improvement for Special:MovePage [core] - 10https://gerrit.wikimedia.org/r/256030 (owner: 10Florianschmidtwelzow) [06:32:33] 10MediaWiki-File-management, 6Commons, 6Multimedia, 7Easy: Download this file link on description page (particularly relevant to svg) - https://phabricator.wikimedia.org/T27148#1877024 (10Tgr) By "download URL" I meant an URL that downloads the image on left-click, instead of opening it. I thought that was... [06:42:13] 10MediaWiki-Unit-tests, 5Patch-For-Review: Tests introduced in tests/phpunit/includes/db/TestORMRowTest.php fail on PostgreSQL - https://phabricator.wikimedia.org/T39601#1877026 (10saper) This is good news! Thank you @legoktm! [06:42:31] (03CR) 10saper: "\o/" [core] - 10https://gerrit.wikimedia.org/r/172662 (https://phabricator.wikimedia.org/T39601) (owner: 10saper) [06:43:47] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1877027 (10Tgr) >>! In T114419#1876179, @ori wrote: > I think we can retain most of the benefits provided by code review by making it optional rather than obligatory. This seems to re... [06:44:53] (03PS1) 10Legoktm: Work around APCu memory corruption bug [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258930 (https://phabricator.wikimedia.org/T120267) [06:46:55] 10MediaWiki-Vagrant, 7Pywikibot-General: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty - https://phabricator.wikimedia.org/T121326#1877029 (10Tgr) The default Python on Trusty is currently 2.7.6 - people would have to remember to type `python3` and hashbangs would not work eit... [06:48:05] (03Abandoned) 10saper: Database independent test for bug 37601 [core] - 10https://gerrit.wikimedia.org/r/100180 (https://bugzilla.wikimedia.org/37601) (owner: 10saper) [06:49:48] (03CR) 10saper: "There is no one left to teach, since the ORM code has been removed from the core." [core] - 10https://gerrit.wikimedia.org/r/100183 (https://bugzilla.wikimedia.org/43475) (owner: 10saper) [06:50:02] (03Abandoned) 10saper: Teach ORMTable to use sequences [core] - 10https://gerrit.wikimedia.org/r/100183 (https://bugzilla.wikimedia.org/43475) (owner: 10saper) [06:53:33] (03CR) 10Legoktm: [C: 032] Move PSR-3 support check right after autoloader setup [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [06:54:44] (03CR) 10Legoktm: [C: 04-1] "Can we put them on top of the table? As default gadgets they should be the most used so should be on top..." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) (owner: 10Niharika29) [06:56:12] (03CR) 10Legoktm: [C: 032] Work around APCu memory corruption bug [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258930 (https://phabricator.wikimedia.org/T120267) (owner: 10Legoktm) [06:57:02] (03CR) 10Niharika29: "There are no stats for these. Having them on top with no stats would be awkward I feel." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) (owner: 10Niharika29) [06:59:15] (03CR) 10Legoktm: [C: 031] "I was thinking that the list is currently ordered by number of users, so the most used gadgets (default ones!) should go on top. But it's " [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) (owner: 10Niharika29) [06:59:27] (03Merged) 10jenkins-bot: Move PSR-3 support check right after autoloader setup [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [07:00:24] (03CR) 10Gergő Tisza: [C: 032] Use vips shrink for multi-page files [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/250308 (https://phabricator.wikimedia.org/T117349) (owner: 10Brian Wolff) [07:02:05] (03Merged) 10jenkins-bot: Work around APCu memory corruption bug [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258930 (https://phabricator.wikimedia.org/T120267) (owner: 10Legoktm) [07:02:07] (03Merged) 10jenkins-bot: Use vips shrink for multi-page files [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/250308 (https://phabricator.wikimedia.org/T117349) (owner: 10Brian Wolff) [07:03:33] 10MediaWiki-extensions-Gadgets, 10Analytics: Track the GadgetUsage statistics over time - https://phabricator.wikimedia.org/T121049#1877034 (10Legoktm) graphite/grafana is probably the best counts over time visualizer we have right now. We'd want to hack into the update process somehow to send the counts every... [07:04:10] 10MediaWiki-Configuration, 5MW-1.26-release, 5Patch-For-Review: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1877035 (10Legoktm) a:3ori [07:05:17] 10MediaWiki-Configuration, 5MW-1.26-release, 5Patch-For-Review: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1877036 (10Legoktm) 5Open>3Resolved Fixed in master and backported to REL1_26. Will be included as part of the 1.26.1 release. Thanks... [07:05:43] 10MediaWiki-Cache, 10MediaWiki-Configuration, 5MW-1.26-release, 5Patch-For-Review: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 with default APCu settings - https://phabricator.wikimedia.org/T120267#1877038 (10Legoktm) [07:06:02] legoktm: Thanks for the review and the backport! [07:06:32] :) [07:06:54] (03PS2) 10Awight: Add an config variable to override the wiki ID [extensions/ORES] - 10https://gerrit.wikimedia.org/r/258916 (https://phabricator.wikimedia.org/T112856) [07:07:51] (03CR) 10jenkins-bot: [V: 04-1] Add an config variable to override the wiki ID [extensions/ORES] - 10https://gerrit.wikimedia.org/r/258916 (https://phabricator.wikimedia.org/T112856) (owner: 10Awight) [07:08:38] (03PS1) 10Pastakhov: Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] (REL1_25) - 10https://gerrit.wikimedia.org/r/258931 [07:08:50] (03CR) 10Pastakhov: [C: 032] Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] (REL1_25) - 10https://gerrit.wikimedia.org/r/258931 (owner: 10Pastakhov) [07:09:26] (03Merged) 10jenkins-bot: Update the CodeMirror library to 5.9 (v 3.4.0) [extensions/CodeMirror] (REL1_25) - 10https://gerrit.wikimedia.org/r/258931 (owner: 10Pastakhov) [07:09:54] (03CR) 10Quiddity: "Logically, yeah, the gadgets with the most users (default) should probably be next to the gadgets with the most users (opt-in)." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) (owner: 10Niharika29) [07:10:08] https://getcomposer.org/doc/articles/troubleshooting.md#xdebug-impact-on-composer ugh [07:10:48] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Analytics, 5ContentTranslation-Release7, 3LE-CX7-Sprint 4, 7WorkType-Maintenance: Calculate the number of translators grouped by translation number in October-December 2015 - https://phabricator.wikimedia.org/T120065#1877045 (10Arrbee) a:5A... [07:10:48] I have to report a bug [07:10:55] http://unicorn.wmflabs.org/flow/ is unrealistic. people are too civil [07:11:01] (03CR) 10Awight: Switch from the "reverted" to "damaging" model (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/257851 (https://phabricator.wikimedia.org/T112856) (owner: 10Awight) [07:11:24] (03PS1) 10Legoktm: Remove kzykhys/pygments dependency [vendor] - 10https://gerrit.wikimedia.org/r/258932 (https://phabricator.wikimedia.org/T120068) [07:13:14] (03PS2) 10Niharika29: Append default gadgets to Special:GadgetUsage table with 'Default' in place of stats [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) [07:13:20] legoktm: For ^this patch, could you test it on your local wiki? I think something else is broken. [07:14:03] legoktm: Changing a new gadget to default doesn't show it as default in the table. [07:14:33] i.e. GadgetRepo doesn't think its onByDefault. [07:14:59] Which is weird because it was fine for all the previous patches. Caching issue or something maybe? [07:15:45] Niharika: sure. I'll do that in the morning then [07:15:57] No worries. [07:16:00] Hey! [07:16:07] Hi shiftsayan! [07:16:16] I am new to IRC, just getting started! [07:16:38] shiftsayan: Are you participating in GCI? [07:16:46] yes [07:17:04] but this is nice, i should have joined earlier! [07:17:05] Awesome. [07:17:18] hey [07:21:15] 6Revscoring, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1877050 (10awight) Status: We need to take the following steps before full functionality is available on the test box. * @halfak will plug the fake data model into the "damaging" slot for testwiki API respon... [07:24:17] (03CR) 10Nemo bis: "Thank you also for fixing the email address in your config already. :)" [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [07:24:34] (03PS2) 10Nemo bis: Reformatted documentation for $wgFooterIcons [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [07:24:38] 10Diffusion: Links from gerrit not working - https://phabricator.wikimedia.org/T121374#1877053 (10Quiddity) 3NEW [07:24:50] are these moderated? [07:26:23] (03CR) 10Nemo bis: "Hmm, I doubt that the todo meant to apply markdown. You could use the command "git blame" to find out who added that todo line and add the" [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [07:27:07] how do I prevent myself from disconnecting? [07:27:24] shiftsayan: What's moderated? [07:27:44] shiftsayan: Keep your connection on then. [07:27:50] as in, are Wikimedia folks also a part of this chat? [07:28:18] shiftsayan: Yep. [07:28:25] cool [07:28:38] I would advise you to stay far far away from IRC [07:28:42] I am trapped and I cannot escape [07:28:49] [07:29:28] (03CR) 10jenkins-bot: [V: 04-1] Reformatted documentation for $wgFooterIcons [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [07:29:41] hydronium, nice nick [07:30:32] Wow, so many GCI students here. [07:30:34] stay positive [07:31:03] badum tssssss [07:31:16] 10MediaWiki-General-or-Unknown, 10Wikimedia-General-or-Unknown, 7Newphp, 7Technical-Debt: PHP 7 compatibility: Embedded variable syntax - https://phabricator.wikimedia.org/T120694#1877060 (10Alexia) I ran php7mar against this and did not find any current instances PHP 7 breaking variable interpolation. I... [07:33:17] Nemo_bis: the test mediawiki-core-phpcs failed in gerrit. what does this mean? [07:33:52] put on a helmet and read the console log [07:34:09] who all here are via GCI? [07:34:49] victorbarbu_: Click on it. It'll tell you the error. [07:35:07] Niharika: it says FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE and then FAILURE [07:35:11] 10MediaWiki-Redirects, 7Browser-Support-Google-Chrome: Google Chrome sometimes does not scroll to the anchor on redirects with fragment - https://phabricator.wikimedia.org/T120244#1877061 (10Fomafix) [07:35:23] keep reading [07:35:25] victorbarbu_: Read the style violation above it. [07:35:50] Or below? Nevemind :P [07:36:10] Zhaofeng_Li: Line exceeds 100 characters; contains 110. [07:36:16] Do I have to recommit [07:36:33] ? [07:36:36] victorbarbu_: Yes. Break it into two lines. [07:36:59] victorbarbu_: Don't forget to do 'git commit --amend' for the follow up commit. [07:37:06] NOT git commit. [07:37:07] break it with a large blunt tool [07:37:11] preferably an enter key [07:37:24] Just keep the review ID intact in the commit message. [07:37:30] so that's all, right? [07:37:45] Hydronium: What's your sarcasm setting? [07:38:04] it's not sarcasm, I was a little scared, because I wasn't sure what that builder is [07:38:11] and I thought I did something bad [07:38:17] low-mild [07:38:22] victorbarbu_: That was aimed at Hydronium. [07:38:27] oh, sorry [07:38:43] not really sarcasm, just trying to make some jokes [07:38:50] Hydronium: Pull it down to just Low. :P [07:38:55] my bad [07:39:05] I don't want the GCI students to be scared off. :) [07:39:14] * Zhaofeng_Li does $this->sarcasmProvider->disable(); // :P [07:39:32] Hydronium: Don't get me wrong, I'm glad to have some jokes around here! [07:40:10] i am beginning to love IRCs now :P [07:44:16] 10MediaWiki-Vagrant, 7Pywikibot-General: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty - https://phabricator.wikimedia.org/T121326#1877063 (10jayvdb) Any Python lower than 2.7.9 iirc is insecure, and will require overriding system provided packages, or a virtualenv. [07:48:01] (03PS3) 10Awight: Add an config variable to override the wiki ID [extensions/ORES] - 10https://gerrit.wikimedia.org/r/258916 (https://phabricator.wikimedia.org/T112856) [07:53:19] 10MediaWiki-extensions-Collection: Download as PDF via rdf2latex causes several rendering problems - https://phabricator.wikimedia.org/T121349#1877064 (10Juetho) Hi @Aklapper, thank you for the hint to wikitables. I see my report as //one// great problem concerning PDF rendering. I'll wait for fixing it. At the... [07:54:16] (03CR) 10Niharika29: "Changed it to have the default ones on top now. During local testing, if I change a non-default gadget to be default, it doesn't show them" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/258925 (https://phabricator.wikimedia.org/T121133) (owner: 10Niharika29) [07:55:03] can someone help me with how to fix stuff on the wikimedia todo? [07:55:04] https://doc.wikimedia.org/mediawiki-core/master/php/todo.html [07:57:31] shiftsayan: A todo is basically a reminder for future to fix something small. Pick a todo that looks easy and fix it, simple. [07:57:51] where does the fixing happen? [07:57:54] sorry i am new to this [07:58:00] shiftsayan: Though, have you setup your development environment? [07:58:24] umm, no [07:58:54] shiftsayan: That's okay. You have to install the development environment in your computer and make the necessary changes in the right files. Then you commit your changes to our code review software where your mentor approves them. [07:59:02] !hacker | shiftsayan [07:59:02] shiftsayan: http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [07:59:26] ohhk this makes sense [07:59:29] This page would give you most of the details. Choose vagrant installation to setup your development environment. [07:59:29] thanksq! [08:03:50] (03PS10) 10Gergő Tisza: [WIP] Use AuthManager [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/251930 (https://phabricator.wikimedia.org/T110460) [08:04:07] (03CR) 10Nemo bis: "07:29:16 3312 | WARNING | Line exceeds 100 characters; contains 110" [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [08:04:27] (03PS7) 10Gergő Tisza: [WIP] Update request handling for linking providers [core] - 10https://gerrit.wikimedia.org/r/255983 [08:04:28] victorbarbu_: line too long [08:04:29] (03PS16) 10Gergő Tisza: [WIP] Use AuthManager on Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [08:04:43] (03PS1) 10VolkerE: Set title link to wiki homepage URL [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/258934 (https://phabricator.wikimedia.org/T117843) [08:07:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use AuthManager [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/251930 (https://phabricator.wikimedia.org/T110460) (owner: 10Gergő Tisza) [08:07:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update request handling for linking providers [core] - 10https://gerrit.wikimedia.org/r/255983 (owner: 10Gergő Tisza) [08:07:59] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use AuthManager on Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [08:08:28] (03CR) 10Nemo bis: [C: 04-1] "This changes the display a lot, doesn't it? Did you test with enhanced recentchanges enabled? Will need screenshots." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [08:11:24] (03CR) 10Nemo bis: [C: 04-1] ""Redocument" doesn't mean to make stylistic changes, it means that the entire documentation needs to be rewritten. In this case, it means " [core] - 10https://gerrit.wikimedia.org/r/258739 (owner: 10Victorbarbu) [08:11:37] (03CR) 10Victorbarbu: "Line 3312 in my file has exactly 99 characters. What happened?" [core] - 10https://gerrit.wikimedia.org/r/258742 (owner: 10Victorbarbu) [08:14:05] (03CR) 10Brian Wolff: "Florianschmidtwelzow: Most browsers don't mind a missing semi-colon, so it would be a hard bug to spot. The only reason I saw it was becau" [core] - 10https://gerrit.wikimedia.org/r/258924 (owner: 10Brian Wolff) [08:15:20] (03CR) 10Gergő Tisza: "Oops, PS7 should not have happened. I'll do a proper rebase." [core] - 10https://gerrit.wikimedia.org/r/255983 (owner: 10Gergő Tisza) [08:17:10] (03CR) 10Victorbarbu: "Oops. Looks like I got this wrong. Do I have time to repair this?" [core] - 10https://gerrit.wikimedia.org/r/258739 (owner: 10Victorbarbu) [08:17:41] (03CR) 10EBernhardson: [WIP] Collect per-node fetch/query latency percentiles (031 comment) [search/extra] - 10https://gerrit.wikimedia.org/r/258720 (owner: 10EBernhardson) [08:18:10] guys, how do I manage to keep the change ID to re-commit on Gerrit? [08:18:39] 3Discovery-Cirrus-Sprint: build completion suggester indices on beta cluster - https://phabricator.wikimedia.org/T121375#1877082 (10EBernhardson) 3NEW [08:19:04] 3Discovery-Cirrus-Sprint: test and validate completion suggester beta feature on beta cluster - https://phabricator.wikimedia.org/T121376#1877089 (10EBernhardson) 3NEW [08:19:20] 3Discovery-Cirrus-Sprint: build completion suggester indices on beta cluster - https://phabricator.wikimedia.org/T121375#1877097 (10EBernhardson) [08:20:39] victorbarbu_: After executing git commit --amend, don't touch anything in the edit interface and save. [08:20:59] okay, thank you [08:21:57] 10CirrusSearch, 6Discovery: split out query latency percentiles (MediaWiki.CirrusSearch.requestTime.*) by query time - https://phabricator.wikimedia.org/T121377#1877098 (10EBernhardson) 3NEW [08:23:16] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: build completion suggester indices on beta cluster - https://phabricator.wikimedia.org/T121375#1877106 (10EBernhardson) [08:23:23] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: test and validate completion suggester beta feature on beta cluster - https://phabricator.wikimedia.org/T121376#1877109 (10EBernhardson) [08:23:45] 6Discovery, 3Discovery-Cirrus-Sprint: Turn on completion suggester beta feature on all Wikimedia wikis - https://phabricator.wikimedia.org/T119989#1877112 (10EBernhardson) [08:23:47] 10CirrusSearch, 6Discovery, 3Discovery-Cirrus-Sprint: test and validate completion suggester beta feature on beta cluster - https://phabricator.wikimedia.org/T121376#1877113 (10EBernhardson) [08:28:02] (03CR) 10Nemo bis: "Yes, nobody is chasing us!" [core] - 10https://gerrit.wikimedia.org/r/258739 (owner: 10Victorbarbu) [08:28:36] (03CR) 10Paladox: "Needs re merge. I think the submit button instead of the public button needs to be used since we are forcing the merge." [extensions/Offline] - 10https://gerrit.wikimedia.org/r/257346 (owner: 10Addshore) [08:28:51] (03PS8) 10Gergő Tisza: [WIP] Update request handling for linking providers [core] - 10https://gerrit.wikimedia.org/r/255983 [08:28:53] (03PS17) 10Gergő Tisza: [WIP] Use AuthManager on Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [08:29:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update request handling for linking providers [core] - 10https://gerrit.wikimedia.org/r/255983 (owner: 10Gergő Tisza) [08:29:53] 10MediaWiki-Configuration: Impossible to override an array-valued global create by extension registration? - https://phabricator.wikimedia.org/T121378#1877117 (10awight) 3NEW [08:30:15] 10MediaWiki-Configuration: Impossible to override an array-valued global created by extension registration? - https://phabricator.wikimedia.org/T121378#1877124 (10awight) [08:30:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use AuthManager on Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [08:35:27] 10MediaWiki-extensions-Newsletter, 3Google-Code-In-2015: Handle errors on (un)subscription in Special:Newsletters - https://phabricator.wikimedia.org/T115874#1735057 (10Glaisher) https://codein.withgoogle.com/dashboard/tasks/5526685684334592/ [08:36:42] 6Revscoring, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1877129 (10awight) @ladsgroup I'm on the same page now--I updated to the patches above, made an additional livehack to only fetch the "reverted" model, and still nothing happens. I'm trying to track down th... [08:39:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Allows to input of plain text such as "today" in time edit widget - https://phabricator.wikimedia.org/T76859#821192 (10Lydia_Pintscher) This was requested again today. [08:39:44] 10MediaWiki-extensions-Newsletter: Special:Newsletter fatals if the newsletter main page is deleted - https://phabricator.wikimedia.org/T119058#1877132 (10Glaisher) p:5Triage>3High [08:41:17] (03CR) 10Pastakhov: [C: 031] "It works for me REL1_26" [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/258934 (https://phabricator.wikimedia.org/T117843) (owner: 10VolkerE) [08:41:49] 10CirrusSearch, 6Discovery: URL-style internal wikilinks are not well-enough tracked or searchable - https://phabricator.wikimedia.org/T121379#1877133 (10Cpiral) 3NEW [08:42:30] (03PS1) 10Awight: Update field name in API response [extensions/ORES] - 10https://gerrit.wikimedia.org/r/258937 [08:49:27] 6Revscoring, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1877141 (10awight) Maybe I can blame the Grid job queue, somehow? At least, error_log() called from inside FetchScoreJob does not go to ~/error.log. [08:50:39] 6Revscoring, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1877142 (10awight) Maybe @yuvipanda knows the answer to [[ https://wikitech.wikimedia.org/wiki/Help_talk:Tool_Labs#Cannot_find_MediaWiki_job_error_logs | this question ]]? [08:51:45] 10MediaWiki-extension-requests: Bulk document converter - https://phabricator.wikimedia.org/T120960#1877144 (10Osnard) @Seppl2013 Using Apache POI sounds great. I assume you already have experience with it? When I migrate MS Word files I almost always convert to HTML first. And then convert the HTML to WikiText... [08:52:36] (03PS4) 10Glaisher: Add confirmation dialog to newsletter deletion form [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/258764 [08:54:36] (03PS2) 10VolkerE: Add icon for 'View Source' menu item [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/252973 (https://phabricator.wikimedia.org/T104213) [08:54:42] (03PS5) 10Glaisher: Add confirmation dialog to newsletter deletion form [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/258764 [08:56:07] (03CR) 10VolkerE: "@Prtksxna Is fixed now, please check and make progress!" [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/252973 (https://phabricator.wikimedia.org/T104213) (owner: 10VolkerE) [09:01:23] (03CR) 10Victorbarbu: "How do I commit changing the commit message but keeping the changes in this page? Is is enough to add the change ID at the end of the comm" [core] - 10https://gerrit.wikimedia.org/r/258739 (owner: 10Victorbarbu) [09:02:21] 10MediaWiki-extensions-ContentTranslation: Article selector scrolls out of viewport in Special:CX - https://phabricator.wikimedia.org/T121380#1877146 (10Nikerabbit) 3NEW [09:04:10] (03CR) 10MaxSem: [C: 04-1] "This replaces a generic solution with a MySQL-only query in a base class." [core] - 10https://gerrit.wikimedia.org/r/255294 (https://phabricator.wikimedia.org/T54294) (owner: 10Alexia) [09:05:49] 10Possible-Tech-Projects, 6Research-and-Data, 10The-Wikipedia-Library: Map different types of measurement for T115119 's schema - https://phabricator.wikimedia.org/T118042#1877153 (10Beetstra) It would be great if this could be a real-time IRC feed as well - as then http://en.wikipedia.org/wiki/User:XLinkBot... [09:06:07] 10MediaWiki-extension-requests: Bulk document converter - https://phabricator.wikimedia.org/T120960#1877154 (10Osnard) Regarding the gerneal topic of this task: - I think that batch processing the content of a ZIP-File should not be too much of a problem once the converter-interface is available - Integratin... [09:07:47] 10MediaWiki-skins-Blueprint: Helper functions don't work because core doesn't support this feature. - https://phabricator.wikimedia.org/T120163#1877155 (10Volker_E) @Pastakhov In my understanding, it should be pretty clear, how important in the sense of how many use cases the change can provide and how much main... [09:11:52] 6Revscoring, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1877157 (10Ladsgroup) Maybe using [[https://www.mediawiki.org/wiki/Manual:How_to_debug | this]] helps us but I don't know which logger should be used. [09:23:19] (03PS2) 10Victorbarbu: Redocumented $wgAutopromote [core] - 10https://gerrit.wikimedia.org/r/258739 [09:23:52] (03CR) 10Mxn: "I don’t have merge rights…" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/231872 (owner: 10Mxn) [09:24:54] (03PS3) 10TTO: Redocumented $wgAutopromote [core] - 10https://gerrit.wikimedia.org/r/258739 (owner: 10Victorbarbu) [09:25:34] victorbarbu_: I amended your commit message; I hope you don't mind. The Change-Id line needs to be the very last line in the commit message; there is no need to put a link to the Doxygen docs, as these will be rebuilt and the TODO will disappear [09:26:13] 10MediaWiki-skins-Blueprint: Helper functions don't work because core doesn't support this feature. - https://phabricator.wikimedia.org/T120163#1877161 (10Pastakhov) @Volker_E: It needs few code, but I don't know why MW Core isn't support it still. Maybe MW devs decided don't allow it or just don't make this unt... [09:26:21] Oh, okay, I got it. It's ok, of course :) [09:26:43] (03CR) 10TTO: [C: 032] "I don't understand Vietnamese, but mxn is a trusted user." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/231872 (owner: 10Mxn) [09:30:47] (03CR) 10Parent5446: "Oh wow, I completely forgot this was a MySQL-only command. Yeah this should be moved to the DatabaseMysqlBase." [core] - 10https://gerrit.wikimedia.org/r/255294 (https://phabricator.wikimedia.org/T54294) (owner: 10Alexia) [09:33:09] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Better monitor the status of MT services - https://phabricator.wikimedia.org/T105452#1877164 (10Amire80) p:5Normal>3High Raising the priority, because we are having more and more services, and such things keep happening. We should discuss ad... [09:33:19] (03Merged) 10jenkins-bot: Vietnamese namespace [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/231872 (owner: 10Mxn) [09:39:33] (03CR) 10Victorbarbu: "The todo only asks for the Special:Contributions page. That's the only one modified. ERC are not part of Special:Contributions (as far as " [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [09:39:59] do ERCs appear in Special:Contributions? [09:41:16] (03CR) 10Petrb: [C: 031] Show the number of MassAction jobs queued on Special:Statistics [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/258769 (https://phabricator.wikimedia.org/T96562) (owner: 10Unicornisaurous) [09:51:04] (03CR) 10Jonas Kress (WMDE): "Had a talk with Lydia. She sad it is import to have possibility to show all." (032 comments) [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [09:51:13] 10MediaWiki-General-or-Unknown, 6operations, 7Graphite, 5MW-1.27-release-notes, and 2 others: mediawiki should send statsd metrics in batches - https://phabricator.wikimedia.org/T116031#1877170 (10fgiunchedi) the train has hit all wikis now, still seeing some jobqueue related traffic not in batches but loo... [09:52:08] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Better monitor the status of MT services - https://phabricator.wikimedia.org/T105452#1877171 (10Amire80) [09:55:48] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Publish button does not become active when editing the translation - https://phabricator.wikimedia.org/T120837#1877189 (10Amire80) Mmmm... so sometimes it becomes and sometimes it doesn't? [09:56:10] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Publish button does not become active when editing the translation - https://phabricator.wikimedia.org/T120837#1877191 (10Amire80) [10:00:57] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Publish button does not become active when editing the translation - https://phabricator.wikimedia.org/T120837#1877208 (10Nikerabbit) Yes. That would indicate some kind of race condition that Trondtr is able to trigger quite reliably. [10:02:50] (03PS1) 10Thiemo Mättig (WMDE): Fix visibility of setUp methods in tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258953 [10:03:21] (03PS1) 10Thiemo Mättig (WMDE): Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 [10:05:05] (03PS1) 10Thiemo Mättig (WMDE): setUp methods in tests must be protected, not public [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258955 [10:09:17] (03PS3) 10Gilles: Video engine [thumbor/video-engine] - 10https://gerrit.wikimedia.org/r/257258 (https://phabricator.wikimedia.org/T120205) [10:09:41] (03CR) 10Gilles: Video engine (031 comment) [thumbor/video-engine] - 10https://gerrit.wikimedia.org/r/257258 (https://phabricator.wikimedia.org/T120205) (owner: 10Gilles) [10:11:39] 10MediaWiki-extensions-RelatedArticles, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: iOS 9: related articles stop showing on subsequent pages if you click on one of them - https://phabricator.wikimedia.org/T121263#1877209 (10bmansurov) a:3bmansurov [10:11:48] (03PS4) 10Gilles: Ghostscript engine [thumbor/ghostscript-engine] - 10https://gerrit.wikimedia.org/r/257180 (https://phabricator.wikimedia.org/T120207) [10:12:54] (03PS1) 10Thiemo Mättig (WMDE): Fix misspelled setUp() in RevisionStorageTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258957 [10:13:39] 10Diffusion: Links from Gerrit to Diffusion not working for "Gadgets" repository - https://phabricator.wikimedia.org/T121374#1877211 (10Aklapper) [10:16:01] (03CR) 10Nemo bis: "True, I'm blind. However Special:Contributions follows the same format as Special:RecentChanges and Special:Watchlist in non-ERC (non-grou" [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [10:16:57] (03PS3) 10Gilles: Add TIFF support [thumbor/vips-engine] - 10https://gerrit.wikimedia.org/r/257198 (https://phabricator.wikimedia.org/T120203) [10:19:10] 10Source-Metadata: Fix librarybase SPARQL endpoint updater - https://phabricator.wikimedia.org/T121381#1877213 (10Tarrow) 3NEW [10:19:13] (03PS5) 10Gilles: TIFF engine [thumbor/tiff-engine] - 10https://gerrit.wikimedia.org/r/257187 (https://phabricator.wikimedia.org/T120203) [10:20:04] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint 4, 5Patch-For-Review, and 2 others: Multiple paragraphs in a section causes data loss on restoration - https://phabricator.wikimedia.org/T121092#1877220 (10Amire80) [10:20:12] (03PS4) 10Gilles: XCF engine [thumbor/xcf-engine] - 10https://gerrit.wikimedia.org/r/257185 (https://phabricator.wikimedia.org/T120201) [10:20:20] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Publish button does not become active when editing the translation - https://phabricator.wikimedia.org/T120837#1877221 (10Trondtr) yes, sometimes (appr in 20% of the cases) I am able to publish ("green button"), and sometimes I am not. Unfortuna... [10:21:29] (03CR) 10Jonas Kress (WMDE): adds dataTables (031 comment) [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [10:21:33] (03PS5) 10Gilles: DjVu engine [thumbor/djvu-engine] - 10https://gerrit.wikimedia.org/r/257183 (https://phabricator.wikimedia.org/T120202) [10:23:00] (03CR) 10Victorbarbu: "I am not really done with it. I am still working to refine my code and improve it, as well as the UX on this page. When it will be done, I" [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [10:23:17] (03PS6) 10Gilles: Minimal VIPS engine [thumbor/vips-engine] - 10https://gerrit.wikimedia.org/r/255431 (https://phabricator.wikimedia.org/T119184) [10:23:51] 10MediaWiki-extensions-UniversalLanguageSelector, 7Upstream: jQueryIME: If contentEditable cursor not in a text node, then insertion goes before the first CE text character - https://phabricator.wikimedia.org/T121216#1877222 (10dchan) I think https://github.com/wikimedia/jquery.ime/pull/422 is ready to merge (... [10:24:21] (03PS4) 10Gilles: Add TIFF support [thumbor/vips-engine] - 10https://gerrit.wikimedia.org/r/257198 (https://phabricator.wikimedia.org/T120203) [10:28:57] 10MediaWiki-extensions-Collection: Download as PDF via rdf2latex causes several rendering problems - https://phabricator.wikimedia.org/T121349#1877223 (10Aklapper) p:5High>3Triage ([[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | Resetting "priority" value to default... [10:30:13] People, instead of literally saying "add a column with the text Contributors", how can I say "add a column with the text Contributors that can be translated to any language"? [10:30:39] in which context? [10:30:55] ah well. #mediawiki-i18n ? [10:31:19] I am working on the Special:Contributions page. But I am not sure if special pages should be available in something else than English [10:31:23] (03CR) 10Cblair91: [C: 032] Replace deprecated editToken with getEditToken [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/258907 (owner: 10Reedy) [10:31:57] 10MediaWiki-Search, 7Easy, 5MW-1.26-release: Interwiki search results should come after local ones in HTML - https://phabricator.wikimedia.org/T87631#1877226 (10NikiWiki) Should I open a bug report? [10:32:10] victorbarbu_: Pretty everything should be translatable [10:33:23] (03PS9) 10Gergő Tisza: [WIP] Update request handling for linking providers [core] - 10https://gerrit.wikimedia.org/r/255983 [10:33:24] Reedy: I don't see any option of translating Special:Contributions on Wikipedia, the Language section seems to be disabled [10:33:40] eh? [10:33:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update request handling for linking providers [core] - 10https://gerrit.wikimedia.org/r/255983 (owner: 10Gergő Tisza) [10:33:58] https://en.wikipedia.org/wiki/Special:Contributions/Reedy?uselang=de [10:34:57] Reedy: Oh, my mistake. Then how should I go about it? [10:35:05] What are you trying to translate? [10:35:52] words. I am trying to implement a table for the contributions page, instead of the traditional list, so table headers, keywords, like *current* etc [10:36:12] $startBody .= Html::rawElement( 'td', array(), 'Article' ); [10:36:22] what would this become to be translateable? [10:36:59] Look for usages of $this->msg() in the file [10:37:04] 10MediaWiki-extensions-ContentTranslation, 10Unplanned-Sprint-Work, 3LE-CX7-Sprint 4, 5Patch-For-Review, and 2 others: Infinite redirect loop when trying to re-translate article after deleting draft - https://phabricator.wikimedia.org/T121116#1877229 (10Arrbee) Verified. This works as expected. [10:38:10] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Article selector scrolls out of viewport in Special:CX - https://phabricator.wikimedia.org/T121380#1877235 (10Amire80) [10:38:15] $this->msg( 'contributions-title', $target )->plain() [10:38:16] For example [10:38:21] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Article selector scrolls out of viewport in Special:CX - https://phabricator.wikimedia.org/T121380#1877237 (10Amire80) p:5Triage>3Normal [10:38:27] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: References are not getting updated cleanly - https://phabricator.wikimedia.org/T121093#1877238 (10Amire80) p:5Triage>3Normal [10:38:31] You'll be able to find 'contributions-title' in languages/i18n/en.json [10:39:14] Oh, that's nice. I am going to read all about localisation, I've just found an article [10:39:45] (03CR) 10Gilles: "Only for __setattr__, because when you set an attribute for the first time you always hit __setattr__. And we want the proxy values to be " [thumbor/proxy-engine] - 10https://gerrit.wikimedia.org/r/257189 (https://phabricator.wikimedia.org/T120566) (owner: 10Gilles) [10:42:09] 10MediaWiki-extensions-Collection: Download as PDF via rdf2latex causes several rendering problems - https://phabricator.wikimedia.org/T121349#1877245 (10Juetho) @Aklapper: Should I now create separate tasks for the detailed problems? # detail 1 - formula indention # detail 2/3 - position of graphics # det... [10:44:54] Reedy: If I don't find what I need, can I add new strings in the localisation file? [10:45:08] victorbarbu_: In most cases, you should be adding new strings [10:45:23] Oh, ok then. Thank you! [10:45:24] Even if you find the exact message, you shouldn't reuse it somewhere else [10:45:37] In english it might be the same, in other languages it's not [10:45:43] If you add to en.json you need to add to qqq.json too [10:46:33] The exact same entry? [10:50:16] (03CR) 10Daniel Kinzler: Create question page if it does not exist (031 comment) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/229348 (owner: 10Thiemo Mättig (WMDE)) [10:52:07] (03PS1) 10Bmansurov: Fix loading related articles on small screens [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/258964 (https://phabricator.wikimedia.org/T121263) [10:56:09] (03CR) 10Nemo bis: "Ok. You can add "[WIP]" to the first line of the commit message if you want to tell people to wait commenting. :)" [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [10:57:12] (03CR) 10Bmansurov: [C: 04-1] "The version number in extension.json should also be updated." (032 comments) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/258200 (https://phabricator.wikimedia.org/T121052) (owner: 10Jdlrobson) [10:57:13] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint 4, 5Patch-For-Review, 7WorkType-NewFunctionality: Save the revision id of source and published article in cx_translations table - https://phabricator.wikimedia.org/T119495#1877253 (10jcrespo) [10:57:16] 10MediaWiki-extensions-ContentTranslation, 10DBA, 7Blocked-on-schema-change, 5ContentTranslation-Release7, and 3 others: Review schema changes for T119495 - https://phabricator.wikimedia.org/T119752#1877251 (10jcrespo) 5Open>3Resolved The change has been applied successfuly, and no regression has been... [10:57:45] (03PS4) 10Gilles: Simplify getattr/setattr magic [thumbor/proxy-engine] - 10https://gerrit.wikimedia.org/r/257189 (https://phabricator.wikimedia.org/T120566) [10:58:11] (03CR) 10Gilles: "Ended up finding a more elegant solution, without the need for a global list." [thumbor/proxy-engine] - 10https://gerrit.wikimedia.org/r/257189 (https://phabricator.wikimedia.org/T120566) (owner: 10Gilles) [11:06:44] 10MediaWiki-extensions-RelatedArticles, 10VisualEditor, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: RelatedArticles disappears during edit process when using VisualEditor - https://phabricator.wikimedia.org/T120443#1877265 (10bmansurov) 5Open>3Resolved [11:08:24] 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning, 6Reading-Admin, 10Reading-Community-Engagement, and 3 others: [EPIC] Read more related articles after end of current article - https://phabricator.wikimedia.org/T94906#1877270 (10bmansurov) [11:08:26] 10Wikimedia-Extension-setup, 7Tracking: Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T33235#1877271 (10bmansurov) [11:12:44] 10MediaWiki-extensions-RelatedArticles, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review, and 2 others: RelatedArticles shows on editor - https://phabricator.wikimedia.org/T120735#1877273 (10bmansurov) There are some comments on the patch. Also the solution is a temporary one as described on the commit messa... [11:14:00] 10MediaWiki-extensions-OAuth, 6Reading-Infrastructure-Team, 7Schema-change: Create oauth_registered_consumer.oarc_owner_only column on metawiki - https://phabricator.wikimedia.org/T121335#1877274 (10jcrespo) > This should go out before Tuesday as I forgot a schema change is involved and merged the patch. Sor... [11:15:01] 10MediaWiki-extensions-OAuth, 10DBA, 6Reading-Infrastructure-Team, 7Schema-change: Create oauth_registered_consumer.oarc_owner_only column on metawiki - https://phabricator.wikimedia.org/T121335#1877275 (10jcrespo) [11:17:52] 10MediaWiki-extensions-RelatedArticles, 10Reading-Community-Engagement, 5Patch-For-Review, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: Only load related articles when the user has scrolled to halfway mark of article - https://phabricator.wikimedia.org/T116838#1877281 (10bmansurov) The pat... [11:28:00] 6Developer-Relations, 3DevRel-December-2015: Tech Talk: Operational security for everyone - https://phabricator.wikimedia.org/T119956#1877303 (10Aklapper) [11:29:26] 6Developer-Relations, 3DevRel-December-2015: Tech Talk: Operational security for everyone - https://phabricator.wikimedia.org/T119956#1841036 (10Aklapper) [11:31:23] 7Design, 10MediaWiki-Gallery, 6Multimedia: No way to access image in packed gallery with long descriptions - https://phabricator.wikimedia.org/T93393#1877320 (10Perhelion) Another example with (`mode="packed-hover"`) small images https://de.wikipedia.org/wiki/Benutzer:Ollemarkeagle#Brandenburg I guess this... [11:33:55] 10MediaWiki-Export-or-Import, 10Wikimedia-Site-Requests, 5MW-1.27-release-notes, 5Patch-For-Review, 7user-notice: Enable importing across all Wikimedia projects - https://phabricator.wikimedia.org/T17583#1877340 (10TTO) There's been occasional posts from gerritbot on this task for the past few months. I... [11:35:57] 6Developer-Relations, 3DevRel-December-2015: Tech Talk: Secure Coding For MediaWiki Developers - https://phabricator.wikimedia.org/T119955#1877345 (10Aklapper) This talk happened on Dec 9 and the Youtube video is at https://www.youtube.com/watch?v=iKdufZQTTao Are the followup steps to email out the youtube vi... [11:38:44] 10Wikimedia-Developer-Summit-2016: How should the WMF support non-technical mediawiki installs? - https://phabricator.wikimedia.org/T113210#1877346 (10Gilles) I'm scheduling two IRC office hours back to back (shouldn't be hard to use the time, we ran over last time) a week from now to continue exploring this top... [11:39:46] 6Developer-Relations, 3DevRel-December-2015: Tech Talk: how to integrate user behavior to get better designs - https://phabricator.wikimedia.org/T119958#1877349 (10Aklapper) > This talk will be on Dec 15th. This Tech Talk has been postponed to some point after the developer summit. There is not yet a final da... [11:40:18] 10Wikimedia-Developer-Summit-2016: How should the WMF support non-technical mediawiki installs? - https://phabricator.wikimedia.org/T113210#1877356 (10Gilles) **Monday 2015-12-21 20:00 UTC until 21:00 UTC #wikimedia-office on Freenode** **IRC office hour: Shared hosting technical alternatives** During the la... [11:41:15] 10Wikimedia-Developer-Summit-2016: How should the WMF support non-technical mediawiki installs? - https://phabricator.wikimedia.org/T113210#1877367 (10Gilles) Monday 2015-12-21 21:00 UTC until 22:00 UTC #wikimedia-office on Freenode **IRC office hour: Shared hosting support definition** Shared hosting usage... [11:42:28] 6Developer-Relations: How to run an team Offsite page on office.wiki - https://phabricator.wikimedia.org/T114970#1877368 (10Aklapper) [11:43:43] 10Wikimedia-Developer-Summit-2016-Organization, 3DevRel-December-2015: Tech Talk: Wikimedia Developer Summit 2016 update and Q&A - https://phabricator.wikimedia.org/T117699#1877370 (10Aklapper) >>! In T117699#1840971 on Dec 1, @Qgil wrote: > This Tech Talk needs to happen in the next 2 weeks, otherwise it will... [11:47:04] 6Developer-Relations, 3DevRel-December-2015: Tech Talk: Graphite and Grafana - https://phabricator.wikimedia.org/T119951#1877376 (10Aklapper) @Krinkle: Can you provide a title (if other than the above) and a summary of the talk? [11:49:26] 6Developer-Relations, 3DevRel-December-2015: Tech Talk: Operational security for everyone - https://phabricator.wikimedia.org/T119956#1877377 (10Aklapper) Link seems to be https://www.youtube.com/watch?v=65K1mm-1FLY but requires signing in. Wondering if that's intentional, seeing "upload it to commons" in the... [11:51:31] andre__: hey, still waiting for the next Screen cast :) [11:52:51] Hi, I am a GCI student [11:52:53] d3r1ck, we all wait I guess [11:52:57] hi pranavk_! [11:53:07] How can I submit patches to a git repo other than through gerrit? [11:53:17] andre__: hi! [11:53:39] through gerrit would be ok, as long as it gets to the other repo too [11:53:53] pranavk_, could you specify what you mean by "other repo"? [11:53:58] The answer depends on the repo... [11:53:59] http://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikibase.git [11:54:05] that's in Gerrit [11:54:08] the wikibase repo [11:54:15] ? [11:54:17] via Gerrit [11:54:39] yes, how can i submit a patch to that repo via Gerrit? [11:54:41] I don't think "other than through gerrit" is possible. And I wonder why you ask that? :) [11:54:46] https://mediawiki.org/wiki/Gerrit/Tutorial [11:55:05] so, I submitted my patch to gerrit already [11:55:13] also see https://www.mediawiki.org/wiki/Google_Code-in_2015#General_recommendations [11:55:20] but one of the mentors requested me to upload it to that repo [11:55:42] the exact words: "can you please submit the change instead to the Wikibase git repo?" :) [11:56:15] pranavk_, I don't think Git/Gerrit allows to "change" the repo a patchset (branch) is against. So basically upload a new one against the right repo, and abandon your current patchset with a link to the new patchset [11:56:29] yeah :-/ [11:56:37] Someone in this IRC room please correct me if I'm wrong. [11:57:26] andre__: one question: i did that, but it's not showing up in that repo [11:57:41] it's appearing on gerrit, but not on the mentioned repo [11:57:47] is that normal? [11:59:32] pranavk_, what is the link that git-review should on your computer? [11:59:37] pranavk_, or well [11:59:42] which steps did you perform exactly? [11:59:49] amending? [12:00:42] i cloned the repo with: git clone ssh://pranavk@gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git [12:00:50] and then i made the changes [12:01:04] amended the commit [12:01:18] and then git review -R [12:02:05] 10Wikimedia-Site-Requests: Add domain to $wgCopyUploadsDomains - https://phabricator.wikimedia.org/T121383#1877435 (10Museo_del_Romanticismo) 3NEW [12:02:05] (03PS2) 10Victorbarbu: Displaying contributions in table [core] - 10https://gerrit.wikimedia.org/r/258897 [12:02:47] pranavk_, I honestly don't know if amending works if you're on a totally different codebase (repository) [12:03:22] (03PS1) 10Sumit: MobileFrontend mw.notification instead of toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) [12:03:31] pranavk_, but I see https://gerrit.wikimedia.org/r/#/c/258967/ [12:03:42] pranavk_, so it seems that it worked?? [12:03:48] superseding https://gerrit.wikimedia.org/r/#/c/258679/ ? [12:03:55] yes, it uploads to gerrit [12:04:06] but i don't see it on http://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikibase.git [12:06:01] which is why i was wondering if i did something wrong [12:06:57] pranavk_, git.wikimedia.org shows what is merged into the codebase. [12:07:11] git.wikimedia.org is for browsing code repositories. [12:07:17] *face palm* [12:07:21] gerrit.wikimedia.org is for proposing code changes and reviewing them. [12:07:25] andre__: ohhhhhh now i get it [12:07:30] pranavk_, no facepalm needed :) It can be confusing! [12:07:48] but one question: why would the mentor tell me to upload the change to that repo? [12:08:11] pranavk_, could you abandon https://gerrit.wikimedia.org/r/#/c/258679/ ? When doing that it will ask for a reason and you could say: wrong repo, superseded by https://gerrit.wikimedia.org/r/#/c/258967/ [12:08:27] andre__: sure [12:08:42] pranavk_, "which repository is for which functionality" is a better question for #wikidata . Because... I don't know. :D [12:08:44] and if i give a +1, would that trigger the jenkins integration test? [12:08:56] andre__: :P [12:08:57] it should happen automatically (I think) [12:09:32] the phpunit test happens automatically, but whenever a mentor +1s it, it tests a bit differently [12:09:49] Oh. Interesting. I have not the slightest idea about that. Well... try? :D [12:09:54] * andre__ not a developer. [12:09:59] whitelists [12:10:19] * pranavk will try [12:10:35] pranavk_: /me [12:10:36] whoops [12:10:46] * pranavk_ will try [12:10:53] thanks :P Reedy [12:12:04] (03CR) 10jenkins-bot: [V: 04-1] MobileFrontend mw.notification instead of toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [12:13:30] pranavk_: when you work on Wikidata stuff I highly recommend to join #wikidata - you can directly chat with the dother evs there which can sometimes save some time for both them and you (compared to commenting on general infrastructure questions in Gerrit which are a bit offtopic there) [12:13:56] andre__: thanks, got it! [12:16:57] pranavk_: (plus they are nice people to talk to :P ) [12:17:06] andre__: :) [12:17:44] andre__: Hello! Do I have to do anything to get my Gerrit change reviewed faster? [12:18:24] victorbarbu_, faster than......? [12:18:27] basically https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews [12:18:42] andre__: faster than the usual review time of commits in our gerrit [12:18:43] victorbarbu_: but I'm not sure which time expectations you have. Feel free to clarify :) [12:18:44] * Reedy grins [12:19:07] Reedy: Wait, faster than two months? Stop stressing me out! ;) [12:19:55] andre__: I don't know. I just to get that reviewed :)) [12:20:15] (03CR) 10Reedy: [C: 04-1] "You should also link the task you're completing..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [12:20:30] Isn't switching things to tables a big accessibility no no? [12:20:49] Reedy: It was a todo [12:21:10] And I completed three of them for a GCI task [12:21:11] victorbarbu_: that patch was 14 hours without review? That's still very okay on a weekend I'd say. :) [12:21:15] pranavk_: hey [12:21:50] victorbarbu_, is there a corresponding bug report in Wikimedia Phabricator for that task? [12:22:02] nope, I would have written it otherwise [12:22:07] Oh I see [12:22:17] or there is not one that I know about [12:22:27] The comment is from 2007 [12:22:36] Hmm [12:22:55] I know a couple of people to maybe ask about this... But wrong time of day for them [12:23:22] Reedy: here is the todo link https://doc.wikimedia.org/mediawiki-core/master/php/todo.html#_todo000143 [12:23:30] Yeah [12:23:42] https://github.com/wikimedia/mediawiki/blame/master/includes/specials/SpecialContributions.php#L959 [12:23:45] It's from a commit from 2007 [12:24:31] OMG how did you find that. [12:24:40] So this might be more controversial nowadays, eight years later [12:24:41] This looks so stalker-ish [12:24:44] Welcome to the world of ancient codebases with rotting comments, also called "software development reality". :-/ [12:25:04] I'm sure I remember someone saying that tables are a no-no for accessiblity [12:25:11] But my work is still valid, isn't it? [12:25:33] Depends on the definition of valid, unfortunately [12:25:36] I mean, I worked to get that completed. It would not be fair to reject my code in task just because that comment is 8 years old [12:25:39] if the student did nothing wrong, your work is still "valid" (in a GCI context) I'd say [12:25:47] Presumably [12:26:03] It's not the comment is 8 years old, more that it's out of date [12:26:09] victorbarbu_, explain/summarize the problem (and the conversation we have here on IRC) in the GCI task so the mentor(s) know about it too [12:26:11] We'll have older comments that are valid [12:26:27] victorbarbu_, don't worry - if it's not your fault it's not your fault. [12:26:41] Your solution looks acceptable for the TODO, on a brief glance, per andre__, you shouldn't be penalised for the comment being very out of date [12:26:43] I will like to ask if there is a project list for GSoC projects that someone can start taking a look at. If there is a list of them, pleaase i will like to have a link :) [12:26:46] thanks [12:26:46] I will probably fail in physics this semester :)) [12:26:58] The worst that should ideally happen, is it won't get merged (in it's current state) [12:27:09] okay, I got it [12:27:11] http://webaim.org/techniques/tables/data [12:27:18] but still, it really seems more organized to me [12:27:25] 10TimedMediaHandler, 10TimedMediaHandler-Player, 10TimedMediaHandler-TimedText: Support subtitles for audio files - https://phabricator.wikimedia.org/T121387#1877484 (10TheDJ) 3NEW [12:27:44] andre__: I guess we should try and reach out to some of the designers at WMF to get an answer ASAP [12:27:47] d3r1ck, general GSoC info is at https://www.mediawiki.org/wiki/Google_Summer_of_Code - there might be also some links somewhere. Not sure if there's some specific list yet, but "Technical Tech Projects" are definitely linked [12:27:52] d3r1ck: https://phabricator.wikimedia.org/tag/possible-tech-projects/ [12:28:16] Reedy, hmm. Royal "we"? :P [12:28:24] wondering who to CC [12:28:32] andre__, codezee, thans [12:28:36] *thanks [12:29:00] andre__: I think pginer might be the best bet [12:29:21] He tends to be fairly responsive [12:29:31] (03CR) 10Aklapper: "As Reedy wrote on IRC, "Your solution looks acceptable for the TODO, on a brief glance, per andre__, you shouldn't be penalised for the co" [core] - 10https://gerrit.wikimedia.org/r/258897 (owner: 10Victorbarbu) [12:29:42] summarized IRC discussion on the patchset ^ [12:29:47] thanks [12:30:20] (03CR) 10DCausse: Add Completion Suggester as a Beta Feature (035 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) (owner: 10DCausse) [12:30:32] We have 5 or 6 UX designers/engineers at the WMF... We should be able to illicit input from one or 2 of them quickly [12:30:54] * andre__ kindly asks pginer to provide some feedback on https://gerrit.wikimedia.org/r/#/c/258897/ (Google Code-In task to fix some TODOs in the code) [12:31:02] Would it be better to create an associated phab task rather than just CC-ing them on random gerrit tasks [12:31:19] * andre__ needs to find some breakfast, be back later [12:32:33] thank you, guys! [12:32:37] Having a Phabricator ticket is always helpful in cases like this [12:34:06] The list of contributions follow a pattern that is used on several other places. It can be improved in different ways, but it would be good to have explicit considerations on what we try to improve, possible approaches and how consistently the approach can be supported in other places. [12:34:57] 7Design, 10MediaWiki-Special-pages: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1877502 (10Reedy) 3NEW [12:35:00] pginer: ^^ [12:35:02] victorbarbu_: ^^ [12:35:03] 10Security-Reviews, 6Security-Team, 10Thumbor: Thumbor Security Review - https://phabricator.wikimedia.org/T114414#1877510 (10Gilles) [12:35:27] victorbarbu_: https://gerrit.wikimedia.org/r/#/c/258897/2/includes/changes/ChangesList.php,unified You've added an extra whitespace in that that should be removed [12:35:42] 10MediaWiki-extensions-WikibaseView, 10Wikidata: [Story] Create a cleaner and compact design - https://phabricator.wikimedia.org/T121390#1877514 (10Jonas) 3NEW a:3Jonas [12:35:56] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 3Wikidata-Sprint-2015-12-01: [Story] Create a cleaner and compact design - https://phabricator.wikimedia.org/T121390#1877522 (10Jonas) [12:36:20] Reedy: changing it now. [12:36:25] victorbarbu_: and when you're amending the commit, please add Bug: T121389 to the commit summary [12:36:37] ok [12:36:47] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [12:37:22] 7Design, 10MediaWiki-Special-pages, 3Google-Code-In-2015: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1877528 (10Reedy) [12:37:44] victorbarbu_: You might want to CC yourself on that task too :) [12:39:10] (03PS3) 10Victorbarbu: Displaying contributions in table [core] - 10https://gerrit.wikimedia.org/r/258897 (https://phabricator.wikimedia.org/T121389) [12:39:56] Reedy: what does CC mean? [12:40:05] Add yourself to the subscriber list [12:40:10] oh [12:40:13] ooh yeah [12:40:21] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-12-01: [Story] Create a cleaner and compact design - https://phabricator.wikimedia.org/T121390#1877534 (10Jonas) {F3086177} [12:41:34] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-12-01: [Story] Create a cleaner and compact design - https://phabricator.wikimedia.org/T121390#1877549 (10Jonas) @Lydia_Pintscher could you please confirm that you approve this design change. [12:41:47] 7Design, 10MediaWiki-Special-pages, 3Google-Code-In-2015, 5Patch-For-Review: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1877551 (10Reedy) https://imgur.com/a/gLdPm is the screenshots [12:41:57] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint 4, and 2 others: Get ContentTranslation to anticipate and handle AbuseFilter warnings and blocks - https://phabricator.wikimedia.org/T114621#1877559 (10Trondtr) Comment to User:SThelen.Aqua: I am glad to hear t... [12:43:40] pginer: Can you comment on https://phabricator.wikimedia.org/T121389 as appropriate please? [12:44:04] sure [12:46:23] d3r1ck: hey! [12:48:49] 10MediaWiki-extensions-WikibaseView, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-12-01: [Story] Create a cleaner and compact design - https://phabricator.wikimedia.org/T121390#1877582 (10Lydia_Pintscher) Yes. Let's do it. Less lines ftw! :) [12:49:11] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Haven't tested" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [12:50:45] (03PS2) 10Sumit: MobileFrontend mw.notification instead of toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) [12:51:54] (03CR) 10Sumit: [C: 04-1] "I was trying to pass tests first, will consider comments in PS3" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [12:53:49] 7Design, 10MediaWiki-Special-pages, 3Google-Code-In-2015, 5Patch-For-Review: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1877586 (10NiharikaKohli) I love the table view. The current view is not much understandable for new contributors. [12:59:04] (03CR) 10Addshore: [C: 032] Show the number of MassAction jobs queued on Special:Statistics [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/258769 (https://phabricator.wikimedia.org/T96562) (owner: 10Unicornisaurous) [12:59:37] (03Merged) 10jenkins-bot: Show the number of MassAction jobs queued on Special:Statistics [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/258769 (https://phabricator.wikimedia.org/T96562) (owner: 10Unicornisaurous) [12:59:58] pranavk_: how are you? [13:00:07] and GCI? [13:00:10] d3r1ck: fine! [13:00:16] GCI's great! [13:01:26] to anyone: could you please give a +1 (or whatever is required) to trigger a jenkins test? [13:01:29] Ok, good to now. Feeel free to ask any problem you have here, there are many mentors and admins available to help you at all times :) [13:01:49] d3r1ck: yes, all the mentors have been great! [13:01:52] now -> know [13:01:54] 7Design, 10MediaWiki-Special-pages, 3Google-Code-In-2015, 5Patch-For-Review: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1877591 (10Pginer-WMF) There are several aspects to consider here: The general recommendation agains the table element (in HTML) is... [13:02:11] https://gerrit.wikimedia.org/r/#/c/258967/ [13:03:22] Does a +1 actually trigger jenkins? [13:03:37] Reedy, yes, if done by a mentor [13:03:55] or anyone with merge rights [13:04:34] when i upload a patch, jenkins does the basic test, but my issue is with the integration test, so i have no way to execute that [13:04:43] "mentors" don't exist in Gerrit. At least not as a role :) [13:04:46] Why can't you? [13:05:05] and +1 means "this patch looks fine" so that should not be given just to trigger some testing [13:05:10] Right [13:05:15] andre__: i'm just used to calling you guys "mentors" :) [13:05:18] I don't think it does trigger it [13:05:25] (03CR) 10jenkins-bot: [V: 04-1] MobileFrontend mw.notification instead of toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [13:05:32] andre__: oh sorry [13:05:52] no problem. just explaining :) [13:05:54] pranavk_: "recheck" keyword should, I think. But not from everyone. [13:06:10] niharika: thanks for "recheck"ing! [13:06:30] Didn't work, apparently. ¯\_(ツ)_/¯ (I have merge rights there though) [13:06:50] Niharika: You've gotta give jenkins a bit of time ;) [13:06:56] i guess it takes a minute... it did last time [13:07:07] Ah. Busy jenkins. [13:07:20] He's just lazy [13:07:45] Reedy: :P [13:09:51] victorbarbu_: Looks like the task has just got more complex :) [13:10:30] pranavk_: You should try and sort it so you can run the tests locally [13:10:37] (03PS15) 10DCausse: Add Completion Suggester as a Beta Feature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) [13:10:49] Reedy: ok [13:18:01] Reedy: well. I've read those, I could come up with a model for all similar special pages [13:18:11] of course, it would take time, but I could do it. [13:19:00] We could probably escalate it from a TODO into a proper GCI task [13:19:16] nononono [13:20:41] it is good right now :)) [13:20:46] althouh, hmm [13:20:54] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/commons.feature:7 features/frozen_index_api.feature:30" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) (owner: 10DCausse) [13:23:33] (03PS16) 10DCausse: Add Completion Suggester as a Beta Feature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) [13:23:46] I have to go, goodbye :) [13:24:10] (03CR) 10Reedy: "CR -1" [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [13:30:00] (03PS1) 10Reedy: Fix HHVM RepoAuthorative mode again [core] - 10https://gerrit.wikimedia.org/r/258971 [13:30:15] (03CR) 10Reedy: "Follows up https://gerrit.wikimedia.org/r/#/c/248809/" [core] - 10https://gerrit.wikimedia.org/r/258971 (owner: 10Reedy) [13:30:30] (03CR) 10Reedy: "Fixed again in https://gerrit.wikimedia.org/r/#/c/258971" [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [13:32:34] (03PS10) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [13:35:49] (03CR) 10jenkins-bot: [V: 04-1] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [13:36:19] Any mentor: can you please recheck this: https://gerrit.wikimedia.org/r/#/c/258967/ [13:36:23] (03PS11) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [13:38:01] 7Design, 10MediaWiki-Special-pages, 3Google-Code-In-2015, 5Patch-For-Review: Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389#1877597 (10Victorbarbu) I could probably help and come up with a model for this problem, if the decision is taken and the solution is... [13:38:57] pranavk_: It still won't work for the same reasons [13:39:08] 10MediaWiki-Search, 7Easy, 5MW-1.26-release: Interwiki search results should come after local ones in HTML - https://phabricator.wikimedia.org/T87631#1877599 (10Aklapper) @NikIWiki: Yes please (and refer to this one that it's a followup)! [13:39:22] Reedy: but I changed the $params array [13:39:38] Reedy: so what error will occur this time? [13:39:50] It won't work [13:40:11] (03CR) 10DCausse: [WIP] Collect per-node fetch/query latency percentiles (031 comment) [search/extra] - 10https://gerrit.wikimedia.org/r/258720 (owner: 10EBernhardson) [13:40:16] im sorry, what won't work? [13:40:23] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) (owner: 10DCausse) [13:40:27] if ( $prop['url'] === 'url' ) { [13:40:41] Look at the example I linked [13:40:44] https://github.com/wikimedia/mediawiki/blob/master/includes/api/ApiQueryWatchlist.php#L65-L87 [13:40:48] (03PS3) 10DCausse: Some refactoring of the suggester [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [13:40:57] It's checking that the prop isn't null, and then array_flip-ing it [13:41:54] but in my case, i don't need to array flip it [13:44:55] (03CR) 10jenkins-bot: [V: 04-1] Some refactoring of the suggester [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [13:46:23] (03CR) 10DCausse: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [13:48:53] pranavk_: Why don't you? [13:48:59] Have you tested it and it works? [13:49:34] pranavk_: I don't think self::PARAM_TYPE => array( 'url' => 'url' ), will work as expected [13:49:46] i haven't tried it yet, but i will [13:54:39] (03CR) 10DCausse: Add more flexible rescore profiles (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/257349 (https://phabricator.wikimedia.org/T110648) (owner: 10DCausse) [13:54:45] (03PS4) 10DCausse: Add more flexible rescore profiles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/257349 (https://phabricator.wikimedia.org/T110648) [13:55:37] (03PS1) 10Yaron Koren: Added decoding of single quotes in "where" clause [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258973 [13:59:48] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/suggest_api.feature:15:19:23:27:31:40:41:42:49:50:51:59:60:62:72:73" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [14:00:30] 6Revscoring, 10ores: Revert model for English Wikiversity - https://phabricator.wikimedia.org/T121397#1877623 (10Halfak) 3NEW [14:04:45] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1877631 (10josephine_l) [14:19:07] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/257349 (https://phabricator.wikimedia.org/T110648) (owner: 10DCausse) [14:19:28] 10MediaWiki-Database, 10DBA, 6Project-Creators: Rename Database to DBA, create blocked-by-schema-change - https://phabricator.wikimedia.org/T119751#1877641 (10jcrespo) I've documented the changes on my workflow on https://wikitech.wikimedia.org/wiki/Schema_changes [14:20:21] 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Better announce the lack of Machine Translation - https://phabricator.wikimedia.org/T106415#1877643 (10Amire80) There are several cases of lack: # Machine translation doesn't exist at all. There's no known technology that provide... [14:23:42] can someone please recheck: https://gerrit.wikimedia.org/r/#/c/258967/ [14:29:39] pranavk_, context? [14:30:08] andre__: imstill stuck on the same task... [14:30:09] pranavk_: there are many people here working on may different repositories. You don't want everybody to have to click the link in order to find out whether it's relevant for them or not :) [14:30:24] andre__: oops [14:30:44] pranavk_, whatever "same task" you mean. (Well, I know, but others might not.) ;) [14:31:24] 10Reading Web Planning: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1877651 (10Wittylama) 3NEW [14:31:39] andre__: https://codein.withgoogle.com/dashboard/task-instances/6195199357222912/ [14:31:41] :) [14:31:41] Wikidata: wbsearchentities: Make returning the entity URL optional || 7 days || Code || Wikimedia || Currently claimed [14:32:10] pranavk_, again: if you want feedback on Wikidata code changes, #wikidata is *the* channel. [14:32:26] andre__: yup, got it [14:32:39] pranavk_: In #wikidata there are definitely the developers who know. Here there might only be a few. Hence your changes over there are higher. [14:37:20] (03PS1) 10Dbrant: Remove IndexOutOfBounds bug check. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258974 [14:37:32] 10MediaWiki-extensions-SemanticForms, 5Patch-For-Review: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1877663 (10saper) This is from https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FSemanticForms.git/master/includes%2Fforminpu... [14:39:27] pranavk_: do you need any help to join the #wikidata IRC channel? Or have you managed? [14:44:02] 10Commons-App-Android-Upload: Find a library to extract GPS coordinates info from a picture, and implement its use - https://phabricator.wikimedia.org/T119279#1877667 (10Nicolas_Raoul) Sounds exactly like what we need :-) It is wonderful that Android has a ready-to-use API for this. Just call it at the place whe... [14:44:42] (03CR) 10Bartosz Dziewoński: "Thanks. The "Set an email address" link shouldn't be styled as a warning, either, I think. I would just remove the styling from it." [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) (owner: 10Neonowy) [14:46:54] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] Not all language links showing up, manual purge required - https://phabricator.wikimedia.org/T47839#1877679 (10Amire80) And another one from Hebrew: https://he.wikipedia.org/wiki/%D7%90%D7%99%D7%99%D7%A8%D7%91%D7%95%D7%A1_A350 [14:47:45] andre__: thanks, i managed! [14:48:18] (03PS2) 10Bearloga: Add links to dashboard repositories so people know where to contribute. [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/258505 (https://phabricator.wikimedia.org/T118551) [14:48:33] 10MediaWiki-extensions-UniversalLanguageSelector, 7Upstream: jQueryIME: If contentEditable cursor not in a text node, then insertion goes before the first CE text character - https://phabricator.wikimedia.org/T121216#1877682 (10dchan) [14:48:52] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/255983 (owner: 10Gergő Tisza) [14:49:22] (03Abandoned) 10Bearloga: Add links to dashboard repositories so people know where to contribute. [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/258505 (https://phabricator.wikimedia.org/T118551) (owner: 10Bearloga) [14:52:45] (03PS1) 10Bearloga: Add repo links for contributing [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/258977 [14:53:04] (03CR) 10Bearloga: [C: 032 V: 032] Add repo links for contributing [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/258977 (owner: 10Bearloga) [14:53:19] (03CR) 10Yaron Koren: [C: 032 V: 031] Added decoding of single quotes in "where" clause [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258973 (owner: 10Yaron Koren) [14:58:51] 10BetaFeatures, 10Reading Web Planning: "related articles" showing regardless of beta features preferences - https://phabricator.wikimedia.org/T121402#1877705 (10Wittylama) 3NEW [14:59:09] 10BetaFeatures, 10Reading Web Planning: "related articles" showing regardless of beta features preferences - https://phabricator.wikimedia.org/T121402#1877714 (10Wittylama) [14:59:28] 6Revscoring: Implement SemanticOperationsSelector for edit types campaign. - https://phabricator.wikimedia.org/T121403#1877716 (10Halfak) 3NEW a:3Halfak [15:02:21] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Monitor the status of the Apertium services for ContentTranslation - https://phabricator.wikimedia.org/T121404#1877726 (10Amire80) 3NEW [15:02:41] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Monitor the status of the Yandex services for ContentTranslation - https://phabricator.wikimedia.org/T121405#1877732 (10Amire80) 3NEW [15:03:02] (03CR) 10Sbisson: [C: 032] Fix misspelled setUp() in RevisionStorageTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258957 (owner: 10Thiemo Mättig (WMDE)) [15:04:29] (03CR) 10Sbisson: [C: 032] setUp methods in tests must be protected, not public [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258955 (owner: 10Thiemo Mättig (WMDE)) [15:06:14] (03Merged) 10jenkins-bot: Fix misspelled setUp() in RevisionStorageTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258957 (owner: 10Thiemo Mättig (WMDE)) [15:06:28] 10MediaWiki-API, 10MediaWiki-Database, 6Revscoring, 7Wikimedia-log-errors: mwapi.errors.APIError: internal_api_error_DBQueryError - https://phabricator.wikimedia.org/T121333#1877741 (10Anomie) > Error: 2013 Lost connection to MySQL server during query (10.64.48.20) This generally means the query was bein... [15:08:37] (03Merged) 10jenkins-bot: setUp methods in tests must be protected, not public [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258955 (owner: 10Thiemo Mättig (WMDE)) [15:08:48] (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:09:50] 6Education-Collab: Facilitate a deeper discussion about tech tools that support WIKI-EDU work - https://phabricator.wikimedia.org/T111965#1877744 (10FloorKoudijs) 5Open>3Resolved [15:10:27] (03PS1) 10Mforns: Reset low mysql consumer queue sizes [eventlogging] - 10https://gerrit.wikimedia.org/r/258982 (https://phabricator.wikimedia.org/T121384) [15:10:46] 6Education-Collab: Interview Lydia Pintscher about WikiData and its connection to Wiki in Eduation - https://phabricator.wikimedia.org/T119064#1877748 (10FloorKoudijs) 5Open>3Resolved [15:11:43] (03CR) 10Mforns: [C: 032 V: 032] "Self-merged, this code was approved already in a previous change. I'll redeploy that as a second try." [eventlogging] - 10https://gerrit.wikimedia.org/r/258982 (https://phabricator.wikimedia.org/T121384) (owner: 10Mforns) [15:13:17] 6Education-Collab: Pick hotel for Collab in-person meeting - https://phabricator.wikimedia.org/T115040#1877751 (10FloorKoudijs) Done! :) Thank you @saramortsell for taking the lead on this and for negotiating a great discount. [15:13:22] 6Education-Collab: Preparing Collab in-person meeting in Stockholm, Sweden - https://phabricator.wikimedia.org/T115038#1877753 (10FloorKoudijs) [15:13:24] 6Education-Collab: Pick hotel for Collab in-person meeting - https://phabricator.wikimedia.org/T115040#1877752 (10FloorKoudijs) 5Open>3Resolved [15:13:43] (03CR) 10jenkins-bot: [V: 04-1] Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:15:26] (03CR) 10Thiemo Mättig (WMDE): Create question page if it does not exist (031 comment) [extensions/Teahouse] - 10https://gerrit.wikimedia.org/r/229348 (owner: 10Thiemo Mättig (WMDE)) [15:16:18] (03PS1) 10Bartosz Dziewoński: SpecialChangeEmail: Remove dead code (whole 'mediawiki.special.changeemail' module) [core] - 10https://gerrit.wikimedia.org/r/258984 [15:18:52] (03PS13) 10Hashar: Update packages, Fix jshint and jscs warnings and errors [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/240001 (owner: 10Paladox) [15:20:07] (03CR) 10Hashar: [C: 031] Update packages, Fix jshint and jscs warnings and errors [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/240001 (owner: 10Paladox) [15:24:37] 10MediaWiki-extensions-WikibaseRepository, 10DataValues, 10Wikidata, 7Easy, and 2 others: Allows to input of plain text such as "today" in time edit widget - https://phabricator.wikimedia.org/T76859#1877762 (10thiemowmde) Should this be a fixed keyword like in SQL and programming languages, namely "now"? I... [15:25:34] (03CR) 10Mholloway: [C: 032 V: 032] Roll out RESTBase usage to Android Beta app: 55% [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/258502 (https://phabricator.wikimedia.org/T118965) (owner: 10BearND) [15:26:50] (03PS1) 10Mholloway: Roll out RESTBase usage to Android Beta app: 55% [extensions/MobileApp] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258985 (https://phabricator.wikimedia.org/T118965) [15:27:14] Hello everybody. Can anybody help me with git and gerrit? I installed gerrit but i don't know how to get a file in order to edit it [15:27:30] (03CR) 10Sbisson: [C: 032] Wrap topic lock/unlock standalone instance with flow-board div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258073 (https://phabricator.wikimedia.org/T120725) (owner: 10Mooeypoo) [15:27:54] 10MediaWiki-API, 6Reading-Infrastructure-Team: Allow access to last modified information for API users - https://phabricator.wikimedia.org/T120872#1877769 (10Anomie) >>! In T120872#1874826, @Jdlrobson wrote: > Apart from the common problem it's not always obvious which API queries to construct {T2001}? Or jus... [15:28:11] 10MediaWiki-API, 6Reading-Infrastructure-Team: Allow access to last modified information for API users - https://phabricator.wikimedia.org/T120872#1877774 (10Anomie) a:5Anomie>3None [15:28:47] (03CR) 10Niedzielski: [C: 031] Remove IndexOutOfBounds bug check. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258974 (owner: 10Dbrant) [15:29:21] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:29:24] (03CR) 10Sniedzielski: [C: 032] Remove IndexOutOfBounds bug check. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258974 (owner: 10Dbrant) [15:29:32] 6Design-Research: Getting video (of design research) on Commons: A How To and a project {kaolo} - https://phabricator.wikimedia.org/T121406#1877776 (10aripstra) 3NEW a:3aripstra [15:32:15] (03CR) 10Sbisson: Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:32:21] (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:32:39] (03Merged) 10jenkins-bot: Wrap topic lock/unlock standalone instance with flow-board div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258073 (https://phabricator.wikimedia.org/T120725) (owner: 10Mooeypoo) [15:33:30] (03Merged) 10jenkins-bot: Remove IndexOutOfBounds bug check. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258974 (owner: 10Dbrant) [15:35:25] (03PS1) 10Reedy: Don't install a custom error handler for hooks [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258986 (https://phabricator.wikimedia.org/T117553) [15:35:31] (03Merged) 10jenkins-bot: Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:35:46] (03CR) 10Sbisson: [C: 032] "I think it can be $topic->getContent( 'plaintext' ), topic-title is the only one that would use it but there's nothing specific to topic-t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258098 (owner: 10Catrope) [15:36:31] (03CR) 10Legoktm: [C: 04-1] "Can you add a comment explaining why there's no leading / so we don't accidentally regress again?" [core] - 10https://gerrit.wikimedia.org/r/258971 (owner: 10Reedy) [15:36:51] legoktm: :D [15:37:02] 10MassAction, 3Google-Code-In-2015, 5Patch-For-Review: Show the number of MassAction jobs queued on Special:Statistics - https://phabricator.wikimedia.org/T96562#1877806 (10Unicornisaurous) 5Open>3Resolved [15:37:56] (03CR) 10Dbrant: [C: 032] Hygiene: move intent creation to target Activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258522 (owner: 10Niedzielski) [15:38:46] (03Merged) 10jenkins-bot: Use plaintext topic title rather than wiktext for the [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258098 (owner: 10Catrope) [15:39:13] <grrrit-wm> (03PS1) 10Reedy: Don't install a custom error handler for hooks [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/258987 (https://phabricator.wikimedia.org/T117553) [15:40:54] <wikibugs> 10WikiProject-X: Women in Red logo - https://phabricator.wikimedia.org/T121409#1877808 (10Harej) 3NEW [15:40:57] <grrrit-wm> (03PS2) 10Reedy: Don't install a custom error handler for hooks [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/258987 (https://phabricator.wikimedia.org/T117553) [15:41:14] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: move intent creation to target Activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258522 (owner: 10Niedzielski) [15:41:27] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Don't install a custom error handler for hooks [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258986 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [15:42:37] <grrrit-wm> (03CR) 10Reedy: "REL1_26: https://gerrit.wikimedia.org/r/#/c/258986/" [core] - 10https://gerrit.wikimedia.org/r/256645 (https://phabricator.wikimedia.org/T117553) (owner: 10Ori.livneh) [15:43:18] <grrrit-wm> (03CR) 10Reedy: "recheck" [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258986 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [15:43:33] <IoannisKydonis> how can i download files from media wiki in order to edit them? (e.g. DefaultSettings.php) [15:43:57] <pranavk_> IoannisKydonis: You can clone them using Git [15:44:14] <pranavk_> https://www.mediawiki.org/wiki/Gerrit/Tutorial [15:44:47] <IoannisKydonis> pranavk: can you give me an example of an order i should give to git in order to do that? [15:45:35] <pranavk_> git clone ssh://<USERNAME>@gerrit.wikimedia.org:29418/mediawiki/core.git [15:45:37] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix visibility of setUp methods in tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258953 (owner: 10Thiemo Mättig (WMDE)) [15:46:29] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:46:44] <grrrit-wm> (03PS2) 10Reedy: Fix HHVM RepoAuthorative mode again [core] - 10https://gerrit.wikimedia.org/r/258971 [15:47:13] <grrrit-wm> (03PS2) 10Sbisson: [wip] Add secondary links to notifications from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 (owner: 10Mooeypoo) [15:48:25] <IoannisKydonis> pranavk: thank you [15:48:49] <Niharika> IoannisKydonis: Are you a GCI student? [15:48:58] <MtDu_> legoktm: Hey! I'm having a little trouble setting up the Echo extension. I think it might have something to do with the fact that my vagrant environment is not set up, which might be because I don't know how to set a server up on my pc. [15:49:01] <grrrit-wm> (03CR) 10Paladox: "recheck" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/256490 (owner: 10Paladox) [15:49:18] <Niharika> IoannisKydonis: If yes, just downloading the file and changing it will not help. You have to test your changes before you submit them. [15:49:32] <grrrit-wm> (03CR) 10Jforrester: [C: 04-1] "A couple of minor comments around nomenclature. Have pinged Nemo bis for confirmation/more details on the translatewiki stuff." (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [15:49:39] <grrrit-wm> (03Merged) 10jenkins-bot: Fix visibility of setUp methods in tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258953 (owner: 10Thiemo Mättig (WMDE)) [15:51:01] <grrrit-wm> (03PS1) 10Reedy: Don't install a custom error handler for hooks [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/258989 (https://phabricator.wikimedia.org/T117553) [15:51:18] <grrrit-wm> (03CR) 10Reedy: "[15:50:56] <basisbit> could you just add a comment "+1 by basisbit; required for mediawiki 1.25.2 with MLEB installed as described in wiki" [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/258987 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [15:51:24] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:51:37] <IoannisKydonis> Niharika: yes i'm a GCI student. Can you please explain me how to do that? [15:52:03] <grrrit-wm> (03CR) 10Paladox: Localise the signiture code (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [15:52:06] <grrrit-wm> (03PS3) 10Paladox: Localise the signiture code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [15:52:48] <Niharika> !hacker | IoannisKydonis [15:52:48] <wm-bot> IoannisKydonis: http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [15:53:08] <grrrit-wm> (03CR) 10Sbisson: "Do we want to do something special when the mention is done by an anonymous user? It shows the IP and a link to an IP user page." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 (owner: 10Mooeypoo) [15:53:09] <Niharika> IoannisKydonis: You need to setup vagrant locally. See 'vagrant installation' [15:53:16] <Niharika> In the link above. [15:53:23] <IoannisKydonis> ok [15:53:42] <grrrit-wm> (03PS2) 10Reedy: Don't install a custom error handler for hooks [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/258989 (https://phabricator.wikimedia.org/T117553) [15:53:43] <wikibugs> 7Design, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 5Patch-For-Review: Updated logo for Ladino Wikipedia - https://phabricator.wikimedia.org/T118491#1877829 (10StevenJ81) @Mareklug, how would you like me to proceed? The wiki is certainly not looking for anything fancy. We don't want to put som... [15:54:09] <grrrit-wm> (03CR) 10Sbisson: Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:54:15] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:54:22] <MtDu_> legoktm: I think what I'm going to do is just uninstall and reinstall everything from square 1. [15:56:20] <grrrit-wm> (03PS1) 10Reedy: Don't install a custom error handler for hooks [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/258990 (https://phabricator.wikimedia.org/T117553) [15:56:51] <grrrit-wm> (03CR) 10Reedy: "REL1_24: https://gerrit.wikimedia.org/r/258989" [core] - 10https://gerrit.wikimedia.org/r/256645 (https://phabricator.wikimedia.org/T117553) (owner: 10Ori.livneh) [15:57:06] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877832 (10Arkanosis) Hi everyone, @Jules78120 reported an issue with MediaWiki:AnonNotice on the French Wikipedia today, where the notice was added at the bottom left of the page... [15:57:25] <grrrit-wm> (03PS4) 10Paladox: Localise the signiture code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [15:57:59] <grrrit-wm> (03Merged) 10jenkins-bot: Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:58:27] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877836 (10Arkanosis) [16:00:55] <wikibugs> 10Wikimedia-Site-Requests: Add domain to $wgCopyUploadsDomains - https://phabricator.wikimedia.org/T121383#1877841 (10Dereckson) p:5Unbreak!>3High [16:03:08] <grrrit-wm> (03CR) 10Paladox: "Ok done at https://gerrit.wikimedia.org/r/#/c/258991/ for translatewiki." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:03:25] <grrrit-wm> (03CR) 10Bmansurov: [C: 04-1] Hygiene: Minor styling improvements (031 comment) [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/251640 (owner: 10Jdlrobson) [16:03:55] <ashley> let's start with the fact that you should never edit DefaultSettings.php :) instead make your changes to LocalSettings.php (which is located in the MW folder root) [16:04:12] <wikibugs> 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-OpenStackManager, 6Labs, 10wikitech.wikimedia.org, and 3 others: MWException after account creation on wikitech - https://phabricator.wikimedia.org/T117553#1877844 (10Reedy) > [15:50:56] <basisbit> could you just add a comment "+1 by basisbit; required... [16:04:27] <ashley> guh, I should learn to scroll down to see the most recent messages... [16:04:41] <wikibugs> 10Wikimedia-Site-Requests, 5Patch-For-Review: Noindex for user namespace on Korean Wikipedia - https://phabricator.wikimedia.org/T121301#1877847 (10revi) 5Open>3Resolved [16:04:48] <grrrit-wm> (03PS1) 10Niharika29: [WIP] Do all DB writes via the JobQueue [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/258992 (https://phabricator.wikimedia.org/T121069) [16:07:00] <Reedy> ashley: Well, not quite... If you're adding/changing a default setting for everyone... :D [16:07:06] <grrrit-wm> (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/MobileApp] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258985 (https://phabricator.wikimedia.org/T118965) (owner: 10Mholloway) [16:07:49] <wikibugs> 6Community-Liaison, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Plan to redirect inactive VisualEditor feedback pages for some wikis to mediawiki.org - https://phabricator.wikimedia.org/T92661#1877859 (10Elitre) @jdforrester-wmf, isn't T90523 still a blocker though? [16:08:21] <ashley> Reedy: heh, aye ;-) but if I had a dollar every time a typical end-user tells me that the file they needed to edit was not LocalSettings.php but DefaultSettings.php "because that's where the settings are" (never mind the huge CAPS LOCK disclaimer at the very beginning of the file)... [16:08:33] <Reedy> :D [16:09:20] <wikibugs> 10Wikimedia-Site-Requests: Noindex for user namespace on Korean Wikipedia - https://phabricator.wikimedia.org/T121301#1877861 (10revi) [16:09:58] <wikibugs> 10MediaWiki-extensions-Newsletter, 10Continuous-Integration-Config: Migrate mediawiki/extensions/Newsletter tests to use npm and grunt jsonlint/jshin - https://phabricator.wikimedia.org/T121352#1877864 (10hashar) That should be replaced by `npm test`. https://www.mediawiki.org/wiki/Continuous_integration/Entr... [16:11:10] <grrrit-wm> (03Merged) 10jenkins-bot: Roll out RESTBase usage to Android Beta app: 55% [extensions/MobileApp] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258985 (https://phabricator.wikimedia.org/T118965) (owner: 10Mholloway) [16:14:31] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877868 (10Jules78120) Here is a screenshot of the problem, which doesn't always occurr {F3087421} [16:15:05] <grrrit-wm> (03PS6) 10Niedzielski: Move content issues and disambiguations to menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258213 [16:15:11] <grrrit-wm> (03CR) 10Niedzielski: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258213 (owner: 10Niedzielski) [16:16:23] <wikibugs> 6Design-Research: Make Design Research Workshop recordings open format and upload to Commons {koala} - https://phabricator.wikimedia.org/T121406#1877874 (10aripstra) [16:17:27] <wikibugs> 10DBA, 6Wikisource, 7Blocked-on-schema-change, 7Schema-change: Schema change for page content language - https://phabricator.wikimedia.org/T69223#1877878 (10jcrespo) I've applied the schema change to testwiki, could it be tested somehow before continuing? I predict problems applying it on commons and wiki... [16:17:29] <grrrit-wm> (03CR) 10Florianschmidtwelzow: [C: 032] SpecialChangeEmail: Remove dead code (whole 'mediawiki.special.changeemail' module) [core] - 10https://gerrit.wikimedia.org/r/258984 (owner: 10Bartosz Dziewoński) [16:18:03] <grrrit-wm> (03PS2) 10Niedzielski: Add article geo-location navigation button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) [16:18:15] <grrrit-wm> (03CR) 10Niedzielski: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) (owner: 10Niedzielski) [16:18:26] <wikibugs> 10DBA, 6Wikisource, 7Blocked-on-schema-change, 7Schema-change: Schema change for page content language - https://phabricator.wikimedia.org/T69223#1877880 (10jcrespo) a:3jcrespo [16:18:45] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877883 (10ashley) For what it's worth...years ago, in r41679, I merged DismissableSiteNotice into core. Skizzerz improved it substantially in the follow-up revisions (r41706, r4171... [16:18:48] <wikibugs> 10Wikispeech: Set up Wikispeech stories on Phabricator - https://phabricator.wikimedia.org/T121206#1877884 (10Lokal_Profil) @Ainali: I need you to create #Wikispeech-Recording and #Wikispeech-NewLanguages before I can populate these. [16:19:54] <grrrit-wm> (03PS1) 10Bearloga: Add JS for updating URL [wikimedia/discovery/wetzel] - 10https://gerrit.wikimedia.org/r/258994 (https://phabricator.wikimedia.org/T117147) [16:20:01] <wikibugs> 10Browser-Tests-Infrastructure, 5Patch-For-Review: Browser tests broken for Internet Explorer, Safari, Android and iOS - https://phabricator.wikimedia.org/T114362#1877889 (10hashar) So I guess we will now want a new release of mediawiki_selenium (1.7.0 ?) and bump all repositories :-} [16:20:03] <grrrit-wm> (03PS1) 10Bearloga: Add JS for updating URL [wikimedia/discovery/rainbow] - 10https://gerrit.wikimedia.org/r/258995 (https://phabricator.wikimedia.org/T117147) [16:20:10] <grrrit-wm> (03PS1) 10Bearloga: Add JS for updating URL [wikimedia/discovery/twilightsparql] - 10https://gerrit.wikimedia.org/r/258996 (https://phabricator.wikimedia.org/T117147) [16:20:19] <grrrit-wm> (03PS1) 10Bearloga: Add JS for updating URL [wikimedia/discovery/prince] - 10https://gerrit.wikimedia.org/r/258997 (https://phabricator.wikimedia.org/T117147) [16:20:37] <grrrit-wm> (03PS1) 10Bearloga: Add JS for updating URL [wikimedia/discovery/wonderbolt] - 10https://gerrit.wikimedia.org/r/258998 (https://phabricator.wikimedia.org/T117147) [16:21:33] <grrrit-wm> (03PS3) 10Sumit: MobileFrontend mw.notification instead of toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) [16:21:35] <grrrit-wm> (03CR) 10GWicke: [C: 04-2] "Aaron, I think it makes sense to start with async production now, and make things seriously reliable (as part of a transaction) in a secon" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/257420 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [16:21:40] <grrrit-wm> (03CR) 10GWicke: [C: 031] execute HTTP POST as a deferred task [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/257420 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [16:22:04] <IoannisKydonis> Hello i'm a GCI student. How can i do a TODO? [16:22:13] <grrrit-wm> (03CR) 10Anomie: [C: 031] "Looks sane, but I don't know if it might break anything either. There are a lot of code paths in OutputPage that specifically check for $t" [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [16:23:17] <grrrit-wm> (03PS2) 10Niedzielski: Hygiene: reorder methods to match interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258638 [16:23:28] <grrrit-wm> (03CR) 10Niedzielski: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258638 (owner: 10Niedzielski) [16:24:54] <wikibugs> 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools, 5Patch-For-Review: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1877898 (10Anomie) >>! In T22189#1876784, @lfaraone wrote: > The page is deleted; it is already hidden from users wi... [16:25:00] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877900 (10Arkanosis) >>! In T108811#1877883, @ashley wrote: > For what it's worth...years ago, in r41679, I merged DismissableSiteNotice into core. Skizzerz improved it substantial... [16:25:17] <legoktm> MtDu: still having trouble? [16:26:16] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Fix HHVM RepoAuthorative mode again [core] - 10https://gerrit.wikimedia.org/r/258971 (owner: 10Reedy) [16:27:01] <grrrit-wm> (03Merged) 10jenkins-bot: SpecialChangeEmail: Remove dead code (whole 'mediawiki.special.changeemail' module) [core] - 10https://gerrit.wikimedia.org/r/258984 (owner: 10Bartosz Dziewoński) [16:27:06] <wikibugs> 6Editing-Analysis: Follow up on users from the visual editor experiment - https://phabricator.wikimedia.org/T111290#1877901 (10Neil_P._Quinn_WMF) I'm mostly done with the analysis (spoiler: still no significant effects from VE). The last piece, which I'm working on this week, is collecting and analyzing the the... [16:27:32] <grrrit-wm> (03PS1) 10Robert Vogel: importImagesRecursive: deleted obsolte files [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/258999 [16:29:19] <grrrit-wm> (03CR) 10BryanDavis: "Just a note here for posterity. This change will ensure that the Composer managed autoloader is activated very early in the request cycle." [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [16:31:00] <wikibugs> 7Easy, 3Wikipedia-Android-App: Improve error handling in Featured Article widget. - https://phabricator.wikimedia.org/T121410#1877904 (10Dbrant) 3NEW [16:31:11] <grrrit-wm> (03CR) 10Legoktm: "Aren't things autoloaded with "files" (most MW extensions) read immediately anyways?" [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [16:32:29] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877912 (10Arkanosis) I guess the “quick fix” for now is to replace the current $notice = Html::inlineScript( Xml::encodeJsCall( 'document.write', array( $notice ) ) ); with som... [16:32:49] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877913 (10PleaseStand) >>! In T108811#1877832, @Arkanosis wrote: > @Jules78120 reported an issue with MediaWiki:AnonNotice on the French Wikipedia today, where the notice was added... [16:33:17] <grrrit-wm> (03Merged) 10jenkins-bot: Fix HHVM RepoAuthorative mode again [core] - 10https://gerrit.wikimedia.org/r/258971 (owner: 10Reedy) [16:33:38] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 7Easy, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: use background-size:cover on related images - https://phabricator.wikimedia.org/T121152#1877915 (10bmansurov) Here [1] is the compatibility table. Mobile browsers don't seem to support this feature we... [16:35:03] <grrrit-wm> (03CR) 10Jforrester: Localise the signiture code (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:35:53] <grrrit-wm> (03PS5) 10Jforrester: Let the signature wikitext be over-ridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:35:58] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning, 7Beta-Feature: "related articles" showing regardless of beta features preferences - https://phabricator.wikimedia.org/T121402#1877920 (10Legoktm) [16:36:19] <grrrit-wm> (03PS3) 10Matthias Mullie: Add filter to ApiEchoNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) [16:36:32] <grrrit-wm> (03CR) 10Jforrester: [C: 031] Let the signature wikitext be over-ridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [16:36:33] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877921 (10Vatadoshu) ok for me the banner is not at the top and not at the bottom. there is no banner on articles ("chien", "chat"). (windows vista chrome 47) but i have it on the... [16:37:39] <grrrit-wm> (03PS1) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:37:55] <wikibugs> 10Browser-Tests-Infrastructure, 5Patch-For-Review: Browser tests broken for Internet Explorer, Safari, Android and iOS - https://phabricator.wikimedia.org/T114362#1877923 (10zeljkofilipin) @hashar that is my plan for this week. [16:38:03] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:38:19] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning, 7Beta-Feature: "related articles" showing regardless of beta features preferences - https://phabricator.wikimedia.org/T121402#1877925 (10bmansurov) Can you try enabling the "Read More" feature specifically (rather than relying on "enable all new... [16:38:36] <wikibugs> 6Phabricator: Understand phabricator scalability - https://phabricator.wikimedia.org/T112776#1877928 (10jcrespo) [16:38:39] <wikibugs> 6Phabricator, 10DBA, 6operations, 5Patch-For-Review, 7WorkType-Maintenance: Phabricator creates MySQL connection spikes: Attempt to connect to phuser@m3-master.eqiad.wmnet failed with error #1040: Too many connections. - https://phabricator.wikimedia.org/T109279#1877926 (10jcrespo) 5Open>3Resolved Th... [16:38:51] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877932 (10Jules78120) >>! In T108811#1877921, @Vatadoshu wrote: > ok for me the banner is not at the top and not at the bottom. there is no banner on articles ("chien", "chat"). >... [16:39:28] <grrrit-wm> (03PS2) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:39:56] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:40:29] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning, 7Beta-Feature: "related articles" showing regardless of beta features preferences - https://phabricator.wikimedia.org/T121402#1877933 (10Wittylama) My mistake - didn't see that this feature was called "read more", was looking for "related articl... [16:41:42] <wikibugs> 6Revscoring, 5Patch-For-Review: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1877935 (10Ladsgroup) @awight I've an idea. I've got this problem in my localhost too, What should I do to log errors and see what happens. You can do it too by cloning again (from scratch) [16:42:23] <grrrit-wm> (03PS3) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:42:50] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:43:27] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1877941 (10Jules78120) [16:43:29] <wikibugs> 10Wikimedia-General-or-Unknown: Create a MOOC about French Wikipedia - https://phabricator.wikimedia.org/T117281#1877940 (10Jules78120) [16:43:41] <grrrit-wm> (03PS4) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:44:05] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:44:55] <grrrit-wm> (03PS5) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:45:18] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:45:28] <grrrit-wm> (03CR) 10Matthias Mullie: Add filter to ApiEchoNotifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) (owner: 10Matthias Mullie) [16:45:51] <grrrit-wm> (03CR) 10Anomie: Initial support for CSP in core [Disabled by default] (031 comment) [core] - 10https://gerrit.wikimedia.org/r/253969 (owner: 10Brian Wolff) [16:47:05] <wikibugs> 10Wikimedia-Site-Requests: Throttle exception for University of Haifa event on 2015-12-15 - https://phabricator.wikimedia.org/T121321#1877952 (10Dereckson) a:3Dereckson [16:48:08] <grrrit-wm> (03PS6) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:48:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:49:22] <grrrit-wm> (03CR) 10Sumit: MobileFrontend mw.notification instead of toast (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [16:49:23] <grrrit-wm> (03PS7) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:49:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:50:45] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning, 7Beta-Feature: "related articles" showing regardless of beta features preferences - https://phabricator.wikimedia.org/T121402#1877959 (10bmansurov) 5Open>3Invalid a:3bmansurov I'll close this as invalid. Let's keep adding suggestions to im... [16:51:32] <grrrit-wm> (03PS1) 10Niedzielski: Hygiene: consolidate PageLoadStrategy init methods [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 [16:51:41] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1877651 (10bmansurov) [16:52:17] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1877976 (10Wittylama) [16:52:32] <grrrit-wm> (03CR) 10Anomie: [C: 04-1] "I'd prefer to do both, in case people do particularly crazy stuff like a non-default directory in $wgExtensionDirectory and still directly" [core] - 10https://gerrit.wikimedia.org/r/258726 (owner: 10Legoktm) [16:53:08] <grrrit-wm> (03PS8) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:53:11] <wikibugs> 6Community-Liaison: Message wikis about upcoming transition to centralized VE feedback - https://phabricator.wikimedia.org/T98465#1877983 (10Elitre) As the technical blocker is solved, I'm going to bug bn, da, el, et, fo, hu, id, kk, mr, ms, no, ro, sco, sk, sq, tl, vi, ca, pt, pl, uk, zh one last time to make s... [16:53:20] <grrrit-wm> (03CR) 10GWicke: [C: 04-1] handle parent_revision_id on page creation (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [16:53:27] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Hygiene: consolidate PageLoadStrategy init methods [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 (owner: 10Niedzielski) [16:53:34] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:53:48] <wikibugs> 10MediaWiki-API, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Create a migration path for legacy bots in an AuthManager world - https://phabricator.wikimedia.org/T121113#1877990 (10Anomie) [16:54:50] <grrrit-wm> (03PS9) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [16:55:17] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [16:55:40] <grrrit-wm> (03PS3) 10Legoktm: registration: When converting, place 'namemsg' under 'name' [core] - 10https://gerrit.wikimedia.org/r/241090 (owner: 10Paladox) [16:55:56] <grrrit-wm> (03CR) 10Legoktm: [C: 032] registration: When converting, place 'namemsg' under 'name' [core] - 10https://gerrit.wikimedia.org/r/241090 (owner: 10Paladox) [16:58:24] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1877651 (10Wittylama) As mentioned in: T116676#1877895 Clicking 'random article' gave me https://en.wikipedia.org/wiki/Gabriels,_New_York. The... [16:58:35] <grrrit-wm> (03CR) 10BryanDavis: "> Aren't things autoloaded with "files" (most MW extensions) read immediately anyways?" [core] - 10https://gerrit.wikimedia.org/r/248809 (owner: 10Gergő Tisza) [16:59:59] <grrrit-wm> (03PS10) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [17:00:06] <grrrit-wm> (03PS2) 10Niedzielski: Hygiene: consolidate PageLoadStrategy init methods [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 [17:00:33] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:00:38] <grrrit-wm> (03CR) 10Paladox: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/241090 (owner: 10Paladox) [17:00:45] <wikibugs> 10Wikimedia-Site-Requests, 5Patch-For-Review: Add domain to $wgCopyUploadsDomains - https://phabricator.wikimedia.org/T121383#1878004 (10Dereckson) a:3Dereckson [17:02:44] <grrrit-wm> (03PS1) 10Scimonster: Add case-changing magic words to mw.jqueryMsg [core] - 10https://gerrit.wikimedia.org/r/259015 (https://phabricator.wikimedia.org/T46495) [17:03:26] <grrrit-wm> (03CR) 10Dbrant: [C: 032] Move content issues and disambiguations to menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258213 (owner: 10Niedzielski) [17:03:40] <wikibugs> 6Community-Liaison: Q3 personal goal: Supporting release of VE to non-English Wikipedias (especially Phase 6 ones); supporting conversations around single tab elsewhere - https://phabricator.wikimedia.org/T121411#1878012 (10Elitre) 3NEW a:3Elitre [17:04:10] <wikibugs> 6Community-Liaison: Q3 personal goal: Decreasing the number of Wikipedias with 0% progress in translations related to VE (focusing on interface messages, especially for Phase 6 wikis) - https://phabricator.wikimedia.org/T121412#1878020 (10Elitre) 3NEW a:3Elitre [17:04:54] <grrrit-wm> (03PS11) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [17:05:11] <wikibugs> 6Community-Liaison: Q3 personal goal: Kickstarting new feedback practices, like the centralization of VE feedback on mw.org - https://phabricator.wikimedia.org/T121413#1878030 (10Elitre) 3NEW a:3Elitre [17:05:18] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:05:54] <grrrit-wm> (03Merged) 10jenkins-bot: Move content issues and disambiguations to menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258213 (owner: 10Niedzielski) [17:06:49] <wikibugs> 10MediaWiki-extensions-Scribunto, 7HHVM: Luasandbox is broken under HHVM 3.10 - https://phabricator.wikimedia.org/T115779#1878042 (10Anomie) >>! In T115779#1875338, @Aklapper wrote: >>>! In T115779#1875281, @alex-mashin wrote: >> Anybody cares? > > So far unfortunately not, as can be seen in the missing activ... [17:07:48] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] "you're a genius Baha! :)" [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/258964 (https://phabricator.wikimedia.org/T121263) (owner: 10Bmansurov) [17:08:41] <grrrit-wm> (03Merged) 10jenkins-bot: registration: When converting, place 'namemsg' under 'name' [core] - 10https://gerrit.wikimedia.org/r/241090 (owner: 10Paladox) [17:08:46] <grrrit-wm> (03Merged) 10jenkins-bot: Fix loading related articles on small screens [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/258964 (https://phabricator.wikimedia.org/T121263) (owner: 10Bmansurov) [17:09:08] <grrrit-wm> (03CR) 10Anomie: Allow JSON values to be included in the API results (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258196 (https://phabricator.wikimedia.org/T120380) (owner: 10Yurik) [17:11:10] <grrrit-wm> (03PS12) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [17:11:39] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:12:44] <grrrit-wm> (03CR) 10Dbrant: [C: 04-1] Add article geo-location navigation button (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) (owner: 10Niedzielski) [17:14:27] <wikibugs> 4(no projects): Investigate request id test failure - https://phabricator.wikimedia.org/T121414#1878062 (10GWicke) 3NEW [17:14:31] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] Special:Preferences Remove red box in email and changed confirm error to warning (032 comments) [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) (owner: 10Neonowy) [17:14:54] <grrrit-wm> (03CR) 10Jdlrobson: [C: 031] "sorry that was meant to be a +1 :) would appreciate thoughts from someone else" [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) (owner: 10Neonowy) [17:16:29] <grrrit-wm> (03CR) 10Anomie: "I'd hope the GCI student would be familiar enough with our codebase to know that we currently support PHP 5.3 which doesn't have traits ye" [core] - 10https://gerrit.wikimedia.org/r/258175 (owner: 10Albert221) [17:17:01] <grrrit-wm> (03PS1) 10Legoktm: [WIP] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) [17:17:32] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [17:22:02] <grrrit-wm> (03PS2) 10Legoktm: [WIP] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) [17:22:16] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [17:22:27] <grrrit-wm> (03PS13) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [17:22:54] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:24:32] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 10Reading Web Planning: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1878093 (10Jdlrobson) > 1 - at least in the English Wikipedia, the manual of style calls for sub-headings to use sentence case, that is "Related... [17:24:40] <grrrit-wm> (03CR) 10Reedy: "Why are you copying in MySQL stuff?" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:24:49] <wikibugs> 10MediaWiki-extensions-RelatedArticles: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1878094 (10Jdlrobson) [17:25:22] <halfak> Hey folks. I'm having some gerrit trouble. I could use some help. [17:25:32] <Reedy> halfak: have you tried turning it off an on again? [17:25:34] <halfak> When I git review -R, I get ~100 commits. [17:25:40] <halfak> It should have just one. [17:25:40] <grrrit-wm> (03PS3) 10Legoktm: [WIP] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) [17:25:49] <halfak> I see to be properly rebased against current production [17:25:52] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [17:25:56] <Reedy> halfak: git fetch --all ? [17:26:01] <Reedy> have you got multiple remotes? [17:26:22] <grrrit-wm> (03CR) 10Anomie: API: Avoid FOUC on help pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258662 (https://phabricator.wikimedia.org/T117901) (owner: 10Legoktm) [17:26:41] <halfak> Huh. git fetch --all seems to have fixed it. [17:26:48] <halfak> So I'm in the ops-puppet repo [17:26:53] <halfak> On "production" [17:26:57] <halfak> I make my change and commit. [17:27:07] <halfak> Then "git pull --rebase origin production" [17:27:29] <halfak> Then "git review -R" [17:27:51] <halfak> Thanks Reedy [17:27:55] <Reedy> I had similar issues having a gerrit and an origin remote [17:28:10] <Reedy> reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ cat ~/.config/git-review/git-review.conf [17:28:10] <Reedy> [gerrit] [17:28:10] <Reedy> defaultremote = origin [17:28:12] <halfak> Aha! I have two repotes. [17:28:17] <halfak> Gerrit and origin [17:29:03] <halfak> So the trick is to pull from gerrit -- not origin. [17:29:06] <halfak> :) [17:29:09] <grrrit-wm> (03PS14) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [17:29:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:29:49] <grrrit-wm> (03CR) 10Dbrant: Add article geo-location navigation button (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) (owner: 10Niedzielski) [17:29:49] <halfak> <3 reedy for the quick help :) [17:30:25] <Reedy> halfak: or fix your gitreview config (it's deprecated, but whatever), and then delete all the gerrit remotes [17:30:37] <grrrit-wm> (03CR) 10Legoktm: API: Avoid FOUC on help pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258662 (https://phabricator.wikimedia.org/T117901) (owner: 10Legoktm) [17:30:52] <halfak> Reedy, gotcha. Will try that. [17:31:40] <wikibugs> 10Wikispeech: Set up extension page - https://phabricator.wikimedia.org/T121416#1878098 (10Lokal_Profil) 3NEW [17:32:42] <MatmaRex> Reedy: halfak: i usually rename my 'origin' remote to 'gerrit' after cloning. git remote rename origin gerrit [17:32:42] <wikibugs> 10Education-Program-Dashboard, 7Article-Recommendation: Article Finder - https://phabricator.wikimedia.org/T111416#1878107 (10Ragesoss) @awight: good idea! We've pushed this back in our roadmap, and the focus will — to begin with — be on finding topics that have significant view traffic but aren't well-develop... [17:33:01] <wikibugs> 10Education-Program-Dashboard, 7Article-Recommendation: Article Finder - https://phabricator.wikimedia.org/T111416#1878108 (10Ragesoss) [17:33:20] <wikibugs> 10Wikispeech: Set up documentation page - https://phabricator.wikimedia.org/T121417#1878109 (10Lokal_Profil) 3NEW [17:33:40] <grrrit-wm> (03PS15) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [17:34:12] <grrrit-wm> (03PS1) 10Gerrit Patch Uploader: Use Language::factory( 'en' ) instead of wfGetLangObj( 'en' ) [core] - 10https://gerrit.wikimedia.org/r/259023 [17:34:14] <grrrit-wm> (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/259023 (owner: 10Gerrit Patch Uploader) [17:34:16] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [17:35:56] <wikibugs> 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1878124 (10Krenair) [17:36:05] <wikibugs> 10Wikispeech-Player: [Story] Recitation of marked text - https://phabricator.wikimedia.org/T121220#1878127 (10Lokal_Profil) [17:36:24] <wikibugs> 10Wikispeech-Player: [Story] Go from article text to surrounding UI - https://phabricator.wikimedia.org/T121217#1878128 (10Lokal_Profil) [17:36:29] <wikibugs> 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#604549 (10Krenair) [17:36:31] <grrrit-wm> (03PS1) 10Mhutti1: Added input box to select the task ID to view [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/259024 (https://phabricator.wikimedia.org/T96411) [17:36:32] <wikibugs> 10Wikispeech-Player: [Story] Start/Stop using keyboard shortcut - https://phabricator.wikimedia.org/T121214#1878132 (10Lokal_Profil) [17:36:36] <wikibugs> 10Wikispeech-Player: [Story] Start/stop using mouse - https://phabricator.wikimedia.org/T121208#1878137 (10Lokal_Profil) [17:36:53] <grrrit-wm> (03PS8) 10Florianschmidtwelzow: WIP: Convert Special:Search input to OOUI [core] - 10https://gerrit.wikimedia.org/r/252718 (https://phabricator.wikimedia.org/T100898) [17:39:04] <grrrit-wm> (03PS1) 10Jdlrobson: Release 2.1.0 [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/259027 (https://phabricator.wikimedia.org/T121052) [17:39:42] <grrrit-wm> (03PS3) 10Jdlrobson: Release 2.1.0 [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/258200 (https://phabricator.wikimedia.org/T121052) [17:40:18] <grrrit-wm> (03PS4) 10Jdlrobson: Release 2.1.0 [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/258200 (https://phabricator.wikimedia.org/T121052) [17:40:32] <grrrit-wm> (03Abandoned) 10Jdlrobson: Release 2.1.0 [extensions/RelatedArticles] (dev) - 10https://gerrit.wikimedia.org/r/259027 (https://phabricator.wikimedia.org/T121052) (owner: 10Jdlrobson) [17:40:57] <Reedy> lol [17:47:38] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 7Easy, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: use background-size:cover on related images - https://phabricator.wikimedia.org/T121152#1878191 (10Jdlrobson) The support is good enough provided the fallback is the status quo. [17:47:49] <victorbarbu_> hello! [17:48:06] <wikibugs> 6Editing-Analysis: measure how do autopromote values affect participation, vandalism, editor retention, etc. - https://phabricator.wikimedia.org/T86189#1878192 (10Milimetric) [17:48:22] <victorbarbu_> to work on a wikidata extension, do I have to clone the repo from gerrit, or simply downloading it [17:49:21] <Reedy> victorbarbu_: if you want to commit changes back, you need to clone it :) [17:49:46] <victorbarbu_> that's what I thought [17:49:59] <victorbarbu_> but...clone it in extensions/ ? [17:50:05] <wikibugs> 10Browser-Tests-Infrastructure, 5Patch-For-Review: Browser tests broken for Internet Explorer, Safari, Android and iOS - https://phabricator.wikimedia.org/T114362#1878205 (10zeljkofilipin) a:5dduvall>3None [17:50:18] <Reedy> Yeah [17:50:18] <wikibugs> 10Browser-Tests-Infrastructure, 5Patch-For-Review: Browser tests broken for Internet Explorer, Safari, Android and iOS - https://phabricator.wikimedia.org/T114362#1693114 (10zeljkofilipin) a:3zeljkofilipin [17:50:52] <grrrit-wm> (03PS3) 10Neonowy: Special:Preferences Remove red box in email and changed confirm error to warning [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) [17:51:18] <victorbarbu_> Reedy: won't there be some kind of "git conflicts"? [17:52:52] <Reedy> it'll be fine [17:54:11] <wikibugs> 6Discovery, 3Discovery-Cirrus-Sprint, 5Patch-For-Review: Turn off A/B test for the accept-language test on or after 2015-12-17 - https://phabricator.wikimedia.org/T119529#1878230 (10mpopov) [17:54:11] <grrrit-wm> (03PS1) 10CSteipp: [WIP] Show password policy on Special:ChangePassword [core] - 10https://gerrit.wikimedia.org/r/259029 [17:54:12] <wikibugs> 6Discovery, 3Discovery-Analysis-Sprint: Analyse results of accept-language header test on or after 2015-12-14 - https://phabricator.wikimedia.org/T119531#1878229 (10mpopov) [17:54:32] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show password policy on Special:ChangePassword [core] - 10https://gerrit.wikimedia.org/r/259029 (owner: 10CSteipp) [17:55:09] <grrrit-wm> (03PS4) 10Gergő Tisza: Add vagrant role for pywikibot [vagrant] - 10https://gerrit.wikimedia.org/r/258711 [17:55:11] <grrrit-wm> (03CR) 10Reedy: "T119583 is for ChangePassword and for signup :)" [core] - 10https://gerrit.wikimedia.org/r/259029 (owner: 10CSteipp) [17:56:24] <csteipp> I'm suspicious Reedy is pinged on anything mentioning passwords now... :) [17:56:30] <wikibugs> 10MediaWiki-User-login-and-signup: Display password requirements when changing a password or signing up - https://phabricator.wikimedia.org/T119583#1878246 (10Reedy) a:3csteipp [17:56:46] <Reedy> I'm just seriously procrastinating today [17:56:48] <Reedy> Not good :P [17:57:23] <csteipp> Reedy: Want to procrastinate further and +1 https://gerrit.wikimedia.org/r/#/c/258387/ ? [17:58:26] <Reedy> heh [17:58:32] <Reedy> Someone should pay me to procrastinate... [17:58:38] <Reedy> (Or is that called a job? ;) [17:58:39] <Reedy> ) [17:59:22] <Reedy> csteipp: Why do I get the feeling the next one is going to be just disabling all password checks with "oh fsck this"? :D [17:59:28] <wikibugs> 3Mobile-App-Android-Sprint-72-Hafnium, 5Patch-For-Review, 3Wikipedia-Android-App, 7WorkType-Maintenance: Changing search query quickly can cause mismatched results - https://phabricator.wikimedia.org/T111890#1878261 (10Etonkovidova) 2.1.136-alpha-2015-12-11 on Nexus 5 (Android 5.1.1) - no problem with the... [18:01:45] <grrrit-wm> (03PS16) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:02:19] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:05:38] <yurik> anomie, how do you make an element into the xml content element? it used to be the '*' - what is it now? [18:05:49] <grrrit-wm> (03PS17) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:06:15] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:08:58] <grrrit-wm> (03PS18) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:09:24] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:12:23] <wikibugs> 10MediaWiki-extensions-RelatedArticles: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1878335 (10Jdlrobson) p:5Triage>3Normal ping @JKatzWMF @dr0ptp4kt (Adam Baso) [18:12:45] <grrrit-wm> (03CR) 10OliverKeyes: [C: 032 V: 032] Add JS for updating URL [wikimedia/discovery/wonderbolt] - 10https://gerrit.wikimedia.org/r/258998 (https://phabricator.wikimedia.org/T117147) (owner: 10Bearloga) [18:13:18] <wikibugs> 10MediaWiki-API, 10MediaWiki-extensions-RelatedArticles: RelatedArticles API query can take 2 seconds - https://phabricator.wikimedia.org/T121254#1878342 (10Jdlrobson) p:5Triage>3High [18:13:38] <grrrit-wm> (03CR) 10OliverKeyes: [C: 032 V: 032] Add JS for updating URL [wikimedia/discovery/prince] - 10https://gerrit.wikimedia.org/r/258997 (https://phabricator.wikimedia.org/T117147) (owner: 10Bearloga) [18:13:42] <grrrit-wm> (03PS3) 10Niedzielski: Add article geo-location navigation button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) [18:14:03] <grrrit-wm> (03CR) 10OliverKeyes: [C: 032 V: 032] Add JS for updating URL [wikimedia/discovery/twilightsparql] - 10https://gerrit.wikimedia.org/r/258996 (https://phabricator.wikimedia.org/T117147) (owner: 10Bearloga) [18:14:08] <grrrit-wm> (03CR) 10Niedzielski: Add article geo-location navigation button (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) (owner: 10Niedzielski) [18:14:13] <wikibugs> 10MediaWiki-DjVu, 10MediaWiki-extensions-MultimediaViewer, 10Internet-Archive, 6Multimedia: Add support for Internet Archive BookReader - https://phabricator.wikimedia.org/T121108#1878347 (10Jdlrobson) p:5Triage>3Low [18:14:16] <grrrit-wm> (03CR) 10OliverKeyes: [C: 032 V: 032] Add JS for updating URL [wikimedia/discovery/rainbow] - 10https://gerrit.wikimedia.org/r/258995 (https://phabricator.wikimedia.org/T117147) (owner: 10Bearloga) [18:14:39] <grrrit-wm> (03CR) 10OliverKeyes: [C: 032 V: 032] Add JS for updating URL [wikimedia/discovery/wetzel] - 10https://gerrit.wikimedia.org/r/258994 (https://phabricator.wikimedia.org/T117147) (owner: 10Bearloga) [18:15:04] <grrrit-wm> (03CR) 10Eevans: handle parent_revision_id on page creation (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) (owner: 10Eevans) [18:15:26] <grrrit-wm> (03PS2) 10Eevans: handle parent_revision_id on page creation [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/258475 (https://phabricator.wikimedia.org/T116786) [18:15:40] <wikibugs> 10MediaWiki-Email, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Adjust datetime in email confirmation email - https://phabricator.wikimedia.org/T29158#1878356 (10Umherirrender) 5Open>3Resolved a:501tonythomas>3Umherirrender [18:15:41] <wikibugs> 10MediaWiki-Email, 7Tracking: ENotif/EConfirm & further enhancements (tracking) - https://phabricator.wikimedia.org/T3932#1878359 (10Umherirrender) [18:15:50] <grrrit-wm> (03CR) 10Bartosz Dziewoński: mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces (034 comments) [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) (owner: 10Bartosz Dziewoński) [18:16:21] <grrrit-wm> (03PS19) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:16:47] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:17:40] <wikibugs> 10MediaWiki-General-or-Unknown, 10MediaWiki-RfCs, 6Analytics-Kanban, 6Discovery, and 7 others: EventBus MVP - https://phabricator.wikimedia.org/T114443#1878366 (10Milimetric) [18:17:44] <grrrit-wm> (03PS20) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:18:03] <Reedy> csteipp: Want me to rebase that for you? [18:18:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:21:40] <grrrit-wm> (03PS1) 10Bearloga: Bump dashboard versions [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/259035 [18:22:24] <grrrit-wm> (03CR) 10Jhobs: [C: 031] "LGTM, Jon has approval from team to self-merge." [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/258200 (https://phabricator.wikimedia.org/T121052) (owner: 10Jdlrobson) [18:22:53] <victorbarbu_> codezee: what about this task? what is wrong with the current version of the banner? [18:22:54] <victorbarbu_> https://codein.withgoogle.com/tasks/5166743517396992/?sp-organization=5505623550590976 [18:22:56] <gcibot> Banners should support extraClassNames parameter for adding extra css classes || 5 days || Code, User Interface || Wikimedia [18:23:26] <victorbarbu_> the text is shown over a translucent black background [18:24:09] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [18:25:57] <wikibugs> 10MediaWiki-extensions-SemanticForms, 5Patch-For-Review: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1878397 (10Yaron_Koren) @saper - Paladox has a patch he's working on, which moves a lot of inline JS into its own files and modules... [18:26:03] <grrrit-wm> (03CR) 10Paladox: "check experimental" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:26:26] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] "Merging as discussed during stand up" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/258200 (https://phabricator.wikimedia.org/T121052) (owner: 10Jdlrobson) [18:27:25] <grrrit-wm> (03PS21) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:27:42] <grrrit-wm> (03CR) 10Paladox: "check experimental" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:27:44] <grrrit-wm> (03Merged) 10jenkins-bot: Release 2.1.0 [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/258200 (https://phabricator.wikimedia.org/T121052) (owner: 10Jdlrobson) [18:27:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:28:07] <grrrit-wm> (03CR) 10OliverKeyes: [C: 032 V: 032] Bump dashboard versions [wikimedia/discovery/dashboard] - 10https://gerrit.wikimedia.org/r/259035 (owner: 10Bearloga) [18:30:49] <codezee> victorbarbu_: text is visible on a dark background, but still an extraClass parameter is needed, in case the banner is dark to change colors and give it a better look [18:30:58] <codezee> victorbarbu_: see https://en.wikivoyage.org/wiki/Vancouver and the dark toc strip [18:31:32] <grrrit-wm> (03PS22) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:31:35] <codezee> if on that banner, colors are flipped, toc could be better, and it'll be the choice of editors to use whichever [18:31:55] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:32:29] <grrrit-wm> (03PS1) 10Niedzielski: Hygiene: use Inkscape for converting icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259036 [18:32:31] <victorbarbu_> but the task comes down to enable adding the possibility to customize by adding extra css classes, doesn't it? [18:32:52] <victorbarbu_> I mean, I don't have to actually implement the css class to switch the colors, do i? [18:33:21] <grrrit-wm> (03CR) 10Niedzielski: "For @mdholloway and @bearND to try. I'm not sure this solves any problems. It _seemed_ to work properly on my system but you'll need inksc" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259036 (owner: 10Niedzielski) [18:34:10] <mdholloway> niedzielski: ^nice, i'll give it a try! [18:35:33] <codezee> victorbarbu_: yes, you have to add the functionality, though it'll be a bonus if you write css [18:35:42] <grrrit-wm> (03PS1) 10Iamanmol: -Replaced $dir with __DIR__ [extensions/examples] - 10https://gerrit.wikimedia.org/r/259037 [18:36:20] <victorbarbu_> I firstly have to understand what colors are switched [18:36:52] <victorbarbu_> Then, I am going to write the CSS as well. Nemo_bis should accept my current task so I can pick this one [18:36:58] <codezee> victorbarbu_: first work on the parameter part and complete it :) If there's time, then write css [18:37:29] <codezee> choosing colors shouldn't be that hard, you can try flipping the existing colors as the task says [18:38:02] <niedzielski> mdholloway: and if you're getting blacked out PNG as the output, it's likely the PNG CRUSH tool, not the exporter [18:38:08] <codezee> victorbarbu_: if you pick this one, remember to install http://mediawiki.org/wiki/Extension:WikidataPageBanner [18:39:48] <victorbarbu_> I have already installed it. I've started working on it already [18:40:54] * Nemo_bis feels called [18:41:40] <wikibugs> 10Reading-Web: Set up metrics for Time on Site - https://phabricator.wikimedia.org/T119352#1878464 (10Milimetric) [18:41:41] <grrrit-wm> (03PS4) 10DCausse: [WIP] Some refactoring of the suggester [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [18:42:15] <grrrit-wm> (03PS1) 10Legoktm: Add missing @throws tag and change Exception subclass being thrown [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259040 [18:42:47] <victorbarbu_> Nemo_bis: well, you should :)) [18:43:14] <IoannisKydonis> Nemo_bis: how can i download a php file in order to edit it? [18:43:46] <grrrit-wm> (03CR) 10Nemo bis: "I think there is a recent open report which asks something similar to this (namely, better alignment between the various parts of each lin" [core] - 10https://gerrit.wikimedia.org/r/258897 (https://phabricator.wikimedia.org/T121389) (owner: 10Victorbarbu) [18:44:58] <Nemo_bis> IoannisKydonis: https://www.mediawiki.org/wiki/Download_from_Git [18:46:15] <grrrit-wm> (03PS23) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:46:43] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:47:06] <grrrit-wm> (03CR) 10DCausse: "Moved the variants fallback code into CompletionSuggester to run only one request as Erik suggested, seems to work but I have to write tes" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [18:48:33] <grrrit-wm> (03PS3) 10Niedzielski: Hygiene: reorder methods to match interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258638 [18:48:37] <grrrit-wm> (03CR) 10Niedzielski: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258638 (owner: 10Niedzielski) [18:48:55] <grrrit-wm> (03PS3) 10Niedzielski: Hygiene: consolidate PageLoadStrategy init methods [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 [18:49:03] <grrrit-wm> (03CR) 10Niedzielski: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 (owner: 10Niedzielski) [18:49:29] <grrrit-wm> (03PS2) 10Umherirrender: Show user names as subpages of special pages in autocomplete search [core] - 10https://gerrit.wikimedia.org/r/256745 [18:50:25] <grrrit-wm> (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comments" [core] - 10https://gerrit.wikimedia.org/r/256745 (owner: 10Umherirrender) [18:50:28] <wikibugs> 6Developer-Relations, 3DevRel-December-2015: Tech Talk: Secure Coding For MediaWiki Developers - https://phabricator.wikimedia.org/T119955#1878525 (10dpatrick) Slides have been uploaded at https://commons.wikimedia.org/wiki/File:Secure_Coding_for_MediaWiki_Developers.pdf [18:50:29] <wikibugs> 6Discovery, 10Wikimedia-Portals: Disable search box A/B test on or after 2015-12-14 - https://phabricator.wikimedia.org/T121425#1878526 (10Ironholds) 3NEW [18:50:35] <grrrit-wm> (03CR) 10Umherirrender: Show user names as subpages of special pages in autocomplete search (032 comments) [core] - 10https://gerrit.wikimedia.org/r/256745 (owner: 10Umherirrender) [18:50:41] <grrrit-wm> (03PS3) 10Umherirrender: Show user names as subpages of special pages in autocomplete search [core] - 10https://gerrit.wikimedia.org/r/256745 [18:52:32] <grrrit-wm> (03PS24) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:53:01] <grrrit-wm> (03CR) 10Umherirrender: [C: 032] Remove unused message [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/258775 (owner: 10Raimond Spekking) [18:53:04] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [18:53:20] <grrrit-wm> (03Merged) 10jenkins-bot: Remove unused message [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/258775 (owner: 10Raimond Spekking) [18:53:41] <grrrit-wm> (03CR) 10Victorbarbu: "@Reedy created a report on Phabricator (https://phabricator.wikimedia.org/T121389) if this is what you mean. The report was created after " [core] - 10https://gerrit.wikimedia.org/r/258897 (https://phabricator.wikimedia.org/T121389) (owner: 10Victorbarbu) [18:54:02] <grrrit-wm> (03PS25) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 [18:56:18] <grrrit-wm> (03PS5) 10Bartosz Dziewoński: mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) [18:58:39] <grrrit-wm> (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/frozen_index_api.feature:30 features/suggest_api.feature:72:73" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [18:59:08] <victorbarbu_> Thank you Nemo_bis [18:59:15] <victorbarbu_> Guys, please comment on this https://phabricator.wikimedia.org/T110904#1878549 [19:00:03] <grrrit-wm> (03CR) 10Gergő Tisza: "Not sure about {{notranslate}}. Isn't "--" language-specific? Hungarian uses an en dash for quotations, for example (which is what prompte" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:00:05] <wikibugs> 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1878553 (10kaldari) @Legoktm: The idea of storing asses... [19:03:50] <grrrit-wm> (03CR) 10Jforrester: "> Isn't "--" language-specific?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:04:31] <grrrit-wm> (03PS1) 10Umherirrender: Add release notes for removed function and class [core] - 10https://gerrit.wikimedia.org/r/259044 [19:04:59] <grrrit-wm> (03CR) 10Umherirrender: "Release notes with Ib5359ee50e42f68e8d1985476c5c2d8146a2d8d5" [core] - 10https://gerrit.wikimedia.org/r/256033 (owner: 10Umherirrender) [19:05:18] <grrrit-wm> (03CR) 10Umherirrender: "Release notes with Ib5359ee50e42f68e8d1985476c5c2d8146a2d8d5" [core] - 10https://gerrit.wikimedia.org/r/258895 (owner: 10Ori.livneh) [19:05:23] <grrrit-wm> (03CR) 10Umherirrender: "Release notes with Ib5359ee50e42f68e8d1985476c5c2d8146a2d8d5" [core] - 10https://gerrit.wikimedia.org/r/258894 (owner: 10Ori.livneh) [19:05:29] <grrrit-wm> (03CR) 10Umherirrender: "Release notes with Ib5359ee50e42f68e8d1985476c5c2d8146a2d8d5" [core] - 10https://gerrit.wikimedia.org/r/258893 (owner: 10Ori.livneh) [19:05:34] <grrrit-wm> (03CR) 10Umherirrender: "Release notes with Ib5359ee50e42f68e8d1985476c5c2d8146a2d8d5" [core] - 10https://gerrit.wikimedia.org/r/258892 (owner: 10Ori.livneh) [19:05:41] <grrrit-wm> (03CR) 10Umherirrender: "Release notes with Ib5359ee50e42f68e8d1985476c5c2d8146a2d8d5" [core] - 10https://gerrit.wikimedia.org/r/257000 (owner: 10Ori.livneh) [19:07:06] <victorbarbu_> How can I address locally stored images in a Wiki page? [19:07:51] <grrrit-wm> (03CR) 10Umherirrender: "Release Notes were fixed with Ia0280d23674ace1ac33aa561b06ee73cab865b29" [core] - 10https://gerrit.wikimedia.org/r/257206 (owner: 10Krinkle) [19:08:09] <victorbarbu_> I saved the image in /mediawiki/images [19:08:47] <grrrit-wm> (03CR) 10Gergő Tisza: "In that case, why not make ~~~~ the default? A bot can create the MediaWiki pages on the existing wikis to avoid surprises." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:10:00] <codezee> victorbarbu_: you use [[File_name.jpg]], but for WikidataPageBanner example see https://www.mediawiki.org/wiki/Extension:WikidataPageBanner#Examples [19:10:22] <wikibugs> 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: Get ContentTranslation to translate all links inside tables - https://phabricator.wikimedia.org/T89951#1878582 (10CennoxX) [19:10:33] <victorbarbu_> codezee: seems like it does not find the image [19:10:50] <codezee> victorbarbu_: did you use correct image name? [19:11:05] <codezee> victorbarbu_: have you uploaded the image first? [19:11:05] <grrrit-wm> (03PS1) 10Paladox: Fix jenkins tests [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259045 [19:11:20] <victorbarbu_> codezee: hmmm upload upload upload [19:11:29] <codezee> victorbarbu_: goto the upload link in the sidebar [19:11:40] <codezee> first upload, then use :) [19:11:59] <victorbarbu_> codezee: I am stupid [19:12:53] <grrrit-wm> (03CR) 10Paladox: "check experimental" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259045 (owner: 10Paladox) [19:13:17] <grrrit-wm> (03PS1) 10Niedzielski: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259046 [19:13:59] <wikibugs> 4(no projects): #mediawiki-core - search results show "\n" at the bottom of the page - https://phabricator.wikimedia.org/T121373#1878600 (10Umherirrender) [19:15:23] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Astropay, 10Fundraising-Backlog, 7FR-Astropay, and 2 others: AstroPay donors all sent to fail page - https://phabricator.wikimedia.org/T108059#1878605 (10DStrine) [19:15:52] <grrrit-wm> (03PS1) 10Paladox: Update Xapian class files to 1.2.21 [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259047 [19:16:15] <wikibugs> 7FR-Astropay: Donate by Credit Card in Argentina - https://phabricator.wikimedia.org/T98221#1878663 (10DStrine) [19:16:16] <wikibugs> 7FR-Astropay: Donate by credit/debit card in Mexico - https://phabricator.wikimedia.org/T98218#1878665 (10DStrine) [19:16:18] <wikibugs> 7FR-Astropay: Donate by Boletos in Brazil - https://phabricator.wikimedia.org/T98215#1878666 (10DStrine) [19:16:20] <wikibugs> 7FR-Astropay: Donate by Cash in Mexico - https://phabricator.wikimedia.org/T98219#1878664 (10DStrine) [19:16:37] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update Xapian class files to 1.2.21 [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259047 (owner: 10Paladox) [19:17:47] <grrrit-wm> (03CR) 10Sniedzielski: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259046 (owner: 10Niedzielski) [19:19:44] <grrrit-wm> (03Abandoned) 10Paladox: Fix jenkins tests failing [extensions/Offline] - 10https://gerrit.wikimedia.org/r/259002 (owner: 10Paladox) [19:21:37] <grrrit-wm> (03CR) 10Paladox: "Which file would I need to change in mediawiki core to support this change." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:21:51] <grrrit-wm> (03PS1) 10BearND: Make EditTaskTest more reliable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259048 (https://phabricator.wikimedia.org/T120035) [19:21:53] <grrrit-wm> (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259046 (owner: 10Niedzielski) [19:22:34] <wikibugs> 10MediaWiki-extensions-OAuth, 10DBA, 6Reading-Infrastructure-Team, 7Schema-change: Create oauth_registered_consumer.oarc_owner_only column on metawiki - https://phabricator.wikimedia.org/T121335#1878693 (10Tgr) >>! In T121335#1877274, @jcrespo wrote: > You cannot expect to have my time right away when othe... [19:26:18] <grrrit-wm> (03CR) 10Gergő Tisza: "includes/EditPage.php probably. You can see the core editor if you disable "Enable enhanced editing toolbar" under the Editing tab of your" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:29:17] <grrrit-wm> (03CR) 10MarkTraceur: "Patch nearly ready, I'm just going to rename it to "mystashedimages"" (0320 comments) [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [19:31:18] <wikibugs> 10CirrusSearch, 6Discovery: Expand cirrus completion suggester api to perform as a generator - https://phabricator.wikimedia.org/T121430#1878729 (10EBernhardson) 3NEW [19:32:45] <grrrit-wm> (03PS1) 10Gergő Tisza: Revert "Add owner-only consumers" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259052 (https://phabricator.wikimedia.org/T87395) [19:33:39] <grrrit-wm> (03PS4) 10MarkTraceur: [WIP] API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) [19:33:45] <grrrit-wm> (03CR) 10Gergő Tisza: [C: 032] Revert "Add owner-only consumers" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259052 (https://phabricator.wikimedia.org/T87395) (owner: 10Gergő Tisza) [19:34:15] <grrrit-wm> (03PS69) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [19:34:23] <IoannisKydonis> Nemo_bis: What is documentation in php? [19:34:42] <grrrit-wm> (03Merged) 10jenkins-bot: Revert "Add owner-only consumers" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259052 (https://phabricator.wikimedia.org/T87395) (owner: 10Gergő Tisza) [19:34:53] <wikibugs> 4(no projects): maps-wma1 instance unresponsive (second time in 3 days) - https://phabricator.wikimedia.org/T121431#1878745 (10dschwen) 3NEW [19:35:05] <grrrit-wm> (03CR) 10Qdinar: "conversion tests are passed but i want to add new tests" [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) (owner: 10Qdinar) [19:35:52] <victorbarbu_> codezee: is this how you imagined the banner? http://imgur.com/a/9ow29 [19:36:04] <grrrit-wm> (03PS1) 10OliverKeyes: Replace Python with Hive/R [wikimedia/discovery/golden] - 10https://gerrit.wikimedia.org/r/259054 (https://phabricator.wikimedia.org/T117915) [19:36:20] <grrrit-wm> (03PS2) 10Addshore: Added input box to select the task ID to view [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/259024 (https://phabricator.wikimedia.org/T96411) (owner: 10Mhutti1) [19:36:26] <grrrit-wm> (03CR) 10Addshore: [C: 032] Added input box to select the task ID to view [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/259024 (https://phabricator.wikimedia.org/T96411) (owner: 10Mhutti1) [19:37:06] <grrrit-wm> (03Merged) 10jenkins-bot: Added input box to select the task ID to view [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/259024 (https://phabricator.wikimedia.org/T96411) (owner: 10Mhutti1) [19:37:40] <grrrit-wm> (03PS6) 10Bartosz Dziewoński: mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) [19:38:37] <codezee> victorbarbu_: on a light background, the text should become dark [19:39:06] <codezee> victorbarbu_: I suggest that we can decide color specifications in another task, you implement the parameter as part of this task [19:39:26] <victorbarbu_> ok then! that's what I am doing [19:39:33] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [19:41:03] <wikibugs> 10MediaWiki-ResourceLoader, 6Performance-Team: Add detection for unused @embed data uris in mw.loader.inspect - https://phabricator.wikimedia.org/T121144#1878785 (10Gilles) p:5Triage>3Low [19:41:25] <wikibugs> 4(no projects): Switch zero results rate dashboards over to the new data sources, including automata detection - https://phabricator.wikimedia.org/T121434#1878788 (10Ironholds) 3NEW a:3Ironholds [19:41:33] <wikibugs> 3Discovery-Analysis-Sprint: Switch zero results rate dashboards over to the new data sources, including automata detection - https://phabricator.wikimedia.org/T121434#1878795 (10Ironholds) [19:41:41] <wikibugs> 3Discovery-Analysis-Sprint: Switch zero results rate dashboards over to the new data sources, including automata detection - https://phabricator.wikimedia.org/T121434#1878788 (10Ironholds) [19:45:09] <grrrit-wm> (03PS2) 10AndyTechGuy: Change documentation of formatTimePeriod [core] - 10https://gerrit.wikimedia.org/r/258774 [19:45:44] <wikibugs> 10MediaWiki-ResourceLoader, 6Performance-Team: Evaluate implementing a @push annotation in CSSMin - https://phabricator.wikimedia.org/T120984#1878814 (10Krinkle) p:5Triage>3Low [19:46:48] <grrrit-wm> (03CR) 10Ankitashukla: "@Ankitaa.bhowmick I apologise for mistakenly adding you as a reviewer here. Please feel free to remove yourself." [extensions/examples] - 10https://gerrit.wikimedia.org/r/259037 (owner: 10Iamanmol) [19:48:25] <grrrit-wm> (03CR) 10Ankitashukla: [C: 031] "The code change is meant to remove the discrepancies between Extension:Example and Extension:BoilerPlate , as a part of a GCI 2015 task." [extensions/examples] - 10https://gerrit.wikimedia.org/r/259037 (owner: 10Iamanmol) [19:49:12] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 5Patch-For-Review, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Release 2.1.0 of RelatedArticles - https://phabricator.wikimedia.org/T121052#1878845 (10Jdlrobson) 5Open>3Resolved [19:49:47] <_atg> When adding reviewers, should you ask the person you are adding as a reviewer if they are ok with it first? Or can you just add them? [19:50:16] <Reedy> _atg: It's difficult. The answer is "it depends" [19:50:43] <wikibugs> 10MediaWiki-ResourceLoader, 6Performance-Team: Collect mw.loader.store statistics - https://phabricator.wikimedia.org/T120893#1878857 (10Krinkle) p:5Triage>3Normal [19:51:08] <Reedy> _atg: What are you trying to get reviewed? [19:51:56] <wikibugs> 10MediaWiki-extensions-WikimediaEvents, 6Performance-Team: Convert mw-js-deprecate from EventLogging to Statsv - https://phabricator.wikimedia.org/T120720#1878863 (10Gilles) p:5Triage>3Normal [19:52:11] <_atg> Reedy: A simple documentation change. Its can be found here: https://gerrit.wikimedia.org/r/258774 [19:53:43] <wikibugs> 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1878867 (10Isarra) So why have an extra tool for this at all? [19:53:46] <Nemo_bis> _atg: you can safely add whoever "git blame" says that has added the @todo and the function itself [19:54:11] <Nemo_bis> If they did so many years ago (as usually happens), maybe mention why you added them as they might have forgotten [19:54:32] <Dereckson> _atg: when you're at https://gerrit.wikimedia.org/r/#/c/258774/2/languages/Language.php you see in the right column line 4626? It indicates you added an extraneous space at the end of the line. `git diff` also shows it. [19:55:26] <grrrit-wm> (03CR) 10Dereckson: "Code documentation added is clear." [core] - 10https://gerrit.wikimedia.org/r/258774 (owner: 10AndyTechGuy) [19:56:37] <grrrit-wm> (03PS2) 10Reedy: [WIP] Show password policy on Special:ChangePassword [core] - 10https://gerrit.wikimedia.org/r/259029 (https://phabricator.wikimedia.org/T119583) (owner: 10CSteipp) [19:56:40] <grrrit-wm> (03CR) 10Paladox: "Thanks. Found it. Will upload a patch in sec. Would I put the message in core instead of having it both in core and wikieditor or have bot" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [19:58:25] <_atg> Dereckson: Ok. Ill remove that space now [19:58:35] <grrrit-wm> (03PS1) 10Paladox: Let the signature wikitext be over-ridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) [19:58:59] <grrrit-wm> (03CR) 10Reedy: "PS2 was just a rebase onto master" [core] - 10https://gerrit.wikimedia.org/r/259029 (https://phabricator.wikimedia.org/T119583) (owner: 10CSteipp) [19:59:09] <grrrit-wm> (03PS2) 10Paladox: Let the signature wikitext be over-ridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) [19:59:32] <grrrit-wm> (03PS6) 10Paladox: Let the signature wikitext be over-ridden locally [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [19:59:44] <grrrit-wm> (03PS50) 10Anomie: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) [20:00:00] <wikibugs> 3Google-Code-In-2015: Add vagrent role for Extension:YouTube - https://phabricator.wikimedia.org/T121436#1878883 (10Mhutti1) 3NEW a:3Mhutti1 [20:00:07] <grrrit-wm> (03PS51) 10Anomie: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) [20:00:19] <grrrit-wm> (03PS1) 10Anomie: Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 [20:00:24] <grrrit-wm> (03CR) 10Paladox: "I've uploaded a patch to core for the same change at https://gerrit.wikimedia.org/r/#/c/259061/" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [20:00:45] <grrrit-wm> (03CR) 10Reedy: [C: 032] Change documentation of formatTimePeriod [core] - 10https://gerrit.wikimedia.org/r/258774 (owner: 10AndyTechGuy) [20:00:48] <grrrit-wm> (03PS1) 10Anomie: Move grant and IP restriction logic from OAuth to core [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 [20:00:50] <Reedy> _atg: LGTM [20:00:58] <grrrit-wm> (03PS1) 10Anomie: Prepare for move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 [20:01:01] <grrrit-wm> (03PS1) 10Anomie: Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 [20:01:09] <grrrit-wm> (03PS1) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [20:01:38] <grrrit-wm> (03PS1) 10Anomie: Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 [20:02:21] <wikibugs> 10MediaWiki-ResourceLoader, 6Performance-Team, 7Performance: Analyze the win/loss of stop combining assets with HTTP/2 - https://phabricator.wikimedia.org/T117682#1878904 (10Krinkle) p:5Triage>3High [20:02:52] <grrrit-wm> (03PS1) 10Bartosz Dziewoński: mw.Upload.dialog: Make the dialog higher (600px) [core] - 10https://gerrit.wikimedia.org/r/259068 [20:02:57] <grrrit-wm> (03CR) 10VolkerE: "@Amire80 As there was a change – I268e4a53e28ac – necessary to support footer links merged recently, abstracting the `getLeftNav()` into g" [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/235033 (https://phabricator.wikimedia.org/T110835) (owner: 10Amire80) [20:03:35] <grrrit-wm> (03CR) 10Brian Wolff: "I kind of think that maybe the password policy list should be able to take objects instead of functions. Then each policy object could be " [core] - 10https://gerrit.wikimedia.org/r/259029 (https://phabricator.wikimedia.org/T119583) (owner: 10CSteipp) [20:03:47] <grrrit-wm> (03PS6) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 [20:04:03] <grrrit-wm> (03PS7) 10Bartosz Dziewoński: mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) [20:04:46] <wikibugs> 10Phlogiston: Incremental load option crashes if there is no previous data - https://phabricator.wikimedia.org/T121437#1878913 (10JAufrecht) 3NEW [20:05:03] <wikibugs> 10Phlogiston: Incremental load option crashes if there is no previous data - https://phabricator.wikimedia.org/T121437#1878920 (10JAufrecht) [20:05:11] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Move grant and IP restriction logic from OAuth to core [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 (owner: 10Anomie) [20:06:26] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 (owner: 10Anomie) [20:07:12] <grrrit-wm> (03PS1) 10Mhutti1: Added vagrent role for Extension:YouTube [vagrant] - 10https://gerrit.wikimedia.org/r/259070 (https://phabricator.wikimedia.org/T121436) [20:07:33] <grrrit-wm> (03CR) 10Dbrant: [C: 032] Add article geo-location navigation button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) (owner: 10Niedzielski) [20:07:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Prepare for move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 (owner: 10Anomie) [20:09:13] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Great work. Thank you!" [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) (owner: 10Neonowy) [20:09:38] <grrrit-wm> (03CR) 10Gergő Tisza: "IIRC using the 'sample' key means the inserted code will be selected. You should use the 'open' key instead." [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [20:09:52] <wikibugs> 10Reading-Web: Experiment with serving lower resolution images as the default for all page views - https://phabricator.wikimedia.org/T120875#1878959 (10Jdlrobson) qlow JPEG setting would be a good start yes given the promising results from Tim in https://phabricator.wikimedia.org/T119797#1867024 I don't see why... [20:10:12] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [20:10:23] <grrrit-wm> (03PS3) 10AndyTechGuy: Change documentation of formatTimePeriod [core] - 10https://gerrit.wikimedia.org/r/258774 [20:10:33] <wikibugs> 10Reading-Web: Experiment with serving lower resolution images as the default for all page views - https://phabricator.wikimedia.org/T120875#1878963 (10Jdlrobson) >>! In T120875#1864141, @Bawolff wrote: > umm, what about interactions with parser/varnish cache? I'm not sure that it will be only 5% seeing this. T... [20:10:59] <grrrit-wm> (03CR) 10Jforrester: [C: 032] mw.Upload.dialog: Make the dialog higher (600px) [core] - 10https://gerrit.wikimedia.org/r/259068 (owner: 10Bartosz Dziewoński) [20:11:19] <grrrit-wm> (03PS2) 10Bartosz Dziewoński: mw.Upload.Dialog: Make the dialog higher (600px) [core] - 10https://gerrit.wikimedia.org/r/259068 [20:11:27] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Typo :)" [core] - 10https://gerrit.wikimedia.org/r/259068 (owner: 10Bartosz Dziewoński) [20:12:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [20:13:03] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Change documentation of formatTimePeriod [core] - 10https://gerrit.wikimedia.org/r/258774 (owner: 10AndyTechGuy) [20:13:19] <wikibugs> 10MediaWiki-Database, 6Performance-Team, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8), 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Migrate extensions using begin/commit to startAtomic/endAtomic as needed - https://phabricator.wikimedia.org/T120791#1878973 (10aaron) [20:13:31] <wikibugs> 10MediaWiki-Database, 6Performance-Team, 5Patch-For-Review: Migrate WikiPage::doEditContent to using startAtomic/endAtomic - https://phabricator.wikimedia.org/T120718#1878974 (10aaron) [20:13:32] <grrrit-wm> (03Merged) 10jenkins-bot: Add article geo-location navigation button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258520 (https://phabricator.wikimedia.org/T114523) (owner: 10Niedzielski) [20:13:35] <_atg> I removed the whitespace from the patch [20:15:42] <wikibugs> 10MediaWiki-extensions-CentralNotice, 6Analytics-Backlog, 10Analytics-EventLogging, 10Traffic, 6operations: Eventlogging should transparently split large event payloads - https://phabricator.wikimedia.org/T114078#1878984 (10Ottomata) Anyone mind if I decline this task? [20:18:38] <grrrit-wm> (03Merged) 10jenkins-bot: Special:Preferences Remove red box in email and changed confirm error to warning [core] - 10https://gerrit.wikimedia.org/r/258917 (https://phabricator.wikimedia.org/T58611) (owner: 10Neonowy) [20:20:18] <wikibugs> 10MediaWiki-Interface, 7Easy, 3Google-Code-In-2015: Email address option in Preferences should not use red box - https://phabricator.wikimedia.org/T58611#1878994 (10matmarex) 5Open>3Resolved a:3Neonowy [20:21:03] <grrrit-wm> (03Merged) 10jenkins-bot: mw.Upload.Dialog: Make the dialog higher (600px) [core] - 10https://gerrit.wikimedia.org/r/259068 (owner: 10Bartosz Dziewoński) [20:23:02] <grrrit-wm> (03CR) 10Bartosz Dziewoński: [C: 032] "Nothing I could complain about :) Thanks for working on this!" [core] - 10https://gerrit.wikimedia.org/r/259015 (https://phabricator.wikimedia.org/T46495) (owner: 10Scimonster) [20:24:17] <grrrit-wm> (03PS1) 10Hashar: browser test: fix logic to find edit action [extensions/Math] - 10https://gerrit.wikimedia.org/r/259075 [20:24:19] <grrrit-wm> (03PS52) 10Anomie: Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) [20:25:53] <grrrit-wm> (03PS2) 10Anomie: Move grant and IP restriction logic from OAuth to core [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 [20:26:40] <grrrit-wm> (03CR) 10Hashar: "Something happened between Dec. 2nd and 3rd and the error message is straightforward:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/259075 (owner: 10Hashar) [20:26:43] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Move grant and IP restriction logic from OAuth to core [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 (owner: 10Anomie) [20:27:15] <IoannisKydonis> Hello. i'm a GCI student. What it means to document something in php? [20:27:45] <grrrit-wm> (03CR) 10Anomie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 (owner: 10Anomie) [20:28:44] <Reedy> IoannisKydonis: Same as any other language [20:28:55] <Reedy> Documenting parameter types. What functions do [20:29:00] <grrrit-wm> (03PS2) 10Anomie: Move grant and IP restriction logic from OAuth to core [core] - 10https://gerrit.wikimedia.org/r/259062 [20:29:00] <Reedy> comments about what blocks of code do [20:29:11] <IoannisKydonis> ok thank you very much [20:29:25] <grrrit-wm> (03CR) 10Anomie: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259063 (owner: 10Anomie) [20:29:29] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] "<youtube>hx27NL_iqEM</youtube>" [vagrant] - 10https://gerrit.wikimedia.org/r/259070 (https://phabricator.wikimedia.org/T121436) (owner: 10Mhutti1) [20:29:39] <victorbarbu_> codezee: do you happen to know the WIkidataPageBanner codebase well? [20:30:01] <codezee> victorbarbu_: yes [20:30:16] <grrrit-wm> (03Merged) 10jenkins-bot: Add case-changing magic words to mw.jqueryMsg [core] - 10https://gerrit.wikimedia.org/r/259015 (https://phabricator.wikimedia.org/T46495) (owner: 10Scimonster) [20:31:14] <victorbarbu_> codezee: I am trying to find out where raw {{PAGEBANNER}} parameters are hooked and parsed, but I simply can't find it. The closest match was addCustomBanner which does not get called... Some hint, please? [20:31:29] <grrrit-wm> (03CR) 10Bartosz Dziewoński: Multimedia cross-wiki upload A/B test (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/258664 (https://phabricator.wikimedia.org/T120867) (owner: 10Bartosz Dziewoński) [20:31:38] <grrrit-wm> (03CR) 10Reedy: "Sounds more OOPsy. Allowing them to self describe. Sounds like it could work better for more complex rules" [core] - 10https://gerrit.wikimedia.org/r/259029 (https://phabricator.wikimedia.org/T119583) (owner: 10CSteipp) [20:32:10] <codezee> victorbarbu_: your guess is correct, parameters are passed to addCustomBanner, that function is actually called by a method in core mediawiki [20:32:21] <codezee> during parsing of wikitext [20:32:23] <wikibugs> 10MediaWiki-Internationalization, 7Easy, 3Google-Code-In-2015, 7I18n, 7JavaScript: Implement lc, lcfirst, uc, and ucfirst magic words in jqueryMsg - https://phabricator.wikimedia.org/T46495#1879021 (10matmarex) 5Open>3Resolved a:3Scimonster [20:32:52] <grrrit-wm> (03PS2) 10Anomie: Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 [20:33:00] <victorbarbu_> look what I did: [20:33:00] <victorbarbu_> wfDebug( 'Entered addCustomBanner' ); [20:33:00] <victorbarbu_> but this does not appea in the debug log, while debug messages from addBanner appear there [20:33:20] <grrrit-wm> (03CR) 10Anomie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [20:33:27] <grrrit-wm> (03PS8) 10Bartosz Dziewoński: mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) [20:33:34] <grrrit-wm> (03PS4) 10Bartosz Dziewoński: Multimedia cross-wiki upload A/B test [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/258664 (https://phabricator.wikimedia.org/T120867) [20:34:26] <victorbarbu_> this is driving me crazy :)) [20:34:47] <grrrit-wm> (03Merged) 10jenkins-bot: Added vagrent role for Extension:YouTube [vagrant] - 10https://gerrit.wikimedia.org/r/259070 (https://phabricator.wikimedia.org/T121436) (owner: 10Mhutti1) [20:35:07] <grrrit-wm> (03PS8) 10Christopher Johnson (WMDE): adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 [20:35:22] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 (owner: 10Anomie) [20:35:46] <codezee> victorbarbu_: add a var_dump('Entered Custombanner') to addCustomBanner beginning, and save the page again, you'll see [20:35:58] <wikibugs> 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1879047 (10Jdforrester-WMF) [20:36:32] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add SessionManager [core] - 10https://gerrit.wikimedia.org/r/243223 (https://phabricator.wikimedia.org/T111296) (owner: 10Anomie) [20:36:33] <codezee> victorbarbu_: you just need to know that when {{PAGEBANNER:...}} is called, it passes the parameters to addCustomBanner which then extracts them using various functions and processes them [20:36:46] <grrrit-wm> (03PS1) 10Dbrant: Fix article and menu bar padding on tablets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259076 [20:37:13] <grrrit-wm> (03PS3) 10Anomie: Add a note to Special:BotPasswords pointing to OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/259067 [20:37:59] <codezee> victorbarbu_: inside that function various parameters are added to $paramsForBannerTemplate array, which get passed to banner.mustache [20:38:00] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Compress graph_specs page property [extensions/Graph] - 10https://gerrit.wikimedia.org/r/255914 (https://phabricator.wikimedia.org/T100942) (owner: 10Yurik) [20:38:04] <grrrit-wm> (03PS2) 10Anomie: Add "bot passwords" [core] - 10https://gerrit.wikimedia.org/r/259066 (https://phabricator.wikimedia.org/T121113) [20:38:41] <victorbarbu_> codezee: I found all the functions that parse the properties. But I couldn't figure out the one that reads them :)) [20:39:00] <victorbarbu_> codezee: and still, the message in your var_dump does not show up anywhere on the page, even with CTRL+F [20:39:15] <grrrit-wm> (03Merged) 10jenkins-bot: Compress graph_specs page property [extensions/Graph] - 10https://gerrit.wikimedia.org/r/255914 (https://phabricator.wikimedia.org/T100942) (owner: 10Yurik) [20:39:38] <grrrit-wm> (03PS2) 10Yurik: Bumped Vega lib, don't send Treat-As-Untrusted [extensions/Graph] - 10https://gerrit.wikimedia.org/r/258725 [20:40:17] <victorbarbu_> codezee: which is kind of strange and frustrating :( [20:42:27] <grrrit-wm> (03CR) 10Reedy: "Any particular reason why?" [core] - 10https://gerrit.wikimedia.org/r/259023 (owner: 10Gerrit Patch Uploader) [20:42:30] <codezee> victorbarbu_: you don't need the function that reads them, that resides in core mediawiki, also show me your vagrant localsettings in a paste [20:43:46] <victorbarbu_> # End of automatically generated settings. [20:43:46] <victorbarbu_> # Add more configuration options below. [20:43:47] <victorbarbu_> include_once '/vagrant/LocalSettings.php'; [20:43:47] <victorbarbu_> wfLoadExtension( 'WikidataPageBanner' ); [20:43:47] <victorbarbu_> $wgDebugToolbar = true; [20:43:48] <victorbarbu_> $wgShowDebug = true; [20:43:48] <victorbarbu_> $wgDevelopmentWarnings = true; [20:44:07] <codezee> victorbarbu_: use http://dpaste.de/ [20:44:29] <victorbarbu_> codezee: do you need the entire file [20:44:31] <victorbarbu_> ? [20:44:33] <grrrit-wm> (03CR) 10Reedy: "Have you implemented example/test dependencies on any extension?" [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [20:44:55] <codezee> victorbarbu_: just copy all the text using ctrl+A and paste it on the link above [20:45:03] <victorbarbu_> codezee: https://dpaste.de/EOh5 there you go [20:46:36] <codezee> victorbarbu_: LocalSettings.php in the outer vagrant directory [20:46:59] <wikibugs> 10MediaWiki-Uploading, 6Commons, 6Multimedia: Provide a copyright click-through guide in the cross-wiki upload tool - https://phabricator.wikimedia.org/T121021#1879075 (10matmarex) The complete designs for ideas A, D, E can be seen at T120867#1874985 now. [20:47:31] <victorbarbu_> codezee: ok, sorry for the misunderstanding. https://dpaste.de/UdVk [20:48:02] <grrrit-wm> (03PS1) 10Dbrant: Add long-press hints for article menu buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 [20:49:39] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add long-press hints for article menu buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 (owner: 10Dbrant) [20:49:40] <codezee> victorbarbu_: can you add a custom banner? [20:51:03] <victorbarbu_> codezee: what's the difference from {{PAGEBANNER:image.jpeg|toc=yes|extraClass=invert}} ? [20:51:43] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 7FR-GlobalCollect, 3Fundraising Sprint Zapp: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1879087 (10awight) a:5awight>3None [20:51:44] <codezee> victorbarbu_: difference from? [20:52:10] <grrrit-wm> (03CR) 10Niedzielski: [C: 031] Fix article and menu bar padding on tablets. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259076 (owner: 10Dbrant) [20:52:25] <grrrit-wm> (03CR) 10Fomafix: "'en' is a static value. wfGetLangObj( 'en' ) does some unnecessary checks and calls Language::factory( 'en' )." [core] - 10https://gerrit.wikimedia.org/r/259023 (owner: 10Gerrit Patch Uploader) [20:52:28] <grrrit-wm> (03CR) 10Sniedzielski: [C: 032] Fix article and menu bar padding on tablets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259076 (owner: 10Dbrant) [20:52:29] <codezee> victorbarbu_: a parameter thats not valid will should just throw a warning [20:53:03] <victorbarbu_> codezee: I added extraClass to $allowedParameters [20:53:27] <victorbarbu_> codezee: by "difference from" I meant, is that snippet I wrote a custom banner? what should a custom banner look like? [20:53:50] <codezee> victorbarbu_: yes thats correct, and I suppose you're not able to see it? [20:54:41] <codezee> add this line to your localsettings -> $wgWPBNamespaces = array( NS_MAIN, NS_USER ); [20:55:18] <victorbarbu_> the localsettings in the outer vagrant directory? [20:55:23] <codezee> victorbarbu_: any one [20:55:39] <grrrit-wm> (03Merged) 10jenkins-bot: Fix article and menu bar padding on tablets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259076 (owner: 10Dbrant) [20:55:44] <victorbarbu_> codezee: look. this snippet {{PAGEBANNER:CanyonWide.jpeg|extraClass=invert|}} looks like this http://imgur.com/MxCKOkd [20:56:31] <victorbarbu_> codezee: woow [20:56:37] <codezee> victorbarbu_: thats correct [20:56:41] <codezee> :) [20:56:41] <victorbarbu_> codezee: after adding that line, it shows the `entered` [20:57:16] <grrrit-wm> (03PS9) 10Bartosz Dziewoński: mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) [20:57:17] <codezee> you missed that configuration option, remember to carefully read the instructions in installation :) [20:58:24] <codezee> victorbarbu_: just for your curiosity, the parameters that you pass to {{PAGEBANNER}} get stored in that array and finally get passed to banner template in template/banner.mustache, have a look at that [20:58:45] <victorbarbu_> codezee: I already learned that :) [20:58:53] <codezee> nice! [20:59:17] <codezee> the task should not be difficult now [20:59:18] <victorbarbu_> codezee: the banner was visible even before changing the local settings, but [20:59:46] <victorbarbu_> but nothing, forget that "but" :)) [21:00:35] <grrrit-wm> (03PS2) 10Dbrant: Add long-press hints for article menu buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 [21:00:35] <victorbarbu_> codezee: the task was not difficult from the beginning, but I couldn't find that little thing :) You saved me [21:01:01] <wikibugs> 6Design-Research, 5Design Research and product team collaboration: Create draft protocol for contextual inquiry in Mexico {gecko} - https://phabricator.wikimedia.org/T121446#1879112 (10aripstra) 3NEW a:3aripstra [21:01:22] <wikibugs> 10MediaWiki-extensions-RelatedArticles: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1879120 (10Wittylama) As requested over on T116676, I've now added my various comments on the talkpage of the project: https://www.mediawiki.org/wiki/Talk:Reading/Web/Pro... [21:01:39] <wikibugs> 10MediaWiki-Vagrant, 10Math, 10Mathoid, 6Services: Update the Math and Mathoid roles - https://phabricator.wikimedia.org/T121447#1879121 (10mobrovac) 3NEW [21:03:00] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] mw.ForeignStructuredUpload.BookletLayout: A/B test of 4 different interfaces [core] - 10https://gerrit.wikimedia.org/r/258416 (https://phabricator.wikimedia.org/T120867) (owner: 10Bartosz Dziewoński) [21:06:06] <MatmaRex> ori: do you think https://gerrit.wikimedia.org/r/#/c/258416/ (the upload A/B test code) is good enough to merge it? i replied to your comments [21:06:33] <wikibugs> 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint Zapp: Impressions are looking weird for mobile campaign - https://phabricator.wikimedia.org/T121042#1879140 (10DStrine) a:3AndyRussG [21:09:32] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1879156 (10Arkanosis) >>! In T108811#1877832, @Arkanosis wrote: > I've not experienced this issue with a fresh install of the 1.26 release with the DismissableSiteNotice extension I... [21:09:51] <grrrit-wm> (03PS3) 10Paladox: Let the signature wikitext be over-ridden locally [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) [21:10:17] <grrrit-wm> (03CR) 10Dbrant: [C: 032] Hygiene: reorder methods to match interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258638 (owner: 10Niedzielski) [21:10:56] <grrrit-wm> (03CR) 10Yurik: Allow JSON values to be included in the API results (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258196 (https://phabricator.wikimedia.org/T120380) (owner: 10Yurik) [21:11:01] <grrrit-wm> (03CR) 10Paladox: "Ok done." [core] - 10https://gerrit.wikimedia.org/r/259061 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [21:11:06] <yurik> anomie, could you clarify https://gerrit.wikimedia.org/r/#/c/258196/ [21:11:13] <grrrit-wm> (03PS1) 10Florianschmidtwelzow: Add dependency to GoogleAPIClient [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/259142 [21:11:45] <victorbarbu_> codezee: If I refresh it a couple of times, the `entered` message does not appear anymore. BUggy thing [21:12:02] <grrrit-wm> (03CR) 10Florianschmidtwelzow: "@Reedy: not yet, bur thanks for this idea :)" [core] - 10https://gerrit.wikimedia.org/r/250060 (https://phabricator.wikimedia.org/T117277) (owner: 10Florianschmidtwelzow) [21:12:38] <grrrit-wm> (03PS7) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 [21:12:41] <grrrit-wm> (03PS76) 10Catrope: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [21:13:03] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: reorder methods to match interface [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/258638 (owner: 10Niedzielski) [21:13:27] <Hydronium> victorbarbu_: they left [21:13:43] <victorbarbu_> I know now [21:14:14] <Hydronium> but what's your issue? maybe i can help [21:14:30] * Hydronium ensures sarcasm is set to low [21:14:35] <AaronSchulz> legoktm: https://gerrit.wikimedia.org/r/#/c/258747/1 [21:14:37] <grrrit-wm> (03CR) 10Sniedzielski: [C: 032] Make EditTaskTest more reliable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259048 (https://phabricator.wikimedia.org/T120035) (owner: 10BearND) [21:15:58] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [21:16:16] <wikibugs> 10MediaWiki-skins-Blueprint: Helper functions don't work because core doesn't support this feature. - https://phabricator.wikimedia.org/T120163#1879172 (10Jdlrobson) MediaWiki purposely does not support helpers as Mustache doesn't support helpers. Long discussion [[ https://www.mediawiki.org/wiki/Requests_for_co... [21:16:27] <victorbarbu_> Well, I am working on WikidataPageBanner right now. The parameters for {{PAGEBANNER}} are parsed in addCustomBanner function. I added a log there with the message "entered". The function should be always called. It is called from time to time, literally...I think there is a bug in vagrant [21:17:19] <grrrit-wm> (03Merged) 10jenkins-bot: Make EditTaskTest more reliable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259048 (https://phabricator.wikimedia.org/T120035) (owner: 10BearND) [21:17:38] <grrrit-wm> (03CR) 10Mattflaschen: "Normally we link to their Special:Contributions page instead of user page for anons." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 (owner: 10Mooeypoo) [21:17:43] <grrrit-wm> (03PS5) 10Florianschmidtwelzow: Convert MobileFrontend to extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/257438 (https://phabricator.wikimedia.org/T88057) [21:17:57] <grrrit-wm> (03CR) 10Florianschmidtwelzow: "PS5 is a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/257438 (https://phabricator.wikimedia.org/T88057) (owner: 10Florianschmidtwelzow) [21:18:33] <grrrit-wm> (03CR) 10Christopher Johnson (WMDE): "Option for all results added. Moved datatable selector from api to app.js. table config is still done in api. added bootstrap styling." [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [21:18:46] <grrrit-wm> (03CR) 10Christopher Johnson (WMDE): adds dataTables (033 comments) [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [21:18:53] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 7FR-Adyen, 3Fundraising Sprint Zapp: Fix CSS on Adyen form - https://phabricator.wikimedia.org/T117897#1879185 (10cwdent) 5Open>3Resolved [21:18:57] <wikibugs> 10Hovercards, 5Patch-For-Review: Popups doesn't work on a fresh install - https://phabricator.wikimedia.org/T96698#1879187 (10Jdlrobson) 5Open>3stalled [21:19:24] <wikibugs> 3Google-Code-In-2015, 5Patch-For-Review: Add vagrent role for Extension:YouTube - https://phabricator.wikimedia.org/T121436#1879189 (10Mhutti1) 5Open>3Resolved [21:19:52] <grrrit-wm> (03PS1) 10Gilles: Initial commit [thumbor/svg-engine] - 10https://gerrit.wikimedia.org/r/259144 [21:20:04] <grrrit-wm> (03CR) 10Gilles: [C: 032 V: 032] Initial commit [thumbor/svg-engine] - 10https://gerrit.wikimedia.org/r/259144 (owner: 10Gilles) [21:20:13] <wikibugs> 10MediaWiki-ResourceLoader, 10MediaWiki-Unit-tests, 5Patch-For-Review: ResourcesTest::testFileExistence does not ignore anchor in url - https://phabricator.wikimedia.org/T115436#1879192 (10Krinkle) p:5Triage>3Low [21:20:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Convert MobileFrontend to extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/257438 (https://phabricator.wikimedia.org/T88057) (owner: 10Florianschmidtwelzow) [21:20:58] <wikibugs> 3Google-Code-In-2015, 5Patch-For-Review: Add vagrant role for Extension:YouTube - https://phabricator.wikimedia.org/T121436#1879194 (10Aklapper) [21:21:08] <grrrit-wm> (03CR) 10Dbrant: [C: 032] Hygiene: consolidate PageLoadStrategy init methods [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 (owner: 10Niedzielski) [21:21:13] <grrrit-wm> (03PS1) 10JGirault: Remove first a/b test [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/259145 [21:21:49] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 5Patch-For-Review, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: iOS 9: related articles stop showing on subsequent pages if you click on one of them - https://phabricator.wikimedia.org/T121263#1879197 (10Jdlrobson) 5Open>3Resolved Confirmed fixed b... [21:22:08] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 7Easy, 5Patch-For-Review, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): RelatedArticles shows on editor - https://phabricator.wikimedia.org/T120735#1879199 (10Aklapper) [21:22:32] <wikibugs> 10MobileFrontend, 5Patch-For-Review: Replace mobile.toast with mw.notification? - https://phabricator.wikimedia.org/T116555#1879200 (10Jdlrobson) a:3Sumit [21:22:48] <wikibugs> 10MobileFrontend, 7Easy, 5Patch-For-Review, 3Reading Web Sprint 61 - Cold Hard Cache, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Watchlist shouldn't re-render - https://phabricator.wikimedia.org/T113667#1879202 (10Aklapper) [21:23:13] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: consolidate PageLoadStrategy init methods [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259009 (owner: 10Niedzielski) [21:23:14] <Hydronium> victorbarbu_: maybe it is a cache thing? [21:23:59] <grrrit-wm> (03PS1) 10Gilles: SVG engine [thumbor/svg-engine] - 10https://gerrit.wikimedia.org/r/259147 (https://phabricator.wikimedia.org/T120204) [21:24:10] <victorbarbu_> Hydronium: I have "DIsabled cache" checked in chrome and I manually cleared the cache like 3 times [21:24:17] <victorbarbu_> now the debug bar won't appear as well... [21:24:20] <Hydronium> Try action=purge [21:25:01] * Hydronium brb [21:25:03] <victorbarbu_> Hydronium: where ? [21:25:32] <Hydronium> nevermind, I don't think action=purge has anything to do with your extension [21:25:43] <Hydronium> oh wait [21:25:48] <Hydronium> it's a page template, right:/ [21:25:48] <Hydronium> ? [21:25:50] <Hydronium> https://www.mediawiki.org/wiki/Manual:Purge [21:28:25] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] "When anonymous and click watch star I no longer see a drawer. Seems to be caused by this patchset." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258969 (https://phabricator.wikimedia.org/T116555) (owner: 10Sumit) [21:29:22] * FlorianSW says to himself: "Yes, you don't need to test your change, anything will work fine." Jenkins replies: "5 of 7 test fails". gj [21:29:51] <grrrit-wm> (03PS6) 10Florianschmidtwelzow: Convert MobileFrontend to extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/257438 (https://phabricator.wikimedia.org/T88057) [21:30:02] <Reedy> FlorianSW: rechedk and hope it wasn't you [21:30:03] <Reedy> xD [21:30:13] <FlorianSW> Reedy, or use --force? [21:30:13] <grrrit-wm> (03CR) 10Jdlrobson: [C: 031] "Have not tested yet but does look like it doesn't impact the normal common use case" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258476 (https://phabricator.wikimedia.org/T117412) (owner: 10Sumit) [21:30:28] <FlorianSW> :D [21:31:55] <wikibugs> 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, and 2 others: Consider removing the extra asterisk for the required parameters inside the template dialog - https://phabricator.wikimedia.org/T107544#1879212 (10AndyTechGuy) a:3AndyTechGuy I claimed this task on the GC... [21:33:09] <grrrit-wm> (03PS3) 10Catrope: Add cross-wiki as a beta feature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256138 (https://phabricator.wikimedia.org/T114237) (owner: 10Mooeypoo) [21:34:24] <grrrit-wm> (03PS8) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 [21:36:50] <grrrit-wm> (03CR) 10EBernhardson: [C: 032] "Some more refactors are in order, but this is a large patch already. More work inside it will just be hard to follow. I've tested this wit" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) (owner: 10DCausse) [21:38:21] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [21:38:33] <wikibugs> 10MediaWiki-extensions-OAuth, 10DBA, 6Reading-Infrastructure-Team, 7Blocked-on-schema-change, 7Schema-change: Create oauth_registered_consumer.oarc_owner_only column on metawiki - https://phabricator.wikimedia.org/T121335#1879227 (10bd808) [21:39:41] <grrrit-wm> (03CR) 10Catrope: "PS73-76:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [21:41:06] <grrrit-wm> (03Merged) 10jenkins-bot: Add Completion Suggester as a Beta Feature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/237693 (https://phabricator.wikimedia.org/T112028) (owner: 10DCausse) [21:41:14] <grrrit-wm> (03CR) 10BearND: "On my Mac I had to install Inkscape using brew as well. I've tried setting the PATH env. variable but that then only caused the GUI to pop" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259036 (owner: 10Niedzielski) [21:43:47] <Hydronium> the secret is to praise the almighty Jenkins and win His favour [21:44:16] <grrrit-wm> (03CR) 10Catrope: [C: 032] Add missing @throws tag and change Exception subclass being thrown [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259040 (owner: 10Legoktm) [21:44:56] <grrrit-wm> (03CR) 10Mholloway: "Using Inkscape with this script actually fails with errors on both of my OS X laptops (a different error for each laptop). Brew update/up" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259036 (owner: 10Niedzielski) [21:45:26] <wikibugs> 3Mobile-Content-Service, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8), 5WMF-deploy-2015-12-15_(1.27.0-wmf.9), and 2 others: Rollout RESTBase usage to Android Beta app - https://phabricator.wikimedia.org/T118965#1879234 (10bearND) 55% roll-out deployed this morning during SWAT; had some issues g... [21:45:26] <grrrit-wm> (03Abandoned) 10Niedzielski: Hygiene: use Inkscape for converting icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259036 (owner: 10Niedzielski) [21:45:44] <wikibugs> 3Reading Web Sprint 60 - Boom Headshot!, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: Move hamburger code back to the top of the page - https://phabricator.wikimedia.org/T118326#1879235 (10JKatzWMF) @jdlrobson @klans_wmf this task just dropped off the map. I don't know how. moving it to cur... [21:45:56] <grrrit-wm> (03CR) 10Catrope: [C: 032] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [21:46:32] <grrrit-wm> (03CR) 10Mholloway: "PS -- I installed Inkscape and XQuartz with disk images, not Homebrew." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259036 (owner: 10Niedzielski) [21:48:04] <grrrit-wm> (03Merged) 10jenkins-bot: Add missing @throws tag and change Exception subclass being thrown [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259040 (owner: 10Legoktm) [21:48:24] <grrrit-wm> (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "features/suggest_api.feature:72:73" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [21:49:19] <grrrit-wm> (03Merged) 10jenkins-bot: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [21:54:22] <grrrit-wm> (03CR) 10Mooeypoo: Add OOUI widgets for cross-wiki bundled notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [21:55:59] <grrrit-wm> (03CR) 10Anomie: [WIP] API to fetch data about stashed images (032 comments) [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [21:56:13] <victorbarbu_> how can I find @codezee nick on gerrit? the name does not appear as a hint when I try to add them as reviewer [21:56:31] <grrrit-wm> (03CR) 10Anomie: "No idea why I suggested "mystashedimages" instead of "mystashedfiles". But you forgot to add the actual file in PS4 ;)" [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [21:56:41] <grrrit-wm> (03CR) 10Anomie: [C: 04-1] [WIP] API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [21:57:36] <Hydronium> victorbarbu_: try "Sumit <asthana.sumit23@gmail.com>" [21:57:41] <Hydronium> https://www.mediawiki.org/wiki/User:Sumit.iitp [21:57:58] <Hydronium> "IRC Nick: codezee" [21:57:59] <wikibugs> 10MediaWiki-extensions-DismissableSiteNotice: DismissableSiteNotice uses document.write - https://phabricator.wikimedia.org/T108811#1879255 (10Arkanosis) >>! In T108811#1877912, @Arkanosis wrote: > I guess the “quick fix” for now is to replace the current > $notice = Html::inlineScript( Xml::encodeJsCall( 'd... [21:59:35] <grrrit-wm> (03PS3) 10Dbrant: Add long-press hints for article menu buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 [21:59:41] <wikibugs> 7Design, 10Design Research Archive: Evaluate usability of the non-MediaWiki 404 page - https://phabricator.wikimedia.org/T110376#1879257 (10aripstra) @ori is this completed, or are you waiting on UI Standardization team for something? We need to close this ticket as the design research part is complete. Can yo... [22:02:51] <wikibugs> 10Design Research Archive, 5Persona research: Iterate Pragmatic Personas using feedback from the workshop {whale} - https://phabricator.wikimedia.org/T104464#1879267 (10aripstra) Iteration complete: See deck at bottom of this page : https://www.mediawiki.org/wiki/Personas_for_product_development [22:04:47] <wikibugs> 7Design, 10Design Research Archive: Evaluate usability of the non-MediaWiki 404 page - https://phabricator.wikimedia.org/T110376#1879271 (10ori) It's blocked on @Volker_E. I think we should keep this open until it is launched. [22:05:37] <grrrit-wm> (03CR) 10Physikerwelt: [C: 031] browser test: fix logic to find edit action [extensions/Math] - 10https://gerrit.wikimedia.org/r/259075 (owner: 10Hashar) [22:07:26] <grrrit-wm> (03CR) 10Physikerwelt: [C: 031] "Is there a simple way to test this in labs?" [vagrant] - 10https://gerrit.wikimedia.org/r/257259 (https://phabricator.wikimedia.org/T119990) (owner: 10BryanDavis) [22:08:38] <grrrit-wm> (03PS7) 10Mattflaschen: Hooks to extend pages retrieval and deletion [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/255981 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [22:10:23] <wikibugs> 6Discovery, 10Wikimedia-Portals, 3Discovery-UX-Sprint: [PAB1] Disable search box A/B test on or after 2015-12-14 - https://phabricator.wikimedia.org/T121425#1879280 (10JGirault) a:3JGirault [22:10:52] <wikibugs> 6Discovery, 10Wikimedia-Portals, 3Discovery-UX-Sprint: [PAB1] Disable search box A/B test on or after 2015-12-14 - https://phabricator.wikimedia.org/T121425#1878526 (10JGirault) [22:10:53] <wikibugs> 6Discovery, 3Discovery-UX-Sprint, 7Epic: EPIC: [Portal A/B test 1]: Change the size of search text field and search button on Wikipedia.org - https://phabricator.wikimedia.org/T112173#1879286 (10JGirault) [22:11:22] <grrrit-wm> (03PS2) 10JGirault: Remove first a/b test [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/259145 (https://phabricator.wikimedia.org/T121425) [22:12:21] <wikibugs> 10MediaWiki-extensions-RelatedArticles: Visually integrate 'related articles' feature more cleanly - https://phabricator.wikimedia.org/T121398#1879294 (10JKatzWMF) @wittylama thanks! I added some comments on the page linked ^ [22:12:22] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] "If we wanted to go a step further we could cache the last request using mw.storage but im not sure of the value at this time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258476 (https://phabricator.wikimedia.org/T117412) (owner: 10Sumit) [22:12:32] <grrrit-wm> (03CR) 10Mattflaschen: "Looks good. Should be documented both in-repo (docs/hooks.txt) and on-wiki (see https://www.mediawiki.org/wiki/Extension_hook_registry)." [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/255981 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [22:12:55] <grrrit-wm> (03PS10) 10Mattflaschen: Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [22:13:12] <wikibugs> 10MediaWiki-Interface, 5Patch-For-Review: Split mediawiki.skinning.interface css files into separate modules - https://phabricator.wikimedia.org/T114695#1879295 (10Jdlrobson) p:5Normal>3Lowest [22:16:04] <grrrit-wm> (03Merged) 10jenkins-bot: MobileFrontend fix back on Special:Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/258476 (https://phabricator.wikimedia.org/T117412) (owner: 10Sumit) [22:16:20] <grrrit-wm> (03CR) 10MarkTraceur: "Fix on the way for the missing file (sigh)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [22:16:39] <grrrit-wm> (03PS5) 10MarkTraceur: [WIP] API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) [22:17:10] <awight> kaldari: ebernhardson: legoktm: anyone want to have a mild opinion on https://gerrit.wikimedia.org/r/#/c/247248/ ? [22:17:29] <grrrit-wm> (03PS9) 10Awight: Use template to render EnhancedChangesList groups [core] - 10https://gerrit.wikimedia.org/r/247248 (https://phabricator.wikimedia.org/T120921) [22:17:52] <kaldari> awight: I support it [22:17:55] <kaldari> :) [22:18:03] <awight> hehe [22:18:12] <awight> Thanks for pushing us towards sanity, btw [22:18:26] <legoktm> awight: I haven't had the chance to review the code, but I support the concept :) My main concern would be making sure that the Wikidata and Flow hooks still work [22:18:50] <kaldari> awight: sadly this is still stalled: https://gerrit.wikimedia.org/r/#/c/206490/ [22:18:53] <wikibugs> 10MediaWiki-Search, 5MW-1.26-release: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#1879303 (10Aklapper) @Ejouvin: Does removing `float: left;` from [[ https://phabricator.wikimedia.org/diffusion/MW/browse/REL1_26/resource... [22:19:05] <wikibugs> 3Wikipedia-Android-App: Create mocks for Wiktionary popup when highlighting word(s) - https://phabricator.wikimedia.org/T114949#1879304 (10Mholloway) Here's the result when I create the png icons with our python script: {F3088791} :( [22:19:57] <awight> legoktm: great point! [22:20:05] <Hydronium> 'vagrant roles enable parsoid' => 'Error: Could not set 'file' on ensure: No such file or directory' bleh [22:20:41] <grrrit-wm> (03CR) 10Awight: "@jdlrobson: Needs a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/206490 (https://phabricator.wikimedia.org/T97188) (owner: 10Jdlrobson) [22:21:25] <wikibugs> 10Wikidata-Page-Banner, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Banners should support extraClassNames parameter - https://phabricator.wikimedia.org/T110904#1879315 (10Jdlrobson) [22:21:32] <Hydronium> oh [22:21:43] <wikibugs> 3Wikipedia-Android-App: Create mocks for Wiktionary popup when highlighting word(s) - https://phabricator.wikimedia.org/T114949#1879316 (10KHammerstein) {F3088802} [22:21:44] <Hydronium> maybe i need the ve role [22:22:16] <wikibugs> 10MediaWiki-API, 10MediaWiki-extensions-RelatedArticles, 7Performance: RelatedArticles API query can take 2 seconds - https://phabricator.wikimedia.org/T121254#1879317 (10Aklapper) [22:22:34] <grrrit-wm> (03CR) 10Niedzielski: [C: 031] "Pretty sweet tweeks! In a future patch, we should try to prevent pull to refresh from engaging and also offset the toasts like in the acti" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 (owner: 10Dbrant) [22:22:49] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [22:22:54] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 3Fundraising Sprint Zapp, 5Patch-For-Review: Create a state dropdown for Mustache forms - https://phabricator.wikimedia.org/T119585#1879318 (10cwdent) @awight T120992 has a small start on doing some for real L10N on the mustache forms, but it... [22:22:55] <grrrit-wm> (03CR) 10Sniedzielski: [C: 032] Add long-press hints for article menu buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 (owner: 10Dbrant) [22:23:45] <wikibugs> 10MediaWiki-skins-Blueprint, 5Patch-For-Review: No icon for "View source" and "Edit" in sidebar - https://phabricator.wikimedia.org/T104213#1879323 (10Volker_E) It seems promising, that we will see just one "Edit" link in near future, looking at progress over at {T58337}. [22:25:16] <grrrit-wm> (03Merged) 10jenkins-bot: Add long-press hints for article menu buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259080 (owner: 10Dbrant) [22:27:18] <wikibugs> 10MediaWiki-extensions-CheckUser, 6WMF-Legal: Mark accounts that hit limit of account creation in one IP for sysops - https://phabricator.wikimedia.org/T107651#1879340 (10Mdennis-WMF) Hello. :) I was asked to comment on this and also sought feedback from Jacob Rogers on the legal team. This tool seems like it... [22:28:16] <wikibugs> 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Other, and 5 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#1879344 (10Aklapper) >>! In T85864#1875643, @Nem... [22:28:53] <wikibugs> 3Wikipedia-Android-App: Create mocks for Wiktionary popup when highlighting word(s) - https://phabricator.wikimedia.org/T114949#1879353 (10bearND) This is how the generated png for xhdpi looks like on my system: {F3088811} [22:29:09] <grrrit-wm> (03PS1) 10Ori.livneh: Add a maintenance script for finding deprecated interfaces [core] - 10https://gerrit.wikimedia.org/r/259162 [22:29:12] <grrrit-wm> (03CR) 10Jdrewniak: [C: 031] Remove first a/b test [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/259145 (https://phabricator.wikimedia.org/T121425) (owner: 10JGirault) [22:29:32] <grrrit-wm> (03PS1) 10Mobrovac: Ask for the MathML and SVG renders only if the input is valid [extensions/Math] - 10https://gerrit.wikimedia.org/r/259164 (https://phabricator.wikimedia.org/T121445) [22:30:54] <wikibugs> 10Reading Web Planning, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: provide contribs link and prevent mobile user without user page from being dumped into blank screen when they click their username - https://phabricator.wikimedia.org/T119412#1879361 (10Jdlrobson) a:5Nirzar>3None [22:31:07] <wikibugs> 10CirrusSearch, 6Discovery: MediaWiki 1.26.0 and CirrusSearch Extension not working with current master or 1.26 version - https://phabricator.wikimedia.org/T121213#1879363 (10Aklapper) 5Open>3stalled p:5Normal>3Triage [22:31:20] <grrrit-wm> (03CR) 10MaxSem: [C: 032] Remove first a/b test [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/259145 (https://phabricator.wikimedia.org/T121425) (owner: 10JGirault) [22:31:38] <grrrit-wm> (03CR) 10Physikerwelt: [C: 032] Ask for the MathML and SVG renders only if the input is valid [extensions/Math] - 10https://gerrit.wikimedia.org/r/259164 (https://phabricator.wikimedia.org/T121445) (owner: 10Mobrovac) [22:31:58] <grrrit-wm> (03CR) 10Ori.livneh: "demo: https://asciinema.org/a/9ge58zsukjdgn8dd5df77j5t5" [core] - 10https://gerrit.wikimedia.org/r/259162 (owner: 10Ori.livneh) [22:32:35] <wikibugs> 6Developer-Relations: Create a user friendly encouraging-to-contribute site - https://phabricator.wikimedia.org/T91633#1879378 (10Aklapper) @Samtar / @Jhernandez: Anyone knows what is left to do in this task exactly that blocks it from being changed to status=resolved? @Samtar: And thanks for your work on this!... [22:32:37] <grrrit-wm> (03PS1) 10IoannisKydonis: :wq [core] - 10https://gerrit.wikimedia.org/r/259166 [22:32:49] <wikibugs> 3Wikipedia-Android-App: Create mocks for Wiktionary popup when highlighting word(s) - https://phabricator.wikimedia.org/T114949#1879379 (10Mholloway) Here's the result when I run it: {F3088829} [22:33:18] <wikibugs> 10MediaWiki-API, 10MediaWiki-Database, 6RevisionScoringAsAService, 7Wikimedia-log-errors: mwapi.errors.APIError: internal_api_error_DBQueryError - https://phabricator.wikimedia.org/T121333#1879380 (10He7d3r) [22:35:03] <wikibugs> 10MediaWiki-Special-pages, 7Easy, 3Google-Code-In-2015: Make Special:MediaStatistics show a total - https://phabricator.wikimedia.org/T117606#1879391 (10Aklapper) [22:35:39] <wikibugs> 10MediaWiki-extensions-MultimediaViewer, 7Easy, 7I18n: Add gender support to Multimediaviewer-text-embed-credit-text-tbls - https://phabricator.wikimedia.org/T85685#1879393 (10Aklapper) a:5Devirk>3None No reply, hence unassigning. [22:35:48] <wikibugs> 10MediaWiki-extensions-MultimediaViewer, 7Easy, 3Google-Code-In-2015, 7I18n: Add gender support to Multimediaviewer-text-embed-credit-text-tbls - https://phabricator.wikimedia.org/T85685#1879395 (10Aklapper) [22:35:51] <wikibugs> 10MediaWiki-Interface, 7JavaScript, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints, 7Regression: redirectToFragment script (redirects to section headers) behaving unreliably - https://phabricator.wikimedia.org/T110501#1879397 (10jhobs) a:5jhobs>3Jdlrobson [22:36:18] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 7Easy, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: use background-size:cover on related images - https://phabricator.wikimedia.org/T121152#1879398 (10jhobs) a:3jhobs [22:36:45] <wikibugs> 10MediaWiki-extensions-MultimediaViewer, 7Easy: $wgNetworkPerformanceSamplingFactor should be called $wgMediaViewerNetworkPerformanceSamplingFactor - https://phabricator.wikimedia.org/T91465#1879399 (10Aklapper) @Tgr: Could this be a potential #Google-Code-in-2015 task you (or someone else?) could imagine to m... [22:37:31] <grrrit-wm> (03PS1) 10Llyrian: added hooks to extensions [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 [22:38:10] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 3Fundraising Sprint Zapp, 5Patch-For-Review: Create a state dropdown for Mustache forms - https://phabricator.wikimedia.org/T119585#1879401 (10cwdent) [22:39:47] <grrrit-wm> (03CR) 10Awight: [V: 031] "I've verified that we this plays nice with the Flow RC hooks..." [core] - 10https://gerrit.wikimedia.org/r/247248 (https://phabricator.wikimedia.org/T120921) (owner: 10Awight) [22:40:37] <ori> andre__: it's not too late to submit those? [22:40:38] <grrrit-wm> (03Merged) 10jenkins-bot: Remove first a/b test [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/259145 (https://phabricator.wikimedia.org/T121425) (owner: 10JGirault) [22:40:40] <ori> (google code-in tasks) [22:40:45] <grrrit-wm> (03Merged) 10jenkins-bot: Ask for the MathML and SVG renders only if the input is valid [extensions/Math] - 10https://gerrit.wikimedia.org/r/259164 (https://phabricator.wikimedia.org/T121445) (owner: 10Mobrovac) [22:41:57] <grrrit-wm> (03CR) 10Awight: [C: 031] "Fundraising is already using Mustache partials, we'd love to see the support in mw-core. I can test this once it's rebased." [core] - 10https://gerrit.wikimedia.org/r/206490 (https://phabricator.wikimedia.org/T97188) (owner: 10Jdlrobson) [22:42:06] <grrrit-wm> (03PS2) 10Physikerwelt: added hooks to extensions [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (owner: 10Llyrian) [22:42:15] <wikibugs> 7Design, 10VisualEditor, 10VisualEditor-MediaWiki, 7Epic, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Change VE integration to only use one edit tab, to avoid user choice paralysis - https://phabricator.wikimedia.org/T58337#1879417 (10Ryasmeen) [22:42:21] <wikibugs> 10Reading-Web: Experiment with serving lower resolution images as the default for all page views - https://phabricator.wikimedia.org/T120875#1879418 (10Tgr) An opt-out does not prevent people from being outraged over a change they don't like. I had to learn that the hard way :-) And of course additional prefere... [22:43:15] <grrrit-wm> (03CR) 10Mattflaschen: [C: 04-1] "Looks good, small stuff." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [22:43:53] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 3Fundraising Sprint Zapp, 5Patch-For-Review: Create a state dropdown for Mustache forms - https://phabricator.wikimedia.org/T119585#1879421 (10awight) @cwdent I'm happy with any degree of provisional wedging, in this case--my only objection i... [22:44:31] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] added hooks to extensions [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (owner: 10Llyrian) [22:44:40] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add a maintenance script for finding deprecated interfaces [core] - 10https://gerrit.wikimedia.org/r/259162 (owner: 10Ori.livneh) [22:46:39] <grrrit-wm> (03PS3) 10Llyrian: WIP: T91505 [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 [22:47:23] <grrrit-wm> (03CR) 10Legoktm: [C: 032] "Thanks" [core] - 10https://gerrit.wikimedia.org/r/259044 (owner: 10Umherirrender) [22:48:26] <wikibugs> 10MediaWiki-extensions-CentralNotice, 6Analytics-Backlog, 10Analytics-EventLogging, 10Traffic, 6operations: Eventlogging should transparently split large event payloads - https://phabricator.wikimedia.org/T114078#1879425 (10Tgr) Is there an alternative path towards making logging non-tiny amounts of data... [22:49:38] <grrrit-wm> (03PS4) 10Llyrian: WIP: [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 [22:50:22] <wikibugs> 10MediaWiki-extensions-CentralNotice, 6Analytics-Backlog, 10Analytics-EventLogging, 10Traffic, 6operations: Eventlogging should transparently split large event payloads - https://phabricator.wikimedia.org/T114078#1879426 (10ori) I don't think it's a problem; excessively large event payloads are a misuse... [22:51:21] <wikibugs> 10MediaWiki-extensions-WikibaseRepository, 10Possible-Tech-Projects, 10Wikidata, 7Epic, 7Tracking: [Epic] Adding new datatypes to Wikidata - https://phabricator.wikimedia.org/T91505#1879427 (10Physikerwelt) [22:51:37] <grrrit-wm> (03PS5) 10Llyrian: WIP: [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 [22:52:37] <wikibugs> 10MediaWiki-API, 10MediaWiki-extensions-RelatedArticles, 7Performance: RelatedArticles API query can take 2 seconds - https://phabricator.wikimedia.org/T121254#1879428 (10Jdlrobson) Have asked @bgerstle-WMF and @bearND to see if this impacts apps too. Thanks @legoktm for showing us where most of the leg work... [22:52:51] <andre__> ori: no. we still accept mentors and tasks at any time :) [22:53:07] <ori> cool [22:53:43] <wikibugs> 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Better announce the lack of Machine Translation - https://phabricator.wikimedia.org/T106415#1879430 (10Trondtr) This is a setup for Apertium, so we are restricted to Apertium language pair (and in general, I assume, to open sourc... [22:53:56] <grrrit-wm> (03PS1) 10BearND: Wiktionary definition icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259173 (https://phabricator.wikimedia.org/T114949) [22:54:20] <grrrit-wm> (03Merged) 10jenkins-bot: Add release notes for removed function and class [core] - 10https://gerrit.wikimedia.org/r/259044 (owner: 10Umherirrender) [22:55:21] <grrrit-wm> (03CR) 10BryanDavis: "You should be able to test by cherry-picking to your /srv/mediawiki-vagrant checkout and running `vagrant provision`" [vagrant] - 10https://gerrit.wikimedia.org/r/257259 (https://phabricator.wikimedia.org/T119990) (owner: 10BryanDavis) [22:57:43] <grrrit-wm> (03CR) 10MarkTraceur: "Ugh, the more I think about it the more I agree with the us_status thing. One sec." [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [22:57:59] <grrrit-wm> (03CR) 10Legoktm: [C: 031] "LGTM, sorry about the delay. I'll merge it tomorrow after the branch cut. Do we need to bump LocalisationCache::VERSION?" [core] - 10https://gerrit.wikimedia.org/r/230998 (https://phabricator.wikimedia.org/T108427) (owner: 10TTO) [22:58:22] <wikibugs> 10MediaWiki-Search, 5MW-1.26-release: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#1879439 (10Ejouvin) Much better. Solve the alignement. Still remains the trailing \n at the end of the page. You can see the result here... [22:58:38] <grrrit-wm> (03PS1) 10Mobrovac: Minor: rename checkTex() to checkTeX() [extensions/Math] - 10https://gerrit.wikimedia.org/r/259175 [22:58:41] <grrrit-wm> (03PS6) 10Llyrian: WIP: Add classes and modify hook in Math [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) [22:59:05] <wikibugs> 7Design, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: Better announce the lack of Machine Translation - https://phabricator.wikimedia.org/T106415#1879444 (10Trondtr) This is the [[ http://wiki.apertium.org/wiki/List_of_language_pairs | list of Apertium language pairs ]]. Pairs under... [22:59:20] <wikibugs> 10MediaWiki-API, 10MediaWiki-extensions-RelatedArticles, 7Performance: RelatedArticles API query can take 2 seconds - https://phabricator.wikimedia.org/T121254#1879446 (10ori) According to @Legoktm's paste, 84.25% of the time is spent waiting on ElasticSearch to return results. [22:59:33] <grrrit-wm> (03PS7) 10Llyrian: WIP: Add classes and modify hook in Math for PT:math [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) [23:00:25] <grrrit-wm> (03PS6) 10MarkTraceur: API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) [23:01:05] <wikibugs> 10MediaWiki-API, 10MediaWiki-extensions-RelatedArticles, 6Discovery, 7Elasticsearch, 7Performance: RelatedArticles API query can take 2 seconds - https://phabricator.wikimedia.org/T121254#1879449 (10Jdlrobson) [23:01:26] <wikibugs> 10MediaWiki-API, 10MediaWiki-extensions-RelatedArticles, 6Discovery, 7Elasticsearch, 7Performance: RelatedArticles API query can take 2 seconds - https://phabricator.wikimedia.org/T121254#1879459 (10Jdlrobson) >>! In T121254#1879446, @ori wrote: > According to @Legoktm's paste, 84.25% of the time is spen... [23:04:33] <grrrit-wm> (03CR) 10Physikerwelt: [C: 032] "While I'd currently prefer Tex rather than TeX to increase readability if TeX is followed by another word, this makes the naming schema mo" [extensions/Math] - 10https://gerrit.wikimedia.org/r/259175 (owner: 10Mobrovac) [23:06:14] <grrrit-wm> (03PS1) 10VolkerE: Improve minor code documentation flaw [extensions/OOUIPlayground] - 10https://gerrit.wikimedia.org/r/259177 [23:06:42] <grrrit-wm> (03Merged) 10jenkins-bot: Minor: rename checkTex() to checkTeX() [extensions/Math] - 10https://gerrit.wikimedia.org/r/259175 (owner: 10Mobrovac) [23:07:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] API to fetch data about stashed images [core] - 10https://gerrit.wikimedia.org/r/258484 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [23:13:41] <grrrit-wm> (03CR) 10Chad: [C: 032] Don't install a custom error handler for hooks [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258986 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:13:47] <grrrit-wm> (03CR) 10Chad: [C: 032] Don't install a custom error handler for hooks [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/258987 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:13:51] <grrrit-wm> (03CR) 10Chad: [C: 032] Don't install a custom error handler for hooks [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/258989 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:13:54] <grrrit-wm> (03CR) 10Chad: [C: 032] Don't install a custom error handler for hooks [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/258990 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:13:59] <wikibugs> 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Mathoid, 10Wikidata, 7Story: [Story] add a new datatype for formulae - https://phabricator.wikimedia.org/T67397#1879474 (10Physikerwelt) [23:14:19] <wikibugs> 3Scrum-Master-Transition: Review Reading Web team norms and values. - https://phabricator.wikimedia.org/T121456#1879478 (10KLans_WMF) 3NEW [23:15:59] <wikibugs> 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 7Documentation: Maintaining RELEASE-NOTES sucks - https://phabricator.wikimedia.org/T121457#1879486 (10Reedy) 3NEW [23:16:55] <wikibugs> 10MediaWiki-extensions-CentralNotice: CentralNotice extension should have a calendar - https://phabricator.wikimedia.org/T35650#1879496 (10Jseddon) p:5Lowest>3Low I'd like to flag this up again and bump up the priority. Requesting and viewing existing and planned campaigns should be possible from the central... [23:17:13] <grrrit-wm> (03PS1) 10Mobrovac: Logging: adjust the log entry levels [extensions/Math] - 10https://gerrit.wikimedia.org/r/259180 (https://phabricator.wikimedia.org/T121445) [23:17:17] <wikibugs> 10MediaWiki-extensions-CentralNotice, 6Analytics-Backlog, 10Analytics-EventLogging, 10Traffic, 6operations: Eventlogging should transparently split large event payloads - https://phabricator.wikimedia.org/T114078#1879499 (10Tgr) "Excessively" seems to be currently defined as "more than 500 characters" (t... [23:17:50] <wikibugs> 10MediaWiki-extensions-RelatedArticles, 7Easy, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: use background-size:cover on related images - https://phabricator.wikimedia.org/T121152#1879500 (10jhobs) This is actually technically a Cards issue, not Related Articles, I think. [23:18:04] <wikibugs> 10MediaWiki-extensions-Cards, 7Easy, 3Reading Web Sprint 62 - DJ-Jazzy-Jeff-and-the-Fresh-Sprints: use background-size:cover on related images - https://phabricator.wikimedia.org/T121152#1879501 (10jhobs) [23:19:25] <grrrit-wm> (03Merged) 10jenkins-bot: Don't install a custom error handler for hooks [core] (REL1_26) - 10https://gerrit.wikimedia.org/r/258986 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:19:43] <grrrit-wm> (03CR) 10Platonides: [C: 04-2] "I'm afraid you haven't understood what was expected from the task." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/259166 (owner: 10IoannisKydonis) [23:22:06] <grrrit-wm> (03PS1) 10Jforrester: VisualEditor: Default to Single Edit Tab mode [vagrant] - 10https://gerrit.wikimedia.org/r/259181 [23:22:47] <wikibugs> 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Highlight "investigation required" errors - https://phabricator.wikimedia.org/T121458#1879507 (10awight) 3NEW [23:23:17] <grrrit-wm> (03PS1) 10Mattflaschen: Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 [23:24:39] <grrrit-wm> (03Merged) 10jenkins-bot: Don't install a custom error handler for hooks [core] (REL1_25) - 10https://gerrit.wikimedia.org/r/258987 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:24:43] <grrrit-wm> (03Merged) 10jenkins-bot: Don't install a custom error handler for hooks [core] (REL1_24) - 10https://gerrit.wikimedia.org/r/258989 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:24:46] <grrrit-wm> (03Merged) 10jenkins-bot: Don't install a custom error handler for hooks [core] (REL1_23) - 10https://gerrit.wikimedia.org/r/258990 (https://phabricator.wikimedia.org/T117553) (owner: 10Reedy) [23:25:53] <grrrit-wm> (03CR) 10Gergő Tisza: [C: 031] Prepare for move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 (owner: 10Anomie) [23:25:56] <grrrit-wm> (03CR) 10Smalyshev: [WIP] Some refactoring of the suggester (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258417 (owner: 10Smalyshev) [23:26:05] <grrrit-wm> (03CR) 10Mattflaschen: "This seems to actually be useful for debugging (e.g. T121455), so I think we should log it unless there's something I'm missing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:27:03] <grrrit-wm> (03CR) 10Gergő Tisza: [C: 031] Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [23:27:37] <grrrit-wm> (03PS1) 10Legoktm: API: Use page_touched for cache invalidation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/259183 [23:28:24] <wikibugs> 10MediaWiki-Search, 5MW-1.26-release: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#1879521 (10Ejouvin) For the remaining \n at the eand. In the file SpecialSearch.php, I found this : $out->addHTML( '<div class="visualCle... [23:29:24] <wikibugs> 10MediaWiki-Search, 5MW-1.26-release: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#1879523 (10Reedy) The stray \n was fixed a while ago in the REL1_26 branch https://github.com/wikimedia/mediawiki/commit/c16ef9fb426109b92... [23:30:16] <grrrit-wm> (03CR) 10Physikerwelt: [C: 032] Logging: adjust the log entry levels [extensions/Math] - 10https://gerrit.wikimedia.org/r/259180 (https://phabricator.wikimedia.org/T121445) (owner: 10Mobrovac) [23:31:49] <grrrit-wm> (03CR) 10Catrope: [C: 032] Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:32:13] <wikibugs> 10MediaWiki-Search, 5MW-1.26-release: Search result columns in 1.26.0 not correctly display when using both title and text scope - https://phabricator.wikimedia.org/T119879#1879525 (10Ejouvin) Ok, did not understand that the fix will comes with the next release. Sorry about that. [23:32:54] <grrrit-wm> (03Merged) 10jenkins-bot: Logging: adjust the log entry levels [extensions/Math] - 10https://gerrit.wikimedia.org/r/259180 (https://phabricator.wikimedia.org/T121445) (owner: 10Mobrovac) [23:33:25] <wikibugs> 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice extension should have a calendar - https://phabricator.wikimedia.org/T35650#1879528 (10Jseddon) [23:33:26] <grrrit-wm> (03CR) 10JGirault: [C: 031] Add icon for 'View Source' menu item [skins/Blueprint] - 10https://gerrit.wikimedia.org/r/252973 (https://phabricator.wikimedia.org/T104213) (owner: 10VolkerE) [23:33:49] <wikibugs> 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 7Documentation: Maintaining RELEASE-NOTES sucks - https://phabricator.wikimedia.org/T121457#1879531 (10Isarra) Yes. Issues: - People forget to even include release notes with their patches - Release notes are often not useful even if they do reme... [23:34:14] <grrrit-wm> (03CR) 10Bene: "I wonder if this shouldn't be done inside of Wikibase instead. We already have some soft dependencies on uls and babel there so we might w" [extensions/Math] - 10https://gerrit.wikimedia.org/r/259167 (https://phabricator.wikimedia.org/T67397) (owner: 10Llyrian) [23:35:11] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:36:08] <grrrit-wm> (03CR) 10Mattflaschen: [C: 032] "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:37:07] <wikibugs> 6Reading-Admin, 10Wikimedia-Developer-Summit-2016-Organization: WikiDev 16 working area: Content format - https://phabricator.wikimedia.org/T119022#1879536 (10RobLa-WMF) [23:37:31] <wikibugs> 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 7Documentation: Maintaining RELEASE-NOTES sucks - https://phabricator.wikimedia.org/T121457#1879538 (10Skizzerz) * Keep it on-wiki and don't bother having a copy in git/gerrit at all, or perhaps have a placeholder RELEASE-NOTES that offers a link to... [23:40:23] <grrrit-wm> (03Merged) 10jenkins-bot: Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:41:28] <grrrit-wm> (03PS2) 10BryanDavis: API: Use page_touched for cache invalidation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/259183 (owner: 10Legoktm) [23:42:07] <grrrit-wm> (03CR) 10BryanDavis: [C: 032] API: Use page_touched for cache invalidation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/259183 (owner: 10Legoktm) [23:42:20] <grrrit-wm> (03PS1) 10BryanDavis: API: Use page_touched for cache invalidation [extensions/MobileFrontend] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/259188 [23:43:20] <wikibugs> 10MediaWiki-Parser, 7Accessibility: Enable, whitelist, and incorporate semantic HTML5 elements: article, aside, figcaption, figure, footer, header, hgroup, main, mark, nav, picture, progress, section, time - https://phabricator.wikimedia.org/T25932#1879547 (10Rezonansowy) If the T12467 has the 'Low', this shou... [23:43:30] <wikibugs> 10MediaWiki-Parser, 7Accessibility: Enable, whitelist, and incorporate semantic HTML5 elements: article, aside, figcaption, figure, footer, header, hgroup, main, mark, nav, picture, progress, section, time - https://phabricator.wikimedia.org/T25932#1879551 (10Rezonansowy) p:5Lowest>3Low [23:44:15] <wikibugs> 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 7Documentation: Maintaining RELEASE-NOTES sucks - https://phabricator.wikimedia.org/T121457#1879553 (10ashley) >>! In T121457#1879531, @Isarra wrote: > - Edit conflicts out the wazoo changing one single file Basically if and when you have a core pat... [23:45:43] <grrrit-wm> (03CR) 10Jdlrobson: API: Use page_touched for cache invalidation (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/259183 (owner: 10Legoktm) [23:46:48] <grrrit-wm> (03Merged) 10jenkins-bot: API: Use page_touched for cache invalidation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/259183 (owner: 10Legoktm) [23:48:44] <wikibugs> 6RevisionScoringAsAService, 10rsaas-editquality : Revert model for English Wikiversity - https://phabricator.wikimedia.org/T121397#1879555 (10Halfak) [23:49:58] <wikibugs> 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Central Notice - Campaign Overlap warning - https://phabricator.wikimedia.org/T121459#1879557 (10Jseddon) 3NEW a:3Jseddon [23:50:14] <wikibugs> 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 7Documentation: Maintaining RELEASE-NOTES sucks - https://phabricator.wikimedia.org/T121457#1879565 (10Reedy) Seems https://www.mediawiki.org/wiki/Requests_for_comment/Release_notes_automation exists... [23:50:16] <wikibugs> 6RevisionScoringAsAService, 10revscoring : Update french language utilities with expanded badword/informals - https://phabricator.wikimedia.org/T121358#1879566 (10Halfak) [23:56:21] <grrrit-wm> (03PS1) 10Jdlrobson: Explicitly scroll to element in hash [core] - 10https://gerrit.wikimedia.org/r/259190 [23:57:52] <grrrit-wm> (03PS1) 10Dbrant: WIP: Set menu color to the dominant color of the lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/259191 [23:58:54] <wikibugs> 7Design: Heading line should not overlap the images and other boxes - https://phabricator.wikimedia.org/T121461#1879578 (10Rezonansowy) 3NEW [23:59:54] <wikibugs> 7Design: Heading line should not overlap the images and other boxes - https://phabricator.wikimedia.org/T121461#1879585 (10Rezonansowy)