[00:00:13] (03CR) 10Reedy: [C: 032] Update .gitignore for Composer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258722 (owner: 10Gergő Tisza) [00:00:46] (03Merged) 10jenkins-bot: Update .gitignore for Composer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258722 (owner: 10Gergő Tisza) [00:00:54] (03CR) 10Legoktm: [C: 032] Fix typo in special page name [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258721 (owner: 10Gergő Tisza) [00:01:26] (03Merged) 10jenkins-bot: Fix typo in special page name [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258721 (owner: 10Gergő Tisza) [00:02:12] (03PS5) 10Florianschmidtwelzow: MediaWiki Widgets: Add new SearchInputWidget [core] - 10https://gerrit.wikimedia.org/r/255436 (https://phabricator.wikimedia.org/T118443) [00:03:45] 10MediaWiki-extensions-OAuth: OAuth consumer registration email address field seems pointless - https://phabricator.wikimedia.org/T121330#1875946 (10Tgr) 3NEW [00:04:28] 10MediaWiki-extensions-OAuth: OAuth consumer registration email address field seems pointless - https://phabricator.wikimedia.org/T121330#1875958 (10Tgr) [00:04:29] 10MediaWiki-extensions-OAuth, 6Reading-Infrastructure-Team, 7Epic: Improve OAuth management interface - https://phabricator.wikimedia.org/T98880#1875957 (10Tgr) [00:04:52] (03CR) 10Legoktm: [C: 04-1] Converted MapSources to new extension registration system (032 comments) [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/258706 (https://phabricator.wikimedia.org/T87939) (owner: 10Mhutti1) [00:09:38] (03PS7) 10Florianschmidtwelzow: WIP: Convert Special:Search input to OOUI [core] - 10https://gerrit.wikimedia.org/r/252718 (https://phabricator.wikimedia.org/T100898) [00:15:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Convert Special:Search input to OOUI [core] - 10https://gerrit.wikimedia.org/r/252718 (https://phabricator.wikimedia.org/T100898) (owner: 10Florianschmidtwelzow) [00:19:21] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1875960 (10awight) My Labs username is just "Awight". The easiest workaround, now that it sounds like you have data in ores_classification, is to set $wgOresDamagingThreshold to something lower. [00:34:58] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1875963 (10Tgr) If the main problem is people copying fair use images from other wikis, why not f... [00:38:45] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Unplanned-Sprint-Work, 3Fundraising Sprint Zapp, and 2 others: Don't show donors error messages when error occurs after successful payment - https://phabricator.wikimedia.org/T120228#1875971 (10Ejegg) 5Open>3Resolved [00:39:31] 10MediaWiki-File-management, 6Commons, 6Multimedia, 10Parsoid, and 9 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1875972 (10Tgr) I don't think there is much overlap between the people who use broken clients and those for whom p... [00:40:12] 10MediaWiki-File-management, 6Commons, 6Multimedia, 6Performance-Team, 5Patch-For-Review: Package bloomd - https://phabricator.wikimedia.org/T120544#1875973 (10Liuxinyu970226) [00:44:40] (03PS2) 10JustinLeung: Added ID to link to graphs and headings [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/258689 [00:46:16] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875974 (10ori) Following @Anomie's instructions, I end up with these warnings & notices: {F3074614} [00:53:46] Hi, I just got here from Google Code-in and I'm going to be trying to contribute to Wikimedia. Could anyone possible give me an overview of the Wikimedia development process please? [00:55:25] Hello, you should find all needed info here :) https://www.mediawiki.org/wiki/Google_Code-in_2015#Instructions_for_GCI_students [00:55:47] awesome, thanks :) [00:58:01] Do you need to have a Linux distro installed to contribute, or can you use Windows? [01:00:47] It's not needed, but it can make things easier [01:00:55] As can a certain amount of command line familiarity [01:01:54] You can use vagrant under windows too [01:01:58] Which will provision a linux vm [01:02:53] There's instruction for MediaWiki-Vagrant: https://www.mediawiki.org/wiki/MediaWiki-Vagrant [01:04:23] Thanks, I'll install that [01:05:13] So approx how many people worldwide contribute to Wikimedia? [01:05:22] Depends what you mean [01:05:45] Contributing to wikimedia is a pretty vague term; editors of Wikipedia contribute to wikimedia [01:06:20] True, didn't think of that [01:08:00] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875977 (10Legoktm) Can you stick a `var_dump($data)` right after ExtensionRegistry reads out of the APC cache at line 133? [01:11:21] (03PS1) 10Aaron Schulz: Prevent edits from having timestamps older that the last one [core] - 10https://gerrit.wikimedia.org/r/258723 [01:12:10] (03PS2) 10Aaron Schulz: Prevent edits with non-monotonic timestamps [core] - 10https://gerrit.wikimedia.org/r/258723 [01:16:10] (03CR) 10jenkins-bot: [V: 04-1] Prevent edits with non-monotonic timestamps [core] - 10https://gerrit.wikimedia.org/r/258723 (owner: 10Aaron Schulz) [01:17:22] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875985 (10ori) >>! In T120267#1875977, @Legoktm wrote: > Can you stick a `var_dump($data)` right after ExtensionRegistry reads out of the APC cache at line 133? {F3074742} [01:19:35] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875986 (10ori) >>! In T120267#1875985, @ori wrote: >>>! In T120267#1875977, @Legoktm wrote: >> Can you stick a `var_dump($data)` right after ExtensionRegistry reads out of the A... [01:20:59] (03CR) 10Microchip08: "Could you make these these changes in the source directory, too? These edits will otherwise get overwritten next time someone runs the sta" [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/258689 (owner: 10JustinLeung) [01:21:29] 7Design, 10Vector: Increase size of Search box on front page - https://phabricator.wikimedia.org/T85329#1875987 (10GOIII) 5Open>3Resolved a:3TheDJ [01:25:36] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875989 (10ori) >>! In T120267#1875986, @ori wrote: >>>! In T120267#1875985, @ori wrote: >>>>! In T120267#1875977, @Legoktm wrote: >>> Can you stick a `var_dump($data)` right aft... [01:26:56] legoktm: sorry, my last comment was wrong (about apc.stat_ctime). I deleted it. If you didn't see it, ignore. [01:27:09] oops, I got all excited :( [01:27:34] thank you for looking into this though :) [01:28:10] ok, this time it really is fixed [01:28:26] changed apc.serializer from 'default' to 'php' (odd, since the comment says default is equivalent to php) [01:29:37] hmm [01:29:46] stock trusty has apc.serializer set to "php" [01:30:44] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1875990 (10He7d3r) In that case, I agree (see also comments on https://gerrit.wikimedia.org/r/#/c/256641/2/includes/Hooks.php,unified). >>! In T118039#1875642, @Ladsgroup wrote: > Sorry, I meant "hidereverted=1" in URL [01:31:00] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875991 (10ori) Changing `apc.serializer = 'default'` to `apc.serializer = 'php'` in /etc/php.d/apcu.ini and then restarting httpd makes the problem go away. [01:31:19] legoktm: but it works in stock trusty, right? [01:31:24] yes [01:33:29] that's probably it then. now the question is what to do about it. we could potentially override whatever is in that file by calling ini_set(), if that works, or we could make mediawiki default to the old behavior (serialize in user code and save as string) if ini_get('apc.serializer') !== 'php' [01:34:45] it'd be great to isolate the source of the corruption and try to have a minimal reproduction case, a small array that doesn't roundtrip to apc correctly [01:36:47] making MW fallback to serializing in user code seems like the safest option [01:38:03] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1875998 (10ori) It'd be great to have a minimal reproduction case (e.g. some cooked-up array that reliably triggers this corruption). Then, when APCBagOStuff is first initialized... [01:39:59] (03PS3) 10Aaron Schulz: Make sure edits are not timestamped before the last edit [core] - 10https://gerrit.wikimedia.org/r/258723 [01:57:04] 10SyntaxHighlight, 7Upstream: SyntaxHighlights' CSS/Less(/Sass) formatting should not include bold elements - https://phabricator.wikimedia.org/T121285#1875999 (10Volker_E) @Jdforrester-WMF Filed issue at https://bitbucket.org/birkenfeld/pygments-main/issues/1181/css-less-scss-css-conform-preprocessor and expl... [01:57:24] 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add screenshots to extension and skin infoboxes on mediawiki.org - https://phabricator.wikimedia.org/T121332#1876000 (10Legoktm) 3NEW [01:57:57] 10SyntaxHighlight, 7Upstream: SyntaxHighlights' CSS/Less(/SCSS/CSS-conform preprocessor) should not use bold formatting - https://phabricator.wikimedia.org/T121285#1876008 (10Volker_E) [02:07:36] 6Revscoring, 7Wikimedia-log-errors: mwapi.errors.APIError: internal_api_error_DBQueryError - https://phabricator.wikimedia.org/T121333#1876009 (10He7d3r) 3NEW [02:09:01] 10MediaWiki-API, 6Revscoring, 7Wikimedia-log-errors: mwapi.errors.APIError: internal_api_error_DBQueryError - https://phabricator.wikimedia.org/T121333#1876017 (10Legoktm) Here's the first traceback: ``` 2015-12-12 21:04:15 mw1140 enwiki exception ERROR: [7984dda5] /w/api.php?pageids=5137507&action=query&rvs... [02:35:16] (03PS1) 10Gergő Tisza: Disable authorization form button after submit [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258724 (https://phabricator.wikimedia.org/T121287) [02:37:05] 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Clicking 'Allow' multiple times quickly causes auth to fail - https://phabricator.wikimedia.org/T121287#1876023 (10Tgr) >>! In T121287#1874712, @Tgr wrote: > Is this a big enough problem to fix in the current interface? I guess that's a stupid question when the... [02:43:28] (03PS1) 10Yurik: Bumped Vega lib, don't send Treat-As-Untrusted [extensions/Graph] - 10https://gerrit.wikimedia.org/r/258725 [02:59:19] (03PS10) 10Yurik: Add custom wiki protocols for data access [extensions/Graph] - 10https://gerrit.wikimedia.org/r/257265 [02:59:36] (03CR) 10Yurik: Add custom wiki protocols for data access (031 comment) [extensions/Graph] - 10https://gerrit.wikimedia.org/r/257265 (owner: 10Yurik) [03:00:11] 10Phabricator-Upstream, 7Security-General, 7Upstream: Panic? Upstream just deprecated the events that we use to implement the Phabricator security extension - https://phabricator.wikimedia.org/T120016#1876028 (10Luke081515) At first: I thinked that we can disable the herald rule and the seucity extension (in... [03:07:29] 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1876029 (10Legoktm) I've been thinking about this over... [03:14:24] 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1876031 (10Harej) As I commented on IRC, it would requi... [03:24:03] I’m trying to run vagrant provision but its failing with “chmod: changing permissions of ‘/tmp/vagrant-puppet’: Read-only file system”. Has anyone seen this before? [03:24:28] I didn’t touch any file permissions. [03:29:54] (03PS4) 10EBernhardson: [WIP] Collect per-node fetch/query latency percentiles [search/extra] - 10https://gerrit.wikimedia.org/r/258720 [03:33:11] 10Phabricator-Upstream, 7Security-General, 7Upstream: Ensure Phab upstream deprecations (_WILLEDITTASK and _DIDEDITTASK) don't compromise our security - https://phabricator.wikimedia.org/T120016#1876034 (10RobLa-WMF) [03:45:49] 10MediaWiki-extensions-WikimediaEvents, 6Analytics-Backlog, 10The-Wikipedia-Library, 10Wikimedia-General-or-Unknown: Implement Schema:ExternalLinkChange - https://phabricator.wikimedia.org/T115119#1876036 (10Beetstra) >>! In T115119#1828267, @Milimetric wrote: > hm, interesting idea but I don't think the d... [03:45:49] (03PS1) 10Legoktm: API: Use $wgExtensionDirectory instead of assuming $IP/extensions [core] - 10https://gerrit.wikimedia.org/r/258726 [03:46:06] "Either sudo or you don't." *puts on sunglasses* [03:48:08] Hyrdonium: But sudo vagrant provision shouldn’t make a difference given that the commands are run through an ssh to the VM anyway… [03:49:21] Its also very possible I broke my VM given that I tried to reboot it and its now taking forever to boot [03:51:17] I know, I was just trying to make a joke [03:52:05] 10Commons-App-Android-Upload: Daily reports - https://phabricator.wikimedia.org/T119164#1876038 (10josephine_l) [03:52:44] perhaps an issue with NFS? [03:53:01] Hey I'm trying to install the Vagrant vm on Windows and am having some problems. I'm not sure if I've set everything up right (I think I have) but I can't find the login details. What credentials do you provide when you log in? [03:53:30] on mediawiki? [03:53:32] Somewhere on the wiki it says “If it asks you for a username or password, its probably ‘vagrant’” [03:53:41] Username/pw: Admin/vagrant [03:55:09] I’m now running vagrant destroy and I feel like I’m about to blow something up [03:56:00] If only vagrant up was as fast as vagrant destroy [03:57:01] your client has smart quotes? whaaaat [03:57:29] ? nah i just typed quotes to my liking [03:58:08] ‘’ != '' [03:58:33] Oh, thats a Mac thing [03:58:40] It does it *everywhere* [03:59:00] interesting [03:59:14] even in a text editor? [03:59:55] Most text editors disable the behavior [04:00:39] The default text editor on Mac does it as long as you’re in rich text mode. [04:04:05] Awesome thanks guys [04:04:43] have fun [04:05:13] its vagrant for both [04:09:23] 6Phabricator: Add help link to explain meaning of priority levels - https://phabricator.wikimedia.org/T87411#1876044 (10Liuxinyu970226) [04:12:09] (03CR) 10Gergő Tisza: [C: 032] Support all values for exif PhotometricInterpretation [core] - 10https://gerrit.wikimedia.org/r/251128 (owner: 10Brian Wolff) [04:12:25] (03CR) 10John Vandenberg: Add vagrant role for pywikibot (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/258711 (owner: 10Gergő Tisza) [04:19:03] (03Merged) 10jenkins-bot: Support all values for exif PhotometricInterpretation [core] - 10https://gerrit.wikimedia.org/r/251128 (owner: 10Brian Wolff) [04:22:13] 10MediaWiki-extensions-OAuth, 6Reading-Infrastructure-Team, 5Patch-For-Review, 7developer-notice: Make "bot" or "personal use" apps a better experience - https://phabricator.wikimedia.org/T87395#1876052 (10Tgr) Uh, I forgot completely that this involves a schema change. I'll take care of that on Monday. [04:27:42] 10MediaWiki-extensions-OAuth, 6Reading-Infrastructure-Team, 7Schema-change: Create oauth_registered_consumer.oarc_owner_only column on metawiki - https://phabricator.wikimedia.org/T121335#1876059 (10Tgr) 3NEW [04:28:18] 10MediaWiki-Export-or-Import: Better handling of timeouts during the import process - https://phabricator.wikimedia.org/T121336#1876065 (10TTO) 3NEW [04:28:41] 10MediaWiki-Export-or-Import, 10Wikimedia-Site-Requests: Half-imported page cannot be deleted - https://phabricator.wikimedia.org/T121337#1876072 (10TTO) 3NEW [04:28:55] 10MediaWiki-Export-or-Import, 10Wikimedia-Site-Requests: Half-imported page cannot be deleted - https://phabricator.wikimedia.org/T121337#1876081 (10TTO) [04:28:57] 10MediaWiki-Export-or-Import: Better handling of timeouts during the import process - https://phabricator.wikimedia.org/T121336#1876065 (10TTO) [04:30:01] why don't GCI students stick around :< [04:30:46] probably so they don't waste time like me :P [04:30:58] * Hydronium goes back to work [04:32:14] 10MediaWiki-extensions-OAuth, 6Reading-Infrastructure-Team, 7Schema-change: Create oauth_registered_consumer.oarc_owner_only column on metawiki - https://phabricator.wikimedia.org/T121335#1876085 (10Tgr) [04:32:17] 10DBA, 7Schema-change, 7Tracking: Schema changes for Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T51188#1876084 (10Tgr) [04:40:42] (03PS1) 10Aaron Schulz: Avoid "CAS updated failed" errors on Special:Preferences double post [core] - 10https://gerrit.wikimedia.org/r/258729 (https://phabricator.wikimedia.org/T95839) [04:41:28] 10MediaWiki-Export-or-Import, 10MediaWiki-Revision-deletion: Better handling of revision deletion on import - https://phabricator.wikimedia.org/T121338#1876088 (10TTO) 3NEW [04:47:14] (03CR) 10jenkins-bot: [V: 04-1] Avoid "CAS updated failed" errors on Special:Preferences double post [core] - 10https://gerrit.wikimedia.org/r/258729 (https://phabricator.wikimedia.org/T95839) (owner: 10Aaron Schulz) [05:01:06] 10MediaWiki-extensions-Translate, 7Easy: "Other languages" message is cached in the wrong language when the page is saved - https://phabricator.wikimedia.org/T62823#1876100 (10Bawolff) I can reproduce. That's super odd [05:03:45] (03PS2) 10Aaron Schulz: Avoid "CAS updated failed" errors on Special:Preferences double post [core] - 10https://gerrit.wikimedia.org/r/258729 (https://phabricator.wikimedia.org/T95839) [05:06:40] 10MediaWiki-Export-or-Import, 10MediaWiki-Maintenance-scripts, 3Google-Code-In-2015: importDump.php should have a parameter to add a prefix to the page titles of imported revisions - https://phabricator.wikimedia.org/T72272#1876103 (10TTO) [05:08:35] (03CR) 10jenkins-bot: [V: 04-1] Avoid "CAS updated failed" errors on Special:Preferences double post [core] - 10https://gerrit.wikimedia.org/r/258729 (https://phabricator.wikimedia.org/T95839) (owner: 10Aaron Schulz) [05:17:35] 10MediaWiki-extensions-Translate, 7Easy: "Other languages" message is cached in the wrong language when the page is saved - https://phabricator.wikimedia.org/T62823#1876108 (10Bawolff) >That's super odd Specifically, I'm surprised we are still storing a parse on edit with "canonical" options. Now that we do a... [05:54:00] 10MediaWiki-Configuration: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1876114 (10ori) I'm pretty certain the bug is the one described here: - https://github.com/krakjoe/apcu/issues/38 - https://github.com/krakjoe/apcu/issues/35 - https://github.co... [05:55:53] (03PS2) 10Ananay: Bug:T87945 Shim added. [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 [06:03:17] (03PS3) 10Ananay: Bug:T87945 Shim added. [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 [06:07:04] (03PS4) 10Ananay: Bug:T87945 Shim added. [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 [06:16:38] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876117 (10Whatamidoing-WMF) A few replies: @Platonides: It unfortunately sounds like your expe... [06:20:52] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876118 (10Whatamidoing-WMF) @Isarra, the point of this thing is to upload a file **with a source... [06:41:57] (03CR) 10Legoktm: [C: 04-1] Bug:T87945 Shim added. (032 comments) [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 (owner: 10Ananay) [06:51:39] (03PS1) 10Ori.livneh: Work around APCu memory corruption bug [core] - 10https://gerrit.wikimedia.org/r/258734 (https://phabricator.wikimedia.org/T120267) [07:26:16] hi am sahil [07:47:08] (03PS3) 10Aaron Schulz: Avoid "CAS updated failed" errors on Special:Preferences double post [core] - 10https://gerrit.wikimedia.org/r/258729 (https://phabricator.wikimedia.org/T95839) [07:50:04] (03PS5) 10Ananay: Bug:T87945 Shim added. [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 [07:51:19] (03CR) 10Brian Wolff: "For the commit message, the Bug: TXXXX part should be on a line of its own, at the bottom of the commit message" [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 (owner: 10Ananay) [07:52:39] tto, so I looked at the code of Import.php and it seems that Phabricator description is outdated? [07:53:44] Hi Georggi! Quite possibly. I'm afraid I'm about to go out for about 3 or 4 hours so you're on your own for a little while. Have fun! Feel free to ask others in this channel in the meantime [07:56:37] I would like you to explain that 2nd part of the task, what it means " to make it possible to import the Wikimedia Ukraine wiki dump at "? [07:56:45] If you can [08:03:04] 4(no projects): Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876127 (10Ankitashukla) 3NEW [08:07:22] 4(no projects): Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876133 (10Ankitashukla) The paste of the og is available [[ https://phabricator.wikimedia.org/P2418 | here ]] [08:08:21] (03PS6) 10Ananay: Bug:T87945 Shim added. [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 [08:11:00] Ahh, found those params, they moved like 100 lines down:) [08:13:47] hello! [08:14:11] hi am sahil [08:14:56] I think we don't know each other, I am participant of GCI [08:16:51] (03PS7) 10Ananay: Bug:T87945 Shim added. [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 [08:16:54] i am also a participant of GCi [08:17:30] is this the first time you participate? [08:17:38] yes [08:18:02] I am in the same situation, and I am not sure how to patch wikimedia's code [08:20:06] i am doing the beginners task [08:20:31] victorbarbu_: Have you downloaded mediawiki. That's the first step [08:20:44] (by download, I mean set up vagrant) [08:21:05] I have set up the vagrant and I have the mediawiki runing on localhost:8080 [08:21:06] :) [08:21:29] 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add screenshots to extension and skin infoboxes on mediawiki.org - https://phabricator.wikimedia.org/T121332#1876134 (10Nemo_bis) [08:21:44] victorbarbu_ gerrit setup? [08:22:07] you mean the account and the SSH key? [08:22:26] yes [08:22:38] done that [08:23:01] basicallt steps given on https://www.mediawiki.org/wiki/Gerrit/Tutorial so that finally you can do 'git-review -R' to submit a patch [08:24:08] there is one problem though. I cannot find the MediaWIki files in my Vagrant (in the SSH interface). [08:24:11] 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add screenshots to extension and skin infoboxes on mediawiki.org - https://phabricator.wikimedia.org/T121332#1876136 (10Nemo_bis) Looks good, thank you. Two questions. # Do we want translated screenshots too in this stage? If not, better exclud... [08:24:24] I cd /vagrant and ls -la and it's empty [08:24:44] victorbarbu_: mediawiki files are in vagrant/mediawiki/ and ssh is not required for that [08:24:50] you can edit them from host os [08:25:32] My current task is to solve 3 todos. I want, for example to solve this one https://doc.wikimedia.org/mediawiki-core/master/php/todo.html#_todo000002 [08:25:35] 4(no projects): Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876137 (10Ankitashukla) After running ``` $ vagrant halt ==> default: Attempting graceful shutdown of VM... tricksy@winterfell ~/projects/vagrant $ vagrant config nfs_shares off tricksy@winterfell ~/... [08:25:39] How do I reference them in my commit message? [08:26:38] (03PS8) 10Legoktm: Add extension.json, empty PHP entry point [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 (https://phabricator.wikimedia.org/T87945) (owner: 10Ananay) [08:27:00] (03CR) 10Legoktm: [C: 032] "Nice work :)" [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 (https://phabricator.wikimedia.org/T87945) (owner: 10Ananay) [08:27:16] victorbarbu_: there must be a phabricator task associated with it [08:27:34] (03Merged) 10jenkins-bot: Add extension.json, empty PHP entry point [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/258675 (https://phabricator.wikimedia.org/T87945) (owner: 10Ananay) [08:27:52] 10MediaWiki-extensions-NewUserMessage, 3Google-Code-In-2015, 5Patch-For-Review: Convert NewUserMessage to use extension registration - https://phabricator.wikimedia.org/T87945#1876140 (10Legoktm) 5Open>3Resolved [08:27:57] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1876141 (10Legoktm) [08:28:25] 10MediaWiki-extensions-Translate, 7Easy, 5Patch-For-Review: "Other languages" message is cached in the wrong language when the page is saved - https://phabricator.wikimedia.org/T62823#1876142 (10Nemo_bis) Thank you bawolff! > cache pollution, only for the content-language version of the page This was happe... [08:28:51] victorbarbu_: you name the phabricator task 'TXXX' at the bottom in the commit message, see a commit from above [08:31:27] codezee: but then, why is this https://doc.wikimedia.org/mediawiki-core/master/php/html/todo.html listed in the task https://codein.withgoogle.com/dashboard/task-instances/6050636076417024/ ? [08:31:28] Fix 3 todos in MediaWiki code || 3 days || Code, Documentation || Wikimedia || Currently claimed || Instances: 5/20 [08:31:36] why is that listed there instead of the phabricator page? [08:32:57] it is just not logical to force me try to find a task from there on phabricator. I am not even sure for which one should I look now [08:33:53] 10WMF-Call-To-Action: WMF to integrate, consolidate, and pause or stop stalled initiatives - https://phabricator.wikimedia.org/T98358#1876143 (10Nemo_bis) Those skins are not a WMF initiative though, is this task for everyone's initiatives? [08:34:15] victorbarbu_: Todo's aren't the same as bugs, so many don't have a corresponding phabricator ticket [08:34:28] victorbarbu_: You can also find todos, using the git-grep tool [08:34:30] e.g. [08:34:34] git grep -i todo [08:34:43] Yeah, but that's what I have to solve, todos [08:35:01] 10MediaWiki-skins-CologneBlue, 10MediaWiki-skins-Modern, 10Reading-Web, 10Wikimedia-Site-Requests: De-deploy the 'Cologne Blue' and 'Modern' skins from Wikimedia production, as no-one is keeping them working - https://phabricator.wikimedia.org/T115430#1876145 (10Nemo_bis) > when we killed five of the then-... [08:35:31] (Be warned that todos vary in difficulty, many are probably very easy, but there may be one or two that are borderline impossible... [08:36:15] 10MediaWiki-extensions-Other: Review PDBHandler extension - https://phabricator.wikimedia.org/T46660#1876146 (10Nemo_bis) > So this should be closed as Declined I suppose? Not really, this task is about identifying the urgent next steps for the extension (and fixing them). Usually it takes many years to deploy... [08:36:18] I was planning to work on reimplementation of APiMessage as a trait [08:37:27] 10MediaWiki-Parser, 7I18n, 7Tracking: GENDER (tracking) - https://phabricator.wikimedia.org/T32443#1876149 (10Nemo_bis) [08:39:24] 10MediaWiki-General-or-Unknown, 5MW-1.26-release, 5Patch-For-Review, 7Upstream, 15User-bd808: Interface 'Psr\Log\LoggerAwareInterface' not found in /vagrant/mediawiki/includes/profiler/TransactionProfiler.php on line 36 - https://phabricator.wikimedia.org/T104037#1876151 (10EFFemeer) I seem to have a sim... [08:43:55] 10MediaWiki-Vagrant: Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876154 (10Legoktm) [08:45:15] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876156 (10Nemo_bis) >>! In T114419#1873960, @Bawolff wrote: >>>! In T114419#1872529, @jayvdb wrote: >> One idea is to establish a more prestigious role called Reviewers , like XEmacs... [08:46:19] 10MediaWiki-Interface, 7I18n, 7Tracking, 7Voice & Tone: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1876159 (10Glaisher) [08:46:21] 10MediaWiki-Special-pages, 7Easy, 3Google-Code-In-2015, 7I18n, and 3 others: Inaccurate success message shown on Special:PasswordReset - https://phabricator.wikimedia.org/T118851#1876157 (10Glaisher) 5Open>3Resolved Thanks! [08:48:23] 10MediaWiki-extensions-EducationProgram: Use a single log (log_type) for any Education Program log_action - https://phabricator.wikimedia.org/T47755#1876163 (10Nemo_bis) >>! In T47755#1872054, @Cenarium wrote: > In fact, we don't //have// to use different log_actions, we can group them in a new log type using T1... [08:48:58] 10MassMessage: Configurable bot flag for MediaWiki message delivery account - https://phabricator.wikimedia.org/T120832#1876164 (10Legoktm) It definitely used to be possible to unflag the bot, this might be a regression from the new User::newSystemUser() function. [08:50:38] bawolff: http://imgur.com/sKxd7qK see this. [08:50:52] The VM does not see the repository [08:50:54] (03PS1) 10Brian Wolff: Make redlink tooltip be content language to stop cache pollution. [core] - 10https://gerrit.wikimedia.org/r/258736 [08:51:24] I've never used vagrant so I'm probably not the best person to ask [08:52:24] codezee said the this is not problem because I can edit the files on host. I can, but I cannot do commits and stuff like that [08:53:50] 10MediaWiki-extensions-Translate, 7Easy, 5Patch-For-Review: "Other languages" message is cached in the wrong language when the page is saved - https://phabricator.wikimedia.org/T62823#1876170 (10Nikerabbit) T34686#371887 [08:53:55] I honestly don't have the slightest idea how to use vagrant. I just have a direct git clone, and installed apache, mysql and php on my laptop [08:54:02] * bawolff hates change [08:55:28] I would have done that If I hadn't had nginx with other projects on my laptop [08:55:32] (03PS2) 10Brian Wolff: Make redlink tooltip be content language to stop cache pollution. [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) [08:55:46] victorbarbu_: you can use mediawiki directory to change code and commit as if vagrant never existed, vagrant is just to run mediawiki in a virtual box [08:56:12] victorbarbu_: You can use MediaWiki with nginx, provided you have php installed [08:56:50] (Its also possible to have multiple web servers on your computer [provided they either aren't both running at the same time, or are running on different ports]) [08:56:50] Oh I think I got it: you're saying that I can commit from the host. But why don't those list in my vm, just for my curiosity ? [08:56:59] * bawolff has no idea [09:00:23] Nemo_bis: I can't believe how long https://phabricator.wikimedia.org/T34686 has been open for... [09:03:22] (03CR) 10jenkins-bot: [V: 04-1] Make redlink tooltip be content language to stop cache pollution. [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) (owner: 10Brian Wolff) [09:04:12] of course [09:05:37] bawolff: good thing that Nikerabbit knows all the bugs ;) [09:07:18] (03PS3) 10Brian Wolff: Make redlink tooltip be content language to stop cache pollution. [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) [09:07:27] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 5Patch-For-Review: "Page does not exist" title cached in wrong language - https://phabricator.wikimedia.org/T34686#1876177 (10Nemo_bis) [09:09:08] Nemo_bis: you're a translateadmin at meta - want to mark https://meta.wikimedia.org/wiki/Requests_for_comment/Password_policy_for_users_with_certain_advanced_permissions for translation? [09:10:57] (Assuming these types of things are supposed to be marked for translation) [09:18:17] Probably yes. I did some tweaking, I'll let someone else fix newlines etc. [09:29:22] ugaga [09:33:10] (03PS3) 10Glaisher: Add script to migrate disabled accounts to blocked accounts [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241512 (https://phabricator.wikimedia.org/T109060) [09:34:04] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876179 (10ori) I'd like to make a counterproposal, and that is that we abolish mandatory code-review, and instead allow people to exercise discretion and self-merge patches when they... [09:35:36] (03CR) 10Glaisher: Add script to migrate disabled accounts to blocked accounts (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/241512 (https://phabricator.wikimedia.org/T109060) (owner: 10Glaisher) [09:40:20] (03PS1) 10Ananay: Bug:T87960 [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) [09:40:22] ori: One interesting aspect of the code review process, is I'm now a lot less careful about code I push to git. In the svn days I always carefully double-checked everything before comiting because comitting bad code was a really bad thing. Now a days, I still generally test all code before shoving to gerrit, but I'm a lot less careful about it [09:40:34] bawolff: me too [09:40:54] it's going to sit in code review for a while and get squinted at by people, so this stuff will surface anyway, right? [09:41:27] plus it'll be someone else's fingerprint on the trigger [09:41:44] i don't consciously think that; that would be cynical. but on some level i do. [09:42:37] our current process does transfer lots of the risk of development, to people who don't benefit [09:43:32] which makes code review a kind of sucky job. Code reviewer is responsible for stuff s/he probably doesn't care about, but is more on the line for it then the person who does care about the code [09:44:11] 10MediaWiki-Interface: Default CSS rule (loaded from ‘load.php’) uses “Linux Libertine” font for headings, thus misses “Linux Libertine O” installed on Ubuntu. - https://phabricator.wikimedia.org/T74515#1876183 (10Edokter) I don't agree with removing Linux Libertine; I want Georgia removed. But anyway... (Also... [09:44:53] yeah. which is such a marked contrast to being asked to review code by someone because s/he is actually interested in your feedback [09:45:23] huh, these (WMF) accounts are dangerously easy to forget about. I just had a weird, why am I not an admin moment. Answer: logged in with wrong account [09:45:27] that is flattering rather than burdensome, at least in my experience. so it's easier and more pleasurable to do. [09:45:44] after redocumenting a member, should I run `make doc` or leave it as it is? [09:45:56] leave it as it is [09:46:06] ok, thanks [09:46:42] there's also the great paradox of mandatory code review, which I know you are keenly aware of: the more neglected and ignored a section of the code is, the more difficult it is to get patches for it reviewed [09:47:21] I've barely touched multimedia-backend code in two months - MW development is so much more fun :) [09:47:54] 10MediaWiki-Database, 10MediaWiki-Page-editing, 6Performance-Team, 5MW-1.27-release-notes, and 2 others: Links tables are sometimes not being populated - https://phabricator.wikimedia.org/T117332#1876184 (10Ankry) >>! In T117332#1817443, @Anomie wrote: > Let's call this "resolved". If the issue still occur... [09:50:08] but yeah. CR can kind of become confrontational quit easily - since when I ask people for code review I don't actually want a review so much as a rubber stamp (Obviously that's not overtly how I think, but after the patch has been sitting there for 2 months and then gets -1'd over something silly, that's how I start to think) [09:52:57] (03CR) 10Nikerabbit: Make redlink tooltip be content language to stop cache pollution. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) (owner: 10Brian Wolff) [09:54:43] (03CR) 10Edokter: [C: 04-1] "Could still use some cleanup, as half the file consists of Inkscape-generated junk." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [09:54:50] bawolff: I don't want to goad you on or anything, but I think it'd be very useful if you repeated some of what you just said on Phab. [09:54:58] (03CR) 10Brian Wolff: "Well lots of things have red links and no TOC, or vice versa, so it would more have to a new instance of splitting rather then taking adva" [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) (owner: 10Brian Wolff) [09:55:43] (03CR) 10Edokter: [C: 031] "Scrap that... The commons version was still poluted. This version is clean! +1" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [09:55:52] In my case the foil for MediaWiki is operations/puppet. it's an interesting comparison, because operations/puppet is no less critical and delicate, and the codebase was formerly very uneven, with lots of very poor quality code. I was pretty motivated to clean it up. Here's my commit graph, with an annotation indicating when I got self-merge privileges: https://dl.dropboxusercontent.com/s/mxallbkc0gj6itx/Screen%20Shot%202015-12-1 [09:55:52] 3%20at%2001.38.46.png [09:56:09] same url without the linebreak: https://dl.dropboxusercontent.com/s/mxallbkc0gj6itx/Screen%20Shot%202015-12-13%20at%2001.38.46.png [09:56:53] Well given we're Wikimedia, we should be pretty keenly aware of the affect of isntant gratification vs peer review [09:57:05] what with nupedia vs wikipedia (Of course that's long long before my time) [09:57:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Story, 3Wikidata-Sprint-2015-12-01: Provide an RDF mapping for external identifiers - https://phabricator.wikimedia.org/T121274#1876185 (10Lydia_Pintscher) [09:59:06] but we see the same thing happen with flagged revs [10:00:23] Personally, I believe that code review can work, and everyone be happy with it, but we would need some very radical changes [10:03:27] I'm not suggesting we get rid of it; I'm suggesting we make it optional. Peer pressure and scorn are pretty effective, and I think it's perfectly legitimate to use them to set high standards for code quality. If you self-merge breaking changes or rapidly self-merge controversial changes without giving any time for discussion, you get censured [10:04:12] (03CR) 10Brian Wolff: "Also, there is a session at dev summit about re-doing how TOC works. If other parts of it get re-done, there's a high probability the cach" [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) (owner: 10Brian Wolff) [10:08:28] I accidentally set a wrong email address for my git account and created a commit. I changed the email but can't send the review to gerrit because "the commiter's email addres is not registered" can I change that without starting over? [10:09:10] (03CR) 10Nikerabbit: "I am quite surprised there isn't a generic way to add post-processing steps yet." [core] - 10https://gerrit.wikimedia.org/r/258736 (https://phabricator.wikimedia.org/T34686) (owner: 10Brian Wolff) [10:10:48] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876187 (10Ladsgroup) >>! In T118039#1875960, @awight wrote: > My Labs username is just "Awight". > > The easiest workaround, now that it sounds like you have data in ores_classification, is to set $wgOresDamagingThreshold to s... [10:10:57] Nikerabbit: Well there sort of is - that sort of is what $wgParserOutputHooks does [10:11:01] ish [10:11:05] (03PS3) 10Umherirrender: Add various point release release notes to HISTORY. [core] - 10https://gerrit.wikimedia.org/r/256049 (owner: 10Reedy) [10:11:08] very -ish [10:11:14] (03CR) 10Umherirrender: [C: 032] Add various point release release notes to HISTORY. [core] - 10https://gerrit.wikimedia.org/r/256049 (owner: 10Reedy) [10:12:08] victorbarbu_: If 'git config user.email' the same as the one on gerrit? [10:12:14] ori: Right, and that seems likely it would be more palatable then giving up code review completely [10:12:28] bawolff: but neither edit sections nor TOC uses it [10:12:33] Glaisher: it is now, but still doesn't work [10:12:58] victorbarbu_: Have you amended the commit after changing? [10:13:09] Nikerabbit: I think the only thing that actually uses it is TimedMediaHandler - and only to add extra modules to OutputPage, which it isn't even very well suited to doing [10:13:46] although, I guess really one probably wants something that runs slightly early for parser post-processing [10:13:50] 10MediaWiki-Database, 10MediaWiki-Page-editing, 6Performance-Team, 5MW-1.27-release-notes, and 2 others: Links tables are sometimes not being populated - https://phabricator.wikimedia.org/T117332#1876188 (10aaron) See also https://gerrit.wikimedia.org/r/#/c/258445/ which will be in the next release. That f... [10:14:21] (03PS1) 10Victorbarbu: Redocumented $wgAutopromote [core] - 10https://gerrit.wikimedia.org/r/258739 [10:14:26] 10MediaWiki-General-or-Unknown, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): "The Title object yields no ID. Perhaps the page doesn't exist?" exceptions from refreshLinksPrioritized - https://phabricator.wikimedia.org/T121228#1876189 (10aaron) 5Open>3Resolved a:3aa... [10:14:32] (03PS1) 10Ori.livneh: Fix for "Error: invalid byte sequence in US-ASCII in ..." [vagrant] - 10https://gerrit.wikimedia.org/r/258740 (https://phabricator.wikimedia.org/T86282) [10:14:41] I had missed that. Amended the change [10:14:55] :) [10:15:49] 10MediaWiki-JobQueue, 7Wikimedia-log-errors: Fatal exception for type „MWException”on ro.wikibooks when changing time zone - https://phabricator.wikimedia.org/T121325#1876194 (10Umherirrender) [10:16:55] 10MediaWiki-Vagrant, 5Patch-For-Review: Error: invalid byte sequence in US-ASCII at /tmp/vagrant-puppet-5/modules-0/hhvm/manifests/init.pp:1 on node mediawiki-vagrant.dev - https://phabricator.wikimedia.org/T86282#1876197 (10ori) Via IRC: ``` 01:45 please help me with this when i run vagrant up... [10:20:06] (03Merged) 10jenkins-bot: Add various point release release notes to HISTORY. [core] - 10https://gerrit.wikimedia.org/r/256049 (owner: 10Reedy) [10:20:44] (03CR) 10Brian Wolff: Initial support for CSP in core [Disabled by default] (031 comment) [core] - 10https://gerrit.wikimedia.org/r/253969 (owner: 10Brian Wolff) [10:21:25] (03PS10) 10Brian Wolff: Initial support for CSP in core [Disabled by default] [core] - 10https://gerrit.wikimedia.org/r/253969 [10:21:29] (03CR) 10Umherirrender: [C: 032 V: 032] "No jenkins here" [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/257057 (owner: 10Legoktm) [10:27:28] 10MediaWiki-extensions-MultimediaViewer: Shorten MediaViewer credit lines - https://phabricator.wikimedia.org/T119686#1876198 (10Aklapper) [10:27:39] (03CR) 10Ori.livneh: [V: 031] "Needs a better commit message, but looks good otherwise. Tested, too." [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/258738 (https://phabricator.wikimedia.org/T87960) (owner: 10Ananay) [10:29:28] 10MediaWiki-extensions-MultimediaViewer, 3Google-Code-In-2015: Shorten MediaViewer credit lines - https://phabricator.wikimedia.org/T119686#1833064 (10Aklapper) https://codein.withgoogle.com/tasks/6221542321029120/ [10:29:29] Shorten author/license credit lines in MediaWiki's MultimediaViewer extension || 4 days || Code || Wikimedia [10:36:45] 10MediaWiki-Recent-changes, 10MediaWiki-extensions-CleanChanges: Hide specific user in recent changes - https://phabricator.wikimedia.org/T63173#1876205 (10matej_suchanek) #mediawiki-extensions-cleanchanges allows filtering by user(s), an inverted search could be added. [10:57:55] (03PS1) 10Aaron Schulz: Fix MWOAuthDAO IDEA errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258741 [11:07:35] 6Developer-Relations, 3DevRel-December-2015, 3DevRel-January-2016: Organize and coordinate Wikimedia's participation in Google Code-In 2015 - https://phabricator.wikimedia.org/T111520#1876209 (10Aklapper) [11:14:06] Vagrant stuck at Waiting for machine to boot. This may take a few minutes... [11:14:21] after some time a timeout error appears [11:15:02] (03PS1) 10Victorbarbu: Reformatted documentation for $wgFooterIcons [core] - 10https://gerrit.wikimedia.org/r/258742 [11:19:47] Georggi: I left you a message at the GCI site. [11:19:56] Did you manage to make any progress with the task? [11:21:37] So I should use Apache to set up a web server? [11:22:04] Georggi: I don't see any reason why that should be necessary. Does everything work fine in Vagrant? [11:22:28] I have not used Vagrant yet:) [11:22:47] Oh, OK... Do you have a working copy of MediaWiki installed on your local machine? [11:23:05] Yes, I cloned it with git [11:23:28] Do you have a web server installed so that you can browse the wiki? [11:23:41] No [11:23:47] please help me this error https://dpaste.de/Jb6R [11:23:53] Is vagrant a web server? never worked with it before [11:24:03] Georggi: OK, you might like to look at the manual installation steps at https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Get_started [11:24:10] Vagrant is a virtual machine with MediaWiki installed on it [11:24:20] It's sort of an all-in-one MW development package' [11:24:30] I don't use it myself, but other people find it useful [11:24:31] tto: can you please help me with this https://dpaste.de/Jb6R [11:24:50] tto: it happens when i try to run vagrant up command [11:25:02] kartikey0303: Sadly, I know very little about Vagrant and cannot help you. [11:25:14] tto: oh ok [11:25:29] Having said that, it looks like a linux permissions error. Is your computer's host OS Linux? [11:25:30] kartikey0303: are you running it as admin? [11:25:33] tto: can you tell any other way to setup media wiki [11:25:53] Yes, you can use the manual installation steps at the page I linked to just above [11:26:03] 10Responsive-Vector: Figure out what to do with the personal tools in responsive Vector - https://phabricator.wikimedia.org/T106465#1876220 (10ashley) [11:26:05] 10Responsive-Vector: Figure out what to do with the footer area in responsive Vector - https://phabricator.wikimedia.org/T106466#1876221 (10ashley) [11:26:15] tto: you mean with sudo. i tried but then the terminal is not able to associate with the virtual machine. [11:26:20] Apache is a bit harder I think to manage:) [11:27:22] Georggi: It's up to you. Getting the wiki going on Apache requires you to edit the httpd.conf file, which can be a bit tricky. [11:27:33] On the other hand, if you use Vagrant, I will not be of much help to you [11:27:52] In that case, I will only be able to help you with the task itself, not getting setup with Vagrant [11:28:13] I will try Vagrant, if something goes too badly, I will set up Apache [11:28:28] Where can I preview the class in SpecialContributions.php file? [11:28:50] kartikey0303: i can try helping (although i'm not a dev, so you can take my advice with a pinch of salt!) [11:29:07] kartikey0303: what is the error message you get when you run sudo? [11:29:27] victorbarbu_: Hello! You can browse to the Special:Contributions page on the wiki (enter Special:Contrbiutions into the search box and press Enter) [11:30:13] pranavk_: no error just stuck at Waiting for machine to boot. This may take a few minutes... and after that it gives a timeout error. [11:30:42] does it say connection timed out? [11:30:47] and then retrying...? [11:31:00] pranavk_: people told me to enable vb.gui and i found that the virtual machine is not able to associate with vagrant [11:31:03] tto: I get 503 HTTP error on localhost:8080 in my vagrant wikimedia [11:31:17] tto: can you offer me some guiding on how to debug this, please? [11:31:27] pranavk_:yes it says connection timed out but doesn't retry [11:31:30] victorbarbu_: So you can't browse any pages of the wiki? [11:31:56] tto: if you are talking about the wiki in the vagrant vm, then no, i can't [11:32:12] I haven't made any change to the php code in there [11:33:05] victorbarbu_, can you browse to http://127.0.0.1:8080/info.php [11:33:11] does it work? [11:33:26] tto: that one works, yeah [11:33:55] kartikey0303: if you give it a minute, it should say "retrying..." [11:34:12] this happened to me too, but it automatically gets fixed [11:34:53] victorbarbu_, sounds like you should look at the server error log. I am looking at the Vagrant documentation, and can't see where that log is located. [11:35:07] Is there a file that looks like an error log in the root folder of the vagrant installation? [11:35:11] pranavk_ no it just quits. here is my error https://dpaste.de/ifWc [11:35:51] kartikey0303: i assume you're using virtualbox? [11:35:58] I have rebooted the vm for the third time [11:36:02] and it works now [11:36:03] pranavk_:yes [11:36:19] kartikey0303: try opening virtualbox while you run the vagrant up command [11:36:34] kartikey0303: try to do vagrant halt && vagrant up [11:36:37] this might solve it [11:36:38] i mean, keep the gui open, so you can see if that throws up any errors [11:37:40] pranavk_:it does not displays any error but asks me to login "vagrant-ubuntu-trusty login:" [11:37:51] is your ssh configured? [11:38:12] pranavk_: using vagrant ssh: [11:38:19] pranavk: ? [11:38:54] kartikey0303: try this: [11:39:01] open the Vagrantfile using vim [11:39:33] kartikey0303: on sec, is your virtualization enabled? [11:39:33] pranank_: ok [11:39:43] intel VT-X or AMD-V? [11:40:02] pranavk_: yep i enabled it VT-X [11:40:09] ok [11:40:45] kartikey0303: you said it asks you to log in, right? [11:41:07] pranavk_:yes in the virtual machine when i open the gui [11:41:31] try username: vagrant and password: vagrant [11:42:25] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 5Patch-For-Review: "Page does not exist" title cached in wrong language - https://phabricator.wikimedia.org/T34686#1876224 (10matej_suchanek) [11:42:39] pranavk_: did. it kicks me into the command inside the virtual machine but the actual terminal still displays "waiting for VM to boot" [11:42:52] after that, shut down the vm, and then rerun vagrant up [11:43:08] pranavk_: do you use "sudo vagrant up" [11:43:22] pranavk_: ok will try [11:43:23] no just close virtualbox and git [11:43:33] then reopen both and run vagrant up in git [11:43:45] or vagrant halt and then vagrant up [11:45:39] pranavk_: ok i did. still stuck at waiting for VM to boot [11:45:51] give it some time... [11:46:05] is it just stuck there, or does it show an error? [11:46:23] pranavk_:i think it will show a timeout error [11:46:48] are you running with the gui open? [11:51:06] kartikey0303: are you still there? [11:52:19] kartikey0303: ok... hope it was fixed [12:01:03] (03PS1) 10Aaron Schulz: [WIP] Convert page creation to using startAtomic()/endAtomic() [core] - 10https://gerrit.wikimedia.org/r/258743 (https://phabricator.wikimedia.org/T120718) [12:06:18] 10MediaWiki-JobQueue, 7Wikimedia-log-errors: Fatal exception for type „MWException”on ro.wikibooks when changing time zone - https://phabricator.wikimedia.org/T121325#1876238 (10aaron) 5Open>3Resolved a:3aaron This was due to a brief config error where rdb4 config was listing under a duplicate rdb3 array... [12:21:09] (03PS1) 10Aaron Schulz: [WIP] Convert page modification to using startAtomic()/endAtomic() [core] - 10https://gerrit.wikimedia.org/r/258744 (https://phabricator.wikimedia.org/T120718) [12:21:53] 10MediaWiki-Vagrant: Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876245 (10Ankitashukla) > $ vagrant provision > ==> default: Running provisioner: lsb_check... > ==> default: Running provisioner: puppet... > ==> default: Running Puppet with site.pp... > ==> def... [12:26:03] (03PS1) 10Aaron Schulz: Fix some MWExceptionHandler IDEA errors [core] - 10https://gerrit.wikimedia.org/r/258745 [12:28:01] (03PS1) 10Gerrit Patch Uploader: Remove loading spinner [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258746 [12:28:04] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258746 (owner: 10Gerrit Patch Uploader) [12:29:21] 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1876246 (10He7d3r) The proposed properties were rejecte... [12:29:49] (03CR) 10TheDJ: "There is also an scss lexer in pygments..." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/258694 (https://phabricator.wikimedia.org/T105788) (owner: 10John Vandenberg) [12:32:28] (03CR) 10TheDJ: "oh right. forgot about this:" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/258694 (https://phabricator.wikimedia.org/T105788) (owner: 10John Vandenberg) [12:33:01] legoktm: FlorianSW told me that the entry point warn was only commented out on wikimedia foundation hosted extensions. I looked at the usage matrix of MapSources and it was blank so I asumed it wasnt used. Is there another way to check? [12:35:36] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876250 (10jayvdb) >>! In T114419#1876179, @ori wrote: > I'd like to make a counterproposal, and that is that we abolish mandatory code-review, and instead allow people to exercise dis... [12:37:17] (03PS2) 10Mhutti1: Converted MapSources to new extension registration system [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/258706 (https://phabricator.wikimedia.org/T87939) [12:44:21] (03PS1) 10Aaron Schulz: Move ArticleSaveComplete hook to doCreate()/doModify() methods [core] - 10https://gerrit.wikimedia.org/r/258747 (https://phabricator.wikimedia.org/T120718) [12:44:51] (03PS1) 10Gerrit Patch Uploader: Use mw. instead of mediaWiki. in code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258748 [12:44:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258748 (owner: 10Gerrit Patch Uploader) [12:47:23] * MtDu_ slaps Nemo_bis around a bit with a large fishbot [12:50:00] Nemo_bis: So could you give me a hint on what to do? https://gerrit.wikimedia.org/r/#/c/258698/1/i18n/qqq.json [12:51:25] (03CR) 10jenkins-bot: [V: 04-1] Move ArticleSaveComplete hook to doCreate()/doModify() methods [core] - 10https://gerrit.wikimedia.org/r/258747 (https://phabricator.wikimedia.org/T120718) (owner: 10Aaron Schulz) [12:52:13] :o beatings [12:54:36] Nemo_bis: What do you mean? [12:55:38] pranavk_:are you there? [12:56:00] Please someone help me with this https://dpaste.de/Jb6R [13:01:27] Is MatmaRex here? [13:17:10] Where is form from LogEventsList.php located? [13:17:23] Because I want to localize it but I don't know context of translations [13:18:59] 10MediaWiki-Documentation, 7Documentation, 3Google-Code-In-2015: Add links to corresponding classes on doc.wikimedia.org to Manual pages on mw.org - https://phabricator.wikimedia.org/T120962#1876255 (10NiharikaKohli) Doc.wm.o is auto-generated and hence always up-to-date, as per my information. Yeah, I know... [13:31:03] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/258747 (https://phabricator.wikimedia.org/T120718) (owner: 10Aaron Schulz) [13:32:17] Albert221: I'm not MatmaRex, but what form do you mean? LogEventsList::showOptions()? that's used on Special:Log [13:32:48] someone helped me on #mediawiki-i18n, but thanks :) [13:33:11] 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1876256 (10Stevietheman) I'm surprised the Wikidata peo... [13:33:30] super :D [13:35:02] (03PS1) 10Albert221: Localization: Gave each special page its own message [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) [13:37:33] ok [13:41:19] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 7Wikimedia-log-errors: Error: 2013 Lost connection to MySQL server during query on IndexPager::buildQueryInfo (LogPager) - https://phabricator.wikimedia.org/T121306#1876262 (10tomasz) A database query error has occurred. This may indicate a bug in the softw... [13:41:56] 10MediaWiki-Vagrant: Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876265 (10Ankitashukla) Fixed this finally. I tried: ``` $ cd mediawiki/ $ ls ``` and found out that there was only one file in this directory. After the above error, I had to pull the repos... [13:41:59] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 7Wikimedia-log-errors: Error: 2013 Lost connection to MySQL server during query on IndexPager::buildQueryInfo (LogPager) - https://phabricator.wikimedia.org/T121306#1876266 (10tomasz) A database query error has occurred. This may indicate a bug in the softw... [13:42:46] 10MediaWiki-Vagrant: Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876267 (10Ankitashukla) 5Open>3Resolved a:3Ankitashukla [13:45:16] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 7Wikimedia-log-errors: Error: 2013 Lost connection to MySQL server during query on IndexPager::buildQueryInfo (LogPager) - https://phabricator.wikimedia.org/T121306#1876269 (10jcrespo) Could this be related to the suppression flag condition? Was there somet... [13:56:27] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 7Wikimedia-log-errors: Error: 2013 Lost connection to MySQL server during query on IndexPager::buildQueryInfo (LogPager) - https://phabricator.wikimedia.org/T121306#1876270 (10jcrespo) I see the error on Commons on the logs: ``` { "_index": "logstash-20... [14:00:47] where is the master folder in mediawiki's core folder after I cloned it using git? [14:01:42] abdumuhaimin: what are you referring to as "master"? [14:02:31] the folder. I was searching for a file called classHTMLForm.html in the core folder [14:02:42] I just couldn't find it [14:03:20] well, there is a htmlform.php [14:03:27] are you searching for that? [14:03:31] abdumuhaimin: after you've cloned core, HTMLForm and related classes can be found in /includes/htmlform/ [14:03:35] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 7Wikimedia-log-errors: Error: 2013 Lost connection to MySQL server during query on IndexPager::buildQueryInfo (LogPager) - https://phabricator.wikimedia.org/T121306#1876272 (10tomasz) I managed to perform that suppression at the second try, so it does look... [14:04:32] pranavk_: nope. it is classHTMLForm.html..I am trying to fix the todos to complete my task in the GCI [14:04:51] ashley: thanks. I will try searching for it [14:09:35] I couldn't find the classHTMLForm.html file. How to fix the todos in the page exactly? [14:10:05] abdumuhaimin: can you provide the link of the todo? [14:10:40] pranavk_: sure. here it is: https://doc.wikimedia.org/mediawiki-core/master/php/classHTMLForm.html#aa405c443cd68ec13bed2972b3a75a31c [14:11:11] abdumuhaimin: this is referring to the HTMLForm.php file [14:11:33] i believe the todo is to document one of its functions [14:12:13] the header says "HTMLForm::displaySection ( " [14:12:35] which is the displaySection function in HTMLForm.php [14:12:57] pranavk_: okay. In the task given in the GCI, I have to fix the todos. Is it by commenting in the file? [14:13:17] no, i think you have to document it in a separate file [14:13:36] im not too sure though, so you should check with the mentor for the task on how to go about it [14:14:04] pranavk_: thanks for the help :) [14:14:26] abdumuhaimin: you're welcome! :) [14:17:02] 10MediaWiki-extension-requests, 10WikiProject-X, 10WikiProject-tools, 3Community-Tech-Sprint: Create an extension for storing WikiProject article assessment metadata in a database table via a parser function - https://phabricator.wikimedia.org/T117142#1876275 (10Ricordisamoa) >>! In T42810#460662, @Ricordi... [14:17:42] (03CR) 10Aklapper: [C: 04-1] "After 15 months of no progress/review on this patch, it now has a merge conflict in includes/AutoLoader.php against git master. :(" [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [14:21:00] (03CR) 10Aklapper: [C: 04-1] "Reply to Anomie's last comment is welcome; setting to -1 as this patch now unfortunately has a merge conflict in includes/Xml.php and need" [core] - 10https://gerrit.wikimedia.org/r/144671 (owner: 10IAlex) [14:23:39] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 7Wikimedia-log-errors: Error: 2013 Lost connection to MySQL server during query on IndexPager::buildQueryInfo (LogPager) - https://phabricator.wikimedia.org/T121306#1876277 (10jcrespo) @tomasz, thank you. Also do not doubt to reply/report again if it happen... [14:24:48] (03CR) 10Aklapper: "Alternative implementation: https://gerrit.wikimedia.org/r/#/c/120357/" [core] - 10https://gerrit.wikimedia.org/r/157054 (https://bugzilla.wikimedia.org/53448) (owner: 10Tpt) [14:27:22] (03CR) 10DCausse: [WIP] Collect per-node fetch/query latency percentiles (031 comment) [search/extra] - 10https://gerrit.wikimedia.org/r/258720 (owner: 10EBernhardson) [14:29:58] (03CR) 10Aklapper: "This is about MW Core's EditPage.php hence adding people from Editing (Brion, James) to this 5-liner patch." [core] - 10https://gerrit.wikimedia.org/r/120357 (https://bugzilla.wikimedia.org/53448) (owner: 10Deepali) [14:33:33] (03CR) 10Aklapper: [C: 04-1] "This patch now has a merge conflict in includes/user/User.php and needs manually rebase. :(" [core] - 10https://gerrit.wikimedia.org/r/151651 (owner: 10Withoutaname) [14:43:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thanks! You'll also need to add message documentation to qqq.json (just a brief comment about where the text is used), otherwise the tests" [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) (owner: 10Albert221) [14:43:18] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) (owner: 10Albert221) [14:50:33] (03CR) 10jenkins-bot: [V: 04-1] Localization: Gave each special page its own message [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) (owner: 10Albert221) [14:51:54] AaronSchulz, Hi :) I'm reviewing your change (https://gerrit.wikimedia.org/r/#/c/258729) and it looks reasonable and very good. However, I'm not sure, how I can test the specific bug you want to fix with that :/ I'm not sure, if there are any steps to safely reproduce this? :/ [14:52:07] 10Wikimedia-Extension-setup: Review and deploy DynamicPageListEngine - https://phabricator.wikimedia.org/T90573#1876299 (10Aklapper) [14:52:08] 10Wikimedia-Extension-setup, 6Wiktionary: Extension:DynamicPageListEngine on the English Wiktionary - https://phabricator.wikimedia.org/T117947#1876298 (10Aklapper) [14:52:15] 10Wikimedia-Extension-setup, 6Wiktionary: Extension:DynamicPageListEngine on the English Wiktionary - https://phabricator.wikimedia.org/T117947#1876300 (10Aklapper) p:5Triage>3Lowest [14:53:03] 10MediaWiki-skins-Chameleon, 7Easy: Logo: add nolink attribute - https://phabricator.wikimedia.org/T68859#1876301 (10Aklapper) a:5Haritha28>3None No feedback to last comment hence unassigning. [14:55:06] 7Documentation: Update documentation pointing to 'wikimedia-office' to instead point to 'wikimedia-meeting' - https://phabricator.wikimedia.org/T103405#1876304 (10Aklapper) a:5Haritha28>3None @Haritha28: This issue has been assigned to you a while ago but as this is blocked by unresolved T103402 I'm unassign... [14:56:27] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 7Easy: Quotation marks are low on Jimmy quote - https://phabricator.wikimedia.org/T94049#1876315 (10Aklapper) @Haritha28: This is in the [[ https://www.mediawiki.org/wiki/Extension:DonationInterface | DonationInterface extension ]]. Does that h... [14:58:49] 10Wikipedia-Store: Wikimedia shop branded as 'Wikipedia' store - https://phabricator.wikimedia.org/T106214#1876318 (10Aklapper) @Ppena: Do you know who could answer the question in the latest comments? [15:13:01] (03PS1) 10Martineznovo: Remove wrong usage documentation in comments [core] - 10https://gerrit.wikimedia.org/r/258750 [15:17:06] (03PS2) 10Albert221: Localization: Gave each special page its own message [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) [15:24:36] 10MediaWiki-Configuration, 5Patch-For-Review: PHP 5.6 and 5.5 does not work with Mediawiki 1.26 on Centos 6.6 - https://phabricator.wikimedia.org/T120267#1876324 (10Minddragon) @ori thank you guys for figuring it out :) [15:38:28] 10MediaWiki-extensions-DynamicPageList, 10Gerrit: Move code of DynamicPageListEngine to Gerrit - https://phabricator.wikimedia.org/T90682#1064837 (10Reedy) @RV1971 have you any interest in doing this? And/or maintaining it out of our gerrit instance? [15:39:02] Sup guys. Anyone else waiting for code-in approval? [15:52:47] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876330 (10Ladsgroup) I made about 140 edits today, still db is empty and no "r" beside edits [15:53:04] 10Wikimedia-Extension-setup: Review and deploy DynamicPageListEngine - https://phabricator.wikimedia.org/T90573#1876331 (10Reedy) I've just initially imported it to https://github.com/reedy/DynamicPageListEngine for people to look at the code more easily. Tagged initial v1.0.0 before making any further changes [16:00:48] (03PS1) 10Ed Hoo: [Cargo] #cargo_query Fix issues with quotes and other parsing [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 [16:03:42] (03CR) 10Ed Hoo: "Apologies for not adding the changes in the initial commit message. I was having some issues with the commit. The proposed changes are as" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 (owner: 10Ed Hoo) [16:06:48] 6Discovery, 10Maps: [WikiMaps Warper] Failure on "Edit tab" (Sorry you do not have permission to view that.) - https://phabricator.wikimedia.org/T121344#1876332 (10Alexrk2) 3NEW a:3Chippyy [16:08:02] 6Discovery, 10Maps: [WikiMaps Warper] Failure on "Edit tab" (Sorry you do not have permission to view that.) - https://phabricator.wikimedia.org/T121344#1876341 (10Alexrk2) Screenshot {F3079511} [16:11:20] 6Discovery, 10Maps: [Wikimaps Warper] Edit tab is not available for maps uploaded by other users - https://phabricator.wikimedia.org/T121345#1876342 (10Alexrk2) 3NEW a:3Chippyy [16:14:08] 6Discovery, 10Maps: [Wikimaps Warper] Problem with file names with an apostrophe character - https://phabricator.wikimedia.org/T121346#1876351 (10Alexrk2) 3NEW a:3Chippyy [16:14:59] (03PS1) 10Gerrit Patch Uploader: General usage and syntax fixes for winter.css [winter] - 10https://gerrit.wikimedia.org/r/258755 [16:15:01] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [winter] - 10https://gerrit.wikimedia.org/r/258755 (owner: 10Gerrit Patch Uploader) [16:22:02] (03PS2) 10Ed Hoo: [Cargo] #cargo_query Fix issues with quotes and other parsing [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 [16:23:19] (03PS2) 10GOIII: General usage and syntax fixes for winter.css [winter] - 10https://gerrit.wikimedia.org/r/258755 (owner: 10Gerrit Patch Uploader) [16:31:19] (03CR) 10Glaisher: Change nl_desc to a blob (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/252712 (owner: 10Glaisher) [16:31:41] (03CR) 10GOIII: "well I'll be damned; it's here" [winter] - 10https://gerrit.wikimedia.org/r/258755 (owner: 10Gerrit Patch Uploader) [16:35:28] (03PS4) 10Glaisher: Change nl_desc to a blob [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/252712 [16:36:16] 10Wikimedia-Extension-setup: Review and deploy DynamicPageListEngine - https://phabricator.wikimedia.org/T90573#1876378 (10Reedy) {F3079673} {F3079676} {F3079675} {F3079677} {F3079678} {F3079679} {F3079680} {F3079681} {F3079682} {F3079683} PHPStorm doesn't see anything too bad, but stuff that does wan... [16:43:19] 10Datasets-General-or-Unknown: enwiki-20151201-pages-articles-multistream.xml.bz2 possibly corrupt? - https://phabricator.wikimedia.org/T121348#1876379 (10Reedy) 3NEW [16:43:39] 10Datasets-General-or-Unknown: enwiki-20151201-pages-articles-multistream.xml.bz2 possibly corrupt? - https://phabricator.wikimedia.org/T121348#1876386 (10Reedy) [16:45:37] 10MediaWiki-extensions-Collection: Download as PDF via rdf2latex causes several rendering problems - https://phabricator.wikimedia.org/T121349#1876388 (10Juetho) 3NEW [16:47:26] Hi ionagamed [16:47:49] It seems your message got lost between botchat and nobody replied ;) [16:47:56] There is more activity at #mediawiki right now [16:47:57] 10Datasets-General-or-Unknown, 10Dumps-Generation: enwiki-20151201-pages-articles-multistream.xml.bz2 possibly corrupt? - https://phabricator.wikimedia.org/T121348#1876395 (10Reedy) [16:48:47] irssi, great :) [16:49:13] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876396 (10Halfak) Hey folks. I just got the psuedo-model deployed to staging. Check out http://ores-staging.wmflabs.org/scores/testwiki/reverted/ We should be able to get it on the prod cluster tomorrow. Woot! [16:49:24] ionagamed: you can follow https://meta.wikimedia.org/wiki/IRC/Instructions#Register_your_nickname.2C_identify.2C_and_enforce to register your nickname [16:49:32] With irssi it's also rather simple to use SASL [16:50:26] 6Revscoring: Deploy tuned random forest model for wikidatawiki - https://phabricator.wikimedia.org/T121350#1876397 (10Halfak) 3NEW a:3Halfak [16:50:57] 6Revscoring: Deploy tuned random forest model for wikidatawiki - https://phabricator.wikimedia.org/T121350#1876406 (10Halfak) This is now up on staging. See http://ores-staging.wmflabs.org/scores/wikidatawiki/ [16:51:54] 6Revscoring: Deploy tuned random forest model for wikidatawiki - https://phabricator.wikimedia.org/T121350#1876397 (10Halfak) @YuviPanda, this change got lumped up with a few new things for ORES, so I'll want to have you somewhat close by when I deploy. [16:57:17] 10MediaWiki-extensions-DynamicPageList, 10Gerrit: Move code of DynamicPageListEngine to Gerrit - https://phabricator.wikimedia.org/T90682#1876410 (10RV1971) I do have an interest, but I'm afraid currently I can't tell when I'll have time to do that. [16:57:22] Nemo_bis: Can you change the IRC task to ask students to log on to #mediawiki instead? This channel is great to intimidate new students. [16:58:39] Niharika: the task mentions both, I think a majority of students join both [16:59:01] And often they don't get a reply on #mediawiki by European night. Sometimes they even ask more channels. :) [16:59:29] But yes, I guess not many interact with the bots or click links. [16:59:45] Nemo_bis: I've seen more students join this one and their messages get no response between all the bot chat. [17:00:35] I guess this one is mentioned first. [17:00:35] <_atg> I'm starting to do some things on the todo list. Some of these items involve redocumenting some items inside DefaultSettings.php, which has a warning on top not to edit. It says the changes will get deleted by next upgrade. Am I allowed to make these documenting changes? [17:01:03] Niharika: Hmm I don't know, I think this was the first case where the student didn't get a reply [17:01:27] _atg: good question. The warning at the top is for site administrators, not for developers. [17:01:56] _atg: because when you install MediaWiki you should override the defaults by writing your own configuration in LocalSettings. DefaultSettings.php is the developers' realm! [17:02:13] This was the 3rd/4th person I see leaving after saying a Hi and idling a few minutes for a reply. [17:02:54] <_atg> Nemo_bis: Ok, thanks! [17:03:33] yo Boyz [17:04:50] I am Etama D Raizel the nobless of all vampires of 21th CE please bear with me since I am 4000 years old [17:05:08] EtramaDRaizel: you must have run a lot of wikis in this long time! [17:05:57] Niharika: on the other hand this channel is more instructive if the students actually follow what happens. The task shouldn't be *only* chat. ;) [17:06:33] of course ... i was always online beneath my coffin!! [17:06:39] EtramaDRaizel: I sure hope you're not another spammer. We seem to get them a lot. [17:07:02] nope i am definatly not a spammer ... [17:07:04] Niharika: I put #mediawiki first now [17:07:20] Nemo_bis: Hmm, true but if you were 14 and I asked you to look at this channel's log, what would you make of it? :P [17:07:34] but in case u need to clear any doubts about vapires you can always call me [17:08:01] Niharika: dunno, at 14 I would probably have clicked all links and ended up reading all the docs of Phabricator and Gerrit [17:08:28] EtramaDRaizel: that's very useful, do you write down all your knowledge in cc-by-sa to ensure it's free for eternity? [17:08:36] Interesting. I dunno what I'd have done. My first IRC experience was horrid. [17:08:43] EtramaDRaizel: you have plenty of time, clearly, and the copyright term in your case is quite extensive [17:09:22] of course i cannot allow mere mortals like you steal my knowledge jus like that ///can i?? [17:10:04] EtramaDRaizel: Were you one of the sidekicks in Twilight? [17:11:02] no definatly not .. how dare you a mere mortals disgrace me by comparing with uncultured racoons like them [17:12:23] Niharika: v nobless are of totally different kind we can survive without drinking blood...... [17:12:42] as a matter of fact i am pure vegan [17:13:01] EtramaDRaizel: Bah, you're not a vampire by definition. [17:13:26] EtramaDRaizel: I'm preetty sure moral rights apply to vampires as well. However extended copyright discussions should move to #wikimedia [17:21:40] so ppl what to do for this codewithgoogle [17:23:39] * EtramaDRaizel scares everyone out of IRC [17:24:22] <_atg> I am deprecating a value in DefaultSettings for a todo item. What version number should I put for @deprecated? [17:25:15] _atg: we're currently developing 1.27 [17:26:00] <_atg> Nemo_bis: ok thanks. Sorry for all the questions, i'm really new to this kind of development [17:26:02] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876411 (10matmarex) @Isarra Yeah, what @Whatamidoing-WMF said. It might be a good idea to make t... [17:28:14] (03PS4) 10Paladox: Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [17:29:09] (03PS5) 10Paladox: Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) [17:36:11] _atg: sure, that's the point of GCI [17:36:24] (03PS1) 10Glaisher: Add confirmation dialog to newsletter deletion form [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/258764 [17:37:01] (03PS2) 10Glaisher: Add confirmation dialog to newsletter deletion form [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/258764 [17:38:33] (03PS3) 10Glaisher: Add confirmation dialog to newsletter deletion form [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/258764 [17:40:11] (03PS1) 10Umherirrender: No prefix suggestion of special and media namespace on special pages [core] - 10https://gerrit.wikimedia.org/r/258765 [17:40:29] 10MediaWiki-extensions-SemanticForms, 5Patch-For-Review: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1876420 (10saper) 5Resolved>3Open Reopening. This is still present in git master: ````php // create calls to JS initia... [17:40:35] 10MediaWiki-extensions-Newsletter, 10Continuous-Integration-Config: Migrate mediawiki/extensions/Newsletter tests to use npm and grunt jsonlint/jshin - https://phabricator.wikimedia.org/T121352#1876422 (10Glaisher) 3NEW [17:41:29] EtramaDRaizel: if you were about 3990 years younger, you could pick up one of those https://codein.withgoogle.com/tasks/?sp-status=2&sp-is_exhausted=False [17:41:34] (03CR) 10Umherirrender: "See I8978e3bd0783f62bc25b32a0fdaa90361abefcf3 for the fix of the recursion" [core] - 10https://gerrit.wikimedia.org/r/257197 (owner: 10Umherirrender) [17:43:18] 10MediaWiki-extensions-SemanticForms, 5Patch-For-Review: Uncaught ReferenceError: jQuery is not defined with action=formedit on MW 1.26 - https://phabricator.wikimedia.org/T121221#1876429 (10Paladox) Where is the file that has that code. Because I have this patch https://gerrit.wikimedia.org/r/#/c/258688/ [17:51:26] (03CR) 10EBernhardson: [WIP] Collect per-node fetch/query latency percentiles (031 comment) [search/extra] - 10https://gerrit.wikimedia.org/r/258720 (owner: 10EBernhardson) [17:55:18] wow [17:56:58] (03CR) 10GOIII: [C: 031] Replace format-bold-ru.png image [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [18:00:21] (03CR) 10Paladox: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258748 (owner: 10Gerrit Patch Uploader) [18:00:55] (03CR) 10Paladox: "Thanks." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/257978 (https://phabricator.wikimedia.org/T119716) (owner: 10Paladox) [18:03:44] (03CR) 10GOIII: [C: 031] Use mw. instead of mediaWiki. in code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258748 (owner: 10Gerrit Patch Uploader) [18:04:47] (03CR) 10Paladox: [C: 031] Use mw. instead of mediaWiki. in code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258748 (owner: 10Gerrit Patch Uploader) [18:07:17] FlorianSW: I am updating another MapSources but legoktm told me to comment out the warn code MapSources.php I looked up the usage matrix and it was empty so how can I know if its used in wikimedia https://wikiapiary.com/wiki/Extension:Mapsources [18:08:42] (03PS3) 10Paladox: Use the same icon as the russian for the ukraine [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258674 (https://phabricator.wikimedia.org/T25914) [18:09:28] FlorianSW: Never mind was searching Mapsources not MapSources... [18:14:01] yes [18:14:03] bye bye [18:15:54] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 3Fundraising Sprint Zapp: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1876445 (10MBeat33) The donor in #188074 gets this error across multiple browsers: OS: Windows 7 Professiona... [18:19:15] mhutti1, sorry, haven't seen your comment :) Is your question answered? [18:19:30] FlorianSW: Yeah thanks# [18:19:44] great! :) [18:23:13] (03CR) 10GOIII: [C: 031] Use the same icon as the russian for the ukraine [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258674 (https://phabricator.wikimedia.org/T25914) (owner: 10Paladox) [18:26:32] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876446 (10awight) > I changed $wgOresDamagingThreshold to 0.3 and no change, Also the the table is still empty: Okay, that's a step behind where I imagined we were. The tricky thing about running a test instance is that you'l... [18:27:50] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876447 (10matmarex) @Tgr According to this query (and assuming that it is correct): ```lang=sq... [18:48:33] Is there support for using normal bind mounts when using MediaWiki-Vagrant with LXC? I'm having trouble getting NFS to work. [18:56:07] ah setting `nfs_shares` causes a fallback to "synced folders". [18:58:19] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint 2, 5Patch-For-Review, 7WorkType-Maintenance: Dialects without Wikipedias are still prompted for translation in sidebar - https://phabricator.wikimedia.org/T113945#1876470 (10He7d3r) When is this going live on Portugue... [19:07:38] 10MediaWiki-File-management, 6Commons, 6Multimedia, 7Easy: Download this file link on description page (particularly relevant to svg) - https://phabricator.wikimedia.org/T27148#1876483 (10Kartikey0303) I am new to open source community. Can i try to work on this bug? [19:18:42] (03PS1) 10Unicornisaurous: Show the number of MassAction jobs queued on Special:Statistics [extensions/MassAction] - 10https://gerrit.wikimedia.org/r/258769 (https://phabricator.wikimedia.org/T96562) [19:22:07] (03PS1) 10Amire80: Fix spelling in EXIF message: seperated -> separated [core] - 10https://gerrit.wikimedia.org/r/258770 [19:37:43] ? whats with all the reconnects? [19:37:55] (03PS7) 10Christopher Johnson (WMDE): adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 [19:43:39] (03CR) 10Raimond Spekking: [C: 032] Fix spelling in EXIF message: seperated -> separated [core] - 10https://gerrit.wikimedia.org/r/258770 (owner: 10Amire80) [19:46:54] 6Security-Team: Review access to security tasks - https://phabricator.wikimedia.org/T97869#1876510 (10Krenair) So that just leaves Eloquence, and somebody figuring out what the status behind Mark's NDA is. [19:50:03] (03CR) 10Christopher Johnson (WMDE): adds dataTables (035 comments) [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [19:51:28] (03Merged) 10jenkins-bot: Fix spelling in EXIF message: seperated -> separated [core] - 10https://gerrit.wikimedia.org/r/258770 (owner: 10Amire80) [19:52:00] 10MediaWiki-Vagrant, 7Pywikibot-General: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty - https://phabricator.wikimedia.org/T121326#1876511 (10jayvdb) [19:53:07] 7Design, 10MediaWiki-General-or-Unknown, 10WikiEditor: "Show edit toolbar" preference is confusing - https://phabricator.wikimedia.org/T32795#1876514 (10Paladox) Adding MediaWiki-General-or-Unknown project since the messages are in the mediawiki core. [19:53:22] (03CR) 10Christopher Johnson (WMDE): "Increased result to 50. Added explorer link and offset it from the link by two non-breaking spaces. Took care of most issues in patch se" [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [19:57:44] 10MediaWiki-Page-editing, 7JavaScript: Move classic (old) edit toolbar (from module mediawiki.action.edit) into an extension - https://phabricator.wikimedia.org/T30856#1876518 (10Paladox) What would the edit bar be replaced with once the old bar is moved into its own extensions. [19:59:17] (03PS1) 10Raimond Spekking: Add i18n file [extensions/NotebookViewer] - 10https://gerrit.wikimedia.org/r/258773 [20:02:27] 10MediaWiki-Vagrant, 7Pywikibot-General: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty - https://phabricator.wikimedia.org/T121326#1876522 (10jayvdb) Another option is to install using `python setup.py install` But given that trusty is our default platform it makes sense to d... [20:03:22] (03PS1) 10AndyTechGuy: Change documentation of formatTimePeriod [core] - 10https://gerrit.wikimedia.org/r/258774 [20:09:21] (03PS1) 10Raimond Spekking: Remove unused message [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/258775 [20:09:38] (03CR) 10jenkins-bot: [V: 04-1] Remove unused message [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/258775 (owner: 10Raimond Spekking) [20:09:40] (03CR) 10Florianschmidtwelzow: [C: 031] Avoid "CAS updated failed" errors on Special:Preferences double post [core] - 10https://gerrit.wikimedia.org/r/258729 (https://phabricator.wikimedia.org/T95839) (owner: 10Aaron Schulz) [20:10:45] (03PS2) 10Raimond Spekking: Remove unused message [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/258775 [20:15:45] legoktm: in fixing T22189 , I'm starting with some code authored by someone else. Should I squash my changes into theirs, leaving only one commit, before submitting for review? Or is it better to submit them as two commits in one review and just squash before merging? [20:16:21] 6Revscoring: Live test of ORES extension - https://phabricator.wikimedia.org/T118039#1876526 (10Halfak) New models are up on ores.wmflabs.org http://ores.wmflabs.org/scores/testwiki/reverted/?revids=1|2|3|4|5|6|7|8|9 ``` { "1": { "prediction": false, "probabilities": { "false": 0.9, "true"... [20:22:55] (03CR) 10jenkins-bot: [V: 04-1] adds dataTables [wikidata/query/rdf] - 10https://gerrit.wikimedia.org/r/257830 (owner: 10Christopher Johnson (WMDE)) [20:23:17] https://github.com/wikimedia/mediawiki/pull/42 [20:23:19] 10MediaWiki-Page-editing, 7JavaScript: Move classic (old) edit toolbar (from module mediawiki.action.edit) into an extension - https://phabricator.wikimedia.org/T30856#1876527 (10Aklapper) @Paladox: [[ https://www.mediawiki.org/wiki/Extension:WikiEditor | WikiEditor ]]. [20:23:24] I remember that guy [20:23:40] he came onto here and called us clowns because he couldn't figure out what a $PATH was [20:25:18] (03PS1) 10Raimond Spekking: Rephrase description message [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/258777 [20:26:00] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools: Add checkboxes for revision deletion on Special:Contributions, Special:DeletedContributions, and Special:Undelete - https://phabricator.wikimedia.org/T22189#1876535 (10lfaraone) For deleted pages, do we want to show checkbo... [20:26:09] 10MediaWiki-Page-editing, 7JavaScript: Move classic (old) edit toolbar (from module mediawiki.action.edit) into an extension - https://phabricator.wikimedia.org/T30856#1876536 (10Paladox) Oh but what about a built in toolbar that would mean that there would be no tool bar if the old bar was too move out into i... [20:26:37] 10TaxonBot: Development of Category Handler (dewiki) - https://phabricator.wikimedia.org/T121299#1876541 (10doctaxon) [20:28:30] (03CR) 10Alex Monk: [C: 032] No prefix suggestion of special and media namespace on special pages [core] - 10https://gerrit.wikimedia.org/r/258765 (owner: 10Umherirrender) [20:30:49] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools: Add checkboxes for revision deletion on Special:Contributions, Special:DeletedContributions, and Special:Undelete - https://phabricator.wikimedia.org/T22189#1876543 (10Krenair) >>! In T22189#1876535, @lfaraone wrote: > I'd... [20:32:00] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1876544 (10lfaraone) [20:32:51] (03CR) 10MarkAHershberger: [C: 032] "Well, I suppose I can ok it." [tools/messdetector] - 10https://gerrit.wikimedia.org/r/206829 (owner: 10MarkAHershberger) [20:33:00] 10Phabricator-Upstream, 7Security-General, 7Upstream: Ensure Phab upstream deprecations (_WILLEDITTASK and _DIDEDITTASK) don't compromise our security - https://phabricator.wikimedia.org/T120016#1876545 (10Krenair) >>! In T120016#1876028, @Luke081515 wrote: > At first: I thinked that we can disable the heral... [20:33:27] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages: Allow changing visibility of multiple revisions on Special:Contributions - https://phabricator.wikimedia.org/T121297#1876546 (10lfaraone) 5duplicate>3Open [20:33:57] 4(no projects): Cannot cursor out of a unicorned annotation - https://phabricator.wikimedia.org/T121357#1876549 (10dchan) 3NEW [20:36:00] (03Merged) 10jenkins-bot: No prefix suggestion of special and media namespace on special pages [core] - 10https://gerrit.wikimedia.org/r/258765 (owner: 10Umherirrender) [20:36:42] lfaraone: squash your changes into theirs [20:36:47] kk [20:38:50] wikimedia should move to hhvm and xhp [20:39:22] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages: Allow changing visibility of multiple revisions on Special:Contributions/DeletedContributions - https://phabricator.wikimedia.org/T121297#1876559 (10Krenair) [20:41:10] 10MediaWiki-File-management, 6Commons, 6Multimedia, 7Easy: Download this file link on description page (particularly relevant to svg) - https://phabricator.wikimedia.org/T27148#1876561 (10Aklapper) @Kartikey0303: Welcome! In general, please see [[ https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_h... [20:41:38] victorbarbu_: Wikimedia is already mostly on HHVM, why XHP? [20:42:06] because it would allow creation of custom component and xml syntax for php [20:42:49] anomie: if api.php gives both 'continue' and 'batchcomplete' in the result… that's a bug, right? [20:43:05] so, instead of having to work with strings, html would become xml [20:43:09] anomie: https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&list=usercontribs&format=json&uclimit=max&ucuser=!%20Bikkit%20!%7C!ptitbiscuit%7C%26bahn%7C(-MEDIAJACK-)%7C(66666)%20Cernunnos%7C(C)enci10%7C(dwt).&ucdir=newer&ucprop=title%7Ctimestamp%7Ccomment%7Ctags [20:43:09] so...XHP [20:43:44] 6MediaWiki-Stakeholders-Group, 10Wikimedia-Developer-Summit-2016, 3DevRel-December-2015: Meeting with MW Stakeholders and WMF - https://phabricator.wikimedia.org/T119403#1876564 (10MarkAHershberger) Aklapper writes: >> I'll ask the others for feedback. > > Has that happened? :) Yes. We're going to be coll... [20:44:45] victorbarbu_, wait, you're proposing changing the output format for page views from html to something else? [20:45:20] Krenair: https://www.facebook.com/notes/facebook-engineering/xhp-a-new-way-to-write-php/294003943919/ no [20:45:27] this is what I am saying [20:46:12] 10Wikimedia-General-or-Unknown: Results of "External links search" in hewiki DB can show incorrect links/matches - https://phabricator.wikimedia.org/T121353#1876565 (10Aklapper) [20:47:14] 10MediaWiki-extensions-DynamicPageList, 10Gerrit: Move code of DynamicPageListEngine to Gerrit - https://phabricator.wikimedia.org/T90682#1876575 (10Aklapper) See https://www.mediawiki.org/wiki/Git/New_repositories/Requests for more info [20:48:43] 10MediaWiki-Page-editing, 7JavaScript: Move classic (old) edit toolbar (from module mediawiki.action.edit) into an extension - https://phabricator.wikimedia.org/T30856#1876579 (10Ricordisamoa) >>! In T30856#1876536, @Paladox wrote: > Oh but what about a built in toolbar that would mean that there would be no t... [20:49:01] victorbarbu_, it sounds like you wouldn't be able to use that code with normal php interpreters [20:49:03] (03PS1) 10LFaraone: Initial implementation of Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/258779 [20:49:49] you said that wikimedia is already mostly using hhvm. hhvm from facebook added xhp to php and hack [20:50:07] so, the php interpreter would be hhvm [20:50:26] 10MediaWiki-extensions-Collection: Download as PDF via rdf2latex causes several rendering problems - https://phabricator.wikimedia.org/T121349#1876584 (10Aklapper) Hi @Juetho, thanks for taking the time to report this! Please include only one problem per report. See https://www.mediawiki.org/wiki/How_to_report_... [20:50:33] 10MediaWiki-Vagrant: Vagrant Up throwing a lot of errors on LInux Mint - https://phabricator.wikimedia.org/T121339#1876586 (10Legoktm) Awesome! [20:50:43] victorbarbu_, but we don't only support hhvm [20:50:49] it would mean a complete codebase rewrite, but the readability would be improved [20:50:52] 10Phabricator-Upstream, 7Security-General, 7Upstream: Ensure Phab upstream deprecations (_WILLEDITTASK and _DIDEDITTASK) don't compromise our security - https://phabricator.wikimedia.org/T120016#1876587 (10Luke081515) @Krenair Sorry, I mean not in this direction. I mean: # You create a task # You decide "loo... [20:51:14] not only does wikimedia have a couple of non-hhvm servers, wikimedia is not the only users of the core software e.g. mediawiki [20:51:40] 6Discovery, 10Maps: [Wikimaps Warper] Edit tab is not available for maps uploaded by other users - https://phabricator.wikimedia.org/T121345#1876589 (10Aklapper) > In Wikimaps Warper Where is "Wikimaps Warper"? [[ https://www.mediawiki.org/wiki/How_to_report_a_bug | Clear steps to reproduce are welcome. ]] Th... [20:51:41] yeah, that's true [20:52:23] 10Phabricator-Upstream, 7Security-General, 7Upstream: Ensure Phab upstream deprecations (_WILLEDITTASK and _DIDEDITTASK) don't compromise our security - https://phabricator.wikimedia.org/T120016#1876592 (10Krenair) Yeah, using the spaces system is a non-starter. [20:52:50] however, I am impressed with what facebook created. and they have successfully rewritten 10 million lines codebase to hack and xhp. that's impressive [20:53:39] they presumably employ a lot more engineers than the number of developers working on mediawiki [20:53:59] yeah, that's also true, but still impressive. [20:54:09] Krenair: I am trying to solve this todo here https://doc.wikimedia.org/mediawiki-core/master/php/todo.html#_todo000143 [20:54:15] 10Phabricator-Upstream, 7Security-General, 7Upstream: Ensure Phab upstream deprecations (_WILLEDITTASK and _DIDEDITTASK) don't compromise our security - https://phabricator.wikimedia.org/T120016#1876593 (10Luke081515) So it would be better to choose the ways at my first comment (or others, but I don't know o... [20:56:36] I have changed the first parameter of Html::rawElement (SpecialContributors.php, line 1125) to 'tr' and modified both getStartBody and getEndBody to create `` and `
` repectively, now the list is created before the table on the page. [20:57:27] basically, there is no error, but the page just does not have the correct markup anymore. [20:57:33] how can I debug this? [20:57:39] and perhaps fix it [20:58:32] (03PS2) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [20:59:35] (03PS3) 10Alex Monk: Allow easy suppression of multiple deleted revs on Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:00:04] 6Revscoring: Update french language utilities with expanded badword/informals - https://phabricator.wikimedia.org/T121358#1876597 (10Halfak) 3NEW a:3Halfak [21:00:28] legoktm: Can you review my changes pls :) https://gerrit.wikimedia.org/r/#/c/258706/ [21:00:43] Krenair: is there a linter I should be using, or something? stylize.php seems to be only for new code. [21:00:50] *new files [21:02:39] phplint does run [21:03:01] I think there's something I have to do to authorise a full test on jenkins [21:04:29] (03CR) 10jenkins-bot: [V: 04-1] Allow easy suppression of multiple deleted revs on Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:04:40] (03CR) 10Alex Monk: [C: 031] "this isn't ready to go in, but +1ing to get jenkins to run the full tests" [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:04:59] (03CR) 10Alex Monk: "oh I see, it ran them when I updated the commit message :/" [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:05:03] Krenair: I think your push -- yeah that. [21:05:28] 'Recheck' ? [21:05:29] we can whitelist lfaraone if we trust him [21:05:32] do we? ;) [21:06:23] (03PS1) 10Paladox: Localise the signiture code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [21:06:32] lfaraone, yeah, so phpcs catches these things [21:07:29] (03PS2) 10Paladox: Localise the signiture code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) [21:09:00] (03PS4) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [21:09:29] legoktm: I solemnly swear I am up to no good. [21:10:56] mhutti1: looking now [21:11:51] legoktm: Cool :) [21:11:56] (03CR) 10Alex Monk: Allow easy suppression of multiple deleted revs (035 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:12:18] did you add chris to the reviewer list lfaraone? [21:12:24] Krenair: yeah [21:12:25] lfaraone: ok, jenkins will run the full suite of tests for any patches uploaded from now on [21:12:31] ok. . . [21:15:24] (03CR) 10Alex Monk: Allow easy suppression of multiple deleted revs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:15:40] lfaraone, sorry for being nitpicky [21:16:16] (03PS3) 10Legoktm: Converted MapSources to new extension registration system [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/258706 (https://phabricator.wikimedia.org/T87939) (owner: 10Mhutti1) [21:16:22] (03CR) 10Legoktm: [C: 032] Converted MapSources to new extension registration system [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/258706 (https://phabricator.wikimedia.org/T87939) (owner: 10Mhutti1) [21:16:33] (03PS5) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [21:18:02] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (033 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:19:28] (03Merged) 10jenkins-bot: Converted MapSources to new extension registration system [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/258706 (https://phabricator.wikimedia.org/T87939) (owner: 10Mhutti1) [21:19:44] 10MediaWiki-Configuration, 5Patch-For-Review, 7Tracking: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875#1876644 (10Legoktm) [21:19:46] 10MediaWiki-extensions-MapSources, 3Google-Code-In-2015, 5Patch-For-Review: Convert MapSources to use extension registration - https://phabricator.wikimedia.org/T87939#1876643 (10Legoktm) 5Open>3Resolved [21:20:50] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools, 5Patch-For-Review: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1876652 (10Krenair) >>! In T22189#1876535, @lfaraone wrote: > For deleted pages, do we want to show checkboxes + cha... [21:20:53] 10MediaWiki-Logging, 5Patch-For-Review: Find some way to regroup related multiple low-activity log types - https://phabricator.wikimedia.org/T121177#1876653 (10Cenarium) [21:25:40] 10MediaWiki-extensions-ContentTranslation, 10Unplanned-Sprint-Work, 3LE-CX7-Sprint 4, 5Patch-For-Review, and 2 others: Infinite redirect loop when trying to re-translate article after deleting draft - https://phabricator.wikimedia.org/T121116#1876655 (10Amire80) [21:25:46] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: References are not getting updated cleanly - https://phabricator.wikimedia.org/T121093#1876656 (10Amire80) [21:25:53] Krenair: is there a standard function to encode a mediawiki title for a URL? and/or a better way for me to construct the special page URL… [21:26:04] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 3LE-CX7-Sprint 4, 5Patch-For-Review, 7WorkType-NewFunctionality: Multiple paragraphs in a section causes data loss on restoration - https://phabricator.wikimedia.org/T121092#1876657 (10Amire80) [21:26:13] 10MediaWiki-extensions-ContentTranslation, 10ContentTranslation-Deployments, 10ContentTranslation-cxserver, 7Technical-Debt, 7WorkType-Maintenance: Switch cxserver to use Node.js 4.2 (ie > 0.10.x) - https://phabricator.wikimedia.org/T121072#1876659 (10Amire80) [21:26:17] lfaraone: mw.Title#getUrl [21:26:22] 10MediaWiki-extensions-ContentTranslation, 10Continuous-Integration-Infrastructure, 10Wikidata, 7Jenkins, 7WorkType-Maintenance: Wikibase Qunit test fails with CX + ULS - https://phabricator.wikimedia.org/T120907#1876661 (10Amire80) [21:26:30] lfaraone: or, mw.util.getUrl [21:28:46] MatmaRex, this is on the server side [21:28:48] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Featured-based suggestions should be a fallback of personalised suggestions - https://phabricator.wikimedia.org/T121227#1876663 (10Amire80) p:5Triage>3Normal [21:28:57] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Adjust suggestion refresh transition - https://phabricator.wikimedia.org/T121230#1876665 (10Amire80) p:5Triage>3Low [21:29:14] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Switching the suggestions languages while loading results in an inconsistent list - https://phabricator.wikimedia.org/T121226#1876667 (10Amire80) p:5Triage>3Normal [21:29:20] lfaraone, wfUrlencode [21:29:23] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Prevent users from selecting the same source and target language for suggestions - https://phabricator.wikimedia.org/T121225#1876670 (10Amire80) p:5Triage>3Normal [21:29:32] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Show a smaller but constant number of suggestions at a time - https://phabricator.wikimedia.org/T121224#1876672 (10Amire80) [21:29:50] Krenair: lfaraone: Title::getLocalURL(), then [21:30:01] SpecialPage::getTitleFor(...)->getLocalURL() [21:30:04] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Make refresh suggestion action more prominent - https://phabricator.wikimedia.org/T121223#1876674 (10Amire80) p:5Triage>3Normal [21:30:06] 10MediaWiki-extensions-EducationProgram: Use a single log (log_type) for any Education Program log_action - https://phabricator.wikimedia.org/T47755#1876676 (10Cenarium) [21:30:21] 7Design, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Refreshing suggestions should always show different suggestions - https://phabricator.wikimedia.org/T121222#1876678 (10Amire80) p:5Triage>3Normal [21:30:36] MatmaRex, legoktm: we only want the title itself [21:30:41] not the full URL [21:30:51] oh... [21:30:54] It's to go in the 'target' parameter to Special:RevisionDelete [21:31:01] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876683 (10Aklapper) >>! In T114419#1863829, @Qgil wrote: > The investigation needed is to know what is the expected outcome of this session, and how @Aklapper's T101686 and T78768 fit... [21:31:09] Krenair: oh, do we want to make that redirect use getLocalURL instead of getFullURL, by the by? [21:31:17] (03CR) 10Cindy-the-browser-test-bot: "features/frozen_index_api.feature:30" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/258799 (owner: 10L10n-bot) [21:31:20] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876685 (10Aklapper) >>! In T114419#1872365, @bawolff wrote: > As for {T78768} > While originally my intended focus for this meeting was volunteers, after discussions with various peop... [21:31:50] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-NewFunctionality: Make dashboard views linkable and resistant to refresh - https://phabricator.wikimedia.org/T121219#1876687 (10Amire80) p:5Triage>3Normal [21:32:23] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Show a loading indicator for ContentTranslation suggestions - https://phabricator.wikimedia.org/T121218#1876689 (10Amire80) p:5Triage>3Normal [21:33:15] 10Diffusion, 6Repository-Admins: Connect/Link Phabricator/Maniphest projects to Diffusion repositories - https://phabricator.wikimedia.org/T120915#1876692 (10Luke081515) p:5Triage>3Low [21:35:12] 10MediaWiki-extensions-ContentTranslation, 7WorkType-Maintenance: References are not getting updated cleanly - https://phabricator.wikimedia.org/T121093#1876695 (10Amire80) The screenshot looks incorrect for several reasons - the paragraph appears twice, there is no section alignment, and the references are nu... [21:36:02] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (033 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:36:08] (03PS6) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [21:36:52] lfaraone, I think either is fine [21:36:56] (03CR) 10DennisRoczek: [C: 032 V: 032] "Thanks. Yes you are right. :-)" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/258777 (owner: 10Raimond Spekking) [21:38:56] (03CR) 10Alex Monk: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:42:44] (03CR) 10jenkins-bot: [V: 04-1] Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:46:56] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [21:47:04] (03PS7) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [21:47:41] 10MassAction, 3Google-Code-In-2015: Special:MassAction should have a box allowing selection of Task to view - https://phabricator.wikimedia.org/T96411#1876713 (10Mhutti1) a:3Mhutti1 [21:48:13] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools, 5Patch-For-Review: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1876714 (10lfaraone) OK, so users with `deleterevision` will see checkboxes. SGTM. [21:49:14] Krenair: and no worries on being pedantic; I appreciate it. I'm new to the codebase :) [21:49:26] great :) [21:49:30] some people aren't so happy about it [21:50:21] I'm equally pedantic at work :P [21:50:31] haha [21:51:52] (03CR) 10Ori.livneh: "Reminder -- this can be removed now." [core] - 10https://gerrit.wikimedia.org/r/185583 (owner: 10Trevor Parscal) [21:52:38] (03CR) 10Bartosz Dziewoński: [C: 032] Localization: Gave each special page its own message [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) (owner: 10Albert221) [21:53:27] I'm not actually clear as to why RevisionDelete cares about the page title, except to do things like show you the suppression log. [21:54:14] If I amend it to accept revisions from multiple titles, should the UI show the union of all the logs or not show the log at all? (possibly an expensive query?) [21:55:11] 10MediaWiki-extensions-DynamicPageList, 10Gerrit: Move code of DynamicPageListEngine to Gerrit - https://phabricator.wikimedia.org/T90682#1876725 (10Reedy) I've imported it to github, and started doing some cosmetic cleanup etc in https://github.com/reedy/DynamicPageListEngine If wanted, we can just push this... [21:57:03] lfaraone: I would list the logs for each page grouped under its title [21:57:40] 10MediaWiki-Revision-deletion, 7Easy: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1876726 (10lfaraone) a:3lfaraone [21:58:55] (03Merged) 10jenkins-bot: Localization: Gave each special page its own message [core] - 10https://gerrit.wikimedia.org/r/258749 (https://phabricator.wikimedia.org/T45502) (owner: 10Albert221) [21:58:56] 10MediaWiki-extensions-Gadgets, 10Analytics: Track the GadgetUsage statistics over time - https://phabricator.wikimedia.org/T121049#1876727 (10Quiddity) I don't have advice/preferences on how to render the data. Simpler (e.g. raw csv monthly dumps, for now) is probably better than nothing. Please boldly edit... [21:59:59] (03CR) 10Reedy: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [22:02:01] (03PS1) 10Ori.livneh: Remove wfGetIP(), deprecated since 1.19 [core] - 10https://gerrit.wikimedia.org/r/258892 [22:02:02] (03PS1) 10Ori.livneh: Remove wfIsTrustedProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258893 [22:02:04] (03PS1) 10Ori.livneh: Remove wfDebugTimer(), deprecated in 1.25 [core] - 10https://gerrit.wikimedia.org/r/258894 [22:02:07] (03PS1) 10Ori.livneh: Remove wfIsConfiguredProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258895 [22:02:38] ori: Do I need to go check for uses? :P [22:02:44] check the commit messages [22:03:15] Sounds like effort [22:03:24] i checked for usage and linked to the search results [22:03:30] :) [22:03:37] no remaining users for any of the ones i submitted [22:03:50] 6Developer-Relations, 3DevRel-February-2016: Have a second Gerrit (Code Review backlog) cleanup day - https://phabricator.wikimedia.org/T115844#1876739 (10Aklapper) [22:03:53] I'm gonna sanity check the first one using a different tool [22:04:18] ori: Are you going to do a single Release notes commit for them all? [22:04:53] Do you think it would be worth it? There are literally *no* remaining users for any of these. [22:05:06] WikiLexicalData has a usage of wfGetIP, but it's commented out [22:05:06] third-partyyyyy [22:05:08] I guess not everything is in Wikimedia's git repos, so sure, I'll add one at the end [22:05:09] yeah [22:05:22] Reedy: if it's commented out it's not usage ;) [22:05:26] (03PS2) 10Reedy: Remove wfGetIP(), deprecated since 1.19 [core] - 10https://gerrit.wikimedia.org/r/258892 (owner: 10Ori.livneh) [22:05:47] (03CR) 10Reedy: [C: 032] "Confirmed deaded in WMF hosted repos. RELEASE-NOTES to come later" [core] - 10https://gerrit.wikimedia.org/r/258892 (owner: 10Ori.livneh) [22:05:51] 6Developer-Relations, 3DevRel-February-2016: Have a second Gerrit (Code Review backlog) cleanup day - https://phabricator.wikimedia.org/T115844#1876741 (10Aklapper) I've moved this from January to February because I don't see having time for this in January, and I'd like to concentrate first on improving the u... [22:05:59] ori: hey, if you're already here, can you quickly sanity-check https://gerrit.wikimedia.org/r/258416 and https://gerrit.wikimedia.org/r/258664 ? :) [22:05:59] yeah, I promise to do a bulk RELEASE-NOTES update at the end [22:06:05] MatmaRex: ok [22:06:24] (03CR) 10Florianschmidtwelzow: "some things :)" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [22:06:37] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Suggestions Favorite: Multiple issues - https://phabricator.wikimedia.org/T120670#1876742 (10Amire80) p:5Triage>3Normal [22:07:05] MatmaRex: I assume the i18n message contents were decided on elsewhere? Or is it fair game to comment on the wording? [22:07:22] 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7WorkType-Maintenance: Publish button does not become active when editing the translation - https://phabricator.wikimedia.org/T120837#1876744 (10Amire80) p:5Triage>3Normal [22:07:28] ori: please do comment on the wording [22:07:43] (03PS2) 10Reedy: Remove wfIsTrustedProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258893 (owner: 10Ori.livneh) [22:07:50] (03CR) 10Reedy: [C: 032] "Confirmed deaded in WMF hosted repos. RELEASE-NOTES to come later" [core] - 10https://gerrit.wikimedia.org/r/258893 (owner: 10Ori.livneh) [22:08:26] ori: or the content, or anything, if you care :) but i primarily want you to check the parts related to actual A/B testing [22:09:06] * Reedy wonders how slow jenkins is going to be today [22:10:00] 10MediaWiki-Interface, 7I18n, 7Tracking, 7Voice & Tone: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638#1876748 (10matmarex) [22:10:02] 10MediaWiki-Interface, 7Easy, 3Google-Code-In-2015, 5MW-1.27-release-notes, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Use of 'allpagessubmit': Give each special page its own message - https://phabricator.wikimedia.org/T45502#1876746 (10matmarex) 5Open>3Resolved [22:12:08] (03Merged) 10jenkins-bot: Remove wfGetIP(), deprecated since 1.19 [core] - 10https://gerrit.wikimedia.org/r/258892 (owner: 10Ori.livneh) [22:14:00] (03PS4) 10Florianschmidtwelzow: Convert Special:ConfirmEmail to OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251283 (https://phabricator.wikimedia.org/T117792) [22:14:13] Hmm [22:14:16] Can we remove 1.25 stuff yet? [22:14:24] (03PS4) 10Florianschmidtwelzow: Convert Special:ComparePages to OOUI [core] - 10https://gerrit.wikimedia.org/r/251013 (https://phabricator.wikimedia.org/T117752) [22:14:44] 1.25 stuff? [22:15:01] Deprecated and unused [22:15:09] https://www.mediawiki.org/wiki/Deprecation [22:15:16] [22:15:16] This MediaWiki page is inactive and kept for historical interest. It may document extensions or features that are obsolete and/or no longer supported. [22:15:16] Do not rely on the information here being up-to-date. [22:15:19] What is this shit? [22:15:26] Isn't the rule of thumb 2 releases? [22:15:32] lol [22:16:12] (03CR) 10jenkins-bot: [V: 04-1] Remove wfIsTrustedProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258893 (owner: 10Ori.livneh) [22:16:22] "Deprecations of MediaWiki core functionality should be flagged for a minimum of two MediaWiki releases before removal" [22:16:39] these patches will be part of 1.27 [22:17:25] I guess 1.25 and 1.26 is 2 releases [22:17:28] And if they're already unused [22:17:36] (03Merged) 10jenkins-bot: Remove wfIsTrustedProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258893 (owner: 10Ori.livneh) [22:17:53] V-1 then V+2 [22:17:55] Jenkins is drunk [22:18:02] xD [22:18:35] Kill all the 1.21 and 1.24 stuff instead ;) [22:19:11] Apparently something in Linker.php is 1.16 O.o [22:19:17] But still used? :P [22:19:18] / Inline logic from deprecated wfDebugTimer() [22:19:28] (03CR) 10Reedy: [C: 04-1] Remove wfDebugTimer(), deprecated in 1.25 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258894 (owner: 10Ori.livneh) [22:19:41] (03PS5) 10Florianschmidtwelzow: Convert Special:EmailUser to use OOUIHTMLForm [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) [22:19:51] (03CR) 10Florianschmidtwelzow: "PS5 is a rebase." [core] - 10https://gerrit.wikimedia.org/r/251288 (https://phabricator.wikimedia.org/T117791) (owner: 10Florianschmidtwelzow) [22:20:36] ... why can I not get these mew calculations correct :| [22:23:49] ? [22:24:33] I want to join the deprecated stuff removal party but the numbers aren't coming out correctly on my friction assignment. [22:26:44] (03PS2) 10Reedy: Remove wfDebugTimer(), deprecated in 1.25 [core] - 10https://gerrit.wikimedia.org/r/258894 (owner: 10Ori.livneh) [22:26:57] (03CR) 10Reedy: [C: 032] Remove wfDebugTimer(), deprecated in 1.25 [core] - 10https://gerrit.wikimedia.org/r/258894 (owner: 10Ori.livneh) [22:27:29] (03PS2) 10Reedy: Remove wfIsConfiguredProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258895 (owner: 10Ori.livneh) [22:27:36] (03CR) 10Reedy: [C: 032] Remove wfIsConfiguredProxy(), deprecated since 1.24 [core] - 10https://gerrit.wikimedia.org/r/258895 (owner: 10Ori.livneh) [22:28:33] wikibits.js is still full of deprecated crap [22:32:44] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876765 (10MZMcBride) >>! In T114419#1876179, @ori wrote: > I'd like to make a counterproposal, and that is that we abolish mandatory code-review, and instead allow people to exercise... [22:34:00] (03Merged) 10jenkins-bot: Remove wfDebugTimer(), deprecated in 1.25 [core] - 10https://gerrit.wikimedia.org/r/258894 (owner: 10Ori.livneh) [22:35:08] is there an easy way to describe what you changed when updating a gerrit revision? [22:36:23] Putting it in a comment is usually the easiest way [22:36:28] not the commit msg [22:40:14] (03CR) 10Ori.livneh: [C: 031] "Looks OK to merge. See comment, but up to you if you want to take it." (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/258664 (https://phabricator.wikimedia.org/T120867) (owner: 10Bartosz Dziewoński) [22:41:58] (03PS1) 10Victorbarbu: Displaying contributions in table [core] - 10https://gerrit.wikimedia.org/r/258897 [22:42:45] (03PS1) 10Reedy: Replace deprecated loadContent with fetchContent [extensions/OracleTextSearch] - 10https://gerrit.wikimedia.org/r/258898 [22:43:39] (03PS1) 10Reedy: Replace deprecated loadContent with fetchContent [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258899 [22:44:06] (03CR) 10jenkins-bot: [V: 04-1] Replace deprecated loadContent with fetchContent [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258899 (owner: 10Reedy) [22:44:16] 6Discovery, 10Maps: [Wikimaps Warper] Edit tab is not available for maps uploaded by other users - https://phabricator.wikimedia.org/T121345#1876769 (10Alexrk2) http://warper.wmflabs.org - login per Wikimedia Commons - choose a map (eg http://warper.wmflabs.org/maps/469) [22:48:07] omg, the hhvm debugger is *amazing* [22:48:37] never used it. what can you do with it? [22:50:03] * Platonides waves at archieb [22:50:55] (03CR) 10Legoktm: [C: 032] Remove wrong usage documentation in comments [core] - 10https://gerrit.wikimedia.org/r/258750 (owner: 10Martineznovo) [22:51:52] (03CR) 10Legoktm: [C: 032] Fix some MWExceptionHandler IDEA errors [core] - 10https://gerrit.wikimedia.org/r/258745 (owner: 10Aaron Schulz) [22:52:43] Does anyone know how many students are participating in GCI this summer [22:52:46] ? [22:52:52] (03PS1) 10Reedy: Remove gen from RawAction. [core] - 10https://gerrit.wikimedia.org/r/258901 [22:55:19] (03PS1) 10Reedy: Remove usage of FSRepo [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/258902 [22:56:28] 6Developer-Relations, 10Wikimedia-Developer-Summit-2016: Make code review not suck - https://phabricator.wikimedia.org/T114419#1876774 (10jayvdb) In many professional fields, and quite often in commercial software engineering, 'Senior' in a job title means the person no longer creates stuff , and only does rev... [22:56:31] (03CR) 10Legoktm: [C: 04-1] "At least the implementation of Wikibase's EntityContent::getSize() looks non-trivial and is not instance cached." [core] - 10https://gerrit.wikimedia.org/r/258723 (owner: 10Aaron Schulz) [22:57:06] we have ~40 so far [22:57:25] (03Merged) 10jenkins-bot: Remove wrong usage documentation in comments [core] - 10https://gerrit.wikimedia.org/r/258750 (owner: 10Martineznovo) [22:58:53] ori: SVN days were much better for fixing deprecated crap [22:59:03] you didn't have to commit to many many different repos :P [23:00:53] " Back in my day… We used SVN…" [23:01:45] (03PS1) 10Reedy: Replace deprecated editToken with getEditToken [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/258903 [23:02:24] (03PS1) 10Reedy: Replace deprecated editToken with getEditToken [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/258904 [23:02:50] (03PS8) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [23:02:52] (03PS1) 10Reedy: Replace deprecated editToken with getEditToken [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/258905 [23:02:54] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (036 comments) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [23:03:09] (03PS1) 10Reedy: Replace deprecated editToken with getEditToken [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/258906 [23:03:17] (03Merged) 10jenkins-bot: Fix some MWExceptionHandler IDEA errors [core] - 10https://gerrit.wikimedia.org/r/258745 (owner: 10Aaron Schulz) [23:04:22] (03PS1) 10Reedy: Replace deprecated editToken with getEditToken [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/258907 [23:04:26] (03CR) 10jenkins-bot: [V: 04-1] Replace deprecated editToken with getEditToken [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/258906 (owner: 10Reedy) [23:05:39] (03CR) 10Yaron Koren: "Can you give any examples of #cargo_query calls that work better with the new code than the old code?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/258753 (owner: 10Ed Hoo) [23:06:14] 10MassMessage: Massmessage should use '~~~~' to sign its posts. - https://phabricator.wikimedia.org/T121209#1876778 (10MZMcBride) This task is related to: * {T56848} * {T70513} * {T98662} The MassMessage extension already warns the sender when a timestamp is not included in the message. The sender name and in... [23:06:32] (03CR) 10Alex Monk: "looks good, will test soon" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [23:08:34] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools, 5Patch-For-Review: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1876783 (10Billinghurst) >>! In T22189#1876652, @Krenair wrote: >>>! In T22189#1876535, @lfaraone wrote: >> For dele... [23:09:44] (03CR) 10Reedy: [C: 032 V: 032] "Overriding jenkins tests. Unrelated" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/257346 (owner: 10Addshore) [23:10:00] (03Abandoned) 10Reedy: Replace deprecated loadContent with fetchContent [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258899 (owner: 10Reedy) [23:10:11] (03CR) 10jenkins-bot: [V: 04-1] Use Article::fetchContent instead of loadContent [extensions/Offline] - 10https://gerrit.wikimedia.org/r/257346 (owner: 10Addshore) [23:10:44] Sigh [23:12:09] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools, 5Patch-For-Review: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1876784 (10lfaraone) Sorry, my choice of wording was poor. I meant: If a page is already deleted, and the user has... [23:12:31] (03PS1) 10Reedy: Fix some syntax errors, implement method stubs [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258909 [23:12:55] (03CR) 10jenkins-bot: [V: 04-1] Fix some syntax errors, implement method stubs [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258909 (owner: 10Reedy) [23:13:24] (03PS9) 10LFaraone: Allow easy suppression of multiple deleted revs [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) [23:13:36] (03CR) 10LFaraone: Allow easy suppression of multiple deleted revs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258779 (https://phabricator.wikimedia.org/T22189) (owner: 10LFaraone) [23:16:12] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876785 (10matmarex) >>! In T120867#1876117, @Whatamidoing-WMF wrote: > @matmarex: I think you s... [23:21:10] 10MediaWiki-extensions-MsUpload, 10Continuous-Integration-Config: jshint:all fails on MsUpload - https://phabricator.wikimedia.org/T121367#1876786 (10Reedy) 3NEW [23:22:18] 10MediaWiki-Uploading, 6Commons, 6Multimedia, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876793 (10matmarex) >>! In T120867#1874472, @matmarex wrote: >>>! In T120867#1870639, @Whatamido... [23:24:50] 10MediaWiki-Database, 10MediaWiki-Page-editing, 6Performance-Team, 5MW-1.27-release-notes, and 2 others: Links tables are sometimes not being populated - https://phabricator.wikimedia.org/T117332#1876794 (10Carnildo) This doesn't appear to have been fixed in -wmf8. ImageTaggingBot reported errors on https... [23:33:15] (03PS4) 10Aaron Schulz: Make sure edits are not timestamped before the last edit [core] - 10https://gerrit.wikimedia.org/r/258723 [23:33:26] (03CR) 10Aaron Schulz: "I looked for those...must have missed that one." [core] - 10https://gerrit.wikimedia.org/r/258723 (owner: 10Aaron Schulz) [23:34:09] (03PS3) 10Yurik: (WAIT) Compress graph_specs page property [extensions/Graph] - 10https://gerrit.wikimedia.org/r/255914 (https://phabricator.wikimedia.org/T100942) [23:35:49] (03PS16) 10Paladox: Add composer.json with parallel-lint [extensions/Offline] - 10https://gerrit.wikimedia.org/r/245929 [23:36:15] (03CR) 10jenkins-bot: [V: 04-1] Add composer.json with parallel-lint [extensions/Offline] - 10https://gerrit.wikimedia.org/r/245929 (owner: 10Paladox) [23:41:23] legoktm: https://gerrit.wikimedia.org/r/#/q/owner:%22Aaron+Schulz%22+status:open,n,z :D [23:41:27] (03CR) 10Paladox: "check experimental" [extensions/Offline] - 10https://gerrit.wikimedia.org/r/258909 (owner: 10Reedy) [23:42:20] 10MediaWiki-Revision-deletion, 10MediaWiki-Special-pages, 6Stewards-and-global-tools, 5Patch-For-Review: Allow mass-suppression on Special:Undelete - https://phabricator.wikimedia.org/T22189#1876796 (10Krenair) Yes. Viewing revision-deleted items and viewing deleted page history are two separate rights, so... [23:50:24] 10MediaWiki-extensions-OpenStackManager, 6Labs, 10Labs-Infrastructure: On create instance failure, give link to quotas page and explain the error - https://phabricator.wikimedia.org/T121368#1876806 (10Reedy) [23:56:00] (03CR) 10Legoktm: [C: 04-1] "Looks good, minor thing inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/258734 (https://phabricator.wikimedia.org/T120267) (owner: 10Ori.livneh) [23:58:27] (03CR) 10Legoktm: [C: 032] Cleanup test jobs better [core] - 10https://gerrit.wikimedia.org/r/258646 (owner: 10Aaron Schulz) [23:58:38] (03CR) 10Legoktm: [C: 032] Check User::getId() in makeTestEdits.php [core] - 10https://gerrit.wikimedia.org/r/258640 (owner: 10Aaron Schulz) [23:59:23] (03CR) 10Legoktm: [C: 032] Fix MWOAuthDAO IDEA errors [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/258741 (owner: 10Aaron Schulz)